{"sample_id":"cross_issue_0001","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Investigate solr performance, diagnose bottlenecks and develop optimizations?","query_context":"This primarily concerns busy instances with large amounts of indexed metadata. Such as the IQSS prod. installation. There's some evidence of Solr becoming the performance bottleneck during high service load. Facet queries are especially suspect. But this has the potential to benefit any busy instance, hence the issue in the main repo. \n\n@kcondon got the ball rolling on this and has already found and applied some useful info. He has started a google doc documenting his work. We may link it here and we will try to document the most useful things we find here (and in the guides, eventually). Kevin's out today, but we had a conversation and decided I'll go ahead an open the issue to make sure this work is scheduled and tracked; striking it while it's hot, etc.","known_context_document_ids":["gh_issue_1753651505"],"reference_answer":"@luddaniel first, I'd like to point you toward a SQL query that might help as a workaround. It's from the useful queries doc linked from URL \n\nList the titles of datasets without files (4.20):\nselect dvo.createdate as date_of_creation, dfv.value as title, dvo.publicationdate as publication_date\nfrom datasetfieldvalue dfv\njoin datasetfield df on dfv.datasetfield_id = df.id\njoin datasetversion dv on df.datasetversion_id = dv.id\njoin dvobject dvo on dv.dataset_id = dvo.id\nwhere datasetfield_id not in\n(select id\nfrom datasetfield\nwhere datasetversion_id in\n(select id\nfrom datasetversion\nwhere id in\n(select datasetversion_id\nfrom filemetadata)))\nand datasetfield_id in\n(select id\nfrom datasetfield\nwhere datasetfieldtype_id in\n(select id\nfrom datasetfieldtype\nwhere name = 'title'))\norder by dvo.createdate;\n\nI see what you mean about fileCount. If I search for my dataset at URL I see it like this:\n\n\"fileCount\": 111,\n\nHowever, this number isn't indexed into Solr. It gets pulled from the database like this:\n\nnullSafeJsonBuilder.add(\"fileCount\", dv.getFileMetadatas().size());\n\nIt looks like I added it in 055fa5f as part of this PR:\n\n- #6623\n\n@landreev even asked why we don't just index the number. I guess we should have. 😞","answer_document_id":"gh_comment_1309349204","silver_evidence_path":["gh_comment_1662821644","gh_issue_1352482931","gh_comment_1309349204"],"evidence_issue_ids":[1753651505,1352482931],"source_repo_name":"IQSS/dataverse","source_issue_id":1753651505,"source_issue_number":9635,"source_issue_url":"https://github.com/IQSS/dataverse/issues/9635","target_repo_name":"IQSS/dataverse","target_issue_id":1352482931,"target_issue_number":8941,"target_issue_url":"https://github.com/IQSS/dataverse/issues/8941","reference_anchor_document_id":"gh_comment_1662821644","reference_answer_author":"pdurbin","reference_answer_author_association":"MEMBER","quality_score":90.22,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0278,"anchor_target_overlap":0.2778,"target_answer_overlap":0.1757},"issue_created_at":"2023-06-12T21:52:31+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1753651505","fragment_type":"issue_description","sequence":0,"text":"Investigate solr performance, diagnose bottlenecks and develop optimizations\nThis primarily concerns busy instances with large amounts of indexed metadata. Such as the IQSS prod. installation. There's some evidence of Solr becoming the performance bottleneck during high service load. Facet queries are especially suspect. But this has the potential to benefit any busy instance, hence the issue in the main repo. \n\n@kcondon got the ball rolling on this and has already found and applied some useful info. He has started a google doc documenting his work. We may link it here and we will try to document the most useful things we find here (and in the guides, eventually). Kevin's out today, but we had a conversation and decided I'll go ahead an open the issue to make sure this work is scheduled and tracked; striking it while it's hot, etc.","author_login":"landreev","author_association":"CONTRIBUTOR","created_at":"2023-06-12T21:52:31+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1659055337","fragment_type":"issue_comment","sequence":1,"text":"Spike issue to investigate Solr performance issues and identify specific actions to take. An issue will be created for each action that is identified. (As per 2023/07/30 prioritization meeting).","author_login":"cmbz","author_association":"NONE","created_at":"2023-07-31T20:04:46+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1662778922","fragment_type":"issue_comment","sequence":2,"text":"There's another low hanging fruit-like improvement that can be handled as a compact, self-contained issue: Inside SearchIncludeFragment (the class file that runs the search for the collection page - i.e., where most searches issued by Dataverse originate) every search is literally run twice, in order to obtain the result counts for the object types NOT currently selected by the user. While the second search is necessary in order to obtain these count(s), it can be run in a more economical way, that can reduce the amount of work for solr to perform by up to 50%. \nThe details are spelled out in a #dv-tech thread and can be copy-and-pasted into an issue once we open it.","author_login":"landreev","author_association":"CONTRIBUTOR","created_at":"2023-08-02T18:48:54+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1662821644","fragment_type":"issue_comment","sequence":3,"text":"@luddaniel I just looked at #8941. If it can be addressed by simply indexing fileCount as another numeric field during indexing, that does sound very straightforward, and I don't know why we haven't implemented it yet/have overlooked it. \nGenerally, we absolutely need to reduce the number of SQL lookups that are required when we process list of results as they come from Solr. Hopefully we can address it soon.","author_login":"landreev","author_association":"CONTRIBUTOR","created_at":"2023-08-02T19:08:32+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[1352482931],"is_known_query_context":false},{"document_id":"gh_comment_1749067425","fragment_type":"issue_comment","sequence":4,"text":"We had a series of prod. auto-restarts again yesterday. This is definitely caused by solr stopping responding, this is confirmed now. \nA bandaid, but hopefully an effective temp. workaround was applied on the solr side, setting up \"circuit breaker\" config options. This makes solr start dropping new connections with 503 when certain threshold of memory and/or cpu utilization is reached, rather than hanging. (the observed search page freezes were accompanied by the cpu utilization approaching 800% - on the 8-cpu node that is dvn-cloud-solr). Thanks/kudos to @kcondon for researching/figuring out the above.","author_login":"landreev","author_association":"CONTRIBUTOR","created_at":"2023-10-05T14:51:20+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1749203001","fragment_type":"issue_comment","sequence":5,"text":"Also noticed that clicking on basic search with no parameters spikes solr cpu. Clicking multiple times raises cpu use rapidly to where I can simulate the 700+% cpu load on solr. Refreshing the homepage or clicking on facets does not do this beyond an initial spike, then levels off. I was able to trigger the cpu circuit breaker, I think, using this method.","author_login":"kcondon","author_association":"CONTRIBUTOR","created_at":"2023-10-05T16:05:27+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1777391909","fragment_type":"issue_comment","sequence":6,"text":"I'm implementing the following application side improvements, and hoping to make a PR soon. (more may be added to the list)\n- Adding app-side support for the Solr-size circuit breakers. Enabling those makes Solr start dropping requests with 503s (instead of dying) under heavy load. As currently implemented however, the page does not detect that condition and doesn't handle it in any special way, and simply shows zero search results/empty collection page. It needs to show something intelligent, along the lines of \"search engine is experiencing heavy load, please try again later\". \n- Optimizing the second search that the page repeats solely for the purpose of populating the type counts facets for the _unchecked_ types. There is absolutely no need to repeat the **same exact search**, with all its super expensive parts, like all the other facets. There's no need to search for anything other than these one or two total counts; or to even run this second search, if all 3 type facets happen to be checked. \n- Adding `nofollow` to all the facet links and such, that we don't want crawlers/bots to touch. This will obviously only help with the nicer bots that take hints and follow rules, but better than nothing. \n- An off switch for facets support on the dataverse page. Again, facets are super expensive; it should be far better to be able to display the page with just the search cards and \"facets are temporarily unavailable because of load issues\" in the left column, than to have an empty page/have a \"solr down\" error page/have the page load take an hour.","author_login":"landreev","author_association":"CONTRIBUTOR","created_at":"2023-10-24T14:46:58+08:00","repo_name":"IQSS/dataverse","issue_id":1753651505,"issue_number":9635,"issue_url":"https://github.com/IQSS/dataverse/issues/9635","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1352482931","fragment_type":"issue_description","sequence":0,"text":"fileCount in Solr Documents and API performance\nHello, I have recently worked on a customized tool that use Dataverse Installation Search API and I was questionning myself on some choices done in code. \n\nMy need was to find all datasets without one custom field and without any files. \nCustomized field is ok `/api/v1/search?q=-alternativeURL:*&type=dataset`\nBut no files... I found that json reponse had fileCount property constructed by java code after solr result. \nProblem is : search is really slow if you ask lot of data.\nEx : `/api/v1/search?q=*&type=dataset&subtree=root&sort=name&order=asc&per_page=1000` takes 37 seconds for a 2.3Mo json file of 1000 datasets on our Dataverse installation (1991 datasets and 29844 datafiles).\nI ended up doing it using mostly SQL queries.\n\n1) I think it would be intesting to have information on solr document instead, in order to have better performance and mostly be able to ask `fileCount:0` in Dataverse Repository UI search bar or using Search API. \nOr maybe display it on Dataverse Installation search snippet result or in a customized tool in my case (ex: 66 files).\nI have seen that the question and the idea had exist in the past during `fileCount` implementation : #6601 #6623\n\n2) I'm a bit disturbed to see simple query based on solr search hiting 37 seconds for only 1000 elements. \nMy guess is there is too much SQL done afterward SOLR result. \nThe interest of using SOLR is to have ultra fast response, my humble opinion is that it's start to lose interest, it would be faster using 100% SQL or 100% Solr don't you think ? \nAs Java developper I do understand that complex application make those choices really complicated due to maintenance of SQL queries and critetrias or to not overload SOLR documents. \nBut there is a performance danger to make SQL queries for each documents of SOLR found.\nI might be off topic, feel free to correct me.\n\nI can't wait to read you and, as always, thanks for you time and services for the community of Dataverse software.","author_login":"luddaniel","author_association":"CONTRIBUTOR","created_at":"2022-08-26T16:30:26+08:00","repo_name":"IQSS/dataverse","issue_id":1352482931,"issue_number":8941,"issue_url":"https://github.com/IQSS/dataverse/issues/8941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1267771066","fragment_type":"issue_comment","sequence":1,"text":"@luddaniel sorry for the slow response. I'm trying to understand what you're up to. 😄 \n\nDoes the field have to be custom? Are you simply saying, \"I want to know which datasets are not using field x?\"\n\n(By \"no files\" I assume you mean \"no documents\". Solr calls results \"documents\".)\n\nIf you're concerned about performance, please try querying Solr directly to see if it's faster. The Dataverse Search API does (sadly) add some overhead but I'm not sure how much.\n\nIf the SQL queries are working for you perhaps you can make a pull request to make an API endpoint.\n\nWhat is this tool you've built? 😄 You've piqued my curiosity. 😄 \n\nMaybe we can chat in real time at URL some day. You're welcome to join!","author_login":"pdurbin","author_association":"MEMBER","created_at":"2022-10-05T00:41:51+08:00","repo_name":"IQSS/dataverse","issue_id":1352482931,"issue_number":8941,"issue_url":"https://github.com/IQSS/dataverse/issues/8941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1280946352","fragment_type":"issue_comment","sequence":2,"text":"Hello @pdurbin :) Thank you for answering\n \n \n\nBy \"no files\" I mean \"To retrieve Dataset without Datafile\". \nMaybe my text was mixing too much informations ^^\n\nIn other words, I want a SOLR field that tells me this dataset has 32 files. So I can ask Dataverse Search with : `fileCount=0` so I retrieve datasets without files or `fileCount>10` so I retrieve datasets with at least 10 files.\n \n\nThat's what I want to do but I cannot due to lack of 1 SOLR field that could contains informations on datafiles owned by a dataset (1 dataset = 1 solr document) \nEx : fileCount (int type) or fileIDs (array type)\n \n\nSadly, I don't have enough time at work to contribute at the moment but our team is thinking about contributing to Dataverse software, someday we will push code for sure !\n \n\nWe created a little python web application to help our support team (non technical persons) of our Dataverse Installation.\nIt uses Dataverse API Endpoints, SQL queries, Dataverse Search API. At this moment :\n\n1. Shows all datasets without datafile and with empty field alternativeUrl (so we can ask scientists to populate their dataset with data)\n2. Import list of email to add them in group (massive user configuration)\n3. Help to merge non admin users by selecting in 2 lists of users one to merge and one user to keep.\n \n\nI will sign in, hope to chat with you soon. It could be easier to exchange using screensharing.\nGenuinely, Ludovic.","author_login":"luddaniel","author_association":"NONE","created_at":"2022-10-17T14:25:10+08:00","repo_name":"IQSS/dataverse","issue_id":1352482931,"issue_number":8941,"issue_url":"https://github.com/IQSS/dataverse/issues/8941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1309349204","fragment_type":"issue_comment","sequence":3,"text":"@luddaniel first, I'd like to point you toward a SQL query that might help as a workaround. It's from the useful queries doc linked from URL \n\nList the titles of datasets without files (4.20):\nselect dvo.createdate as date_of_creation, dfv.value as title, dvo.publicationdate as publication_date\nfrom datasetfieldvalue dfv\njoin datasetfield df on dfv.datasetfield_id = df.id\njoin datasetversion dv on df.datasetversion_id = dv.id\njoin dvobject dvo on dv.dataset_id = dvo.id\nwhere datasetfield_id not in\n(select id\nfrom datasetfield\nwhere datasetversion_id in\n(select id\nfrom datasetversion\nwhere id in\n(select datasetversion_id\nfrom filemetadata)))\nand datasetfield_id in\n(select id\nfrom datasetfield\nwhere datasetfieldtype_id in\n(select id\nfrom datasetfieldtype\nwhere name = 'title'))\norder by dvo.createdate;\n\nI see what you mean about fileCount. If I search for my dataset at URL I see it like this:\n\n\"fileCount\": 111,\n\nHowever, this number isn't indexed into Solr. It gets pulled from the database like this:\n\nnullSafeJsonBuilder.add(\"fileCount\", dv.getFileMetadatas().size());\n\nIt looks like I added it in 055fa5f as part of this PR:\n\n- #6623\n\n@landreev even asked why we don't just index the number. I guess we should have. 😞","author_login":"pdurbin","author_association":"MEMBER","created_at":"2022-11-09T20:39:39+08:00","repo_name":"IQSS/dataverse","issue_id":1352482931,"issue_number":8941,"issue_url":"https://github.com/IQSS/dataverse/issues/8941","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0002","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"APM data shows telemetry being called ~30 times a day?","query_context":"We recently enabled APM on the `overview-aws-eu-west-1` kibana (QA environment used to monitor all the other QA deployments).\nWhile analyzing the data, I noticed something interesting and after talking to @Bamieh I wanted to open an issue to track this.\n\nThis cluster is running 7.16.0 (meaning URL is already merged into it) and it seems like it's calling the telemetry API way more often than one would expect.\n\nThe latency of each call is `10-60s` and they happen once about every hour. \nSome contain failures. \n\nAPM data from past 7 days\nDiscover telemetry call transactions,refreshInterval:(pause:!t,value:0),time:(from:now-7d%2Fd,to:now))&_a=(columns:!(transaction.name,observer.hostname,client.ip,host.ip,client.geo.location,client.geo.country_name,labels.deploymentName),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:processor.name,negate:!f,params:(query:transaction),type:phrase),query:(match_phrase:(processor.name:transaction))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:service.name,negate:!f,params:(query:kibana),type:phrase),query:(match_phrase:(service.name:kibana))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:transaction.name,negate:!f,params:!('POST%20%2Fapi%2Ftelemetry%2Fv2%2Fclusters%2F_stats'),type:phrases),query:(bool:(minimum_should_match:1,should:!((match_phrase:(transaction.name:'POST%20%2Fapi%2Ftelemetry%2Fv2%2Fclusters%2F_stats')))))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:labels.deploymentName,negate:!f,params:(query:overview-aws-eu-west-1),type:phrase),query:(match_phrase:(labels.deploymentName:overview-aws-eu-west-1)))),grid:(),hideChart:!f,index:apm_static_index_pattern_id,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc))))\nOne of the errors found in the telemetry request","known_context_document_ids":["gh_issue_1105780879"],"reference_answer":"Another idea that would improve our visibility of telemetry is URL What do you think?","answer_document_id":"gh_comment_1004798642","silver_evidence_path":["gh_comment_1014581993","gh_issue_1061276639","gh_comment_1004798642"],"evidence_issue_ids":[1105780879,1061276639],"source_repo_name":"elastic/kibana","source_issue_id":1105780879,"source_issue_number":123144,"source_issue_url":"https://github.com/elastic/kibana/issues/123144","target_repo_name":"elastic/kibana","target_issue_id":1061276639,"target_issue_number":119466,"target_issue_url":"https://github.com/elastic/kibana/issues/119466","reference_anchor_document_id":"gh_comment_1014581993","reference_answer_author":"afharo","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.25,"target_answer_overlap":0.2857},"issue_created_at":"2022-01-17T12:13:34+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1105780879","fragment_type":"issue_description","sequence":0,"text":"APM data shows telemetry being called ~30 times a day\nWe recently enabled APM on the `overview-aws-eu-west-1` kibana (QA environment used to monitor all the other QA deployments).\nWhile analyzing the data, I noticed something interesting and after talking to @Bamieh I wanted to open an issue to track this.\n\nThis cluster is running 7.16.0 (meaning URL is already merged into it) and it seems like it's calling the telemetry API way more often than one would expect.\n\nThe latency of each call is `10-60s` and they happen once about every hour. \nSome contain failures. \n\nAPM data from past 7 days\nDiscover telemetry call transactions,refreshInterval:(pause:!t,value:0),time:(from:now-7d%2Fd,to:now))&_a=(columns:!(transaction.name,observer.hostname,client.ip,host.ip,client.geo.location,client.geo.country_name,labels.deploymentName),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:processor.name,negate:!f,params:(query:transaction),type:phrase),query:(match_phrase:(processor.name:transaction))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:service.name,negate:!f,params:(query:kibana),type:phrase),query:(match_phrase:(service.name:kibana))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:transaction.name,negate:!f,params:!('POST%20%2Fapi%2Ftelemetry%2Fv2%2Fclusters%2F_stats'),type:phrases),query:(bool:(minimum_should_match:1,should:!((match_phrase:(transaction.name:'POST%20%2Fapi%2Ftelemetry%2Fv2%2Fclusters%2F_stats')))))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:apm_static_index_pattern_id,key:labels.deploymentName,negate:!f,params:(query:overview-aws-eu-west-1),type:phrase),query:(match_phrase:(labels.deploymentName:overview-aws-eu-west-1)))),grid:(),hideChart:!f,index:apm_static_index_pattern_id,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc))))\nOne of the errors found in the telemetry request","author_login":"lizozom","author_association":"CONTRIBUTOR","created_at":"2022-01-17T12:13:34+08:00","repo_name":"elastic/kibana","issue_id":1105780879,"issue_number":123144,"issue_url":"https://github.com/elastic/kibana/issues/123144","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1014581993","fragment_type":"issue_comment","sequence":1,"text":"The repetition could be caused by URL And the fix will ship in `8.0.0`.\n\nIn the meanwhile, I'd recommend upgrading to `7.16.2` to make use of the caching mechanism so it will save many ES requests.\n\nAfter looking at the APM data, I also identified 2 potential improvements so we can reduce the amount of time it takes to generate the telemetry report: \n- URL \n- URL \n\nI also added them to our Meta issue for Telemetry performance improvements URL","author_login":"afharo","author_association":"MEMBER","created_at":"2022-01-17T14:07:01+08:00","repo_name":"elastic/kibana","issue_id":1105780879,"issue_number":123144,"issue_url":"https://github.com/elastic/kibana/issues/123144","linked_issue_ids":[1061276639],"is_known_query_context":false},{"document_id":"gh_comment_1026970563","fragment_type":"issue_comment","sequence":2,"text":"@lizozom I was going to ask the same since we covered most of it. I'll go ahead and close it. Feel free to reopen if needed.","author_login":"afharo","author_association":"MEMBER","created_at":"2022-02-01T15:29:25+08:00","repo_name":"elastic/kibana","issue_id":1105780879,"issue_number":123144,"issue_url":"https://github.com/elastic/kibana/issues/123144","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1061276639","fragment_type":"issue_description","sequence":0,"text":"[Meta][Telemetry] Reduce telemetry footprint\nReducing the telemetry footprint ensures future scalability of our telemetry and puts a system in place to enable performance optimizations for our collection methods. This also helps reduce the number of people opting out of telemetry in cases where telemetry is causing significant spikes in resources.\n\n- [x] Exponentially backs off retry attempts for sending usage data #115221\n- [x] Cache stats to avoid #117084\n- [x] [Telemetry] Use lastReported timestamp on the 'browser' as well #87846\n- [x] Performance improvements on collectors:\n - [x] URL \n - [x] URL \n- [x] URL \n- [x] #123837\n- [x] Add telemetry around the time it is taking for grabbing the telemetry stats #119468\n- [x] #122516\n- [x] #122572\n- [x] Audit Usage collection with high Kibana/ES performance cost for some clusters #117489\n- [ ] Add load-test suites to identify our performance limitations\n - [x] Concurrent users URL \n - [ ] #122637\n- [ ] #93770\n- [x] Lens using a separate UI collection #48352\n- [ ] URL \n- [ ] #135922","author_login":"Bamieh","author_association":"MEMBER","created_at":"2021-11-23T13:16:04+08:00","repo_name":"elastic/kibana","issue_id":1061276639,"issue_number":119466,"issue_url":"https://github.com/elastic/kibana/issues/119466","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_983499281","fragment_type":"issue_comment","sequence":1,"text":"Should we also tackle URL IMHO, it will reduce the number of requests to only 1 every 24h (no matter how many users the cluster has).","author_login":"afharo","author_association":"MEMBER","created_at":"2021-12-01T10:26:00+08:00","repo_name":"elastic/kibana","issue_id":1061276639,"issue_number":119466,"issue_url":"https://github.com/elastic/kibana/issues/119466","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004798642","fragment_type":"issue_comment","sequence":2,"text":"Another idea that would improve our visibility of telemetry is URL What do you think?","author_login":"afharo","author_association":"MEMBER","created_at":"2022-01-04T13:12:18+08:00","repo_name":"elastic/kibana","issue_id":1061276639,"issue_number":119466,"issue_url":"https://github.com/elastic/kibana/issues/119466","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0004","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Question for the target label?","query_context":"Thank you for your excellent work! \n\nI noticed that in the `taskvars_target_label_zrange.json` file, you provide the key actions and the corresponding object labels for each task. For example, \n\n\"close_grill+0\": [\n {\n \"action\": \"grasp\",\n \"object\": {\n \"name\": \"grill handle\",\n \"fine\": [87],\n \"coarse\": [87, 86]\n }\n },\n {\n \"action\": \"move grasped object up\"\n }\n ]. \n\nI am curious about the meaning of the numbers in `\"fine\": [87]` and `\"coarse\": [87, 86]`. What do these values represent, and where do they come from? \n\nLooking forward to your response！","known_context_document_ids":["gh_issue_2855981342"],"reference_answer":"The issue was actually caused by a boundary being rendered. This is resolved in 1.0.9.\n\nFYI, you might find it more convenient to use the `task.get_demos()` functionality, rather than parsing the demo folders yourself (see here). If you pass in the live=False flag, then it gives you a list of demos loaded from file. You can also set `image_paths=True` if you want the paths rather than the images themselves.","answer_document_id":"gh_comment_720423891","silver_evidence_path":["gh_comment_2662874603","gh_issue_728638632","gh_comment_720423891"],"evidence_issue_ids":[2855981342,728638632],"source_repo_name":"vlc-robot/robot-3dlotus","source_issue_id":2855981342,"source_issue_number":9,"source_issue_url":"https://github.com/vlc-robot/robot-3dlotus/issues/9","target_repo_name":"stepjam/RLBench","target_issue_id":728638632,"target_issue_number":96,"target_issue_url":"https://github.com/stepjam/RLBench/issues/96","reference_anchor_document_id":"gh_comment_2662874603","reference_answer_author":"stepjam","reference_answer_author_association":"OWNER","quality_score":92.47,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2973,"anchor_target_overlap":0.1277,"target_answer_overlap":0.0294},"issue_created_at":"2025-02-16T09:11:12+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2855981342","fragment_type":"issue_description","sequence":0,"text":"Question for the target label\nThank you for your excellent work! \n\nI noticed that in the `taskvars_target_label_zrange.json` file, you provide the key actions and the corresponding object labels for each task. For example, \n\n\"close_grill+0\": [\n {\n \"action\": \"grasp\",\n \"object\": {\n \"name\": \"grill handle\",\n \"fine\": [87],\n \"coarse\": [87, 86]\n }\n },\n {\n \"action\": \"move grasped object up\"\n }\n ]. \n\nI am curious about the meaning of the numbers in `\"fine\": [87]` and `\"coarse\": [87, 86]`. What do these values represent, and where do they come from? \n\nLooking forward to your response！","author_login":"chenzixuan99","author_association":"NONE","created_at":"2025-02-16T09:11:12+08:00","repo_name":"vlc-robot/robot-3dlotus","issue_id":2855981342,"issue_number":9,"issue_url":"https://github.com/vlc-robot/robot-3dlotus/issues/9","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2661402465","fragment_type":"issue_comment","sequence":1,"text":"The RLBench simulator provides groundtruth segmentation masks. These numbers are the instance ids of the object in the groundtruth mask. We manually annotated the labels.","author_login":"cshizhe","author_association":"COLLABORATOR","created_at":"2025-02-16T12:10:13+08:00","repo_name":"vlc-robot/robot-3dlotus","issue_id":2855981342,"issue_number":9,"issue_url":"https://github.com/vlc-robot/robot-3dlotus/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2662874603","fragment_type":"issue_comment","sequence":2,"text":"Sorry, I have another confusion. I referred to a solution mentioned in an issue from RLBench: URL and I tried to obtain the instance IDs of the object in task `take_shoes_out_of_box`. However, the result I generated seems to not match the values in the script you provided. \n\nI obtained a total of 37 object IDs, and the ID for the box lid is 35, \n\nImage\n\nbut in the script you provided, it is 96. \n \n\n\"take_shoes_out_of_box+0\": [\n {\n \"action\": \"grasp\",\n \"object\": {\n \"name\": \"box lid\",\n \"fine\": [96],\n \"coarse\": [92, 96]\n }\n },\n {\n \"action\": \"move grasped object up\"\n },\n {\n \"action\": \"grasp\",\n \"object\": {\n \"name\": \"shoe\",\n \"fine\": [82],\n \"coarse\": [82]\n }\n },\n {\n \"action\": \"move grasped object out\"\n },\n {\n \"action\": \"grasp\",\n \"object\": {\n \"name\": \"shoe\",\n \"fine\": [102],\n \"coarse\": [102]\n }\n },\n {\n \"action\": \"move grasped object out\"\n }\n ]\n\nI would like to ask again, how are these instance IDs obtained?\n\nLooking forward to your reply and would greatly appreciate it!","author_login":"chenzixuan99","author_association":"NONE","created_at":"2025-02-17T11:44:19+08:00","repo_name":"vlc-robot/robot-3dlotus","issue_id":2855981342,"issue_number":9,"issue_url":"https://github.com/vlc-robot/robot-3dlotus/issues/9","linked_issue_ids":[728638632],"is_known_query_context":false},{"document_id":"gh_comment_2663068255","fragment_type":"issue_comment","sequence":3,"text":"Please follow the instruction in our dataset generation to get the groundtruth segmentation masks. Our annotated ids are related to these masks.","author_login":"cshizhe","author_association":"COLLABORATOR","created_at":"2025-02-17T13:06:11+08:00","repo_name":"vlc-robot/robot-3dlotus","issue_id":2855981342,"issue_number":9,"issue_url":"https://github.com/vlc-robot/robot-3dlotus/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2914791561","fragment_type":"issue_comment","sequence":4,"text":"@cshizhe @chenzixuan99 I have the same problem as you, can you provide the code to get the instance ID? I want to know the labels of different objects. I will be very grateful.","author_login":"Cheng909865905","author_association":"NONE","created_at":"2025-05-28T03:34:53+08:00","repo_name":"vlc-robot/robot-3dlotus","issue_id":2855981342,"issue_number":9,"issue_url":"https://github.com/vlc-robot/robot-3dlotus/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_728638632","fragment_type":"issue_description","sequence":0,"text":"segmentation mask rendering problem?\nHi,\n\nI was trying to generate a bunch of images and masks for the place_cups task. I generated the dataset using the following command:\n\npython tools/dataset_generator.py --save_path ./debug --tasks place_cups --image_size '256,256' --episodes_per_task 1 --variations 1\n\nI assume each number in the segmentation map corresponds to certain types of objects. And indeed, some of the numbers are correctly associated with the object. For example, the image looks like:\n\n0022\n\nThe number 36 corresponds to:\n\n36_22\n\nwhich seems to be correct.\n\nHowever, I found that some number corresponds to the wrong region. Specifically, number 35 corresponds to:\n\n35_22\n\n---\n\nI guess this is not an expected phenomenon? Is this a bug of mask rendering? Or how should I get the correct mask for objects?\n\nThanks a lot!","author_login":"HaozhiQi","author_association":"NONE","created_at":"2020-10-24T02:40:43+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_718396148","fragment_type":"issue_comment","sequence":1,"text":"Hi @HaozhiQi. \n\nThis is not expected behaviour, so theres probably a bug in the mask decoding. I'll take a look. Thanks for pointing this out. \nWould it be possible for you send me a reproducible script that shows the bug?","author_login":"stepjam","author_association":"OWNER","created_at":"2020-10-29T06:41:40+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_718542230","fragment_type":"issue_comment","sequence":2,"text":"Hi @stepjam ,\n\nSure! I use RLBench with version 1.0.9 (\ngit checkout 1.0.9\n) and installed with \npython setup.py install --user\n. My pyrep version is 1.2.\n\nAs I mentioned above, I generated the observations using the official script: \n\npython tools/dataset_generator.py --save_path ./debug --tasks place_cups --image_size '256,256' --episodes_per_task 1 --variations 1\n\nThen I run the following script:\n\nimport os\nimport cv2\nimport shutil\nimport numpy as np\n\nfrom tqdm import tqdm\nfrom glob import glob\n\ndef main():\n src_dir = './debug/place_cups/'\n tar_dir = './debug/parsed_place_cups/'\n\n variations = sorted(glob(f'{src_dir}/variation*/'))\n for v_i, variation in enumerate(tqdm(variations)):\n episodes = sorted(glob(f'{variation}/episodes/episode*/'))\n for e_i, episode in enumerate(episodes):\n image_path = f'{episode}/front_rgb/'\n images = glob(f'{image_path}/*.png')\n os.makedirs(f'{tar_dir}/image/v{v_i:03d}_e{e_i:03d}/', exist_ok=True)\n for image in images:\n im_id = int(image.split('/')[-1].split('.')[0])\n tar_path = f'{tar_dir}/image/v{v_i:03d}_e{e_i:03d}/{im_id:04d}.png'\n shutil.copy2(image, tar_path)\n mask = cv2.imread(image.replace('rgb', 'mask'), 0)\n obj_ids = list(np.unique(mask))\n for o_id, obj_id in enumerate(obj_ids):\n im = cv2.imread(image)\n masked_image = (mask == obj_id)[..., None] * im\n os.makedirs(f'{tar_dir}/{v_i}_{e_i}/', exist_ok=True)\n cv2.imwrite(f'{tar_dir}/{v_i}_{e_i}/{obj_id}_{im_id}.png', masked_image)\n\nif __name__ == '__main__':\n main()","author_login":"HaozhiQi","author_association":"NONE","created_at":"2020-10-29T09:29:31+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_720423891","fragment_type":"issue_comment","sequence":3,"text":"The issue was actually caused by a boundary being rendered. This is resolved in 1.0.9.\n\nFYI, you might find it more convenient to use the `task.get_demos()` functionality, rather than parsing the demo folders yourself (see here). If you pass in the live=False flag, then it gives you a list of demos loaded from file. You can also set `image_paths=True` if you want the paths rather than the images themselves.","author_login":"stepjam","author_association":"OWNER","created_at":"2020-11-02T11:48:54+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_723555622","fragment_type":"issue_comment","sequence":4,"text":"Hi @stepjam,\n\nI observed something weird for the place cups task. For id 33, it gives:\n33_214\nThere is a small green segment on top of the cup, which should not be the case.\n\nMoreover, when I'm playing with other tasks, a similar issue happened. The problematic task is block_pyramid. Using a similar script (see the bottom), it produces the following results:\n\nThe id 53 corresponds to: \n53_97\nwhich should be a green region indicating the target.\n\nMoreover, I though each id will correspond to a single object, but id 54 and 55 give:\n54_817\n55_20\n\nThis seems to be a systematic error rather than a bug for a single task. I'm thinking there may exist some bug in the .ttm file generation? Could you take a look at it?\n\nThe script I used to parse block_pyramid is:\n\npython tools/dataset_generator.py --save_path ./debug --tasks block_pyramid --image_size '256,256' --episodes_per_task 1 --variations 1\n\nimport os\nimport cv2\nimport shutil\nimport numpy as np\n\nfrom tqdm import tqdm\nfrom glob import glob\n\ndef main():\n src_dir = './debug/block_pyramid/'\n tar_dir = './debug/parsed_block_pyramid/'\n\n variations = sorted(glob(f'{src_dir}/variation*/'))\n for v_i, variation in enumerate(tqdm(variations)):\n episodes = sorted(glob(f'{variation}/episodes/episode*/'))\n for e_i, episode in enumerate(episodes):\n image_path = f'{episode}/front_rgb/'\n images = glob(f'{image_path}/*.png')\n os.makedirs(f'{tar_dir}/image/v{v_i:03d}_e{e_i:03d}/', exist_ok=True)\n for image in images:\n im_id = int(image.split('/')[-1].split('.')[0])\n tar_path = f'{tar_dir}/image/v{v_i:03d}_e{e_i:03d}/{im_id:04d}.png'\n shutil.copy2(image, tar_path)\n mask = cv2.imread(image.replace('rgb', 'mask'), 0)\n obj_ids = list(np.unique(mask))\n for o_id, obj_id in enumerate(obj_ids):\n im = cv2.imread(image)\n masked_image = (mask == obj_id)[..., None] * im\n os.makedirs(f'{tar_dir}/{v_i}_{e_i}/', exist_ok=True)\n cv2.imwrite(f'{tar_dir}/{v_i}_{e_i}/{obj_id}_{im_id}.png', masked_image)\n\nif __name__ == '__main__':\n main()","author_login":"HaozhiQi","author_association":"NONE","created_at":"2020-11-08T10:08:03+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_723560890","fragment_type":"issue_comment","sequence":5,"text":"Hi,\nThere may be a bug. Could you first swap to loading demos through the Environment interface? In your script that you linked, you are nor decoding the masks correctly.","author_login":"stepjam","author_association":"OWNER","created_at":"2020-11-08T10:59:40+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_723680767","fragment_type":"issue_comment","sequence":6,"text":"Hi, \n\nSorry, I didn't realize the mask is converted to 3 channel RGB image in the tools/dataset_generator.py so my parsing mask code is wrong. After changing it to single channel mask image, it works as expected. \n\nThanks a lot for your time!","author_login":"HaozhiQi","author_association":"NONE","created_at":"2020-11-08T23:14:46+08:00","repo_name":"stepjam/RLBench","issue_id":728638632,"issue_number":96,"issue_url":"https://github.com/stepjam/RLBench/issues/96","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0005","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"multiprocessing: serialization must ensure that contexts are compatible (the same)?","query_context":"BPO | 33196\n--- | :---\nNosy | @pitrou, @vstinner, @taleinat, @applio, @arcivanov, @augustogoulart\nFiles | test_lock_sigsegv.py testing_on_fedora.png coredump: coredump (Fedora 29) \n\n *Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.* \n\n Show more details \n\nGitHub fields:\n\npython\nassignee = None\nclosed_at = None\ncreated_at = \nlabels = ['3.8', '3.7', 'library', 'type-crash']\ntitle = 'multiprocessing: serialization must ensure that contexts are compatible (the same)'\nupdated_at = \nuser = ' URL \n\nbugs.python.org fields:\n\npython\nactivity = \nactor = 'davin'\nassignee = 'none'\nclosed = False\nclosed_date = None\ncloser = None\ncomponents = ['Library (Lib)']\ncreation = \ncreator = 'arcivanov'\ndependencies = []\nfiles = ['47510', '47931', '47933']\nhgrepos = []\nissue_num = 33196\nkeywords = []\nmessage_count = 11.0\nmessages = ['314762', '314792', '329491', '329719', '329845', '329892', '329893', '329898', '329908', '329909', '329913']\nnosy_count = 6.0\nnosy_names = ['pitrou', 'vstinner', 'taleinat', 'davin', 'arcivanov', 'augustogoulart']\npr_nums = []\npriority = 'normal'\nresolution = None\nstage = 'needs patch'\nstatus = 'open'\nsuperseder = None\ntype = 'crash'\nurl = ' URL \nversions = ['Python 3.6', 'Python 3.7', 'Python 3.8']\n\n \n\n \n### Linked PRs\n* gh-107275\n* gh-108377\n* gh-108378","known_context_document_ids":["gh_issue_1198989599"],"reference_answer":"Hmm, interesting. I thought that the auto-merge feature would also auto-close the issue, but it didn't.","answer_document_id":"gh_comment_1703941240","silver_evidence_path":["gh_comment_1694470703","gh_issue_1868196368","gh_comment_1703941240"],"evidence_issue_ids":[1198989599,1868196368],"source_repo_name":"python/cpython","source_issue_id":1198989599,"source_issue_number":77377,"source_issue_url":"https://github.com/python/cpython/issues/77377","target_repo_name":"python/cpython","target_issue_id":1868196368,"target_issue_number":108520,"target_issue_url":"https://github.com/python/cpython/issues/108520","reference_anchor_document_id":"gh_comment_1694470703","reference_answer_author":"pitrou","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.5714,"target_answer_overlap":0.125},"issue_created_at":"2018-04-01T05:58:11+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1198989599","fragment_type":"issue_description","sequence":0,"text":"multiprocessing: serialization must ensure that contexts are compatible (the same)\nBPO | 33196\n--- | :---\nNosy | @pitrou, @vstinner, @taleinat, @applio, @arcivanov, @augustogoulart\nFiles | test_lock_sigsegv.py testing_on_fedora.png coredump: coredump (Fedora 29) \n\n *Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.* \n\n Show more details \n\nGitHub fields:\n\npython\nassignee = None\nclosed_at = None\ncreated_at = \nlabels = ['3.8', '3.7', 'library', 'type-crash']\ntitle = 'multiprocessing: serialization must ensure that contexts are compatible (the same)'\nupdated_at = \nuser = ' URL \n\nbugs.python.org fields:\n\npython\nactivity = \nactor = 'davin'\nassignee = 'none'\nclosed = False\nclosed_date = None\ncloser = None\ncomponents = ['Library (Lib)']\ncreation = \ncreator = 'arcivanov'\ndependencies = []\nfiles = ['47510', '47931', '47933']\nhgrepos = []\nissue_num = 33196\nkeywords = []\nmessage_count = 11.0\nmessages = ['314762', '314792', '329491', '329719', '329845', '329892', '329893', '329898', '329908', '329909', '329913']\nnosy_count = 6.0\nnosy_names = ['pitrou', 'vstinner', 'taleinat', 'davin', 'arcivanov', 'augustogoulart']\npr_nums = []\npriority = 'normal'\nresolution = None\nstage = 'needs patch'\nstatus = 'open'\nsuperseder = None\ntype = 'crash'\nurl = ' URL \nversions = ['Python 3.6', 'Python 3.7', 'Python 3.8']\n\n \n\n \n### Linked PRs\n* gh-107275\n* gh-108377\n* gh-108378","author_login":"69d2e7fa-119a-4360-858f-934e2ab9fb33","author_association":"MANNEQUIN","created_at":"2018-04-01T05:58:11+08:00","repo_name":"python/cpython","issue_id":1198989599,"issue_number":77377,"issue_url":"https://github.com/python/cpython/issues/77377","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1660941380","fragment_type":"issue_comment","sequence":1,"text":"cc @vstinner I sent a PR for this, are you the right person to review it?","author_login":"albanD","author_association":"NONE","created_at":"2023-08-01T19:20:39+08:00","repo_name":"python/cpython","issue_id":1198989599,"issue_number":77377,"issue_url":"https://github.com/python/cpython/issues/77377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1680432654","fragment_type":"issue_comment","sequence":2,"text":"@albanD:\n \n\nI'm not available to review your PR. Maybe @pitrou can review it.","author_login":"vstinner","author_association":"MEMBER","created_at":"2023-08-16T11:30:23+08:00","repo_name":"python/cpython","issue_id":1198989599,"issue_number":77377,"issue_url":"https://github.com/python/cpython/issues/77377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1694470703","fragment_type":"issue_comment","sequence":3,"text":"Patch apparently caused regression for nested multiprocessing calls in 11.5. #108520","author_login":"terryjreedy","author_association":"MEMBER","created_at":"2023-08-26T18:42:34+08:00","repo_name":"python/cpython","issue_id":1198989599,"issue_number":77377,"issue_url":"https://github.com/python/cpython/issues/77377","linked_issue_ids":[1868196368],"is_known_query_context":false},{"document_id":"gh_issue_1868196368","fragment_type":"issue_description","sequence":0,"text":"Nested multiprocessing leads to `AttributeError: is_fork_ctx` with `forkserver` or `spawn` methods\n# Bug report\n\n### Checklist\n\n- [X] I am confident this is a bug in CPython, not a bug in a third-party project\n- [X] I have searched the CPython issue tracker,\nand am confident this bug has not been reported before\n\n### CPython versions tested on:\n\n3.11\n\n### Operating systems tested on:\n\nLinux\n\n### Output from running 'python -VV' on the command line:\n\nPython 3.11.5 (main, Aug 26 2023, 00:26:34) [GCC 12.2.1 20220924]\n\n### A clear and concise description of the bug:\n\nUsing nested `multiprocessing` (i.e. spawn a child process inside a child process) is broken as of Python 3.11.5, leading to an attribute error.\n\npython\nProcess Process-1:\nTraceback (most recent call last):\n File \"/usr/local/lib/python3.11/multiprocessing/process.py\", line 314, in _bootstrap\n self.run()\n File \"/usr/local/lib/python3.11/multiprocessing/process.py\", line 108, in run\n self._target(*self._args, **self._kwargs)\n File \"/io/pyi_multiprocessing_nested_process.py\", line 15, in process_function\n process.start()\n File \"/usr/local/lib/python3.11/multiprocessing/process.py\", line 121, in start\n self._popen = self._Popen(self)\n ^^^^^^^^^^^^^^^^^\n File \"/usr/local/lib/python3.11/multiprocessing/context.py\", line 224, in _Popen\n return _default_context.get_context().Process._Popen(process_obj)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/local/lib/python3.11/multiprocessing/context.py\", line 288, in _Popen\n return Popen(process_obj)\n ^^^^^^^^^^^^^^^^^^\n File \"/usr/local/lib/python3.11/multiprocessing/popen_spawn_posix.py\", line 32, in __init__\n super().__init__(process_obj)\n File \"/usr/local/lib/python3.11/multiprocessing/popen_fork.py\", line 19, in __init__\n self._launch(process_obj)\n File \"/usr/local/lib/python3.11/multiprocessing/popen_spawn_posix.py\", line 47, in _launch\n reduction.dump(process_obj, fp)\n File \"/usr/local/lib/python3.11/multiprocessing/reduction.py\", line 60, in dump\n ForkingPickler(file, protocol).dump(obj)\n File \"/usr/local/lib/python3.11/multiprocessing/synchronize.py\", line 106, in __getstate__\n if self.is_fork_ctx:\n ^^^^^^^^^^^^^^^^\nAttributeError: 'Lock' object has no attribute 'is_fork_ctx'\nResults: [1]\n\nMinimal code example below. Invoke with argument `fork`, `forkserver` or `spawn`. `fork` will work. `forkserver` and `spawn` will both raise the above error. All three variants work with Python 3.11.4.\n\npython\nimport sys\nimport multiprocessing\n\ndef nested_process_function(queue):\n print(\"Running nested sub-process!\")\n queue.put(2)\n\ndef process_function(queue):\n print(\"Running sub-process!\")\n queue.put(1)\n\n process = multiprocessing.Process(target=nested_process_function, args=(queue,))\n process.start()\n process.join()\n\ndef main(start_method):\n multiprocessing.set_start_method(start_method)\n queue = multiprocessing.Queue()\n\n process = multiprocessing.Process(target=process_function, args=(queue,))\n process.start()\n process.join()\n\n results = []\n while not queue.empty():\n results.append(queue.get())\n\n print(f\"Results: {results}\")\n assert results == [1, 2]\n\nif __name__ == '__main__':\n if len(sys.argv) != 2:\n raise SystemExit(f\"Usage: {sys.argv[0]} fork|forkserver|spawn\")\n\n main(sys.argv[1])\n\nI believe that the source of this regression is URL which adds the attribute `is_fork_ctx` to `multiprocessing.Lock()` but doesn't update the pickle methods (`__getstate__()` and `__setstate__()`) so after being serialised and deserialised, the `Lock()` object looses that attribute.\n\nThe following patch, adding `is_fork_ctx` to the pickle methods, makes the above work again.\n\ndiff\ndiff --git a/Lib/multiprocessing/synchronize.py b/Lib/multiprocessing/synchronize.py\nindex 2328d33212..9c5c2aada6 100644\n--- a/Lib/multiprocessing/synchronize.py\n+++ b/Lib/multiprocessing/synchronize.py\n@@ -109,10 +109,11 @@ def __getstate__(self):\n 'not supported. Please use the same context to create '\n 'multiprocessing objects and Process.')\n h = sl.handle\n- return (h, sl.kind, sl.maxvalue, sl.name)\n+ return (h, sl.kind, sl.maxvalue, sl.name, self.is_fork_ctx)\n \n def __setstate__(self, state):\n- self._semlock = _multiprocessing.SemLock._rebuild(*state)\n+ self._semlock = _multiprocessing.SemLock._rebuild(*state[:4])\n+ self.is_fork_ctx = state[4]\n util.debug('recreated blocker with handle %r' % state[0])\n self._make_methods()\n\n[tasklist]\n### Tasks\n\n \n### Linked PRs\n* gh-108568\n* gh-108691\n* gh-108692","author_login":"bwoodsend","author_association":"NONE","created_at":"2023-08-26T18:14:50+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1698336682","fragment_type":"issue_comment","sequence":1,"text":"Just to add confirmation to what has already been documented here and to document for others using the gcloud cli and finding this in search, I'm on python3.11.5 as well (`Python 3.11.5 (main, Aug 24 2023, 15:09:45) [Clang 14.0.3 (clang-1403.0.22.14.1)]`) and am encountering this error with the `gcloud` cli tools. \n\nA search for the following error message brought me here:\n\nsh\n$ gcloud storage cp gs://bucket/file ./ --verbosity debug\nDEBUG: Running [gcloud.storage.cp] with arguments: [--verbosity: \"debug\", DESTINATION: \"./\", SOURCE:1: \"['gs://bucket/file']\"]\nDEBUG: Starting new HTTPS connection (1): storage.googleapis.com:443\nDEBUG: URL \"GET /storage/v1/b/bucket/o/data%2Ffile?alt=json&projection=noAcl HTTP/1.1\" 200 896\nCopying gs://bucket/file to file://./file\nINFO: Using high CPU count, single-file workload config.\n⠛ERROR: gcloud crashed (AttributeError): 'Lock' object has no attribute 'is_fork_ctx' \n\nThis happens regardless of which gcloud version I upgrade or downgrade to:\n\n$ gcloud version\nGoogle Cloud SDK 444.0.0\nbeta 2023.08.22\nbq 2.0.97\ncore 2023.08.22\ngcloud-crc32c 1.0.0\ngsutil 5.25\n\nAnd I can successfully execute the command if I tell gcloud to use an older python version before 3.11.5, e.g.:\n\nsh\n$ CLOUDSDK_PYTHON=python3.10 gcloud storage cp gs://bucket/file ./\n# (executes just fine)","author_login":"carbocation","author_association":"NONE","created_at":"2023-08-30T00:56:02+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1703940986","fragment_type":"issue_comment","sequence":2,"text":"The fix appears to be merged and backported. Shouldn't this be closed?","author_login":"bwoodsend","author_association":"NONE","created_at":"2023-09-02T21:09:20+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1703941240","fragment_type":"issue_comment","sequence":3,"text":"Hmm, interesting. I thought that the auto-merge feature would also auto-close the issue, but it didn't.","author_login":"pitrou","author_association":"MEMBER","created_at":"2023-09-02T21:11:01+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722077332","fragment_type":"issue_comment","sequence":4,"text":"It doesn't seem like a fix has been released for Mac yet. I'm still hitting this issue after running `brew upgrade` since it's still using python 3.11.5. I did confirm the workaround provided by @carbocation works correctly.","author_login":"samos123","author_association":"NONE","created_at":"2023-09-16T00:27:25+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722215750","fragment_type":"issue_comment","sequence":5,"text":"Correct, the fix version will be 3.11.6 which doesn't exist yet.","author_login":"bwoodsend","author_association":"NONE","created_at":"2023-09-16T12:05:08+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744051444","fragment_type":"issue_comment","sequence":6,"text":"looks like python3.11.6 was released today. I haven't tested the fix since I'm waiting for `brew` to support it (to keep my installations manageable).","author_login":"carbocation","author_association":"NONE","created_at":"2023-10-03T02:07:43+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763311746","fragment_type":"issue_comment","sequence":7,"text":"I can confirm that the problem no longer occurs with python 3.11.6 (tested with `Google Cloud SDK 446.0.1` on `MacOS 13.4`). I had the issue with python 3.11.5","author_login":"nfonrose","author_association":"NONE","created_at":"2023-10-15T08:00:05+08:00","repo_name":"python/cpython","issue_id":1868196368,"issue_number":108520,"issue_url":"https://github.com/python/cpython/issues/108520","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0006","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"--path is not working?","query_context":"Looks like add command is not working with -p and --path parameters. It's ignoring the given path.\n\nAlso it would be good to have a way to set in components.json the path of the generated components.","known_context_document_ids":["gh_issue_1790326877"],"reference_answer":"This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.","answer_document_id":"gh_comment_2184252012","silver_evidence_path":["gh_comment_1622524000","gh_issue_1772209613","gh_comment_2184252012"],"evidence_issue_ids":[1790326877,1772209613],"source_repo_name":"shadcn-ui/ui","source_issue_id":1790326877,"source_issue_number":848,"source_issue_url":"https://github.com/shadcn-ui/ui/issues/848","target_repo_name":"shadcn-ui/ui","target_issue_id":1772209613,"target_issue_number":686,"target_issue_url":"https://github.com/shadcn-ui/ui/issues/686","reference_anchor_document_id":"gh_comment_1622524000","reference_answer_author":"shadcn","reference_answer_author_association":"COLLABORATOR","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.4167,"target_answer_overlap":0.0},"issue_created_at":"2023-07-05T21:07:24+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1790326877","fragment_type":"issue_description","sequence":0,"text":"--path is not working\nLooks like add command is not working with -p and --path parameters. It's ignoring the given path.\n\nAlso it would be good to have a way to set in components.json the path of the generated components.","author_login":"GivailsonNeves","author_association":"NONE","created_at":"2023-07-05T21:07:24+08:00","repo_name":"shadcn-ui/ui","issue_id":1790326877,"issue_number":848,"issue_url":"https://github.com/shadcn-ui/ui/issues/848","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1622524000","fragment_type":"issue_comment","sequence":1,"text":"The `-p` parameter doesn't work for ui components as I describe in this issue #686. In future releases it will be possibile to change the installation folder.","author_login":"dan5py","author_association":"CONTRIBUTOR","created_at":"2023-07-05T21:16:15+08:00","repo_name":"shadcn-ui/ui","issue_id":1790326877,"issue_number":848,"issue_url":"https://github.com/shadcn-ui/ui/issues/848","linked_issue_ids":[1772209613],"is_known_query_context":false},{"document_id":"gh_comment_2183584959","fragment_type":"issue_comment","sequence":2,"text":"This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.","author_login":"shadcn","author_association":"COLLABORATOR","created_at":"2024-06-21T23:43:06+08:00","repo_name":"shadcn-ui/ui","issue_id":1790326877,"issue_number":848,"issue_url":"https://github.com/shadcn-ui/ui/issues/848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1772209613","fragment_type":"issue_description","sequence":0,"text":"question(cli): override component installation path\n@shadcn The `add` command accept the `--path` argument to override the component installation path but it doesn't work for items with the `components:ui` type. In the previous version the cli asked for the installation path, but now is forced to the `ui` subfolder.\n\n URL \n\nIs this required or not?","author_login":"dan5py","author_association":"CONTRIBUTOR","created_at":"2023-06-23T21:57:06+08:00","repo_name":"shadcn-ui/ui","issue_id":1772209613,"issue_number":686,"issue_url":"https://github.com/shadcn-ui/ui/issues/686","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869136117","fragment_type":"issue_comment","sequence":1,"text":"I think this is a duplicate of #1156. shadcn has started looking into it.","author_login":"tony19","author_association":"NONE","created_at":"2023-12-25T22:24:06+08:00","repo_name":"shadcn-ui/ui","issue_id":1772209613,"issue_number":686,"issue_url":"https://github.com/shadcn-ui/ui/issues/686","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932759402","fragment_type":"issue_comment","sequence":2,"text":"Right now, the shadcn has a specific folder to install their components, so u gotta adapt your folder structure to receive shadcn components without any problem, in the shadcn installation u can remake your folder structure just pressing \"y\" on a step.\nBut to solve your doubt you should visit URL","author_login":"victormicco","author_association":"NONE","created_at":"2024-02-07T19:51:08+08:00","repo_name":"shadcn-ui/ui","issue_id":1772209613,"issue_number":686,"issue_url":"https://github.com/shadcn-ui/ui/issues/686","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2184252012","fragment_type":"issue_comment","sequence":3,"text":"This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.","author_login":"shadcn","author_association":"COLLABORATOR","created_at":"2024-06-22T23:42:44+08:00","repo_name":"shadcn-ui/ui","issue_id":1772209613,"issue_number":686,"issue_url":"https://github.com/shadcn-ui/ui/issues/686","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2606008520","fragment_type":"issue_comment","sequence":4,"text":"It looks like there's a new target field that might help here.","author_login":"iloveitaly","author_association":"NONE","created_at":"2025-01-22T00:19:09+08:00","repo_name":"shadcn-ui/ui","issue_id":1772209613,"issue_number":686,"issue_url":"https://github.com/shadcn-ui/ui/issues/686","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0007","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[FEAT] Make the advanced options more accessible.","query_context":"I recently heard about the advanced features in passing, and when I went to go image an SD card, I decided that these advanced options would save a lot of time. I then downloaded the imager tool and spent a solid minute clicking the options to find this menu.\n\nAfter Googling I found this page which ten told me I had to press Ctrl+Shift+X, which isn't obvious.\n\nI feel that this is bad UX, as most people won't be aware of this keyboard shortcuts, even if it would be helpful to them!\n\nI ask for a button somewhere on the main UI (such as another button in the button row or somewhere else)","known_context_document_ids":["gh_issue_1099471426"],"reference_answer":"Well, on Mac the application executable is not in the path.\nAnd yes, you do can actually `cd` into .app containers, but I doubt many Mac users know that.\nWould require entering something like: `/Applications/Raspberry\\ Pi\\ Imager.app/Contents/MacOS/rpi-imager --option`\n\nKeyboard combo was also changed \"shift\" + \"ctrl\" + \"X\", to be able to have the same combination on MacOS.\nEven though ctrl+alt+x may be easier to remember for some, MacOS lacked \"alt\".","answer_document_id":"gh_comment_811045949","silver_evidence_path":["gh_comment_1016814139","gh_issue_837890820","gh_comment_811045949"],"evidence_issue_ids":[1099471426,837890820],"source_repo_name":"raspberrypi/rpi-imager","source_issue_id":1099471426,"source_issue_number":334,"source_issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","target_repo_name":"raspberrypi/rpi-imager","target_issue_id":837890820,"target_issue_number":180,"target_issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","reference_anchor_document_id":"gh_comment_1016814139","reference_answer_author":"maxnet","reference_answer_author_association":"COLLABORATOR","quality_score":87.55,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1,"anchor_target_overlap":0.12,"target_answer_overlap":0.0909},"issue_created_at":"2022-01-11T18:03:25+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_1099471426","fragment_type":"issue_description","sequence":0,"text":"[FEAT] Make the advanced options more accessible.\nI recently heard about the advanced features in passing, and when I went to go image an SD card, I decided that these advanced options would save a lot of time. I then downloaded the imager tool and spent a solid minute clicking the options to find this menu.\n\nAfter Googling I found this page which ten told me I had to press Ctrl+Shift+X, which isn't obvious.\n\nI feel that this is bad UX, as most people won't be aware of this keyboard shortcuts, even if it would be helpful to them!\n\nI ask for a button somewhere on the main UI (such as another button in the button row or somewhere else)","author_login":"foxt","author_association":"NONE","created_at":"2022-01-11T18:03:25+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1016473052","fragment_type":"issue_comment","sequence":1,"text":"Yes, second this! \n\nI just found out via a random tutorial... no way of knowing this feature even exists.\nAnd when using it the second time after a while I forgot the \"magical\" key combination.. so I needed to spend some time again searching to find it. \n\nI would be very nice to have an \"advanced\" button. Maybe a bit hidden or bind a \"are you sure?\" modal if you must.","author_login":"JasperAlgra","author_association":"NONE","created_at":"2022-01-19T13:36:35+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016798831","fragment_type":"issue_comment","sequence":2,"text":"Hey,\nIf you want this perhaps you can tell me what you think about an unofficial fork, it seems like its what Rpi foundation suggests there:\n URL","author_login":"guysoft","author_association":"NONE","created_at":"2022-01-19T19:30:39+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[837890820],"is_known_query_context":false},{"document_id":"gh_comment_1016804926","fragment_type":"issue_comment","sequence":3,"text":"The reason I raise this issue is because it is inaccessible to those that\ndon't previously know of these settings. Making a fork does NOT improve\nvisibility.\n\nWhile I'm sure using a terminal to set up WiFi is the \"correct\" way, for\nmost users clicking a box in an application on a computer that already\nknows the password is easier, especially when they might not have a monitor\n& keyboard to attach to the Pi.\n\nOn Wed, 19 Jan 2022 at 7:30 pm, Guy Sheffer ***@***.***>\nwrote:","author_login":"theLMGN","author_association":"NONE","created_at":"2022-01-19T19:38:59+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[837890820],"is_known_query_context":false},{"document_id":"gh_comment_1016814139","fragment_type":"issue_comment","sequence":4,"text":"You have a point regarding visibility. Unless the fork becomes more common knowledge.\nIf there are more community OSes onboard that use such a fork, it might make it more widely known. Since it seems keeping the UI simple makes sense if you want to be educational. Rpi Foundation people wrote in the issue there:\n#180 (comment) they don't want to do is.\nIt means there might be enough reason to make a community fork with more advanced options in general.\n\nFor example, you could add custom fields as a feature in the advanced tab (domain names, static IPs, you name it, more images to pick from).","author_login":"guysoft","author_association":"NONE","created_at":"2022-01-19T19:51:33+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[837890820],"is_known_query_context":false},{"document_id":"gh_comment_1016820660","fragment_type":"issue_comment","sequence":5,"text":"There is code in git that will display an extra button (cog icon) if the user selected an image that advertises support for advanced settings.\n\nTo advertise support add to the images in your json the option: \n\n\"init_format\": \"systemd\" \n\n(or \"init_format\": \"cloudinit\" if your image is based on Ubuntu Server)","author_login":"maxnet","author_association":"COLLABORATOR","created_at":"2022-01-19T20:00:18+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016828902","fragment_type":"issue_comment","sequence":6,"text":"@maxnet Cool, I understood that is in the works (from our talk here URL .","author_login":"guysoft","author_association":"NONE","created_at":"2022-01-19T20:10:27+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016833943","fragment_type":"issue_comment","sequence":7,"text":"Just no distributions in the repository that advertise support right now.\nBut since you are maintaining your own .json file, you do can add the option to make it work for your distro...","author_login":"maxnet","author_association":"COLLABORATOR","created_at":"2022-01-19T20:17:12+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016844323","fragment_type":"issue_comment","sequence":8,"text":"I don't have an Ubuntu-based distro on the official JSON atm.\nAlso my Ubuntu-based distros can also handle wifi settings from the raspbian distro format thanks to CustomPiOS network module. So if you pick them as a custom images advanced settings for wifi do work.","author_login":"guysoft","author_association":"NONE","created_at":"2022-01-19T20:31:36+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016847275","fragment_type":"issue_comment","sequence":9,"text":"If you have RPI OS based distros the setting would be \"init_format\": \"systemd\" \n\n(instead of cloudinit)","author_login":"maxnet","author_association":"COLLABORATOR","created_at":"2022-01-19T20:35:54+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1770956780","fragment_type":"issue_comment","sequence":10,"text":"OS customisation is now accessible without a keyboard shortcut (and Ubuntu server is in the standard OS list with customisation enabled)","author_login":"cillian64","author_association":"COLLABORATOR","created_at":"2023-10-19T13:08:46+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":1099471426,"issue_number":334,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/334","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_837890820","fragment_type":"issue_description","sequence":0,"text":"Make advanced options discoverable\nI submitted two issues (#178 and #179) to do automatic setup of SSH and wifi. Turns out that feature already exists, which is fantastic!\n\nUnfortunately it's completely undiscoverable. There's no way to know it exists unless you magically already know.\n\nThere should be some visual indication that the option is available - \"do you want to set up advanced options?\" sort of thing.","author_login":"Timmmm","author_association":"NONE","created_at":"2021-03-22T16:20:42+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_804262609","fragment_type":"issue_comment","sequence":1,"text":"I have to say you guys make a lot of disappointingly user-hostile decisions. You don't let users resize the window (a very standard feature), you hide the option to set the freaking wifi password. That is so beginner unfriendly!\n \n\nIf by \"discussed\" you mean \"almost everyone agreed it was bone-headed\", then sure. Look at the comments from your users!\n \n \n \n \n \n\nI'd also like to reply to one of the two (that I counted) replies in favour:\n \n\nWell for a start you literally just forgot the shortcut!, but secondly how are you supposed to remember the shortcut if you never even knew it existed?\n\nThis goes against basically every UX principle ever. I could understand it if the options were super dangerous, but we're talking about setting up wifi here! What world are you living in where you think people with a Raspberry Pi are intimidated by wifi?\n\nAnyway I'll leave you to your crazy designs.","author_login":"Timmmm","author_association":"NONE","created_at":"2021-03-22T17:42:13+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_808105310","fragment_type":"issue_comment","sequence":2,"text":"@maxnet / @ghollingworth Is it worth mentioning the magic advanced-mode key-combo in URL ?","author_login":"lurch","author_association":"CONTRIBUTOR","created_at":"2021-03-26T10:31:31+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_808878011","fragment_type":"issue_comment","sequence":3,"text":"If you actually want users to know about this very useful feature then just put a button for it in the app. Very few people will read the Readme but everyone uses the app.\n\nIf you don't want users to know about this feature then you should think hard about why, because it's clearly insane to write a feature that you don't want anyone to actually discover.","author_login":"Timmmm","author_association":"NONE","created_at":"2021-03-28T10:36:20+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_808909770","fragment_type":"issue_comment","sequence":4,"text":"Yes, everybody working at Raspberry Pi is clearly insane :stuck_out_tongue_winking_eye: Welcome to the madhouse :upside_down_face:","author_login":"lurch","author_association":"CONTRIBUTOR","created_at":"2021-03-28T15:09:20+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_811000609","fragment_type":"issue_comment","sequence":5,"text":"It's not even been 2 weeks and I just had to look up the key combo already. To do that I had to first find the blog post. I'll accept I have a poor memory but that aside, this was by no means resolved in the blog comments. I fully appreciate these extra options might be overwhelming/confusing to our newest users and we absolutely don't want that, but I think there is a middle ground here. Could we discuss what that might look like?","author_login":"kingosticks","author_association":"NONE","created_at":"2021-03-31T11:45:51+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_811029266","fragment_type":"issue_comment","sequence":6,"text":"The shortcut sort of was the middle ground.\nBetween team #we-are-targetting-beginners rejecting the concept of a button, and team #experts coming up with a command line option (which is non-trivial to use on say Mac OS X).","author_login":"maxnet","author_association":"COLLABORATOR","created_at":"2021-03-31T12:27:37+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_811045949","fragment_type":"issue_comment","sequence":7,"text":"Well, on Mac the application executable is not in the path.\nAnd yes, you do can actually `cd` into .app containers, but I doubt many Mac users know that.\nWould require entering something like: `/Applications/Raspberry\\ Pi\\ Imager.app/Contents/MacOS/rpi-imager --option`\n\nKeyboard combo was also changed \"shift\" + \"ctrl\" + \"X\", to be able to have the same combination on MacOS.\nEven though ctrl+alt+x may be easier to remember for some, MacOS lacked \"alt\".","author_login":"maxnet","author_association":"COLLABORATOR","created_at":"2021-03-31T12:56:18+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_811102832","fragment_type":"issue_comment","sequence":8,"text":"OK, thanks for that explanation regarding Mac.\n\nSo to clarify, is a button with a very clear warning really off the table? Such a button could be small and placed in the bottom corner to reduce the chance of being accidentally pressed. Something like this:\n\nScreenshot from 2021-03-31 14-14-04\n\nIf someone still feels this could lead to anyone accidentally changing the advanced options, what if one of the advanced options was to always show this button? So then you only have to remember/lookup the magic shortcut once. If that is still somehow disagreeable, you could have the button hidden unless the `--show-advanced-options` command line option is used (for the benefit of non-Mac OS users only).\n\nI'm really struggling to see how this adjustment makes the tool noticeably more confusing for new users. And it's much better for those other users who do want to easily enable SSH, change the hostname, configure WiFi etc.","author_login":"kingosticks","author_association":"NONE","created_at":"2021-03-31T14:15:47+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_816190733","fragment_type":"issue_comment","sequence":9,"text":"So, would you accept a pull request with such a change? If not, what could we adjust to make it more apealing to those in charge here?","author_login":"kingosticks","author_association":"NONE","created_at":"2021-04-08T20:57:29+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_816451376","fragment_type":"issue_comment","sequence":10,"text":"For the moment we've already made our decision about how we're going to support this functionality. As said many times before we do not want to change the user interface at the moment since this is the easiest way for people to image SD cards.\n\nWhen an easier way appears we may then make this a more complex interface for more advanced users, but until then we will not be changing it.\n\nYou are free to build and distribute your own version (as long as you remove the Raspberry Pi logos and wordmark from the front page.)","author_login":"ghollingworth","author_association":"NONE","created_at":"2021-04-09T06:43:05+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_816462017","fragment_type":"issue_comment","sequence":11,"text":"Disappointing but of course that's your decision to make. Thanks for taking the time to reply.","author_login":"kingosticks","author_association":"NONE","created_at":"2021-04-09T07:03:04+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016797979","fragment_type":"issue_comment","sequence":12,"text":"Hey,\n \n\n@ghollingworth\n\nEr - I am actually considering making my own version, since there are about 6 standing ``[OS Request]`` issue with no answers (filter to requests).\nDoes it make sense to you guys there? I don't want to step on anyone toes, though it seems like all other users in the thread might welcome a \"unofficialpi\" fork.\nI am also in the works of adding json generation in CustomPiOS (related URL ). And knowing what is the stand on that would help me decide if a fork is worth having.\n\n(I was actually got here thinking we could join efforts and make a smoother CI/CD using github actions or something more accessible)","author_login":"guysoft","author_association":"NONE","created_at":"2022-01-19T19:29:32+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1017165732","fragment_type":"issue_comment","sequence":13,"text":"In general, those requests have sat idle while I think about how best to put them in. In the end, the more images that do the same thing (home automation or 3D printer for example), I'm just going to add in a secondary list. For example:\n\nOther Specific Purpose OSs\n -> OctoPi\n -> Other 3D printer OSs\n --> ABC\n --> Simply etc","author_login":"ghollingworth","author_association":"CONTRIBUTOR","created_at":"2022-01-20T06:41:29+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1022692820","fragment_type":"issue_comment","sequence":14,"text":"Hey, so I started looking in to making a fork, for now It already uses its own json list and merges ones in another repo:\n\n URL \n\nAnd it takes it from:\n URL \nWhich already has a github action to merge the official .json and add on top of it.\n\nIf I get Ci/CD for this running we could have a less restricted and more advanced version of rpi-imager. Perhaps even make it support other SBCs.\nIt could also be a space to see what works and then merge it up to mainstream.","author_login":"guysoft","author_association":"NONE","created_at":"2022-01-26T23:18:56+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1022948058","fragment_type":"issue_comment","sequence":15,"text":"Nice work guysoft! @Raspberry Pi why did you delete his message? If there's a good reason then you should probably say before people make assumptions. If there isn't then I would strongly consider reinstating it ASAP before people realise!","author_login":"Timmmm","author_association":"NONE","created_at":"2022-01-27T08:07:00+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026801719","fragment_type":"issue_comment","sequence":16,"text":"Hey, just to update that I spoke to Gordon and all is good. No need to make any assumptions :)\nI might start working on a \"packed with distros rpi-imager\" once I get OctoPi and FullPageOS RCs out.","author_login":"guysoft","author_association":"NONE","created_at":"2022-02-01T12:42:08+08:00","repo_name":"raspberrypi/rpi-imager","issue_id":837890820,"issue_number":180,"issue_url":"https://github.com/raspberrypi/rpi-imager/issues/180","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0008","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Typography: Theme defined font sizes are no longer working?","query_context":"### Description\n\nIt looks like the font sizes a theme defines in its theme.json are no longer working.\n\n| without plugin | with plugin |\n| ----------- | ----------- |\n| localhost local_ (12) | localhost local_ (13) |\n\nFor example, in the theme, `--wp--preset--font-size--medium` should be `1.05rem` but with Gutenberg plugin, the size is `clamp(14px, 0.875rem + ((1vw - 3.2px) * 0.625), 20px)`\n\nI can see this issue with other themes too.\n\n### Step-by-step reproduction instructions\n\n1. Open a homepage in the browser.\n2. Deactivate Gutenberg trunk\n3. Open the homepage in a new tab\n4. Notice the difeerence\n\n### Screenshots, screen recording, code snippet\n\n_No response_\n\n### Environment info\n\n- WP 6.4.2\n- Gutenberg Trunk\n\n### Please confirm that you have searched existing issues in the repo.\n\nYes\n\n### Please confirm that you have tested with all plugins deactivated except Gutenberg.\n\nYes","known_context_document_ids":["gh_issue_2084324813"],"reference_answer":"It seems we're keeping this on the WordPress 6.5 Editor Task board intentionally in the No Status column in hopes that it'll be addressed for 6.5. It does seem like a critical issue for many builders. I see it as In Progress on the Automattic team Ignite's project board. @ajlende do you have any updates on this, please?","answer_document_id":"gh_comment_1939366828","silver_evidence_path":["gh_comment_1903911842","gh_issue_1783868460","gh_comment_1939366828"],"evidence_issue_ids":[2084324813,1783868460],"source_repo_name":"WordPress/gutenberg","source_issue_id":2084324813,"source_issue_number":57889,"source_issue_url":"https://github.com/WordPress/gutenberg/issues/57889","target_repo_name":"WordPress/gutenberg","target_issue_id":1783868460,"target_issue_number":52200,"target_issue_url":"https://github.com/WordPress/gutenberg/issues/52200","reference_anchor_document_id":"gh_comment_1903911842","reference_answer_author":"colorful-tones","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1,"anchor_target_overlap":0.2,"target_answer_overlap":0.1071},"issue_created_at":"2024-01-16T15:52:43+08:00","valid_comment_count":47,"fragments":[{"document_id":"gh_issue_2084324813","fragment_type":"issue_description","sequence":0,"text":"Typography: Theme defined font sizes are no longer working\n### Description\n\nIt looks like the font sizes a theme defines in its theme.json are no longer working.\n\n| without plugin | with plugin |\n| ----------- | ----------- |\n| localhost local_ (12) | localhost local_ (13) |\n\nFor example, in the theme, `--wp--preset--font-size--medium` should be `1.05rem` but with Gutenberg plugin, the size is `clamp(14px, 0.875rem + ((1vw - 3.2px) * 0.625), 20px)`\n\nI can see this issue with other themes too.\n\n### Step-by-step reproduction instructions\n\n1. Open a homepage in the browser.\n2. Deactivate Gutenberg trunk\n3. Open the homepage in a new tab\n4. Notice the difeerence\n\n### Screenshots, screen recording, code snippet\n\n_No response_\n\n### Environment info\n\n- WP 6.4.2\n- Gutenberg Trunk\n\n### Please confirm that you have searched existing issues in the repo.\n\nYes\n\n### Please confirm that you have tested with all plugins deactivated except Gutenberg.\n\nYes","author_login":"iamtakashi","author_association":"NONE","created_at":"2024-01-16T15:52:43+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1900587219","fragment_type":"issue_comment","sequence":1,"text":"Pinging @richtabor and @annezazu b/c IMO this is a pretty big deal (and breaking change).","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-19T15:03:49+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1903892680","fragment_type":"issue_comment","sequence":2,"text":"To further illustrate what is happening, see below.\n\n**What font sizes should be in my Powder theme:**\n\nimage\n\n**What is output with Gutenberg 17.5 active:**\n\nimage","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-22T12:21:48+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1903898704","fragment_type":"issue_comment","sequence":3,"text":"Moreover, Gutenberg trunk seems to exacerbate the problem with even more unexpected results and—in this case—breaking changes on the front end.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-22T12:25:25+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1903911842","fragment_type":"issue_comment","sequence":4,"text":"Perhaps this is related (or has similar behavior) to URL \n\nAlso pinging @carolinan as she was involved in the issue I mentioned.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-22T12:33:31+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[1783868460],"is_known_query_context":false},{"document_id":"gh_comment_1904241987","fragment_type":"issue_comment","sequence":5,"text":"@ajlende, could this be a side-effect or regression from work introduced in #56661 ? Can you take a peek, please?","author_login":"colorful-tones","author_association":"MEMBER","created_at":"2024-01-22T15:26:55+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1904590588","fragment_type":"issue_comment","sequence":6,"text":"@bgardner @colorful-tones, thanks for adding more context.\n\n It'd be great if this issue gets fixed quickly. It blocks theme creations if you use the trunk :/","author_login":"iamtakashi","author_association":"NONE","created_at":"2024-01-22T18:41:17+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1905095212","fragment_type":"issue_comment","sequence":7,"text":"I'll escalate where I can too. Thank you for the ping and raising the alarm.","author_login":"annezazu","author_association":"CONTRIBUTOR","created_at":"2024-01-23T00:48:40+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1909210508","fragment_type":"issue_comment","sequence":8,"text":"Can’t wait to see what you come up with @ajlende, as Gutenberg 17.6 RC1 now has breaking changes on the front end with font sizes.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-25T01:47:55+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1914747269","fragment_type":"issue_comment","sequence":9,"text":"Any progress on this? The first image comparison with TT4 might have not illustrated the issue very much because the difference was subtle. The extent of the disturbance depends on the design of the theme, and this example might illustrate the issue better The left is how it should be and the right is the current status.\n\nScreenshot 2024-01-29 at 13 47 04","author_login":"iamtakashi","author_association":"NONE","created_at":"2024-01-29T13:56:54+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915019586","fragment_type":"issue_comment","sequence":10,"text":"I am far from an expert in how those properties are handled in Gutenberg, but maybe changing the `prevent_override` to `false` solves the problem: link.\n\nprevent_override => false\n\nI've tested that and, making that change, it seems to work for my case:\n* If I have a theme.json with sizes with the same slug as the default ones (\"small\", \"medium\", \"large\"...) the value from the theme takes precedence over the default value in Gutenberg.\n* If I remove the `fontSizes` from the theme, they still appear now with the values provided by Gutenberg.\n\nIs that what we want? If that should be the solution I can work on a pull request.","author_login":"SantosGuillamot","author_association":"CONTRIBUTOR","created_at":"2024-01-29T16:03:34+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915136246","fragment_type":"issue_comment","sequence":11,"text":"@SantosGuillamot Thanks for taking a look! I've also been working on this and commented in the PR that caused the issue (#56661). It'll be helpful if you can review when I get it working.","author_login":"ajlende","author_association":"CONTRIBUTOR","created_at":"2024-01-29T16:46:52+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915214444","fragment_type":"issue_comment","sequence":12,"text":"Great to hear you are working on that 🙂 \n \n\nOh, that's a pity. I can test whatever the solution is, although I'm not gonna be available until tomorrow.","author_login":"SantosGuillamot","author_association":"CONTRIBUTOR","created_at":"2024-01-29T17:22:40+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1917882277","fragment_type":"issue_comment","sequence":13,"text":"Noting that while the front end is better/fixed, the font sizes in the editor (Typography > Size) are still being hijacked by core sizes. In other words, the screenshots from my comment above are still in an issue.\n\ncc: @annezazu for visibility and @iamtakashi to confirm if seeing the same thing.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-30T20:58:23+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1917895248","fragment_type":"issue_comment","sequence":14,"text":"To re-iterate, these were just taken with/without Gutenberg 17.6.0-rc.3 active.\n\n**Gutenberg not active:**\n\nimage\n\n**Gutenberg active:**\n\nimage","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-30T21:07:31+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1917897806","fragment_type":"issue_comment","sequence":15,"text":"Just reopening if this is still an ongoing issue and not fully corrected with the latest change.","author_login":"justintadlock","author_association":"NONE","created_at":"2024-01-30T21:09:14+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918040897","fragment_type":"issue_comment","sequence":16,"text":"@bgardner - Just to help me understand the current issue:\n\nFrom what I'm seeing in your latest screenshots is that the core sizes are listed above yours. If that is the only problem, there's a separate issue for that: URL \n\nOr is it that your custom sizes are not working still?","author_login":"justintadlock","author_association":"NONE","created_at":"2024-01-30T22:47:15+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[1783868460],"is_known_query_context":false},{"document_id":"gh_comment_1918105112","fragment_type":"issue_comment","sequence":17,"text":"@justintadlock I see that this exists: URL \n\nThe problem is that in the editor, where there are font sizes names common with core/default themes and my Frost/Powder themes (Small, Medium, Large, and Extra Large in this case) the drop down menu shows the core values and not my theme values. With the revert in URL the issue is no longer on the front end out of the box—just when text is given any of those sizes listed above (in which case it becomes a front end problem.)\n\nIn English: if a theme declares font sizes that are identical to the ones in core, core should defer altogether (front end, back end, site editor) to the theme.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-30T23:49:19+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[1783868460],"is_known_query_context":false},{"document_id":"gh_comment_1918922801","fragment_type":"issue_comment","sequence":18,"text":"For me I have turned off every style, but with Gutenberg 6.4.3 (since 6.4.0 iirc) font size is back\n\n`theme.json`:\n\njson\n{\n \"$schema\": \" URL \n \"version\": 2,\n \"settings\": {\n \"appearanceTools\": false,\n \"typography\": {\n \"defaultFontSizes\": false,\n \"customFontSize\": false,\n \"lineHeight\": false,\n \"dropCap\": false,\n \"fluid\": false,\n \"fontStyle\": false,\n \"fontWeight\": false,\n \"letterSpacing\": false,\n \"textDecoration\": false,\n \"textTransform\": false,\n \"fontFamilies\": [],\n \"fontSizes\": []\n }\n },\n\nThe font size control is back, making the whole \"Styles\" tab appear:\n\nimage","author_login":"ktmn","author_association":"NONE","created_at":"2024-01-31T11:30:18+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1920553076","fragment_type":"issue_comment","sequence":19,"text":"Since this issue has been reopened, I will also change the project board status from \"Done\" to \"ToDo\".","author_login":"t-hamano","author_association":"CONTRIBUTOR","created_at":"2024-02-01T05:38:38+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1927365324","fragment_type":"issue_comment","sequence":20,"text":"I think the original issue caused by URL which was resolved when we reverted in #58456.\n\nThe original issue ( URL is still open, as is this other one about duplicate font sizes: URL \n\nI think these two issues cover all the currently known bugs, so I'll close this one in favour of them.","author_login":"scruffian","author_association":"CONTRIBUTOR","created_at":"2024-02-05T16:19:41+08:00","repo_name":"WordPress/gutenberg","issue_id":2084324813,"issue_number":57889,"issue_url":"https://github.com/WordPress/gutenberg/issues/57889","linked_issue_ids":[1783868460],"is_known_query_context":false},{"document_id":"gh_issue_1783868460","fragment_type":"issue_description","sequence":0,"text":"Global styles: Default font sizes are added\n### Description\n\nI created a blank theme and added custom font sizes.\nThis works intended in the editor, but in the Global styles, default font sizes are added in the drop down (S, M, L, XL)\n\n### Step-by-step reproduction instructions\n\n1. Copy the nearly blank theme.js from below\n2. Go into Global Style → Typography → Text\n3. See in the drop down the additional \"Small, Medium, Large, Extra Large\" font sizes, that shouldn't be there.\n\n theme.js \n \n\njavascript\n{\n \"settings\": {\n \"appearanceTools\": true,\n \"color\": {\n \"background\": true,\n \"custom\": true,\n \"customDuotone\": true,\n \"customGradient\": true,\n \"defaultDuotone\": false,\n \"defaultGradients\": false,\n \"defaultPalette\": false,\n \"duotone\": [],\n \"gradients\": [],\n \"palette\": [],\n \"text\": true\n },\n \"layout\": {\n \"contentSize\": \"620px\",\n \"wideSize\": \"1000px\"\n },\n \"shadow\": {\n \"defaultPresets\": true,\n \"presets\": []\n },\n \"spacing\": {\n \"customSpacingSize\": true,\n \"spacingScale\": {\n \"increment\": 1.5,\n \"mediumStep\": 1.5,\n \"operator\": \"*\",\n \"steps\": 7,\n \"unit\": \"rem\"\n },\n \"spacingSizes\": [],\n \"units\": [\"%\", \"px\", \"em\", \"rem\", \"vh\", \"vw\"]\n },\n \"typography\": {\n \"customFontSize\": true,\n \"dropCap\": true,\n \"fluid\": true,\n \"fontFamilies\": [\n {\n \"fontFamily\": \"-apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', sans-serif\",\n \"name\": \"System Font\",\n \"slug\": \"system-font\"\n },\n {\n \"fontFace\": [\n {\n \"fontFamily\": \"Barlow\",\n \"fontStyle\": \"italic\",\n \"fontWeight\": \"700\",\n \"src\": [\"file:./assets/fonts/barlow_italic_700.ttf\"]\n },\n {\n \"fontFamily\": \"Barlow\",\n \"fontStyle\": \"normal\",\n \"fontWeight\": \"700\",\n \"src\": [\"file:./assets/fonts/barlow_normal_700.ttf\"]\n },\n {\n \"fontFamily\": \"Barlow\",\n \"fontStyle\": \"italic\",\n \"fontWeight\": \"600\",\n \"src\": [\"file:./assets/fonts/barlow_italic_600.ttf\"]\n },\n {\n \"fontFamily\": \"Barlow\",\n \"fontStyle\": \"normal\",\n \"fontWeight\": \"600\",\n \"src\": [\"file:./assets/fonts/barlow_normal_600.ttf\"]\n },\n {\n \"fontFamily\": \"Barlow\",\n \"fontStyle\": \"italic\",\n \"fontWeight\": \"400\",\n \"src\": [\"file:./assets/fonts/barlow_italic_400.ttf\"]\n },\n {\n \"fontFamily\": \"Barlow\",\n \"fontStyle\": \"normal\",\n \"fontWeight\": \"400\",\n \"src\": [\"file:./assets/fonts/barlow_normal_400.ttf\"]\n }\n ],\n \"fontFamily\": \"Barlow\",\n \"slug\": \"barlow\"\n }\n ],\n \"fontSizes\": [\n {\n \"name\": \"Display xl\",\n \"slug\": \"Display-xl\",\n \"size\": \"96px\",\n \"fluid\": {\n \"max\": \"96px\",\n \"min\": \"52px\"\n }\n },\n {\n \"name\": \"Display lg\",\n \"slug\": \"Display-lg\",\n \"size\": \"72px\",\n \"fluid\": {\n \"max\": \"72px\",\n \"min\": \"46px\"\n }\n },\n {\n \"name\": \"Display md\",\n \"slug\": \"Display-md\",\n \"size\": \"60px\",\n \"fluid\": {\n \"max\": \"60px\",\n \"min\": \"42px\"\n }\n },\n {\n \"name\": \"Display sm\",\n \"slug\": \"Display-sm\",\n \"size\": \"52px\",\n \"fluid\": {\n \"max\": \"52px\",\n \"min\": \"40px\"\n }\n },\n {\n \"name\": \"Heading 1\",\n \"slug\": \"Heading-1\",\n \"size\": \"48px\",\n \"fluid\": {\n \"max\": \"48px\",\n \"min\": \"36px\"\n }\n },\n {\n \"name\": \"Heading 2\",\n \"slug\": \"Heading-2\",\n \"size\": \"36px\",\n \"fluid\": {\n \"max\": \"36px\",\n \"min\": \"30px\"\n }\n },\n {\n \"name\": \"Heading 3\",\n \"slug\": \"Heading-3\",\n \"size\": \"28px\",\n \"fluid\": {\n \"max\": \"28px\",\n \"min\": \"26px\"\n }\n },\n {\n \"name\": \"Heading 4\",\n \"slug\": \"Heading-4\",\n \"size\": \"24px\",\n \"fluid\": {\n \"max\": \"24px\",\n \"min\": \"22px\"\n }\n },\n {\n \"name\": \"Heading 5\",\n \"slug\": \"Heading-5\",\n \"size\": \"20px\",\n \"fluid\": {\n \"max\": \"20px\",\n \"min\": \"19px\"\n }\n },\n {\n \"name\": \"Heading 6\",\n \"slug\": \"Heading-6\",\n \"size\": \"18px\",\n \"fluid\": {\n \"max\": \"18px\",\n \"min\": \"17px\"\n }\n },\n {\n \"name\": \"Paragraph lg\",\n \"slug\": \"paragraph-lg\",\n \"size\": \"18px\",\n \"fluid\": {\n \"max\": \"18px\",\n \"min\": \"17px\"\n }\n },\n {\n \"name\": \"Paragraph base\",\n \"slug\": \"paragraph-base\",\n \"size\": \"16px\",\n \"fluid\": {\n \"max\": \"16px\",\n \"min\": \"16px\"\n }\n },\n {\n \"name\": \"Paragraph sm\",\n \"slug\": \"paragraph-sm\",\n \"size\": \"14px\",\n \"fluid\": {\n \"max\": \"14px\",\n \"min\": \"14px\"\n }\n },\n {\n \"name\": \"Info md\",\n \"slug\": \"Info-md\",\n \"size\": \"12px\",\n \"fluid\": {\n \"max\": \"12px\",\n \"min\": \"12px\"\n }\n },\n {\n \"name\": \"Info sm\",\n \"slug\": \"Info-sm\",\n \"size\": \"10px\",\n \"fluid\": {\n \"max\": \"10px\",\n \"min\": \"10px\"\n }\n }\n ],\n \"fontStyle\": true,\n \"fontWeight\": true,\n \"letterSpacing\": true,\n \"textDecoration\": true,\n \"textTransform\": true\n },\n \"useRootPaddingAwareAlignments\": true\n },\n \"styles\": {\n \"spacing\": {\n \"padding\": {\n \"bottom\": \"0px\",\n \"left\": \"16px\",\n \"right\": \"16px\",\n \"top\": \"0px\"\n }\n }\n },\n \"templateParts\": [\n {\n \"area\": \"header\",\n \"name\": \"header\"\n },\n {\n \"area\": \"footer\",\n \"name\": \"footer\"\n }\n ],\n \"version\": 2,\n \"$schema\": \" URL \n}\n\n \n\n \n \n\n### Screenshots, screen recording, code snippet\n\n| Block styles (as it should be) | Global styles (with additonal font sizes) |\n|--------|--------|\n| <img width=\"160\" alt=\"image\" src=\" URL | <img width=\"160\" alt=\"image\" src=\" URL |\n\n### Environment info\n\n- WP 6.2.2\n- GB 16.1.0\n\n### Please confirm that you have searched existing issues in the repo.\n\nYes\n\n### Please confirm that you have tested with all plugins deactivated except Gutenberg.\n\nYes","author_login":"hanneslsm","author_association":"NONE","created_at":"2023-07-01T12:30:21+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1616603858","fragment_type":"issue_comment","sequence":1,"text":"Hi\nI copied the code example from the issue and used it to replace the theme.json in Twenty Twenty-Three.\n\n- 6.2.2 only: No issue\n- 6.2.2 and 16.1.0: Additional font sizes as described\n- 6.3-beta2-56121: Additional font sizes as described","author_login":"carolinan","author_association":"CONTRIBUTOR","created_at":"2023-07-02T11:14:39+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722467354","fragment_type":"issue_comment","sequence":2,"text":"@annezazu Can you please add this issue to the Polish board ? Cheers!","author_login":"hanneslsm","author_association":"NONE","created_at":"2023-09-17T12:33:53+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1813496536","fragment_type":"issue_comment","sequence":3,"text":"Just bumping. I indeed noticed this as well. I'm seeing the default sizes appearing in the editor alongside custom ones as well as in the DOM as variables. I can't actually find a way to remove them. I don't think this happened in the past so I'm not sure what changed. I'm running 6.4.1 and the Gutenberg 17.0.2","author_login":"dabowman","author_association":"NONE","created_at":"2023-11-16T00:09:24+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1813499690","fragment_type":"issue_comment","sequence":4,"text":"Also noting that this can cause a known issue where two type sizes can conflict with eachother. If two type sizes have the same value then selecting one will cause the block to revert to the first matching style that appears in the list. Normally this isn't a big issue, unless the default styles don't disappear when you define custom ones. The default styles appear first in the list so selecting a custom style with the same value forces it to select the default.","author_login":"dabowman","author_association":"NONE","created_at":"2023-11-16T00:13:02+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1828143458","fragment_type":"issue_comment","sequence":5,"text":"I'm seeing the same settings in both places (WP 6.4 + GB trunk); however, the four default font sizes ('Small', 'Medium', 'Large', 'Extra Large') appear first in the block styles, but last in the global styles. In other places where Gutenberg provides default values for something we add a `default*` option to disable showing those settings, but I don't see one for font sizes right now.\n\nSo, it sounds to me like there are two parts to solving this fully.\n\n1. Add a `defaultFontSizes` option that allows for the default size options to be hidden.\n2. Ensure that the order of the default, theme, and user sizes are the same in both places when they are all enabled.","author_login":"ajlende","author_association":"CONTRIBUTOR","created_at":"2023-11-27T16:08:28+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918048044","fragment_type":"issue_comment","sequence":6,"text":"This should work as a quick fix for disabling the default font sizes, but I'm pretty sure the CSS for them won't be printed either:\n\nphp\nadd_filter('wp_theme_json_data_default', function($theme_json) {\n $data = [\n 'version' => 2,\n 'settings' => [\n 'typography' => [\n 'fontSizes' => []\n ]\n ]\n ];\n\n return $theme_json->update_with($data);\n});","author_login":"justintadlock","author_association":"NONE","created_at":"2024-01-30T22:52:14+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918109503","fragment_type":"issue_comment","sequence":7,"text":"@justintadlock Can confirm the filter above is working perfectly and as expected. CSS is printed and Small, Medium, Large, and Extra Large sizes show correct values in the Typography > Font Size menu in post editor as well as correctly on the front end when chosen.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-30T23:54:07+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918304529","fragment_type":"issue_comment","sequence":8,"text":"We can't expect theme developers to add this filter as a long term solution.","author_login":"carolinan","author_association":"CONTRIBUTOR","created_at":"2024-01-31T03:12:06+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918312607","fragment_type":"issue_comment","sequence":9,"text":"@carolinan Agreed. I was merely confirming it worked to see if it helped inform a permanent fix in core.","author_login":"bgardner","author_association":"NONE","created_at":"2024-01-31T03:23:32+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1927367380","fragment_type":"issue_comment","sequence":10,"text":"I have removed this from the Polish board is it's too big to go into 6.5.","author_login":"scruffian","author_association":"CONTRIBUTOR","created_at":"2024-02-05T16:20:40+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930992715","fragment_type":"issue_comment","sequence":11,"text":"@scruffian I'm a bit confused by this last comment. Can you clarify? I've added it to the 6.5 board to be safe as it's clearly impacting theme authors and seems important to get fixed. Ideally, this is resolved for 6.5 but I definitely want to understand more if/why that might not be feasible.","author_login":"annezazu","author_association":"CONTRIBUTOR","created_at":"2024-02-07T00:09:14+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1931989619","fragment_type":"issue_comment","sequence":12,"text":"We put in a fix for this, but it ended up creating worse bugs, so we took it out again. We are still working on a fix, but it's going to take longer than we have before the cut off. I hope it will make it into a Gutenberg release soon :)","author_login":"scruffian","author_association":"CONTRIBUTOR","created_at":"2024-02-07T12:53:45+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932084119","fragment_type":"issue_comment","sequence":13,"text":"I agree with @carolinan on this, it is inconvenient to ask to touch two places to configure the theme but at the same time I think it is nice to give the opportunity to confiugure the theme dynamically. \n\nI've seen some options line `blockGap` accepting three values, `false`, `true`, `null` triggering different results. Could be the same for the collections, something like `false` deactivate the feature, `[]|{}` empty object add nothing more. Indeed we cannot pass an empty collection to signaling the theme we want any option because it would make difficult to address the cases where someone might want to edit the value via a filter giving dynamic data which might be empty or not while at the same time they want to keep the current theme / core configuration.","author_login":"widoz","author_association":"CONTRIBUTOR","created_at":"2024-02-07T13:45:46+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932094478","fragment_type":"issue_comment","sequence":14,"text":"We can't expect theme developers to add this filter as a long term solution.\n\nI agree with @carolinan on this, it is inconvenient to ask to touch two places to configure the theme but at the same time I think it is nice to give the opportunity to confiugure the theme dynamically.\n\nI've seen some options line blockGap accepting three values, false, true, null triggering different results. Could be the same for the collections, something like false deactivate the feature, []|{} empty object add nothing more. Indeed we cannot pass an empty collection to signaling the theme we want any option because it would make difficult to address the cases where someone might want to edit the value via a filter giving dynamic data which might be empty or not while at the same time they want to keep the current theme / core configuration.\n\n### Update\nSorry, I've not took into account the theme override the core configuration, disabling via the same option wouldn't work because there'll be no way to add more options. (edited)","author_login":"widoz","author_association":"CONTRIBUTOR","created_at":"2024-02-07T13:50:58+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932538750","fragment_type":"issue_comment","sequence":15,"text":"@annezazu To clarify some more, we want to fix this issue by adding a `defaultFontSizes` option in theme.json which matches how many other presets work. And we _thought_ we had it working in #56661.\n\nUnfortunately, the behavior of having that setting either enabled or disabled is different from the current implementation (merging default options with theme options). This is the \"worse bug\" that @scruffian mentioned—old themes looked different after the change. To fix that issue, we need to bump the theme.json version so old (theme.json v2) themes can continue to work as they currently do and new (theme.json v3) themes can start using the new defaults.\n\nIncreasing a theme.json version isn't a small change. And this is the first time that we're changing a default value, so there's no precedent set for how to do it. We want to get it right because there's two other options that could be updated the same way.\n\nYou can see my progress in #58409. The change already seemed big enough that we didn't want to rush it for 6.5.","author_login":"ajlende","author_association":"CONTRIBUTOR","created_at":"2024-02-07T17:28:58+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939366828","fragment_type":"issue_comment","sequence":16,"text":"It seems we're keeping this on the WordPress 6.5 Editor Task board intentionally in the No Status column in hopes that it'll be addressed for 6.5. It does seem like a critical issue for many builders. I see it as In Progress on the Automattic team Ignite's project board. @ajlende do you have any updates on this, please?","author_login":"colorful-tones","author_association":"MEMBER","created_at":"2024-02-12T19:10:20+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939491844","fragment_type":"issue_comment","sequence":17,"text":"This isn't going to make it to 6.5 as stated above :( I left it for a bit to see if we could make progress since, as you noted, it's an important issue but it's not going to happen 24 hours before beta 1. Punting now.","author_login":"annezazu","author_association":"CONTRIBUTOR","created_at":"2024-02-12T20:13:27+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939546415","fragment_type":"issue_comment","sequence":18,"text":"@justintadlock So you're saying that the font sizes will be broken in the site editor for any theme that uses slugs similar to core?","author_login":"bgardner","author_association":"NONE","created_at":"2024-02-12T20:47:46+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939555957","fragment_type":"issue_comment","sequence":19,"text":"Yes. \n\nThis has been an issue for several major releases and no one has a fix for it yet that doesn't break other things. Given the complexity of the issue, it's unlikely to be fixed in time for 6.5. Of course, if any contributor has time for a PR to fix in the next 24 hours, that could change. I'm sure plenty of folks would be willing to test.","author_login":"justintadlock","author_association":"CONTRIBUTOR","created_at":"2024-02-12T20:53:51+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939559751","fragment_type":"issue_comment","sequence":20,"text":"@justintadlock This issue has not existed (at least what I am experiencing URL until recently. The current version 6.4.3 is not experiencing this issue, and if ignored, this will become a major disaster for users of these themes. I am not sure at this point if anyone understands the severity of it, and I will glad Zoom you (or @annezazu) or whomever to show exactly what is happening.","author_login":"bgardner","author_association":"NONE","created_at":"2024-02-12T20:56:51+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939589285","fragment_type":"issue_comment","sequence":21,"text":"@bgardner - This specific ticket was created for Wordpress 6.2.2 and Gutenberg 16.1.0, so I want to make sure it's clear we're talking about punting something that's been understood to be an ongoing thing.\n\nNot sure if #57889 should be reopened at the moment, especially if it's a new issue introduced since WP 6.4. In that case, it should definitely be addressed for 6.5. Anyway, pinging some folks to see what we can get done. :)","author_login":"justintadlock","author_association":"CONTRIBUTOR","created_at":"2024-02-12T21:11:29+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939629306","fragment_type":"issue_comment","sequence":22,"text":"@justintadlock I understand. The original issue that was created ( URL was created at 6.4.2, and that is where I chimed in. It has since been closed, but the problem still exists. I think it needs to be re-opened (again) and made a priority for 6.5.","author_login":"bgardner","author_association":"NONE","created_at":"2024-02-12T21:38:54+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939637711","fragment_type":"issue_comment","sequence":23,"text":"Because this issue touches all of my themes, Ollie by Mike McAlister, even @ndiego's personal theme. Not to mention the (possible) 100's of themes that are using theme sizes/slugs similar to core.","author_login":"bgardner","author_association":"NONE","created_at":"2024-02-12T21:43:10+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939669566","fragment_type":"issue_comment","sequence":24,"text":"Circling back to ack that I Zoomed with @annezazu and @ajlende to walk through what I reported in URL More to come.","author_login":"bgardner","author_association":"NONE","created_at":"2024-02-12T22:03:46+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1941562622","fragment_type":"issue_comment","sequence":25,"text":"I tried to describe the problem we still see in this thread. Sorry, if it wasn't clear.","author_login":"iamtakashi","author_association":"NONE","created_at":"2024-02-13T13:50:35+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1991139077","fragment_type":"issue_comment","sequence":26,"text":"@scruffian I'm not sure the fix was reverted, we reverted a change that create this issue.","author_login":"youknowriad","author_association":"CONTRIBUTOR","created_at":"2024-03-12T09:22:42+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2010686264","fragment_type":"issue_comment","sequence":27,"text":"I think it's okay to close this now.\n\nI figured it was still in a broken state because URL had fixed it, but was reverted in URL causing it to be an issue again. URL was intended to reimplement URL and solve the issue again. However, URL which was the origin of this bug was reverted in URL fixing this issue. 😵‍💫 \n\nI still have the PR for adding the `defaultFontSizes` option in URL which I would still appreciate some reviews on 🙂 But I will be closing this issue now.","author_login":"ajlende","author_association":"CONTRIBUTOR","created_at":"2024-03-20T21:38:32+08:00","repo_name":"WordPress/gutenberg","issue_id":1783868460,"issue_number":52200,"issue_url":"https://github.com/WordPress/gutenberg/issues/52200","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0009","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"profile param does not working with AWS SSO config?","query_context":"I am able to use `load_aws_credentials()` with my default profile but it does not work when I specify a different profile, e.g. `load_aws_credentials('prod')`","known_context_document_ids":["gh_issue_1922544723"],"reference_answer":"lets move any discussion here to the aws repo and close this one. Check out the reply here: URL for a working workflow with secrets","answer_document_id":"gh_comment_2037509893","silver_evidence_path":["gh_comment_2006775038","gh_issue_1877574388","gh_comment_2037509893"],"evidence_issue_ids":[1922544723,1877574388],"source_repo_name":"duckdb/duckdb_aws","source_issue_id":1922544723,"source_issue_number":14,"source_issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","target_repo_name":"duckdb/duckdb_aws","target_issue_id":1877574388,"target_issue_number":10,"target_issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","reference_anchor_document_id":"gh_comment_2006775038","reference_answer_author":"samansmink","reference_answer_author_association":"COLLABORATOR","quality_score":86.57,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4286,"anchor_target_overlap":0.1277,"target_answer_overlap":0.0714},"issue_created_at":"2023-10-02T19:37:16+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_1922544723","fragment_type":"issue_description","sequence":0,"text":"profile param does not working with AWS SSO config\nI am able to use `load_aws_credentials()` with my default profile but it does not work when I specify a different profile, e.g. `load_aws_credentials('prod')`","author_login":"bobcolner","author_association":"NONE","created_at":"2023-10-02T19:37:16+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1801761694","fragment_type":"issue_comment","sequence":1,"text":"@bobcolner thanks for reporting. SSO configs may not yet be fully supported","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2023-11-08T12:09:29+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2004010988","fragment_type":"issue_comment","sequence":2,"text":"Hey @samansmink! \nI've played around and using sso while specifying the profile still doesn't work.\nBUT when doing this : \n\nCREATE SECRET (\n TYPE S3,\n PROVIDER credential_chain,\n CHAIN 'sso',\n PROFILE 'my-profile'\n )\n \n\n This does work. So, I guess we missed a small thing in the extension 🤔?\n Maybe worth updating the documentation to mention how to use `sso` , I've heard a couple of users requesting this","author_login":"mehd-io","author_association":"NONE","created_at":"2024-03-18T14:04:27+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006775038","fragment_type":"issue_comment","sequence":3,"text":"This all seems somewhat broken on v0.10 on Linux:\n* `CALL load_aws_crendentials();` no longer works on `v0.10.0 20b1486d11` for me when `AWS_PROFILE` is set. This is regression from `v0.9.2 3c695d7ba9`. (Although even 0.9.2 is not reliable - see #10.)\n* `CREATE SECRET` does not work for me when specifying the profile name - it returns `Success=true` from the call, but I then get a 403 error when the S3 `GET` request is made\n* If I set the `AWS_PROFILE` env var and use `CREATE SECRET`, omitting the profile parameter, it fails in the same way (and also if you omit the `CHAIN` parameter too)\n\nI can't make either `CALL load_aws_credentials()` or `CREATE SECRET` work on v0.10. If I run `aws configure export-credentials --profile foo` and manually set the legacy `s3_access_key_id`, `s3_secret_access_key` and `s3_session_token` config variables then everything works properly, so there's nothing wrong with the current SSO session, just the wiring here in DuckDB.","author_login":"herebebeasties","author_association":"NONE","created_at":"2024-03-19T10:40:17+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[1877574388],"is_known_query_context":false},{"document_id":"gh_comment_2031254975","fragment_type":"issue_comment","sequence":4,"text":"Hey everyone, thanks for reporting. I will try to set up some SSO config in our CI testing environment to properly test the SSO login method and fix any issues. \n\nJust for clarity here, @herebebeasties Did you also try the create secret syntax as described by @mehd-io?","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-04-02T07:23:33+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037500656","fragment_type":"issue_comment","sequence":5,"text":"Afaict the workflow described by @mehd-io works. I will PR this to the docs.\n\nSince `load_aws_credentials` is now deprecated, I did not test that and will not fix that if its broken\n\nI will leave this open until this is properly tested in the aws extension ci","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-04-04T15:20:23+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037523289","fragment_type":"issue_comment","sequence":6,"text":"Yes. It did not work for me - see the bullet points in my above message. What I've put in my above message is accurate.","author_login":"herebebeasties","author_association":"NONE","created_at":"2024-04-04T15:28:28+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037531907","fragment_type":"issue_comment","sequence":7,"text":"@herebebeasties\n\nCould you provide a reproducible example for the `CREATE SECRET` flow, describing the exact steps you've taken and the contents of your ~/.aws/config file? otherwise its a bit hard for me to reproduce this","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-04-04T15:32:11+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037551417","fragment_type":"issue_comment","sequence":8,"text":"I'm not really sure what a \"reproducible example\" would look like here beyond what I've already described, other than scripting up the creation of a whole AWS environment, S3 bucket, AWS policy, role, policy mapping, Microsoft Azure AD domain creation, SSO setup, etc. which would be pretty complex and time-consuming. Do you have something smaller and more specific in mind?\n\nI'll try to find some time to have a stab at debugging why this is failing in gdb, as tbh it's probably easier to do that than the above.","author_login":"herebebeasties","author_association":"NONE","created_at":"2024-04-04T15:40:17+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037576841","fragment_type":"issue_comment","sequence":9,"text":"Well, for example, I ran:\n\n`aws configure sso`\n\nnow my `~/.aws/config` looks like\n\n[default]\nregion=eu-west-1\n\n[profile duckdb-sso-test]\nsso_session = ...\nsso_account_id = ...\nsso_role_name = ...\nregion = eu-west-1\n\n[sso-session duckdb-sso-test]\nsso_start_url = ...\nsso_region =...\nsso_registration_scopes = ...\n\nThen to login I run:\n\naws sso login --profile=duckdb-sso-test\n\nNow I get a pop up in my browser to login, which I do.\n\nThen in DuckDB i run:\n\nSQL\nCREATE SECRET (\n TYPE s3, \n PROVIDER credential_chain, \n CHAIN 'sso', \n PROFILE 'duckdb-sso-test'\n);\n\nAnd now my auth works fine, and when I query `SELECT secret_string FROM duckdb_secrets()` I get:\n\nname=sso;type=s3;provider=credential_chain;serializable=true;scope=s3://,s3n://,s3a://;endpoint=s3.amazonaws.com;key_id=redacted;region=eu-west-1;secret=redacted;session_token=redacted\n\nAlternatively, If you would give a stab at debugging this, that would be super useful for sure.","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-04-04T15:50:49+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037687186","fragment_type":"issue_comment","sequence":10,"text":"That's exactly the same skeleton as my set-up and yet it doesn't work for me. I'll have a look in a debugger.","author_login":"herebebeasties","author_association":"NONE","created_at":"2024-04-04T16:38:04+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037691345","fragment_type":"issue_comment","sequence":11,"text":"Thanks! Be aware of the fact that I had to rerun the `aws sso login --profile=duckdb-sso-test` after some time. Also, DuckDB stores the raw temporary credentials in the secret, so when the session token expires, the secret is not automatically updated and needs to be manually re-created","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-04-04T16:40:31+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2076087806","fragment_type":"issue_comment","sequence":12,"text":"interesting, I have the same problem with duckdb under linux\n\nwhat worked in the end: \n\n1. write tmp credential to env: `$(AWS_PROFILE=dev-sso aws configure export-credentials --format env)`\n2. start duckdb\n3. load credential: `CALL load_aws_credentials();`\n4. set the region: `SET s3_region = 'eu-central-1';`\n5. select data: `SELECT * FROM 's3://bucket/path/file.parquet';` \n\nUsing the CONFIG storage above, it returns \"success\" but does not store any secret: \n\nD CREATE SECRET (\n TYPE S3,\n PROVIDER CREDENTIAL_CHAIN,\n REGION 'eu-central-1',\n PROFILE 'dev-sso',\n ENDPOINT 's3.eu-central-1.amazonaws.com'\n );\n100% ▕████████████████████████████████████████████████████████████▏\n┌─────────┐\n│ Success │\n│ boolean │\n├─────────┤\n│ true │\n└─────────┘\n\nD SELECT secret_string FROM duckdb_secrets();\n┌────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐\n│ secret_string │\n│ varchar │\n├────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤\n│ name=__default_s3;type=s3;provider=credential_chain;serializable=true;scope=s3://,s3n://,s3a://;endpoint=s3.eu-central-1.amazonaws.com;region=eu-central-1 │\n└────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘","author_login":"aweiher","author_association":"NONE","created_at":"2024-04-25T00:25:42+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2267347856","fragment_type":"issue_comment","sequence":13,"text":"I put up a PR (#49) to support SSO auth using the new method. It works on my machine :tm:","author_login":"drmorr0","author_association":"NONE","created_at":"2024-08-04T05:32:57+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2445181954","fragment_type":"issue_comment","sequence":14,"text":"I will close this issue, it works now on at least 2 machines ;) Feel free to open a new issue if sso problems persist","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-10-29T19:42:28+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1922544723,"issue_number":14,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1877574388","fragment_type":"issue_description","sequence":0,"text":"support loading credentials set by `aws sso login`\n`aws sso login` is a common path for users to log into their AWS console. The extension does not currently extract tokens from `~/.aws/sso/cache` where authentication token is cached to disk through this path. User needs to manually run `aws configure` to set up their `~/.aws/credentials` instead for the extension work. It would be great if support for the common path of `aws sson login` can be supported also.","author_login":"stephaniewang526","author_association":"NONE","created_at":"2023-09-01T14:52:32+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1751921300","fragment_type":"issue_comment","sequence":1,"text":"This setup seems to work for me:\n\n[default]\nsso_session = my-sso\nsso_account_id = 123456789123\nsso_role_name = SomeRole\nregion = us-east-1\noutput = json\n\n[sso-session my-sso]\nsso_region = us-east-1\nsso_start_url = URL \nsso_registration_scopes = sso:account:access\n\nNot sure if something was changed since this issue was opened.","author_login":"rairaman","author_association":"NONE","created_at":"2023-10-08T04:58:28+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1752498422","fragment_type":"issue_comment","sequence":2,"text":"Doesn't work here but I have a different setup with:\n`[default]\nsso_session = my-sso\nsso_account_id = 123456789123\nsso_role_name = SomeRole\n\noutput = json\n\n[sso-session my-sso]\nsso_region = us-east-1\nsso_start_url = URL \nsso_registration_scopes = sso:account:access`","author_login":"Anteus","author_association":"NONE","created_at":"2023-10-09T07:48:25+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847534984","fragment_type":"issue_comment","sequence":3,"text":"Also not working for me with same config as @rairaman \nI'm on `v0.9.2 3c695d7ba9`, linux ubuntu 22.04. I tried both zsh and bash, and even python with `duckdb.sql()`. \nNothing works.\nA colleague of mine has it work on his mac, his aws profile looks the same :shrug:","author_login":"RobbertDM","author_association":"NONE","created_at":"2023-12-08T17:05:29+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851062271","fragment_type":"issue_comment","sequence":4,"text":"After building myself, it works:\n\n./build/release/duckdb \nv0.9.3-dev1243 6af3519ec1\nD call load_aws_credentials();\n\nGives me a nice table full of credentials, while\n\nduckdb\nv0.9.2 3c695d7ba9\nD call load_aws_credentials();\n\nGives me an empty table.","author_login":"RobbertDM","author_association":"CONTRIBUTOR","created_at":"2023-12-11T23:32:14+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1992314686","fragment_type":"issue_comment","sequence":5,"text":"For me at least, if you have just done an `aws sso login` then it works. If some time has gone by then it doesn't.\n\n\"Ah, well your session must have expired!\" I hear you say. But no; `aws s3 ls` works just fine. So something else going on here.","author_login":"herebebeasties","author_association":"NONE","created_at":"2024-03-12T18:40:13+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037509893","fragment_type":"issue_comment","sequence":6,"text":"lets move any discussion here to the aws repo and close this one. Check out the reply here: URL for a working workflow with secrets","author_login":"samansmink","author_association":"COLLABORATOR","created_at":"2024-04-04T15:22:45+08:00","repo_name":"duckdb/duckdb_aws","issue_id":1877574388,"issue_number":10,"issue_url":"https://github.com/duckdb/duckdb_aws/issues/10","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0010","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Introduce common undo functionality and prevent accidental cell deletion?","query_context":"My request concerns the same as this one (closed issue from 2+ years ago): URL \n\nIt seems to be a frequently occurring problem until today, and a reason for people not to use VSCode for Jupyter notebooks. See for example: URL \n\nIt happens all too often: once a cell is not in focus, and one hits the common key combination to undo the last change (on Mac: Cmd + z), a cell gets deleted. Despite the suggested \"solution\" in issue 1998 (just hitting the key \"z\" when not focused on a cell), this does more of the same: it deletes cells!\nOnce a cell is deleted, undoing via menu or via Cmd + Shift + P (command palette), deletes just more cells. \n\nSo basically, with this extension, undoing in any way means deleting. And deleting can't be undone. \n\nI use VSCode for programming a lot. Just removing the common undo key combination is not an option for me. \n\nAlso, I think there really ought to be a working solution to undo an accidental deletion, because it seems to be the norm in any application these days to have the ability to undo the last change (deleting a cell is a change as well).\n\nBesides the obvious: it would be nice to undo the last edit, whether a cell is active or not!\n\nHas there been any developments in this regard?","known_context_document_ids":["gh_issue_1431563855"],"reference_answer":"This is fixed in main and will be available in next Insiders (tomorrow) and the next Stable.","answer_document_id":"gh_comment_2302987942","silver_evidence_path":["gh_comment_1358143262","gh_issue_1413465106","gh_comment_2302987942"],"evidence_issue_ids":[1431563855,1413465106],"source_repo_name":"microsoft/vscode","source_issue_id":1431563855,"source_issue_number":165159,"source_issue_url":"https://github.com/microsoft/vscode/issues/165159","target_repo_name":"microsoft/vscode","target_issue_id":1413465106,"target_issue_number":163943,"target_issue_url":"https://github.com/microsoft/vscode/issues/163943","reference_anchor_document_id":"gh_comment_1358143262","reference_answer_author":"rebornix","reference_answer_author_association":"MEMBER","quality_score":89.38,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3077,"anchor_target_overlap":0.0769,"target_answer_overlap":0.0},"issue_created_at":"2022-11-01T09:12:58+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1431563855","fragment_type":"issue_description","sequence":0,"text":"Introduce common undo functionality and prevent accidental cell deletion\nMy request concerns the same as this one (closed issue from 2+ years ago): URL \n\nIt seems to be a frequently occurring problem until today, and a reason for people not to use VSCode for Jupyter notebooks. See for example: URL \n\nIt happens all too often: once a cell is not in focus, and one hits the common key combination to undo the last change (on Mac: Cmd + z), a cell gets deleted. Despite the suggested \"solution\" in issue 1998 (just hitting the key \"z\" when not focused on a cell), this does more of the same: it deletes cells!\nOnce a cell is deleted, undoing via menu or via Cmd + Shift + P (command palette), deletes just more cells. \n\nSo basically, with this extension, undoing in any way means deleting. And deleting can't be undone. \n\nI use VSCode for programming a lot. Just removing the common undo key combination is not an option for me. \n\nAlso, I think there really ought to be a working solution to undo an accidental deletion, because it seems to be the norm in any application these days to have the ability to undo the last change (deleting a cell is a change as well).\n\nBesides the obvious: it would be nice to undo the last edit, whether a cell is active or not!\n\nHas there been any developments in this regard?","author_login":"repetitioestmaterstudiorum","author_association":"NONE","created_at":"2022-11-01T09:12:58+08:00","repo_name":"microsoft/vscode","issue_id":1431563855,"issue_number":165159,"issue_url":"https://github.com/microsoft/vscode/issues/165159","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1298645179","fragment_type":"issue_comment","sequence":1,"text":"Exactly @roblourens it's about the undo operation (no matter how it's called - \"z\", \"cmd + z\", from the command palette, from the menu), and that it doesn't undo the last action but deletes a cell, if the cell is not focused.\n\nBUT: this also happens when there IS focus on a cell, one scrolls up to another part of the notebook, and types. Usually, VSCode jumps back to where the cursor is still active (as do other apps). In jupyter mode, the last active cell is deleted. \nAnd yes, if one \"panicks\", then indeed, more cells are added to the \"kill list\" ;)\n\n_I use Local history, but it does not record any history when working on jupyter notebooks, and I found no config to change that. Also jupyter checkpoints don't get created (I saw another issue about that - I believe that is related to my M1 device though, so let's not entangle issues)._\n\nI think there are the following two problems here:\n\n1. the undo action behaves very abnormally compared to any other modern app, when a cell is not active\n2. the same applies if there theoretically IS focus on a cell but the cell is scrolled out of the viewport\n3. once undo accidentally deletes a cell, there's no way of restoring it","author_login":"repetitioestmaterstudiorum","author_association":"NONE","created_at":"2022-11-01T15:03:40+08:00","repo_name":"microsoft/vscode","issue_id":1431563855,"issue_number":165159,"issue_url":"https://github.com/microsoft/vscode/issues/165159","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1300583817","fragment_type":"issue_comment","sequence":2,"text":"It is undoing the last notebook-level action, it's undoing the cell addition. If you \"redo\" it puts the cell back. If you delete a cell like with cmd+backspace, then undo, it undoes the delete.\n\nYour problem 2 is annoying, yes, we might be able to do a better job with the focus state of cells that are scrolled out of view (and thus not actually rendered and focused).\n\nSo for 1, I believe it is consistent, maybe just not obvious since the cell \"add\" may have been a long time ago, so you don't realize you're undoing it. And 3, it can be restored by \"redo\" which makes sense, this is reversing the action you just did.\n\nAlso, the local history does seem very inconsistent.","author_login":"roblourens","author_association":"MEMBER","created_at":"2022-11-02T14:51:08+08:00","repo_name":"microsoft/vscode","issue_id":1431563855,"issue_number":165159,"issue_url":"https://github.com/microsoft/vscode/issues/165159","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1300716252","fragment_type":"issue_comment","sequence":3,"text":"Thank you for the hint about redoing, I wasn't aware! That indeed solves (3).","author_login":"repetitioestmaterstudiorum","author_association":"NONE","created_at":"2022-11-02T15:42:09+08:00","repo_name":"microsoft/vscode","issue_id":1431563855,"issue_number":165159,"issue_url":"https://github.com/microsoft/vscode/issues/165159","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1358143262","fragment_type":"issue_comment","sequence":4,"text":"Let's use URL to track problem 1&2 as both are talking about the same that it's not clear that users are undoing an operation they might not be aware of.","author_login":"rebornix","author_association":"MEMBER","created_at":"2022-12-19T19:19:40+08:00","repo_name":"microsoft/vscode","issue_id":1431563855,"issue_number":165159,"issue_url":"https://github.com/microsoft/vscode/issues/165159","linked_issue_ids":[1413465106],"is_known_query_context":false},{"document_id":"gh_issue_1413465106","fragment_type":"issue_description","sequence":0,"text":"Type in an invisible cell in edit mode, it goes to command mode\n### Applies To\n\n- [X] Notebooks (.ipynb files)\n- [ ] Interactive Window and\\/or Cell Scripts (.py files with \\#%% markers)\n\n### What happened?\n\nWhen trying to type in a cell (in edit mode for sure), but the cell is invisible, it automatically goes into command mode.\n\nTyping to an invisible cell is common: \n- user pastes many lines of code at the end of a cell;\n- user scrolls to check other part of the notebook.\n\nThis can be dangerous as user may hit `d` multiple times while typing, so cells are deleted.\n\nThe expected behavior is: when cell is invisible while in edit mode, typing should let notebook jump back to make it visible and it's kept in edit mode.\n\n### VS Code Version\n\n1.72.2\n\n### Jupyter Extension Version\n\n2022.9.1202862440\n\n### Jupyter logs\n\nshell\n(no special log for this issue)\n\n### Coding Language and Runtime Version\n\n_No response_\n\n### Language Extension Version (if applicable)\n\n_No response_\n\n### Anaconda Version (if applicable)\n\n_No response_\n\n### Running Jupyter locally or remotely?\n\nLocal","author_login":"yuuuxt","author_association":"NONE","created_at":"2022-10-18T04:34:01+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1282619545","fragment_type":"issue_comment","sequence":1,"text":"As far as I know, this would only affect when the cell itself is scrolled out of the viewport. This case\n \n\nwhen the cursor is out of the viewport but the cell itself is still rendered, should be fine.","author_login":"roblourens","author_association":"MEMBER","created_at":"2022-10-18T15:52:37+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1282623461","fragment_type":"issue_comment","sequence":2,"text":"In fact, it's not fine: cell will be out of view, too.\n\nI created this issue because I just deleted 2 cells by accident as I described.","author_login":"yuuuxt","author_association":"NONE","created_at":"2022-10-18T15:55:08+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1282638270","fragment_type":"issue_comment","sequence":3,"text":"Also, IMAO I don't agree it's a feature request, this behaviour can confuse user and cause loss of data; hope you can reconsider its priority. :)","author_login":"yuuuxt","author_association":"NONE","created_at":"2022-10-18T16:04:42+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1339821704","fragment_type":"issue_comment","sequence":4,"text":"I agree it's actually a bug, when the previous focus is in the cell out of viewport, users would expect typing can bring the cell into view, or at least just typing instead of running keybindings in command mode.","author_login":"rebornix","author_association":"MEMBER","created_at":"2022-12-06T18:48:56+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1978674354","fragment_type":"issue_comment","sequence":5,"text":"I am having problems with this aspect of the Jupyter extension also, I have luckily only deleted cells a couple of times. \n\nWith a fix underway, are there any suggested workaround settings that could perhaps at least mitigate the entering of command mode from an newly unrendered cell?","author_login":"SRooke","author_association":"NONE","created_at":"2024-03-05T12:34:30+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2302987942","fragment_type":"issue_comment","sequence":6,"text":"This is fixed in main and will be available in next Insiders (tomorrow) and the next Stable.","author_login":"rebornix","author_association":"MEMBER","created_at":"2024-08-21T20:48:52+08:00","repo_name":"microsoft/vscode","issue_id":1413465106,"issue_number":163943,"issue_url":"https://github.com/microsoft/vscode/issues/163943","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0011","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Tests / Docs / Docs fails on old PRs with blurb?","query_context":"The tests for PR #8150 were all green. When I added a blurb for #8150, Tests / Docs / Docs failed because of the 4-digit number.\n URL \n \n\nThe error occurred during the sphinx html build, but I have no idea where the misinformation is stored or what tracker this properly belongs on.","known_context_document_ids":["gh_issue_1801613083"],"reference_answer":"It is not clear to me whether to backport, so I did not, but this could still be done. Closing now.","answer_document_id":"gh_comment_1634487008","silver_evidence_path":["gh_comment_1633114020","gh_issue_1801646524","gh_comment_1634487008"],"evidence_issue_ids":[1801613083,1801646524],"source_repo_name":"python/cpython","source_issue_id":1801613083,"source_issue_number":106689,"source_issue_url":"https://github.com/python/cpython/issues/106689","target_repo_name":"python/cpython","target_issue_id":1801646524,"target_issue_number":106690,"target_issue_url":"https://github.com/python/cpython/issues/106690","reference_anchor_document_id":"gh_comment_1633114020","reference_answer_author":"terryjreedy","reference_answer_author_association":"MEMBER","quality_score":74.82,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0455,"anchor_target_overlap":0.0455,"target_answer_overlap":0.0},"issue_created_at":"2023-07-12T19:19:44+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_1801613083","fragment_type":"issue_description","sequence":0,"text":"Tests / Docs / Docs fails on old PRs with blurb\nThe tests for PR #8150 were all green. When I added a blurb for #8150, Tests / Docs / Docs failed because of the 4-digit number.\n URL \n \n\nThe error occurred during the sphinx html build, but I have no idea where the misinformation is stored or what tracker this properly belongs on.","author_login":"terryjreedy","author_association":"MEMBER","created_at":"2023-07-12T19:19:44+08:00","repo_name":"python/cpython","issue_id":1801613083,"issue_number":106689,"issue_url":"https://github.com/python/cpython/issues/106689","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1633093016","fragment_type":"issue_comment","sequence":1,"text":"The full message:\n \n\nIt doesn't work with _PR_ numbers.\n\nIt's expecting either a GitHub _issue_ number, the lowest such began at 32426, from when we transferred issues over from URL \n\nOr use the other format to specify a BPO ID.\n\nI think the easiest thing is to create a new issue for the PR, and use that issue number.","author_login":"hugovk","author_association":"MEMBER","created_at":"2023-07-12T19:28:40+08:00","repo_name":"python/cpython","issue_id":1801613083,"issue_number":106689,"issue_url":"https://github.com/python/cpython/issues/106689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1633114020","fragment_type":"issue_comment","sequence":2,"text":"There was no bpo issue: in the initial message, Ammar said \"(Can be marked with skip issue and skip news as it pertains to the build process)\" but I decided that a visible addition possibly used by non-core devs (to run coverage) should be mentioned. I opened #106690.","author_login":"terryjreedy","author_association":"MEMBER","created_at":"2023-07-12T19:47:02+08:00","repo_name":"python/cpython","issue_id":1801613083,"issue_number":106689,"issue_url":"https://github.com/python/cpython/issues/106689","linked_issue_ids":[1801646524],"is_known_query_context":false},{"document_id":"gh_issue_1801646524","fragment_type":"issue_description","sequence":0,"text":"Add a .coveragerc file to the CPython repository\nCheck branches both ways and ignore code that should be excluded from coverage. This includes some special directives for IDLE.\n\nThis file is used by the coverage package. It can be used where it is, in the repository directory, or copied elsewhere, depending on how one runs coverage.\n\n \n### Linked PRs\n* gh-8150","author_login":"terryjreedy","author_association":"MEMBER","created_at":"2023-07-12T19:46:31+08:00","repo_name":"python/cpython","issue_id":1801646524,"issue_number":106690,"issue_url":"https://github.com/python/cpython/issues/106690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1634487008","fragment_type":"issue_comment","sequence":1,"text":"It is not clear to me whether to backport, so I did not, but this could still be done. Closing now.","author_login":"terryjreedy","author_association":"MEMBER","created_at":"2023-07-13T15:48:31+08:00","repo_name":"python/cpython","issue_id":1801646524,"issue_number":106690,"issue_url":"https://github.com/python/cpython/issues/106690","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0012","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"vcpkg provided FluidSynth sounds incorrect compared to Meson wrap?","query_context":"### Are you using the latest DOSBox Staging version?\n\n- [x] I have checked and I'm using the latest release.\n\n### Different version than latest?\n\n_No response_\n\n### What operating system are you using?\n\nLinux x86_64\n\n### If other OS or Linux, please describe\n\nDebian 12\n\n### Are you running DOSBox Staging on a native OS?\n\n- [x] I am running Staging on a native OS\n\n### Relevant hardware info\n\n_No response_\n\n### Have you checked that no other similar issue already exists?\n\n- [x] I have searched and have not found similar issues.\n\n### A clear and concise description of what the bug is\n\nIt sounds like it's underwater or something. I also get the bad sound with my system (Debian provided) FluidSynth. Only the Meson wrap sounds correct.\n\nBad - System 2.3.1\nGood - Meson wrap 2.3.3\nBad - vcpkg 2.4.2\n\nfluidsynth-recordings.zip\n\nSoundfont I'm using:\n\nSC-55.SoundFont.v1.2b.sf2.zip\n\n### Steps to reproduce the behaviour\n\nExplain in detail how to reproduce the bug. Assume no familiarity with the software.\n1. Use Sound font linked above with FluidSynth\n2. Play first level of Doom using General MIDI\n3. Test with meson using `meson setup --force-fallback-for=fluidsynth` - Sound correct\n4. Test with CMake using vcpkg - Unlock hidden Doom underwater level\n\n### Download URL of affected game or software\n\n_No response_\n\n### Your configuration\n\nini\n\n### Provide a log\n\ntext\n\n### Code of conduct and contributing guidelines\n\n- [x] Yes, I agree.","known_context_document_ids":["gh_issue_2958983307"],"reference_answer":"This is not a bug. What you hear in `vcpkg.ogg` is called chrous - ever heard of?\n\nThe soundfont you use enables chorus for almost every instrument. So, even if the MIDI doesn't use chorus, the soundfont will!\n\nIf you don't like it, either use a different soundfont or disable chorus completely in fluidsynth.\n\nThe fix implemented by #1339 does ensure that chrous will now be heard in both, single and double precision builds.\n \n\nThere is no \"gold standard\". IIRC, CMake had double precision mode enabled by default. The old and long gone autotools buildsystem had single precision as default. My advice: Use single precision. It's less CPU expensive, better auto-vectorizable and sounds exactly the same. (Well, unless one encounters fancy numeric bugs like #1331.)\nPerhaps I'll change the default to single precision in the future.","answer_document_id":"gh_comment_2773293865","silver_evidence_path":["gh_comment_2777611858","gh_issue_2959151454","gh_comment_2773293865"],"evidence_issue_ids":[2958983307,2959151454],"source_repo_name":"dosbox-staging/dosbox-staging","source_issue_id":2958983307,"source_issue_number":4264,"source_issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","target_repo_name":"FluidSynth/fluidsynth","target_issue_id":2959151454,"target_issue_number":1523,"target_issue_url":"https://github.com/FluidSynth/fluidsynth/issues/1523","reference_anchor_document_id":"gh_comment_2777611858","reference_answer_author":"derselbst","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2424,"anchor_target_overlap":0.2424,"target_answer_overlap":0.1385},"issue_created_at":"2025-03-30T17:05:03+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2958983307","fragment_type":"issue_description","sequence":0,"text":"vcpkg provided FluidSynth sounds incorrect compared to Meson wrap\n### Are you using the latest DOSBox Staging version?\n\n- [x] I have checked and I'm using the latest release.\n\n### Different version than latest?\n\n_No response_\n\n### What operating system are you using?\n\nLinux x86_64\n\n### If other OS or Linux, please describe\n\nDebian 12\n\n### Are you running DOSBox Staging on a native OS?\n\n- [x] I am running Staging on a native OS\n\n### Relevant hardware info\n\n_No response_\n\n### Have you checked that no other similar issue already exists?\n\n- [x] I have searched and have not found similar issues.\n\n### A clear and concise description of what the bug is\n\nIt sounds like it's underwater or something. I also get the bad sound with my system (Debian provided) FluidSynth. Only the Meson wrap sounds correct.\n\nBad - System 2.3.1\nGood - Meson wrap 2.3.3\nBad - vcpkg 2.4.2\n\nfluidsynth-recordings.zip\n\nSoundfont I'm using:\n\nSC-55.SoundFont.v1.2b.sf2.zip\n\n### Steps to reproduce the behaviour\n\nExplain in detail how to reproduce the bug. Assume no familiarity with the software.\n1. Use Sound font linked above with FluidSynth\n2. Play first level of Doom using General MIDI\n3. Test with meson using `meson setup --force-fallback-for=fluidsynth` - Sound correct\n4. Test with CMake using vcpkg - Unlock hidden Doom underwater level\n\n### Download URL of affected game or software\n\n_No response_\n\n### Your configuration\n\nini\n\n### Provide a log\n\ntext\n\n### Code of conduct and contributing guidelines\n\n- [x] Yes, I agree.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-03-30T17:05:03+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2764673217","fragment_type":"issue_comment","sequence":1,"text":"I found the difference by doing some FluidSynth builds out of tree straight from upstream. In our `meson.build`, we're setting `enable-floats=true`. There's a CMake setting with the same name upstream. Description is \"enable type float instead of double for DSP samples\".\n\nWe probably want to set this in vcpkg if possible. At least this SC55 soundfont I'm using seems to depend on it.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-03-30T17:51:01+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764747813","fragment_type":"issue_comment","sequence":2,"text":"That's a FluidSynth bug. They had single precision float related bugs in their DSP code before, so looks like there's more:\n\n URL \n\nCan you report that on the FluidSynth issue tracker as well? I will look into setting 32-bit float mode at build time in the meantime (I think it helps with performance on low-end hardware somewhat).","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-03-30T21:11:44+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764756012","fragment_type":"issue_comment","sequence":3,"text":"I'm looking into it. I setup an overlay port for vcpkg to set custom build flags. Then I found that on top of the 32-bit float compile option that needs to be set, there's also a regression somewhere in between 2.3.3 and 2.4.2. So now I'm bisecting FluidSynth.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-03-30T21:34:52+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764759702","fragment_type":"issue_comment","sequence":4,"text":"Bisect done. It was actually the fix for that issue that caused the regression I'm noticing.\n\nFirst bad commit: URL \n\nFirst bad version: 2.3.6\n\nAll the versions after that commit sound equally as bad with 32-bit and 64-bit.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-03-30T21:45:31+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764766593","fragment_type":"issue_comment","sequence":5,"text":"Nice job :medal_sports: I don't these more recent versions have anything we really need, so we might wanna pin the version to 2.3.5 and ship 0.82.1 with that. I wanna get it out in a few days.","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-03-30T22:04:50+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764770034","fragment_type":"issue_comment","sequence":6,"text":"Are you planning on shipping with @shermp 's PR? If not, the Meson build is fine. It's parked on 2.3.3 with the Meson wrap.\n\nAlso, I found a vcpkg bug while I was working through this. URL","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-03-30T22:13:53+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764779441","fragment_type":"issue_comment","sequence":7,"text":"I put a PR in the ext repo. It uses an overlay port to make changes to the compile flags and downgrade the version.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-03-30T22:35:57+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764794455","fragment_type":"issue_comment","sequence":8,"text":"Not for 0.82.1. But we need the vcpkg fix for the MSVC CI build, so it's great you've done that so quickly 🎖 \n \n \n\nNice one, man! 🥳 🚀","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-03-30T23:13:56+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[2959151454],"is_known_query_context":false},{"document_id":"gh_comment_2777611858","fragment_type":"issue_comment","sequence":9,"text":"Re-opening this as the FluidSynth devs have stated this is not an upstream regression. See comment here: URL \n\nNeeds some more investigation. It looks like 2.3.5 and below had a bug that effectively disabled chorus when using `enable-floats=on`. I'm not sure why having no chorus makes this soundfont sound more correct. Is that a thing we should be explicitly disabling or is there another bug in our FluidSynth calling code?","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-04-04T05:43:34+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[2959151454],"is_known_query_context":false},{"document_id":"gh_comment_2777637307","fragment_type":"issue_comment","sequence":10,"text":"Yeah, I did investigate it a bit just didn't want to change things again before 0.82.1. At least now the behaviour is the same on macOS, Linux and Windows.\n\nI think Trevor's SC-55 SoundFont is just a bit crap 😎 If you check out our FluidSynth integration, a few SF2 files are already blacklisted to auto-disable the chorus with `fsynth_chorus = auto`.\n\nSo basically the solution is to just upgrade to the latest FS in 0.83.0, use the single precision path, and put this SC-55 recreation attempt on the blacklist too and call it a day 🤷🏻 We can't fix slightly crappy SF2 files 🤷🏻 \n\nI put much more trust in something well-thought-out like GeneralUser GS. The guys seems to know what he's doing, and he's done extensive testing on his SoundFont in a variety of SoundFont players. Trevor's work, on the other hand, seems like a hobbyist effort by a guy who doesn't have too much experience with authoring SF2 files. So I wouldn't use his SF2 as a benchmark for anything.\n\nSee the GeneralUser GS author's detailed instructions to get the best out of his SoundFont in DOSBox Staging:\n URL \n\nI'm intending to auto-detect GeneralUser GS in `fsynth_chorus = auto` and `fsynth_reverb = auto` mode and apply his recommended settings in 0.83.0.","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-04-04T06:04:38+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[2959151454],"is_known_query_context":false},{"document_id":"gh_comment_2777670844","fragment_type":"issue_comment","sequence":11,"text":"Yep, that makes sense. I'll give that a test later with the latest 2.4.4 FluidSynth. Then we can stay up to date with upstream. Hopefully you're right and it's just a buggy SF2 file with a quick and easy workaround via the blacklist.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-04-04T06:29:04+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2777675502","fragment_type":"issue_comment","sequence":12,"text":"Yeah, I'm pretty sure about that. I've just commented on the ticket in the FS issue tracker as well:\n URL \n\nWe want to be in sync with upstream because a few new interesting improvements are coming, e.g. SC-55-like portamento mode:\n URL \n\nI did a deep-dive into the portamento issue a while ago and concluded FS isn't capable of emulating the SC-55-specific portamento curves, so the best course of action for DOS games it just filter portamento MIDI messages out altogether. With this portamento enhancement, we'll be able to remove that filtering and just set FS into \"SC-55 portamento mode\".\n\nSee here:\n URL","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-04-04T06:32:25+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[2959151454],"is_known_query_context":false},{"document_id":"gh_comment_2779430704","fragment_type":"issue_comment","sequence":13,"text":"I tested blacklisting the soundfont to disable chorus. Unfortunately, now it sounds incorrect in a different way. Instead of \"underwater\", it sounds very muffled almost like it's in a tunnel. I tested with 2.3.5 and 2.4.4 with `enable-floats` both on and off and it all sounds wrong.\n\nIt appears this soundfont depends on chorus and 2.3.5 was not effectively disabling it as I previously thought. It instead sounds different and this soundfont depends on the old behavior.\n\nWe probably should test other soundfonts to see if there's more regressions before upgrading FluidSynth. If this is an outlier, we could print a log message if the user's soundfont contains \"SC-55\" warning that it's problematic and recommend they try out SoundCanvas instead.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-04-04T18:02:28+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781325010","fragment_type":"issue_comment","sequence":14,"text":"That makes sense to me @weirddan455. With the default settings there was a _lot_ of chorus applied to the sounds. Chorus effects work by adding multiple slightly detuned versions of the signal on top of the original signal. So yeah, with a strong chorus effect you'll get a quite noticeable volume boost!\n\nConsequently, with the chorus removed, we get a big volume drop and the relative volume of the reverb (the tunnel effect you're referring to) thus becomes a lot higher.\n\nThis is how Trevor's SF2 sounds compared to NukedSC55 with tweaked FluidSynth chorus and reverb settings. I used FluidSynth 2.4.2 built by the ext project before you introduce the override for this recording. I've just copied the chorus & reverb setting values from the settings' help, then tweaked the level parameter of both until the output started resembling the NukedSC55's output.\n\nrecordings.zip\n\nSo my conclusion is everthing works as expected. In 0.83.0 we can auto-detect this SF2 file an apply these tweaked settings when `fsynth_chorus` and `fsynth_reverb` is on `auto`. It's probably worth it as it was a popular SF2 prior to NukedSC55.\n\nini\n[midi]\n#mididevice = soundcanvas\nmididevice = fluidsynth\n\n[fluidsynth]\nsoundfont = \"D:\\Emulators\\DOS\\SoundFonts\\SC-55.SoundFont.v1.2b.sf2\"\nsoundfont_volume = 150\nfsynth_chorus = 3 0.1 0.3 8.0 sine\nfsynth_reverb = 0.61 0.23 0.76 0.15","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-04-06T09:18:35+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2803204549","fragment_type":"issue_comment","sequence":15,"text":"Have you had a chance to thest this with my tweaked settings @weirddan455 ?","author_login":"johnnovak","author_association":"MEMBER","created_at":"2025-04-14T22:30:49+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2807832980","fragment_type":"issue_comment","sequence":16,"text":"Those settings sound good to me and seem to fix the regression. Tested on 2.3.5 and 2.4.4.","author_login":"weirddan455","author_association":"COLLABORATOR","created_at":"2025-04-16T00:17:00+08:00","repo_name":"dosbox-staging/dosbox-staging","issue_id":2958983307,"issue_number":4264,"issue_url":"https://github.com/dosbox-staging/dosbox-staging/issues/4264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2959151454","fragment_type":"issue_description","sequence":0,"text":"Regression with \"enable-floats=on\" in DOSBox Staging\n### FluidSynth version\n2.3.6 is the first affected release. Up to and including 2.4.4 are also affected.\n4fc38101f01c5fdc7283054d65c264823b274708 is the first bad commit\n\n### Describe the bug\nPlaying Doom with an SC-55 soundfont sounds incorrect unless FluidSynth is compiled with \"enable-floats=on\". Starting with 4fc38101f01c5fdc7283054d65c264823b274708 it sounds incorrect regardless of that setting.\n\nSoundfont: URL \nRecordings: URL \n\nThe one named `meson.ogg` is the correct sounding one and `vcpkg.ogg` is the incorrect sounding one. It almost sounds like the music is playing underwater. \n\n### Expected behavior\nIdeally, it should sound correct regardless of the \"enable-floats\" setting but I'll settle for fixing the regression and we can continue to use that compile flag.\n\n### Steps to reproduce\nPlay the first level of Doom in DOSBox staging with a newer version of FluidSynth. Doom should be configured to run with General MIDI. In the .conf file, you should have\n\n[midi]\nmididevice = fluidsynth\n\n[fluidsynth]\nsoundfont = path/to/above/sc55.sf2","author_login":"weirddan455","author_association":"NONE","created_at":"2025-03-30T22:57:20+08:00","repo_name":"FluidSynth/fluidsynth","issue_id":2959151454,"issue_number":1523,"issue_url":"https://github.com/FluidSynth/fluidsynth/issues/1523","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2768081123","fragment_type":"issue_comment","sequence":1,"text":"As explained in my comment here, the behaviour is all over the place depending on which version you use and whether you do a single or double precision float build:\n URL \n\nYeah, I get it it's compelling to call a change in behaviour from one FluidSynth minor version to the next a regression, but because of these permutations in behaviour, I'm questioning if there was ever a \"correct\" behaviour implemented in the first place 😄 \n\nMaybe finding answer to a few questions would help: is double precision mode supposed to be the \"gold standard\"? Have most people been using FluidSynth compiled in double precision mode over the last 5-10+ years? If so, I'm inclined to think that's the \"correct\" behaviour.\n\nThe tricky thing is it's very hard to determine the \"correct\" behaviour by just comparing the results we get when using some random SoundFonts found on the internet. It doesn't even matter that they're popular; that proves nothing. Some people might have created the an SF2 file with something entirely different than FluidSynth which has slightly different behaviour. Then maybe some SF2 files were authored back in the 90s with Vienna Soundfont Studio for all we know!\n\nI guess SF2 files created with Vienna Soundfont Studio played back on an SB Live! or Audigy board is the \"most authentic\" standard SF2 playback standard to strive for. But then, if some people authored SF2 files in the past 20 years using FluidSynth or whatever else, those might sound a bit funky on a real SB Live! board... 🥶 \n\nSo... ultimately I have no idea what is even considered correct here. Please advise 😄","author_login":"johnnovak","author_association":"NONE","created_at":"2025-04-01T04:40:46+08:00","repo_name":"FluidSynth/fluidsynth","issue_id":2959151454,"issue_number":1523,"issue_url":"https://github.com/FluidSynth/fluidsynth/issues/1523","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773293865","fragment_type":"issue_comment","sequence":2,"text":"This is not a bug. What you hear in `vcpkg.ogg` is called chrous - ever heard of?\n\nThe soundfont you use enables chorus for almost every instrument. So, even if the MIDI doesn't use chorus, the soundfont will!\n\nIf you don't like it, either use a different soundfont or disable chorus completely in fluidsynth.\n\nThe fix implemented by #1339 does ensure that chrous will now be heard in both, single and double precision builds.\n \n\nThere is no \"gold standard\". IIRC, CMake had double precision mode enabled by default. The old and long gone autotools buildsystem had single precision as default. My advice: Use single precision. It's less CPU expensive, better auto-vectorizable and sounds exactly the same. (Well, unless one encounters fancy numeric bugs like #1331.)\nPerhaps I'll change the default to single precision in the future.","author_login":"derselbst","author_association":"MEMBER","created_at":"2025-04-02T17:48:50+08:00","repo_name":"FluidSynth/fluidsynth","issue_id":2959151454,"issue_number":1523,"issue_url":"https://github.com/FluidSynth/fluidsynth/issues/1523","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2777667356","fragment_type":"issue_comment","sequence":3,"text":"Cheers, so you're saying the double-precision behaviour has always been correct. That's good to know 👍🏻 \n \n\nYeah, I've heard plenty of modulation effects such as chorus during producing music for about 30 years now 😏 \n \n \n\nYep, I've concluded the SF2 file in question is just badly authored, so there's nothing we can do (other than disabling or tweaking the chorus setting to it sounds acceptable).\n \n\nYeah I looked into the official specs, and in indeed, it doesn't say anything specific about how the chorus and reverb effects should sound. But probably the default DSP settings on the SB Live! and Audigy boards are a rough \"de-facto\" standard. Probably your default chorus and reverb settings are close to that.\n\nThe author of GeneralUser GS who speaks highly of FluidSynth has started an SF2 compliance suite. There are also real-hardware recordings of the SB Live! and Audigy for reference.\n\n URL \n \n\nYep, I think switching to single-precision would be a good idea. I don't think you're gaining any quality advantage by doing 64-bit float math. Just like you said, you only need to ensure the DSP stuff is stable when using 32-bit floats too.","author_login":"johnnovak","author_association":"NONE","created_at":"2025-04-04T06:26:36+08:00","repo_name":"FluidSynth/fluidsynth","issue_id":2959151454,"issue_number":1523,"issue_url":"https://github.com/FluidSynth/fluidsynth/issues/1523","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781457045","fragment_type":"issue_comment","sequence":4,"text":"I am in close contact with Christian here on GH. His test is actually part of our testsuite, although this is unrelated to how chorus / reverb should behave, since there is no definition of \"how exactly\".","author_login":"derselbst","author_association":"MEMBER","created_at":"2025-04-06T14:40:40+08:00","repo_name":"FluidSynth/fluidsynth","issue_id":2959151454,"issue_number":1523,"issue_url":"https://github.com/FluidSynth/fluidsynth/issues/1523","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0013","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"systray as a module?","query_context":"Systray is placed by var ``tray = right|left``\n\nI think that it could be a nice thing to make it as a module. To be able to place it where we want, and to duplicate it (don't think it is possible, just wondering).","known_context_document_ids":["gh_issue_199763778"],"reference_answer":"There is no fixed timeline. It is mainly tied to which features I want in it. In the 3.6 blog post I said that I wanted to have a fixed tray, new font renderer, and some config syntax improvements in 3.7. But it is starting to look like that will be take too much time for a single release (I really want to release more often than every 12 months).\n\nSo I think we should release 3.7 once the tray module is stable and I am finished with #2609. I do want to finish #2609 before 3.7 because it will result in some breaking tray changes (basically if you had the tray anywhere outside of the bar window, this will no longer work) and if people should migrate to the module anyway that won't be a big problem.","answer_document_id":"gh_comment_1153250005","silver_evidence_path":["gh_comment_1803112121","gh_issue_1205909413","gh_comment_1153250005"],"evidence_issue_ids":[199763778,1205909413],"source_repo_name":"polybar/polybar","source_issue_id":199763778,"source_issue_number":314,"source_issue_url":"https://github.com/polybar/polybar/issues/314","target_repo_name":"polybar/polybar","target_issue_id":1205909413,"target_issue_number":2689,"target_issue_url":"https://github.com/polybar/polybar/issues/2689","reference_anchor_document_id":"gh_comment_1803112121","reference_answer_author":"patrick96","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1053,"anchor_target_overlap":0.2174,"target_answer_overlap":0.2982},"issue_created_at":"2017-01-10T08:51:17+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_199763778","fragment_type":"issue_description","sequence":0,"text":"systray as a module\nSystray is placed by var ``tray = right|left``\n\nI think that it could be a nice thing to make it as a module. To be able to place it where we want, and to duplicate it (don't think it is possible, just wondering).","author_login":"eoli3n","author_association":"NONE","created_at":"2017-01-10T08:51:17+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1072405468","fragment_type":"issue_comment","sequence":1,"text":"@Vlek Sorry for not replying to this earlier. We never issued bounties before. There is currently an effort by @raffael0 to make the current tray a module. Once that is finished, I'd be happy to coordinate a bounty payout between the two of you through our collective.\n\nYou would then make a one-time donation and @raffael0 would submit an expense for that amount that we then pay out.","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-03-18T13:22:22+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097868411","fragment_type":"issue_comment","sequence":2,"text":"Looking forward to this, the normal systray is buggy on fluxbox. using this module would likely solve my issues.","author_login":"SamuelGogarty","author_association":"NONE","created_at":"2022-04-13T10:17:03+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722377294","fragment_type":"issue_comment","sequence":3,"text":"Run this as a startup script:\n\n#!/bin/sh\nsleep 10 &\nkillall xembedsniproxy\n\nHappily running polybar under KDE with the systray","author_login":"Kyesarri","author_association":"NONE","created_at":"2023-09-17T03:03:38+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1803112121","fragment_type":"issue_comment","sequence":4,"text":"@Vlek Yes, this has now finally made into a stable release in version 3.7.0.\n\nThe tracking issue for the feature is #2689 and the initial modularization work was done in #2595.\n\n@raffael0 Do you want to receive this bounty through the polybar collective? It seems to be really easy, they even auto-generate the invoice for you. Payouts can be made through direct bank transfer or paypal.\n\n@Vlek Appreciate you paying out a bounty for this 😃. If Raffael accepts, you can make a one-time donation to the collective with the desired amount and I will coordinate this being paid out through the collective's expense system.","author_login":"patrick96","author_association":"MEMBER","created_at":"2023-11-09T03:37:03+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[1205909413],"is_known_query_context":false},{"document_id":"gh_comment_1803426726","fragment_type":"issue_comment","sequence":5,"text":"Wow. Yeah i'll gladly take the bounty in any way that is easiest for you.\nThank you! Just let me know what I have to do","author_login":"raffael0","author_association":"CONTRIBUTOR","created_at":"2023-11-09T09:06:34+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1805368949","fragment_type":"issue_comment","sequence":6,"text":"That's great! Once @Vlek sends the money, I can create an invoice invitation for you and you simply have to fill out the payment details. Is your protonmail email ok?\n\n@Vlek You can now make a \"Custom Contribution\" with the desired amount here: URL","author_login":"patrick96","author_association":"MEMBER","created_at":"2023-11-10T09:22:50+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1806605397","fragment_type":"issue_comment","sequence":7,"text":"@patrick96 @raffael0 sent. $100 for the bounty, $20 toward Polybar. Thank you both!\n\nimage","author_login":"Vlek","author_association":"NONE","created_at":"2023-11-11T00:50:00+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1806651798","fragment_type":"issue_comment","sequence":8,"text":"That's very generous, thank you very much!\n\n@raffael0 I have sent you an invoice invitation, let me know if everything works out.","author_login":"patrick96","author_association":"MEMBER","created_at":"2023-11-11T03:12:37+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1816568492","fragment_type":"issue_comment","sequence":9,"text":"I just wanted to let you know that I received the money. Thank you @Vlek for the generous bounty and @patrick96 for being a great maintainer and organizing the payout!","author_login":"raffael0","author_association":"CONTRIBUTOR","created_at":"2023-11-17T14:52:25+08:00","repo_name":"polybar/polybar","issue_id":199763778,"issue_number":314,"issue_url":"https://github.com/polybar/polybar/issues/314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1205909413","fragment_type":"issue_description","sequence":0,"text":"Stabilize tray module\nWith #2595 being merged, there are a few steps to make the tray module stable.\nThe goal is to completely deprecate positioning the tray without a module (and all `tray-*` settings in the bar section).\n\n* [x] Automatically hide/show the tray window depending on whether a tray position (`%{Pt}` tag) is set in the renderer. This is needed to deal with hiding modules.\n* [x] Remove `tray-position = adaptive` again and just activate the tray when a tray module exists (or one of the other positions is set). The existence of a tray module should override any value for `tray-position`. In particular, if a tray module exists *and* `tray-position` is set, a warning or error should be printed.\n* [x] Fix the tray window being pushed off the bar if there is too much stuff on the bar. The tray window should always be fully within the bar window.\n* [x] Rework all tray settings in module (see below)\n* [x] Write module documentation on RTD\n * [x] Write migration docs on RTD.\n* [x] Emit deprecation warnings for `tray-position` and all other tray settings in the bar section. #3002\n\nIt's probably easiest to implement each of these in a separate PR to keep complexity low. The order shouldn't matter except that the last one should be done last.\n\nIf we don't make the tray stable before the 3.7 release, polybar should also emit a warning whenever the tray module is used so that people are aware that the tray module may break again in the future.\n\n---\n\nFor those wanting to test it out right now, I'll also add a minimal example for how to add the tray module. All of this is experimental and any config options may change before the tray becomes stable.\n\ndosini\n[bar/example]\nmodules-left = tray\n\n[module/tray]\ntype = internal/tray\nformat = \n\n---\n\nWe could now also completely change the tray behavior if the module is used without it being a breaking change. In the `tray_manager` we could have a flag `in_module` that can be used to differentiate between behavior for the old tray or the module.\nWe should consider taking advantage of this, especially for formatting.\n\n* [x] There should be `tray-spacing`, which determines the spacing between the icons (`tray-padding` kind of does this already but the padding is also added at the beginning and end of the tray window.\n* [x] `tray-padding` should now be applied to the left and right of each individual icon (just as what happens for regular labels). Only supports points and pixels\n* [x] `tray-maxsize` and `tray-scale` should be merged into a single option. They both affect `client_height`, while `tray-maxsize` also increases spacing. This can be made cleaner. There should probably be just a single `tray-size` option (percentage with offset relative to bar height, defaults to 66%) and the final icon height and width is `min(bar_heigh, tray-size)`.\n* [x] Use of `tray-background` should be discouraged. Make it clear that it will only affect tha background of individual icons, not the spacing in between.\n\nThis would help fix #1207 I think.\n\nThe following tray settings will not have any equivalent setting in the module:\n\n* `tray-detached`: Not really sure what the use-case for this ever was\n* `tray-transparent`: Already deprecated and has no effect\n* `tray-offset-x`: Can be achieved with format offsets and offset tags.\n* `tray-offset-y`: Due to the tray being subwindows now, it cannot be moved outside of the bar area anyway. If people want to vertically position icons within the bar, we could introduce a `tray-alignmnent` setting.\n\n---\n\nThe new tray module would also be a workaround for #651, as long as there is enough padding before or after the tray module.\n\n---\n\n**Linked Issues & PRs**\n\n* #2723 \n* #2726 \n* #2727 \n* #2609\n* #3002","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-04-15T21:50:09+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100747754","fragment_type":"issue_comment","sequence":1,"text":"Since we now have experimental support in the feature branch we should probably add some documentation on how to use it. I think adding a new module in the wiki sidebar would probably be the best solution with a big experimental warning on top.\nAnother approach would be to wait with the documentation until the feature is stable.\nHow would you like to handle this?","author_login":"raffael0","author_association":"CONTRIBUTOR","created_at":"2022-04-16T20:09:27+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100787415","fragment_type":"issue_comment","sequence":2,"text":"I don't think documentation is crucial at the moment. Especially since any settings inside the tray module may well change again. We should probably hold off writing documentation until at least the config settings are stable.","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-04-17T02:07:57+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101181604","fragment_type":"issue_comment","sequence":3,"text":"Could you still provide a short example of how to use it? I would like to try it.","author_login":"tiagovla","author_association":"NONE","created_at":"2022-04-18T07:37:18+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114050287","fragment_type":"issue_comment","sequence":4,"text":"I thought a bit about the remaining issues and I have some questions/comments.\n1. Hiding the tray window. Was this already implemented? I'm not really sure which position you mean. The one we set in the context or the global position(left,center...)? When are the modules hidden?\n2. `tray_postition = adaptive`: Is there a way to check in the tray_manager if the tray module was instantiated? I added `adaptive` because I didn't know how to figure out when no tray module was instantiated and therefor didn't know when not to set left, right, center.\n3. pushed off bar: Has there been some prior work into something similar like this(Maybe with text)? Otherwise I imagine that this is going to be really difficult to implement since we never know in the renderer how much content will be added before or after the tray and how wide the tray is. I can't think of a way to approach this.\n4. How do you want to manage the configs? I can think of two approaches. First would be to keep the config handling in the tray_manager and just read the config from the tray module instead of the bar. This is a bit messy. The other option would be to move the config handling to the tray module. This is a much cleaner solution but then it's quite hard to get the config settings to the tray_manager(Maybe with a signal?) since they are completely separate right now. \n\nRight now a lot of logic is split between the tray_manager and the tray module with no way of them interacting(Besides signals). This complicates a lot but I can't think of a way to simplify this short of moving the tray_manager completely into the tray module. I'm unsure how \"clean\" we should implement these things since some(like the tray_position) will be removed later which cleans up a lot of code.","author_login":"raffael0","author_association":"CONTRIBUTOR","created_at":"2022-04-30T20:36:33+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114057195","fragment_type":"issue_comment","sequence":5,"text":"I didn't formulate that clearly, I meant whether the dispatch called `apply_tray_position` with a valid position. Tray hiding wasn't implemented before but since modules can be hidden, the tray should probably support it as well.\nWhat currently happens, is that if the module is hidden, no `%{Pt}` tag is emitted, so the tray position isn't updated and the tray just stays wherever it was in the previous render cycle.\n\nModules can be hidden using module actions (for example using polybar-msg).\n \n\nThe tray can't really check this. But what we can do, is pass this information from the controller to `bar::start` which then passes it to `tray_manager::setup`. The controller can check this in the loop where it creates the modules.\n \n\nFor text that doesn't fit onto the bar, we render a fading out gradient at the end of the bar when the left, right, and center blocks are placed on the bar:\n\n URL \n\nHowever, for the tray, my idea was to not have this logic in the renderer but in the tray itself.\nThe tray manager knows how wide the tray and the bar are, so when it receives the `tray_pos_change` signal, it can calculate whether the new position will place the tray window (partially) outside of the bar. And instead of hiding parts of the tray window when it goes outside of the bar, we keep it at the right end of the bar instead of letting it slide off. The calculation for the tray position would look something like this:\n\ntray_pos = bar.x + max(0, min(tray_pos, bar.w - tray_width))\n\n \n\nI think we should go with the first option, the tray manager should be responsible for loading its own configuration options. This could be achieved by passing the name of the tray module to `tray_manager::setup`.\n\n---\n\nIf we didn't have to still support `tray-position = left|center|right`, we would create the tray manager instace inside the tray module and would not have any of these issues about communicating information between components. But even if it is going to be removed at some point, it will still be with us for some time, so we shouldn't just be sloppy here.","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-04-30T21:31:09+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1149461926","fragment_type":"issue_comment","sequence":6,"text":"With the tray becoming a module, is it possible that true transparency could be added (as per URL \n\nNot to impose more features on this issue, just curious as to the possibility/complexity as someone without much understanding of X/WMs.","author_login":"ruscur","author_association":"NONE","created_at":"2022-06-08T04:58:48+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1149776129","fragment_type":"issue_comment","sequence":7,"text":"I also barely know anything about X and window managers :sweat_smile: so I'm probably not really qualified to answer that. \n\nThe changes we added in these PRs are basically one big hack. As you might know the tray right now is a separate window overlayed over the bar window. Instead of removing this window and incorporating the tray into the bar, we decided to internally create blank module with the same size as the tray window. The tray window is then just moved over the blank window in the bar. Therefore, the tray now behaves like a normal module but is still a separate window. \n\nI think that since we only change the window position the same problem still remains with true transparency although @patrick96 probably knows a lot more about it.\n\nI hope this helps!","author_login":"raffael0","author_association":"CONTRIBUTOR","created_at":"2022-06-08T11:07:10+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152130692","fragment_type":"issue_comment","sequence":8,"text":"Sorry for the radio silence, I have been swamped the past few weeks. I appreciate your work on this :smiley: \n\nI should have some time to start reviewing stuff again next week, but I will only be around sporadically for at least a month or two.\n\n---\n \n\n:+1:\n \n\nTrue transparency remains as difficult as it has before, this \"new\" tray module didn't really change how the tray is rendered, just where it is placed on the bar. I am considering adding back true transparency in #2609, but no promises.\n \n\nI don't think we will ever get away from doing it like this. Since each tray icon is a separate window, we have to somehow overlay them over the bar window.","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-06-10T08:49:34+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153000471","fragment_type":"issue_comment","sequence":9,"text":"I'll look over/reorganize my existing PRs till next week and try to finish the settings one. \n\nSince the plan is to release this feature with 3.7. What's your timetable for that release?","author_login":"raffael0","author_association":"CONTRIBUTOR","created_at":"2022-06-11T21:24:59+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153250005","fragment_type":"issue_comment","sequence":10,"text":"There is no fixed timeline. It is mainly tied to which features I want in it. In the 3.6 blog post I said that I wanted to have a fixed tray, new font renderer, and some config syntax improvements in 3.7. But it is starting to look like that will be take too much time for a single release (I really want to release more often than every 12 months).\n\nSo I think we should release 3.7 once the tray module is stable and I am finished with #2609. I do want to finish #2609 before 3.7 because it will result in some breaking tray changes (basically if you had the tray anywhere outside of the bar window, this will no longer work) and if people should migrate to the module anyway that won't be a big problem.","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-06-12T18:07:44+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328325562","fragment_type":"issue_comment","sequence":11,"text":"@Quantenzitrone I have also noticed this and I think I no longer see this in #2609. However certain applications still have that issue (dropbox for me) and I have not yet found a way to make them behave (I am not even sure if a way exists).\n\nI have also decided to not implement true transparency for the tray icons because we would have to do the compositing ourselves and couldn't use a compositor like picom and I don't have the time to do that.","author_login":"patrick96","author_association":"MEMBER","created_at":"2022-11-27T19:46:37+08:00","repo_name":"polybar/polybar","issue_id":1205909413,"issue_number":2689,"issue_url":"https://github.com/polybar/polybar/issues/2689","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0014","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Add an installer option to not install the service?","query_context":"Hello,\n\nbecause of the issue with windows_exporter not starting on boot, discussed here:\n\n URL \n URL \n URL \n\nthe **only** reliable way to use this software is to wrap the service in a tool such as WinSW or the classic nssm.\n\nThat isn't ideal, but at least it works - however it poses a new problem: Because the windows_exporter MSI always forecfully installs the windows_exporter service my ansible role to deploy the windows_exporter now always has to do two consecutive changes and is not properly idempotent anymore:\n\nAfter installing or updating windows_exporter (change 1), it has to replace the auto-created, non-functioning service from the installer with the winsw-wrapped version of the service again (change 2 - even though the winsw service and its configuration haven't changed, this task will now result in a change)\n\nThis service flip-flopping during a rollout could be avoided if the MSI installer exposed an argument that allows the service-creation to be suppressed during the install.\n\nThanks!","known_context_document_ids":["gh_issue_1320492618"],"reference_answer":"It seems like it worked as expected, because that an internal windows installer behavior.\n\nWindows Installer mostly does nothing on reinstaller. To restore an installation, you have to force a repair mode.\n\nwith \n\nmsiexec.exe /fa \"windows_exporter-0.26.0-amd64.msi\" /qn\n\nthe service is getting restored. I tested that on a windows server. Sadly, we are unable to change the windows installer behavior here.","answer_document_id":"gh_comment_2105943992","silver_evidence_path":["gh_comment_1867836315","gh_issue_2054100920","gh_comment_2105943992"],"evidence_issue_ids":[1320492618,2054100920],"source_repo_name":"prometheus-community/windows_exporter","source_issue_id":1320492618,"source_issue_number":1033,"source_issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","target_repo_name":"prometheus-community/windows_exporter","target_issue_id":2054100920,"target_issue_number":1368,"target_issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1368","reference_anchor_document_id":"gh_comment_1867836315","reference_answer_author":"jkroepke","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2121,"anchor_target_overlap":0.2424,"target_answer_overlap":0.1724},"issue_created_at":"2022-07-28T07:08:49+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1320492618","fragment_type":"issue_description","sequence":0,"text":"Add an installer option to not install the service\nHello,\n\nbecause of the issue with windows_exporter not starting on boot, discussed here:\n\n URL \n URL \n URL \n\nthe **only** reliable way to use this software is to wrap the service in a tool such as WinSW or the classic nssm.\n\nThat isn't ideal, but at least it works - however it poses a new problem: Because the windows_exporter MSI always forecfully installs the windows_exporter service my ansible role to deploy the windows_exporter now always has to do two consecutive changes and is not properly idempotent anymore:\n\nAfter installing or updating windows_exporter (change 1), it has to replace the auto-created, non-functioning service from the installer with the winsw-wrapped version of the service again (change 2 - even though the winsw service and its configuration haven't changed, this task will now result in a change)\n\nThis service flip-flopping during a rollout could be avoided if the MSI installer exposed an argument that allows the service-creation to be suppressed during the install.\n\nThanks!","author_login":"jantari","author_association":"NONE","created_at":"2022-07-28T07:08:49+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":1320492618,"issue_number":1033,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1221102942","fragment_type":"issue_comment","sequence":1,"text":"Right now the only difference between the MSI and EXE options provided by this project are the system service and the firewall rules (plus any intrinsic MSI behaviour).\nIs the EXE not an option for your use case?","author_login":"breed808","author_association":"CONTRIBUTOR","created_at":"2022-08-19T21:24:29+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":1320492618,"issue_number":1033,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826382286","fragment_type":"issue_comment","sequence":2,"text":"I have worked around the issue by giving the working (WinSW-wrapped) service a different name (such as `windows_exporter_winsw`). Now I only have to delete/disable the `windows_exporter` service after every update of windows_exporter, but an update is a change anyways so it doesn't matter that we tack on another required follow-up change.\n\nUsing the EXE would be very inconvenient for two reasons:\n\n1. We use package managers like `chocolatey` or `winget` to provision and update software, and both only carry the MSI installer. To use the EXE installer we would have to create and maintain a custom software package.\n2. The EXE download is not an installer, just a \"portable\" executable. This means it doesn't register its presence on the system with the MSI software database or the registry keys for ARP. This means it won't be tracked by software inventory systems. We have to verify that updates are being installed and are working as expected in case our deployment contains a (logic) error.\n\nSoftware that's in the MSI database or at least the registry can easily be inventoried and tracked across thousands of systems by external tools.","author_login":"jantari","author_association":"NONE","created_at":"2023-11-25T17:26:14+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":1320492618,"issue_number":1033,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826408455","fragment_type":"issue_comment","sequence":3,"text":"To confirm, the request originated from a need to manage the `windows_exporter` service, due to the MSI-provided service failing to start?\n\nIs that still the case now that #1047 (`window_exporter` >= `v0.20.0`) has been implemented?","author_login":"breed808","author_association":"CONTRIBUTOR","created_at":"2023-11-25T19:55:05+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":1320492618,"issue_number":1033,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1867836315","fragment_type":"issue_comment","sequence":4,"text":"When attempting to test v0.24.0 on some machines I ran into a follow-up problem: URL \n\nSince I had removed the (formerly unreliable) `windows_exporter` service intentionally in favor of my own, now, when I perform a reinstall of windows_exporter to recreate the service and remove my own wrapper-service (`windows_exporter_winsw`) I am left with no windows_exporter running at all - because reinstalling the software did not recreate the missing service.","author_login":"jantari","author_association":"NONE","created_at":"2023-12-22T15:50:47+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":1320492618,"issue_number":1033,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","linked_issue_ids":[2054100920],"is_known_query_context":false},{"document_id":"gh_comment_2018194161","fragment_type":"issue_comment","sequence":5,"text":"Exactly.\n \n\nI checked across our systems where we deployed 0.24.0 without a WinSW wrapper to test it, and we haven't seen these issues with the service failing to start anymore. Thus this issue is resolved for me, thanks.","author_login":"jantari","author_association":"NONE","created_at":"2024-03-25T14:55:21+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":1320492618,"issue_number":1033,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1033","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2054100920","fragment_type":"issue_description","sequence":0,"text":"Reinstalling MSI does not create service\nWhen the MSI installer is re-run to do an in-place reinstall or \"repair\", it does not recreate the windows_exporter service if missing.\n\nSteps to reproduce:\n\npowershell\n# Perform initial install of the latest version\nchoco install prometheus-windows-exporter.install --version 0.24.0\n# Confirm service is created and running\nGet-Service -Name windows_exporter\n# Stop and delete the service\nsc.exe stop windows_exporter\nsc.exe delete windows_exporter\n# Oops! But no worries, perform a reinstall to fix it\nchoco install prometheus-windows-exporter.install --version 0.24.0 --force\n# Check whether the service has been recreated - it will not be there!\nGet-Service -Name windows_exporter\n\nI have noticed that the service is recreated as expected when:\n\n- Performing an upgrade install, such as when installing 0.23.1, then deleting the service, then installing 0.24.0\n- Performing an explicit uninstall first, then an install again","author_login":"jantari","author_association":"NONE","created_at":"2023-12-22T15:48:54+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":2054100920,"issue_number":1368,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018215554","fragment_type":"issue_comment","sequence":1,"text":"Yep, I reproduced with 0.25.1 as well. Here's a copy-paste repro without chocolatey, just using onboard windows stuff:\n\npowershell\n# Download windows_exporter 0.25.1\ncurl.exe -LO \" URL \n\n# Install it\ncmd.exe /D /C start \"\" /wait /b msiexec.exe /i \"windows_exporter-0.25.1-amd64.msi\" /qn\n\n# Confirm windows_exporter service exists\nsc.exe queryex windows_exporter\n\n# Remove windows_exporter service\nsc.exe stop windows_exporter\nsc.exe delete windows_exporter\n\n# Reinstall windows_exporter to repair\ncmd.exe /D /C start \"\" /wait /b msiexec.exe /i \"windows_exporter-0.25.1-amd64.msi\" /qn\n\n# Confirm windows_exporter service exists\nsc.exe queryex windows_exporter\n\n# IT'S NOT THERE\n\nOnly way to bring the service back is to completely uninstall windows_exporter, and then reinstall.","author_login":"jantari","author_association":"NONE","created_at":"2024-03-25T15:03:59+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":2054100920,"issue_number":1368,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1368","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105943992","fragment_type":"issue_comment","sequence":2,"text":"It seems like it worked as expected, because that an internal windows installer behavior.\n\nWindows Installer mostly does nothing on reinstaller. To restore an installation, you have to force a repair mode.\n\nwith \n\nmsiexec.exe /fa \"windows_exporter-0.26.0-amd64.msi\" /qn\n\nthe service is getting restored. I tested that on a windows server. Sadly, we are unable to change the windows installer behavior here.","author_login":"jkroepke","author_association":"MEMBER","created_at":"2024-05-11T16:14:48+08:00","repo_name":"prometheus-community/windows_exporter","issue_id":2054100920,"issue_number":1368,"issue_url":"https://github.com/prometheus-community/windows_exporter/issues/1368","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0015","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"processor network error on Send transaction?","query_context":"# Bug Report\n\n## Description\n\n \n\nErroe message: WPP-025 - status-proxy-O.error: insufficient funds for gas * price + value: add ress 0x3212fD7C2C7984DD6de153691D901445fC8AA07 have 2783037892\n8767798 want 159078669589875316\n\n## Steps to reproduce\n\n \nUse an account that has enough funds to do a send transaction on Mainnet\n\n1. Go to the Wallet\n2. Click Send\n3. When the modal opens, select a small amount of eth to sent\n4. Notice that an error displays \n\n#### Expected behavior\nUser to be able to perform a Send tx\n\n#### Actual behavior\nUser unable to do a send tx, even though they have enough funds\nScreenshot 2024-09-16 at 4 43 40 PM\n\n### Additional Information\ngeth 2.log.zip\napp_20240916_154447.log\n\n- Status desktop version: 2.30 rc-1\n- Operating System: Mac OS Sonoma","known_context_document_ids":["gh_issue_2529504508"],"reference_answer":"There is no actually one conclusion (as it was checked with disabled both grove and proxy(, and the discussion moved there, but yeah, seems that the issue might be on both sides - grove and proxy. \nThanks for the comment. I'll bring this issue today on wallet sync, thank you","answer_document_id":"gh_comment_2385308488","silver_evidence_path":["gh_comment_2363286139","gh_issue_2536473359","gh_comment_2385308488"],"evidence_issue_ids":[2529504508,2536473359],"source_repo_name":"status-im/status-desktop","source_issue_id":2529504508,"source_issue_number":16352,"source_issue_url":"https://github.com/status-im/status-desktop/issues/16352","target_repo_name":"status-im/status-mobile","target_issue_id":2536473359,"target_issue_number":21292,"target_issue_url":"https://github.com/status-im/status-mobile/issues/21292","reference_anchor_document_id":"gh_comment_2363286139","reference_answer_author":"churik","reference_answer_author_association":"MEMBER","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3333,"target_answer_overlap":0.0},"issue_created_at":"2024-09-16T21:08:57+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2529504508","fragment_type":"issue_description","sequence":0,"text":"processor network error on Send transaction\n# Bug Report\n\n## Description\n\n \n\nErroe message: WPP-025 - status-proxy-O.error: insufficient funds for gas * price + value: add ress 0x3212fD7C2C7984DD6de153691D901445fC8AA07 have 2783037892\n8767798 want 159078669589875316\n\n## Steps to reproduce\n\n \nUse an account that has enough funds to do a send transaction on Mainnet\n\n1. Go to the Wallet\n2. Click Send\n3. When the modal opens, select a small amount of eth to sent\n4. Notice that an error displays \n\n#### Expected behavior\nUser to be able to perform a Send tx\n\n#### Actual behavior\nUser unable to do a send tx, even though they have enough funds\nScreenshot 2024-09-16 at 4 43 40 PM\n\n### Additional Information\ngeth 2.log.zip\napp_20240916_154447.log\n\n- Status desktop version: 2.30 rc-1\n- Operating System: Mac OS Sonoma","author_login":"virginiabalducci","author_association":"NONE","created_at":"2024-09-16T21:08:57+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2354714935","fragment_type":"issue_comment","sequence":1,"text":"@virginiabalducci that error doesn't come from our side, it's from the network. Not sure what we can do there.\n\nDuring the sending process if any network error occurs the transfer processor will display it as `WPP-025` error, but the description may differ, it reflects a real error.\n\nAlso I see that you got this error: `WPP-025 - status-proxy-O.error: insufficient funds for gas * price + value: address 0x3212fD7C2C7984DD6de153691D901445fC8AA07 have 27830378928767798 want 159078669589875316`\nbut no chain we support has a positive balance for the used address `0x3212fD7C2C7984DD6de153691D901445fC8AA07`\nso the error is expected, not sure what's wrong?","author_login":"saledjenic","author_association":"CONTRIBUTOR","created_at":"2024-09-17T07:06:14+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2363286139","fragment_type":"issue_comment","sequence":2,"text":"@virginiabalducci to get a better understanding about router's logic, please have a look at this comment URL","author_login":"saledjenic","author_association":"CONTRIBUTOR","created_at":"2024-09-20T09:32:33+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[2536473359],"is_known_query_context":false},{"document_id":"gh_comment_2363531151","fragment_type":"issue_comment","sequence":3,"text":"I guess yes, that's what we're going to do with the new Send modal design.","author_login":"saledjenic","author_association":"CONTRIBUTOR","created_at":"2024-09-20T11:40:37+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2396362247","fragment_type":"issue_comment","sequence":4,"text":"I experience this error whenever I try to transfer funds, such as buying a Status ENS domain or trying wallet-to-wallet transaction. The origin Status Wallet has 21 USD, and I can't transfer any amount of money to the destination Wallet on the Ethereum mainnet. The error is always the same in both Simple and Advanced modes:\n\n`WPP-028 - status-proxy-O.error: failed with 50130704 gas: insufficient f unds for gas * price + value: address 0×925Bd[...]2917E have 0 want 4025019521328142`\n\nThis is using my Status account on mainnet, not a test account on testnet (Status desktop 2.30.0).\n\nI'm far from an expert here, but I don't think this error is expected, @saledjenic (CC/ @virginiabalducci )\n\nI hope this helps!\n\nImage","author_login":"jorge-campo","author_association":"NONE","created_at":"2024-10-07T09:12:23+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2396389922","fragment_type":"issue_comment","sequence":5,"text":"Hi @jorge-campo you're right it should not be like that when buying ens name. There are 2 potential reasons for that:\n- you should confirm that your account (the one you're using for sending the tx) has enough ETH to pay for the tx execution besides having 10 SNT for the ens name (in the screenshot I see that the selected token is ETH and you're trying to send 10 ETH actually). So that's most likely the reason. If you want to buy an ens name, go to Settings/Ens usernames section\n- we're still using grove provider and the error that you're experiencing is coming from it and it can be unreliable in some cases and should not be there after we switch to nodefleet, that supposed to be very soon, these days. But based on the screenshot, that's not the case there.","author_login":"saledjenic","author_association":"CONTRIBUTOR","created_at":"2024-10-07T09:24:27+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2396467157","fragment_type":"issue_comment","sequence":6,"text":"Thanks, @saledjenic !\n\nThe screenshot is unrelated to the ENS name purchase; it's a direct wallet-to-wallet transaction of ETH on Ethereum mainnet. I have 21 USD in my wallet, and I can't send 10, 5, or 2 USD with the \"insufficient gas fee\" error.\n\nI am happy to hear that the switch to Nodefleet will happen soon! 👍","author_login":"jorge-campo","author_association":"NONE","created_at":"2024-10-07T09:58:47+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2399602700","fragment_type":"issue_comment","sequence":7,"text":"Closing this one as it has been concluded this is related to network issues and not from the app itself","author_login":"virginiabalducci","author_association":"NONE","created_at":"2024-10-08T11:37:10+08:00","repo_name":"status-im/status-desktop","issue_id":2529504508,"issue_number":16352,"issue_url":"https://github.com/status-im/status-desktop/issues/16352","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2536473359","fragment_type":"issue_description","sequence":0,"text":"Unable to send tokens which are available only on L1 network\nFro reproduction you can use SNT\n\n**Steps:** \n\n1. Restore the account which has SNT \n2. Proceed with sending flow\n3. See if the routes are built after entering valid amount\n\n**Actual result:** \n\nStatus-debug-logs - 2024-09-19T171851.912.zip\n\nOn mobile I receive different errors, like \ntransfer amount exceeds balance\n or \nnot available for chain ID\n\nphoto_2024-09-19 17 04 50\nphoto_2024-09-19 17 04 55\n\nSame on Desktop: \n\n<img width=\"542\" alt=\"Status Desktop 2024-09-19 17-09-01\" src=\" URL \n\ncc @saledjenic @anastasiyaig \n### Additional Information\n\n- Status version: nightly \n- Operating System: Android, iOS\n\n[comment]: # (Please, add logs/notes if necessary)","author_login":"pavloburykh","author_association":"CONTRIBUTOR","created_at":"2024-09-19T14:12:39+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2361117129","fragment_type":"issue_comment","sequence":1,"text":"i was able to send snt just 2 days ago. i dont have any context besides that. maybe something got broken recently \n\n@virginiabalducci can you pls check?","author_login":"anastasiyaig","author_association":"NONE","created_at":"2024-09-19T14:16:44+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2361172818","fragment_type":"issue_comment","sequence":2,"text":"thanks @virginiabalducci \n@saledjenic @dlipicar do you know the root cause?","author_login":"anastasiyaig","author_association":"NONE","created_at":"2024-09-19T14:33:25+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2363275012","fragment_type":"issue_comment","sequence":3,"text":"@virginiabalducci I was able to reproduce your case with `0x32e12fd7c2c7984dd6de153691d901445fc8aa07` address.\n\nSo let's analyze it:\n- you want to send 1 SNT from the `0x32e12fd7c2c7984dd6de153691d901445fc8aa07` from any of the supported chains (mainnet, opt, arb) to the recipient address to any chain (mainnet, opt, arb) \n- what are possible options (since you have a positive balance for SNT only on mainnet):\n 1. mainnet -> mainnet (transfer)\n 2. mainnet -> optimism (bridge)\n 3. mainnet -> arbitrum (bridge)\n- let's look now at how the router sees that request since all chains are available on both from and to sides:\n 1. check transfer for mainnet -> mainnet -> this returns `insufficient funds for gas * price + value: address 0x32e12fD7C2C7984DD6de153691D901445fC8AA07 have 16773029697747188 want 235096461785385998`\n 2. check transfer optimism -> optimism (transfer) -> `execution reverted: ERC20: transfer amount exceeds balance` cause you have 0 SNT on optimism\n 3. check transfer arbitrum -> arbitrum (transfer) -> `execution reverted: ERC20: transfer amount exceeds balance` cause you have 0 SNT on arbitrum\n 4. check bridge `mainnet` -> `optimism` -> `not available for chainID` means there is no contract for bridging SNT\n 5. check bridge `mainnet` -> `arbitrum` -> `not available for chainID` means there is no contract for bridging SNT\n 6. check bridge `optimism` -> `mainnet` -> `not available for chainID` means there is no contract for bridging SNT\n 7. check bridge `optimism` -> `arbitrum` -> `not available for chainID` means there is no contract for bridging SNT\n 8. check bridge `arbitrum` -> `mainnet` -> `not available for chainID` means there is no contract for bridging SNT\n 9. check bridge `arbitrum` -> `optimism` -> `not available for chainID` means there is no contract for bridging SNT\n- now looking at the previous point we confirmed that there is no route that can be made, which is correct, that's what the router says, but a question is about the error, which one of those is the most meaningful for you? You cannot choose one, but the right way would be to return all of them, right? Displaying all of them was rejected as an idea in one of my PRs and then we had to choose one to display. There is some logic for selecting the most meaningful error which is working quite well, but in case like this one where all chains are in play on the \"from\" and \"to\" side is hard to select one (especially when we have different processor orders among router runs) cause all are valid errors.\n\n**To summarize and conclude, there is no error in the router logic.**\n@virginiabalducci @anastasiyaig @pavloburykh @alwx","author_login":"saledjenic","author_association":"NONE","created_at":"2024-09-20T09:26:37+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2363354434","fragment_type":"issue_comment","sequence":4,"text":"Thank you for the comment @saledjenic \n\nI have couple of questions here:\n\n1. Regarding insufficient funds error: we have an open issue URL Could you please leave a comment in that issue summarising your findings regrading this problem. I remember that recently there have been much discussions in different Discord channels, but unfortunately there is no summary in the ticket. Currently we are not able to perform L1-L1 transactions in Status app, at the same time I am able to perform same transaction with the same account using Metamask. \n\n2. At which point do we understand that token is available only on L1 and thus there is no sense to try building any routes except L1-L1? Can we prevent from trying to perform \nmainnet -> optimism (bridge)\n, \nmainnet -> arbitrum (bridge)\n etc steps if we know that only mainnet-mainnet is available? To be honest, this is very confusing that we are showing user the irrelevant errors like \ntransfer amount exceeds balance\n or \nnot available for chain ID\n while app UI shows that we are trying to build L1-L1 route and both errors have nothing to do with L1-L1 in this case. Why we are not showing \ninsufficient funds\n here which is related to L1-L1 route building?","author_login":"pavloburykh","author_association":"CONTRIBUTOR","created_at":"2024-09-20T10:06:59+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2385222345","fragment_type":"issue_comment","sequence":5,"text":"I believe we can close URL in favour of URL and wait for new RPC provider integration 🤞","author_login":"churik","author_association":"MEMBER","created_at":"2024-10-01T09:03:52+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[2536473359],"is_known_query_context":false},{"document_id":"gh_comment_2385250877","fragment_type":"issue_comment","sequence":6,"text":"i would suggest to check proxy logic since the issue was not on the router side, but on proxy. So querying Infura directly was just fine. Replacing provider wont help in this specific case. There is an explanation in URL @churik","author_login":"anastasiyaig","author_association":"NONE","created_at":"2024-10-01T09:16:45+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2385308488","fragment_type":"issue_comment","sequence":7,"text":"There is no actually one conclusion (as it was checked with disabled both grove and proxy(, and the discussion moved there, but yeah, seems that the issue might be on both sides - grove and proxy. \nThanks for the comment. I'll bring this issue today on wallet sync, thank you","author_login":"churik","author_association":"MEMBER","created_at":"2024-10-01T09:41:51+08:00","repo_name":"status-im/status-mobile","issue_id":2536473359,"issue_number":21292,"issue_url":"https://github.com/status-im/status-mobile/issues/21292","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0016","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Since the last update, Media Player seems to no longer be able to play very long files?","query_context":"### The problem\n\nI have a 10 hour long track of white noise I play through HA when I sleep. Been using it for a long while, with no issue. \n\nAs of the last HA update, it seems to no longer play. The file can still be played on the computer, and the HA automation that turns it on/off will still play any \"normal\" length file when I run the automation, but it seems to refuse to play it to the speaker if it's the too long file. \n\n### What version of Home Assistant Core has the issue?\n\ncore-2025.4.1\n\n### What was the last working version of Home Assistant Core?\n\ncore-2024.3.X\n\n### What type of installation are you running?\n\nHome Assistant OS\n\n### Integration causing the issue\n\nMedia Player\n\n### Link to integration documentation on our website\n\n URL \n\n### Diagnostics information\n\nLet me know what would be useful, and I'll send it to you. \n\n### Example YAML snippet\n\nyaml\nThis is the automation I use to cue it up: \n\naction: media_player.play_media\ntarget:\n entity_id: media_player.office\ndata:\n media_content_id: >-\n media-source://media_source/local/White Noise Black Screen ¦ Sleep, Study,\n Focus ¦ 10 Hours (128kbit_AAC).m4a\n media_content_type: audio/mp4\nmetadata:\n title: White Noise Black Screen ¦ Sleep, Study, Focus ¦ 10 Hours (128kbit_AAC).m4a\n thumbnail: null\n media_class: music\n children_media_class: null\n navigateIds:\n - {}\n - media_content_type: app\n media_content_id: media-source://media_source\n\n### Anything in the logs that might be useful for us?\n\ntxt\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_2980017210"],"reference_answer":"I have no clue what your issue is exactly, what are you trying to do and what does it do and what do you expect?","answer_document_id":"gh_comment_2817090952","silver_evidence_path":["gh_comment_2786747676","gh_issue_2977679118","gh_comment_2817090952"],"evidence_issue_ids":[2980017210,2977679118],"source_repo_name":"home-assistant/core","source_issue_id":2980017210,"source_issue_number":142540,"source_issue_url":"https://github.com/home-assistant/core/issues/142540","target_repo_name":"home-assistant/core","target_issue_id":2977679118,"target_issue_number":142494,"target_issue_url":"https://github.com/home-assistant/core/issues/142494","reference_anchor_document_id":"gh_comment_2786747676","reference_answer_author":"joostlek","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4615,"anchor_target_overlap":0.3077,"target_answer_overlap":0.2},"issue_created_at":"2025-04-08T14:39:21+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2980017210","fragment_type":"issue_description","sequence":0,"text":"Since the last update, Media Player seems to no longer be able to play very long files?\n### The problem\n\nI have a 10 hour long track of white noise I play through HA when I sleep. Been using it for a long while, with no issue. \n\nAs of the last HA update, it seems to no longer play. The file can still be played on the computer, and the HA automation that turns it on/off will still play any \"normal\" length file when I run the automation, but it seems to refuse to play it to the speaker if it's the too long file. \n\n### What version of Home Assistant Core has the issue?\n\ncore-2025.4.1\n\n### What was the last working version of Home Assistant Core?\n\ncore-2024.3.X\n\n### What type of installation are you running?\n\nHome Assistant OS\n\n### Integration causing the issue\n\nMedia Player\n\n### Link to integration documentation on our website\n\n URL \n\n### Diagnostics information\n\nLet me know what would be useful, and I'll send it to you. \n\n### Example YAML snippet\n\nyaml\nThis is the automation I use to cue it up: \n\naction: media_player.play_media\ntarget:\n entity_id: media_player.office\ndata:\n media_content_id: >-\n media-source://media_source/local/White Noise Black Screen ¦ Sleep, Study,\n Focus ¦ 10 Hours (128kbit_AAC).m4a\n media_content_type: audio/mp4\nmetadata:\n title: White Noise Black Screen ¦ Sleep, Study, Focus ¦ 10 Hours (128kbit_AAC).m4a\n thumbnail: null\n media_class: music\n children_media_class: null\n navigateIds:\n - {}\n - media_content_type: app\n media_content_id: media-source://media_source\n\n### Anything in the logs that might be useful for us?\n\ntxt\n\n### Additional information\n\n_No response_","author_login":"Obioban","author_association":"NONE","created_at":"2025-04-08T14:39:21+08:00","repo_name":"home-assistant/core","issue_id":2980017210,"issue_number":142540,"issue_url":"https://github.com/home-assistant/core/issues/142540","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2786747676","fragment_type":"issue_comment","sequence":1,"text":"did you play file directly ? or use TTS to play?\nmy issue is URL \nHA->TTS->DLNA issue.\nbelongs to media_player or Core?","author_login":"norikohxb","author_association":"NONE","created_at":"2025-04-08T15:00:33+08:00","repo_name":"home-assistant/core","issue_id":2980017210,"issue_number":142540,"issue_url":"https://github.com/home-assistant/core/issues/142540","linked_issue_ids":[2977679118],"is_known_query_context":false},{"document_id":"gh_comment_2786981716","fragment_type":"issue_comment","sequence":2,"text":"@Obioban does it also fail to play when you do it trough the Media browser, or only on the automation?\n\nAre there any errors or warnings on the logs?\nAlso, what is the integration for the media player/speaker?","author_login":"abmantis","author_association":"CONTRIBUTOR","created_at":"2025-04-08T16:15:12+08:00","repo_name":"home-assistant/core","issue_id":2980017210,"issue_number":142540,"issue_url":"https://github.com/home-assistant/core/issues/142540","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2787147748","fragment_type":"issue_comment","sequence":3,"text":"When I play it in the browser, on the computer, it plays fine through the computer speakers. \n\nWhen I try to set the source to the speakers, that's when it failed. \n\nIntegration is sonos-- playing to an ethernet wired sonos amp. \n\nWhen I try to play the file, the log records the following 3 items:\nOffice changed to Paused triggered by action Media player: Play media\nOffice changed to Playing\nOffice changed to Idle\n\nAll 3 occur in the same second, per the log.","author_login":"Obioban","author_association":"NONE","created_at":"2025-04-08T17:17:00+08:00","repo_name":"home-assistant/core","issue_id":2980017210,"issue_number":142540,"issue_url":"https://github.com/home-assistant/core/issues/142540","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2787153535","fragment_type":"issue_comment","sequence":4,"text":"Since you asked about the speaker integration, as I diagnostic I just tried to send it to an Apple TV instead-- same result. I don't think the problem is on the speaker side.","author_login":"Obioban","author_association":"NONE","created_at":"2025-04-08T17:19:10+08:00","repo_name":"home-assistant/core","issue_id":2980017210,"issue_number":142540,"issue_url":"https://github.com/home-assistant/core/issues/142540","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2807730553","fragment_type":"issue_comment","sequence":5,"text":"- Are you using a reverse proxy of some sort?\n- Have you correctly configured (or configured) an internal/external URLs in the core Home Assistant configuration/settings?\n- \n../Frenck","author_login":"frenck","author_association":"MEMBER","created_at":"2025-04-15T23:07:47+08:00","repo_name":"home-assistant/core","issue_id":2980017210,"issue_number":142540,"issue_url":"https://github.com/home-assistant/core/issues/142540","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2977679118","fragment_type":"issue_description","sequence":0,"text":"downgrade from 2025.4.1 to 2025.3.4 then edge-TTS->xiaodu spk ->works well\n### The problem\n\ndowngrade from 2025.4.1 to 2025.3.4 then edge-TTS->xiaodu spk ->works well \nafter upgrade to 2025.4.0 same problem xiaodu spk fail to be TTS message to speaker\nthen upgrade to 2025.4.1 same issue. xiaodu spk fail\nbut xiaoya spk can work normally \nbut because i have >25 xiaodu spks so i have to downgrade from 2025.4.1 to 2025.3.4\n\n### What version of Home Assistant Core has the issue?\n\n2025.4.1\n\n### What was the last working version of Home Assistant Core?\n\n_No response_\n\n### What type of installation are you running?\n\nHome Assistant OS\n\n### Integration causing the issue\n\n_No response_\n\n### Link to integration documentation on our website\n\n_No response_\n\n### Diagnostics information\n\n_No response_\n\n### Example YAML snippet\n\nyaml\n\n### Anything in the logs that might be useful for us?\n\ntxt\n\n### Additional information\n\n_No response_","author_login":"norikohxb","author_association":"NONE","created_at":"2025-04-07T18:37:35+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2784272316","fragment_type":"issue_comment","sequence":1,"text":"after upgrade from 2025.3.4 to 2025.4.0 . automation can't tts message to xiaodu spk. \nthe whole message will be stuck in some word or repeat some words again and again ,will never stop reading\nbut on the same time xiaoya speaker will not happen such issue. it work normally\nonly xiaodu spk (A1) will not work\nafter downgrade to 2025.3.4 no matter xiaodu or xiaoya speakers work both well","author_login":"norikohxb","author_association":"NONE","created_at":"2025-04-07T18:55:57+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2785264282","fragment_type":"issue_comment","sequence":2,"text":"i have upgrade to 2025.4.1 for a few days .\nat frist I did not think the XiaoDu speaker issue was caused by the upgrade. \nI thought it is my wifi 2.4G setting that caused it.\nbecause XiaoYa speaker has no such issue. \nuntil yesterday. i realized that it maybe the upgrade of the home asssistant ,those new version codes made this error\n and after i downgrade to version 2025.3.4 it fixed the XiaoDu speaker issue. \nbut i got above errors.\nif i uparde to 2025.4.1 it will fix below error but XiaoDu speaker can't be TTS out message\nThe following integrations and platforms could not be set up:\n\nrecorder (Show logs)\nhistory (Show logs)\nlogbook (Show logs)\nenergy (Show logs)\ndefault_config (Show logs)\nPlease check your config and logs.\nif i downgrade to 2025.3.4 will not have above history and record error but XiaoDu speaker can't work normally","author_login":"norikohxb","author_association":"NONE","created_at":"2025-04-08T05:29:59+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2817090952","fragment_type":"issue_comment","sequence":3,"text":"I have no clue what your issue is exactly, what are you trying to do and what does it do and what do you expect?","author_login":"joostlek","author_association":"MEMBER","created_at":"2025-04-20T09:48:13+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2831475049","fragment_type":"issue_comment","sequence":4,"text":"Hi \n`edge-TTS` is a custom component, which is not maintained by the HA core project. Please report your issue to the maintainer or in the source repository of this custom component.\nThx 👍","author_login":"mib1185","author_association":"CONTRIBUTOR","created_at":"2025-04-25T21:38:15+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2834562581","fragment_type":"issue_comment","sequence":5,"text":"no matter edge-tts or google tts they both not work with xiaodu speaker\ni did not upgrade edge-tts or google tts pluging (addon) \nwhen I upgrade from 2025.3.4 to newer version. the xiaodu speaker will fail to read out message.\nI do not think it is only edge-TTS plug's issue.\nand no matter 2025.3.4 or 2024.4.4 their edge-tts plugin (addon) seems to be the same version","author_login":"norikohxb","author_association":"NONE","created_at":"2025-04-28T09:16:39+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2834566933","fragment_type":"issue_comment","sequence":6,"text":"if you want use HA to TTS out a message . for example \" abcdefghijklmnopqrstuvwxyz\"\nthe xiaodu speaker will speak out h , h h h ... or stuck no message out .\nrepeat and repeat \nover and over\nwill not come to end . unlesss you reboot HA","author_login":"norikohxb","author_association":"NONE","created_at":"2025-04-28T09:18:26+08:00","repo_name":"home-assistant/core","issue_id":2977679118,"issue_number":142494,"issue_url":"https://github.com/home-assistant/core/issues/142494","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0017","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"docker image (mac/aarch64) failing?","query_context":"Hi Keegan,\n\nDo you know if it's an issue with my docker image or maybe with the Gradle docker image or something else regarding:\n\n URL \n\nThe Dockerfile is here: URL \n\nkind regards, and have a nice week :-)\nJohannes","known_context_document_ids":["gh_issue_1993121883"],"reference_answer":"Thanks a lot. Can you check if it's working without the existing `sirix-data` folder? I've just committed a fix, hopefully: URL","answer_document_id":"gh_comment_1819490644","silver_evidence_path":["gh_comment_1864540078","gh_issue_1992023803","gh_comment_1819490644"],"evidence_issue_ids":[1993121883,1992023803],"source_repo_name":"keeganwitt/docker-gradle","source_issue_id":1993121883,"source_issue_number":268,"source_issue_url":"https://github.com/keeganwitt/docker-gradle/issues/268","target_repo_name":"sirixdb/sirix","target_issue_id":1992023803,"target_issue_number":681,"target_issue_url":"https://github.com/sirixdb/sirix/issues/681","reference_anchor_document_id":"gh_comment_1864540078","reference_answer_author":"JohannesLichtenberger","reference_answer_author_association":"MEMBER","quality_score":76.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2023-11-14T16:38:03+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1993121883","fragment_type":"issue_description","sequence":0,"text":"docker image (mac/aarch64) failing\nHi Keegan,\n\nDo you know if it's an issue with my docker image or maybe with the Gradle docker image or something else regarding:\n\n URL \n\nThe Dockerfile is here: URL \n\nkind regards, and have a nice week :-)\nJohannes","author_login":"JohannesLichtenberger","author_association":"NONE","created_at":"2023-11-14T16:38:03+08:00","repo_name":"keeganwitt/docker-gradle","issue_id":1993121883,"issue_number":268,"issue_url":"https://github.com/keeganwitt/docker-gradle/issues/268","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1818183628","fragment_type":"issue_comment","sequence":1,"text":"Sorry, I can't tell from what's posted there what the error might be. I'm going to need some more information to be able to help. It is still the case that Alpine images don't support ARM yet, if that helps.","author_login":"keeganwitt","author_association":"OWNER","created_at":"2023-11-20T03:48:55+08:00","repo_name":"keeganwitt/docker-gradle","issue_id":1993121883,"issue_number":268,"issue_url":"https://github.com/keeganwitt/docker-gradle/issues/268","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1864540078","fragment_type":"issue_comment","sequence":2,"text":"I believe this was resolved in sirixdb/sirix#681. If this isn't the case, let me know and we can re-open this issue.","author_login":"keeganwitt","author_association":"OWNER","created_at":"2023-12-20T14:10:42+08:00","repo_name":"keeganwitt/docker-gradle","issue_id":1993121883,"issue_number":268,"issue_url":"https://github.com/keeganwitt/docker-gradle/issues/268","linked_issue_ids":[1992023803],"is_known_query_context":false},{"document_id":"gh_issue_1992023803","fragment_type":"issue_description","sequence":0,"text":"Cannot build docker-compose on arm64/aarch64\nThe current docker-compose build script does not function on my M1 mac:\n\n % docker compose build\n[+] Building 3.2s (5/5) FINISHED docker:desktop-linux\n => [server internal] load build definition from Dockerfile 0.0s\n => => transferring dockerfile: 1.83kB 0.0s\n => [server internal] load .dockerignore 0.0s\n => => transferring context: 2B 0.0s\n => ERROR [server internal] load metadata for docker.io/library/gradle:jdk21-alpine 3.2s\n => ERROR [server internal] load metadata for docker.io/library/gradle:8.4-jdk21-graal 3.2s\n => [server auth] library/gradle:pull token for registry-1.docker.io 0.0s\n------\n \n------\n------\n \n------\nfailed to solve: gradle:jdk21-alpine: no match for platform in manifest sha256:039614406f658505c65357c71056442e65b30b3f19400199d96265c88261ecc6: not found\n\nNot sure how to solve the above.","author_login":"jtippett","author_association":"NONE","created_at":"2023-11-14T05:35:28+08:00","repo_name":"sirixdb/sirix","issue_id":1992023803,"issue_number":681,"issue_url":"https://github.com/sirixdb/sirix/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1810654394","fragment_type":"issue_comment","sequence":1,"text":"Same as #682, I think?\n\nThanks for letting me know :+1: hope we'll be able to fix it","author_login":"JohannesLichtenberger","author_association":"MEMBER","created_at":"2023-11-14T16:42:21+08:00","repo_name":"sirixdb/sirix","issue_id":1992023803,"issue_number":681,"issue_url":"https://github.com/sirixdb/sirix/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1818209866","fragment_type":"issue_comment","sequence":2,"text":"hi @JohannesLichtenberger can confirm the latest changes now work successfully for me. Awesome!","author_login":"jtippett","author_association":"NONE","created_at":"2023-11-20T04:28:57+08:00","repo_name":"sirixdb/sirix","issue_id":1992023803,"issue_number":681,"issue_url":"https://github.com/sirixdb/sirix/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1818238179","fragment_type":"issue_comment","sequence":3,"text":"Let me add one more comment. This line in the docker-compose file:\n\n volumes:\n - /opt/sirix/sirix-data:/opt/sirix/sirix-data\n\nCauses the launch to fail unless the folder is specifically created and mapped in Docker. I was able to make it boot by creating a test folder in my user dir and making it available in Docker desktop app:\n\n` - /Users/james/sirix-data:/opt/sirix/sirix-data`","author_login":"jtippett","author_association":"NONE","created_at":"2023-11-20T05:09:20+08:00","repo_name":"sirixdb/sirix","issue_id":1992023803,"issue_number":681,"issue_url":"https://github.com/sirixdb/sirix/issues/681","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1819490644","fragment_type":"issue_comment","sequence":4,"text":"Thanks a lot. Can you check if it's working without the existing `sirix-data` folder? I've just committed a fix, hopefully: URL","author_login":"JohannesLichtenberger","author_association":"MEMBER","created_at":"2023-11-20T17:16:19+08:00","repo_name":"sirixdb/sirix","issue_id":1992023803,"issue_number":681,"issue_url":"https://github.com/sirixdb/sirix/issues/681","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0018","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"'touch' detection is invalid?","query_context":"Using this on a laptop computer, and I have set\n\njs\n anchors.options = {\n visible: 'touch'\n }\n\nHowever, it is detecting that a laptop is a touch device. When I look at the source code and try some in the browser console, `!!window.TouchEvent` is returning true, which is here in the source code — URL \n\n------------\n\nexample in use: URL","known_context_document_ids":["gh_issue_1406658896"],"reference_answer":"Thanks for the detailed report. You're totally right about where that new behavior is coming from.\n\nUnfortunately, the behavior you're seeing is intended. To quote the docs:\n \n\nIf you're seeing the links in your browser on Windows 10, that means your browser supports touch events (more specifically, `window.TouchEvent`). That might mean your desktop/laptop has support for touch interface (many windows computers, like surface books, do), or that the browser would support a touch interface if it were installed on such a device.\n\nThe change that you saw in the newer AnchorJS version comes from a similar Modernizr update, which was intended to make touch event detection more accurate. You can see details on that here: URL \n\nUltimately, I'm comfortable leaving this feature as-is, focused on detecting touch-events, which only approximates touchscreen detection. The alternative is to remove the feature altogether (which is what Modernizr eventually did).\n\nIf you prefer the former behavior, I'd say feel free to continue using v4.2.2.","answer_document_id":"gh_comment_759926543","silver_evidence_path":["gh_comment_1382674984","gh_issue_781844345","gh_comment_759926543"],"evidence_issue_ids":[1406658896,781844345],"source_repo_name":"bryanbraun/anchorjs","source_issue_id":1406658896,"source_issue_number":188,"source_issue_url":"https://github.com/bryanbraun/anchorjs/issues/188","target_repo_name":"bryanbraun/anchorjs","target_issue_id":781844345,"target_issue_number":168,"target_issue_url":"https://github.com/bryanbraun/anchorjs/issues/168","reference_anchor_document_id":"gh_comment_1382674984","reference_answer_author":"bryanbraun","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1304,"anchor_target_overlap":0.2439,"target_answer_overlap":0.1803},"issue_created_at":"2022-10-12T18:54:25+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1406658896","fragment_type":"issue_description","sequence":0,"text":"'touch' detection is invalid\nUsing this on a laptop computer, and I have set\n\njs\n anchors.options = {\n visible: 'touch'\n }\n\nHowever, it is detecting that a laptop is a touch device. When I look at the source code and try some in the browser console, `!!window.TouchEvent` is returning true, which is here in the source code — URL \n\n------------\n\nexample in use: URL","author_login":"nichoth","author_association":"NONE","created_at":"2022-10-12T18:54:25+08:00","repo_name":"bryanbraun/anchorjs","issue_id":1406658896,"issue_number":188,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/188","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1374384459","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the issue and PR. I hope to be able to take a closer look at this next week. 👍","author_login":"bryanbraun","author_association":"OWNER","created_at":"2023-01-07T05:33:11+08:00","repo_name":"bryanbraun/anchorjs","issue_id":1406658896,"issue_number":188,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376685432","fragment_type":"issue_comment","sequence":2,"text":"For such an excellent plugin, I would like to share my demo, my touch can be used well! There are also hover prompts and one-click copy (he can jump to the anchor by clicking on it).","author_login":"y377","author_association":"NONE","created_at":"2023-01-10T03:38:41+08:00","repo_name":"bryanbraun/anchorjs","issue_id":1406658896,"issue_number":188,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1382674984","fragment_type":"issue_comment","sequence":3,"text":"Hey, @nichoth, thanks for reporting the issue.\n\nThis issue has come up before and been discussed in detail here: URL \n\nIn short, your fix addresses some common device use-cases but breaks others because there's no reliable way to detect a touchscreen. 😞 \n\nUltimately, this touch feature is misleading and I plan to remove it entirely in a future version of AnchorJS.\n\nMy recommendation is that if you want the older behavior of this, you can use version 4.2.2 as described here.","author_login":"bryanbraun","author_association":"OWNER","created_at":"2023-01-14T06:32:09+08:00","repo_name":"bryanbraun/anchorjs","issue_id":1406658896,"issue_number":188,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/188","linked_issue_ids":[781844345],"is_known_query_context":false},{"document_id":"gh_comment_1382912271","fragment_type":"issue_comment","sequence":4,"text":"Ok thanks for checking it out. I am using my fork currently, and that has been working for me.","author_login":"nichoth","author_association":"NONE","created_at":"2023-01-14T20:42:27+08:00","repo_name":"bryanbraun/anchorjs","issue_id":1406658896,"issue_number":188,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_781844345","fragment_type":"issue_description","sequence":0,"text":"Anchor icon is always visible on Windows when visible=touch after promoted to v4.3.0\n**Issue description**\n\nWe identified a behavior change after promoted Anchorjs from v4.2.2 to v4.3.0. \n\n We are using `visible: touch` as anchor options. For `v4.2.2`, the anchor image is `hover` on page of `Windows10`, after promoted to `v4.3.0`, the anchor image is `always` there instead of `hover`.\n\nHere are sample pages to help understand the issue:\n_v4.2.2 page(hover)_: URL \n_v4.3.0 page(always)_: URL \n\n**Operating System**: Windows\n\n**AnchorJs version**: 4.3.0\n\n**Expected Behavior**:\nAnchorJS links only become visible when hovering over the headings like before for Windows when visible is touch.\n\n**Actual Behavior**:\nAnchorJS links are always visible for Windows when visible is touch.\n\n**Note:**\nThis behavior change seems related to the newly added condition `window.TouchEvent` in function `isTouchDevice()` with this commit\n \nthis.isTouchDevice=function(){return Boolean(\"ontouchstart\"in window||**window.TouchEvent**||window.DocumentTouch&&document instanceof DocumentTouch)}\n \n,this.isTouchDevice=function(){return!!(\"ontouchstart\"in window||window.DocumentTouch&&document instanceof DocumentTouch)}","author_login":"v-pegao","author_association":"NONE","created_at":"2021-01-08T04:58:37+08:00","repo_name":"bryanbraun/anchorjs","issue_id":781844345,"issue_number":168,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_759926543","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the detailed report. You're totally right about where that new behavior is coming from.\n\nUnfortunately, the behavior you're seeing is intended. To quote the docs:\n \n\nIf you're seeing the links in your browser on Windows 10, that means your browser supports touch events (more specifically, `window.TouchEvent`). That might mean your desktop/laptop has support for touch interface (many windows computers, like surface books, do), or that the browser would support a touch interface if it were installed on such a device.\n\nThe change that you saw in the newer AnchorJS version comes from a similar Modernizr update, which was intended to make touch event detection more accurate. You can see details on that here: URL \n\nUltimately, I'm comfortable leaving this feature as-is, focused on detecting touch-events, which only approximates touchscreen detection. The alternative is to remove the feature altogether (which is what Modernizr eventually did).\n\nIf you prefer the former behavior, I'd say feel free to continue using v4.2.2.","author_login":"bryanbraun","author_association":"OWNER","created_at":"2021-01-14T04:59:33+08:00","repo_name":"bryanbraun/anchorjs","issue_id":781844345,"issue_number":168,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1248632671","fragment_type":"issue_comment","sequence":2,"text":"`Boolean('ontouchstart' in window || window.TouchEvent || window.DocumentTouch && document instanceof DocumentTouch)` returns true in the current Chrome (Version 105.0.5195.125) on my old MacBook Pro, which doesn't have a touch screen. The new behavior is unacceptable to me, so I will have to stay on v4.2.2. 😕","author_login":"KasparEtter","author_association":"NONE","created_at":"2022-09-15T21:08:20+08:00","repo_name":"bryanbraun/anchorjs","issue_id":781844345,"issue_number":168,"issue_url":"https://github.com/bryanbraun/anchorjs/issues/168","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0019","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Cleanup CSI Snapshots post Polling of VSC times out in CSI Plugin.","query_context":"**What steps did you take and what happened:**\n \nAs of today the CSI plugin waits for the VSC to get reconciled for default 10minutes.\nAfter that CSI leaves the VS in the cluster.\nThis leads to accumulation of useless VS in the cluster which ends up throttling the CSI drivers installed in the cluster. Because the CSI driver keeps on retrying endlessly.\n\n**What did you expect to happen:**\nCleanup the VS if tracking has failed in the CSI plugin.\n\n**The following information will help us better understand what's going on**:\n\n_If you are using velero v1.7.0+:_ \nPlease use `velero debug --backup --restore ` to generate the support bundle, and attach to this issue, more options please refer to `velero debug --help` \n\n_If you are using earlier versions:_ \nPlease provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)\n- `kubectl logs deployment/velero -n velero`\n- `velero backup describe ` or `kubectl get backup/ -n velero -o yaml`\n- `velero backup logs `\n- `velero restore describe ` or `kubectl get restore/ -n velero -o yaml`\n- `velero restore logs `\n\n**Anything else you would like to add:**\n \n\nRelated issue #6209 and also in similar code path as #6165 \n\n**Environment:**\n\n- Velero version (use `velero version`): \n- Velero features (use `velero client config get features`): \n- Kubernetes version (use `kubectl version`):\n- Kubernetes installer & version:\n- Cloud provider or hardware configuration:\n- OS (e.g. from `/etc/os-release`):\n\n**Vote on this issue!**\n\nThis is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here. \nUse the \"reaction smiley face\" up to the right of this comment to vote.\n\n- :+1: for \"I would like to see this bug fixed as soon as possible\"\n- :-1: for \"There are more important bugs to focus on right now\"","known_context_document_ids":["gh_issue_1692659645"],"reference_answer":"There are two issues being discussed here:\n1. Object has been modified issue:\n\nI1111 12:01:13.229378 1 snapshot_controller.go:167] updating VolumeSnapshotContent[snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4] error status failed Operation cannot be fulfilled on volumesnapshotcontents.snapshot.storage.k8s.io \"snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4\": the object has been modified; please apply your changes to the latest version and try again\n\nThis has been fixed for all common cases in snapshotter master, which will be in v5.0.0. The version v4.2.1 will not have this fix. \n\n2. #533 - this issue is unrelated to the above error. I've reproduced it in master without the `object has been modified error`. The object are constantly being re-queued without backoff, even though backoff is configured. I'm still looking into why that is the case.\n\nI've been busy the past few weeks, but I'm hoping to continue looking into this one again soon.","answer_document_id":"gh_comment_984190842","silver_evidence_path":["gh_comment_1534670188","gh_issue_920840960","gh_comment_984190842"],"evidence_issue_ids":[1692659645,920840960],"source_repo_name":"vmware-tanzu/velero","source_issue_id":1692659645,"source_issue_number":6219,"source_issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","target_repo_name":"kubernetes-csi/external-snapshotter","target_issue_id":920840960,"target_issue_number":533,"target_issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","reference_anchor_document_id":"gh_comment_1534670188","reference_answer_author":"ggriffiths","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.1667,"target_answer_overlap":0.2222},"issue_created_at":"2023-05-02T15:42:50+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_1692659645","fragment_type":"issue_description","sequence":0,"text":"Cleanup CSI Snapshots post Polling of VSC times out in CSI Plugin.\n**What steps did you take and what happened:**\n \nAs of today the CSI plugin waits for the VSC to get reconciled for default 10minutes.\nAfter that CSI leaves the VS in the cluster.\nThis leads to accumulation of useless VS in the cluster which ends up throttling the CSI drivers installed in the cluster. Because the CSI driver keeps on retrying endlessly.\n\n**What did you expect to happen:**\nCleanup the VS if tracking has failed in the CSI plugin.\n\n**The following information will help us better understand what's going on**:\n\n_If you are using velero v1.7.0+:_ \nPlease use `velero debug --backup --restore ` to generate the support bundle, and attach to this issue, more options please refer to `velero debug --help` \n\n_If you are using earlier versions:_ \nPlease provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)\n- `kubectl logs deployment/velero -n velero`\n- `velero backup describe ` or `kubectl get backup/ -n velero -o yaml`\n- `velero backup logs `\n- `velero restore describe ` or `kubectl get restore/ -n velero -o yaml`\n- `velero restore logs `\n\n**Anything else you would like to add:**\n \n\nRelated issue #6209 and also in similar code path as #6165 \n\n**Environment:**\n\n- Velero version (use `velero version`): \n- Velero features (use `velero client config get features`): \n- Kubernetes version (use `kubectl version`):\n- Kubernetes installer & version:\n- Cloud provider or hardware configuration:\n- OS (e.g. from `/etc/os-release`):\n\n**Vote on this issue!**\n\nThis is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here. \nUse the \"reaction smiley face\" up to the right of this comment to vote.\n\n- :+1: for \"I would like to see this bug fixed as soon as possible\"\n- :-1: for \"There are more important bugs to focus on right now\"","author_login":"anshulahuja98","author_association":"CONTRIBUTOR","created_at":"2023-05-02T15:42:50+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1534199496","fragment_type":"issue_comment","sequence":1,"text":"Could you give more background about CSI drivers reaching their throttle when there is enough legacy VS left?\nAlthough VSs are accumulated, they should end with `ReadyToUse` state, do CSI drivers still poll on those VSs?","author_login":"blackpiglet","author_association":"CONTRIBUTOR","created_at":"2023-05-04T07:11:00+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1534670188","fragment_type":"issue_comment","sequence":2,"text":"URL \n URL \n\nThe polling is controlled by the external snapshotter. That will relentlessly try. Have verified from logs. \nEarlier even exponential backoff was broken in external snapshotter, it is fixed now (AFAIK), but still the expectation is that \"checkSnapshotANdUpdate\" there is a function like this which is periodically called and if a VS/VSC is not ready, it will attempt to fix it.","author_login":"anshulahuja98","author_association":"CONTRIBUTOR","created_at":"2023-05-04T12:16:05+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[920840960],"is_known_query_context":false},{"document_id":"gh_comment_1534766206","fragment_type":"issue_comment","sequence":3,"text":"Do you mean this function `checkandUpdateContentStatusOperation`?\nIf we are talking about this function, checking the not-ready VolumeSnapshotContent or VolumeSnapshot seems inevitable, and that only happens for the not-yet-ready VolumeSnapshotContents. The accumulated VolumeSnapshotContents should have no impact on this.","author_login":"blackpiglet","author_association":"CONTRIBUTOR","created_at":"2023-05-04T13:17:21+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1535678003","fragment_type":"issue_comment","sequence":4,"text":"I can check back on the exact functionality on code pointers(will take me some time to look back at the code), but I am confident on the behavior of external snapshotter retrying endlessly. We have verified multiple times from ext snapshotter logs.\n\nKeeping that investigation aside do you see any merit otherwise in leaving the orphan VS in the cluster?\nIrrespective we should still cleanup the VS which are not being used/wont be GCed from the cluster.","author_login":"anshulahuja98","author_association":"CONTRIBUTOR","created_at":"2023-05-05T04:16:06+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1535805711","fragment_type":"issue_comment","sequence":5,"text":"Those VolumeSnapshots are kept for backup deletion. They are kept for deleting the snapshot resources from cloud providers.\nI agree with you that this is not an ideal way, and they should be cleaned.\nWith the current design, if we delete those VolumeSnapshots, the VolumeSnapshots should be restored before deleting the backup to prevent snapshots left on providers forever, and I didn't find a fitting place to do that.","author_login":"blackpiglet","author_association":"CONTRIBUTOR","created_at":"2023-05-05T07:00:09+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1535878954","fragment_type":"issue_comment","sequence":6,"text":"Those VS are not even tracked as part of the backup\non failure, the BIA returns nil\n\nSo during GC these VS is not cleaned up.\nThey are just orphan VS.","author_login":"anshulahuja98","author_association":"CONTRIBUTOR","created_at":"2023-05-05T07:58:35+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1535896346","fragment_type":"issue_comment","sequence":7,"text":"If we are talking about the error case, I agree those VSs should be cleaned in this place.","author_login":"blackpiglet","author_association":"CONTRIBUTOR","created_at":"2023-05-05T08:13:13+08:00","repo_name":"vmware-tanzu/velero","issue_id":1692659645,"issue_number":6219,"issue_url":"https://github.com/vmware-tanzu/velero/issues/6219","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_920840960","fragment_type":"issue_description","sequence":0,"text":"external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff\nCreating a snapshot from a non-existing volume will repro this. @jsafrane discovered this, opening this issue for tracking.","author_login":"ggriffiths","author_association":"MEMBER","created_at":"2021-06-14T23:08:35+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_887724146","fragment_type":"issue_comment","sequence":1,"text":"Ran into this as well. If further info can be helpful let me know.","author_login":"travisghansen","author_association":"NONE","created_at":"2021-07-27T18:11:19+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_887736412","fragment_type":"issue_comment","sequence":2,"text":"@travisghansen did you repro this by creating a snapshot from a non-existing volume? Want to make sure it's the same cause.","author_login":"ggriffiths","author_association":"MEMBER","created_at":"2021-07-27T18:29:45+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_887814342","fragment_type":"issue_comment","sequence":3,"text":"In my case the api call to the backing storage system had some invalid options in the payload resulting in a failure. I would effectively pass the failed api response back up to the grpc client (this repo?) and observe that over and over at a rapid pace.","author_login":"travisghansen","author_association":"NONE","created_at":"2021-07-27T20:31:11+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966990511","fragment_type":"issue_comment","sequence":4,"text":"Hi, ran into this issue while there was a permissions issue and create snapshot call has failed. Attached logs (enabled verbose logging in snapshotter) if they might help. \n\nsnapshotter_logs.txt\n\nI see an `enqueued \"snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4\" for sync ` everytime as part of `setAnnVolumeSnapshotBeingCreated` method - Not sure if this is expected.\n\nAs there is a create snapshot call almost every 150ms, the underlying API is getting throttled. Also there are too many mutations to the snapshot object. As the API throttling is generally at a customer tenant level this might impact other customer scenarios as well. Any update on the issue/fix ?","author_login":"shrac","author_association":"NONE","created_at":"2021-11-12T10:25:50+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_968539377","fragment_type":"issue_comment","sequence":5,"text":"+1\nThe controller seems to be in a bad state, and can bring the cluster health by throttling the vendor APIs\n \n@ggriffiths any update on this fix?","author_login":"anshulahuja98","author_association":"NONE","created_at":"2021-11-15T04:58:58+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_969417097","fragment_type":"issue_comment","sequence":6,"text":"Yes, that is the same issue @shrac. I'm looking into the root cause of this issue, no update yet.","author_login":"ggriffiths","author_association":"MEMBER","created_at":"2021-11-15T23:10:08+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_977983697","fragment_type":"issue_comment","sequence":7,"text":"Does this still happen with the latest code in the master branch?","author_login":"xing-yang","author_association":"COLLABORATOR","created_at":"2021-11-24T15:28:19+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_983800127","fragment_type":"issue_comment","sequence":8,"text":"@anshulahuja98 The following error should not occur any more with the code in the master branch.\n\nI1111 12:01:13.229378 1 snapshot_controller.go:167] updating VolumeSnapshotContent[snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4] error status failed Operation cannot be fulfilled on volumesnapshotcontents.snapshot.storage.k8s.io \"snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4\": the object has been modified; please apply your changes to the latest version and try again\n\n@ggriffiths This should be fixed with the \"patch\" fix?","author_login":"xing-yang","author_association":"COLLABORATOR","created_at":"2021-12-01T16:14:56+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_983806438","fragment_type":"issue_comment","sequence":9,"text":"Can you point me to the PR that fixed it? I am not very clear as to what fixed it.\nAnd when can we expect the new release with the required fix.\nCurrent version is 4.2.1 from August","author_login":"anshulahuja98","author_association":"NONE","created_at":"2021-12-01T16:21:48+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_984161538","fragment_type":"issue_comment","sequence":10,"text":"@anshulahuja98 This following PR changes \"update\" to \"patch\". That reduces the error \"the object has been modified\".\n URL","author_login":"xing-yang","author_association":"COLLABORATOR","created_at":"2021-12-01T23:49:59+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_984190842","fragment_type":"issue_comment","sequence":11,"text":"There are two issues being discussed here:\n1. Object has been modified issue:\n\nI1111 12:01:13.229378 1 snapshot_controller.go:167] updating VolumeSnapshotContent[snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4] error status failed Operation cannot be fulfilled on volumesnapshotcontents.snapshot.storage.k8s.io \"snapcontent-c5a12581-b9c7-430e-9c61-9bcb576a60d4\": the object has been modified; please apply your changes to the latest version and try again\n\nThis has been fixed for all common cases in snapshotter master, which will be in v5.0.0. The version v4.2.1 will not have this fix. \n\n2. #533 - this issue is unrelated to the above error. I've reproduced it in master without the `object has been modified error`. The object are constantly being re-queued without backoff, even though backoff is configured. I'm still looking into why that is the case.\n\nI've been busy the past few weeks, but I'm hoping to continue looking into this one again soon.","author_login":"ggriffiths","author_association":"MEMBER","created_at":"2021-12-02T00:49:13+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[920840960],"is_known_query_context":false},{"document_id":"gh_comment_1017076311","fragment_type":"issue_comment","sequence":12,"text":"@ggriffiths How to set the backoff to the snapshot-controller?","author_login":"zhucan","author_association":"MEMBER","created_at":"2022-01-20T03:10:17+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018307257","fragment_type":"issue_comment","sequence":13,"text":"@xing-yang @ggriffiths Maybe ecause of the URL to update the snapshotcontent. \n\nAfter the snapshot was created failed, it will to remove the \"snapshot.storage.kubernetes.io/volumesnapshot-being-created\" and update the snapshotcontent.","author_login":"zhucan","author_association":"MEMBER","created_at":"2022-01-21T08:58:06+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018312849","fragment_type":"issue_comment","sequence":14,"text":"image\nIf we don't remove the annotion \"snapshot.storage.kubernetes.io/volumesnapshot-being-created\" and not update the snapshotcontent, the retry interal is 1s. 2s, 4s, 8s,16s,32s,64s,128s,256s, 5min.","author_login":"zhucan","author_association":"MEMBER","created_at":"2022-01-21T09:04:34+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018564469","fragment_type":"issue_comment","sequence":15,"text":"I see. So it is not really a normal requeue due to the failure but it is a new update that triggers the requeue. If we don't remove the annotation \"snapshot.storage.kubernetes.io/volumesnapshot-being-created\" and don't update the snapshotcontent, how does the snapshotter know the creation has failed? If the annotation is not removed, the snapshotter will think the storage system is still working on the snapshot creation. CreateSnapshot will be called to query the snapshot status. One thing to explore is to see if we can use ListSnapshots instead of CreateSnapshot (if ListSnapshots is supported by CSI driver) to check snapshot status.","author_login":"xing-yang","author_association":"COLLABORATOR","created_at":"2022-01-21T14:40:21+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018568807","fragment_type":"issue_comment","sequence":16,"text":"Another idea to explore is to compare the old obj vs the new obj when update is triggered. If the annotation \"snapshot.storage.kubernetes.io/volumesnapshot-being-created\" is the only thing being removed, maybe we don't need to go through CreateSnapshot again.","author_login":"xing-yang","author_association":"COLLABORATOR","created_at":"2022-01-21T14:43:34+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019654234","fragment_type":"issue_comment","sequence":17,"text":"If we can only compare the annotations of the snapshotcontent, if they are different, we don't re-queue.","author_login":"zhucan","author_association":"MEMBER","created_at":"2022-01-24T02:23:28+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019665656","fragment_type":"issue_comment","sequence":18,"text":"I think we need to check if the annotation \"snapshot.storage.kubernetes.io/volumesnapshot-being-created\" is the only thing being removed and if that's the only change. If there are other changes, we still need to process it.","author_login":"xing-yang","author_association":"COLLABORATOR","created_at":"2022-01-24T02:55:47+08:00","repo_name":"kubernetes-csi/external-snapshotter","issue_id":920840960,"issue_number":533,"issue_url":"https://github.com/kubernetes-csi/external-snapshotter/issues/533","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0021","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Fix bugs on Korean MSX Conversion To SMS games On SG-1000 Mode Emulation?","query_context":"Bug:\n168426478-19e640b6-d2c5-4bb4-b307-1c736fc22aaa\n168426489-68094b63-dd8a-43fa-bba7-8ce8b76f53b7\n168426499-11534212-7e93-4128-a7c9-23d97efa1a3a\n\nFixed:\n168426558-d89354ff-b41b-470a-8076-a6583ab8abbf\n168426585-5842bd13-4c39-42fa-8679-186101233835\n168426617-aba13656-ac8f-49e8-b58a-c2198fffe84f\n\nYou must add Feature of RAM\n\nSG-1000/SG-1000 II RAM:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nMaster System/Mark III/Master System II RAM:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nGame Gear RAM:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nGenesis / Mega Drive / CD RAM:","known_context_document_ids":["gh_issue_1236226169"],"reference_answer":"I already answered these issues report:\n- those games do NOT work on stock SG-1000 hardware because they need more RAM than the SG-1000 has (afaik, MSX has more RAM than SG-1000)\n- the colors look wrong but that is how they look on Master System hardware\n\nThe solution to your problem is to run these games on SG-1000 hardware with RAM extension cartridge, which is not possible yet in this emulator but you are free to use another emulator if it works for you... just stop spamming the issue report.","answer_document_id":"gh_comment_1060855437","silver_evidence_path":["gh_comment_1128076935","gh_issue_1161409262","gh_comment_1060855437"],"evidence_issue_ids":[1236226169,1161409262],"source_repo_name":"ekeeke/Genesis-Plus-GX","source_issue_id":1236226169,"source_issue_number":431,"source_issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","target_repo_name":"ekeeke/Genesis-Plus-GX","target_issue_id":1161409262,"target_issue_number":419,"target_issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/419","reference_anchor_document_id":"gh_comment_1128076935","reference_answer_author":"ekeeke","reference_answer_author_association":"OWNER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.3871,"anchor_target_overlap":0.3281,"target_answer_overlap":0.125},"issue_created_at":"2022-05-15T08:48:16+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1236226169","fragment_type":"issue_description","sequence":0,"text":"Fix bugs on Korean MSX Conversion To SMS games On SG-1000 Mode Emulation\nBug:\n168426478-19e640b6-d2c5-4bb4-b307-1c736fc22aaa\n168426489-68094b63-dd8a-43fa-bba7-8ce8b76f53b7\n168426499-11534212-7e93-4128-a7c9-23d97efa1a3a\n\nFixed:\n168426558-d89354ff-b41b-470a-8076-a6583ab8abbf\n168426585-5842bd13-4c39-42fa-8679-186101233835\n168426617-aba13656-ac8f-49e8-b58a-c2198fffe84f\n\nYou must add Feature of RAM\n\nSG-1000/SG-1000 II RAM:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nMaster System/Mark III/Master System II RAM:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nGame Gear RAM:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nGenesis / Mega Drive / CD RAM:","author_login":"MrKrabs07","author_association":"NONE","created_at":"2022-05-15T08:48:16+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1236226169,"issue_number":431,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1126890713","fragment_type":"issue_comment","sequence":1,"text":"Reported. Don't you get tired of this? If you want support for a corner case, fork the code and do it yourself.\nIf the main developer abandons this great project, it will be because of you. You're boring stones.","author_login":"AlbertoDiazC","author_association":"NONE","created_at":"2022-05-15T09:02:55+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1236226169,"issue_number":431,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1126902851","fragment_type":"issue_comment","sequence":2,"text":"I am considering closing the issue reports for good, too bad for other people but this constant trolling (or maybe it is just some foem of autism, I don't know... and don't care) is too annoying.\n\nHe has been reported at least twice to github but still comes back after a while. He is also apparently doing the same in other emulators repisitory, looking at the user history.","author_login":"ekeeke","author_association":"OWNER","created_at":"2022-05-15T10:18:53+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1236226169,"issue_number":431,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1126937392","fragment_type":"issue_comment","sequence":3,"text":"@ekeeke for the record, I am autistic. But, I would never go out of my way to harass someone like this individual has done. Usually, when someone bullies someone online, from a psychological standpoint, it is because they are trying to fill the gap over something they have no control over in life, be it divorce, problems with friends or family, etc. \n\nThere are certainly better things to do with one's free time. Just don't let this stuff get you down. \nI have dealt with my own share of bullies when working on various online projects. But, you just gotta keep strong in mind at all times. And, you will prevail.\n\nWhen I first got into working with the Mini Classics, another team decided to try to push me out of the scene with various tactics. In the end, me just being me, being nice to everyone, had way more people supporting my unorthodox and creative solutions and workarounds, emulation wise, and I am satisfied with the current state of things.\n\nIf you like movies or tv shows, find something you've been meaning to watch! Just know, people like me will always have your back and appreciate what efforts you put forth in anything and all you do, whether or not they are autistic:)","author_login":"KMFDManic","author_association":"NONE","created_at":"2022-05-15T13:06:31+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1236226169,"issue_number":431,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1128076935","fragment_type":"issue_comment","sequence":4,"text":"@MrKrabs07 Stop spamming the same request.\n\nThe spam links:\n\n#432 \n#430 \n#425 \n#422 \n#420 \n#419 \n#417 \n#416 \n#415 \n#414 \n#413 \n\nThose are Master System games (with .sms file extension) They don't work on SG-1000 Hardware because SG-1000 has 1KB or 2KB RAM but they need 8KB Before. Master System & Game Gear mode with TMS9918 mode is Incorrect by SMS Plus. Including SMS Plus GX, Kega Fusion, MEKA, Gearsystem Always uses TMS9918. Gearsystem, Kega Fusion, MEKA, SMS Plus's SG-1000 Uses 16KB RAM.\n\nThe color look wrong on TMS9918 Content on Master System & Game Gear Hardware. Black Screen On Genesis/Mega Drive Hardware. Genesis/Mega Drive Has No TMS9918-Compatible. Master System Has 256-Colors (Z80 CPU). Like CRT TV CPUs Uses Z80.\n\n**RULES:**\n\n1. No spamming\n\n2. No Not Safe For Work Content\n\n3. No Copyrighted Content\n\n@ekeeke Please lock this conversation and delete issue #432 #425 #422 #420 #419 #417 #416 #415 #414 #413","author_login":"SquidwardKrabs","author_association":"NONE","created_at":"2022-05-16T19:57:21+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1236226169,"issue_number":431,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","linked_issue_ids":[1161409262],"is_known_query_context":false},{"document_id":"gh_comment_1128109717","fragment_type":"issue_comment","sequence":5,"text":"@SquidwardKrabs we all know it's just you under another account. It is so very nice to see you are such an upstanding individual that you spend all of your free time playing mental games. You realize, if you keep this up, you will only make it so ekeeke and others no longer have interest in bettering these emulators for the thousands upon thousands of people that use them. There are far better things you can do with your free time than bullying others online.\n\nAlso note, what you are doing is actually a crime, which can land you in jail if you keep it up. \n\n@ekeeke Sorry to see you have to go through this nonsense due to an obviously mentally unstable individual who truly needs to get help.","author_login":"KMFDManic","author_association":"NONE","created_at":"2022-05-16T20:34:27+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1236226169,"issue_number":431,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/431","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1161409262","fragment_type":"issue_description","sequence":0,"text":"Genesis Plus GX 1.7.6 Request: Fix Bug On Some MSX Conversation Games On SG-1000.\nIt's Not Correct When Some MSX Conversation Games Bug On SG-1000 Emulation. I Know That MSX Conversation Games Works On SG-1000 Hardware. Also Works On Gearsystem Core. Try To Use Gearsystem Core And Update SG-1000's Emulation To Gearsystem Core's SG-1000 Emulation. I'm NOT Spamming. Do NOT Dislike That Issue.\n URL \n156840091-ae84839e-089f-474c-a453-f24df0ba0239\n156840105-b869a04f-74a2-4486-a377-ed362dc25dd3\n156840122-647f9344-1a5c-4852-b25b-75d8b2ce365e\n156840129-4a87bf25-63b8-4a0f-8b05-fe7f59d46cd1\n156840133-ec7822c4-e0f4-4c82-b3a3-33396583dcd3\n156840140-560f34d4-bcb1-46e3-aadf-395b2e4400d9","author_login":"ghost","author_association":"NONE","created_at":"2022-03-07T13:19:07+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1161409262,"issue_number":419,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/419","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1060806098","fragment_type":"issue_comment","sequence":1,"text":"It sure looks like you are spamming to me. And you have fired up 3 different accounts apparently. No means no buddy.\n\nimage","author_login":"birdybro","author_association":"NONE","created_at":"2022-03-07T15:23:25+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1161409262,"issue_number":419,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/419","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1060855437","fragment_type":"issue_comment","sequence":2,"text":"I already answered these issues report:\n- those games do NOT work on stock SG-1000 hardware because they need more RAM than the SG-1000 has (afaik, MSX has more RAM than SG-1000)\n- the colors look wrong but that is how they look on Master System hardware\n\nThe solution to your problem is to run these games on SG-1000 hardware with RAM extension cartridge, which is not possible yet in this emulator but you are free to use another emulator if it works for you... just stop spamming the issue report.","author_login":"ekeeke","author_association":"OWNER","created_at":"2022-03-07T16:05:58+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1161409262,"issue_number":419,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/419","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1060864984","fragment_type":"issue_comment","sequence":3,"text":"I'm Using MD.emu For Android. I Need To Get Support For SG-1000 With Gearsystem Core, Game Gear With Genesis Plus GX Core. Master System, Genesis, Sega CD To Be Updated Core To Genesis Plus GX. Got It. \n\nI Need 8GB RAM Phones Running On Android 11 To Download More Emulators. Google Pixel 5.","author_login":"HaroldSlikk","author_association":"NONE","created_at":"2022-03-07T16:14:43+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1161409262,"issue_number":419,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/419","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1060869992","fragment_type":"issue_comment","sequence":4,"text":"@HaroldSlikk You Must Stop Spamming. You Have To Read Community Guidelines. You're Not Allowed To Spam. It's Illegal. Also About Community Guidelines Strike, Copyright Strike","author_login":"DVDVIDE","author_association":"NONE","created_at":"2022-03-07T16:19:10+08:00","repo_name":"ekeeke/Genesis-Plus-GX","issue_id":1161409262,"issue_number":419,"issue_url":"https://github.com/ekeeke/Genesis-Plus-GX/issues/419","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0022","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Tado integration login error since 2025.3.4?","query_context":"### The problem\n\nI cannot login in Tado integration since updating HA to 2025.3.4.\nLogin at URL works fine.\n\n### What version of Home Assistant Core has the issue?\n\ncore-2025.3.4\n\n### What was the last working version of Home Assistant Core?\n\ncore-2025.3.3\n\n### What type of installation are you running?\n\nHome Assistant Supervised\n\n### Integration causing the issue\n\nTado\n\n### Link to integration documentation on our website\n\n URL \n\n### Diagnostics information\n\nLogger: homeassistant.components.tado.config_flow\nQuelle: components/tado/config_flow.py:87\nIntegration: Tado (Dokumentation, Probleme)\nErstmals aufgetreten: 12:17:17 (5 Vorkommnisse)\nZuletzt protokolliert: 12:26:19\n\nUnexpected exception\nTraceback (most recent call last):\n File \"/usr/src/homeassistant/homeassistant/components/tado/config_flow.py\", line 87, in async_step_user\n validated = await validate_input(self.hass, user_input)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/src/homeassistant/homeassistant/components/tado/config_flow.py\", line 52, in validate_input\n tado = await hass.async_add_executor_job(\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n Tado, data[CONF_USERNAME], data[CONF_PASSWORD]\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n )\n ^\n File \"/usr/local/lib/python3.13/concurrent/futures/thread.py\", line 59, in run\n result = self.fn(*self.args, **self.kwargs)\n File \"/usr/local/lib/python3.13/site-packages/PyTado/interface/interface.py\", line 46, in __init__\n self._http = Http(\n ~~~~^\n username=username,\n ^^^^^^^^^^^^^^^^^^\n ... ...\n debug=debug,\n ^^^^^^^^^^^^\n )\n ^\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 153, in __init__\n self._id, self._token_refresh = self._login()\n ~~~~~~~~~~~^^\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 333, in _login\n raise TadoException(\n f\"Login failed for unknown reason with status code {response.status_code}\"\n )\nPyTado.exceptions.TadoException: Login failed for unknown reason with status code 403\n\n### Example YAML snippet\n\nyaml\n\n### Anything in the logs that might be useful for us?\n\ntxt\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_2940321408"],"reference_answer":"Sorry, the change is too large to ship in a patch. Feel free to join the beta testing, which starts today.\n\n../Frenck","answer_document_id":"gh_comment_2753888816","silver_evidence_path":["gh_comment_2745232025","gh_issue_2853449615","gh_comment_2753888816"],"evidence_issue_ids":[2940321408,2853449615],"source_repo_name":"home-assistant/core","source_issue_id":2940321408,"source_issue_number":141107,"source_issue_url":"https://github.com/home-assistant/core/issues/141107","target_repo_name":"home-assistant/core","target_issue_id":2853449615,"target_issue_number":138518,"target_issue_url":"https://github.com/home-assistant/core/issues/138518","reference_anchor_document_id":"gh_comment_2745232025","reference_answer_author":"frenck","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.45,"target_answer_overlap":0.0},"issue_created_at":"2025-03-22T11:27:39+08:00","valid_comment_count":157,"fragments":[{"document_id":"gh_issue_2940321408","fragment_type":"issue_description","sequence":0,"text":"Tado integration login error since 2025.3.4\n### The problem\n\nI cannot login in Tado integration since updating HA to 2025.3.4.\nLogin at URL works fine.\n\n### What version of Home Assistant Core has the issue?\n\ncore-2025.3.4\n\n### What was the last working version of Home Assistant Core?\n\ncore-2025.3.3\n\n### What type of installation are you running?\n\nHome Assistant Supervised\n\n### Integration causing the issue\n\nTado\n\n### Link to integration documentation on our website\n\n URL \n\n### Diagnostics information\n\nLogger: homeassistant.components.tado.config_flow\nQuelle: components/tado/config_flow.py:87\nIntegration: Tado (Dokumentation, Probleme)\nErstmals aufgetreten: 12:17:17 (5 Vorkommnisse)\nZuletzt protokolliert: 12:26:19\n\nUnexpected exception\nTraceback (most recent call last):\n File \"/usr/src/homeassistant/homeassistant/components/tado/config_flow.py\", line 87, in async_step_user\n validated = await validate_input(self.hass, user_input)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/src/homeassistant/homeassistant/components/tado/config_flow.py\", line 52, in validate_input\n tado = await hass.async_add_executor_job(\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n Tado, data[CONF_USERNAME], data[CONF_PASSWORD]\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n )\n ^\n File \"/usr/local/lib/python3.13/concurrent/futures/thread.py\", line 59, in run\n result = self.fn(*self.args, **self.kwargs)\n File \"/usr/local/lib/python3.13/site-packages/PyTado/interface/interface.py\", line 46, in __init__\n self._http = Http(\n ~~~~^\n username=username,\n ^^^^^^^^^^^^^^^^^^\n ... ...\n debug=debug,\n ^^^^^^^^^^^^\n )\n ^\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 153, in __init__\n self._id, self._token_refresh = self._login()\n ~~~~~~~~~~~^^\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 333, in _login\n raise TadoException(\n f\"Login failed for unknown reason with status code {response.status_code}\"\n )\nPyTado.exceptions.TadoException: Login failed for unknown reason with status code 403\n\n### Example YAML snippet\n\nyaml\n\n### Anything in the logs that might be useful for us?\n\ntxt\n\n### Additional information\n\n_No response_","author_login":"arboeh","author_association":"NONE","created_at":"2025-03-22T11:27:39+08:00","repo_name":"home-assistant/core","issue_id":2940321408,"issue_number":141107,"issue_url":"https://github.com/home-assistant/core/issues/141107","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2745231669","fragment_type":"issue_comment","sequence":1,"text":"Same here. The Tado iOS app and website are both still working fine. Double checked that I'm using the correct password. The integration fails to login since updating HA to 2025.3.4 .","author_login":"mt104","author_association":"NONE","created_at":"2025-03-22T11:42:46+08:00","repo_name":"home-assistant/core","issue_id":2940321408,"issue_number":141107,"issue_url":"https://github.com/home-assistant/core/issues/141107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745232025","fragment_type":"issue_comment","sequence":2,"text":"Tado has changed their authentication flow, from password to device flow. This has been patched in the underlying library PyTado and is ready to be merged within Home Assistant. More information can be found here: URL","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-22T11:43:57+08:00","repo_name":"home-assistant/core","issue_id":2940321408,"issue_number":141107,"issue_url":"https://github.com/home-assistant/core/issues/141107","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_issue_2853449615","fragment_type":"issue_description","sequence":0,"text":"[Notice] Deprecation/removal of password flow support from auth.tado.com\n### The problem\n\nHi, Mike from tado GmbH. We wanted to let you know that we will be removing support for the password flow on our Oauth server. We will be removing the functionality by **~~15 March 2025~~** **21 March 2025**.\n\nThe replacement for this is to use the device code flow (for more info see here or here). This flow is more secure and more appropriate for dealing with use cases where there is limited access to a browser and/or there is no possibility to support the redirect in an authorization code flow (e.g. on the command line, in a script). \n\nThis can be used in tandem with the refresh token flow and **must** be in the case that you want to have long-lived access. Our current analysis finds that users using the password grant flow, including those through Home Assistant, do not, in general, use the refresh flow. This causes significant load on our servers because each password check requires expensive hash calculation. \n\nFor more information, see also this post on the tado support page.\n\nNote, I've posted this also on the tado client currently being used by HA (see here also with a code snippet).\n\n### What version of Home Assistant Core has the issue?\n\ncore-*\n\n### What was the last working version of Home Assistant Core?\n\n_No response_\n\n### What type of installation are you running?\n\nHome Assistant OS\n\n### Integration causing the issue\n\ntado\n\n### Link to integration documentation on our website\n\n URL \n\n### Diagnostics information\n\n_No response_\n\n### Example YAML snippet\n\nyaml\n\n### Anything in the logs that might be useful for us?\n\ntxt\n\n### Additional information\n\n_No response_","author_login":"mgmarino","author_association":"NONE","created_at":"2025-02-14T11:37:39+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659146012","fragment_type":"issue_comment","sequence":1,"text":"Thanks for reaching out, @mgmarino. We'll work this out and keep you posted about any progress.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-02-14T11:57:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2722680873","fragment_type":"issue_comment","sequence":2,"text":"What's the status of HA being ready for the API being turned off. I saw that URL was cut which includes the new flow changes but I guess some changes on HA side will be needed to be made to accommodate this.\n\ne.g. token + refresh token will need to be stored on HA instead of user/pass due to the OAuth flow changes.","author_login":"inverse","author_association":"CONTRIBUTOR","created_at":"2025-03-13T21:00:31+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2723440187","fragment_type":"issue_comment","sequence":3,"text":"It sounds like we're not ready? Can we reach back out to our Tado contact to let them know and ask for more time?","author_login":"mikelward","author_association":"NONE","created_at":"2025-03-14T04:31:25+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2723809632","fragment_type":"issue_comment","sequence":4,"text":"I have updated the referenced end date to correspond with the most recent communication to the customers (21 March 2025)","author_login":"mgmarino","author_association":"NONE","created_at":"2025-03-14T06:55:17+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2724789353","fragment_type":"issue_comment","sequence":5,"text":"Development activities in HA have started. PR is coming. I have aligned with a Core Developer we get Priority on this PR.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-14T13:58:32+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2738231110","fragment_type":"issue_comment","sequence":6,"text":"PR has been made and already (sub)reviewed with a Core Developer. HA intends to push this in the Beta release, which will be on Friday. It should be included in the 2024.4 release, if I am not mistaken.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-19T21:47:13+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739396542","fragment_type":"issue_comment","sequence":7,"text":"Thanks for the update, @erwindouna. We still need to remove the password flow this Friday. We will try to keep the refresh flow associated with this client open until the 2024.4 release. Keeping that open should allow users to continue using HA at least until a restart. For users who are forced to restart, then they should still have the option to use the Beta release.","author_login":"mgmarino","author_association":"NONE","created_at":"2025-03-20T07:01:08+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742569462","fragment_type":"issue_comment","sequence":8,"text":"I can at least confirm that you loose the tado device functions when you reboot today (21st) as other updates require it. Thanks for working this.","author_login":"relighted","author_association":"NONE","created_at":"2025-03-21T07:32:35+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742666582","fragment_type":"issue_comment","sequence":9,"text":"@erwindouna Thanks for working on this. \nAny idea on when this BETA release would be made available? Because I too lost my access to Tado from HA as previous post, which does break a lot of automation in my HA installation. \nOr if you know a workaround I'd be happy to hear it","author_login":"Kraganov","author_association":"NONE","created_at":"2025-03-21T08:28:52+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742670583","fragment_type":"issue_comment","sequence":10,"text":"Unfortunately I don't know another workaround within HA. The refresh token would stay alive long enough when the 2024.4 would go alive. Only those installations that rebooted would potentially be impacted, regrettably.\nThe Beta scheduled this Wednesday.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-21T08:30:55+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742673713","fragment_type":"issue_comment","sequence":11,"text":"Not a workaround per-se, but the Node Red Tado plugin has already been updated and works so you could use that","author_login":"derekoharrow","author_association":"NONE","created_at":"2025-03-21T08:32:33+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742809769","fragment_type":"issue_comment","sequence":12,"text":"I restarted HA this morning, unaware of this issue. I didn't relish the thought of being without heading/hot water until Wednesday so I tried downloading the code in the open PR with a view to installing it as a `custom_component`.\n\nUnfortunately for those considering this approach, it didn't work:\n\n`\n2025-03-21 09:27:29.593 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Home for tado\nTraceback (most recent call last):\n File \"/usr/src/homeassistant/homeassistant/config_entries.py\", line 753, in __async_setup_with_context\n result = await component.async_setup_entry(hass, self)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/config/custom_components/tado/__init__.py\", line 70, in async_setup_entry\n entry.data[CONF_REFRESH_TOKEN],\n ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^\nKeyError: 'refresh_token'\n2025-03-21 09:27:33.859 DEBUG (MainThread) [custom_components.tado] Setting up Tado connection\n2025-03-21 09:27:33.859 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Home for tado\nTraceback (most recent call last):\n File \"/usr/src/homeassistant/homeassistant/config_entries.py\", line 753, in __async_setup_with_context\n result = await component.async_setup_entry(hass, self)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/config/custom_components/tado/__init__.py\", line 70, in async_setup_entry\n entry.data[CONF_REFRESH_TOKEN],\n ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^\nKeyError: 'refresh_token'\n\n`","author_login":"WhimsySpoon","author_association":"NONE","created_at":"2025-03-21T09:31:22+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742812398","fragment_type":"issue_comment","sequence":13,"text":"That would require the latest PyTado as well. Which gives the device flow I built in.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-21T09:32:21+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742813786","fragment_type":"issue_comment","sequence":14,"text":"Good point. I guess doing this inside of an HAOS instance is going to be a pig to achieve.","author_login":"WhimsySpoon","author_association":"NONE","created_at":"2025-03-21T09:32:59+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2743005989","fragment_type":"issue_comment","sequence":15,"text":"As i understand there is no work around at the moment and we need to wait for the pr to merge? Anything that can be done manualy?","author_login":"nickjuhhhh","author_association":"NONE","created_at":"2025-03-21T10:51:29+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2743034473","fragment_type":"issue_comment","sequence":16,"text":"As I understand it, even with the PR merged, this won't be released until HA Core 2024.4 beta dropping next Wednesday, so it's going to be the better part of a week before it's resolved.\n\nLooks like Node Red could be a work-around though.","author_login":"WhimsySpoon","author_association":"NONE","created_at":"2025-03-21T11:04:08+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2743122684","fragment_type":"issue_comment","sequence":17,"text":"Well i dont use nodered so i think i will pass that option :p","author_login":"nickjuhhhh","author_association":"NONE","created_at":"2025-03-21T11:43:31+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2743469891","fragment_type":"issue_comment","sequence":18,"text":"I'd love to use the local Homekit support, but unfortunately the water heater add on was never supported.","author_login":"WhimsySpoon","author_association":"NONE","created_at":"2025-03-21T14:04:30+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2744200040","fragment_type":"issue_comment","sequence":19,"text":"Hi @erwindouna, could you confirm me what is going to be needed when you say: \"It should be included in the 2025.4 release\"? I am asking because I have a home assistant I would like to avoid updating and I don't know if your words mean that of course I will need to update core version or I will be able to continue with my current version (2024-11) and I will only need to update tado integration. Thanks","author_login":"CristianGonzalezFernandez","author_association":"NONE","created_at":"2025-03-21T18:52:21+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2744297540","fragment_type":"issue_comment","sequence":20,"text":"This will also impact older versions. Tado had disabled the password flow. I would recommend to upgrade to 2025.4 when it's released.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-21T19:45:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2744364891","fragment_type":"issue_comment","sequence":21,"text":"Thank to all who are working on this but has shown to me the vulnerabilities of some HA integrations. Not a complaint as its supported by very talented but essentially amateur folks. I am shifting to a localised TADO solution from now on.","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-21T20:17:27+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2744472828","fragment_type":"issue_comment","sequence":22,"text":"How? I am interested how you want to get rid of the cloud. Out of curiosity.","author_login":"sven-debug","author_association":"NONE","created_at":"2025-03-21T21:22:07+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2744500175","fragment_type":"issue_comment","sequence":23,"text":"They were given lots of notice but now scrabbling around trying to sort it\nout. As I said not complaining at all but it's not professional\n\nOn Fri, 21 Mar 2025, 21:29 Edwin D., ***@***.***> wrote:","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-21T21:41:06+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2744524165","fragment_type":"issue_comment","sequence":24,"text":"To those asking of non cloud tado use home kit .. it's not fully functional but I run it just in case ... Like now where TADO HA integration is useless until when?","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-21T21:52:40+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2744560219","fragment_type":"issue_comment","sequence":25,"text":"Oh dear... I don't criticise anyone at all. I am just expressing my view\nthat we rely on a community of amateurs to support this integration. I can\nmake it work fine locally and have rigged things .. just very disappointed\nthat after numerous flags from TADO this wasn't addressed until now\n\nOn Fri, 21 Mar 2025, 22:01 Edwin D., ***@***.***> wrote:","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-21T22:07:09+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2744562920","fragment_type":"issue_comment","sequence":26,"text":"Peace ... Go your own way xx\n\nOn Fri, 21 Mar 2025, 22:01 Edwin D., ***@***.***> wrote:","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-21T22:09:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2744603902","fragment_type":"issue_comment","sequence":27,"text":"GitHub - smart7324/homebridge-tado-platform-next: Homebridge plugin for controlling Tado devices\nHomebridge plugin for controlling Tado devices\n\nlooks like they’ve managed to update the plugin for homebridge to use new oauth method","author_login":"DariukaB","author_association":"NONE","created_at":"2025-03-21T22:37:09+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745114784","fragment_type":"issue_comment","sequence":28,"text":"sure to say 2025.3.4 core didn;t include the integration fix, as I am running it now","author_login":"dacootmeister","author_association":"NONE","created_at":"2025-03-22T07:34:27+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745140582","fragment_type":"issue_comment","sequence":29,"text":"The fix is still being developed so not yet ready to deploy live. Also, given that it's a breaking change it's less likely to be included in a patch release.\n\n URL","author_login":"orbsmiv","author_association":"NONE","created_at":"2025-03-22T08:29:25+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745145326","fragment_type":"issue_comment","sequence":30,"text":"That's obvious. But why did Home Assistant inform Tado that they would provide a fix until the password authentication flow is removed?","author_login":"danielpotthast","author_association":"NONE","created_at":"2025-03-22T08:44:23+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745146766","fragment_type":"issue_comment","sequence":31,"text":"That’s bad news. It means an integration not working for a couple of weeks😔","author_login":"canedje","author_association":"NONE","created_at":"2025-03-22T08:49:15+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745148795","fragment_type":"issue_comment","sequence":32,"text":"I hear you. I completely forgot about it not working and had no not water this morning, much to the annoyance of my family.\n\nI too wanted to get frustrated; yes, this could have probsbly been fixed sooner, and it's going to be a week before the beta is released, then it's going to be another week or two of running a potentially buggy HA Core beta, but I remembered it's just one person maintaining this, in their own time. And I shouldn't have invested so heavily in Tado's ecosystem when I'm so reliant on their cloud.\n\nThe best thing we can do right now is try the home kit workarounds, be patient and help the dev(s) with any testing they may need.","author_login":"WhimsySpoon","author_association":"NONE","created_at":"2025-03-22T08:55:17+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745172415","fragment_type":"issue_comment","sequence":33,"text":"How can i workaround with homekit? I tried to add bridge, it's enabled in pair mode but i cant't find it under integration","author_login":"lotablet","author_association":"NONE","created_at":"2025-03-22T09:30:42+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745178026","fragment_type":"issue_comment","sequence":34,"text":"Try this URL \n\nI had to factory reset my bridge to get it to work before.","author_login":"WhimsySpoon","author_association":"NONE","created_at":"2025-03-22T09:34:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745210792","fragment_type":"issue_comment","sequence":35,"text":"I use homekit integration\n\nOn Fri, 21 Mar 2025, 21:22 Zvenster, ***@***.***> wrote:","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-22T10:57:00+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2745235221","fragment_type":"issue_comment","sequence":36,"text":"Consider the following:\n\n- This notice of deprecation was sent 4 weeks in advance.\n- It took the underlying PyTado library almost 3 weeks to get a first working version released ( URL \n- it took them until March 17 to get this stable enough to use. ( URL \n- any other library than PyTado and HA was not even informed of this change, they had to hear from others or receive the email 2 weeks ago that this was coming\n\nThis meant there was less than 1 week to develop, test and verify for HA.\n\nSource: Ive ported this change to another library (libtado) which i use in my own script, and their maintainer was also *just* in time to get this released. ( URL \n\nWith this being a significant change, and also a breaking one, i guess this is how it is, unfortunately.","author_login":"arjanvlek","author_association":"NONE","created_at":"2025-03-22T11:54:54+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745277848","fragment_type":"issue_comment","sequence":37,"text":"I get an error “Failed setup, will retry: Error during Tado setup: Login failed for unknown reason with status code 403” since update to latest version on HA CORE. Any suggestions please?","author_login":"Ra7t0r","author_association":"NONE","created_at":"2025-03-22T13:54:56+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745327027","fragment_type":"issue_comment","sequence":38,"text":"Would love to use the Homekit integration for Tado. There are just a few things missing like the battery status and the current heating percentage.","author_login":"nistei","author_association":"NONE","created_at":"2025-03-22T15:45:38+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745328002","fragment_type":"issue_comment","sequence":39,"text":"Had same issue. Removed the Tado integration and switched to local. (Homekit)\n\nIf you don't see it come up in HA, just follow the steps via the link below, to factory reset the Tado bridge. (don't worry, you don't need to repair the thermostats or radiators)\n\n URL","author_login":"rgruyters","author_association":"NONE","created_at":"2025-03-22T15:48:04+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745333418","fragment_type":"issue_comment","sequence":40,"text":"This hot fix did the trick for me and the integration now works:\n\n URL \n\nIf you're using docker, attach to its console \n\ndocker ps\ndocker exec -it /bin/bash\n\nAnd run the two commands from the comment above. \n\ncd /config\ncurl -o- -L URL | bash /dev/stdin -d tado -p 140761\n\nThis invokes a script that downloads the PR code above and converts it to a custom component in your config/custom_components folder.\n\nThen restart your homeassitant instance, empty your browser cache and follow the instructions to repair the integration. It should work straight away.","author_login":"igiannakas","author_association":"NONE","created_at":"2025-03-22T16:02:34+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745337682","fragment_type":"issue_comment","sequence":41,"text":"@igiannakas it only works if the HA system language is english 😉","author_login":"TDCroPower","author_association":"NONE","created_at":"2025-03-22T16:13:16+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745378996","fragment_type":"issue_comment","sequence":42,"text":"@igiannakas thanks, that fixed the TADO integration. After rebooting, I got this message: \"Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble\", so I did another reboot and the fix finally worked.","author_login":"PaoloPC","author_association":"NONE","created_at":"2025-03-22T17:33:02+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745381263","fragment_type":"issue_comment","sequence":43,"text":"Tado not fixed yet for me with this version, anyone any Idea?\n\nFailed setup, will retry: Error during Tado setup: Login failed for unknown reason with status code 403","author_login":"thoompje","author_association":"NONE","created_at":"2025-03-22T17:39:37+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745902622","fragment_type":"issue_comment","sequence":44,"text":"Here is a workaround for those who are not using Docker:\n URL","author_login":"bkarakashev","author_association":"NONE","created_at":"2025-03-22T22:48:46+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2745914110","fragment_type":"issue_comment","sequence":45,"text":"I'have the same problem after reboot the Home Assistant. Home Assistant is running on Core 2025.3.3. Reconfig of the integration gifes a unexpected error. \n\nImage","author_login":"willsmarthome","author_association":"NONE","created_at":"2025-03-22T23:31:08+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746109867","fragment_type":"issue_comment","sequence":46,"text":"As I commented in the other thread URL , after some failures I was able to trigger the reconfiguration and the new Tado authentication process connecting to HA from outside my network using the HA app on my cell phone.","author_login":"mmmunafo","author_association":"NONE","created_at":"2025-03-23T09:24:31+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746124228","fragment_type":"issue_comment","sequence":47,"text":"Same for me…\nNo login possible for Tado…\nHapend after update 2025.3.4.","author_login":"Fatalmose","author_association":"NONE","created_at":"2025-03-23T10:01:56+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746148162","fragment_type":"issue_comment","sequence":48,"text":"if you are running HA OS like me, go to Advanced SSH & Web Terminal and type\n\n/config\n\nand \n\ncurl -o- -L URL | bash /dev/stdin -d tado -p 140761\n\nReboot HA and add integration\n\nthis solved everything","author_login":"lotablet","author_association":"NONE","created_at":"2025-03-23T11:04:04+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746153283","fragment_type":"issue_comment","sequence":49,"text":"Mind to explain what this does? I am surely not applying this blindly","author_login":"schlossperle","author_association":"NONE","created_at":"2025-03-23T11:16:59+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746154187","fragment_type":"issue_comment","sequence":50,"text":"does exaclty what explained here URL \nit replace tado integration with login fixeded","author_login":"lotablet","author_association":"NONE","created_at":"2025-03-23T11:19:13+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2746158347","fragment_type":"issue_comment","sequence":51,"text":"Hello \nThank you.\nI apply this solution.\nI succeded to connect to my tado devices.\nRegards","author_login":"toto25550","author_association":"NONE","created_at":"2025-03-23T11:26:08+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2746179533","fragment_type":"issue_comment","sequence":52,"text":"good to hear that the solution works.\nwill there be a release soon?\nor in what time frame will this be in an official release?","author_login":"sanojjonas","author_association":"NONE","created_at":"2025-03-23T12:16:15+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746181433","fragment_type":"issue_comment","sequence":53,"text":"Unfortunately it's not working for me. Still having the error and no folder in custom components. Does anyone have an idea, why this error appers at the end ? \n\nImage","author_login":"1192410","author_association":"NONE","created_at":"2025-03-23T12:20:42+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746188391","fragment_type":"issue_comment","sequence":54,"text":"The goal is to have this merged in before the Beta, which is scheduled this Wednesday. If all goes well it can be shipped in the 2025.4 release.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-23T12:37:16+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746195314","fragment_type":"issue_comment","sequence":55,"text":"workaround with script works for me so far; waiting for the final release. Thx","author_login":"vrtsman","author_association":"NONE","created_at":"2025-03-23T12:50:31+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746293567","fragment_type":"issue_comment","sequence":56,"text":"I applied the workaround. Custom folder created and reconfigure button appeared. Still i have the error \" Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble\" \n\nImage","author_login":"chinezbrun","author_association":"NONE","created_at":"2025-03-23T16:15:25+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746309959","fragment_type":"issue_comment","sequence":57,"text":"@chinezbrun You have to delete tado from HA and reinstall it!","author_login":"Christian-CFP","author_association":"NONE","created_at":"2025-03-23T16:53:23+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746324114","fragment_type":"issue_comment","sequence":58,"text":"Found out the same. You have to ignore or delete the auto-discovered Tado,\nthen add a new instance.\nMaybe this is something that should be fixed in the PR, but IDK\n\nOp zo 23 mrt 2025 om 17:53 schreef Christian ***@***.***>:","author_login":"arjanvlek","author_association":"NONE","created_at":"2025-03-23T17:26:42+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2746342535","fragment_type":"issue_comment","sequence":59,"text":"work around also not working for me. Currently using my Node-red flows that I have for back up. Node-Red have new Tado nodes that establish the Oauth link ok. There is a great example flow that shows you how to do it at ( URL \n\nwork well.","author_login":"briancrocker42","author_association":"NONE","created_at":"2025-03-23T18:03:27+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746449136","fragment_type":"issue_comment","sequence":60,"text":"Thank you so much for your advice, but after two days of tinkering, I haven't achieved anything, and at seventy years old, it seems too late to go back to university.\nFrom what I can see, many of us are having trouble controlling Tado from our home automation app (in my case, Home Assistant). I think Tado has set the bar too high for many of us with this new process.\nI don't even know where to enter the calls. I've typed them into the \"Terminal\" in Home Assistant, reset them, and haven't achieved anything.\nAnyway, thanks everyone. I'll keep trying.","author_login":"Kepasub","author_association":"NONE","created_at":"2025-03-23T20:55:29+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746459364","fragment_type":"issue_comment","sequence":61,"text":"We're aiming for a Beta release on Wednesday. Please keep notified of this thread and I hope we can resolve this for you all as soon as we can!","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-23T20:59:17+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746474419","fragment_type":"issue_comment","sequence":62,"text":"Check if you have the Terminal installed. If so, it will appear in the Home Assistant sidebar.\n\nImage\n\nIf not, install it via the Add-on Store:\n\nImage\n\nRun the Following Commands in the Terminal\n\nOpen the terminal and enter:\n\ncd /config\n\ncurl -o- -L URL | bash /dev/stdin -d tado -p 140761\n\n⚠️ Note:\nSometimes, the entire command may not paste correctly into the terminal. If that happens, try pasting it again carefully.\n\nRestart Home Assistant\nAfter running the command, restart Home Assistant once or twice for the changes to take effect.","author_login":"1192410","author_association":"NONE","created_at":"2025-03-23T21:24:51+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746524922","fragment_type":"issue_comment","sequence":63,"text":"Again, thank you very much for your collaboration.\nI'll wait until Thursday, because I'm afraid I might mess it up more and more. Actually, I only have one schedule that will turn on the heating at off-schedule hours if it's very cold outside. I can schedule the rest directly from the MyTado app.\nI've even deleted the Tado integration, and as some have commented, I haven't been able to reinstall it. Even after Thursday, I have my doubts about having a Tado token, which I presume I'll need to reinstall the integration.\nI do have the Terminal in the sidebar, but after deleting the Tado integration, I don't know if the command will have done anything.\nAgain, thank you very much: Kepa","author_login":"Kepasub","author_association":"NONE","created_at":"2025-03-23T22:52:23+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2746531101","fragment_type":"issue_comment","sequence":64,"text":"Rest assured, once the patch becomes available you will be provided with user friendly steps to authenticate with Tado again. On the background the tokens will be obtained, stored and refreshed accordingly as you were used to. I hope you can manage in the main time, if you prefer not to run the work around.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-23T23:05:48+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2747316487","fragment_type":"issue_comment","sequence":65,"text":"Workaround doesn't work for me :( I get:\n\nImportError: cannot import name 'AddConfigEntryEntitiesCallback' from 'homeassistant.helpers.entity_platform' (/usr/src/homeassistant/homeassistant/helpers/entity_platform.py)","author_login":"jan8p","author_association":"NONE","created_at":"2025-03-24T08:42:06+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2747704410","fragment_type":"issue_comment","sequence":66,"text":"I've this error during authentication:\n\n`UnboundLocalError: cannot access local variable 'tado_device_url' where it is not associated with a value\n`","author_login":"gabriele-latino","author_association":"NONE","created_at":"2025-03-24T10:52:02+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748050287","fragment_type":"issue_comment","sequence":67,"text":"Great! It worked after following the above procedure via Terminal, restarting HA, and logging back into TADO. You did a great job.\n\nAfter the failure, however, I'm now suspicious.\n\nI use a TADO Smart IR Remote Control to control my DANYON split air conditioning system via HA.\n\nDo any of you know of another cloud-free solution for this?","author_login":"lehmanro2","author_association":"NONE","created_at":"2025-03-24T12:58:17+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748065326","fragment_type":"issue_comment","sequence":68,"text":"@lehmanro2\n \n \n \n\nYou can use the homekit integration to install the \"Smart AC Control V3+\" in Home Assistant.","author_login":"HunterX86","author_association":"NONE","created_at":"2025-03-24T13:03:46+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748132142","fragment_type":"issue_comment","sequence":69,"text":"I've just been researching what Smart AC Control V3+ is. Also from Tado. I'm jumping out of the frying pan and into the fire.","author_login":"lehmanro2","author_association":"NONE","created_at":"2025-03-24T13:26:29+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748160555","fragment_type":"issue_comment","sequence":70,"text":"**A copy from the Pull Request**\n\nThe fix has been merged and this means it will be made available shortly! The earliest possibility will be in the **Beta**, on **Wednesday the 26th of March**. For those we didn't felt comfortable or were unable to get the custom component fix in (provided by @Dillton, again thanks for your great work around!), this is the easiest way to get the new code.\nThe other opportunity will be the release of **2025.4.0**. Currently this PR is still qualified to be part in this release.\n\n**How to opt-in for the Beta?**\nFirst a short disclaimer: it's a Beta. Please treat it like a Beta. It might show some instabilities and hick-ups in parts of Home Assistant.\n\n1. Go-to your system settings:\nimage\n\n2. Go-to updates:\nimage\n\n3. On the top-right, find the three dots and click \"Join Beta channel\":\nimage\n\n4. Confirm to join the Beta channel:\nimage\n\n**I have installed the custom component/work around. What should I do?**\nYou **have to** remove the customer component/work around. Why? The custom component will also be the first referenced to be used. Effectively meaning if you don't remove it, the _old code_ will always be called and future updates of the Tado integration will not be made effective. If this is what you intend, feel free to do so. If you wish to get back on track, you _have to_ remove the work around.\nPlease use the following command in your terminal:\n \n\net me close of with thanking all the collaborators who were very eager to tinkering a long and find solutions and being very supportive to help other users! A great example, even in a dire situation, how the Open Source community tries to help each other!\n\nLet's now focus on the Beta and onwards to the official release. Feel free to ask for support in this thread, which I will monitor to help around as best as I can. 😃","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-24T13:35:55+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748466148","fragment_type":"issue_comment","sequence":71,"text":"One question regarding the timing of the removal of the custom component. Does it matter when this needs to be removed, i.e. before or after the 2025.4 upgrade ? I would think first remove the custom component and then do the update to 2025.4 and it should all work fine.","author_login":"1192410","author_association":"NONE","created_at":"2025-03-24T15:08:50+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748488184","fragment_type":"issue_comment","sequence":72,"text":"I would recommend to \"clean\" your installation, yes. So remove the custom component prior to upgrading.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-24T15:14:46+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2749515915","fragment_type":"issue_comment","sequence":73,"text":"This person is a legend, worded like magic. Thank you to all who keeps this stuff running.","author_login":"Lankyalong","author_association":"NONE","created_at":"2025-03-24T22:11:30+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2750492828","fragment_type":"issue_comment","sequence":74,"text":"I have two instances of the Tado integration (two homes). I did what's described here and it worked with the first instance: it asked me to click a link which took me to a tado login web page, where I had to type my credentials. However, when I tried to do the same for the other instance, it took me to the same page but didn't ask for the other home's credentials. Both integrations are showing as correctly working, but the sensors and entities related to the second instance (for which I wasn't asked to login) don't work.","author_login":"jacoscar","author_association":"NONE","created_at":"2025-03-25T08:38:36+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2750517825","fragment_type":"issue_comment","sequence":75,"text":"Then Tado think's you're logging in with the same account. On the authentication page you should be able to switch accounts. This is something that is managed on Tado's side _how and on which account you login_.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-25T08:46:44+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2750525047","fragment_type":"issue_comment","sequence":76,"text":"Ok, so how do I force home assistant to present me with the login link again? It thinks I’m logged in but I’m clearly not","author_login":"jacoscar","author_association":"NONE","created_at":"2025-03-25T08:49:30+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2750568364","fragment_type":"issue_comment","sequence":77,"text":"You could enforce a \"Reload\" on this particular instance and see if this enforces a new login step. If you're very tech savvy: you can goto `/config/.config_entries` and find the particular Tado instance. Remove the attribute `CONF_REFRESH_TOKEN` and the integration should automatically provided a re-authentication.\n\nOther than that, I haven't included a reconfigure step in the current code. Might be a good addition for a later phase. In the worst case scenario, delete the instance and rename the entities once they're loaded back in.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-25T09:05:27+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2750720321","fragment_type":"issue_comment","sequence":78,"text":"\"Reload\" just \"reloads successfully\" without asking for login. Unfortunately I am on Home Assistant OS, so I cannot access the config folder","author_login":"jacoscar","author_association":"NONE","created_at":"2025-03-25T10:01:01+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2750996248","fragment_type":"issue_comment","sequence":79,"text":"@mgmarino while I appreciate the support, the lead-time for this breaking change was _very_ short, leaving users of the stable HA release train with non-functional Tado support, at least until 2025.4 is released (which is not available yet). Having support for the new auth flow this quickly in HA is already impressive, but one month of notice is simply way too short to allow for a smooth transition.","author_login":"accumulator","author_association":"NONE","created_at":"2025-03-25T11:47:27+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2752029606","fragment_type":"issue_comment","sequence":80,"text":"I use a HA docker installation and have two instances of Tado with a lot of entities (80+) - the mentioned workarounds and fixes do not work for me and I am not able to join the beta channel. Any solution for my case too?\n\nThanks soo much for your great work and for keeping it alive :-)","author_login":"fabi86","author_association":"NONE","created_at":"2025-03-25T17:31:26+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2752404944","fragment_type":"issue_comment","sequence":81,"text":"When I try the workaround I get `[%key:common::config_flow::abort::already_configured_account%]`. I believe it's probably because I disabled but didn't remove my old config before trying it but now all Tado entries are gone for me to delete it.\nAny ideas?","author_login":"jwhiteley93","author_association":"NONE","created_at":"2025-03-25T20:11:34+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753701875","fragment_type":"issue_comment","sequence":82,"text":"Quite strange that this was announced 6 weeks ago and that we need to wait for the next major monthly HA release. In my honest opinion this should already be pushed in a HA fix release as soon as possible. We are talking about an essential component that controls the climate in your home, not a fancy nice-to-have thingy. Each day your users are raising new tickets for this blocking issue. Thanks for the hard work though.","author_login":"groenmarsmannetje","author_association":"NONE","created_at":"2025-03-26T09:17:33+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753721458","fragment_type":"issue_comment","sequence":83,"text":"@groenmarsmannetje 6 weeks is a ridiculously short amount of time for Tado to announce a major breaking change. The reasons you described (essential component, used by many) is the exact reason it shouldn't be rushed and we make sure it is solid before reaching production.\n\nYou must remember that HA is a free, open source platform maintained by a community. It's likely the person updating this is doing it in evenings and weekends, unpaid.","author_login":"jwhiteley93","author_association":"NONE","created_at":"2025-03-26T09:25:03+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753725257","fragment_type":"issue_comment","sequence":84,"text":"Well ... the current solution is not solid .... because it is not working at all ;-)","author_login":"groenmarsmannetje","author_association":"NONE","created_at":"2025-03-26T09:26:33+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753732567","fragment_type":"issue_comment","sequence":85,"text":"I agree this should be pushed in a fix update, but you should also get off your high horse @groenmarsmannetje. This is free software and you're not entitled to anything.","author_login":"LarsStegman","author_association":"CONTRIBUTOR","created_at":"2025-03-26T09:29:14+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753739809","fragment_type":"issue_comment","sequence":86,"text":"It is not totally free.... I pay a monthly fee... to support HA and the community. I am giving \"customer feedback\" for free, maybe good to just listen to what your users tell you, it might be that you could learn something from it for free ;-)","author_login":"groenmarsmannetje","author_association":"NONE","created_at":"2025-03-26T09:32:00+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753862650","fragment_type":"issue_comment","sequence":87,"text":"You pay a monthly fee to a commercial company, Nabu Casa, for their product, Home Assistant Cloud. They pay some people who work on home assistant, but not the person that owns the Tado integration. The HA Devs did nothing wrong here, this was entirely Tado's fault.","author_login":"jwhiteley93","author_association":"NONE","created_at":"2025-03-26T10:07:21+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753888816","fragment_type":"issue_comment","sequence":88,"text":"Sorry, the change is too large to ship in a patch. Feel free to join the beta testing, which starts today.\n\n../Frenck","author_login":"frenck","author_association":"MEMBER","created_at":"2025-03-26T10:17:23+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753918418","fragment_type":"issue_comment","sequence":89,"text":"Well, at least it is a (another) reminder that cloud-requiring hardware is just not reliable enough if you want to avoid these manufacturer surprises :)\n\nIs anyone aware of a open solution to control these sub-1GHz 6LoWPAN thermostats?","author_login":"accumulator","author_association":"NONE","created_at":"2025-03-26T10:27:09+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2754627714","fragment_type":"issue_comment","sequence":90,"text":"Sorry mate, but things like these makes me want to quit all my open source projects. Even though (I assume) your intentions are good, you cannot expect them to throw any principles over board by shipping such a big change as a hotfix just because some random vendor decided to introduce a breaking change like that. In fact you cannot blame them either as they do not support things like the tado integration officially. Indeed it is still based on a reverse engineered api, so Tado was just being nice by giving 6 weeks of time.\n\nAgain I feel like your intention is good, however your message most certainly hurts those trying to provide free software all day every day. Lastly I want to mention that HA's release cycle is 1 month (which is already interestingly short given the amount of testing that must be done to ensure everything works even with custom integrations). In the end, you do have a solution as of now as you can use the beta software which includes the fix. As @accumulator said a local solution would be even better. In fact I already spend around 3 months trying to reverse engineer the commands send by the bridge to and from the thermostats. Quite an effort, but when I'm successful, one _might_ be able to use an esp8266 acting like the bridge. At least I'm already able to turn em on and off locally 🤷🏼","author_login":"orangecoding","author_association":"NONE","created_at":"2025-03-26T14:27:07+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2754784374","fragment_type":"issue_comment","sequence":91,"text":"Thank you so much, \"orangecoding,\" for your comment. **Please don't leave!**\nWhat would become of us who don't master coding languages ​​and survive thanks to visual editors without those of you who master coding languages? What would we be without those who voluntarily contribute a portion of their time and dedicate that time and their best will to all of us?\nWithout you, open source would be nothing. Instead, it's more than just code. **It's a philosophy.**\nThanks to all those who promote open source.\nBest regards: Kepa","author_login":"Kepasub","author_association":"NONE","created_at":"2025-03-26T15:14:18+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755000740","fragment_type":"issue_comment","sequence":92,"text":"Thanks @Kepasub \nIt's good to know there are still people out there that doesn't take all of this for granted. To be honest I cannot blame anybody. Society has changed to become an ever growing crowd of people expecting free stuff is just around the corner. It's pretty frustrating to spend weekends on solving a problem and then get bombarded by random strangers insulting me for not fixing things earlier. Anyway, I'm side-tracking this thread, forgive me ;) \n\nTLDR; For those that needs a fix now, go with the beta, for those who can wait, it's only 7 more days until it's release day.","author_login":"orangecoding","author_association":"NONE","created_at":"2025-03-26T16:20:47+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755126748","fragment_type":"issue_comment","sequence":93,"text":"I think what may have frustrated most of those affected is that we only found out when our HA boxes restarted after applying the 2025.3.4 update on/after the 21st March. \nIf we'd known that a restart was going to stop HA talking to Tado we would have probably held off until 2025.4 came along.","author_login":"DavidR-C","author_association":"NONE","created_at":"2025-03-26T17:04:52+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755176870","fragment_type":"issue_comment","sequence":94,"text":"I know it was unrelated to the HA update. But it was the restart that stopped it working. If we (the Tado users) had held off updating and therefor not restarted our HA, then I think our HA would still be talking to Tado.\nThe 2025.3.4 update just happened to be released around the 21st March when Tado turned off that authentication method.","author_login":"DavidR-C","author_association":"NONE","created_at":"2025-03-26T17:25:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755213476","fragment_type":"issue_comment","sequence":95,"text":"\"We will try to keep the refresh flow associated with this client open until the 2024.4 release. Keeping that open should allow users to continue using HA at least until a restart\"\n\nThis is what Tado wrote above. The update triggered the reboot and this prevented the integration from continuing to work.","author_login":"StefanSarzio","author_association":"NONE","created_at":"2025-03-26T17:36:00+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755361262","fragment_type":"issue_comment","sequence":96,"text":"Unfortunately that's not what actually happened, and thanks to HA we have all the traces to check this 😆\nI lost all Tado data on 21/03 15:24 (CET), while my HA hasn't been rebooted between 17/03 19:14 and 22/03 10:50 (which is the time I updated to 2025.4).\nSo in my case at least the Tado integration lost access to the platform completely out of the blue, while I was at work.","author_login":"jcnico","author_association":"NONE","created_at":"2025-03-26T18:10:23+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755384052","fragment_type":"issue_comment","sequence":97,"text":"The long awaited Beta is out! Details can be found here: URL \n\nI hope this brings the stability and ease of use to solve this issue. If you encounter any trouble, please use the Beta issue tracker: URL","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-26T18:20:35+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757074824","fragment_type":"issue_comment","sequence":98,"text":"After my installation got broken last week, I decided in the end to just control temporarily directly from Tado app and just wait for the BETA. \n\nThis morning, the BETA showed up in my updates, I installed it and immediately got a fix notification for an expired Tado Authentication. \nOnce I clicked submit, I received a new message with the OAuth link, but also the token separately (in case it would not get filled in automatically).\nI followed the link to the Tado OAuth and confirmed with my Tado login and that was it. \n\nIssue fixed, without having to mess around too much with custom integrations from CLI and such. Happy Days! \n\nA big thanks to @erwindouna for his hard work, and to the community for testing and confirming different solutions and workarounds, even if I chose not to use them.\n\nTo those getting so frustrated, come on, lighten up, there really are much worse things in life that waiting one week for a software fix. \n(which, by the way is incredibly fast -again props to Erwin for that-, even if you count the whole period being less than 2 months., it's still very fast)","author_login":"Kraganov","author_association":"NONE","created_at":"2025-03-27T08:06:21+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757216553","fragment_type":"issue_comment","sequence":99,"text":"Small Update on my previous post: If you do a \"Restart Home Assistant\" your authentication will expire and needs to be renewed.","author_login":"Kraganov","author_association":"NONE","created_at":"2025-03-27T08:48:39+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757251188","fragment_type":"issue_comment","sequence":100,"text":"This isn't intended behavior. I made it persistent so the refresh token is saved and can be reused upon a restart.\nI just checked again on my local setup and this works this way.\nDo you have logging?","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-27T09:02:25+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757307640","fragment_type":"issue_comment","sequence":101,"text":"You might want to consider sponsoring @erwindouna (a one-time donation option is also available). I just sent some money—huge thanks for all the effort! \n URL","author_login":"orangecoding","author_association":"NONE","created_at":"2025-03-27T09:23:45+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757727998","fragment_type":"issue_comment","sequence":102,"text":"I installed the beta version and can confirm that the fix works. The re-authentication worked without issue at my side. Thanks for all the effort!","author_login":"groenmarsmannetje","author_association":"NONE","created_at":"2025-03-27T11:36:58+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757787904","fragment_type":"issue_comment","sequence":103,"text":"Not necessary to do my work. Nonetheless your gesture is greatly appreciated!","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-27T12:00:52+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757927087","fragment_type":"issue_comment","sequence":104,"text":"@erwindouna it happened this morning, maybe half hour or so after initial install, when I ran a restart as I had been tinkering a bit. (unrelated config). However, I just tried to reproduce it with debug logging enabled, and it staid persistent now. \nI saw there was an update BETA as well, so thought I'd try that one at once too and still persistent. \nMust have been something funky this morning","author_login":"Kraganov","author_association":"NONE","created_at":"2025-03-27T12:51:18+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2759430158","fragment_type":"issue_comment","sequence":105,"text":"That's a new leas for me. So every new fresh installation the persistence is gone. Again, this is not intended behavior but a good lead for me to investigate. Thanks!","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-27T20:42:24+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2760411884","fragment_type":"issue_comment","sequence":106,"text":"Maybe not always: as in my previous post, I successfully upgrade to the b2 yesterday and also did a restart in an attempt to reproduce. \nMaybe, it's only the first time that it happens, for some reason?","author_login":"Kraganov","author_association":"NONE","created_at":"2025-03-28T07:15:03+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761116857","fragment_type":"issue_comment","sequence":107,"text":"I think the token is only valid for about 10 minutes. I wonder if this is just bad timing - token nearly expiring when you restart so by the time it's restarted and refreshed the token it's timed-out?\nIs it possible to force a token refresh on shutting down HA?","author_login":"derekoharrow","author_association":"NONE","created_at":"2025-03-28T11:37:22+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761152646","fragment_type":"issue_comment","sequence":108,"text":"I have gotten information about the strict security of the refresh token. It comes down that the reusage of the refresh token is secured in such away that it may not be reused multiple times in a refresh token flow (this is a prevention for stolen refresh tokens). If the OAuth server detects this potential threat, it will log out.\n\nBasically this means if the refresh token is not expired yet and it's being offered multiple times (twice as I understood) to re-authenticate - in the case of a reboot - it will be made invalid and the user has to actually re-authenticate via the offered flow within HA.\n\nEither wait for 30 days when the refresh token expires (keep track on when you first logged in) or accept when you've done multiple reboots within the 30 days you have to go through an actual re-authenticate, simply because Tado secured its login very well. :)\n\nI can tinker along and see in alignment with Tado what can be done, yet I won't give it an enormous high priority - since this is intended security from Tado and we should not interfere with it. In this worst case you need to hold your horses and not reboot daily or accept you need to re-authenticate if you ask for a refresh token too early in a row. :)","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-28T11:55:47+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761160068","fragment_type":"issue_comment","sequence":109,"text":"That sounds eminently reasonable. A small update to this effect in the documentation would suffice","author_login":"jwt99412","author_association":"NONE","created_at":"2025-03-28T11:59:28+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761215811","fragment_type":"issue_comment","sequence":110,"text":"Good point. I will adjust the documentation. 👍 \n \n\nLet me break it down in a _normal flow_ and _refresh too often flow_:\n\n**Normal flow**\n1. You authenticate with Tado and HA obtains an access token and refresh token.\n2. The access token is used in every single call we make with Tado (to fetch data, to set new states, etc.). The access token is only valid for 10 minutes. The refresh token is valid for 30 days after issuing.\n3. If the access token is about to expire, PyTado will detect this 30 seconds ahead before expiration (this is to prevent you as a user run into nasty situations 😉) and it will use the refresh token to obtain a new access token (again, valid for only 10 minutes). This cycle will continue on and on, as long as the refresh token is still valid.\n4. If the refresh token is about to expire, PyTado will detect as well 30 seconds ahead before expiring. It will then ask Tado for a new refresh token to be used. This cycle continues on and on, but simply happens on the background every 30 days.\n5. From this point on, if nothing happens that breaks these tokens (forced logouts from the OAuth server, whatsoever), you have no interference at all and should not have to re-authenticate anytime soon.\n\n**Refresh too often**\nAll steps above apply, where the caveat is in step 4. If you ask for a new refresh too often (twice according to my current understanding) within the expiration period of 30 days, the OAuth server of Tado marks this as _suspicious_. Why would a user ask for a new refresh token multiple if its current one is still active? It might have been stolen. It's a prevention.\nThis behavior can be triggered if you reboot you HA instance multiple times within the 30 day period. Why? Since within HA we store the refresh token to make that persistent and help you out and not require you login with Tado each time you login.\nI don't store the access token within HA (only in the memory of the runtime). Simply for the reason it expires so quickly and serves no other purpose.\n\nAgain, this is what I currently understand of the workings of the OAuth server of Tado. My basic advise for now would be, don't try to reboot unnecessarily if you find the re-authentication annoying. Otherwise, accept the excellent steps we provide in HA to seamlessly re-authenticate you with Tado. 😄","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-28T12:24:12+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761424369","fragment_type":"issue_comment","sequence":111,"text":"Update in docu should also suffice for me. It being an effect of a security feature, is only good news. In the end, having to quickly re-authenticate is not what one would call a \"big deal\". (definitely, because it would only happen when you're working in HA anyway)","author_login":"Kraganov","author_association":"NONE","created_at":"2025-03-28T13:49:47+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761476733","fragment_type":"issue_comment","sequence":112,"text":"Race conditioning is what I believe applies here. The same refresh token is used twice or more, it will automatically logout, from the information I received from an insider.\nFrankly speaking my explanation doesn't stand. When I rush multiple reboots, the same refresh token should be offered it lastly obtained. Yet, not re-authentication is enforced on me.\n\nIf you can share the logging that you can obtain and elaborate the steps you're doing, I might be able to reproduce it and understand better what's causing it. :)","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-28T14:08:25+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2761598486","fragment_type":"issue_comment","sequence":113,"text":"I have to make a rectification here. It's more due to multi threading. I'll look into it.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-03-28T14:52:13+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2763242676","fragment_type":"issue_comment","sequence":114,"text":"With 2025.4.b8 on 2 different instances I get Error 500 The server got itself into trouble. \n\nLog shows:\nPyTado.http :: ERROR :: Failed to refresh token, probably wrong credentials. Status code: 400","author_login":"jelmerkk","author_association":"NONE","created_at":"2025-03-29T09:01:35+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2763243334","fragment_type":"issue_comment","sequence":115,"text":"On the beta instance I removed the integration, there I get this error while trying to add the discovered integration:\n\n File \"/config/custom_components/tado/config_flow.py\", line 85, in _wait_for_login\n await self.hass.async_add_executor_job(self.tado.device_activation)\n File \"/usr/local/lib/python3.13/concurrent/futures/thread.py\", line 59, in run\n result = self.fn(*self.args, **self.kwargs)\n File \"/usr/local/lib/python3.13/site-packages/PyTado/interface/interface.py\", line 99, in device_activation\n self._http.device_activation()\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 554, in device_activation\n if self._check_device_activation():\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 545, in _check_device_activation\n raise TadoException(f\"Login failed. Reason: {token_response.reason}\")\nPyTado.exceptions.TadoException: Login failed. Reason: Bad Request","author_login":"jelmerkk","author_association":"NONE","created_at":"2025-03-29T09:03:12+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764219848","fragment_type":"issue_comment","sequence":116,"text":"@mgmarino thanks for helping the awesome opensource devs on their way here and also kudos for notifying the community.\n\nI would like to mention, as feedback to the Tado company the following:\n\nprobably many (at least me) bought the tado because of the home assistant integration. So I'd assume there is plenty of support coming to tado from this community and you as a company most likely know that.\n\nIn that light, I feel the deprecation notice on an active user base of about 5 weeks is ridiculously short.\nAt the moment, a large amount of users have impact on their automations in their homes. \n\nFor example, in my 5 person household, everyone knows how to use home assistant, but none besides me have the tado app. Yes, we have a physical fallback for manual control, but our automations are now gone.\n\nI understand that Tado supports their own app, and the API might be more of a tinkering thingie, but in light of a vibrant ecosystem with many users that support Tado and their hardware, I feel this is kind of a let down.\n\nBasically, because of a performance issue in the password flow, you gave 5 weeks notice.\n\nIn my opinion, this could have been handled with more time in reserve (arbitrarily, 3 months seems a minimum) to not burden the community and the developers that spend their spare time for this integration.\n\nAll in all this is a hasty decision, with loads of pressure on this community if I read the threads right, with a lot of synchronization with core HA devs, who can probably spend their time better on cool stuff, than dealing with a badly managed deprecation schedule from TAdo.\n\n@mgmarino nothing personal against you of course 👍 \n\nMaybe Tado could help out a bit by giving the devs working overtime on this a bit of extra love, I already see a link asking for this here URL \n\nthanks for listening","author_login":"rolfvreijdenberger","author_association":"NONE","created_at":"2025-03-29T19:50:12+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2764698147","fragment_type":"issue_comment","sequence":117,"text":"@chinezbrun Can you expand on what exactly you did? I run HA in Docker as well. i would really appreciate it. :-)","author_login":"ThomasClaudinger","author_association":"NONE","created_at":"2025-03-30T18:57:14+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2764758604","fragment_type":"issue_comment","sequence":118,"text":"Just install the fix, clearing the browser cache and restart HA. But, I understood that 2025.4 will have the fix :).","author_login":"chinezbrun","author_association":"NONE","created_at":"2025-03-30T21:42:20+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2770522112","fragment_type":"issue_comment","sequence":119,"text":"Seems like issue is fixed with the latest HA update(Core 2025.3.4, Supervisor 2025.03.4, Operating System 15.1).","author_login":"WickTrimmer","author_association":"NONE","created_at":"2025-04-01T19:47:28+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2770565866","fragment_type":"issue_comment","sequence":120,"text":"I've updated to Core: `2025.3.4` (Docker Container) and Tado is blocking the startup of HA in `Initializing` state\n\nIt seems to be blocked on timeouts for HTTP requests originating from the Tado integration:\n\nbash\n File \"/usr/local/lib/python3.13/site-packages/PyTado/http.py\", line 166, in _log_response\n f\"\\n\\tData: {response.json()}\"\n ~~~~~~~~~~~~~^^\n File \"/usr/local/lib/python3.13/site-packages/requests/models.py\", line 974, in json\n return complexjson.loads(self.text, **kwargs)\n ^^^^^^^^^\n File \"/usr/local/lib/python3.13/site-packages/requests/models.py\", line 926, in text\n if not self.content:\n ^^^^^^^^^^^^\n File \"/usr/local/lib/python3.13/site-packages/requests/models.py\", line 902, in content\n self._content = b\"\".join(self.iter_content(CONTENT_CHUNK_SIZE)) or b\"\"\n ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/usr/local/lib/python3.13/site-packages/requests/models.py\", line 826, in generate\n raise ConnectionError(e)\nrequests.exceptions.ConnectionError: HTTPConnectionPool(host='54.170.199.124', port=8080): Read timed out.\n\nIf I try to `curl` that address I seem to get a `200 OK` but the request never returns, just blocks _(maybe normal/maybe not)_:\n\n**tim@raspberrypi:~ $ curl -v URL \n* Trying 54.170.199.124:8080...\n* Connected to 54.170.199.124 (54.170.199.124) port 8080 (#0)\n \n \n \n \n \n* Mark bundle as not supporting multiuse\n< HTTP/1.1 200 OK\n< Content-Length: 9442375\n< Content-Type: application/json\n< Date: Tue, 01 Apr 2025 20:06:50 GMT\n< \n\nGot to CTRL+C here to get back to my shell","author_login":"timvaillancourt","author_association":"NONE","created_at":"2025-04-01T20:08:38+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2770659002","fragment_type":"issue_comment","sequence":121,"text":"Tado has deprecated an authentication method we used on the background. It has been patched and is available in the Beta if you need it urgently. Tomorrow the official release will be shipped which will also contain this fix.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-04-01T20:52:42+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2772648570","fragment_type":"issue_comment","sequence":122,"text":"I just updated;\n\nCore 2025.3.4\nSupervisor 2025.03.4\nOperating System 15.1\n\nWhat do I need to do to re-establish auth between HA and Tado? I tried clicking the \"reconfigure\" on the integration, and then provide my password, but I am getting \"unexpected error\"\n\nImage","author_login":"rpuls","author_association":"NONE","created_at":"2025-04-02T13:56:32+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2772747994","fragment_type":"issue_comment","sequence":123,"text":"@mgmarino quick thanks for taking the time to post the deprecation notice in here - much better than just silently deprecating the login flow.\n\nEveryone who's been working on a fix, likewise, big ❤️","author_login":"lawrencedudley","author_association":"NONE","created_at":"2025-04-02T14:28:45+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2772891087","fragment_type":"issue_comment","sequence":124,"text":"Sounds hopeful ... is this a fix for both Tado legacy and Tado X devices? (right now my legacy devices are working fine with the current beta, but not the X devices).","author_login":"EACourts","author_association":"NONE","created_at":"2025-04-02T15:05:52+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2772912187","fragment_type":"issue_comment","sequence":125,"text":"For Tado X you can apply the fix mentioned above on top of 2025.4, this works for some but let's verify the final version.\n\nOn Wed, Apr 2, 2025, at 17:06, Edwin wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nJelmer Koekkoek\n0649883184 | ***@***.***","author_login":"jelmerkk","author_association":"NONE","created_at":"2025-04-02T15:13:06+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[2853449615],"is_known_query_context":false},{"document_id":"gh_comment_2773382909","fragment_type":"issue_comment","sequence":126,"text":"A big thank YOU to everybody being involved to make it working again. My HA-Docker just restarted the new April-Release AND Tado is working again!!! Hurra!!!","author_login":"gillmar","author_association":"NONE","created_at":"2025-04-02T18:30:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773611844","fragment_type":"issue_comment","sequence":127,"text":"I updated to 2025.4 and want to install the tado integration. My question is: do I need to install the custom integration first or can i add tado without it?","author_login":"HunterX86","author_association":"NONE","created_at":"2025-04-02T20:09:51+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773625001","fragment_type":"issue_comment","sequence":128,"text":"Custom integration was a workaround until 2025.4 was released - no need to install it now","author_login":"pieman3000","author_association":"NONE","created_at":"2025-04-02T20:16:47+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773635234","fragment_type":"issue_comment","sequence":129,"text":"Thanks to everyone who has volunteered their time to help others.\nI haven't received version 2025.4 yet.","author_login":"Kepasub","author_association":"NONE","created_at":"2025-04-02T20:21:39+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773650531","fragment_type":"issue_comment","sequence":130,"text":"I've got 2025.4 and my Tado X is still not working (Tado 3+ in another location is working fine). What do I need to do? Someone mentioned a fix/workaround until a permanent fix is included, but I can't find it.","author_login":"EACourts","author_association":"NONE","created_at":"2025-04-02T20:27:45+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773653010","fragment_type":"issue_comment","sequence":131,"text":"Thanks so much to all the developers and testers!!\n\nDo we need to remove the custom integration iow the work around before installing the core component ?","author_login":"Aham330","author_association":"NONE","created_at":"2025-04-02T20:29:06+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773701827","fragment_type":"issue_comment","sequence":132,"text":"Thanks again to everyone who has volunteered their time to help others.\nI've already received version 2025.4, and the integration (I had deleted the previous one) worked perfectly.","author_login":"Kepasub","author_association":"NONE","created_at":"2025-04-02T20:46:20+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773712779","fragment_type":"issue_comment","sequence":133,"text":"thanks for all the hard work and to everyone who has worked on this.\nIntegration asked for new device authentication flow and everything is well again 👍 \nThanks again!","author_login":"rolfvreijdenberger","author_association":"NONE","created_at":"2025-04-02T20:52:03+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773732495","fragment_type":"issue_comment","sequence":134,"text":"A quick fix for me, at this point running HA in Docker, was to change the image-tag from stable to \"2025.4\". \n\nAfter updating, HA showed an error message that Tado authentication were put of date. Now I re-authenticated tado and everything is working again.\n\nI'll change it back to stable once 2025.4 is considered the stable version.","author_login":"ThomasClaudinger","author_association":"NONE","created_at":"2025-04-02T20:59:55+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773800002","fragment_type":"issue_comment","sequence":135,"text":"Then you need to put back in the custom component that takes care of the Tado X. It's not supported in the default integration, yet. :)","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-04-02T21:39:48+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2773802207","fragment_type":"issue_comment","sequence":136,"text":"can you give me the link and the instructions on how to do that?","author_login":"HunterX86","author_association":"NONE","created_at":"2025-04-02T21:41:17+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2774544069","fragment_type":"issue_comment","sequence":137,"text":"I still have the config flow 500 error when I try to add Tado back again, any tips on how to solve? Running the latest 2025.4 version of HA.","author_login":"mariobrosch","author_association":"NONE","created_at":"2025-04-03T05:37:30+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2774871435","fragment_type":"issue_comment","sequence":138,"text":"Hi @erwindouna,\n\nThanks for all the work on this. I have asked before but did not see an answer so maybe it got lost in the many posts here. \n\nIn the merged \"Tado migrate to OAuth Device Flow #140761\" you mentioned to remove `rm -rf /config/custom_components/tado` the temporary custom tado integration when updating to 2025.4.0. Is this still applicable or do we just update as is?\n\nthanks in advance.","author_login":"Aham330","author_association":"NONE","created_at":"2025-04-03T08:25:51+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2774877115","fragment_type":"issue_comment","sequence":139,"text":"You need to do this if you have the custom integration installed, if not then you can update as normal.","author_login":"pieman3000","author_association":"NONE","created_at":"2025-04-03T08:28:05+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2775337499","fragment_type":"issue_comment","sequence":140,"text":"I can also confirm that authentication works now after upgrading to 2025.4.0.","author_login":"kasabov","author_association":"NONE","created_at":"2025-04-03T10:51:22+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2775374226","fragment_type":"issue_comment","sequence":141,"text":"Same here. It works now after updating to HAOS 15.1 and Core 2025.4.0.\nThank you so much for all the good work 👍","author_login":"PunzIII","author_association":"NONE","created_at":"2025-04-03T10:57:03+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2775591905","fragment_type":"issue_comment","sequence":142,"text":"Hallo zusammen, besten Dank für die sehr gute Arbeit. Mit OS 15.1 und Core 2025.04 ist auch bei uns das Problem gelöst. 👍","author_login":"wb1958","author_association":"NONE","created_at":"2025-04-03T12:12:16+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2775821739","fragment_type":"issue_comment","sequence":143,"text":"Yea, same here +1.\nVery impressive that you guys manage to get a fix live with the official release, considering how short that deprecation notice was. 💪","author_login":"rpuls","author_association":"NONE","created_at":"2025-04-03T13:37:28+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2776769608","fragment_type":"issue_comment","sequence":144,"text":"Update also brought my Tados back - thanks to the team for fixing this under such time pressure!","author_login":"defux-23","author_association":"NONE","created_at":"2025-04-03T19:47:20+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2777746658","fragment_type":"issue_comment","sequence":145,"text":"I disagree. It still doesn't work out of the box for Tado X, which needs a workaround to make it function correctly.","author_login":"EACourts","author_association":"NONE","created_at":"2025-04-04T07:13:51+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2777834625","fragment_type":"issue_comment","sequence":146,"text":"Unfortunately TadoX support requires a rewrite of PyTado which is happening (but taking time) but is not part of this OAuth change. TadoX was not supported before either.","author_login":"jelmerkk","author_association":"NONE","created_at":"2025-04-04T07:43:02+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2779615764","fragment_type":"issue_comment","sequence":147,"text":"@EACourts you can track Tado X progress in the library in this issue URL \n\nI'm sure HA support will shortly follow after that's closed","author_login":"inverse","author_association":"CONTRIBUTOR","created_at":"2025-04-04T19:52:25+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781494523","fragment_type":"issue_comment","sequence":148,"text":"Hot working for me :( I've tried thte workaround but I continue to get an error:\n\nImage\n\nand I cannot ignore it","author_login":"msavazzi","author_association":"CONTRIBUTOR","created_at":"2025-04-06T16:12:27+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781495760","fragment_type":"issue_comment","sequence":149,"text":"I removed everything, reboot: \n\nImage\n\nImage\n\nnothing happens :(\n\nlatest version:\n\nImage","author_login":"msavazzi","author_association":"CONTRIBUTOR","created_at":"2025-04-06T16:15:45+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781510812","fragment_type":"issue_comment","sequence":150,"text":"Do a hard refresh of your frontend with CTRL + F5. That should load in the strings for this part of the autehniciaton.","author_login":"erwindouna","author_association":"CONTRIBUTOR","created_at":"2025-04-06T16:55:32+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2781605202","fragment_type":"issue_comment","sequence":151,"text":"Same here.\nMy TadoX was working with the custom component but has been broken by the latest HA update. I've tried it with and without the custom component but the problem is the same - when I try to configure it I get a white box titled \"Tado\" with a never-ending rotating circle. \nA previously configured Tado V3+ continues to work fine.","author_login":"EACourts","author_association":"NONE","created_at":"2025-04-06T19:41:03+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2785358637","fragment_type":"issue_comment","sequence":152,"text":"Hello,\n\nI still have problems with the Tado integration. \nAfter a reboot of the Home Assistant I have to log in again regularly. \nI have reinstalled the integration, but the problem remains. \nDid I miss something, do I need to do something else?\n\nImage","author_login":"willsmarthome","author_association":"NONE","created_at":"2025-04-08T06:25:01+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2785362892","fragment_type":"issue_comment","sequence":153,"text":"If you have Tado X, stop trying, the custom component is not working properly after an update and needs a lot if tricky stuff to get it to work again after every update. I stopped trying and waiting for the full support by default","author_login":"mariobrosch","author_association":"NONE","created_at":"2025-04-08T06:27:29+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2808996680","fragment_type":"issue_comment","sequence":154,"text":"For reference, I do have Tado X working on the latest Home Assistant version using the custom component from @dmho.\n\n \n\nAt some point after a Home Assistant update, Tado became unauthenticated for me. To fix it, I went through the auth process manually using the link from Developer Tools (since the UI was stuck on a loading screen when I tried to re-authenticate).\n\nImage\n\nThis workaround has kept Tado X working for me so far!","author_login":"polamoros","author_association":"NONE","created_at":"2025-04-16T09:40:47+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2841239614","fragment_type":"issue_comment","sequence":155,"text":"This has worked for me too. I was wondering if it even NEEDs the custom component?\nThe only problem I have is that I need to re-authenticate Tado after every reboot or update of HA, which can be quite often.","author_login":"EACourts","author_association":"NONE","created_at":"2025-04-30T08:38:55+08:00","repo_name":"home-assistant/core","issue_id":2853449615,"issue_number":138518,"issue_url":"https://github.com/home-assistant/core/issues/138518","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0023","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Can't add FirefoxPWA's patched Firefox.app into filtered applications?","query_context":"FirefoxPWA is a way to install PWA as an app with Firefox. On macOS, it downloads a separate instance of Firefox to ~/Library/Application Support/firefoxpwa/runtime/Firefox.app, and patches the binary to do some additional magic for PWA to work. However, I'm not able to add this Firefox.app into filtered applications, so I'm seeing many ads.\n\n### Steps to reproduce\n1. Install FirefoxPWA's extension as well as the native counterpart (via Homebrew on macOS)\n2. Create a PWA with it\n3. Try to add the patched Firefox.app into filtered applications\n\n### Expected behavior\nThe separate, patched Firefox.app should be added to the list, and filtering should work\n\n### Actual behavior\nThe app is not added to the list and filtering is not working. AdGuard instead highlights the original Firefox.app in the list, which locates in /Applications/Firefox.app, as if they're the same one, but they're not.\n\nThen I tried adding the PWA app it creates in ~/Applications (for example ~/Applications/Spotify.app) into filtered applications. It showed up in the list, but the ads are still not filtered this way, so I think being able to add that patched Firefox.app is the key.\n\nFinally I granted AdGuard full disk access then retried, but it doesn't work. And I tried trashing the original Firefox.app & delete its entry from the list before adding the patched one. It did show up in the list this way, but filtering is still not working.\n\n### Customer ID \nNot seeing a \"Customer ID\" in the email reply? Ticket number is 554896. Or is it this strange string at the end? -> [X7LYQM-557Q] \n\n### Your environment\n* Environment name and version: Firefox 94.0.1, macOS 12.0.1\n* Any specific potentially conflicting software installed: LuLu firewall","known_context_document_ids":["gh_issue_1059360875"],"reference_answer":"I'm pretty late because I didn't have much time. Anyway, I tried doing this but it doesn't work for me. It appears the executable does not see variables set in `LSEnvironment`, so the app cannot start.\n\nApparently `LSEnvironment` by processes started via \"Launch Services\" and not via terminal (source?). However, it also does not work for me when I try to launch it from Launchpad. Maybe it's because I'm using the old macOS 10.15.7 (the latest I could install into VM)? But in any case, I would like if launching from the terminal (using `firefoxpwa site launch` and `open`) would also work.\n\nIs there any more reliable way of setting environment variables for a bundle? Or, is `swiftc` included in standard macOS out-of-the-box? This isn't the nicest solution, but maybe PWAsForFirefox could compile a new executable when installing each PWA and include `exePath` and `pwaId` directly in the source code.","answer_document_id":"gh_comment_1171110512","silver_evidence_path":["gh_comment_1041771721","gh_issue_1140099939","gh_comment_1171110512"],"evidence_issue_ids":[1059360875,1140099939],"source_repo_name":"AdguardTeam/AdguardForMac","source_issue_id":1059360875,"source_issue_number":993,"source_issue_url":"https://github.com/AdguardTeam/AdguardForMac/issues/993","target_repo_name":"filips123/PWAsForFirefox","target_issue_id":1140099939,"target_issue_number":131,"target_issue_url":"https://github.com/filips123/PWAsForFirefox/issues/131","reference_anchor_document_id":"gh_comment_1041771721","reference_answer_author":"filips123","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2647,"anchor_target_overlap":0.2941,"target_answer_overlap":0.2319},"issue_created_at":"2021-11-21T11:58:12+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_1059360875","fragment_type":"issue_description","sequence":0,"text":"Can't add FirefoxPWA's patched Firefox.app into filtered applications\nFirefoxPWA is a way to install PWA as an app with Firefox. On macOS, it downloads a separate instance of Firefox to ~/Library/Application Support/firefoxpwa/runtime/Firefox.app, and patches the binary to do some additional magic for PWA to work. However, I'm not able to add this Firefox.app into filtered applications, so I'm seeing many ads.\n\n### Steps to reproduce\n1. Install FirefoxPWA's extension as well as the native counterpart (via Homebrew on macOS)\n2. Create a PWA with it\n3. Try to add the patched Firefox.app into filtered applications\n\n### Expected behavior\nThe separate, patched Firefox.app should be added to the list, and filtering should work\n\n### Actual behavior\nThe app is not added to the list and filtering is not working. AdGuard instead highlights the original Firefox.app in the list, which locates in /Applications/Firefox.app, as if they're the same one, but they're not.\n\nThen I tried adding the PWA app it creates in ~/Applications (for example ~/Applications/Spotify.app) into filtered applications. It showed up in the list, but the ads are still not filtered this way, so I think being able to add that patched Firefox.app is the key.\n\nFinally I granted AdGuard full disk access then retried, but it doesn't work. And I tried trashing the original Firefox.app & delete its entry from the list before adding the patched one. It did show up in the list this way, but filtering is still not working.\n\n### Customer ID \nNot seeing a \"Customer ID\" in the email reply? Ticket number is 554896. Or is it this strange string at the end? -> [X7LYQM-557Q] \n\n### Your environment\n* Environment name and version: Firefox 94.0.1, macOS 12.0.1\n* Any specific potentially conflicting software installed: LuLu firewall","author_login":"wzxu","author_association":"NONE","created_at":"2021-11-21T11:58:12+08:00","repo_name":"AdguardTeam/AdguardForMac","issue_id":1059360875,"issue_number":993,"issue_url":"https://github.com/AdguardTeam/AdguardForMac/issues/993","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1041771721","fragment_type":"issue_comment","sequence":1,"text":"Hello there!\n\nThe impossibility of filtering PWA apps is due to the way the FirefoxPWA solution is implemented. We have opened an issue.\n\nThe original Firefox.app and the patched Firefox.app are the same from the point of view of the system, since they have the same bundle identifier. You can see it visually as follows:\n\n1. Set the original Firefox.app as the default browser\n2. Delete original Firefox.app\n3. Perform an action that should open the default browser.\n \nThe patched Firefox.app will open.","author_login":"dakuzmin69","author_association":"NONE","created_at":"2022-02-16T15:44:27+08:00","repo_name":"AdguardTeam/AdguardForMac","issue_id":1059360875,"issue_number":993,"issue_url":"https://github.com/AdguardTeam/AdguardForMac/issues/993","linked_issue_ids":[1140099939],"is_known_query_context":false},{"document_id":"gh_comment_1043307538","fragment_type":"issue_comment","sequence":2,"text":"Thanks a lot for the explanation and opening the issue there! Will be keeping an eye on it 👀","author_login":"wzxu","author_association":"NONE","created_at":"2022-02-17T19:00:08+08:00","repo_name":"AdguardTeam/AdguardForMac","issue_id":1059360875,"issue_number":993,"issue_url":"https://github.com/AdguardTeam/AdguardForMac/issues/993","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1140099939","fragment_type":"issue_description","sequence":0,"text":"Change the way the final PWA app is formed on macOS\n### Problem Description\n\nAdGuard can't filter PWA due to the way PWAsForFirefox generates the executable for the PWA application.\n\n### Proposed Solution\n\nThe most preferred way is to replace the script with a real executable binary file.\nThis is a simple example source code for an executable.\n\nimport Foundation\n\nlet exePath = ProcessInfo.processInfo.environment[\"exePath\"]!\nlet pwaId = ProcessInfo.processInfo.environment[\"pwaId\"]!\n\nlet task = Process()\ntask.launchPath = exePath\ntask.arguments = [\"site\", \"launch\", \"--direct-launch\", pwaId, \"\\\"$@\\\"\"]\ntask.launch()\ntask.waitUntilExit()\n\nIn order for the updated environment to be detected by the process, it is necessary to make changes to the info.plist file by adding the following lines there.\n\n LSEnvironment \n \n exePath \n /path/to/firefoxpwa \n pwaId \n PWAID \n \n\n### Additional Information\n\nI tested this solution, it works fine.\nThe executable file was compiled using swiftc, after that I replaced the original executable with my executable and modified the info.plist file.","author_login":"dakuzmin69","author_association":"NONE","created_at":"2022-02-16T14:33:06+08:00","repo_name":"filips123/PWAsForFirefox","issue_id":1140099939,"issue_number":131,"issue_url":"https://github.com/filips123/PWAsForFirefox/issues/131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1171110512","fragment_type":"issue_comment","sequence":1,"text":"I'm pretty late because I didn't have much time. Anyway, I tried doing this but it doesn't work for me. It appears the executable does not see variables set in `LSEnvironment`, so the app cannot start.\n\nApparently `LSEnvironment` by processes started via \"Launch Services\" and not via terminal (source?). However, it also does not work for me when I try to launch it from Launchpad. Maybe it's because I'm using the old macOS 10.15.7 (the latest I could install into VM)? But in any case, I would like if launching from the terminal (using `firefoxpwa site launch` and `open`) would also work.\n\nIs there any more reliable way of setting environment variables for a bundle? Or, is `swiftc` included in standard macOS out-of-the-box? This isn't the nicest solution, but maybe PWAsForFirefox could compile a new executable when installing each PWA and include `exePath` and `pwaId` directly in the source code.","author_login":"filips123","author_association":"OWNER","created_at":"2022-06-30T11:37:13+08:00","repo_name":"filips123/PWAsForFirefox","issue_id":1140099939,"issue_number":131,"issue_url":"https://github.com/filips123/PWAsForFirefox/issues/131","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0024","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Can't do mkltfs on HP StorageWorks Trivium 3000?","query_context":"Hello.\n\nI've compiled LTFS using manual in README on my Debian 11 Bullseye (Linux 5.13.19-2-pve #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) x86_64 GNU/Linux)\n\nThe device is HP StorageWorks Ultrium 3000 SAS, cartridges are Sony LTX1500G\n\n`ltfs -o device_list` shows connected hardware:\n\n885 LTFS14000I LTFS starting, LTFS version 2.5.0.0 (Prelim), log level 2.\n885 LTFS14058I LTFS Format Specification version 2.4.0.\n885 LTFS14104I Launched by \"ltfs -o device_list\".\n885 LTFS14105I This binary is built for Linux (x86_64).\n885 LTFS14106I GCC version is 10.2.1 20210110.\n885 LTFS17087I Kernel version: Linux version 5.13.19-2-pve (build@proxmox) (gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) i386.\n885 LTFS17089I Distribution: PRETTY_NAME=\"Debian GNU/Linux 11 (bullseye)\".\n885 LTFS17085I Plugin: Loading \"sg\" tape backend.\nTape Device list:.\nDevice Name = /dev/sg1 (0.0.0.0), Vendor ID = HP , Product ID = Ultrium 5-SCSI , Serial Number = HUJ011CW59, Product Name =[Ultrium 5-SCSI].\n\nBut when I try to do mkltfs, I'm getting the following error:\n\nroot@office:~# mkltfs -d /dev/sg1\nLTFS15000I Starting mkltfs, LTFS version 2.5.0.0 (Prelim), log level 2.\nLTFS15041I Launched by \"mkltfs -d /dev/sg1\".\nLTFS15042I This binary is built for Linux (x86_64).\nLTFS15043I GCC version is 10.2.1 20210110.\nLTFS17087I Kernel version: Linux version 5.13.19-2-pve (build@proxmox) (gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) i386.\nLTFS17089I Distribution: PRETTY_NAME=\"Debian GNU/Linux 11 (bullseye)\".\nLTFS15003I Formatting device '/dev/sg1'.\nLTFS15004I LTFS volume blocksize: 524288.\nLTFS15005I Index partition placement policy: None.\n\nLTFS11337I Update index-dirty flag (1) - NO_BARCODE (0x0x56531f111be0).\nLTFS17085I Plugin: Loading \"sg\" tape backend.\nLTFS30209I Opening a device through sg-ibmtape driver (/dev/sg1).\nLTFS30250I Opened the SCSI tape device 0.0.0.0 (/dev/sg1).\nLTFS30207I Vendor ID is HP .\nLTFS30208I Product ID is Ultrium 5-SCSI .\nLTFS30214I Firmware revision is Z6MW.\nLTFS30215I Drive serial is HUJ011CW59.\nLTFS30285I The reserved buffer size of /dev/sg1 is 524288.\nLTFS30294I Setting up timeout values from RSOC.\nLTFS17160I Maximum device block size is 1048576.\nLTFS11330I Loading cartridge.\nLTFS39805W The timeout table is not configured: SCSI OP code 0x4d. Use the default timeout.\nLTFS11332I Load successful.\nLTFS39805W The timeout table is not configured: SCSI OP code 0x4d. Use the default timeout.\nLTFS17157I Changing the drive setting to write-anywhere mode.\nLTFS15049I Checking the medium (mount).\nLTFS39805W The timeout table is not configured: SCSI OP code 0x4d. Use the default timeout.\nLTFS30205I LOCATE (0x92) returns -20802.\nLTFS30263I LOCATE returns End-of-Data (EOD) not found (-20802) /dev/sg1.\nLTFS12037E Cannot seek: backend call failed (-20802).\nLTFS11006E Cannot read volume: failed to load the tape.\nLTFS30205I MODESELECT (0x55) returns -20500.\nLTFS30263I MODESELECT returns Invalid Field in Parameter List (-20500) /dev/sg1.\nLTFS15023I Formatting failed.\n\nMaybe you have any ideas what's the problem? The cartridges & streamer are absolutely new","known_context_document_ids":["gh_issue_1137558436"],"reference_answer":"Yes. But the alternative is to use /dev/nst* instead. `nst` device never issue `REWIND` at open/close.\n\nAnother point is to add `-o eject` option to LTFS for a safeguard. Basically LTFS tries to use `append only mode` of IBM drives. But the `append only mode` only can clear when the tape is ejected from the drive spec. So LTFS only uses the `append only mode` when `-o eject`. Because historically default behavior is keep the tape on drive at unmount, so it is no chance to disable the `append only mode`. (May be it is a good timing to consider to change default behavior...)\n\nAnyway, you can avoid data corruption because of `REWIND` from another path if you add `-o eject` in the command line. But you may receive an write error (and goes to R/O mode) when `REWIND` from another path happens.","answer_document_id":"gh_comment_530654792","silver_evidence_path":["gh_comment_1040055293","gh_issue_491189983","gh_comment_530654792"],"evidence_issue_ids":[1137558436,491189983],"source_repo_name":"LinearTapeFileSystem/ltfs","source_issue_id":1137558436,"source_issue_number":336,"source_issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/336","target_repo_name":"LinearTapeFileSystem/ltfs","target_issue_id":491189983,"target_issue_number":157,"target_issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","reference_anchor_document_id":"gh_comment_1040055293","reference_answer_author":"piste-jp-ibm","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2222,"target_answer_overlap":0.1429},"issue_created_at":"2022-02-14T16:38:06+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1137558436","fragment_type":"issue_description","sequence":0,"text":"Can't do mkltfs on HP StorageWorks Trivium 3000\nHello.\n\nI've compiled LTFS using manual in README on my Debian 11 Bullseye (Linux 5.13.19-2-pve #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) x86_64 GNU/Linux)\n\nThe device is HP StorageWorks Ultrium 3000 SAS, cartridges are Sony LTX1500G\n\n`ltfs -o device_list` shows connected hardware:\n\n885 LTFS14000I LTFS starting, LTFS version 2.5.0.0 (Prelim), log level 2.\n885 LTFS14058I LTFS Format Specification version 2.4.0.\n885 LTFS14104I Launched by \"ltfs -o device_list\".\n885 LTFS14105I This binary is built for Linux (x86_64).\n885 LTFS14106I GCC version is 10.2.1 20210110.\n885 LTFS17087I Kernel version: Linux version 5.13.19-2-pve (build@proxmox) (gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) i386.\n885 LTFS17089I Distribution: PRETTY_NAME=\"Debian GNU/Linux 11 (bullseye)\".\n885 LTFS17085I Plugin: Loading \"sg\" tape backend.\nTape Device list:.\nDevice Name = /dev/sg1 (0.0.0.0), Vendor ID = HP , Product ID = Ultrium 5-SCSI , Serial Number = HUJ011CW59, Product Name =[Ultrium 5-SCSI].\n\nBut when I try to do mkltfs, I'm getting the following error:\n\nroot@office:~# mkltfs -d /dev/sg1\nLTFS15000I Starting mkltfs, LTFS version 2.5.0.0 (Prelim), log level 2.\nLTFS15041I Launched by \"mkltfs -d /dev/sg1\".\nLTFS15042I This binary is built for Linux (x86_64).\nLTFS15043I GCC version is 10.2.1 20210110.\nLTFS17087I Kernel version: Linux version 5.13.19-2-pve (build@proxmox) (gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) i386.\nLTFS17089I Distribution: PRETTY_NAME=\"Debian GNU/Linux 11 (bullseye)\".\nLTFS15003I Formatting device '/dev/sg1'.\nLTFS15004I LTFS volume blocksize: 524288.\nLTFS15005I Index partition placement policy: None.\n\nLTFS11337I Update index-dirty flag (1) - NO_BARCODE (0x0x56531f111be0).\nLTFS17085I Plugin: Loading \"sg\" tape backend.\nLTFS30209I Opening a device through sg-ibmtape driver (/dev/sg1).\nLTFS30250I Opened the SCSI tape device 0.0.0.0 (/dev/sg1).\nLTFS30207I Vendor ID is HP .\nLTFS30208I Product ID is Ultrium 5-SCSI .\nLTFS30214I Firmware revision is Z6MW.\nLTFS30215I Drive serial is HUJ011CW59.\nLTFS30285I The reserved buffer size of /dev/sg1 is 524288.\nLTFS30294I Setting up timeout values from RSOC.\nLTFS17160I Maximum device block size is 1048576.\nLTFS11330I Loading cartridge.\nLTFS39805W The timeout table is not configured: SCSI OP code 0x4d. Use the default timeout.\nLTFS11332I Load successful.\nLTFS39805W The timeout table is not configured: SCSI OP code 0x4d. Use the default timeout.\nLTFS17157I Changing the drive setting to write-anywhere mode.\nLTFS15049I Checking the medium (mount).\nLTFS39805W The timeout table is not configured: SCSI OP code 0x4d. Use the default timeout.\nLTFS30205I LOCATE (0x92) returns -20802.\nLTFS30263I LOCATE returns End-of-Data (EOD) not found (-20802) /dev/sg1.\nLTFS12037E Cannot seek: backend call failed (-20802).\nLTFS11006E Cannot read volume: failed to load the tape.\nLTFS30205I MODESELECT (0x55) returns -20500.\nLTFS30263I MODESELECT returns Invalid Field in Parameter List (-20500) /dev/sg1.\nLTFS15023I Formatting failed.\n\nMaybe you have any ideas what's the problem? The cartridges & streamer are absolutely new","author_login":"D13410N3","author_association":"NONE","created_at":"2022-02-14T16:38:06+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":1137558436,"issue_number":336,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/336","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1039752507","fragment_type":"issue_comment","sequence":1,"text":"Hmm, it's interesting... Is this tape really brand new?\n\nThe `mkltfs` checks the tape was already formatted or not before formatting it. Normally, the `mkltfs` checks there are two partitions format and then tries to mount the tape for checking. There are two funny points in this case.\n\n1. The `mkltfs` didn't detect non-partitioned tape at all. Is this tape really brand new?\n2. The `mkltfs` tried to seek to the end of data but the drive returned an error `End-of-Data (EOD) not found`. This is clearly drive fault if this tape really brand new. It shall find a EOD at the beginning of the tape.\n\nYou can use `--force` option to skip the LTFS format check if it is sure you can erase everything of this tape.","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2022-02-15T01:26:06+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":1137558436,"issue_number":336,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/336","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1039994719","fragment_type":"issue_comment","sequence":2,"text":"Yes, it's absolutely new - unpacked it some days ago.\n\nTried to use `--force` argument (but not sure if in the right way, no I see another error\n\nroot@office:~# mkltfs -d /dev/sg --force\nLTFS15000I Starting mkltfs, LTFS version 2.5.0.0 (Prelim), log level 2.\nLTFS15041I Launched by \"mkltfs -d /dev/sg --force\".\nLTFS15042I This binary is built for Linux (x86_64).\nLTFS15043I GCC version is 10.2.1 20210110.\nLTFS17087I Kernel version: Linux version 5.13.19-2-pve (build@proxmox) (gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP PVE 5.13.19-4 (Mon, 29 Nov 2021 12:10:09 +0100) i386.\nLTFS17089I Distribution: PRETTY_NAME=\"Debian GNU/Linux 11 (bullseye)\".\nLTFS15003I Formatting device '/dev/sg'.\nLTFS15004I LTFS volume blocksize: 524288.\nLTFS15005I Index partition placement policy: None.\n\nLTFS11337I Update index-dirty flag (1) - NO_BARCODE (0x0x565238a7fc20).\nLTFS17085I Plugin: Loading \"sg\" tape backend.\nLTFS30209I Opening a device through sg-ibmtape driver (/dev/sg).\nLTFS30288I Opening a tape device for drive serial /dev/sg.\nLTFS12012E Cannot open device: failed backend open call.\nLTFS15009E Cannot open device '/dev/sg' (-21711).\nLTFS15023I Formatting failed.","author_login":"D13410N3","author_association":"NONE","created_at":"2022-02-15T08:30:12+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":1137558436,"issue_number":336,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/336","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040055293","fragment_type":"issue_comment","sequence":3,"text":"I believe it is a known HBA issue. Need to recompile with `--enable-buggy-ifs`.\n\nSee #157 and URL","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2022-02-15T09:36:49+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":1137558436,"issue_number":336,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/336","linked_issue_ids":[491189983],"is_known_query_context":false},{"document_id":"gh_comment_1040086767","fragment_type":"issue_comment","sequence":4,"text":"Recompiled. Thanks for your answer, it really helped!\n\nroot@office:/opt/ltfs# df -h | grep ltfs\nltfs:HUJ011CW59 1.4T 0 1.4T 0% /ltfs","author_login":"D13410N3","author_association":"NONE","created_at":"2022-02-15T10:09:33+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":1137558436,"issue_number":336,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/336","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_491189983","fragment_type":"issue_description","sequence":0,"text":"Problems mounting tapes\nAll of a sudden, I'm having trouble mounting both of my tapes (which mounted before successfully). This is what I'm seeing:\n\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14000I LTFS starting, LTFS version 2.4.1.1 (10227), log level 3.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14058I LTFS Format Specification version 2.4.0.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14104I Launched by \"ltfs -o devname=/dev/sg3 /opt/VS/vsMounts/000025L7 -o trace\".\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14105I This binary is built for Linux (x86_64).\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14106I GCC version is 6.3.0 20170516.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS17087I Kernel version: Linux version 4.20.11 (root@debian) (gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)) #1 SMP Thu Feb 21 09:13:14 EST 2019 i386.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS17089I Distribution: PRETTY_NAME=\"Debian GNU/Linux 9 (stretch)\".\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14063I Sync type is \"time\", Sync time is 300 sec.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS17085I Plugin: Loading \"sg\" tape backend.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS17085I Plugin: Loading \"unified\" iosched backend.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS14095I Set the tape device write-anywhere mode to avoid cartridge ejection.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30209I Opening a device through sg-ibmtape driver (/dev/sg3).\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30207I Vendor ID is IBM .\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30208I Product ID is ULTRIUM-HH7 .\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30214I Firmware revision is JAY1.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30215I Drive serial is 10WT074468.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS17160I Maximum device block size is 1048576.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS11330I Loading cartridge.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30252I Logical block protection is disabled.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS11332I Load successful.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS17157I Changing the drive setting to write-anywhere mode.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS11005I Mounting the volume.\nSep 9 07:34:15 alice2 ltfs[25588]: 63f4 LTFS30252I Logical block protection is disabled.\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS30216W Length mismatch is detected. (Act = 4096, resid = 0, resid_sense = -520192).\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS30216W Length mismatch is detected. (Act = 4096, resid = 0, resid_sense = -520192).\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS12049E Cannot read: backend call failed (-21716).\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS11174E Cannot read ANSI label: read failed (-21716).\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS11171E Failed to read label (-21716) from partition 1.\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS11009E Cannot read volume: failed to read partition labels.\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS14013E Cannot mount the volume.\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS30252I Logical block protection is disabled.\n\nIt doesn't look like `--enable-buggy-ifs` would help in this case as it seems to be an overrun.\n\nHBA is:\n\n06:08.0 SCSI storage controller: LSI Logic / Symbios Logic SAS1068 PCI-X Fusion-MPT SAS (rev 01)","author_login":"swt2c","author_association":"CONTRIBUTOR","created_at":"2019-09-09T16:08:45+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_529731439","fragment_type":"issue_comment","sequence":1,"text":"I don't think `--enable-buggy-ifs` is effective in this binary. Because `LTFS30216W` is logged only when `SUPPORT_BUGGY_IFS` is not defined.\n\nSep 9 07:34:21 alice2 ltfs[25588]: 63f4 LTFS30216W Length mismatch is detected. (Act = 4096, resid = 0, resid_sense = -520192).\n\n URL \n\nCould you confirm `-DSUPPORT_BUGGY_IFS` is added in the build process of LTFS?","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2019-09-10T01:39:30+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_529746617","fragment_type":"issue_comment","sequence":2,"text":"`SUPPORT_BUGGY_IFS` is NOT enabled in this case. I mentioned `SUPPORT_BUGGY_LFS` because I don't think it will help me in this case, because `diff_len < 0` so it would just fail anyway with `-EDEV_OVERRUN` instead of `-EDEV_LENGTH_MISMATCH`.","author_login":"swt2c","author_association":"CONTRIBUTOR","created_at":"2019-09-10T02:53:15+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_529791931","fragment_type":"issue_comment","sequence":3,"text":"Thank you for your clarification. I got your point.\n\nCould you put the log with `-o verbose=606`? LTFS may log more detail.","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2019-09-10T06:32:14+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530230200","fragment_type":"issue_comment","sequence":4,"text":"It looks there is no chance to support this HBA. LTFS tried to read rec #0 (VOL1 = 80 bytes) but there is no chance to detect the read record is 80-byte long from returned information... \n\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30201D CDB check condition: sense = 000000, No Additional Sense Information.\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30204D READ (0x08) expected error -20000.\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30216W Length mismatch is detected. (Act = 4096, resid = 0, resid_sense = -520192).","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2019-09-11T05:49:07+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530232412","fragment_type":"issue_comment","sequence":5,"text":"I strongly recommend to use newer and famous HBA. \n\nBut I saw similar issues in the past. I cannot grantee anything but you can try on your risk. (Again I cannot guarantee even if you crash this HBA on the methods below...)\n\n1. Some RAID supported adapters (I don't remember the parts number) make a funny behhavior against tape device when RAID feature is on. You can try this HBA with RAID feature off\n2. I think this HBA is used on VM as a virtual HBA to bridge physical HBA on the machine. If so, you can to use iSCSI instead\n3. You might have some `TAPE SUPPORT` switch on the configuration utility of the HBA if you are lucky\n4. You may have latest firmware of the HBA. The latest firmware may help you if you are lucky","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2019-09-11T05:58:12+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530370431","fragment_type":"issue_comment","sequence":6,"text":"Yes, we've heard that RAID supported adapters do not work well with tape drives. We have another HBA on order.\n\nDo you have a list of recommended HBAs that work well with LTFS?","author_login":"swt2c","author_association":"CONTRIBUTOR","created_at":"2019-09-11T13:04:11+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530641833","fragment_type":"issue_comment","sequence":7,"text":"I'm sorry, I have realized my previous analysis is wrong... The HBA may be not bad...\n\nOn partition 0, LTFS can receive residual length like \n\nSep 10 06:37:32 alice2 ltfs[21640]: 5488 LTFS30398D Backend readpos: (0, 0) FM = 0 10WT074468.\nSep 10 06:37:32 alice2 ltfs[21640]: 5488 LTFS39801D SCSI timeout (op_code 0x08, timeout = 2340).\nSep 10 06:37:33 alice2 ltfs[21640]: 5488 LTFS30201D CDB check condition: sense = 000000, No Additional Sense Information.\nSep 10 06:37:33 alice2 ltfs[21640]: 5488 LTFS30204D READ (0x08) expected error -20000.\nSep 10 06:37:33 alice2 ltfs[21640]: 5488 LTFS30218D Read block: underrun in illegal length. residual = 4016, actual = 80.\nSep 10 06:37:33 alice2 ltfs[21640]: 5488 LTFS30395D Backend read: 4096 bytes 10WT074468.\n\nBut LTFS detects overrun condition on partition 1.\n\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30398D Backend readpos: (1, 0) FM = 0 10WT074468.\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS39801D SCSI timeout (op_code 0x08, timeout = 2340).\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30201D CDB check condition: sense = 000000, No Additional Sense Information.\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30204D READ (0x08) expected error -20000.\nSep 10 06:37:38 alice2 ltfs[21640]: 5488 LTFS30216W Length mismatch is detected. (Act = 4096, resid = 0, resid_sense = -520192).\n\nFrom the residual information, actual read is 4096 and remaining length is 520192. So teh record length on the tape shall 4096 + 520192 = 524288 (512 * 1024).\n\nI believe LTFS wrote the data at the beginning of partiton1 while it's writing a file. The only possibility come up to my mind is someone opened /dev/st? while LTFS is running. It may rewind the tape in the middle of LTFS operations.\n\nLTFS uses a data protection mechanism of the drive when it can be used. But it may not be enabled in this case.","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2019-09-12T02:46:59+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530650573","fragment_type":"issue_comment","sequence":8,"text":"Oh. That actually may be a possibility. The system I'm working with will periodically open the tape device to check the serial number, etc. Originally it was using /dev/sg?, but that failed when LTFS had mounted the tape. So, I switched it the process to use /dev/st?. I guess I need to avoid opening /dev/st? at all while LTFS has /dev/sg? mounted?","author_login":"swt2c","author_association":"CONTRIBUTOR","created_at":"2019-09-12T03:36:06+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530654792","fragment_type":"issue_comment","sequence":9,"text":"Yes. But the alternative is to use /dev/nst* instead. `nst` device never issue `REWIND` at open/close.\n\nAnother point is to add `-o eject` option to LTFS for a safeguard. Basically LTFS tries to use `append only mode` of IBM drives. But the `append only mode` only can clear when the tape is ejected from the drive spec. So LTFS only uses the `append only mode` when `-o eject`. Because historically default behavior is keep the tape on drive at unmount, so it is no chance to disable the `append only mode`. (May be it is a good timing to consider to change default behavior...)\n\nAnyway, you can avoid data corruption because of `REWIND` from another path if you add `-o eject` in the command line. But you may receive an write error (and goes to R/O mode) when `REWIND` from another path happens.","author_login":"piste-jp-ibm","author_association":"MEMBER","created_at":"2019-09-12T04:01:21+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_533133496","fragment_type":"issue_comment","sequence":10,"text":"This seems to be working fine after I reformatted and switched to using /dev/nst* for status calls. Thanks for the help!","author_login":"swt2c","author_association":"CONTRIBUTOR","created_at":"2019-09-19T13:35:24+08:00","repo_name":"LinearTapeFileSystem/ltfs","issue_id":491189983,"issue_number":157,"issue_url":"https://github.com/LinearTapeFileSystem/ltfs/issues/157","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0025","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Replace `Foreign.Marshal.Error.void` with a re-export of `Data.Functor.void`?","query_context":"These two functions have identical behavior and names, but differing types. (This can cause annoying and pointless \"ambiguous occurrence\" errors when both are in scope.) `Data.Functor.void` is more general than `Foreign.Marshal.Error.void`, but the proposed change is nevertheless a breaking one since the more general type of `Data.Functor.void` can cause type inference to fail in some cases.\n\nBut `Foreign.Marshal.Error.void` has been deprecated since `base-4.6.0.0`, which shipped with ghc-7.6.1 and was released in September 2012, more than a decade ago. Potentially-affected users have had plenty of time to migrate.\n\nSide note: `Foreign.Marshal.Error.void` is specified in the Haskell2010 report; see this chapter. Otherwise I might propose to just delete this function instead of generalizing it.","known_context_document_ids":["gh_issue_2216540717"],"reference_answer":"OK, let's vote on this.\n\nDear CLC members, the proposal is to extend Impact Assessments section of `PROPOSALS.md` with a paragraph \n \n\n@angerman @hasufell @tomjaguarpaw @parsonsmatt @velveteer @mixphix \n\n----\n\n+1 from me, see my comment above.","answer_document_id":"gh_comment_2077901685","silver_evidence_path":["gh_comment_2078653480","gh_issue_2204287673","gh_comment_2077901685"],"evidence_issue_ids":[2216540717,2204287673],"source_repo_name":"haskell/core-libraries-committee","source_issue_id":2216540717,"source_issue_number":264,"source_issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","target_repo_name":"haskell/core-libraries-committee","target_issue_id":2204287673,"target_issue_number":262,"target_issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","reference_anchor_document_id":"gh_comment_2078653480","reference_answer_author":"Bodigrim","reference_answer_author_association":"COLLABORATOR","quality_score":85.27,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1818,"anchor_target_overlap":0.3636,"target_answer_overlap":0.0455},"issue_created_at":"2024-03-30T15:39:28+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_2216540717","fragment_type":"issue_description","sequence":0,"text":"Replace `Foreign.Marshal.Error.void` with a re-export of `Data.Functor.void`\nThese two functions have identical behavior and names, but differing types. (This can cause annoying and pointless \"ambiguous occurrence\" errors when both are in scope.) `Data.Functor.void` is more general than `Foreign.Marshal.Error.void`, but the proposed change is nevertheless a breaking one since the more general type of `Data.Functor.void` can cause type inference to fail in some cases.\n\nBut `Foreign.Marshal.Error.void` has been deprecated since `base-4.6.0.0`, which shipped with ghc-7.6.1 and was released in September 2012, more than a decade ago. Potentially-affected users have had plenty of time to migrate.\n\nSide note: `Foreign.Marshal.Error.void` is specified in the Haskell2010 report; see this chapter. Otherwise I might propose to just delete this function instead of generalizing it.","author_login":"clyring","author_association":"MEMBER","created_at":"2024-03-30T15:39:28+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2067674282","fragment_type":"issue_comment","sequence":1,"text":"Given that the function is deprecated for a decade, I don’t see a reason not to delete it. We are way far away from Haskell Report to bother about it.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-20T13:28:25+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067808953","fragment_type":"issue_comment","sequence":2,"text":"@tomjaguarpaw @mixphix @hasufell @angerman @parsonsmatt @velveteer any more opinions about `Foreign.Marshal.Error.void`?","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-20T23:01:48+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067913746","fragment_type":"issue_comment","sequence":3,"text":"I would like a base that conforms to the spec or an update to the spec.\n\nDo we know why the deprecation was introduced?\n\nI don't see base in the 7.6 tree URL","author_login":"hasufell","author_association":"MEMBER","created_at":"2024-04-21T05:36:55+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067941700","fragment_type":"issue_comment","sequence":4,"text":"I don't have a strong opinion between the three options (no change, replace with general version, remove it).","author_login":"tomjaguarpaw","author_association":"COLLABORATOR","created_at":"2024-04-21T07:33:30+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2068073229","fragment_type":"issue_comment","sequence":5,"text":"It was deprecated by @simonmar in URL Apr 2012, but there is no explanation or discussion attached.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-21T14:53:41+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2068074217","fragment_type":"issue_comment","sequence":6,"text":"Given the deprecation message I guess the reason was that the more general version of `void` should be preferred!\n\n{-# DEPRECATED void \"use Control.Monad.void instead\" #-}","author_login":"tomjaguarpaw","author_association":"COLLABORATOR","created_at":"2024-04-21T14:56:54+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2077879933","fragment_type":"issue_comment","sequence":7,"text":"@parsonsmatt @angerman @velveteer any more opinion on the preferred course of actions here?","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-25T18:14:12+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2078463489","fragment_type":"issue_comment","sequence":8,"text":"Another point to consider: A fair number of packages have `import Foreign hiding ( void )` which will trigger a `-Wdodgy-imports` warning if `void` is completely removed from `Foreign.Marshal.Error`. That's not a big deal: there are several acceptable ways of dealing with this warning, including silencing it. But it does probably create busy-work for the relevant maintainers, which could be avoided by replacing `Foreign.Marshal.Error.void` with a re-export of `Data.Functor.void`.\n\nBut I won't sleep any less soundly if the committee still prefers to delete the function instead.","author_login":"clyring","author_association":"MEMBER","created_at":"2024-04-26T01:20:19+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2078653480","fragment_type":"issue_comment","sequence":9,"text":"@clyring we don't consider warnings breaking changes: URL \n\nWerror users get what they asked for.","author_login":"hasufell","author_association":"MEMBER","created_at":"2024-04-26T05:23:05+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[2204287673],"is_known_query_context":false},{"document_id":"gh_comment_2080063957","fragment_type":"issue_comment","sequence":10,"text":"I think we all agree that `Foreign.Marshal.Error` is not a right place for `void :: Functor f => f a -> f ()`, it's just that CLC members may have different appetite when it comes to breakage. \n\nAs noted in the proposal, replacing `void :: IO a -> IO ()` with `void :: Functor f => f a -> f ()` is also a breaking change, because it can potentially make type checking ambiguous. So it would require an impact assessment, same as just removing it. So I guess it's a question which impact assessment (and patches) @clyring is motivated enough to perform.\n\nIf we go for re-export, let's *deprecate* it, so that we do not close the door to the eventual removal of the function.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-26T20:18:48+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2254577883","fragment_type":"issue_comment","sequence":11,"text":"@clyring unless there is some progress by the end of August, I'll have to close the proposal as abandoned.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-07-28T16:47:54+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2323453549","fragment_type":"issue_comment","sequence":12,"text":"Closing as abandoned, feel free to reopen when there are resources to continue.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-09-01T18:34:54+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2216540717,"issue_number":264,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2204287673","fragment_type":"issue_description","sequence":0,"text":"Regarding \"-Werror\" and how the proposals are examined by the committee\nHello committee,\n\nIn light of recent proposals that were discussed with deprecation and warning mechanisms at their core, I see a strange phenomenon of pleading for users of `-Werror`, that is to say the flag that turns every warning, no matter how benign, and including `-Wcompat`, into fatal errors.\n\nThis is quite surprising because users of `-Werror` voluntarily checked out of the ability to be programmatically warned ahead of time for breaking changes that would happen in a couple of major releases. By not being selective on which warning they want to turn into errors, they prefer to have things break early, compromising neither on the \"break\", nor on the \"early\".\n\nHence from my point of view, it is quite peculiar to see arguments opposed to future breaking changes with a progressive deprecation phase, in order to protect the users who so dearly wish things to break early.\n\nI would like to ask the committee to solve the matter of `-Werror` once and for all, preferring solutions like warning groups, that allow granularity, instead of never ever emitting any kind of warning at all.","author_login":"Kleidukos","author_association":"MEMBER","created_at":"2024-03-24T10:40:48+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016776419","fragment_type":"issue_comment","sequence":1,"text":"This shouldn't even be a discussion. If you enabled -Werror you are asking for early fatal breakage. And that's what you get. We should not entertain the idea that -Werror need to be considered when deprecating. The whole point is to warn people for upcoming changes. If you run with -Werror you get the warning as fatal error early. Not a bit later when it fatally breaks. Deprecations allow you to also get some more context as to why. And you can often specifically opt out of a specific warning at the module level if you so need to.","author_login":"angerman","author_association":"NONE","created_at":"2024-03-24T11:21:43+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017133100","fragment_type":"issue_comment","sequence":2,"text":"I think what sparked this thread is that these types of discussions are constantly coming up. So the question is if we as a CLC should encode common singular principles we all agree on in a document, so that contributors know what they're getting into and we can just link to the document whenever it comes up again.\n\nSuch a document wouldn't really be set in stone and could as well be discarded by a future CLC.\n\nBut I believe it makes things a bit easier.\n\nThis is far less ambitious than coming up with a \"stability policy\". I see this really about avoiding repetitive discussions.","author_login":"hasufell","author_association":"MEMBER","created_at":"2024-03-25T03:11:57+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018913645","fragment_type":"issue_comment","sequence":3,"text":"I agree, and mind you I'm addicted to `-Werror -Wall -Wcompat` stuff.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-03-25T21:05:00+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2020635336","fragment_type":"issue_comment","sequence":4,"text":"@mixphix Don't feel targeted if you're not guilty of this. This sort of principle also applies to submitters and third-party reviewers on the proposals.","author_login":"Kleidukos","author_association":"MEMBER","created_at":"2024-03-26T14:46:47+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2026167045","fragment_type":"issue_comment","sequence":5,"text":"GHC's new stability principles explicitly say that they will not keep warnings stable: URL \n\n(Obviously the CLC can do something different to GHC, but it's a reference point)","author_login":"michaelpj","author_association":"NONE","created_at":"2024-03-28T21:32:30+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067394001","fragment_type":"issue_comment","sequence":6,"text":"@Kleidukos what kind of a format resolution besides personal statements from CLC members are you looking for if any?","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-19T23:35:38+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067619943","fragment_type":"issue_comment","sequence":7,"text":"@Bodigrim A note in Impact Assessments would be the end goal, so that the opinion of the CLC doesn't get lost in this ticket when it is closed.","author_login":"Kleidukos","author_association":"MEMBER","created_at":"2024-04-20T09:42:27+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067731738","fragment_type":"issue_comment","sequence":8,"text":"@Kleidukos would you like to suggest a specific wording? How about the following?\n\n\"Note that additional or new warnings and deprecations are not classified as breaking changes. We assume that users who enable `-Werror` make a conscious and informed choice to break their builds as early and as fatal as possible.\"\n\nSuch wording still allows CLC members to have individual opinions whether a given warning / deprecation is worth the trouble. It's not like anyone can incur as many warnings as they like, but they do not count towards breakage and do not require a proposer to write patches to fix them.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-20T17:08:12+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2077901685","fragment_type":"issue_comment","sequence":9,"text":"OK, let's vote on this.\n\nDear CLC members, the proposal is to extend Impact Assessments section of `PROPOSALS.md` with a paragraph \n \n\n@angerman @hasufell @tomjaguarpaw @parsonsmatt @velveteer @mixphix \n\n----\n\n+1 from me, see my comment above.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-25T18:26:22+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[2204287673],"is_known_query_context":false},{"document_id":"gh_comment_2080047895","fragment_type":"issue_comment","sequence":10,"text":"Thanks all, that's enough votes to approve. I'll implement the change in a moment.","author_login":"Bodigrim","author_association":"COLLABORATOR","created_at":"2024-04-26T20:04:58+08:00","repo_name":"haskell/core-libraries-committee","issue_id":2204287673,"issue_number":262,"issue_url":"https://github.com/haskell/core-libraries-committee/issues/262","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0026","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug Report][3.0.0-beta.10] `v-select`'s label get active always?","query_context":"### Environment\n**Vuetify Version:** 3.0.0-beta.10\n**Vue Version:** 3.2.38\n**Browsers:** Chrome 105.0.0.0\n**OS:** Windows 10\n\n### Steps to reproduce\nTry to use blank string `v-model` value and you see the label get an active state\n\n data: () => ({\n items: ['Foo', 'Bar', 'Fizz', 'Buzz'],\n standardSelect: '',\n outlinedSelect:'',\n soloVariant:'',\n plainVariant:'',\n underlinedVariant:'',\n }),\n\n### Expected Behavior\nv-select does not get an active state\n\n### Actual Behavior\nRefer to code pen for details \n\n### Reproduction Link\n URL","known_context_document_ids":["gh_issue_1360012166"],"reference_answer":"This has since been resolved with the property **cache-items**.\n\n URL \n\nClosing this as resolved.\n\nIf you have any questions, please reach out to us in our Discord community.","answer_document_id":"gh_comment_861520120","silver_evidence_path":["gh_comment_1236815922","gh_issue_320787715","gh_comment_861520120"],"evidence_issue_ids":[1360012166,320787715],"source_repo_name":"vuetifyjs/vuetify","source_issue_id":1360012166,"source_issue_number":15730,"source_issue_url":"https://github.com/vuetifyjs/vuetify/issues/15730","target_repo_name":"vuetifyjs/vuetify","target_issue_id":320787715,"target_issue_number":4000,"target_issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","reference_anchor_document_id":"gh_comment_1236815922","reference_answer_author":"johnleider","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.1176,"target_answer_overlap":0.1538},"issue_created_at":"2022-09-02T10:36:13+08:00","valid_comment_count":30,"fragments":[{"document_id":"gh_issue_1360012166","fragment_type":"issue_description","sequence":0,"text":"[Bug Report][3.0.0-beta.10] `v-select`'s label get active always\n### Environment\n**Vuetify Version:** 3.0.0-beta.10\n**Vue Version:** 3.2.38\n**Browsers:** Chrome 105.0.0.0\n**OS:** Windows 10\n\n### Steps to reproduce\nTry to use blank string `v-model` value and you see the label get an active state\n\n data: () => ({\n items: ['Foo', 'Bar', 'Fizz', 'Buzz'],\n standardSelect: '',\n outlinedSelect:'',\n soloVariant:'',\n plainVariant:'',\n underlinedVariant:'',\n }),\n\n### Expected Behavior\nv-select does not get an active state\n\n### Actual Behavior\nRefer to code pen for details \n\n### Reproduction Link\n URL","author_login":"alokVishu","author_association":"NONE","created_at":"2022-09-02T10:36:13+08:00","repo_name":"vuetifyjs/vuetify","issue_id":1360012166,"issue_number":15730,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/15730","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1236804805","fragment_type":"issue_comment","sequence":1,"text":"Hello @KaelWD,\n\nIn Vuetify 2, Select does not behave the same when I use a blank string as model value: URL","author_login":"alokVishu","author_association":"NONE","created_at":"2022-09-05T10:10:34+08:00","repo_name":"vuetifyjs/vuetify","issue_id":1360012166,"issue_number":15730,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/15730","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1236815922","fragment_type":"issue_comment","sequence":2,"text":"Sorry, power outage deleted my response. \n\nv3 keeps items defined in the model (#4000), so this is more like URL \nAn initial value of `null` has the behaviour you want.","author_login":"KaelWD","author_association":"MEMBER","created_at":"2022-09-05T10:21:42+08:00","repo_name":"vuetifyjs/vuetify","issue_id":1360012166,"issue_number":15730,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/15730","linked_issue_ids":[320787715],"is_known_query_context":false},{"document_id":"gh_comment_1236822090","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the response.\n\nNow, we are using null for the initial value.","author_login":"alokVishu","author_association":"NONE","created_at":"2022-09-05T10:28:13+08:00","repo_name":"vuetifyjs/vuetify","issue_id":1360012166,"issue_number":15730,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/15730","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_320787715","fragment_type":"issue_description","sequence":0,"text":"[Bug Report] Selected options are removed when options are updated even when options are available in model property\n### Versions and Environment\n**Vuetify:** 1.0.16\n**Vue:** 2.5.11\n**Browsers:** Chrome 66.0.3359.139\n**OS:** Windows 7\n\n### Steps to reproduce\nClick on update button.\nThen see in model there is but selection is removed from v-select\n\n### Expected Behavior\nOption should not removed from selection\n\n### Actual Behavior\nIt is removed from selection\n\n### Reproduction Link\n URL","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-07T12:35:24+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387071604","fragment_type":"issue_comment","sequence":1,"text":"That behaviour is intentional, although it should be removed from the model too iirc.","author_login":"KaelWD","author_association":"OWNER","created_at":"2018-05-07T13:52:55+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387155490","fragment_type":"issue_comment","sequence":2,"text":"Hi @KaelWD, I want behavior like, if i remove from list after selecting it should be displayed as selected.\nIs that possible?","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-07T18:18:13+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387162794","fragment_type":"issue_comment","sequence":3,"text":"If you use `cache-items` then yes, although it will still be visible in the menu. I don't really know what your use-case is for this though.","author_login":"KaelWD","author_association":"OWNER","created_at":"2018-05-07T18:42:49+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387166421","fragment_type":"issue_comment","sequence":4,"text":"@KaelWD thanks for your answer, I can use cache-items but if it would be good if removed item is not visible in list.","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-07T18:54:45+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387166997","fragment_type":"issue_comment","sequence":5,"text":"And if you want reference of this use-case, you can check libraries like vue-multiselect or element-ui's select component.","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-07T18:56:36+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387326063","fragment_type":"issue_comment","sequence":6,"text":"I don't think that's good behavior. If the item is removed from the list but still selected then there will be no way to unselect it. The `el-select` seems similar to our ` ` however, which does appear to have the behaviour you want.","author_login":"KaelWD","author_association":"OWNER","created_at":"2018-05-08T08:28:36+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_387349686","fragment_type":"issue_comment","sequence":7,"text":"@KaelWD But if i make v-select autocomplete then there is problem.\nIt will allow user to create tag.","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-08T09:55:11+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388559807","fragment_type":"issue_comment","sequence":8,"text":"Hi @KaelWD , can you check changes I made related to this issue.\nAnd I am new to contributing, if there is anything I can improve you can tell me","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-12T14:43:08+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388675698","fragment_type":"issue_comment","sequence":9,"text":"You cannot have a selection that is not present in the available options. The fact that it leaves the model is completely fine as you can provide whatever value you want to the input. I see that you provided an example of another framework working as you want, but I'd argue to say that it is invalid and not what you would expect from a regular select, so it will not be here.","author_login":"johnleider","author_association":"OWNER","created_at":"2018-05-14T01:56:04+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388709911","fragment_type":"issue_comment","sequence":10,"text":"Hi @johnleider, I also agree with you. But in my use-case I want this behaviour, ok let me tell you how I am using v-select.\nI have four v-select.\n1.) Destinations\n2.) Sailing Dates\n3.) Sailing Duration\n4.) Departure Ports\n\nAnd all four v-select's options are dependent on each other, means if I select destination it will update all other three v-select's options.\n\nSo, if user selected 3 destination then it will update all other three and after that if user selects from available Sailing Dates it will also update destinations then user's selection will disappear from v-select.\n\nI don't know about you, but if I am the user and my selection is removed automatically without touching it, I will be pissed.","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-14T06:27:13+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388714484","fragment_type":"issue_comment","sequence":11,"text":"This could be solved by for example adding the already selected option to the updated values and notifying the user that it is no longer valid, for example displaying it as disabled or with red text.","author_login":"nekosaur","author_association":"CONTRIBUTOR","created_at":"2018-05-14T06:52:48+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388725724","fragment_type":"issue_comment","sequence":12,"text":"@nekosaur yup I can update the list, but then it will change the position of selected value and for displaying it as disabled is not appropriate in my case because I want the user to have with option to deselect it even if it is not in the list because I am maintain the another array for that.\n\nWhat do you say?","author_login":"akki-jat","author_association":"NONE","created_at":"2018-05-14T07:42:55+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388733513","fragment_type":"issue_comment","sequence":13,"text":"I can see the argument for both of these, and the current behaviour is technically buggy too because it removes the value from the input but doesn't update the model. I don't like adding yet another prop to the component though, so we have to decide if it should instead be the default behaviour to show the model even if it's not in items.","author_login":"KaelWD","author_association":"OWNER","created_at":"2018-05-14T08:14:07+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388781649","fragment_type":"issue_comment","sequence":14,"text":"I would say this is out of the hands of the component. If you are mutating the items to dynamically remove items, you should dynamically update the model as well.","author_login":"johnleider","author_association":"OWNER","created_at":"2018-05-14T11:14:25+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_396668322","fragment_type":"issue_comment","sequence":15,"text":"We've decided to consider this after someone on discord posted a similar problem: URL","author_login":"KaelWD","author_association":"MEMBER","created_at":"2018-06-12T17:21:52+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_462269269","fragment_type":"issue_comment","sequence":16,"text":"Is there a workaround, while this issue gets resolved?\nI am using `v-autocomplete` to search for a list of names asynchronously using an API call. I show 5 names initially. When user searches for a name, API call is made to fetch search results. I am using `cache-items` prop.\nNow, my requirement is as follows:\nWhen the `v-autocomplete` loads, I want to provide it with some pre-selected names. The problem I am running into is that since some of the pre-selected names are not available in the initial list of names, they never show up in the selection.\nSo, for example, There are 20 names on the server(`name1`,`name2`,.....`name20`) and the initial list only has 5 names(`name1` to `name5`). Now, if I want `name7` to be already selected, it is not possible right now because it is not present in the list.","author_login":"kanteankit","author_association":"NONE","created_at":"2019-02-11T09:51:42+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_484527434","fragment_type":"issue_comment","sequence":17,"text":"The workaround I found out is to manually add set model's value using searchInput's setter, triggering a server query, here is a working codepen, I usually use Vuex and lodash to throttle server requests\n URL","author_login":"BigsonLvrocha","author_association":"NONE","created_at":"2019-04-18T14:12:13+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_486181627","fragment_type":"issue_comment","sequence":18,"text":"I needed to do an autocomplete with multiple selection and server side rendered list (the user able to select one or more names, which have too many options), `cache-items` would not be an option since they wanted multiple field filtering (the text can match the name or the login name), so I used no-filter prop to give this responsibility solely to the server.\nThe workaround I made for this case is to use `prepend-item` slot to show the selected items inside my own value variable. I show them as a list with a checkbox icon in the tile action to indicate that it is selected and a divider for aesthetics. \nI tried to use `selection` prop to show the number of selected items only at the first item, but I ran into this problem, which was making the text disappear when the user tried to filter for another result, so I am using `prepend-inner` slot for it, with a span wrapped in a slide-x transition for smoothness. \nI know this is an edgy use case, but still a use case for what the component proposes","author_login":"BigsonLvrocha","author_association":"NONE","created_at":"2019-04-24T11:20:22+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_529713354","fragment_type":"issue_comment","sequence":19,"text":"@KaelWD Does this issue have an open PR? The label `has PR` was attached a long time ago and since then nothing has happened.","author_login":"kanteankit","author_association":"NONE","created_at":"2019-09-10T00:06:09+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530269409","fragment_type":"issue_comment","sequence":20,"text":"@kanteankit It had open PR but library author closed PR with comment **Unfortunately this is not functionality that we are looking to implement at this time.**\n\nPR Link: URL","author_login":"akki-jat","author_association":"NONE","created_at":"2019-09-11T08:03:08+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530270334","fragment_type":"issue_comment","sequence":21,"text":"@johnleider Can we re-open it and see if this can get fixed?","author_login":"kanteankit","author_association":"NONE","created_at":"2019-09-11T08:05:48+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_581023071","fragment_type":"issue_comment","sequence":22,"text":"@akki-jat That is the answer for most PR, I do not understand why bug fixing is not the functionality you intend to implement, would you prefer something with bugs? it is?","author_login":"joaoeudes7","author_association":"NONE","created_at":"2020-02-01T11:54:19+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_581023669","fragment_type":"issue_comment","sequence":23,"text":"@akki-jat That is the answer for most PR, I do not understand why bug fixing is not the functionality you intend to implement. Prefer components with bugs? it is?","author_login":"joaoeudes7","author_association":"NONE","created_at":"2020-02-01T12:02:16+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_730533927","fragment_type":"issue_comment","sequence":24,"text":"Is there an update on this? It seems there is a fair amount of traffic linked to this issue and should be pushed up the stack.","author_login":"NickMSW","author_association":"NONE","created_at":"2020-11-19T17:44:55+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861520120","fragment_type":"issue_comment","sequence":25,"text":"This has since been resolved with the property **cache-items**.\n\n URL \n\nClosing this as resolved.\n\nIf you have any questions, please reach out to us in our Discord community.","author_login":"johnleider","author_association":"MEMBER","created_at":"2021-06-15T13:55:44+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861558484","fragment_type":"issue_comment","sequence":26,"text":"With cache-items, the item still shows up when unselected which is unwanted in a server side rendered options scenario. One way I found out was to use computed property: URL","author_login":"BigsonLvrocha","author_association":"NONE","created_at":"2021-06-15T14:41:14+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1174004245","fragment_type":"issue_comment","sequence":27,"text":"Probably it could be helpful for someone, I tried workaround suggested above ( URL but i need to use server side search by many attributes, and if i simply add `no-filter` prop then selected options would still be displayed in list, regardless of whether they meet search condition or not.\nSo i added `filter` prop with following value:\n\n filter(item) {\n return this.searchResults.some((itemFromServer) => itemFromServer.id === item.id)\n },\n\nHere i just check if item exist in array received from the server. And if it exists, then it will be displayed in the list. If it not, then it won't be displayed, but it still will be presented in VAutocomplete items, thus selected items remain visible.","author_login":"cherrybar","author_association":"NONE","created_at":"2022-07-04T16:54:45+08:00","repo_name":"vuetifyjs/vuetify","issue_id":320787715,"issue_number":4000,"issue_url":"https://github.com/vuetifyjs/vuetify/issues/4000","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0028","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"importing electron in a WebWorker doesn't work?","query_context":"Doing `import { ipcRenderer} from 'electron'` (or any other renderer electron module) crashes the app with `reason: \"crashed\"` and `exitCode: 11`.\n\n## Details\n\n- I'm trying to migrate from Webpack and the same code works there.\n- `nodeIntegrationInWorker` is set to true.\n- Exit code 11 usually means Segmentation fault.\n- One thing that is being logged in the Terminal when the app crashes:\n \n\n [20890:0831/172750.464535:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464559:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464564:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464569:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464572:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464578:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464580:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464584:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464601:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464606:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464609:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464612:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n \n\n- Another thing:\n \n\n Error sending from webFrameMain: Error: Render frame was disposed before WebFrameMain could be accessed\n at n._sendInternal (node:electron/js2c/browser_init:165:629)\n at b._sendInternal (node:electron/js2c/browser_init:161:2573)\n at node:electron/js2c/browser_init:193:729\n at new Promise ( )\n at Object.invokeInWebContents (node:electron/js2c/browser_init:193:477)\n at b.executeJavaScript (node:electron/js2c/browser_init:161:3267)\n at process.processTicksAndRejections (node:internal/process/task_queues:96:5)","known_context_document_ids":["gh_issue_1357471351"],"reference_answer":"This isn't a bug - using IPC requires a render frame, which a worker doesn't and can't have.","answer_document_id":"gh_comment_1190665929","silver_evidence_path":["gh_comment_1240426896","gh_issue_1310833614","gh_comment_1190665929"],"evidence_issue_ids":[1357471351,1310833614],"source_repo_name":"electron-vite/vite-plugin-electron","source_issue_id":1357471351,"source_issue_number":69,"source_issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","target_repo_name":"electron/electron","target_issue_id":1310833614,"target_issue_number":34992,"target_issue_url":"https://github.com/electron/electron/issues/34992","reference_anchor_document_id":"gh_comment_1240426896","reference_answer_author":"codebytere","reference_answer_author_association":"MEMBER","quality_score":84.21,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0526,"anchor_target_overlap":0.3158,"target_answer_overlap":0.2222},"issue_created_at":"2022-08-31T15:02:30+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_1357471351","fragment_type":"issue_description","sequence":0,"text":"importing electron in a WebWorker doesn't work\nDoing `import { ipcRenderer} from 'electron'` (or any other renderer electron module) crashes the app with `reason: \"crashed\"` and `exitCode: 11`.\n\n## Details\n\n- I'm trying to migrate from Webpack and the same code works there.\n- `nodeIntegrationInWorker` is set to true.\n- Exit code 11 usually means Segmentation fault.\n- One thing that is being logged in the Terminal when the app crashes:\n \n\n [20890:0831/172750.464535:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464559:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464564:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464569:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464572:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464578:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464580:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464584:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464601:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464606:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n [20890:0831/172750.464609:ERROR:shared_image_manager.cc(267)] SharedImageManager::ProduceOverlay: Trying to Produce a Overlay representation from a non-existent mailbox.\n [20890:0831/172750.464612:ERROR:skia_output_device_buffer_queue.cc(354)] Invalid mailbox.\n \n\n- Another thing:\n \n\n Error sending from webFrameMain: Error: Render frame was disposed before WebFrameMain could be accessed\n at n._sendInternal (node:electron/js2c/browser_init:165:629)\n at b._sendInternal (node:electron/js2c/browser_init:161:2573)\n at node:electron/js2c/browser_init:193:729\n at new Promise ( )\n at Object.invokeInWebContents (node:electron/js2c/browser_init:193:477)\n at b.executeJavaScript (node:electron/js2c/browser_init:161:3267)\n at process.processTicksAndRejections (node:internal/process/task_queues:96:5)","author_login":"astoilkov","author_association":"CONTRIBUTOR","created_at":"2022-08-31T15:02:30+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1233153096","fragment_type":"issue_comment","sequence":1,"text":"I think that's the reason for the crash: URL \n\nClosing this issue. Sorry for incorrectly reporting it here.","author_login":"astoilkov","author_association":"NONE","created_at":"2022-08-31T16:20:32+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1233158049","fragment_type":"issue_comment","sequence":2,"text":"Was wrong about it. Upgrading Electron to the latest doesn't fix the problem. The problem is somewhere else.","author_login":"astoilkov","author_association":"NONE","created_at":"2022-08-31T16:25:12+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1233852846","fragment_type":"issue_comment","sequence":3,"text":"Yes. I will start working on building a reproducible demo.\n\nDid you try to import and call an electron module in a WebWorker (loaded with `type: \"module\"`)? Does it work for you?","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-01T07:19:44+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1233924104","fragment_type":"issue_comment","sequence":4,"text":"`type: \"module\"` will be supported in `v0.9.3`, coming soon. 🚚","author_login":"caoxiemeihao","author_association":"MEMBER","created_at":"2022-09-01T08:22:29+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235152964","fragment_type":"issue_comment","sequence":5,"text":"Great! So, for now, there is no need for me to create a reproducible demo, right?","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-02T07:14:42+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235175456","fragment_type":"issue_comment","sequence":6,"text":"<img width=\"1340\" alt=\"image\" src=\" URL \nThere's something wrong with building esm support, I'm trying to Debug Vite and it's confusing.\nOr I'll use Rollup to get around this.\nSorry for the wait.","author_login":"caoxiemeihao","author_association":"MEMBER","created_at":"2022-09-02T07:40:40+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235271004","fragment_type":"issue_comment","sequence":7,"text":"A little context (it might be useful for you):\n- I don't get any error from Vite when using `type: \"module\"` when creating a new WebWorker.\n- `import something from 'module'` doesn't work if I don't set the `type: \"module\"`.\n\nI also may use WebWorker without `type: \"module\"` but I'm not sure how should I import stuff. Maybe it's not possible?","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-02T09:20:39+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235475063","fragment_type":"issue_comment","sequence":8,"text":"`type: \"module\"` doesn't work with Electron, probably because Electron doesn't support ESM well.\nI built the ESM version of the plugin, but Electron doesn't work when `type: \"module\"` is enabled.\n\nSupport `type: \"module\"` branch 👉 vite-plugin-electron/tree/type-module\n\nRun setup\n\nbash\ncd playground/usecase-in-main\n\nnpm run dev\n\nErrors\n\nlog\nApp threw an error during load\nError [ERR_REQUIRE_ESM]: require() of ES Module /Users/atom/Desktop/github/vite-plugin-electron/playground/usecase-in-main/dist/electron/main/index.js from /Users/atom/Desktop/github/vite-plugin-electron/node_modules/.pnpm/electron@19.0.8/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js not supported.\nInstead change the require of index.js in /Users/atom/Desktop/github/vite-plugin-electron/node_modules/.pnpm/electron@19.0.8/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js to a dynamic import() which is available in all CommonJS modules.\n at c._load (node:electron/js2c/asar_bundle:5:13343)\n at loadApplicationPackage (/Users/atom/Desktop/github/vite-plugin-electron/node_modules/.pnpm/electron@19.0.8/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js:110:16)\n at Object. (/Users/atom/Desktop/github/vite-plugin-electron/node_modules/.pnpm/electron@19.0.8/node_modules/electron/dist/Electron.app/Contents/Resources/default_app.asar/main.js:222:9)\n at c._load (node:electron/js2c/asar_bundle:5:13343)\n at Object. (node:electron/js2c/browser_init:185:3104)\n at ./lib/browser/init.ts (node:electron/js2c/browser_init:185:3308)\n at __webpack_require__ (node:electron/js2c/browser_init:1:128)\n at node:electron/js2c/browser_init:1:1200\n at node:electron/js2c/browser_init:1:1267\n at c._load (node:electron/js2c/asar_bundle:5:13343)","author_login":"caoxiemeihao","author_association":"MEMBER","created_at":"2022-09-02T12:57:53+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235585284","fragment_type":"issue_comment","sequence":9,"text":"I'm creating the WebWorker from the renderer process. Is this relevant?","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-02T14:40:10+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1236184688","fragment_type":"issue_comment","sequence":10,"text":"I'm in the process of swapping from webpack to vite, and one of the issues I have atm is the production build is crashing when trying to use nodejs modules, but works fine in development.\n\ne.g.\n\n`index.ts`:\n\nimport TestWorker from \"@/workers/test-worker?worker\";\nconst testWorker = new TestWorker();\n\n`workers/test-worker.ts`:\n\nimport * as path from \"path\";\nconsole.log(path.parse(__dirname));\n\nI have `nodeIntegrationInWorker: true`, and as I said it works fine in development, but in the production build it doesn't recognise the path module and the built worker file looks a little sketchy:\n\nimage\n\nIs this the right issue to report this? Am curious if the work you're doing will fix this or if my issue is unrelated.","author_login":"Jazcash","author_association":"NONE","created_at":"2022-09-03T19:16:20+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1236214231","fragment_type":"issue_comment","sequence":11,"text":"This project is just for my personal interest, I have not tested many cases, such as `web worder`.\nBy the way, Vite behaves very differently during development and build, so I run into really tricky issues a lot of the time.","author_login":"caoxiemeihao","author_association":"MEMBER","created_at":"2022-09-03T23:43:36+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1238329284","fragment_type":"issue_comment","sequence":12,"text":"Done. Here is the repo: URL \n\nThe important part is in `renderer/main.ts`:\n\nts\ndocument.body.addEventListener('click', () => {\n new Worker(new URL('./worker.ts', import.meta.url), {\n type: 'module'\n })\n})\n\nClicking on the \"hello\" text will run the code and the `BrowserWindow` will crash. You can open DevTools before you click the \"hello\" text so you can see DevTools shows a message as well.","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-06T15:44:30+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240152966","fragment_type":"issue_comment","sequence":13,"text":"@astoilkov 👋\nEventually, I found that using `ipcRenderer` in a Web Worker would cause the Electron-Renderer to crash. This is confusing!\n URL \nI submitted a PR to try to bypass access to ipcRenderer.","author_login":"caoxiemeihao","author_association":"MEMBER","created_at":"2022-09-08T02:48:05+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240300251","fragment_type":"issue_comment","sequence":14,"text":"Great, thanks! Are you going to implement a fix in electron-vite-renderer?","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-08T06:53:21+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240342387","fragment_type":"issue_comment","sequence":15,"text":"This problem may come from Electron itself, what we can do is to hide `ipcRenderer` when using electron module in Web Worker. Not sure if this is the right thing to do or if we need to state this in the README.md. 🤔","author_login":"caoxiemeihao","author_association":"MEMBER","created_at":"2022-09-08T07:36:59+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240426896","fragment_type":"issue_comment","sequence":16,"text":"I think you can safely hide `ipcRenderer` in Web Worker because it seems, as I learned just now, that you shouldn't access it and the behavior is expected because there isn't a `webFrame` inside of workers — URL","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-08T08:55:24+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[1310833614],"is_known_query_context":false},{"document_id":"gh_comment_1240667784","fragment_type":"issue_comment","sequence":17,"text":"Another idea: You can throw an error if someone tries to access an ipcRenderer property (using a Proxy) and explain the issue. This will be very helpful to other users.","author_login":"astoilkov","author_association":"NONE","created_at":"2022-09-08T12:44:19+08:00","repo_name":"electron-vite/vite-plugin-electron","issue_id":1357471351,"issue_number":69,"issue_url":"https://github.com/electron-vite/vite-plugin-electron/issues/69","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1310833614","fragment_type":"issue_description","sequence":0,"text":"[Bug]: BrowserWindow crashes after web worker calls ipcRenderer.invoke\n### Preflight Checklist\n\n- [X] I have read the Contributing Guidelines for this project.\n- [X] I agree to follow the Code of Conduct that this project adheres to.\n- [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.\n\n### Electron Version\n\n17.4.10\n\n### What operating system are you using?\n\nWindows\n\n### Operating System Version\n\nwindows 10 21H1\n\n### What arch are you using?\n\nx64\n\n### Last Known Working Electron version\n\n_No response_\n\n### Expected Behavior\n\nCan call ipcRenderer.invoke or ipcRenderer.send normally in the web worker\n\n### Actual Behavior\n\nBrowserWindow crashes after web worker calls ipcRenderer.invoke or ipcRenderer.send\n\n### Testcase Gist URL\n\n URL \n\n### Additional Information\n\n_No response_","author_login":"lyswhut","author_association":"NONE","created_at":"2022-07-20T10:42:27+08:00","repo_name":"electron/electron","issue_id":1310833614,"issue_number":34992,"issue_url":"https://github.com/electron/electron/issues/34992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1190665929","fragment_type":"issue_comment","sequence":1,"text":"This isn't a bug - using IPC requires a render frame, which a worker doesn't and can't have.","author_login":"codebytere","author_association":"MEMBER","created_at":"2022-07-20T19:24:17+08:00","repo_name":"electron/electron","issue_id":1310833614,"issue_number":34992,"issue_url":"https://github.com/electron/electron/issues/34992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240425710","fragment_type":"issue_comment","sequence":2,"text":"Maybe not a bug but it took me days to discover this problem and understand why our Web Worker is crashing. Maybe you can just handle the error and throw a user friendly error.","author_login":"astoilkov","author_association":"CONTRIBUTOR","created_at":"2022-09-08T08:54:21+08:00","repo_name":"electron/electron","issue_id":1310833614,"issue_number":34992,"issue_url":"https://github.com/electron/electron/issues/34992","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0029","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Component level note content needs to allow text formatting?","query_context":"## Summary\nRight now all note types allow text formatting for its content with a few exceptions:\n- `dimensions`\n- `physfacet`\n- `acqinfo`\n\nThe following note types aren't displaying at all when the content has text formatting\n- `physdesc`\n- `index`\n\n`physdesc` may be the place to start because `dimensions` and `physfacet` are EAG tags nested within `physdesc`.\n\nThis issue may overlap with AR-136 In Progress which calls for text formatting in component `unittitle`\n\nPlease see the attached spreadsheet for data on whether or not a note type displays and/or allows text formatting.\ncomponent_notes_text.xlsx\n\n## Acceptance Criteria\n- [ ] Text formatting is allowed and displays on all note types that are listed in the above spreadsheet\n\n## Testing Instructions\n- Use the G334 – 54 slides component on staging\n- Ensure there is bold or underline formatting for the following:\n - Acquisition information\n - Physical description\n - Physical facet\n - Dimensions\n - Indexes\n\n \n Text formatting \n\nImage","known_context_document_ids":["gh_issue_3005122319"],"reference_answer":"Example of text formatting not rendering in : URL \n\ncode snippet:\n` \n \n \"Singing for her supper,\" The Hill , pp.\n 30-31 `\n\nI will add an example of text formatting not rendering in component level notes shortly.","answer_document_id":"gh_comment_2807469850","silver_evidence_path":["gh_comment_2819697893","gh_issue_2987316279","gh_comment_2807469850"],"evidence_issue_ids":[3005122319,2987316279],"source_repo_name":"notch8/archives_online","source_issue_id":3005122319,"source_issue_number":153,"source_issue_url":"https://github.com/notch8/archives_online/issues/153","target_repo_name":"notch8/archives_online","target_issue_id":2987316279,"target_issue_number":102,"target_issue_url":"https://github.com/notch8/archives_online/issues/102","reference_anchor_document_id":"gh_comment_2819697893","reference_answer_author":"brijmcla","reference_answer_author_association":"COLLABORATOR","quality_score":85.08,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0635,"anchor_target_overlap":0.2162,"target_answer_overlap":0.1765},"issue_created_at":"2025-04-18T14:55:00+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_3005122319","fragment_type":"issue_description","sequence":0,"text":"Component level note content needs to allow text formatting\n## Summary\nRight now all note types allow text formatting for its content with a few exceptions:\n- `dimensions`\n- `physfacet`\n- `acqinfo`\n\nThe following note types aren't displaying at all when the content has text formatting\n- `physdesc`\n- `index`\n\n`physdesc` may be the place to start because `dimensions` and `physfacet` are EAG tags nested within `physdesc`.\n\nThis issue may overlap with AR-136 In Progress which calls for text formatting in component `unittitle`\n\nPlease see the attached spreadsheet for data on whether or not a note type displays and/or allows text formatting.\ncomponent_notes_text.xlsx\n\n## Acceptance Criteria\n- [ ] Text formatting is allowed and displays on all note types that are listed in the above spreadsheet\n\n## Testing Instructions\n- Use the G334 – 54 slides component on staging\n- Ensure there is bold or underline formatting for the following:\n - Acquisition information\n - Physical description\n - Physical facet\n - Dimensions\n - Indexes\n\n \n Text formatting \n\nImage","author_login":"jillpe","author_association":"NONE","created_at":"2025-04-18T14:55:00+08:00","repo_name":"notch8/archives_online","issue_id":3005122319,"issue_number":153,"issue_url":"https://github.com/notch8/archives_online/issues/153","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2819697893","fragment_type":"issue_comment","sequence":1,"text":"From Bri:\n\nComponents are the items (series, subseries, etc) within a finding aid. Some people call it an inventory. In EAD XML terms, components are within . Ticket #102 dealt with component title text formatting, but #153 addresses notes within . I don't think there are any examples in the Notch8 staying site, but here is an example from another EAD.\n\n \n General \n \n(Enclosing The PLAC [newsletter of the Patent Law Association of Chicago], Vol. 6, No. 3, October 1979, pp. 1-4;\n An Evening at the Washington Award, \n Midwest Engineer \n; Letter from John J. Chrystal of the Patent Law Association of Chicago to Joe Allen of October 19, 1979; and Draft bill to establish Patent and Trademark Office as a separate entity)","author_login":"sjproctor","author_association":"NONE","created_at":"2025-04-21T23:28:38+08:00","repo_name":"notch8/archives_online","issue_id":3005122319,"issue_number":153,"issue_url":"https://github.com/notch8/archives_online/issues/153","linked_issue_ids":[2987316279],"is_known_query_context":false},{"document_id":"gh_comment_2829100297","fragment_type":"issue_comment","sequence":2,"text":"@brijmcla I am having a hard time finding an example of text formatting in any of the tags listed in this ticket. Do you have an example of a `physdesc` tag, ideally with a nested `dimensions` and `physfacet` that has text formatting?","author_login":"sjproctor","author_association":"NONE","created_at":"2025-04-25T00:07:06+08:00","repo_name":"notch8/archives_online","issue_id":3005122319,"issue_number":153,"issue_url":"https://github.com/notch8/archives_online/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2830567284","fragment_type":"issue_comment","sequence":3,"text":"There isn't an existing example in the Notch8 staging site. Here is a code example that I edited from the component G334 – 54 slides from the Hattin finding aid. \n\n \n \n G334 – 54 slides \n 1","author_login":"brijmcla","author_association":"COLLABORATOR","created_at":"2025-04-25T14:18:57+08:00","repo_name":"notch8/archives_online","issue_id":3005122319,"issue_number":153,"issue_url":"https://github.com/notch8/archives_online/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2842234875","fragment_type":"issue_comment","sequence":4,"text":"# QA RESULTS: :warning: PENDING\n\ntested on STAGING\n\n## Acceptance Criteria\n- [ ] Text formatting is allowed and displays on all note types that are listed in the above spreadsheet\n\n## Testing Instructions\n- Use the G334 – 54 slides component on staging\n- Ensure there is bold or underline formatting for the following:\n - Acquisition information\n - Physical description\n - Physical facet\n - Dimensions\n - Indexes\n\n \n Text formatting \n\nImage","author_login":"ShanaLMoore","author_association":"NONE","created_at":"2025-04-30T14:45:25+08:00","repo_name":"notch8/archives_online","issue_id":3005122319,"issue_number":153,"issue_url":"https://github.com/notch8/archives_online/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2842304257","fragment_type":"issue_comment","sequence":5,"text":"@brijmcla we are finishing up our last ticket for the sprint. This is ready for your review!","author_login":"sjproctor","author_association":"NONE","created_at":"2025-04-30T15:06:28+08:00","repo_name":"notch8/archives_online","issue_id":3005122319,"issue_number":153,"issue_url":"https://github.com/notch8/archives_online/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2987316279","fragment_type":"issue_description","sequence":0,"text":"Improving text formatting at item level titles\n# ⚠️ REQUIRES REINDEXING ⚠️\n\n## Summary\nText formatting at item level title not coming through\n\n**Current**\n\n \n \n\n**Expected archives.iu.edu**\n\n \n\n## Acceptance Criteria\n- [ ] As a user EAD formatting attributes are consistent across all item level titles","author_login":"jillpe","author_association":"NONE","created_at":"2025-04-11T01:25:16+08:00","repo_name":"notch8/archives_online","issue_id":2987316279,"issue_number":102,"issue_url":"https://github.com/notch8/archives_online/issues/102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2802305017","fragment_type":"issue_comment","sequence":1,"text":"Bri to share an example of what this should look like. Currently the code exists to format EAD information, it's just not coming in","author_login":"jillpe","author_association":"NONE","created_at":"2025-04-14T16:49:56+08:00","repo_name":"notch8/archives_online","issue_id":2987316279,"issue_number":102,"issue_url":"https://github.com/notch8/archives_online/issues/102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2807469850","fragment_type":"issue_comment","sequence":2,"text":"Example of text formatting not rendering in : URL \n\ncode snippet:\n` \n \n \"Singing for her supper,\" The Hill , pp.\n 30-31 `\n\nI will add an example of text formatting not rendering in component level notes shortly.","author_login":"brijmcla","author_association":"COLLABORATOR","created_at":"2025-04-15T20:50:19+08:00","repo_name":"notch8/archives_online","issue_id":2987316279,"issue_number":102,"issue_url":"https://github.com/notch8/archives_online/issues/102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2807500909","fragment_type":"issue_comment","sequence":3,"text":"Scratch adding an example in notes. This ticket is scoped for .","author_login":"brijmcla","author_association":"COLLABORATOR","created_at":"2025-04-15T21:02:49+08:00","repo_name":"notch8/archives_online","issue_id":2987316279,"issue_number":102,"issue_url":"https://github.com/notch8/archives_online/issues/102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2807501303","fragment_type":"issue_comment","sequence":4,"text":"Bri confirmed it looks like the issues is with the attribute `render=\"italic\"` as opposed to something like a tag for rendering italics","author_login":"sjproctor","author_association":"NONE","created_at":"2025-04-15T21:03:03+08:00","repo_name":"notch8/archives_online","issue_id":2987316279,"issue_number":102,"issue_url":"https://github.com/notch8/archives_online/issues/102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810726883","fragment_type":"issue_comment","sequence":5,"text":"cc @kirkkwang I've triggered a deploy to prod. Could you reindex staging when it's ready and move to QA once that's done?","author_login":"ShanaLMoore","author_association":"NONE","created_at":"2025-04-16T20:43:37+08:00","repo_name":"notch8/archives_online","issue_id":2987316279,"issue_number":102,"issue_url":"https://github.com/notch8/archives_online/issues/102","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0030","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Put more requests for help & advice on requests into public?","query_context":"We could have a public \"get help on this request\" link somewhere on request pages, which goes through to the user support inbox but also gets posted on the request thread (perhaps behind a tabbed interface).\n\nWe could then allow admins to answer the help request in public, with the aim of being able to point people towards existing answers rather than using canned responses to reply privately.\n\nPossibly, on viewing the help request, admins could also mark it safe for public comment (rather than admin-only reply) to enable other users to contribute. We could have a feed of these help requests similar to URL","known_context_document_ids":["gh_issue_1204706916"],"reference_answer":"We could have an admin page of \"allowed tags\" that users can suggest or add (like our body performance tags or `pit`-related tags). That would reduce the impact of users adding synonyms or tags that generate notes.","answer_document_id":"gh_comment_1191554388","silver_evidence_path":["gh_comment_1101817966","gh_issue_67254835","gh_comment_1191554388"],"evidence_issue_ids":[1204706916,67254835],"source_repo_name":"mysociety/alaveteli","source_issue_id":1204706916,"source_issue_number":6970,"source_issue_url":"https://github.com/mysociety/alaveteli/issues/6970","target_repo_name":"mysociety/alaveteli","target_issue_id":67254835,"target_issue_number":2302,"target_issue_url":"https://github.com/mysociety/alaveteli/issues/2302","reference_anchor_document_id":"gh_comment_1101817966","reference_answer_author":"garethrees","reference_answer_author_association":"MEMBER","quality_score":85.78,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.25,"target_answer_overlap":0.0556},"issue_created_at":"2022-04-14T15:51:25+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1204706916","fragment_type":"issue_description","sequence":0,"text":"Put more requests for help & advice on requests into public\nWe could have a public \"get help on this request\" link somewhere on request pages, which goes through to the user support inbox but also gets posted on the request thread (perhaps behind a tabbed interface).\n\nWe could then allow admins to answer the help request in public, with the aim of being able to point people towards existing answers rather than using canned responses to reply privately.\n\nPossibly, on viewing the help request, admins could also mark it safe for public comment (rather than admin-only reply) to enable other users to contribute. We could have a feed of these help requests similar to URL","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-04-14T15:51:25+08:00","repo_name":"mysociety/alaveteli","issue_id":1204706916,"issue_number":6970,"issue_url":"https://github.com/mysociety/alaveteli/issues/6970","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1101817966","fragment_type":"issue_comment","sequence":1,"text":"Already ideally admins (and others) will provide advice in public via an annotation. \n\nExposing per-request tags URL would enable the use of a tag to flag a request for help. Ideally we'd have a button to add the tag, and a page listing requests on which help has been sought. \n\nRelated:\n\nConsider presenting the \"next steps\" / refusal advice publicly #6286 \n\nPrevious discussion on offering help in public via a mailing list, an option it was decided not to pursue:\n\n URL","author_login":"RichardTaylor","author_association":"MEMBER","created_at":"2022-04-18T22:29:10+08:00","repo_name":"mysociety/alaveteli","issue_id":1204706916,"issue_number":6970,"issue_url":"https://github.com/mysociety/alaveteli/issues/6970","linked_issue_ids":[67254835],"is_known_query_context":false},{"document_id":"gh_comment_1101821185","fragment_type":"issue_comment","sequence":2,"text":"Often users who write to the support team seeking advice have not classified their response (or they've classified it as needing the attention of the team) whereas if they had classified it eg. rejected or awaiting a response the system would have automatically offered advice. \n\nDoing more to encourage classification could prevent users seeking human help:\n\n URL","author_login":"RichardTaylor","author_association":"MEMBER","created_at":"2022-04-18T22:34:40+08:00","repo_name":"mysociety/alaveteli","issue_id":1204706916,"issue_number":6970,"issue_url":"https://github.com/mysociety/alaveteli/issues/6970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2485551011","fragment_type":"issue_comment","sequence":3,"text":"This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.\nShould we decide to revisit this issue in the future, it can be reopened.","author_login":"HelenWDTK","author_association":"CONTRIBUTOR","created_at":"2024-11-19T12:14:10+08:00","repo_name":"mysociety/alaveteli","issue_id":1204706916,"issue_number":6970,"issue_url":"https://github.com/mysociety/alaveteli/issues/6970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_67254835","fragment_type":"issue_description","sequence":0,"text":"Expose per-request tags publicly and enable searching and browsing using such tags\nThis is a request that has been made by a user of WhatDoTheyKnow.\n\nThe request suggests allowing anyone to assign tags to a request - as an option under the \"Things to do with this request Anyone\" heading under a request's correspondence. \n\nTheir ideas in relation to search include showing search results collected by tag within a particular body.","author_login":"RichardTaylor","author_association":"NONE","created_at":"2015-04-09T01:07:33+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_439637781","fragment_type":"issue_comment","sequence":1,"text":"By not having this feature we could be missing out on a way to highlight requests of interest. \n\nA \"tribunal\" tag could be used to mark requests which have been appealed to the Information Rights Tribunal for example. \n\n URL","author_login":"RichardTaylor","author_association":"NONE","created_at":"2018-11-17T18:30:33+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_439828010","fragment_type":"issue_comment","sequence":2,"text":"Tags _are_ indexed, so that search _nearly_ works. \n\n URL is what you're after.\n\nObviously the discovery of this is poor, but its at least usable for promoting on Twitter etc.","author_login":"garethrees","author_association":"MEMBER","created_at":"2018-11-19T09:33:05+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_734957662","fragment_type":"issue_comment","sequence":3,"text":"Noting a suggestion raised during the mySociety retreat which was something along the lines of each user could be allocated a certain number of tags which they could allocate to requests. \n\nThe idea was as I understand it if tags were to be used to flag up requests of particular value / interest, they could be rationed, so any one user would have to allocate them judiciously. \n\nI think this might be getting away from tagging and more towards an \"upvoting\" system. \n\nNot crediting the idea to anyone as I might not have noted in the way they were envisaging it working.","author_login":"RichardTaylor","author_association":"NONE","created_at":"2020-11-27T19:13:49+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_775880359","fragment_type":"issue_comment","sequence":4,"text":"See URL for a campaign encouraging users to tag requests via a hashtag in the request subject. The tag is then used to make it easier to avoid duplicate requests to the same body. \n\nPresumably if there had been a public tagging feature they'd have used that.","author_login":"RichardTaylor","author_association":"NONE","created_at":"2021-02-09T11:46:03+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_775881481","fragment_type":"issue_comment","sequence":5,"text":"A WhatDoTheyKnow.com user has suggested a database field for ICO decision reference numbers, enabling linking of requests to decision notices. \n\nThis could be achieved via tagging requests, with a tag format of eg. \n\n`ICO_REF:XXXXXXX`\n\nkey:value tags are used extensively in the WhatDoTheyKnow body database, so using them when tagging requests too feels reasonable.","author_login":"RichardTaylor","author_association":"NONE","created_at":"2021-02-09T11:48:20+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_786143568","fragment_type":"issue_comment","sequence":6,"text":"Consider legal and other risks of publicising existing tags where they might to draw attention, or be deemed to draw attention, to request threads on which we've hidden material.","author_login":"RichardTaylor","author_association":"NONE","created_at":"2021-02-25T19:24:09+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114006584","fragment_type":"issue_comment","sequence":7,"text":"We could start by exposing, and perhaps allowing the public to submit, tags relating to poor public body performance:\n\n URL \n\nThere is a potential moderation issue though.","author_login":"RichardTaylor","author_association":"MEMBER","created_at":"2022-04-30T15:28:32+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1161635991","fragment_type":"issue_comment","sequence":8,"text":"If we did this we'd have to be a little careful about how it interacts with the special behaviour of some tags and showing notes based on a request's tags (#6912).\n\nLet's say we have a Note that applies to requests tagged `foo`. This would likely be deducible from the exposed tags and the note content. Users could then add `foo` to other requests and the Note would appear, whether relevant or not. Do we want e.g. #7106 to be user-controllable?\n\nWe could automatically generate a moderation notification in this scenario based on the fact that we'd know an added tag relates to a Note or special behaviour, but that creates admin work. Would we then also want to tweak the behaviour of #6912 to list out content that an in-creation Note would get added to in the case that the tag `foo` unexpectedly exists on some requests?","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-06-21T11:44:21+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173655704","fragment_type":"issue_comment","sequence":9,"text":"We could use tagging to help capture PIT extensions, which could help to differentiate between requests that are illegally late, and ones where the deadline had been legally extended. This could even feed into the Pro dashboard in some way.","author_login":"FOIMonkey","author_association":"NONE","created_at":"2022-07-04T10:36:15+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191554388","fragment_type":"issue_comment","sequence":10,"text":"We could have an admin page of \"allowed tags\" that users can suggest or add (like our body performance tags or `pit`-related tags). That would reduce the impact of users adding synonyms or tags that generate notes.","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-07-21T14:27:30+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235745778","fragment_type":"issue_comment","sequence":11,"text":"As do NARA over in the United States - their \"Citizen Archivist\" programme has volunteers doing a similar task, and makes use of tagging. They even have \"missions\" which are a targetted way of prioritising certain activities. Maybe there is merit in us looking at this?\n\n URL \n URL","author_login":"mdeuk","author_association":"COLLABORATOR","created_at":"2022-09-02T17:26:04+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2485642911","fragment_type":"issue_comment","sequence":12,"text":"This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.\nShould we decide to revisit this issue in the future, it can be reopened.","author_login":"HelenWDTK","author_association":"CONTRIBUTOR","created_at":"2024-11-19T12:55:40+08:00","repo_name":"mysociety/alaveteli","issue_id":67254835,"issue_number":2302,"issue_url":"https://github.com/mysociety/alaveteli/issues/2302","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0031","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":".so file not found?","query_context":"Getting this error after installation in Docker container\n\nCould not open library '/usr/local/bundle/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/libcld3.so': /usr/local/bundle/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/libcld3.so: cannot open shared object file: No such file or directory (LoadError)\n\nThe `.so` file is present in `/usr/local/bundle/gems/cld3-3.5.0/lib/` but not `/usr/local/bundle/gems/cld3-3.5.0/ext/cld3/libcld3.so` \n\nReproduction: URL \n URL","known_context_document_ids":["gh_issue_1510961856"],"reference_answer":"`extension_dir` is the best place for `ffi_lib` feature. We will document it at URL \n\nI did investigate all affected gems in rubygems.org and fixed them that released in 2022. see URL \n\nI'll close this issue because there is no action about this in RubyGems 3.4.x.","answer_document_id":"gh_comment_1376890386","silver_evidence_path":["gh_comment_1427068442","gh_issue_1511387812","gh_comment_1376890386"],"evidence_issue_ids":[1510961856,1511387812],"source_repo_name":"akihikodaki/cld3-ruby","source_issue_id":1510961856,"source_issue_number":37,"source_issue_url":"https://github.com/akihikodaki/cld3-ruby/issues/37","target_repo_name":"rubygems/rubygems","target_issue_id":1511387812,"target_issue_number":6205,"target_issue_url":"https://github.com/rubygems/rubygems/issues/6205","reference_anchor_document_id":"gh_comment_1427068442","reference_answer_author":"hsbt","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.3333,"target_answer_overlap":0.25},"issue_created_at":"2022-12-26T13:28:18+08:00","valid_comment_count":49,"fragments":[{"document_id":"gh_issue_1510961856","fragment_type":"issue_description","sequence":0,"text":".so file not found\nGetting this error after installation in Docker container\n\nCould not open library '/usr/local/bundle/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/libcld3.so': /usr/local/bundle/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/libcld3.so: cannot open shared object file: No such file or directory (LoadError)\n\nThe `.so` file is present in `/usr/local/bundle/gems/cld3-3.5.0/lib/` but not `/usr/local/bundle/gems/cld3-3.5.0/ext/cld3/libcld3.so` \n\nReproduction: URL \n URL","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-26T13:28:18+08:00","repo_name":"akihikodaki/cld3-ruby","issue_id":1510961856,"issue_number":37,"issue_url":"https://github.com/akihikodaki/cld3-ruby/issues/37","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1367861386","fragment_type":"issue_comment","sequence":1,"text":"tl; dr: cld3-ruby won't support the latest RubyGems until RubyGems developers figure out a reliable way to get the path to the binary. I recommend to stay away of the latest RubyGems and Ruby, which includes the lastest RubyGems for now.\n\nI authored commit 0ff7bb57a052fbdc346f28c1e1e9b097bfc606b6 but I decided *not* to merge this change. The problem of this change is that the binary won't be installed to the `lib` directory on Fedora and on Arch Linux (and potentially on other distributions as well). For details, see:\n- URL \n- URL \n\nReferring to the `lib` directory can also be problematic in the future as the binary in the directory is stated to be removed anyway: URL \n\nUnfortunately the reality is that RubyGems introduced a disruptive change without realizing its nature and there is no good workaround. I hope the situation gets better soon; only a few days have passed since Ruby 3.2.0 release anyway so let's wait a bit longer.","author_login":"akihikodaki","author_association":"OWNER","created_at":"2022-12-30T11:07:47+08:00","repo_name":"akihikodaki/cld3-ruby","issue_id":1510961856,"issue_number":37,"issue_url":"https://github.com/akihikodaki/cld3-ruby/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427068442","fragment_type":"issue_comment","sequence":2,"text":"Is there an active/open discussion against ruby gems somewhere? I see that URL was linked, but is closed now.","author_login":"josh-m-sharpe","author_association":"NONE","created_at":"2023-02-12T16:03:59+08:00","repo_name":"akihikodaki/cld3-ruby","issue_id":1510961856,"issue_number":37,"issue_url":"https://github.com/akihikodaki/cld3-ruby/issues/37","linked_issue_ids":[1511387812],"is_known_query_context":false},{"document_id":"gh_comment_1427069390","fragment_type":"issue_comment","sequence":3,"text":"I don't think so. There is a PR to document an API useful to fix the issue but it's kind of stale and does not provide an exact procedure to resolve the path: URL","author_login":"akihikodaki","author_association":"OWNER","created_at":"2023-02-12T16:08:20+08:00","repo_name":"akihikodaki/cld3-ruby","issue_id":1510961856,"issue_number":37,"issue_url":"https://github.com/akihikodaki/cld3-ruby/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1437308223","fragment_type":"issue_comment","sequence":4,"text":"@akihikodaki Please consider releasing a version compatible with ruby 3.2 even if it is not optimal for all use cases. You can release it as prerelease gem so that it has to be opted in explicitly.","author_login":"j-manu","author_association":"NONE","created_at":"2023-02-20T16:52:12+08:00","repo_name":"akihikodaki/cld3-ruby","issue_id":1510961856,"issue_number":37,"issue_url":"https://github.com/akihikodaki/cld3-ruby/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1511387812","fragment_type":"issue_description","sequence":0,"text":"Cleaning build artifact broke some of gems\n### Describe the problem as clearly as you can\n\nRelated with URL and URL \n\nI found the some of issues related object cleanup.\n\n* URL \n* URL \n\n`ffi` may uses build artifact under the `ext` directory, not installation directory. Because they couldn't require gem library via `ffi`.\n\nI didn't investigate `ffi` side yet.\n\n### Post steps to reproduce the problem\n\nbundle init; bundle add blurhash; bundle exec ruby -rblurhash -e 'puts Blurhash::VERSION'\n\n`ffi` try load under the `ext` directory like\n\n/Users/hsbt/.local/share/gem/gems/blurhash-0.1.6/lib/../ext/blurhash/encode.bundle\n\n(`$HOME/.local/share/gem` is my GEM_HOME environment)\n\n* Build files by RubyGems 3.4.1\n\n$ fd .\nCHANGELOG.md\nCODE_OF_CONDUCT.md\nGemfile\nGemfile.lock\nLICENSE.txt\nREADME.md\nRakefile\nbin/\nbin/console\nbin/setup\nblurhash.gemspec\next/\next/blurhash/\next/blurhash/Makefile\next/blurhash/encode.c\next/blurhash/encode.h\next/blurhash/extconf.rb\nlib/\nlib/blurhash/\nlib/blurhash/version.rb\nlib/blurhash.rb\nlib/encode.bundle\n\n* Build files with RubyGems 3.3.26\n\n$ fd .\nCHANGELOG.md\nCODE_OF_CONDUCT.md\nGemfile\nGemfile.lock\nLICENSE.txt\nREADME.md\nRakefile\nbin/\nbin/console\nbin/setup\nblurhash.gemspec\next/\next/blurhash/\next/blurhash/Makefile\next/blurhash/encode.bundle\next/blurhash/encode.c\next/blurhash/encode.h\next/blurhash/encode.o\next/blurhash/extconf.rb\nlib/\nlib/blurhash/\nlib/blurhash/version.rb\nlib/blurhash.rb\nlib/encode.bundle\n\n### What's the next step?\n\nI'm not sure we should revert URL yet. Because why `ffi` uses extensions under the `ext` directory. But this change may broke many of gems depends on `ffi` some of gems.","author_login":"hsbt","author_association":"MEMBER","created_at":"2022-12-27T03:04:46+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365579398","fragment_type":"issue_comment","sequence":1,"text":"If this change is intentional, we'd want to change lines like URL","author_login":"zunda","author_association":"NONE","created_at":"2022-12-27T03:15:56+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365583096","fragment_type":"issue_comment","sequence":2,"text":"I found another issue URL without `ffi` usage.\n\n`ox` relied on `ext/ox/ox.{so,bundle}` from their ruby code.","author_login":"hsbt","author_association":"MEMBER","created_at":"2022-12-27T03:28:42+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365584250","fragment_type":"issue_comment","sequence":3,"text":"I was aware of this potential problem, but I wasn't able to find out any regression in few popular gems I have tested. The question now is what's wrong. Should you rely on files in original build destination removed by `make clean` folder after successful `make install`? Per my understanding doing this is a mistake in autotools world.","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-27T03:33:04+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365586074","fragment_type":"issue_comment","sequence":4,"text":"Basically, I agreed to clean build directory with you.\n\n* `blurhash`: They should use under the `lib` directory, not `ext` directory.\n* `ruby-argon2`: Tha find logic of `ffi-compiler` is may wrong. \n* `ox`: They use `require_relative \"ox.so\"`, not `ox/ox`.\n\nI'm not sure how the impact about this. I can investigate and fix them for the current issues.","author_login":"hsbt","author_association":"MEMBER","created_at":"2022-12-27T03:40:15+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365624276","fragment_type":"issue_comment","sequence":5,"text":"I'm looking into extensions right now to revisit how they works to make it finally clear. I'm not sure that fix is handling all the use-cases yet. Currently extensions are copied into two places per following code. URL","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-27T05:30:47+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365626096","fragment_type":"issue_comment","sequence":6,"text":"This also broke this gem - URL and its predecessor\n\nIdeally this change should be opt in. There are unmaintained gems that used to work but are now broken.","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-27T05:36:23+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365627942","fragment_type":"issue_comment","sequence":7,"text":"That's seems like similar problem with ffi fixed path.\n\n URL","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-27T05:42:22+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365650249","fragment_type":"issue_comment","sequence":8,"text":"Well, turns out @eloyesp and @simi were right and I completely missed the case of using the artifacts directly when I deemed #6133 as \"mostly compatible\" at URL 🤦‍♂️ . And it does not seem that rare in retrospective since the compiled artifacts used to live relatively to the other gem files, not in some more strange location.\n\nAs per what to do, I'm not sure. For now I can move #6133 to the breaking changes section and add a note about what to do?\n\nAlso, regarding what to do, I want to note that installing to lib was supposed to be something only temporary and it was eventually planned to stop doing that. At least there's a TODO about making that change for RubyGems 4. I think the rationale being that extensions are arch-dependent, so they should be installed to an arch-dependent folder (and `lib` is not). I think the \"arch-dependent\" alternative would be `Gem.loaded_specs[ ].extension_dir`.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-27T06:36:13+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365667123","fragment_type":"issue_comment","sequence":9,"text":"There's also this ramification that I didn't think about:\n \n\nArtifacts generated at the `ext` folder (and now automatically cleaned up after installation) are the only ones with a valid `ox/ox` require path. Now that possible require path is gone. I wonder if this is also related to #6204 🤔.\n\nThinking about an ideal deprecation path here, it seems pretty messy to me 😭. We would need to warn when this kind of route is `require`'d. For that an idea would be to instead install a Ruby file that first warns and then delegates to the properly installed compiled artifact. But we'd want to display the warning only to gem authors, not to gem users, since gem users can't really do much about these warnings. I guess we'd need to detect whether the CWD is the root of the gem for that or something.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-27T07:09:41+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365674248","fragment_type":"issue_comment","sequence":10,"text":"Alternatively, since damage is done now and a fully clean deprecation path does not exist anymore, we could add a way for users to opt-out of the new behavior as suggested above, until gems are fixed and users can move on to the new version.\n\nIdeally we could make this setting configurable per gem, so that users can still benefit from the savings of cleaning up other artifacts, but that's probably overkill.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-27T07:24:24+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365686991","fragment_type":"issue_comment","sequence":11,"text":"I don't see why it should be opt out instead of opt in. Not cleaning up artefacts doesn't change any behaviour. It just uses extra diskspace, which is same as before.\n\nDisk space is cheap. I spent some 5 hours yesterday trying to figure this out. Look at the number of people who commented on URL I'm pretty sure they would have happily spent that extra diskspace\n \n\nThis was caught in our CI since we use a Dockerfile which uses the latest rubygems. Imagine someone deploying a new machine image which does that. Apps which used to work will break in production. This latest update is a **ticking time bomb**. \n\nPlease revert this change and push an update. It can be brought back as an opt in.","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-27T07:51:40+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365689940","fragment_type":"issue_comment","sequence":12,"text":"@j-manu I have explained the root of the problem at URL I don't see any place (I was looking into already) where anyone recommends (even outside of RubyGems) to use those intermediate folder artifacts. I'm still wondering why that is used in those listed gems.\n\nOriginally this was reported by unhappy users with 1GB+ gem directories with intermediate build artifacts of grpc for example ( URL or similar trouble mentioned by sassc gem if I remember well causing troubles with other usecases (tiny containers, ...).","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-27T07:57:42+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[1511387812],"is_known_query_context":false},{"document_id":"gh_comment_1365705288","fragment_type":"issue_comment","sequence":13,"text":"@simi Ok. I didn't know there were gems with such high disk usage. It makes sense for those gems.\n\nBut my point is that any system where an affected gem is used and rubygems are updated to latest (like in a setup script) will break.\n\nDoesn't it make more sense to revert the change and bring it back as opt in?","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-27T08:21:56+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365706409","fragment_type":"issue_comment","sequence":14,"text":"I also spent over the 5 hours to fix them. Don't brag about the time spent. We are considering what's the best way and for the Ruby's ecosystem.","author_login":"hsbt","author_association":"MEMBER","created_at":"2022-12-27T08:23:43+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365711715","fragment_type":"issue_comment","sequence":15,"text":"We're considering what's best, the fact that a change breaks something for someone does not necessarily mean that it needs a revert. Even if we all believe this change is a right move that benefits the majority of the community, we need to evaluate how common it is to depend on the old behavior, and how common this is going to be in the wild and make a decision.\n\nOf course, this only affects people not locking their dependencies, so a quick fix for people out there is to lock their dependency on RubyGems, which is a good practice for all your external dependencies anyways.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-27T08:32:38+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365712247","fragment_type":"issue_comment","sequence":16,"text":"It is hard to say, since personally I would not recommend to rely on `gem update --system` anywhere in automation for various (security, reliability, maintainability) reasons. For now feel free to replace that with `gem update --system 3.3.26` or any other version working well for you.\n \n\nAs mentioned before, this is not easy to make opt-in/opt-out and after release it is even much harder. Also as mentioned before, I still do see using intermediate directory artifacts as a undocumented/not recommended way of handling gem extensions. If you have any insight, feel free to share to make it easier to decide.","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-27T08:33:31+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365721757","fragment_type":"issue_comment","sequence":17,"text":"I'm not bragging about time spent. I'm comparing the time spent by various people including you to the advantage of this change - diskspace saved.\n\nPlease understand that I'm not trying to blame you or any of the maintainers. The change was made in good faith and I appreciate the effort all maintainers put in\n\nWe all have the same goals. As you said the health of Ruby's ecosystem. \n\nThis is a breaking change. The gems affected may not have been following best practices but they worked before this change and now don't.\n\nThe best practices I know for deployment involves locking the Gemfile and locking the Ruby. I have never locked the rubygems. \n\nI have already solved the problem for myself. I am only asking for a revert and opt in because I think people might find out about this by their apps breaking.","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-27T08:50:45+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365730605","fragment_type":"issue_comment","sequence":18,"text":"I understand the pragmatic side of this, and we generally try to follow it. Just want to note that according to that definition, _any_ change is a breaking change. Because anybody could be depending on anything. A breaking change is a change that breaks public, documented usages of software, like APIs or any other contracts.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-27T09:04:46+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1366091575","fragment_type":"issue_comment","sequence":19,"text":"I think that we are discussing many intermixed issues, and it is hard to solve them all with a single patch. So I would like to split the problem in parts:\n\n- There is no documented folder structure for installed ruby gems so every user use a different strategy to access built extensions. To fix this we need to document a public API to access built extensions, like: `Gem.loaded_specs[ ].extension_dir`, that works. By getting the API clear we make sure that most people interact with the gems with a simple entry point. We could also \"promote\" that API on the `ffi` docs and examples.\n\n- We need a consistent \"extensions\" path, accessible by that is correctly added to `LOAD_PATH`, as currently that folder is no consistent for git sourced gems installed with `bundler` (see here).\n\n- On the other hand, we need a patch for the current version to make it easy to workaround current issues with unmaintained gems. We can add the `--dirty` flag that disable the `clean` step altogether.\n\nMay be I'm missing some problem, but hope that the idea of _divide and conquer_ helps here.","author_login":"eloyesp","author_association":"CONTRIBUTOR","created_at":"2022-12-27T18:23:05+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1366385825","fragment_type":"issue_comment","sequence":20,"text":"These gems were not depending upon a private API but a behaviour. Rubygems did not delete build artifacts before but now it does. I'm struggling to come up with an apt analogy but it is like automatically running `make clean` after `make install`. \n\nI found a couple of other gems which are probably affected by the same problem\n* URL \n* URL","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-28T05:46:37+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1366388761","fragment_type":"issue_comment","sequence":21,"text":"@j-manu Please report the same problems after confirming and investigating them.\n\n`modelfox` case happened at Dec 21, 2022. That date is before the date of RubyGems release.","author_login":"hsbt","author_association":"MEMBER","created_at":"2022-12-28T05:54:51+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1366394531","fragment_type":"issue_comment","sequence":22,"text":"This is a bit of a philosophical discussion, but again, every change changes some behavior from something to something else. So every change is a breaking change if you depend on the old behavior. To give a stupid example, even we released RubyGems 2.4.2 to be exactly the same as RubyGems 2.4.1, except for the version number, that would be a breaking change for a gem `foo` implemented as `raise if Gem.rubygems_version > Gem::Version.new(\"2.4.1\")` 🤣.\n\nThe way I see it, not deleting build artifacts was an internal change unless we explicitly documented that the build artifacts are meant to be used (which we don't, as far as I know). Our understanding is installation artifacts installed by `make install` is what is meant to be used, not anything else.\n\nThat said, we understand some fairly popular gems were relying on this even if not officially supported in any way, and we're willing to minimize the disruption for people, so we'll make this work again somehow, at least temporarily, until we have a less disrupting way to do this.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-28T06:06:49+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1366404300","fragment_type":"issue_comment","sequence":23,"text":"Breaking Change - We will agree to disagree on this 🙂\n\nRegarding using `gem update --system` without pinning a version, here are a few examples of it being used\n\n* Discourse\n* Plots2\n* Rswag\n* Cloudserver\n* Shuttle\n* Plaid Ruby\n\nIt's a very common pattern.","author_login":"j-manu","author_association":"NONE","created_at":"2022-12-28T06:29:24+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367853469","fragment_type":"issue_comment","sequence":24,"text":"So what should one do here, realistically? Just starting an unmodified Docker image of `ruby:2.3.0` will fail to install and load some gems because of this change.\n\nShould I downgrade Rubygems inside the containers? Which version should I use? Will it work on Ruby 3.2.0 to backport to an earlier version than the shipped version?\n\nOr is the solution to fork problematic gems and fix it there? What does the fix look like? Should the compiled files be moved into `lib` until we have a better option?\n\nSorry for being a bit dense here, but I find the discussion here to be pretty spread out over multiple things, and I just want to be pragmatic for the moment to get things working again.\n \n \n\nThank you.","author_login":"Mange","author_association":"NONE","created_at":"2022-12-30T10:49:56+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367857364","fragment_type":"issue_comment","sequence":25,"text":"@Mange ignoring your tone of voice, can you share details on what's your problem? Which gems? Have you tried to update to latest gem versions?","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-30T10:59:41+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367868077","fragment_type":"issue_comment","sequence":26,"text":"Hi, I'm a developer of an affected gem (cld3). First thanks for working on this issue and proposing a fix for cld3. For cld3, this issue is tracked at: URL \n\nI'm sorry but I decided not to apply the proposed fix, which uses the `lib` directory as an alternative. One of the problems of this approach is that the copy in the `lib` directory is expected to be removed in the future, which is already noted in this issue.\n\nBut I also found another issue: apparently some distributors patch RubyGems so that it won't create the copy at the `lib` directory. The below is the patches included in Fedora and Arch Linux:\n- URL \n- URL \n\nEventually I decided not to support the latest RubyGems until a reliable way to get the binary is determined. It's been only a few days since Ruby 3.2.0 was released and I can wait a bit longer.","author_login":"akihikodaki","author_association":"NONE","created_at":"2022-12-30T11:22:57+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367870934","fragment_type":"issue_comment","sequence":27,"text":"@akihikodaki Did you try `Gem.loaded_specs[ ].extension_dir`?","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-30T11:30:59+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367874427","fragment_type":"issue_comment","sequence":28,"text":"@deivid-rodriguez @simi I'm aware of the interface but I don't introduce it to my gem yet because it seems an API not documented and I haven't seen a consensus that it is the way forward though I do think it is a promising option. I'm not in hurry so I'll just wait until the interface to be used gets decided.","author_login":"akihikodaki","author_association":"NONE","created_at":"2022-12-30T11:40:39+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367881390","fragment_type":"issue_comment","sequence":29,"text":"That's the proper way of storing compiled extensions. Anyway feel free to wait if you're not in rush. I do plan to upgrade some guides to make it clear what's recommended way of handling extensions, since we have found out (thanks to this issue) there are various practices applied and not all of them are the good ones. \n\nBtw. IMHO in your case the best would be to not vendorize the gld3 at all, and ask client to install it into standard system paths on its own (using system package manager or by compiling and installing manually). But I understand that would add additional steps to the client side and it is not possible everytime.","author_login":"simi","author_association":"MEMBER","created_at":"2022-12-30T11:59:56+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1367890831","fragment_type":"issue_comment","sequence":30,"text":"@simi I think I will wait for the updated guide; it would help greatly.\n\ncld3 is not designed in a way it can be installed as an independent library. Chromium and the Python binding just takes source files, compiles them, and link them directly. It also has a CMake build script, but it's just for compiling and doesn't have install rules (it doesn't say what header files to be copied and where the copies should be placed, for example) so it's not really useful. cld3-ruby also has its own code to convert cld3's C++ API to C so we need to build a shared object anyway.","author_login":"akihikodaki","author_association":"NONE","created_at":"2022-12-30T12:20:16+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368060144","fragment_type":"issue_comment","sequence":31,"text":"I proposed URL to get `Gem::Specification#extension_dir` documented.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2022-12-30T19:18:22+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368220252","fragment_type":"issue_comment","sequence":32,"text":"I apologize if it came off wrong. I tried to formulate myself as formal and technical as possible and just focusing on practicality, but I suppose that I didn't do it well. I'll reflect on how to make it even more cold in the future! :-)\n \n\nSome old gems cannot be installed on a newer version of Ruby.\nI want help them to fix it, but I'm not sure what API to use in any potential patches I want to send in.\nI think I would want an \"upgrade guide\" or \"here's how to install shared libraries in your gem\" instruction. Is this documented anywhere?\n\n---\n\nI should add that I'm super happy for this change. I was one of the people that had real problems with `grpc` adding gigabytes of build artifacts when installing and actually migrated away from some Google services partly for that reason. I look forward to having this change implemented.","author_login":"Mange","author_association":"NONE","created_at":"2022-12-31T14:08:20+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371249932","fragment_type":"issue_comment","sequence":33,"text":"@deivid-rodriguez this conversation has prompted a question...\n\nIt makes sense that `Gem.loaded_specs[ ].extension_dir` should be the place to put these extension artifacts. However, is there a way for the gem to know what ` ` is without hard-coding it or passing it in as a parameter? Like, to be detected from context?\n\nI was looking at the ffi-compiler code to see if there was a way to get it to output to the appropriate directory, as a strategy to get support to be automatically added to old gems that use it, like scrypt. Right now, ffi-compiler outputs to the a subdirectory of the source directory, which might be ext. At least one of the gems mentioned above has run into this issue because of artifacts created by ffi-compiler. I'm trying to figure out how ffi-compiler could detect the right output directory if it's being used to compile an ext, and again when it's being used to load the stuff it compiled earlier. But to do that, it need to know that ` ` to get the right directory.\n\nBtw, afaik scrypt is not affected by this issue despite ffi-compiler putting the output files in ext, because it doesn't use \"extconf.rb\", so its generated code isn't deleted from ext. Still, it would be better to output to the right directories.\n\nAnother gotcha is that ffi-compiler isn't really maintained anymore, and the newer fork has a different name, which means that it's not usable by old gems which reference the original name. So I'm working on trying to fix the issue in a vendored ffi-compiler gem until it gets maintained again.","author_login":"BrianHawley","author_association":"NONE","created_at":"2023-01-04T18:02:22+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371273441","fragment_type":"issue_comment","sequence":34,"text":"@BrianHawley I'm not sure if that's possible, I think the full name of the gem would need to be passed as a parameter since there's one extensions dir per gem. For example, from my Ruby installation:\n\n/Users/deivid/.asdf/installs/ruby/3.2.0/lib/ruby/gems/3.2.0/extensions/arm64-darwin-22/3.2.0/\n├── byebug-11.1.3\n│   ├── byebug\n│   │   └── byebug.bundle\n│   ├── gem.build_complete\n│   └── gem_make.out\n├── commonmarker-0.23.6\n│   ├── commonmarker\n│   │   └── commonmarker.bundle\n│   ├── gem.build_complete\n│   └── gem_make.out\n...\n\nAt URL @hsbt linked to `ffi-compiler` code and suggested we could do something about it there, but then the few fixes have gone directly to each affected gem so not sure if this is fixable inside `ffi-compiler`. Sorry I'm not able to help more, please share what you find.","author_login":"deivid-rodriguez","author_association":"MEMBER","created_at":"2023-01-04T18:25:59+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[1511387812],"is_known_query_context":false},{"document_id":"gh_comment_1372069398","fragment_type":"issue_comment","sequence":35,"text":"Hi, the fast_excel gem uses ffi to compile libxslxwriter and is also impacted by the change.\n\nThere is a PR URL which removes the `clean` task. As @Mange pointed there, I also think it's not the right move, but then I don't know how to fix, because from what I read in this issue, it seems to me the path for loading libxlsxwriter is the good one: URL \n\nI'm clearly a noob about how a gem should build extensions, install, clean, etc.. so if anyone here could tell if the related pr in fast_excel is the solution, or if the shared lib should be built at an other place then correctly loaded by ffi.\nMaybe @deivid-rodriguez, @simi, @BrianHawley ?","author_login":"sly7-7","author_association":"NONE","created_at":"2023-01-05T10:59:26+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1372682762","fragment_type":"issue_comment","sequence":36,"text":"cross referencing some other extensions:\n* levenshtein-ffi has two proposed fixes\n * URL \n * URL \n* murmurhash3\n * discussion issue URL","author_login":"jhawthorn","author_association":"CONTRIBUTOR","created_at":"2023-01-05T20:10:44+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373090734","fragment_type":"issue_comment","sequence":37,"text":"Given URL I think I can help you, @sly7-7.\n \n \n \n \n \n\nYou're already doing the no-code extconf.rb trick. I think that the `sitearchdir` var can be used to make the Makefile `install` target actually do something, then you can use `Gem.loaded_specs[\"fast_excel\"].extension_dir` to get the directory for the file you pass to `ffi_lib`.\n\nThere's nothing in that PR that makes sense, except the title. I'll make a new one if you don't get to it first.","author_login":"BrianHawley","author_association":"NONE","created_at":"2023-01-06T03:15:31+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[1511387812],"is_known_query_context":false},{"document_id":"gh_comment_1373738936","fragment_type":"issue_comment","sequence":38,"text":"@BrianHawley Thank you for the help, I think I've finally managed to find an acceptable fix. If you have the time, could you please review URL and see if that makes sense ?","author_login":"sly7-7","author_association":"NONE","created_at":"2023-01-06T14:58:39+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374386045","fragment_type":"issue_comment","sequence":39,"text":"With a few days passed I decided to revisit this issue for my gem but the situation does not seem good. People are inventing different ways to fix this one problem, which may be creating potential compatibility hazards in the future. The below is candidates of fixes I have seen so far:\n- Iterate `$LOAD_PATH`: URL \n- Search `lib` and fall back to `ext`: URL \n- Read `extension_dir` and fall back to `lib`: URL","author_login":"akihikodaki","author_association":"NONE","created_at":"2023-01-07T05:45:49+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375342517","fragment_type":"issue_comment","sequence":40,"text":"@akihikodaki I've done it that way because reading this issue, it seemed to me this is the direction rubygems is taking (mostly seing URL","author_login":"sly7-7","author_association":"NONE","created_at":"2023-01-09T09:43:15+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[1511387812],"is_known_query_context":false},{"document_id":"gh_comment_1375381618","fragment_type":"issue_comment","sequence":41,"text":"I also think `extension_dir` is the most promising one, but it is not clarified yet if we can say it is the better one than other options.\n\nAlso, it is unclear what kind of fall backs we should have. Falling back to `lib` will allow running the gem during development without installing, but there are some caveats:\n- You need to copy the binary to `lib` during development.\n- It does not work in the case where binary is copied to global `sitearchdir`.\n- If you write the code to read `extension_dir` in a wrong way, the code may still work because of the fall back and the bug may not be noticed before someone tries to install the released gem to Fedora, which does not copy binaries to `lib`.\n\nSo we may need to consolidate the method to fall back when RubyGems is not in use, or just decide to iterate `$LOAD_PATH`; it is more complex but solves all of these problems.","author_login":"akihikodaki","author_association":"NONE","created_at":"2023-01-09T10:14:28+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376890386","fragment_type":"issue_comment","sequence":42,"text":"`extension_dir` is the best place for `ffi_lib` feature. We will document it at URL \n\nI did investigate all affected gems in rubygems.org and fixed them that released in 2022. see URL \n\nI'll close this issue because there is no action about this in RubyGems 3.4.x.","author_login":"hsbt","author_association":"MEMBER","created_at":"2023-01-10T08:22:50+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376895879","fragment_type":"issue_comment","sequence":43,"text":"My plan is to add recommendations to RubyGems guides as well. Feel free to close or leave open until that is done as well.","author_login":"simi","author_association":"MEMBER","created_at":"2023-01-10T08:28:03+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1407759205","fragment_type":"issue_comment","sequence":44,"text":"As a temporary **local fix**, I went to the gem dir and compile myself, using `make`.\n\n/home/fidalgo/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/ffi-1.15.5/lib/ffi/library.rb:145:in `block in ffi_lib': Could not open library '/home/fidalgo/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/libcld3.so': /home/fidalgo/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/libcld3.so: cannot open shared object file: No such file or directory (LoadError)\n\nSo I went to `/home/fidalgo/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/cld3-3.5.0/lib/cld3/../../ext/cld3/` and just run `make` and voila, app loads again.\n\nNOTE: This is a local workaround only.","author_login":"fidalgo","author_association":"NONE","created_at":"2023-01-29T20:12:52+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1421429241","fragment_type":"issue_comment","sequence":45,"text":"You can also just copy the already-compiled file from the gem's lib/ directory. We ran into this on the `threatstack-agent-ruby` gem, which we can't fork and fix -.-","author_login":"nevinera","author_association":"NONE","created_at":"2023-02-07T20:51:27+08:00","repo_name":"rubygems/rubygems","issue_id":1511387812,"issue_number":6205,"issue_url":"https://github.com/rubygems/rubygems/issues/6205","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0032","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"StickyHeader scrolling issue.","query_context":"### Can we access your project?\n\n- [X] I give permission for members of the FlutterFlow team to access and test my project for the sole purpose of investigating this issue.\n\n### Current Behavior\n\nI have a scrollable column, with a StickyHeader inside it. The content of the StickyHeader widget is a listview. I have datapills in the header of the StickyHeader, which filter my listview below. If one scrolls down in the list view and switches to another datapill and the filtered list items length is shorter, the header of the StickyHeader jumps to the bottom of the page and resets back only if the content is touch scrolled. I tried hiding and displaying the header again after the filter is applied, but the behavior is the same. I also tried scrollto action on the content view, that didn't seem to do anything either.\n\n### Expected Behavior\n\nThe conent updates based on the filter change, but the sticky header sticks to the top. \n\n### Steps to Reproduce\n\n1. Create New Page, add navigation to the page from home page. (You may be able to do it on Home page as well instead).\n2. Add new Page State variable showItems, Boolean set to true by default. \n3. Select the column in the new page. Make it scrollable, select stretch for Cross Axis Alignment.\n4. Add StickyHeader widget inside the column.\n5. Add a Button into the header, wrap it in a row. Set the action on it to to update page state toggle the value of showItems\n6. Select the last sample list item container in the content of the sticky header, make its visibility conditional equal to page state variable showItems.\n7. Duplicate these a couple of times so the list items are scrollable down the page. \n8. Launch the application, navigate to the test page, scroll down in the list view then push the button in the header. You will notice that the header will jump to the bottom of the page.\n\n### Reproducible from Blank\n\n- [x] The steps to reproduce above start from a blank project.\n\n### Bug Report Code (Required)\n\nITFXi87huJdgrthE+qniLMZonmEwGVwbbZIRiO4aTTEjGJz1BIYMaffSS1pBONOkTWw2KEWKpHsE0uj3ivP9IMYBNSquUapCwatUZj3vWky/aoSTBsyaQ0QnAdpbGhG90YmsniJdCNNhdEIs7DiMBeeRSindNKH6Zwh9f6PHaOI=\n\n### Visual documentation\n\n<img width=\"402\" alt=\"image\" src=\" URL \n\n<img width=\"384\" alt=\"image\" src=\" URL \n\n### Environment\n\nmarkdown\n- FlutterFlow version: v5.0.2\n- Platform: Web, iOS, Android\n- Browser name and version: Chrome 129.0.6668.60 \n- Operating system and version affected: MacOS Sequoia 15.0, iOS 18\n\n### Additional Information\n\nTrying to publish my updated app with this new page in it.","known_context_document_ids":["gh_issue_2564259668"],"reference_answer":"Can't replicate the issue on Flutter v3.0.0 and sticky_headers 0.3.0. Please retest and if it's still a problem provide example so we can resolve it.","answer_document_id":"gh_comment_1127068714","silver_evidence_path":["gh_comment_2408053360","gh_issue_768639317","gh_comment_1127068714"],"evidence_issue_ids":[2564259668,768639317],"source_repo_name":"FlutterFlow/flutterflow-issues","source_issue_id":2564259668,"source_issue_number":3970,"source_issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","target_repo_name":"fluttercommunity/flutter_sticky_headers","target_issue_id":768639317,"target_issue_number":44,"target_issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","reference_anchor_document_id":"gh_comment_2408053360","reference_answer_author":"slightfoot","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.1667,"target_answer_overlap":0.0},"issue_created_at":"2024-10-03T14:47:35+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2564259668","fragment_type":"issue_description","sequence":0,"text":"StickyHeader scrolling issue.\n### Can we access your project?\n\n- [X] I give permission for members of the FlutterFlow team to access and test my project for the sole purpose of investigating this issue.\n\n### Current Behavior\n\nI have a scrollable column, with a StickyHeader inside it. The content of the StickyHeader widget is a listview. I have datapills in the header of the StickyHeader, which filter my listview below. If one scrolls down in the list view and switches to another datapill and the filtered list items length is shorter, the header of the StickyHeader jumps to the bottom of the page and resets back only if the content is touch scrolled. I tried hiding and displaying the header again after the filter is applied, but the behavior is the same. I also tried scrollto action on the content view, that didn't seem to do anything either.\n\n### Expected Behavior\n\nThe conent updates based on the filter change, but the sticky header sticks to the top. \n\n### Steps to Reproduce\n\n1. Create New Page, add navigation to the page from home page. (You may be able to do it on Home page as well instead).\n2. Add new Page State variable showItems, Boolean set to true by default. \n3. Select the column in the new page. Make it scrollable, select stretch for Cross Axis Alignment.\n4. Add StickyHeader widget inside the column.\n5. Add a Button into the header, wrap it in a row. Set the action on it to to update page state toggle the value of showItems\n6. Select the last sample list item container in the content of the sticky header, make its visibility conditional equal to page state variable showItems.\n7. Duplicate these a couple of times so the list items are scrollable down the page. \n8. Launch the application, navigate to the test page, scroll down in the list view then push the button in the header. You will notice that the header will jump to the bottom of the page.\n\n### Reproducible from Blank\n\n- [x] The steps to reproduce above start from a blank project.\n\n### Bug Report Code (Required)\n\nITFXi87huJdgrthE+qniLMZonmEwGVwbbZIRiO4aTTEjGJz1BIYMaffSS1pBONOkTWw2KEWKpHsE0uj3ivP9IMYBNSquUapCwatUZj3vWky/aoSTBsyaQ0QnAdpbGhG90YmsniJdCNNhdEIs7DiMBeeRSindNKH6Zwh9f6PHaOI=\n\n### Visual documentation\n\n<img width=\"402\" alt=\"image\" src=\" URL \n\n<img width=\"384\" alt=\"image\" src=\" URL \n\n### Environment\n\nmarkdown\n- FlutterFlow version: v5.0.2\n- Platform: Web, iOS, Android\n- Browser name and version: Chrome 129.0.6668.60 \n- Operating system and version affected: MacOS Sequoia 15.0, iOS 18\n\n### Additional Information\n\nTrying to publish my updated app with this new page in it.","author_login":"fabianjozsa","author_association":"NONE","created_at":"2024-10-03T14:47:35+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2392727535","fragment_type":"issue_comment","sequence":1,"text":"Hi @fabianjozsa, I tried to used sticky header many time, however always opted at the end for a stack, reason being was that annoying jiggling effect that the header has when you scroll the list below (even when setting fixed hardcoded height and width sizes). Have you find a solution for that? Do you get that jiggling jumping like weird thing it does when scrolling?","author_login":"Kato-Official","author_association":"NONE","created_at":"2024-10-04T03:35:20+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2392733183","fragment_type":"issue_comment","sequence":2,"text":"I mean this one: \n\n URL \n\nAnyone from support knows how to fix that header moving so to be \"sticky\" without moving and shaking?","author_login":"Kato-Official","author_association":"NONE","created_at":"2024-10-04T03:43:56+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2393740667","fragment_type":"issue_comment","sequence":3,"text":"Hello!\n\nI attempted to replicate the issue but was unable to do so.\n\nHere are the steps I followed:\n\n1. Created a new blank project.\n2. Set the Column on the default page as Scrollable.\n3. Added a StickyHeader.\n4. Added two buttons to toggle the value of an AppState variable.\n5. Filled the list with multiple containers to enable scrolling.\n6. Ran the project in Test Mode.\n7. Scrolled to the bottom and tapped the button.\n\nCould you confirm if there’s anything I might have missed in these steps? I’m happy to investigate further!\n\nLooking forward to your feedback. Public Project you can clone to test and modify: URL","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2024-10-04T13:43:23+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405379354","fragment_type":"issue_comment","sequence":4,"text":"Please watch this video that shows the issue in action:\n\n URL","author_login":"fabianjozsa","author_association":"NONE","created_at":"2024-10-10T15:03:14+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405381013","fragment_type":"issue_comment","sequence":5,"text":"Didn't mean to close the issue. Please watch the video.\n\n URL","author_login":"fabianjozsa","author_association":"NONE","created_at":"2024-10-10T15:03:54+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408047022","fragment_type":"issue_comment","sequence":6,"text":"**Hello,**\n\nThank you for the video. I was able to replicate the issue on my end. However, I'm still not certain whether this is a Flutter-specific problem or something that FlutterFlow can address. I'll forward this to our engineering team for further investigation.","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2024-10-11T20:00:14+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408053360","fragment_type":"issue_comment","sequence":7,"text":"I just found out this is a known issue with the package ( URL I'll add this as evidence to see if the engineer team may apply a solution","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2024-10-11T20:05:07+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[768639317],"is_known_query_context":false},{"document_id":"gh_comment_2436239399","fragment_type":"issue_comment","sequence":8,"text":"I reported this issue and others related to Sticky Header, you can check it here:\n\n URL","author_login":"Franco98404","author_association":"NONE","created_at":"2024-10-24T20:02:59+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2436874045","fragment_type":"issue_comment","sequence":9,"text":"Mate that issue was opened in Jan 25, we are now in October, maybe would be good to merge them all into one and push them back up top. @Alezanello what do you think?","author_login":"Kato-Official","author_association":"NONE","created_at":"2024-10-25T05:34:53+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":2564259668,"issue_number":3970,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/3970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_768639317","fragment_type":"issue_description","sequence":0,"text":"Headers don't get stick to top after disappearing keyboard.\nsticky_header_issue\n\nHeaders don't get stick to top when I try to disappear keyboard . it does not work as it should do. sticky header overlaps its own content . when I scroll little bit then it goes to its place on top as you can see in uploaded Gif.","author_login":"am1tr0r","author_association":"NONE","created_at":"2020-12-16T09:39:33+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_821757603","fragment_type":"issue_comment","sequence":1,"text":"still waiting for the solution.. because i have the same issue..","author_login":"masbenx","author_association":"NONE","created_at":"2021-04-17T03:20:55+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_853683623","fragment_type":"issue_comment","sequence":2,"text":"I can reproduce when entering to other page then go back. I believe it's same root cause.","author_login":"chrisynchen","author_association":"NONE","created_at":"2021-06-03T08:22:22+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1127068714","fragment_type":"issue_comment","sequence":3,"text":"Can't replicate the issue on Flutter v3.0.0 and sticky_headers 0.3.0. Please retest and if it's still a problem provide example so we can resolve it.","author_login":"slightfoot","author_association":"MEMBER","created_at":"2022-05-15T22:36:07+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1315406364","fragment_type":"issue_comment","sequence":4,"text":"Hi, I'm currently experiencing the same issue mentioned above.\nCurrently on Flutter v3.3.6 and sticky_headers 0.3.0+2.\n\nHere is the full code:\nimport 'package:flutter/material.dart';\nimport 'package:sticky_headers/sticky_headers.dart';\n\nvoid main() {\n runApp(const MyApp());\n}\n\nclass MyApp extends StatelessWidget {\n const MyApp({super.key});\n\n @override\n Widget build(BuildContext context) {\n return MaterialApp(\n title: 'Flutter Demo',\n theme: ThemeData(\n primarySwatch: Colors.blue,\n ),\n home: const MyHomePage(title: 'Flutter Demo Home Page'),\n );\n }\n}\n\nclass MyHomePage extends StatefulWidget {\n const MyHomePage({super.key, required this.title});\n final String title;\n\n @override\n State createState() => _MyHomePageState();\n}\n\nclass _MyHomePageState extends State {\n final firstList = ['Hello', 'What is up?', 'You alright?'];\n final secondList = ['Bye', 'Adios'];\n final thirdList = ['Apple', 'Banana', 'Cherry', 'Durian', 'Figs'];\n\n @override\n Widget build(BuildContext context) {\n final combinedList = [firstList, secondList, thirdList];\n return Scaffold(\n appBar: AppBar(\n title: Text(widget.title),\n ),\n body: Column(\n children: [\n Expanded(\n child: Center(\n child: CustomScrollView(\n reverse: true,\n slivers: [\n SliverList(\n delegate: SliverChildBuilderDelegate((context, index) {\n return reversedMessageList(combinedList[index]);\n }, childCount: combinedList.length)),\n ],\n ),\n ),\n ),\n TextField(\n style: Theme.of(context).textTheme.bodyText1,\n keyboardType: TextInputType.multiline,\n maxLines: 10,\n minLines: 1,\n textCapitalization: TextCapitalization.sentences,\n decoration: const InputDecoration(\n labelText: 'Message',\n ),\n ),\n ],\n ),\n floatingActionButton: FloatingActionButton(\n onPressed: () {},\n child: const Icon(Icons.add),\n ),\n );\n }\n\n Widget reversedMessageList(List messages) {\n //All messages sharing the same date, where date is displayed as StickyHeader\n return StickyHeader(\n overlapHeaders: false,\n content: Column(\n children: [\n for (int i = 0; i < messages.length; i++)\n Container(\n decoration: const BoxDecoration(\n color: Color(0xD9B2924A),\n borderRadius: BorderRadius.all(Radius.circular(20))),\n child: Padding(\n padding: const EdgeInsets.all(20),\n child: Text(messages[i])))\n ],\n ),\n header: Padding(\n padding: const EdgeInsets.all(5),\n child: Center(\n child: Container(\n decoration: const BoxDecoration(\n color: Color(0xD9590E98),\n borderRadius: BorderRadius.all(Radius.circular(20))),\n child: Padding(\n padding: const EdgeInsets.all(8),\n child: Text('Number of messages ${messages.length}'))))),\n );\n\n URL \n\n }\n}","author_login":"toasterrrrr","author_association":"NONE","created_at":"2022-11-15T14:40:36+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1333119182","fragment_type":"issue_comment","sequence":5,"text":"@slightfoot is it possible to reopen this issue? Many thanks.","author_login":"toasterrrrr","author_association":"NONE","created_at":"2022-12-01T03:38:46+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107374755","fragment_type":"issue_comment","sequence":6,"text":"A solution that works for me is to add `WidgetsBindingObserver` mixin to the widget encapsulating the list view, add it as an observer to `WidgetsBinding.instance` and implement `didChangeMetrics` as follows:\n\ndart\n@override\n void didChangeMetrics() {\n super.didChangeMetrics();\n setState(() {});\n }\n\nhope this helps","author_login":"amantoux","author_association":"NONE","created_at":"2024-05-13T11:53:15+08:00","repo_name":"fluttercommunity/flutter_sticky_headers","issue_id":768639317,"issue_number":44,"issue_url":"https://github.com/fluttercommunity/flutter_sticky_headers/issues/44","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0033","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Test dicovery doesn't provide feedback on failure?","query_context":"I find quite often my tests \"disappear\" from the test window, or discovery appears to do nothing. This is almost always because I've introduced a syntax error in the package I'm testing which results in an import failure. The reason is clear in the Python Test Log, i.e. below I forgot to install a dependency culminating in discovery failing with exit code 2. If this should happen at the very least the test sidebar should provide some indication that test discovery exited abnormally - perhaps with a highlight on the \"Show Test Output\" icon since clicking on that is the first step in resolving the issue.\n\nTest Discovery failed: \nError: ============================= test session starts ==============================\n\n \n\n import ahocorasick # pip install pyahocorasick\nE ModuleNotFoundError: No module named 'ahocorasick'\n=========================== short test summary info ============================\nERROR tests/test_label_model.py\n!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!\n===================== 5 tests collected, 1 error in 2.00s ======================\n\nTraceback (most recent call last):\n File \"/home/david/.vscode/extensions/ms-python.python-2021.7.1060902895/pythonFiles/testing_tools/run_adapter.py\", line 22, in \n main(tool, cmd, subargs, toolargs)\n File \"/home/david/.vscode/extensions/ms-python.python-2021.7.1060902895/pythonFiles/testing_tools/adapter/__main__.py\", line 100, in main\n parents, result = run(toolargs, **subargs)\n File \"/home/david/.vscode/extensions/ms-python.python-2021.7.1060902895/pythonFiles/testing_tools/adapter/pytest/_discovery.py\", line 44, in discover\n raise Exception(\"pytest discovery failed (exit code {})\".format(ec))\nException: pytest discovery failed (exit code 2)","known_context_document_ids":["gh_issue_952422800"],"reference_answer":"Hello, thank you for all your patience and assistance- your help is critical to us being able to deliver the best product to our users! A few things:\n\n1. Can you try switch your log level to trace (you can do so in the command palette) and then running it again and sending me both the logs from the `python` output channel and the `python test output` channel? I have extra error logging I've been adding and it might give some more insight.\n2. To clarify on your setup it is a multiroot workspace with multiple modules per workspace? When you talk about projects A,B,C and D are these within a specific workspace? Then where does the 40+ modules come into play?\n3. I see from that output you have a few plugins in use, does removing all of those change anything? I know you tried with the pytest-fixtures one already. `plugins: dictsdiff-0.5.8, pyfakefs-4.7.0, requests-mock-1.9.3, unordered-0.5.2, mock-3.10.0, cov-2.12.1, pytest_check-1.0.2, smtpdfix-0.4.2`\n\nThank you!","answer_document_id":"gh_comment_1751401030","silver_evidence_path":["gh_comment_1638830186","gh_issue_1796995157","gh_comment_1751401030"],"evidence_issue_ids":[952422800,1796995157],"source_repo_name":"microsoft/vscode-python","source_issue_id":952422800,"source_issue_number":16786,"source_issue_url":"https://github.com/microsoft/vscode-python/issues/16786","target_repo_name":"microsoft/vscode-python","target_issue_id":1796995157,"target_issue_number":21599,"target_issue_url":"https://github.com/microsoft/vscode-python/issues/21599","reference_anchor_document_id":"gh_comment_1638830186","reference_answer_author":"eleanorjboyd","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.4286,"target_answer_overlap":0.1594},"issue_created_at":"2021-07-26T01:50:41+08:00","valid_comment_count":43,"fragments":[{"document_id":"gh_issue_952422800","fragment_type":"issue_description","sequence":0,"text":"Test dicovery doesn't provide feedback on failure\nI find quite often my tests \"disappear\" from the test window, or discovery appears to do nothing. This is almost always because I've introduced a syntax error in the package I'm testing which results in an import failure. The reason is clear in the Python Test Log, i.e. below I forgot to install a dependency culminating in discovery failing with exit code 2. If this should happen at the very least the test sidebar should provide some indication that test discovery exited abnormally - perhaps with a highlight on the \"Show Test Output\" icon since clicking on that is the first step in resolving the issue.\n\nTest Discovery failed: \nError: ============================= test session starts ==============================\n\n \n\n import ahocorasick # pip install pyahocorasick\nE ModuleNotFoundError: No module named 'ahocorasick'\n=========================== short test summary info ============================\nERROR tests/test_label_model.py\n!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!\n===================== 5 tests collected, 1 error in 2.00s ======================\n\nTraceback (most recent call last):\n File \"/home/david/.vscode/extensions/ms-python.python-2021.7.1060902895/pythonFiles/testing_tools/run_adapter.py\", line 22, in \n main(tool, cmd, subargs, toolargs)\n File \"/home/david/.vscode/extensions/ms-python.python-2021.7.1060902895/pythonFiles/testing_tools/adapter/__main__.py\", line 100, in main\n parents, result = run(toolargs, **subargs)\n File \"/home/david/.vscode/extensions/ms-python.python-2021.7.1060902895/pythonFiles/testing_tools/adapter/pytest/_discovery.py\", line 44, in discover\n raise Exception(\"pytest discovery failed (exit code {})\".format(ec))\nException: pytest discovery failed (exit code 2)","author_login":"david-waterworth","author_association":"NONE","created_at":"2021-07-26T01:50:41+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1636212654","fragment_type":"issue_comment","sequence":1,"text":"Hello! We have just finished our testing rewrite and are beginning the roll out to users. I have tested this issue with the re-write and I am no longer reproducing the bug! If you would like to try it yourself, you need to add this setting to your users `settings.json` `\"python.experiments.optInto\": [\"pythonTestAdapter\"]`. Let me know if it doesn’t work for you and we can re-open this issue. Thanks!","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-07-14T18:11:46+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636273451","fragment_type":"issue_comment","sequence":2,"text":"Hi @eleanorjboyd, is there something else we need to do for this setting to take effect?\n\nimage","author_login":"aholmes","author_association":"NONE","created_at":"2023-07-14T18:51:43+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636277777","fragment_type":"issue_comment","sequence":3,"text":"Actually, it looks like it _kind of_ works after putting the setting in my WSL config.\n\nimage","author_login":"aholmes","author_association":"NONE","created_at":"2023-07-14T18:55:15+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636281634","fragment_type":"issue_comment","sequence":4,"text":"You can confirm you have the rewrite enabled by setting `\"python.analysis.logLevel\": \"Trace\",` in your user settings then check for `Experiment 'pythonTestAdapter'` is active in your python logs. Do you see that in your logs?","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-07-14T18:57:37+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636299487","fragment_type":"issue_comment","sequence":5,"text":"Looks like it is.\n\nimage\n\nHere are my observations so far:\n\n- The test extension takes a few seconds to appear on the left. It's the last one to \"load.\"\n- When I click on it, I first see this: \nimage\n- A couple seconds later I see what's in my prior screenshot.","author_login":"aholmes","author_association":"NONE","created_at":"2023-07-14T19:12:35+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636301830","fragment_type":"issue_comment","sequence":6,"text":"By the way, I selected to install the pre-release version of the Python extension. I'm not sure whether that's needed to test the `pythonTestAdapter` change. I was running the release version prior to this.","author_login":"aholmes","author_association":"NONE","created_at":"2023-07-14T19:14:48+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1638830186","fragment_type":"issue_comment","sequence":7,"text":"Hi! Could you send me your logs? I am wondering if there is an error there about UUIDs and if so would be connected to this: URL","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-07-17T20:33:44+08:00","repo_name":"microsoft/vscode-python","issue_id":952422800,"issue_number":16786,"issue_url":"https://github.com/microsoft/vscode-python/issues/16786","linked_issue_ids":[1796995157],"is_known_query_context":false},{"document_id":"gh_issue_1796995157","fragment_type":"issue_description","sequence":0,"text":"Test discovery (pytest) fails in multi-root workspace: \"payload UUID is not recognized\"\nType: Bug \n\n# Behaviour\n\nIt looks like test discovery was updated in the most recent Python release and it now breaks for my multi-root, multi-venv project.\n\nWhen I run discovery, I see a stream of log messages about running the pytest commands and then a lot of messages like:\n\n2023-07-10 14:31:48.395 [info] Using result resolver for discovery\n2023-07-10 14:31:48.395 [info] Using result resolver for discovery\n2023-07-10 14:31:48.395 [info] Using result resolver for discovery\n2023-07-10 14:31:48.438 [error] On data received: Error occurred because the payload UUID is not recognized\n2023-07-10 14:31:48.438 [error] On data received: Error occurred because the payload UUID is not recognized\n2023-07-10 14:31:48.438 [error] On data received: Error occurred because the payload UUID is not recognized\n2023-07-10 14:31:48.680 [info] Test server connected to a client.\n2023-07-10 14:31:48.686 [info] Test server connected to a client.\n2023-07-10 14:31:48.686 [info] Test server connected to a client.\n\nOnce the refresh completes, I'll see only one, sometimes two or my test packages int he explorer and nothing else.\n\nIt looks to me like you may have changed how tests are discovered and handled by the new test server (experiment is enabled) and the discovery processes are not communicating back to the thread that's expecting them? Or maybe only the UUID from the last spawned process is tracked so that's the only one that gets discovered?\n\n## Expected vs. Actual\n\nExpected: All of my tests to be discovered, displayed, and runnable from the test explorer. \n\nActual: Only tests from one module show up in test explorer.\n\n## Steps to reproduce:\n\n1. Create a multi-root workspace (mine has ~40 projects, 2 might be enough to trigger this?) where each project has it's own virtual environment in ` /.venv` and `python.defaultInterpreterPath: \"${workspaceFolder}/.venv/bin/python`.\n1. Define pytest tests in each of the projects\n1. Open the Test Explorer view\n1. Refresh tests if they are not auto-discovered\n\n \n\n \n# Diagnostic data\n\n- Python version (& distribution if applicable, e.g. Anaconda): 3.9.16\n- Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv\n- Value of the `python.languageServer` setting: Default\n\n`Python` output included in separate comment. Issue body too long.\n\nExtension version: 2023.12.0\nVS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)\nOS version: Windows_NT x64 10.0.19044\nModes:\nRemote OS version: Linux x64 3.10.0-1160.88.1.el7.x86_64 (**test discovery running on this remote**)\nRemote OS version: Linux x64 4.18.0-425.19.2.el8_7.x86_64\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|AMD EPYC 7763 64-Core Processor (8 x 2445)|\n|GPU Status|2d_canvas: unavailable_software canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: disabled_software multiple_raster_threads: enabled_on opengl: disabled_off rasterization: disabled_software raw_draw: disabled_off_ok video_decode: disabled_software video_encode: disabled_software vulkan: disabled_off webgl: unavailable_software webgl2: unavailable_software webgpu: unavailable_software|\n|Load (avg)|undefined|\n|Memory (System)|31.95GB (12.54GB free)|\n|Process Argv|--crash-reporter-id 87e5818c-cbab-4d10-bc7f-19efe79b03de|\n|Screen Reader|yes|\n|VM|0%|\n\n|Item|Value|\n|---|---|\n|Remote|SSH: remote.host.com (**test discovery running on this remote**)|\n|OS|Linux x64 3.10.0-1160.88.1.el7.x86_64|\n|CPUs|Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz (4 x 2499)|\n|Memory (System)|30.81GB (17.23GB free)|\n|VM|0%|\n\n|Item|Value|\n|---|---|\n|Remote|SSH: remote2.host.com|\n|OS|Linux x64 4.18.0-425.19.2.el8_7.x86_64|\n|CPUs|Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz (4 x 2500)|\n|Memory (System)|30.75GB (18.92GB free)|\n|VM|0%|\n \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383cf:30185419\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\nvserr242cf:30382550\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvsdfh931:30280409\nvshan820:30294714\nvstes263:30335439\nvscod805:30301674\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\nvsaa593:30376534\npythonvs932:30410667\npy29gd2263:30784847\nvscaat:30438848\nvsclangdf:30486550\nc4g48928:30535728\ndsvsc012cf:30540253\npynewext54:30695312\nazure-dev_surveyone:30548225\n2e4cg342:30602488\npyind779:30671433\n89544117:30613380\npythonsymbol12:30671437\nshowlangstatbar:30737416\nvsctsb:30748421\npythonms35:30701012\n03d35959:30757346\npythonfmttext:30731395\npythoncmv:30756943\nfixshowwlkth:30771522\nhideindicator:30785051\npythongtdpath:30769146\ni26e3531:30780429\npythonnosm12tcf:30779713\npythonidxpt:30784022\npythonnocebcf:30776496\nh7j2d465:30786200","author_login":"mrburrito","author_association":"NONE","created_at":"2023-07-10T15:14:18+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1629507207","fragment_type":"issue_comment","sequence":1,"text":"Also, I can't seem to turn any of the python experiments off, no matter what I do in the config file(s). Not sure if that's by design or a completely separate bug.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-07-10T18:44:50+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1629800948","fragment_type":"issue_comment","sequence":2,"text":"Hello! Looking into these bugs you reported, I appreciate all your help! In terms of the experiment does ` \"python.experiments.optOutFrom\": [\"pythonTestAdapter\"],` not work for you? Did you reload the window? If that is not working then it is a different issue so let me know. Thanks!","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-07-10T22:12:50+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1630743600","fragment_type":"issue_comment","sequence":3,"text":"`optOutFrom` works! Didn't realize that was a thing. Turning off the experiment gets my tests discoverable again, so that's a win. I'll check out the multi-root project on RHEL8 too and comment there if the symlink problem resolves the issue.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-07-11T12:34:17+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1631101194","fragment_type":"issue_comment","sequence":4,"text":"Looking into the UUID thing- one issue I have is I have trouble reproing it. Were you able to consistently get the error message `2023-07-10 14:31:48.438 [error] On data received: Error occurred because the payload UUID is not recognized`?","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-07-11T16:07:17+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1631216707","fragment_type":"issue_comment","sequence":5,"text":"Yep. It comes up every time. I'll see if I can put together an example repo I can share, but not 100% I'll be able to do that easily.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-07-11T17:28:40+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1632738881","fragment_type":"issue_comment","sequence":6,"text":"I created a sample repo you can use. When I run this on my Windows VSCode with a Linux Remote over SSH, I get the UUID errors. When I run it on my MacBook, I don't get the UUID errors but I still get the same behavior; only one project's tests show up in the explorer. Not sure why the error messages aren't showing up on the Mac and haven't tried testing locally in Windows. Hopefully this helps you find a solution!\n\n URL","author_login":"mrburrito","author_association":"NONE","created_at":"2023-07-12T15:19:10+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636300510","fragment_type":"issue_comment","sequence":7,"text":"I'm actually running into \"Error occurred because the payload UUID is not recognized\" in a single workspace scenario (`pypa/packaging`).","author_login":"brettcannon","author_association":"MEMBER","created_at":"2023-07-14T19:13:29+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636386065","fragment_type":"issue_comment","sequence":8,"text":"We figured out the root cause- its a problem with when UUIDs are being deleted when the command to the test server is done running but not when the test server is done sending the response back. Therefore the UUID is being deleted pre-maturely. Working on a fix to have the actions to happen in the correct order.","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-07-14T20:21:14+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636738085","fragment_type":"issue_comment","sequence":9,"text":"I'm desperate! Using Vscode 1.80.1 and if I put:\n\n\"python.experiments.optOutFrom\": [\"pythonTestAdapter\"]\n\nIt gets greyed out and I see this message:\n\n<img width=\"981\" alt=\"Screenshot 2023-07-15 at 12 10 10\" src=\" URL \n\nWhat in heaven does it mean!?\n\nI can't access my tests!!!","author_login":"alanwilter","author_association":"NONE","created_at":"2023-07-15T11:13:45+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636746947","fragment_type":"issue_comment","sequence":10,"text":"Well, well, I had to add this line specifically in to remote-server setting.\n\nAnd added that actually: `\"python.experiments.enabled\": false,`\n\nThis is not great. I really want to centralise all my settings in one place and make exceptions... well, when they are **exceptions**!\n\nNow I need to keep my eyes in **every** remote setup I have!\n\nI simply don't want any experimental stuff! You guys have created the Insider Vscode for what then?","author_login":"alanwilter","author_association":"NONE","created_at":"2023-07-15T12:01:21+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1638953681","fragment_type":"issue_comment","sequence":11,"text":"If you ever find yourself in a situation where the latest extension version simply is not working, you can pin to an older version that does work for you until we manage to fix the bug causing you issues.\n \n\nI wouldn't label this work as experimental. The new testing code passed through pre-release users and internal team testing. It's unfortunate this bug didn't trigger until more people were able to use the new code in more varied scenarios. It's behind an experiment flag so we can control the rollout in case of showstopper bugs, not because we are actively \"experimenting\" with our stable users (as I said, this code already passed various quality gates to even reach this level of rollout). If we had not used our experiment infrastructure to control this then this would have gone out to all users this release with no possibility for us to do an emergency rollback without pushing a new version of the extension or given you a way to opt out in any way until we made a new release with a fix.\n \n\nTo get early feedback from users willing to help us find bugs early. Obviously this didn't come up from testing with our pre-release users and are now only running across this from wider usage.","author_login":"brettcannon","author_association":"MEMBER","created_at":"2023-07-17T22:09:30+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639601576","fragment_type":"issue_comment","sequence":12,"text":"How to pin?\n\nI apologise for my ton but when one wastes a whole morning, in a weekend with a critical deadline... \nI'm not against experiments but, please, make it easier to opt-out.","author_login":"alanwilter","author_association":"NONE","created_at":"2023-07-18T06:47:58+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1640731167","fragment_type":"issue_comment","sequence":13,"text":"You can change the version in the extension view via \"Install Another Version\":\n\nimage\n\nNow if you want it to update when we push a new stable version, that's all you need to do.\n\nIf you want to stay on that version, you can turn off automatic updates for the extension:\n\nimage\n\nOtherwise you need to turn off automatic extension updates via the `extensions.autoUpdate` setting (unfortunately it's a global setting).\n \n\nApology accepted. We realize hitting any bug is annoying and we obviously do what we can to avoid it; this is why there isn't anything the extension does that you couldn't do manually (e.g., run your test suite from the command-line instead of having VS Code do it). We always strive to make sure there's no lock-in specifically to make sure we are never a complete blocker for one's work or you feel trapped by the extension.","author_login":"brettcannon","author_association":"MEMBER","created_at":"2023-07-18T18:22:57+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1682683433","fragment_type":"issue_comment","sequence":14,"text":"@eleanorjboyd I'm assuming this fix is in the latest version of the plugin? I'm still not seeing all my tests discovered. Haven't tried against the skeleton repo I sent you yet, but our actual project is only showing me one test package.\n\nAlso, it no longer shows all my subpackages as top-level elements in the test view. Instead, I have the root of our project and have to drill down our folder structure to see the tests. With the multi-root worksapce, I would still expect to see each root module as a test parent.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-08-17T17:26:29+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1682838192","fragment_type":"issue_comment","sequence":15,"text":"Still seeing the same issue with Insiders build and pre-release versions of Python/Pylance.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-08-17T19:24:44+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1747744114","fragment_type":"issue_comment","sequence":16,"text":"Hi, are you able to check if this is now resolved on insiders? I have made even more edits to the flow to hopefully not delete the UUID pre-maturely which I think was the problem. If not I will have to go a different direction for the investigation. Thanks for your help!","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-10-04T22:38:59+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1748876834","fragment_type":"issue_comment","sequence":17,"text":"Problem is still there. I'm getting a ton of these errors:\n\n The python test process was terminated before it could exit on its own, the process errored with: Code: 5, Signal: null\n2023-10-05 13:04:21.392 [error] pytest test discovery error \n\nOnce the test refresh finishes, I see the tests for one of my projects, a `pytest Discovery Error` for another that references the error messages above, and none of the other projects in the workspace. If I refresh again, the view clears and a few different projects flicker in the list as their tests get collected, but they're immediately replaced by whatever finishes next and I ended up with the view I had originally.\n\nSo... simplified version, if my workspace has projects A, B, C, and D and I refresh tests, the Test Explorer shows:\n\n- A\n-- tests\n--- unit\n---- test_xyz\n- pytest Discovery Error [B]\n\nIf I refresh tests again, I'll see the tests for C appear instead of A for about a second, then discovery completes on A and I'm back to the view above. It does look like the Discovery Error bounces between B and D with every refresh.\n\nI am able to run the tests for A once the refresh completes.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-10-05T13:14:57+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1749611725","fragment_type":"issue_comment","sequence":18,"text":"@mrburrito just to make sure, do you have any other pytest plug-ins configured?","author_login":"brettcannon","author_association":"MEMBER","created_at":"2023-10-05T20:41:36+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750701638","fragment_type":"issue_comment","sequence":19,"text":"Only one is `pytest-fixtures` which I wouldn't think would interfere with test discovery, but I'll turn it off and see if anything changes.\n\nLocal plugins:\n\nDavidAnson.vscode-markdownlint@0.52.0\ndsznajder.es7-react-js-snippets@4.4.3\neamodio.gitlens@2023.6.605\necmel.vscode-html-css@1.13.1\nfoxundermoon.shell-format@7.2.5\nGitHub.vscode-pull-request-github@0.75.2023100509\nhashicorp.terraform@2.29.2023100414\niliazeus.vscode-ansi@1.1.6\nk--kato.intellij-idea-keybindings@1.5.10\nlizebang.bash-extension-pack@0.0.4\nmads-hartmann.bash-ide-vscode@1.39.0\nmarclipovsky.string-manipulation@0.5.7\nms-azuretools.vscode-docker@1.26.1\nms-python.black-formatter@2023.5.11881008\nms-python.isort@2023.11.11881009\nms-python.python@2023.19.12791027\nms-python.vscode-pylance@2023.10.11\nms-vscode-remote.remote-containers@0.317.0\nms-vscode-remote.remote-ssh@0.106.4\nms-vscode-remote.remote-ssh-edit@0.86.0\nms-vscode-remote.remote-wsl@0.81.7\nms-vscode-remote.vscode-remote-extensionpack@0.24.0\nms-vscode.powershell@2023.6.0\nms-vscode.remote-explorer@0.4.1\nms-vscode.remote-server@1.4.3\nnickmillerdev.pytest-fixtures@0.3.3\nqux-bbb.text-utils@0.1.7\nredhat.ansible@2.7.98\nredhat.vscode-yaml@1.14.0\nRemisa.shellman@5.7.0\nrogalmic.bash-debug@0.3.9\nrpinski.shebang-snippets@0.1.4\ntimonwong.shellcheck@0.34.0\n\nRemote Plugins:\n\nDavidAnson.vscode-markdownlint@0.52.0\ndsznajder.es7-react-js-snippets@4.4.3\neamodio.gitlens@14.3.0\necmel.vscode-html-css@1.13.1\nfoxundermoon.shell-format@7.2.5\nGitHub.vscode-pull-request-github@0.74.0\nhashicorp.terraform@2.28.0\niliazeus.vscode-ansi@1.1.6\nlizebang.bash-extension-pack@0.0.4\nmads-hartmann.bash-ide-vscode@1.39.0\nmarclipovsky.string-manipulation@0.5.7\nms-azuretools.vscode-docker@1.26.1\nms-python.black-formatter@2023.4.1\nms-python.flake8@2023.9.12791029\nms-python.isort@2023.10.1\nms-python.python@2023.19.12791027\nms-python.vscode-pylance@2023.10.11\nms-vscode.powershell@2023.6.0\nnickmillerdev.pytest-fixtures@0.3.3\nqux-bbb.text-utils@0.1.7\nredhat.ansible@2.7.98\nredhat.vscode-yaml@1.14.0\nRemisa.shellman@5.7.0\nrogalmic.bash-debug@0.3.9\nrpinski.shebang-snippets@0.1.4\ntimonwong.shellcheck@0.34.0","author_login":"mrburrito","author_association":"NONE","created_at":"2023-10-06T13:40:33+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750741191","fragment_type":"issue_comment","sequence":20,"text":"Same behavior with that plugin enabled or disabled. I'm seeing a different set of tests today but still only one of my 40+ modules showing up.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-10-06T14:06:59+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750813827","fragment_type":"issue_comment","sequence":21,"text":"Not sure if this is relevant or if the discovery code accounts for it, but the pytest discovery check is returning the same ` ` top-level element for almost all of my modules.\n\nSample structure:\n\n/root_dir\n /packages\n /module1\n /module2\n /stages\n /module3\n /module4\n\nSample output:\n\n============================= test session starts ==============================\nplatform linux -- Python 3.9.16, pytest-7.2.2, pluggy-1.3.0\nrootdir: /root_dir\nplugins: dictsdiff-0.5.8, pyfakefs-4.7.0, requests-mock-1.9.3, unordered-0.5.2, mock-3.10.0, cov-2.12.1, pytest_check-1.0.2, smtpdfix-0.4.2\ncollected 10 items\n\n \n \n \n \n\n========================= 10 tests collected in 1.50s ==========================\n============================= test session starts ==============================\nplatform linux -- Python 3.9.16, pytest-7.2.2, pluggy-1.3.0\nrootdir: /root_dir\nplugins: dictsdiff-0.5.8, pyfakefs-4.7.0, requests-mock-1.9.3, unordered-0.5.2, mock-3.10.0, cov-2.12.1, pytest_check-1.0.2, smtpdfix-0.4.2\ncollected 10 items\n\n \n \n \n \n========================= 10 tests collected in 1.50s ==========================\n============================= test session starts ==============================\nplatform linux -- Python 3.9.16, pytest-7.2.2, pluggy-1.3.0\nrootdir: /root_dir\nplugins: dictsdiff-0.5.8, pyfakefs-4.7.0, requests-mock-1.9.3, unordered-0.5.2, mock-3.10.0, cov-2.12.1, pytest_check-1.0.2, smtpdfix-0.4.2\ncollected 10 items\n\n \n \n \n \n========================= 10 tests collected in 1.50s ==========================\n============================= test session starts ==============================\nplatform linux -- Python 3.9.16, pytest-7.2.2, pluggy-1.3.0\nrootdir: /root_dir\nplugins: dictsdiff-0.5.8, pyfakefs-4.7.0, requests-mock-1.9.3, unordered-0.5.2, mock-3.10.0, cov-2.12.1, pytest_check-1.0.2, smtpdfix-0.4.2\ncollected 10 items\n\n \n \n \n========================= 10 tests collected in 1.50s ==========================\n\nThat output doesn't seem to have any bearing on what gets displayed in the test explorer, though I haven't seen any of the modules with fully qualified paths show up.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-10-06T14:51:25+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1751401030","fragment_type":"issue_comment","sequence":22,"text":"Hello, thank you for all your patience and assistance- your help is critical to us being able to deliver the best product to our users! A few things:\n\n1. Can you try switch your log level to trace (you can do so in the command palette) and then running it again and sending me both the logs from the `python` output channel and the `python test output` channel? I have extra error logging I've been adding and it might give some more insight.\n2. To clarify on your setup it is a multiroot workspace with multiple modules per workspace? When you talk about projects A,B,C and D are these within a specific workspace? Then where does the 40+ modules come into play?\n3. I see from that output you have a few plugins in use, does removing all of those change anything? I know you tried with the pytest-fixtures one already. `plugins: dictsdiff-0.5.8, pyfakefs-4.7.0, requests-mock-1.9.3, unordered-0.5.2, mock-3.10.0, cov-2.12.1, pytest_check-1.0.2, smtpdfix-0.4.2`\n\nThank you!","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-10-06T21:04:24+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1794728276","fragment_type":"issue_comment","sequence":23,"text":"Oops. Somehow missed that last comment. I'll respond with details in a few minutes.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-11-06T12:38:29+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1794849105","fragment_type":"issue_comment","sequence":24,"text":"1. I'll try to bump logging and attach. If I can reproduce with my bare bones example project, it'll be pretty straightforward, otherwise I need to do some log cleanup and might take a bit.\n\n2. I may be confusing things with terminology. I have a multi-root workspace with ~60 defined roots. All but 5-6 of those have their own Python environment defined with pytest tests. We do have them organized into smaller subsets (e.g. stages, packages, etc. as I described above), but from a VSCode view, everything is on one level, so my roots might be:\n\n \n\n packages :: A (./packages/A)\n packages :: B (./packages/B)\n stages :: C (./stages/C)\n stages :: D (./stages/D)\n \n\n When I'm refreshing tests, I might see the tests for `packages :: A`, then refresh and see only the tests for `stages :: C`, but never all of the tests.\n\n3. Those are pytest plugins, not VSCode extensions. Can't really disable them because they're in use by our tests.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-11-06T13:39:58+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1795071625","fragment_type":"issue_comment","sequence":25,"text":"That test run is from this example repository. It replicates the behavior I see on my real project and answers your question 3 above since it doesn't use any pytest plugins. It's also almost identical in structure to my real repo (question 2), though that's grown by a few roots since I created the example.\n\n URL","author_login":"mrburrito","author_association":"NONE","created_at":"2023-11-06T15:18:21+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1797018326","fragment_type":"issue_comment","sequence":26,"text":"Hello, thank you for the detailed logs and all the notes I really appreciate it. I am going out of office for the next 3 weeks and therefore will not be able to help in this time. I will loop in @karthiknadig in case you have outstanding questions to get by in the meantime.\n\nAdditional, @karthiknadig do you know what this log is saying / if it might impact?\n\n2023-11-06 14:16:30.540 [warning] Failed to check if /alt/source/vscode-test-discovery/group1/group1_p3/.venv/bin/python is an executable [Error: ENOENT: no such file or directory, lstat '/alt/source/vscode-test-discovery/group1/group1_p3/.venv/bin/python'] {\n errno: -2,\n code: 'ENOENT',\n syscall: 'lstat',\n path: '/alt/source/vscode-test-discovery/group1/group1_p3/.venv/bin/python'\n}","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-11-06T23:20:49+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1797024672","fragment_type":"issue_comment","sequence":27,"text":"So, several of our projects don't have Python environments but it seems like the Python plugin tries to find the virtualenv anyway. I left that configuration in the example so it mirrored my actual project. Those are the Node errors that get thrown when it tries to find `${workspaceRoot}/.venv/bin/python` and it doesn't exist.","author_login":"mrburrito","author_association":"NONE","created_at":"2023-11-06T23:27:37+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1797025117","fragment_type":"issue_comment","sequence":28,"text":"realized now this isn't the problem- seeing other messages elsewhere which show it did run and this was just a warning.","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-11-06T23:28:07+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1797028997","fragment_type":"issue_comment","sequence":29,"text":"New thought actually, @karthiknadig what do you think about the theory that in this multiroot workspace case the results are attempting to be parsed by the wrong adapter (like an adapter from a different workspace) instead of the one which it actually correlates to. Therefore it would error out all the other workspaces instead of just letting them wait for their response to be returned. Thinking `this._onDataReceived.fire({ uuid: '', data: '' });` this line here if deleted might lead to success since it doesn't cause unsuccessful resolves on other workspaces. But I am unsure if I am getting the multiroot scenario correctly @karthiknadig for this to be true","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-11-06T23:30:14+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1797033220","fragment_type":"issue_comment","sequence":30,"text":"That makes sense. This should get addressed when we use the per-run named-pipe server.","author_login":"karthiknadig","author_association":"MEMBER","created_at":"2023-11-06T23:34:46+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1820422815","fragment_type":"issue_comment","sequence":31,"text":"I have the exact same problem, let me know if I can provide some feedback","author_login":"Hanspagh","author_association":"NONE","created_at":"2023-11-21T08:10:14+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1860964810","fragment_type":"issue_comment","sequence":32,"text":"update for those in this thread with symlink issues:\n\nI have put together a detailed problem report and proposed solution for symlinks. Please check it out here and contribute any thoughts you may have: URL","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2023-12-18T16:26:31+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1861882109","fragment_type":"issue_comment","sequence":33,"text":"Is the symlink fix expected to fully resolve this or is that just a related fix? I think I'm still having this problem even if I open it from the non-symlinked path (which I've been doing because of all the symlink problems!).","author_login":"mrburrito","author_association":"NONE","created_at":"2023-12-19T00:02:40+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1964869872","fragment_type":"issue_comment","sequence":34,"text":"I'm no longer on the team that was having the issues. Let me try to get somebody to test it out and get back to you! Looking to see if I can reproduce on a different project as well.","author_login":"mrburrito","author_association":"NONE","created_at":"2024-02-26T18:55:39+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2057981024","fragment_type":"issue_comment","sequence":35,"text":"@alanwilter I have re-opened the issue so we can discuss there- thanks","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2024-04-15T23:30:49+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2057981896","fragment_type":"issue_comment","sequence":36,"text":"Also closing this issue since we dont have the repro anymore but please create another issue / follow up on #22018 about symlinks so we can discuss any ongoing problems","author_login":"eleanorjboyd","author_association":"MEMBER","created_at":"2024-04-15T23:31:50+08:00","repo_name":"microsoft/vscode-python","issue_id":1796995157,"issue_number":21599,"issue_url":"https://github.com/microsoft/vscode-python/issues/21599","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0034","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Error deploying Wazuh Indexer cluster via Puppet?","query_context":"|Wazuh version|Component|Install type|Install method|Platform|\n|---|---|---|---|---|\n| 4.6.0 Beta 1 | Wazuh component | Indexer | Puppet | Ubuntu 18.04|\n\nI discovered in the test carried out in this issue that, deploying indexer cluster via puppet isn't successful. Each indexer node is installed and configured separately but are not part of the same cluster.\n\nTesting the Wazuh indexer cluster with the security admin script provides the output below showing only one node:\n\nconsole\nroot@indexer2:/home/rolly# /usr/share/wazuh-indexer/bin/indexer-security-init.sh\n**************************************************************************\n** This tool will be deprecated in the next major release of OpenSearch **\n** URL **\n**************************************************************************\nSecurity Admin v7\nWill connect to 127.0.0.1:9200 ... done\nConnected as \"CN=admin,OU=Wazuh,O=Wazuh,L=California,C=US\"\nOpenSearch Version: 2.8.0\nContacting opensearch cluster 'opensearch' and wait for YELLOW clusterstate ...\nClustername: wazuh-cluster\nClusterstate: GREEN\nNumber of nodes: 1\nNumber of data nodes: 1\n.opendistro_security index does not exists, attempt to create it ... done (0-all replicas)\nPopulate config from /etc/wazuh-indexer/opensearch-security/\nWill update '/config' with /etc/wazuh-indexer/opensearch-security/config.yml\n SUCC: Configuration for 'config' created or updated\nWill update '/roles' with /etc/wazuh-indexer/opensearch-security/roles.yml\n SUCC: Configuration for 'roles' created or updated\nWill update '/rolesmapping' with /etc/wazuh-indexer/opensearch-security/roles_mapping.yml\n SUCC: Configuration for 'rolesmapping' created or updated\nWill update '/internalusers' with /etc/wazuh-indexer/opensearch-security/internal_users.yml\n SUCC: Configuration for 'internalusers' created or updated\nWill update '/actiongroups' with /etc/wazuh-indexer/opensearch-security/action_groups.yml\n SUCC: Configuration for 'actiongroups' created or updated\nWill update '/tenants' with /etc/wazuh-indexer/opensearch-security/tenants.yml\n SUCC: Configuration for 'tenants' created or updated\nWill update '/nodesdn' with /etc/wazuh-indexer/opensearch-security/nodes_dn.yml\n SUCC: Configuration for 'nodesdn' created or updated\nWill update '/whitelist' with /etc/wazuh-indexer/opensearch-security/whitelist.yml\n SUCC: Configuration for 'whitelist' created or updated\nWill update '/audit' with /etc/wazuh-indexer/opensearch-security/audit.yml\n SUCC: Configuration for 'audit' created or updated\nWill update '/allowlist' with /etc/wazuh-indexer/opensearch-security/allowlist.yml\n SUCC: Configuration for 'allowlist' created or updated\nSUCC: Expected 10 config types for node {\"updated_config_types\":[\"allowlist\",\"tenants\",\"rolesmapping\",\"nodesdn\",\"audit\",\"roles\",\"whitelist\",\"internalusers\",\"actiongroups\",\"config\"],\"updated_config_size\":10,\"message\":null} is 10 ([\"allowlist\",\"tenants\",\"rolesmapping\",\"nodesdn\",\"audit\",\"roles\",\"whitelist\",\"internalusers\",\"actiongroups\",\"config\"]) due to: null\nDone with success\n\nAlso although dashboard deployment was not part of the test description, I however tried to install but got the following error when trying to access via URL.\n\nimage\n\nThe dashboard error log shows the following:\n\nconsole\nroot@dashboard:/home/rolly# tail /tmp/wazuh-dashboard.log\nOct 04 11:33:15 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:15Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:17 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:17Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:20 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:20Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:22 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:22Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:25 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:25Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:27 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:27Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:30 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:30Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:32 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:32Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:35 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:35Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:37 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:37Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\n\nThe dashboard searches for the indexer on `localhost` instead of its IP address(`192.168.21.170` or `192.168.21.171` in the case of this test)","known_context_document_ids":["gh_issue_1926015553"],"reference_answer":"I did a test installation with the classes for distributed installation and found several problems:\n\nIt was necessary to declare each of the nodes and they were fixed, so I opted to modify the code of the `indexer_dist.pp` class so that it does not configure any parameters of the `opensearch.yml` template except the default values and that they are assigned in the installation manifest\n\nThe config.yml file for the creation of the certificates has fixed values assigned and I am investigating how to be able to assign these values of each node by means of an array, which should have a pair of values for each item (node name, ip) So I continue with the investigation to review how to assign these values to the creation template of the `config.yml` file.\n\nModifying the `indexer_dist.yml` manifest allowed me to deploy an AIO environment, but it requires a different configuration of the install manifest than what we currently have:\n\n$discovery_type = 'single'\nstage { 'certificates': }\nstage { 'repo': }\nstage { 'indexerdeploy': }\nstage { 'securityadmin': }\nstage { 'dashboard': }\nstage { 'manager': }\nStage[certificates] -> Stage[repo] -> Stage[indexerdeploy] -> Stage[securityadmin] -> Stage[manager] -> Stage[dashboard]\nExec {\n timeout => 0,\n}\nnode \"ip-172-31-35-35.us-east-2.compute.internal\" {\n class { 'wazuh::certificates_dist': \n stage => certificates,\n }\n class { 'wazuh::repo_use':\n stage => repo,\n }\n class { 'wazuh::indexer_dist':\n stage => indexerdeploy,\n }\n class { 'wazuh::manager':\n manage_repos => false,\n stage => manager,\n }\n class { 'wazuh::filebeat_oss_dist':\n stage => manager,\n }\n class { 'wazuh::dashboard_dist':\n stage => dashboard,\n }\n}","answer_document_id":"gh_comment_1581435077","silver_evidence_path":["gh_comment_1748688373","gh_issue_1562978439","gh_comment_1581435077"],"evidence_issue_ids":[1926015553,1562978439],"source_repo_name":"wazuh/wazuh","source_issue_id":1926015553,"source_issue_number":19405,"source_issue_url":"https://github.com/wazuh/wazuh/issues/19405","target_repo_name":"wazuh/wazuh-puppet","target_issue_id":1562978439,"target_issue_number":632,"target_issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","reference_anchor_document_id":"gh_comment_1748688373","reference_answer_author":"vcerenu","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.2222,"target_answer_overlap":0.3571},"issue_created_at":"2023-10-04T11:36:18+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1926015553","fragment_type":"issue_description","sequence":0,"text":"Error deploying Wazuh Indexer cluster via Puppet\n|Wazuh version|Component|Install type|Install method|Platform|\n|---|---|---|---|---|\n| 4.6.0 Beta 1 | Wazuh component | Indexer | Puppet | Ubuntu 18.04|\n\nI discovered in the test carried out in this issue that, deploying indexer cluster via puppet isn't successful. Each indexer node is installed and configured separately but are not part of the same cluster.\n\nTesting the Wazuh indexer cluster with the security admin script provides the output below showing only one node:\n\nconsole\nroot@indexer2:/home/rolly# /usr/share/wazuh-indexer/bin/indexer-security-init.sh\n**************************************************************************\n** This tool will be deprecated in the next major release of OpenSearch **\n** URL **\n**************************************************************************\nSecurity Admin v7\nWill connect to 127.0.0.1:9200 ... done\nConnected as \"CN=admin,OU=Wazuh,O=Wazuh,L=California,C=US\"\nOpenSearch Version: 2.8.0\nContacting opensearch cluster 'opensearch' and wait for YELLOW clusterstate ...\nClustername: wazuh-cluster\nClusterstate: GREEN\nNumber of nodes: 1\nNumber of data nodes: 1\n.opendistro_security index does not exists, attempt to create it ... done (0-all replicas)\nPopulate config from /etc/wazuh-indexer/opensearch-security/\nWill update '/config' with /etc/wazuh-indexer/opensearch-security/config.yml\n SUCC: Configuration for 'config' created or updated\nWill update '/roles' with /etc/wazuh-indexer/opensearch-security/roles.yml\n SUCC: Configuration for 'roles' created or updated\nWill update '/rolesmapping' with /etc/wazuh-indexer/opensearch-security/roles_mapping.yml\n SUCC: Configuration for 'rolesmapping' created or updated\nWill update '/internalusers' with /etc/wazuh-indexer/opensearch-security/internal_users.yml\n SUCC: Configuration for 'internalusers' created or updated\nWill update '/actiongroups' with /etc/wazuh-indexer/opensearch-security/action_groups.yml\n SUCC: Configuration for 'actiongroups' created or updated\nWill update '/tenants' with /etc/wazuh-indexer/opensearch-security/tenants.yml\n SUCC: Configuration for 'tenants' created or updated\nWill update '/nodesdn' with /etc/wazuh-indexer/opensearch-security/nodes_dn.yml\n SUCC: Configuration for 'nodesdn' created or updated\nWill update '/whitelist' with /etc/wazuh-indexer/opensearch-security/whitelist.yml\n SUCC: Configuration for 'whitelist' created or updated\nWill update '/audit' with /etc/wazuh-indexer/opensearch-security/audit.yml\n SUCC: Configuration for 'audit' created or updated\nWill update '/allowlist' with /etc/wazuh-indexer/opensearch-security/allowlist.yml\n SUCC: Configuration for 'allowlist' created or updated\nSUCC: Expected 10 config types for node {\"updated_config_types\":[\"allowlist\",\"tenants\",\"rolesmapping\",\"nodesdn\",\"audit\",\"roles\",\"whitelist\",\"internalusers\",\"actiongroups\",\"config\"],\"updated_config_size\":10,\"message\":null} is 10 ([\"allowlist\",\"tenants\",\"rolesmapping\",\"nodesdn\",\"audit\",\"roles\",\"whitelist\",\"internalusers\",\"actiongroups\",\"config\"]) due to: null\nDone with success\n\nAlso although dashboard deployment was not part of the test description, I however tried to install but got the following error when trying to access via URL.\n\nimage\n\nThe dashboard error log shows the following:\n\nconsole\nroot@dashboard:/home/rolly# tail /tmp/wazuh-dashboard.log\nOct 04 11:33:15 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:15Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:17 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:17Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:20 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:20Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:22 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:22Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:25 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:25Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:27 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:27Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:30 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:30Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:32 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:32Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:35 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:35Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\nOct 04 11:33:37 dashboard opensearch-dashboards[6486]: {\"type\":\"log\",\"@timestamp\":\"2023-10-04T11:33:37Z\",\"tags\":[\"error\",\"opensearch\",\"data\"],\"pid\":6486,\"message\":\"[ConnectionError]: connect ECONNREFUSED 127.0.0.1:9200\"}\n\nThe dashboard searches for the indexer on `localhost` instead of its IP address(`192.168.21.170` or `192.168.21.171` in the case of this test)","author_login":"Rolly-M","author_association":"MEMBER","created_at":"2023-10-04T11:36:18+08:00","repo_name":"wazuh/wazuh","issue_id":1926015553,"issue_number":19405,"issue_url":"https://github.com/wazuh/wazuh/issues/19405","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1748688373","fragment_type":"issue_comment","sequence":1,"text":"Currently, the wazuh-puppet repository does not allow a distributed deployment.\nIt will be included in `4.8.0` with this issue:\n- URL","author_login":"teddytpc1","author_association":"MEMBER","created_at":"2023-10-05T11:21:03+08:00","repo_name":"wazuh/wazuh","issue_id":1926015553,"issue_number":19405,"issue_url":"https://github.com/wazuh/wazuh/issues/19405","linked_issue_ids":[1562978439],"is_known_query_context":false},{"document_id":"gh_comment_1748698914","fragment_type":"issue_comment","sequence":2,"text":"We will continue the distributed deployment development here:\n- URL","author_login":"teddytpc1","author_association":"MEMBER","created_at":"2023-10-05T11:28:48+08:00","repo_name":"wazuh/wazuh","issue_id":1926015553,"issue_number":19405,"issue_url":"https://github.com/wazuh/wazuh/issues/19405","linked_issue_ids":[1562978439],"is_known_query_context":false},{"document_id":"gh_issue_1562978439","fragment_type":"issue_description","sequence":0,"text":"Add option for distributed deploy\nIn the documentation of Wazuh Puppet deploy only have an example for deploy an AIO and it is necessary add another example about deployment with distributed servers.","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-01-30T18:29:48+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1414297472","fragment_type":"issue_comment","sequence":1,"text":"An analysis was made of the changes that are required on the wazuh-puppet repository in order to deploy a distributed environment:\nModify the use of the template for the config.yml. The config.yml file that is currently used is a fixed template that only contains this data:\n\n yaml\n# config.yml\nnodes:\n indexer:\n -name: indexer\n ip: 127.0.0.1\n server:\n - name: server\n ip: 127.0.0.1\n dashboard:\n - name: dashboard\n ip: 127.0.0.1\n\nIt is necessary to modify the wazuh::certificates class so that when creating the certificates it creates a config.yml file according to the environment that is going to be deployed.\n\nModify the movement of the `.pem` and `key.pem` keys of each node. These files are created on the same server where Wazuh indexer is going to be deployed, so when moving these files it only moves them to the corresponding directories. This process is generated with hard coded data, since just as the config.yml file is fixed, so are the names of the keys and that is why it performs a move of the exact files, without taking into account variables and so on.\n\nIn itself, the dynamics of the current AIO and the distributed environment are very different, since each current class of each product is almost independent, so at the time of installation they do not require previous steps as if the distributed environment requires and it is extremely necessary that the certificates of each domain are generated in one location and then moved, or at least a unique root-ca is generated. Then each node creates its certificates with this root-ca in common, which is currently not contemplated and is done in a very simple way on a single server.","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-02-02T20:02:14+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1416341504","fragment_type":"issue_comment","sequence":2,"text":"A new manifest was created where the wazuh::indexer class is declared, which mainly removes many hardcoded options and allows using variables for indexer deployment with more than one node, such as the list of nodes to install.\n\nA new template of the config,yml file was created, to be able to assign variables with the names and IPs of all the nodes for which a certificate is going to be generated. The previous template was too basic and was hardcoded with the names and IPs that belonged to localhost, the new template contemplates different variables assignable by the deployment manifest:\n\n yaml\nnodes:\n indexer:\n - name: indexer- \n ip: \n - name: indexer- \n ip: \n - name: indexer- \n ip: \n server:\n -name: manager-master\n ip: \n node_type: master\n -name: manager-worker\n ip: \n node_type: worker\n dashboard:\n - name: dashboard\n ip: \n\nA new opensearch.yml template was created since the previous one had the names of all the node certificates hardcoded, so it is necessary to change these values.\n\nThe section where the securityadmin was executed, which only has to be run on the main node of the cluster, was removed from within the indexer manifest, and a new class was created to perform this action later.\n\nWe worked on a new deployment script, it is not finished but its objective is to be able to assign the necessary variables for the deployment beforehand, such as the names of the nodes and their IPs:\n\n ruby\n$node1-ip =\n$node2-ip =\n$node3-ip =\n$master-ip =\n$worker-ip =\n$dashboard-ip =\n$indexer_node1_name = 'node1'\n$indexer_node2_name = 'node2'\n$indexer_node3_name = 'node3'\n\nclass['wazuh::certificates-dist']\n\nnode \"node1\" {\n if $facts['os']['family'] == 'Debian' {\n Class['wazuh::repo'] -> Class['apt::update'] -> Package['wazuh-indexer']\n } else {\n Class['wazuh::repo'] -> Package['wazuh-indexer']\n }\n class { 'wazuh::indexer-dist':\n indexer_node_name => \"$indexer_node1_name\",\n indexer_network_host => \"$node1-ip\",\n }\n}\nnode \"node2\" {\n if $facts['os']['family'] == 'Debian' {\n Class['wazuh::repo'] -> Class['apt::update'] -> Package['wazuh-indexer']\n } else {\n Class['wazuh::repo'] -> Package['wazuh-indexer']\n }\n class { 'wazuh::indexer-dist':\n indexer_node_name => \"$indexer_node2_name\",\n indexer_network_host => \"$node2-ip\",\n }\n}\nnode \"node3\" {\n if $facts['os']['family'] == 'Debian' {\n Class['wazuh::repo'] -> Class['apt::update'] -> Package['wazuh-indexer']\n } else {\n Class['wazuh::repo'] -> Package['wazuh-indexer']\n }\n class { 'wazuh::indexer-dist':\n indexer_node_name => \"$indexer_node3_name\",\n indexer_network_host => \"$node3-ip\",\n }\n}\n\nTests must be done and verification of running securityadmin at the end of the installation and subsequent transfer of the previously created certificates.","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-02-03T20:00:57+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1442249999","fragment_type":"issue_comment","sequence":3,"text":"The configuration of the distributed environment of Wazuh through Puppet is finished.\n\nFor the installation, the following manifest must be executed, adding the names of the Puppet agent nodes to each one and adding the necessary IPs.\n\n rb\n$node1host = '172.31.2.205'\n$node2host = '172.31.12.65'\n$node3host = '172.31.6.144'\n$masterhost = '172.31.2.205'\n$workerhost = '172.31.12.65'\n$dashboardhost = '172.31.6.144'\n$indexer_node1_name = 'node1'\n$indexer_node2_name = 'node2'\n$indexer_node3_name = 'node3'\n$cluster_size = '3'\n# Define stage for order execution\nstage { 'certificates': }\nstage { 'repo': }\nstage { 'indexerdeploy': }\nstage { 'securityadmin': }\nstage { 'dashboard': }\nstage { 'manager': }\nStage[certificates] -> Stage[repo] -> Stage[indexerdeploy] -> Stage[securityadmin] -> Stage[manager] -> Stage[dashboard]\nExec {\n timeout => 0,\n}\n\nnode \"ip-172-31-18-215.us-west-1.compute.internal\" {\n class { 'wazuh::certificates_dist': \n stage => certificates,\n }\n}\nnode \"ip-172-31-2-205.us-west-1.compute.internal\" {\n class { 'wazuh::repo_use':\n stage => repo,\n }\n class { 'wazuh::indexer_dist':\n indexer_node_name => \"$indexer_node1_name\",\n indexer_network_host => \"$node1host\",\n indexer_node_max_local_storage_nodes => \"$cluster_size\",\n stage => indexerdeploy,\n }\n class { 'wazuh::securityadmin':\n stage => securityadmin,\n }\n class { 'wazuh::manager':\n ossec_cluster_name => 'wazuh-cluster',\n ossec_cluster_node_name => 'wazuh-master',\n ossec_cluster_node_type => 'master',\n ossec_cluster_key => '01234567890123456789012345678912',\n ossec_cluster_bind_addr => \"$masterhost\",\n ossec_cluster_nodes => [\"$masterhost\"],\n manage_repos => false,\n ossec_cluster_disabled => 'no',\n stage => manager,\n }\n class { 'wazuh::filebeat_oss_dist':\n filebeat_oss_indexer_ip => \"$node1host\",\n stage => manager,\n }\n}\nnode \"ip-172-31-12-65.us-west-1.compute.internal\" {\n class { 'wazuh::repo_use':\n stage => repo,\n }\n class { 'wazuh::indexer_dist':\n indexer_node_name => \"$indexer_node2_name\",\n indexer_network_host => \"$node2host\",\n indexer_node_max_local_storage_nodes => \"$cluster_size\",\n stage => indexerdeploy,\n }\n class { 'wazuh::manager':\n ossec_cluster_name => 'wazuh-cluster',\n ossec_cluster_node_name => 'wazuh-worker',\n ossec_cluster_node_type => 'worker',\n ossec_cluster_key => '01234567890123456789012345678912',\n ossec_cluster_bind_addr => \"$masterhost\",\n ossec_cluster_nodes => [\"$masterhost\"],\n manage_repos => false,\n ossec_cluster_disabled => 'no',\n stage => manager,\n }\n}\nnode \"ip-172-31-6-144.us-west-1.compute.internal\" {\n class { 'wazuh::repo_use':\n stage => repo,\n }\n class { 'wazuh::indexer_dist':\n indexer_node_name => \"$indexer_node3_name\",\n indexer_network_host => \"$node3host\",\n indexer_node_max_local_storage_nodes => \"$cluster_size\",\n stage => indexerdeploy,\n }\n class { 'wazuh::dashboard_dist':\n indexer_server_ip => \"$node1host\",\n manager_api_host => \"$masterhost\",\n stage => dashboard,\n }\n}\n\nThe manifest has several stages, in which the certificates are created in the Puppet server, they are moved to the directory of one of the modules, which will serve to later move the certificates to the necessary agents, then proceed to install Wazuh indexer on each node, securityadmin is run and then Wazuh manager (master and worker) and Wazuh dashboard are installed.","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-02-23T18:36:14+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1581435077","fragment_type":"issue_comment","sequence":4,"text":"I did a test installation with the classes for distributed installation and found several problems:\n\nIt was necessary to declare each of the nodes and they were fixed, so I opted to modify the code of the `indexer_dist.pp` class so that it does not configure any parameters of the `opensearch.yml` template except the default values and that they are assigned in the installation manifest\n\nThe config.yml file for the creation of the certificates has fixed values assigned and I am investigating how to be able to assign these values of each node by means of an array, which should have a pair of values for each item (node name, ip) So I continue with the investigation to review how to assign these values to the creation template of the `config.yml` file.\n\nModifying the `indexer_dist.yml` manifest allowed me to deploy an AIO environment, but it requires a different configuration of the install manifest than what we currently have:\n\n$discovery_type = 'single'\nstage { 'certificates': }\nstage { 'repo': }\nstage { 'indexerdeploy': }\nstage { 'securityadmin': }\nstage { 'dashboard': }\nstage { 'manager': }\nStage[certificates] -> Stage[repo] -> Stage[indexerdeploy] -> Stage[securityadmin] -> Stage[manager] -> Stage[dashboard]\nExec {\n timeout => 0,\n}\nnode \"ip-172-31-35-35.us-east-2.compute.internal\" {\n class { 'wazuh::certificates_dist': \n stage => certificates,\n }\n class { 'wazuh::repo_use':\n stage => repo,\n }\n class { 'wazuh::indexer_dist':\n stage => indexerdeploy,\n }\n class { 'wazuh::manager':\n manage_repos => false,\n stage => manager,\n }\n class { 'wazuh::filebeat_oss_dist':\n stage => manager,\n }\n class { 'wazuh::dashboard_dist':\n stage => dashboard,\n }\n}","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-06-07T20:05:47+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1601645893","fragment_type":"issue_comment","sequence":5,"text":"Made all documentation changes in the URL branch and created the PR URL pull/6186 for approval.","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-06-21T20:42:54+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1787406010","fragment_type":"issue_comment","sequence":6,"text":"The commits of this change were taken to merge to the 4.8.0 branch, a complete deployment was tested with 3 `Wazuh indexer` nodes, 1 `Wazuh dashboard`, 1 `Wazuh manager` master and 1 `Wazuh manager` worker and the deployment was carried out successfully.\n\n$node1host = '172.31.23.191'\n$node2host = '172.31.28.121'\n$node3host = '172.31.24.156'\n$masterhost = '172.31.28.245'\n$workerhost = '172.31.28.97'\n$dashboardhost = '172.31.31.95'\n$indexer_node1_name = 'node1'\n$indexer_node2_name = 'node2'\n$indexer_node3_name = 'node3'\n$cluster_size = '3'\n$indexer_discovery_hosts = [$node1host, $node2host, $node3host]\n$indexer_cluster_initial_master_nodes = [$node1host, $node2host, $node3host]\n$indexer_cluster_CN = [$indexer_node1_name, $indexer_node2_name, $indexer_node3_name]\n# Define stage for order execution\nstage { 'certificates': }\nstage { 'repo': }\nstage { 'indexerdeploy': }\nstage { 'securityadmin': }\nstage { 'dashboard': }\nstage { 'manager': }\nstage { 'agent': }\nStage[certificates] -> Stage[repo] -> Stage[indexerdeploy] -> Stage[securityadmin] -> Stage[manager] -> Stage[dashboard] -> Stage[agent]\nExec {\n timeout => 0,\n}\nnode \"ip-172-31-26-67.us-west-1.compute.internal\" {\n class { 'wazuh::certificates': \n indexer_certs => [[\"$indexer_node1_name\",\"$node1host\" ],[\"$indexer_node2_name\",\"$node2host\" ],[\"$indexer_node3_name\",\"$node3host\" ]],\n manager_master_certs => [['master',\"$masterhost\"]],\n manager_worker_certs => [['worker',\"$workerhost\"]],\n dashboard_certs => [\"$dashboardhost\"],\n stage => certificates,\n }\n class { 'wazuh::repo':\n stage => repo,\n }\n}\nnode \"ip-172-31-23-191.us-west-1.compute.internal\" {\n class { 'wazuh::repo':\n stage => repo,\n }\n class { 'wazuh::indexer':\n indexer_node_name => \"$indexer_node1_name\",\n indexer_network_host => \"$node1host\",\n indexer_node_max_local_storage_nodes => \"$cluster_size\",\n indexer_discovery_hosts => $indexer_discovery_hosts,\n indexer_cluster_initial_master_nodes => $indexer_cluster_initial_master_nodes,\n indexer_cluster_CN => $indexer_cluster_CN,\n stage => indexerdeploy,\n }\n class { 'wazuh::securityadmin':\n stage => securityadmin,\n }\n}\nnode \"ip-172-31-28-121.us-west-1.compute.internal\" {\n class { 'wazuh::repo':\n stage => repo,\n }\n class { 'wazuh::indexer':\n indexer_node_name => \"$indexer_node2_name\",\n indexer_network_host => \"$node2host\",\n indexer_node_max_local_storage_nodes => \"$cluster_size\",\n indexer_discovery_hosts => $indexer_discovery_hosts,\n indexer_cluster_initial_master_nodes => $indexer_cluster_initial_master_nodes,\n indexer_cluster_CN => $indexer_cluster_CN,\n stage => indexerdeploy,\n }\n}\nnode \"ip-172-31-24-156.us-west-1.compute.internal\" {\n class { 'wazuh::repo':\n stage => repo,\n }\n class { 'wazuh::indexer':\n indexer_node_name => \"$indexer_node3_name\",\n indexer_network_host => \"$node3host\",\n indexer_node_max_local_storage_nodes => \"$cluster_size\",\n indexer_discovery_hosts => $indexer_discovery_hosts,\n indexer_cluster_initial_master_nodes => $indexer_cluster_initial_master_nodes,\n indexer_cluster_CN => $indexer_cluster_CN,\n stage => indexerdeploy,\n }\n}\n node \"ip-172-31-28-245.us-west-1.compute.internal\" { \n class { 'wazuh::repo':\n stage => repo,\n }\n class { 'wazuh::manager':\n ossec_cluster_name => 'wazuh-cluster',\n ossec_cluster_node_name => 'wazuh-master',\n ossec_cluster_node_type => 'master',\n ossec_cluster_key => '01234567890123456789012345678912',\n ossec_cluster_bind_addr => \"$masterhost\",\n ossec_cluster_nodes => [\"$masterhost\"],\n ossec_cluster_disabled => 'no',\n stage => manager,\n }\n}\n node \"ip-172-31-28-97.us-west-1.compute.internal\" {\n class { 'wazuh::repo':\n stage => repo,\n }\n class { 'wazuh::manager':\n ossec_cluster_name => 'wazuh-cluster',\n ossec_cluster_node_name => 'wazuh-worker',\n ossec_cluster_node_type => 'worker',\n ossec_cluster_key => '01234567890123456789012345678912',\n ossec_cluster_bind_addr => \"$masterhost\",\n ossec_cluster_nodes => [\"$masterhost\"],\n ossec_cluster_disabled => 'no',\n stage => manager,\n }\n}\nnode \"ip-172-31-31-95.us-west-1.compute.internal\" {\n class { 'wazuh::repo':\n stage => repo,\n }\n class { 'wazuh::dashboard':\n indexer_server_ip => \"$node1host\",\n manager_api_host => \"$masterhost\",\n stage => dashboard,\n }\n}\n\nIn addition, the documentation was modified so that the distributed example does not try to install Wazuh agent on the nodes and the commits were moved to merge to the `4.8.0` branch of `wazuh-documentation`.","author_login":"vcerenu","author_association":"MEMBER","created_at":"2023-10-31T15:06:20+08:00","repo_name":"wazuh/wazuh-puppet","issue_id":1562978439,"issue_number":632,"issue_url":"https://github.com/wazuh/wazuh-puppet/issues/632","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0035","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"TransformerPS1S2 Issue?","query_context":"I'm having issues trying to get a 6-phase rectifier circuit to work. I sent the netlist over to the ngspice guys and they found a possible error with .SUBCKT Transformers_TransformerPS1S2. The netlist line \"R3 nSPlus nSplus {RS1}\" is wrong. There may be other errors in the .SUBCKT.\n\n URL \n\n2023-11-14_105159\n\n6_Phase_Rectifier.zip\n\n**TODO** list:\n- [x] Fix short circuit in transformer model\n- [x] Add TD parameter for sine source\n- [x] Deprecate red AC source","known_context_document_ids":["gh_issue_1993072219"],"reference_answer":"I have uploaded a new `Transformer.lib` library. Thanks for the contribution! Closing this.","answer_document_id":"gh_comment_1883416893","silver_evidence_path":["gh_comment_1827247936","gh_issue_1995913067","gh_comment_1883416893"],"evidence_issue_ids":[1993072219,1995913067],"source_repo_name":"ra3xdh/qucs_s","source_issue_id":1993072219,"source_issue_number":362,"source_issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","target_repo_name":"ra3xdh/qucs_s","target_issue_id":1995913067,"target_issue_number":367,"target_issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","reference_anchor_document_id":"gh_comment_1827247936","reference_answer_author":"ra3xdh","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3,"anchor_target_overlap":0.3,"target_answer_overlap":0.125},"issue_created_at":"2023-11-14T16:11:49+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1993072219","fragment_type":"issue_description","sequence":0,"text":"TransformerPS1S2 Issue\nI'm having issues trying to get a 6-phase rectifier circuit to work. I sent the netlist over to the ngspice guys and they found a possible error with .SUBCKT Transformers_TransformerPS1S2. The netlist line \"R3 nSPlus nSplus {RS1}\" is wrong. There may be other errors in the .SUBCKT.\n\n URL \n\n2023-11-14_105159\n\n6_Phase_Rectifier.zip\n\n**TODO** list:\n- [x] Fix short circuit in transformer model\n- [x] Add TD parameter for sine source\n- [x] Deprecate red AC source","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-14T16:11:49+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1810849897","fragment_type":"issue_comment","sequence":1,"text":"Holger recommendation is as follow. I cannot find \"chgtol\" in the Qucs settings.\n\nYou may add this line to the netlist. \n.options abstol=10u chgtol=1e-10 method=gear\n Because you have high voltages, chgtol and abstol reduce the precision requirements, especially the gear method here yields a transient solution. It looks strange though, and you should simulate up to 1 s to see the output signal decay.","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-14T18:07:14+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1810859189","fragment_type":"issue_comment","sequence":2,"text":"Yes, the options helps. You may use the .OPTIONS device. \nimage","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-14T18:12:25+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1810879342","fragment_type":"issue_comment","sequence":3,"text":"Output is wrong. Supposed to look like the following.\n6-phase-rectifier\n\n6-phase-rectifier-out","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-14T18:23:06+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1811263847","fragment_type":"issue_comment","sequence":4,"text":"Holger said to use Delay instead of Phase for the AC source. This and the changes to Transient Parameters seems to solve the issues. \n\nCan the \"Qucs\" AC source have VO (offset) and TD (delay) added as a parameter? The \"Spice\" AC source usage is a bit confusing. \n\nAttached is the \"good and bad\" schematics. As shown below, when using Delay in the AC source, the 120 and 240 Degree transformer outputs had a +/-200 volt DC offset. Unsure how this is possible. The offset occurs even if the diodes are removed.\n\nWaiting for Holger to verify if this is a bug. \n\n2023-11-14_152103\n\n6_Phase_Rectifier.zip","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-14T20:53:26+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1812745398","fragment_type":"issue_comment","sequence":5,"text":"Yes, you may use the generic SPICE source for this purpose: \nimage\n \n\nNo, this is done intentionally for Qucs compatibility. This node never caused problems before.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-15T15:26:42+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1812890938","fragment_type":"issue_comment","sequence":6,"text":"The \"ac Voltage Source\" at the bottom of the Sources menu is a Spice only component so Qucs compatibility isn't an issue. It has a single default entry of \"Vac\" which is wrong. ngspice thinks it is a DC source. Why was this device created when \"V Source\" is available.\n\nCan you alter \"ac Voltage Source\" by adding all the parameters to the Menu so the User can change them? \n\n2023-11-15_111458\n\n2023-11-15_111955\n\n2023-11-15_113042\n\n2023-11-15_113155","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-15T16:44:18+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1812897384","fragment_type":"issue_comment","sequence":7,"text":"Yes, I have just added the TD and VO parameters for AC source. This fix will be available since the new release.\n\nimage","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-15T16:48:11+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1812908121","fragment_type":"issue_comment","sequence":8,"text":"The \"ac Voltage Source\" at the bottom of the Sources menu will still be wrong if not changed or deleted. Why was it created?\n\n2023-11-15_115150","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-15T16:54:41+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1812913865","fragment_type":"issue_comment","sequence":9,"text":"This device was added by @MikeBrinson long time ago. I cannot say what was the purpose for this device. I am also finding two type of source confusing. I may delete it in the next release. The *V source* device would be sufficient if one need full SPICE definition.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-15T16:58:14+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1827247936","fragment_type":"issue_comment","sequence":10,"text":"I have deprecated the red AC source. The remaining issues with the transformer library will be fixed in #367 Closing this as completed.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-27T07:11:20+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1993072219,"issue_number":362,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/362","linked_issue_ids":[1995913067],"is_known_query_context":false},{"document_id":"gh_issue_1995913067","fragment_type":"issue_description","sequence":0,"text":"XSPICEPS1S2 transformer issues\nI found more problems with XSPICEPS1S2 in Transformer.lib. I made three circuits comparing XSPICEPS1S2 and TransformerPS1S2 in Transformer.lib to Three Mutual Inductors in Components. Analysis of TransformerPS1S2 and Three Mutual Inductors generally agree but XSPICEPS1S2 is wrong and generates errors.\n\nXSPICEPS1S2 has two issues:\n\n1. Rp, Rs1 and Rs2 generate warnings. Is there node naming issues like in TransformerPS1S2?\n2. The \"Turns Ratio\" is half what it should be. You can see the output voltages and currents in the plots are half compared to transformers TransformerPS1S2 and Three Mutual Inductors.\n\nI recreated the subcircuit for XSPICEPS1S2 made by Mike Brinson. It can be modified to fix the \"turns ratio\" problem.\n\nI also recreated the subcircuit for XSPICEPS1. It's \"turns ratio\" seems OK.\n\n**TODO**\n\n- [x] Replace models in Transformer.lib\n\n2023-11-15_192246\n\n2023-11-15_205939\n \n2023-11-15_215510\n\nTransformer_Lib_Test_prj.zip","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-16T02:16:26+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1813858000","fragment_type":"issue_comment","sequence":1,"text":"No, the variable should be wrapped in braces like `{Rs1}` Otherwise Ngspice may interpret it as the model.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-16T06:24:11+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1814503052","fragment_type":"issue_comment","sequence":2,"text":"Holger corrected the XSPICEPS1S2 subcircuit. AFAIK, the info in the online help is wrong.\n\nI found another issue, Cores.lib uses the same data for every core so only one core is correct....","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-16T14:08:15+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1814735021","fragment_type":"issue_comment","sequence":3,"text":"Yes, I have also noticed that the Cores.lib uses duplicate data. Unfortunately, I have no source data for this library and cannot provide the fix. The library was developed by @MikeBrinson around 2015. I cannot say where did he take the cores data.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-16T15:52:48+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1814741934","fragment_type":"issue_comment","sequence":4,"text":"The help on readthedocs.io should be deprecated and replaced by the new tutorial. It contains a lot of outdated information. I have started to collect the new documentation here: URL But this a slow process. Writing documentation requires much more time effort than writing a code.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2023-11-16T15:56:13+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1815314617","fragment_type":"issue_comment","sequence":5,"text":"Here is the updated Transformers.lib. All identified errors have been fixed.\n\nI left the \"Cores\" data in Transformers.lib and Cores.lib as it was. I could not find any info on the web. Looks like manually pulling data from B/H plots would be required. Some of the cores are nothing a user would ever make a transformer.\n\nI requested info from Mike Brinson...\n\nTransformers.zip","author_login":"tomhajjar","author_association":"NONE","created_at":"2023-11-16T21:05:49+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1883416893","fragment_type":"issue_comment","sequence":6,"text":"I have uploaded a new `Transformer.lib` library. Thanks for the contribution! Closing this.","author_login":"ra3xdh","author_association":"OWNER","created_at":"2024-01-09T16:51:09+08:00","repo_name":"ra3xdh/qucs_s","issue_id":1995913067,"issue_number":367,"issue_url":"https://github.com/ra3xdh/qucs_s/issues/367","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0037","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Terminus error -- call to undefined method?","query_context":"Good day,\nWe got the error as following when trying to build the environments thru GitHub action:\n`PHP Fatal error: Uncaught Error: Call to undefined method Pantheon\\TerminusBuildTools\\Commands\\EnvPushCommand::getsite() in /home/runner/.terminus/terminus-dependencies-c788000802/vendor/pantheon-systems/terminus-build-tools-plugin/src/Commands/BuildToolsBase.php:1120`\n\nIt is PR from `mylocalbranch` -> `develop` branch. The workflow file install terminus part as blowing:\n\n - name: Install Terminus\n run: |\n mkdir ~/terminus && cd ~/terminus\n curl -L URL --silent \" URL | perl -nle'print $& while m{\"tag_name\": \"\\K.*?(?=\")}g')/terminus.phar --output terminus\n chmod +x terminus\n sudo ln -s ~/terminus/terminus /usr/local/bin/terminus\n\nI tried to downgrade teriminus 3.6.2 version, action still failed and same error as above.\n`$(curl) --silent \" URL \nPlease let me know if more info need to provided.\n\nThanks.\n\nImage","known_context_document_ids":["gh_issue_3047481618"],"reference_answer":"I got some reports in Slack of this working so I'm closing this ticket. Thanks everyone involved!\n\nFeel free to open a new issue if there is something else that needs to be addressed :)","answer_document_id":"gh_comment_2863831995","silver_evidence_path":["gh_comment_2861238183","gh_issue_3047429096","gh_comment_2863831995"],"evidence_issue_ids":[3047481618,3047429096],"source_repo_name":"pantheon-systems/terminus-build-tools-plugin","source_issue_id":3047481618,"source_issue_number":498,"source_issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/498","target_repo_name":"pantheon-systems/terminus-build-tools-plugin","target_issue_id":3047429096,"target_issue_number":497,"target_issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/497","reference_anchor_document_id":"gh_comment_2861238183","reference_answer_author":"kporras07","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0},"issue_created_at":"2025-05-08T00:32:41+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_3047481618","fragment_type":"issue_description","sequence":0,"text":"Terminus error -- call to undefined method\nGood day,\nWe got the error as following when trying to build the environments thru GitHub action:\n`PHP Fatal error: Uncaught Error: Call to undefined method Pantheon\\TerminusBuildTools\\Commands\\EnvPushCommand::getsite() in /home/runner/.terminus/terminus-dependencies-c788000802/vendor/pantheon-systems/terminus-build-tools-plugin/src/Commands/BuildToolsBase.php:1120`\n\nIt is PR from `mylocalbranch` -> `develop` branch. The workflow file install terminus part as blowing:\n\n - name: Install Terminus\n run: |\n mkdir ~/terminus && cd ~/terminus\n curl -L URL --silent \" URL | perl -nle'print $& while m{\"tag_name\": \"\\K.*?(?=\")}g')/terminus.phar --output terminus\n chmod +x terminus\n sudo ln -s ~/terminus/terminus /usr/local/bin/terminus\n\nI tried to downgrade teriminus 3.6.2 version, action still failed and same error as above.\n`$(curl) --silent \" URL \nPlease let me know if more info need to provided.\n\nThanks.\n\nImage","author_login":"yihuangpx","author_association":"NONE","created_at":"2025-05-08T00:32:41+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047481618,"issue_number":498,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/498","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2860942429","fragment_type":"issue_comment","sequence":1,"text":"This is happening when pushing to Pantheon multidev environments. Didn't try `master` branch yet but feel it will failed as well.","author_login":"yihuangpx","author_association":"NONE","created_at":"2025-05-08T00:37:02+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047481618,"issue_number":498,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/498","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2861238183","fragment_type":"issue_comment","sequence":2,"text":"Duplicate of #497, a fix is linked there, we'll get that merged and a new release out.","author_login":"pwtyler","author_association":"MEMBER","created_at":"2025-05-08T02:02:46+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047481618,"issue_number":498,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/498","linked_issue_ids":[3047429096],"is_known_query_context":false},{"document_id":"gh_issue_3047429096","fragment_type":"issue_description","sequence":0,"text":"terminus build:workflow:wait results in call to undefined method getsite() with Terminus 4.0\nAfter upgrading to Terminus 4.0 and Terminus Build Tools Plugin 3.0.10, I get the following error when running `terminus build:workflow:wait`\n \n\nIt appears a reference to getSite() was missed in URL \n\n URL","author_login":"RichardDavies","author_association":"NONE","created_at":"2025-05-07T23:47:51+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047429096,"issue_number":497,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/497","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2862683977","fragment_type":"issue_comment","sequence":1,"text":"We've also experienced our build process this morning on `terminus build:env:push`:\n\nImage","author_login":"Alexj12","author_association":"NONE","created_at":"2025-05-08T11:16:18+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047429096,"issue_number":497,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/497","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2863600747","fragment_type":"issue_comment","sequence":2,"text":"Another fix was just merged and a new version was tagged. Please give it a try\nThanks!","author_login":"kporras07","author_association":"COLLABORATOR","created_at":"2025-05-08T16:13:12+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047429096,"issue_number":497,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/497","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2863831995","fragment_type":"issue_comment","sequence":3,"text":"I got some reports in Slack of this working so I'm closing this ticket. Thanks everyone involved!\n\nFeel free to open a new issue if there is something else that needs to be addressed :)","author_login":"kporras07","author_association":"COLLABORATOR","created_at":"2025-05-08T17:52:45+08:00","repo_name":"pantheon-systems/terminus-build-tools-plugin","issue_id":3047429096,"issue_number":497,"issue_url":"https://github.com/pantheon-systems/terminus-build-tools-plugin/issues/497","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0038","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[fhir-client] Calling $validate from the fhir-client fails in the main branch?","query_context":"We are using the FHIRClient validate method to validate Bundle resource by passing the Bundle object. \n\nclient.validate(finalBundle)\n\nIt fails to perform validation. The FHIR server log displays following message\n\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRHttpServl 2 Creating FHIRHttpServletRequestWrapper for HttpServletRequest: com.ibm.ws.webcontainer40.srt.SRTServletRequest40@ee864739\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRHttpServl 2 Retrieved these 'header' query parameters from the request URI: {}\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRHttpServl 2 Content-Type is application/xml\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRRestServl I Received request: tenantId:[default] dsId:[default] user:[fhiruser] method:[POST] uri:[ URL \n[6/17/22, 16:27:24:365 UTC] 00000042 FHIRProvider > com.ibm.fhir.provider.FHIRProvider readFrom ENTRY\n[6/17/22, 16:27:24:375 UTC] 00000042 FHIRProvider com.ibm.fhir.server.resources.Operation invoke(String,String,Resource) ENTRY\n[6/17/22, 16:27:24:376 UTC] 00000042 FHIRResource 1 'Resource' is not a valid resource type.\n[6/17/22, 16:27:24:381 UTC] 00000042 FHIRResource 1\nOperationOutcome:\n{\"resourceType\":\"OperationOutcome\",\"id\":\"ac-13-0-2-cd77fa72-e66c-4b97-a533-56c7af817a67\",\"issue\":[{\"severity\":\"fatal\",\"code\":\"not-supported\",\"_code\":{\"extension\":[{\"url\":\" URL is not a valid resource type.\"}}]}\n[6/17/22, 16:27:24:381 UTC] 00000042 RestAuditLogg > com.ibm.fhir.server.util.RestAuditLogger logOperation ENTRY\n[6/17/22, 16:27:24:381 UTC] 00000042 RestAuditLogg com.ibm.fhir.provider.FHIRProvider writeTo ENTRY\n[6/17/22, 16:27:24:385 UTC] 00000042 FHIRProvider < com.ibm.fhir.provider.FHIRProvider writeTo RETURN\n[6/17/22, 16:27:24:385 UTC] 00000042 FHIRRestServl I Completed request[0.024226862 secs]: tenantId:[default] dsId:[default] user:[fhiruser] method:[POST] uri:[ URL status:[404]\n[6/17/22, 16:27:24:385 UTC] 00000042 FHIRRestServl < com.ibm.fhir.server.filter.rest.FHIRRestServletFilter doFilter RETURN\n\n**Following is a sample Bundl resource that has validation error but the validation operation does npt detect it**\nEST-REG-ForVikas-RegTesting-Enriched.xml.zip","known_context_document_ids":["gh_issue_1275335128"],"reference_answer":"Error 404 issued with the text the \"unknow\" text is not a valid resource Closing issue.\nThe 404 is given for both 4.0 and 4.3 fhir versions","answer_document_id":"gh_comment_1157169642","silver_evidence_path":["gh_comment_1159148612","gh_issue_1121185566","gh_comment_1157169642"],"evidence_issue_ids":[1275335128,1121185566],"source_repo_name":"IBM/FHIR","source_issue_id":1275335128,"source_issue_number":3722,"source_issue_url":"https://github.com/IBM/FHIR/issues/3722","target_repo_name":"IBM/FHIR","target_issue_id":1121185566,"target_issue_number":3265,"target_issue_url":"https://github.com/IBM/FHIR/issues/3265","reference_anchor_document_id":"gh_comment_1159148612","reference_answer_author":"d0roppe","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.3333,"target_answer_overlap":0.25},"issue_created_at":"2022-06-17T18:15:56+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1275335128","fragment_type":"issue_description","sequence":0,"text":"[fhir-client] Calling $validate from the fhir-client fails in the main branch\nWe are using the FHIRClient validate method to validate Bundle resource by passing the Bundle object. \n\nclient.validate(finalBundle)\n\nIt fails to perform validation. The FHIR server log displays following message\n\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRHttpServl 2 Creating FHIRHttpServletRequestWrapper for HttpServletRequest: com.ibm.ws.webcontainer40.srt.SRTServletRequest40@ee864739\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRHttpServl 2 Retrieved these 'header' query parameters from the request URI: {}\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRHttpServl 2 Content-Type is application/xml\n[6/17/22, 16:27:24:361 UTC] 00000042 FHIRRestServl I Received request: tenantId:[default] dsId:[default] user:[fhiruser] method:[POST] uri:[ URL \n[6/17/22, 16:27:24:365 UTC] 00000042 FHIRProvider > com.ibm.fhir.provider.FHIRProvider readFrom ENTRY\n[6/17/22, 16:27:24:375 UTC] 00000042 FHIRProvider com.ibm.fhir.server.resources.Operation invoke(String,String,Resource) ENTRY\n[6/17/22, 16:27:24:376 UTC] 00000042 FHIRResource 1 'Resource' is not a valid resource type.\n[6/17/22, 16:27:24:381 UTC] 00000042 FHIRResource 1\nOperationOutcome:\n{\"resourceType\":\"OperationOutcome\",\"id\":\"ac-13-0-2-cd77fa72-e66c-4b97-a533-56c7af817a67\",\"issue\":[{\"severity\":\"fatal\",\"code\":\"not-supported\",\"_code\":{\"extension\":[{\"url\":\" URL is not a valid resource type.\"}}]}\n[6/17/22, 16:27:24:381 UTC] 00000042 RestAuditLogg > com.ibm.fhir.server.util.RestAuditLogger logOperation ENTRY\n[6/17/22, 16:27:24:381 UTC] 00000042 RestAuditLogg com.ibm.fhir.provider.FHIRProvider writeTo ENTRY\n[6/17/22, 16:27:24:385 UTC] 00000042 FHIRProvider < com.ibm.fhir.provider.FHIRProvider writeTo RETURN\n[6/17/22, 16:27:24:385 UTC] 00000042 FHIRRestServl I Completed request[0.024226862 secs]: tenantId:[default] dsId:[default] user:[fhiruser] method:[POST] uri:[ URL status:[404]\n[6/17/22, 16:27:24:385 UTC] 00000042 FHIRRestServl < com.ibm.fhir.server.filter.rest.FHIRRestServletFilter doFilter RETURN\n\n**Following is a sample Bundl resource that has validation error but the validation operation does npt detect it**\nEST-REG-ForVikas-RegTesting-Enriched.xml.zip","author_login":"vikforfda","author_association":"NONE","created_at":"2022-06-17T18:15:56+08:00","repo_name":"IBM/FHIR","issue_id":1275335128,"issue_number":3722,"issue_url":"https://github.com/IBM/FHIR/issues/3722","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1159148612","fragment_type":"issue_comment","sequence":1,"text":"Thanks Vikas. It looks like the client was dependent on $validate being served at `[base]/Resource/$validate`.\nWe used to support that but I removed that support in #3265.\nI think we'll need to update the client to infer the resource type from the resource that was passed.\n\n URL for more info.","author_login":"lmsurpre","author_association":"MEMBER","created_at":"2022-06-17T18:51:48+08:00","repo_name":"IBM/FHIR","issue_id":1275335128,"issue_number":3722,"issue_url":"https://github.com/IBM/FHIR/issues/3722","linked_issue_ids":[1121185566],"is_known_query_context":false},{"document_id":"gh_comment_1160508481","fragment_type":"issue_comment","sequence":2,"text":"@vikforfda what kind of object is your `finalBundle`?\n\nour FHIRClientImpl validate implementation is already invoking validate on a type-specific basis, and so I now suspect this is an issue with your code and not ours.","author_login":"lmsurpre","author_association":"MEMBER","created_at":"2022-06-20T14:20:50+08:00","repo_name":"IBM/FHIR","issue_id":1275335128,"issue_number":3722,"issue_url":"https://github.com/IBM/FHIR/issues/3722","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1163257784","fragment_type":"issue_comment","sequence":3,"text":"The issue was on our side. We were using an older version of fhir client to invoke the validation operation API. After we updated it to use versions 4.11.1 (most recent IBM-FHIR release) or 5.0.0-SNAPSHOT (corresponds to the WIP IBM-FHIR R4b release) then the validation correctly identified the error","author_login":"vikforfda","author_association":"NONE","created_at":"2022-06-22T15:25:25+08:00","repo_name":"IBM/FHIR","issue_id":1275335128,"issue_number":3722,"issue_url":"https://github.com/IBM/FHIR/issues/3722","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1121185566","fragment_type":"issue_description","sequence":0,"text":"Remove any remaining support for requests to abstract endpoints like `[base]/Resource`\n**Is your feature request related to a problem? Please describe.**\nIn URL we added warnings for requests to \"abstract\" type endpoints like `[base]/Resource`.\nNow I'd like to pull the trigger and remove that support altogether.\n\n**Describe the solution you'd like**\nhave requests to `[base]/Resource` handled just like requests to `[base]/bogus`\n\n**Describe alternatives you've considered**\nkeep supporting it in whatever way we do today\n\n**Acceptance Criteria**\n\n1. \n GIVEN a 5.0 version of IBM FhIR Server\n WHEN a request is made to `[base]/bogus`\n THEN it results in a 404 not found\n\n**Additional context**\none such place is FHIRResource.checkType(String):\n\nif (!ModelSupport.isConcreteResourceType(type)) {\n log.warning(\"Use of abstract resource types like '\" + type + \"' in FHIR URLs is deprecated and will be removed in a future release\");\n}","author_login":"lmsurpre","author_association":"MEMBER","created_at":"2022-02-01T20:51:19+08:00","repo_name":"IBM/FHIR","issue_id":1121185566,"issue_number":3265,"issue_url":"https://github.com/IBM/FHIR/issues/3265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1157169642","fragment_type":"issue_comment","sequence":1,"text":"Error 404 issued with the text the \"unknow\" text is not a valid resource Closing issue.\nThe 404 is given for both 4.0 and 4.3 fhir versions","author_login":"d0roppe","author_association":"MEMBER","created_at":"2022-06-16T02:41:59+08:00","repo_name":"IBM/FHIR","issue_id":1121185566,"issue_number":3265,"issue_url":"https://github.com/IBM/FHIR/issues/3265","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0039","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Update help pages to clarify ownership of requests once published?","query_context":"As discussed on WDTK volunteer catch up call 24/06/2021 - URL \n\n- Should make clear to pro and non pro users the requests aren’t “theirs” once published. \n- Treat like publishing under Creative Commons / Open licence \n- “You’re making this a public asset” .. “doing a public service”. \n- Issue with existing requests .. can’t retrospectively apply a public licence.","known_context_document_ids":["gh_issue_929470990"],"reference_answer":"Simplest thing to do here is change the default value of the select box and add more emphasis to the consequence of selecting a particular value:\n\n<img width=\"702\" alt=\"Screenshot 2022-09-21 at 14 38 53\" src=\" URL \n\n<img width=\"685\" alt=\"Screenshot 2022-09-21 at 14 38 59\" src=\" URL","answer_document_id":"gh_comment_1253741192","silver_evidence_path":["gh_comment_1239634281","gh_issue_1024400982","gh_comment_1253741192"],"evidence_issue_ids":[929470990,1024400982],"source_repo_name":"mysociety/whatdotheyknow-theme","source_issue_id":929470990,"source_issue_number":841,"source_issue_url":"https://github.com/mysociety/whatdotheyknow-theme/issues/841","target_repo_name":"mysociety/alaveteli","target_issue_id":1024400982,"target_issue_number":6567,"target_issue_url":"https://github.com/mysociety/alaveteli/issues/6567","reference_anchor_document_id":"gh_comment_1239634281","reference_answer_author":"garethrees","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.1667,"target_answer_overlap":0.1053},"issue_created_at":"2021-06-24T17:52:49+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_929470990","fragment_type":"issue_description","sequence":0,"text":"Update help pages to clarify ownership of requests once published\nAs discussed on WDTK volunteer catch up call 24/06/2021 - URL \n\n- Should make clear to pro and non pro users the requests aren’t “theirs” once published. \n- Treat like publishing under Creative Commons / Open licence \n- “You’re making this a public asset” .. “doing a public service”. \n- Issue with existing requests .. can’t retrospectively apply a public licence.","author_login":"MattK1234","author_association":"COLLABORATOR","created_at":"2021-06-24T17:52:49+08:00","repo_name":"mysociety/whatdotheyknow-theme","issue_id":929470990,"issue_number":841,"issue_url":"https://github.com/mysociety/whatdotheyknow-theme/issues/841","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1239619936","fragment_type":"issue_comment","sequence":1,"text":"At a minimum we need to clarify\n\n* What circumstances might we hide material or destroy data on their requests\n* Policies on re-embargoing. Need technical measures ( URL first, but even if they exist it needs to be clear in UI and/or help pages what the expectations should be.","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-09-07T16:28:41+08:00","repo_name":"mysociety/whatdotheyknow-theme","issue_id":929470990,"issue_number":841,"issue_url":"https://github.com/mysociety/whatdotheyknow-theme/issues/841","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1239634281","fragment_type":"issue_comment","sequence":2,"text":"URL would be a good place for this.\n\nNeed to also check T&C's.","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-09-07T16:42:29+08:00","repo_name":"mysociety/whatdotheyknow-theme","issue_id":929470990,"issue_number":841,"issue_url":"https://github.com/mysociety/whatdotheyknow-theme/issues/841","linked_issue_ids":[1024400982],"is_known_query_context":false},{"document_id":"gh_comment_2481257128","fragment_type":"issue_comment","sequence":3,"text":"This issue is being closed due to a lack of discussion or resolution for over 12 months. Should we decide to revisit this issue in the future, it can be reopened.","author_login":"HelenWDTK","author_association":"CONTRIBUTOR","created_at":"2024-11-17T12:58:12+08:00","repo_name":"mysociety/whatdotheyknow-theme","issue_id":929470990,"issue_number":841,"issue_url":"https://github.com/mysociety/whatdotheyknow-theme/issues/841","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1024400982","fragment_type":"issue_description","sequence":0,"text":"Make Pro requests public by default\nCurrently there is a default position of a 3 month embargo on Pro requests. \n\nI suggest making no embargo the default, and requiring the setting of an embargo to be something which needs to be done actively, this would promote the publication of requests and responses. \n\nIssue raised having seen a Tweet by a Pro user who appears unsure about the embargo they have set: \n \n\n URL","author_login":"RichardTaylor","author_association":"NONE","created_at":"2021-10-12T21:08:12+08:00","repo_name":"mysociety/alaveteli","issue_id":1024400982,"issue_number":6567,"issue_url":"https://github.com/mysociety/alaveteli/issues/6567","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152945126","fragment_type":"issue_comment","sequence":1,"text":"+1 I keep nearly making embargoed requests by mistake. It'd be good to be able to set a default that applied to all my requests unless I said otherwise.","author_login":"FOIMonkey","author_association":"NONE","created_at":"2022-06-11T15:00:36+08:00","repo_name":"mysociety/alaveteli","issue_id":1024400982,"issue_number":6567,"issue_url":"https://github.com/mysociety/alaveteli/issues/6567","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253741192","fragment_type":"issue_comment","sequence":2,"text":"Simplest thing to do here is change the default value of the select box and add more emphasis to the consequence of selecting a particular value:\n\n<img width=\"702\" alt=\"Screenshot 2022-09-21 at 14 38 53\" src=\" URL \n\n<img width=\"685\" alt=\"Screenshot 2022-09-21 at 14 38 59\" src=\" URL","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-09-21T13:49:49+08:00","repo_name":"mysociety/alaveteli","issue_id":1024400982,"issue_number":6567,"issue_url":"https://github.com/mysociety/alaveteli/issues/6567","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253764867","fragment_type":"issue_comment","sequence":3,"text":"Would need to consider interaction with URL / URL Just-created requests should have the same mechanics as just-published requests.","author_login":"garethrees","author_association":"MEMBER","created_at":"2022-09-21T14:07:07+08:00","repo_name":"mysociety/alaveteli","issue_id":1024400982,"issue_number":6567,"issue_url":"https://github.com/mysociety/alaveteli/issues/6567","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2485207993","fragment_type":"issue_comment","sequence":4,"text":"This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.\nShould we decide to revisit this issue in the future, it can be reopened.","author_login":"HelenWDTK","author_association":"CONTRIBUTOR","created_at":"2024-11-19T09:51:31+08:00","repo_name":"mysociety/alaveteli","issue_id":1024400982,"issue_number":6567,"issue_url":"https://github.com/mysociety/alaveteli/issues/6567","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0040","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Jetbrains Toolbox \"Invalid client serial\" when using dbus-user=filter?","query_context":"### Description\n\nJetbrains Toolbox takes an insane amount of time to load up and display its tray icon when using `--dbus-user=filter`. Unlike a normal run, it displays the following message:\n\n** (process:10596): WARNING **: 21:28:17.026: Invalid client serial\n\nThis message originates from xdg-dbus-proxy, in flatpak-proxy.c.\n\n### Steps to Reproduce\n\n1. Download the toolbox app URL \n2. Run `firejail --noprofile --dbus-user=proxy --appimage ./jetbrains-toolbox`\n\n### Expected behavior\n\nThe app runs and displays a GtkStatusIcon as a fallback for having no access to a StatusNotifierItem tray.\n\n### Actual behavior\n\nIt took a solid 5 minutes to start up and do this.\n\n### Behavior without a profile\n\nN/A\n\n### Additional context\n\nI don't have a StatusNotifierItem implementation like snixembed, yet running outside of firejail makes it work. I want it to run with either --dbus-user=none or --dbus-user=proxy, either is fine.\n\n### Environment\n\n- Gentoo amd64\n- i3 window manager with polybar\n\nfirejail version 0.9.70\n\nCompile time support:\n - always force nonewprivs support is disabled\n - AppArmor support is disabled\n - AppImage support is enabled\n - chroot support is enabled\n - D-BUS proxy support is enabled\n - file transfer support is enabled\n - firetunnel support is disabled\n - IDS support is disabled\n - networking support is enabled\n - output logging is enabled\n - overlayfs support is disabled\n - private-home support is enabled\n - private-cache and tmpfs as user enabled\n - SELinux support is disabled\n - user namespace support is enabled\n - X11 sandboxing support is enabled\n\n### Checklist\n\n- [x] The issues is caused by firejail (i.e. running the program by path (e.g. `/usr/bin/vlc`) \"fixes\" it).\n- [x] I can reproduce the issue without custom modifications (e.g. globals.local).\n- [ ] The program has a profile. (If not, request one in ` URL \n- [ ] The profile (and redirect profile if exists) hasn't already been fixed upstream.\n- [x] I have performed a short search for similar issues (to avoid opening a duplicate).\n - [x] I'm aware of `browser-allow-drm yes`/`browser-disable-u2f no` in `firejail.config` to allow DRM/U2F in browsers.\n- [ ] I used `--profile=PROFILENAME` to set the right profile. (Only relevant for AppImages)\n\n### Log\n\n \n Output of LC_ALL=C firejail --noprofile --dbus-user=proxy --appimage ./jetbrains-toolbox \n \n\nParent pid 10594, child pid 10598\n\n** Warning: dropping all Linux capabilities and setting NO_NEW_PRIVS prctl **\n\nMounting appimage type 2\nWarning: An abstract unix socket for session D-BUS might still be available. Use --net or remove unix from --protocol set.\nChild process initialized in 50.05 ms\n\n** (process:10596): WARNING **: 21:28:17.026: Invalid client serial","known_context_document_ids":["gh_issue_1311780149"],"reference_answer":"This has to do with the exception handling of the calling code.\nWhen DBus is not available dbus-java will instantly fail with an `AddressResolvingException` or an `IOException`. When the calling code swallows the exception, nothing will happen (no DBus usage, no blocking).\n\nWhen blocking certain calls the problem is different. While establishing connection to DBus worked (handshaking, sending Hello etc), specific calls get blocked. In that case the connection (at least in version 4.0.0) gets into some sort of half-disconnected behaviour, which causes the connection to be treated as connected when it actually isn't.\nThis was fixed in 4.1.0 of dbus-java. \n\nWhen using 4.1.0 with your setup, the application will only block for about 10-20 seconds due to waiting for method replys which will never be received.\n\nI improved this in the latest 4.1.1 snapshot, so dbus-java will no longer wait for method-replies if the disconnection from the bus was caused by an `IOException` (e.g. of the transport like in this case).\n\nThe error message 'invalid client serial' you see is not from dbus-java but from some launcher used to start the jetbrains-toolbox.\nI guess that this has something to do with messages not arriving at that application, but usually this does not hurt.","answer_document_id":"gh_comment_1192363188","silver_evidence_path":["gh_comment_1192411101","gh_issue_1313065459","gh_comment_1192363188"],"evidence_issue_ids":[1311780149,1313065459],"source_repo_name":"netblue30/firejail","source_issue_id":1311780149,"source_issue_number":5265,"source_issue_url":"https://github.com/netblue30/firejail/issues/5265","target_repo_name":"hypfvieh/dbus-java","target_issue_id":1313065459,"target_issue_number":177,"target_issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","reference_anchor_document_id":"gh_comment_1192411101","reference_answer_author":"hypfvieh","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.2708,"target_answer_overlap":0.1176},"issue_created_at":"2022-07-20T19:40:05+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1311780149","fragment_type":"issue_description","sequence":0,"text":"Jetbrains Toolbox \"Invalid client serial\" when using dbus-user=filter\n### Description\n\nJetbrains Toolbox takes an insane amount of time to load up and display its tray icon when using `--dbus-user=filter`. Unlike a normal run, it displays the following message:\n\n** (process:10596): WARNING **: 21:28:17.026: Invalid client serial\n\nThis message originates from xdg-dbus-proxy, in flatpak-proxy.c.\n\n### Steps to Reproduce\n\n1. Download the toolbox app URL \n2. Run `firejail --noprofile --dbus-user=proxy --appimage ./jetbrains-toolbox`\n\n### Expected behavior\n\nThe app runs and displays a GtkStatusIcon as a fallback for having no access to a StatusNotifierItem tray.\n\n### Actual behavior\n\nIt took a solid 5 minutes to start up and do this.\n\n### Behavior without a profile\n\nN/A\n\n### Additional context\n\nI don't have a StatusNotifierItem implementation like snixembed, yet running outside of firejail makes it work. I want it to run with either --dbus-user=none or --dbus-user=proxy, either is fine.\n\n### Environment\n\n- Gentoo amd64\n- i3 window manager with polybar\n\nfirejail version 0.9.70\n\nCompile time support:\n - always force nonewprivs support is disabled\n - AppArmor support is disabled\n - AppImage support is enabled\n - chroot support is enabled\n - D-BUS proxy support is enabled\n - file transfer support is enabled\n - firetunnel support is disabled\n - IDS support is disabled\n - networking support is enabled\n - output logging is enabled\n - overlayfs support is disabled\n - private-home support is enabled\n - private-cache and tmpfs as user enabled\n - SELinux support is disabled\n - user namespace support is enabled\n - X11 sandboxing support is enabled\n\n### Checklist\n\n- [x] The issues is caused by firejail (i.e. running the program by path (e.g. `/usr/bin/vlc`) \"fixes\" it).\n- [x] I can reproduce the issue without custom modifications (e.g. globals.local).\n- [ ] The program has a profile. (If not, request one in ` URL \n- [ ] The profile (and redirect profile if exists) hasn't already been fixed upstream.\n- [x] I have performed a short search for similar issues (to avoid opening a duplicate).\n - [x] I'm aware of `browser-allow-drm yes`/`browser-disable-u2f no` in `firejail.config` to allow DRM/U2F in browsers.\n- [ ] I used `--profile=PROFILENAME` to set the right profile. (Only relevant for AppImages)\n\n### Log\n\n \n Output of LC_ALL=C firejail --noprofile --dbus-user=proxy --appimage ./jetbrains-toolbox \n \n\nParent pid 10594, child pid 10598\n\n** Warning: dropping all Linux capabilities and setting NO_NEW_PRIVS prctl **\n\nMounting appimage type 2\nWarning: An abstract unix socket for session D-BUS might still be available. Use --net or remove unix from --protocol set.\nChild process initialized in 50.05 ms\n\n** (process:10596): WARNING **: 21:28:17.026: Invalid client serial","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-20T19:40:05+08:00","repo_name":"netblue30/firejail","issue_id":1311780149,"issue_number":5265,"issue_url":"https://github.com/netblue30/firejail/issues/5265","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1190713790","fragment_type":"issue_comment","sequence":1,"text":"`--dbus-user=proxy` is not supported. It's `filter`.\n\n---\n\nThe fallback code a program uses if an dbus name does not exists is outside of the scope of firejail, consider reporting this to jetbrains then.\n\nIf you believe this happens because of an implementation deatil of xdg-dbus-proxy, report it there.\n\nTL;DR: Is this a firejail issue?","author_login":"rusty-snake","author_association":"COLLABORATOR","created_at":"2022-07-20T20:16:29+08:00","repo_name":"netblue30/firejail","issue_id":1311780149,"issue_number":5265,"issue_url":"https://github.com/netblue30/firejail/issues/5265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1190785491","fragment_type":"issue_comment","sequence":2,"text":"I meant --dbus-user=filter, of course. Does --dbus-user=proxy even work?\n\nAnyway, this program uses libappindicator. That's what uses GtkStatusIcon as a fallback.\n\nThis problem doesn't happen without firejail, as the fallback works properly in that case, though it's very possible that it's a xdg-dbus-proxy thing.","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-20T21:41:22+08:00","repo_name":"netblue30/firejail","issue_id":1311780149,"issue_number":5265,"issue_url":"https://github.com/netblue30/firejail/issues/5265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1190873533","fragment_type":"issue_comment","sequence":3,"text":"Yeah, I managed to reproduce it with the following setup:\n\nxdg-dbus-proxy \"$DBUS_SESSION_BUS_ADDRESS\" dbus --log --proxy &\nDBUS_SESSION_BUS_ADDRESS=\"unix:path=$PWD/dbus\" ~/.local/share/JetBrains/Toolbox/bin/jetbrains-toolbox","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-20T23:37:51+08:00","repo_name":"netblue30/firejail","issue_id":1311780149,"issue_number":5265,"issue_url":"https://github.com/netblue30/firejail/issues/5265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192411101","fragment_type":"issue_comment","sequence":4,"text":"The library causing the hang turned out to be dbus-java, not libappindicator. The issue is further discussed here, with a potential fix that might appear in future releases: URL \n\nFor now, a different workaround to get the application to not hang yet still display a GtkStatusIcon-powered tray icon would be to run with `dbus-user none`, and writing the following in `~/.config/JetBrains/Toolbox/toolboxrc` to start a dummy non-proxying D-Bus server in the sandbox:\n\neval $(dbus-launch)\nexport DBUS_SESSION_BUS_ADDRESS\n./$app \"$@\"\nkill $DBUS_SESSION_BUS_PID\nexit","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-22T10:09:56+08:00","repo_name":"netblue30/firejail","issue_id":1311780149,"issue_number":5265,"issue_url":"https://github.com/netblue30/firejail/issues/5265","linked_issue_ids":[1313065459],"is_known_query_context":false},{"document_id":"gh_comment_1192992745","fragment_type":"issue_comment","sequence":5,"text":"@mid-kid Thanks for the details.\n\n(Re-closing as \"not planned\" since the bug is not in firejail)","author_login":"kmk3","author_association":"COLLABORATOR","created_at":"2022-07-22T23:00:18+08:00","repo_name":"netblue30/firejail","issue_id":1311780149,"issue_number":5265,"issue_url":"https://github.com/netblue30/firejail/issues/5265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1313065459","fragment_type":"issue_description","sequence":0,"text":"\"Invalid client serial\" when used with xdg-dbus-proxy\nHi, I was trying to use Jetbrains Toolbox with xdg-dbus-proxy, and I encountered an issue with your library.\n\nSpecifically, if xdg-dbus-proxy's --filter option is being used, the app will hang on startup for about 5-10 minutes before continuing. Meanwhile, xdg-dbus-proxy spits out the following message:\n\n** (process:10596): WARNING **: 21:28:17.026: Invalid client serial\n\n## steps to reproduce\n\nDownload the Jetbrains Toolbox app, then run the following:\n\nxdg-dbus-proxy \"$DBUS_SESSION_BUS_ADDRESS\" \"$HOME/dbus\" --filter --log &\nDBUS_SESSION_BUS_ADDRESS=\"unix:path=$HOME/dbus\" ./jetbrains-toolbox\n\nFull xdg-dbus-proxy log:\n\nC1: -> org.freedesktop.DBus call org.freedesktop.DBus.Hello at /org/freedesktop/DBus\nB1: all signal com.canonical.Unity.LauncherEntry.Update at /\n\n** (process:15395): WARNING **: 12:49:58.552: Invalid client serial\n\n## temporary workaround\nrun jetbrains-toolbox like this instead:\n\n./jetbrains-toolbox --appimage-extract && cd squashfs-root\nrm lib/dbus-java-transport-native-unixsocket-4.0.0.jar\nAPPDIR=\"$PWD\" APPIMAGE=\"$HOME/.local/share/JetBrains/Toolbox/bin/jetbrains-toolbox\" DBUS_SESSION_BUS_ADDRESS=\"unix:path=$HOME/dbus\" ./AppRun\n\nThis causes the app to never connect to dbus, bypassing the hang.\n\n## cross-linked issues\n URL \n URL","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-21T10:51:34+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191379623","fragment_type":"issue_comment","sequence":1,"text":"Sorry I don't get it...\nWhat are you trying to do and where is it related to dbus-java?\nWhat is xdg-dbus-proxy and why should I use it?\nWhich version of dbus-java is involved here?\nAre you using it as client or is it running the embedded dbus?","author_login":"hypfvieh","author_association":"OWNER","created_at":"2022-07-21T11:40:18+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191388658","fragment_type":"issue_comment","sequence":2,"text":"xdg-dbus-proxy is a utility used for separating apps that use dbus from the rest of the system, giving them only access to the specific services that they need. It creates its own dbus server and connects to the system's dbus server to proxy and filter calls. This is incredibly useful for any kind of sandboxing technology, such as flatpak and firejail.\n\nI am trying to get an app that uses dbus-java to run inside a sandbox whilst using xdg-dbus-proxy to restrict its access from most dbus services. My current trail of debugging has led me towards this library, as removing its transport jar changes the result of the execution, causing it to not connect to dbus at all, instead of hanging.\n\nThe version of dbus-java involved, according to the jar files in jetbrains-toolbox, is 4.0.0.","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-21T11:50:44+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191437746","fragment_type":"issue_comment","sequence":3,"text":"Is there any sort of log produced by dbus-java? Usually dbus-java uses Slf4j with any slf4j compliant logger to log what's going on. Especially turning on TRACE-logging would definitely help to find out what is going on.","author_login":"hypfvieh","author_association":"OWNER","created_at":"2022-07-21T12:42:57+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191514238","fragment_type":"issue_comment","sequence":4,"text":"Are you sure you are xdg-dbus-proxy the correct way?\nJust using --filter will cause xdg-dbus-proxy to block all communication except for the initial handshaking to DBus.\nSee here.\n\nWhen using xdg-dbus-proxy and a patched version of jetbrains-toolbox (with logging enabled) I can see that dbus-java connects to the Bus for the handshaking stuff, but as soon as jetbrains-toolbox want to listen to signals of com.canonical.Unity.LauncherEntry the signal is not being answered and the socket is closed.\nFor me it looks like if there are missing a lot of options for xdg-dbus-proxy to tell the proxy to allow talking to com.canonical.Unity.LauncherEntry and may others as well.","author_login":"hypfvieh","author_association":"OWNER","created_at":"2022-07-21T13:52:38+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191524339","fragment_type":"issue_comment","sequence":5,"text":"I wasn't able to tell which dbus services it was trying to access, but yeah I reckon it needs a few whitelists to work. Still, I don't have a com.canonical.Unity.LauncherEntry on my system, so it should have the same behavior here? And if DBUS_SESSION_BUS_ADDRESS is set to some bogus value like \"foo\", it gracefully and silently fails as well..","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-21T14:01:44+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192363188","fragment_type":"issue_comment","sequence":6,"text":"This has to do with the exception handling of the calling code.\nWhen DBus is not available dbus-java will instantly fail with an `AddressResolvingException` or an `IOException`. When the calling code swallows the exception, nothing will happen (no DBus usage, no blocking).\n\nWhen blocking certain calls the problem is different. While establishing connection to DBus worked (handshaking, sending Hello etc), specific calls get blocked. In that case the connection (at least in version 4.0.0) gets into some sort of half-disconnected behaviour, which causes the connection to be treated as connected when it actually isn't.\nThis was fixed in 4.1.0 of dbus-java. \n\nWhen using 4.1.0 with your setup, the application will only block for about 10-20 seconds due to waiting for method replys which will never be received.\n\nI improved this in the latest 4.1.1 snapshot, so dbus-java will no longer wait for method-replies if the disconnection from the bus was caused by an `IOException` (e.g. of the transport like in this case).\n\nThe error message 'invalid client serial' you see is not from dbus-java but from some launcher used to start the jetbrains-toolbox.\nI guess that this has something to do with messages not arriving at that application, but usually this does not hurt.","author_login":"hypfvieh","author_association":"OWNER","created_at":"2022-07-22T09:17:30+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192405757","fragment_type":"issue_comment","sequence":7,"text":"Thanks a lot for digging into this issue! Glad to know the mechanics of all of this now. It makes sense, as xdg-dbus-proxy works in a way many applications don't expect, but I guess I was confused since I've never seen similar behavior in other programs using dbus. Many thanks for implementing a workaround anyway, I'll be patiently waiting for that to trickle downstream :)\n\nAnd yeah, the \"Invalid client serial\" message comes from xdg-dbus-proxy itself: URL \nI wrongly assumed that would be the issue since I didn't see this message pop up during correct operation. It might not be related at all.","author_login":"mid-kid","author_association":"NONE","created_at":"2022-07-22T10:04:17+08:00","repo_name":"hypfvieh/dbus-java","issue_id":1313065459,"issue_number":177,"issue_url":"https://github.com/hypfvieh/dbus-java/issues/177","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0041","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Unable to build due to \"clang++ exited with error code 1\" and empty file?","query_context":"### Apple platform\n\niOS\n\n### Framework version\n\nnet9.0-*\n\n### Affected platform version\n\nVS 2022 17.13.1\n\n### Description\n\n1>C:\\Program Files\\dotnet\\packs\\Microsoft.iOS.Sdk.net9.0_18.2\\18.2.9180\\targets\\Xamarin.Shared.Sdk.targets(1665,3): error : clang++ exited with code 1:\n1>C:\\Program Files\\dotnet\\packs\\Microsoft.iOS.Sdk.net9.0_18.2\\18.2.9180\\targets\\Xamarin.Shared.Sdk.targets(1665,3): error : ld: file is empty in '/Users/**/Library/Caches/Xamarin/mtbs/builds/**/e714b99856d2d8abeed05f03af7a2bd21b67f244c175af00f39b5193cbd8bd41/C:/Program Files/dotnet/packs/Microsoft.NETCore.App.Runtime.Mono.ios-arm64/9.0.2/runtimes/ios-arm64/native/libmono-component-marshal-ilgen-static.a'\n1>C:\\Program Files\\dotnet\\packs\\Microsoft.iOS.Sdk.net9.0_18.2\\18.2.9180\\targets\\Xamarin.Shared.Sdk.targets(1665,3): error : clang++: error: linker command failed with exit code 1 (use -v to see invocation)\n\nI checked that path on the Mac and it is indeed a 0 byte file. All the other files in that directory are non-zero in size.\n\nThe corresponding file on my Windows machine is 199KB.\n\nI scp'd that file from my Windows machine to the Mac and that allowed the build process to get past that error and it seems to fully build, though it can't deploy due to an issue with the iOS version.\n\n### Steps to Reproduce\n\nI don't know. I have had to do so many things to get to this point with a brand new Mac and an app that has never been built for iOS before.\n\n### Did you find any workaround?\n\nYes, I copied the file from my Windows machine to the Mac, overwriting the 0-byte file. \n\n### Build logs\n\n_No response_","known_context_document_ids":["gh_issue_2870172979"],"reference_answer":"It's a known issue, and there's a proposal to improve this scenario: URL (which also explains the reason why it behaves like it does today).","answer_document_id":"gh_comment_2684410954","silver_evidence_path":["gh_comment_2676983958","gh_issue_2873322464","gh_comment_2684410954"],"evidence_issue_ids":[2870172979,2873322464],"source_repo_name":"dotnet/macios","source_issue_id":2870172979,"source_issue_number":22235,"source_issue_url":"https://github.com/dotnet/macios/issues/22235","target_repo_name":"dotnet/macios","target_issue_id":2873322464,"target_issue_number":22238,"target_issue_url":"https://github.com/dotnet/macios/issues/22238","reference_anchor_document_id":"gh_comment_2676983958","reference_answer_author":"rolfbjarne","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.5556,"target_answer_overlap":0.1818},"issue_created_at":"2025-02-21T22:48:18+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2870172979","fragment_type":"issue_description","sequence":0,"text":"Unable to build due to \"clang++ exited with error code 1\" and empty file\n### Apple platform\n\niOS\n\n### Framework version\n\nnet9.0-*\n\n### Affected platform version\n\nVS 2022 17.13.1\n\n### Description\n\n1>C:\\Program Files\\dotnet\\packs\\Microsoft.iOS.Sdk.net9.0_18.2\\18.2.9180\\targets\\Xamarin.Shared.Sdk.targets(1665,3): error : clang++ exited with code 1:\n1>C:\\Program Files\\dotnet\\packs\\Microsoft.iOS.Sdk.net9.0_18.2\\18.2.9180\\targets\\Xamarin.Shared.Sdk.targets(1665,3): error : ld: file is empty in '/Users/**/Library/Caches/Xamarin/mtbs/builds/**/e714b99856d2d8abeed05f03af7a2bd21b67f244c175af00f39b5193cbd8bd41/C:/Program Files/dotnet/packs/Microsoft.NETCore.App.Runtime.Mono.ios-arm64/9.0.2/runtimes/ios-arm64/native/libmono-component-marshal-ilgen-static.a'\n1>C:\\Program Files\\dotnet\\packs\\Microsoft.iOS.Sdk.net9.0_18.2\\18.2.9180\\targets\\Xamarin.Shared.Sdk.targets(1665,3): error : clang++: error: linker command failed with exit code 1 (use -v to see invocation)\n\nI checked that path on the Mac and it is indeed a 0 byte file. All the other files in that directory are non-zero in size.\n\nThe corresponding file on my Windows machine is 199KB.\n\nI scp'd that file from my Windows machine to the Mac and that allowed the build process to get past that error and it seems to fully build, though it can't deploy due to an issue with the iOS version.\n\n### Steps to Reproduce\n\nI don't know. I have had to do so many things to get to this point with a brand new Mac and an app that has never been built for iOS before.\n\n### Did you find any workaround?\n\nYes, I copied the file from my Windows machine to the Mac, overwriting the 0-byte file. \n\n### Build logs\n\n_No response_","author_login":"bzd3y","author_association":"NONE","created_at":"2025-02-21T22:48:18+08:00","repo_name":"dotnet/macios","issue_id":2870172979,"issue_number":22235,"issue_url":"https://github.com/dotnet/macios/issues/22235","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2675803236","fragment_type":"issue_comment","sequence":1,"text":"Actually, that deploy issue also seems to be a bug. When I added `MinimumOSVersion` to my Info.plist file, I get the following error: \n \n\nBut I have the following in my project file:\n\nxml\n 13.0 \n\nI was able to get rid of that error and deploy and run by changing the above to:\n\nxml\n 13.0 \n\nUsing the entire target framework string instead of the platform identifier.\n\nThen I added a msbuild target to output $(TargetPlatformIdentifier) and that outputs \"MacCatalyst\".\n\nI'm not sure if these two issues are related.","author_login":"bzd3y","author_association":"NONE","created_at":"2025-02-21T23:16:31+08:00","repo_name":"dotnet/macios","issue_id":2870172979,"issue_number":22235,"issue_url":"https://github.com/dotnet/macios/issues/22235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2676983958","fragment_type":"issue_comment","sequence":2,"text":"I think I reported the main issue in the wrong place, so I'm closing this and moving the issue with $(TargetPlatformIdentifier) to #22238.","author_login":"bzd3y","author_association":"NONE","created_at":"2025-02-23T16:49:49+08:00","repo_name":"dotnet/macios","issue_id":2870172979,"issue_number":22235,"issue_url":"https://github.com/dotnet/macios/issues/22235","linked_issue_ids":[2873322464],"is_known_query_context":false},{"document_id":"gh_issue_2873322464","fragment_type":"issue_description","sequence":0,"text":"$(TargetPlatformIdentifier) is not being set correctly for iOS\n### Apple platform\n\niOS\n\n### Framework version\n\nnet9.0-*\n\n### Affected platform version\n\nVS 2022 17.13.1\n\n### Description\n\nI split this from an issue I created earlier: #22235, but I am going to close that because I think I added it in the wrong place and need to report that through the VS Feedback feature. I'm also not sure I am adding this issue in the right place.\n \nI have a project configured with the following:\n\nxml\n 13.0 \n 13.1 \n 23.0 \n\nThe last line, for Android, works. The MacCatalyst line also appears to work, though I haven't tested it all the way to deploying.\n\nThe first line does not work when deploying to an iOS with an OS version below 18.2. The condition is not met and so the `SupportedOSPlatformVersion` defaults to 18.2.\n\nAdding a `Target` to the project file to output the value of $(TargetPlatformIdentifier) has some strange behavior.\n\nWhen doing a solution rebuild it will output a 'MacCatalyst' (this is why I think the above line for MacCatalyst works) and 'Android'. It will not output 'iOS'.\n\nHowever, if I do a build by running the app on a remote iOS device, it only outputs 'iOS', as expected. But after that the deploy fails due to the device not having the minimum required OS version of 18.2. It looks like mtouch is what outputs the error. The error is long and formatted all on one line, but it contains the following messages:\n \n \n \n\nThe following configurations do work:\n\nxml\n 13.0 \n 13.1 \n 23.0 \n\nand\n\nxml\n $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) \n\n 13.0 \n 13.1 \n 23.0 \n\nFor some additional information, if the minimum OS version is set in Info.plist to \"13.0\" then an error (or warning? I don't remember) is output stating that the value conflicts with the value from the project of \"18.2\", indicating that it isn't getting picked up and is being defaulted to 18.2.\n\nThis part might be subjective, but it seems strange to default the minimum OS version to the maximum OS version. I would think the default OS version should be the minimum OS version supported by the framework. To that point, the configuration from the MAUI template sets `SupportedOSPlatformVersion` to \"11.0\". It seems like that should be the default for `SupportedOSPlatformVersion` isn't specified at all.\n\n### Steps to Reproduce\n\nCreate a MAUI 9.0 project and add the above lines to the project file. Run the project on a device running a version lower than iOS 18.2. It will build, but not deploy.\n\n### Did you find any workaround?\n\nYes, the last two configurations described above.\n\n### Build logs\n\n_No response_","author_login":"bzd3y","author_association":"NONE","created_at":"2025-02-23T16:47:00+08:00","repo_name":"dotnet/macios","issue_id":2873322464,"issue_number":22238,"issue_url":"https://github.com/dotnet/macios/issues/22238","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2678962813","fragment_type":"issue_comment","sequence":1,"text":"This is a bit counterintuitive, but the problem is `TargetPlatformIdentifier` isn't set at this point in the build process - so the question becomes \"why is it working for Mac Catalyst and Android?\"\n\nI was able to test both Android and Mac Catalyst, and it doesn't work on either platform. This is easy enough to see with a non-sensical values:\n\nxml\n 1.0 \n 1.0 \n\nand the build succeeds just fine, for both Android and Mac Catalyst.\n\nchanging to:\n\nxml\n 1.0 \n 1.0 \n\nraises a build error on both platforms.\n\nI'm not sure why it seems to work for you, but it might just be that the default value kicks in and you don't see any problems with it.\n \n\nWe've had different opinions on this internally, and there doesn't seem to be an obvious default logic that works across all platforms. In fact it seem to depend on how old the minimum OS version actually is - would you expect the default to be the minimum iOS version if the minimum was something ridiculous, such as iOS 2.0? This isn't entirely hypothetical, apparently this happens when building for Windows, the SDK supports some rather old versions of Windows.\n\nIn any case, I just wanted to acknowledge that your point is something we're aware of, and we may end up changing in the future.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-02-24T16:13:23+08:00","repo_name":"dotnet/macios","issue_id":2873322464,"issue_number":22238,"issue_url":"https://github.com/dotnet/macios/issues/22238","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2683598237","fragment_type":"issue_comment","sequence":2,"text":"I see, thanks for the explanation. Now that you mention it, the others not working makes sense because I remember before this that changing the value wasn't getting rid of some warnings to version guard some code that I thought it should. Now I know why. I guess that should have clued me in.\n\nBut shouldn't it be set that early in the build process? Otherwise, what use is it? It doesn't have a _ prefix to indicate it is internal. So now my question is why does that exist if it can't be used?\n\nAs for the supported versions, I'll just say that the issue might not be that it doesn't support the minimum by default, but that it only supports exactly the last version by default, so a solution that just handled that differently would probably be better (for example, defaulting to last version - 1 or something like that).","author_login":"bzd3y","author_association":"NONE","created_at":"2025-02-26T00:33:01+08:00","repo_name":"dotnet/macios","issue_id":2873322464,"issue_number":22238,"issue_url":"https://github.com/dotnet/macios/issues/22238","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2684410954","fragment_type":"issue_comment","sequence":3,"text":"It's a known issue, and there's a proposal to improve this scenario: URL (which also explains the reason why it behaves like it does today).","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-02-26T09:31:05+08:00","repo_name":"dotnet/macios","issue_id":2873322464,"issue_number":22238,"issue_url":"https://github.com/dotnet/macios/issues/22238","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0043","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Run DLL error after start?","query_context":"**Describe the bug**\nAfter start of bleachbit I see a popup with an error message \"the module was not found\"\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Install Bleachbit\n2. Start Bleachbit\n3. See error\n\nThe error happens every time.\n\n**Expected behavior**\nNo error popup.\n\n**Screenshots**\nImage\n\n**Desktop (please complete the following information):**\n - OS: Windows 11\n - BleachBit version 4.6.2","known_context_document_ids":["gh_issue_2864436529"],"reference_answer":"@mr-brunes \n@harkinhails \n\nRecently there were major upgrades in the Python framework that may help. Would you please test one of these options?\n\n1. BleachBit 4.9.0 alpha is based on Python 3.10 and is digitally signed\n2. BleachBit 4.9.1 CI build 2775 , based in Python 3.11, is newer but is not digitally signed.\n\nBoth have known issues, so may not be ideal for everyday use. However, testing would tell us a lot about whether the Python upgrade fixed the issue.\n\nA workaround is install BleachBit in a folder without a space such as \n* `c:\\bleachbit`\n* `d:\\bleachbit\n* `d:\\program_files_x86\\bleachbit`\n\nPlease let me know what you find out.","answer_document_id":"gh_comment_2669987493","silver_evidence_path":["gh_comment_2669986301","gh_issue_2340729855","gh_comment_2669987493"],"evidence_issue_ids":[2864436529,2340729855],"source_repo_name":"bleachbit/bleachbit","source_issue_id":2864436529,"source_issue_number":1778,"source_issue_url":"https://github.com/bleachbit/bleachbit/issues/1778","target_repo_name":"bleachbit/bleachbit","target_issue_id":2340729855,"target_issue_number":1685,"target_issue_url":"https://github.com/bleachbit/bleachbit/issues/1685","reference_anchor_document_id":"gh_comment_2669986301","reference_answer_author":"az0","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1613,"anchor_target_overlap":0.875,"target_answer_overlap":0.1},"issue_created_at":"2025-02-19T21:26:24+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2864436529","fragment_type":"issue_description","sequence":0,"text":"Run DLL error after start\n**Describe the bug**\nAfter start of bleachbit I see a popup with an error message \"the module was not found\"\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Install Bleachbit\n2. Start Bleachbit\n3. See error\n\nThe error happens every time.\n\n**Expected behavior**\nNo error popup.\n\n**Screenshots**\nImage\n\n**Desktop (please complete the following information):**\n - OS: Windows 11\n - BleachBit version 4.6.2","author_login":"chrisonline","author_association":"NONE","created_at":"2025-02-19T21:26:24+08:00","repo_name":"bleachbit/bleachbit","issue_id":2864436529,"issue_number":1778,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1778","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2669986301","fragment_type":"issue_comment","sequence":1,"text":"@chrisonline This looks like issue 1685 \"The specified module could not be found\". Recently there were major upgrades in the Python that may help. Would you please test one of these options?\n\n1. BleachBit 4.9.0 alpha is based on Python 3.10 and is digitally signed\n2. BleachBit 4.9.1 CI build 2775 , based in Python 3.11, is newer but is not digitally signed.\n\nBoth have known issues, so may not be ideal for everyday use. However, testing would tell us a lot about whether the Python upgrade fixed the issue.\n\nA third option is to install BleachBit in a folder without a space such as \n* `c:\\bleachbit`\n* `d:\\bleachbit\n* `d:\\program_files_x86\\bleachbit`\n\nPlease let me know what you find out.","author_login":"az0","author_association":"MEMBER","created_at":"2025-02-19T23:21:40+08:00","repo_name":"bleachbit/bleachbit","issue_id":2864436529,"issue_number":1778,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1778","linked_issue_ids":[2340729855],"is_known_query_context":false},{"document_id":"gh_comment_2673835696","fragment_type":"issue_comment","sequence":2,"text":"@az0 With **BleachBit 4.9.0 alpha** I don't get this error anymore. So I will wait until 4.9.0 is released. Thanks.","author_login":"chrisonline","author_association":"NONE","created_at":"2025-02-21T07:56:02+08:00","repo_name":"bleachbit/bleachbit","issue_id":2864436529,"issue_number":1778,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1778","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2340729855","fragment_type":"issue_description","sequence":0,"text":"\"The specified module could not be found.\" - It's back from the dead.\nSame issue fixed here, introduced back again in 4.6.0.","author_login":"harkinhails","author_association":"NONE","created_at":"2024-06-07T15:38:21+08:00","repo_name":"bleachbit/bleachbit","issue_id":2340729855,"issue_number":1685,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1685","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2211844395","fragment_type":"issue_comment","sequence":1,"text":"I am wondering whether it was in fact fixed for 4.4.0 as stated in the related ticket, so do BleachBit 4.4.0 and 4.4.2 have this issue on your system? See old downloads.","author_login":"az0","author_association":"MEMBER","created_at":"2024-07-06T18:33:28+08:00","repo_name":"bleachbit/bleachbit","issue_id":2340729855,"issue_number":1685,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1685","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2402994692","fragment_type":"issue_comment","sequence":2,"text":"4.6.2 still has this issue \"There was a problem starting D:\\Program ... The specified module could not be found.\"","author_login":"mr-brunes","author_association":"NONE","created_at":"2024-10-09T18:22:43+08:00","repo_name":"bleachbit/bleachbit","issue_id":2340729855,"issue_number":1685,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1685","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2669987493","fragment_type":"issue_comment","sequence":3,"text":"@mr-brunes \n@harkinhails \n\nRecently there were major upgrades in the Python framework that may help. Would you please test one of these options?\n\n1. BleachBit 4.9.0 alpha is based on Python 3.10 and is digitally signed\n2. BleachBit 4.9.1 CI build 2775 , based in Python 3.11, is newer but is not digitally signed.\n\nBoth have known issues, so may not be ideal for everyday use. However, testing would tell us a lot about whether the Python upgrade fixed the issue.\n\nA workaround is install BleachBit in a folder without a space such as \n* `c:\\bleachbit`\n* `d:\\bleachbit\n* `d:\\program_files_x86\\bleachbit`\n\nPlease let me know what you find out.","author_login":"az0","author_association":"MEMBER","created_at":"2025-02-19T23:22:34+08:00","repo_name":"bleachbit/bleachbit","issue_id":2340729855,"issue_number":1685,"issue_url":"https://github.com/bleachbit/bleachbit/issues/1685","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0044","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"New styles for footer actions?","query_context":"Here are the styles of this specific component:\n\nImage\n\nAnd more generally of all dropdowns like this: URL \n\nIdeally we’d only get to this after @wagtail/gsoc-ux-unification has implemented their changes to the JS side of this. \n\nNote for footer actions – there is much more than just the dropdown, we also need to make sure the new styles work with the bulk chooser’s components, and with our dirty form check messages.\n\nAs part of this, we could also add this component to the user creation screen to help with #5906. Ideally #7366, #6591, #7650 will have also been fixed.\n\nSub-tasks:\n\n- [x] Re-implement dropdown buttons with Tippy\n- [x] Re-implement bulk actions + button styles according to new designs\n- [x] Include styleguide improvements for warning buttons URL","known_context_document_ids":["gh_issue_1342641565"],"reference_answer":"@Nazi-pikachu no as you can see in my description above this is blocked by two other issues.","answer_document_id":"gh_comment_1377145095","silver_evidence_path":["gh_comment_1898097534","gh_issue_1527230646","gh_comment_1377145095"],"evidence_issue_ids":[1342641565,1527230646],"source_repo_name":"wagtail/wagtail","source_issue_id":1342641565,"source_issue_number":9030,"source_issue_url":"https://github.com/wagtail/wagtail/issues/9030","target_repo_name":"wagtail/wagtail","target_issue_id":1527230646,"target_issue_number":9869,"target_issue_url":"https://github.com/wagtail/wagtail/issues/9869","reference_anchor_document_id":"gh_comment_1898097534","reference_answer_author":"thibaudcolas","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.2,"target_answer_overlap":0.375},"issue_created_at":"2022-08-18T06:55:13+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1342641565","fragment_type":"issue_description","sequence":0,"text":"New styles for footer actions\nHere are the styles of this specific component:\n\nImage\n\nAnd more generally of all dropdowns like this: URL \n\nIdeally we’d only get to this after @wagtail/gsoc-ux-unification has implemented their changes to the JS side of this. \n\nNote for footer actions – there is much more than just the dropdown, we also need to make sure the new styles work with the bulk chooser’s components, and with our dirty form check messages.\n\nAs part of this, we could also add this component to the user creation screen to help with #5906. Ideally #7366, #6591, #7650 will have also been fixed.\n\nSub-tasks:\n\n- [x] Re-implement dropdown buttons with Tippy\n- [x] Re-implement bulk actions + button styles according to new designs\n- [x] Include styleguide improvements for warning buttons URL","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2022-08-18T06:55:13+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1274533203","fragment_type":"issue_comment","sequence":1,"text":"Hi @thibaudcolas I was wondering if this is still open for anyone to work on?","author_login":"ForJessicaSake","author_association":"NONE","created_at":"2022-10-11T11:26:30+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1277251789","fragment_type":"issue_comment","sequence":2,"text":"Hi @ForJessicaSake, yep, I don’t think anyone else has worked on this.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2022-10-13T08:40:43+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1277260603","fragment_type":"issue_comment","sequence":3,"text":"Okay great, I’ll work on it can you please assign it to me 😊 thank you!","author_login":"ForJessicaSake","author_association":"NONE","created_at":"2022-10-13T08:48:01+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1279555853","fragment_type":"issue_comment","sequence":4,"text":"@ForJessicaSake we do not assign issues (outside of core team) so feel free to just start on this.","author_login":"lb-","author_association":"MEMBER","created_at":"2022-10-14T22:45:45+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291270942","fragment_type":"issue_comment","sequence":5,"text":"Hi @ForJessicaSake, can you let us know where you got to with this? Please let us know if you have any questions.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2022-10-26T00:13:41+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306777106","fragment_type":"issue_comment","sequence":6,"text":"@Seremba feel free to give this a go as we have not heard back from @ForJessicaSake for some time.","author_login":"lb-","author_association":"MEMBER","created_at":"2022-11-08T07:58:31+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1308354113","fragment_type":"issue_comment","sequence":7,"text":"Hi @thibaudcolas @lb- would you mind helping me locate the file for these changes?","author_login":"Seremba","author_association":"CONTRIBUTOR","created_at":"2022-11-09T07:59:00+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317649408","fragment_type":"issue_comment","sequence":8,"text":"@Seremba have a look at this PR - it touches the same area of the UI. \n\n URL \n\nHowever, it's good to learn how to find these things yourself. The best way is to look at the CSS classes in the DOM and search through the code in your editor.","author_login":"lb-","author_association":"MEMBER","created_at":"2022-11-16T20:47:39+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1898097534","fragment_type":"issue_comment","sequence":9,"text":"I’ve done quite a bit of the work on this in #11456 – the footer actions code is much simpler now, so should be easier for us to complete this ticket. There were a few snags:\n\n- The proposed widths for the sticky actions would mean a lot more wrapping of text to two lines for languages longer than english (so I stopped at 310px rather than the 250px in the designs)\n- The designs in Ben’s original screenshot here have too low contrast between the footer actions background and the page background in my opinion. Not sure this is an actual issue but I found it hard on the eye to not know exactly what part of the page was sticky and what was within. Something I’d like to discuss at least.\n\nAnd more generally:\n\n- Those styles need to work for both footer actions on \"forms\", and bulk actions. Currently we only have designs for very simple \"form\" footer actions, while the bulk actions are more complex visually\n- We need to make sure the footer actions also support having text within, the \"unsaved page data\" warning and also meta text for bulk actions.\n\n---\n\nAnother snag was that footer actions markup currently is copy-pasted all over the place, with lots of inconsistencies. So as part of completing this I think we need to refactor the code to have an implementation that’s easier to reuse. Particularly in the context of #9869.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-01-18T09:23:14+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[1527230646],"is_known_query_context":false},{"document_id":"gh_comment_2324311811","fragment_type":"issue_comment","sequence":10,"text":"Assigning back to @benenright for a review of how we can tweak the designs to complete this, based on my notes above. Here are specific problem scenarios that might warrant design changes.\n\n## Footer actions with warning message\n\nfooter actions with warning text\n\n## Bulk actions\n\nbulk actions\n\n## Bulk actions with \"Select all\" link\n\nbulk actions select all","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-09-02T09:51:56+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2324453731","fragment_type":"issue_comment","sequence":11,"text":"I think that we should keep the background indigo, as I don't think there is much value in trying to make a light background work behind these actions, and the potential usability issues outway the original intention...\n\nThe original intention was to reduce the visual weight of the form footer actions - being something that sticks on the browser bottom edge, it felt like this was worth trying. But in the context of the bulk actions, that only appear once triggered by selecting a checkbox, the dark background helps users to notice it, and if we move to a lower contrast background, it risks them not being noticed (some usability testing we did a while back showed that some users expected these bulk actions to appear at the top of the listing (as per Gmail for eg), but since the indigo bg was high contrast with the page bg, people did notice it at bottom).\n\nI do think it would be worth revisiting how we ensure good contrast for this type of panel specifically in dark mode (as the low contrast means we likely have that usability issue where people don't notice it appear):\n\nimage","author_login":"benenright","author_association":"NONE","created_at":"2024-09-02T11:04:19+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2326344340","fragment_type":"issue_comment","sequence":12,"text":"@benenright I forgot one other variation on footer actions, which is used when viewing a past version of a page:\n\nfooter actions past revision\n\nThis is testable on this past revision demo page. Could you give us design guidance for that as well?\n\n---\n\nre bulk actions, anecdotally we received related feedback from low-vision users (though it’s low on details so I’m following up):","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-09-03T12:00:25+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2355579068","fragment_type":"issue_comment","sequence":13,"text":"Hi\n\nIn this view, I don't know the history as to why the button is orange, but to me it feels like the top banner is doing enough to alert people this is a previous version of this page. I feel like for that reason we _could_ just revert the buttons to be teal here...\n\nHowever, maybe it's likely that people who have become used to seeing the buttons orange will get confused if they go back to teal). So for that reason it's prob safer just to address the fact that the white text on orange is not high enough contrast... and we should change it to use the same text colour as in the alert banner. \n\nImage\n\n----\n\nWhile we're here. could we fix this UI glitch where the button loses it's top left and top right border radius after you open then close the options:\n\nBefore:\nImage\n\nAfter:\nImage","author_login":"benenright","author_association":"NONE","created_at":"2024-09-17T12:21:46+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2401726842","fragment_type":"issue_comment","sequence":14,"text":"👍 sounds good to me that we’d have the button consistently teal. As you say the banner is already doing a good job warning users, and the button text is different as well. Also agree re keeping the indigo background in the light theme.\n\nWill leave it with @laymonage to figure out where to place the \"Delete\" buttons we occasionally have in forms, that could either go in a \"footer actions\" dropdown, or in a \"slim header\" falafel actions menu 👀","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-10-09T08:50:46+08:00","repo_name":"wagtail/wagtail","issue_id":1342641565,"issue_number":9030,"issue_url":"https://github.com/wagtail/wagtail/issues/9030","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1527230646","fragment_type":"issue_description","sequence":0,"text":"Implement sticky form actions across all forms\n### Is your proposal related to a problem?\n\nSee #9760 for further context. Blocked by #9030, #7366. On some of the forms in the CMS, we have the \"Submit\" and other action buttons at the end of the form, while on others we use a \"sticky footer actions\" component. For consistency, we’d like to switch all forms to \"sticky actions\" wherever possible.\n\n### Describe the solution you'd like\n\n- The Save/Submit button of a form should be sticky at the bottom of the screen.\n- Any secondary action buttons (\"Delete\") should live within the dropdown\n\n### Describe alternatives you've considered\n\nSee UX research in #9760.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2023-01-10T11:29:59+08:00","repo_name":"wagtail/wagtail","issue_id":1527230646,"issue_number":9869,"issue_url":"https://github.com/wagtail/wagtail/issues/9869","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377127582","fragment_type":"issue_comment","sequence":1,"text":"Hi @thibaudcolas i would like to work on this issue, is it up for grab?","author_login":"Nazi-pikachu","author_association":"CONTRIBUTOR","created_at":"2023-01-10T11:39:45+08:00","repo_name":"wagtail/wagtail","issue_id":1527230646,"issue_number":9869,"issue_url":"https://github.com/wagtail/wagtail/issues/9869","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377145095","fragment_type":"issue_comment","sequence":2,"text":"@Nazi-pikachu no as you can see in my description above this is blocked by two other issues.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2023-01-10T11:52:35+08:00","repo_name":"wagtail/wagtail","issue_id":1527230646,"issue_number":9869,"issue_url":"https://github.com/wagtail/wagtail/issues/9869","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0046","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"There is a probability of crashing when using Warhammer right-click to attack creatures?","query_context":"version 1.20.1\nforge 47.3.1\nweaponmod-forge-1.20.1-1.21.3\narchitectury-9.2.14-forge\ncloth-config-11.1.118-forge\nThere is a probability of crashing when using Warhammer right-click to attack creatures.\nI really like this mod.\nAlso, my English is not good, so I used mechanical translation.","known_context_document_ids":["gh_issue_2382678492"],"reference_answer":"Alright, I've looked into this again. Not sure where my head was at before, but I've reverted my previous changes, applied the suggested changes, and released a new version.\nThanks again @XFactHD for your input!","answer_document_id":"gh_comment_1406683731","silver_evidence_path":["gh_comment_2199311190","gh_issue_1511265531","gh_comment_1406683731"],"evidence_issue_ids":[2382678492,1511265531],"source_repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","source_issue_id":2382678492,"source_issue_number":45,"source_issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","target_repo_name":"CyclopsMC/EvilCraft","target_issue_id":1511265531,"target_issue_number":961,"target_issue_url":"https://github.com/CyclopsMC/EvilCraft/issues/961","reference_anchor_document_id":"gh_comment_2199311190","reference_answer_author":"rubensworks","reference_answer_author_association":"MEMBER","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3333,"target_answer_overlap":0.0},"issue_created_at":"2024-07-01T02:46:42+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2382678492","fragment_type":"issue_description","sequence":0,"text":"There is a probability of crashing when using Warhammer right-click to attack creatures\nversion 1.20.1\nforge 47.3.1\nweaponmod-forge-1.20.1-1.21.3\narchitectury-9.2.14-forge\ncloth-config-11.1.118-forge\nThere is a probability of crashing when using Warhammer right-click to attack creatures.\nI really like this mod.\nAlso, my English is not good, so I used mechanical translation.","author_login":"Wheatley11","author_association":"NONE","created_at":"2024-07-01T02:46:42+08:00","repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","issue_id":2382678492,"issue_number":45,"issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2199077838","fragment_type":"issue_comment","sequence":1,"text":"I tried to reproduce this bug again and found that it only crashes when the focus is on the creature.\nThis is the log of the game crash. I hope it can help lock in the bug.\nminecraft-exported-logs-2024-07-01T10-47-35.log","author_login":"Wheatley11","author_association":"NONE","created_at":"2024-07-01T02:52:51+08:00","repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","issue_id":2382678492,"issue_number":45,"issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2199203061","fragment_type":"issue_comment","sequence":2,"text":"I am trying to reproduce this currently, but I am unable to do so yet.\nYour logs are cut-off sadly. Could you try posting the full file?\nAlso, the file `G:\\game\\game2\\我的世界\\.minecraft\\versions\\1.20.1ff\\crash-reports\\crash-2024-07-01_10.47.10-client.txt` might help","author_login":"ThexXTURBOXx","author_association":"OWNER","created_at":"2024-07-01T04:22:18+08:00","repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","issue_id":2382678492,"issue_number":45,"issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2199224772","fragment_type":"issue_comment","sequence":3,"text":"Sadly, this is still cut off - I need everything that is above ` at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?] {}`\n\nYour current crash log does not show something specific to BWM: Legacy yet","author_login":"ThexXTURBOXx","author_association":"OWNER","created_at":"2024-07-01T04:46:42+08:00","repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","issue_id":2382678492,"issue_number":45,"issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2199286759","fragment_type":"issue_comment","sequence":4,"text":"Sorry, I don't quite understand this. The previous logs were automatically exported by an unofficial launcher. This is the log I found in the logs folder\nlatest.log","author_login":"Wheatley11","author_association":"NONE","created_at":"2024-07-01T05:46:10+08:00","repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","issue_id":2382678492,"issue_number":45,"issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2199311190","fragment_type":"issue_comment","sequence":5,"text":"Now I can see the full crash log, thanks :)\n\nThis is the same issue as URL so the fix should be rather analogous","author_login":"ThexXTURBOXx","author_association":"OWNER","created_at":"2024-07-01T06:06:15+08:00","repo_name":"ThexXTURBOXx/Balkons-WeaponMod-Legacy","issue_id":2382678492,"issue_number":45,"issue_url":"https://github.com/ThexXTURBOXx/Balkons-WeaponMod-Legacy/issues/45","linked_issue_ids":[1511265531],"is_known_query_context":false},{"document_id":"gh_issue_1511265531","fragment_type":"issue_description","sequence":0,"text":"IllegalStateException: Accessing LegacyRandomSource from multiple threads\n#### Issue type:\n\n- :bug: Bug \n\n____\n\n#### Short description:\n\nGame crashes due to blood_splash particle colliding with blood_stain block.\n\n#### Exact Error:\nThe game crashed whilst accessing legacyrandomsource from multiple threads\nError: java.lang.IllegalStateException: Accessing LegacyRandomSource from multiple threads\n\nSame as #954 and #949 in the ATM8 modpack.\n\n#### Steps to reproduce the problem:\n\n1. Load the game, play for a while\n2. Mobs receive damage by falling or in a mob farm\n3. Game crashes due to collision of blood particle and blood stain\n\n#### Expected behaviour:\n\nThe game should not be crashing randomly due to blood stain block and blood splash particle interaction.\n____\n\n#### Versions:\n\n- This mod: EvilCraft 1.2.12\n- Minecraft: 1.19.\n- Forge: 43.1.55\n- ATM8 Modpack: 1.0.7\n\n#### Log file:\n\ncrash-2022-12-26_13.19.15-server.txt","author_login":"Ninjawolf0007","author_association":"NONE","created_at":"2022-12-26T21:42:37+08:00","repo_name":"CyclopsMC/EvilCraft","issue_id":1511265531,"issue_number":961,"issue_url":"https://github.com/CyclopsMC/EvilCraft/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365686848","fragment_type":"issue_comment","sequence":1,"text":"EvilCraft isn't using `LegacyRandomSource` anywhere anymore since #954 as it isn't thread-safe.\n\nHowever, Minecraft itself _is_ using `LegacyRandomSource` for spawning particles. So if another mod is using `LegacyRandomSource` incorrectly, and Minecraft spawn a particle, a delayed crash will occur. So the other mod that is using `LegacyRandomSource` incorrectly is at fault here.\nOther particle-generating mods will likely result in a similar crash due to this, even though they are not at fault.\n\nI recommend reporting to your modpack author, and asking them to add/remove mods until they find the offending mod, and reporting it to them. There's not much I can do on my end unfortunately.","author_login":"rubensworks","author_association":"MEMBER","created_at":"2022-12-27T07:51:22+08:00","repo_name":"CyclopsMC/EvilCraft","issue_id":1511265531,"issue_number":961,"issue_url":"https://github.com/CyclopsMC/EvilCraft/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1403884727","fragment_type":"issue_comment","sequence":2,"text":"Since this issue is still happening in the latest version of AllTheMods 8 (1.0.9), further research into this was done and it was found that EvilCraft is indeed at fault here despite the previous fix. The previously deployed fix doesn't achieve anything regarding this issue as the crash doesn't happen directly in any of the code touched by the fix since that code did use the correct `RandomSource` from the `Level` given by the caller. The actual crash always happens in Minecraft code when the `LevelRenderer` tries to apply some particle amount randomisation because it tries to use the client level's random from the server thread where your code unintentionally calls it from.\n\nThe underlying issue causing this crash is that the spawning of the blood splash particles ( URL does not check for the logical client side, it only checks for the physical client side, both explicitely via the helper call (checks `FMLEnvironment.dist == Dist.CLIENT`, which is purely the physical side) and implicitely via the `@OnlyIn(Dist.CLIENT)` annotation. This leads to the particle spawning code being called from the server thread in singleplayer as is visible in both the stacktrace linked by the OP and this log snippet where the logging of the `LegacyRandomSource` was extended via Mixins for debugging purposes. The proper fix for this is to replace the helper call with a call to `Level#isClientSide()` in the method linked above, which would prevent the code from reaching across logical sides and crashing in the `LevelRenderer`'s random shenanigans.\n\nIt's also worth noting that the previous fix is potentially unsafe since it deploys a global and completely unguarded `SingleThreadedRandomSource`, which may produce weird results when accessed from multiple threads, which is the reason why the `LegacyRandomSource` crashes in these concurrent access scenarios.","author_login":"XFactHD","author_association":"NONE","created_at":"2023-01-25T16:26:41+08:00","repo_name":"CyclopsMC/EvilCraft","issue_id":1511265531,"issue_number":961,"issue_url":"https://github.com/CyclopsMC/EvilCraft/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1404640930","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the findings @XFactHD! Will have a look at this soon.","author_login":"rubensworks","author_association":"MEMBER","created_at":"2023-01-26T07:29:49+08:00","repo_name":"CyclopsMC/EvilCraft","issue_id":1511265531,"issue_number":961,"issue_url":"https://github.com/CyclopsMC/EvilCraft/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1406683731","fragment_type":"issue_comment","sequence":4,"text":"Alright, I've looked into this again. Not sure where my head was at before, but I've reverted my previous changes, applied the suggested changes, and released a new version.\nThanks again @XFactHD for your input!","author_login":"rubensworks","author_association":"MEMBER","created_at":"2023-01-27T15:49:51+08:00","repo_name":"CyclopsMC/EvilCraft","issue_id":1511265531,"issue_number":961,"issue_url":"https://github.com/CyclopsMC/EvilCraft/issues/961","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0047","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[PT Run] [Time and Date plugin] Allow custom format string?","query_context":"### Description of the new feature / enhancement\n\nThe PR #16662 implements a new plugin for date and time values.\n\nIt might be interesting to support custom format string as user input like the wox plugin \"DateTimeFormatter\".\n\n### Scenario when this would be used?\n\nIf the user needs an unsupported format.\n\n### Supporting information\n\n URL \n\n---\n\n⚠ The work on this enhancement can't begin before the plugin code is merged into main branch!!","known_context_document_ids":["gh_issue_1164290560"],"reference_answer":"@Picazsoo \nGreat request. Feel free to open the PR. Your contribution is welcome. If you need any help, you can ask me.\n\nI personally prefer `YYYY-MM-DD_HH-MM-SS` in my file names. Not sure what's better or if we need both variations/a setting.","answer_document_id":"gh_comment_1482750791","silver_evidence_path":["gh_comment_1475403472","gh_issue_1631100144","gh_comment_1482750791"],"evidence_issue_ids":[1164290560,1631100144],"source_repo_name":"microsoft/PowerToys","source_issue_id":1164290560,"source_issue_number":16934,"source_issue_url":"https://github.com/microsoft/PowerToys/issues/16934","target_repo_name":"microsoft/PowerToys","target_issue_id":1631100144,"target_issue_number":24911,"target_issue_url":"https://github.com/microsoft/PowerToys/issues/24911","reference_anchor_document_id":"gh_comment_1475403472","reference_answer_author":"htcfreek","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.3387,"target_answer_overlap":0.125},"issue_created_at":"2022-03-09T18:25:12+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1164290560","fragment_type":"issue_description","sequence":0,"text":"[PT Run] [Time and Date plugin] Allow custom format string\n### Description of the new feature / enhancement\n\nThe PR #16662 implements a new plugin for date and time values.\n\nIt might be interesting to support custom format string as user input like the wox plugin \"DateTimeFormatter\".\n\n### Scenario when this would be used?\n\nIf the user needs an unsupported format.\n\n### Supporting information\n\n URL \n\n---\n\n⚠ The work on this enhancement can't begin before the plugin code is merged into main branch!!","author_login":"htcfreek","author_association":"COLLABORATOR","created_at":"2022-03-09T18:25:12+08:00","repo_name":"microsoft/PowerToys","issue_id":1164290560,"issue_number":16934,"issue_url":"https://github.com/microsoft/PowerToys/issues/16934","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1475403472","fragment_type":"issue_comment","sequence":1,"text":"Hi @htcfreek , I think this is a really good idea. Even better would be to _also_ be able to manually add custom format string in the Date and Time plugin settings. So the user could specify their own custom format and always have it appear as the very last result (hence possible to navigate directly to it by pressing up).\n\nThe reason this functionality would be pretty useful is because currently none of the include date & time formats can be directly pasted into a Windows file / directory name, since they include either forward slashes or colons. I created an issue #24911 for a proposal for a simple addition of one more date time format, but more robust solution with custom persistable format would be preferable I think.","author_login":"Picazsoo","author_association":"NONE","created_at":"2023-03-19T21:22:40+08:00","repo_name":"microsoft/PowerToys","issue_id":1164290560,"issue_number":16934,"issue_url":"https://github.com/microsoft/PowerToys/issues/16934","linked_issue_ids":[1631100144],"is_known_query_context":false},{"document_id":"gh_comment_2695536691","fragment_type":"issue_comment","sequence":2,"text":"I have searched for this and can't find it, so apologies if it's a duplicate suggestion.\n\nI spend a lot of time with one foot in the USA and the other in Great Britain or Europe, and that means dates being misinterpreted because of the **mm/dd/yy** vs **dd/mm/yy** thing we are all familiar with.\n\nThis multicultural issue has led me in my daily life to use the format you see on passports and some American driver licenses: \nDD-MMM-YYYY, for example, today is: **3 MAR 2025**\n\nIt is impossible to misinterpret a date written in this format, and I've taken to formatting my dates this way in Excel and in correspondence. I mostly use a short \"long form\" in my correspondence when adding days of the week: **Mon 3 Mar 2025**\n\n**The cultural issue, which I suspect many people have, particularly Americans working overseas:**\nHaving worked on loads of US based accounting documents in my career, my habit is to enter dates on the numerical keypad in US format. So while I **_write_** today's date as Mon 3-Mar-2025, I **_enter_** today's date in Excel as 3/3/25. \n\nSo far, so good - Windows can do this, and Excel can do this, as it stores dates as numbers and we have loads of formatting options including just this issue. _But that is only true if my Windows settings are set to USA, like this:_\n \n\nBut I really struggle with that - I **want** my Windows system date to look like this:\n \n\n_**Actually, I would prefer the system date to read \"**Mon 3 Mar 2025**\" but I can't find a way to produce this \"short\" longform**_\n\n**Problem #1**\nWhen you dig into the \"English (world) settings, there is no short or long form option that abbreviates the days of the week to Mon, Tue, Wed, Thu, Fri, Sat and Sun. The longform system date that includes the day of the week uses too much real estate.\n\nIt would be terrific if we could add an abbreviated day of week to the short date option.\n\n**Problem #2**\nWhen you have set the system date parameters to the \"world\" settings, your excel spreadsheets no longer provide a formatting option which permits data entry in dd/mm/yy format. Your entire Excel world is now expecting data entry in mm/dd/yy format and its derivatives.\n\nI cannot for the life of me sort out how use the international system date format I prefer in combination with Excel accepting date entry in standard US format of mm/dd/yy with the option of displaying those dates in the \"International Passport\" format.\n\nPerhaps I'm missing something despite having played around with Excel date and custom format options for ages.\n\nIs this something that could be done? Or have I completely missed the standard options available to me?\n\nThanks","author_login":"YankeeGeordie","author_association":"NONE","created_at":"2025-03-03T21:07:32+08:00","repo_name":"microsoft/PowerToys","issue_id":1164290560,"issue_number":16934,"issue_url":"https://github.com/microsoft/PowerToys/issues/16934","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2695649824","fragment_type":"issue_comment","sequence":3,"text":"Well you bring me to an following idea that could be the best solution. We add a multilline text setting that allows the following:\n\nMyFormat1=YYYY-DD-MM\nMyFormat2=DD-MMM-YYYY\n....","author_login":"htcfreek","author_association":"COLLABORATOR","created_at":"2025-03-03T21:55:06+08:00","repo_name":"microsoft/PowerToys","issue_id":1164290560,"issue_number":16934,"issue_url":"https://github.com/microsoft/PowerToys/issues/16934","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2695963938","fragment_type":"issue_comment","sequence":4,"text":"Thank you.\n\nSince my programming days pretty much ended with COBOL, FORTRAN and dBase\nIII with a touch of SQL in the 1980s, I'll not annoy you with code related\nsuggestions, but perhaps this clarification helps:\n\n1. Excel appears to derive what it expects as date *entry* formats from the\nsystem date setting.\n2. Excel offers different date *formatting *options based on the formatting\nof the system date.\n3. A logical fork which allows *formatting* the displayed system date *to\nbe different *from the instructions Excel receives might prove useful in\ngetting the end result I'm suggesting.\n4. Adding more examples to include day of week to your multiline text:\n\nMyFormat3=DOW-DD-MMM-YYYY\nMyFormat4=DOW_DD_MMM_YYYY\n\nSo put another way, what I'm suggesting is a *separation* between the\nsystem date format as shown on the Windows taskbar and the system date\nformat as read by Excel (and likely other Microsoft products). Either\nthat, or modify the date options code in Excel that permits the same level\nof customization.\n\nTo follow any of this, one must understand something that I find very odd\nand might be missed at first reading, so I'll repeat it:\n\nWhile Excel stores dates as numbers and can format their display in many\ndifferent ways, Excel does not appear to offer options as to how those\ndates are entered. So if the system date is set to \"World\", Excel expects\nyou to enter dates in dd/mm/yy sequence. I propose a bifurcated approach,\nallowing display of system date in World format and data entry of dates in\nUS format.\n\nI hope that is clear! And if you got all that the first time, I apologize\nfor repeating it. Thank you again.\n\nOn Mon, Mar 3, 2025 at 3:55 PM Heiko ***@***.***> wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n-- \nMark Merritt\n***@***.***\n505.270.5522","author_login":"YankeeGeordie","author_association":"NONE","created_at":"2025-03-04T01:38:07+08:00","repo_name":"microsoft/PowerToys","issue_id":1164290560,"issue_number":16934,"issue_url":"https://github.com/microsoft/PowerToys/issues/16934","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1631100144","fragment_type":"issue_description","sequence":0,"text":"Filename-compatible datetime format in PowerToys Run Time and Date plugin\n### Description of the new feature / enhancement\n\nThe _Time and Date_ plugin functionality in _PowerToys Run_ is very handy for quick obtaining of current date / date and time. However none of the existing options are compatible with Windows filenames constraints. That means that it is not possible to quickly obtain a date-time in format, that could be easily pasted into a filename/directory name when e.g. downloading a file from the internet or simply saving or renaming any file or creating/renaming a directory.\n\nI propose a solution by adding additional filename-compatible version of the timestamp.\nThe date and time formatting should:\n- be easily human-readable\n- allow for good file sorting by name (year -> month -> day -> hour -> minute -> second)\n- omit any characters forbidden in Windows file names (e.g. forward slashes and colons)\n\nOne such possibility would be `yyyy_MM_dd-hh_mm_ss`. However this is not set in stone and I am definitely open to suggestions.\n\nI am happy to provide a PR with the changes if there is agreement that this would be a sensible addition to the project.\n\n### Scenario when this would be used?\n\nThis would be used when needing to obtain human-readable current date and time that can be embedded in directory/file name. Currently no such format is available.\n\n### Supporting information\n\n_No response_","author_login":"Picazsoo","author_association":"CONTRIBUTOR","created_at":"2023-03-19T20:10:56+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1480322548","fragment_type":"issue_comment","sequence":1,"text":"Hi @stefansjfw Stefan,\nI disagree that this is a dupe of the issue #16934. In that issue the referenced Wox plugin's behavior is that a user can type the requested format into the prompt and have the current date formatted as such. That is obviously cumbersome for day to day use, since one would have to retype the required format string on every single invocation. What I propose is a permanent addition of one additional format in the results that would provide easily pastable filename-compatible format.\n\nBut I can continue the conversation in the other issue I guess if it is inappropriate here.\n\nBest regards,\nJachym","author_login":"Picazsoo","author_association":"NONE","created_at":"2023-03-22T22:09:27+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1480350251","fragment_type":"issue_comment","sequence":2,"text":"@Picazsoo Ok, I was considering linked issue as a more generic solution. Reopening the issue.","author_login":"stefansjfw","author_association":"COLLABORATOR","created_at":"2023-03-22T22:42:38+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482750791","fragment_type":"issue_comment","sequence":3,"text":"@Picazsoo \nGreat request. Feel free to open the PR. Your contribution is welcome. If you need any help, you can ask me.\n\nI personally prefer `YYYY-MM-DD_HH-MM-SS` in my file names. Not sure what's better or if we need both variations/a setting.","author_login":"htcfreek","author_association":"COLLABORATOR","created_at":"2023-03-24T12:53:10+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1483514128","fragment_type":"issue_comment","sequence":4,"text":"Hi @htcfreek, I have no problem with your proposed format. I am not sure that including both options would be a good idea, because these two are not the two only valid options anyway and even including just two variations would already bloat up the results list. So if you agree I would stick to your format for now.\n\nI have more ambitious implementation working that allows enabling & customizing the date & time format string in the settings, but I would prefer to only do that after this simple implementation as the changes are much larger and I expect some understandable push-back on that one.","author_login":"Picazsoo","author_association":"NONE","created_at":"2023-03-24T22:29:59+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1483852080","fragment_type":"issue_comment","sequence":5,"text":"@Picazsoo \nNo need to stress you. Please update the unit test project too.","author_login":"htcfreek","author_association":"COLLABORATOR","created_at":"2023-03-25T15:33:32+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1483931812","fragment_type":"issue_comment","sequence":6,"text":"I had to change from `yyyy-MM-dd_hh-mm-ss` to `yyyy-MM-dd_HH-mm-ss`. Otherwise the hourly value in the timestamp would be terribly ambiguous - therefore useless.","author_login":"Picazsoo","author_association":"NONE","created_at":"2023-03-25T21:59:06+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1538777094","fragment_type":"issue_comment","sequence":7,"text":"Fixed in 0.69 which was released in the start of April 2023.","author_login":"crutkas","author_association":"MEMBER","created_at":"2023-05-08T17:41:46+08:00","repo_name":"microsoft/PowerToys","issue_id":1631100144,"issue_number":24911,"issue_url":"https://github.com/microsoft/PowerToys/issues/24911","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0049","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"InputImageRotation issues: Vertical images are not working, etc...","query_context":"In Flutter I am trying to detect text from images in horizontal orientation is working perfectly but Vertical orientation text is not detected.\nI am using the google_ml_kit plugin.\nAnyone has a solution for this or another way to achieve this functionality.\n\nHere you can check it is working with native android :- URL","known_context_document_ids":["gh_issue_1220531565"],"reference_answer":"Closing this issue.\n\nFix: google_mlkit_text_recognition instead of `google_ml_kit`.\n\nMore details here: URL \n\nMoving `InputImage` and `InputImageRotation` issues to: URL","answer_document_id":"gh_comment_1113691037","silver_evidence_path":["gh_comment_1113685031","gh_issue_1212534085","gh_comment_1113691037"],"evidence_issue_ids":[1220531565,1212534085],"source_repo_name":"flutter-ml/google_ml_kit_flutter","source_issue_id":1220531565,"source_issue_number":240,"source_issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","target_repo_name":"bharat-biradar/Google-Ml-Kit-plugin","target_issue_id":1212534085,"target_issue_number":231,"target_issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","reference_anchor_document_id":"gh_comment_1113685031","reference_answer_author":"fbernaly","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.4286,"target_answer_overlap":0.3846},"issue_created_at":"2022-04-29T11:04:03+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_1220531565","fragment_type":"issue_description","sequence":0,"text":"InputImageRotation issues: Vertical images are not working, etc...\nIn Flutter I am trying to detect text from images in horizontal orientation is working perfectly but Vertical orientation text is not detected.\nI am using the google_ml_kit plugin.\nAnyone has a solution for this or another way to achieve this functionality.\n\nHere you can check it is working with native android :- URL","author_login":"bipin-sakariya","author_association":"NONE","created_at":"2022-04-29T11:04:03+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1113672934","fragment_type":"issue_comment","sequence":1,"text":"Same Problem here.\n\nI am using the example app provided by the package author.\nIt works fine in portrait mode but if I rotate the device all the API's stop working or acting malfunction.\n\nTo be specific, I am using Samsung Galaxy Tab A7 SM-T505 right now and it is not working OK.\n\nTo test if there is a problem in imageOrientation I just added a log print over this function inside _processCameraImage:\n\n...\nfinal imageRotation = InputImageRotationValue.fromRawValue(camera.sensorOrientation) ?? InputImageRotation.rotation0deg;\n print('orientation: ${imageRotation.rawValue}');\n...\n\nand find that it is always 90 even if I rotate the device it will always detect my device in landscape mode.\nI don't know if I am testing and point in correct direction but I think it is something related to the cameraOrientation which brings this bug.\n\nI am using the last version of camera and recent update of ml_kit.\n\ngoogle_ml_kit: ^0.10.0\n camera: ^0.9.4+20","author_login":"prooshani","author_association":"NONE","created_at":"2022-04-29T19:58:55+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113683815","fragment_type":"issue_comment","sequence":2,"text":"This issue has to do with the orientation of your device/camera/inputImage. The example app is not production code and only works on portrait mode. Feel free to modify the example app to support landscape, but you need to edit this method: URL \n\nI have not played that much with the orientation and metadata, but you need to create the correct instance of `InputImagePlaneMetadata` and `InputImageData` to pass to `InputImage.fromBytes`.\n\nOnce you figure it out come back and share the fix here or create a PR, contributions are always welcome.","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-29T20:13:26+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113685031","fragment_type":"issue_comment","sequence":3,"text":"Another comment in another discussion that might help you to resolve your issue is here: URL","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-29T20:15:04+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[1212534085],"is_known_query_context":false},{"document_id":"gh_comment_1113959849","fragment_type":"issue_comment","sequence":4,"text":"As you mentioned earlier, I believe it is something related to camera package which cannot find the correct aspect ratio after orientation change.\nTo be exact, the imageProcess is working on something different than what you have in cameraPreview because, if you move the camera at the edge, where the barcode is merely outside the cameraPreview, you can see that it can detect the barcode correctly. SO, I think the image which is processing has different data than what we have in the cameraPreview.\n\nI hope I could investigate further to see if I can match the zoom level of Landscape and Portrait in cameraPreview to see if the issue is resolved or not.\n\nAny suggestion is highly appreciated.","author_login":"prooshani","author_association":"NONE","created_at":"2022-04-30T09:51:08+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113960168","fragment_type":"issue_comment","sequence":5,"text":"From my view the current culprit is this widget from camera_view.dart:\n\n` Widget _liveFeedBody() {\n if (_controller?.value.isInitialized == false) {\n return Container();\n }\n\n final size = MediaQuery.of(context).size;\n // calculate scale depending on screen and camera ratios\n // this is actually size.aspectRatio / (1 / camera.aspectRatio)\n // because camera preview size is received as landscape\n // but we're calculating for portrait orientation\n var scale = size.aspectRatio * _controller.value.aspectRatio;\n\n // to prevent scaling down, invert the value\n if (scale [\n \n Transform.scale(\n scale: scale,\n child: Center(\n child: _changingCameraLens\n ? Center(\n child: const Text('Changing camera lens'),\n )\n : CameraPreview(_controller),\n ),\n ),\n if (widget.customPaint != null) widget.customPaint,\n Positioned(\n bottom: 100,\n left: 50,\n right: 50,\n child: Slider(\n value: zoomLevel,\n min: minZoomLevel,\n max: maxZoomLevel,\n onChanged: (newSliderValue) {\n setState(() {\n zoomLevel = newSliderValue;\n _controller.setZoomLevel(zoomLevel);\n });\n },\n divisions: (maxZoomLevel - 1).toInt() < 1 ? null : (maxZoomLevel - 1).toInt(),\n ),\n )\n ],\n ),\n );\n }\n`","author_login":"prooshani","author_association":"NONE","created_at":"2022-04-30T09:53:27+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124357165","fragment_type":"issue_comment","sequence":6,"text":"The landscape zoomed picture problem rooted from this part of the code:\n\n Transform.scale(\n scale: scale,\n child: Center(\n child: _changingCameraLens\n ? Center(\n child: const Text('Changing camera lens'),\n )\n : CameraPreview(_controller),\n ),\n ),\n\nIf you change the `scale: scale` to `scale:1` it will fix the landscape orientation zoom problem but with some drawbacks.\nThe main cons of doing this is the aspect ratio of the camera preview, which looks to be not the same as the main scaffold's body.\nAfter all, I think passing 1 to `scale` may solve the problem for now.","author_login":"prooshani","author_association":"NONE","created_at":"2022-05-11T22:38:43+08:00","repo_name":"flutter-ml/google_ml_kit_flutter","issue_id":1220531565,"issue_number":240,"issue_url":"https://github.com/flutter-ml/google_ml_kit_flutter/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1212534085","fragment_type":"issue_description","sequence":0,"text":"TextRecognizer works ok on Android but the result letters are all corrupted on iOS\nHi,\n\nI got recommended to use google_mlkit_text_recognition instead of google_ml_kit as followes\n URL \n\nHowever, it still works ok on Android but not on iOS using google_mlkit_text_recognition as using google_ml_kit\n\nrecognizedText.text look ok on Android but the letters in it are all corrupted on iOS\nFor now, I need only English TextRecognizer\n\n import 'package:google_mlkit_text_recognition/google_mlkit_text_recognition.dart';\n\n textRecognizer = TextRecognizer(script: TextRecognitionScript.latin);\n final File? imageFile = await getImage(ImageSource.gallery);\n\n if(imageFile != null) {\n final inputImage = InputImage.fromFile(imageFile);\n final RecognizedText recognizedText = await textRecognizer.processImage(inputImage);\n \n String text = recognizedText.text;\n print('${this.className} extractText : ' + text);\n }\n\ngoogle_mlkit_text_recognition 0.0.1\n\nMy development environment is as followes\niOS 14.7.1\nXcode 13.3\n\nPlease help me to solve this issue\nThanks in advance","author_login":"kodol73","author_association":"NONE","created_at":"2022-04-22T16:03:07+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1106659663","fragment_type":"issue_comment","sequence":1,"text":"@kodol73 : could you share an image of the text you are trying to recognize? I have been trying text recognizer and it works for me.","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-22T16:09:13+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1106665862","fragment_type":"issue_comment","sequence":2,"text":"Here you have some screenshoot of the example app in iOS and it is working.\n\nIMG_0050\n\nIMG_0051","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-22T16:16:48+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109404349","fragment_type":"issue_comment","sequence":3,"text":"i have a same problem, it detect wrong text when run on IOS flutter","author_login":"pdhiepCMCJapan","author_association":"NONE","created_at":"2022-04-26T06:36:33+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109571611","fragment_type":"issue_comment","sequence":4,"text":"It seems that some images of text are recognized correctly, but some other images of text are corrupted\nI just tried with example app, but has the same result\n\nThe result of recognizing below image is corrupted\nPlease check with the below image\n\nIMG_1391","author_login":"kodol73","author_association":"NONE","created_at":"2022-04-26T09:31:46+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1110245737","fragment_type":"issue_comment","sequence":5,"text":"@kodol73 : I tried your image with the example app and so far it does not look corrupted to me. It looks pretty much good to me.\n\nIMG_0052","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-26T21:02:54+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1110380789","fragment_type":"issue_comment","sequence":6,"text":"You tried it on iPhone, right?\nCan you please let me know your phone model and iOS version?","author_login":"kodol73","author_association":"NONE","created_at":"2022-04-27T00:35:59+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1110426518","fragment_type":"issue_comment","sequence":7,"text":"I tried with both an iPhone 11 and iPhone 6S, both with iOS 15 and I am using Xcode 13.3","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-27T01:14:31+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112390024","fragment_type":"issue_comment","sequence":8,"text":"it's weird, I just upgraded iOS to 15.4.1, but the same result\nIt generated corrupted text like the following with the image\n\nT\nT\nooo\n5\n\nJust in case, I test with google_ml_kit 0.8.0 because example app uses google_ml_kit\n\nPlease help me to solve this issue","author_login":"kodol73","author_association":"NONE","created_at":"2022-04-28T16:06:01+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112657862","fragment_type":"issue_comment","sequence":9,"text":"I had this same issue, but resolved it on iOS. \n\nStill testing android but I am passing the File from camera plugin cameraController.takePicture() as the InputImage.fromFile(imageFile) and looking at text it had almost no relevant data, and any data it did have was like:\nA\nooD\nTM\n\nAfter removing the google_ml_kit plugin, and replacing it with only the google_mlkit_text_recognition: ^0.2.0 it works fine. No idea why to be honest, but specifying just text recognition instead of the umbrella plugin resolved. Would like to hear some details on this if there are any.","author_login":"codyfilatov","author_association":"NONE","created_at":"2022-04-28T21:11:13+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112668225","fragment_type":"issue_comment","sequence":10,"text":"Thanks @codyfilatov for the suggestion.\n\nDo you still have issues with Android? both platforms are working okay?\n\n@kodol73 : give it a try","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-28T21:25:17+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112703012","fragment_type":"issue_comment","sequence":11,"text":"Both platforms are working okay now. \nAlthough I did not have this issue with Android to begin with.\n\nThe only issue I am having now on iOS is the orientation of my image when processing, it thinks it is in landscape when it is in portrait, so the bounding boxes are messed up, does not happen on Android. My image does not have any exif orientation data. I would be nice to have if no orientation data exists to predict based on the height/width, looks like it defaults to Landscape if no data exists. But that's another issue I can figure out.\n\nHope OP resolves issue with the dependency change.\nThanks","author_login":"codyfilatov","author_association":"NONE","created_at":"2022-04-28T22:13:45+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112707485","fragment_type":"issue_comment","sequence":12,"text":"@codyfilatov: once you figure the orientation out, share here or create another issue if necessary. I have seen issues with different orientations as well.","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-28T22:20:58+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113194986","fragment_type":"issue_comment","sequence":13,"text":"I just tested the newly released version of google_mlkit_text_recognition, 0.2.0, nothing else changed \nThe issue doesn't appear any more\n\nThanks","author_login":"kodol73","author_association":"NONE","created_at":"2022-04-29T11:27:04+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113200986","fragment_type":"issue_comment","sequence":14,"text":"Sharing here just as a note.\nThe orientation issue was caused by no EXIF orientation data on the image in iOS taken from the camera plugin takePicture function. Since the image file had no EXIF orientation data I assume the text regognizer (and barcode scanner) was returning odd (not incorrect) values. \n\nThe values did not translate as expected as when I set a Container DecorationImage as the same file the image is displayed correctly as taken, but the values were printed mirrored and counter clockwise consistently. \n\nAfter using the image package to set the EXIF orientation data to 1 and rewriting the bytes to a new file, then passing that file to MLkit the boundingBox values were as expected.","author_login":"codyfilatov","author_association":"NONE","created_at":"2022-04-29T11:35:29+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113390253","fragment_type":"issue_comment","sequence":15,"text":"XFile imageCaptureXFile = await this.cameraController!.takePicture();\nFile imageFile = File(imageCaptureXFile.path);\nthis.imageFile = imageFile;\nimg.Image? image = img.decodeImage(await imageFile.readAsBytes());\nif(image == null){\n Util.showToast('Image was not found.');\n this.isConfirming = false;\n this.imageFile = null;\n setState(() {});\n return;\n}\nif(!image.exif.hasOrientation){\n print('Baking orientation into image...');\n image.exif.orientation = 1;\n File orientatedImageFile = File((await getTemporaryDirectory()).path + Uuid().v4() + '.jpg');\n await orientatedImageFile.create();\n await orientatedImageFile.writeAsBytes(img.encodeJpg(image));\n await imageFile.delete();\n imageFile = orientatedImageFile;\n this.imageFile = orientatedImageFile;\n\n image = img.decodeImage(await orientatedImageFile.readAsBytes());\n if(image == null){\n setState(() {});\n return;\n }\n}\n\nThis is what I use for my use case. Keep in mind I only want portrait.\nI use the package:image/image.dart . Ignore the bad code, I'll clean it up later.\n\nTextRecognizer textDetector = TextRecognizer(script: TextRecognitionScript.latin);\nRecognizedText recognisedText = await textDetector.processImage(InputImage.fromFile(imageFile));","author_login":"codyfilatov","author_association":"NONE","created_at":"2022-04-29T14:28:13+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113691037","fragment_type":"issue_comment","sequence":16,"text":"Closing this issue.\n\nFix: google_mlkit_text_recognition instead of `google_ml_kit`.\n\nMore details here: URL \n\nMoving `InputImage` and `InputImageRotation` issues to: URL","author_login":"fbernaly","author_association":"COLLABORATOR","created_at":"2022-04-29T20:19:55+08:00","repo_name":"bharat-biradar/Google-Ml-Kit-plugin","issue_id":1212534085,"issue_number":231,"issue_url":"https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/231","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0050","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"SharePoint Online API: Access denied creating Personal Site when passing Signed In User Bearer Token?","query_context":"#### Category\n- [ ] Question\n- [ ] Typo\n- [x] Bug\n- [ ] Additional article idea\n\n#### Expected or Desired Behavior\n\nThe below HTTP call should create a new personal site for the user\n\nPOST /_vti_bin/client.svc/ProcessQuery HTTP/1.1\nHost: tenant-admin.sharepoint.com\nContent-Type: application/xml\nAuthorization: Bearer \n\n \n \n \n \n \n user@tenant.onmicrosoft.com \n \n \n \n \n \n \n \n \n\n#### Observed Behavior\n\nAbove request results in `200 OK` response but returns the below error, no personal site is created for the user.\n\n[\n {\n \"SchemaVersion\": \"15.0.0.0\",\n \"LibraryVersion\": \"16.0.19318.12002\",\n \"ErrorInfo\": {\n \"ErrorMessage\": \"Access denied. You do not have permission to perform this action or access this resource.\",\n \"ErrorValue\": null,\n \"TraceCorrelationId\": \"7c05089f-70d6-1000-af48-5aaa8564ad67\",\n \"ErrorCode\": -2147024891,\n \"ErrorTypeName\": \"System.UnauthorizedAccessException\"\n },\n \"TraceCorrelationId\": \"7c05089f-70d6-1000-af48-5aaa8564ad67\"\n }\n]\n\n#### Steps to Reproduce\n\n- Create Azure AD application\n- Set the following delegate SharePoint Online API permissions\n - AllSites.FullControl\n - User.ReadWrite.All\n- Grant Admin consent for delegated permissions\n- Generate Bearer Token using OAuth 2.0 Authorization Code Flow\n - Provide Tenant Admin credentials\n- Pass Bearer Token in Authorisation header of request\n\n#### Related Issues\n\n URL \n URL \n URL","known_context_document_ids":["gh_issue_497145561"],"reference_answer":"Unfortunately the SharePoint Online support engineers are not always 100% up to date about the limitations of their own products... :-( In this case the issue lies with the fact that a requested permission through an Azure AD application grant is not being recognized by SharePoint online specifically when it comes to the UPS (User Profile Service Application). With -UseWebLogin we use a different type of authentication (cookiebased/legacy) where as with all the other authentication methods we use the currently by Microsoft promoted way of authentication : Azure AD OAuth. We switched over to Azure AD OAuth as the default as more and more API requests we need to make are located in the Microsoft Graph. And the MS Graph only supports Azure AD OAuth. \n\nIn order for the OAuth authentication flow to work one needs to grant permissions to an Azure AD App registration, either a multi-tenant one alike the PnP Management Shell, or your own registered one. Our tests show that while the correct permissions are in place, SPO is not allowing the user to perform the actions. We brought this up with the product manager in charge of those APIs back then but are still awaiting feedback.","answer_document_id":"gh_comment_861545754","silver_evidence_path":["gh_comment_2721677638","gh_issue_808356405","gh_comment_861545754"],"evidence_issue_ids":[497145561,808356405],"source_repo_name":"SharePoint/sp-dev-docs","source_issue_id":497145561,"source_issue_number":4673,"source_issue_url":"https://github.com/SharePoint/sp-dev-docs/issues/4673","target_repo_name":"pnp/powershell","target_issue_id":808356405,"target_issue_number":277,"target_issue_url":"https://github.com/pnp/powershell/issues/277","reference_anchor_document_id":"gh_comment_2721677638","reference_answer_author":"erwinvanhunen","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1154,"anchor_target_overlap":0.25,"target_answer_overlap":0.1159},"issue_created_at":"2019-09-23T14:48:34+08:00","valid_comment_count":93,"fragments":[{"document_id":"gh_issue_497145561","fragment_type":"issue_description","sequence":0,"text":"SharePoint Online API: Access denied creating Personal Site when passing Signed In User Bearer Token\n#### Category\n- [ ] Question\n- [ ] Typo\n- [x] Bug\n- [ ] Additional article idea\n\n#### Expected or Desired Behavior\n\nThe below HTTP call should create a new personal site for the user\n\nPOST /_vti_bin/client.svc/ProcessQuery HTTP/1.1\nHost: tenant-admin.sharepoint.com\nContent-Type: application/xml\nAuthorization: Bearer \n\n \n \n \n \n \n user@tenant.onmicrosoft.com \n \n \n \n \n \n \n \n \n\n#### Observed Behavior\n\nAbove request results in `200 OK` response but returns the below error, no personal site is created for the user.\n\n[\n {\n \"SchemaVersion\": \"15.0.0.0\",\n \"LibraryVersion\": \"16.0.19318.12002\",\n \"ErrorInfo\": {\n \"ErrorMessage\": \"Access denied. You do not have permission to perform this action or access this resource.\",\n \"ErrorValue\": null,\n \"TraceCorrelationId\": \"7c05089f-70d6-1000-af48-5aaa8564ad67\",\n \"ErrorCode\": -2147024891,\n \"ErrorTypeName\": \"System.UnauthorizedAccessException\"\n },\n \"TraceCorrelationId\": \"7c05089f-70d6-1000-af48-5aaa8564ad67\"\n }\n]\n\n#### Steps to Reproduce\n\n- Create Azure AD application\n- Set the following delegate SharePoint Online API permissions\n - AllSites.FullControl\n - User.ReadWrite.All\n- Grant Admin consent for delegated permissions\n- Generate Bearer Token using OAuth 2.0 Authorization Code Flow\n - Provide Tenant Admin credentials\n- Pass Bearer Token in Authorisation header of request\n\n#### Related Issues\n\n URL \n URL \n URL","author_login":"garrytrinder","author_association":"CONTRIBUTOR","created_at":"2019-09-23T14:48:34+08:00","repo_name":"SharePoint/sp-dev-docs","issue_id":497145561,"issue_number":4673,"issue_url":"https://github.com/SharePoint/sp-dev-docs/issues/4673","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2655989667","fragment_type":"issue_comment","sequence":1,"text":"Any update on this?\nSince ASC will be retired for SharePoint we'll have to use an Entra App Registration.\nBut that still doesn't seem to work...","author_login":"rjansen-rocnova","author_association":"NONE","created_at":"2025-02-13T09:20:41+08:00","repo_name":"SharePoint/sp-dev-docs","issue_id":497145561,"issue_number":4673,"issue_url":"https://github.com/SharePoint/sp-dev-docs/issues/4673","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2721677638","fragment_type":"issue_comment","sequence":2,"text":"Same challenge here, after discovering URL i was hopeful that using CreatePersonalSiteEnqueueBulk together with an entra id app registration and certificate will work, but sadly as of today it does not on our tenant and fails with the following error message:\n\nMicrosoft.SharePoint.Client.ServerUnauthorizedAccessException: 'Attempted to perform an unauthorized operation.'\n\nSince many years we have been using SharePoint app only such as:\n URL \n\nWith the retirement of acs by 02.04.2026 this approach will no longer work, or am i misunderstanding the communication by Microsoft? What is the way forward here for the app only scenario, we really don't want to revert back to service accounts...\n\n@andrewconnell @waldekmastykarz @garrytrinder thanks for your support!","author_login":"TashunkoWitko","author_association":"NONE","created_at":"2025-03-13T15:32:20+08:00","repo_name":"SharePoint/sp-dev-docs","issue_id":497145561,"issue_number":4673,"issue_url":"https://github.com/SharePoint/sp-dev-docs/issues/4673","linked_issue_ids":[808356405],"is_known_query_context":false},{"document_id":"gh_issue_808356405","fragment_type":"issue_description","sequence":0,"text":"[BUG] Set-PnPUserProfileProperty : Access denied. You do not have permission to perform\nPlease see also related discussion Can Get nut can't Set with pnp.powershell\n\n### Expected behavior \nCmdlet `Set-PnPUserProfileProperty` allows to update of user-profile properties\n\n### Actual behavior \nError is raised:\n\n`\nSet-PnPUserProfileProperty : Access denied. You do not have permission to perform this action or access this resource.\nAt line:1 char:1\n+ Set-PnPUserProfileProperty -Account 'test@foobar.com ...\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n + CategoryInfo : WriteError: (:) [Set-PnPUserProfileProperty], ServerUnauthorizedAccessException\n + FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.UserProfiles.SetUserProfileProperty\n\n`\n\n### Steps to reproduce behavior\n1. Connect SharePoint Online\n2. Run following code: `Set-PnPUserProfileProperty -Account 'test@foobar.com' -PropertyName 'WorkPhone' -Value '0123456789'`\n\n### What is the version of the Cmdlet module you are running?\n`Manifest 1.3.0 PnP.PowerShell {Add-PnPAlert, Add-PnPApp, Add-PnPApplicationCustomizer, Add-PnPContentType...}`\n\n### Which operating system/environment are you running PnP PowerShell on?\n- [x] Windows\n- [ ] Linux\n- [ ] MacOS\n- [ ] Azure Cloud Shell\n- [ ] Azure Functions\n- [ ] Other : please specify","author_login":"thuld","author_association":"NONE","created_at":"2021-02-15T09:24:13+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_779174506","fragment_type":"issue_comment","sequence":1,"text":"How did you connect to SPO? i.e. which switch on the \"_Connect-PnPOnline_\"?\n\nI have noticed a similar issue this morning, i.e. \"**Access denied**.\" when using the \"_-UseWebLogin_\" or \"_-Interactive_\" arguments. However, when I connected via \"**-Credentials**\" on the \"_Connect-PnPOnline_\", it worked.\n\nPerhaps the issue is with the Connect-PnPOnline cmdlet.","author_login":"BaronSparky","author_association":"NONE","created_at":"2021-02-15T11:57:46+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_779181202","fragment_type":"issue_comment","sequence":2,"text":"The issue is most likely connected to the registration of the PnP Management Shell application that is in place in your Azure AD. Run `Register-PnPManagementShellApplication` again, it will change the granted permissions: we added the userprofile readwrite right there like 2 weeks ago (it used to be only read access).","author_login":"erwinvanhunen","author_association":"MEMBER","created_at":"2021-02-15T12:09:47+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_779673884","fragment_type":"issue_comment","sequence":3,"text":"I am using the following approach to connect to SharePoint Online:\n\n`\nConnect-PnPOnline -Url ' URL -Interactive\n\n`\n\n@erwinvanhunen We registered the application yesterday and the permissions of this application seems ok:\n\nimage","author_login":"thuld","author_association":"NONE","created_at":"2021-02-16T08:32:07+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_780095568","fragment_type":"issue_comment","sequence":4,"text":"I just tested and indeed it doesn't work with a bearer token (which is what we use by default). It seems that that is (not more?) supported. We'll investigate that. I noticed that if you use -UseWebLogin (which is cookie based auth) it does work.\n\nI'll leave this issue open while we investigate.","author_login":"erwinvanhunen","author_association":"MEMBER","created_at":"2021-02-16T20:23:16+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_810501378","fragment_type":"issue_comment","sequence":5,"text":"My customer needs a fix for this! Here are a couple of possible clues, though I still get the same error behavior discussed in this issue.\n\nAccessing SharePoint using an application context, also known as app-only says \"User Profile CSOM write operations do not work with Azure AD application - read operations work. Both read and write operations work through SharePoint App-Only principal\". Then Granting access using SharePoint App-Only gives instructions for setting that up. I was feeling pretty good when I found this, but then when I tested, still \"Access denied. You do not have permission to perform this action or access this resource. Microsoft.SharePoint.Client.ServerUnauthorizedAccessException, ServerErrorCode : -2147024891, ServerErrorTypeName : System.UnauthorizedAccessException\".\n\n**Another possible clue** is that Granting access using SharePoint App-Only shows **-AppId** and **-AppSecret** parameters for Connect-PnPOnline, but the current version (1.3.0?) doesn't provide those parameters, only -ClientId and -ClientSecret. \n\n_Is there a PnP core version I can test with that provides -AppId and -AppSecret?_","author_login":"Markarend","author_association":"NONE","created_at":"2021-03-30T18:59:22+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_810503241","fragment_type":"issue_comment","sequence":6,"text":"@SebasT87 what version of SharePointPnP are you using as a workaround?","author_login":"Markarend","author_association":"NONE","created_at":"2021-03-30T19:02:12+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_810530821","fragment_type":"issue_comment","sequence":7,"text":"@veronicageek, my apologies for seeming demanding, the exclamation point is a bit overused these days! I absolutely appreciate everyone's supporting each other, and I'll post something if I find an answer. I'm trying some things in this article now: URL","author_login":"Markarend","author_association":"NONE","created_at":"2021-03-30T19:45:37+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_812654321","fragment_type":"issue_comment","sequence":8,"text":"Can anyone share what **Connect-PnPOnline** parameter set and values to use to authenticate from an Azure Function App so the script can _write_ User Profile properties without requiring an interactive login?\n\nI used **Register-PnPManagementShellAccess** successfully and it appears to be configured correctly. But I'm unsure how to tell Connect-PnPOnline to use the **PnP Management Shell** app that it installs, except with -Interactive which only works locally, not from an Azure Function App.\n\nAlso tried these approaches to no avail. All can read SP profile properties but none can write:\nConnect-PnPOnline docs Example 6 (why doesn't this work if the app has SharePoint | User.ReadWrite.All | Application | Read and write user profiles?)\n\nGranting access using SharePoint App-Only (may be deprecated, but moot because it doesn't work though it says it should for this specific scenario)\n\nMany thanks","author_login":"Markarend","author_association":"NONE","created_at":"2021-04-02T18:27:26+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_812676121","fragment_type":"issue_comment","sequence":9,"text":"Finally found a way to authenticate to SharePoint online to _write_ profile properties without an interactive/user logon, that works from Azure function app. Unfortunately it uses ACS which is retired now but _explicitly still supported for SharePoint use_. So it's not my preferred approach, but as it actually works, it's better than all other approaches so far.\n\nThe key is to follow this article Granting access using SharePoint App-Only, but to add the scope /sharepoint/**social**/tenant. Update the Permission Request XML as follows, and it will permit writing user profile properties.\n\n \n \n \n \n\nStill looking for a more \"modern\" approach that's not just supported as a waiver from a retired approach. Many thanks to all!","author_login":"Markarend","author_association":"NONE","created_at":"2021-04-02T19:24:43+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_813848212","fragment_type":"issue_comment","sequence":10,"text":"Hello, Is there an ETA on this Bug when it will be resolved ?","author_login":"patrickTimmerman","author_association":"NONE","created_at":"2021-04-06T06:04:05+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_814107329","fragment_type":"issue_comment","sequence":11,"text":"Like @veronicageek said upthread, all of this work is done by volunteers in their spare time. There usually isn't an ETA and some bugs don't get fixed.","author_login":"ToddKlindt","author_association":"CONTRIBUTOR","created_at":"2021-04-06T13:10:29+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_825656257","fragment_type":"issue_comment","sequence":12,"text":"To give you an update: this is not an issue with PnP PowerShell but has to do with how SharePoint Online handles authorization. We provided Microsoft with this feedback and are waiting for them to reply on it. We have no ETA when that will happen.","author_login":"erwinvanhunen","author_association":"MEMBER","created_at":"2021-04-23T13:24:59+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_848080413","fragment_type":"issue_comment","sequence":13,"text":"I tested it with `-WebLogin` and it indeed worked, thank you for that workaround. My environment is Windows, PnP.PowerShell 1.5.0.","author_login":"mirontoli","author_association":"NONE","created_at":"2021-05-25T17:41:05+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_848999968","fragment_type":"issue_comment","sequence":14,"text":"This thread was closed? The bug is still active. With -interactive or using an Azure AD registered application with full control of sites and read/write of user profiles the error still exists.","author_login":"wimp777","author_association":"NONE","created_at":"2021-05-26T18:02:19+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_849002451","fragment_type":"issue_comment","sequence":15,"text":"Bot closed this issue due to inactivity, have opened it. The best option now would be to contact MS support and explain the case to them.","author_login":"gautamdsheth","author_association":"COLLABORATOR","created_at":"2021-05-26T18:05:05+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_849012966","fragment_type":"issue_comment","sequence":16,"text":"Right. Which they will point back to this thread as its a community driven module and not maintained by Microsoft. I'll probably fall back to the old Sharepoint module and hope PnP gets updated as a work around.","author_login":"wimp777","author_association":"NONE","created_at":"2021-05-26T18:18:58+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_849024228","fragment_type":"issue_comment","sequence":17,"text":"You can do a minimal CSOM code and use the same access token for the support case. The underlying code is all CSOM C#. Unfortunately we have no clue if and when it will be fixed at all. Other cmdlets work perfectly fine with this auth flow but somehow this particular one doesn’t.","author_login":"gautamdsheth","author_association":"COLLABORATOR","created_at":"2021-05-26T18:35:26+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_849064957","fragment_type":"issue_comment","sequence":18,"text":"@wimp777 and as mentioned above the workaround for Azure AD registered application is to use Granting access using SharePoint App-Only, which works if you also add the scope ** URL to those instructions. I know it's not the same as Azure AD registered but it's close and it works.","author_login":"Markarend","author_association":"NONE","created_at":"2021-05-26T19:38:24+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_849536384","fragment_type":"issue_comment","sequence":19,"text":"As @erwinvanhunen mentioned earlier in this thread, this isn't an issue with PowerShell PnP but dependant on MSFT's actions.","author_login":"veronicageek","author_association":"COLLABORATOR","created_at":"2021-05-27T10:55:25+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861545754","fragment_type":"issue_comment","sequence":20,"text":"Unfortunately the SharePoint Online support engineers are not always 100% up to date about the limitations of their own products... :-( In this case the issue lies with the fact that a requested permission through an Azure AD application grant is not being recognized by SharePoint online specifically when it comes to the UPS (User Profile Service Application). With -UseWebLogin we use a different type of authentication (cookiebased/legacy) where as with all the other authentication methods we use the currently by Microsoft promoted way of authentication : Azure AD OAuth. We switched over to Azure AD OAuth as the default as more and more API requests we need to make are located in the Microsoft Graph. And the MS Graph only supports Azure AD OAuth. \n\nIn order for the OAuth authentication flow to work one needs to grant permissions to an Azure AD App registration, either a multi-tenant one alike the PnP Management Shell, or your own registered one. Our tests show that while the correct permissions are in place, SPO is not allowing the user to perform the actions. We brought this up with the product manager in charge of those APIs back then but are still awaiting feedback.","author_login":"erwinvanhunen","author_association":"MEMBER","created_at":"2021-06-15T14:26:06+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861547864","fragment_type":"issue_comment","sequence":21,"text":"Please share your case number so I can look into this. Either here or send it to me privately.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-15T14:28:31+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861552714","fragment_type":"issue_comment","sequence":22,"text":"25392520\n\nAvel Pinales\nSenior Consultant\nP 216.359.7866 | E ***@***.******@***.***>\n\n***@***.***D761D1.DF053AC0] \nSent: Tuesday, June 15, 2021 10:29 AM\nTo: pnp/powershell ***@***.***>\nCc: Pinales, Avel ; Comment ***@***.***>\nSubject: Re: [pnp/powershell] [BUG] Set-PnPUserProfileProperty : Access denied. You do not have permission to perform (#277)\n\n@veronicageek< URL I opened a case with Microsoft and escalated this with their SharePoint Online engineers for this issue. I was told that this is not an issue on their end and that the issue is with the module itself.\n\nPlease share your case number so I can look into this. Either here or send it to me privately.\n\n-\nYou are receiving this because you commented.\nReply to this email directly, view it on GitHub< URL or unsubscribe< URL \n\n________________________________\nImportant Notice: This email message and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the named addressee, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Core BTS. Core BTS specifically disclaims liability for any damage caused by any virus transmitted by this email.","author_login":"apinales","author_association":"NONE","created_at":"2021-06-15T14:34:13+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[808356405],"is_known_query_context":false},{"document_id":"gh_comment_861576549","fragment_type":"issue_comment","sequence":23,"text":"Thanks for sharing @apinales. Looking into it with the support team.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-15T15:03:35+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_862322486","fragment_type":"issue_comment","sequence":24,"text":"@apinales Discussed this with the support team. We would very much like to dive into this issue but since your case has been closed two months ago already we would like to ask you to open a new case and have it reference your old case. If you can share the new case number with me, we'll ensure the correct details will be transferred to the engineer who will handle the case.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-16T12:04:55+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_862371310","fragment_type":"issue_comment","sequence":25,"text":"Thanks for creating the ticket @apinales. I'm already aware of the ticket number, no need to share.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-16T13:16:20+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_866766064","fragment_type":"issue_comment","sequence":26,"text":"I am running into this issue right now. Some updates:\n\n- It was working fine with SharePointPnPPowerShellOnline fine, issue started appearing when we migrated to PnP.PowerShell 1.5.0.\n- Raised a case with Microsoft support and they are looking into it.\n- Got some updates from them to upgrade to 1.6.0 to see if that resolves the issue. However, it does not. Facing same issue with PnP.PowerShell version 1.6.0\n- Tried -UseWebLogin and it does work. -Interactive and -Credentials do not work. However, I can't really use -UseWebLogin since we are running this script from an Azure automation account runbook.\n- Re-ran Register-PnPManagementShellAccess and provided global admin consent again, that didn't change outcome. \n- I don't get \"Access Denied\" error text. For me, the error message is : \"This operation requires you to be managing your own data or have administrator privileges.\" I tried this with SharePoint administrator and even a global administrator role role, however outcome is same.","author_login":"mohandivraniya","author_association":"NONE","created_at":"2021-06-23T11:44:32+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_866768621","fragment_type":"issue_comment","sequence":27,"text":"@mohandivraniya can you share your case number so we can bundle it with the one we already have ongoing at the moment for this?\n\nIn my repro I'm getting the exact same error message as you. What stumbles me here is that you say it works with SharePointPnPPowerShellOnline. What version of it were you using? How did you connect using that?","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-23T11:49:17+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_866772967","fragment_type":"issue_comment","sequence":28,"text":"My case number - 26234370\nI am using SharePointPnPPowerShellOnline version 3.23.2007.0.\nI am connecting using Connect-PnPOnline -Url > -UseWebLogin","author_login":"mohandivraniya","author_association":"NONE","created_at":"2021-06-23T11:56:40+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_866779319","fragment_type":"issue_comment","sequence":29,"text":"@mohandivraniya that explains it then. WebLogin will work as it works through a cookie to authenticate. The issue I believe we are all facing here is that we cannot register an application in AAD, apply the SharePoint Application principal Users.ReadWrite.All and use that to update a user profile. You would either need to assign the same client Id social permissions through AppInv.aspx as well to make it work or alternatively use -UseWebLogin.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-23T12:06:48+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_866839692","fragment_type":"issue_comment","sequence":30,"text":"Here's a non-interactive method for connecting that does work to change user profile properties from a script running in an Azure runbook or function: Example 3 on this page. You must make one change. Follow this article Granting access using SharePoint App-Only, but add the scope /sharepoint/**social**/tenant. Update the Permission Request XML as follows, and it will permit writing user profile properties.\n\n \n \n \n \n\nThis ACS method is retired now but _explicitly still supported for SharePoint use_","author_login":"Markarend","author_association":"NONE","created_at":"2021-06-23T13:32:41+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_866844848","fragment_type":"issue_comment","sequence":31,"text":"Thanks @Markarend for taking the time to detail out what I mentioned above to help others better understand the workaround. Still I believe that should be seen as a workaround. We're currently trying to see if filing a hotfix request for this has any chance of succeeding.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-06-23T13:39:20+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_869933559","fragment_type":"issue_comment","sequence":32,"text":"It would be awesome if Microsoft could fix this for Azure AD app-only contexts. This has been an issue for a while, and you lose a bit of transparency for your app registrations when you are building AD Apps, and subsequently have to register some permissions though appinv.aspx","author_login":"bcameron1231","author_association":"NONE","created_at":"2021-06-28T18:50:28+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_871986234","fragment_type":"issue_comment","sequence":33,"text":"We are tripping over this as well. Found this thread and it's awesome that there are workarounds and - more important - this is being worked on. 👍\n\nStanding in line and waiting for the engineers to click \"ship it\" ;)","author_login":"heinrich-ulbricht","author_association":"NONE","created_at":"2021-07-01T07:10:29+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_876750837","fragment_type":"issue_comment","sequence":34,"text":"Turns out engineering already had a backlog item open to implement those permissions. The need to have this implemented is raised to engineering through a Critical Design Change Request (CDCR) now based on the discussion here with the aim of prioritizing the backlog item on upcoming sprints. They're currently looking into the efforts it would take to implement this.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-07-08T21:15:54+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_883807689","fragment_type":"issue_comment","sequence":35,"text":"Just as an update, the topic is still on the table and has not been forgotten. No decision has been made yet if this functionality will be adjusted or not unfortunately.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-07-21T01:07:14+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_900699260","fragment_type":"issue_comment","sequence":36,"text":"Any update from Microsoft SharePoint Online on this issue?????","author_login":"asfd79","author_association":"NONE","created_at":"2021-08-17T23:33:06+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_901669111","fragment_type":"issue_comment","sequence":37,"text":"Its still under discussion. Vacation period makes things progress slow unfortunately. Also because there is an easy workaround available, it takes more effort to raise the priority on this.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-08-19T07:14:13+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_901689290","fragment_type":"issue_comment","sequence":38,"text":"@KoenZomers Thanks for updating me. The easy workaround you are talking about is app-only credential?","author_login":"asfd79","author_association":"NONE","created_at":"2021-08-19T07:48:53+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_901696753","fragment_type":"issue_comment","sequence":39,"text":"The easy workaround is to apply what is written here:\n URL \n\nSo you can combine your AAD App Registration with ACS permissions to make this work. You would just need to get another token from ACS to handle the user profile stuff, if you directly communicate with the SharePoint/Graph APIs. If you use PnP PowerShell, this will be done automatically for you and you just need to set the permissions as mentioned in the referenced post.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-08-19T08:00:32+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[808356405],"is_known_query_context":false},{"document_id":"gh_comment_902376819","fragment_type":"issue_comment","sequence":40,"text":"@KoenZomers Thanks, mate. I give it a go. Really really hope Microsoft fix it properly so.","author_login":"asfd79","author_association":"NONE","created_at":"2021-08-20T02:10:59+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_908680214","fragment_type":"issue_comment","sequence":41,"text":"I'd like to add that this is something I'd like to see resolved for a current client. While I can (barely) keep up with the subtle nuance and intricacies of things like this, clients/customers often times aren't paying as close attention. As a result those that have to build/deliver/transition solutions that require both Azure App Registration and the legacy ACS permissions have a hard time explaining this to customer teams. It also requires delivery of code that will be known to have a limited life span in that ACS will only likely be supported for some (unknown) period of time. I'd like to vote this up in priority / escalation such that administrators can have custom SPO user profile sync jobs that don't require ACS any longer.","author_login":"brianpmccullough","author_association":"NONE","created_at":"2021-08-30T20:43:07+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912561019","fragment_type":"issue_comment","sequence":42,"text":"Hi,\nI tried the workaround method suggested using SharePoint-App Online registration, and using this function of pnp powershell code : Set-PnPUserProfileProperty\nI am now getting error 401, did i miss something ?","author_login":"jeffangama","author_association":"NONE","created_at":"2021-09-03T13:58:54+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912648223","fragment_type":"issue_comment","sequence":43,"text":"@jeffangama did you add an AppPermissionsRequest as described here\n\nWhen using SharePoint App-Only, must add the scope /sharepoint/social/tenant. Update the Permission Request XML as follows, and it will permit writing user profile properties.","author_login":"Markarend","author_association":"NONE","created_at":"2021-09-03T16:03:35+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_919780362","fragment_type":"issue_comment","sequence":44,"text":"@Markarend thx for you contribution to this topic. Very helpfull ! I was using the SharePoint App-Only method already. It works at our test tenant, but at the customer it gives an error.\n\nI used exactly the same XML as you do at /_layouts/15/appinv.aspx\n\n \n \n \n \n\nI used this code:\n\n$GLOBAL:spAppOnlyClientId = \"XXXX\"\n$GLOBAL:spAppOnlyClientSecret = \"XXXX\"\n$GLOBAL:connection = Connect-PnPOnline -url \" URL -clientId $GLOBAL:spAppOnlyClientId -clientSecret $GLOBAL:spAppOnlyClientSecret\n(Get-PnPUserProfileProperty -Account \" \" -Connection $GLOBAL:connection).UserProfileProperties\n\nThe error I receive is:\n`The remote server returned an error: (401) Unauthorized.`\n\nDo you have any clue why this isn't working?\n\nAs an alternative I tried the -UseWebLogin method, which works. But it should run in a Azure runbook, so this method is of no use to us.","author_login":"MartijnMolegraaf","author_association":"NONE","created_at":"2021-09-15T07:44:52+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_920349326","fragment_type":"issue_comment","sequence":45,"text":"@MartijnMolegraaf Check if ACS auth is disabled on the tenant where it gives you the unauthorized.\n\npowershell\nConnect-SPOService -Url URL \nGet-SPOTenant | select DisableCustomAppAuthentication\n\nEnsure it reports back False. If not, you need to set it to false using:\n\npowershell\nSet-SPOTenant -DisableCustomAppAuthentication $false","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-09-15T20:22:15+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_920352062","fragment_type":"issue_comment","sequence":46,"text":"As an update to this item. We have discussed the situation with engineering. They are aware of this situation and this GitHub thread and are evaluating their options.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-09-15T20:26:35+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_920566968","fragment_type":"issue_comment","sequence":47,"text":"Morning @KoenZomers . You made my day, that was indeed the cause and solution. Thank you !\n\nIn addition, it is appreciated that you have discussed this case and looked at possible options.","author_login":"MartijnMolegraaf","author_association":"NONE","created_at":"2021-09-16T04:31:21+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_975690726","fragment_type":"issue_comment","sequence":48,"text":"Not yet unfortunately. Its not getting priority yet to be looked at. We'll keep pushing.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-11-22T16:19:50+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_975698978","fragment_type":"issue_comment","sequence":49,"text":"@KoenZomers - When the problem is fixed from MSFT side, will it be automatically updated in the PnP module or will we have to also fix our code?","author_login":"veronicageek","author_association":"COLLABORATOR","created_at":"2021-11-22T16:28:56+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_976227402","fragment_type":"issue_comment","sequence":50,"text":"@veronicageek depends a bit on how they decide to fix it. Most probably it will not need code changes from our end.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-11-23T07:40:54+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_979273557","fragment_type":"issue_comment","sequence":51,"text":"What would currently be the best way to update SharePoint profile photos despite of this bug?","author_login":"maartendamen","author_association":"NONE","created_at":"2021-11-25T14:46:58+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_979588801","fragment_type":"issue_comment","sequence":52,"text":"Utilising New-PnPUPABulkImportJob achieves the same result in a roundabout way","author_login":"warwickofthegh","author_association":"NONE","created_at":"2021-11-26T01:41:19+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_982665578","fragment_type":"issue_comment","sequence":53,"text":"@maartendamen have a look at the documentation: URL . The idea is that you write the updates you want to do in a JSON file, upload it somewhere to SharePoint Online and then call this cmdlet to ask to process it for you. Alternatively you can also directly connect Azure Active Directory with the SharePoint Online User Profile store using URL \n\nPermissions wise you will not solve anything with this by the way.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2021-11-30T14:03:31+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014319726","fragment_type":"issue_comment","sequence":54,"text":"Is there any way to upvote this issue at Microsoft? Because the old module SharePointPnPPowerShellOnline still works for me. But it seems that it will be retired. And the new method doesn't work. That doesn't feel right for a production environment.","author_login":"JohnKoornneef","author_association":"NONE","created_at":"2022-01-17T09:36:25+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015369832","fragment_type":"issue_comment","sequence":55,"text":"I know this one has been open for quite some time already and that there are a lot of organizations that are hitting this issue. I can say that we're closer than ever on getting this addressed. I'm not at liberty to give any timelines on it, but know that we are still actively working on it internally to get it resolved. Thank you for your patience everyone.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2022-01-18T12:36:25+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015371166","fragment_type":"issue_comment","sequence":56,"text":"No need to. It has priority already.\n\nYou're okay with using the SharePointPnPPowerShellOnline library for now. If it works, it works. It will likely also still work for you with PnP.PowerShell as long as you use the same login method, i.e. -UseWeblogin. Nothing has changed with regards to that.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2022-01-18T12:38:17+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019962817","fragment_type":"issue_comment","sequence":57,"text":"Everyone - I'm working at Microsoft Support, and with @KoenZomers and Engineering on this issue.\nMicrosoft Engineering has analyzed this issue and is currently working on a fix. It requires collaboration between multiple teams and there is no ETA for the moment. I will update this thread as updates occur","author_login":"Yvand","author_association":"NONE","created_at":"2022-01-24T10:48:00+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1023147558","fragment_type":"issue_comment","sequence":58,"text":"I tested using SharePointPnPPowerShellOnline legacy module and it works at my end, although it is older module than PnP.PowerShell.","author_login":"vvdadhe","author_association":"NONE","created_at":"2022-01-27T12:17:12+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026333714","fragment_type":"issue_comment","sequence":59,"text":"Still patiently waiting on Microsoft to fix this (not the community).","author_login":"brianpmccullough","author_association":"NONE","created_at":"2022-02-01T00:03:25+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124016397","fragment_type":"issue_comment","sequence":60,"text":"Still not working with\nConnectPnPOnline -Url \"myco-admin.sharepoint.com\" -ClientId \"ZZZZZZ\" -Tenant \"myco.onmicrosoft.com\" -Thumbprint \"XXXXXXX\"\n\nWhen will MSFT fix this ?\n\nSet-PnPUserProfileProperty : This operation requires you to be managing your own data or have administrator privileges.\nAt line:12 char:5\n+ Set-PnPUserProfileProperty -Account xxxxxx -Prope ...\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n + CategoryInfo : WriteError: (:) [Set-PnPUserProfileProperty], ServerException\n + FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.UserProfiles.SetUserProfileProperty","author_login":"parlevjo2","author_association":"NONE","created_at":"2022-05-11T16:54:48+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153574996","fragment_type":"issue_comment","sequence":61,"text":"Everyone - I checked with Engineering a few day ago, which confirmed they are currently working on a hotfix for this issue.\nThe plan is to release it this calendar year, I don't have a more specific date.","author_login":"Yvand","author_association":"NONE","created_at":"2022-06-13T07:32:46+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1197358829","fragment_type":"issue_comment","sequence":62,"text":"I had success using this command \"Connect-PnPOnline -s -url $Url -Credentials $Creds\"","author_login":"felipe-developer","author_association":"NONE","created_at":"2022-07-27T20:56:38+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207065019","fragment_type":"issue_comment","sequence":63,"text":"We had the same. We call it a work around, becasue we want to quit using a credential. Our line is.\nConnect-PnPOnline -Url $AdminSiteURL -Credentials $credential -SPOManagementShell","author_login":"parlevjo2","author_association":"NONE","created_at":"2022-08-05T22:30:28+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1300882354","fragment_type":"issue_comment","sequence":64,"text":"@WiljanD I got no update since my last message but I just asked for one, I'll post back here if/when I get an answer","author_login":"Yvand","author_association":"NONE","created_at":"2022-11-02T16:47:19+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1314694030","fragment_type":"issue_comment","sequence":65,"text":"Time is just about up on this. Can we expect this to be fixed anytime soon? I have been patiently waiting for almost 2 years.","author_login":"brianpmccullough","author_association":"NONE","created_at":"2022-11-15T03:00:58+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1350886815","fragment_type":"issue_comment","sequence":66,"text":"@Yvand Hello, have you got any news/ETA ?\nFor anyone having issue with non interactive login please refer to @Markarend comments which have a workaround while waiting for the Microsoft fix, especially this one URL","author_login":"kodsu","author_association":"NONE","created_at":"2022-12-14T10:45:45+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[808356405],"is_known_query_context":false},{"document_id":"gh_comment_1352712102","fragment_type":"issue_comment","sequence":67,"text":"@kodsu yes, I got confirmation from Engineering that they are actively working on this and they already completed a good part of the work, although it is not finished yet.\nThey did not communicate a timeline when it will ship in production, but it will not be before CY 2023.","author_login":"Yvand","author_association":"NONE","created_at":"2022-12-15T08:25:47+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1369022340","fragment_type":"issue_comment","sequence":68,"text":"2023 is here. hope the teams working on this will get us a solution soon.","author_login":"rimayug","author_association":"NONE","created_at":"2023-01-02T15:09:50+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1411857741","fragment_type":"issue_comment","sequence":69,"text":"Today I got an update from Engineering: They continued the work and made progress since my last message, but they still don't have a more precise timeline to communicate, very unfortunately","author_login":"Yvand","author_association":"NONE","created_at":"2023-02-01T10:51:55+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1412006246","fragment_type":"issue_comment","sequence":70,"text":"Imagine being a PM and getting this response from engineering ⛈️😉","author_login":"heinrich-ulbricht","author_association":"NONE","created_at":"2023-02-01T12:50:57+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1415518980","fragment_type":"issue_comment","sequence":71,"text":"@heinrich-ulbricht I'm just the messenger who understands the frustration of people in this thread who are waiting for this fix for so long.\nI take the time to chase Engineering and provide whatever update I have, even if it is a poor one.\nI could have chosen to just remain silent","author_login":"Yvand","author_association":"NONE","created_at":"2023-02-03T09:51:33+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1432973155","fragment_type":"issue_comment","sequence":72,"text":"Is the current work-around still working?\n\nI created a new Azure AD App + secret.\nNext on the tenant-admin.sharepoint.com/_layouts/15/appinv.aspx added the FullControl rights to both the content and social scope.\nUsing Connect-PnPOnline with ClientId and ClientSecret, the Get-PnPUserProfileProperty command is working fine.\nBut Set-PnPUserProfileProperty returns the following error:\n\nSet-PnPUserProfileProperty : De huidige gebruiker is niet gemachtigd om deze bewerking uit te voeren.\nAt line:1 char:1\n+ Set-PnPUserProfileProperty -Account $acc.AccountName -PropertyName 'S ...\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n + CategoryInfo : InvalidOperation: (:) [Set-PnPUserProfileProperty], PSInvalidOperationException\n + FullyQualifiedErrorId : InvalidOperation,PnP.PowerShell.Commands.UserProfiles.SetUserProfileProperty\n\nThe error text in this Dutch tenant translates the same but the CategoryInfo differs from the topic start.","author_login":"Mntz","author_association":"NONE","created_at":"2023-02-16T11:55:19+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433018992","fragment_type":"issue_comment","sequence":73,"text":"Did you run the following on each Geo where you need to perform the Get/Set? Also, if multi-geo, you will need to so the ACS registration (AppInv.aspx) on each central admin site.\n\nset-spotenant -DisableCustomAppAuthentication $false\n\n URL","author_login":"brianpmccullough","author_association":"NONE","created_at":"2023-02-16T12:33:10+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433082466","fragment_type":"issue_comment","sequence":74,"text":"Found the issue... the error was kind of misleading:\nI tried to set SPS-Location but the location value was not yet available in the term store.\nSince I first tried Set-PnPUserProfileProperty using certificate authentication instead of using secrets I figured it was still the same issue, but no.","author_login":"Mntz","author_association":"NONE","created_at":"2023-02-16T13:23:01+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433089536","fragment_type":"issue_comment","sequence":75,"text":"Yes, for sync scenarios, I usually let those termsets remain open - following the model that OOB SharePoint uses for fields like Job Title, etc.","author_login":"brianpmccullough","author_association":"NONE","created_at":"2023-02-16T13:28:32+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1478829190","fragment_type":"issue_comment","sequence":76,"text":"ERROR: This operation requires you to be managing your own data or have administrator privileges.\n\nGetting the same error here when using Azure Function and App Registration.\n\nIs there a fix?","author_login":"sli701","author_association":"NONE","created_at":"2023-03-22T02:16:07+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1521915599","fragment_type":"issue_comment","sequence":77,"text":"Connect-PnPOnline -Url $URL -UseWebLogin. This is not ideal nor what we want for automation purposes, but it will work. When working on multiple users, I add it to the Begin block and do the work in the Process block of the script in order to pipe information to the script. Hope that helps.","author_login":"RichWorld-Tech","author_association":"NONE","created_at":"2023-04-25T14:44:08+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655282432","fragment_type":"issue_comment","sequence":78,"text":"Just wanted to mention that New-PnPUPABulkImportJob works fine with an app registration with Certificate and permissions assigned only in AAD with SharePoint \"Sites.FullControl.All\" and \"User.ReadWrite.All\" and no permissions assigned in SPO at /_layouts/15/appinv.aspx , tested it this week in 2 different tenants.","author_login":"jackpoz","author_association":"CONTRIBUTOR","created_at":"2023-07-28T08:38:39+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655294132","fragment_type":"issue_comment","sequence":79,"text":"Thanks a lot @jackpoz, will definitely try this out. Glad to get rid of this ACS dependance.","author_login":"testad","author_association":"NONE","created_at":"2023-07-28T08:45:09+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771378925","fragment_type":"issue_comment","sequence":80,"text":"This seems to be working for me. I just fixed an automation I had working.","author_login":"rayghost503","author_association":"NONE","created_at":"2023-10-19T16:57:09+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771470823","fragment_type":"issue_comment","sequence":81,"text":"I was able to test New-PnPUPABulkImportJob with Managed Identity in Automation Account in Azure and it works fine that way too","author_login":"jackpoz","author_association":"CONTRIBUTOR","created_at":"2023-10-19T18:02:54+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1790506296","fragment_type":"issue_comment","sequence":82,"text":"Good to hear the feedback here that it has started to work for some of you. Just for awareness, the PG is still actively working on completing implementing this scenario. This means for now that it might already work for you, but specific scenarios, such as when you're using taxonomy driven user profile fields, might not work yet. Keep this in mind when switching to the Azure AD / Entra ID option. Test everything thoroughly. If it works for your use case, you're good to go, if it doesn't yet, bear a little longer with us, it's still work in progress.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2023-11-02T10:56:52+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791730867","fragment_type":"issue_comment","sequence":83,"text":"I got the error: the current user has insufficient permissions to perform this operation for:\nSetMultiValuedProfileProperty \nSetSingleValueProfileProperty for property: SPS-Location\n\n However, SetSingleValueProfileProperty does work for other custom properties \n\nI use PNP.framework, set ClientContext using new AuthenticationManager().GetACSAppOnlyContext(siteurl, clientid, secret) \n\n Thanks","author_login":"bpw320","author_association":"NONE","created_at":"2023-11-03T00:15:40+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928467187","fragment_type":"issue_comment","sequence":84,"text":"Get-PnPUserProfileProperty works with -ClientSecret but not working with -Thumbprint. Getting Access Denied.","author_login":"sidndis27","author_association":"NONE","created_at":"2024-02-05T23:07:14+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928958442","fragment_type":"issue_comment","sequence":85,"text":"I fixed the issue with the latest PowerShell module on Powershell 7.2 with the command \"Sync-PnPSharePointUserProfilesFromAzureActiveDirectory\" all information is well documented: URL \n\nThe service principal needs to have the following rights:\nGraph API:\n[User.Read.All]\n\nSharepoint API\n[User.Read.All]\n[Sites.FullControl.All]\n\nWhich will look like:\n \" -AppRole \"User.Read.All\" -BuiltInType MicrosoftGraph`\n`Add-PnPAzureADServicePrincipalAppRole -Principal \" \" -AppRole \"Sites.FullControl.All\" -BuiltInType SharePointOnline`\n`Add-PnPAzureADServicePrincipalAppRole -Principal \" \" -AppRole \"User.Read.All\" -BuiltInType SharePointOnline`\n\nThen also grant the permissions in Sharepoint:\nApp permission:\n` \n`\nI suspect that this rights package will help in granting rights also for Set-PnPUserProfileProperty, but I started using the latest module because it adds support for using System managed identities and User Managed Identities which I'm using in combination with a automation account to sync the attributes from Azure AD to SharePoint.\n\nThe script looks like this:\n\nConnect-PnPOnline tentantname-admin.sharepoint.com -ManagedIdentity -UserAssignedManagedIdentityClientId \"Service principal ObjectID\"\n\n$users = Get-PnPAzureADUser -select \"OnPremisesSamAccountName\"\n\nSync-PnPSharePointUserProfilesFromAzureActiveDirectory -UserProfilePropertyMapping @{\"UserName\"=\"OnPremisesSamAccountName\";\"CellPhone\"=\"MobilePhone\"} -Users $users -Folder \"Documents\"\n\nDisconnect-PnPOnline","author_login":"WiljanD","author_association":"NONE","created_at":"2024-02-06T07:54:47+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2161934182","fragment_type":"issue_comment","sequence":86,"text":"Is there a way to assign these permissions using the PnP commandlets? Or some non SharePoint registration?","author_login":"ttd-kevinclement","author_association":"NONE","created_at":"2024-06-12T01:50:46+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2162721930","fragment_type":"issue_comment","sequence":87,"text":"In my testing the issue with ACL is now solved, and so legacy auth using appreg.aspx is no longer needed.\nI have tested using both system managed identity and app reg with cert. Both works fine updating user profile properties including term set fields with only API permissions\n\n`Set-PnPUserProfileProperty -Account adelev@contoso.onmicrosoft.com -PropertyName \"SPS-Location\" -Value \"Stockholm\"`\n\nYou can ignore the exchange perm as it was only used for testing\nimage","author_login":"AndersRask","author_association":"NONE","created_at":"2024-06-12T11:01:42+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2163590118","fragment_type":"issue_comment","sequence":88,"text":"Looks like TermStore permission is all that was missing. Rest of the commands seem to work now.","author_login":"ttd-kevinclement","author_association":"NONE","created_at":"2024-06-12T17:43:54+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2163703872","fragment_type":"issue_comment","sequence":89,"text":"Thanks @AndersRask for sharing and @ttd-kevinclement for confirming. I will update our documentation with this great info.\n\nI guess with that, we can also finally close this long running open issue. Thanks for providing all the feedback and thoughts here everyone.","author_login":"KoenZomers","author_association":"COLLABORATOR","created_at":"2024-06-12T18:55:14+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2862743589","fragment_type":"issue_comment","sequence":90,"text":"Hi,\n\nIf I'm not mistaken the original issue is still not fixed?\n\nI see something was solved concerning ACL, but the original issue was **without using ACL** and since it is going away I'm not going to use it.\n\nSo I'm now in the same situation as the OP.\n\nTrying to read certain extension attributes from EntraID profiles and write the values into SharePoint User Profile custom properties. \n\nHere's what I have tried:\n\n# Connect to Microsoft Graph API\nConnect-MgGraph -Scopes \"User.Read\"\n\n# Fetch users where Company Name is \"CompanyXYZ\"\n$users = Get-MgUser -Filter \"companyName eq 'CompanyXYZ'\"\n\n# Connect to SharePoint Online\nConnect-PnPOnline -Url \" URL -ClientId \n\n# Update SharePoint user profiles\nforeach ($user in $users) {\n    $customAttribute = $user.companyName\n    Set-PnPUserProfileProperty -Account $user.UserPrincipalName -PropertyName \"CompanyName\" -Value $customAttribute\n}\n\nSet-PnPUserProfileProperty gives error: \"This operation requires you to be managing your own data or have administrator privileges.\"\n\nI have set these (Delegated) API permissions to PnP Powershell and I'm a Global Admin:\n\nMicrosoft Graph: User.Read.All\nSharePoint: AllSites.FullControl, TermStore.ReadWrite.All, User.ReadWrite.All","author_login":"DavorSukeri","author_association":"NONE","created_at":"2025-05-08T11:41:09+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2865468021","fragment_type":"issue_comment","sequence":91,"text":"Thanks for you suggestion, but I don't think that would help me since eventually I would run this with Managed Identity from Azure Runbook. :(","author_login":"DavorSukeri","author_association":"NONE","created_at":"2025-05-09T07:33:10+08:00","repo_name":"pnp/powershell","issue_id":808356405,"issue_number":277,"issue_url":"https://github.com/pnp/powershell/issues/277","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0051","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Issues when running on fly genome?","query_context":"Hello Andrey:\nI have worked with isoquant output on mouse genome and find it super cool. So now I tried to run isoquant on long read seq from a fly RNA seq data, with the attempt to get de novo transcripts in specific knockout model. But it seems to be not working.\nMy line was: \nisoquant.py \\\n--reference/homes/01/dmmccormick/oliviaao/Genome_assembly_Release_6_plus_ISO1_MT/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.fna \\\n--bam METTL3_KO_LacZ_RNAi.bc_3_sorted.bam \\\n--data_type nanopore \\\n-o METTL3_KO_LacZ \\\n\nBelow is the error I encountered:\n2025-06-11 14:32:32,590 - CRITICAL - IsoQuant failed with the following error, please, submit this issue to URL (most recent call last):\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/bin/isoquant.py\", line 870, in \n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/bin/isoquant.py\", line 864, in main\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/bin/isoquant.py\", line 814, in run_pipeline\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 432, in process_all_samples\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 456, in process_sample\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 547, in collect_reads\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 595, in resolve_multimappers\nOSError: [Errno 24] Too many open files: 'METTL3_KO_LacZ/OUT/aux/OUT.save_multimappers_NW_001846120.1'\n\nOn the other hand, I also tried running isoquant with all the parameters by\n--reference /homes/01/dmmccormick/oliviaao/Genome_assembly_Release_6_plus_ISO1_MT/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.fna \\\n--genedb /homes/01/dmmccormick/oliviaao/Genome_assembly_Release_6_plus_ISO1_MT/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.gtf \\\n--bam METTL3_KO_LacZ_RNAi.bc_3_sorted.bam \\\n--data_type nanopore \\\n-o METTL3_KO_LacZ \\\nThis line of code gives me a different error by telling me the GTF file is corrupted. But this GTF file is directly downloaded from NCBI without no modification to anything...?\n\nPlease let me know if you could help with these errors, and what I could do to help in this process.\nThank you\n\nOlivia","known_context_document_ids":["gh_issue_3137931074"],"reference_answer":"Dear @biochristmas \n\nThe correct command is `ulimit -n`, while you mentioned you used `ulimit -c`. Could you try -n option and see if it helps?\n\nBest\nAndrey","answer_document_id":"gh_comment_1908560795","silver_evidence_path":["gh_comment_2976657420","gh_issue_2054749079","gh_comment_1908560795"],"evidence_issue_ids":[3137931074,2054749079],"source_repo_name":"ablab/IsoQuant","source_issue_id":3137931074,"source_issue_number":316,"source_issue_url":"https://github.com/ablab/IsoQuant/issues/316","target_repo_name":"ablab/IsoQuant","target_issue_id":2054749079,"target_issue_number":133,"target_issue_url":"https://github.com/ablab/IsoQuant/issues/133","reference_anchor_document_id":"gh_comment_2976657420","reference_answer_author":"andrewprzh","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2632,"anchor_target_overlap":0.2051,"target_answer_overlap":0.0},"issue_created_at":"2025-06-11T19:46:53+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_3137931074","fragment_type":"issue_description","sequence":0,"text":"Issues when running on fly genome\nHello Andrey:\nI have worked with isoquant output on mouse genome and find it super cool. So now I tried to run isoquant on long read seq from a fly RNA seq data, with the attempt to get de novo transcripts in specific knockout model. But it seems to be not working.\nMy line was: \nisoquant.py \\\n--reference/homes/01/dmmccormick/oliviaao/Genome_assembly_Release_6_plus_ISO1_MT/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.fna \\\n--bam METTL3_KO_LacZ_RNAi.bc_3_sorted.bam \\\n--data_type nanopore \\\n-o METTL3_KO_LacZ \\\n\nBelow is the error I encountered:\n2025-06-11 14:32:32,590 - CRITICAL - IsoQuant failed with the following error, please, submit this issue to URL (most recent call last):\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/bin/isoquant.py\", line 870, in \n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/bin/isoquant.py\", line 864, in main\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/bin/isoquant.py\", line 814, in run_pipeline\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 432, in process_all_samples\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 456, in process_sample\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 547, in collect_reads\n File \"/homes/01/dmmccormick/miniconda3/envs/isoquant/share/isoquant-3.7.0-0/src/dataset_processor.py\", line 595, in resolve_multimappers\nOSError: [Errno 24] Too many open files: 'METTL3_KO_LacZ/OUT/aux/OUT.save_multimappers_NW_001846120.1'\n\nOn the other hand, I also tried running isoquant with all the parameters by\n--reference /homes/01/dmmccormick/oliviaao/Genome_assembly_Release_6_plus_ISO1_MT/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.fna \\\n--genedb /homes/01/dmmccormick/oliviaao/Genome_assembly_Release_6_plus_ISO1_MT/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.gtf \\\n--bam METTL3_KO_LacZ_RNAi.bc_3_sorted.bam \\\n--data_type nanopore \\\n-o METTL3_KO_LacZ \\\nThis line of code gives me a different error by telling me the GTF file is corrupted. But this GTF file is directly downloaded from NCBI without no modification to anything...?\n\nPlease let me know if you could help with these errors, and what I could do to help in this process.\nThank you\n\nOlivia","author_login":"AoJR","author_association":"NONE","created_at":"2025-06-11T19:46:53+08:00","repo_name":"ablab/IsoQuant","issue_id":3137931074,"issue_number":316,"issue_url":"https://github.com/ablab/IsoQuant/issues/316","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2976657420","fragment_type":"issue_comment","sequence":1,"text":"Dear Olivia\n\nThank you for the kind feedback!\n\nRegarding the first question - IsoQuant creates a few files for each chromosome in the reference genome. However, every file system has a limit on the number of simultaneously open files. \nSo I suggest either of two:\n- set `ulimit -n `, i.e. `ulimit -n 100000` as discussed here URL \n- keep only reference chromosomes in the reference genome (e.g. remove all contigs and patches, or download main assembly file).\n\nCould you give me an error from the second run? It's always possible to set `--no_gtf_check` to skip GTF checking.\n\nBest\nAndrey","author_login":"andrewprzh","author_association":"COLLABORATOR","created_at":"2025-06-16T13:26:23+08:00","repo_name":"ablab/IsoQuant","issue_id":3137931074,"issue_number":316,"issue_url":"https://github.com/ablab/IsoQuant/issues/316","linked_issue_ids":[2054749079],"is_known_query_context":false},{"document_id":"gh_comment_3001091441","fragment_type":"issue_comment","sequence":2,"text":"@AoJR \n\nAs the log suggests, tt seems like you annotation has duplicated genes:\n` Duplicated gene id Dmel_CG32491 on line 418825`\n\nIsoQuant tried to correct your annotation, but it explicitly wants you to know there is problem. You can try using corrected annotation suggested by IsoQuant:\n`An attempt to correct this GTF was made, the result is written to /homes/01/dmmccormick/oliviaao/2025_drs_longreads/2025_0515_All_context_model_Bam_file/S2_LacZ_gtf/GCF_000001215.4_Release_6_plus_ISO1_MT_genomic.corrected.gtf`\n\nBest\nAndrey","author_login":"andrewprzh","author_association":"COLLABORATOR","created_at":"2025-06-24T16:09:24+08:00","repo_name":"ablab/IsoQuant","issue_id":3137931074,"issue_number":316,"issue_url":"https://github.com/ablab/IsoQuant/issues/316","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3025652144","fragment_type":"issue_comment","sequence":3,"text":"Thank you Andrey. I run with the corrected gtf genenrated from isoquant and it runs smoothly.","author_login":"AoJR","author_association":"NONE","created_at":"2025-07-01T21:57:48+08:00","repo_name":"ablab/IsoQuant","issue_id":3137931074,"issue_number":316,"issue_url":"https://github.com/ablab/IsoQuant/issues/316","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2054749079","fragment_type":"issue_description","sequence":0,"text":"OSError: [Errno 24] Too many open files\nHi,\nI've been running isoquant-3.3.1-0 recently and encountered an \"OSError: [Errno 24] Too many open files\" error when processing the chromosome NW_019678884.1. I've attempted to rerun it three times using the \"--resume\" parameter, but the same error persists. Is there any way to resolve this issue?\n微信图片_20231223183858","author_login":"shizhuoxing","author_association":"NONE","created_at":"2023-12-23T10:42:22+08:00","repo_name":"ablab/IsoQuant","issue_id":2054749079,"issue_number":133,"issue_url":"https://github.com/ablab/IsoQuant/issues/133","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868574134","fragment_type":"issue_comment","sequence":1,"text":"Dear @shizhuoxing \n\nI think it's an operating system limit, which can be changed using\n\nulimit -n \n\nI presume setting something like 10000 should be enough.\n\nBest\nAndrey","author_login":"andrewprzh","author_association":"COLLABORATOR","created_at":"2023-12-24T18:38:36+08:00","repo_name":"ablab/IsoQuant","issue_id":2054749079,"issue_number":133,"issue_url":"https://github.com/ablab/IsoQuant/issues/133","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1905518905","fragment_type":"issue_comment","sequence":2,"text":"Hi,\nI have recently encountered this problem as well. I set it to have no size limit using ‘ulimit -c unlimited,’ but I still receive errors.\nerro","author_login":"biochristmas","author_association":"NONE","created_at":"2024-01-23T08:19:01+08:00","repo_name":"ablab/IsoQuant","issue_id":2054749079,"issue_number":133,"issue_url":"https://github.com/ablab/IsoQuant/issues/133","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1908560795","fragment_type":"issue_comment","sequence":3,"text":"Dear @biochristmas \n\nThe correct command is `ulimit -n`, while you mentioned you used `ulimit -c`. Could you try -n option and see if it helps?\n\nBest\nAndrey","author_login":"andrewprzh","author_association":"COLLABORATOR","created_at":"2024-01-24T17:05:12+08:00","repo_name":"ablab/IsoQuant","issue_id":2054749079,"issue_number":133,"issue_url":"https://github.com/ablab/IsoQuant/issues/133","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1914198573","fragment_type":"issue_comment","sequence":4,"text":"I was able to run smoothly after setting the parameter 'ulimit -n 1000000', thanks!","author_login":"shizhuoxing","author_association":"NONE","created_at":"2024-01-29T08:31:22+08:00","repo_name":"ablab/IsoQuant","issue_id":2054749079,"issue_number":133,"issue_url":"https://github.com/ablab/IsoQuant/issues/133","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0052","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[FP]: Wrongly reporting vulnerability CVE-2021-41033 on org.eclipse.osgi-3.18.0?","query_context":"### Package URl\n\npkg:maven/org.eclipse.platform/org.eclipse.osgi@3.18.0\n\n### CPE\n\ncpe:2.3:a:eclipse:equinox:*:*:*:*:*:*:*:* versions up to (excluding) 4.21\n\n### CVE\n\nCVE-2021-41033\n\n### ODC Integration\n\n{\"label\"=>\"Maven Plugin\"}\n\n### ODC Version\n\n8.3.1\n\n### Description\n\nPer CVE Affected component: \nEclipse Equinox, at least until version 4.21\ncpe:2.3:a:eclipse:equinox:*:*:*:*:*:*:*:* versions up to (excluding) 4.21\n\nonly 3PP \"org.eclipse.osgi-3.18.0.jar\" used, but NOT packing/using the vulnerable 3PP component \"Eclipse Equinox\", even they are NOT packed as indirect dependency in the environment. And this vulnerability is more specific to IDE and the plugin installation of eclipse. But tool is reporting this vulnerability on org.eclipse.osgi-3.18.0.jar, which is wrong.\n\nFrom Dependency Check tool team, we need confirmation on these false positives. Could you please validate and confirm?","known_context_document_ids":["gh_issue_1854278536"],"reference_answer":"Yes I think this is good, because even today I see a lot of \"unsave http\" warnings but no one seems to care!\nMaking it default redirect seems not to improve the situation here, so I think it should really not be the default.\n\nSadly the current implementation is only on the transport level otherwise I could think about something like even asking the user the same way as we ask for certificates:\n\n- Skip the mirror / edit the location\n- Try https instead\n- use http even if its unsecure\n\nAt least I think (depending on the setting) P2 might want to filter out unsecure mirrors and somehow notify them that they have to upgrade to https, e.g. by getting a list of mirrors that currently use unsafe transports.\n\nFor the UI, I think there should be a Warning whenever there is a site added with http and ask the user:\n\n1. Try https instead\n2. cancel the operation\n\nIt would therefore also be good to ask on start if one wants to convert all http -> https ...","answer_document_id":"gh_comment_1480705821","silver_evidence_path":["gh_comment_1946930733","gh_issue_1634204129","gh_comment_1480705821"],"evidence_issue_ids":[1854278536,1634204129],"source_repo_name":"dependency-check/DependencyCheck","source_issue_id":1854278536,"source_issue_number":5881,"source_issue_url":"https://github.com/dependency-check/DependencyCheck/issues/5881","target_repo_name":"eclipse-equinox/p2","target_issue_id":1634204129,"target_issue_number":230,"target_issue_url":"https://github.com/eclipse-equinox/p2/issues/230","reference_anchor_document_id":"gh_comment_1946930733","reference_answer_author":"laeubi","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2264,"anchor_target_overlap":0.1733,"target_answer_overlap":0.2319},"issue_created_at":"2023-08-17T05:29:23+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1854278536","fragment_type":"issue_description","sequence":0,"text":"[FP]: Wrongly reporting vulnerability CVE-2021-41033 on org.eclipse.osgi-3.18.0\n### Package URl\n\npkg:maven/org.eclipse.platform/org.eclipse.osgi@3.18.0\n\n### CPE\n\ncpe:2.3:a:eclipse:equinox:*:*:*:*:*:*:*:* versions up to (excluding) 4.21\n\n### CVE\n\nCVE-2021-41033\n\n### ODC Integration\n\n{\"label\"=>\"Maven Plugin\"}\n\n### ODC Version\n\n8.3.1\n\n### Description\n\nPer CVE Affected component: \nEclipse Equinox, at least until version 4.21\ncpe:2.3:a:eclipse:equinox:*:*:*:*:*:*:*:* versions up to (excluding) 4.21\n\nonly 3PP \"org.eclipse.osgi-3.18.0.jar\" used, but NOT packing/using the vulnerable 3PP component \"Eclipse Equinox\", even they are NOT packed as indirect dependency in the environment. And this vulnerability is more specific to IDE and the plugin installation of eclipse. But tool is reporting this vulnerability on org.eclipse.osgi-3.18.0.jar, which is wrong.\n\nFrom Dependency Check tool team, we need confirmation on these false positives. Could you please validate and confirm?","author_login":"prabutdr","author_association":"NONE","created_at":"2023-08-17T05:29:23+08:00","repo_name":"dependency-check/DependencyCheck","issue_id":1854278536,"issue_number":5881,"issue_url":"https://github.com/dependency-check/DependencyCheck/issues/5881","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1946930733","fragment_type":"issue_comment","sequence":1,"text":"What is the status of this?\nI tried to summarize the problem in order to make it more clear.\n\nThe Equinox Platform just bundles a bunch of components which can be also individually used and consumed from maven central. The Equinox Platform has a version number but each bundled component has its own version number (and a maven group/artifact id). The latest version of the Equinox Platform is 4.30, see here for a list of contained components are their version.\n\nCVE-2021-41033 states that all Equinox versions \n org.eclipse.platform \n org.eclipse.osgi \n 3.18.0 \n \n\nFor an outsider it is hard to determine if your used component suffers from a CVE which just states which Equinox Platform version is affected. In this specific case i think that the OSGi Framework was not vulnerable because of CVE-2021-41033.\nThe problem was in P2, according to this issue.\n\nHowever i think this a general problem and lets assume that the OSGi Framework was affected.\nCVE-2021-41033 was fixed in Equinox Platform >= 4.21, which contains Equinox OSGi Framework in version 3.17, see here.\nSo using Equinox OSGi Framework in version 3.17 and above should be fine, but OWASP complains because it mixes up the Equinox Platform version with the Equinox OSGi Framework version.\n\nI think this is general problem and might affect other parts of the Equinox Platform as well like (Equinox CM, Equinox Console, etc..) and it would be nice if we could work out a solution for this.","author_login":"profhenry","author_association":"NONE","created_at":"2024-02-15T18:45:00+08:00","repo_name":"dependency-check/DependencyCheck","issue_id":1854278536,"issue_number":5881,"issue_url":"https://github.com/dependency-check/DependencyCheck/issues/5881","linked_issue_ids":[1634204129],"is_known_query_context":false},{"document_id":"gh_comment_1948158733","fragment_type":"issue_comment","sequence":2,"text":"The eclipse maintainer stated that this is indeed a false positive\nand that the mentioned artifact (Equinox OSGi Framework) was never affected by CVE-2021-41033, see here.\n\nSo please add this as a false positive, thanks in advance.","author_login":"profhenry","author_association":"NONE","created_at":"2024-02-16T10:48:15+08:00","repo_name":"dependency-check/DependencyCheck","issue_id":1854278536,"issue_number":5881,"issue_url":"https://github.com/dependency-check/DependencyCheck/issues/5881","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1634204129","fragment_type":"issue_description","sequence":0,"text":"CVE-2021-41033: Provide improved support for dealing with http protocol in p2\nImprove the handling of http protocol by the p2 framework.\n\nThe following links provide background detail:\n\n- URL \n- URL \n\nSome work has been done to log warnings when the use of http protocol is detected in some limited contexts:\n\n URL \n\nSuch warnings were considered undesirable in some environments, e.g., inside a corporate firewall, so support was provided to allow logged warnings to be disabled:\n\n URL \n\nTo provide both maximum flexibility and maximum security, I propose to expand the current approach to fully address CVE-2021-41033 and beyond.\n\nI propose that we focus on guarding/monitoring p2's transport layer as a whole such that **all** internet access is taken into consideration, including the following mainstream use cases:\n- p2 repository content metadata and artifact metadata, composite children, and repository reference URLs, e.g.,\n - URL \n- mirror server URLs, i.e., the `p2.mirrorsURL` property in the artifact metadata, e.g.,\n - URL \n- mirror URLs, e.g.,\n - URL \n- artifacts URLs, e.g.,\n - URL \n\nI propose three modes of http handling:\n1. **allow**\n - This is basically what we have now, i.e., log a warning but allow that warning to be suppressed. The warning will be logged for all http access, not simply once per repository and only for repository URLs.\n3. **redirect**\n - Any http URI will be redirected/written to use https such that no http request ever reaches out into the network.\n5. **block**\n - Any http URI will be blocked as if the network were down/inaccessible.\n\nOne important question is \"what should be the default behavior in the absence of an explicit choice of one of those three\"? I propose the framework defaults to **block** http access. Product/application builders (or even users) can then choose whether to **allow** such access or **redirect** such access; they will be alerted to that choice by the exception that blocks the access. (Note that within a corporate firewall, it might well be the case that redirection to https causes failures due to missing root certificates so **allow**, while not ideal, may be needed in some limited environments where security is ensured via external mechanisms.)\n\nI have a PR pending to implement the above proposal. \n\nComments on the proposal are welcome!","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-21T15:49:43+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1478098404","fragment_type":"issue_comment","sequence":1,"text":"Should it not the other way round ;-)\n\nMaven is blocking http for a while and even though it produce some disturbance it seems people can manage this, so **block** as a default seems suitable to me.\n \n\nProbably better \"rewrite\" as redirection would need to happen on the server side, this seems similar to the \"http-only\" setting in firefox: URL","author_login":"laeubi","author_association":"MEMBER","created_at":"2023-03-21T15:56:33+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1478149388","fragment_type":"issue_comment","sequence":2,"text":"Oops. 😜 \n\nI edited the original text of fix the for block!\n\nI personally prefer the term redirect because \"rewrite\" sounds a little more like we might be modify (i.e., literally re-write) the sources of the URLs when we are actually \"directing\" the underlying transport layer to use https no matter what. The https-only link doesn't use either term. This is more about style/preference rather than substance, so if someone else feels strongly, I have bigger fish to fry. 😛 In the implementation this is controlled by system properties...","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-21T16:14:56+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1478170656","fragment_type":"issue_comment","sequence":3,"text":"Well on the transport layer it is actually enforce SSL :-D\n\nMaybe it would then be better to not use such naming as allow / block / ... so maybe more make it more generic as its done with cipher suites to have a blacklist of protocols (!), as for example one might also thing that plain ftp is bad, so maybe like this as a default (**block**):\n\n-Dp2.transport.insecure = warn\n-Dp2.transport.block = ftp,http\n\nto **allow** but warn:\n\n-Dp2.transport.block = \n\nto allow but do not warn:\n\n-Dp2.transport.insecure = debug\n-Dp2.transport.block = \n\nAnd if one really wants redirect\n\n-Dp2.transport.http = redirect","author_login":"laeubi","author_association":"MEMBER","created_at":"2023-03-21T16:26:53+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479785458","fragment_type":"issue_comment","sequence":4,"text":"@akurtakov \n\nDo you guys want the SDK product to specify `-Dp2.httpAction=redirect`?\n\n@jonahgraham \n\nDo you want the EPP products to specify `-Dp2.httpAction=redirect`?\n\nI plan to do this for the Eclipse Installer...","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-22T15:31:27+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479789405","fragment_type":"issue_comment","sequence":5,"text":"I even think this should be the default value for the parameter if nothing else specified.","author_login":"akurtakov","author_association":"MEMBER","created_at":"2023-03-22T15:33:50+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479807503","fragment_type":"issue_comment","sequence":6,"text":"One \"vague\" reason I had for choosing **block** as the default is because this forces people to recognize/notice there is a decision to be made. But I suppose a counter argument is that if 99% of the applications (I made that number up) will want **redirect**, then make that the default. If the SDK, all the EPP packages, and the installer all want to specify **redirect**, it's certainly easier to make that the default. \n\nSo if @jonahgraham agrees and no one else objects strongly (with good arguments), I'm happy to change the default...\n\n@iloveeclipse Maybe you have an opinion about the default?","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-22T15:42:57+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479864923","fragment_type":"issue_comment","sequence":7,"text":"Yes, if the server doesn't support https, there will be an error to that effect. Also, within corporate firewalls, there could be failures because of missing root certificates, which folks sometime avoid by using http, but since most things (touch points) are already specifying https, that's already often an issue.","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-22T16:12:55+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1480705821","fragment_type":"issue_comment","sequence":8,"text":"Yes I think this is good, because even today I see a lot of \"unsave http\" warnings but no one seems to care!\nMaking it default redirect seems not to improve the situation here, so I think it should really not be the default.\n\nSadly the current implementation is only on the transport level otherwise I could think about something like even asking the user the same way as we ask for certificates:\n\n- Skip the mirror / edit the location\n- Try https instead\n- use http even if its unsecure\n\nAt least I think (depending on the setting) P2 might want to filter out unsecure mirrors and somehow notify them that they have to upgrade to https, e.g. by getting a list of mirrors that currently use unsafe transports.\n\nFor the UI, I think there should be a Warning whenever there is a site added with http and ask the user:\n\n1. Try https instead\n2. cancel the operation\n\nIt would therefore also be good to ask on start if one wants to convert all http -> https ...","author_login":"laeubi","author_association":"MEMBER","created_at":"2023-03-23T07:17:13+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1480800620","fragment_type":"issue_comment","sequence":9,"text":"It's clear I can't make everyone happy all of the time and it's clear that I do not have time to heat up nor cool down oceans. Prompting users about the protocol is just beyond the scope of what I plan to do. Such URLs can first appear within composites, or from references to other sites, i.e., places where the user just doesn't see where the URL comes from nor can the user change it...\n\nI will change the default to minimize the amount of effort needed by product/application builders and I will address some of the concerns in via:\n\n URL \n\nAs such , both -Dp2.ftpRule and -Dp2httpRule are supported and both are `redirect` by default.\n\nI will not move the logic outside of the transport layer because it's way too likely some caller will overlook:\nimage\n\nAlso , the current implementation is hard coded so there is currently no use case. Should such a use case arise in the future, it can be addressed at that time.","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-23T08:50:31+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1480828674","fragment_type":"issue_comment","sequence":10,"text":"You asked for feedback here\n \n\nSo I gave my feedback on where I think things *might* be improved, obviously you are free to _ignore_ them, _adapt_ how you seem best fit or whatever else, so for me its not about making anyone *happy* ...\n \n\nI think the use-case is already described here (even though that's not necessarily my use case or the eclipse use case), lets say I have **one** site that do not supports https (for whatever reason), this will currently fail unless I allow unsecure access for **every** site.","author_login":"laeubi","author_association":"MEMBER","created_at":"2023-03-23T09:06:19+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481505433","fragment_type":"issue_comment","sequence":11,"text":"Your feedback has been helpful and constructive and has been adapted into the implementation to make it better and more general than it would have been without your feedback. 😄","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-23T16:27:47+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482353105","fragment_type":"issue_comment","sequence":12,"text":"FYI, that was changed during the previous release cycle by this commit:\n\n URL","author_login":"merks","author_association":"CONTRIBUTOR","created_at":"2023-03-24T07:11:28+08:00","repo_name":"eclipse-equinox/p2","issue_id":1634204129,"issue_number":230,"issue_url":"https://github.com/eclipse-equinox/p2/issues/230","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0053","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Transfer Ownership?","query_context":"**Nextcloud (please complete the following information):**\n- Nextcloud-Version: 22.2.5\n- Forms-Version: 2.4.0\n\n**Is your feature request related to a problem? Please describe.**\nNextcloud is used by many companies, that implies staff turnover and leaving employees. If the account is disabled or deleted, we lost access to the forms and related data. \n\n**Describe the solution you'd like**\nWe would like to be able to transfer forms ownership from an user to another, using occ commands and/or a web gui option.\n\n**Describe alternatives you've considered**\nI thought about changing manually the db, but it seems touchy and I cannot give control to it through my userbase. \n\n**Additional context**\nIf this isn't a regular use case, I think it may tend to become one as Nextcloud seems to be more and more used by privacy-concerned companies. Nextcloud Files and Calendar are already proposing such a feature, it's a shame that this is not \"standardized\".\n\nThanks for your reading and thanks for the amount of work you're placing on Nextcloud as a whole.","known_context_document_ids":["gh_issue_1157247336"],"reference_answer":"It’s set for 4.0 so not urgent, but also definitely not wontfix. It already came up in our own little usecase that we needed the marketing team and me to have access to the Forms.","answer_document_id":"gh_comment_647549602","silver_evidence_path":["gh_comment_1146586198","gh_issue_610258798","gh_comment_647549602"],"evidence_issue_ids":[1157247336,610258798],"source_repo_name":"nextcloud/forms","source_issue_id":1157247336,"source_issue_number":1131,"source_issue_url":"https://github.com/nextcloud/forms/issues/1131","target_repo_name":"nextcloud/forms","target_issue_id":610258798,"target_issue_number":322,"target_issue_url":"https://github.com/nextcloud/forms/issues/322","reference_anchor_document_id":"gh_comment_1146586198","reference_answer_author":"jancborchardt","reference_answer_author_association":"MEMBER","quality_score":85.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0625,"anchor_target_overlap":0.25,"target_answer_overlap":0.3571},"issue_created_at":"2022-03-02T14:08:32+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_1157247336","fragment_type":"issue_description","sequence":0,"text":"Transfer Ownership\n**Nextcloud (please complete the following information):**\n- Nextcloud-Version: 22.2.5\n- Forms-Version: 2.4.0\n\n**Is your feature request related to a problem? Please describe.**\nNextcloud is used by many companies, that implies staff turnover and leaving employees. If the account is disabled or deleted, we lost access to the forms and related data. \n\n**Describe the solution you'd like**\nWe would like to be able to transfer forms ownership from an user to another, using occ commands and/or a web gui option.\n\n**Describe alternatives you've considered**\nI thought about changing manually the db, but it seems touchy and I cannot give control to it through my userbase. \n\n**Additional context**\nIf this isn't a regular use case, I think it may tend to become one as Nextcloud seems to be more and more used by privacy-concerned companies. Nextcloud Files and Calendar are already proposing such a feature, it's a shame that this is not \"standardized\".\n\nThanks for your reading and thanks for the amount of work you're placing on Nextcloud as a whole.","author_login":"ThibautPlg","author_association":"NONE","created_at":"2022-03-02T14:08:32+08:00","repo_name":"nextcloud/forms","issue_id":1157247336,"issue_number":1131,"issue_url":"https://github.com/nextcloud/forms/issues/1131","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1097474532","fragment_type":"issue_comment","sequence":1,"text":"This would be useful; User A develops the form, transfer Form to Users B,C,D... or Group. Then recipient users can share link to external people to answer/fill-in and collect their own answers.","author_login":"CorinthCom","author_association":"NONE","created_at":"2022-04-13T02:04:09+08:00","repo_name":"nextcloud/forms","issue_id":1157247336,"issue_number":1131,"issue_url":"https://github.com/nextcloud/forms/issues/1131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1146586198","fragment_type":"issue_comment","sequence":2,"text":"I support this request! I set up a form for an organizer of a small community festival and wish to assign editing rights to the organizing circle. See also URL","author_login":"ajoana","author_association":"NONE","created_at":"2022-06-04T10:42:07+08:00","repo_name":"nextcloud/forms","issue_id":1157247336,"issue_number":1131,"issue_url":"https://github.com/nextcloud/forms/issues/1131","linked_issue_ids":[610258798],"is_known_query_context":false},{"document_id":"gh_comment_1153666801","fragment_type":"issue_comment","sequence":3,"text":"Same here! \nI have developed forms, but need my editor to be able to edit them also","author_login":"TheMetMan","author_association":"NONE","created_at":"2022-06-13T09:06:32+08:00","repo_name":"nextcloud/forms","issue_id":1157247336,"issue_number":1131,"issue_url":"https://github.com/nextcloud/forms/issues/1131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1197966891","fragment_type":"issue_comment","sequence":4,"text":"Additionally:\n\nIt would be nice if you could configure to transfer all forms to another user / the admin, when a user is deleted (instead of removing the forms). This would be useful e.g. if a user leaves your company.","author_login":"susnux","author_association":"NONE","created_at":"2022-07-28T10:33:47+08:00","repo_name":"nextcloud/forms","issue_id":1157247336,"issue_number":1131,"issue_url":"https://github.com/nextcloud/forms/issues/1131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1201220994","fragment_type":"issue_comment","sequence":5,"text":"Hi.\nthx for forms in nextcloud.\nI got also to this. I would prefer to share the edit feature to someone else, e.g. a circle.","author_login":"ReimarBauer","author_association":"NONE","created_at":"2022-08-01T13:40:16+08:00","repo_name":"nextcloud/forms","issue_id":1157247336,"issue_number":1131,"issue_url":"https://github.com/nextcloud/forms/issues/1131","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_610258798","fragment_type":"issue_description","sequence":0,"text":"Collaborative editing of Forms\nHello!\n\nIt would be really nice if we have collaborative editing of Forms.\n\n### Usage Examples\n- The whole marketing team has access to some Forms and responses.\n- My situation: I have a team of some people. They review user requests (bug reports and feature request) for my public programs. They talk with the user and create cards on the correct board in the Deck app. But only I have access to the form response and that makes it a bit harder. I have to export all response as excel/csv and send it to them every time new responses are here.\n\n### What do I think about how It could be used\nShare a Form to other users/groups and define if they have access to view the responses and if they have access to edit the Form. It should also be possible then to allow/deny re-sharing the Form.\nAs a good example, take the Deck app.\n\nThis feature has been discussed already here: #316","author_login":"Pilzinsel64","author_association":"NONE","created_at":"2020-04-30T17:30:11+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_643348306","fragment_type":"issue_comment","sequence":1,"text":"I split the part of **Ability to share responses #455** out because that one is reasonable and simpler to do.\n\nCollaborative editing of Forms comes with all the pitfalls of conflict handling etc and it’s not something we should get into yet at this stage. :)","author_login":"jancborchardt","author_association":"MEMBER","created_at":"2020-06-12T15:55:04+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_646972465","fragment_type":"issue_comment","sequence":2,"text":"Is it possible to re-use some how some parts of the Text app, which allows to organise collaboration in creation of very simple forms, eg checkboxes?..","author_login":"ostasevych","author_association":"NONE","created_at":"2020-06-20T10:11:59+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_646999766","fragment_type":"issue_comment","sequence":3,"text":"@ostasevych I don’t think so, as in Nextcloud Text we use ProseMirror as base which is focused on text editing. But ref @juliushaertl for info.","author_login":"jancborchardt","author_association":"MEMBER","created_at":"2020-06-20T14:02:18+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647443230","fragment_type":"issue_comment","sequence":4,"text":"Yes, I don't think that using prosemirror and its document format here will make a lot of sense. For some collaborative editing, you could of course use a somehow similar change tracking based sync format as the text app does, but this will most likely require a larger amount of work in restructuring the database for that.","author_login":"juliushaertl","author_association":"MEMBER","created_at":"2020-06-22T10:56:21+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647540949","fragment_type":"issue_comment","sequence":5,"text":"Yeah, for me it's far too complicated.\nWe could have a way to allow working on different questions, adding/removing.\nBut we cannot implement a conflict resolution (the hardes part) easily.\n\nI'd either close as wontfix or just partial one","author_login":"skjnldsv","author_association":"MEMBER","created_at":"2020-06-22T14:05:10+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647549602","fragment_type":"issue_comment","sequence":6,"text":"It’s set for 4.0 so not urgent, but also definitely not wontfix. It already came up in our own little usecase that we needed the marketing team and me to have access to the Forms.","author_login":"jancborchardt","author_association":"MEMBER","created_at":"2020-06-22T14:19:41+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_678127343","fragment_type":"issue_comment","sequence":7,"text":"Great to read that this will be adressed.\nImho it's kind of misleading, that there is the sharing function with other users for forms at all","author_login":"splashote","author_association":"NONE","created_at":"2020-08-21T08:57:55+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_718398784","fragment_type":"issue_comment","sequence":8,"text":"Hello, I ended up here since my and my team heavily rely on Nextcloud and if only one of us can create and edit a form without collaboration by the others, this implementation is almost useless. If I may: is it really necessary to define conflicts management? I feel like if the user just knows forms have to be edited one at a time, this integration could be **very** useful and not that hard to implement.\n\nThanks a lot for your work and your time!\n\nT.","author_login":"xplosionmind","author_association":"NONE","created_at":"2020-10-29T06:47:28+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_743979325","fragment_type":"issue_comment","sequence":9,"text":"Extending the thoughts of @xplosionmind , a simple mutex-solution would be fully satisfying imho. Just have a lock on the form while it is being edited and a timeout if one forgets to free it afterwards.\nConflict handling is mainly needed for realtime or offline collaborative editing. Offline is not possible anyway (it's browser only, right?) and realtime is really cool but only necessary in corner cases. :)","author_login":"shukon","author_association":"NONE","created_at":"2020-12-13T09:34:48+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_800785753","fragment_type":"issue_comment","sequence":10,"text":"I'm waiting this feature for months. I hope that doesn't take long. My job is on the table. \nSending good vibes to the dev team.\nThxx","author_login":"tonyhts","author_association":"NONE","created_at":"2021-03-17T04:31:53+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_821093324","fragment_type":"issue_comment","sequence":11,"text":"An idea to allow for a workaround might be to implement import and export of forms (#582). Users could then share their exported, say CSV, files. The different exported CSV files could be manually merged in a spreadsheet app and imported to the final form.\n\nThis would at least work for our use case. What do you think?","author_login":"bitbacchus","author_association":"NONE","created_at":"2021-04-16T10:54:17+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_831357603","fragment_type":"issue_comment","sequence":12,"text":"hi there,\n\ncould the survey (forms) be provided with an edit(orange)/public(green) button (i.e. a button that changes color and function by click). when the button is set to edit, the edit option for groups or nextcloud-user or a public-edit-link appears. and when the button is clicked to public, the edit-group/nextcloud-user/public-edit-link is blocked and can only be edited by the creator of the survey (forms)?\n\nor all people added as editors to the survey (forms) can click the edit/public button to 'lock' or 'unlock' the survey?\n\nthx for your work, i like this project <3","author_login":"k33la1n0","author_association":"NONE","created_at":"2021-05-03T15:56:05+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_874236937","fragment_type":"issue_comment","sequence":13,"text":"Perhaps **Etherpad** could be useful in some way to meet this challenge: URL","author_login":"agentlibre","author_association":"NONE","created_at":"2021-07-05T16:55:59+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1146608201","fragment_type":"issue_comment","sequence":14,"text":"I'd be happy to just have a group or circle with the right to edit - only one at a time. I'm just a user but wouldn't a file lock be enough while one is editing?","author_login":"ajoana","author_association":"NONE","created_at":"2022-06-04T13:16:34+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1785534150","fragment_type":"issue_comment","sequence":15,"text":"Hello and thanks for the app,\nI came here because we also need this feature. In our case, the communication team needs to edit the forms that other teams make.\nThanks a lot and have a good day :)","author_login":"rosa2","author_association":"NONE","created_at":"2023-10-30T16:01:19+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1988609949","fragment_type":"issue_comment","sequence":16,"text":"We don't need collaborative editing, but just having more than one person who has the right to edit a form would be really useful when preparing a form together. It doesn't need to do any conflict resolution, just let me edit text in a form someone else created. That would be nice. :)","author_login":"RalfJung","author_association":"NONE","created_at":"2024-03-11T14:43:43+08:00","repo_name":"nextcloud/forms","issue_id":610258798,"issue_number":322,"issue_url":"https://github.com/nextcloud/forms/issues/322","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0054","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Rust TL-B serialization?","query_context":"### Summary\n\nTL-B serialization is a fundamental component of the TON blockchain, enabling the encoding and decoding of data structures in a compact, efficient, and schema-based binary format. To provide Rust developers with seamless support for this critical feature, we propose developing a TL-B serialization library in Rust. This library will allow developers to work with TL-B schemas directly in their Rust applications, enhancing the capabilities of TON-based tools and services.\n\n### Context\n\nThe TL-B (Type Language - Binary) format is widely used within the TON blockchain for serializing and deserializing data structures, such as messages, cells, and state data. While other programming languages have partial implementations or utilities for TL-B serialization, Rust lacks a comprehensive and developer-friendly library tailored for this purpose. By creating a dedicated TL-B serialization library in Rust, we can empower developers to build efficient and reliable applications in the TON ecosystem. Key features of the proposed library include:\n • Support for defining and parsing TL-B schemas directly in Rust.\n • Serialization and deserialization of TL-B data structures into binary format.\n • Bit-level data manipulation for precise TL-B compliance.\n • Recursive structure handling for complex TL-B schemas.\n • Error handling to ensure data integrity and conformity with TL-B specifications.\n • Integration with existing TON blockchain tools, such as tonlibjson, for seamless workflows.\n \nSuppose we have a simple TL-B schema:\nuse std::io::{self, Read, Write};\n\n// Example struct matching the TL-B schema\nstruct User {\n text: String,\n age: i32,\n}\n\n// Serialization\nimpl User {\n fn serialize(&self, writer: &mut impl Write) -> io::Result {\n // Serialize the text as a string (length-prefixed, for example)\n let text_bytes = self.text.as_bytes();\n let length = text_bytes.len() as u32;\n writer.write_all(&length.to_be_bytes())?;\n writer.write_all(text_bytes)?;\n\n // Serialize the age as a 32-bit integer\n writer.write_all(&self.age.to_be_bytes())?;\n Ok(())\n }\n\n // Deserialization\n fn deserialize(reader: &mut impl Read) -> io::Result {\n // Read the text length\n let mut length_bytes = [0u8; 4];\n reader.read_exact(&mut length_bytes)?;\n let length = u32::from_be_bytes(length_bytes);\n\n // Read the text\n let mut text_bytes = vec![0u8; length as usize];\n reader.read_exact(&mut text_bytes)?;\n\n // Read the age\n let mut age_bytes = [0u8; 4];\n reader.read_exact(&mut age_bytes)?;\n let age = i32::from_be_bytes(age_bytes);\n\n Ok(Self {\n text: String::from_utf8(text_bytes).unwrap(),\n age,\n })\n }\n}\n\n### References\n\nDevelop a Rust library that implements TL-B serialization, enabling developers to encode, decode, and manipulate TL-B data structures effortlessly within Rust applications.\n\n### Estimate suggested reward\n\n$5,000 USD in TON equivalent","known_context_document_ids":["gh_issue_2669308519"],"reference_answer":"### @mitinarseny thank you for the contribution!\n\nTo accurately recognize your **valuable contributions** in our repository, we kindly request you to submit a Pull Request to the Hall of Fame file, providing the wallet address and a link to the bounty with the number.\n\nPlease follow these steps:\n1) Fork the repository (if you haven't already).\n2) Edit the Hall of Fame file, commit, and push your changes.\n3) Create a Pull Request from your fork to the main repository, providing the wallet address and a link to the bounty with the number (for example, Pull Request URL \nFor reference on what your entry should look like, please see the examples of past merged pull requests.\n\n4) And please follow the questbook proposal stage in accordance with the bounty guideline","answer_document_id":"gh_comment_2202141267","silver_evidence_path":["gh_comment_2483706487","gh_issue_2145953947","gh_comment_2202141267"],"evidence_issue_ids":[2669308519,2145953947],"source_repo_name":"ton-society/grants-and-bounties","source_issue_id":2669308519,"source_issue_number":874,"source_issue_url":"https://github.com/ton-society/grants-and-bounties/issues/874","target_repo_name":"ton-society/grants-and-bounties","target_issue_id":2145953947,"target_issue_number":444,"target_issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","reference_anchor_document_id":"gh_comment_2483706487","reference_answer_author":"delovoyhomie","reference_answer_author_association":"COLLABORATOR","quality_score":77.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3125,"target_answer_overlap":0.04},"issue_created_at":"2024-11-18T17:33:05+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2669308519","fragment_type":"issue_description","sequence":0,"text":"Rust TL-B serialization\n### Summary\n\nTL-B serialization is a fundamental component of the TON blockchain, enabling the encoding and decoding of data structures in a compact, efficient, and schema-based binary format. To provide Rust developers with seamless support for this critical feature, we propose developing a TL-B serialization library in Rust. This library will allow developers to work with TL-B schemas directly in their Rust applications, enhancing the capabilities of TON-based tools and services.\n\n### Context\n\nThe TL-B (Type Language - Binary) format is widely used within the TON blockchain for serializing and deserializing data structures, such as messages, cells, and state data. While other programming languages have partial implementations or utilities for TL-B serialization, Rust lacks a comprehensive and developer-friendly library tailored for this purpose. By creating a dedicated TL-B serialization library in Rust, we can empower developers to build efficient and reliable applications in the TON ecosystem. Key features of the proposed library include:\n • Support for defining and parsing TL-B schemas directly in Rust.\n • Serialization and deserialization of TL-B data structures into binary format.\n • Bit-level data manipulation for precise TL-B compliance.\n • Recursive structure handling for complex TL-B schemas.\n • Error handling to ensure data integrity and conformity with TL-B specifications.\n • Integration with existing TON blockchain tools, such as tonlibjson, for seamless workflows.\n \nSuppose we have a simple TL-B schema:\nuse std::io::{self, Read, Write};\n\n// Example struct matching the TL-B schema\nstruct User {\n text: String,\n age: i32,\n}\n\n// Serialization\nimpl User {\n fn serialize(&self, writer: &mut impl Write) -> io::Result {\n // Serialize the text as a string (length-prefixed, for example)\n let text_bytes = self.text.as_bytes();\n let length = text_bytes.len() as u32;\n writer.write_all(&length.to_be_bytes())?;\n writer.write_all(text_bytes)?;\n\n // Serialize the age as a 32-bit integer\n writer.write_all(&self.age.to_be_bytes())?;\n Ok(())\n }\n\n // Deserialization\n fn deserialize(reader: &mut impl Read) -> io::Result {\n // Read the text length\n let mut length_bytes = [0u8; 4];\n reader.read_exact(&mut length_bytes)?;\n let length = u32::from_be_bytes(length_bytes);\n\n // Read the text\n let mut text_bytes = vec![0u8; length as usize];\n reader.read_exact(&mut text_bytes)?;\n\n // Read the age\n let mut age_bytes = [0u8; 4];\n reader.read_exact(&mut age_bytes)?;\n let age = i32::from_be_bytes(age_bytes);\n\n Ok(Self {\n text: String::from_utf8(text_bytes).unwrap(),\n age,\n })\n }\n}\n\n### References\n\nDevelop a Rust library that implements TL-B serialization, enabling developers to encode, decode, and manipulate TL-B data structures effortlessly within Rust applications.\n\n### Estimate suggested reward\n\n$5,000 USD in TON equivalent","author_login":"DevNebulaX","author_association":"NONE","created_at":"2024-11-18T17:33:05+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2669308519,"issue_number":874,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/874","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2483706487","fragment_type":"issue_comment","sequence":1,"text":"Please visit #444 also.\n\nSpeaking of improvements, I'd like infallible (and preferably non-panicking) store functions; they seem more optimal. They could be implemented as in URL","author_login":"ProgramCrafter","author_association":"CONTRIBUTOR","created_at":"2024-11-18T17:39:39+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2669308519,"issue_number":874,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/874","linked_issue_ids":[2145953947],"is_known_query_context":false},{"document_id":"gh_comment_2493531725","fragment_type":"issue_comment","sequence":2,"text":"Thank you for your submission. After careful review, we regret to inform you that we cannot proceed with your application at this time, as a Rust SDK has already been implemented as part of the Bounty program (see bounty #182).","author_login":"delovoyhomie","author_association":"COLLABORATOR","created_at":"2024-11-22T11:25:34+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2669308519,"issue_number":874,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2145953947","fragment_type":"issue_description","sequence":0,"text":"TL-B serialization in Rust\n### Summary\n\nImplement a Rust library for effective and convenient TL-B (Typed Language Binary) serialization and deserialization.\n\n### Context\n\n### Why it's Important?\nImplementing TL-B serialization in Rust is imperative to offer wider language support allowing more programmers to contribute to TON.\n\n### Problem showcase:\nFrom TL-B Language docs:\n \n\nAt the moment, the only existing Rust library that has very basic support for TL-B serialization and deserialization is tonlib-rs.\nWhile it implements basic functionality for storing uints/strings/addresses into `Cell` and reading these exact types back from it, but it becomes hard to serialize complex nested structures (e.g. DeDust nested Swaps). The library does not define unified traits for serialization/deserialization, so you can't compose types with each other, while using powerful features of Rust type system. This might discourage Rust developers from contributing to the project.\n\n### Potential Solution:\nHere is my initial implementation of a Rust library that supports TL-B serialization and deserialization: URL \n\nIt already supports effective TL-B (de)serialization for primitive types and composing them into larger ones, following best practices and leveraging features of Rust type system.\n\nThe library has similar design to serde and serde_with traits. One might ask: why to define your own (de)serialization traits and not to use existing serde ecosystem and implement a new data format for TL-B? That's a reasonable question to ask and I tried this way in the beginning. But, unfortunately, per-bit serialization and references to Cells cannot be expressed with serde's data model.\n\n### Things needed to be done:\n* Documentation\n* Cell serialization into bytes needs to be optimized and to reuse existing `BitSerialize` trait from this crate.\n* More testing\n* Publish crate to crates.io registry\n* Open a PR for integration with tonlib-rs\n\n### Future improvements:\n* `syn`-powered TL-B schema parsing\n* Code-gen for (de)serialization by using [`#[derive(TLBSerialize)]`]( URL \n\n### References\n\n* tlb – this library\n* TL-B Language\n* tonlib-rs\n\n### Estimate suggested reward\n\n$5K","author_login":"mitinarseny","author_association":"NONE","created_at":"2024-02-21T06:43:34+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2145953947,"issue_number":444,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1957709579","fragment_type":"issue_comment","sequence":1,"text":"I'd like to add my initial implementation: URL \nRight now it only collects a list of stores to be done into a cell, but that can be modified easily.\n\nrust\n#[tlb_enum_serializable]\n#[tlb_assert_unsafe(items_prefixes_nonoverlap)]\nenum CommonMsgInfo {\n #[tlb_item_serializable(u 0 1bit, ihr_disabled, bounce, bounced, src, dest,\n value, ihr_fee, fwd_fee, created_lt, created_at)]\n int_msg_info {\n ihr_disabled: bool,\n bounce: bool,\n bounced: bool,\n src: ton::Address,\n dest: ton::Address,\n value: ton::CurrencyCollection,\n ihr_fee: ton::Coins,\n fwd_fee: ton::Coins,\n created_lt: u64,\n created_at: u32\n }\n}\n\n...\nprintln!(\"{:?}\", CommonMsgInfo::default().serialize());\n// [\"u 0 1bit\", \"u 1 1bit\", \"u 1 1bit\", \"u 0 1bit\",\n// \"u 4 3bit\", \"u 0 8bit\", \"u 0 128bit\", \"u 0 128bit\", \"u 4 3bit\", \"u 0 8bit\", \"u 0 128bit\", \"u 0 128bit\",\n// \"u 0 4bit\", \"u 0 0bit\", \"u 0 1bit\", \"u 0 4bit\", \"u 0 0bit\", \"u 0 4bit\", \"u 0 0bit\",\n// \"u 10001 64bit\", \"u 0 32bit\"]","author_login":"ProgramCrafter","author_association":"CONTRIBUTOR","created_at":"2024-02-21T18:59:19+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2145953947,"issue_number":444,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1958570154","fragment_type":"issue_comment","sequence":2,"text":"There is also broxus/ton-labs-block which already has full implementation of block.tlb.","author_login":"hacker-volodya","author_association":"NONE","created_at":"2024-02-22T03:00:07+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2145953947,"issue_number":444,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008140094","fragment_type":"issue_comment","sequence":3,"text":"Thank you for your initiative, but it seems that there are already tools of this kind available now.","author_login":"delovoyhomie","author_association":"COLLABORATOR","created_at":"2024-03-19T21:09:07+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2145953947,"issue_number":444,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2145853596","fragment_type":"issue_comment","sequence":4,"text":"I'm happy to announce that ~tlb~ toner finally found its usage in in ton-grpc!\ntoner is going to be used to implement balancing over shards to safely implement deserialization of complex nested structs, such as:\n\ntlb\n_ (HashmapE 32 ^(BinTree ShardDescr)) = ShardHashes;\n\n@akostylev0 Please, correct me if I'm wrong here.\n\nI'm going to continue working on toner and will add a proper documentation soon.\nIf anyone also wants to use it, check out the docs. Please, feel free to reach out in case you have any questions or suggestions.\n\nHope it helps! ❤️","author_login":"mitinarseny","author_association":"NONE","created_at":"2024-06-03T18:25:25+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2145953947,"issue_number":444,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2202141267","fragment_type":"issue_comment","sequence":5,"text":"### @mitinarseny thank you for the contribution!\n\nTo accurately recognize your **valuable contributions** in our repository, we kindly request you to submit a Pull Request to the Hall of Fame file, providing the wallet address and a link to the bounty with the number.\n\nPlease follow these steps:\n1) Fork the repository (if you haven't already).\n2) Edit the Hall of Fame file, commit, and push your changes.\n3) Create a Pull Request from your fork to the main repository, providing the wallet address and a link to the bounty with the number (for example, Pull Request URL \nFor reference on what your entry should look like, please see the examples of past merged pull requests.\n\n4) And please follow the questbook proposal stage in accordance with the bounty guideline","author_login":"delovoyhomie","author_association":"COLLABORATOR","created_at":"2024-07-02T07:16:37+08:00","repo_name":"ton-society/grants-and-bounties","issue_id":2145953947,"issue_number":444,"issue_url":"https://github.com/ton-society/grants-and-bounties/issues/444","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0055","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"iOS return 500 while using flutter uploader with version 1.x?","query_context":"For android the flutter uploader works fine, the server able to upload the data. But for iOS, I meet this issue.\n3f1086db-3486-42f2-9b66-d2523640280f\n\nThen, I have tried the flutter uploader with version 3.0 beta, it didn't appear this error, but it straight went into this line first and the progress automatically = 100\n uploader.result.listen((result) {\n BotToast.showText(text:\"Complete\");\n }\n instead of this\n uploader.progress.listen((progress) {\n BotToast.showText(text:progress.progess.toString());\n }\n \nthen it automatically run 2nd time ( uploader.enqueue() ) then start from listening the progress=0. When the progress =100 and result = UploadTaskStatus.complete , it did toast the complete but my server couldn't receive any data from it.","known_context_document_ids":["gh_issue_933380033"],"reference_answer":"What content type is the file you are uploading? You need to match it using `Content-Type`.","answer_document_id":"gh_comment_1287397857","silver_evidence_path":["gh_comment_1152243497","gh_issue_1040395068","gh_comment_1287397857"],"evidence_issue_ids":[933380033,1040395068],"source_repo_name":"fluttercommunity/flutter_uploader","source_issue_id":933380033,"source_issue_number":184,"source_issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/184","target_repo_name":"fluttercommunity/flutter_uploader","target_issue_id":1040395068,"target_issue_number":204,"target_issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/204","reference_anchor_document_id":"gh_comment_1152243497","reference_answer_author":"ened","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2353,"anchor_target_overlap":0.1765,"target_answer_overlap":0.1429},"issue_created_at":"2021-06-30T07:11:58+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_933380033","fragment_type":"issue_description","sequence":0,"text":"iOS return 500 while using flutter uploader with version 1.x\nFor android the flutter uploader works fine, the server able to upload the data. But for iOS, I meet this issue.\n3f1086db-3486-42f2-9b66-d2523640280f\n\nThen, I have tried the flutter uploader with version 3.0 beta, it didn't appear this error, but it straight went into this line first and the progress automatically = 100\n uploader.result.listen((result) {\n BotToast.showText(text:\"Complete\");\n }\n instead of this\n uploader.progress.listen((progress) {\n BotToast.showText(text:progress.progess.toString());\n }\n \nthen it automatically run 2nd time ( uploader.enqueue() ) then start from listening the progress=0. When the progress =100 and result = UploadTaskStatus.complete , it did toast the complete but my server couldn't receive any data from it.","author_login":"neohboonyee99","author_association":"NONE","created_at":"2021-06-30T07:11:58+08:00","repo_name":"fluttercommunity/flutter_uploader","issue_id":933380033,"issue_number":184,"issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/184","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1152243497","fragment_type":"issue_comment","sequence":1,"text":"have you checked that the issue is not the content-type header? we had the same issue (server not receiving anything when the request came from iOS but worked fine on android) and setting no content-type header worked for MultipartFormDataUpload\nRelated issue #204","author_login":"raphaelgurtner","author_association":"NONE","created_at":"2022-06-10T11:03:50+08:00","repo_name":"fluttercommunity/flutter_uploader","issue_id":933380033,"issue_number":184,"issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/184","linked_issue_ids":[1040395068],"is_known_query_context":false},{"document_id":"gh_comment_1279658665","fragment_type":"issue_comment","sequence":2,"text":"@raphaelgurtner what does setting no content-type header means? Can you please tell me what to write? Here is my code:\n\nawait FlutterUploader().enqueue(\n RawUpload(\n url: uploadUrls[i],\n // required: url to upload to\n path: selectedVideos[i].path,\n // required: list of files that you want to upload\n method: UploadMethod.PUT,\n // HTTP method (POST or PUT or PATCH)\n // headers: {\"apikey\": \"api_123456\", \"userkey\": \"userkey_123456\"},\n tag: 'post video uploading', // custom tag which is returned in result/progress\n ),\n );","author_login":"waqadArshad","author_association":"NONE","created_at":"2022-10-15T04:46:24+08:00","repo_name":"fluttercommunity/flutter_uploader","issue_id":933380033,"issue_number":184,"issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/184","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1040395068","fragment_type":"issue_description","sequence":0,"text":"Fail to upload file in IOS\nHi , thanks for great work!\nI use flutter_uploader 1.2.1 to upload file and photos to server, server code is asp.net core web api ,like following code:\npublic Response UploadFile(IFormFile file)\n{\n /* code ...*/\n}\neverything is ok where in Android. \nbut in IOS device：iphone 7 plus. it is not work.\nfrom log, file had been uploaded ,but in server file is null（as code above）. \nlog:\nURLSessionDidCompleteWithError: upload completed\nURLSessionDidCompleteWithError: response: {\"returnValue\":null,\"isSuccess\":false,\"code\":\"0\",\"description\":\"no file！\"}, task: completed\nURLSessionDidSendBodyData: taskId: chillisource.flutter_uploader.upload.background.13, byteSent: 390718, totalBytesSent: 390718, totalBytesExpectedToSend: 390718, progress:100.0\nURLSessionDidReceiveData:\nURLSessionDidCompleteWithError: chillisource.flutter_uploader.upload.background.13 with response: ...\n\nwould you please give some help?","author_login":"tranice","author_association":"NONE","created_at":"2021-10-31T07:11:20+08:00","repo_name":"fluttercommunity/flutter_uploader","issue_id":1040395068,"issue_number":204,"issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/204","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1279658843","fragment_type":"issue_comment","sequence":1,"text":"@tranice what does setting no content-type header means? Can you please tell me what to write? Here is my code:\n\nawait FlutterUploader().enqueue(\n RawUpload(\n url: uploadUrls[i],\n // required: url to upload to\n path: selectedVideos[i].path,\n // required: list of files that you want to upload\n method: UploadMethod.PUT,\n // HTTP method (POST or PUT or PATCH)\n // headers: {\"apikey\": \"api_123456\", \"userkey\": \"userkey_123456\"},\n tag: 'post video uploading', // custom tag which is returned in result/progress\n ),\n );","author_login":"waqadArshad","author_association":"NONE","created_at":"2022-10-15T04:47:14+08:00","repo_name":"fluttercommunity/flutter_uploader","issue_id":1040395068,"issue_number":204,"issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/204","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287397857","fragment_type":"issue_comment","sequence":2,"text":"What content type is the file you are uploading? You need to match it using `Content-Type`.","author_login":"ened","author_association":"COLLABORATOR","created_at":"2022-10-21T20:20:06+08:00","repo_name":"fluttercommunity/flutter_uploader","issue_id":1040395068,"issue_number":204,"issue_url":"https://github.com/fluttercommunity/flutter_uploader/issues/204","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0056","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Add an unauthenticated GetDataHolderBrands endpoint exposed as a public API?","query_context":"# Description\nAs part of the API Uplift for Data Holder Multi-Sector support #424, there are considerations to be made on how the GetDataHolderBrands endpoint can be augmented to allow unauthenticated client access.\n\nThis piece of work has been extracted into its own change request to allow this topic to be considered beyond maintenance iteration 9.\n\n# Area Affected\nRegister APIs will need to be structured to expose GetDataHolderBrands information from a public API\n\n# Change Proposed\n\nThe following changes are proposed:\n\n1. Create a new GetDataHolderBrands endpoint returning the same payload in time for energy\n2. Move this endpoint out of the secure domain, removing MTLS and authentication requirements\n3. Move this endpoint into the public API domain, allowing the API to be accessible via CDN and leverage ETags\n4. Add industry filtering behaviour:\n• Default: All data holder brands will be returned\n• Query parameter filter: allow filtering by industry sector\n5. Remove paging, aligning the response definition to other public APIs\n\n## Options:\n1. Create an unauthenticated Data Holder Brands API returning the same content as the current authenticated API. The authenticated version of the API will be deprecated once a schedule has been determined\n\n2. Create an unauthenticated Data Holder Brands API returning a subset of the content currently returned in the authenticated API. Security endpoint information would NOT be included in this API. Both the authenticated and unauthenticated APIs would be maintained.\n\n## Considerations:\n\n- What are the consequences of making this information available publicly?\n- What are the use cases which will be used from the public and authenticated APIs?","known_context_document_ids":["gh_issue_1067844680"],"reference_answer":"A dependency date was set as 15 November 2022 to align with the Energy release timeframe and considerations to change this date will be discussed further through Issue #507 in Maintenance Iteration 11.\n\nThis change was incorporated into release v1.17.0.\n\nPlease refer to Decision 237 for further details.","answer_document_id":"gh_comment_1138120421","silver_evidence_path":["gh_comment_1107363878","gh_issue_1164638186","gh_comment_1138120421"],"evidence_issue_ids":[1067844680,1164638186],"source_repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","source_issue_id":1067844680,"source_issue_number":444,"source_issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","target_repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","target_issue_id":1164638186,"target_issue_number":488,"target_issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","reference_anchor_document_id":"gh_comment_1107363878","reference_answer_author":"CDR-API-Stream","reference_answer_author_association":"COLLABORATOR","quality_score":93.03,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.09,"anchor_target_overlap":0.069,"target_answer_overlap":0.1818},"issue_created_at":"2021-12-01T01:20:39+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_1067844680","fragment_type":"issue_description","sequence":0,"text":"Add an unauthenticated GetDataHolderBrands endpoint exposed as a public API\n# Description\nAs part of the API Uplift for Data Holder Multi-Sector support #424, there are considerations to be made on how the GetDataHolderBrands endpoint can be augmented to allow unauthenticated client access.\n\nThis piece of work has been extracted into its own change request to allow this topic to be considered beyond maintenance iteration 9.\n\n# Area Affected\nRegister APIs will need to be structured to expose GetDataHolderBrands information from a public API\n\n# Change Proposed\n\nThe following changes are proposed:\n\n1. Create a new GetDataHolderBrands endpoint returning the same payload in time for energy\n2. Move this endpoint out of the secure domain, removing MTLS and authentication requirements\n3. Move this endpoint into the public API domain, allowing the API to be accessible via CDN and leverage ETags\n4. Add industry filtering behaviour:\n• Default: All data holder brands will be returned\n• Query parameter filter: allow filtering by industry sector\n5. Remove paging, aligning the response definition to other public APIs\n\n## Options:\n1. Create an unauthenticated Data Holder Brands API returning the same content as the current authenticated API. The authenticated version of the API will be deprecated once a schedule has been determined\n\n2. Create an unauthenticated Data Holder Brands API returning a subset of the content currently returned in the authenticated API. Security endpoint information would NOT be included in this API. Both the authenticated and unauthenticated APIs would be maintained.\n\n## Considerations:\n\n- What are the consequences of making this information available publicly?\n- What are the use cases which will be used from the public and authenticated APIs?","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2021-12-01T01:20:39+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1071624279","fragment_type":"issue_comment","sequence":1,"text":"During MI #10, it was identified that one of the key use-cases for having a public GetDataHolderBrands API is to allow public clients to discover data holders in the CDR and their respective product reference data, status, and outage endpoints.\n\nOption 2 could be conceivably constrained in scope to target this use case.","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-03-17T22:14:35+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1089617720","fragment_type":"issue_comment","sequence":2,"text":"Thanks for taking the time to assess the issue and develop a proposed solution. Stay or Go is supportive of Option 1 proposed above - i.e. the create a new API, `Get Product Reference Data Endpoints`.\n\nWith regard to the `brandId`, this should be the same as the `dataHolderBrandId` in the existing `Get Data Holder Brands` API.\n\nThis has obviously been a significant gap and oversight for 2-3 years since the PRD endpoints were first implemented in the banking industry, so we request this change be ranked as an absolute priority for implementation Waiting until the end of the year, when Energy is to be implement, is not really acceptable in our mind.","author_login":"af-stayorgo","author_association":"NONE","created_at":"2022-04-06T01:19:35+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091181099","fragment_type":"issue_comment","sequence":3,"text":"Given conversations during the maintenance iteration, the ACCC would like to make it clear that if it is not acceptable for brandId to be optional, this item will need to be delayed until a time that the ACCC can assess a solution where this would be achievable.","author_login":"ACCC-CDR","author_association":"NONE","created_at":"2022-04-07T07:28:09+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091227927","fragment_type":"issue_comment","sequence":4,"text":"With regard to `brandId` and a delay, I think 'delay' and the trade-off needs to be defined. If the API can be delivered within the next month without the brandId, then that would be worth doing. If its going to be delivered in 6 months, then brandId should be in-scope.\n\nIf faced with the above choice, I'd recommend delivering V1 of the API in one month's time without the `brandId` and then add it to the API in 6 months time as V2.\n\nNot having `brandId` does create significant complexity and operational risk for anyone consuming the data, so its not an acceptable long-term solution.\n\nNot having the API at all make the PRD largely unusable, and certainly unreliable.","author_login":"af-stayorgo","author_association":"NONE","created_at":"2022-04-07T07:52:37+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1096075825","fragment_type":"issue_comment","sequence":5,"text":"Collaboration on this issue through maintenance iteration 10, has resulted in the following DSB proposal, expanding off of @ACCC-CDR's initial proposal.\n\nRather than duplicate the GetDataHolderBrands API for unauthenticated clients, a new API optimised for discovery of public data holder APIs (PRD, status, and outage and any future public endpoints) will be defined named: `Get Data Holder Brand Public Endpoints`\n\nThe schema will be optimised for presentation of Data Holder Brands and discovery of associated public endpoints. It will therefore have the following fields:\n\nName | Type | Required | Description\n-- | -- | -- | --\nbrandName | String | true | Name of the data holder brand hosting the public endpoints\nbrandId | String | ~false~ true | ID of the data holder brand hosting the public endpoints\npublicBaseUri | UriString | true | Public endpoints base URL\nlogoUri | UriString | true | Data Holder Brand logo URL\n~industry~ industries | ~String~ [string] | true | The industries the Data Holder Brand belongs to. Please note that the CDR Register entity model is constrained to one industry per brand which is planned to be relaxed in the future.\nlastUpdated | DateTime | true | Time when the record was last updated\nabn | String | false | Australian Business Number for the organisation\nacn | String | false | Australian Company Number for the organisation\narbn | String | false | Australian Registered Body Number. ARBNs are issued to registrable Australian bodies and foreign companies\n\nThe payload will be a shortened version of the data holder brands payload with a flat simplified structure. \n\nThe industries array will follow the same convention as GetDataHolderBrands URL Only one industry will initially be supported until multiple industry sectors per brand are supported on the CDR Register.\n\nDiscussion has occurred on whether the brandId can remain optional until the CDR Register is able to guarantee the field will be populated. The DSB does not seek to define an interim solution in the standards. This leaves the responsibility to the ACCC to coordinate the release of this API based on their release schedules. Any interim solution will also remain the responsibility of the ACCC.","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-04-12T05:25:47+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1104662133","fragment_type":"issue_comment","sequence":6,"text":"Feedback we have received from the ACCC indicates they will not be able to specify a delivery date for the proposed solution and an interim solution will be required. As highlighted from ACCC's feedback, a mandatory `brandId` will not be available in the short to medium term.\n\nFeedback from industry during MI 10 has highlighted that an interim solution that provides a mandatory unique identifier in addition to the `brandId`, would meet the need to reconcile each record until a complete solution can be delivered.\n\nIn order to give the ACCC flexibility in delivering the full solution, provide partial value to API clients, and to simplify reading of the standards, the DSB has decided to propose an interim solution.\n\n## Proposal\n\nBased on the feedback received from stakeholders, the DSB proposed the following:\n\n1. `brandId` moves from mandatory to optional\n2. To enable clients to reconcile data holder brand records from this API with those retrieved in previous requests, an interim identifier (`interimId`) is proposed. This will allow for clients to use the following logic:\na. IF the record includes a `brandId`, use `brandId` as the record identifier ELSE use `interimId` as the record identifier\nb. If in a future request the `brandId` is populated, move the record identifier from `interimId` to `brandId`\n3. For each record, when `brandId` is finally populated, the `interimId` will be maintained for a minimum of 1 month prior to being retired.\n\nThis logic will provide a transition period, allowing clients to migrate records from referencing the `interimId` to the `brandId` in anticipation of `brandId` becoming the mandatory identifier. Once `brandId` becomes the defacto standard identifier, `interimId` can be phased out per record after the transition period of a minimum of 1 month has passed.\n\n \n\n**Interim Solution (V1) - targeted latest dependency date of 01st October 2022**\n_Note that this solution is intended to be a temporary solution until the ACCC is able to deliver the complete solution._\n\nName | Type | Required | X-Conditional | Description\n-- | -- | -- | -- | --\nbrandName | String | true |   | Name of the data holder brand hosting the public endpoints\nbrandId | String | false | true | ID of the data holder brand hosting the public endpoints.  To be used to uniquely identify the record and not to be reused\ninterimId | String | false | true | Interim ID of the data holder brand hosting the public endpoints. This is to be used to uniquely identify the record when brandId is not populated and is not to be reused\npublicBaseUri | UriString | true |   | Public endpoints base URL\nlogoUri | UriString | true |   | Data Holder Brand logo URL\nindustries | [string] | true |   | The industries the Data Holder Brand belongs to. Please note that the CDR Register entity model is constrained to one industry per brand which is planned to be relaxed in the future.\nlastUpdated | DateTime | true |   | Time when the record was last updated\nabn | String | false |   | Australian Business Number for the organisation\nacn | String | false |   | Australian Company Number for the organisation\narbn | String | false |   | Australian Registered Body Number. ARBNs are issued to registrable Australian bodies and foreign companies\n\n \n\n**Complete Solution (V2) - targeted release to be assessed in a future maintenance iteration**\n\nName | Type | Required | Description\n-- | -- | -- | --\nbrandName | String | true | Name of the data holder brand hosting the public endpoints\nbrandId | String | true | ID of the data holder brand hosting the public endpoints.  To be used to uniquely identify the record and not to be reused\npublicBaseUri | UriString | true | Public endpoints base URL\nlogoUri | UriString | true | Data Holder Brand logo URL\nindustries | [string] | true | The industries the Data Holder Brand belongs to. Please note that the CDR Register entity model is constrained to one industry per brand which is planned to be relaxed in the future.\nlastUpdated | DateTime | true | Time when the record was last updated\nabn | String | false | Australian Business Number for the organisation\nacn | String | false | Australian Company Number for the organisation\narbn | String | false | Australian Registered Body Number. ARBNs are issued to registrable Australian bodies and foreign companies","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-04-21T03:14:17+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1104722222","fragment_type":"issue_comment","sequence":7,"text":"This approach look fine. Key to success is to deliver the interim solution quickly. Thanks","author_login":"af-stayorgo","author_association":"NONE","created_at":"2022-04-21T05:25:26+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1105868243","fragment_type":"issue_comment","sequence":8,"text":"The ACCC reiterates it’s previous commentary that if the solution the ACCC has previously proposed is not accepted then we’ll be unable to commit to a 1st of October 2022 delivery date. The ACCC does not support the inclusion of an `interimId` for the same reason it does not support a mandatory `brandId`, the additional solution delivery and operational effort. If the ACCC’s proposed solution cannot be agreed upon, the ACCC suggests deferring this GitHub issue to the next Maintenance Iteration so that the alternative options that the ACCC proposed on the 23rd March can be discussed.","author_login":"ACCC-CDR","author_association":"NONE","created_at":"2022-04-22T00:02:01+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1107363878","fragment_type":"issue_comment","sequence":9,"text":"This sounds a _lot_ like hostage taking by the regulator, perhaps if the ACCC engaged the community earlier it wouldn't be facing timeline issues. October is 6 months away, that's the time accepted by all the other participants in the ecosystem, I find it pretty hypocritical for the ACCC to enforce FDO obligations, request shorter timelines on Participants and then not accept the convention for its own delivery.\n \n\nIs the ACCC _honestly_ suggesting that these records _don't_ already have a database identifier associated with them? If there isn't an identifier already present how else would the ACCC be administering the records? Hand coding them? Smoke signals from some tower in Canberra? I thought the `interimId` proposal was to allow for the id to change which seems to eliminate any architectural reason to oppose it.\n \n\nI was at the last maintenance call and I don't believe ACCC bothered to show up, perhaps it should have. If the ACCC is going to throw its toys out of the pram whenever it doesn't get what it wants then perhaps the Minister should be called in to resolve _who exactly is responsible_ for Register related Standards since it seems increasingly ambiguous. \n\nIt isn't a reasonable nor sustainable solution for non-government technical implementers trying to plan activities based on guidance from multiple government bodies on delivery timelines that are, in the Register case, quite opaque.","author_login":"perlboy","author_association":"NONE","created_at":"2022-04-23T05:12:00+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[1164638186],"is_known_query_context":false},{"document_id":"gh_comment_1107409149","fragment_type":"issue_comment","sequence":10,"text":"Just want to highlight again that this API is already close to 3 years late - i.e. it should have been delivered on 1-Jul-2019 when the first PRD APIs were launched. Waiting another 6 months for this API really isn't an acceptable outcome for the industry or the success of the CDR.\n\nThis is a very simple API and shouldn't take more than a week to build. We therefore request that it be priorities and delivered within the next 4 weeks. Happy to have a conversation with the ACCC (assuming they are responsible for building the API) if technical advice is required.\n\nRegarding the `interimId`, the suggestion above to use the ACCC's existing database identifier makes sense, assuming they have one. If the existing database has been implemented without a unique identifier (e.g. in an Excel spreadsheet), then the ABN should be a sufficient proxy - i.e. a company may rebrand, but they don't normally change their ABN. Otherwise, it would be very simple to add an 'interimId' the the existing database.","author_login":"af-stayorgo","author_association":"NONE","created_at":"2022-04-23T07:20:18+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1140628577","fragment_type":"issue_comment","sequence":11,"text":"To summarise, the contention remained that the `interimId` presented increased complexity for ACCC delivery, conflicting with industry highlighting the urgency of delivery of this API with a mandatory identifier in order to be fit for purpose.\n\nWith this being considered, the DSB’s position remained unchanged as the interim solution shares the implementation burden between the CDR Register and clients until the complete solution is available. No other solution has been proposed which is seen as fit for purpose. The 1 October 2022 delivery date proposed is the latest that this API can be released and provide meaningful value to the CDR. Later delivery will erode the value of this API as industry may look for alternative sources for discovery. Earlier delivery will increase the value of this API as it will increase the period unauthenticated clients are able to leverage its value and increase confidence that the CDR Register is the source of truth in the CDR.\n\n| API Details | |\n| ------------- | ------------- |\n| **API Name** | Get Data Holder Brands Summary |\n| **Path** | `GET /cdr-register/v1/{industry}/data-holders/brands/summary` |\n\nRelease v1.17.0. for the CDS incorporates the interim solution **(V1)** into the standards.\n\nIssue #518 has been raised to track delivery of the Complete Solution **(V2)**\n\nPlease refer to Decision 237 for further details.","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-05-30T02:49:33+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1067844680,"issue_number":444,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1164638186","fragment_type":"issue_description","sequence":0,"text":"Data holder behaviour clarification required when receiving registrations with unsupported authorisation scopes\n# Description\nThe introduction of the energy sector will introduce the following new authorisation scopes to the CDS:\n\n| New Authorisation Scopes for Energy|\n|--|\n| energy:electricity.servicepoints.basic:read |\n| energy:electricity.servicepoints.detail:read |\n| energy:electricity.usage:read |\n| energy:electricity.der:read |\n| energy:accounts.basic:read |\n| energy:accounts.detail:read |\n| energy:accounts.paymentschedule:read |\n| energy:accounts.concessions:read |\n| energy:billing:read |\n\nBanking data holders who do not participate in the energy sector are not going to support energy APIs and the associated authorisation scopes.\n\nClarification is required on how data holders should behave when receiving registration create and update requests where the SSA `scope` field is populated with unsupported scopes.\n\n# Area Affected\nSecurity Profile > Client Registration\n\n# Change Proposed\nThis is not the first time where unsupported scopes have been populated in SSAs. Banking sector phasing resulted in this scenario occurring.\n\nFeedback on this issue needs to be reviewed and considerations made as to whether the standards need to articulate this behaviour","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-03-10T01:37:39+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1068621385","fragment_type":"issue_comment","sequence":1,"text":"For reference, guidance on this issue has previously been provided: URL","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-03-16T01:04:56+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082506554","fragment_type":"issue_comment","sequence":2,"text":"It has been an expectation that Data Holder Brands should ignore unsupported authorisation scopes presented in the SSA for the creation and update of Client Registrations, as reflected in the following guidance: URL \n\nHowever, this hasn't been explicitly called in the standards and there is an opportunity for the standards to clarify this scenario.\n\nThe DSB proposes that the standards are updated to specify that:\n\n_Data Holder Brands should ignore unsupported authorisation scopes presented in the SSA for the creation and update of Client Registrations._\n\nA future dated obligation would align this change with the Energy release timeframe of 15th November 2022.","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-03-30T00:50:10+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097466201","fragment_type":"issue_comment","sequence":3,"text":"ACCC strongly supports the proposed change outlined above and requests an earlier obligation date to support the introduction of Energy. ACCC proposes 15th September 2022 as the future dated obligation, to ensure Data Holders are responding correctly to data requests prior to the implementation of the Energy Sector.","author_login":"ACCC-CDR","author_association":"NONE","created_at":"2022-04-13T01:48:05+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1098701619","fragment_type":"issue_comment","sequence":4,"text":"After incorporating feedback from the community through maintenance iteration 10, the proposal is being updated to move this requirement from a SHOULD to a MUST.\n\nThe DSB now proposes that the standards are updated to specify that:\n\n_Data Holder Brands MUST ignore unsupported authorisation scopes presented in the SSA for the creation and update of Client Registrations._\n\nRegarding changing the FDO to 15th September 2022, further discussion is required to consider having an FDO less the 6 months out. Changes to the FDO will not be considered as part of maintenance iteration 10 however, will be considered for maintenance iteration 11.\n\nThe DSB invites the community to comment on this change","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-04-14T04:36:35+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1123158192","fragment_type":"issue_comment","sequence":5,"text":"Issue #507 has been raised to investigate the opportunity for modifying the FDO date for this piece of work","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-05-11T04:02:22+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1138120421","fragment_type":"issue_comment","sequence":6,"text":"A dependency date was set as 15 November 2022 to align with the Energy release timeframe and considerations to change this date will be discussed further through Issue #507 in Maintenance Iteration 11.\n\nThis change was incorporated into release v1.17.0.\n\nPlease refer to Decision 237 for further details.","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-05-26T03:45:19+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1247439593","fragment_type":"issue_comment","sequence":7,"text":"ForgeRock is seeking clarification. This article URL states that:\n\n\"As described, the DH would allow the request but accept the client registration with the subset of scopes the DH supports per RFC7591\"\n\nHowever, this RFC does not state that subsets of scopes should be supported during Dynamic Client Registration. It states:\n\n\"The semantics of values in this list are service specific. If omitted, an authorization server MAY register a client with a default set of scopes.\"\n\nThis comment appears to indicate that either a precise set of scopes be requested during DCR, or none at all.\n\nRFC7591 does point to RFC6749 [ URL which allows subsets, but as RFC6749 pertains to authorization, not registration, this is seen by ForgeRock as irrelevant.\n\nQuestion\nHas this change proposal been backed by the OAuth2.0 standard? (and could you please point me to the document, or perhaps point out any misunderstanding of the above document/s?) Or has CDR requested a change to the standard to allow vendors to enable our customers to support the approach?","author_login":"SlatsFR","author_association":"NONE","created_at":"2022-09-15T00:40:54+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276923787","fragment_type":"issue_comment","sequence":8,"text":"Hi @SlatsFR, the reference in regards to RFC7591 is towards general dynamic client registration requirements.\n\nThe reason for DHs ignoring unsupported scopes is due the the way the CDR Register operates. It issues the SSA signed using the Register CA cert incorporating all scopes an ADR is accredited for. The way the CDR Rules are expressed it means that once a data recipient is accredited, they are accredited for all sectors and hence all scopes across those sectors: right now that is banking and energy. In future that will include telecommunications etc.\n​\nTo ensure that an ADR can successfully manage their client registration with a DH when they present all scopes (noting that the ADR cannot control which scopes the CDR Register generates for it), the DH needs to facilitate the client registration updates without rejecting the request.\n\nHope that helps.\n​","author_login":"CDR-API-Stream","author_association":"COLLABORATOR","created_at":"2022-10-13T01:53:44+08:00","repo_name":"ConsumerDataStandardsAustralia/standards-maintenance","issue_id":1164638186,"issue_number":488,"issue_url":"https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/488","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0057","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Cannot handle enums with numeric fields?","query_context":"### Expected Behavior\n\nWhen presented with enum with number fields (e.g. `FOO(1)`), it should respect `@JsonValue` and `@JsonCreator` and should compile.\n\n### Actual Behaviour\n\nWhen running the test, compilation fails with\n\n Caused by: com.fasterxml.jackson.databind.JsonMappingException: Cannot deserialize value of type `java.lang.Number` from String \"EdDSA\": not a valid number\n\nThis works fine in micronaut 3.\n\nThe error does not really make sense as the enum should be serialized to a number (based on `@JsonValue`) and never be in the string form. \n\n### Steps To Reproduce\n\n1. Clone URL \n2. Run the test and see compilation fail with the above error (it does not even get to running the test)\n3. Adjust the HelloController to use COSEAlgorithmIdentifier2 (with 2 suffix). This uses `@JsonProperty` instead\n4. Re-run the test and see it pass\n\nRaising this in micronaut repo, as the same enum class serializes and deserializes fine with jackson by itself.\n\n### Environment Information\n\n- OSX\n- JDK 21\n- Micronaut 4.0.0 -> 4.7.6\n\n### Example Application\n\n URL \n\n### Version\n\n4.7.6","known_context_document_ids":["gh_issue_2865142438"],"reference_answer":"The problem is here: URL \n\nOpenApi calls `.values()` to get the values of the enum. This calls (for Java) the following in core URL \n\nThe problem is that inside that code (even if we copy it to the openapi module) we don't have access to any bean metadata that Micronaut produces. All the `Element`s in the stream are javax elements and not Micronaut. I don't see a way to check if those element have the appropriate annotation to generate the right value instead of the `toString()` that it's done at this moment.\n\n@graemerocher any thoughts if there is a way to do this?","answer_document_id":"gh_comment_1019896924","silver_evidence_path":["gh_comment_2670539764","gh_issue_812077811","gh_comment_1019896924"],"evidence_issue_ids":[2865142438,812077811],"source_repo_name":"micronaut-projects/micronaut-openapi","source_issue_id":2865142438,"source_issue_number":1996,"source_issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","target_repo_name":"micronaut-projects/micronaut-openapi","target_issue_id":812077811,"target_issue_number":471,"target_issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","reference_anchor_document_id":"gh_comment_2670539764","reference_answer_author":"ilopmar","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2353,"anchor_target_overlap":0.1176,"target_answer_overlap":0.1951},"issue_created_at":"2025-02-20T05:45:52+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2865142438","fragment_type":"issue_description","sequence":0,"text":"Cannot handle enums with numeric fields\n### Expected Behavior\n\nWhen presented with enum with number fields (e.g. `FOO(1)`), it should respect `@JsonValue` and `@JsonCreator` and should compile.\n\n### Actual Behaviour\n\nWhen running the test, compilation fails with\n\n Caused by: com.fasterxml.jackson.databind.JsonMappingException: Cannot deserialize value of type `java.lang.Number` from String \"EdDSA\": not a valid number\n\nThis works fine in micronaut 3.\n\nThe error does not really make sense as the enum should be serialized to a number (based on `@JsonValue`) and never be in the string form. \n\n### Steps To Reproduce\n\n1. Clone URL \n2. Run the test and see compilation fail with the above error (it does not even get to running the test)\n3. Adjust the HelloController to use COSEAlgorithmIdentifier2 (with 2 suffix). This uses `@JsonProperty` instead\n4. Re-run the test and see it pass\n\nRaising this in micronaut repo, as the same enum class serializes and deserializes fine with jackson by itself.\n\n### Environment Information\n\n- OSX\n- JDK 21\n- Micronaut 4.0.0 -> 4.7.6\n\n### Example Application\n\n URL \n\n### Version\n\n4.7.6","author_login":"gnarroway-bullish","author_association":"NONE","created_at":"2025-02-20T05:45:52+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2670539764","fragment_type":"issue_comment","sequence":1,"text":"From URL it appears that maybe `@JsonValue` is not really supported. If that is still the case, it would be good to at least be able to compile (like in micronaut 3), rather than blow up.","author_login":"gnarroway-bullish","author_association":"NONE","created_at":"2025-02-20T06:00:08+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[812077811],"is_known_query_context":false},{"document_id":"gh_comment_2670623981","fragment_type":"issue_comment","sequence":2,"text":"Unfortunately, this is a limitation of the annotation processor. You see, the annotation processor does not see your code and cannot execute it, it only sees the class structure. Therefore, all I can see is a method or field that is marked as JsonValue , but I cannot uniquely calculate the values ​​that correspond to enums.\n\nFor example, if a method is marked as JsonValue , then it is not necessarily a simple getter, there may be other logic, but I cannot see it in the annotation processor.\n\nSimilarly, with a field marked as JsonValue - the enum field does not necessarily correspond to the argument of the enum constructor, it may well be transformed in the constructor.\n\nMoreover, the annotation processor does NOT see the values ​​that you describe in the enum constructor. For example yuor example:\n\njava\npublic enum COSEAlgorithmIdentifier {\n EdDSA(-8),\n RS1(-65535);\n...\n}\n\nmicronaut openapi doesn't see values `-8` and `-65535`, because it is a code. Annotation processor can see only annotations and values inside annotaions.\n\nThe single way to work with it - add annotaion for every enum constant:\n\njava\npublic enum COSEAlgorithmIdentifier {\n @JsonProperty(\"-8\")\n EdDSA(-8),\n @JsonProperty(\"-65535\")\n RS1(-65535);\n...\n}","author_login":"altro3","author_association":"COLLABORATOR","created_at":"2025-02-20T07:00:07+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2670671655","fragment_type":"issue_comment","sequence":3,"text":"I see. Is there any reason why it would not crash in micronaut 3 then? \n\nGiven the enum class is from an external depenendency not directly in my control, do you have any suggested workaround that doesn't involve maintaining a copy of the class in my own code base?","author_login":"gnarroway-bullish","author_association":"NONE","created_at":"2025-02-20T07:27:59+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2670692289","fragment_type":"issue_comment","sequence":4,"text":"I can't tell you, but this is not a micronaut-openapi problem. This annotation processor is only used to generate the OpenAPI spec for your code and does not play any role in the actual operation of the application, so you should create an issue in micronaut core , not here.","author_login":"altro3","author_association":"COLLABORATOR","created_at":"2025-02-20T07:40:10+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2671509736","fragment_type":"issue_comment","sequence":5,"text":"Please, create an issue in micronaut-core module ( URL because micronaut-openapi just create openapi.yml file","author_login":"altro3","author_association":"COLLABORATOR","created_at":"2025-02-20T13:30:43+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2676696749","fragment_type":"issue_comment","sequence":6,"text":"@gnarroway-bullish fixed it here: URL \n\nSo, the problem is that micronaut openapi determined the type of your enum correctly, analyzing the method with the annotation `@JsonValue` - the type was integer .\n\nBut because you did not put the annotation JsonProperty , an incorrect schema was obtained with the type integer , but the values ​​of the enum `EdDSA` and `RS1`\n\nSerialization and deserialization occurred inside, due to which the values ​​of `EdDSA` and `RS1` tried to be converted as numbers, because the type of the schema is integer .\n\nIn general, I made it so that now information about the annotation JsonProperty will be written in the console and the enum type will be set as string . Thus, there will be no error, there will be a message that there is not enough information to correctly construct the enum schema","author_login":"altro3","author_association":"COLLABORATOR","created_at":"2025-02-23T08:12:01+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2680246938","fragment_type":"issue_comment","sequence":7,"text":"thank you @altro3 , and really appreciate the responsiveness","author_login":"gnarroway-bullish","author_association":"NONE","created_at":"2025-02-25T02:35:42+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":2865142438,"issue_number":1996,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/1996","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_812077811","fragment_type":"issue_description","sequence":0,"text":"JsonProperty not getting picked up by yaml generation for Enum\n### Task List\n\n- [ X ] Steps to reproduce provided\n- [ N/A] Stacktrace (if present) provided\n- [ N/A] Example that reproduces the problem uploaded to Github\n- [ X ] Full description of the issue provided (see below)\n\n### Steps to Reproduce\n\n1. Create Java Enum Class with JsonProperty\n\nimport com.fasterxml.jackson.annotation.JsonProperty;\n\npublic enum CurrencyPair2 {\n @JsonProperty(\"CAD-USD\") CADUSD(\"CAD\", \"USD\");\n private final String baseCurrency;\n private final String quoteCurrency;\n\n CurrencyPair2(String baseCurrency, String quoteCurrency) {\n this.baseCurrency = baseCurrency;\n this.quoteCurrency = quoteCurrency;\n }\n\n public String getBaseCurrency() {\n return baseCurrency;\n }\n\n public String getQuoteCurrency() {\n return quoteCurrency;\n }\n\n}\n\n2. Reference class in response object/request params\n3. Build OpenApi:\n\nannotationProcessor(\"io.micronaut.openapi:micronaut-openapi\")\n...\nimplementation(\"io.swagger.core.v3:swagger-annotations:2.1.6\")\n...\n\ntasks.withType(JavaCompile) {\n options.fork = true\n options.forkOptions.jvmArgs << '-Dmicronaut.openapi.views.spec=rapidoc.enabled=true,swagger-ui.enabled=true,swagger-ui.theme=flattop'\n}\n\n4. Check Swagger output\n\n### Expected Behaviour\n\nEnum values should be CAD-USD and serialization should convert appropriately\n\nCurrencyPair2:\n type: string\n enum:\n - CAD-USD\n\n### Actual Behaviour\nSerialization converts on ingress and egress appropriately but enum values are CADUSD in the swagger schema\n\nCurrencyPair2:\n type: string\n enum:\n - CADUSD\n\nTell us what happens instead\n\n### Environment Information\n\n- **Operating System**: MavOS Mojave version 10.14.6 \n- **Micronaut Version:** 1.3.4\n- **JDK Version:** \n- OPENAPI_VERSION=2.0.10\n\n### Example Application\n\n- TODO: link to github repository with example that reproduces the issue","author_login":"ccorcoran-nydig","author_association":"NONE","created_at":"2021-02-19T14:41:36+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019896924","fragment_type":"issue_comment","sequence":1,"text":"The problem is here: URL \n\nOpenApi calls `.values()` to get the values of the enum. This calls (for Java) the following in core URL \n\nThe problem is that inside that code (even if we copy it to the openapi module) we don't have access to any bean metadata that Micronaut produces. All the `Element`s in the stream are javax elements and not Micronaut. I don't see a way to check if those element have the appropriate annotation to generate the right value instead of the `toString()` that it's done at this moment.\n\n@graemerocher any thoughts if there is a way to do this?","author_login":"ilopmar","author_association":"MEMBER","created_at":"2022-01-24T09:34:30+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141407477","fragment_type":"issue_comment","sequence":2,"text":"@ccorcoran-nydig Hi! I added the ability to view annotations on enum constants - URL . But this feature will appear only in release `3.6.0`. After that, it will be possible to implement this feature","author_login":"altro3","author_association":"CONTRIBUTOR","created_at":"2022-05-30T18:40:14+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1212104507","fragment_type":"issue_comment","sequence":3,"text":"@altro3 Any plans to add support for `@JsonValue` annotation?","author_login":"daltonconley","author_association":"NONE","created_at":"2022-08-11T14:56:15+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1212881561","fragment_type":"issue_comment","sequence":4,"text":"@altro3 Hi! I thought about it, but could not come up with a normal solution to support this annotation. Watch how the library works: the analyzer parses the structure of classes and enums, and can read the annotations that are used there.\n\nSo, the problem is: in order to support JsonValue, you need to call the method, i.e. run certain logic to understand what value will be the result.\n\nIn general, I'm just not sure that such logic is possible in this library. :-(","author_login":"altro3","author_association":"CONTRIBUTOR","created_at":"2022-08-12T08:51:15+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1212881900","fragment_type":"issue_comment","sequence":5,"text":"@daltonconley Hi! I thought about it, but could not come up with a normal solution to support this annotation. Watch how the library works: the analyzer parses the structure of classes and enums, and can read the annotations that are used there.\n\nSo, the problem is: in order to support JsonValue, you need to call the method, i.e. run certain logic to understand what value will be the result.\n\nIn general, I'm just not sure that such logic is possible in this library. :-(","author_login":"altro3","author_association":"CONTRIBUTOR","created_at":"2022-08-12T08:51:39+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1221550896","fragment_type":"issue_comment","sequence":6,"text":"@daltonconley I have good news for you. I implemented JsonValue annotation support :-). We are waiting for the merge of my changes and the new release (see URL","author_login":"altro3","author_association":"CONTRIBUTOR","created_at":"2022-08-21T13:53:06+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1227347793","fragment_type":"issue_comment","sequence":7,"text":"@altro3 Was pleased to see the above PR as I have a similar issue with @JsonValue which I expected would be fixed with your latest commit. I've built 4.5.0-SNAPSHOT from your PR and updated the dependency of my minimal recreation project locally and there's some improvement as it seems to obey the @JsonProperty annotation but still doesn't work for me with @JsonValue.\n\nInterestingly I now get the warning:\n\nNote: Generating OpenAPI Documentation\n{path omitted}.../swagger-enum-gen/src/main/java/com/example/ResponseEnum.java:8: warning: Can't find enum class com.example.ResponseEnum\n\nwhen running, but it still outputs the yaml with the Enum names (and one JsonProperty value). \n\nThe checked in bug recreation project above is still on the default dependencies rather than on your snapshot version. Please shout if I can be of any assistance. Thanks very much for your efforts!","author_login":"dclarke18","author_association":"NONE","created_at":"2022-08-25T14:35:44+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1229494378","fragment_type":"issue_comment","sequence":8,"text":"@dclarke18 @daltonconley I also tested this functionality. Well, unfortunately this functionality cannot be done in any way. I rolled back my changes because my solution only works at the testing level. The problem lies in the limitations of Java itself. Java, when executing annotation processors, does not load classes from the main classpath and does not provide access to the source codes of these classes. Those. the annotation processor only accesses the structure of the classes, but cannot call methods from these classes or read the method bodies in any way. So the only solution for enums is to put a JsonProperty annotation on each enum value.\n\nProcessing JsonValue at the annotation processor level is impossible to do :-(","author_login":"altro3","author_association":"CONTRIBUTOR","created_at":"2022-08-28T16:01:41+08:00","repo_name":"micronaut-projects/micronaut-openapi","issue_id":812077811,"issue_number":471,"issue_url":"https://github.com/micronaut-projects/micronaut-openapi/issues/471","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0058","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Deno add - \"Failed to install from package.json\" \"Unexpected character.\"?","query_context":"Version: Deno 2.0.4\n\n$ deno add npm:debug\nAdd npm:debug@4.3.7\nerror: Failed to install from package.json\n\nCaused by:\n 0: Invalid version requirement\n 1: Unexpected character.\n ^\n ~\n$ cat deno.json\n{\n \"name\": \"...\",\n \"description\": \"...\",\n \"version\": \"3.0.0-alpha.5\",\n \"exports\": \"./src/index.ts\",\n \"tasks\": {\n \"build\": \"deno run --allow-read --allow-write scripts/export-json-schema.ts\",\n \"coverage\": \"deno coverage | deno run jsr:@silverbucket/threshold 100 88\",\n \"test\": \"deno test --coverage --clean --allow-env src/**/*.test.ts\"\n },\n \"imports\": {\n \"@silverbucket/threshold\": \"jsr:@silverbucket/threshold@1.0.2\",\n \"@types/node\": \"npm:@types/node@22.5.0\",\n \"@types/debug\": \"npm:@types/debug@4.1.12\",\n \"ajv\": \"npm:ajv@8.12.0\",\n \"ajv-formats\": \"npm:ajv-formats@2.1.1\",\n \"@silverbucket/ajv-formats-draft2019\": \"jsr:@silverbucket/ajv-formats-draft2019@1.6.1\",\n \"debug\": \"npm:debug@4.3.7\"\n }\n}","known_context_document_ids":["gh_issue_2625657914"],"reference_answer":"It looks good, but I think we probably dont' need any changes in deno_semver. Probably it could just be handled in deno_package_json (I'm not sure though)","answer_document_id":"gh_comment_2484503489","silver_evidence_path":["gh_comment_2541975358","gh_issue_2634017203","gh_comment_2484503489"],"evidence_issue_ids":[2625657914,2634017203],"source_repo_name":"denoland/deno","source_issue_id":2625657914,"source_issue_number":26653,"source_issue_url":"https://github.com/denoland/deno/issues/26653","target_repo_name":"denoland/deno","target_issue_id":2634017203,"target_issue_number":26726,"target_issue_url":"https://github.com/denoland/deno/issues/26726","reference_anchor_document_id":"gh_comment_2541975358","reference_answer_author":"dsherret","reference_answer_author_association":"MEMBER","quality_score":82.05,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0256,"anchor_target_overlap":0.2258,"target_answer_overlap":0.1538},"issue_created_at":"2024-10-31T00:32:30+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2625657914","fragment_type":"issue_description","sequence":0,"text":"Deno add - \"Failed to install from package.json\" \"Unexpected character.\"\nVersion: Deno 2.0.4\n\n$ deno add npm:debug\nAdd npm:debug@4.3.7\nerror: Failed to install from package.json\n\nCaused by:\n 0: Invalid version requirement\n 1: Unexpected character.\n ^\n ~\n$ cat deno.json\n{\n \"name\": \"...\",\n \"description\": \"...\",\n \"version\": \"3.0.0-alpha.5\",\n \"exports\": \"./src/index.ts\",\n \"tasks\": {\n \"build\": \"deno run --allow-read --allow-write scripts/export-json-schema.ts\",\n \"coverage\": \"deno coverage | deno run jsr:@silverbucket/threshold 100 88\",\n \"test\": \"deno test --coverage --clean --allow-env src/**/*.test.ts\"\n },\n \"imports\": {\n \"@silverbucket/threshold\": \"jsr:@silverbucket/threshold@1.0.2\",\n \"@types/node\": \"npm:@types/node@22.5.0\",\n \"@types/debug\": \"npm:@types/debug@4.1.12\",\n \"ajv\": \"npm:ajv@8.12.0\",\n \"ajv-formats\": \"npm:ajv-formats@2.1.1\",\n \"@silverbucket/ajv-formats-draft2019\": \"jsr:@silverbucket/ajv-formats-draft2019@1.6.1\",\n \"debug\": \"npm:debug@4.3.7\"\n }\n}","author_login":"silverbucket","author_association":"NONE","created_at":"2024-10-31T00:32:30+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2449705332","fragment_type":"issue_comment","sequence":1,"text":"I tried reproducing the problem and with provided `deno.json` and running `deno add npm:debug` I don't get any error. @silverbucket could you please provide more information about your project?","author_login":"bartlomieju","author_association":"MEMBER","created_at":"2024-10-31T12:14:34+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2449773350","fragment_type":"issue_comment","sequence":2,"text":"@bartlomieju Sure what would you like to see? To answer your question, there is no package.json.\n\nbash\n$ ls -al\ntotal 40\ndrwxr-xr-x@ 9 njenning staff 288 Oct 31 01:26 .\ndrwxr-xr-x@ 15 njenning staff 480 Aug 26 23:06 ..\n-rw-r--r--@ 1 njenning staff 1077 Aug 26 23:06 LICENSE\n-rw-r--r--@ 1 njenning staff 271 Aug 29 14:54 README.md\ndrwxr-xr-x@ 2 njenning staff 64 Oct 31 01:24 coverage\n-rw-r--r--@ 1 njenning staff 823 Oct 31 01:26 deno.json\n-rw-r--r--@ 1 njenning staff 5814 Aug 27 17:53 deno.lock\ndrwxr-xr-x@ 4 njenning staff 128 Aug 27 17:44 scripts\ndrwxr-xr-x@ 12 njenning staff 384 Oct 31 01:23 src\n\n$ deno add npm:debug\nAdd npm:debug@4.3.7\nerror: Failed to install from package.json\n\nCaused by:\n 0: Invalid version requirement\n 1: Unexpected character.\n ^\n ~\n\nIt might be worth mentioning that this is a mono-repo, however I've never had issues converting packages one at a time with deno 1.45, it was only upgrading to 2.0.x that I started getting issues like this.","author_login":"silverbucket","author_association":"NONE","created_at":"2024-10-31T12:52:24+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2449885152","fragment_type":"issue_comment","sequence":3,"text":"We should improve this error message to say the file the error occurs in. Probably there's a package.json in the workspace in this case.","author_login":"dsherret","author_association":"MEMBER","created_at":"2024-10-31T13:47:19+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466963639","fragment_type":"issue_comment","sequence":4,"text":"Using deno `2.0.6` I'm getting another variation of this bug. Same repo I mentioned about, this time it's not with the `package.json` at the root of the repository, but a different pacakge at the same level as the `schemas` package.\n\nbash\nproject-root/packages/schemas $ deno install\nerror: Failed to install '@sockethub/client'\n at file:///project-root/packages/examples/package.json\n\nCaused by:\n 0: Invalid version requirement\n 1: Unexpected character.\n ^\n ~","author_login":"silverbucket","author_association":"NONE","created_at":"2024-11-10T22:33:48+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2470266837","fragment_type":"issue_comment","sequence":5,"text":"@nathanwhit Should I create a new ticket? Or can you re-open this one?","author_login":"silverbucket","author_association":"NONE","created_at":"2024-11-12T11:19:59+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2477571808","fragment_type":"issue_comment","sequence":6,"text":"Hmm we're putting the dependency in the correct file now, but we error out because we validate all of the `package.json` files in the workspace when we cache the dependencies, and one of them has a version requirement (`workspace:^`) that we don't support.\n\nI feel like maybe we should make `workspace:^` not a hard error? Or at least not a parsing error","author_login":"nathanwhit","author_association":"MEMBER","created_at":"2024-11-14T22:55:12+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541940014","fragment_type":"issue_comment","sequence":7,"text":"Hey, Im facing a similar issue when upgrading from v1.146 to v2.\n\nWe have a backend monorepo and it uses `import_map.json` files to manage dependencies per sub module in our monorepo. We don't have a package.json (except our Next.js frontend which is still on node). we do have a deno.jsonc at the root level of our project. After upgrading Deno, we get these errors when we run or try to install:\n\nsh\n# install\nerror: Error in @stripe/react-stripe-js@3.1.0 parsing version requirement for dependency \"react-dom\": \">=16.8.0 && <=^19.0.0\"\ndeno install\nCaused by:\n 0: Invalid version requirement\n 1: Unexpected character.\n \n ~\n\nsh\n# run\nRunning service\nWatcher Process started.\nerror: Could not find a matching package for 'npm:pg@8.12.0' in the node_modules directory. Ensure you have all your JSR and npm dependencies listed in your deno.json or package.json, then run `deno install`. Alternatively, turn on auto-install by specifying `\"nodeModulesDir\": \"auto\"` in your deno.json file.\n\nWatcher Process started.\nerror: [ERR_MODULE_NOT_FOUND] Cannot find module 'file:///Users/app/node_modules/type-fest/index.js' imported from 'file:///Users/app/@types/date.types.ts'\n at file:///Users/app/@types/date.types.ts:8:24\n\nthis is part of our import_map.json file:\n\njson\n{\n \"imports\": {\n \"kysely\": \" URL \n \"pg\": \"npm:pg@8.12.0\",\n \"query-string\": \" URL \n \"remeda\": \" URL \n \"stripe\": \" URL \n \"type-fest\": \"npm:type-fest@4.30.1\",\n \"zod\": \" URL \n }\n}","author_login":"bombillazo","author_association":"NONE","created_at":"2024-12-13T17:39:40+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541975358","fragment_type":"issue_comment","sequence":8,"text":"\"react-dom\": \">=16.8.0 && <=^19.0.0\"\n\nimage\n\nThis doesn't work the way they probably think.\n\n \nundefined\n \ntrue\n\nI opened URL \n\nA huge problem in npm dependencies is npm allows people to just put whatever even when it doesn't make sense. I'll update deno_semver to handle that situation. Follow URL for updates\n\nI think though the original issue can now be closed because workspace specifiers like `workspace:^` are now implemented URL","author_login":"dsherret","author_association":"MEMBER","created_at":"2024-12-13T17:59:12+08:00","repo_name":"denoland/deno","issue_id":2625657914,"issue_number":26653,"issue_url":"https://github.com/denoland/deno/issues/26653","linked_issue_ids":[2634017203],"is_known_query_context":false},{"document_id":"gh_issue_2634017203","fragment_type":"issue_description","sequence":0,"text":"Support other `workspace:` specifiers\nCurrently Deno supports `workspace:*` specifiers in `package.json`, but tools like pnpm also support\n`workspace:^`, `workspace:~` and others.\n\nSee URL \n\nNecessary changes would need to be applied around this code:\n URL","author_login":"bartlomieju","author_association":"MEMBER","created_at":"2024-11-04T22:46:51+08:00","repo_name":"denoland/deno","issue_id":2634017203,"issue_number":26726,"issue_url":"https://github.com/denoland/deno/issues/26726","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480586244","fragment_type":"issue_comment","sequence":1,"text":"I did some digging into this and here's what I found:\n1. Handling of `workspace:` specifiers in `package.json` is done here: URL \n2. The `workspace:` prefix is stripped and the remainder is passed to `VersionReq::parse_from_npm` from `deno_semver`: URL \n3. `*` or `x.y.z` are valid ranges in this context, but `~` and `^` are not\n4. It appears that simply stripping `workspace:` is not good enough here and we should have a dedicated functionality in `deno_semver` to handle `workspace:` version constraints that will accept `~` and `^`, otherwise we'd have to alter the current parsing which would break other stuff, because `\"mypackage\": \"^\"` is not a valid range, but `\"mypackage\": \"workspace:^\"` is.\n\n@dsherret do you agree here?","author_login":"bartlomieju","author_association":"MEMBER","created_at":"2024-11-16T14:07:53+08:00","repo_name":"denoland/deno","issue_id":2634017203,"issue_number":26726,"issue_url":"https://github.com/denoland/deno/issues/26726","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2484503489","fragment_type":"issue_comment","sequence":2,"text":"It looks good, but I think we probably dont' need any changes in deno_semver. Probably it could just be handled in deno_package_json (I'm not sure though)","author_login":"dsherret","author_association":"MEMBER","created_at":"2024-11-19T01:14:31+08:00","repo_name":"denoland/deno","issue_id":2634017203,"issue_number":26726,"issue_url":"https://github.com/denoland/deno/issues/26726","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0059","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Evaluate DAG versioning & bundles with a Airflow 3 pre-release?","query_context":"**What we want to do**\n\nEvaluate how DAG Bundles and DAG versioning are behaving with Cosmos.\n\nTry out Airflow 3.0 with Cosmos example DAGs:\n\nCOMMIT_SHA=573cd95 AIRFLOW_HOME=$(pwd) uvx \\\n --python 3.11 \\\n --from \"git+ URL \\\n --with \"git+ URL \\\n --with \"git+ URL \\\n bash -c \"\n cd \\$(python -c 'import airflow, os; print(os.path.dirname(airflow.__file__))') && \\\n # Build the new UI (located in the 'ui' directory)\n cd ui && pnpm install && pnpm build && \\\n # Build the legacy UI (located in the 'www' directory)\n cd ../www && yarn install --frozen-lockfile && yarn run build && \\\n airflow standalone\n \"\n\nSee the UI working in:\n URL \n URL \n\nFocus on the work of these AIPs:\n* AIP-63: DAG Versioning\n* AIP-66: DAG Bundles & Parsing\n\n**Acceptance criteria**\n\n* [ ] Document which Airflow/Cosmos version was tested\n* [ ] Raise any concerns and problems faced with @jedcunningham and team\n* [ ] Have an action plan","known_context_document_ids":["gh_issue_2809003806"],"reference_answer":"Create a PR isolating changes and add conditionals so we can all work using this same code base","answer_document_id":"gh_comment_2748459590","silver_evidence_path":["gh_comment_2733210868","gh_issue_2928438849","gh_comment_2748459590"],"evidence_issue_ids":[2809003806,2928438849],"source_repo_name":"astronomer/astronomer-cosmos","source_issue_id":2809003806,"source_issue_number":1488,"source_issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","target_repo_name":"astronomer/astronomer-cosmos","target_issue_id":2928438849,"target_issue_number":1621,"target_issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1621","reference_anchor_document_id":"gh_comment_2733210868","reference_answer_author":"tatiana","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2273,"anchor_target_overlap":0.3182,"target_answer_overlap":0.0},"issue_created_at":"2025-01-24T09:48:33+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2809003806","fragment_type":"issue_description","sequence":0,"text":"Evaluate DAG versioning & bundles with a Airflow 3 pre-release\n**What we want to do**\n\nEvaluate how DAG Bundles and DAG versioning are behaving with Cosmos.\n\nTry out Airflow 3.0 with Cosmos example DAGs:\n\nCOMMIT_SHA=573cd95 AIRFLOW_HOME=$(pwd) uvx \\\n --python 3.11 \\\n --from \"git+ URL \\\n --with \"git+ URL \\\n --with \"git+ URL \\\n bash -c \"\n cd \\$(python -c 'import airflow, os; print(os.path.dirname(airflow.__file__))') && \\\n # Build the new UI (located in the 'ui' directory)\n cd ui && pnpm install && pnpm build && \\\n # Build the legacy UI (located in the 'www' directory)\n cd ../www && yarn install --frozen-lockfile && yarn run build && \\\n airflow standalone\n \"\n\nSee the UI working in:\n URL \n URL \n\nFocus on the work of these AIPs:\n* AIP-63: DAG Versioning\n* AIP-66: DAG Bundles & Parsing\n\n**Acceptance criteria**\n\n* [ ] Document which Airflow/Cosmos version was tested\n* [ ] Raise any concerns and problems faced with @jedcunningham and team\n* [ ] Have an action plan","author_login":"tatiana","author_association":"COLLABORATOR","created_at":"2025-01-24T09:48:33+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2615393130","fragment_type":"issue_comment","sequence":1,"text":"@phanikumv suggested we try this with the nightly image. We can check with Rahul","author_login":"tatiana","author_association":"COLLABORATOR","created_at":"2025-01-27T10:38:07+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2619201016","fragment_type":"issue_comment","sequence":2,"text":"Tables of interest:\n- dag_run:\n- dag_version:\n- serialized_dag:\n- dag_code:\n\n1. Run Cosmos DAG - v X\n2. Without changing Cosmos DAG, re-run v X\n3. Change Cosmos python code, re-run v Y\n4. Change dbt project, re-run, v Z\n\nWe need to use a version backend. We need to use the Git Repo\n\nTODO:\n- add diagram\n- add reference on GitRepo\n\nThis is expected to work with local executors only.\n\nThis is likely not expected to run using DAG test.","author_login":"tatiana","author_association":"COLLABORATOR","created_at":"2025-01-28T14:42:46+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2650948610","fragment_type":"issue_comment","sequence":3,"text":"I spoke to @jedcunningham, and he suggested we try out the alpha, since this has been released since we first wrote this ticket - it would make our lives easier. He'll share the info with us","author_login":"tatiana","author_association":"COLLABORATOR","created_at":"2025-02-11T14:14:09+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2733210868","fragment_type":"issue_comment","sequence":4,"text":"We have an Airflow standalone local setup for AF3 beta2, and we are experiencing issues even in loading individual cosmos tasks, for instance, `DbtCloneLocalOperator`. So, we are removing this issue from the scope of the current sprint and will work on URL and URL","author_login":"pankajastro","author_association":"CONTRIBUTOR","created_at":"2025-03-18T13:23:49+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[2928438849],"is_known_query_context":false},{"document_id":"gh_comment_2851666680","fragment_type":"issue_comment","sequence":5,"text":"Tested some basic cases\n\nKeeping the dbt Project Outside the DAG Folder:\n\n- Modifying the DAG file updates the DAG version.\n- Changes made to the dbt project do not impact the DAG version.\n\nKeeping the dbt Project Inside the DAG Folder:\n\n- Modifying the DAG file updates the DAG version.\n- Changes made to the dbt project do not affect the DAG version.\n\nThis is what we were expecting. I’ll do a deeper analysis further.","author_login":"pankajastro","author_association":"CONTRIBUTOR","created_at":"2025-05-05T17:06:09+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2851826350","fragment_type":"issue_comment","sequence":6,"text":"I tested the DAG below, which is independent of Cosmos, and found that changing the content in the Python file /usr/local/airflow/dags/hello.py does not update the DAG version.\n\npython\nfrom airflow.providers.standard.operators.bash import BashOperator\nimport datetime\nfrom airflow.sdk import DAG\nimport pendulum\n\nwith DAG(\n dag_id=\"example_bash_operator\",\n schedule=\"0 0 * * *\",\n start_date=pendulum.datetime(2021, 1, 1, tz=\"UTC\"),\n catchup=False,\n dagrun_timeout=datetime.timedelta(minutes=60),\n tags=[\"example\", \"example2\"],\n params={\"example_key\": \"example_value\"},\n) as dag:\n run_this = BashOperator(\n task_id=\"run_after_loop\",\n bash_command=\"python /usr/local/airflow/dags/hello.py\",\n )","author_login":"pankajastro","author_association":"CONTRIBUTOR","created_at":"2025-05-05T17:40:42+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2871603928","fragment_type":"issue_comment","sequence":7,"text":"I'm trying to understand how we decide if the DAG version needs to be updated: \nReaching out team here for the same: URL","author_login":"pankajastro","author_association":"CONTRIBUTOR","created_at":"2025-05-12T08:55:10+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2900357627","fragment_type":"issue_comment","sequence":8,"text":"It seems there's a bug in the DAG bundle; I've reported the issue here: URL","author_login":"pankajastro","author_association":"CONTRIBUTOR","created_at":"2025-05-22T08:28:51+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2809003806,"issue_number":1488,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2928438849","fragment_type":"issue_description","sequence":0,"text":"Be able to parse and run a DAG containing one Cosmos Local operator in Airflow 3\n**Context**\n\nWe are facing several issues when attempting to run Cosmos with Airflow 3. To advance, we're reducing the scope of the problem so we can iterate quicker.\n\nOnce #1620 is completed, we want to run in Airflow 3 a simple DAG built with parts of Cosmos using the following configuration:\n\n* `RenderConfig` should use `LoadMode.DBT_MANIFEST`\n* `ProfileConfig` with Profile YAML\n\nExample:\n\nimport os\nfrom datetime import datetime\nfrom pathlib import Path\nfrom typing import Any\n\nfrom airflow import DAG\n\nfrom cosmos.config import ProfileConfig\nfrom cosmos.operators.local import DbtCloneLocalOperator\n\nDEFAULT_DBT_ROOT_PATH = Path(__file__).parent / \"dbt\"\nDBT_ROOT_PATH = Path(os.getenv(\"DBT_ROOT_PATH\", DEFAULT_DBT_ROOT_PATH))\nDBT_PROJ_DIR = Path(\"/Users/pankaj/Documents/astro_code/airflow3_dev/jaffle_shop\")\nDBT_PROFILE_PATH = DBT_PROJ_DIR / \"profiles.yml\"\nDBT_ARTIFACT = DBT_PROJ_DIR / \"target\"\n\nprofile_config = ProfileConfig(\n profile_name=\"default\",\n target_name=\"dev\",\n profiles_yml_filepath=DBT_PROFILE_PATH,\n)\n\nwith DAG(\"example_operators\", start_date=datetime(2024, 1, 1), catchup=False) as dag:\n clone_operator = DbtCloneLocalOperator(\n profile_config=profile_config,\n project_dir=DBT_PROJ_DIR,\n task_id=\"clone\",\n dbt_cmd_flags=[\"--models\", \"stg_customers\", \"--state\", DBT_ARTIFACT],\n install_deps=True,\n append_env=True,\n )\n\n clone_operator\n\n**Acceptance criteria**\n\n* [ ] Any developer should be able to run this DAG, so we should not have hard-coded path values\n* [ ] The DAG should be parsed without errors\n* [ ] The dbt clone command should be run without errors","author_login":"tatiana","author_association":"COLLABORATOR","created_at":"2025-03-18T13:02:51+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2928438849,"issue_number":1621,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1621","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748263414","fragment_type":"issue_comment","sequence":1,"text":"The DAG parsing is working on the branch: URL \n\nI'm able to run DAG \n\nimport os\nfrom datetime import datetime\nfrom pathlib import Path\n\nfrom airflow import DAG\n\nfrom cosmos.config import ProfileConfig\nfrom cosmos.operators.local import DbtCloneLocalOperator, DbtRunLocalOperator, DbtSeedLocalOperator\n\nDEFAULT_DBT_ROOT_PATH = Path(__file__).parent / \"dbt\"\nDBT_ROOT_PATH = Path(os.getenv(\"DBT_ROOT_PATH\", DEFAULT_DBT_ROOT_PATH))\nDBT_PROJ_DIR = Path(\"/Users/pankaj/Documents/astro_code/astronomer-cosmos/dev/dags/dbt/jaffle_shop\")\nDBT_PROFILE_PATH = DBT_PROJ_DIR / \"profiles.yml\"\nDBT_ARTIFACT = DBT_PROJ_DIR / \"target\"\n\nprofile_config = ProfileConfig(\n profile_name=\"default\",\n target_name=\"dev\",\n profiles_yml_filepath=DBT_PROFILE_PATH,\n)\n\nwith DAG(\"example_operators\", start_date=datetime(2024, 1, 1), catchup=False) as dag:\n seed_operator = DbtSeedLocalOperator(\n profile_config=profile_config,\n project_dir=DBT_PROJ_DIR,\n task_id=\"seed\",\n dbt_cmd_flags=[\"--select\", \"raw_customers\"],\n install_deps=True,\n append_env=True,\n )\n\n clone_operator = DbtCloneLocalOperator(\n profile_config=profile_config,\n project_dir=DBT_PROJ_DIR,\n task_id=\"clone\",\n dbt_cmd_flags=[\"--models\", \"stg_customers\", \"--state\", DBT_ARTIFACT],\n install_deps=True,\n append_env=True,\n )\n\n run_operator = DbtRunLocalOperator(\n profile_config=profile_config,\n project_dir=DBT_PROJ_DIR,\n task_id=\"run\",\n dbt_cmd_flags=[\"--models\", \"stg_customers\"],\n install_deps=True,\n append_env=True,\n )\n\n seed_operator >> [run_operator, clone_operator]\n\nwith `airflow dag test ` command \n\nWhen triggering it from the Airflow UI, the dagrun gets stuck at\n\n[2025-03-24T19:32:06.783+0530] {local_task_job_runner.py:120} INFO - ::group::Pre task execution logs\n[2025-03-24T19:32:06.788+0530] {taskinstance.py:2351} INFO - Dependencies all met for dep_context=non-requeueable deps ti= \n[2025-03-24T19:32:06.789+0530] {taskinstance.py:2351} INFO - Dependencies all met for dep_context=requeueable deps ti= \n[2025-03-24T19:32:06.790+0530] {taskinstance.py:2592} INFO - Starting attempt 1 of 1\n[2025-03-24T19:32:06.793+0530] {taskinstance.py:2615} INFO - Executing on None\n[2025-03-24T19:32:06.798+0530] {standard_task_runner.py:131} INFO - Started process 81127 to run task\n[2025-03-24T19:32:06.802+0530] {standard_task_runner.py:147} INFO - Running: ['airflow', 'tasks', 'run', 'example_operators', 'seed', 'manual__2025-03-24T14:01:17.808538+00:00_QYRo5rS0', '--raw', '--subdir', '/Users/pankaj/Documents/astro_code/astronomer-cosmos/scripts/airflow3/dags/operator_dag.py', '--cfg-path', '/var/folders/hd/7r9vjkwj4hnfyph52pr_b7lc0000gn/T/tmpraiej989']\n[2025-03-24T19:32:06.804+0530] {standard_task_runner.py:148} INFO - Subtask seed\n[2025-03-24T19:32:06.822+0530] {task_command.py:442} INFO - Running on host pankajs-macbook-pro.local\n[2025-03-24T19:32:06.892+0530] {taskinstance.py:2902} INFO - Exporting env vars: AIRFLOW_CTX_DAG_OWNER='airflow' AIRFLOW_CTX_DAG_ID='example_operators' AIRFLOW_CTX_TASK_ID='seed' AIRFLOW_CTX_TRY_NUMBER='1' AIRFLOW_CTX_DAG_RUN_ID='manual__2025-03-24T14:01:17.808538+00:00_QYRo5rS0'\n[2025-03-24T19:32:06.893+0530] {taskinstance.py:690} INFO - ::endgroup::\n[2025-03-24T19:32:07.987+0530] {local.py:213} INFO - dbtRunner is available. Using dbtRunner for invoking dbt.\n[2025-03-24T19:32:07.988+0530] {local.py:416} INFO - Cloning project to writable temp directory /var/folders/hd/7r9vjkwj4hnfyph52pr_b7lc0000gn/T/tmp0qu0uuky from /Users/pankaj/Documents/astro_code/astronomer-cosmos/dev/dags/dbt/jaffle_shop\n[2025-03-24T19:32:07.991+0530] {config.py:356} INFO - Using user-supplied profiles.yml at /Users/pankaj/Documents/astro_code/astronomer-cosmos/dev/dags/dbt/jaffle_shop/profiles.yml\n[2025-03-24T19:32:07.993+0530] {runner.py:60} INFO - Trying to run dbtRunner with:\n ['deps', '--project-dir', '/var/folders/hd/7r9vjkwj4hnfyph52pr_b7lc0000gn/T/tmp0qu0uuky', '--profiles-dir', '/Users/pankaj/Documents/astro_code/astronomer-cosmos/dev/dags/dbt/jaffle_shop', '--profile', 'default', '--target', 'dev']\n in /var/folders/hd/7r9vjkwj4hnfyph52pr_b7lc0000gn/T/tmp0qu0uuky\n[2025-03-24T19:32:08.053+0530] {logging_mixin.py:212} INFO - 14:02:08 Running with dbt=1.9.3","author_login":"pankajastro","author_association":"CONTRIBUTOR","created_at":"2025-03-24T14:08:59+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2928438849,"issue_number":1621,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1621","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2748459590","fragment_type":"issue_comment","sequence":2,"text":"Create a PR isolating changes and add conditionals so we can all work using this same code base","author_login":"tatiana","author_association":"COLLABORATOR","created_at":"2025-03-24T15:07:54+08:00","repo_name":"astronomer/astronomer-cosmos","issue_id":2928438849,"issue_number":1621,"issue_url":"https://github.com/astronomer/astronomer-cosmos/issues/1621","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0060","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"roachtest: cdc/schemareg failed?","query_context":"roachtest.cdc/schemareg failed with artifacts on release-22.1 @ 000c9624b56b09d5fbd06557c559b2f910142a9c:\n\nThe test failed on branch=release-22.1, cloud=gce:\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n cdc.go:514,cdc.go:883,test_runner.go:883: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n\n cluster.go:1934,cdc.go:1449,panic.go:1038,test_impl.go:248,cdc.go:514,cdc.go:883,test_runner.go:883: cluster.RunE: context canceled\n (1) attached stack trace\n -- stack trace:\n | main.(*clusterImpl).RunE\n | main/pkg/cmd/roachtest/cluster.go:1951\n | main.(*clusterImpl).Run\n | main/pkg/cmd/roachtest/cluster.go:1932\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.kafkaManager.stop\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:1449\n | runtime.gopanic\n | GOROOT/src/runtime/panic.go:1038\n | main.(*testImpl).Fatal\n | main/pkg/cmd/roachtest/test_impl.go:248\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runCDCSchemaRegistry\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:514\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerCDC.func10\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:883\n | main.(*testRunner).runTest.func2\n | main/pkg/cmd/roachtest/test_runner.go:883\n | runtime.goexit\n | GOROOT/src/runtime/asm_amd64.s:1581\n Wraps: (2) cluster.RunE\n Wraps: (3) context canceled\n Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errors.errorString\n\n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n/cc @cockroachdb/cdc\n \n\nThis test on roachdash | Improve this report!\n \n\nJira issue: CRDB-22922","known_context_document_ids":["gh_issue_1515042175"],"reference_answer":"roachtest.cdc/schemareg failed with artifacts on release-22.2 @ 07a53a36601e9ca5fcffcff55f69b43c6dfbf1c1:\n\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n(test_impl.go:286).Fatal: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n(test_impl.go:286).Fatal: cluster.RunE: context canceled\n\n Parameters: ROACHTEST_cloud=gce \n, ROACHTEST_cpu=4 \n, ROACHTEST_encrypted=false \n, ROACHTEST_fs=ext4 \n, ROACHTEST_localSSD=true \n, ROACHTEST_ssd=0 \n \n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94482 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.1 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","answer_document_id":"gh_comment_1369468438","silver_evidence_path":["gh_comment_1368373729","gh_issue_1515049216","gh_comment_1369468438"],"evidence_issue_ids":[1515042175,1515049216],"source_repo_name":"cockroachdb/cockroach","source_issue_id":1515042175,"source_issue_number":94482,"source_issue_url":"https://github.com/cockroachdb/cockroach/issues/94482","target_repo_name":"cockroachdb/cockroach","target_issue_id":1515049216,"target_issue_number":94496,"target_issue_url":"https://github.com/cockroachdb/cockroach/issues/94496","reference_anchor_document_id":"gh_comment_1368373729","reference_answer_author":"cockroach-teamcity","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.9634,"anchor_target_overlap":0.7576,"target_answer_overlap":0.9839},"issue_created_at":"2022-12-31T07:14:23+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1515042175","fragment_type":"issue_description","sequence":0,"text":"roachtest: cdc/schemareg failed\nroachtest.cdc/schemareg failed with artifacts on release-22.1 @ 000c9624b56b09d5fbd06557c559b2f910142a9c:\n\nThe test failed on branch=release-22.1, cloud=gce:\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n cdc.go:514,cdc.go:883,test_runner.go:883: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n\n cluster.go:1934,cdc.go:1449,panic.go:1038,test_impl.go:248,cdc.go:514,cdc.go:883,test_runner.go:883: cluster.RunE: context canceled\n (1) attached stack trace\n -- stack trace:\n | main.(*clusterImpl).RunE\n | main/pkg/cmd/roachtest/cluster.go:1951\n | main.(*clusterImpl).Run\n | main/pkg/cmd/roachtest/cluster.go:1932\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.kafkaManager.stop\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:1449\n | runtime.gopanic\n | GOROOT/src/runtime/panic.go:1038\n | main.(*testImpl).Fatal\n | main/pkg/cmd/roachtest/test_impl.go:248\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runCDCSchemaRegistry\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:514\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerCDC.func10\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:883\n | main.(*testRunner).runTest.func2\n | main/pkg/cmd/roachtest/test_runner.go:883\n | runtime.goexit\n | GOROOT/src/runtime/asm_amd64.s:1581\n Wraps: (2) cluster.RunE\n Wraps: (3) context canceled\n Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errors.errorString\n\n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n/cc @cockroachdb/cdc\n \n\nThis test on roachdash | Improve this report!\n \n\nJira issue: CRDB-22922","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2022-12-31T07:14:23+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515042175,"issue_number":94482,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94482","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1368373729","fragment_type":"issue_comment","sequence":1,"text":"roachtest.cdc/schemareg failed with artifacts on release-22.1 @ 000c9624b56b09d5fbd06557c559b2f910142a9c:\n\nThe test failed on branch=release-22.1, cloud=gce:\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n cdc.go:514,cdc.go:883,test_runner.go:883: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n\n cluster.go:1934,cdc.go:1449,panic.go:1038,test_impl.go:248,cdc.go:514,cdc.go:883,test_runner.go:883: cluster.RunE: context canceled\n (1) attached stack trace\n -- stack trace:\n | main.(*clusterImpl).RunE\n | main/pkg/cmd/roachtest/cluster.go:1951\n | main.(*clusterImpl).Run\n | main/pkg/cmd/roachtest/cluster.go:1932\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.kafkaManager.stop\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:1449\n | runtime.gopanic\n | GOROOT/src/runtime/panic.go:1038\n | main.(*testImpl).Fatal\n | main/pkg/cmd/roachtest/test_impl.go:248\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runCDCSchemaRegistry\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:514\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerCDC.func10\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:883\n | main.(*testRunner).runTest.func2\n | main/pkg/cmd/roachtest/test_runner.go:883\n | runtime.goexit\n | GOROOT/src/runtime/asm_amd64.s:1581\n Wraps: (2) cluster.RunE\n Wraps: (3) context canceled\n Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errors.errorString\n\n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94496 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.2 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2023-01-01T07:15:10+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515042175,"issue_number":94482,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94482","linked_issue_ids":[1515049216],"is_known_query_context":false},{"document_id":"gh_comment_1368701733","fragment_type":"issue_comment","sequence":2,"text":"roachtest.cdc/schemareg failed with artifacts on release-22.1 @ 000c9624b56b09d5fbd06557c559b2f910142a9c:\n\nThe test failed on branch=release-22.1, cloud=gce:\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n cdc.go:514,cdc.go:883,test_runner.go:883: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n\n cluster.go:1934,cdc.go:1449,panic.go:1038,test_impl.go:248,cdc.go:514,cdc.go:883,test_runner.go:883: cluster.RunE: context canceled\n (1) attached stack trace\n -- stack trace:\n | main.(*clusterImpl).RunE\n | main/pkg/cmd/roachtest/cluster.go:1951\n | main.(*clusterImpl).Run\n | main/pkg/cmd/roachtest/cluster.go:1932\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.kafkaManager.stop\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:1449\n | runtime.gopanic\n | GOROOT/src/runtime/panic.go:1038\n | main.(*testImpl).Fatal\n | main/pkg/cmd/roachtest/test_impl.go:248\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runCDCSchemaRegistry\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:514\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerCDC.func10\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:883\n | main.(*testRunner).runTest.func2\n | main/pkg/cmd/roachtest/test_runner.go:883\n | runtime.goexit\n | GOROOT/src/runtime/asm_amd64.s:1581\n Wraps: (2) cluster.RunE\n Wraps: (3) context canceled\n Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errors.errorString\n\n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94496 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.2 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2023-01-02T07:10:34+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515042175,"issue_number":94482,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94482","linked_issue_ids":[1515049216],"is_known_query_context":false},{"document_id":"gh_comment_1369456409","fragment_type":"issue_comment","sequence":3,"text":"roachtest.cdc/schemareg failed with artifacts on release-22.1 @ 000c9624b56b09d5fbd06557c559b2f910142a9c:\n\nThe test failed on branch=release-22.1, cloud=gce:\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n cdc.go:514,cdc.go:883,test_runner.go:883: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n\n cluster.go:1934,cdc.go:1449,panic.go:1038,test_impl.go:248,cdc.go:514,cdc.go:883,test_runner.go:883: cluster.RunE: context canceled\n (1) attached stack trace\n -- stack trace:\n | main.(*clusterImpl).RunE\n | main/pkg/cmd/roachtest/cluster.go:1951\n | main.(*clusterImpl).Run\n | main/pkg/cmd/roachtest/cluster.go:1932\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.kafkaManager.stop\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:1449\n | runtime.gopanic\n | GOROOT/src/runtime/panic.go:1038\n | main.(*testImpl).Fatal\n | main/pkg/cmd/roachtest/test_impl.go:248\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runCDCSchemaRegistry\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:514\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.registerCDC.func10\n | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/cdc.go:883\n | main.(*testRunner).runTest.func2\n | main/pkg/cmd/roachtest/test_runner.go:883\n | runtime.goexit\n | GOROOT/src/runtime/asm_amd64.s:1581\n Wraps: (2) cluster.RunE\n Wraps: (3) context canceled\n Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errors.errorString\n\n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94496 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.2 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2023-01-03T07:19:12+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515042175,"issue_number":94482,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94482","linked_issue_ids":[1515049216],"is_known_query_context":false},{"document_id":"gh_issue_1515049216","fragment_type":"issue_description","sequence":0,"text":"roachtest: cdc/schemareg failed\nroachtest.cdc/schemareg failed with artifacts on release-22.2 @ 07a53a36601e9ca5fcffcff55f69b43c6dfbf1c1:\n\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n(test_impl.go:286).Fatal: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n(test_impl.go:286).Fatal: cluster.RunE: context canceled\n\n Parameters: ROACHTEST_cloud=gce \n, ROACHTEST_cpu=4 \n, ROACHTEST_encrypted=false \n, ROACHTEST_fs=ext4 \n, ROACHTEST_localSSD=true \n, ROACHTEST_ssd=0 \n \n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94482 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.1 release-blocker]\n \n \n/cc @cockroachdb/cdc\n \n\nThis test on roachdash | Improve this report!\n \n\nJira issue: CRDB-22936","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2022-12-31T07:42:30+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515049216,"issue_number":94496,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368376624","fragment_type":"issue_comment","sequence":1,"text":"roachtest.cdc/schemareg failed with artifacts on release-22.2 @ 07a53a36601e9ca5fcffcff55f69b43c6dfbf1c1:\n\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n(test_impl.go:286).Fatal: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n(test_impl.go:286).Fatal: cluster.RunE: context canceled\n\n Parameters: ROACHTEST_cloud=gce \n, ROACHTEST_cpu=4 \n, ROACHTEST_encrypted=false \n, ROACHTEST_fs=ext4 \n, ROACHTEST_localSSD=true \n, ROACHTEST_ssd=0 \n \n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94482 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.1 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2023-01-01T07:42:45+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515049216,"issue_number":94496,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368711257","fragment_type":"issue_comment","sequence":2,"text":"roachtest.cdc/schemareg failed with artifacts on release-22.2 @ 07a53a36601e9ca5fcffcff55f69b43c6dfbf1c1:\n\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n(test_impl.go:286).Fatal: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n(test_impl.go:286).Fatal: cluster.RunE: context canceled\n\n Parameters: ROACHTEST_cloud=gce \n, ROACHTEST_cpu=4 \n, ROACHTEST_encrypted=false \n, ROACHTEST_fs=ext4 \n, ROACHTEST_localSSD=true \n, ROACHTEST_ssd=0 \n \n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94482 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.1 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2023-01-02T07:42:04+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515049216,"issue_number":94496,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1369468438","fragment_type":"issue_comment","sequence":3,"text":"roachtest.cdc/schemareg failed with artifacts on release-22.2 @ 07a53a36601e9ca5fcffcff55f69b43c6dfbf1c1:\n\ntest artifacts and logs in: /artifacts/cdc/schemareg/run_1\n(test_impl.go:286).Fatal: pq: Use of CHANGEFEED requires an enterprise license. Your evaluation license expired on December 30, 2022. If you're interested in getting a new license, please contact subscriptions@cockroachlabs.com and we can help you out.\n(test_impl.go:286).Fatal: cluster.RunE: context canceled\n\n Parameters: ROACHTEST_cloud=gce \n, ROACHTEST_cpu=4 \n, ROACHTEST_encrypted=false \n, ROACHTEST_fs=ext4 \n, ROACHTEST_localSSD=true \n, ROACHTEST_ssd=0 \n \n Help \n \n\nSee: roachtest README\n\nSee: How To Investigate \\(internal\\)\n\n \n \n Same failure on other branches \n \n\n- #94502 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-master release-blocker]\n- #94482 roachtest: cdc/schemareg failed [C-test-failure O-roachtest O-robot T-cdc branch-release-22.1 release-blocker]\n \n \n \n\nThis test on roachdash | Improve this report!","author_login":"cockroach-teamcity","author_association":"MEMBER","created_at":"2023-01-03T07:43:16+08:00","repo_name":"cockroachdb/cockroach","issue_id":1515049216,"issue_number":94496,"issue_url":"https://github.com/cockroachdb/cockroach/issues/94496","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0061","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Default shortcut keys cannot be used.","query_context":"os:ubuntu22.04\nyazi version: 25.3.7\n\nInstall and configure according to the instructions in the readme.","known_context_document_ids":["gh_issue_2924079161"],"reference_answer":"Wow, thanks! I rarely start `nvim .` myself so I didn't know about it.\n\nBut I can reproduce it too, although it happens so fast on my machine that I missed it previously. I'll add a note about this to the docs for now.\n\nI don't know if it's possible to automatically apply this at the correct time with this solution, but at least people can now copy paste this into their configs.","answer_document_id":"gh_comment_2694776475","silver_evidence_path":["gh_comment_2733104647","gh_issue_2889886478","gh_comment_2694776475"],"evidence_issue_ids":[2924079161,2889886478],"source_repo_name":"mikavilpas/yazi.nvim","source_issue_id":2924079161,"source_issue_number":830,"source_issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","target_repo_name":"mikavilpas/yazi.nvim","target_issue_id":2889886478,"target_issue_number":802,"target_issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","reference_anchor_document_id":"gh_comment_2733104647","reference_answer_author":"mikavilpas","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.3158,"target_answer_overlap":0.1176},"issue_created_at":"2025-03-17T07:53:37+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2924079161","fragment_type":"issue_description","sequence":0,"text":"Default shortcut keys cannot be used.\nos:ubuntu22.04\nyazi version: 25.3.7\n\nInstall and configure according to the instructions in the readme.","author_login":"kdurant","author_association":"NONE","created_at":"2025-03-17T07:53:37+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2729134873","fragment_type":"issue_comment","sequence":1,"text":"Can you give an example? What are you trying to do exactly?\n\nCurrently yazi.nvim completely overrides keys and they cannot be used in yazi.","author_login":"mikavilpas","author_association":"OWNER","created_at":"2025-03-17T11:24:51+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2731379117","fragment_type":"issue_comment","sequence":2,"text":"Image\nAfter installing the plugin, except for F1 which can be used, none of the other shortcut keys respond at all.","author_login":"kdurant","author_association":"NONE","created_at":"2025-03-18T01:52:44+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2733104647","fragment_type":"issue_comment","sequence":3,"text":"Exactly the same as in the readme file.\n\nlua\n---@type LazySpec\n{\n \"mikavilpas/yazi.nvim\",\n event = \"VeryLazy\",\n dependencies = { \"folke/snacks.nvim\", lazy = true },\n keys = {\n -- 👇 in this section, choose your own keymappings!\n {\n \" -\",\n mode = { \"n\", \"v\" },\n \" Yazi \",\n desc = \"Open yazi at the current file\",\n },\n {\n -- Open in the current working directory\n \" cw\",\n \" Yazi cwd \",\n desc = \"Open the file manager in nvim's working directory\",\n },\n {\n \" \",\n \" Yazi toggle \",\n desc = \"Resume the last yazi session\",\n },\n },\n ---@type YaziConfig | {}\n opts = {\n -- if you want to open yazi instead of netrw, see below for more info\n open_for_directories = false,\n keymaps = {\n show_help = \" \",\n },\n },\n -- 👇 if you use `open_for_directories=true`, this is recommended\n init = function()\n -- More details: URL \n -- vim.g.loaded_netrw = 1\n vim.g.loaded_netrwPlugin = 1\n end,\n}","author_login":"kdurant","author_association":"NONE","created_at":"2025-03-18T12:47:57+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[2889886478],"is_known_query_context":false},{"document_id":"gh_comment_2735521452","fragment_type":"issue_comment","sequence":4,"text":"With the same configuration, it is normal on another machine.\nI will tinker with it slowly when I have time. Thank you.","author_login":"kdurant","author_association":"NONE","created_at":"2025-03-19T06:49:02+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2926826561","fragment_type":"issue_comment","sequence":5,"text":"@mikavilpas Does this mean keys like Mac OS's `Command` key cannot be used in yazi.nvim? I had noticed it works for yazi outside of nvim","author_login":"ezequiel","author_association":"NONE","created_at":"2025-06-01T08:39:36+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2926988163","fragment_type":"issue_comment","sequence":6,"text":"Hmm what I meant was that if yazi.nvim has a binding for e.g. ` `, it will always process that key (in neovim), while keys that do not have a yazi.nbim mapping are sent to Yazi to be processed there.\n\nI think the command key might never be sent on its own, but I don't exactly know how it works. Does it work for you on neovim if you open `:term` and then start Yazi there?","author_login":"mikavilpas","author_association":"OWNER","created_at":"2025-06-01T10:30:08+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2924079161,"issue_number":830,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/830","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2889886478","fragment_type":"issue_description","sequence":0,"text":"Netrw supression\nLooks like \nopen_for_directories = true\n doesn't supress netrw correctly, somehow\n\nNot sure is it due your plugin or not, but with my decision below all works correct\nNetrw-noload doc was a solution\n\nIn my case enough \nvim.g.loaded_netrwPlugin = 1\n\nIf I do readme way, netrw preloads before yazi\n\nlua\nreturn {\n \"mikavilpas/yazi.nvim\",\n event = \"VeryLazy\",\n opts = {\n open_for_directories = true,\n },\n}\n\nasciicast\n\nBut if I add netrw \"supression\" part into init then all works properly\n\nlua\nreturn {\n \"mikavilpas/yazi.nvim\",\n init = function()\n -- Block netrw plugin load\n -- vim.g.loaded_netrw = 1\n vim.g.loaded_netrwPlugin = 1\n end,\n event = \"VeryLazy\",\n opts = {\n open_for_directories = true,\n },\n}\n\nasciicast\n\nSystem settings:\nYazi 25.2.26 (Arch Linux 2025-02-27)\nkitty 0.39.1\nNVIM v0.10.4\n\nAlso, thx for this beautiful plugin:)","author_login":"SadEagle","author_association":"NONE","created_at":"2025-03-03T00:23:51+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2889886478,"issue_number":802,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2694776475","fragment_type":"issue_comment","sequence":1,"text":"Wow, thanks! I rarely start `nvim .` myself so I didn't know about it.\n\nBut I can reproduce it too, although it happens so fast on my machine that I missed it previously. I'll add a note about this to the docs for now.\n\nI don't know if it's possible to automatically apply this at the correct time with this solution, but at least people can now copy paste this into their configs.","author_login":"mikavilpas","author_association":"OWNER","created_at":"2025-03-03T15:31:02+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2889886478,"issue_number":802,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2696294207","fragment_type":"issue_comment","sequence":2,"text":"I'm a non native speaker myself. I think it's non ambiguous, but I agree it could be worded in a way that's a lot more clear.\n\nI'll try to improve it.","author_login":"mikavilpas","author_association":"OWNER","created_at":"2025-03-04T05:50:47+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2889886478,"issue_number":802,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3138388102","fragment_type":"issue_comment","sequence":3,"text":"this still does have an issue where opening with nvim . will not make it open the current working directory and instead try to use a bogus filepath","author_login":"kaem-e","author_association":"NONE","created_at":"2025-07-31T02:45:56+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2889886478,"issue_number":802,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3138608211","fragment_type":"issue_comment","sequence":4,"text":"@kaem-e can you open a new issue with a reproduction script ( URL ?","author_login":"mikavilpas","author_association":"OWNER","created_at":"2025-07-31T05:29:48+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2889886478,"issue_number":802,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3621015378","fragment_type":"issue_comment","sequence":5,"text":"It seems to be working now! Maybe something else from my config influenced this? Or did you change something with the latest update?","author_login":"S1lander","author_association":"NONE","created_at":"2025-12-06T19:33:39+08:00","repo_name":"mikavilpas/yazi.nvim","issue_id":2889886478,"issue_number":802,"issue_url":"https://github.com/mikavilpas/yazi.nvim/issues/802","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0062","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Recursively controlling a circuit takes exponential time and memory?","query_context":"### Environment\n\n- **Qiskit version**: 1.0\n- **Python version**: 3.12\n- **Operating system**: OSX and Linux\n \n\n### What is happening?\n\nRecursively adding controls to an initial sub-circuit will cause Qiskit to hang, using up ever increasing CPU and memory resources. E.g. the below will never complete, but taking `N=5` or so will.\n\npython\n\nN = 10\nsub_qc = QuantumCircuit(1)\nsub_qc.x(0)\n\nout = QuantumCircuit(N)\nout.compose(sub_qc,range(sub_qc.num_qubits), inplace=True)\n\nfor kk in range(N-1):\n sub_qc = sub_qc.control()\n out.compose(sub_qc,range(sub_qc.num_qubits), inplace=True)\n\n### How can we reproduce the issue?\n\nRun above\n\n### What should happen?\n\nIt should not take apparently exponential time\n\n### Any suggestions?\n\n_No response_","known_context_document_ids":["gh_issue_2139057968"],"reference_answer":"The primary focus of this issue is to decompose an `MCXGate()` using non-exponential number of `CX` gates, without using ancillas, thus fixing URL","answer_document_id":"gh_comment_1978343520","silver_evidence_path":["gh_comment_1952366355","gh_issue_811114828","gh_comment_1978343520"],"evidence_issue_ids":[2139057968,811114828],"source_repo_name":"Qiskit/qiskit","source_issue_id":2139057968,"source_issue_number":11823,"source_issue_url":"https://github.com/Qiskit/qiskit/issues/11823","target_repo_name":"Qiskit/qiskit","target_issue_id":811114828,"target_issue_number":5872,"target_issue_url":"https://github.com/Qiskit/qiskit/issues/5872","reference_anchor_document_id":"gh_comment_1952366355","reference_answer_author":"ShellyGarion","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1,"target_answer_overlap":0.1667},"issue_created_at":"2024-02-16T17:28:33+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_2139057968","fragment_type":"issue_description","sequence":0,"text":"Recursively controlling a circuit takes exponential time and memory\n### Environment\n\n- **Qiskit version**: 1.0\n- **Python version**: 3.12\n- **Operating system**: OSX and Linux\n \n\n### What is happening?\n\nRecursively adding controls to an initial sub-circuit will cause Qiskit to hang, using up ever increasing CPU and memory resources. E.g. the below will never complete, but taking `N=5` or so will.\n\npython\n\nN = 10\nsub_qc = QuantumCircuit(1)\nsub_qc.x(0)\n\nout = QuantumCircuit(N)\nout.compose(sub_qc,range(sub_qc.num_qubits), inplace=True)\n\nfor kk in range(N-1):\n sub_qc = sub_qc.control()\n out.compose(sub_qc,range(sub_qc.num_qubits), inplace=True)\n\n### How can we reproduce the issue?\n\nRun above\n\n### What should happen?\n\nIt should not take apparently exponential time\n\n### Any suggestions?\n\n_No response_","author_login":"nonhermitian","author_association":"CONTRIBUTOR","created_at":"2024-02-16T17:28:33+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1948964421","fragment_type":"issue_comment","sequence":1,"text":"This is because `control` by default, for historical reasons, performs an eager synthesis of the control operation, so the scaling is fairly naturally super-linear (for arbitrary controlled gates). The solution for the simple representation of the objects is to use the modern form that @alexanderivrii has been getting in place, where controls, inverses and gate powers are represented as modifier tags on the gate, and only realised at synthesis time. In your example, setting `annotated=True` in the `control` call will make this script work in linear time of `N`.\n\nThat said, when it actually comes to synthesising the gates through `transpile`, you're still almost certainly going to see the super-linear blow up. Our arbitrary-control syntheses probably aren't the best they can be yet, but I think the general case is still going to scale quite a lot with the number of controls.","author_login":"jakelishman","author_association":"MEMBER","created_at":"2024-02-16T17:38:53+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1948965558","fragment_type":"issue_comment","sequence":2,"text":"Just as an immediate copy-pastable example of the above:\n\npython\nfrom qiskit import QuantumCircuit\n\nN = 100\nsub_qc = QuantumCircuit(1)\nsub_qc.x(0)\n\nout = QuantumCircuit(N)\nout.compose(sub_qc,range(sub_qc.num_qubits), inplace=True)\n\nfor kk in range(N-1):\n sub_qc = sub_qc.control(annotated=True)\n out.compose(sub_qc,range(sub_qc.num_qubits), inplace=True)","author_login":"jakelishman","author_association":"MEMBER","created_at":"2024-02-16T17:39:40+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1948974345","fragment_type":"issue_comment","sequence":3,"text":"Fwiw, slightly better form for this would be to do:\n\npython\nfrom qiskit import QuantumCircuit\n\nN = 100\nsub_qc = QuantumCircuit(1)\nsub_qc.x(0)\nsub = sub_qc.to_gate()\n\nout = QuantumCircuit(N)\nout.append(sub, range(sub.num_qubits))\n\nfor kk in range(N-1):\n sub = sub.control(annotated=True)\n out.append(sub, range(sub.num_qubits))\n\n`compose` is a circuit-inlining method, where a circuit represents a program. A single object in a circuit is a `Gate` (if unitary) or `Instruction` (if not), and that's the base blocking structure of the object and how it's pulled through the transpiler. Using the native block structure like that (rather than inlining things with `compose`) will be / should be better for performance longer term, especially as our things like synthesis of these gate annotations improves, because the tranpsiler will be able to retain the abstract/logical structure of the circuit for more longer, and do operations on large-scale abstract components, rather than a flattened structure caused by over-use of `compose`. `compose` is of course better when you _want_ the structures to be merged / inlined, but I don't think this particular example is one of those.","author_login":"jakelishman","author_association":"MEMBER","created_at":"2024-02-16T17:45:38+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949042354","fragment_type":"issue_comment","sequence":4,"text":"Ok thanks. I am trying to benchmark various aspects of Qiskit, and this one broke things, where as other frameworks can handle the controlled circuit. \n\nIs there anyway for an user to find out what `annotated=True` does in the control? I cannot seem to find it. Also, if it prevents blow-up, why is it not on by default?","author_login":"nonhermitian","author_association":"CONTRIBUTOR","created_at":"2024-02-16T18:18:19+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949078483","fragment_type":"issue_comment","sequence":5,"text":"It's not on by default because that would have been a major breaking API change, and we're not confident that it's as well supported through the entire stack as the current form yet. It will become the default once it and its synthesis have matured a little more - I'd imagine changing the default of `control` will be one of the API breaks of Qiskit 2.0.\n\nFor example, at the moment, the multiple `control` form of annotated gate isn't merging the controlled modifiers into one, nor do the transpiler passes that synthesise the annotated forms of the gates, so we'll still effectively be doing the same looped calls you were underneath. That's not super hard to fix of course, just an indication of the newness of the feature in Qiskit.\n\nWhat are you meaning by \"any way for a user to find out what it does?\"? It's a modifier, so it doesn't really _do_ anything (in the sense of the eager synthesis of `ControlledGate`) does on the spot. How it gets synthesised to actual hardware depends (in theory, not yet in practice) on the basis gates and coupling constraints of the hardware, which isn't defined at the point of creating an abstract circuit, but would happen during compilation.","author_login":"jakelishman","author_association":"MEMBER","created_at":"2024-02-16T18:33:28+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949084763","fragment_type":"issue_comment","sequence":6,"text":"Yeah, no I answered my own question when I tried to change the basis on the circuit and it just kept running. \n\nIt also modifies the circuit drawing, which is not too important, but unexpected.","author_login":"nonhermitian","author_association":"CONTRIBUTOR","created_at":"2024-02-16T18:36:08+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950392510","fragment_type":"issue_comment","sequence":7,"text":"Continuing with Jake's example, here are a few thoughts on the following synthesis step:\n\nAn expression of the form `sub.control(annotated=True) ... .control(annotated=True)` would actually combine all of the control modifiers into a single list, that is create an \"annotated operation\" whose \"base operation\" is `sub` and whose modifiers are the list `[ControlModifier(1), ..., ControlModifier(1)]`. \n\nFor `N=10`, synthesizing this directly is very slow, but we do have a new transpiler pass `OptimizeAnnotated` in Qiskit 1.0 that canonicalizes the modifiers, that is replaces the list of modifiers by a single control modifier with multiple controls. We are still investigating how to best integrate it into the transpiler flow, so it's now on by default, but one would use this along the following lines:\n\nfrom qiskit.transpiler.passes import OptimizeAnnotated\nbasis_gates = ['cx', 'id', 'u']\nout = OptimizeAnnotated(basis_gates=basis_gates)(out)\n\nThe pass is recursive, descending into the definitions of custom gates, and it needs basis gates and equivalence library to know which definitions to examine and which to skip. \n\nFor `N=10`, the optimized circuit `out` is now susceptible to transpilation (i.e. to either `transpile` or to `HighLevelSynthesis`). However the approach still does not scale to much larger values of `N`. If I recall correctly (not too sure about this), our default algorithm for synthesizing multiply-controlled gates without ancilla qubits produces exponentially many gates. \n\nOne could do a bit better by replacing the code\n\nsub_qc = QuantumCircuit(1)\nsub_qc.x(0)\nsub = sub_qc.to_gate()\n\nby\n\nsub = XGate()\n\nin which case the synthesis algorithm would treat the annotated `sub` essentially as a `MCX`-gate, producing half as many gates and somewhat decreasing runtime, but unfortunately the default synthesis algorithm (\"McxGrey\") for MCX-gates without ancillas still produces exponentially many gates.","author_login":"alexanderivrii","author_association":"CONTRIBUTOR","created_at":"2024-02-17T21:47:38+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952366355","fragment_type":"issue_comment","sequence":8,"text":"Indeed, it seems that the current synthesis algorithms for multi-controlled gates could be improved. See the discussion in #5872","author_login":"ShellyGarion","author_association":"MEMBER","created_at":"2024-02-19T12:38:49+08:00","repo_name":"Qiskit/qiskit","issue_id":2139057968,"issue_number":11823,"issue_url":"https://github.com/Qiskit/qiskit/issues/11823","linked_issue_ids":[811114828],"is_known_query_context":false},{"document_id":"gh_issue_811114828","fragment_type":"issue_description","sequence":0,"text":"Decompose CnXGate grows exponentially in terms of CX, instead of linear\n@anedumla noticed that theorem 5 in URL bounds the amount of CNOTs needed to decompose a SU(2) gate when (n-1)-controlled. \n\n<img width=\"508\" alt=\"Screenshot 2021-02-18 at 14 38 14\" src=\" URL \n\nThe bound of resulting CNOTs in the decomposition grows linearly with respect to the amount of controlled qubits. However, the decomposition of MCX groups exponentially:\n\nnumber_of_qubits = []\nresult = []\nboundery = []\nfor k in range(1, 10):\n n = k+1\n circuit = QuantumCircuit(k+1)\n circuit.append(XGate().control(k), list(range(k+1)))\n unroller = Unroller(basis_gates)\n qc = unroller(circuit)\n number_of_qubits.append(n)\n result.append(qc.count_ops()['cx'])\n boundery.append(28*n-88)\n\nimage\n\n### What is the expected enhancement?\nA non-ancilla decomposition of `QuantumCircuit.mcx()` should result in a linear amount of CNOTs. URL refers to URL for calculating A-B-C, that can be precomputed. \n\n<img width=\"615\" alt=\"Screenshot 2021-02-18 at 14 46 00\" src=\" URL \n\nIn it's generic form, Theorem 5 can be applied any multi-controlled-W, where W \\in SU(2). Therefore, I assume is can be generalised to fix the example URL by creating a possible decomposition.","author_login":"1ucian0","author_association":"MEMBER","created_at":"2021-02-18T13:47:34+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_781949195","fragment_type":"issue_comment","sequence":1,"text":"How to decompose a gate in SU(2) into A, B, C : URL \n\nFrom Lemma 4.1., every element of SU(2) can be expressed as \nimage\n\nThen, from the proof of Lemma 4.3.:\nimage","author_login":"anedumla","author_association":"CONTRIBUTOR","created_at":"2021-02-19T09:23:13+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_781967066","fragment_type":"issue_comment","sequence":2,"text":"For a general unitary, not in SU(2), (i.e X gate) Theorem 4[1] seems to be applicable that gives a CNOT count that scales quadratic. According to the upper bound they give, it's beneficial to use their scheme only when n > 10. (however the bound they give seems not to be tight and i can think it can be improved).\n\nEven ancilla decompositions of `mcx` can be proved (according to section 1 of the appendix A[1]) when:\n- `mode=recursion`. Current implementation uses 1 ancilla and has exponential CNOT count. With one ancilla qubit, it can be done with linear cost (16n - 40) (n: total no. of qubits)\n- `mode=v-chain-dirty`. Current implementation uses (12k - 22) CNOTs (k: no. of controls). It can be reduced to (8k - 6) that is better for k > 4.\n\nCan i work on this?\n\n[1] URL","author_login":"georgios-ts","author_association":"CONTRIBUTOR","created_at":"2021-02-19T09:55:03+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026252571","fragment_type":"issue_comment","sequence":3,"text":"I'm cleaning the assignees so it can be back to the pool of available `short projects`.","author_login":"1ucian0","author_association":"MEMBER","created_at":"2022-01-31T21:58:18+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1210675901","fragment_type":"issue_comment","sequence":4,"text":"Sounds good! @mtreinish should a synthesis interface be used for this?","author_login":"1ucian0","author_association":"MEMBER","created_at":"2022-08-10T13:29:19+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433444115","fragment_type":"issue_comment","sequence":5,"text":"Hi @1ucian0 ,\n\nWe have been working on this issue. Instead of using theorem 5 in [ URL this issue motivated us to develop a new decomposition that requires a smaller number of gates for SU(2) multi-controlled gates [ URL PR#8710 is the first step to solve this issue and reduces the number of gates in the MCXRecursive (that now is not recursive).","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2023-02-16T17:21:36+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433450989","fragment_type":"issue_comment","sequence":6,"text":"@AlexisRalli: this issue and all the PRs that link to it above are what I was trying to find when you asked me about them the other day. For others' reference: Alexis had also had some ideas about the generalised MCU constructions (see #9574 for one part, but I think he had more in the works as well), who I then told @alexanderivrii and @ShellyGarion about.\n\nI don't have much to contribute myself to the discussion, just trying to link up all the folks I know about working on this, or things adjacent to this.","author_login":"jakelishman","author_association":"MEMBER","created_at":"2023-02-16T17:26:59+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433499178","fragment_type":"issue_comment","sequence":7,"text":"Thanks @jakelishman,\n\nWe intend to contribute with an n-qubit multi-controlled su(2) decomposition that requires ~16n cx if the gate has one real diagonal and ~20n for any other su2 gate.","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2023-02-16T18:03:33+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1460071363","fragment_type":"issue_comment","sequence":8,"text":"Hi everyone,\n\nI am reporting what we have done up until now about this issue.\n\nWe found some problems that need a fix concerning multi-controlled gates: multi-controlled rotations grow exponentially #9741; MCXVChain with dirty ancilla not optimal #9740; and MCXRecursive not optimal #9743.\n\nWe fixed the MCXVChain with dirty auxiliary qubits #9687 and the MCXRecursive #8710. We also fixed mcry and mcrx #9688. There is a conflict PR about multi-controlled rotations #9574. However, #9688 produces circuits with fewer cx gates because it implements our recent work about su(2) multi-controlled gates.\n\nWe did not fix mcrz because the actual implementation of mcrz applies an mcp gate (not su(2)) #9202. I do not know if we should open a PR with a fix to mcrz because this will impact several test cases and other users.\n\nWe would also like to contribute to #7505.","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2023-03-08T12:18:26+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1478853633","fragment_type":"issue_comment","sequence":9,"text":"@ewinston. PR #9836 fix the mcrz. However it breaks compatibility tests. It is also necessary to include the multiplexer with a small number of control qubits.","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2023-03-22T02:59:10+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966010630","fragment_type":"issue_comment","sequence":10,"text":"@adjs @rafaella-vale - according to your paper [1] and to the function `_mcsu2_real_diagonal`, this function should decompose any multi-controlled SU(2) gate with a real main diagonal or secondary diagonal, hence it should also be able to decompose `mcx` or `mcp` gates.\n\n[1] URL \n\nHowever, this decomposition does not work properly, since it does not provide the expected operator:\n\nfrom qiskit.circuit.library.standard_gates import multi_control_rotation_gates as mcrg \nfor num_controls in range(3, 10, 2):\n qc = mcrg._mcsu2_real_diagonal(XGate().to_matrix(), num_controls, use_basis_gates=True)\n qc1 = QuantumCircuit(num_controls+1)\n qc1.mcx(list(range(num_controls)), num_controls)\n \n print (np.allclose(Operator(qc).to_matrix(), Operator(qc1).to_matrix() ))\n print (Operator(qc).equiv(Operator(qc1)))\n\ngives `False` and `False`. \nIt also does not work for `PhaseGate()` and `mcp`.\nBut the same code seems to work for the pairs: `RXGate()` and `mcrx`, `RYGate()` and `mcry`, `RZGate()` and `mcrz`.\n\nMoreover, \n\nnum_controls = 2\nqc = mcrg._mcsu2_real_diagonal(XGate().to_matrix(), num_controls, use_basis_gates=True)\n(Operator(qc).to_matrix()).round(decimals=0)\n\nproduces a wrong matrix for the Toffoli gate (in the last line it should be `1` and not `-1`):\n\narray([[ 1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j],\n [ 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j],\n [ 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, -0.-0.j, 0.+0.j],\n [ 0.+0.j, 0.+0.j, 0.+0.j, -0.-0.j, 0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j],\n [ 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j, 0.+0.j],\n [ 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j, 0.+0.j],\n [ 0.+0.j, 0.+0.j, 0.-0.j, 0.+0.j, 0.+0.j, 0.+0.j, 1.+0.j, 0.+0.j],\n [ 0.+0.j, 0.+0.j, 0.+0.j, -1.-0.j, 0.+0.j, 0.+0.j, 0.+0.j, 0.+0.j]])","author_login":"ShellyGarion","author_association":"MEMBER","created_at":"2024-02-27T08:20:22+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966035624","fragment_type":"issue_comment","sequence":11,"text":"Another synthesis method for MCX gates, if we also allow ancillas, then I think that the best method appears here: \n URL \n\nimage\nimage","author_login":"ShellyGarion","author_association":"MEMBER","created_at":"2024-02-27T08:36:08+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1967317345","fragment_type":"issue_comment","sequence":12,"text":"Hi @ShellyGarion, in this PR #9687 the mcx requires 8k-6 cnots (and k-2 ancillary qubits) to implement a k-controlled mcx. PR #8710 improves the number of cx gates with one auxiliary qubit (lemma 9 of URL","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2024-02-27T18:06:10+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1967333338","fragment_type":"issue_comment","sequence":13,"text":"The approximated multi controlled U(2) without ancillary qubits is implemented in qclib. \n\npip install qclib\n\npython\nimport numpy as np\nimport qiskit\nfrom qiskit.quantum_info import Operator\nfrom qclib.gates.mcu import MCU\n\ntol = 10**-2\nn_controls = 11\nX = np.array([[0, 1], [1, 0]])\nqc = qiskit.QuantumCircuit(n_controls)\nMCU.mcu(qc, X, list(range(n_controls-1)), n_controls-1, tol)\ntqc = qiskit.transpile(qc, basis_gates=['u', 'cx'])\n\nprint('mcu # operations', tqc.count_ops())\n\nqiskit_circuit = qiskit.QuantumCircuit(n_controls)\nqiskit_circuit.mcx(list(range(n_controls-1)), n_controls-1)\nqiskit_circuit.draw()\n\nt_qiskit_circuit = qiskit.transpile(qiskit_circuit, basis_gates=['u', 'cx'])\nprint('qiskit # operations', t_qiskit_circuit.count_ops())\n\nqc_matrix = Operator(qc).to_matrix()\nqiskit_matrix = Operator(qiskit_circuit).to_matrix()\n\nprint(np.allclose(qc_matrix, qiskit_matrix, atol=tol))\n\nwill return\n\nmcu # operations OrderedDict([('u', 395), ('cx', 360)])\nqiskit # operations OrderedDict([('u', 3070), ('cx', 3068)])\nTrue","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2024-02-27T18:16:51+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968690712","fragment_type":"issue_comment","sequence":14,"text":"Thank you @adjs for referring us to your recent manuscripts [1] and [2]. Would you be interested in contributing the code to Qiskit?","author_login":"ShellyGarion","author_association":"MEMBER","created_at":"2024-02-28T10:33:28+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968849191","fragment_type":"issue_comment","sequence":15,"text":"@thiagom123 and @JeffersonDeyvis can you implement approximate multi-controlled gate in qiskit?","author_login":"adjs","author_association":"CONTRIBUTOR","created_at":"2024-02-28T12:09:31+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1978343520","fragment_type":"issue_comment","sequence":16,"text":"The primary focus of this issue is to decompose an `MCXGate()` using non-exponential number of `CX` gates, without using ancillas, thus fixing URL","author_login":"ShellyGarion","author_association":"MEMBER","created_at":"2024-03-05T09:43:24+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2233727071","fragment_type":"issue_comment","sequence":17,"text":"I am very happy to finally close this issue as all the PRs mentioned here have finally been merged!\nI would like to thank @adjs and everyone who contributed to this enormous effort!\nFeel free to open new issues and PRs with further synthesis algorithms for MCX with or without ancilla qubits if you think that they may be better than the current code.","author_login":"ShellyGarion","author_association":"MEMBER","created_at":"2024-07-17T16:32:42+08:00","repo_name":"Qiskit/qiskit","issue_id":811114828,"issue_number":5872,"issue_url":"https://github.com/Qiskit/qiskit/issues/5872","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0064","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Uncaught TypeError: Cannot read properties of undefined (reading 'hasOwnProperty') Console error thrown while using GTranslate widget and logged into website as admin?","query_context":"## Bug Description\n\nAs flagged in the support forum, the following console error is thrown while using GTranslate plugin widget and logged into website as admin:\n\nUncaught TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')\n at _._setupNS (/_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:261:314)\n at /_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:287:17\n at /_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:292:11\n at /_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:293:9\n\nI have been able to replicate this on a TasteWP site with just Site Kit and GTranslate installed. This only displayed when logged into the site as admin and viewing a page with the GTranslate widget place on it. When testing from an incognito browser and not logged in the console error does not display. You do not need to interact with the widget for the console error to show as it will display on page load.\n\nVideo recording of this in action:\n\n URL \n\n## Steps to reproduce\n\n1. Set up fresh TasteWP website with Site Kit installed and set up.\n2. Install the GTranslate plugin.\n3. Go to **Settings > GTranslate** and select an option for **'Show in menu'** and **'Show floating language selector'** so that the widget will display on posts/pages.\n4. Visit the site homepage and console error should display.\n\n## Screenshots\n\n \n\n## Additional Context\n\n \n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Acceptance criteria\n\n* \n\n## Implementation Brief\n\n* \n\n### Test Coverage\n\n* \n\n## QA Brief\n\n* \n\n## Changelog entry\n\n*","known_context_document_ids":["gh_issue_1397411854"],"reference_answer":"### QA Update: ✅ \n\n**Verified:**\n\n- Installed GTranslate chrome extension and WordPress plugin verified the extension works.\n- Visited a page on frontend, and the gtranslate extension is translating page.\n- Tested gtranslate plugin, you can add shortcode [gtranslate] into any page, and the gtranslate widget shows and translation works.\n- Tested with the Google Translate extension as well as GTranslate.\n- No console or front end error messages.\n- Completed a regression test on the behaviour fixed in URL \n\n \n Screenshots \n\nimage\nimage\nimage\nimage\nimage","answer_document_id":"gh_comment_1715732635","silver_evidence_path":["gh_comment_1572525362","gh_issue_1736797139","gh_comment_1715732635"],"evidence_issue_ids":[1397411854,1736797139],"source_repo_name":"google/site-kit-wp","source_issue_id":1397411854,"source_issue_number":5969,"source_issue_url":"https://github.com/google/site-kit-wp/issues/5969","target_repo_name":"google/site-kit-wp","target_issue_id":1736797139,"target_issue_number":7121,"target_issue_url":"https://github.com/google/site-kit-wp/issues/7121","reference_anchor_document_id":"gh_comment_1572525362","reference_answer_author":"wpdarren","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.5,"target_answer_overlap":0.7368},"issue_created_at":"2022-10-05T08:12:49+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1397411854","fragment_type":"issue_description","sequence":0,"text":"Uncaught TypeError: Cannot read properties of undefined (reading 'hasOwnProperty') Console error thrown while using GTranslate widget and logged into website as admin\n## Bug Description\n\nAs flagged in the support forum, the following console error is thrown while using GTranslate plugin widget and logged into website as admin:\n\nUncaught TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')\n at _._setupNS (/_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:261:314)\n at /_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:287:17\n at /_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:292:11\n at /_/translate_http/_/js/k=translate_http.tr.cs.sS79CTwCGSs.O/d=1/rs=AN8SPfooco5r-XPZgZHhoMWywin50i9rzg/m=el_conf:293:9\n\nI have been able to replicate this on a TasteWP site with just Site Kit and GTranslate installed. This only displayed when logged into the site as admin and viewing a page with the GTranslate widget place on it. When testing from an incognito browser and not logged in the console error does not display. You do not need to interact with the widget for the console error to show as it will display on page load.\n\nVideo recording of this in action:\n\n URL \n\n## Steps to reproduce\n\n1. Set up fresh TasteWP website with Site Kit installed and set up.\n2. Install the GTranslate plugin.\n3. Go to **Settings > GTranslate** and select an option for **'Show in menu'** and **'Show floating language selector'** so that the widget will display on posts/pages.\n4. Visit the site homepage and console error should display.\n\n## Screenshots\n\n \n\n## Additional Context\n\n \n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Acceptance criteria\n\n* \n\n## Implementation Brief\n\n* \n\n### Test Coverage\n\n* \n\n## QA Brief\n\n* \n\n## Changelog entry\n\n*","author_login":"adamdunnage","author_association":"COLLABORATOR","created_at":"2022-10-05T08:12:49+08:00","repo_name":"google/site-kit-wp","issue_id":1397411854,"issue_number":5969,"issue_url":"https://github.com/google/site-kit-wp/issues/5969","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1298621742","fragment_type":"issue_comment","sequence":1,"text":"@adamdunnage Weirdly i can reproduce the issue intermittently. First time I tried, I got the error message in the console. Then after a couple of refresh and not doing anything specific that would alter the plugin, the error was not there. Check the screencast below, where I refresh the page, but there are no errors:\n\n URL \n\nThis will require some further investigation @FlicHollis @eclarke1","author_login":"asvinb","author_association":"COLLABORATOR","created_at":"2022-11-01T14:51:08+08:00","repo_name":"google/site-kit-wp","issue_id":1397411854,"issue_number":5969,"issue_url":"https://github.com/google/site-kit-wp/issues/5969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1572525362","fragment_type":"issue_comment","sequence":2,"text":"I've investigated and identified the cause and a potential fix for this issue, which I have captured in the new issue #7121.","author_login":"techanvil","author_association":"COLLABORATOR","created_at":"2023-06-01T17:49:21+08:00","repo_name":"google/site-kit-wp","issue_id":1397411854,"issue_number":5969,"issue_url":"https://github.com/google/site-kit-wp/issues/5969","linked_issue_ids":[1736797139],"is_known_query_context":false},{"document_id":"gh_issue_1736797139","fragment_type":"issue_description","sequence":0,"text":"Fix console error thrown while using GTranslate widget and logged into website as admin.\n## Bug Description\n\nThis is a followup to fix the support issue captured in URL \n \n\n## Steps to reproduce\n\nSee the steps to reproduce on URL although note that I had to install an older version of the theme to get the **Show in menu** option to show anything (I switched to the Twenty Twenty-One theme).\n\n## Screenshots\n\nThis is the snippet of code provided via GTranslate that throws the error.\n\nimage.png\n\nThe argument it's invoked with can be seen here:\n\nimage.png\n\nAnd, the contemporaneous state of `window.google` can be seen here:\n\nimage.png\n\n## Additional Context\n\n \n - PHP Version: any\n - OS: any\n - Browser: any\n - Plugin Version: historical, but verified on 1.101.0\n - Device: any\n\n \n\nAs can be seen in the screenshots above, the code is throwing an error because it's trying to deeply reference an object on `window.google`, but `window.google` is `undefined`.\n\nIt appears that this conflict is occurring as a result of Site Kit's code where it intentionally initializes `window.google` to `undefined`:\n\n URL \n\nThis itself was deliberately introduced as a result of URL so care needs to be taken not to reintroduce a problem with regard to this issue.\n\nPreliminary investigation suggests a fix could be to initialize `window.google` to an empty object, rather that `undefined` - this appears to work both with GTranslate and with Site Kit's own Google Charts. However, this needs to be thoroughly investigated for viability.\n\n---------------\n\n_Do not alter or remove anything below. The following sections will be managed by moderators only._\n\n## Acceptance criteria\n\n* Site Kit should not prevent Google Translate from functioning\n* This includes integrations via the official browser extension, and the GTranslate plugin\n\nNote: there are known stability issues with Google Translate related to React crashing due to DOM changes made by Google Translate – this is a separate issue which is out of scope here. This issue is specific to allowing Google Translate to function at all on the page when SK is present/active\n\n## Implementation Brief\n\n* Locate the file at `assets/js/util/initialize-google-global.js`\n* Update the value of `global.google` within the condition to be `{}` as opposed to `undefined`\n* The final block of code should look as follows:\n\nif ( ! Object.prototype.hasOwnProperty.call( global, 'google' ) ) {\n global.google = {};\n}\n\n \n\n### Test Coverage\n* No additional tests required.\n\n## QA Brief\n\n* Install GTranslate chrome extension and WordPress plugin - URL \n* Open dashboard, verify gtranslate extension works\n* Open website, and some page on frontend, and verify that gtranslate extension is translating page (working)\n* To test gtranslate plugin, you can add shortcode `[gtranslate]` into any page, and verify the gtranslate widget shows on that page and translation works\n* It would be also worth giving this a test with the Google Translate extension as well as GTranslate.\n* Lastly, it would also be worthwhile doing a regression test on the behaviour fixed in URL as mentioned in the bug description.\n\n## Changelog entry\n\n* Fix console error thrown while using Site Kit in conjunction with Google Translate.","author_login":"techanvil","author_association":"COLLABORATOR","created_at":"2023-06-01T17:45:48+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615118280","fragment_type":"issue_comment","sequence":1,"text":"Note: after further investigation, this error also happens with the Google Translate browser extension which is likely more widely used than the GTranslate plugin.","author_login":"aaemnnosttv","author_association":"COLLABORATOR","created_at":"2023-06-30T19:40:45+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615126069","fragment_type":"issue_comment","sequence":2,"text":"@bethanylang this one is ready to start moving as soon as we have the capacity.","author_login":"aaemnnosttv","author_association":"COLLABORATOR","created_at":"2023-06-30T19:50:28+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1673104740","fragment_type":"issue_comment","sequence":3,"text":"@aaemnnosttv Sure, I can ask someone to pick this up for IB so I can try to get it into the next sprint – will depend on what kind of launch blockers we have from the KMW Bug Bash, though. Thanks!","author_login":"bethanylang","author_association":"COLLABORATOR","created_at":"2023-08-10T12:14:21+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1709929300","fragment_type":"issue_comment","sequence":4,"text":"I've not identified a need for any Test Coverage additions herein, please let me know if anyone is in disagreement with this. Existing tests should fail (unit and/or visual) should the change have any negative side effects.","author_login":"10upsimon","author_association":"COLLABORATOR","created_at":"2023-09-07T10:45:49+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710014205","fragment_type":"issue_comment","sequence":5,"text":"@10upsimon Can you please add an estimate here? Thanks much!","author_login":"bethanylang","author_association":"COLLABORATOR","created_at":"2023-09-07T11:51:15+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710024895","fragment_type":"issue_comment","sequence":6,"text":"Hi @10upsimon, thanks for your further investigation on this one.\n\nAs discussed on Slack, it does sound likely that the case whereby you manually construct a chart via the JS console is not really representative of a real-world scenario, particularly as you've noted that copying the same code into the page body does not result in an error. That said, if you do have those snippets to hand and can paste them here, I'd be interested to see the code just for a clearer picture of things.\n\nI'm also interested to know if you've verified the proposed fix works when using the Google Translate extension in addition to G Translate, it would be good to have this assurance that it's a general purpose fix.\n\nWith regard to your question about testing, I'd agree, this isn't a case that we need to add any additional test coverage for. Our existing tests should provide coverage for general chart rendering, and it's probably not worth adding an E2E test for the integrated case with Google Translate.","author_login":"techanvil","author_association":"COLLABORATOR","created_at":"2023-09-07T11:59:53+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710120228","fragment_type":"issue_comment","sequence":7,"text":"@techanvil I can confirm that using the Google Translate Extension is a success as well as using the GTranslate plugin. Both work when the default/fallback value is updated to `{}`;\n\nAs for the snippet I was inserting, here it is:\n\nconst script = document.createElement('script');\nscript.src = ' URL \ndocument.body.appendChild( script );\n\nfunction drawChart() {\n\n // Create the data table.\n var data = new window.google.visualization.DataTable();\n data.addColumn('string', 'Topping');\n data.addColumn('number', 'Slices');\n data.addRows([\n ['Mushrooms', 3],\n ['Onions', 1],\n ['Olives', 1],\n ['Zucchini', 1],\n ['Pepperoni', 2]\n ]);\n\n // Set chart options\n var options = {'title':'How Much Pizza I Ate Last Night',\n 'width':400,\n 'height':300};\n\n // Instantiate and draw our chart, passing in some options.\n var chart = new window.google.visualization.PieChart(document.getElementById('wpbody'));\n chart.draw(data, options);\n }\n\nscript.onload = () => {\n console.log('Script loaded successfuly');\n // Load the Visualization API and the corechart package.\n google.charts.load('current', {'packages':['corechart']});\n\n // Set a callback to run when the Google Visualization API is loaded.\n google.charts.setOnLoadCallback(drawChart);\n};\n\nHere are the console errors that arise (in the SK dashboard) as a result:\n\n<img width=\"705\" alt=\"image\" src=\" URL \n\nIt is an odd error given that `new` is clearly used in the code, but I also suspect this is somewhat totally disconnected to the SK app and somewhat irrelevant, it was merely an observation while testing.","author_login":"10upsimon","author_association":"COLLABORATOR","created_at":"2023-09-07T13:06:56+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710244310","fragment_type":"issue_comment","sequence":8,"text":"I've update the issue with estimate of 3, given that the change itself is minimal, as would be the QAB.","author_login":"10upsimon","author_association":"COLLABORATOR","created_at":"2023-09-07T14:21:47+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710322787","fragment_type":"issue_comment","sequence":9,"text":"Thank you @techanvil , I've updated to state that no additional tests are required, as IMO they do not seem warranted. Handing this over for IBR.","author_login":"10upsimon","author_association":"COLLABORATOR","created_at":"2023-09-07T15:08:25+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1714374198","fragment_type":"issue_comment","sequence":10,"text":"Hey @zutigrm, this looks good and I've merged the PR. I've also added a couple of additional points to the QAB myself, in order to spare a round trip and move this along to the QA column.","author_login":"techanvil","author_association":"COLLABORATOR","created_at":"2023-09-11T18:23:42+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1715732635","fragment_type":"issue_comment","sequence":11,"text":"### QA Update: ✅ \n\n**Verified:**\n\n- Installed GTranslate chrome extension and WordPress plugin verified the extension works.\n- Visited a page on frontend, and the gtranslate extension is translating page.\n- Tested gtranslate plugin, you can add shortcode [gtranslate] into any page, and the gtranslate widget shows and translation works.\n- Tested with the Google Translate extension as well as GTranslate.\n- No console or front end error messages.\n- Completed a regression test on the behaviour fixed in URL \n\n \n Screenshots \n\nimage\nimage\nimage\nimage\nimage","author_login":"wpdarren","author_association":"COLLABORATOR","created_at":"2023-09-12T13:31:16+08:00","repo_name":"google/site-kit-wp","issue_id":1736797139,"issue_number":7121,"issue_url":"https://github.com/google/site-kit-wp/issues/7121","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0065","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Erreur après mise a jour de core?","query_context":"Depuis la mise a jour de core de ce jour j'ai cette erreur:\n\nERROR (MainThread) [homeassistant.components.binary_sensor] linkytic: Not adding entity with invalid device info: Invalid device info {'default_manufacturer': 'ENEDIS', 'default_model': 'Compteur communiquant Linky', 'default_name': 'Linky', 'identifiers': {('linkytic', '8cf004887b4e5242b31780c04d6df0ee')}, 'manufacturer': None, 'model': None} for 'linkytic' config entry: device info needs to either describe a device, link to existing device or provide extra information.","known_context_document_ids":["gh_issue_1885543993"],"reference_answer":"Il est possible que domoticz mettait simplement de côté les lignes invalides silencieusement quand j'ai décidé de les faire remonter (justement pour aider l'utilisateur a détecter un mauvais module ou lien). Mais je ne peux le dire avec certitude, je n'ai pas regardé le code de domoticz.\n \n\nJe ne saurais dire, malheureusement mon domaine (software) commence là où le hardware fini :)\n \n \n\n~1 erreur/minute sur le lien série c'est clairement beaucoup\n \n\ntag ok, valeur ok, checksum ko\n \n \n \nFailed to validate the checksum of line 'b'?PTARIF HC.. HC.. (None) | s1 780 0b1100001100 | truncated 12 0b1100 \f | computed 44 0b101100 , | expected 60 0b111100 <\n \n\ntag ko, valeur ok, checksum inconnu\n\nCela confirme ma conclusion précédente, vous avez beaucoup de lignes incorrectes en provenance du lien série. Mon intégration doit pouvoir les gérer tout en continuant de fonctionner, c'était le but de la mise à jour et si vous avez de nouveau une erreur de type `Uncaught thread exception` (celle-ci stoppant l'execution de l'intégration) prévenez moi que je rajoute un correctif.\n\nMaintenant concernant vos erreurs/trames incorrectes en provenance du lien série, je ne saurais dire... Est-ce votre Linky qui est défectueux ? Votre connexion TIC ? Votre module série ? Le cablage ? J'ai bien peur que le seul moyen de le savoir serait de changer un élément après l'autre jusqu'à identifier le coupable. Ou alors simplement conserver l'ensemble tel quel et laisser l'intégration mettre de côté les lignes problématiques :)","answer_document_id":"gh_comment_1590684776","silver_evidence_path":["gh_comment_1710210346","gh_issue_1755571267","gh_comment_1590684776"],"evidence_issue_ids":[1885543993,1755571267],"source_repo_name":"hekmon/linkytic","source_issue_id":1885543993,"source_issue_number":14,"source_issue_url":"https://github.com/hekmon/linkytic/issues/14","target_repo_name":"hekmon/linkytic","target_issue_id":1755571267,"target_issue_number":11,"target_issue_url":"https://github.com/hekmon/linkytic/issues/11","reference_anchor_document_id":"gh_comment_1710210346","reference_answer_author":"hekmon","reference_answer_author_association":"OWNER","quality_score":82.11,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0263,"anchor_target_overlap":0.3455,"target_answer_overlap":0.2371},"issue_created_at":"2023-09-07T09:51:35+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_1885543993","fragment_type":"issue_description","sequence":0,"text":"Erreur après mise a jour de core\nDepuis la mise a jour de core de ce jour j'ai cette erreur:\n\nERROR (MainThread) [homeassistant.components.binary_sensor] linkytic: Not adding entity with invalid device info: Invalid device info {'default_manufacturer': 'ENEDIS', 'default_model': 'Compteur communiquant Linky', 'default_name': 'Linky', 'identifiers': {('linkytic', '8cf004887b4e5242b31780c04d6df0ee')}, 'manufacturer': None, 'model': None} for 'linkytic' config entry: device info needs to either describe a device, link to existing device or provide extra information.","author_login":"ConvarDeutschland","author_association":"NONE","created_at":"2023-09-07T09:51:35+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1710005700","fragment_type":"issue_comment","sequence":1,"text":"Bonjour,\n\nIdem chez moi depuis ce matin avec la mise à jour HA Core en 2023.9.0.\n\nlinkytic: Not adding entity with invalid device info: Invalid device info {'default_manufacturer': 'ENEDIS', 'default_model': 'Compteur communiquant Linky', 'default_name': 'Linky', 'identifiers': {('linkytic', 'XXXXXXXXXXXXXXXXXXXXX')}, 'manufacturer': 'ITRON', 'model': 'Compteur monophasé 60 A généralisation Linky G3 - arrivée puissance haute'} for 'linkytic' config entry: device info needs to either describe a device, link to existing device or provide extra information.\n\nMerci","author_login":"clerelus","author_association":"NONE","created_at":"2023-09-07T11:44:07+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710210346","fragment_type":"issue_comment","sequence":2,"text":"Effectivement chez moi aussi les entités sont toujours là, mais plus dans l'appareil. L'appareil est toujours là mais sans entités.\n\nOn dirait que la manière de déclarer l'identifiant de l'appareil n'est plus valide. Il faut que je regarde, pas certain de pouvoir faire ca dans l'immédiat mais merci d'avoir remonté le problème.\n\n---\n \n \n \n \n \n\nIl s'agit d'une erreur différente d'une mauvaise ligne lue sur le lien TIC qui peut être \"normale\" et non liée à l'intégration en elle même. Un exemple sur URL (1ère erreur).","author_login":"hekmon","author_association":"OWNER","created_at":"2023-09-07T14:02:21+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[1755571267],"is_known_query_context":false},{"document_id":"gh_comment_1710230107","fragment_type":"issue_comment","sequence":3,"text":"Hello, je confirme je viens de voir le même souci exactement immediatement après maj core","author_login":"superjaegermaster","author_association":"NONE","created_at":"2023-09-07T14:13:00+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710246780","fragment_type":"issue_comment","sequence":4,"text":"La première erreur dans mes logs lié à l'appareil invalide date du 25 Août. On dirait que le problème existait avant la .9 mais est devenu visible que récemment.","author_login":"hekmon","author_association":"OWNER","created_at":"2023-09-07T14:23:17+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710261783","fragment_type":"issue_comment","sequence":5,"text":"Oui j'ai deja notice ce pb dans la version 2023.8.3 mais c'était revenu en faisant un refresh\njai d'ailleur essayé un downgrade de HA en cette version et j'ai toujours le pb.","author_login":"ToyNBoys","author_association":"NONE","created_at":"2023-09-07T14:32:25+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710668304","fragment_type":"issue_comment","sequence":6,"text":"Bon j'ai désormais les certitudes suivantes :\n\n- Depuis la version du mois d'Août, Home Assistant n'aime plus la manière de déclarer l'appareil agrégeant les entités\n- Ce n'était alors pas un problème bloquant : l'appareil était bien créé mais vide, sans entités rattachées et les entités continuaient de fonctionner dans leur coin (ce qui explique que je n'ai pas vu le problème plus tôt)\n- Depuis la version 9 (de septembre) ce problème de déclaration d'appareil est devenu bloquant : les entités ne sont plus créés par Home Assistant à cause de leur lien invalide vers l'appareil\n\nPar contre, je n'ai pas encore mis le doigt sur qu'est-ce qui fait que la déclaration de l'appareil n'est plus considérée comme valide... Je continue de chercher.","author_login":"hekmon","author_association":"OWNER","created_at":"2023-09-07T19:30:02+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710674430","fragment_type":"issue_comment","sequence":7,"text":"je viens d'ouvrir ma console ESX et je vois ca..\nscreen\n\nje pense pas que ca t'aide mais sait on jamais","author_login":"ToyNBoys","author_association":"NONE","created_at":"2023-09-07T19:36:20+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710766044","fragment_type":"issue_comment","sequence":8,"text":"Cela devrait être corrigé avec la v2.0.6.\n\nPour ceux qui voudraient plus de détails :\n\n- Les appareils sont maintenant catégorisés en 3 types par Home Assistant et chacun de ces types ont un ensemble de propriétés à respecter. C'est à dire qu'il n'est plus possible de renseigner celles qui nous arrangent et d'en mélanger certaines.\n- La déclaration précédente de l'appareil définissait à la fois un `default_manufacturer` et un `manufacturer` ainsi qu'un `default_model` et un `model`. Les defaults étant des constantes au cas où l'ADCO dont le vrai constructeur et modèle sont dérivés une fois la ligne lue sur le lien série (voir entité \"Adresse du compteur\").\n- Mélanger les 2 n'est plus permis et la correction a été de définir les `manufacturer`, `model` et `name` (afin de correspondre à la définition de type `Primary`) et de retirer les `default_manufacturer`, `default_model` et `default_name` qui ne sont pas accepté en type `Primary` mais seulement `Secondary`.\n\nMerci d'avoir porté le problème à mon attention et pour votre patience.\n\nEn attente de vos retours pour fermer (ou non) cette issue !","author_login":"hekmon","author_association":"OWNER","created_at":"2023-09-07T21:01:33+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710773222","fragment_type":"issue_comment","sequence":9,"text":"cela semble bon de mon coté ! Merci encore Hekmon !\nje pense me creer une instance HA differente specialement pour l'energie qui ne serait pas mise a jour, pour justement eviter cela... qu'en penses tu ?","author_login":"ToyNBoys","author_association":"NONE","created_at":"2023-09-07T21:08:34+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710776417","fragment_type":"issue_comment","sequence":10,"text":"Bonsoir,\nMême problème en faisant la mise à jour ce matin.\n\nPlusieurs traces dans les logs :\n\n`Détails du journal (ERREUR)\nLogger: homeassistant.components.binary_sensor\nSource: helpers/entity_platform.py:621\nIntegration: Capteur binaire (documentation, issues)\nFirst occurred: 21:01:06 (1 occurrences)\nLast logged: 21:01:06\n\nlinkytic: Not adding entity with invalid device info: Invalid device info {'default_manufacturer': 'ENEDIS', 'default_model': 'Compteur communiquant Linky', 'default_name': 'Linky', 'identifiers': {('linkytic', '91352f6da5a194c179aae1534d533446')}, 'manufacturer': 'SAGEM / SAGEMCOM', 'model': None} for 'linkytic' config entry: device info needs to either describe a device, link to existing device or provide extra information.`\n\n`Détails du journal (ERREUR)\nLogger: root\nSource: helpers/entity.py:876\nFirst occurred: 21:01:06 (1 occurrences)\nLast logged: 21:01:06\n\nUncaught thread exception\nTraceback (most recent call last):\n File \"/usr/local/lib/python3.11/threading.py\", line 1038, in _bootstrap_inner\n self.run()\n File \"/config/custom_components/linkytic/serial_reader.py\", line 144, in run\n notif_callback(forced_update)\n File \"/config/custom_components/linkytic/sensor.py\", line 807, in update_notification\n self.schedule_update_ha_state(force_refresh=True)\n File \"/usr/src/homeassistant/homeassistant/helpers/entity.py\", line 876, in schedule_update_ha_state\n self.hass.create_task(\n ^^^^^^^^^^^^^^^^^^^^^\nAttributeError: 'NoneType' object has no attribute 'create_task'`","author_login":"wkup","author_association":"NONE","created_at":"2023-09-07T21:11:52+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710779079","fragment_type":"issue_comment","sequence":11,"text":"Que cela représente plus de travail de maintenance pour vous @ToyNBoys :D\nAprès si la fiabilité et la disponibilité des informations liées à l'énergie est importante voir critique, cela peut s'entendre j'imagine !\n\nMais mon avis est certainement biaisé car si quelque chose se casse... je n'ai qu'à le réparer sans forcément dépendre de quelqu'un d'autre. C'est un plus ;)\n\n---\n \n \n \n \n \n \n \n \n \n \n \n\n@wkup vous semblez utiliser la version 2.0.5, avez-vous essayé la version 2.0.6 mis en ligne il y a quelques minutes et indiqué 2 messages plus haut ?","author_login":"hekmon","author_association":"OWNER","created_at":"2023-09-07T21:14:34+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710783726","fragment_type":"issue_comment","sequence":12,"text":"Merci pour votre avis ! Je vais ptet juste faire un snapshot avant de faire une Maj HA et voila... \nOui cest important pour suivre ma conso et production et si vous etes en vacances ca peux etre chiant, nayant pas vos compétences dans ce domaine... \nMerci encore en tout cas encore beau boulot !","author_login":"ToyNBoys","author_association":"NONE","created_at":"2023-09-07T21:19:34+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1711475144","fragment_type":"issue_comment","sequence":13,"text":"@hekmon La 2.06 marche pour moi, merci pour la rapidité de la mise en place d'une solution","author_login":"ConvarDeutschland","author_association":"NONE","created_at":"2023-09-08T10:54:09+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1711585872","fragment_type":"issue_comment","sequence":14,"text":"Bonjour,\nLes données redescendent bien dorénavant sur les entités. Merci @hekmon pour cette réactivité et ce travail correctif de qualité.\nUne remarque toutefois. La carte \"Energie\" de HA ne s'alimente pas de mon côté. Avez-vous constaté la même chose de votre côté ?\nMerci","author_login":"clerelus","author_association":"NONE","created_at":"2023-09-08T12:22:54+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1711640001","fragment_type":"issue_comment","sequence":15,"text":"Salut, c'est ok de mon coté, regarde dans la \"configuration de l'energie\" voir si ton entité a pas sautée","author_login":"ToyNBoys","author_association":"NONE","created_at":"2023-09-08T13:04:12+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1711835274","fragment_type":"issue_comment","sequence":16,"text":"Vu que le problème semble corrigé, je clos cette issue. Mais vous pouvez bien entendu continuer à discuter dessus si nécessaire.","author_login":"hekmon","author_association":"OWNER","created_at":"2023-09-08T15:18:02+08:00","repo_name":"hekmon/linkytic","issue_id":1885543993,"issue_number":14,"issue_url":"https://github.com/hekmon/linkytic/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1755571267","fragment_type":"issue_description","sequence":0,"text":"Plusieurs Erreurs\nBonjour, \nDéjà merci pour votre travail, depuis plusieurs jours j’essaye de faire fonctionner le soft sous home assistant mais j’ai plusieurs erreurs dans les logs et arrêt après 1 min ou 2 de fonctionnement…\nPouvez-vous m’aidez ? \n\n1 erreur : \n\nLogger: custom_components.linkytic.serial_reader\nSource: custom_components/linkytic/serial_reader.py:112 \nIntegration: Linky TIC (documentation, issues) \nFirst occurred: 21:47:48 (2 occurrences) \nLast logged: 21:48:59\n\nFailed to validate the checksum of line 'b'ISOUSC 45 \\x7f'': ISOUSC -> 45 (None) | s1 607 0b1001011111 | truncated 31 0b11111 \u001f | computed 63 0b111111 ? | expected 127 0b1111111 \n\n2 erreurs :\n\nUncaught thread exception\nTraceback (most recent call last):\n File \"/usr/local/lib/python3.11/threading.py\", line 1038, in _bootstrap_inner\n self.run()\n File \"/config/custom_components/linkytic/serial_reader.py\", line 112, in run\n tag = self._parse_line(line)\n ^^^^^^^^^^^^^^^^^^^^^^\n File \"/config/custom_components/linkytic/serial_reader.py\", line 295, in _parse_line\n self._validate_checksum(tag, timestamp, field_value, checksum)\n File \"/config/custom_components/linkytic/serial_reader.py\", line 334, in _validate_checksum\n raise InvalidChecksum(\n ^^^^^^^^^^^^^^^^\n File \"/config/custom_components/linkytic/serial_reader.py\", line 369, in __init__\n self.tag = tag.decode(\"ascii\")\n ^^^^^^^^^^^^^^^^^^^\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xbf in position 2: ordinal not in range(128)\n\nMerci par avance .","author_login":"baby-scarf","author_association":"NONE","created_at":"2023-06-13T20:03:05+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590031286","fragment_type":"issue_comment","sequence":1,"text":"Bonjour @baby-scarf ,\n\nRegardons cela ensemble.\n\n**1ère erreur**\nLa première erreur tout d'abord, en soit elle n'a rien d'inquiétant. Chaque ligne sur la connexion série possède à la fin un checksum pour valider l'intégrité de la ligne (et permettre de détecter une ligne invalide et éviter la remontée d'une mauvaise information). Cela peut arriver de temps en temps d'avoir une ligne invalide pour diverses raisons (mauvaise qualité du lien série, perturbation électromagnétique changeant la valeur d'un bit, etc...). L'important est simplement de ne pas en avoir trop souvent (sinon le câble ou le module série devrait être examinés voir remplacés).\n\nEn y regardant de plus près, le checksum remonté par l'erreur semble être `0x7f` ce qui est normalement (c'est à dire d'après le standard Enedis)... impossible : celui-ci de devrait se trouver qu'entre `0x20` et `0x5f`. Il semble donc que la perturbation ait impacté les bits composant le checksum (le nom du tag `ISOUSC` et sa valeure `45` semblent elles être normales) et l'intégration a donc décidé de ne pas prendre en compte cette dernière ne pouvant la vérifier. Comportement normal donc.\n\n**2eme erreur**\nConcernant la seconde erreur, c'est elle qui vous cause problème dans le sens où elle arrête le thread de série car l'erreur n'est pas prévue. Cette dernière prend racine lors de la formation d'une erreur de lecture série (comme la première) mais n'arrive pas à finaliser la remontée de cette erreur (où vous auriez eu une erreur du même format que la première).\n\nLe détails de la seconde erreur semble indiquer que cette fois ci le tag comporte des bits invalides, amenant la définition d'un seul caractère (`in position 2`) hors des valeurs possibles de l'encoding ASCII utilisé par ENEDIS sur le lien TIC.\n\n**Donc ?**\nJe vais regarder pour publier rapidement une nouvelle version gérant correctement la seconde erreur pour éviter le crash du thread de gestion de la connexion série (je n'avais encore jamais eu de problèmes à ce niveau là) : cela ne corrigera pas l'erreur en elle même mais, comme pour la première, cela permettra de mettre la ligne de côté et de continuer à traiter les suivantes : l'intégration continuera de fonctionner malgré ces erreurs.\n\nPar contre... Je ne vous cache qu'il est hautement inhabituel d'avoir autant d'erreurs sur un lien série et en aussi peu de temps. Quel module TIC/série utilisez vous ? La connexion série entre le TIC du Linky et le module est-elle bien en place ? Le câble n'est-il pas abimé ? Y a-t-il une source de pollution électromagnétique proche ? (des câbles trop fins pourraient être simplement trop sensibles par rapport a des câbles gainés).","author_login":"hekmon","author_association":"OWNER","created_at":"2023-06-13T21:09:35+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590043929","fragment_type":"issue_comment","sequence":2,"text":"Pouvez-vous essayer la version 2.0.5 ? Elle devrait éviter l'arrêt de fonctionnement de l'intégration pour les cas comme votre seconde erreur.\n\nJe vous encourage tout de même à surveiller les logs de l'intégration et les erreurs de validation de lignes (comme votre première erreur) : il peut arriver d'en avoir mais cela est sensé être des cas rares et isolés et non fréquents (cf mon dernier message).","author_login":"hekmon","author_association":"OWNER","created_at":"2023-06-13T21:22:31+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590514561","fragment_type":"issue_comment","sequence":3,"text":"Bonjour, \n\nmerci pour votre efficacité et rapidité, je vais essayé de répondre à vos questions.\nJ’utilise un module fabriqué par moi à base optocoupleur 814 et quelques résistances relié au linky avec du câble fin téléphone, pourtant ce module même fonctionné très bien avec domoticz. \nsi c’est vraiment mon module après plusieurs essais je le remplacerai par la suite.\nTous mon matériel est branché au niveau de tableau général proche de la freebox, un Rflink. \nJ’ai mis en place votre correction ce matin je vous tiens informer de la suite .\n\nune question : est il possible de branché mon module directement sur le port GPIO du raspberry comme je fesais avant pour domoticz ?","author_login":"baby-scarf","author_association":"NONE","created_at":"2023-06-14T05:52:10+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590518340","fragment_type":"issue_comment","sequence":4,"text":"Un log après 1 heure de fonctionnement : \n\nLogger: custom_components.linkytic.serial_reader\nSource: custom_components/linkytic/serial_reader.py:112 \nIntegration: Linky TIC (documentation, issues) \nFirst occurred: 06:44:57 (66 occurrences) \nLast logged: 07:51:54\n\nFailed to validate the checksum of line 'b'ISOUSC 45 \\x7f'': ISOUSC -> 45 (None) | s1 607 0b1001011111 | truncated 31 0b11111 \u001f | computed 63 0b111111 ? | expected 127 0b1111111 \nFailed to validate the checksum of line 'b'\\xbfPTARIF HC.. -> HC.. (None) | s1 908 0b1110001100 | truncated 12 0b1100 \f | computed 44 0b101100 , | expected 60 0b111100 HC.. (None) | s1 740 0b1011100100 | truncated 36 0b100100 $ | computed 68 0b1000100 D | expected 60 0b111100 HC.. (None) | s1 780 0b1100001100 | truncated 12 0b1100 \f | computed 44 0b101100 , | expected 60 0b111100 -> 000000 (None) | s1 1000 0b1111101000 | truncated 40 0b101000 ( | computed 72 0b1001000 H | expected 66 0b1000010 B","author_login":"baby-scarf","author_association":"NONE","created_at":"2023-06-14T05:55:48+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590684776","fragment_type":"issue_comment","sequence":5,"text":"Il est possible que domoticz mettait simplement de côté les lignes invalides silencieusement quand j'ai décidé de les faire remonter (justement pour aider l'utilisateur a détecter un mauvais module ou lien). Mais je ne peux le dire avec certitude, je n'ai pas regardé le code de domoticz.\n \n\nJe ne saurais dire, malheureusement mon domaine (software) commence là où le hardware fini :)\n \n \n\n~1 erreur/minute sur le lien série c'est clairement beaucoup\n \n\ntag ok, valeur ok, checksum ko\n \n \n \nFailed to validate the checksum of line 'b'?PTARIF HC.. HC.. (None) | s1 780 0b1100001100 | truncated 12 0b1100 \f | computed 44 0b101100 , | expected 60 0b111100 <\n \n\ntag ko, valeur ok, checksum inconnu\n\nCela confirme ma conclusion précédente, vous avez beaucoup de lignes incorrectes en provenance du lien série. Mon intégration doit pouvoir les gérer tout en continuant de fonctionner, c'était le but de la mise à jour et si vous avez de nouveau une erreur de type `Uncaught thread exception` (celle-ci stoppant l'execution de l'intégration) prévenez moi que je rajoute un correctif.\n\nMaintenant concernant vos erreurs/trames incorrectes en provenance du lien série, je ne saurais dire... Est-ce votre Linky qui est défectueux ? Votre connexion TIC ? Votre module série ? Le cablage ? J'ai bien peur que le seul moyen de le savoir serait de changer un élément après l'autre jusqu'à identifier le coupable. Ou alors simplement conserver l'ensemble tel quel et laisser l'intégration mettre de côté les lignes problématiques :)","author_login":"hekmon","author_association":"OWNER","created_at":"2023-06-14T08:05:07+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1632746748","fragment_type":"issue_comment","sequence":6,"text":"Bonjour @baby-scarf ,\n\nSans retour de votre part je me verrai contraint de fermer cette issue.","author_login":"hekmon","author_association":"OWNER","created_at":"2023-07-12T15:23:45+08:00","repo_name":"hekmon/linkytic","issue_id":1755571267,"issue_number":11,"issue_url":"https://github.com/hekmon/linkytic/issues/11","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0067","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"scrollable modal opens at the end of the page?","query_context":"### Flux version\n\nv1.1.6\n\n### Livewire version\n\nv3.6.1\n\n### Tailwind version\n\nv3.4.13\n\n### Browser and Operating System\n\nSafari on macOS\n\n### What is the problem?\n\nIf a modal contains so much text that it needs to be scrolled and there is a link or button at the bottom, the focus jumps to it and the page is displayed from the bottom.\n\n### Code snippets\n\n \n \n Edit profile \n \n\n \n \n Update profile \n Make changes to your personal details. \n \n\n Optat adis eum ad quam non nossequi offictatur? Qui odionse quamus reheni as dolento corersp elecest maximus net milisim quatiumquis es volorestia seque qui aut lab iduntib eaquidu ciligen daepro dit fugias doloremolent lacearci bla quam, cum vellabo ribusa vel et volupta ad quodiorit aceperum fugia simoluptur aut plam que vel eatur, ut volor simagnatur? Quideni ssitionsed quodis rerferuptas ella doluptate perest, ut volorpo rescimus doluptat acea iliquam, sentibu sdaniatiist, con prae repedi quamus nullorias quas essimus consed moluptae es aut perum doluptatur, id mostoreces idelibus dent mo optate ressimus, omnimag nimoles sunt, sini conseque consequae. Nis porrum, ulliqui ipsum consequo volorest hil imusandamus am quis sequiat iaecaborendi consequos non coneceribus quis quia exerferio ea cum ent, voluptaquis et ipsam quam hillit, sum sunt volorpos autem ium earchil eturit qui dolorro mincidignim faccum fugia nus illignis essitat empossequam dolupiendi conesciis deribus ea que num inullam quam conseque volum quam laborep tatempo raeculpa esed quiatust endicie ndanducima aut landae ra voluptios dolupta tiuntem. Simet latur arit, tem ati odit utescia spitatur? Aquunda consequia dolenih icimpor eiciam, comni commolo maximusam voles quam ea dis int adigendi aturiataqui ilignat inveruptas volorem rerum quis ea quuntot atempedit et aut autaquat.\n Hilit, omnite cupiendi ulpa quod quiandi taquame ntiandam, num et veliqui quam quibus accuptur adi omnis aris antinimin nihilit optur aborendipsam dolorio vendusa dipicabor aditi optur, ut aribusae sitati oditatat reptiatium quas por as molut omnihit, tet ipicienem ut aut aut fuga. Item nonsendias dunto essum utatio. Ugiatem olupis adit erspers pidunt quatem etus voloriam ut molestem et as ma quam et acillore, sunt.\n Us. Me re venis aut quam quae cum di dolupti aspidebis dolupiciatas aut aut perro tecto officiduciam rem sunt et omniendellit quiaspe riatur, accatetur?\n Arum et rem utata dolorum doluptaquam rem se qui odi consed ut quam re cores esent oditi ipsant volo venimpos et eum eneceperum di officia dolore etum reictur alignient ra simporrum faccum alitaqui officate volo temo enihil experio. Culluptas dem hillab int ad et occatis sequunt qui rest, quam rest, ium nia vitatemporum quaspicium asiminu llitis eos rem exerror ruptatia experit la pa si aut unt, si nonsequam elia nihic temolum ut quat.\n At enet qui omniend ipitaes nonsequ idesti incto exceperum volorum enisinum quia conet accum repti dus el incitate officilitat.\n Les eosam il ipsanientem il ipsaperi omnimi, si dus dis dellam, serit, occuptation porior aut as seque poreped quatur maiost, consequo et que doloremque pre, nossendia susda cus suntio. Idunt volo exeriatum volestrum voluptatium volupta tiorro blam est quiae vero dolor aut lab id est, quam, te poriore pelictio. Namus, comnimo te verum qui int alia nos velloriandam que nist doluptatur a nulpa quisci beris velia voluptatem id et oditincid qui utes ra verio. Ga. Nempos aut dolest faccae ea quamet rerissimusam res restrum ese et aut que dolore pro ipisque sintem. Udipici demquos ad quia dendem volorrum fugiaepudi cullabor sae minus, occusan imendae cepero ium liatqui dolore venim facessitius volut fugiaspit, quis aut am quam, qui volectem fuga. Animusciis et, tecum eumquib usandaest offic tem aceaquaest, solo conse ditium veri duntusaped molupiducidi dolorestrum dolupta epudicitae nonesci atetur aspel experrum, officipsam quas pe mo iligendantet que ventem iurest iuri adi aut molut re cum fuga. Fic totatium et es maximustent.\n Ame et repratum que earchit, cum voluptatam, ese aut rem dolor atem exeriatiusae rem doluptae solut estrum alique nonem volupic illecab istotatatur? Qui berescia pre coria vidio voluptaqui quae dolluptas alis rerum doluptatem que dolest ut que nobist quiaepe dignatibus debis molupta temquidunt qui dolupta sit doluptatias perume volo tem. Culpari te perro omnit es mos explant que nossum reptat quiam imaio doloreiume lacestet qui net que ped quis debit ma vendae rera quaeper natquis verum im is earciet eariam volorest, sim re odis et ipiendant as doluptium fuga. Edicae. Uritia prorectet, tem fugia que vollab ipiendi commodit harumqu undant rerfercim reris ut verrovid ut harcipsa cusdant doluptatem fuga. Ita pres sum hil imped eveliquis dus voluptur?\n Andis dolupture officta temporitati omnimpos andanda ntendio nserumquo officilique doloruntem ium voluptaquia siment experferatem nonsed et, suntis alicte consed quid ma sum ex etus solorescia dolut optaera quunditius, volum harumqu asitio eum qui omnimil lendae prorit re, voluptatis doluptae sae essincient as modipitiis rerum quam fugiatibus, simus quam, offictemque cus, sumquod ignimporum doluptas repudicto berumquas quaspic tem eos qui con cusa quis quae pora cuptios ime dolore volora numque consendio. Ut rem harumet excerrum est anditibus si id que pa vollend untiorro exceptate volorep eribus molore voluptat officia sperum as andae. Ugitas esciam, ommoloraes etus sit autes veligende int eatus.\n Borporum qui dus, con rest laboriae nessit exceperempor alita doluptatiat. \n\n \n \n HTML;\n }\n}\n\n### How do you expect it to work?\n\nThe modal should open from the top.\n\n### Please confirm (incomplete submissions will not be addressed)\n\n- [x] I have provided easy and step-by-step instructions to reproduce the bug.\n- [x] I have provided code samples as text and NOT images.\n- [x] I understand my bug report will be closed if I haven't met the criteria above.","known_context_document_ids":["gh_issue_2911280606"],"reference_answer":"@jradtilbrook thanks for the link! I just tested adding autofocus to the dialog itself, but it didn't seem to do anything. If you can give me an example of that working, I'd be happy to see if I can get working with Flux's modal.","answer_document_id":"gh_comment_2686658198","silver_evidence_path":["gh_comment_2716284862","gh_issue_2736394528","gh_comment_2686658198"],"evidence_issue_ids":[2911280606,2736394528],"source_repo_name":"livewire/flux","source_issue_id":2911280606,"source_issue_number":1302,"source_issue_url":"https://github.com/livewire/flux/issues/1302","target_repo_name":"livewire/flux","target_issue_id":2736394528,"target_issue_number":854,"target_issue_url":"https://github.com/livewire/flux/issues/854","reference_anchor_document_id":"gh_comment_2716284862","reference_answer_author":"joshhanley","reference_answer_author_association":"MEMBER","quality_score":93.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.4,"target_answer_overlap":0.2222},"issue_created_at":"2025-03-11T17:03:30+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2911280606","fragment_type":"issue_description","sequence":0,"text":"scrollable modal opens at the end of the page\n### Flux version\n\nv1.1.6\n\n### Livewire version\n\nv3.6.1\n\n### Tailwind version\n\nv3.4.13\n\n### Browser and Operating System\n\nSafari on macOS\n\n### What is the problem?\n\nIf a modal contains so much text that it needs to be scrolled and there is a link or button at the bottom, the focus jumps to it and the page is displayed from the bottom.\n\n### Code snippets\n\n \n \n Edit profile \n \n\n \n \n Update profile \n Make changes to your personal details. \n \n\n Optat adis eum ad quam non nossequi offictatur? Qui odionse quamus reheni as dolento corersp elecest maximus net milisim quatiumquis es volorestia seque qui aut lab iduntib eaquidu ciligen daepro dit fugias doloremolent lacearci bla quam, cum vellabo ribusa vel et volupta ad quodiorit aceperum fugia simoluptur aut plam que vel eatur, ut volor simagnatur? Quideni ssitionsed quodis rerferuptas ella doluptate perest, ut volorpo rescimus doluptat acea iliquam, sentibu sdaniatiist, con prae repedi quamus nullorias quas essimus consed moluptae es aut perum doluptatur, id mostoreces idelibus dent mo optate ressimus, omnimag nimoles sunt, sini conseque consequae. Nis porrum, ulliqui ipsum consequo volorest hil imusandamus am quis sequiat iaecaborendi consequos non coneceribus quis quia exerferio ea cum ent, voluptaquis et ipsam quam hillit, sum sunt volorpos autem ium earchil eturit qui dolorro mincidignim faccum fugia nus illignis essitat empossequam dolupiendi conesciis deribus ea que num inullam quam conseque volum quam laborep tatempo raeculpa esed quiatust endicie ndanducima aut landae ra voluptios dolupta tiuntem. Simet latur arit, tem ati odit utescia spitatur? Aquunda consequia dolenih icimpor eiciam, comni commolo maximusam voles quam ea dis int adigendi aturiataqui ilignat inveruptas volorem rerum quis ea quuntot atempedit et aut autaquat.\n Hilit, omnite cupiendi ulpa quod quiandi taquame ntiandam, num et veliqui quam quibus accuptur adi omnis aris antinimin nihilit optur aborendipsam dolorio vendusa dipicabor aditi optur, ut aribusae sitati oditatat reptiatium quas por as molut omnihit, tet ipicienem ut aut aut fuga. Item nonsendias dunto essum utatio. Ugiatem olupis adit erspers pidunt quatem etus voloriam ut molestem et as ma quam et acillore, sunt.\n Us. Me re venis aut quam quae cum di dolupti aspidebis dolupiciatas aut aut perro tecto officiduciam rem sunt et omniendellit quiaspe riatur, accatetur?\n Arum et rem utata dolorum doluptaquam rem se qui odi consed ut quam re cores esent oditi ipsant volo venimpos et eum eneceperum di officia dolore etum reictur alignient ra simporrum faccum alitaqui officate volo temo enihil experio. Culluptas dem hillab int ad et occatis sequunt qui rest, quam rest, ium nia vitatemporum quaspicium asiminu llitis eos rem exerror ruptatia experit la pa si aut unt, si nonsequam elia nihic temolum ut quat.\n At enet qui omniend ipitaes nonsequ idesti incto exceperum volorum enisinum quia conet accum repti dus el incitate officilitat.\n Les eosam il ipsanientem il ipsaperi omnimi, si dus dis dellam, serit, occuptation porior aut as seque poreped quatur maiost, consequo et que doloremque pre, nossendia susda cus suntio. Idunt volo exeriatum volestrum voluptatium volupta tiorro blam est quiae vero dolor aut lab id est, quam, te poriore pelictio. Namus, comnimo te verum qui int alia nos velloriandam que nist doluptatur a nulpa quisci beris velia voluptatem id et oditincid qui utes ra verio. Ga. Nempos aut dolest faccae ea quamet rerissimusam res restrum ese et aut que dolore pro ipisque sintem. Udipici demquos ad quia dendem volorrum fugiaepudi cullabor sae minus, occusan imendae cepero ium liatqui dolore venim facessitius volut fugiaspit, quis aut am quam, qui volectem fuga. Animusciis et, tecum eumquib usandaest offic tem aceaquaest, solo conse ditium veri duntusaped molupiducidi dolorestrum dolupta epudicitae nonesci atetur aspel experrum, officipsam quas pe mo iligendantet que ventem iurest iuri adi aut molut re cum fuga. Fic totatium et es maximustent.\n Ame et repratum que earchit, cum voluptatam, ese aut rem dolor atem exeriatiusae rem doluptae solut estrum alique nonem volupic illecab istotatatur? Qui berescia pre coria vidio voluptaqui quae dolluptas alis rerum doluptatem que dolest ut que nobist quiaepe dignatibus debis molupta temquidunt qui dolupta sit doluptatias perume volo tem. Culpari te perro omnit es mos explant que nossum reptat quiam imaio doloreiume lacestet qui net que ped quis debit ma vendae rera quaeper natquis verum im is earciet eariam volorest, sim re odis et ipiendant as doluptium fuga. Edicae. Uritia prorectet, tem fugia que vollab ipiendi commodit harumqu undant rerfercim reris ut verrovid ut harcipsa cusdant doluptatem fuga. Ita pres sum hil imped eveliquis dus voluptur?\n Andis dolupture officta temporitati omnimpos andanda ntendio nserumquo officilique doloruntem ium voluptaquia siment experferatem nonsed et, suntis alicte consed quid ma sum ex etus solorescia dolut optaera quunditius, volum harumqu asitio eum qui omnimil lendae prorit re, voluptatis doluptae sae essincient as modipitiis rerum quam fugiatibus, simus quam, offictemque cus, sumquod ignimporum doluptas repudicto berumquas quaspic tem eos qui con cusa quis quae pora cuptios ime dolore volora numque consendio. Ut rem harumet excerrum est anditibus si id que pa vollend untiorro exceptate volorep eribus molore voluptat officia sperum as andae. Ugitas esciam, ommoloraes etus sit autes veligende int eatus.\n Borporum qui dus, con rest laboriae nessit exceperempor alita doluptatiat. \n\n \n \n HTML;\n }\n}\n\n### How do you expect it to work?\n\nThe modal should open from the top.\n\n### Please confirm (incomplete submissions will not be addressed)\n\n- [x] I have provided easy and step-by-step instructions to reproduce the bug.\n- [x] I have provided code samples as text and NOT images.\n- [x] I understand my bug report will be closed if I haven't met the criteria above.","author_login":"DonCamillo11","author_association":"NONE","created_at":"2025-03-11T17:03:30+08:00","repo_name":"livewire/flux","issue_id":2911280606,"issue_number":1302,"issue_url":"https://github.com/livewire/flux/issues/1302","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2715444614","fragment_type":"issue_comment","sequence":1,"text":"@DonCamillo11 I think this is similar to URL \n\nHave a look at this as a workaround: URL","author_login":"jeffchown","author_association":"NONE","created_at":"2025-03-11T19:12:22+08:00","repo_name":"livewire/flux","issue_id":2911280606,"issue_number":1302,"issue_url":"https://github.com/livewire/flux/issues/1302","linked_issue_ids":[2736394528],"is_known_query_context":false},{"document_id":"gh_comment_2715568459","fragment_type":"issue_comment","sequence":2,"text":"@jeffchown tried this workaround, but doesn’t seem to work in my case","author_login":"DonCamillo11","author_association":"NONE","created_at":"2025-03-11T19:59:26+08:00","repo_name":"livewire/flux","issue_id":2911280606,"issue_number":1302,"issue_url":"https://github.com/livewire/flux/issues/1302","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2716284862","fragment_type":"issue_comment","sequence":3,"text":"@DonCamillo11 thanks for reporting and the help @jeffchown! I'm going to close this as it's a duplicate of #854. If you could add a comment to that issue and mention your work around, that'd be great, thanks!","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-03-12T03:06:10+08:00","repo_name":"livewire/flux","issue_id":2911280606,"issue_number":1302,"issue_url":"https://github.com/livewire/flux/issues/1302","linked_issue_ids":[2736394528],"is_known_query_context":false},{"document_id":"gh_issue_2736394528","fragment_type":"issue_description","sequence":0,"text":"Autofocus in modals forcing screenreaders to the end of the modal\n### Flux version\n\n1.0.23\n\n### Livewire version\n\n3.5.12\n\n### What is the problem?\n\nWhen you use a Flux modal, it autofocuses whatever is actionable (like an input or a button) within the modal. This makes sense for a sighted user who can read the modal's content then proceed to interact with whatever actionable element is focused. However for a screenreader, unless the actionable element is the absolute first one in the modal the autofocus skips them over the regular flow in the modal. This means that in order to fully read a modal screenreaders have to scan backwards from the actionable element to any text elements (like headings or paragraphs) then navigate forward again which isn't very accessible since people with vision impairments can't see that there's more content to navigate to. \n\nOriginally reported in this discussion thread: URL \n\n### Code snippets\n\nOn the site I'm trying to meet accessibility on, I have modals with a heading, text, then an action button at the bottom. However because of the autofocus functionality the user is automatically being forced to the bottom of my modal. You should be able to recreate this with any Flux modal with both text elements and actionable items, but since this ask for how to reproduce it, this is the exact code I've been using when testing this issue:\n\nI've customized the modal component to allow me to have my close action as a button instead of a standard x (only change is to the close button section)\n\nblade\n \n \n {{ $trigger }}\n \n\n class($classes) }}\n @if ($name) data-modal=\"{{ $name }}\" @endif\n @if ($variant === 'flyout') data-flux-flyout @endif\n x-data\n @isset($__livewire)\n x-on:modal-show.document=\"\n if ($event.detail.name === @js($name) && ($event.detail.scope === @js($__livewire->getId()))) $el.showModal();\n if ($event.detail.name === @js($name) && (! $event.detail.scope)) $el.showModal();\n \"\n x-on:modal-close.document=\"\n if ($event.detail.name === @js($name) && ($event.detail.scope === @js($__livewire->getId()))) $el.close();\n if (! $event.detail.name || ($event.detail.name === @js($name) && (! $event.detail.scope))) $el.close();\n \"\n @else\n x-on:modal-show.document=\"if ($event.detail.name === @js($name) && (! $event.detail.scope)) $el.showModal()\"\n x-on:modal-close.document=\"if (! $event.detail.name || ($event.detail.name === @js($name) && (! $event.detail.scope))) $el.close()\"\n @endif\n \n {{ $slot }}\n\n {{-- start of my customization --}}\n @if($close_type == 'button')\n \n \n \n @elseif($closable)\n {{-- This \"[&[hidden]]:block\" hack is here to prevent this element from effecting classes like \"space-y-6\" --}}\n \n \n \n \n \n @endif\n {{-- end of my customization --}}\n \n \n\n \n\nThen the modal I'm actually testing with looks like so:\n\nblade\n \n \n \n View Help Text \n \n \n\n \n \n \n Average Fuel Economy\n \n\n The Fuel Economy rating displayed is an average for operation while in gasoline mode only. Actual total energy usage will vary depending on daily distances driven in relation to the vehicle’s EV-mode range, as PHEV vehicles switch over to gasoline mode once battery charge is exhausted. \n \n\nMy actual modal looks like this:\nImage\n\n### How do you expect it to work?\n\nI would expect that the modal would allow the screenreader to focus on the first element first, then move through the modal in normal document flow instead of being autofocused and forced to skip around in the document flow in order to get all of the content out of a modal. Whether this is the ability to turn off autofocus in modals or choose which element gets focus first, either would work to allow developers to create accessible modals!\n\n### Please confirm (incomplete submissions will not be addressed)\n\n- [x] I have provided easy and step-by-step instructions to reproduce the bug.\n- [x] I have provided code samples as text and NOT images.\n- [x] I understand my bug report will be closed if I haven't met the criteria above.","author_login":"stuininga1","author_association":"NONE","created_at":"2024-12-12T16:40:53+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2563742536","fragment_type":"issue_comment","sequence":1,"text":"I second that! There should be option to disable autofocus for inputs within modal. Espacially when modal is a flyout\n\n \n\nIn this example I have some text and images preceding the form and do not want to be focused on the form straight away.","author_login":"aurawindsurfing","author_association":"NONE","created_at":"2024-12-27T14:14:59+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564159979","fragment_type":"issue_comment","sequence":2,"text":"One workaround may be to add:\n\n \n\nat the top of your form (or in whatever position will best serve your modal.","author_login":"jeffchown","author_association":"NONE","created_at":"2024-12-28T03:51:03+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586077549","fragment_type":"issue_comment","sequence":3,"text":"For now we are going to add support for adding `:autofocus=\"false\"` to turn off autofocus in modals.","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-01-13T02:46:05+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586176632","fragment_type":"issue_comment","sequence":4,"text":"I've investigated this and at the moment the focus is actually coming from the native Dialog element. It by default focuses the first focusable element in the dialog.\n\nI can't find a simple way to disable the autofocus for the Dialog element. Instead there are a bunch of solutions similar to @jeffchown's which suggest to add a hidden input at the top of the Dialog which is focusable.\n\n@stuininga1 do you have any experience with screen readers and the native Dialog element or any suggestions on how best to handle it?","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-01-13T04:59:07+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2686616129","fragment_type":"issue_comment","sequence":5,"text":"@joshhanley I've run into something similar, I see MDN says you could add autofocus to the dialog itself to effectively disable. Does that mean we could actually get a `:autofocus=\"false\"` attribute that does it this way?","author_login":"jradtilbrook","author_association":"NONE","created_at":"2025-02-27T02:02:13+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2686658198","fragment_type":"issue_comment","sequence":6,"text":"@jradtilbrook thanks for the link! I just tested adding autofocus to the dialog itself, but it didn't seem to do anything. If you can give me an example of that working, I'd be happy to see if I can get working with Flux's modal.","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-02-27T02:14:00+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2686673445","fragment_type":"issue_comment","sequence":7,"text":"Ah yes I initially implemented it in firefox and it worked. But now trying it in chrome, it does not 😭","author_login":"jradtilbrook","author_association":"NONE","created_at":"2025-02-27T02:16:15+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2686683457","fragment_type":"issue_comment","sequence":8,"text":"@jradtilbrook ah bummer 😕 that would have been great if it worked across all browsers.","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-02-27T02:17:42+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2686698748","fragment_type":"issue_comment","sequence":9,"text":"Only other thing I think we might be able to do is a autofocused \"Skip to content\" button like GitHub and Google have.","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-02-27T02:30:36+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2743990265","fragment_type":"issue_comment","sequence":10,"text":"Hi everyone, adding autfocus to a different element inside the dialog works well when opening it. This way at least you get control on what gets it at first.","author_login":"minti2","author_association":"NONE","created_at":"2025-03-21T17:19:26+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2799034851","fragment_type":"issue_comment","sequence":11,"text":"We've managed to add support so that dialog elements doing autofocus the first element by essentially adding a honeypot first element, that the dialog focuses, then we remove from the tab order. This ensures that a screenreader and user's focus is at the top of modal. Using `autofocus` on the dialog (if supported by the browser) or any input inside still works as expected.","author_login":"joshhanley","author_association":"MEMBER","created_at":"2025-04-12T20:51:34+08:00","repo_name":"livewire/flux","issue_id":2736394528,"issue_number":854,"issue_url":"https://github.com/livewire/flux/issues/854","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0069","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: Incomplete tool calling response for pipeline-parallel vllm with ray?","query_context":"### Your current environment\n\nvllm v0.5.4\n\nSetup A) single docker container with vllm, no pipeline-parallelism\n\ndocker run ... vllm/vllm-openai:v0.5.4 --model \"meta-llama/Meta-Llama-3.1-70B-Instruct\" --tensor-parallel-size 2 --max-model-len=4096\n\nSetup B) two docker containers with ray + vllm (pipeline parallelism)\n\ndocker run -it ... --network host --entrypoint /bin/bash vllm/vllm-openai:v0.5.4\n\n# start ray head node in one of the docker containers\nray start --head --disable-usage-stats\n\n# start ray worker node in the other docker container\nray start --address=' :6379'\n\n# start vllm in head node container\nvllm serve \"meta-llama/Meta-Llama-3.1-70B-Instruct\" --tensor-parallel-size 1 --pipeline-parallel-size 2 --distributed-executor-backend ray --max-model-len=4096\n\nThe issue does not depend on the model; e.g. it also appears with `meta-llama/Meta-Llama-3-70B-Instruct` instead of Llama-3.1\n\n### 🐛 Describe the bug\n\nWithout pipeline-parallelism, a request with tool calling is responded correctly with a valid tool call. \nWith pipeline-parallelism, the same request is responded with incomplete tool call (just a few tokens long, but still status 200). \n\nExample request:\n\n{\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"max_tokens\": 200,\n \"seed\": 8,\n \"messages\": [\n {\n \"role\": \"user\",\n \"content\": \"What is the weather like in Berlin?\"\n }\n ],\n \"tools\": [\n {\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"description\": \"Get the current weather\",\n \"parameters\": {\n \"type\": \"object\",\n \"properties\": {\n \"location\": {\n \"type\": \"string\",\n \"description\": \"The city and state, e.g. San Francisco, CA\"\n },\n \"format\": {\n \"type\": \"string\",\n \"enum\": [\"celsius\", \"fahrenheit\"],\n \"description\": \"The temperature unit to use. Infer this from the users location.\"\n }\n },\n \"required\": [\"location\", \"format\"]\n }\n }\n }\n ],\n \"tool_choice\": {\"type\": \"function\", \"function\": {\"name\": \"get_current_weather\"}}\n}\n\nResponse for setup A (no pipeline-parallelism)\n\n{\n \"id\": \"chat-a9e517fd2f0e4ac3817896596c5cc907\",\n \"object\": \"chat.completion\",\n \"created\": 1722929009,\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"choices\": [\n {\n \"index\": 0,\n \"message\": {\n \"role\": \"assistant\",\n \"content\": \"\",\n \"tool_calls\": [\n {\n \"id\": \"chatcmpl-tool-0b5f4340c31d42c19765aa5f755586a3\",\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"arguments\": \"{\\\"location\\\": \\\"Berlin\\\", \\\"format\\\": \\\"celsius\\\"}\"\n }\n }\n ]\n },\n \"logprobs\": null,\n \"finish_reason\": \"stop\",\n \"stop_reason\": null\n }\n ],\n \"usage\": {\n \"prompt_tokens\": 251,\n \"total_tokens\": 265,\n \"completion_tokens\": 14\n }\n}\n\nThe response for setup B (pipeline-parallelism with ray)\n\n{\n \"id\": \"chat-80f69a8c5403478ea0c75943e7bab3af\",\n \"object\": \"chat.completion\",\n \"created\": 1722931399,\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"choices\": [\n {\n \"index\": 0,\n \"message\": {\n \"role\": \"assistant\",\n \"content\": \"\",\n \"tool_calls\": [\n {\n \"id\": \"chatcmpl-tool-b6517d27352947969bf3d3dc8b8c6b98\",\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"arguments\": \"{\\\"location\"\n }\n }\n ]\n },\n \"logprobs\": null,\n \"finish_reason\": \"stop\",\n \"stop_reason\": null\n }\n ],\n \"usage\": {\n \"prompt_tokens\": 251,\n \"total_tokens\": 254,\n \"completion_tokens\": 3\n }\n}","known_context_document_ids":["gh_issue_2450246404"],"reference_answer":"My initial thoughts;\n\n- URL -> Plugin needs to change the API to accept stateful logit processor\n- URL -> Right now, I feel orthogonal (there are overlap, but the PR mentioned APIs are supposed to be used \"with\" logit processor, and this RFC is logit processor specific).\n- URL seems like a implementation of second part. \n- URL seems orthogonal (existing logit processors will just work)","answer_document_id":"gh_comment_2164087425","silver_evidence_path":["gh_comment_2276791605","gh_issue_2346658694","gh_comment_2164087425"],"evidence_issue_ids":[2450246404,2346658694],"source_repo_name":"vllm-project/vllm","source_issue_id":2450246404,"source_issue_number":7194,"source_issue_url":"https://github.com/vllm-project/vllm/issues/7194","target_repo_name":"vllm-project/vllm","target_issue_id":2346658694,"target_issue_number":5423,"target_issue_url":"https://github.com/vllm-project/vllm/issues/5423","reference_anchor_document_id":"gh_comment_2276791605","reference_answer_author":"rkooo567","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1463,"anchor_target_overlap":0.3171,"target_answer_overlap":0.3448},"issue_created_at":"2024-08-06T08:16:25+08:00","valid_comment_count":28,"fragments":[{"document_id":"gh_issue_2450246404","fragment_type":"issue_description","sequence":0,"text":"[Bug]: Incomplete tool calling response for pipeline-parallel vllm with ray\n### Your current environment\n\nvllm v0.5.4\n\nSetup A) single docker container with vllm, no pipeline-parallelism\n\ndocker run ... vllm/vllm-openai:v0.5.4 --model \"meta-llama/Meta-Llama-3.1-70B-Instruct\" --tensor-parallel-size 2 --max-model-len=4096\n\nSetup B) two docker containers with ray + vllm (pipeline parallelism)\n\ndocker run -it ... --network host --entrypoint /bin/bash vllm/vllm-openai:v0.5.4\n\n# start ray head node in one of the docker containers\nray start --head --disable-usage-stats\n\n# start ray worker node in the other docker container\nray start --address=' :6379'\n\n# start vllm in head node container\nvllm serve \"meta-llama/Meta-Llama-3.1-70B-Instruct\" --tensor-parallel-size 1 --pipeline-parallel-size 2 --distributed-executor-backend ray --max-model-len=4096\n\nThe issue does not depend on the model; e.g. it also appears with `meta-llama/Meta-Llama-3-70B-Instruct` instead of Llama-3.1\n\n### 🐛 Describe the bug\n\nWithout pipeline-parallelism, a request with tool calling is responded correctly with a valid tool call. \nWith pipeline-parallelism, the same request is responded with incomplete tool call (just a few tokens long, but still status 200). \n\nExample request:\n\n{\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"max_tokens\": 200,\n \"seed\": 8,\n \"messages\": [\n {\n \"role\": \"user\",\n \"content\": \"What is the weather like in Berlin?\"\n }\n ],\n \"tools\": [\n {\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"description\": \"Get the current weather\",\n \"parameters\": {\n \"type\": \"object\",\n \"properties\": {\n \"location\": {\n \"type\": \"string\",\n \"description\": \"The city and state, e.g. San Francisco, CA\"\n },\n \"format\": {\n \"type\": \"string\",\n \"enum\": [\"celsius\", \"fahrenheit\"],\n \"description\": \"The temperature unit to use. Infer this from the users location.\"\n }\n },\n \"required\": [\"location\", \"format\"]\n }\n }\n }\n ],\n \"tool_choice\": {\"type\": \"function\", \"function\": {\"name\": \"get_current_weather\"}}\n}\n\nResponse for setup A (no pipeline-parallelism)\n\n{\n \"id\": \"chat-a9e517fd2f0e4ac3817896596c5cc907\",\n \"object\": \"chat.completion\",\n \"created\": 1722929009,\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"choices\": [\n {\n \"index\": 0,\n \"message\": {\n \"role\": \"assistant\",\n \"content\": \"\",\n \"tool_calls\": [\n {\n \"id\": \"chatcmpl-tool-0b5f4340c31d42c19765aa5f755586a3\",\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"arguments\": \"{\\\"location\\\": \\\"Berlin\\\", \\\"format\\\": \\\"celsius\\\"}\"\n }\n }\n ]\n },\n \"logprobs\": null,\n \"finish_reason\": \"stop\",\n \"stop_reason\": null\n }\n ],\n \"usage\": {\n \"prompt_tokens\": 251,\n \"total_tokens\": 265,\n \"completion_tokens\": 14\n }\n}\n\nThe response for setup B (pipeline-parallelism with ray)\n\n{\n \"id\": \"chat-80f69a8c5403478ea0c75943e7bab3af\",\n \"object\": \"chat.completion\",\n \"created\": 1722931399,\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"choices\": [\n {\n \"index\": 0,\n \"message\": {\n \"role\": \"assistant\",\n \"content\": \"\",\n \"tool_calls\": [\n {\n \"id\": \"chatcmpl-tool-b6517d27352947969bf3d3dc8b8c6b98\",\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"arguments\": \"{\\\"location\"\n }\n }\n ]\n },\n \"logprobs\": null,\n \"finish_reason\": \"stop\",\n \"stop_reason\": null\n }\n ],\n \"usage\": {\n \"prompt_tokens\": 251,\n \"total_tokens\": 254,\n \"completion_tokens\": 3\n }\n}","author_login":"sfbemerk","author_association":"CONTRIBUTOR","created_at":"2024-08-06T08:16:25+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2271758907","fragment_type":"issue_comment","sequence":1,"text":"how about using a single node and pp size 2 ( so that it uses multiprocessing backend)? does it still have this issue?","author_login":"youkaichao","author_association":"MEMBER","created_at":"2024-08-06T17:10:58+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2271774413","fragment_type":"issue_comment","sequence":2,"text":"I just tested it, but the bug appears there as well:\nSetup C) one docker container with 2 GPUs (pipeline-parallel, no ray)\n\ndocker run ... vllm/vllm-openai:v0.5.4 --model \"meta-llama/Meta-Llama-3.1-70B-Instruct\" --tensor-parallel-size 1 --pipeline-parallel-size 2 --max-model-len=4096\n\nagain the incomplete response:\n\n{\n \"id\": \"chat-28622b0c3d074caead37fb5441ca2407\",\n \"object\": \"chat.completion\",\n \"created\": 1722964614,\n \"model\": \"meta-llama/Meta-Llama-3.1-70B-Instruct\",\n \"choices\": [\n {\n \"index\": 0,\n \"message\": {\n \"role\": \"assistant\",\n \"content\": \"\",\n \"tool_calls\": [\n {\n \"id\": \"chatcmpl-tool-9dfa147ec16245d7a8efd67ddfc6012f\",\n \"type\": \"function\",\n \"function\": {\n \"name\": \"get_current_weather\",\n \"arguments\": \"{\\\"location\"\n }\n }\n ]\n },\n \"logprobs\": null,\n \"finish_reason\": \"stop\",\n \"stop_reason\": null\n }\n ],\n \"usage\": {\n \"prompt_tokens\": 251,\n \"total_tokens\": 254,\n \"completion_tokens\": 3\n }\n}","author_login":"sfbemerk","author_association":"NONE","created_at":"2024-08-06T17:19:15+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2272566959","fragment_type":"issue_comment","sequence":3,"text":"I solved this, as you only need to add \"min_tokens\": **. I set it to 50 due to my completion length.","author_login":"loredunk","author_association":"NONE","created_at":"2024-08-07T03:57:49+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2273897128","fragment_type":"issue_comment","sequence":4,"text":"I did some investigation, the problem is quite deep. In the case of guided decoding we are using _stateful_ logits processors. However, in PP, the logits processors will get cloned when sent to the workers other than the driver workers. This is ok for the TP use cases since the logits processor is not cloned and the state lives as long as the sequence group does. This is an issue for beyond PP however, and will affect anything SPMD. For those cases though, one solution might be to have the logits processor live on the worker. Pinging @njhill as this is quite similar to the seed issue and he might have some suggestions on the best way to resolve it.\n\nMP GPU Executor, [ ]\nRank: 0, [ ]\n(VllmWorkerProcess pid=2199329) Rank: 1, [ ]","author_login":"andoorve","author_association":"CONTRIBUTOR","created_at":"2024-08-07T16:48:39+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274519110","fragment_type":"issue_comment","sequence":5,"text":"I think we need to overhaul logits processor part. it should not be a part of sampling parameter.\n\nsampling parameter should just store the constraint, like regex or json schema. and the constraint decoding state (i.e. FSM state) should live in each sequence. The FSM itself, with masks for every state, should be retrieved from some cache that maps from regex to FSM.","author_login":"youkaichao","author_association":"MEMBER","created_at":"2024-08-07T23:34:16+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274848309","fragment_type":"issue_comment","sequence":6,"text":"Yes exactly\n \nYup agreed\n \n\nWe can keep the FSM as part of logits processor but map from sequence to FSM in the worker similar to torch Generator. Ideally this is done in a clean and future-proof way.\n\n@rkooo567 You mention support for guided decoding in URL Is this something you're looking into?","author_login":"andoorve","author_association":"CONTRIBUTOR","created_at":"2024-08-08T02:47:19+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274937421","fragment_type":"issue_comment","sequence":7,"text":"not exactly, but to make it work with SPMD, I believe we need exactly the same solution. So I may look into it soon. URL","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-08-08T04:39:27+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274999809","fragment_type":"issue_comment","sequence":8,"text":"also totally agreed with @youkaichao. I think that's the direction we should go (and what we wanted to achieve with URL","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-08-08T05:46:11+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[2346658694],"is_known_query_context":false},{"document_id":"gh_comment_2275002749","fragment_type":"issue_comment","sequence":9,"text":"Yes @rkooo567 I think a lot of the stuff from SPMD is basically directly the same for PP.","author_login":"andoorve","author_association":"CONTRIBUTOR","created_at":"2024-08-08T05:48:59+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2276750794","fragment_type":"issue_comment","sequence":10,"text":"There is already as a PR to make the stateful logit processor shareable\n\n URL \n\nThe idea is as described; pass around logit_processor factories instead of instantiation, and then each Sequence has its own instantiation of logit_processor","author_login":"jon-chuang","author_association":"NONE","created_at":"2024-08-08T22:09:22+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2276760253","fragment_type":"issue_comment","sequence":11,"text":"To make URL work with URL I think the `SequenceDataDelta` will leave the `SequenceData.logit_processors` untouched, and logit_processor will obtain the state from `SequenceData` as per usual once it has been updated with `SequenceDataDelta`\n\nMeaning to say, probably minimal changes are required.","author_login":"jon-chuang","author_association":"NONE","created_at":"2024-08-08T22:15:43+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2276791605","fragment_type":"issue_comment","sequence":12,"text":"Absolutely, this has been planned for some time - a larger overhaul of how logits processors work is planned e.g. URL but is stalled a bit given how it needs to fit with other changes. I feel we can make some incremental improvements in the meantime, potentially starting with #5329 that @jon-chuang referenced.\n\nRe needing the state to be in the worker for PP etc, I know it's also required for SPMD but imo should just be part of making the batches stateful (same for the torch.Generators).","author_login":"njhill","author_association":"MEMBER","created_at":"2024-08-08T22:31:04+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[2346658694],"is_known_query_context":false},{"document_id":"gh_comment_2284095476","fragment_type":"issue_comment","sequence":13,"text":"@jon-chuang , I've been focusing on other issues in the past couple of weeks, but if this can be an incremental step on the way of a broader refactoring as @njhill mentioned, I'll sync this PR with main again.","author_login":"maxdebayser","author_association":"CONTRIBUTOR","created_at":"2024-08-12T14:10:33+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2528955391","fragment_type":"issue_comment","sequence":14,"text":"We've encountered an issue, which I strongly assume is related to this.\n\nWhen hosting Qwen/Qwen2-VL-72B-Instruct-AWQ in distributed mode via ray (with \"--tensor-parallel-size 4 --pipeline-parallel-size 2\") it is not possible to use guided_json mode. It does not return an error code, but stops generating after 3 tokens: ´´´{\"content\"\n. Increasing the min_tokens as mentioned above via extra_body does not resolve the issue. When disabling \"guided_json\" the model generates a response without an issue. When not using \"--pipeline-parallel-size 2\" it is possible to use guided_json properly.\n\nIf needed, I can provide more details/output, but currently this looks quite related.","author_login":"edallmeier","author_association":"NONE","created_at":"2024-12-09T18:05:50+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2557263756","fragment_type":"issue_comment","sequence":15,"text":"Setup C) one docker container with 2 GPUs (pipeline-parallel, no ray)\n\nI'm removing the ray label since it appears in MP executor as well. cc @richardliaw","author_login":"ruisearch42","author_association":"COLLABORATOR","created_at":"2024-12-20T15:53:17+08:00","repo_name":"vllm-project/vllm","issue_id":2450246404,"issue_number":7194,"issue_url":"https://github.com/vllm-project/vllm/issues/7194","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2346658694","fragment_type":"issue_description","sequence":0,"text":"[RFC]: Improve guided decoding (logit_processor) APIs and performance.\n### Motivation.\n\nCurrently, guided decoding & logit processor API is incomplete has has several issues. The RFC is intended to bring up problems and solutions. Some of issues may have been already addressed and there are PRs out already.\n\nThere are 3 major issues.\n- It is not supported from SamplingParamters\n- It is not possible to support batch/async logit processing.\n- Upon failures, engine will die.\n\n### Proposed Change.\n\nAPI\n----\nguided decoding parameters are not supported with SamplingParams. It is addressed from URL \n\nPerformance\n-------------\nCurrently, logit processors APIs are applied row by row blocking ( URL Instead, we can use parallel processing (e.g., ray or thread pool) to improve the logit processing performance. We are using this mechanism internally at Anyscale. We'd like to support this feature in OSS, and would like to improve logit processor API to support 1. async. 2. batching. \n\nThis requires logit processor to be\n- stateful (to use a tool like Ray or thread pool). I think this PR URL is likely sufficient. \n- async. We'd like to propose \"prepare\" API which can separate out compute_logits from preparing logits.\n\nclass LogitPostProcessor:\n def initialize(self, logit_processor_config: LogitProcessorConfig):\n \"\"\"Initialize the post processor. Post processor may have states\n such as thread pool or Ray actors. It should be initialized\n here.\n \"\"\"\n ...\n\n def prepare(\n self,\n seq_gruop_metadata_list: List[SequenceGroupMetadata]):\n \"\"\"Asynchronously prepare logit masks.\"\"\"\n ...\n\n def apply(self, logits: torch.Tensor) -> torch.Tensor:\n \"\"\"Apply the prepared masks to a given logits.\"\"\"\n ...\n\n# For each model, we will have\n\ndef compute_logits(...):\n ....\n\ndef prepare_logits(seq_group_metadata_list):\n ....\n\n`prepare` and `apply` assume 1:1 calls. E.g., once prepare is called, apply has to be called before another prepare is called. I think it is the safe assumption. Alternatively, we can make prepare return a class, but that will make interface surface larger, so I don't prefer that solution (but I am open to hear feedback!)\n\nThis is the example usage of the API\n\n # each model will have prepare_logits API\n self.model.prepare_logits(seq_group_metadata_list)\n hidden_states = model_executable(\n input_ids=input_tokens,\n positions=input_positions,\n kv_caches=kv_caches,\n attn_metadata=attn_metadata,\n **multi_modal_kwargs,\n )\n # Compute the logits. logit processors are applied here.\n logits = self.model.compute_logits(hidden_states, sampling_metadata)\n\nWe are also considering to upstream Ray based batch processing implementation with lmformatenforcer.\n\nFailure Handling\n----------------\nWhen using a stateful logit processor, it is possible requests are failed. For example, if we use Ray, Ray actors can die. Or there could be user's schema issue that cannot be caught ahead of time.\n\nWhen it happens, we should fail the seq_group immediately. We will introduce a new status \"FINISHED_INTERNAL_ERROR = enum.auto()\" to URL If any logit processor is failed, we will mark the relevant seq_group as failed, and the request will be aborted. \n\n### Feedback Period.\n\n_No response_\n\n### CC List.\n\ncc @simon-mo @Yard1 \n\n### Any Other Things.\n\n_No response_","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-06-11T14:59:31+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2161488845","fragment_type":"issue_comment","sequence":1,"text":"I have a few questions:\n \n\nCan you elaborate on why you think placing the guided decoding parameters in the `SamplingParams` is a good idea? As I commented in #4130, I think they conceptually overlap with the logits processors implementing the guided decoding, which are already in the `SamplingParams`.\n \n \n \n \n\nDo you maybe mean _stateless_? If not, what do you mean exactly?\n\nRegarding the topic of statefulness: we probably don't want to limit ourselves to stateless logits processors. If we manage to make the API so that it is easy to implement stateful logits processors, we would already make things much better. E.g. I think that a very good thing to address would be to add infrastructure for pooling stateful objects and making it easy to define that one such object should not be shared across sequences and requests, or at least should be reset before being used.\n\nCould you also please elaborate on the new `LogitsPostProcessor` API you propose? Is this the API to be implemented by logits processors? Or is this an API to be implemented by the models?\n\nAre there maybe some type annotations missing for the return values of e.g. `prepare`? If this method does not return anything, this means the `LogitsPostProcessor` is stateful, right? Shouldn't we aim for a stateless design here, to make parallelization easier?\n\nI might have misunderstood the proposal though. So, I'd be really happy if you could elaborate on it.\n\nAll in all, I would be very interested in improvements in this area, so I'm glad you're working on it!","author_login":"br3no","author_association":"CONTRIBUTOR","created_at":"2024-06-11T19:44:38+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2161661495","fragment_type":"issue_comment","sequence":2,"text":"It's like moving the functionality to the core API. Right now, it is implemented like an add-on (only working with OpenAI server), and it doesn't work with tools like URL (because we directly use the core API). \n \n\nTo improve time to prepare masks for json mode, we want to use parallel processing tools such as threadpool or ray. It requires the logit processor to be \"stateful\" because we don't want to recreate actors or threadpools everytime logit processos is requested (it should be created in `__init__`).\n \n\n+1. I think it'd be an implementation of part 2. \n \n\nIt will replace `_apply_logit_processor` private API inside logit_processor.py. Right now, we apply logit mask row by row. We instead 1. find the relevant logit processor created. 2. logit_processor.prepare(seq_group_metadata_list) -> logit_processor.prepare(rows)\n \n\nYou are right the prep and apply is stateful. We can make it this way as well.\n\n masks = self.model.prepare_logits(seq_group_metadata_list)\n hidden_states = model_executable(\n input_ids=input_tokens,\n positions=input_positions,\n kv_caches=kv_caches,\n attn_metadata=attn_metadata,\n **multi_modal_kwargs,\n )\n # Compute the logits. logit processors are applied here.\n logits = self.model.compute_logits(hidden_states, sampling_metadata, masks)\n\nBut I found it easier to just make it fully stateful. \n\nHope this clarifies the proposal a little bit!","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-06-11T21:52:41+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164081049","fragment_type":"issue_comment","sequence":3,"text":"We should make this work with the following RFCs\n\n@NadavShmayo URL \n@mmoskal URL \n@mmoskal URL \n@maxdebayser @njhill URL \n@lynkz-matt-psaltis URL","author_login":"simon-mo","author_association":"COLLABORATOR","created_at":"2024-06-12T23:44:31+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164087425","fragment_type":"issue_comment","sequence":4,"text":"My initial thoughts;\n\n- URL -> Plugin needs to change the API to accept stateful logit processor\n- URL -> Right now, I feel orthogonal (there are overlap, but the PR mentioned APIs are supposed to be used \"with\" logit processor, and this RFC is logit processor specific).\n- URL seems like a implementation of second part. \n- URL seems orthogonal (existing logit processors will just work)","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-06-12T23:49:20+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164191867","fragment_type":"issue_comment","sequence":5,"text":"Some ideas:\n- maybe `initialize()` can be async? the reason is that we don't start scheduling sequences, where the processor is still initializing (in case it takes a few seconds)\n- add some sort of `free()` API so resources can be freed\n\nWith an additional post-sampling callback, this would subsume by SequenceController:\n\n def sampled(self, seq: 'Sequence', token_id: int,\n logprobs: Dict[int, 'Logprob']) -> Tuple[int, List[int], bool]:\n \"\"\"\n Informs the controller a given token has been sampled.\n Returns the number of tokens to backtrack, the tokens to append,\n and whether to stop.\n \"\"\"\n if token_id == seq.eos_token_id:\n return 0, [], True\n return 0, [token_id], False","author_login":"mmoskal","author_association":"CONTRIBUTOR","created_at":"2024-06-13T01:39:29+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164192353","fragment_type":"issue_comment","sequence":6,"text":"Some ideas:\n- maybe `initialize()` can be async? the reason is that we don't start scheduling sequences, where the processor is still initializing (in case it takes a few seconds)\n- add some sort of `free()` API so resources can be freed\n\nWith an additional post-sampling callback, this would subsume by SequenceController:\n\n def sampled(self, seq: 'Sequence', token_id: int,\n logprobs: Dict[int, 'Logprob']) -> Tuple[int, List[int], bool]:\n \"\"\"\n Informs the controller a given token has been sampled.\n Returns the number of tokens to backtrack, the tokens to append,\n and whether to stop.\n \"\"\"\n if token_id == seq.eos_token_id:\n return 0, [], True\n return 0, [token_id], False","author_login":"mmoskal","author_association":"CONTRIBUTOR","created_at":"2024-06-13T01:40:05+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2165975186","fragment_type":"issue_comment","sequence":7,"text":"I see. I found that API is limited for our particular use case because as you know it is applied after sampling is done (whereas we want to apply logit processor on final logits). It's great if we can subsume it. \n \n\nI am open to it, but right now there's no specific use cases. \n \n\nHow is this guaranteed now?","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-06-13T15:15:21+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168106997","fragment_type":"issue_comment","sequence":8,"text":"@rkooo567 thanks, let me see if I understand it:\n\nThe idea is that the logits processors will be asked to `prepare` their masks asynchronously and in the meantime the model is going to be run. Once both are ready, the logits are computed by having the model call `apply`.\n\nThis means that the whole process needs to guarantee that there is one logits processor instance per request per sequence. Correct?\n\nThe implementation will need to be very careful to avoid contention issues.\n\n---\n\nRegarding the combination of this with the other PRs: I'm still struggling a bit to understand what general design we need. Let me explain: \n\nThe logits processors are now applied in the models; so the general signature of the operation is \n\ncompute_logits(hidden_states: Tensor, ...) -> Tensor\n\nWe want to support ff-tokens or backtracking (e.g. #4775). These things happen a few layers above the model and don't fit this API above.\n\nSo we're talking about different things in different abstraction layers at the same time.\n\nAm I the only one? Is the design clear to you folks? If so, I would appreciate it a lot if someone could describe where which types of object would play which role.","author_login":"br3no","author_association":"CONTRIBUTOR","created_at":"2024-06-14T13:55:20+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168851730","fragment_type":"issue_comment","sequence":9,"text":"@br3no One thing that took me a while to see is that there is only one `LogitPostProcessor` per LLMEngine - it handles logits for **all** sequences in the current batch.\n\nThere was some discussion of allowing a list of those, but IMHO it's easy to write a `LogitPostProcessor` that bundles an arbitrary number of ``LogitPostProcessor`s so I think there's no need to have a list of post processors in vLLM.\n\nI'm the one asking for `ff_tokens` and `backtracking`, I think @rkooo567 is not doing this now.","author_login":"mmoskal","author_association":"CONTRIBUTOR","created_at":"2024-06-14T22:46:44+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168954939","fragment_type":"issue_comment","sequence":10,"text":"@rkooo567 @simon-mo @mmoskal some additional thoughts after we talked offline yesterday:\n\nIt's a concern that the current support is kind of broken, it doesn't work for input batches or beam search due to the stateful/concurrency thing. So I wonder if we could prioritize some simpler immediate fixes for that along with the egregious performance overhead with json mode due to having to construct a new `CFGuide` instance every time. i.e. before the more significant rework to introduce batched application and the prepare step... WDYT?\n\nA couple of other thoughts about the proposed interface:\n- Why would we need an `initialize` method, couldn't a regular constructor be used for this?\n- I'm not sure that it's a good idea to expose `List[SequenceGroupMetadata]` in this API ... I had assumed `SequenceGroupMetadata` is an internal datastructure that we want the freedom to change without breaking 3rd party LogitsProcessor impls. Probably should have some simpler dataclass or abstract class designed specifically for the API.","author_login":"njhill","author_association":"COLLABORATOR","created_at":"2024-06-15T00:05:59+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2169179016","fragment_type":"issue_comment","sequence":11,"text":"@mmoskal thanks for your answer! I also would like to support ff-tokens since I think this would contribute to alleviate the performance issues. \n\n@njhill I’m not familiar with lm-format-enforcer, but for the Outlines processors now only the CFG one is problematic. The others are now stateless. Should we concentrate on a “fix” for the output_format: json issue? This would involve an object pool for the CFGGuide for that particular use case. Or am I missing other aspects here?","author_login":"br3no","author_association":"CONTRIBUTOR","created_at":"2024-06-15T07:30:09+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2173000746","fragment_type":"issue_comment","sequence":12,"text":"I also agree with it. I have impression the current interface is a little over-designed with some vague implementation in mind. For ff-tokens and backtracking, I would like to see the implementation otherwise it is very difficult to design the interface (that's why we punted). I think the interface I propose here is not going to bother us getting there (logit processor API also feels like it is not very stable API yet, so we have time to iterate). \n \n\nDoes it mean supporting stateful logit processor first (meaning merging the open PR)? I am okay with this. \n \n\nI think regular constructor could work. The main reason was we need to pass the decode config to the logit processor, and since it is inside the model, the required change was big. I think constructor makes more sense actually. \n \n\nYeah it is a good point. for our internal impl, we just need seq_data, seq_ids, request_id, and sampling params.","author_login":"rkooo567","author_association":"COLLABORATOR","created_at":"2024-06-17T10:30:05+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2457889023","fragment_type":"issue_comment","sequence":13,"text":"Hi all, for those who are following this thread, I started benchmarking current performance for guided decoding in vLLM here #10046","author_login":"aarnphm","author_association":"CONTRIBUTOR","created_at":"2024-11-05T18:29:53+08:00","repo_name":"vllm-project/vllm","issue_id":2346658694,"issue_number":5423,"issue_url":"https://github.com/vllm-project/vllm/issues/5423","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0070","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Some tokenizer exceptions not being applied?","query_context":"It seems like some of tokenizer exemption rules for the english models are not being applied. In the example below \"yall\" is correctly lemmatized as \"you\" + \"all\" but \"doin\" is lemmatized as \"doin\".\n\n## How to reproduce the behaviour\n \n\nimport spacy\n\nnlp = spacy.load(\"en_core_web_md\")\n\nstring = \"How are yall doin?\"\n\nfor tok in nlp(string):\n print(tok.text, tok.lemma_)\n\nOutput\n\nHow how\nare be\ny you\nall all\ndoin doin\n? ?\n\n## Environment\n \n- **spaCy version:** 3.7.2\n- **Platform:** Linux-6.5.10-200.fc38.x86_64-x86_64-with-glibc2.37\n- **Python version:** 3.10.12\n- **Pipelines:** en_core_web_md (3.7.0)","known_context_document_ids":["gh_issue_1989477572"],"reference_answer":"Thanks again for the report, we've updated this in the internal attribute ruler data and added a test to `spacy-models`, so let's hope this is fixed in the next round of pipeline releases (probably pipeline version v3.8.0).","answer_document_id":"gh_comment_1794964709","silver_evidence_path":["gh_comment_1808497172","gh_issue_1973600854","gh_comment_1794964709"],"evidence_issue_ids":[1989477572,1973600854],"source_repo_name":"explosion/spaCy","source_issue_id":1989477572,"source_issue_number":13126,"source_issue_url":"https://github.com/explosion/spaCy/issues/13126","target_repo_name":"explosion/spaCy","target_issue_id":1973600854,"target_issue_number":13098,"target_issue_url":"https://github.com/explosion/spaCy/issues/13098","reference_anchor_document_id":"gh_comment_1808497172","reference_answer_author":"adrianeboyd","reference_answer_author_association":"MEMBER","quality_score":87.58,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0455,"anchor_target_overlap":0.0455,"target_answer_overlap":0.0952},"issue_created_at":"2023-11-12T16:27:42+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_1989477572","fragment_type":"issue_description","sequence":0,"text":"Some tokenizer exceptions not being applied\nIt seems like some of tokenizer exemption rules for the english models are not being applied. In the example below \"yall\" is correctly lemmatized as \"you\" + \"all\" but \"doin\" is lemmatized as \"doin\".\n\n## How to reproduce the behaviour\n \n\nimport spacy\n\nnlp = spacy.load(\"en_core_web_md\")\n\nstring = \"How are yall doin?\"\n\nfor tok in nlp(string):\n print(tok.text, tok.lemma_)\n\nOutput\n\nHow how\nare be\ny you\nall all\ndoin doin\n? ?\n\n## Environment\n \n- **spaCy version:** 3.7.2\n- **Platform:** Linux-6.5.10-200.fc38.x86_64-x86_64-with-glibc2.37\n- **Python version:** 3.10.12\n- **Pipelines:** en_core_web_md (3.7.0)","author_login":"DavidRamosSal","author_association":"NONE","created_at":"2023-11-12T16:27:42+08:00","repo_name":"explosion/spaCy","issue_id":1989477572,"issue_number":13126,"issue_url":"https://github.com/explosion/spaCy/issues/13126","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1807685745","fragment_type":"issue_comment","sequence":1,"text":"In spacy v2 the tokenizer and lemmatizer exceptions were both maintained as part of the tokenizer, but now in v3 the tokenizer exceptions are in the tokenizer settings and the lemmatizer settings are in the `attribute_ruler`. If you want to see all the details, look at the rules in `nlp.tokenizer.rules` and `nlp.get_pipe(\"attribute_ruler\").patterns`. If you'd like, you can customize any of these rules/patterns in the `en_core_web_*` pipelines as necessary for your task.\n\nThe existing lemmatizer exception only applies to `\"doin'\"` and not `\"doin\"`, but looking again at the details there are some mistakes in the current rules, which have the lemma as \"doing\" instead of \"do\", so we'll get that updated for the next model release (probably v3.8.0).","author_login":"adrianeboyd","author_association":"MEMBER","created_at":"2023-11-13T08:42:06+08:00","repo_name":"explosion/spaCy","issue_id":1989477572,"issue_number":13126,"issue_url":"https://github.com/explosion/spaCy/issues/13126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1808497172","fragment_type":"issue_comment","sequence":2,"text":"The existing lemmatizer exception for `\"doin'\"` is not working for me either. This must be related to #13098 because after adding\n\nnlp.get_pipe(\"attribute_ruler\").add(patterns = [[{'LOWER': \"doin'\"}]], attrs= {'LEMMA': 'do'}, index= 0)\n\nthe lemmatization works as intended.","author_login":"DavidRamosSal","author_association":"NONE","created_at":"2023-11-13T16:23:19+08:00","repo_name":"explosion/spaCy","issue_id":1989477572,"issue_number":13126,"issue_url":"https://github.com/explosion/spaCy/issues/13126","linked_issue_ids":[1973600854],"is_known_query_context":false},{"document_id":"gh_comment_1809936227","fragment_type":"issue_comment","sequence":3,"text":"Ah, thanks for the note about that. My intention was that `NORM` would help here with `doin'` vs. `doin’`, but the tokenizer exceptions are more complicated than I remembered. I'll just revert all the `NORM` changes back to `LOWER` for the next model release so it goes back to the v3.6.0 behavior. (If these changes are causing problems for you, it should work fine to use the v3.6.0 `en_core*` models with v3.7.0.)","author_login":"adrianeboyd","author_association":"MEMBER","created_at":"2023-11-14T10:27:23+08:00","repo_name":"explosion/spaCy","issue_id":1989477572,"issue_number":13126,"issue_url":"https://github.com/explosion/spaCy/issues/13126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1810091878","fragment_type":"issue_comment","sequence":4,"text":"Thanks for the help, the v3.6.0 `en_core*` models indeed work better for my task.","author_login":"DavidRamosSal","author_association":"NONE","created_at":"2023-11-14T12:13:21+08:00","repo_name":"explosion/spaCy","issue_id":1989477572,"issue_number":13126,"issue_url":"https://github.com/explosion/spaCy/issues/13126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1815990991","fragment_type":"issue_comment","sequence":5,"text":"I just went ahead and published updated v3.7 `en` models, which now should be available through `spacy download`.","author_login":"adrianeboyd","author_association":"MEMBER","created_at":"2023-11-17T09:04:14+08:00","repo_name":"explosion/spaCy","issue_id":1989477572,"issue_number":13126,"issue_url":"https://github.com/explosion/spaCy/issues/13126","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1973600854","fragment_type":"issue_description","sequence":0,"text":"Lemmatisation of \"did\" is no longer \"do\" in the context of n't\nI just updated from spacy 3.6 to 3.7 and \"did\" is no longer getting lemmatised as \"do\" when followed by n't.\n\nnlp = spacy.load(\"en_core_web_sm\")\nsent = \"I didn't go to the bank at the weekend.\"\nfor tok in nlp(sent):\n print(tok.text, tok.lemma_)\n\nOutput:\n\nI I\ndid did # lemma should be \"do\"\nn't n't\ngo go\nto to\nthe the\nbank bank\nat at\nthe the\nweekend weekend\n. .\n\n## How to reproduce the behaviour\n \n\n- **spaCy version:** 3.7.2\n- **Platform:** Linux-6.2.0-1017-gcp-x86_64-with-glibc2.35\n- **Python version:** 3.10.12\n- **Pipelines:** en_core_web_sm (3.7.0)","author_login":"chrisjbryant","author_association":"NONE","created_at":"2023-11-02T06:34:59+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791555216","fragment_type":"issue_comment","sequence":1,"text":"hello @chrisjbryant\nI think the error comes from the code you provided. \nyou should process the text with **nlp function** before doing the for loop like this: \n\n`doc = nlp(sent)`","author_login":"Kepsondiaz","author_association":"NONE","created_at":"2023-11-02T21:21:44+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791556337","fragment_type":"issue_comment","sequence":2,"text":"your code should look like this : \n\n`nlp = spacy.load(\"en_core_web_sm\")\nsent = \"I didn't go to the bank at the weekend.\"\ndoc = nlp(sent)\n\nfor tok in doc:\n print(tok.text, tok.lemma_)\n`","author_login":"Kepsondiaz","author_association":"NONE","created_at":"2023-11-02T21:22:48+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791556891","fragment_type":"issue_comment","sequence":3,"text":"`I -PRON-\ndid do\nn't not\ngo go\nto to\nthe the\nbank bank\nat at\nthe the\nweekend weekend\n. .\n`","author_login":"Kepsondiaz","author_association":"NONE","created_at":"2023-11-02T21:23:18+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791557899","fragment_type":"issue_comment","sequence":4,"text":"`I -PRON-\ndid do\nn't not\ngo go\nto to\nthe the\nbank bank\nat at\nthe the\nweekend weekend\n. .\n`","author_login":"Kepsondiaz","author_association":"NONE","created_at":"2023-11-02T21:24:11+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791558254","fragment_type":"issue_comment","sequence":5,"text":"I -PRON-\ndid do\nn't not\ngo go\nto to\nthe the\nbank bank\nat at\nthe the\nweekend weekend\n. .","author_login":"Kepsondiaz","author_association":"NONE","created_at":"2023-11-02T21:24:29+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791847496","fragment_type":"issue_comment","sequence":6,"text":"Ah! My bad, that was a mistake in my demo code above. \n\nI did some more testing as the error appeared in my code when I upgraded spacy in my app, but when I test a clean spacy install, lemmatisation works as expected. So most likely not a spacy problem!","author_login":"chrisjbryant","author_association":"NONE","created_at":"2023-11-03T03:20:19+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791857798","fragment_type":"issue_comment","sequence":7,"text":"My bad, that was a typo in my example code. I have updated it now. The error is still present in spacy.","author_login":"chrisjbryant","author_association":"NONE","created_at":"2023-11-03T03:42:33+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792041701","fragment_type":"issue_comment","sequence":8,"text":"Hi @chrisjbryant, can you set up a fresh virtual environment and run this script there? I can't reproduce this. If I run \n\npython\nimport spacy\nprint(spacy.__version__)\nnlp = spacy.load(\"en_core_web_sm\")\nsent = \"I didn't go to the bank at the weekend.\"\nfor tok in nlp(sent):\n print(tok.text, tok.lemma_)\n\nmy output is:\n\n3.7.2\nI I\ndid do\nn't not\ngo go\nto to\nthe the\nbank bank\nat at\nthe the\nweekend weekend\n. .","author_login":"rmitsch","author_association":"CONTRIBUTOR","created_at":"2023-11-03T08:30:20+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792051231","fragment_type":"issue_comment","sequence":9,"text":"I was previously using a conda env, but just tried with venv and same result. :/\n\nPython 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n \n \n3.7.2\n \n \n \n... print(tok.text, tok.lemma_)\n... \nI I\ndid did\nn't n't\ngo go\nto to\nthe the\nbank bank\nat at\nthe the\nweekend weekend\n. .","author_login":"chrisjbryant","author_association":"NONE","created_at":"2023-11-03T08:38:28+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792066968","fragment_type":"issue_comment","sequence":10,"text":"Huh, after noticing I ran this with Python 3.9 I set up a clean venv with Python 3.10 - there I can reproduce this. We'll look into it.","author_login":"rmitsch","author_association":"CONTRIBUTOR","created_at":"2023-11-03T08:51:58+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792080174","fragment_type":"issue_comment","sequence":11,"text":"I can confirm that this is a bug. A few of the attribute ruler patterns were switched from `LOWER` to `NORM` in v3.7.x (to generalize a bit better overall), but \"did\" is already normalized to \"do\" by the tokenizer, and then the \"did n't\" pattern no longer matches as intended.\n\nYou can add the old rule back to the current `en_core_*` models as a workaround:\n\npython\nnlp.get_pipe(\"attribute_ruler\").add(\n patterns=[[{\"TAG\": \"VBD\", \"LOWER\": \"did\"}]],\n attrs={\"POS\": \"AUX\", \"LEMMA\": \"do\"},\n index=0,\n)","author_login":"adrianeboyd","author_association":"MEMBER","created_at":"2023-11-03T09:03:43+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792183230","fragment_type":"issue_comment","sequence":12,"text":"Just to make sure, don't forget to check other cases too, since I now also recreated it with `hadn't`!","author_login":"chrisjbryant","author_association":"NONE","created_at":"2023-11-03T10:21:09+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792234671","fragment_type":"issue_comment","sequence":13,"text":"Yeah, we'll review all the changes. (The underlying idea was to use `NORM` to match more variants of contractions with apostrophes.)","author_login":"adrianeboyd","author_association":"MEMBER","created_at":"2023-11-03T10:55:08+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1794964709","fragment_type":"issue_comment","sequence":14,"text":"Thanks again for the report, we've updated this in the internal attribute ruler data and added a test to `spacy-models`, so let's hope this is fixed in the next round of pipeline releases (probably pipeline version v3.8.0).","author_login":"adrianeboyd","author_association":"MEMBER","created_at":"2023-11-06T14:32:51+08:00","repo_name":"explosion/spaCy","issue_id":1973600854,"issue_number":13098,"issue_url":"https://github.com/explosion/spaCy/issues/13098","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0071","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Hibernate regression in Quarkus 3.17.2 org.hibernate.bytecode.enhance.spi.EnhancementException fails to build?","query_context":"### Describe the bug\n\nHibernate regression in Quarkus 3.17.2 \n\nWe have an entity that implements one or more interfaces. Those interface methods don't always map to a field in the class but to another method. This has worked fine in all versions of Quarkus (Hibernate) through 3.16.4, error started when we upgraded to 3.17.2, I did not try 3.17.0.\n\nposh\n[ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:3.17.2:build (default) on project json-view-schema-example: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors\n[ERROR] [error]: Build step io.quarkus.deployment.steps.ClassTransformingBuildStep#handleClassTransformation threw an exception: java.lang.reflect.UndeclaredThrowableException\n[ERROR] at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:862)\n[ERROR] at io.quarkus.builder.BuildContext.run(BuildContext.java:256)\n[ERROR] at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)\n[ERROR] at java.base/java.lang.Thread.run(Thread.java:1583)\n[ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:499)\n[ERROR] Caused by: java.util.concurrent.ExecutionException: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [com.example.jsonview.model.Group] failed because no field named [x] could be found for property accessor method [getX]. To fix this, make sure all property accessor methods have a matching field.\n[ERROR] at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)\n[ERROR] at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep.handleClassTransformation(ClassTransformingBuildStep.java:273)\n[ERROR] at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)\n[ERROR] at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)\n[ERROR] ... 8 more\n[ERROR] Caused by: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [com.example.jsonview.model.Group] failed because no field named [x] could be found for property accessor method [getX]. To fix this, make sure all property accessor methods have a matching field.\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.checkUnsupportedAttributeNaming(EnhancerImpl.java:497)\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.doEnhance(EnhancerImpl.java:178)\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.lambda$enhance$1(EnhancerImpl.java:120)\n[ERROR] at org.hibernate.bytecode.internal.bytebuddy.ByteBuddyState.rewrite(ByteBuddyState.java:166)\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.enhance(EnhancerImpl.java:120)\n[ERROR] at io.quarkus.hibernate.orm.deployment.HibernateEntityEnhancer$HibernateEnhancingClassVisitor.hibernateEnhancement(HibernateEntityEnhancer.java:83)\n[ERROR] at io.quarkus.hibernate.orm.deployment.HibernateEntityEnhancer$HibernateEnhancingClassVisitor.visitEnd(HibernateEntityEnhancer.java:76)\n[ERROR] at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:395)\n[ERROR] at io.quarkus.panache.common.deployment.visitors.PanacheEntityClassAccessorGenerationVisitor.visitEnd(PanacheEntityClassAccessorGenerationVisitor.java:126)\n[ERROR] at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:395)\n[ERROR] at org.objectweb.asm.ClassReader.accept(ClassReader.java:749)\n[ERROR] at org.objectweb.asm.ClassReader.accept(ClassReader.java:425)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep.transformClass(ClassTransformingBuildStep.java:367)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep$2.call(ClassTransformingBuildStep.java:238)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep$2.call(ClassTransformingBuildStep.java:225)\n[ERROR] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)\n[ERROR] ... 7 more\n\nHere is a reproducer app: json-view-schema-example.zip\n\n### Expected behavior\n\nBuild should be successful like it has been until using Quarkus 3.17.2.\n\n### Actual behavior\n\nBuild fails with org.hibernate.bytecode.enhance.spi.EnhancementException:\n\n### How to Reproduce?\n\n_No response_\n\n### Output of `uname -a` or `ver`\n\n_No response_\n\n### Output of `java -version`\n\njava 21.0.4 2024-07-16 LTS\n\n### Quarkus version or git rev\n\n_No response_\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\nApache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_2715867937"],"reference_answer":"@wcicola the present issue was fixed in URL which means it's fixed in Quarkus 3.17.6 (through #45235). I unfortunately forgot to close issues fixed in the latest ORM version, I'll get to it right now.\n\nCould you please test this with Quarkus 3.17.6, and if your problem still occurs, open a new issue? Preferably, directly on hibernate.atlassian.net and with a reproducer based on this.\n\nThank you.","answer_document_id":"gh_comment_2594771430","silver_evidence_path":["gh_comment_2516426046","gh_issue_2710930019","gh_comment_2594771430"],"evidence_issue_ids":[2715867937,2710930019],"source_repo_name":"quarkusio/quarkus","source_issue_id":2715867937,"source_issue_number":44909,"source_issue_url":"https://github.com/quarkusio/quarkus/issues/44909","target_repo_name":"quarkusio/quarkus","target_issue_id":2710930019,"target_issue_number":44863,"target_issue_url":"https://github.com/quarkusio/quarkus/issues/44863","reference_anchor_document_id":"gh_comment_2516426046","reference_answer_author":"yrodiere","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1579,"anchor_target_overlap":0.2895,"target_answer_overlap":0.1875},"issue_created_at":"2024-12-03T20:02:54+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2715867937","fragment_type":"issue_description","sequence":0,"text":"Hibernate regression in Quarkus 3.17.2 org.hibernate.bytecode.enhance.spi.EnhancementException fails to build\n### Describe the bug\n\nHibernate regression in Quarkus 3.17.2 \n\nWe have an entity that implements one or more interfaces. Those interface methods don't always map to a field in the class but to another method. This has worked fine in all versions of Quarkus (Hibernate) through 3.16.4, error started when we upgraded to 3.17.2, I did not try 3.17.0.\n\nposh\n[ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:3.17.2:build (default) on project json-view-schema-example: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors\n[ERROR] [error]: Build step io.quarkus.deployment.steps.ClassTransformingBuildStep#handleClassTransformation threw an exception: java.lang.reflect.UndeclaredThrowableException\n[ERROR] at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:862)\n[ERROR] at io.quarkus.builder.BuildContext.run(BuildContext.java:256)\n[ERROR] at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)\n[ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)\n[ERROR] at java.base/java.lang.Thread.run(Thread.java:1583)\n[ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:499)\n[ERROR] Caused by: java.util.concurrent.ExecutionException: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [com.example.jsonview.model.Group] failed because no field named [x] could be found for property accessor method [getX]. To fix this, make sure all property accessor methods have a matching field.\n[ERROR] at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)\n[ERROR] at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep.handleClassTransformation(ClassTransformingBuildStep.java:273)\n[ERROR] at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)\n[ERROR] at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)\n[ERROR] ... 8 more\n[ERROR] Caused by: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [com.example.jsonview.model.Group] failed because no field named [x] could be found for property accessor method [getX]. To fix this, make sure all property accessor methods have a matching field.\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.checkUnsupportedAttributeNaming(EnhancerImpl.java:497)\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.doEnhance(EnhancerImpl.java:178)\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.lambda$enhance$1(EnhancerImpl.java:120)\n[ERROR] at org.hibernate.bytecode.internal.bytebuddy.ByteBuddyState.rewrite(ByteBuddyState.java:166)\n[ERROR] at org.hibernate.bytecode.enhance.internal.bytebuddy.EnhancerImpl.enhance(EnhancerImpl.java:120)\n[ERROR] at io.quarkus.hibernate.orm.deployment.HibernateEntityEnhancer$HibernateEnhancingClassVisitor.hibernateEnhancement(HibernateEntityEnhancer.java:83)\n[ERROR] at io.quarkus.hibernate.orm.deployment.HibernateEntityEnhancer$HibernateEnhancingClassVisitor.visitEnd(HibernateEntityEnhancer.java:76)\n[ERROR] at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:395)\n[ERROR] at io.quarkus.panache.common.deployment.visitors.PanacheEntityClassAccessorGenerationVisitor.visitEnd(PanacheEntityClassAccessorGenerationVisitor.java:126)\n[ERROR] at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:395)\n[ERROR] at org.objectweb.asm.ClassReader.accept(ClassReader.java:749)\n[ERROR] at org.objectweb.asm.ClassReader.accept(ClassReader.java:425)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep.transformClass(ClassTransformingBuildStep.java:367)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep$2.call(ClassTransformingBuildStep.java:238)\n[ERROR] at io.quarkus.deployment.steps.ClassTransformingBuildStep$2.call(ClassTransformingBuildStep.java:225)\n[ERROR] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)\n[ERROR] ... 7 more\n\nHere is a reproducer app: json-view-schema-example.zip\n\n### Expected behavior\n\nBuild should be successful like it has been until using Quarkus 3.17.2.\n\n### Actual behavior\n\nBuild fails with org.hibernate.bytecode.enhance.spi.EnhancementException:\n\n### How to Reproduce?\n\n_No response_\n\n### Output of `uname -a` or `ver`\n\n_No response_\n\n### Output of `java -version`\n\njava 21.0.4 2024-07-16 LTS\n\n### Quarkus version or git rev\n\n_No response_\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\nApache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)\n\n### Additional information\n\n_No response_","author_login":"dhoffer","author_association":"NONE","created_at":"2024-12-03T20:02:54+08:00","repo_name":"quarkusio/quarkus","issue_id":2715867937,"issue_number":44909,"issue_url":"https://github.com/quarkusio/quarkus/issues/44909","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2515621798","fragment_type":"issue_comment","sequence":1,"text":"I can confirm this bug is limited to Quarkus 3.17.2 only, which uses hibernate 6.6.3.Final.\n\nQuarkus 3.17.0 which uses hibernate 6.6.1.Final does not have this bug.","author_login":"dhoffer","author_association":"NONE","created_at":"2024-12-03T21:50:06+08:00","repo_name":"quarkusio/quarkus","issue_id":2715867937,"issue_number":44909,"issue_url":"https://github.com/quarkusio/quarkus/issues/44909","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2516426046","fragment_type":"issue_comment","sequence":2,"text":"@geoand yes, this error is also triggered by the new check introduced by URL see my comment on the other issue for more details.\n\nA possible workaround is annotating those methods with `jakarta.persistence.Transient`, or changing their name so they don't start with `is`, `get` or `set`. \n\nI've added the link to the reproducer for this issue in the Hibernate issue I previously created, thank you @dhoffer for providing that and reporting the issue, we should address this case as well when refining the check.","author_login":"mbladel","author_association":"CONTRIBUTOR","created_at":"2024-12-04T07:42:18+08:00","repo_name":"quarkusio/quarkus","issue_id":2715867937,"issue_number":44909,"issue_url":"https://github.com/quarkusio/quarkus/issues/44909","linked_issue_ids":[2710930019],"is_known_query_context":false},{"document_id":"gh_comment_2516446651","fragment_type":"issue_comment","sequence":3,"text":"Thanks for reporting. Closing as duplicate of #44863 , let's follow progress there.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2024-12-04T07:52:26+08:00","repo_name":"quarkusio/quarkus","issue_id":2715867937,"issue_number":44909,"issue_url":"https://github.com/quarkusio/quarkus/issues/44909","linked_issue_ids":[2710930019],"is_known_query_context":false},{"document_id":"gh_issue_2710930019","fragment_type":"issue_description","sequence":0,"text":"org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [org.acme.domain.MyEntity] failed\n### Describe the bug\n\nException occurs during Build:\n` org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [org.acme.domain.MyEntity] failed because no field named [modelType] could be found for property accessor method [getModelType]. To fix this, make sure all property accessor methods have a matching field.`\n\n### Expected behavior\n\nThe Build should succeed.\n\n### Actual behavior\n\nWhen building the project:\nERROR] Caused by: java.util.concurrent.ExecutionException: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [org.acme.domain.MyEntity] failed because no field named [modelType] could be found for property accessor method [getModelType]. To fix this, make sure all property accessor methods have a matching field.\n\n### How to Reproduce?\n\nReproducer: URL \nJust build the project with maven.\nSimple Entity:\n\nJava\n@Entity\npublic class MyEntity {\n\n @Id\n private UUID id;\n\n public UUID getId() {\n return id;\n }\n\n public void setId(UUID id) {\n this.id = id;\n }\n\n public void getXXX() {\n }\n\n @PrePersist\n public void setId(){\n id = UUID.randomUUID();\n }\n \n public String getModelType() {\n return \"MyEntity\";\n }\n}\n\nAfter changing the PrePersist setter to a seperate name the build is working:\n\nJava\n@Entity\npublic class MyEntity {\n\n @Id\n private UUID id;\n\n public UUID getId() {\n return id;\n }\n\n public void setId(UUID id) {\n this.id = id;\n }\n\n public void getXXX() {\n }\n\n @PrePersist\n public void prePersistSetId(){\n id = UUID.randomUUID();\n }\n \n public String getModelType() {\n return \"MyEntity\";\n }\n}\n\n### Output of `uname -a` or `ver`\n\nDarwin Mac-C6VD4H4XT3 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:00:32 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6030 arm64\n\n### Output of `java -version`\n\nopenjdk version \"21.0.5\" 2024-10-15 OpenJDK Runtime Environment Homebrew (build 21.0.5) OpenJDK 64-Bit Server VM Homebrew (build 21.0.5, mixed mode, sharing)\n\n### Quarkus version or git rev\n\n3.17.2 --> hibernate-core 6.6.3\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\nMaven home: /opt/homebrew/Cellar/maven/3.9.9/libexec Java version: 21.0.5, vendor: Homebrew, runtime: /opt/homebrew/Cellar/openjdk@21/21.0.5/libexec/openjdk.jdk/Contents/Home Default locale: de_DE, platform encoding: UTF-8 OS name: \"mac os x\", version: \"15.1.1\", arch: \"aarch64\", family: \"mac\"\n\n### Additional information\n\n@yrodiere Can you please check. Thx.\nSee: URL","author_login":"KaiSuchomel","author_association":"CONTRIBUTOR","created_at":"2024-12-02T07:52:47+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2510986581","fragment_type":"issue_comment","sequence":1,"text":"Hello @KaiSuchomel, thank you for reporting the issue and providing a simple mapping which reproduces your problem.\n\nThe error you're facing is caused by a recent change in Hibernate's bytecode-enhancement logic: URL The new check is needed because support for bytecode enhanced entities with `AccessType.PROPERTY` (using getter/setter methods instead of fields) does not function properly unless the field names exactly match the method names - in Quarkus this can be especially problematic since enhancement is done at build-time and we expect all entities to be enhanced at runtime.\n\nUsing `setX`, where `X` is a persistent property name, as the method name in your entity classes is generally not a good idea, especially when using bytecode-enhancement, as the method could be mistaken as a setter for that field. So the \"workaround\" you found is more than valid and I would suggest keeping that as-is.\n\nRegardless, I believe the check should in this case insce:\n\n1. The entity is using `AccessType.FIELD`, since the `@Id` annotation is placed on the `id` field;\n2. The pre-persist method `setId` corresponds to an actually existing field\n\nWe should open an issue on Hibernate ORM's Jira to keep track of this and possibly improve the check.","author_login":"mbladel","author_association":"CONTRIBUTOR","created_at":"2024-12-02T09:21:14+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2516427377","fragment_type":"issue_comment","sequence":2,"text":"@geoand I believe so, yes, I've added a link to that issue and its reproducer to the ORM Jira - thanks for the ping.","author_login":"mbladel","author_association":"CONTRIBUTOR","created_at":"2024-12-04T07:43:06+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2593717121","fragment_type":"issue_comment","sequence":3,"text":"I've recently encountered a similar issue that seems to be related, but haven't yet seen a report of this exact manifestation of it either here or on the Hibernate Jira.\n\nIf an entity:\n\n1. Is mapped using `AccessType.PROPERTY`,\n2. Extends a class with fields that are accessible to subclasses, and\n3. Tries to map those accessible superclass fields using annotations on its own getters/setters\n\nThen the build fails also with a similar EnhancementException.\n\nI can put together a full repro project and/or post on the Hibernate Jira if it would help, but the only required code for reproduction is a Quarkus 3.17.2+ project using `quarkus-hibernate-orm` and with these two classes:\n\npackage test.entity;\n\nimport jakarta.persistence.MappedSuperclass;\n\n@MappedSuperclass\npublic abstract class AbstractEntity {\n\n protected Long oid;\n}\n\npackage test.entity;\n\nimport jakarta.persistence.Column;\nimport jakarta.persistence.Entity;\nimport jakarta.persistence.Id;\n\n@Entity\npublic class EntityTest extends AbstractEntity {\n\n @Id\n @Column(name = \"ID\")\n public Long getOid() {\n\n return oid;\n }\n\n public void setOid(Long oid) {\n\n this.oid = oid;\n }\n}\n\nThe result of `mvn package`:\n\n[ERROR] Caused by: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [test.entity.EntityTest] failed because no field named [oid] could be found for property accessor method [getOid]. To fix this, make sure all property accessor methods have a matching field.\n\nBasically, the bytecode enhancement process seems to now be only considering fields declared in the same class that contains the getters/setters, whereas it previously detected inherited fields without issue. The same code builds fine using Quarkus 3.17.0 or lower.","author_login":"wcicola","author_association":"NONE","created_at":"2025-01-15T18:58:37+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2594771430","fragment_type":"issue_comment","sequence":4,"text":"@wcicola the present issue was fixed in URL which means it's fixed in Quarkus 3.17.6 (through #45235). I unfortunately forgot to close issues fixed in the latest ORM version, I'll get to it right now.\n\nCould you please test this with Quarkus 3.17.6, and if your problem still occurs, open a new issue? Preferably, directly on hibernate.atlassian.net and with a reproducer based on this.\n\nThank you.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2025-01-16T08:04:12+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2595629892","fragment_type":"issue_comment","sequence":5,"text":"@yrodiere @mbladel Many thanks! I'll get that put together and posted today.","author_login":"wcicola","author_association":"NONE","created_at":"2025-01-16T13:15:24+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2791992998","fragment_type":"issue_comment","sequence":6,"text":"We are discovering this issue in 3.21.2 again. It worked until 3.21.1 and started to fail in 3.21.2. Anyone else rediscovering this?","author_login":"dhufnagel","author_association":"NONE","created_at":"2025-04-10T08:37:05+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2795920171","fragment_type":"issue_comment","sequence":7,"text":"In our Environment the deployment is failing with the error again with quarkus 3.21.2. Running with quarkus 3.32.1.\n@dhufnagel Have you a cretaed a reproducer?\nMay be the URL is causing the issue.","author_login":"KaiSuchomel","author_association":"CONTRIBUTOR","created_at":"2025-04-11T06:07:46+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2795957792","fragment_type":"issue_comment","sequence":8,"text":"@dhufnagel @mbladel \nI have enhance the reproducer: URL \nWith quarkus 3.21.1 everything is running, quarkus 3.21.2 is failing with:\n`[ERROR] Caused by: org.hibernate.bytecode.enhance.spi.EnhancementException: Enhancement of [org.acme.domain.RevisionBase] failed because no field named [id] could be found for property accessor method [getId]. To fix this, make sure all property accessor methods have a matching field.`","author_login":"KaiSuchomel","author_association":"CONTRIBUTOR","created_at":"2025-04-11T06:29:24+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2796012879","fragment_type":"issue_comment","sequence":9,"text":"I was out of Office and did. Not have the time to create a reproducer. But it seems to be related to the issue @mbladel is mentioning. We have an entity with a getSomething() method, where \"something\" is not a property but extract information from other properties. So I think in our case we track the mentioned issue.","author_login":"dhufnagel","author_association":"NONE","created_at":"2025-04-11T06:52:52+08:00","repo_name":"quarkusio/quarkus","issue_id":2710930019,"issue_number":44863,"issue_url":"https://github.com/quarkusio/quarkus/issues/44863","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0072","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"bug: Copying and pasting?","query_context":"### Version\n\n1.30.0\n\n### Describe the bug\n\nI find copying and pasting code or content difficult, especially from Jupyter Notebook to the chat interface. \n\nIt ends up pasting new Jupyter cells within the notebook instead of pasting the copied content to the chat tab. \n\nCopying and pasting code or content is difficult and frustrating. It has made the user experience awful.\n\n### Expected behavior\n\nI expected the copied content to be pasted on the chat tab instead it always pastes the created content on Jupyter notebook as a new cell.\n\n### Additional context\n\n_No response_","known_context_document_ids":["gh_issue_2456180588"],"reference_answer":"Hey @AlfSandoval \n\nThank you for providing the detailed report. The team will take a look into it.\nIt seems, that this is caused because of focus handling.","answer_document_id":"gh_comment_2500685736","silver_evidence_path":["gh_comment_2569044325","gh_issue_2693998480","gh_comment_2500685736"],"evidence_issue_ids":[2456180588,2693998480],"source_repo_name":"sourcegraph/cody","source_issue_id":2456180588,"source_issue_number":5146,"source_issue_url":"https://github.com/sourcegraph/cody/issues/5146","target_repo_name":"sourcegraph/cody","target_issue_id":2693998480,"target_issue_number":6200,"target_issue_url":"https://github.com/sourcegraph/cody/issues/6200","reference_anchor_document_id":"gh_comment_2569044325","reference_answer_author":"PriNova","reference_answer_author_association":"COLLABORATOR","quality_score":79.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0588,"anchor_target_overlap":0.1765,"target_answer_overlap":0.0},"issue_created_at":"2024-08-08T16:15:50+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2456180588","fragment_type":"issue_description","sequence":0,"text":"bug: Copying and pasting\n### Version\n\n1.30.0\n\n### Describe the bug\n\nI find copying and pasting code or content difficult, especially from Jupyter Notebook to the chat interface. \n\nIt ends up pasting new Jupyter cells within the notebook instead of pasting the copied content to the chat tab. \n\nCopying and pasting code or content is difficult and frustrating. It has made the user experience awful.\n\n### Expected behavior\n\nI expected the copied content to be pasted on the chat tab instead it always pastes the created content on Jupyter notebook as a new cell.\n\n### Additional context\n\n_No response_","author_login":"chineidu","author_association":"NONE","created_at":"2024-08-08T16:15:50+08:00","repo_name":"sourcegraph/cody","issue_id":2456180588,"issue_number":5146,"issue_url":"https://github.com/sourcegraph/cody/issues/5146","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2278253494","fragment_type":"issue_comment","sequence":1,"text":"Thanks @chineidu I will make sure the product team sees this in the weekly community feedback report.","author_login":"jdorfman","author_association":"MEMBER","created_at":"2024-08-09T15:51:30+08:00","repo_name":"sourcegraph/cody","issue_id":2456180588,"issue_number":5146,"issue_url":"https://github.com/sourcegraph/cody/issues/5146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2371504582","fragment_type":"issue_comment","sequence":2,"text":"So this is a bug still going on. I though I was going crazy because each time I hit ctrl-v or paste something in the chat it duplicate the last cell of my jupyter notebook","author_login":"HaArLiNsH","author_association":"NONE","created_at":"2024-09-24T14:39:34+08:00","repo_name":"sourcegraph/cody","issue_id":2456180588,"issue_number":5146,"issue_url":"https://github.com/sourcegraph/cody/issues/5146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2371525363","fragment_type":"issue_comment","sequence":3,"text":"I think Jupyter causes it. It's more like a Jupyter notebook bug.","author_login":"chineidu","author_association":"NONE","created_at":"2024-09-24T14:46:57+08:00","repo_name":"sourcegraph/cody","issue_id":2456180588,"issue_number":5146,"issue_url":"https://github.com/sourcegraph/cody/issues/5146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2569044325","fragment_type":"issue_comment","sequence":4,"text":"@chineidu this issue is duplicated by another issue where I explained that this is not the fault of Cody but\nof the jupyter plugin.\nHave a look at my comment\n URL \n\n@PriNova I think you can close this issue as well as this is not the fault of Cody.","author_login":"ichim-david","author_association":"CONTRIBUTOR","created_at":"2025-01-03T10:57:22+08:00","repo_name":"sourcegraph/cody","issue_id":2456180588,"issue_number":5146,"issue_url":"https://github.com/sourcegraph/cody/issues/5146","linked_issue_ids":[2693998480],"is_known_query_context":false},{"document_id":"gh_comment_2569097199","fragment_type":"issue_comment","sequence":5,"text":"Thank you @ichim-david for the support. I will close this issue.","author_login":"PriNova","author_association":"COLLABORATOR","created_at":"2025-01-03T11:43:04+08:00","repo_name":"sourcegraph/cody","issue_id":2456180588,"issue_number":5146,"issue_url":"https://github.com/sourcegraph/cody/issues/5146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2693998480","fragment_type":"issue_description","sequence":0,"text":"bug: copy pasting in jupyter notebooks\nType: Bug \n\n## Extension Information\n \n- Cody Version: 1.45.1732320290\n- VS Code Version: 1.93.1\n- Extension Host: desktop\n\n## Steps to Reproduce\n \n1. Open a Jupyter Notebook in VS Code.\n2. Copy content from a cell in the notebook.\n3. Paste the content into the Cody chat window.\n4. Observe duplication of cells in the notebook or issues with the paste action.\n\n## Expected Behaviour\n \nContent from the Jupyter Notebook should paste seamlessly into the Cody chat without causing duplication of cells in the notebook.\n\n## Actual Behaviour\n \nCopy-pasting from the Jupyter Notebook into the Cody chat causes duplication of cells in the notebook. Clicking off the notebook tab is required to paste content into Cody chat.\n\n## Logs\n \n\nExtension version: 1.45.1732320290\nVS Code version: Cursor 0.43.3 (09a504fa3bdd3caa05bfe01b88bd2b79e283d240, 2024-11-24T21:46:28.029Z)\nOS version: Windows_NT x64 10.0.22631\nModes:\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|13th Gen Intel(R) Core(TM) i9-13950HX (32 x 2419)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off|\n|Load (avg)|undefined|\n|Memory (System)|63.76GB (31.32GB free)|\n|Process Argv||\n|Screen Reader|no|\n|VM|0%|","author_login":"AlfredoSandovalx","author_association":"NONE","created_at":"2024-11-26T10:00:45+08:00","repo_name":"sourcegraph/cody","issue_id":2693998480,"issue_number":6200,"issue_url":"https://github.com/sourcegraph/cody/issues/6200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2500685736","fragment_type":"issue_comment","sequence":1,"text":"Hey @AlfSandoval \n\nThank you for providing the detailed report. The team will take a look into it.\nIt seems, that this is caused because of focus handling.","author_login":"PriNova","author_association":"COLLABORATOR","created_at":"2024-11-26T12:36:49+08:00","repo_name":"sourcegraph/cody","issue_id":2693998480,"issue_number":6200,"issue_url":"https://github.com/sourcegraph/cody/issues/6200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2567025359","fragment_type":"issue_comment","sequence":2,"text":"@AlfredoSandovalx I just tried this issue and it seems to be a problem with how jupyter notebooks behave in VSCode.\nI can reproduce your bug using Vs Code on a Mac with Cody\nbut I can also reproduce this bug by having Supermaven opened and trying to paste inside it's chat panel.\nTry it yourself and see if that is not the case.\n\nAs such I would add an issue to the extension or VSCode rather than to Cody\ncody-jupyter-paste\nIn this picture what I had in the paste registry was the content seen in the terminal, while triggering the paste action gave the same message as seen in the jupyter cells","author_login":"ichim-david","author_association":"CONTRIBUTOR","created_at":"2025-01-01T14:11:57+08:00","repo_name":"sourcegraph/cody","issue_id":2693998480,"issue_number":6200,"issue_url":"https://github.com/sourcegraph/cody/issues/6200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2567298723","fragment_type":"issue_comment","sequence":3,"text":"@ichim-david You nailed it. Had this on Vscode, Cursor and windsurf. Will share w/ Vs.","author_login":"AlfredoSandovalx","author_association":"NONE","created_at":"2025-01-02T05:25:29+08:00","repo_name":"sourcegraph/cody","issue_id":2693998480,"issue_number":6200,"issue_url":"https://github.com/sourcegraph/cody/issues/6200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2568968200","fragment_type":"issue_comment","sequence":4,"text":"I close this issue as resolved.\n\nThank you all for the help.","author_login":"PriNova","author_association":"COLLABORATOR","created_at":"2025-01-03T09:57:26+08:00","repo_name":"sourcegraph/cody","issue_id":2693998480,"issue_number":6200,"issue_url":"https://github.com/sourcegraph/cody/issues/6200","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0075","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Using Triton 3.2: ModuleNotFoundError: No module named 'triton.ops'?","query_context":"I updated to Triton 3.2 and get the following error message\n\nModuleNotFoundError: No module named 'triton.ops'","known_context_document_ids":["gh_issue_2874498135"],"reference_answer":"What's your `triton` package version? The newest `triton` has removed `triton.ops`. You can use `pip install triton==3.0.0` to avoid this issue.","answer_document_id":"gh_comment_2673363339","silver_evidence_path":["gh_comment_2678243044","gh_issue_2864957871","gh_comment_2673363339"],"evidence_issue_ids":[2874498135,2864957871],"source_repo_name":"welltop-cn/ComfyUI-TeaCache","source_issue_id":2874498135,"source_issue_number":53,"source_issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","target_repo_name":"welltop-cn/ComfyUI-TeaCache","target_issue_id":2864957871,"target_issue_number":51,"target_issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","reference_anchor_document_id":"gh_comment_2678243044","reference_answer_author":"YunjieYu","reference_answer_author_association":"COLLABORATOR","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.375,"target_answer_overlap":0.0},"issue_created_at":"2025-02-24T10:30:21+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2874498135","fragment_type":"issue_description","sequence":0,"text":"Using Triton 3.2: ModuleNotFoundError: No module named 'triton.ops'\nI updated to Triton 3.2 and get the following error message\n\nModuleNotFoundError: No module named 'triton.ops'","author_login":"Maxxxel","author_association":"NONE","created_at":"2025-02-24T10:30:21+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2678243044","fragment_type":"issue_comment","sequence":1,"text":"The same issue as URL \nPlease downgrade triton to 3.0.0:\n`pip install triton==3.0.0`","author_login":"YunjieYu","author_association":"COLLABORATOR","created_at":"2025-02-24T12:14:07+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[2864957871],"is_known_query_context":false},{"document_id":"gh_comment_2682225890","fragment_type":"issue_comment","sequence":2,"text":"But Pytorch2.6.0+cu126 needs triton>=3.2.\n\nPlease consider support it.\n\nImage","author_login":"techidsk","author_association":"NONE","created_at":"2025-02-25T14:42:34+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2705387178","fragment_type":"issue_comment","sequence":3,"text":"I just confirmed that PyTorch 2.6 + Triton 3.2 + latest ComfyUI + TeaCache (+ other nodes like GGUF) works, and it runs Wan much faster than uncompiled. OP's issue may be because some Python package or ComfyUI node is outdated. Next time please paste the full error log to help locate the problem","author_login":"woct0rdho","author_association":"NONE","created_at":"2025-03-07T02:39:30+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708487387","fragment_type":"issue_comment","sequence":4,"text":"For triton 3.2, you need to update bitsandbytes to 0.45.3 and you should be fine.","author_login":"mykeehu","author_association":"NONE","created_at":"2025-03-08T21:05:25+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2711837595","fragment_type":"issue_comment","sequence":5,"text":"I have the same problem. I tried upgrading to triton-windows today (iirc I had a slightly older version of Triton 3.2 running), but now many nodes in Comfy don't load anymore, asking for a missing Triton.Ops.\n\nAnd I do have bitsandbytes==0.45.3 and I was able to run Wan & HV in Comfy with Torch.Compile, Teacache and Sageattention a few hours ago.","author_login":"CognitiveDiffusion","author_association":"NONE","created_at":"2025-03-10T21:07:10+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2712184685","fragment_type":"issue_comment","sequence":6,"text":"@CognitiveDiffusion Please paste the full error log to help locate the problem","author_login":"woct0rdho","author_association":"NONE","created_at":"2025-03-11T00:57:44+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2874498135,"issue_number":53,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/53","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2864957871","fragment_type":"issue_description","sequence":0,"text":"Neither installation in comfyui nor manual downloading from github can be used.\nError message：Cannot import D:\\anzhuanbao\\shellagent\\ComfyUI_windows_portable_nvidia\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI-TeaCache-main module for custom nodes: No module named 'comfy.ldm.lightricks'\n\nUninstalling and fixing TeaCache nodes in comfyui failed\n\nImage","author_login":"tianyi631","author_association":"NONE","created_at":"2025-02-20T03:14:30+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2864957871,"issue_number":51,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2670443364","fragment_type":"issue_comment","sequence":1,"text":"Your ComfyUI version is too old. Please update your ComfyUI and try again.","author_login":"YunjieYu","author_association":"COLLABORATOR","created_at":"2025-02-20T04:36:15+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2864957871,"issue_number":51,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673209950","fragment_type":"issue_comment","sequence":2,"text":"That isn't it.\n\nSame issue, I just uninstalled and reinstalled everything, entirely up to date. It seems it might have to do with this from my traceback:\n\nModuleNotFoundError: No module named 'triton.ops'\n\nCannot import /home/xxx/ComfyUI/custom_nodes/ComfyUI-TeaCache module for custom nodes: No module named 'triton.ops'\n\ntriton.ops seems to have been moved to triton-lang maybe?","author_login":"jnz86","author_association":"NONE","created_at":"2025-02-21T02:39:40+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2864957871,"issue_number":51,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673361458","fragment_type":"issue_comment","sequence":3,"text":"What's your `triton` package version? The newest `triton` has removed `triton.ops`. You can use `pip install triton==3.0.0` to avoid this issue.","author_login":"YunjieYu","author_association":"COLLABORATOR","created_at":"2025-02-21T04:11:33+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2864957871,"issue_number":51,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673363339","fragment_type":"issue_comment","sequence":4,"text":"What's your `triton` package version? The newest `triton` has removed `triton.ops`. You can use `pip install triton==3.0.0` to avoid this issue.","author_login":"YunjieYu","author_association":"COLLABORATOR","created_at":"2025-02-21T04:12:47+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2864957871,"issue_number":51,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673833605","fragment_type":"issue_comment","sequence":5,"text":"Thank you very much for your help, the problem is completely solved after the update","author_login":"tianyi631","author_association":"NONE","created_at":"2025-02-21T07:54:50+08:00","repo_name":"welltop-cn/ComfyUI-TeaCache","issue_id":2864957871,"issue_number":51,"issue_url":"https://github.com/welltop-cn/ComfyUI-TeaCache/issues/51","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0076","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Inappropriate rebalances being selected?","query_context":"I'm currently testing with the config file settings: \n\necon_ratio: 0.5\nlost_profit: true\n\n... and have run the rebalancer with no further parameters specified via command line. Each time, it has selected routes that are inappropriate. For instance, rebalancing a target channel that I currently charge 30ppm with a source currently charging 200ppm. \n\nAlso, I've attempted to specify a source channel via command line without any further parameters, hoping regolancer would attempt to find an appropriate rebalance with any possible target channels fitting the liquidity criteria specified in config.json; however, it throws error \"No source channels selected.\" Am I missing something here?\n\nThanks!","known_context_document_ids":["gh_issue_1393712210"],"reference_answer":"Check if the max fee displayed is correct for you. Manually calculate the target channel future income (as `(base_fee + amount * fee_ppm) * econ_ratio`), subtract the source channel fee (as `base_fee + amount * fee_ppm`).","answer_document_id":"gh_comment_1264359118","silver_evidence_path":["gh_comment_1264606026","gh_issue_1391222221","gh_comment_1264359118"],"evidence_issue_ids":[1393712210,1391222221],"source_repo_name":"rkfg/regolancer","source_issue_id":1393712210,"source_issue_number":6,"source_issue_url":"https://github.com/rkfg/regolancer/issues/6","target_repo_name":"rkfg/regolancer","target_issue_id":1391222221,"target_issue_number":2,"target_issue_url":"https://github.com/rkfg/regolancer/issues/2","reference_anchor_document_id":"gh_comment_1264606026","reference_answer_author":"rkfg","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2308,"anchor_target_overlap":0.2308,"target_answer_overlap":0.1667},"issue_created_at":"2022-10-02T10:14:12+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1393712210","fragment_type":"issue_description","sequence":0,"text":"Inappropriate rebalances being selected\nI'm currently testing with the config file settings: \n\necon_ratio: 0.5\nlost_profit: true\n\n... and have run the rebalancer with no further parameters specified via command line. Each time, it has selected routes that are inappropriate. For instance, rebalancing a target channel that I currently charge 30ppm with a source currently charging 200ppm. \n\nAlso, I've attempted to specify a source channel via command line without any further parameters, hoping regolancer would attempt to find an appropriate rebalance with any possible target channels fitting the liquidity criteria specified in config.json; however, it throws error \"No source channels selected.\" Am I missing something here?\n\nThanks!","author_login":"mcsnubbs","author_association":"NONE","created_at":"2022-10-02T10:14:12+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1264606026","fragment_type":"issue_comment","sequence":1,"text":"What was the max fee reported for the route? Does it match the formula here? Are you sure you specified the options correctly? Currently unknown options are ignored, I think it should be fixed to prevent mistakes.\n \n\nThe default liquidity limit is 50%, does your source channel have more than 50% balance on your side considering the amount that will be deducted after successful rebalance? If you want to use it no matter what you should specify `--pfrom=100` (or any target above 50) and `--allow-unbalance-from`.","author_login":"rkfg","author_association":"OWNER","created_at":"2022-10-02T10:23:51+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[1391222221],"is_known_query_context":false},{"document_id":"gh_comment_1264614755","fragment_type":"issue_comment","sequence":2,"text":"I'm sure I'm missing something... heres an example.\n\nconfig file is:\n\n{\n \"macaroon_dir\": \"/home/regolancer/.lnd/data/chain/bitcoin/mainnet/\",\n \"macaroon_filename\": \"admin.macaroon\",\n \"network\": \"mainnet\",\n \"tlscert\": \"/home/regolancer/.lnd/tls.cert\",\n \"econ_ratio\": 0.2,\n \"amount\": 10000,\n \"min_amount\": 5000,\n \"probe_steps\": 5,\n \"pfrom\": 10,\n \"pto\": 30,\n \"stat\": \"stats.csv\",\n \"lost_profit\": true,\n \"exclude_channels_in\": [\n ],\n \"exclude_channels_out\": [\n ],\n \"exclude_channels\": [\n ],\n \"exclude_nodes\": [\n ]\n}\n\n$ go/bin/regolancer -f /home/regolancer/config.json\n\n2022/10/02 06:53:59 Attempt #2, amount: 10000 (max fee: 0)\nTotal fee: 1\n826396237984169984 [allyourbankarebelongtous|75ch|2.96,267,124sat|035fed4182fbd0725264f8a0018cabb6b25514dd231291162ac8dd63afb278e9e8]\n825335209304981506 1000 [Xolotl ⚡ LND|47ch|3.82,000,000sat|033b277b17cf7c70fd4de5cbe8dcaeda0cd63d44fcd680f82f76dcac2ebad10c2f]\n825424269808435201 10 [Stone Of Jordan|135ch|13.04,996,386sat|02bce4f7ae5b2d51c18575b3f277e296d9df800a54d749d7a3145c9e40237e4011]\n815450599751221249 0 [zero fee routing | CLN|1387ch|84.74,988,554sat|038fe1bd966b5cb0545963490c631eaa1924e2c4c0ea4e7dcb5d4582a1e7f2f1a5]\n811015169933639681 0 [Thrash.at|134ch|3.77,192,869sat|03ac61c971d146787a036f75e80a9fbede238a75d0c396f1fe996def00f0ac5dbe]\n816899756183846912 251 [Milky*Cilia|230ch|25.15,165,870sat|022a03c83e94ab037a64dd71e54f1796db185f21b1d88ceea5486a274ec257e995]\n\n2022/10/02 06:54:13 Success! Paid 1 in fees\n\n... telegram bot reports I paid 126 ppm to rebalance from allyourbanks (currently I charge 50ppm) to Thrash.at (currently I charge 30ppm)","author_login":"mcsnubbs","author_association":"NONE","created_at":"2022-10-02T11:05:36+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[1391222221],"is_known_query_context":false},{"document_id":"gh_comment_1264617855","fragment_type":"issue_comment","sequence":3,"text":"Yeah, that looks wrong. Do you use the latest version from master? #5 was fixed, when the max fee becomes negative lnd simply ignores this restriction and uses whatever route it finds. In your case it says 0 but if the actual fee is less than 1 sat (and more than -1 sat) it could've been rounded up to zero.","author_login":"rkfg","author_association":"OWNER","created_at":"2022-10-02T11:19:05+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264618542","fragment_type":"issue_comment","sequence":4,"text":"Got it.. Not as familiar w the workings of github, branches/etc… followed this guide with exception of changing version to 1.2.0\n\n URL \n\nOn Sun, Oct 2, 2022 at 7:19 AM, rkfg ***@***.***> wrote:","author_login":"mcsnubbs","author_association":"NONE","created_at":"2022-10-02T11:22:02+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264619656","fragment_type":"issue_comment","sequence":5,"text":"Yep, could be confusing. Maybe it's better to install with `go install github.com/rkfg/regolancer@master` instead of `@latest`. I'm not good at versioning admittedly 😅. Btw cool guide, I didn't expect someone to write it for my software! Feels extremely rewarding, thanks!","author_login":"rkfg","author_association":"OWNER","created_at":"2022-10-02T11:26:57+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264620490","fragment_type":"issue_comment","sequence":6,"text":"Will give it a try - satsHive did the guide for raspibolt. Thank you\n\nOn Sun, Oct 2, 2022 at 7:27 AM, rkfg ***@***.***> wrote:","author_login":"mcsnubbs","author_association":"NONE","created_at":"2022-10-02T11:31:06+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264645747","fragment_type":"issue_comment","sequence":7,"text":"@master worked! Thank you\n\nUsing your suggestions above I also tried -pfrom and --allow-unbalance-from in an attempt to force a rebalance with a max ppm as:\n\n$ go/bin/regolancer -f /home/regolancer/config.json pfrom=100 --allow-unbalance-from --fee-limit-ppm=25 --from=828274203871412225\n\nhowever it still says no source channels exist... that particular channel has about 50% outbound currently. Am I missing any other required flags/attributes? Thank again","author_login":"mcsnubbs","author_association":"NONE","created_at":"2022-10-02T13:35:06+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264646122","fragment_type":"issue_comment","sequence":8,"text":"Disregard .... needed --pfrom=100 \n\nIt works; crazy fast thank you! Will continue experimenting with this","author_login":"mcsnubbs","author_association":"NONE","created_at":"2022-10-02T13:36:58+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264646608","fragment_type":"issue_comment","sequence":9,"text":"Glad it worked, I also added displaying msat fees, hopefully everywhere they're shown. They look like `0.350` and such, I tried `350msat` but it was lowkey ugly and confusing. And unknown flags should result in descriptive errors now.","author_login":"rkfg","author_association":"OWNER","created_at":"2022-10-02T13:39:26+08:00","repo_name":"rkfg/regolancer","issue_id":1393712210,"issue_number":6,"issue_url":"https://github.com/rkfg/regolancer/issues/6","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1391222221","fragment_type":"issue_description","sequence":0,"text":"Take \"lost profits\" from source channels into consideration for picking a route\nRebalance-lnd's biggest strength coming from the economical viable computation whether a source is the right source or not.\nI just tried a rebalance with --pfrom and --pto, and it picked a rather expensive source, to pull a certainly cheaper target.\n\nAware that I can exclude the channel or the node, but is it feasible to implement the profitability computation to mark sources only if the cost + lost profit is < than the possible profit of a target?","author_login":"TrezorHannes","author_association":"NONE","created_at":"2022-09-29T17:20:00+08:00","repo_name":"rkfg/regolancer","issue_id":1391222221,"issue_number":2,"issue_url":"https://github.com/rkfg/regolancer/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1263133751","fragment_type":"issue_comment","sequence":1,"text":"This can be added as an optional parameter, yes. I never found it useful personally because I know which channels are sinks and can simply exclude them from the sources (and they usually have less than 50% outbound). The rest rarely move themselves so their fees are more like random rewards I don't count on much. Setting zero fee on those channels doesn't help moving them at all so I just leave it small.","author_login":"rkfg","author_association":"OWNER","created_at":"2022-09-30T05:54:13+08:00","repo_name":"rkfg/regolancer","issue_id":1391222221,"issue_number":2,"issue_url":"https://github.com/rkfg/regolancer/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264359118","fragment_type":"issue_comment","sequence":2,"text":"Check if the max fee displayed is correct for you. Manually calculate the target channel future income (as `(base_fee + amount * fee_ppm) * econ_ratio`), subtract the source channel fee (as `base_fee + amount * fee_ppm`).","author_login":"rkfg","author_association":"OWNER","created_at":"2022-10-01T13:04:43+08:00","repo_name":"rkfg/regolancer","issue_id":1391222221,"issue_number":2,"issue_url":"https://github.com/rkfg/regolancer/issues/2","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0078","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[ServerErrors][TypeScript] 5.0.0-dev.20230206?","query_context":"The following errors were reported by 5.0.0-dev.20230206\nPipeline that generated this bug\nLogs for the pipeline run\nFile that generated the pipeline\n\nThis run considered 200 popular TS repos from GH (after skipping the top 0).\n\n \n Successfully analyzed 187 of 200 visited repos \n\n| Outcome | Count |\n|---------|-------|\n| Detected interesting changes | 8 |\n| Detected no interesting changes | 179 |\n| Git clone failed | 1 |\n| Unknown failure | 12 |\n\n \n\n## Investigation Status\n| Repo | Errors | Outcome |\n|------|--------|---------|\n|angular/angular-cli|1| |\n|apache/echarts|1| |\n|BuilderIO/qwik|1| |\n|GrapesJS/grapesjs|1| |\n|mantinedev/mantine|1| |\n|nocodb/nocodb|1| |\n|palantir/blueprint|1| |\n|redwoodjs/redwood|1| |","known_context_document_ids":["gh_issue_1573487642"],"reference_answer":"Probably all related:\n\n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n\nI'll try closing these and we'll revisit if they pop back up.","answer_document_id":"gh_comment_1423493149","silver_evidence_path":["gh_comment_1421687506","gh_issue_1575235123","gh_comment_1423493149"],"evidence_issue_ids":[1573487642,1575235123],"source_repo_name":"microsoft/TypeScript","source_issue_id":1573487642,"source_issue_number":52645,"source_issue_url":"https://github.com/microsoft/TypeScript/issues/52645","target_repo_name":"microsoft/TypeScript","target_issue_id":1575235123,"target_issue_number":52662,"target_issue_url":"https://github.com/microsoft/TypeScript/issues/52662","reference_anchor_document_id":"gh_comment_1421687506","reference_answer_author":"DanielRosenwasser","reference_answer_author_association":"MEMBER","quality_score":76.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2023-02-07T00:19:55+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_1573487642","fragment_type":"issue_description","sequence":0,"text":"[ServerErrors][TypeScript] 5.0.0-dev.20230206\nThe following errors were reported by 5.0.0-dev.20230206\nPipeline that generated this bug\nLogs for the pipeline run\nFile that generated the pipeline\n\nThis run considered 200 popular TS repos from GH (after skipping the top 0).\n\n \n Successfully analyzed 187 of 200 visited repos \n\n| Outcome | Count |\n|---------|-------|\n| Detected interesting changes | 8 |\n| Detected no interesting changes | 179 |\n| Git clone failed | 1 |\n| Unknown failure | 12 |\n\n \n\n## Investigation Status\n| Repo | Errors | Outcome |\n|------|--------|---------|\n|angular/angular-cli|1| |\n|apache/echarts|1| |\n|BuilderIO/qwik|1| |\n|GrapesJS/grapesjs|1| |\n|mantinedev/mantine|1| |\n|nocodb/nocodb|1| |\n|palantir/blueprint|1| |\n|redwoodjs/redwood|1| |","author_login":"typescript-bot","author_association":"COLLABORATOR","created_at":"2023-02-07T00:19:55+08:00","repo_name":"microsoft/TypeScript","issue_id":1573487642,"issue_number":52645,"issue_url":"https://github.com/microsoft/TypeScript/issues/52645","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1421687506","fragment_type":"issue_comment","sequence":1,"text":"The `addImportFromExportedSymbol` from grapesjs and nocodb is likely the same, and filed at #52662.","author_login":"DanielRosenwasser","author_association":"MEMBER","created_at":"2023-02-08T00:18:36+08:00","repo_name":"microsoft/TypeScript","issue_id":1573487642,"issue_number":52645,"issue_url":"https://github.com/microsoft/TypeScript/issues/52645","linked_issue_ids":[1575235123],"is_known_query_context":false},{"document_id":"gh_comment_1421712480","fragment_type":"issue_comment","sequence":2,"text":"The echarts issue with `getMemberOverrideModifierStatus` and `getTextOfPropertyName` is filed at #52664.","author_login":"DanielRosenwasser","author_association":"MEMBER","created_at":"2023-02-08T00:44:10+08:00","repo_name":"microsoft/TypeScript","issue_id":1573487642,"issue_number":52645,"issue_url":"https://github.com/microsoft/TypeScript/issues/52645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1575235123","fragment_type":"issue_description","sequence":0,"text":"Assertion failure when class member snippet relies on default-exported type\nts\n// @filename: other.ts\nexport default class Other {}\n\n// @filename: base.ts\nimport Other from \"./other\";\n\nexport class Base {\n foo(): Other {\n throw new Error(\"\");\n }\n}\n\n// @filename: derived.ts\nimport { Base } from \"./base\";\n\nexport class Derived extends Base {\n /*$*/\n}\n\nRequest completions with class member snippets and snippet completions enabled.\n\nMessage: Error processing request. Debug Failure.\nError: Debug Failure.\n at Object.addImportFromExportedSymbol (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:156324:70)\n at /vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:161889:63\n at Array.forEach ( )\n at importSymbols (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:161889:21)\n at createSignatureDeclarationFromSignature (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:161567:25)\n at outputMethod (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:161495:30)\n at Object.addNewNodeForMemberSymbol (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:161474:25)\n at getEntryForMemberCompletion (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:135751:24)\n at createCompletionEntry (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:135603:23)\n at getCompletionEntriesFromSymbols (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:136106:29)\n at completionInfoFromData (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:135415:31)\n at Object.getCompletionsAtPosition (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:135275:36)\n at Object.getCompletionsAtPosition (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:169151:35)\n at IpcIOSession.Session.getCompletions (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:181300:64)\n at Session.handlers.ts.Map.ts.getEntries._a. (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:179973:61)\n at /vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:182034:96\n at IpcIOSession.Session.executeWithRequestId (/vscode/bin/linux-x64/some-id-insider/extensions/node_modules/typescript/lib/tsserver.js:182025:28)","author_login":"DanielRosenwasser","author_association":"MEMBER","created_at":"2023-02-08T00:17:24+08:00","repo_name":"microsoft/TypeScript","issue_id":1575235123,"issue_number":52662,"issue_url":"https://github.com/microsoft/TypeScript/issues/52662","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1423493149","fragment_type":"issue_comment","sequence":1,"text":"Probably all related:\n\n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n\nI'll try closing these and we'll revisit if they pop back up.","author_login":"DanielRosenwasser","author_association":"MEMBER","created_at":"2023-02-09T01:49:07+08:00","repo_name":"microsoft/TypeScript","issue_id":1575235123,"issue_number":52662,"issue_url":"https://github.com/microsoft/TypeScript/issues/52662","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0079","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Create a POA request in vets-api?","query_context":"## Background\nFor users intending to submit a request digitally, the CTA on the `review-and-submit` page will update to \"Submit form\" (per URL When the user clicks \"Submit form\" on the frontend, the backend should create a POA request in vets-api. This will allow the request to appear in the Accredited Rep Portal, for a representative to accept/decline.\n\nIf the creation fails, the frontend will need to know so that it can show the user an error and give them the opportunity to try re-submitting. (That will be handled in URL \n\nImplementation note:\n- We can assume that we'll have approval for pilot (which will be 6-12 months) for the POA request to be in the vets-api database (not CorpDB).\n\nOpen questions:\n1. What is the expectation (if any) in the VA Forms Library, when a form is submitted? Are there any built-in callbacks or submit hooks that we can pick up?\n2. What information should be included in the request? \n3. How/where do we create the request, so the ARP can receive it?\n4. After the POA Request is created, where do we store the expiration date?\n5. After the POA request is created, do we need to store the record ID anywhere in ARM code for future troubleshooting?\n\n## Tasks\n- [ ] Create a POA request\n- [ ] Pass an error back to the frontend if there is an issue creating the request\n- [ ] Unit tests\n\n## Acceptance Criteria\n- [ ] When a user clicks \"Submit form\" on the Review page, a POA request is created in a vets-api database which is then passed to the Accredited Representative Portal for a representative to accept/decline the POA request.\n- [ ] When there's an error creating a POA request, let the frontend know so it can serve an error to the user.","known_context_document_ids":["gh_issue_2768388898"],"reference_answer":"Will include this in the request endpoint. Blocked until Jon is done building that.","answer_document_id":"gh_comment_2622486515","silver_evidence_path":["gh_comment_2635152129","gh_issue_2764720615","gh_comment_2622486515"],"evidence_issue_ids":[2768388898,2764720615],"source_repo_name":"department-of-veterans-affairs/va.gov-team","source_issue_id":2768388898,"source_issue_number":99974,"source_issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99974","target_repo_name":"department-of-veterans-affairs/va.gov-team","target_issue_id":2764720615,"target_issue_number":99803,"target_issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","reference_anchor_document_id":"gh_comment_2635152129","reference_answer_author":"holdenhinkle","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.1538,"target_answer_overlap":0.1111},"issue_created_at":"2025-01-04T03:07:49+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2768388898","fragment_type":"issue_description","sequence":0,"text":"Create a POA request in vets-api\n## Background\nFor users intending to submit a request digitally, the CTA on the `review-and-submit` page will update to \"Submit form\" (per URL When the user clicks \"Submit form\" on the frontend, the backend should create a POA request in vets-api. This will allow the request to appear in the Accredited Rep Portal, for a representative to accept/decline.\n\nIf the creation fails, the frontend will need to know so that it can show the user an error and give them the opportunity to try re-submitting. (That will be handled in URL \n\nImplementation note:\n- We can assume that we'll have approval for pilot (which will be 6-12 months) for the POA request to be in the vets-api database (not CorpDB).\n\nOpen questions:\n1. What is the expectation (if any) in the VA Forms Library, when a form is submitted? Are there any built-in callbacks or submit hooks that we can pick up?\n2. What information should be included in the request? \n3. How/where do we create the request, so the ARP can receive it?\n4. After the POA Request is created, where do we store the expiration date?\n5. After the POA request is created, do we need to store the record ID anywhere in ARM code for future troubleshooting?\n\n## Tasks\n- [ ] Create a POA request\n- [ ] Pass an error back to the frontend if there is an issue creating the request\n- [ ] Unit tests\n\n## Acceptance Criteria\n- [ ] When a user clicks \"Submit form\" on the Review page, a POA request is created in a vets-api database which is then passed to the Accredited Representative Portal for a representative to accept/decline the POA request.\n- [ ] When there's an error creating a POA request, let the frontend know so it can serve an error to the user.","author_login":"oddball-lindsay","author_association":"CONTRIBUTOR","created_at":"2025-01-04T03:07:49+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2768388898,"issue_number":99974,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99974","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2622529916","fragment_type":"issue_comment","sequence":1,"text":"Partially blocked on this until ART finalizes their models. There's a stack of inflight work that will significantly change their modeling and that makes it difficult to create requests at this time.\n\nIn the meantime, we can make a generic endpoint for submission so that the front end has that integration ready to go. we can put in a temporary way to force errors to surface that to users, and we can test the success email.","author_login":"jvcAdHoc","author_association":"CONTRIBUTOR","created_at":"2025-01-29T18:35:55+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2768388898,"issue_number":99974,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2635152129","fragment_type":"issue_comment","sequence":2,"text":"Calling out the work related to this, in case we need to reconsider any other approaches once the ARF models are finalized:\n1. #99802\n2. #99804\n3. #99973 \n4. #99803 \n5. #101322","author_login":"oddball-lindsay","author_association":"CONTRIBUTOR","created_at":"2025-02-04T21:49:50+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2768388898,"issue_number":99974,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99974","linked_issue_ids":[2764720615],"is_known_query_context":false},{"document_id":"gh_comment_2654428662","fragment_type":"issue_comment","sequence":3,"text":"First pr is in review. It will need ART and Platform approval to merge","author_login":"jvcAdHoc","author_association":"CONTRIBUTOR","created_at":"2025-02-12T17:41:34+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2768388898,"issue_number":99974,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2764720615","fragment_type":"issue_description","sequence":0,"text":"Digital submission email confirmation in VA Notify Staging\n## Background\nIn #99802, users who intend to request POA digitally will have a new \"Submit form\" CTA on the `review-and-submit` page.\n\nClicking \"Submit form\" will create the POA request ( URL and after that request is successfully created:\n1. The user will be routed to the `confirmation` page\n2. If the user entered an email address for themself (Veteran users only for v2), the user will receive an email notification reiterating the next steps.\n\nThis email notification currently exists in VA Notify Staging with the name \"Appoint a Representative v2 - Digital Submit Confirm\".\n\n## Tasks\n- [ ] After a POA request is successfully created, engage VA Notify for the \"Appoint a Representative v2 - Digital Submit Confirm\" email.\n- [ ] Work with @oddball-lindsay to adjust variables in the email template, as needed.\n- [ ] Confirm everything is working as expected in VA Notify Staging.\n\n## Acceptance Criteria\n- [ ] The Appoint v2 experience is setup to send an email notification to any users who request POA digitally.\n- [ ] The VA Notify template is rendering as expected, including variable content and is ready to be promoted to Production.","author_login":"oddball-lindsay","author_association":"CONTRIBUTOR","created_at":"2024-12-31T23:16:38+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2622486515","fragment_type":"issue_comment","sequence":1,"text":"Will include this in the request endpoint. Blocked until Jon is done building that.","author_login":"holdenhinkle","author_association":"COLLABORATOR","created_at":"2025-01-29T18:13:30+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2635142061","fragment_type":"issue_comment","sequence":2,"text":"Now that the submission endpoint is done I can continue working on the data model for the email and can put the code that calls it in that new endpoint. That calling code will probably be moved elsewhere eventually.","author_login":"opticbob","author_association":"NONE","created_at":"2025-02-04T21:43:51+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2638206627","fragment_type":"issue_comment","sequence":3,"text":"The data object that takes the PDF/digital form submission and extracts the info used in the email template is done. I need to write some tests for it and it'll be ready to go.","author_login":"opticbob","author_association":"NONE","created_at":"2025-02-05T22:46:03+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2649036441","fragment_type":"issue_comment","sequence":4,"text":"@opticbob confirming I've removed the times from the email template: \n\nImage","author_login":"oddball-lindsay","author_association":"CONTRIBUTOR","created_at":"2025-02-10T19:29:04+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2652263916","fragment_type":"issue_comment","sequence":5,"text":"This is still in team review. Platform has reminded me that they can't review it until it's been team reviewed.","author_login":"opticbob","author_association":"NONE","created_at":"2025-02-11T23:06:53+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2655027260","fragment_type":"issue_comment","sequence":6,"text":"The PR for this is team and Platform reviewed and ready to merge. I haven't merged it yet because I can't figure out how to add the staging template id to the vsp-infra-application-manifests repo. The staging file I added to last time no longer contains those values and I can't find it in the repo. I confirmed that the email is still sending just fine from staging.\n\nI've asked the VA Notify team for assistance, details on slack.","author_login":"opticbob","author_association":"NONE","created_at":"2025-02-12T23:00:23+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2660129851","fragment_type":"issue_comment","sequence":7,"text":"The code for sending the email is done, I haven't added the template id to the manifests repo where that value can be used from within `vets-api`. The PR to do that is waiting on feedback from Platform.","author_login":"opticbob","author_association":"NONE","created_at":"2025-02-14T19:42:09+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2664095347","fragment_type":"issue_comment","sequence":8,"text":"Platform has responded, I've updated the PR and that is back in front of them to review.","author_login":"opticbob","author_association":"NONE","created_at":"2025-02-17T21:21:48+08:00","repo_name":"department-of-veterans-affairs/va.gov-team","issue_id":2764720615,"issue_number":99803,"issue_url":"https://github.com/department-of-veterans-affairs/va.gov-team/issues/99803","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0080","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: Electron helper high cpu usage?","query_context":"### Preflight Checklist\n\n- [X] I have read the Contributing Guidelines for this project.\n- [X] I agree to follow the Code of Conduct that this project adheres to.\n- [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.\n\n### Electron Version\n\n16.0.1\n\n### What operating system are you using?\n\nmacOS\n\n### Operating System Version\n\nmacOS big sur 11.5.2\n\n### What arch are you using?\n\nx64\n\n### Last Known Working Electron version\n\n_No response_\n\n### Expected Behavior\n\nObserving system load should be fine I think.\n\n URL \n\nthe module works fine itself, but when i run it with electron or as a fork process it impact cpu usage\n\n### Actual Behavior\n\nimage\n\nthe electron helper is about 99% usage\n\n### Testcase Gist URL\n\n URL \n\n### Additional Information\n\nimage\n\nbash\ngit clone URL \ncd revealer\nnpm i\nnpm run dev","known_context_document_ids":["gh_issue_1058947734"],"reference_answer":"@brandon-doornbos, thanks. That RC build is based on recently released @electron 16.0.6 which includes @chromium bump so I thought maybe the issue got fixed somewhere upstream in @chromium. So will be releasing a new version built on old/v15 @electron.\n \n\nDoesn't happen to me on Linux for some reason.","answer_document_id":"gh_comment_1004969103","silver_evidence_path":["gh_comment_1005046466","gh_issue_1051014796","gh_comment_1004969103"],"evidence_issue_ids":[1058947734,1051014796],"source_repo_name":"electron/electron","source_issue_id":1058947734,"source_issue_number":31916,"source_issue_url":"https://github.com/electron/electron/issues/31916","target_repo_name":"vladimiry/ElectronMail","target_issue_id":1051014796,"target_issue_number":461,"target_issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","reference_anchor_document_id":"gh_comment_1005046466","reference_answer_author":"vladimiry","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.375,"anchor_target_overlap":0.25,"target_answer_overlap":0.1379},"issue_created_at":"2021-11-19T21:55:09+08:00","valid_comment_count":60,"fragments":[{"document_id":"gh_issue_1058947734","fragment_type":"issue_description","sequence":0,"text":"[Bug]: Electron helper high cpu usage\n### Preflight Checklist\n\n- [X] I have read the Contributing Guidelines for this project.\n- [X] I agree to follow the Code of Conduct that this project adheres to.\n- [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.\n\n### Electron Version\n\n16.0.1\n\n### What operating system are you using?\n\nmacOS\n\n### Operating System Version\n\nmacOS big sur 11.5.2\n\n### What arch are you using?\n\nx64\n\n### Last Known Working Electron version\n\n_No response_\n\n### Expected Behavior\n\nObserving system load should be fine I think.\n\n URL \n\nthe module works fine itself, but when i run it with electron or as a fork process it impact cpu usage\n\n### Actual Behavior\n\nimage\n\nthe electron helper is about 99% usage\n\n### Testcase Gist URL\n\n URL \n\n### Additional Information\n\nimage\n\nbash\ngit clone URL \ncd revealer\nnpm i\nnpm run dev","author_login":"crapthings","author_association":"NONE","created_at":"2021-11-19T21:55:09+08:00","repo_name":"electron/electron","issue_id":1058947734,"issue_number":31916,"issue_url":"https://github.com/electron/electron/issues/31916","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1005046466","fragment_type":"issue_comment","sequence":1,"text":"Also starting from @electron v16 facing an abnormally high CPU load issue, see URL So had to downgrade to v15. Could not yet narrow down the scope.","author_login":"vladimiry","author_association":"NONE","created_at":"2022-01-04T17:59:59+08:00","repo_name":"electron/electron","issue_id":1058947734,"issue_number":31916,"issue_url":"https://github.com/electron/electron/issues/31916","linked_issue_ids":[1051014796],"is_known_query_context":false},{"document_id":"gh_comment_1024490644","fragment_type":"issue_comment","sequence":2,"text":"Thanks for reporting this and helping to make Electron better!\n\nBecause of time constraints, triaging code with third-party dependencies is usually not feasible for a small team like Electron's.\n\nWould it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.\n\nStand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.\n\nI'm adding the `blocked/need-repro` label for this reason. After you make a test case, please link to it in a followup comment.\n\nThanks in advance! Your help is appreciated.","author_login":"nornagon","author_association":"MEMBER","created_at":"2022-01-28T18:20:15+08:00","repo_name":"electron/electron","issue_id":1058947734,"issue_number":31916,"issue_url":"https://github.com/electron/electron/issues/31916","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1295642072","fragment_type":"issue_comment","sequence":3,"text":"@deepak1556 \n\nDo you think this thread URL is related to the current bug?","author_login":"M00N-MAN","author_association":"NONE","created_at":"2022-10-28T23:38:34+08:00","repo_name":"electron/electron","issue_id":1058947734,"issue_number":31916,"issue_url":"https://github.com/electron/electron/issues/31916","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1301703518","fragment_type":"issue_comment","sequence":4,"text":"我目前用的是 Linux arch芯片的电脑，使用electron做的应用出现了这个问题，有什么解决办法吗？\n#######\nI am currently using a computer with Linux arch chip. This problem occurs in the application made with electron. Is there any solution?","author_login":"yanguoqiang29","author_association":"NONE","created_at":"2022-11-03T06:42:48+08:00","repo_name":"electron/electron","issue_id":1058947734,"issue_number":31916,"issue_url":"https://github.com/electron/electron/issues/31916","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1051014796","fragment_type":"issue_description","sequence":0,"text":"High CPU usage as of v4.13.0\nHi, I upgraded to `v4.13.0` recently and noticed that my fans were spinning even though I wasn't doing any CPU intensive tasks. Upon inspections it looks like one of the threads belonging to ElectronMail were the cause:\nimage\n\nMaybe it's due to some kind of continuous event loop?\n\nOS: Arch Linux","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-11T14:05:38+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966350172","fragment_type":"issue_comment","sequence":1,"text":"It's a renderer/web/@chromium process but hard to say just by the screenshot which part of the functionality it's related to (@protonmail web clients or app's UI). I'm not seeing any intensive CPU load at my side (Linux).","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-11T14:32:44+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966522157","fragment_type":"issue_comment","sequence":2,"text":"I think the issue started after I enabled the \"custom actions\" menu, but that is blind speculation on my part as it could've been a coincidence.\n\nI can help by debugging the code on my computer. I cloned the code and installed the dependencies, but I can't find a way to run the app without building it so that I can use debugger tools to profile the code.\n\n$ npm run start:electron:dev\n \n \n\nError launching app\nUnable to find Electron app at ./app-dev/electron-main.js\n\nCan you guide me through the debug process? I have experience with JavaScript and NodeJS, but I am not really familiar with other tools, especially TypeScript.","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-11T18:18:49+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966542624","fragment_type":"issue_comment","sequence":3,"text":"I thought maybe I missed properly disconnection the `MutationObserver` thing which might potentially cause the issue. But I just debugged it and can confirm it gets well disconnected (here is the code line). The minor optimization I just pushed is 9af8f4c665d6eae57a4b0a2df7ef7ae73dd454b0.\n \n\nIt's the same build steps as listed in readme (excluding the packaging step), but at the end run `yarn assets:dev && yarn build:dev`. Then you start it by `yarn start:electron:dev`. There is at the moment no hot reload thing for the web stuff (dropped it long time ago and didn't get back yet).","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-11T18:50:04+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966543986","fragment_type":"issue_comment","sequence":4,"text":"Build command: `yarn && yarn assets:dev && yarn build:dev && yarn clean:prebuilds && npm exec --package=electron-builder -- electron-builder install-app-deps --arch=x64`","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-11T18:52:13+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966866474","fragment_type":"issue_comment","sequence":5,"text":"Thanks for the instructions, but for some reason yarn is giving me errors, I ran the command from your post as well as the one from README: URL (output is too long so I pasted on an external site)","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-12T06:49:54+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966869676","fragment_type":"issue_comment","sequence":6,"text":"I missed the fact that you will need to build @protonmail clients by running `yarn assets:dev`. Better download those clients by URL (taken from URL ie v4.13.0 release build jobs). Then unpack the archive to some place, rename the `app => app-dev` folder, and then copy to the project folder.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-12T06:57:45+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966922434","fragment_type":"issue_comment","sequence":7,"text":"I did what you asked, and ran `yarn build:dev`, but it's still not working...\n\nTheDcoder@arch /m/d/P/J/ElectronMail (master)> yarn start:electron:dev\nyarn run v1.22.17\n$ electron ./app-dev/electron-main.js\nError launching app\nUnable to find Electron app at /mnt/data_partition/Projects/JavaScript/ElectronMail/app-dev/electron-main.js\n\nCannot find module '/mnt/data_partition/Projects/JavaScript/ElectronMail/app-dev/electron-main.js'\nRequire stack:\n- /mnt/data_partition/Projects/JavaScript/ElectronMail/node_modules/electron/dist/resources/default_app.asar/main.js\n- \nerror Command failed with exit code 1.\ninfo Visit URL for documentation about this command.\n\nTheDcoder@arch /m/d/P/J/ElectronMail (master)> ls app-dev\nassets electron-main electron-preload web\n\nI think we can debug this more efficiently if we can communicate in real-time, do you use IRC or Matrix?","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-12T08:40:26+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966925962","fragment_type":"issue_comment","sequence":8,"text":"My bad, I didn't update the `start:electron / start:electron:dev` npm scripts after recent `./app/electron-main.js => ./app/electron-main/index.cjs` rename. So use direct run, like `npx electron ./app-dev/electron-main/index.cjs`. Done now in 92a8834b7f5491a5bc639e96acb873eb5a09e086.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-12T08:46:37+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966932722","fragment_type":"issue_comment","sequence":9,"text":"Direct run worked... but unfortunately the native build artifacts were compiled with an older version of node, so I can't use them:\n\nError: The module '/mnt/data_partition/Projects/JavaScript/ElectronMail/node_modules/spellchecker/build/Release/spellchecker.node'\nwas compiled against a different Node.js version using\nNODE_MODULE_VERSION 93. This version of Node.js requires\nNODE_MODULE_VERSION 99. Please try re-compiling or re-installing\nthe module (for instance, using `npm rebuild` or `npm install`).\n at process.func [as dlopen] (node:electron/js2c/asar_bundle:5:1800)\n at Object.Module._extensions..node (node:internal/modules/cjs/loader:1199:18)\n at Object.func [as .node] (node:electron/js2c/asar_bundle:5:1800)\n at Module.load (node:internal/modules/cjs/loader:988:32)\n at Module._load (node:internal/modules/cjs/loader:829:12)\n at Function.c._load (node:electron/js2c/asar_bundle:5:13331)\n at Module.require (node:internal/modules/cjs/loader:1012:19)\n at require (node:internal/modules/cjs/helpers:94:18)\n at Object. (/mnt/data_partition/Projects/JavaScript/ElectronMail/node_modules/spellchecker/lib/spellchecker.js:3:16)\n at Module._compile (node:internal/modules/cjs/loader:1116:14) {\n code: 'ERR_DLOPEN_FAILED'\n}\n\nI will try building ProtonMail myself.","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-12T08:57:48+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966934463","fragment_type":"issue_comment","sequence":10,"text":"A native dependencies. You need to run `yarn clean:prebuilds && npm exec --package=electron-builder -- electron-builder install-app-deps --arch=x64` (listed above).","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-12T09:00:36+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966938803","fragment_type":"issue_comment","sequence":11,"text":"Oops, my bad, I missed that command. I ran it again and the app is running :+1:\n\nI have encountered another issue though, I am getting this error while logging in;\n\nFailed to resolve the \"web-client\" bundle location by \" URL API entry point value\n\nMy fan is not spinning at full speed yet, so the resource-consuming loop isn't triggered at this point.","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-12T09:07:17+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966943226","fragment_type":"issue_comment","sequence":12,"text":"Make sure you properly unpacked the @protonmail web clients (see URL After doing that unpacking/renaming you need to run `yarn assets:dev` again so the script takes client from the ./output/git/backup and puts it into ./app-dev/webclient.\n \n\nAt this point it's only the app stuff is loaded, no @protonmail involving yet.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-12T09:14:00+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[1051014796],"is_known_query_context":false},{"document_id":"gh_comment_966971595","fragment_type":"issue_comment","sequence":13,"text":"Awesome, thanks for assistance, I am able to run the app now.\n\nBut I couldn't reproduce the 100% CPU usage... so I tested with the pre-built release version and it still is eating up 100% of the CPU. It only happens once I load an email, so I guess it has to do something with the specific version/build of the ProtonMail stack?\n\n@vladimiry Did you test the release build? Perhaps you might be able to reproduce it too.","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-12T09:57:56+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_967118430","fragment_type":"issue_comment","sequence":14,"text":"Sorry for not explaining properly, I mean the exact binaries, I think a very specific version of ProtonMail stack might be responsible...","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-12T13:28:08+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_967636471","fragment_type":"issue_comment","sequence":15,"text":"I too have high CPU usage since the update.\nI'm on Windows 10 with a i7700k and ElectonMail is is using 13-17% CPU, even when its closed to the tray.","author_login":"prestr","author_association":"NONE","created_at":"2021-11-12T21:54:58+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_967795055","fragment_type":"issue_comment","sequence":16,"text":"Can you test the build shared in URL (it's v4.13.0 but with downgraded @electron).","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-13T07:00:54+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_967821938","fragment_type":"issue_comment","sequence":17,"text":"@vladimiry This build is working without performance issues! Hardly any CPU is being used during idle now :)","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-13T08:36:10+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_967827155","fragment_type":"issue_comment","sequence":18,"text":"Great, so you have got a workaround for now. It means that the issue lies somewhere in @electron since 16.0.0-beta.8 => 15.3.1 downgrade did the trick.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-13T08:39:03+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_968088649","fragment_type":"issue_comment","sequence":19,"text":"Just confirming that the build is working for me too on Windows 10.","author_login":"prestr","author_association":"NONE","created_at":"2021-11-13T15:46:21+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_968090551","fragment_type":"issue_comment","sequence":20,"text":"So it's not system-specific as the issue reported to be happening in Linux and Windows 10.\n\nI will consider publishing a new release with downgraded @electron if more reports get posted here. But would prefer to first make a new build based on a stable @electron v16 (it's going to be released next week).","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-13T15:59:32+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_968931196","fragment_type":"issue_comment","sequence":21,"text":"I am experiencing high cpu usage on Windows 11 as well since last update","author_login":"fusionneur","author_association":"NONE","created_at":"2021-11-15T13:52:46+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_968977801","fragment_type":"issue_comment","sequence":22,"text":"Ok, I wait then for @electron v16 stable release which gets published this week. Then I ask to test the new build and then I release the v15 or v16 @electron-based version depending on the testing outcome.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-15T14:42:02+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_970192060","fragment_type":"issue_comment","sequence":23,"text":"I'm asking everyone affected by abnormal CPU load of v4.13.0 to test the build shared in URL","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-16T11:45:58+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_970563573","fragment_type":"issue_comment","sequence":24,"text":"WIP version 4.13.1 from mega link still causing 10% (high) cpu usage all the time on Windows 10.","author_login":"Tigrich","author_association":"NONE","created_at":"2021-11-16T18:44:09+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_970573414","fragment_type":"issue_comment","sequence":25,"text":"Thanks. So a stable/today's @electron v16 reelase is also affected. It's at the moment unclear what exactly causes the abnormally high CPU usage between different @electron versions and I was not able to locate related open issues in URL but since a renderer process is affected the cause is likely somewhere in @chromium integrant. So it looks like we had to stick to @electron v15 for now.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-16T18:54:37+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_970711587","fragment_type":"issue_comment","sequence":26,"text":"Hopefully, a final testing build is uploaded here. Going to publish it as v4.13.1 release when someone confirms that it doesn't cause an abnormally high CPU usage.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-16T21:52:54+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_970881258","fragment_type":"issue_comment","sequence":27,"text":"v4.13.1-wip-2 no more abnormal cpu usage for me on Windows 10.","author_login":"Tigrich","author_association":"NONE","created_at":"2021-11-16T23:59:30+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_971314453","fragment_type":"issue_comment","sequence":28,"text":"@vladimiry I tested the 2nd wip and I see constant 2-3% usage by two of the processes, maybe this is an unrelated issue but it is there. It was not present in `v4.13.0` with downgraded electron, it had 0% usage during idle.","author_login":"TheDcoder","author_association":"NONE","created_at":"2021-11-17T07:37:34+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_971320101","fragment_type":"issue_comment","sequence":29,"text":"@TheDcoder the recent build I shared (v4.13.1-wip-2) is built on @electron 15.3.2. The previously shared was 15.3.1-based and verified as not causing the issue. I'm ok to wait for one/two days before publishing the recently shared build as a release so we could get additional feedback from you or someone else.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-17T07:47:26+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_971354720","fragment_type":"issue_comment","sequence":30,"text":"For me v4.13.1-wip-2 (built on @electron 15.3.2) works fine - i see no idle cpu usage","author_login":"fusionneur","author_association":"NONE","created_at":"2021-11-17T08:36:35+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_974418427","fragment_type":"issue_comment","sequence":31,"text":"Can confirm that v4.13.1-wip-2 also fixes the high CPU usage for me (Arch Linux).","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2021-11-19T20:24:09+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_974478848","fragment_type":"issue_comment","sequence":32,"text":"The v4.13.1 RC build assembled from the `master` branch is uploaded here. Hope someone confirms that there is no issue. It should be fine as it's based on the same @electron v15.3.2 but comes with updated @protonmail web clients.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-19T21:17:53+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_974647134","fragment_type":"issue_comment","sequence":33,"text":"Any more feedbacks? I'm about to publish the recently shared build as a new release.","author_login":"vladimiry","author_association":"OWNER","created_at":"2021-11-20T13:02:03+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004668052","fragment_type":"issue_comment","sequence":34,"text":"Can someone who had CPU usage problem before to test this v4.13.2 release candidate build?\n\nChangelog draft:\n- Bundle proton-vpn-settings web client into the app (#470).\n- Update @ProtonMail web clients stack. The `session.bin` file produced or modified by the v4.13.2+ app version won't be compatible with the previous app versions.\n- Upgrade @electron.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-01-04T09:56:35+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004942892","fragment_type":"issue_comment","sequence":35,"text":"Just tried the RC, and the issue has returned on my Arch Linux machine. One of the processes is again maxing out one thread. (Even after a restart)","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-01-04T16:13:21+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004969103","fragment_type":"issue_comment","sequence":36,"text":"@brandon-doornbos, thanks. That RC build is based on recently released @electron 16.0.6 which includes @chromium bump so I thought maybe the issue got fixed somewhere upstream in @chromium. So will be releasing a new version built on old/v15 @electron.\n \n\nDoesn't happen to me on Linux for some reason.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-01-04T16:38:33+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004994321","fragment_type":"issue_comment","sequence":37,"text":"It's Manjaro (Arch based). I would not ask someone to test the build if I could reproduce the issue at my side.\n\nTo face the issue, do I need to perform a specific action in the app or just start it and login into the proton account?\n \n\nPlease list them here. I don't believe though that @electron contributors will start actively looking into it until the minimal repro project gets provided (which normally hard to do for such kind of issues).\n\nBtw. Notice the below note. So if you use persistent session feature you will have to keep using that RC build or login again if you prefer downgrading to a stable release (new release is coming soon). The reason is that @protomail changed the session credentials storage format in a web clients.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-01-04T16:54:00+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1005038851","fragment_type":"issue_comment","sequence":38,"text":"I tried it fresh on my laptop today, and the only thing I did was install the RC pacman file and then login. This did not do anything so then I closed the app and opened it again and upon logging in, one full thread utilized. On my PC, where I already had the previous version, I just installed the RC and it immediately did it upon logging in.\n \n URL which lists URL which I can't read. The other one I found was for a different version, sorry.\n\nI just can't fathom what would cause this, as it is consistently happening to both my Arch machines but not your Arch based machine.\nIs there something else that I could do to help with finding the cause? Are there debugging tools or something?","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-01-04T17:49:10+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1005043620","fragment_type":"issue_comment","sequence":39,"text":"The app's code need to be compiled in \"dev\" mode in order to be able to open dev tools (I think it's a web/renderer process i a problematic one). There is no documentation on this matter. It's not a complex process but time-consuming, similar to what described in URL Debugging of the main process can be achieved as listed in URL but I tend to think that it's not the main process causes the problem.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-01-04T17:56:07+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1005050733","fragment_type":"issue_comment","sequence":40,"text":"Yes it's clear that it's a renderer process since we got screenshot provided in URL","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-01-04T18:06:04+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[1051014796],"is_known_query_context":false},{"document_id":"gh_comment_1005078151","fragment_type":"issue_comment","sequence":41,"text":"What about this build? if it runs well I will be publishing it as a new release then.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-01-04T18:45:15+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1005084096","fragment_type":"issue_comment","sequence":42,"text":"Yep, no problems.\n\nBTW, i built the thing and a dev build, so I'll see if I can find something.","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-01-04T18:54:07+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1009031247","fragment_type":"issue_comment","sequence":43,"text":"Hello again, well I could not find anything with just the normal debugging tools, and if I would want to debug electron itself, well, debug symbols. The whole electron repository doesn't even fit on my drive so that's a no.\n\nLet's hope that this gets fixed accidentally someday.","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-01-10T16:08:06+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1028392821","fragment_type":"issue_comment","sequence":44,"text":"What about this build (built on recently released @electron v18.0.0-alpha.1 from wip-electron-18 branch)? Still causing issue?","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-02-02T21:52:27+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1028400113","fragment_type":"issue_comment","sequence":45,"text":"Thanks for the test. So it's confirmed that newest @electron v18 alpha is unfortunately also affected.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-02-02T22:02:57+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082738083","fragment_type":"issue_comment","sequence":46,"text":"@brandon-doornbos can you test this build? I has been assembled on recently published @electron v19.0.0-alpha.1. Anyone else is also welcome to test the build.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-03-30T07:43:05+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083079411","fragment_type":"issue_comment","sequence":47,"text":"The high usage does not seem to affect me with this build, so it may actually be fixed. We probably need other people from this thread to confirm it though. (I'm still on the same platform)","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-03-30T12:29:07+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083086208","fragment_type":"issue_comment","sequence":48,"text":"Thanks. So hopefully the next app release will be utilizing @electron v19 runtime. If possible please keep using this build (same as v4.13.6 but with bumped @electron).","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-03-30T12:36:11+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083182831","fragment_type":"issue_comment","sequence":49,"text":"Good call, after using the build for a while longer, the problem seems to have returned. A renderer process is again fully stressing out a single core :(.","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-03-30T14:04:56+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1084283319","fragment_type":"issue_comment","sequence":50,"text":"Asking to share the CPU and GPU type used (including integrated graphics) as it might potentially help to narrow down the scope.\n\nAlso maybe someone who can reproduce the issue could try running the app with disable-like GPU/rendering-related command-line switches from the URL list (you would run the in-page search by the `gpu / renrerer` keywords to locate those switches).","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-03-31T08:51:07+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1086711883","fragment_type":"issue_comment","sequence":51,"text":"I've got an R5 1600 and an RX480, so no integrated graphics.\n\nIt consistently hits one core when I start the app, then if I switch to another account and close the app, it often fixes itself. So maybe it is related to residual processes.\n\nThe behavior is the same in X11 and Wayland.\n\nList of command line arguments I've tried:\n- `--disable-mojo-renderer`\n- `--disable-gpu`\n- `--disable-new-content-rendering-timeout`\n- `--disable-partial-raster`\n- `--disable-renderer-accessibility`\n- `--disable-renderer-backgrounding`\n- `--enable-nacl`\n- `--enable-oop-rasterization`\n- `--extension-process`\n- `--font-cache-shared-handle`\n- `--font-render-hinting`\n- `--instant-process`\n- `--renderer-cmd-prefix=\"valgrind --tool=callgrind\"`\n- `--disable-accelerated-2d-canvas`\n- `--disable-frame-rate-limit`\n- `--disable-gpu-compositing`\n- `--disable-gpu-driver-bug-workarounds`\n- `--disable-gpu-early-init`\n- `--disable-gpu-memory-buffer-compositor-resources`\n- `--disable-gpu-memory-buffer-video-frames`\n- `--disable-gpu-process-crash-limit`\n- `--disable-gpu-program-cache`\n- `--disable-gpu-rasterization`\n- `--disable-gpu-sandbox`\n- `--disable-gpu-shader-disk-cache`\n- `--disable-gpu-vsync`\n- `--disable-gpu-watchdog`\n- `--disable-threaded-compositing`\n- `--disable-zero-copy`\n- `--enable-gpu-debugging`\n- `--enable-native-gpu-memory-buffers`\n- `--gpu-launcher=\"valgrind --tool=callgrind\"`\n- `--ignore-gpu-blocklist`\n- `--in-process-gpu`\n- `--use-fake-mjpeg-decode-accelerator`","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-04-02T19:55:48+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145809786","fragment_type":"issue_comment","sequence":52,"text":"Can someone test the electron v19 based build (build log / changes)? There is a hope that the following changes will make some effect: updated proton clients, updated electron, dropped MutationObserver use in the project.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-06-03T10:08:36+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1146172278","fragment_type":"issue_comment","sequence":53,"text":"Well this may finally be it :).\nIt has not yet shown any signs of excessive resource usage, even after a restart and some usage.","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-06-03T16:51:20+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1146178303","fragment_type":"issue_comment","sequence":54,"text":"Thanks for the feedback. If possible, please keep using this build for a while. Hopefully, the next app release switches to the recent @electron version.","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-06-03T16:57:19+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1146798446","fragment_type":"issue_comment","sequence":55,"text":"Still haven't found any issues, after multiple days, many restarts and actual usage.\nWe probably need a second person from this thread to confirm, but as far as I can see it's fixed.\n\nAlso, thank you for continually thinking of us :).","author_login":"brandon-doornbos","author_association":"NONE","created_at":"2022-06-05T12:46:45+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158767477","fragment_type":"issue_comment","sequence":56,"text":"Going to publish this build later today as a release. Can someone do a final test?","author_login":"vladimiry","author_association":"OWNER","created_at":"2022-06-17T11:12:40+08:00","repo_name":"vladimiry/ElectronMail","issue_id":1051014796,"issue_number":461,"issue_url":"https://github.com/vladimiry/ElectronMail/issues/461","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0081","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Remove/replace references to EC:1.6.1.2?","query_context":"I refreshed the list of obsolete ECs (in #27812), and a new one has been added:\n\n- ERROR: < URL has a definition xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has a synonym xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has an xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has a definition xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has a synonym xref to an obsolete EC: \"EC:1.6.1.2\"","known_context_document_ids":["gh_issue_2273941526"],"reference_answer":"oh, interesting. This is the solr query:\n\n URL \n\nNotice that `+ ` is translated ` ` (double space). This is because the `+` is a URL encoding of a space. The solution is to use the right URL escaping when constructing the SOLR urls. We should also check other characters that typically get encoded, e.g. `:`.","answer_document_id":"gh_comment_2089387099","silver_evidence_path":["gh_comment_2091868401","gh_issue_2274404063","gh_comment_2089387099"],"evidence_issue_ids":[2273941526,2274404063],"source_repo_name":"geneontology/go-ontology","source_issue_id":2273941526,"source_issue_number":27814,"source_issue_url":"https://github.com/geneontology/go-ontology/issues/27814","target_repo_name":"geneontology/amigo","target_issue_id":2274404063,"target_issue_number":718,"target_issue_url":"https://github.com/geneontology/amigo/issues/718","reference_anchor_document_id":"gh_comment_2091868401","reference_answer_author":"cmungall","reference_answer_author_association":"MEMBER","quality_score":91.11,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.1579,"target_answer_overlap":0.0556},"issue_created_at":"2024-05-01T18:06:03+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2273941526","fragment_type":"issue_description","sequence":0,"text":"Remove/replace references to EC:1.6.1.2\nI refreshed the list of obsolete ECs (in #27812), and a new one has been added:\n\n- ERROR: < URL has a definition xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has a synonym xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has an xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has a definition xref to an obsolete EC: \"EC:1.6.1.2\"\n- ERROR: < URL has a synonym xref to an obsolete EC: \"EC:1.6.1.2\"","author_login":"balhoff","author_association":"MEMBER","created_at":"2024-05-01T18:06:03+08:00","repo_name":"geneontology/go-ontology","issue_id":2273941526,"issue_number":27814,"issue_url":"https://github.com/geneontology/go-ontology/issues/27814","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2089329010","fragment_type":"issue_comment","sequence":1,"text":"This is a bit complicated issue.\nEC:1.6.1.1 NAD(P)(+) transhydrogenase (Si-specific) has other name NAD(P)(+) transhydrogenase (B-specific) RHEA:11692\nEC:1.6.1.2 NAD(P)+ transhydrogenase (Re/Si-specific) is transferred to\nEC 7.1.1.1 proton-translocating NAD(P)(+) transhydrogenase RHEA:47992\nEC:1.6.1.3 NAD(P)(+) transhydrogenase RHEA:11692\n\nGO:0008746 NAD(P)+ transhydrogenase activity XREF to EC:1.6.1.1/EC:1.6.1.2/RHEA:11692\n\n... GO:0008750 NAD(P)+ transhydrogenase (AB-specific) activity XREF to EC:1.6.1.2. Also XREF MetaCyc:PYRNUTRANSHYDROGEN-RXN suggests it is about EC:1.6.1.1 and EC:1.6.1.3\n... GO:0003957 NAD(P)+ transhydrogenase (B-specific) activity XREF to EC:1.6.1.1 (NOT RHEA:11692)","author_login":"raymond91125","author_association":"CONTRIBUTOR","created_at":"2024-05-02T00:21:08+08:00","repo_name":"geneontology/go-ontology","issue_id":2273941526,"issue_number":27814,"issue_url":"https://github.com/geneontology/go-ontology/issues/27814","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2089675359","fragment_type":"issue_comment","sequence":2,"text":"**For GO:0008746 NAD(P)+ transhydrogenase activity** XREF to EC:1.6.1.1/EC:1.6.1.2/RHEA:11692\n- [ ] Obsolete ; this is the general case that corresponds to URL which states \"This entry stands for enzymes whose stereo-specificity with respect to NADPH is not known\"; this is associated with the same RHEA as 1.6.1.1 and has no genes associated with it. It seems like the stereospecificity is always known. \n\n**Child GO:0008750 NAD(P)+ transhydrogenase (AB-specific) activity** : \n- [ ] Change general cross references to EC 7.1.1.1 proton-translocating NAD(P)(+) transhydrogenase and RHEA:47992\n- [ ] Change definition to match RHEA \n- [ ] Change definition cross reference to RHEA:47992\n- [ ] remove the link to \"pubs.acs....\" in the def xref that (dead link) \n\n**Child GO:0003957 NAD(P)+ transhydrogenase (B-specific) activity** XREF to EC:1.6.1.1 \n- [ ] Xrefs should be to EC:1.6.1.1 and RHEA:11692\n- [ ] Definition should be adjusted to match RHEA's. \n\nDoes that seem right ? \n\nThanks, Pascale","author_login":"pgaudet","author_association":"CONTRIBUTOR","created_at":"2024-05-02T06:20:44+08:00","repo_name":"geneontology/go-ontology","issue_id":2273941526,"issue_number":27814,"issue_url":"https://github.com/geneontology/go-ontology/issues/27814","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091868401","fragment_type":"issue_comment","sequence":3,"text":"(based on UniProt catalytic activity)\nGO:0008746 NAD(P)+ transhydrogenase activity, there are 6 experimental annotations. I reported an AmiGO bug URL Of those 6, there is a mixture of Rhea:47992, Rhea:11692, and Rhea:10824 (incorrect GO annotation?).\nGO:0003957 NAD(P)+ transhydrogenase (B-specific) activity The only annotation PntAA is actually of Rhea:47992.\n\nSince GO doesn't have EC:1.6.1.3, this issue may not be relevant. This comment \"This entry stands for enzymes whose stereo-specificity with respect to NADPH is not known\", I interpret it to mean that EC:1.6.1.3 is different from EC:1.6.1.1 rather than EC:1.6.1.1 is a subclass.","author_login":"raymond91125","author_association":"CONTRIBUTOR","created_at":"2024-05-02T22:44:35+08:00","repo_name":"geneontology/go-ontology","issue_id":2273941526,"issue_number":27814,"issue_url":"https://github.com/geneontology/go-ontology/issues/27814","linked_issue_ids":[2274404063],"is_known_query_context":false},{"document_id":"gh_comment_2095254851","fragment_type":"issue_comment","sequence":4,"text":"Hi @raymond91125 \nIs my suggestion above not working What do you propose to do? \n\nThanks, Pascale","author_login":"pgaudet","author_association":"CONTRIBUTOR","created_at":"2024-05-06T06:06:48+08:00","repo_name":"geneontology/go-ontology","issue_id":2273941526,"issue_number":27814,"issue_url":"https://github.com/geneontology/go-ontology/issues/27814","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100980495","fragment_type":"issue_comment","sequence":5,"text":"@raymond91125 \nSee @amandamackie 's input in the annotation ticket: URL \n\nGO:0003957 NAD(P)+ transhydrogenase (B-specific) activity 's definition and the parent ''proton transmembrane transporter activity'' should be removed. \n\nThanks, Pascale","author_login":"pgaudet","author_association":"CONTRIBUTOR","created_at":"2024-05-08T16:41:00+08:00","repo_name":"geneontology/go-ontology","issue_id":2273941526,"issue_number":27814,"issue_url":"https://github.com/geneontology/go-ontology/issues/27814","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2274404063","fragment_type":"issue_description","sequence":0,"text":"Annotation filter GO class (direct) not working\nTo reproduce:\n URL \nclick on GO class (direct) shows Total annotations: 103\n(89) NAD(P)+ transhydrogenase activity\n(9) NAD(P)+ transhydrogenase (AB-specific) activity\n(5) NAD(P)+ transhydrogenase (B-specific) activity\nclick on any line shows Total annotations: 0","author_login":"raymond91125","author_association":"NONE","created_at":"2024-05-02T00:48:20+08:00","repo_name":"geneontology/amigo","issue_id":2274404063,"issue_number":718,"issue_url":"https://github.com/geneontology/amigo/issues/718","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2089387099","fragment_type":"issue_comment","sequence":1,"text":"oh, interesting. This is the solr query:\n\n URL \n\nNotice that `+ ` is translated ` ` (double space). This is because the `+` is a URL encoding of a space. The solution is to use the right URL escaping when constructing the SOLR urls. We should also check other characters that typically get encoded, e.g. `:`.","author_login":"cmungall","author_association":"MEMBER","created_at":"2024-05-02T01:39:38+08:00","repo_name":"geneontology/amigo","issue_id":2274404063,"issue_number":718,"issue_url":"https://github.com/geneontology/amigo/issues/718","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113567827","fragment_type":"issue_comment","sequence":2,"text":"I talked a little with @pkalita-lbl about proximate places to look for the issue. While adding a fix (encoding/decoding), there may also be consequences in the UI filters and bookmarking, in addition to the \"main\" issue of the query to the Solr server.\n\nThere are some oddities that have slipped into the code over the years in response to years of LBL testing (e.g. URL the bug may be a consequence of that (or just a regular \"oops\" on my part). Either way, a fix should be XSS-safe.\n\nThe problem code is probably in the `bbop-manager-golr` package, at URL . A possible place to start might be URL which uses `encodeURI()`. One way to approach this would be by the tests in that package, although that may practically be a slow way forward.","author_login":"kltm","author_association":"MEMBER","created_at":"2024-05-15T22:18:27+08:00","repo_name":"geneontology/amigo","issue_id":2274404063,"issue_number":718,"issue_url":"https://github.com/geneontology/amigo/issues/718","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113572033","fragment_type":"issue_comment","sequence":3,"text":"The JS code is old, baroque, and quirky (ooo--`prototype`!). If any problems or confusions come up, it's probably faster to drag me in than directly wrestle with whatever was in my head at the time.","author_login":"kltm","author_association":"MEMBER","created_at":"2024-05-15T22:20:42+08:00","repo_name":"geneontology/amigo","issue_id":2274404063,"issue_number":718,"issue_url":"https://github.com/geneontology/amigo/issues/718","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2159454484","fragment_type":"issue_comment","sequence":4,"text":"Another good URI-encoding test case\n\n* Go to URL \n* Expand the \"GO class (direct)\" facet and click more\n* In the modal search for \"ascr\"\n* Click the \"+\" button next to \"ascr#2 binding\"","author_login":"pkalita-lbl","author_association":"CONTRIBUTOR","created_at":"2024-06-10T23:06:12+08:00","repo_name":"geneontology/amigo","issue_id":2274404063,"issue_number":718,"issue_url":"https://github.com/geneontology/amigo/issues/718","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0082","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Kubeflow User Research & Survey Strategy?","query_context":"So far, the Kubeflow community has published a yearly user survey composed of high level questions to gauge how users interact with Kubeflow, what are the most used components, what are the biggest gaps, and how Kubeflow is deployed in production. The survey provides a good snapshot of users demographics and, with the help of freeform questions, it provides a pretty detailed report of specific areas users would like to see improved.\n\nThis information has proven very useful to understand what are the most used components; missing capabilities; usability concerns; distributions adoption; etc.\n\nThere are two aspects to consider now that the community is maturing and building ever more complex capabilities:\n\n- **Interviews**: the current process still lacks a second critical phase in user research: the interview. User interviews help create a detailed picture of the user personas, understand their needs, validate the survey findings, and drill down into specific usability concerns.\n- **Component-specific research**: Working Groups need detailed feedback on existing/new components and features. A (yearly) high-level generic user survey doesn’t help working groups getting specific feedback on what they are building and what users would like to see in the future.\n\nKubeflow is a very complicated platform, the AI/ML landscape is changing rapidly. We need to adopt a product-led mindset and develop a platform strategy to holistically look at Kubeflow as whole, understand what it is and where it is going, based on consumer’s feedback and understanding. We cannot base our decisions on assumptions, we need a user research approach to validate our intuition and maximize our community effort towards building something that pays off.\n\nI don't want to start in this issue a never ending debate on how we should adopt product thinking (that discussion can happen in a separate issue) but rather have a tactical conversation on how we can improve our current user research initiatves to drive better and more informative outcomes.\n\nIn this document URL I list some bullet points on surveys and interview and make some proposal on what we can do in the next months.\n\ncc @kubeflow/wg-notebooks-leads @kubeflow/wg-manifests-leads @kubeflow/wg-training-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-automl-leads @kubeflow/release-team @jbottum @andreyvelich @johnugeorge @james-jwu @akgraner","known_context_document_ids":["gh_issue_2151486794"],"reference_answer":"Thank you for opening this, the way you've laid out the work to be done and linked other issues is quite helpful!","answer_document_id":"gh_comment_1937833683","silver_evidence_path":["gh_comment_1961701712","gh_issue_2110295525","gh_comment_1937833683"],"evidence_issue_ids":[2151486794,2110295525],"source_repo_name":"kubeflow/community","source_issue_id":2151486794,"source_issue_number":705,"source_issue_url":"https://github.com/kubeflow/community/issues/705","target_repo_name":"cncf/tag-app-delivery","target_issue_id":2110295525,"target_issue_number":546,"target_issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","reference_anchor_document_id":"gh_comment_1961701712","reference_answer_author":"joshgav","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.2143,"anchor_target_overlap":0.125,"target_answer_overlap":0.3636},"issue_created_at":"2024-02-23T17:11:01+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2151486794","fragment_type":"issue_description","sequence":0,"text":"Kubeflow User Research & Survey Strategy\nSo far, the Kubeflow community has published a yearly user survey composed of high level questions to gauge how users interact with Kubeflow, what are the most used components, what are the biggest gaps, and how Kubeflow is deployed in production. The survey provides a good snapshot of users demographics and, with the help of freeform questions, it provides a pretty detailed report of specific areas users would like to see improved.\n\nThis information has proven very useful to understand what are the most used components; missing capabilities; usability concerns; distributions adoption; etc.\n\nThere are two aspects to consider now that the community is maturing and building ever more complex capabilities:\n\n- **Interviews**: the current process still lacks a second critical phase in user research: the interview. User interviews help create a detailed picture of the user personas, understand their needs, validate the survey findings, and drill down into specific usability concerns.\n- **Component-specific research**: Working Groups need detailed feedback on existing/new components and features. A (yearly) high-level generic user survey doesn’t help working groups getting specific feedback on what they are building and what users would like to see in the future.\n\nKubeflow is a very complicated platform, the AI/ML landscape is changing rapidly. We need to adopt a product-led mindset and develop a platform strategy to holistically look at Kubeflow as whole, understand what it is and where it is going, based on consumer’s feedback and understanding. We cannot base our decisions on assumptions, we need a user research approach to validate our intuition and maximize our community effort towards building something that pays off.\n\nI don't want to start in this issue a never ending debate on how we should adopt product thinking (that discussion can happen in a separate issue) but rather have a tactical conversation on how we can improve our current user research initiatves to drive better and more informative outcomes.\n\nIn this document URL I list some bullet points on surveys and interview and make some proposal on what we can do in the next months.\n\ncc @kubeflow/wg-notebooks-leads @kubeflow/wg-manifests-leads @kubeflow/wg-training-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-automl-leads @kubeflow/release-team @jbottum @andreyvelich @johnugeorge @james-jwu @akgraner","author_login":"StefanoFioravanzo","author_association":"MEMBER","created_at":"2024-02-23T17:11:01+08:00","repo_name":"kubeflow/community","issue_id":2151486794,"issue_number":705,"issue_url":"https://github.com/kubeflow/community/issues/705","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1961701712","fragment_type":"issue_comment","sequence":1,"text":"I also opened a CNCF Service Desk ticket URL to better understand how other CNCF project are doing this. Apparently the TAG App Delivery is conducting a very interesting initiative:\n- URL \n- URL \n\nThat discussion goes way beyond the scope of this issue (purely focused on our mid-term survey+interview strategy) but is good food for thought on how to adopt a product-thinking mindset. There's a lot of material that can be helpful to us. They also also investigating tools and practices to run user interviews with a repeatable framework and in compliance to GDPR policies. So I'll definitely reach out, maybe they can help us","author_login":"StefanoFioravanzo","author_association":"MEMBER","created_at":"2024-02-23T17:15:02+08:00","repo_name":"kubeflow/community","issue_id":2151486794,"issue_number":705,"issue_url":"https://github.com/kubeflow/community/issues/705","linked_issue_ids":[2110295525],"is_known_query_context":false},{"document_id":"gh_comment_1961746855","fragment_type":"issue_comment","sequence":2,"text":"@StefanoFioravanzo thanks for kicking this off. As need steps, we might create the 1st set of survey questions completed. As we discussed, we have reused the questions from previous years, but we don't have to this year. As the same time, we need to identify users and ask if they will participate in some interviews. I think those requests need to be very defined in terms of privacy, time commitment and benefits (for the user). I would suggest defining 10 questions. Note some of those questions will be multiple choice and so we will need answers for each question. Would this be created and delivered via google forms ?","author_login":"jbottum","author_association":"CONTRIBUTOR","created_at":"2024-02-23T17:47:35+08:00","repo_name":"kubeflow/community","issue_id":2151486794,"issue_number":705,"issue_url":"https://github.com/kubeflow/community/issues/705","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1964738306","fragment_type":"issue_comment","sequence":3,"text":"Amazing, we also have to get this into the hands of internal company employees this time. E.g. DHL, some hospitals I know of and other end user companies. Just announcing it on the internet is not enough. We also have to do so in companies intranets and private channels.","author_login":"juliusvonkohout","author_association":"MEMBER","created_at":"2024-02-26T17:44:19+08:00","repo_name":"kubeflow/community","issue_id":2151486794,"issue_number":705,"issue_url":"https://github.com/kubeflow/community/issues/705","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965018933","fragment_type":"issue_comment","sequence":4,"text":"@juliusvonkohout yeah that's a whole discussion we should have - what is the \"hidden\" user base, how do we reach out, how do we keep track of gatekeepers, etc. I am sure these would provide a level of insight into real world production scenarios we, as a community, have not heard yet.","author_login":"StefanoFioravanzo","author_association":"MEMBER","created_at":"2024-02-26T19:14:10+08:00","repo_name":"kubeflow/community","issue_id":2151486794,"issue_number":705,"issue_url":"https://github.com/kubeflow/community/issues/705","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2847669362","fragment_type":"issue_comment","sequence":5,"text":"I have a long adopter list now and there is the KOC.\n/close\nPlease reopen if needed.","author_login":"juliusvonkohout","author_association":"MEMBER","created_at":"2025-05-02T16:47:50+08:00","repo_name":"kubeflow/community","issue_id":2151486794,"issue_number":705,"issue_url":"https://github.com/kubeflow/community/issues/705","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2110295525","fragment_type":"issue_description","sequence":0,"text":"Platform-as-a-Product Research\n### Motivation\n\nAs we have learned in the Platform Engineering Maturity Model seeing your developer platform as a product is a significant sign of the maturity of your platform. But how does product management actually work with a developer platform and what tools and patterns are successfully used by platform leaders and builders? \n\nWe have a lot of assumptions around those questions, but in order to deliver an helpful guide that empowers other organisations to elevate their platform maturity by using proven product management patterns and tools, we have to put in some research and prove - or disprove - our assumptions.\n\n### Work Issues\n\n// TODO: Create Issues for the following topics once addressed \n// TODO: Enrich this list with more topics we need to work on\n\n* [ ] Interview Script and Guidelines\n* [ ] Interview and Research Tools\n* [ ] Recruiting of Interviewees\n* [ ] Analyse of first set of interviews\n* [ ] Publication of first results\n\n**Hint:** Our work progress so far can be found in this research document. \n\n### Outcome\n\nAs a first goal of this research initiative we first want to learn. \nWe want to learn what tools and patterns successful platform leader and builder use to manage their platform as a product.  \nWe want to learn what potential challenges other organisations might face in their platform engineering maturity journey when productizing their platforms and how they can overcome them.  \nWe want to learn, (if and) why successful platform teams productised their platform and what opportunities lie within introducing product thinking in other organisations. \n\nAs a second goal of this research initiative we want to share what we learned:  \nThis can be in the form of another WG Platforms Whitepaper, Best Practice Guides, Blog Posts, Talks or any other contribution that might empower other organisations to follow in the footsteps of leading Platform-as-a-Product success stories.","author_login":"Rotfuks","author_association":"NONE","created_at":"2024-01-31T14:58:33+08:00","repo_name":"cncf/tag-app-delivery","issue_id":2110295525,"issue_number":546,"issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1921404265","fragment_type":"issue_comment","sequence":1,"text":"Quick one @Rotfuks, URL do you think we need both of the issues still? I guess the other is more about a whitepaper than the research, but did want to point out...","author_login":"loujaybee","author_association":"NONE","created_at":"2024-02-01T14:04:51+08:00","repo_name":"cncf/tag-app-delivery","issue_id":2110295525,"issue_number":546,"issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1921429432","fragment_type":"issue_comment","sequence":2,"text":"Hmm good point @loujaybee - that ticket still seems to be pretty valid for what we're doing there. And I even commented there, so I should know it! :laughing: \n\nThis one was the outcome of a discussion around the next steps for the initiative and how to formalise and make the work more transparent in the scope of our working group.  \nThe other ticket sure has way more text to go through - but it also with that has all the context and the action items that we're listing here. What do you think @mluskind, should we keep this \"smaller\" epic here or use the original whitepaper one?","author_login":"Rotfuks","author_association":"NONE","created_at":"2024-02-01T14:13:51+08:00","repo_name":"cncf/tag-app-delivery","issue_id":2110295525,"issue_number":546,"issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1921581495","fragment_type":"issue_comment","sequence":3,"text":"Just talked to @mluskind, yes makes sense to close this as a duplicate and put some effort in the original ticket where people might already watch for updates. Thanks for the heads up!  \nAnd sorry @abangser for closing it while you just labeled it :heart: :laughing:","author_login":"Rotfuks","author_association":"NONE","created_at":"2024-02-01T15:23:17+08:00","repo_name":"cncf/tag-app-delivery","issue_id":2110295525,"issue_number":546,"issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936214575","fragment_type":"issue_comment","sequence":4,"text":"After a short checkin with @mluskind and looking at the plan of the couple of new issues we're creating here we decided it would be a better approach to use this as a dedicated ticket for the now streamlined effort that we're aiming for in this research and close the other here linked epic with the outcome of forming the initial platform-as-a-product research group and setting the topic and scope of the research we will conduct within the scope of this epic here now. Soooo, reopening it :)","author_login":"Rotfuks","author_association":"NONE","created_at":"2024-02-09T16:20:00+08:00","repo_name":"cncf/tag-app-delivery","issue_id":2110295525,"issue_number":546,"issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937833683","fragment_type":"issue_comment","sequence":5,"text":"Thank you for opening this, the way you've laid out the work to be done and linked other issues is quite helpful!","author_login":"joshgav","author_association":"COLLABORATOR","created_at":"2024-02-11T18:37:55+08:00","repo_name":"cncf/tag-app-delivery","issue_id":2110295525,"issue_number":546,"issue_url":"https://github.com/cncf/tag-app-delivery/issues/546","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0083","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Dealing with words with multiple meanings?","query_context":"In math, a \"lattice\" can refer to (at least) two completely different concepts (think \"subgroup lattice\" versus \"$\\mathbb{Z}^n$ is a lattice in $\\mathbb{R}^n$\"). In German, these two concepts have different words (\"Verband\" and \"Gitter\").\n\nCan this be handled by your setup? How would I enter it?","known_context_document_ids":["gh_issue_1847184189"],"reference_answer":"OK, it turned out to be a lot easier than I thought to make a temporary fix: for now, there is no distinction between adjectives and nouns; e.g. the term \"diagonal matrix\" is simply its own entry, separate from \"matrix\". This should solve this problem.","answer_document_id":"gh_comment_1675482360","silver_evidence_path":["gh_comment_1675299079","gh_issue_1847166068","gh_comment_1675482360"],"evidence_issue_ids":[1847184189,1847166068],"source_repo_name":"thosgood/maths-dictionary","source_issue_id":1847184189,"source_issue_number":34,"source_issue_url":"https://github.com/thosgood/maths-dictionary/issues/34","target_repo_name":"thosgood/maths-dictionary","target_issue_id":1847166068,"target_issue_number":33,"target_issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","reference_anchor_document_id":"gh_comment_1675299079","reference_answer_author":"thosgood","reference_answer_author_association":"OWNER","quality_score":73.64,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0455,"anchor_target_overlap":0.125,"target_answer_overlap":0.0},"issue_created_at":"2023-08-11T17:26:13+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1847184189","fragment_type":"issue_description","sequence":0,"text":"Dealing with words with multiple meanings\nIn math, a \"lattice\" can refer to (at least) two completely different concepts (think \"subgroup lattice\" versus \"$\\mathbb{Z}^n$ is a lattice in $\\mathbb{R}^n$\"). In German, these two concepts have different words (\"Verband\" and \"Gitter\").\n\nCan this be handled by your setup? How would I enter it?","author_login":"fingolfin","author_association":"NONE","created_at":"2023-08-11T17:26:13+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847184189,"issue_number":34,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/34","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1675298025","fragment_type":"issue_comment","sequence":1,"text":"the way this is handled is that every concept corresponds exactly to an entry on wikidata (almost always, modulo a few edge cases, and these will eventually have wikidata tags too), so for example lattice in the former sense is Q595364 and in the latter sense it is Q1096885 — the fact that they happen to have the same translation into English is then something that the database doesn't care about :-)","author_login":"thosgood","author_association":"OWNER","created_at":"2023-08-11T19:57:04+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847184189,"issue_number":34,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675299079","fragment_type":"issue_comment","sequence":2,"text":"however, at the moment there is no entry for lattice in either sense, and there is no way for users to add entries via the submission tool, but I'm hoping to do a massive restructure of the entire project soon (see the comments that I'm just about to write on URL that will fix this","author_login":"thosgood","author_association":"OWNER","created_at":"2023-08-11T19:58:09+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847184189,"issue_number":34,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/34","linked_issue_ids":[1847166068],"is_known_query_context":false},{"document_id":"gh_issue_1847166068","fragment_type":"issue_description","sequence":0,"text":"Representing compound words\nIn German, often words are combined to form new words. As a result, the translation of \"Fourier series\" is \"Fourierreihe\" (and *not* \"Fourier Reihe\"). For \"power series\" it is \"Potenzreihe\" (and \"Potenz Reihe\" would be *really* strange to read).\n\nIs there a way to specify this yet? If not, perhaps one could be added?","author_login":"fingolfin","author_association":"NONE","created_at":"2023-08-11T17:11:42+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847166068,"issue_number":33,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675118799","fragment_type":"issue_comment","sequence":1,"text":"There are also examples where it is possible to use an \"adjective noun\" combo, but it is unusual and the compound would be preferable: e.g. \"diagonal matrix\" could be translated as \"diagonale Matrix\", but this would be odd, the usual translation is \"Diagonalmatrix\".","author_login":"fingolfin","author_association":"NONE","created_at":"2023-08-11T17:13:29+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847166068,"issue_number":33,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675138556","fragment_type":"issue_comment","sequence":2,"text":"Here's another complication: \"value\" is \"Wert\" in German. But \"absolute value\" is \"Betrag\", or sometimes \"Absolutbetrag\", but never \"absoluter Wert\" or anything else involving \"Wert\".","author_login":"fingolfin","author_association":"NONE","created_at":"2023-08-11T17:27:16+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847166068,"issue_number":33,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675300577","fragment_type":"issue_comment","sequence":3,"text":"Great questions, and first of all thank you for your interest in contributing!\n\nAs for an actual answer, it basically boils down to \"with how poorly the database is currently structured, this is impossible\" *but* I'm hoping to get do a complete restructure over the next week or so (if I find the time) which would solve this issue entirely — I'll post on this thread when that's done!","author_login":"thosgood","author_association":"OWNER","created_at":"2023-08-11T19:59:39+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847166068,"issue_number":33,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675482360","fragment_type":"issue_comment","sequence":4,"text":"OK, it turned out to be a lot easier than I thought to make a temporary fix: for now, there is no distinction between adjectives and nouns; e.g. the term \"diagonal matrix\" is simply its own entry, separate from \"matrix\". This should solve this problem.","author_login":"thosgood","author_association":"OWNER","created_at":"2023-08-11T22:43:03+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847166068,"issue_number":33,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675503286","fragment_type":"issue_comment","sequence":5,"text":"Oh, that's great!\n\nUnfortunately it also means I have to redo this PR I was preparing to add a bunch of German translation... :-(. But I'll manage, no worries ;-)","author_login":"fingolfin","author_association":"NONE","created_at":"2023-08-11T23:08:58+08:00","repo_name":"thosgood/maths-dictionary","issue_id":1847166068,"issue_number":33,"issue_url":"https://github.com/thosgood/maths-dictionary/issues/33","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0085","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"data.table spark/databases interface?","query_context":"data.table is awesome but most people don't have 100GB memory in order to handle really large data sets in memory.\n\nBig progress has been made making the Apache Spark framework available through R in the last couple of years. Two such projects are Apache's sparkr and Rstudio's sparklyr. Both of these provide a dplyr style interface to spark's data processing engine.\n\nAs a heavy data.table user it would be amazing if there were to be a data.table interface for spark. That would make it incredibly easy for data scientists to migrate their projects from the smaller CSV style data sets to the huge data sets that can be processed by spark.\n\nA classic data pipeline for me is\n1. Bring the data into R by CSV\n2. Do some pre-processing (filters, joins, aggregation, feature extraction) of the data using data.table\n3. Build a model using one of R's many machine learning packages\n\nI want to be able to migrate this to\n1. Connect to data on hadoop cluster\n2. Do some pre-processing (filters, joins, aggregation, feature extraction) of the data using data.table's spark interface\n3. Build a model using one of spark's many machine learning algorithm.","known_context_document_ids":["gh_issue_173510650"],"reference_answer":"another way to contribute, even without knowing much about how data.table works (in C or otherwise), is to look at the open issues, and try to see if you can reproduce a bug report, then add a comment on the issue that explains what you did and whether or not the issue is reproducible. (and if you can make a simpler example than what is reported, that is even better)","answer_document_id":"gh_comment_1796971673","silver_evidence_path":["gh_comment_1881670842","gh_issue_1976590125","gh_comment_1796971673"],"evidence_issue_ids":[173510650,1976590125],"source_repo_name":"Rdatatable/data.table","source_issue_id":173510650,"source_issue_number":1828,"source_issue_url":"https://github.com/Rdatatable/data.table/issues/1828","target_repo_name":"Rdatatable/data.table","target_issue_id":1976590125,"target_issue_number":5723,"target_issue_url":"https://github.com/Rdatatable/data.table/issues/5723","reference_anchor_document_id":"gh_comment_1881670842","reference_answer_author":"tdhock","reference_answer_author_association":"MEMBER","quality_score":86.57,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.6667,"target_answer_overlap":0.0714},"issue_created_at":"2016-08-26T18:08:05+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_173510650","fragment_type":"issue_description","sequence":0,"text":"data.table spark/databases interface\ndata.table is awesome but most people don't have 100GB memory in order to handle really large data sets in memory.\n\nBig progress has been made making the Apache Spark framework available through R in the last couple of years. Two such projects are Apache's sparkr and Rstudio's sparklyr. Both of these provide a dplyr style interface to spark's data processing engine.\n\nAs a heavy data.table user it would be amazing if there were to be a data.table interface for spark. That would make it incredibly easy for data scientists to migrate their projects from the smaller CSV style data sets to the huge data sets that can be processed by spark.\n\nA classic data pipeline for me is\n1. Bring the data into R by CSV\n2. Do some pre-processing (filters, joins, aggregation, feature extraction) of the data using data.table\n3. Build a model using one of R's many machine learning packages\n\nI want to be able to migrate this to\n1. Connect to data on hadoop cluster\n2. Do some pre-processing (filters, joins, aggregation, feature extraction) of the data using data.table's spark interface\n3. Build a model using one of spark's many machine learning algorithm.","author_login":"ysgit","author_association":"NONE","created_at":"2016-08-26T18:08:05+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1880022338","fragment_type":"issue_comment","sequence":1,"text":"Proposed `dplyr.table` does not need to interact with data.table at all and can be completely standalone package.\nAll it needs is to mimic data.table's API:\n\nr\nDT[subset, select, groupby]\n\nThat makes it much easier to deliver rather than trying to fit translation inside `[.data.table`.","author_login":"jangorecki","author_association":"MEMBER","created_at":"2024-01-07T10:48:32+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1880110623","fragment_type":"issue_comment","sequence":2,"text":"I might be missing something (sorry: long, old thread with several hidden replies). But since we're ultimately talking syntax masking/mimicking, wouldn't it be easier in the long-run to create something like a `database.table` package that translates the `[i, j, by]` into the appropriate backend(s)? Or, perhaps easier for conversion, going through the new `DT(i, j, by)` functional syntax that Matt introduced not so long ago.\n\nHaving a dedicated `database.table` frontend package that directly controls the syntax generics is probably more aligned with the data.table way than going through d(b)plyr in the end.\n\n(I think that this might Jan's point, so again apologies if I'm just quibbling over the name.)\n\n+1 on DuckDB fwiw.","author_login":"grantmcdermott","author_association":"CONTRIBUTOR","created_at":"2024-01-07T16:50:28+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1880117277","fragment_type":"issue_comment","sequence":3,"text":"Integration of various sources/targets is a lot of dev and maintenance, therefore doing single integration to dplyr, and via it having another backends feels like much more likely to be achieved. If we want to target only spark, or only duckdb, then I agree it's better to translate directly rather than via dplyr.\n\nAn off topic: DT() has been pulled back for the moment from exported API.","author_login":"jangorecki","author_association":"MEMBER","created_at":"2024-01-07T17:19:06+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1881670842","fragment_type":"issue_comment","sequence":4,"text":"I agree that it would be possible and preferable to implement this in a separate package, which hopefully would get the seal of approval #5723","author_login":"tdhock","author_association":"MEMBER","created_at":"2024-01-08T19:10:09+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[1976590125],"is_known_query_context":false},{"document_id":"gh_comment_1881680036","fragment_type":"issue_comment","sequence":5,"text":"also based on the new governance this is out of scope -- \"Functionality that is out of current scope...Manipulating out-of-memory data, e.g. data stored on disk or remote SQL DB, (as opposed e.g. to sqldf / dbplyr)\" and consensus seems to be that this should be implemented in another package, so I am closing this issue. (feel free to re-open if I have mis-understood)","author_login":"tdhock","author_association":"MEMBER","created_at":"2024-01-08T19:15:43+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1916430817","fragment_type":"issue_comment","sequence":6,"text":"one more advantage of the data.table syntax/API for arrow (R package)? I naively URL","author_login":"lucasmation","author_association":"NONE","created_at":"2024-01-30T09:36:12+08:00","repo_name":"Rdatatable/data.table","issue_id":173510650,"issue_number":1828,"issue_url":"https://github.com/Rdatatable/data.table/issues/1828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1976590125","fragment_type":"issue_description","sequence":0,"text":"Building a data.table community of packages with “Seal of Approval”\nWith the goal of building a community of packages that have similar philosophies and syntax that are separate from data.table (and outside of data.table scope #5722), we would like to set up a “Seal of Approval” (play on the mascots of `data.table`) process. The process for a package receiving the Seal of Approval could be: \n\n* The package developer submits a standard application, indicating that their package is on CRAN, is actively maintained, and has at least one of the features listed below.\n* A small number of volunteers from the data.table community review the application to ensure that the criteria are met.  (This includes no testing or vetting of the package functionality itself; only checking that it's an appropriate choice for the Seal.)\n* There is some variety of public community vote to approve the package. \n\nApproval will include being listed as a Seal of Approval package on the data.table repository and an SVG of the “seal” that they can include on their own repository/package logo. The initial idea would be packages that do at least one of the following:\n\n* Built on the same principles as data.table (#5693)\n* Extends the functionality of data.table to other contexts (e.g., to databases) with similar syntax\n* Uses data.table on the backend of the package\n\nPossible examples of this could include packages that have few dependencies (e.g. `tinytest`), extend functionality (e.g. `dtplyr`, `tidytable`, `tidyfast`), and packages that use data.table on the backend (e.g. `modelsummary`).\n \nThis process would hopefully help other developers feel more connected to data.table and be more likely to want to support it. Things for us to decide on are:\n\n1. Does this idea resonate with the data.table community?\n3. If so, does the list of criteria make sense for the purposes of the Seal of Approval?\n5. What else should be considered in designing the Seal of Approval?","author_login":"TysonStanley","author_association":"MEMBER","created_at":"2023-11-03T16:53:27+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793011987","fragment_type":"issue_comment","sequence":1,"text":"I believe data.table was made to play nicely with any package, by following many conventions from base R.\nMaking a \"seal approved\" may give an impression that some packages works better with data.table, while others don't work well or don't work at all with data.table...\n\nRather than having community of packages I would prefer to have all packages to be in a community.","author_login":"jangorecki","author_association":"MEMBER","created_at":"2023-11-03T19:49:59+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793103662","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your feedback on it. I agree that data.table is nicely designed to work well with all sorts of packages (and in ways that are not always obvious!). I don't think our intention would be to say there are certain packages that work best with data.table and others don't. The goal would be to help build the community around data.table. This was just one idea of how we could engage more R users and get them into the data.table repository more. We would also hope that it would spawn more ideas of how to use data.table with other packages, across more situations. The documentation (and other resources) are vast on data.table but I think there is still a lot of users that don't find it (and how to use it) early enough.\n\nDo you have other suggestions on how to make entry into data.table use and development easier?","author_login":"TysonStanley","author_association":"MEMBER","created_at":"2023-11-03T21:05:02+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793266847","fragment_type":"issue_comment","sequence":3,"text":"I have been using data.table as a user, but I know that many parts have been written in C. I have no clue where I could start to learn C to make meaningful contributions.\n\nI would like to have some guidelines for novice users who want to contribute to data.table.","author_login":"AngelFelizR","author_association":"NONE","created_at":"2023-11-04T00:28:00+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793349927","fragment_type":"issue_comment","sequence":4,"text":"Is there anything besides an approval process {data.table} maintainers would be committing to as part of this?\n\nWould the approval be granted in perpetuity / renewed regularly / granted with possible revocation under \"certain circumstances\" (which)?","author_login":"MichaelChirico","author_association":"MEMBER","created_at":"2023-11-04T05:35:53+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793361567","fragment_type":"issue_comment","sequence":5,"text":"I was on the same boat, reading code of PRs was quite useful, but what was game changer is to start coding, I started with rolling mean. Then I received great feedback in my PRs, mostly from Matt, so it was easy to pick up good practices. Often I draft naive version in R, to reflect how I will code it in C, I might even skip using functions like `sum` and code it as a for loop.","author_login":"jangorecki","author_association":"MEMBER","created_at":"2023-11-04T06:41:01+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793501000","fragment_type":"issue_comment","sequence":6,"text":"Source of the project you are going to contribute to.\nAnd which function... The one that doesn't exist yet :)","author_login":"jangorecki","author_association":"MEMBER","created_at":"2023-11-04T17:22:40+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793501862","fragment_type":"issue_comment","sequence":7,"text":"@AngelFelizR The r-contributors slack (r-contributors.slack.com) hosted a book club on learning C for R users last year:\n\n URL \n\nI believe there are videos still available; try asking in the `#book-club-modern-c` channel there. Otherwise expressing new interest is a way to get the book club running a second time (others have already inquired).","author_login":"MichaelChirico","author_association":"MEMBER","created_at":"2023-11-04T17:27:00+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793502336","fragment_type":"issue_comment","sequence":8,"text":"As for data.table's own C code, I think the most straightforward stuff would be:\n\n - cj.c\n - coalesce.c\n - fifelse.c\n - idatetime.c\n - nafill.c\n - rbindlist.c\n - transpose.c","author_login":"MichaelChirico","author_association":"MEMBER","created_at":"2023-11-04T17:29:05+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793531731","fragment_type":"issue_comment","sequence":9,"text":"@MichaelChirico, thank you for your advice. I hope to contribute C code in the long term to continue progressing this amazing project.\n\nI want to be prepared to the point where we can task moving data.table to work with data on disk.\n\nI am here because the data.table survey asked if I wanted to contribute, so I started reading the issues.","author_login":"AngelFelizR","author_association":"NONE","created_at":"2023-11-04T19:15:47+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1796971673","fragment_type":"issue_comment","sequence":10,"text":"another way to contribute, even without knowing much about how data.table works (in C or otherwise), is to look at the open issues, and try to see if you can reproduce a bug report, then add a comment on the issue that explains what you did and whether or not the issue is reproducible. (and if you can make a simpler example than what is reported, that is even better)","author_login":"tdhock","author_association":"MEMBER","created_at":"2023-11-06T22:42:16+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2026123417","fragment_type":"issue_comment","sequence":11,"text":"To make this a concrete proposal:\n1. we will add a section in README.md entitled \"Seal of Approval\" with a brief statement explaining that this is a list of packages which are built using data.table, and what functionality they provide. \n2. the approval process is the same as for anything. If you want to list your package under Seal of Approval, submit a PR that changes README.md (add your package to the list). Make sure the change has a link to your package web page, and also a brief description of how data.table is used, and what new/interesting/unique functionality your package provides.\n3. The data.table maintainers will judge submissions based on relevance -- does this package provide a new/interesting/unique functionality beyond what is provided by data.table? Also I believe Seal of Approval packages should be outside of data.table scope. A data.table maintainer will merge the PR if there is consensus, just like for any other PR.\n\nFor example I have been developing URL which provides named capture regex functionality, using and outputting data.tables, and I would like that package for inclusion under Seal of Approval. \n\nAnother example would be the mlr3 packages which are built using data.table.\n\nI see the Seal of Approval as a way of building community, by increasing awareness about how widely-used data.table is among other R packages.","author_login":"tdhock","author_association":"MEMBER","created_at":"2024-03-28T21:07:02+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2026215677","fragment_type":"issue_comment","sequence":12,"text":"I think this will ultimately be a pretty low lift while allowing more public connections to the community.","author_login":"TysonStanley","author_association":"MEMBER","created_at":"2024-03-28T22:05:53+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2027413268","fragment_type":"issue_comment","sequence":13,"text":"glad to see some positive feedback to my proposal. \nalso would be cool to have some logo with a sea lion giving a thumbs up, does anybody have graphics/art skills? @Maradestefanis ?\nMy vision is that the README.md should have a one-line mention of the package, with a link to a blog post on URL which gives further details. So that would entail a little extra work for the package author: writing that blog post. (But no extra work for data.table devs, who just review the PR with a change to README.md)","author_login":"tdhock","author_association":"MEMBER","created_at":"2024-03-29T15:53:14+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033025392","fragment_type":"issue_comment","sequence":14,"text":"Hey @tdhock I'm stepping in and I can give the logo a shot. It would be great to have it in high definition, if possible. Can you provide that? Also, is there anything else you need from me for the blog?","author_login":"MaraDestefanis","author_association":"NONE","created_at":"2024-04-02T20:22:05+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033091087","fragment_type":"issue_comment","sequence":15,"text":"Hi Mara the existing logo graphics files are in URL is that high enough definition?","author_login":"tdhock","author_association":"MEMBER","created_at":"2024-04-02T21:00:55+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2034103279","fragment_type":"issue_comment","sequence":16,"text":"Yes, awesome! I've been trying it out these days\n\nMara Destefanis\nLic. Comunicación Social. Máster Ciencia de Datos\nTel: (+598) 99041531\nLn: URL \nweb: URL \n\nEl mar, 2 abr 2024 a las 18:01, Toby Dylan Hocking ( ) escribió:","author_login":"MaraDestefanis","author_association":"NONE","created_at":"2024-04-03T09:51:18+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[1976590125],"is_known_query_context":false},{"document_id":"gh_comment_2049509429","fragment_type":"issue_comment","sequence":17,"text":"Toby, Iam working on this graphics a sea lion giving a thumbs up, for now\nit is regular and not really nice the result. I will try again and send you\nthe result in a few days.\n\nI´ll keep pushing forward\n\nMara Destefanis\nLic. Comunicación Social. Máster Ciencia de Datos\nTel: (+598) 99041531\nLn: URL \nweb: URL \n\nEl mié, 3 abr 2024 a las 6:51, Mara Destefanis ***@***.***>)\nescribió:","author_login":"MaraDestefanis","author_association":"NONE","created_at":"2024-04-11T11:40:39+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[1976590125],"is_known_query_context":false},{"document_id":"gh_comment_2099409950","fragment_type":"issue_comment","sequence":18,"text":"Hi all,\n\nI'm reaching out with a couple ideas/options for the Seal of Approval process, to see if we can find one that everyone agrees on.\n\n**On this repository:** \n\n@jangorecki expressed some concern with a list on this repository's ReadMe, because it implies some kind of closed community, instead of data.table being accessible to anyone.\n\nI propose that we simply at a `Seal-of-Approval.md` file in this repo that contains a simple list of packages that have gotten approval. Then, we can link to this md at the bottom the ReadMe, in the Community section, and reserve all additional details for blog posts on the raft instead of them clogging up this repo.\n\n**Approval process:**\n\nAt first, @TysonStanley had suggested that approval was initialized with a PR to this repo, and @MichaelChirico was wondering about the expectations from maintainers for reviewing.\n\nI want to suggest a reverse-order: \n* Folks seeking Seal of Approval would submit by PR to The Raft. \n* Here is a sample draft for what would be submitted.\n* I would act as a first screen, and then if the proposal seems reasonable, I would PR this repo with the relevant information.\n* I could also, if desired, tag reviewer(s) in my PR.\n\nThis would be kind of a mini \"journal-style\" process that would maybe take some of the burden off the maintainers.\n\n**Longevity:**\n\nMichael also asked about whether this approval is granted in perpetuity or not. I think just workload wise, we wouldn't commit to periodic re-reviews. However, if someone were to alert us to an issue with a package - say, it's no longer actively maintained - we'd take it off the list at maintainer's discretion.\n\n**Type of SoA Packages:**\n\nI've come up with four types of packages that might merit approval; in principle, a submitter would have to justify the package falling in one or more of these categories. I'd love feedback if anything seems amiss:\n\n- [ ] **An extension package:** Adds to the internal functionality of `data.table`\n\n- [ ] **An application package:** Uses `data.table` to accomplish a particular task or analysis.\n\n- [ ] **A bridge package:** Translates `data.table` syntax to different syntax or provides helper functions for transitioning between `data.table` and another object type.\n\n- [ ] **A partner package:** Not necessarily directly connected to `data.table`, but deliberately follows the core philosophies of `data.table`.\n\n---\n\nSo, tl;dr, in this proposal:\n* Someone submits info on their package to The Raft\n* I review it, then PR this repo adding the package name to a simple .md list, and supply relevant info for maintainters\n* Maintainers merge PR at their discretion\n* Package is then published as a blog post to The Raft\n\nLet me know if this sounds workable to you, or if you have other suggestions! :)","author_login":"kbodwin","author_association":"NONE","created_at":"2024-05-07T22:20:46+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2162016829","fragment_type":"issue_comment","sequence":19,"text":"Since there are no major blocking concerns with Kelly's most recent proposal, I would suggest that we go ahead with that.","author_login":"tdhock","author_association":"MEMBER","created_at":"2024-06-12T03:06:35+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2212579862","fragment_type":"issue_comment","sequence":20,"text":"Since the seal of approval is moving forward with Kelly's suggestion, should we close this now?","author_login":"TysonStanley","author_association":"MEMBER","created_at":"2024-07-07T21:18:15+08:00","repo_name":"Rdatatable/data.table","issue_id":1976590125,"issue_number":5723,"issue_url":"https://github.com/Rdatatable/data.table/issues/5723","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0086","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"OBS Studio not working?","query_context":"*(Sorry I deleted the template, but I made sure to include all the information that it asked)*\n\nObs studio doesn't propose any screen output source.\n \n\nThe reason I ask that here and not in obs-studio repository is because obs works in sway, I switched from sway to wayfire recently and this is the only inconvenience I noticed. I believe Obs uses something called pipewire in wayland environments.\n\n**versions**\nwayfire 0.7.4\nobs 29.1.1 (64bit)\n\nHere's the log when I run Obs from the command line, maybe it can help to debug:\n\ndebug: Found portal inhibitor\ndebug: Attempted path: share/obs/obs-studio/locale/en-US.ini\ndebug: Attempted path: /usr/share/obs/obs-studio/locale/en-US.ini\ndebug: Attempted path: share/obs/obs-studio/locale.ini\ndebug: Attempted path: /usr/share/obs/obs-studio/locale.ini\ndebug: Attempted path: share/obs/obs-studio/themes/Yami.qss\ndebug: Attempted path: /usr/share/obs/obs-studio/themes/Yami.qss\ninfo: Platform: Wayland\ninfo: CPU Name: AMD Ryzen 9 5900HS with Radeon Graphics\ninfo: CPU Speed: 4466.433MHz\ninfo: Physical Cores: 8, Logical Cores: 16\ninfo: Physical Memory: 15381MB Total, 2761MB Free\ninfo: Kernel Version: Linux 6.1.18-200.fc37.x86_64\ninfo: Distribution: \"Fedora Linux\" 37\ninfo: Desktop Environment: Wayfire (wayfire)\ninfo: Session Type: wayland\ninfo: Qt Version: 6.4.3 (runtime), 6.4.3 (compiled)\ninfo: Portable mode: false\ninfo: OBS 29.1.1 (linux)\ninfo: ---------------------------------\ninfo: ---------------------------------\ninfo: audio settings reset:\n samples per sec: 48000\n speakers: 2\n max buffering: 960 milliseconds\n buffering type: dynamically increasing\ninfo: ---------------------------------\ninfo: Initializing OpenGL...\ninfo: Using EGL/Wayland\ninfo: Initialized EGL 1.5\ninfo: Loading up OpenGL on adapter AMD AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.49, 6.1.18-200.fc37.x86_64)\ninfo: OpenGL loaded successfully, version 4.6 (Core Profile) Mesa 23.0.3, shading language 4.60\ninfo: ---------------------------------\ninfo: video settings reset:\n base resolution: 352x397\n output resolution: 352x396\n downscale filter: Bicubic\n fps: 60/1\n format: NV12\n YUV mode: Rec. 709/Partial\ninfo: NV12 texture support not available\ninfo: P010 texture support not available\ninfo: Audio monitoring device:\n name: Default\n id: default\ninfo: ---------------------------------\nwarning: Failed to load 'en-US' text for module: 'decklink-captions.so'\nwarning: Failed to load 'en-US' text for module: 'decklink-output-ui.so'\nlibDeckLinkAPI.so: cannot open shared object file: No such file or directory\nwarning: A DeckLink iterator could not be created. The DeckLink drivers may not be installed\nwarning: Failed to initialize module 'decklink.so'\ninfo: [pipewire] No captures available\nerror: os_dlopen(libnvidia-encode.so.1->libnvidia-encode.so.1): libnvidia-encode.so.1: cannot open shared object file: No such file or directory\n\nnvc0_screen_create:1169 - Error allocating PGRAPH context for M2MF: -110\nerror: VAAPI: Failed to initialize display in vaapi_device_h264_supported\ninfo: VAAPI: API version 1.16\ninfo: FFmpeg VAAPI H264 encoding not supported\nnvc0_screen_create:1169 - Error allocating PGRAPH context for M2MF: -16\nerror: VAAPI: Failed to initialize display in vaapi_device_hevc_supported\ninfo: FFmpeg VAAPI HEVC encoding not supported\ninfo: [obs-websocket] [obs_module_load] you can haz websockets (Version: 5.2.2 | RPC Version: 1)\ninfo: [obs-websocket] [obs_module_load] Qt version (compile-time): 6.4.3 | Qt version (run-time): 6.4.3\ninfo: [obs-websocket] [obs_module_load] Linked ASIO Version: 102600\ninfo: [obs-websocket] [obs_module_load] Module loaded.\ninfo: [vlc-video]: VLC 3.0.19 Vetinari found, VLC video source enabled\ninfo: ---------------------------------\ninfo: Loaded Modules:\ninfo: vlc-video.so\ninfo: text-freetype2.so\ninfo: rtmp-services.so\ninfo: obs-x264.so\ninfo: obs-websocket.so\ninfo: obs-vst.so\ninfo: obs-transitions.so\ninfo: obs-outputs.so\ninfo: obs-libfdk.so\ninfo: obs-filters.so\ninfo: obs-ffmpeg.so\ninfo: linux-v4l2.so\ninfo: linux-pulseaudio.so\ninfo: linux-pipewire.so\ninfo: linux-jack.so\ninfo: linux-capture.so\ninfo: linux-alsa.so\ninfo: image-source.so\ninfo: frontend-tools.so\ninfo: decklink-output-ui.so\ninfo: decklink-captions.so\ninfo: ---------------------------------\nQWidget::setTabOrder: 'first' and 'second' must be in the same window\ninfo: ==== Startup complete ===============================================\ninfo: All scene data cleared\ninfo: ------------------------------------------------\ninfo: [Python: resize-base-resolution-from-source2.py] \ninfo: [obs-scripting]: Loaded python script: resize-base-resolution-from-source2.py\ninfo: pulse-input: Server name: 'PulseAudio (on PipeWire 0.3.70) 15.0.0'\ninfo: pulse-input: Audio format: s16le, 48000 Hz, 2 channels\ninfo: pulse-input: Started recording from 'bluez_output.58_FC_C6_1C_55_4E.1.monitor' (default)\ninfo: [Loaded global audio device]: 'Desktop Audio'\ninfo: pulse-input: Server name: 'PulseAudio (on PipeWire 0.3.70) 15.0.0'\ninfo: pulse-input: Audio format: s32le, 48000 Hz, 2 channels\ninfo: pulse-input: Started recording from 'alsa_input.pci-0000_08_00.6.analog-stereo' (default)\ninfo: [Loaded global audio device]: 'Mic/Aux'\nerror: Source ID 'pipewire-desktop-capture-source' not found\nerror: Failed to create source 'Screen Capture (PipeWire) 2'!\ninfo: Switched to scene 'asdf'\ninfo: ------------------------------------------------\ninfo: Loaded scenes:\ninfo: - scene 'asdf':\ninfo: - scene 'sdf':\ninfo: - source: 'Screen Capture (PipeWire) 2' (pipewire-desktop-capture-source)\ninfo: ------------------------------------------------\ninfo: adding 21 milliseconds of audio buffering, total audio buffering is now 21 milliseconds (source: Desktop Audio)","known_context_document_ids":["gh_issue_1738346961"],"reference_answer":"The first way is the correct way. What is your wayfire.ino file? The example config contains an autostart entry for exporting the necessary environmental variables to dbus/systemd.","answer_document_id":"gh_comment_1310223700","silver_evidence_path":["gh_comment_1573946927","gh_issue_1443601643","gh_comment_1310223700"],"evidence_issue_ids":[1738346961,1443601643],"source_repo_name":"WayfireWM/wayfire","source_issue_id":1738346961,"source_issue_number":1802,"source_issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","target_repo_name":"WayfireWM/wayfire","target_issue_id":1443601643,"target_issue_number":1611,"target_issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","reference_anchor_document_id":"gh_comment_1573946927","reference_answer_author":"ammen99","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1458,"anchor_target_overlap":0.25,"target_answer_overlap":0.2353},"issue_created_at":"2023-06-02T14:52:04+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1738346961","fragment_type":"issue_description","sequence":0,"text":"OBS Studio not working\n*(Sorry I deleted the template, but I made sure to include all the information that it asked)*\n\nObs studio doesn't propose any screen output source.\n \n\nThe reason I ask that here and not in obs-studio repository is because obs works in sway, I switched from sway to wayfire recently and this is the only inconvenience I noticed. I believe Obs uses something called pipewire in wayland environments.\n\n**versions**\nwayfire 0.7.4\nobs 29.1.1 (64bit)\n\nHere's the log when I run Obs from the command line, maybe it can help to debug:\n\ndebug: Found portal inhibitor\ndebug: Attempted path: share/obs/obs-studio/locale/en-US.ini\ndebug: Attempted path: /usr/share/obs/obs-studio/locale/en-US.ini\ndebug: Attempted path: share/obs/obs-studio/locale.ini\ndebug: Attempted path: /usr/share/obs/obs-studio/locale.ini\ndebug: Attempted path: share/obs/obs-studio/themes/Yami.qss\ndebug: Attempted path: /usr/share/obs/obs-studio/themes/Yami.qss\ninfo: Platform: Wayland\ninfo: CPU Name: AMD Ryzen 9 5900HS with Radeon Graphics\ninfo: CPU Speed: 4466.433MHz\ninfo: Physical Cores: 8, Logical Cores: 16\ninfo: Physical Memory: 15381MB Total, 2761MB Free\ninfo: Kernel Version: Linux 6.1.18-200.fc37.x86_64\ninfo: Distribution: \"Fedora Linux\" 37\ninfo: Desktop Environment: Wayfire (wayfire)\ninfo: Session Type: wayland\ninfo: Qt Version: 6.4.3 (runtime), 6.4.3 (compiled)\ninfo: Portable mode: false\ninfo: OBS 29.1.1 (linux)\ninfo: ---------------------------------\ninfo: ---------------------------------\ninfo: audio settings reset:\n samples per sec: 48000\n speakers: 2\n max buffering: 960 milliseconds\n buffering type: dynamically increasing\ninfo: ---------------------------------\ninfo: Initializing OpenGL...\ninfo: Using EGL/Wayland\ninfo: Initialized EGL 1.5\ninfo: Loading up OpenGL on adapter AMD AMD Radeon Graphics (renoir, LLVM 15.0.7, DRM 3.49, 6.1.18-200.fc37.x86_64)\ninfo: OpenGL loaded successfully, version 4.6 (Core Profile) Mesa 23.0.3, shading language 4.60\ninfo: ---------------------------------\ninfo: video settings reset:\n base resolution: 352x397\n output resolution: 352x396\n downscale filter: Bicubic\n fps: 60/1\n format: NV12\n YUV mode: Rec. 709/Partial\ninfo: NV12 texture support not available\ninfo: P010 texture support not available\ninfo: Audio monitoring device:\n name: Default\n id: default\ninfo: ---------------------------------\nwarning: Failed to load 'en-US' text for module: 'decklink-captions.so'\nwarning: Failed to load 'en-US' text for module: 'decklink-output-ui.so'\nlibDeckLinkAPI.so: cannot open shared object file: No such file or directory\nwarning: A DeckLink iterator could not be created. The DeckLink drivers may not be installed\nwarning: Failed to initialize module 'decklink.so'\ninfo: [pipewire] No captures available\nerror: os_dlopen(libnvidia-encode.so.1->libnvidia-encode.so.1): libnvidia-encode.so.1: cannot open shared object file: No such file or directory\n\nnvc0_screen_create:1169 - Error allocating PGRAPH context for M2MF: -110\nerror: VAAPI: Failed to initialize display in vaapi_device_h264_supported\ninfo: VAAPI: API version 1.16\ninfo: FFmpeg VAAPI H264 encoding not supported\nnvc0_screen_create:1169 - Error allocating PGRAPH context for M2MF: -16\nerror: VAAPI: Failed to initialize display in vaapi_device_hevc_supported\ninfo: FFmpeg VAAPI HEVC encoding not supported\ninfo: [obs-websocket] [obs_module_load] you can haz websockets (Version: 5.2.2 | RPC Version: 1)\ninfo: [obs-websocket] [obs_module_load] Qt version (compile-time): 6.4.3 | Qt version (run-time): 6.4.3\ninfo: [obs-websocket] [obs_module_load] Linked ASIO Version: 102600\ninfo: [obs-websocket] [obs_module_load] Module loaded.\ninfo: [vlc-video]: VLC 3.0.19 Vetinari found, VLC video source enabled\ninfo: ---------------------------------\ninfo: Loaded Modules:\ninfo: vlc-video.so\ninfo: text-freetype2.so\ninfo: rtmp-services.so\ninfo: obs-x264.so\ninfo: obs-websocket.so\ninfo: obs-vst.so\ninfo: obs-transitions.so\ninfo: obs-outputs.so\ninfo: obs-libfdk.so\ninfo: obs-filters.so\ninfo: obs-ffmpeg.so\ninfo: linux-v4l2.so\ninfo: linux-pulseaudio.so\ninfo: linux-pipewire.so\ninfo: linux-jack.so\ninfo: linux-capture.so\ninfo: linux-alsa.so\ninfo: image-source.so\ninfo: frontend-tools.so\ninfo: decklink-output-ui.so\ninfo: decklink-captions.so\ninfo: ---------------------------------\nQWidget::setTabOrder: 'first' and 'second' must be in the same window\ninfo: ==== Startup complete ===============================================\ninfo: All scene data cleared\ninfo: ------------------------------------------------\ninfo: [Python: resize-base-resolution-from-source2.py] \ninfo: [obs-scripting]: Loaded python script: resize-base-resolution-from-source2.py\ninfo: pulse-input: Server name: 'PulseAudio (on PipeWire 0.3.70) 15.0.0'\ninfo: pulse-input: Audio format: s16le, 48000 Hz, 2 channels\ninfo: pulse-input: Started recording from 'bluez_output.58_FC_C6_1C_55_4E.1.monitor' (default)\ninfo: [Loaded global audio device]: 'Desktop Audio'\ninfo: pulse-input: Server name: 'PulseAudio (on PipeWire 0.3.70) 15.0.0'\ninfo: pulse-input: Audio format: s32le, 48000 Hz, 2 channels\ninfo: pulse-input: Started recording from 'alsa_input.pci-0000_08_00.6.analog-stereo' (default)\ninfo: [Loaded global audio device]: 'Mic/Aux'\nerror: Source ID 'pipewire-desktop-capture-source' not found\nerror: Failed to create source 'Screen Capture (PipeWire) 2'!\ninfo: Switched to scene 'asdf'\ninfo: ------------------------------------------------\ninfo: Loaded scenes:\ninfo: - scene 'asdf':\ninfo: - scene 'sdf':\ninfo: - source: 'Screen Capture (PipeWire) 2' (pipewire-desktop-capture-source)\ninfo: ------------------------------------------------\ninfo: adding 21 milliseconds of audio buffering, total audio buffering is now 21 milliseconds (source: Desktop Audio)","author_login":"vdegenne","author_association":"NONE","created_at":"2023-06-02T14:52:04+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1573946927","fragment_type":"issue_comment","sequence":1,"text":"@ammen99 I found this thread URL and decided to include \n\n[autostart]\n01_xdp=/usr/libexec/xdg-desktop-portal\n02_xdpg=/usr/libexec/xdg-desktop-portal-gtk\n03_xdpw=/usr/libexec/xdg-desktop-portal-wlr\n\nin my config file.\n\nIt seems that it works now! though I really don't know why. Does it change the way things are getting rendered on the screen in general?\n\n(If there is a section in the documentation that talks about this, could you please redirect me?)\n\nSo far wayfire is really boosting my production and I can't be thankful enough for that, if there is anyway we can make donations, please let me know.","author_login":"vdegenne","author_association":"NONE","created_at":"2023-06-02T15:43:23+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[1443601643],"is_known_query_context":false},{"document_id":"gh_comment_1574065323","fragment_type":"issue_comment","sequence":2,"text":"Glad to hear it works :)\n\nFor screen recording/sharing/etc. Wayfire and most wlroots-based compositors (Sway too) have a semi-private protocol, called wlr-screencopy. However, after we had this protocol, another way for this was standardized, which is also supported by GNOME and KDE (via xdg-desktop-portal). There is `xdg-desktop-portal-wlr` which basically translates from the wlroots' protocol to the xdp one, and OBS will not work unless this bridging component runs in the background (since OBS uses the standard xdp recording protocol).","author_login":"ammen99","author_association":"MEMBER","created_at":"2023-06-02T17:17:28+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1574300954","fragment_type":"issue_comment","sequence":3,"text":"@ammen99 Well... I think it is somehow related but do you happen to know why file picker doesn't show up? For instance when I click \"upload a file\" in browser, a window should open so I can choose a file on my local machine, but for some reason it doesn't show up.\n\nI thought autorun the portals would fix this issue but it doesn't.","author_login":"vdegenne","author_association":"NONE","created_at":"2023-06-02T20:51:48+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1574370814","fragment_type":"issue_comment","sequence":4,"text":"Do you run xdg-desktop-portal-gtk? It should be autostarted if you have the dbus/systemd env vars exported by autostart, the wiki has a section on that iirc.","author_login":"ammen99","author_association":"MEMBER","created_at":"2023-06-02T22:10:56+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575002139","fragment_type":"issue_comment","sequence":5,"text":"@ammen99 yes here's the `[autostart]` section in my config file \n\n[autostart]\nautostart_wf_shell = true\n00_dbus = dbus-launch\n01_xdp=/usr/libexec/xdg-desktop-portal\n02_xdpg=/usr/libexec/xdg-desktop-portal-gtk\n03_xdpw=/usr/libexec/xdg-desktop-portal-wlr\nportal=/usr/libexec/xdg-desktop-portal-gtk\n\nMaybe I shouldn't use all the portals at once?\n\nAlso I have the problem in chrome right now, but file chooser seems to work in Firefox. Maybe I should open a new issue for that?","author_login":"vdegenne","author_association":"NONE","created_at":"2023-06-03T14:50:43+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575003909","fragment_type":"issue_comment","sequence":6,"text":"Here's my config (no need for a new issue, this isn't a Wayfire issue anyway, it is all about the dbus stuff):\n\n[autostart]\n0_0 = systemctl --user import-environment\nportal = sleep 1 && (XDG_SESSION_TYPE=wayland XDG_CURRENT_DESKTOP=sway /usr/libexec/xdg-desktop-portal --replace & /usr/libexec/xdg-desktop-portal-wlr)\n\nYou can either set `XDG_*` before starting Wayfire, or replace the already-running portals like I do here.\n\nYou do need the systemctl command, or at least `dbus-update-activation-environment WAYLAND_DISPLAY DISPLAY XAUTHORITY` for all dbus-activated stuff to work, that includes file chooser dialogs.","author_login":"ammen99","author_association":"MEMBER","created_at":"2023-06-03T14:56:36+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869872673","fragment_type":"issue_comment","sequence":7,"text":"Having same issue, I launched `xdg-desktop-portal-wlr`, restarted `pipewire`, but I still get the `info: [pipewire] No captures available` message on `obs` launch, and there are no relevant outputs in `helvum`.","author_login":"bodqhrohro","author_association":"NONE","created_at":"2023-12-27T01:52:29+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869986071","fragment_type":"issue_comment","sequence":8,"text":"To have the output picker show up, you need to have `slurp` installed.","author_login":"kode54","author_association":"CONTRIBUTOR","created_at":"2023-12-27T06:15:50+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1870406552","fragment_type":"issue_comment","sequence":9,"text":"Really strange that it's not showing the Screen Capture (Pipewire) with the XDG Desktop Portal loaded.","author_login":"kode54","author_association":"CONTRIBUTOR","created_at":"2023-12-27T15:27:16+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2508978290","fragment_type":"issue_comment","sequence":10,"text":"Coming back to this issue, trying to find \"window capture\" (not \"screen capture\") but I can't find it, I don't know if that's a limitation of obs on wayland or another dbus issue.\nCan you guys tell me if you have it?","author_login":"vdegenne","author_association":"NONE","created_at":"2024-11-30T14:26:00+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2508984197","fragment_type":"issue_comment","sequence":11,"text":"If I understand correctly, it's a limitation of wayland. There is currently, no way to identify a window. This is likely to change in the future, with the introduction of ext-foreign-toplevel-list protocol which provides a means to identify views with a unique id. This isn't yet supported by wlroots. Once the support for this is added, then you'll be able to capture views.","author_login":"marcusbritanicus","author_association":"CONTRIBUTOR","created_at":"2024-11-30T14:47:02+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2508986104","fragment_type":"issue_comment","sequence":12,"text":"I think this might be the case of wlroots and wayfire supporting this protocol, which outlines the ability to capture single toplevels.","author_login":"soreau","author_association":"MEMBER","created_at":"2024-11-30T14:54:27+08:00","repo_name":"WayfireWM/wayfire","issue_id":1738346961,"issue_number":1802,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1802","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1443601643","fragment_type":"issue_description","sequence":0,"text":"What's the right way to start a wayland session?\nthere'are 2 ways to start a WM session for sway/wayfire/...\nno matter start the WM from tty manually, or let DM load the session for WM, or start a command by DM.\n1. run sway/wayfire directly.\n2. run sway/wayfire by dbus: `dbus-launch wayfire`\n\ni am using greetd and tui-greeter.\n## Way 1, launch WM directly\nall things works but except gvfs and fcitx5-rime. \n- gvfs fails\nthunar report the gvfs was not work currectly, and there's no vols appear in left panel of thunar.\nfor tracering the issue, all of them report an GLIB error.\nfor example , this is the report of gvfs debug , using comomand GVFS_DEBUG=1 $(find /usr/lib* -name gvfsd 2>/dev/null) --replace 2>&1 | tee gvfsd.log :\n\n(process:14320): GLib-GObject-CRITICAL **: 11:21:21.921: g_object_new_with_properties: assertion 'G_TYPE_IS_OBJECT (object_type)' failed\n\n(process:14320): GLib-GIO-CRITICAL **: 11:21:21.924: g_volume_monitor_get_mounts: assertion 'G_IS_VOLUME_MONITOR (volume_monitor)' failed\n\n(process:14320): GLib-GObject-WARNING **: 11:21:21.924: invalid (NULL) pointer instance\n\n(process:14320): GLib-GObject-CRITICAL **: 11:21:21.924: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed\n\n(process:14320): GLib-GObject-WARNING **: 11:21:21.924: invalid (NULL) pointer instance\n\n(process:14320): GLib-GObject-CRITICAL **: 11:21:21.924: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed\n\n- fcitx5-rime\nthis input method not work in chromium.\n\n- obs-studio works in this way.\n\n## Way 2, lauch WM by dbus\n\nif i use this command to let the DM start the WM\n\ncmd='tuigreet -cmd dbus-launch wayfire'\n\nor type ` dbus-launch wayfire` in tty\n\n- gvfs works.\n\n- fcitx5-rime works everywhere.\n\n- but obs-studio can't take screen record (no `capture screen source (pipewire)` appears), cant' start virtual camera.\n\nerror: Failed to inhibit: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: on path org.freedesktop.portal.Inhibit object not found“/org/freedesktop/portal/desktop”interface\n\n- some program fails, like celluloid\ncan't be started by GUI, both in thunar or wofi.\nbut can be started by terminal, with the same error reported above.\nall packages like xdg-desktop-portal , xdg-desktop-portal-wlr already installed.\n\n## additional\n\ni'm using void-linux.\ndbus-daemon was runing in all these situation.\ndbus service was enabled and elogind was launched by greetd.","author_login":"superiums","author_association":"NONE","created_at":"2022-11-10T10:03:19+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1310223700","fragment_type":"issue_comment","sequence":1,"text":"The first way is the correct way. What is your wayfire.ino file? The example config contains an autostart entry for exporting the necessary environmental variables to dbus/systemd.","author_login":"ammen99","author_association":"MEMBER","created_at":"2022-11-10T12:40:58+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311565277","fragment_type":"issue_comment","sequence":2,"text":"i let greetd to start a script called wayfire-run :\nin this script, i exported some enviroment and start wayfire:\n\nbash\n\n# cat $(which wayfire-run)\n\n#!/bin/sh\n\n# Session\nexport XDG_SESSION_TYPE=wayland\nexport XDG_SESSION_DESKTOP=Wayfire\nexport XDG_CURRENT_DESKTOP=Wayfire\n\n# Wayland stuff\nexport MOZ_ENABLE_WAYLAND=1\nexport QT_QPA_PLATFORM=wayland\nexport SDL_VIDEODRIVER=wayland\nexport _JAVA_AWT_WM_NONREPARENTING=1\n\n# exec dbus-launch --exit-with-session wayfire $@\nexec wayfire $@","author_login":"superiums","author_association":"NONE","created_at":"2022-11-11T11:15:52+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311572027","fragment_type":"issue_comment","sequence":3,"text":"dbus service was enabled, so am i still need to start a dbus-launch on start ?\n\nshell\n# ls /var/service/\nNetworkManager@ agetty-tty3@ bluetoothd@ polkitd@\nacpid@ agetty-tty4@ cupsd@ rtkit@\nagetty-tty1@ agetty-tty5@ dbus@ udevd@\nagetty-tty2@ agetty-tty6@ greetd@ uuidd@\n\ni have tried `dbus-run-session wayfire`, but it results the same situations as dbus-launch.","author_login":"superiums","author_association":"NONE","created_at":"2022-11-11T11:22:06+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311582961","fragment_type":"issue_comment","sequence":4,"text":"when runing session by `dbus-run-session`\n\n# ps -aux|grep dbus\n\nroot 1103 0.0 0.0 2352 1160 ? Ss 18:35 0:00 runsvdir -P /run/runit/runsvdir/current log: pid=1135 comm=\"NetworkManager -n\") (using servicehelper) dbus-daemon[1127]: [system] Successfully activated service 'org.freedesktop.nm_dispatcher' dbus-daemon[1127]: [system] Activating service name='fi.w1.wpa_supplicant1' requested by ':1.7' (uid=0 pid=1135 comm=\"NetworkManager -n\") (using servicehelper) dbus-daemon[1127]: [system] Successfully activated service 'fi.w1.wpa_supplicant1' ...\nroot 1113 0.0 0.0 2200 764 ? Ss 18:35 0:00 runsv dbus\ndbus 1127 0.0 0.0 3720 2900 ? S 18:35 0:00 dbus-daemon --system --nofork --nopidfile\nshvo 1397 0.0 0.0 3780 2224 ? Ss 18:35 0:00 /usr/bin/dbus-daemon --syslog --fork --print-pid 4 --print-address 8 --session\nshvo 1496 0.0 0.0 3276 2440 ? S 18:35 0:00 /usr/bin/dbus-daemon --config-file=/usr/share/defaults/at-spi2/accessibility.conf --nofork --print-address 11 --address=unix:path=/run/user/1000/at-spi/bus","author_login":"superiums","author_association":"NONE","created_at":"2022-11-11T11:32:10+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1314715473","fragment_type":"issue_comment","sequence":5,"text":"while open chromium or electron , every works , but report:\n\nno such interface : org.freedesktop.portal.FileChooser\n\nfile chooser works.","author_login":"superiums","author_association":"NONE","created_at":"2022-11-15T03:34:33+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1314729239","fragment_type":"issue_comment","sequence":6,"text":"Ensure `xdg-desktop-portal` is running. If you want to start it, add it to autostart\n\n[autostart]\n01_xdp=/usr/libexec/xdg-desktop-portal\n02_xdpg=/usr/libexec/xdg-desktop-portal-gtk\n03_xdpw=/usr/libexec/xdg-desktop-portal-wlr","author_login":"marcusbritanicus","author_association":"CONTRIBUTOR","created_at":"2022-11-15T03:48:35+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1319472164","fragment_type":"issue_comment","sequence":7,"text":"`/usr/libexec/xdg-desktop-portal` is runing by runit.\n\n02_xdpg=/usr/libexec/xdg-desktop-portal-gtk\n03_xdpw=/usr/libexec/xdg-desktop-portal-wlr\n\ni run these two manually, but nothing change.","author_login":"superiums","author_association":"NONE","created_at":"2022-11-18T02:39:55+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1331783755","fragment_type":"issue_comment","sequence":8,"text":"@superiums You are not meant to run xdg-desktop-portal-gtk manually. Can you post your full wayfire.ini file?","author_login":"ammen99","author_association":"MEMBER","created_at":"2022-11-30T08:12:39+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336222123","fragment_type":"issue_comment","sequence":9,"text":"My uwsm might be of interest\ndbus session stuff should be handled on systemd/logind side in general.","author_login":"Vladimir-csp","author_association":"NONE","created_at":"2022-12-03T19:15:04+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1337121457","fragment_type":"issue_comment","sequence":10,"text":"yeh, it's an session stuff and should be handled by logind, i've seen uwsm, \nbut void linux has no systemd, services was loaded by runit. does it work in this situation ?","author_login":"superiums","author_association":"NONE","created_at":"2022-12-05T10:46:17+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1337610125","fragment_type":"issue_comment","sequence":11,"text":"Then no, sorry. It relies on systemd unit mechanisms heavily.","author_login":"Vladimir-csp","author_association":"NONE","created_at":"2022-12-05T15:52:32+08:00","repo_name":"WayfireWM/wayfire","issue_id":1443601643,"issue_number":1611,"issue_url":"https://github.com/WayfireWM/wayfire/issues/1611","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0087","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"NavigationBar onTap ripple alignment bug?","query_context":"Hi, using Flutter 3.7 with `flex_color_scheme: ^6.1.2`.\n\nflex\n\ndart\nFlexThemeData.dark(\n scheme: FlexScheme.flutterDash,\n surfaceMode: FlexSurfaceMode.levelSurfacesLowScaffold,\n blendLevel: 15,\n subThemesData: const FlexSubThemesData(),\n keyColors: const FlexKeyColors(),\n visualDensity: FlexColorScheme.comfortablePlatformDensity,\n useMaterial3: true,\n swapLegacyOnMaterial3: true,\n)\n\nThanks for your hard work!","known_context_document_ids":["gh_issue_1561492427"],"reference_answer":"cc: @HansMuller \nNot sure why the ink ripple is shifted in M3. It might be due to the different label sizes in M2 and M3. \nI will fix this with a better a rect.","answer_document_id":"gh_comment_1360462664","silver_evidence_path":["gh_comment_1408007975","gh_issue_1505448979","gh_comment_1360462664"],"evidence_issue_ids":[1561492427,1505448979],"source_repo_name":"rydmike/flex_color_scheme","source_issue_id":1561492427,"source_issue_number":114,"source_issue_url":"https://github.com/rydmike/flex_color_scheme/issues/114","target_repo_name":"flutter/flutter","target_issue_id":1505448979,"target_issue_number":117420,"target_issue_url":"https://github.com/flutter/flutter/issues/117420","reference_anchor_document_id":"gh_comment_1408007975","reference_answer_author":"TahaTesser","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.2821,"target_answer_overlap":0.3077},"issue_created_at":"2023-01-29T22:51:17+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1561492427","fragment_type":"issue_description","sequence":0,"text":"NavigationBar onTap ripple alignment bug\nHi, using Flutter 3.7 with `flex_color_scheme: ^6.1.2`.\n\nflex\n\ndart\nFlexThemeData.dark(\n scheme: FlexScheme.flutterDash,\n surfaceMode: FlexSurfaceMode.levelSurfacesLowScaffold,\n blendLevel: 15,\n subThemesData: const FlexSubThemesData(),\n keyColors: const FlexKeyColors(),\n visualDensity: FlexColorScheme.comfortablePlatformDensity,\n useMaterial3: true,\n swapLegacyOnMaterial3: true,\n)\n\nThanks for your hard work!","author_login":"esenmx","author_association":"NONE","created_at":"2023-01-29T22:51:17+08:00","repo_name":"rydmike/flex_color_scheme","issue_id":1561492427,"issue_number":114,"issue_url":"https://github.com/rydmike/flex_color_scheme/issues/114","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1408007975","fragment_type":"issue_comment","sequence":1,"text":"Thanks @esenmx for the issue report. \n\nYes I am aware of this issue. It is a bug in Flutter 3.7, basically a regression, a bug that does not exist in Flutter 3.3 nor in Flutter master channel, since there is fix for it already in master channel.\n\nUnfortunately that fix did not make it into Flutter 3.7 stable as cherry pick for the release. It would have needed an extra cherry pick for the 3.7 stable release, since 3.7 release had already had its code freeze when the fix was made. Now we have to wait and hope a fix for this is included in the first Flutter 3.7 hotfix (3.7.1).\n\nThe ink bug is only visible if the `NavigationBar` height is different than the default M3 height of 80dp. If you make the height lower than 80dp, the ink effect moves the diff amount from 80dp below it, if you make the height higher than 80dp, the effect moves up with same amount that it is higher than 80dp. So there is some kind of offset error on the ink ripple.\n\nFlexColorScheme defaults to an opinionated design that is only 62 dp heighh in both M2 and M3. As a workaround, if you set its height to 80dp\n\ndart\n subThemesData: const FlexSubThemesData( \n navigationBarHeight: 80.0,\n ),\n\nThe issue becomes invisible.\n\nI will when I release the FCS 7.0 stable version introduce a with FCS 6.x style break, that sets the default when opting in on M3 to 80dp instead of 62dp. Which as said is the default for M3 design anyway. At least then this issue is not visible by default when opting in on M3. It will still be there when using M2 though, since I don't want to break past default for FCS when using M2. I will leave the manual workaround to set it to 80dp to be the choice of the developer when using M2. Well let's see, it depends a bit on the timeline for the fix to land.\n\nThe PR that fixes this issue can be found here:\n URL \n\nThe author of the fix @TahaTesser and @Piinks are aware that this might be a big enough issue to be included in the first hotfix to Flutter 3.7.\n\nI will keep this issue open until there is a fix for it Flutter. I will also add it to known issues in the docs.","author_login":"rydmike","author_association":"OWNER","created_at":"2023-01-30T05:10:10+08:00","repo_name":"rydmike/flex_color_scheme","issue_id":1561492427,"issue_number":114,"issue_url":"https://github.com/rydmike/flex_color_scheme/issues/114","linked_issue_ids":[1505448979],"is_known_query_context":false},{"document_id":"gh_comment_1410193161","fragment_type":"issue_comment","sequence":2,"text":"@esenmx for information the fix to this Flutter 3.7 bug has been cherry-picked here URL it will thus most likely be included in the first Flutter hotfix release 3.7.1.","author_login":"rydmike","author_association":"OWNER","created_at":"2023-01-31T11:30:09+08:00","repo_name":"rydmike/flex_color_scheme","issue_id":1561492427,"issue_number":114,"issue_url":"https://github.com/rydmike/flex_color_scheme/issues/114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413954712","fragment_type":"issue_comment","sequence":3,"text":"Sadly it did not make it to 3.7.1, maybe 3.7.2 then. Yes I know, quite disappointing, but I have no control over what lands when in the framework :smile:","author_login":"rydmike","author_association":"OWNER","created_at":"2023-02-02T15:46:46+08:00","repo_name":"rydmike/flex_color_scheme","issue_id":1561492427,"issue_number":114,"issue_url":"https://github.com/rydmike/flex_color_scheme/issues/114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1423797249","fragment_type":"issue_comment","sequence":4,"text":"@esenmx the Flutter SDK fix for this landed in Flutter hotfix 3.7.2. Closing this issue.\n URL","author_login":"rydmike","author_association":"OWNER","created_at":"2023-02-09T08:16:19+08:00","repo_name":"rydmike/flex_color_scheme","issue_id":1561492427,"issue_number":114,"issue_url":"https://github.com/rydmike/flex_color_scheme/issues/114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1505448979","fragment_type":"issue_description","sequence":0,"text":"[NavigationBar] ink ripple positioned is shifted in M3\nAt first, I thought it might be a resolution issue it looks like the ink ripple rendered at a different vertical offset in M3 for some reason.\n\n URL \n\nWhen running the example as it is without enabling M3, ink is rendered at the right location and you can't see peeking outside but when M3 is enabled, it's slightly off. \n\nScreenshot 2022-12-21 at 01 15 1\n\nScreenshot 2022-12-21 at 01 12","author_login":"TahaTesser","author_association":"MEMBER","created_at":"2022-12-20T23:24:13+08:00","repo_name":"flutter/flutter","issue_id":1505448979,"issue_number":117420,"issue_url":"https://github.com/flutter/flutter/issues/117420","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1360462664","fragment_type":"issue_comment","sequence":1,"text":"cc: @HansMuller \nNot sure why the ink ripple is shifted in M3. It might be due to the different label sizes in M2 and M3. \nI will fix this with a better a rect.","author_login":"TahaTesser","author_association":"MEMBER","created_at":"2022-12-20T23:27:44+08:00","repo_name":"flutter/flutter","issue_id":1505448979,"issue_number":117420,"issue_url":"https://github.com/flutter/flutter/issues/117420","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1408063086","fragment_type":"issue_comment","sequence":2,"text":"When you change the height from 80dp, the M3 default, the ink ripple shifts with offset amount up/down equal to height change diff and direction. It affects both M2 and M3 mode. The issue did not exist in stable 3.3 but has now regressed into stable 3.7. \n\nSee example here: URL","author_login":"rydmike","author_association":"CONTRIBUTOR","created_at":"2023-01-30T06:25:08+08:00","repo_name":"flutter/flutter","issue_id":1505448979,"issue_number":117420,"issue_url":"https://github.com/flutter/flutter/issues/117420","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413967991","fragment_type":"issue_comment","sequence":3,"text":"Sadly it did not make it into 3.7.1, nor a bunch of other important M3 fixes that exist in master, oh well, later then... 😄","author_login":"rydmike","author_association":"CONTRIBUTOR","created_at":"2023-02-02T15:55:29+08:00","repo_name":"flutter/flutter","issue_id":1505448979,"issue_number":117420,"issue_url":"https://github.com/flutter/flutter/issues/117420","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0088","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Regression in v2: parent() returns old data even after the parent was invalidated using invalidate()?","query_context":"### Describe the bug\n\nThis is hard to explain, but I'll do my best.\nImagine the following route structure:\n\nroutes/\n├─ +page.svelte\n├─ +layout.ts\n├─ [id]/\n│ ├─ +page.svelte\n│ ├─ +page.ts\n├─ add/\n│ ├─ +page.svelte\n\nThe root page shows a basket of fruits, which is loaded from an API in the root +layout.ts. It also includes a button that links to the add page.\nThe add page includes a button that adds fruit to the basket by posting to the API. After doing so, it invalidates the root +layout.ts load function and then navigates to the root page. \nThe [id] page only verifies whether a fruit with such an ID exists in the basket. It does that using the +page.ts load function, which fetches the parent using `await parent()` and then observes, whether a fruit with such an ID is in the parent data.\n\nNow, let's imagine I do this:\n- I navigate to the add page\n- I press the button to add a fruit\n- I get redirected to the root page, where the fruit is now listed.\n- I click the fruit, which redirects me to /[id] with the fruit id.\n- However, the page tells me that no such fruit exists.\n- I click back and navigate to the root page, which now does not list the fruit at all.\n- I refreshed the page, and now everything works.\n\nHere's a video where I do that:\n\n URL \n\nHowever, when I downgrade to sveltekit v1, or use `invalidateAll()` instead of `invalidate()`, everything works correctly, and the `parent()` function returns correct data. \n\n### Reproduction\n\nSvelteKit v2: URL \nThe issue here is easily reproducible as shown in the video\n\nSvelteKit v1: URL \nThe issue is not reproducible, everything works as expected. See the video:\n\n URL \n\nAnd as a bonus, SvelteKit v2 using `invalidateAll()`: URL \nThe issue is also not reproducible, everything works as expected.\n\n### Logs\n\nShell\nNot applicable\n\n### System Info\n\nShell\nSystem:\n OS: Linux 6.6 Arch Linux\n CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor\n Memory: 35.83 GB / 62.70 GB\n Container: Yes\n Shell: 3.7.0 - /usr/bin/fish\n Binaries:\n Node: 18.18.2 - /usr/bin/node\n Yarn: 1.22.21 - /usr/bin/yarn\n npm: 10.2.5 - /usr/bin/npm\n pnpm: 8.14.0 - /usr/bin/pnpm\n bun: 1.0.18 - /usr/bin/bun\n Browsers:\n Chromium: 120.0.6099.199\n npmPackages:\n @sveltejs/adapter-auto: ^3.0.0 => 3.1.1 \n @sveltejs/kit: ^2.0.0 => 2.4.1 \n @sveltejs/vite-plugin-svelte: ^3.0.0 => 3.0.1 \n svelte: ^4.2.7 => 4.2.9 \n vite: ^5.0.3 => 5.0.12\n\n### Severity\n\nblocking an upgrade\n\n### Additional Information\n\nPS: Even though using `invalidateAll` is a workaround, I've decided to use the \"blocking an upgrade\" severity as rerunning all the load functions is not acceptable.\n**I hope I explained the issue well, if you have any questions, ask me.**","known_context_document_ids":["gh_issue_2092246534"],"reference_answer":"The original issue is about `await goto(..); await invalidate(..)`, which calls `load` twice which is expected behavior: In the linked reproduction, the `goto` makes `load` rerun because of the changed search parameter and the `invalidate` afterwards makes it run again because the dependency it has declared with `depends` is invalidated.\n\nThe issue some others in this thread have about `await invalidate(..); await goto(..)` calling it twice was a bug that has been fixed by #11268","answer_document_id":"gh_comment_1952399868","silver_evidence_path":["gh_comment_1903697323","gh_issue_1796697628","gh_comment_1952399868"],"evidence_issue_ids":[2092246534,1796697628],"source_repo_name":"sveltejs/kit","source_issue_id":2092246534,"source_issue_number":11696,"source_issue_url":"https://github.com/sveltejs/kit/issues/11696","target_repo_name":"sveltejs/kit","target_issue_id":1796697628,"target_issue_number":10359,"target_issue_url":"https://github.com/sveltejs/kit/issues/10359","reference_anchor_document_id":"gh_comment_1903697323","reference_answer_author":"dummdidumm","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.2222,"target_answer_overlap":0.3226},"issue_created_at":"2024-01-20T21:29:55+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2092246534","fragment_type":"issue_description","sequence":0,"text":"Regression in v2: parent() returns old data even after the parent was invalidated using invalidate()\n### Describe the bug\n\nThis is hard to explain, but I'll do my best.\nImagine the following route structure:\n\nroutes/\n├─ +page.svelte\n├─ +layout.ts\n├─ [id]/\n│ ├─ +page.svelte\n│ ├─ +page.ts\n├─ add/\n│ ├─ +page.svelte\n\nThe root page shows a basket of fruits, which is loaded from an API in the root +layout.ts. It also includes a button that links to the add page.\nThe add page includes a button that adds fruit to the basket by posting to the API. After doing so, it invalidates the root +layout.ts load function and then navigates to the root page. \nThe [id] page only verifies whether a fruit with such an ID exists in the basket. It does that using the +page.ts load function, which fetches the parent using `await parent()` and then observes, whether a fruit with such an ID is in the parent data.\n\nNow, let's imagine I do this:\n- I navigate to the add page\n- I press the button to add a fruit\n- I get redirected to the root page, where the fruit is now listed.\n- I click the fruit, which redirects me to /[id] with the fruit id.\n- However, the page tells me that no such fruit exists.\n- I click back and navigate to the root page, which now does not list the fruit at all.\n- I refreshed the page, and now everything works.\n\nHere's a video where I do that:\n\n URL \n\nHowever, when I downgrade to sveltekit v1, or use `invalidateAll()` instead of `invalidate()`, everything works correctly, and the `parent()` function returns correct data. \n\n### Reproduction\n\nSvelteKit v2: URL \nThe issue here is easily reproducible as shown in the video\n\nSvelteKit v1: URL \nThe issue is not reproducible, everything works as expected. See the video:\n\n URL \n\nAnd as a bonus, SvelteKit v2 using `invalidateAll()`: URL \nThe issue is also not reproducible, everything works as expected.\n\n### Logs\n\nShell\nNot applicable\n\n### System Info\n\nShell\nSystem:\n OS: Linux 6.6 Arch Linux\n CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor\n Memory: 35.83 GB / 62.70 GB\n Container: Yes\n Shell: 3.7.0 - /usr/bin/fish\n Binaries:\n Node: 18.18.2 - /usr/bin/node\n Yarn: 1.22.21 - /usr/bin/yarn\n npm: 10.2.5 - /usr/bin/npm\n pnpm: 8.14.0 - /usr/bin/pnpm\n bun: 1.0.18 - /usr/bin/bun\n Browsers:\n Chromium: 120.0.6099.199\n npmPackages:\n @sveltejs/adapter-auto: ^3.0.0 => 3.1.1 \n @sveltejs/kit: ^2.0.0 => 2.4.1 \n @sveltejs/vite-plugin-svelte: ^3.0.0 => 3.0.1 \n svelte: ^4.2.7 => 4.2.9 \n vite: ^5.0.3 => 5.0.12\n\n### Severity\n\nblocking an upgrade\n\n### Additional Information\n\nPS: Even though using `invalidateAll` is a workaround, I've decided to use the \"blocking an upgrade\" severity as rerunning all the load functions is not acceptable.\n**I hope I explained the issue well, if you have any questions, ask me.**","author_login":"kyngs","author_association":"NONE","created_at":"2024-01-20T21:29:55+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1903697323","fragment_type":"issue_comment","sequence":1,"text":"This bug is very real but hasn't been acknowledged by the team yet, see URL \n\nAnd also : \n\n URL \n URL \n URL \n URL \n URL \n URL","author_login":"gterras","author_association":"NONE","created_at":"2024-01-22T10:33:19+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[1796697628],"is_known_query_context":false},{"document_id":"gh_comment_1903700324","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the information! I hope they tackle this soon as this is a very severe issue for me.","author_login":"kyngs","author_association":"NONE","created_at":"2024-01-22T10:35:06+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[1796697628],"is_known_query_context":false},{"document_id":"gh_comment_1903728094","fragment_type":"issue_comment","sequence":3,"text":"Partial invalidation has never been fully functional in SvelteKit, even pre 1.0. I suspect none of the maintainers know how to fix it.","author_login":"gterras","author_association":"NONE","created_at":"2024-01-22T10:47:24+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1903789358","fragment_type":"issue_comment","sequence":4,"text":"@Rich-Harris I'm sorry for mentioning you, as I'm sure you have a lot of work. But you're the author of the original PR which @gterras suspects to be the culprit. Unfortunately, the issues with invalidating have been here for almost half a year, and they seem to progressively get worse. Could you please take a look into this?","author_login":"kyngs","author_association":"NONE","created_at":"2024-01-22T11:17:08+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[1796697628],"is_known_query_context":false},{"document_id":"gh_comment_1906821575","fragment_type":"issue_comment","sequence":5,"text":"I can confirm that the PR is causing the issue, removing the `invalidated.length = 0;` does fix my issue, but it might cause a new one.","author_login":"kyngs","author_association":"NONE","created_at":"2024-01-23T19:55:13+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[1796697628],"is_known_query_context":false},{"document_id":"gh_comment_1906856862","fragment_type":"issue_comment","sequence":6,"text":"@stalkerg hey! Seeing that you liked the issue, do you have the same problem?","author_login":"kyngs","author_association":"NONE","created_at":"2024-01-23T20:20:47+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907351992","fragment_type":"issue_comment","sequence":7,"text":"@kyngs not yet; I did it to improve visibility. Unfortently I have no time now to go deeper and fix it. If nobody fixes it next week, I will try to help.","author_login":"stalkerg","author_association":"CONTRIBUTOR","created_at":"2024-01-24T04:19:25+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1931263261","fragment_type":"issue_comment","sequence":8,"text":"I'm experiencing the same issue. In my case, I have a page that calls `parent()` and an invalidate call in the layout that redirects to `/login` when an auth check fails. Previously that worked just fine, but now it gets stuck showing the same page, but loaded with `/login`'s page data.","author_login":"hmnd","author_association":"CONTRIBUTOR","created_at":"2024-02-07T04:31:44+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1934405330","fragment_type":"issue_comment","sequence":9,"text":"Is there any movement on this? This is a fairly serious regression, and is preventing us from moving to SK v2. \n\nI did create a simple GitHub project that demonstrates the problem, if that helps... URL","author_login":"denjpeters","author_association":"NONE","created_at":"2024-02-08T15:45:26+08:00","repo_name":"sveltejs/kit","issue_id":2092246534,"issue_number":11696,"issue_url":"https://github.com/sveltejs/kit/issues/11696","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1796697628","fragment_type":"issue_description","sequence":0,"text":"Invalidate + Goto triggers load() twice with custom identifier\n### Describe the bug\n\nHi, \n\nIt seems that using a goto() + invalidate() triggers twice an invalidate method which calls twice the load() method from +page.server. This happens only when using custom identifiers as stated by official documentation : URL \n \n\nGIVEN load() depending on (foo:bar) WHEN goto + invalidate(foo:bar) THEN load method called twice (KO)\nGIVEN load() depending on (foo-bar) WHEN goto + invalidate(foo-bar) THEN load method called once (OK)\n\nIf I just misunderstood this documentation, please let me know :)\nMaybe invalidate + goto should be used together ? But goto doesn't seem to invalidate at every searchParams change (when modyfing existing searchParam value)\nThanks for your work !\n\n### Reproduction\n\nMinimal reproduction: \n\n URL \n\n+page.js\n\n \n import { goto, invalidate } from \"$app/navigation\";\n\n /** @type {import('./$types').PageData} */ \n export let data;\n\n async function onBtnClickKO () {\n await goto(`?page=${data.page +1 ?? 0}`);\n await invalidate('search:something');\n };\n\n async function onBtnClickOK () {\n await goto(`?page=${data.page +1 ?? 0}`);\n await invalidate('search-something');\n };\n \n\n Welcome to SvelteKit \n Visit \n\n Invalidate KO \n Invalidate OK \n\n+page.server.js\n\nexport const load = async ({ url, depends }) => {\n const searchParams = new URL(url).searchParams;\n\n const page = +(searchParams.get('page') ?? 0);\n\n depends('search:something');\n depends('search-something');\n console.log('LOAD, THIS LOG SHOULD BE DISPLAYED ONLY ONCE PER REFRESH');\n\n return {\n page,\n results: [{ a: '1', b: '2' }]\n };\n};\n\n### Logs\n\n_No response_\n\n### System Info\n\nShell\n\"@sveltejs/kit\": \"1.22.1\",\n\n### Severity\n\nannoyance\n\n### Additional Information\n\n_No response_","author_login":"camboui","author_association":"NONE","created_at":"2023-07-10T12:43:12+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1858277679","fragment_type":"issue_comment","sequence":1,"text":"We just discovered the same issue in our application. Whenever we have the following code:\n\njs\nsomeAPI.updateEntity(entity)\n .then(async () => {\n await invalidate(\"app:someEntity\")\n await goto(\"/url/of/entity\")\n })\n\nwe end up with the respective load function being called twice:\n\nScreenshot 2023-12-15 at 18 43 56\n\nTo add to the fun, if we have something like this:\n\njs\nsomeAPI.updateEntity(entity)\n .then(async (res) => {\n await invalidate(\"app:someEntity\")\n await invalidate(\"app:listOfEntities\")\n await goto(\"/url/of/entity\")\n })\n\nwe end up with the load function that has `depends(\"app:someEntity\")` being triggered 3 times (the `depends(\"app:listOfEntities\"` load function is in the `+page.ts` of a parent route). \n\nWe tried that both with using URL or custom identifier, the results are the same. \n\nI'd argue that the severity is more than \"annoyance\", as this slows down the page, as we have to wait for 2 or 3 repeated GET requests to finish. Also it puts unnecessary pressure on the API server, as it has to serve a lot of pointless GET requests.","author_login":"realvasko","author_association":"NONE","created_at":"2023-12-15T17:58:27+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1888232685","fragment_type":"issue_comment","sequence":2,"text":"Indeed in our case we have frequently invalidated load functions triggering large computations and this bug causes us trouble, is it expected to be fixed at some point ?","author_login":"gterras","author_association":"NONE","created_at":"2024-01-12T01:08:37+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1901172341","fragment_type":"issue_comment","sequence":3,"text":"Great to know I am not going crazy! I was flumoxxed about this issue! #11663 \nNeeds a fix ASAP","author_login":"ShriPunta","author_association":"NONE","created_at":"2024-01-19T21:56:30+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1903384630","fragment_type":"issue_comment","sequence":4,"text":"I can also confirm that upgrading to SvelteKit v2.0 solved the problem for us.","author_login":"realvasko","author_association":"NONE","created_at":"2024-01-22T07:10:21+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1903672343","fragment_type":"issue_comment","sequence":5,"text":"Careful there are chances you went from a major annoyance bug to an app breaking bug, see URL it's not obvious to see at first.","author_login":"gterras","author_association":"NONE","created_at":"2024-01-22T10:18:48+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952399868","fragment_type":"issue_comment","sequence":6,"text":"The original issue is about `await goto(..); await invalidate(..)`, which calls `load` twice which is expected behavior: In the linked reproduction, the `goto` makes `load` rerun because of the changed search parameter and the `invalidate` afterwards makes it run again because the dependency it has declared with `depends` is invalidated.\n\nThe issue some others in this thread have about `await invalidate(..); await goto(..)` calling it twice was a bug that has been fixed by #11268","author_login":"dummdidumm","author_association":"MEMBER","created_at":"2024-02-19T12:58:13+08:00","repo_name":"sveltejs/kit","issue_id":1796697628,"issue_number":10359,"issue_url":"https://github.com/sveltejs/kit/issues/10359","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0089","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Engine: `local_ident`'s `id` type is opaque?","query_context":"The interface for `local_ident` in the engine is defined like this:\n\nocaml\n type id [@@deriving show, yojson, hash, compare, sexp, eq]\n\n val mk_id : kind -> int -> id\n\n type t = { name : string; id : id }\n [@@deriving show, yojson, hash, compare, sexp, eq]\n\nThe `id` type is opaque so backends cannot inspect the `kind` of a `local_ident`.\n\nWithout this information, certain things become impossible.","known_context_document_ids":["gh_issue_2464556642"],"reference_answer":"Yeah. I see what you mean. Indeed, we may end up with a messy and complicated API...\n\nThe implementation itself is already quite messy and complicated, actually 😅 I would like to revisit it at some point...\n\nI think we should maybe brainstorm and figure out what kind of naming transformations one could want, and then decide whether a unified API is possible. I wonder what would be the best way of doing that: maybe a GH discussion?\n\nI think a unified API & unified transformation \"engine\" would be great. Having a declarative description of what a specific backend needs in terms of naming scheme, and then invoking the name transformation mechanism seems the right think to do to me. The concrete_ident module has invariants, and it's easy to break them, so doing something uniformly would be great.","answer_document_id":"gh_comment_2396043340","silver_evidence_path":["gh_comment_2395983457","gh_issue_2417566711","gh_comment_2396043340"],"evidence_issue_ids":[2464556642,2417566711],"source_repo_name":"hacspec/hax","source_issue_id":2464556642,"source_issue_number":850,"source_issue_url":"https://github.com/hacspec/hax/issues/850","target_repo_name":"hacspec/hax","target_issue_id":2417566711,"target_issue_number":793,"target_issue_url":"https://github.com/hacspec/hax/issues/793","reference_anchor_document_id":"gh_comment_2395983457","reference_answer_author":"W95Psp","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.4167,"target_answer_overlap":0.1923},"issue_created_at":"2024-08-14T00:23:46+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2464556642","fragment_type":"issue_description","sequence":0,"text":"Engine: `local_ident`'s `id` type is opaque\nThe interface for `local_ident` in the engine is defined like this:\n\nocaml\n type id [@@deriving show, yojson, hash, compare, sexp, eq]\n\n val mk_id : kind -> int -> id\n\n type t = { name : string; id : id }\n [@@deriving show, yojson, hash, compare, sexp, eq]\n\nThe `id` type is opaque so backends cannot inspect the `kind` of a `local_ident`.\n\nWithout this information, certain things become impossible.","author_login":"paulmure","author_association":"CONTRIBUTOR","created_at":"2024-08-14T00:23:46+08:00","repo_name":"hacspec/hax","issue_id":2464556642,"issue_number":850,"issue_url":"https://github.com/hacspec/hax/issues/850","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2395983457","fragment_type":"issue_comment","sequence":1,"text":"Here I think I have the same concerns as #793: this kind of thing should be used for naming scheme only, what kind of things do you need for local idents?","author_login":"W95Psp","author_association":"COLLABORATOR","created_at":"2024-10-07T06:07:20+08:00","repo_name":"hacspec/hax","issue_id":2464556642,"issue_number":850,"issue_url":"https://github.com/hacspec/hax/issues/850","linked_issue_ids":[2417566711],"is_known_query_context":false},{"document_id":"gh_comment_2396003677","fragment_type":"issue_comment","sequence":2,"text":"It’s been a while since I looked at this. IIRC, we needed to inspect the kind to see if a local variable is a const generic (which we treat differently than other local vars).","author_login":"paulmure","author_association":"CONTRIBUTOR","created_at":"2024-10-07T06:22:13+08:00","repo_name":"hacspec/hax","issue_id":2464556642,"issue_number":850,"issue_url":"https://github.com/hacspec/hax/issues/850","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2396019108","fragment_type":"issue_comment","sequence":3,"text":"Mmh, I see, looks like a legitimate use to me, I can see phases needing such info. Let's merge that PR (finally... I'm sorry --again-- for how long that took...)","author_login":"W95Psp","author_association":"COLLABORATOR","created_at":"2024-10-07T06:33:08+08:00","repo_name":"hacspec/hax","issue_id":2464556642,"issue_number":850,"issue_url":"https://github.com/hacspec/hax/issues/850","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2417566711","fragment_type":"issue_description","sequence":0,"text":"Raw view on `concrete_ident`\nCurrently, `concrete_ident` is exported to engines as an opaque type. To get its underlying content, one would need to make a `VIEW_API` which transform the underlying path and definition into a view.\n\nWhile the `VIEW_API` can accept options such as a `NAME_POLICY`, it seems intractable to have an API that is flexible to accommodate all possible name transformation schemes. For example, there is currently no way to configure the prefix scheme built-in to the default view api.\n\nIt seems appropriate to just export the raw underlying content without any transformations, giving each engine the option to have full control over how to translate `concrete_ident`s.","author_login":"paulmure","author_association":"CONTRIBUTOR","created_at":"2024-07-18T23:34:47+08:00","repo_name":"hacspec/hax","issue_id":2417566711,"issue_number":793,"issue_url":"https://github.com/hacspec/hax/issues/793","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2368423142","fragment_type":"issue_comment","sequence":1,"text":"@W95Psp @paulmure what's the state here? It looks to me like the PR only needs a review?","author_login":"franziskuskiefer","author_association":"MEMBER","created_at":"2024-09-23T14:19:25+08:00","repo_name":"hacspec/hax","issue_id":2417566711,"issue_number":793,"issue_url":"https://github.com/hacspec/hax/issues/793","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2395981021","fragment_type":"issue_comment","sequence":2,"text":"Hi @paulmure, I've been trying to review a few times, but each time I end up wondering if that's the right thing to do.\n\nI agree with you, the view API is restrictive: it imposes a common view on naming for every backend.\nBut I suspect most of the backend will have the same needs.\nI don't want the backends to re-implement, over and over, name translation.\n\nCould you give me some examples of a custom naming scheme you would like to have, and that would be too specific to your use case to be mainlined?\nClearly, for something like prefixes, we could make it parametric (as you say)","author_login":"W95Psp","author_association":"COLLABORATOR","created_at":"2024-10-07T06:05:25+08:00","repo_name":"hacspec/hax","issue_id":2417566711,"issue_number":793,"issue_url":"https://github.com/hacspec/hax/issues/793","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2396010804","fragment_type":"issue_comment","sequence":3,"text":"Controlling the prefix is definitely a priority right now. But we think it would also be useful to control how much of the fully qualified path is used based on what’s currently imported. But this may be easily implemented by allowing the view API to export a list of path items. \n\nThe reason why I suggested exporting the entire type is because it seems like this sort of fine-grained tweaking can easily lead to a messy and unprincipled view API. But there’s definitely a lot of room for design choices and I’m not entirely certain what’s the best solution here.","author_login":"paulmure","author_association":"CONTRIBUTOR","created_at":"2024-10-07T06:27:19+08:00","repo_name":"hacspec/hax","issue_id":2417566711,"issue_number":793,"issue_url":"https://github.com/hacspec/hax/issues/793","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2396043340","fragment_type":"issue_comment","sequence":4,"text":"Yeah. I see what you mean. Indeed, we may end up with a messy and complicated API...\n\nThe implementation itself is already quite messy and complicated, actually 😅 I would like to revisit it at some point...\n\nI think we should maybe brainstorm and figure out what kind of naming transformations one could want, and then decide whether a unified API is possible. I wonder what would be the best way of doing that: maybe a GH discussion?\n\nI think a unified API & unified transformation \"engine\" would be great. Having a declarative description of what a specific backend needs in terms of naming scheme, and then invoking the name transformation mechanism seems the right think to do to me. The concrete_ident module has invariants, and it's easy to break them, so doing something uniformly would be great.","author_login":"W95Psp","author_association":"COLLABORATOR","created_at":"2024-10-07T06:48:24+08:00","repo_name":"hacspec/hax","issue_id":2417566711,"issue_number":793,"issue_url":"https://github.com/hacspec/hax/issues/793","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0090","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"RedisReceiver FeatureRequest: Cluster Info Capability?","query_context":"### Component(s)\n\nreceiver/redis\n\n### Is your feature request related to a problem? Please describe.\n\nRedis Receiver is currently only for monitoring individual redis performance. Need ability to also record the cluster info related to the individual instance\n\n### Describe the solution you'd like\n\nAdditional Optional Metrics that use the CLUSTER INFO command to return the fields returned from that command.\n\n### Describe alternatives you've considered\n\nBash Script to parse the commands manually but it would be nice to have it included in the receiver\n\n### Additional context\n\nExample Return from CLUSTER INFO command on a single node\n`cluster_state:ok\ncluster_slots_assigned:16384\ncluster_slots_ok:16384\ncluster_slots_pfail:0\ncluster_slots_fail:0\ncluster_known_nodes:152\ncluster_size:104\ncluster_current_epoch:827\ncluster_my_epoch:753\ncluster_stats_messages_ping_sent:7235\ncluster_stats_messages_pong_sent:7387\ncluster_stats_messages_fail_sent:309\ncluster_stats_messages_sent:14931\ncluster_stats_messages_ping_received:7387\ncluster_stats_messages_pong_received:7212\ncluster_stats_messages_fail_received:3\ncluster_stats_messages_received:14602\ntotal_cluster_links_buffer_limit_exceeded:0\n`","known_context_document_ids":["gh_issue_2870951792"],"reference_answer":"This is a very interesting feature, and many of the plugins in otel col contrib are currently restricted to running on a single instance.","answer_document_id":"gh_comment_2487175790","silver_evidence_path":["gh_comment_2676352775","gh_issue_2453087208","gh_comment_2487175790"],"evidence_issue_ids":[2870951792,2453087208],"source_repo_name":"open-telemetry/opentelemetry-collector-contrib","source_issue_id":2870951792,"source_issue_number":38117,"source_issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","target_repo_name":"open-telemetry/opentelemetry-collector-contrib","target_issue_id":2453087208,"target_issue_number":34460,"target_issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","reference_anchor_document_id":"gh_comment_2676352775","reference_answer_author":"JaredTan95","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1562,"anchor_target_overlap":0.3125,"target_answer_overlap":0.1538},"issue_created_at":"2025-02-22T16:16:08+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_2870951792","fragment_type":"issue_description","sequence":0,"text":"RedisReceiver FeatureRequest: Cluster Info Capability\n### Component(s)\n\nreceiver/redis\n\n### Is your feature request related to a problem? Please describe.\n\nRedis Receiver is currently only for monitoring individual redis performance. Need ability to also record the cluster info related to the individual instance\n\n### Describe the solution you'd like\n\nAdditional Optional Metrics that use the CLUSTER INFO command to return the fields returned from that command.\n\n### Describe alternatives you've considered\n\nBash Script to parse the commands manually but it would be nice to have it included in the receiver\n\n### Additional context\n\nExample Return from CLUSTER INFO command on a single node\n`cluster_state:ok\ncluster_slots_assigned:16384\ncluster_slots_ok:16384\ncluster_slots_pfail:0\ncluster_slots_fail:0\ncluster_known_nodes:152\ncluster_size:104\ncluster_current_epoch:827\ncluster_my_epoch:753\ncluster_stats_messages_ping_sent:7235\ncluster_stats_messages_pong_sent:7387\ncluster_stats_messages_fail_sent:309\ncluster_stats_messages_sent:14931\ncluster_stats_messages_ping_received:7387\ncluster_stats_messages_pong_received:7212\ncluster_stats_messages_fail_received:3\ncluster_stats_messages_received:14602\ntotal_cluster_links_buffer_limit_exceeded:0\n`","author_login":"SuprPhatAnon","author_association":"NONE","created_at":"2025-02-22T16:16:08+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2870951792,"issue_number":38117,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2676352775","fragment_type":"issue_comment","sequence":1,"text":"This can be more complicated than it seems. The receiver is intended to scrape metrics from individual instances. If we just add the cluster-related metrics, they will be published from all the scrapers as duplicated metrics. I believe, this should be controlled by leader election, which is currently in development for Kubernetes. The leader elector would ensure that the cluster-wise metrics are collected only from only collector instance. \n\ncc @rakesh-garimella for visibility","author_login":"dmitryax","author_association":"MEMBER","created_at":"2025-02-22T19:04:04+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2870951792,"issue_number":38117,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","linked_issue_ids":[2453087208],"is_known_query_context":false},{"document_id":"gh_comment_2676358155","fragment_type":"issue_comment","sequence":2,"text":"If it was cluster wide metrics I would agree with you. However this is the cluster metrics according to the local instance which is not duplicated across all nodes in the cluster as it includes metrics such as messages its recieved from other nodes and what it thinks the current epoch is.","author_login":"SuprPhatAnon","author_association":"NONE","created_at":"2025-02-22T19:17:37+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2870951792,"issue_number":38117,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2676633520","fragment_type":"issue_comment","sequence":3,"text":"@SuprPhatAnon, thanks for clarifying. That should be straightforward to add, then. Feel free to contribute if you have a chance","author_login":"dmitryax","author_association":"MEMBER","created_at":"2025-02-23T05:36:27+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2870951792,"issue_number":38117,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2688630150","fragment_type":"issue_comment","sequence":4,"text":"@akstron I was going to pick it up in a couple weeks when things got more calm but feel free to tackle it","author_login":"SuprPhatAnon","author_association":"NONE","created_at":"2025-02-27T17:26:09+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2870951792,"issue_number":38117,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3221160831","fragment_type":"issue_comment","sequence":5,"text":"Hi @dmitryax , I would like to work on this issue.\nHere's what I've understood from the issue description:\n\nCurrent behaviour - The Receiver can scrape metrics only from a single Redis node.\n\nRequired behaviour - Support has to be added for `CLUSTER INFO` command also, so that it can also collect metrics from that command.\n\nHave I understood this correctly?","author_login":"yaten2302","author_association":"CONTRIBUTOR","created_at":"2025-08-25T17:41:19+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2870951792,"issue_number":38117,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/38117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2453087208","fragment_type":"issue_description","sequence":0,"text":"Leader Election Extension\n### The purpose and use-cases of the new component\n\nThere can be a use case where one needs to run components in an HA mode. But currently running multiple instances of components like `k8sclusterreceiver` would\ncause collection of duplicate metrics. In order to be able to run such receivers in an HA mode one needs to make sure only one receiver is active. This can be achieved by utilizing the leader election mechanism provided by Kubernetes client library. \n\nThe support for extension can be implemented as an extension so that any component that wants to leverage leader election can use it easily.\n\n### Example configuration for the component\n\nyaml\nreceivers:\n k8sclusterreceiver:\n leader_elector: leader_elector\nextensions:\n leader_elector:\n auth_type: kubeConfig\n lease_name: foo\n lease_namespace: default\n\n### Telemetry data types supported\n\ntraces, metrics, and logs\n\n### Is this a vendor-specific component?\n\n- [ ] This is a vendor-specific component\n- [ ] If this is a vendor-specific component, I am a member of the OpenTelemetry organization.\n- [ ] If this is a vendor-specific component, I am proposing to contribute and support it as a representative of the vendor.\n\n### Code Owner(s)\n\n@skhalash @a-thaler @rakesh-garimella \n\n### Sponsor (optional)\n\n@dmitryax (volunteered)\n\n### Additional context\n\nI work at SAP on a project called Kyma: URL In Kyma, we recently developed such a receiver and we are already testing it out in a production setup: URL \n\nWe’ve noticed discussions in the community about introducing leader election in the k8sobjects and k8scluster receivers. That's why we believe that a generic mechanism could be quite beneficial. If there’s interest, we are ready to contribute it to the Open Telemetry project.","author_login":"skhalash","author_association":"NONE","created_at":"2024-08-07T10:02:58+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2295989901","fragment_type":"issue_comment","sequence":1,"text":"Hey @ChrsMark! Thanks for the feedback. Yes, exactly the leader is responsible for enabling a sub-receiver (such as `k8sclusterreceiver` and `k8sobjectsreceiver`) if the collector is running as a DaemonSet or a Deployment.\n\nYes, I fully agree with the concerns about resource limits/requests. However, as you said, it should be properly documented. Not sure if there is a way to workaround it.\n\nRegarding putting some extra load on the k8s API - do you mean querying/updating leases?","author_login":"skhalash","author_association":"NONE","created_at":"2024-08-19T08:34:54+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2352345051","fragment_type":"issue_comment","sequence":2,"text":"@skhalash yes, but this is something that can also be properly documented along with some perf tests results so as users be aware of any possible impact to their clusters.","author_login":"ChrsMark","author_association":"MEMBER","created_at":"2024-09-16T08:53:34+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2430553500","fragment_type":"issue_comment","sequence":3,"text":"Why does it have to be a separate receiver? I think this should be an extension providing an interface that _any_ receiver can connect to check if it's a leader (have to do the work) or not (do nothing).","author_login":"dmitryax","author_association":"MEMBER","created_at":"2024-10-23T00:24:00+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438690152","fragment_type":"issue_comment","sequence":4,"text":"Hey @dmitryax! Thanks so much for your response! We’d be happy to contribute such a component. I don’t have much experience with extensions—would this mean that every receiver needing this functionality would require code modifications? Implementing it as a delegating receiver, similar to receiver-creator, could avoid it.","author_login":"skhalash","author_association":"NONE","created_at":"2024-10-25T19:58:01+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438966151","fragment_type":"issue_comment","sequence":5,"text":"Modifying code is fine - better than having two similar receivers. It's better to write some code, but keep the user interface clean. Restricting it to receiver_creator, we won't be able to use leader election for receivers that don't work with receiver creator, for example URL or don't need to use it all, e.g. collecting data from a static endpoint. Also, future of receiver_creator is unclear. We might take a different approach to discovery and consolidate all scraping receivers in one, see URL","author_login":"dmitryax","author_association":"MEMBER","created_at":"2024-10-25T22:28:11+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2443552571","fragment_type":"issue_comment","sequence":6,"text":"Thanks for the response! We'll explore the idea of implementing leader election as an extension instead of a receiver and will get back to you.","author_login":"skhalash","author_association":"NONE","created_at":"2024-10-29T08:27:10+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2459830626","fragment_type":"issue_comment","sequence":7,"text":"Hey @dmitryax,\n\nWe're exploring a specific use case and wanted to get your thoughts. The scenario involves multiple receivers within a single running collector instance that may need to operate in singleton mode, using leader election. To support this, each receiver might need its own lease, allowing each to be managed by a different leader.\n\nWe're considering two possible approaches:\n\n1. Embedding the lease configuration directly within each interested receiver’s configuration.\n2. Creating multiple instances of a new extension, like `singleton/foo` and `singleton/bar`, each referenced by its respective receiver.\n\nThe second approach seems simpler to implement. However, from what I’ve seen, there aren’t any examples in the wild of multiple instances of extensions being registered. Do you think this approach would be feasible?","author_login":"skhalash","author_association":"NONE","created_at":"2024-11-06T13:59:45+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2487175790","fragment_type":"issue_comment","sequence":8,"text":"This is a very interesting feature, and many of the plugins in otel col contrib are currently restricted to running on a single instance.","author_login":"JaredTan95","author_association":"MEMBER","created_at":"2024-11-20T02:11:30+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2493302067","fragment_type":"issue_comment","sequence":9,"text":"We did some investigation and agree that implementing leader election as an extension is indeed a cleaner solution. We will provide a PR with the implementation soon.","author_login":"skhalash","author_association":"NONE","created_at":"2024-11-22T09:24:14+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2575061464","fragment_type":"issue_comment","sequence":10,"text":"Hi @chenlujjj I am actively working on this. I plan to create a PR with initial implementation of the extension in this week.","author_login":"rakesh-garimella","author_association":"NONE","created_at":"2025-01-07T11:33:36+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2582895475","fragment_type":"issue_comment","sequence":11,"text":"Initial Implementation for the extension has been done here. @dmitryax please have a look.","author_login":"rakesh-garimella","author_association":"NONE","created_at":"2025-01-10T14:56:06+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665694542","fragment_type":"issue_comment","sequence":12,"text":"The second PR with actual implementation is here: URL So please reopen the issue","author_login":"rakesh-garimella","author_association":"CONTRIBUTOR","created_at":"2025-02-18T13:18:22+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2453087208,"issue_number":34460,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34460","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0091","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Python][Packaging][Release] Missing pyarrow wheels for 17.0.0 release?","query_context":"### Describe the bug, including details regarding any error messages, version, and platform.\n\nFor example, release 16.1.0 has 7 Python 3.8 wheels\n\npyarrow-16.1.0-cp38-cp38-win_amd64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_28_x86_64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_28_aarch64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl\npyarrow-16.1.0-cp38-cp38-macosx_11_0_arm64.whl\npyarrow-16.1.0-cp38-cp38-macosx_10_15_x86_64.whl\n\nwhile 17.0.0 has only 2\n\npyarrow-17.0.0-cp38-cp38-macosx_11_0_arm64.whl\npyarrow-17.0.0-cp38-cp38-macosx_10_15_x86_64.whl\n\n### Component(s)\n\nPython","known_context_document_ids":["gh_issue_2411638185"],"reference_answer":"Hello @raulcd :wave:\nI've set the project limit for `pyarrow` to 40 GB on PyPI. Please be mindful of the frequency of releases at that size.\nHave a nice week! :snake:","answer_document_id":"gh_comment_2232928937","silver_evidence_path":["gh_comment_2231415167","gh_issue_2410813511","gh_comment_2232928937"],"evidence_issue_ids":[2411638185,2410813511],"source_repo_name":"apache/arrow","source_issue_id":2411638185,"source_issue_number":43289,"source_issue_url":"https://github.com/apache/arrow/issues/43289","target_repo_name":"pypi/support","target_issue_id":2410813511,"target_issue_number":4409,"target_issue_url":"https://github.com/pypi/support/issues/4409","reference_anchor_document_id":"gh_comment_2231415167","reference_answer_author":"cmaureir","reference_answer_author_association":"MEMBER","quality_score":94.96,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.087,"anchor_target_overlap":0.2174,"target_answer_overlap":0.25},"issue_created_at":"2024-07-16T16:58:55+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2411638185","fragment_type":"issue_description","sequence":0,"text":"[Python][Packaging][Release] Missing pyarrow wheels for 17.0.0 release\n### Describe the bug, including details regarding any error messages, version, and platform.\n\nFor example, release 16.1.0 has 7 Python 3.8 wheels\n\npyarrow-16.1.0-cp38-cp38-win_amd64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_28_x86_64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_28_aarch64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl\npyarrow-16.1.0-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl\npyarrow-16.1.0-cp38-cp38-macosx_11_0_arm64.whl\npyarrow-16.1.0-cp38-cp38-macosx_10_15_x86_64.whl\n\nwhile 17.0.0 has only 2\n\npyarrow-17.0.0-cp38-cp38-macosx_11_0_arm64.whl\npyarrow-17.0.0-cp38-cp38-macosx_10_15_x86_64.whl\n\n### Component(s)\n\nPython","author_login":"edgarrmondragon","author_association":"NONE","created_at":"2024-07-16T16:58:55+08:00","repo_name":"apache/arrow","issue_id":2411638185,"issue_number":43289,"issue_url":"https://github.com/apache/arrow/issues/43289","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2231415167","fragment_type":"issue_comment","sequence":1,"text":"Thanks for reporting this. I shared the issue on the mailing list: URL \n\nWe reached the quota limit on PyPI and I am waiting for the quota to be increased in order to upload the missing wheels for 3.8, 3.9 and source distribution. The issue on PyPI to track the quota increase is this one: URL","author_login":"raulcd","author_association":"MEMBER","created_at":"2024-07-16T17:05:26+08:00","repo_name":"apache/arrow","issue_id":2411638185,"issue_number":43289,"issue_url":"https://github.com/apache/arrow/issues/43289","linked_issue_ids":[2410813511],"is_known_query_context":false},{"document_id":"gh_comment_2232996754","fragment_type":"issue_comment","sequence":2,"text":"The missing wheels and source distribution have been uploaded to PyPI.","author_login":"raulcd","author_association":"MEMBER","created_at":"2024-07-17T10:41:31+08:00","repo_name":"apache/arrow","issue_id":2411638185,"issue_number":43289,"issue_url":"https://github.com/apache/arrow/issues/43289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2410813511","fragment_type":"issue_description","sequence":0,"text":"Project Limit Request: pyarrow - 40 GiB\n### Project URL\n\n URL \n\n### Does this project already exist?\n\n- [X] Yes\n\n### New limit\n\n40 GiB\n\n### Update issue title\n\n- [X] I have updated the title.\n\n### Which indexes\n\nPyPI\n\n### About the project\n\nApache Arrow bindings for Python. Active since 2017.\n\n### How large is each release?\n\nSource: ~1 MiB\nBinaries: ~1200 MiB (Windows, macOS, Linux, CPython 3.{8,9,10,11 12})\n\n### How frequently do you make a release?\n\nWe do major releases every 3 months and eventually some patch releases.\n\n### Code of Conduct\n\n- [X] I agree to follow the PSF Code of Conduct","author_login":"raulcd","author_association":"NONE","created_at":"2024-07-16T10:38:47+08:00","repo_name":"pypi/support","issue_id":2410813511,"issue_number":4409,"issue_url":"https://github.com/pypi/support/issues/4409","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2232928937","fragment_type":"issue_comment","sequence":1,"text":"Hello @raulcd :wave:\nI've set the project limit for `pyarrow` to 40 GB on PyPI. Please be mindful of the frequency of releases at that size.\nHave a nice week! :snake:","author_login":"cmaureir","author_association":"MEMBER","created_at":"2024-07-17T10:04:38+08:00","repo_name":"pypi/support","issue_id":2410813511,"issue_number":4409,"issue_url":"https://github.com/pypi/support/issues/4409","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0092","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Displayed articles are not sorted by date?","query_context":"# IMPORTANT\n* [x] I have read the CONTRIBUTING.md and followed the provided tips\n* [x] I accept that the issue will be closed without comment if I do not check here\n* [x] I accept that the issue will be closed without comment if I do not fill out all items in the issue template.\n\n## Explain the Problem\nArticles shown in the frontend are not sorted by it's date, but instead of some import date / import ID and grouping.\n\nPlease see the video below, you can clearly see that there are articles once \"x hours ago\", then \"days ago\", then \"hours ago\" again, then somewhen \"weeks ago\"...\nI do expect that WHATEVER the source of the news article is, is on top if it was published the most recently. \n\n URL \n\nThis issue seems similar but was closed and stayed closed: < URL \n\nWhat I quickly tried is changing the `OrderBy` at `nextcloud/apps/news/lib/Db/ItemMapperV2.php` to `pub_date`, then the situation minimally improved, but guess thats the point where changes are needed.\n\nJust for reference, this is how TT-RSS orders newest:\n\ngrafik\n\n## Steps to Reproduce\nExplain what you did to encounter the issue\n1. Open news\n2. see the list is not ordered by date and I have to read OLD news first, before seeing other NEW news. Inverse - have to read NEW news, before seeing other OLD news of it!\n\n## System Information\n* News app version: 17.0.0\n* Nextcloud version: 22.2.3\n* Cron type: crontab\n* PHP version: 7.4\n* Database and version: mariadb 10\n* Browser and version: Any browser\n* OS and version: Any OS with a browser\n\n----\n\nWould be really cool if you can sort the news by date, instead of some ID made up on your own at database. It would be very fine if the user needs to check \"sort by date\" / toggle between ID and date, whatever is easiest and works \nThanks!","known_context_document_ids":["gh_issue_1074839548"],"reference_answer":"@CarlSchwan migrated the admin settings to Vue js already that part is done.\nHe also took the existing work and cleaned the code a bit, but didn't continue after that probably due to time constraints. You can find a PR with the changes.\n\n@devlinjunker continued the work on the vue-rewrite branch, there are already some commits on that branch, you can find pull requests in his forked repository that are in progress.\n\nThat is the latest status.","answer_document_id":"gh_comment_1287429057","silver_evidence_path":["gh_comment_1487776042","gh_issue_236198045","gh_comment_1287429057"],"evidence_issue_ids":[1074839548,236198045],"source_repo_name":"nextcloud/news","source_issue_id":1074839548,"source_issue_number":1608,"source_issue_url":"https://github.com/nextcloud/news/issues/1608","target_repo_name":"nextcloud/news","target_issue_id":236198045,"target_issue_number":195,"target_issue_url":"https://github.com/nextcloud/news/issues/195","reference_anchor_document_id":"gh_comment_1487776042","reference_answer_author":"Grotax","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.125,"target_answer_overlap":0.1351},"issue_created_at":"2021-12-08T21:20:19+08:00","valid_comment_count":24,"fragments":[{"document_id":"gh_issue_1074839548","fragment_type":"issue_description","sequence":0,"text":"Displayed articles are not sorted by date\n# IMPORTANT\n* [x] I have read the CONTRIBUTING.md and followed the provided tips\n* [x] I accept that the issue will be closed without comment if I do not check here\n* [x] I accept that the issue will be closed without comment if I do not fill out all items in the issue template.\n\n## Explain the Problem\nArticles shown in the frontend are not sorted by it's date, but instead of some import date / import ID and grouping.\n\nPlease see the video below, you can clearly see that there are articles once \"x hours ago\", then \"days ago\", then \"hours ago\" again, then somewhen \"weeks ago\"...\nI do expect that WHATEVER the source of the news article is, is on top if it was published the most recently. \n\n URL \n\nThis issue seems similar but was closed and stayed closed: < URL \n\nWhat I quickly tried is changing the `OrderBy` at `nextcloud/apps/news/lib/Db/ItemMapperV2.php` to `pub_date`, then the situation minimally improved, but guess thats the point where changes are needed.\n\nJust for reference, this is how TT-RSS orders newest:\n\ngrafik\n\n## Steps to Reproduce\nExplain what you did to encounter the issue\n1. Open news\n2. see the list is not ordered by date and I have to read OLD news first, before seeing other NEW news. Inverse - have to read NEW news, before seeing other OLD news of it!\n\n## System Information\n* News app version: 17.0.0\n* Nextcloud version: 22.2.3\n* Cron type: crontab\n* PHP version: 7.4\n* Database and version: mariadb 10\n* Browser and version: Any browser\n* OS and version: Any OS with a browser\n\n----\n\nWould be really cool if you can sort the news by date, instead of some ID made up on your own at database. It would be very fine if the user needs to check \"sort by date\" / toggle between ID and date, whatever is easiest and works \nThanks!","author_login":"gsantner","author_association":"NONE","created_at":"2021-12-08T21:20:19+08:00","repo_name":"nextcloud/news","issue_id":1074839548,"issue_number":1608,"issue_url":"https://github.com/nextcloud/news/issues/1608","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1020040318","fragment_type":"issue_comment","sequence":1,"text":"Seems editing `nextcloud/custom_apps/news/lib/Db/ItemMapperV2.php` does not work anymore, still getting wrong order when viewing a folder:\n\nobrazek","author_login":"chylex","author_association":"NONE","created_at":"2022-01-24T12:19:17+08:00","repo_name":"nextcloud/news","issue_id":1074839548,"issue_number":1608,"issue_url":"https://github.com/nextcloud/news/issues/1608","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100696867","fragment_type":"issue_comment","sequence":2,"text":"Yea but I think it can be closed, the frontend urgently needs a complete rewrite as the technology it uses is no longer supported and bugs/security issues will stay open. If that is not done the problem will keep existing for forever.\nIf the frontend gets rebuild this issue will not be relevant anymore.","author_login":"Grotax","author_association":"MEMBER","created_at":"2022-04-16T15:58:54+08:00","repo_name":"nextcloud/news","issue_id":1074839548,"issue_number":1608,"issue_url":"https://github.com/nextcloud/news/issues/1608","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487776042","fragment_type":"issue_comment","sequence":3,"text":"@Grotax maybe we can add this as todo/sub task for #195? This way it's not 'out of sight'.","author_login":"fazlerabbi37","author_association":"NONE","created_at":"2023-03-29T00:25:10+08:00","repo_name":"nextcloud/news","issue_id":1074839548,"issue_number":1608,"issue_url":"https://github.com/nextcloud/news/issues/1608","linked_issue_ids":[236198045],"is_known_query_context":false},{"document_id":"gh_issue_236198045","fragment_type":"issue_description","sequence":0,"text":"Frontend is outdated\nThe frontend is outdated in various ways and is therefore way harder to maintain then needed:\n\n* Building the js bundle should be done with a few lines of webpack \n* After webpack is set up we can move to modularizing the code and use es6 module loading\n* Minification should be done with babili since uglifyjs doesnt work with anything remotely ES6 nor newer\n* Thirdparty libs should be pulled in entire from npm\n* Frontend should probably be migrated to a newer Angular or different technology\n\nFor an example webpack file with typescript see URL and URL for integration with karma\n\n \n\n---\nWant to back this issue? **Post a bounty on it!** We accept bounties via Bountysource.","author_login":"BernhardPosselt","author_association":"MEMBER","created_at":"2017-06-15T13:48:11+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_409475188","fragment_type":"issue_comment","sequence":1,"text":"Some apps are already migrated to Vue. On my personal todo list I have a task trying to rewrite the frontend with Vue.js, but don't know when I'm able to start.\nIn general I would like to see a new maintainable frontend. :grinning:","author_login":"danopz","author_association":"CONTRIBUTOR","created_at":"2018-08-01T07:18:06+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_409479332","fragment_type":"issue_comment","sequence":2,"text":"@danopz We already have a lot of components ready-to-use for vue. If you want to upgrade the news app, we'll help you with a great joy ;)","author_login":"skjnldsv","author_association":"MEMBER","created_at":"2018-08-01T07:34:11+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_641320289","fragment_type":"issue_comment","sequence":3,"text":"I would be glad to help migrating this app to vue.js.\n\n_I migrated the flowupload app to vue (from angular) a month ago (the frontend of this app is obviously more complicated)_","author_login":"TessyPowder","author_association":"NONE","created_at":"2020-06-09T14:05:41+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_667117702","fragment_type":"issue_comment","sequence":4,"text":"@Grotax @TessyPowder @schaal @SMillerDev @danopz @BernhardPosselt we have a Nextcloud Talk instance also with e.g. a channel for Vue discussions, as well as a \"News team\" channel – it’s not very active yet but we do have @David-Development @stefan-niedermann and @phedlund already in! :)","author_login":"jancborchardt","author_association":"MEMBER","created_at":"2020-07-31T13:24:05+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_667118632","fragment_type":"issue_comment","sequence":5,"text":"And another thing: We are working on a new \"Dashboard\" at the moment and it would be quite cool if there would be a News app widget for it? :slightly_smiling_face: – see details at URL","author_login":"jancborchardt","author_association":"MEMBER","created_at":"2020-07-31T13:26:07+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_668421902","fragment_type":"issue_comment","sequence":6,"text":"I'm not really gonna spend any time on the vue migration, but if you want you can invite me with ` @me.com`","author_login":"SMillerDev","author_association":"CONTRIBUTOR","created_at":"2020-08-04T07:09:06+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_668422887","fragment_type":"issue_comment","sequence":7,"text":"Yea sure but I'm not very active at the moment `info@b-brahmer.de`","author_login":"Grotax","author_association":"MEMBER","created_at":"2020-08-04T07:11:19+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_670216577","fragment_type":"issue_comment","sequence":8,"text":"How can we get access ? Is it the instance at cloud.nextcloud.com ?","author_login":"TessyPowder","author_association":"NONE","created_at":"2020-08-06T22:10:46+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_670221549","fragment_type":"issue_comment","sequence":9,"text":"Just invited the 3 of you, you should get an invitation mail. :) Yes it is the instance at cloud.nextcloud.com – and you will also be able to e.g. use the mobile apps for convenience. (You can change your names and also set avatars, but file upload is restricted for guest users.)","author_login":"jancborchardt","author_association":"MEMBER","created_at":"2020-08-06T22:25:50+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_670383389","fragment_type":"issue_comment","sequence":10,"text":"_(i changed my username to JonathanTreffler and updated comments mentioning my old username. I wanted to change it for a while and the number of mentions i then need to update only increases)_","author_login":"JonathanTreffler","author_association":"NONE","created_at":"2020-08-07T07:51:54+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_923908696","fragment_type":"issue_comment","sequence":11,"text":"The Angular version of news will only be supported until end of 2021.","author_login":"Grotax","author_association":"MEMBER","created_at":"2021-09-21T11:54:22+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1226520541","fragment_type":"issue_comment","sequence":12,"text":"I updated the admin page to vue here URL , would be great if someone could give it a review","author_login":"CarlSchwan","author_association":"MEMBER","created_at":"2022-08-24T22:30:04+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1261114232","fragment_type":"issue_comment","sequence":13,"text":"It looks like the frontend is updated to vue as well in v18.2.0","author_login":"meichthys","author_association":"NONE","created_at":"2022-09-28T15:52:39+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287288205","fragment_type":"issue_comment","sequence":14,"text":"Sorry if I post this here on the wrong place but I was thinking about contributing to the vue rewrite but it's getting a bit messy here with all the branches and PRs. Which one is the most promising/recent one? And can we coordinate work on that?","author_login":"powerpaul17","author_association":"CONTRIBUTOR","created_at":"2022-10-21T18:12:28+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287429057","fragment_type":"issue_comment","sequence":15,"text":"@CarlSchwan migrated the admin settings to Vue js already that part is done.\nHe also took the existing work and cleaned the code a bit, but didn't continue after that probably due to time constraints. You can find a PR with the changes.\n\n@devlinjunker continued the work on the vue-rewrite branch, there are already some commits on that branch, you can find pull requests in his forked repository that are in progress.\n\nThat is the latest status.","author_login":"Grotax","author_association":"MEMBER","created_at":"2022-10-21T20:56:36+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1288803278","fragment_type":"issue_comment","sequence":16,"text":"Are the forks by @CarlSchwan and @devlinjunker different? Is it clear at the moment which to contribute to?","author_login":"rhyst","author_association":"CONTRIBUTOR","created_at":"2022-10-24T10:29:08+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1290527940","fragment_type":"issue_comment","sequence":17,"text":"I can't really say. Both are quite in the beginning.\n\nProbably best of you take a look at both and decide for yourself which is the better base to contribute to.","author_login":"Grotax","author_association":"MEMBER","created_at":"2022-10-25T13:10:07+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1404225066","fragment_type":"issue_comment","sequence":18,"text":"Good evening 👋🏼 \n\nI see this has been ongoing for some time, I also see that some of the issues affected by this are still ongoing.\n\nIs there any update on when a rewrite of the frontend will complete?\nAn issue that was opened about date order was closed as the fix is a rewrite, but thats still in progress.","author_login":"mhzawadi","author_association":"NONE","created_at":"2023-01-25T21:07:51+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1404634672","fragment_type":"issue_comment","sequence":19,"text":"It'll be done when it is done. You can't plan volunteer time and motivation.","author_login":"SMillerDev","author_association":"CONTRIBUTOR","created_at":"2023-01-26T07:19:25+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1742868542","fragment_type":"issue_comment","sequence":20,"text":"@scottdotau there is URL that has regular contributions. Those contributions have a TODO, so you could pick something up from that.","author_login":"SMillerDev","author_association":"CONTRIBUTOR","created_at":"2023-10-02T11:46:39+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1742871044","fragment_type":"issue_comment","sequence":21,"text":"@SMillerDev appreciate it, obviously didn't read all the replies 🙃.","author_login":"scottdotau","author_association":"NONE","created_at":"2023-10-02T11:48:29+08:00","repo_name":"nextcloud/news","issue_id":236198045,"issue_number":195,"issue_url":"https://github.com/nextcloud/news/issues/195","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0093","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"How to correctly taint \"%this\"?","query_context":"### Overall Description\n\nHi, I want to write a plugin that can taint any class when any field of the class is tainted (e.g, when a tainted variable is passed to `obj.setName(String)`, I want the `obj` is tainted as well after that). However, the caller variable is not affected even through the \"%this\" variable in the callee function is tainted. So how to correctly handle this?\n\nYou can refer to the minimum reproduce code below that the \"%this\" in callee function is tainted\n \n\nHowever the caller \"%this\" is untouched\n \n\nI may misunderstand some parts of the pta analysis, do I need to manually propagate this (why not be handled automatically)?\n\n### Expected Behavior\n\nThe caller object is also tainted.\n\n### Current Behavior\n\nThe caller object is not tainted.\n\n### Tai-e Arguments\n\n \n Click here to see Tai-e Options \n \n\n \nyaml\noptionsFile: null\nprintHelp: false\nclassPath: []\nappClassPath:\n - tester-1.0-SNAPSHOT.jar\nmainClass: org.example.Main\ninputClasses: []\njavaVersion: 8\nprependJVM: false\nallowPhantom: true\nworldBuilderClass: pascal.taie.frontend.soot.SootWorldBuilder\noutputDir: output\npreBuildIR: false\nworldCacheMode: false\nscope: ALL\nnativeModel: true\nplanFile: null\nanalyses:\n ir-dumper: ;\n pta: \"taint-config:config.yml;plugins:[pascal.taie.analysis.pta.plugin.taint.SuperTaintHandler];dump:true\"\nonlyGenPlan: false\nkeepResult:\n - $KEEP-ALL\n\n \n\n \n\n### Tai-e Log\n\n \n Click here to see IR log \n \n\n \n\n static void process(java.lang.String r1) {\n org.example.User $r0;\n [0@L8] $r0 = new org.example.User;\n [1@L8] invokespecial $r0. ()>();\n [2@L9] invokevirtual $r0. (r1);\n [3@L10] invokestatic ($r0);\n [4@L11] return;\n }\n\n public void setName(java.lang.String name) {\n [0@L9] %this. = name;\n [1@L10] return;\n }\n \n\n \n\n \n Click here to see points-to results \n \n\n \n\n[]: /%stringconst0 -> [[]:MergedObj{ }]\n[]: /r0 -> [[]:EntryPointObj{alloc=MethodParam{ /0},type=java.lang.String[] in }]\n[]: /$r0 -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: /r1 -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /$r1 -> [[]:NewObj{ [1@L1147] new java.io.PrintStream}, []:NewObj{ [9@L1150] new java.io.PrintStream}]\n[]: /$r2 -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /r0 -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: /$r1 -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /%this -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: ()>/%this -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: /%this -> [[]:MergedObj{ }, []:NewObj{ [0@L8] new org.example.User}, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /name -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n \n\n \n\n### Additional Information\n\n \n Click here to see key code of my plugin \n \n\n \n\n// It may not be efficient, any suggestions to improve? \n@Override\n public void onNewCSMethod(CSMethod csMethod) {\n JMethod method = csMethod.getMethod();\n Context context = csMethod.getContext();\n IR ir = method.getIR();\n for (Stmt i : ir.getStmts()) {\n if (i instanceof StoreField) {\n StoreField st = (StoreField) i;\n if (st.getLValue() instanceof InstanceFieldAccess) {\n InstanceFieldAccess lv = (InstanceFieldAccess) st.getLValue();\n if (lv.getBase().toString() == \"%this\" && lv.getFieldRef().getDeclaringClass() == method.getDeclaringClass()\n && !st.getRValue().isConst()) {\n CSVar from = solver.getCSManager().getCSVar(context, st.getRValue());\n CSVar to = solver.getCSManager().getCSVar(context, lv.getBase());\n solver.addPFGEdge(from, to, FlowKind.LOCAL_ASSIGN);\n }\n }\n }\n }\n }\n \n\n \n\n \n Click here to see minimum reproduce code \n \n\n \n\npackage org.example;\n\npublic class Main {\n static void sk(User u){\n System.out.println(u.getName());\n }\n static void process(String src){\n User s=new User();\n s.setName(src);\n sk(s);\n }\n public static void main(String[] args) {\n process(\"xxx\");\n }\n}\n\npackage org.example;\n\npublic class User {\n public String getName() {\n return name;\n }\n\n public void setName(String name) {\n this.name = name;\n }\n\n private String name;\n\n}","known_context_document_ids":["gh_issue_2318719027"],"reference_answer":"Writing taint configuration programmatically is our future plan. It's being incubated.","answer_document_id":"gh_comment_1907358255","silver_evidence_path":["gh_comment_2133218763","gh_issue_2095930435","gh_comment_1907358255"],"evidence_issue_ids":[2318719027,2095930435],"source_repo_name":"pascal-lab/Tai-e","source_issue_id":2318719027,"source_issue_number":109,"source_issue_url":"https://github.com/pascal-lab/Tai-e/issues/109","target_repo_name":"pascal-lab/Tai-e","target_issue_id":2095930435,"target_issue_number":86,"target_issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","reference_anchor_document_id":"gh_comment_2133218763","reference_answer_author":"zhangt2333","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1978,"anchor_target_overlap":0.2963,"target_answer_overlap":0.1429},"issue_created_at":"2024-05-27T09:39:35+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2318719027","fragment_type":"issue_description","sequence":0,"text":"How to correctly taint \"%this\"?\n### Overall Description\n\nHi, I want to write a plugin that can taint any class when any field of the class is tainted (e.g, when a tainted variable is passed to `obj.setName(String)`, I want the `obj` is tainted as well after that). However, the caller variable is not affected even through the \"%this\" variable in the callee function is tainted. So how to correctly handle this?\n\nYou can refer to the minimum reproduce code below that the \"%this\" in callee function is tainted\n \n\nHowever the caller \"%this\" is untouched\n \n\nI may misunderstand some parts of the pta analysis, do I need to manually propagate this (why not be handled automatically)?\n\n### Expected Behavior\n\nThe caller object is also tainted.\n\n### Current Behavior\n\nThe caller object is not tainted.\n\n### Tai-e Arguments\n\n \n Click here to see Tai-e Options \n \n\n \nyaml\noptionsFile: null\nprintHelp: false\nclassPath: []\nappClassPath:\n - tester-1.0-SNAPSHOT.jar\nmainClass: org.example.Main\ninputClasses: []\njavaVersion: 8\nprependJVM: false\nallowPhantom: true\nworldBuilderClass: pascal.taie.frontend.soot.SootWorldBuilder\noutputDir: output\npreBuildIR: false\nworldCacheMode: false\nscope: ALL\nnativeModel: true\nplanFile: null\nanalyses:\n ir-dumper: ;\n pta: \"taint-config:config.yml;plugins:[pascal.taie.analysis.pta.plugin.taint.SuperTaintHandler];dump:true\"\nonlyGenPlan: false\nkeepResult:\n - $KEEP-ALL\n\n \n\n \n\n### Tai-e Log\n\n \n Click here to see IR log \n \n\n \n\n static void process(java.lang.String r1) {\n org.example.User $r0;\n [0@L8] $r0 = new org.example.User;\n [1@L8] invokespecial $r0. ()>();\n [2@L9] invokevirtual $r0. (r1);\n [3@L10] invokestatic ($r0);\n [4@L11] return;\n }\n\n public void setName(java.lang.String name) {\n [0@L9] %this. = name;\n [1@L10] return;\n }\n \n\n \n\n \n Click here to see points-to results \n \n\n \n\n[]: /%stringconst0 -> [[]:MergedObj{ }]\n[]: /r0 -> [[]:EntryPointObj{alloc=MethodParam{ /0},type=java.lang.String[] in }]\n[]: /$r0 -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: /r1 -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /$r1 -> [[]:NewObj{ [1@L1147] new java.io.PrintStream}, []:NewObj{ [9@L1150] new java.io.PrintStream}]\n[]: /$r2 -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /r0 -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: /$r1 -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /%this -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: ()>/%this -> [[]:NewObj{ [0@L8] new org.example.User}]\n[]: /%this -> [[]:MergedObj{ }, []:NewObj{ [0@L8] new org.example.User}, []:TaintObj{alloc= /0,type=java.lang.String}]\n[]: /name -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n \n\n \n\n### Additional Information\n\n \n Click here to see key code of my plugin \n \n\n \n\n// It may not be efficient, any suggestions to improve? \n@Override\n public void onNewCSMethod(CSMethod csMethod) {\n JMethod method = csMethod.getMethod();\n Context context = csMethod.getContext();\n IR ir = method.getIR();\n for (Stmt i : ir.getStmts()) {\n if (i instanceof StoreField) {\n StoreField st = (StoreField) i;\n if (st.getLValue() instanceof InstanceFieldAccess) {\n InstanceFieldAccess lv = (InstanceFieldAccess) st.getLValue();\n if (lv.getBase().toString() == \"%this\" && lv.getFieldRef().getDeclaringClass() == method.getDeclaringClass()\n && !st.getRValue().isConst()) {\n CSVar from = solver.getCSManager().getCSVar(context, st.getRValue());\n CSVar to = solver.getCSManager().getCSVar(context, lv.getBase());\n solver.addPFGEdge(from, to, FlowKind.LOCAL_ASSIGN);\n }\n }\n }\n }\n }\n \n\n \n\n \n Click here to see minimum reproduce code \n \n\n \n\npackage org.example;\n\npublic class Main {\n static void sk(User u){\n System.out.println(u.getName());\n }\n static void process(String src){\n User s=new User();\n s.setName(src);\n sk(s);\n }\n public static void main(String[] args) {\n process(\"xxx\");\n }\n}\n\npackage org.example;\n\npublic class User {\n public String getName() {\n return name;\n }\n\n public void setName(String name) {\n this.name = name;\n }\n\n private String name;\n\n}","author_login":"MXWXZ","author_association":"NONE","created_at":"2024-05-27T09:39:35+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2318719027,"issue_number":109,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/109","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2133218763","fragment_type":"issue_comment","sequence":1,"text":"Hello,\n\nThank you for providing such a detailed description and information about the issue. This helps reduce the number of interactions needed, which is greatly appreciated by open source maintainers. \n\nBefore addressing your question, I have a side note. What prompted you to modify the placeholder for `Tai-e Log` in our _New Issue Template_? We intend it to provide runtime information originally, such as `Tai-e Commit: d610a880a2c05968c9e60400f2041f281dee809f` and `java.runtime.version: 17.0.6+10`, among other details. This is not a complaint, just a user study. 😆\n\n---\n \n\nMy Intuition: In this points-to set, a _%this_ variable of type `org.example.User` points to a `String`, which doesn't follow the type system. You should mock another `TaintObj` with the same type as _%this_.\n \n\nYou mentioned \"Any\", so it is temporarily not achievable directly in the current Tai-e. Because _Writing taint configuration programmatically is our future plan. It's being incubated._\n\nBut if you are in urgent need, I provide a simple idea below for your customized implementation: monitor all changes in the points-to set of all InstanceFields. If a `TaintObj` appears, mock a TaintObj which pointed to by the InstanceField's Instance's var.","author_login":"zhangt2333","author_association":"COLLABORATOR","created_at":"2024-05-27T10:54:13+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2318719027,"issue_number":109,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/109","linked_issue_ids":[2095930435],"is_known_query_context":false},{"document_id":"gh_comment_2134340194","fragment_type":"issue_comment","sequence":2,"text":"I found my `tai-e.log` is always empty :(. In case some information are needed:\n\ncommit: 47bdb8b2361083151a44ba76ee2f9f2dbd363b40\njava: Java(TM) SE Runtime Environment (build 17.0.11+7-LTS-207)\n\n \n \n Thanks for your help. I wrote another transfer to do this:\n\npublic class ThisTransfer implements Transfer {\n HeapModel heap;\n\n public ThisTransfer(HeapModel heap) {\n this.heap = heap;\n }\n\n @Override\n public PointsToSet apply(PointerFlowEdge edge, PointsToSet input) {\n if (edge.target() instanceof CSVar && ((CSVar) edge.target()).getVar().toString() == \"%this\") {\n List append = new ArrayList<>();\n input.forEach(o -> {\n if (o.getObject() instanceof MockObj mo && mo.toString().startsWith(\"TaintObj\")) {\n if (mo.getType() != edge.target().getType()) {\n append.add(new CSObj(heap.getMockObj(mo.getDescriptor(), mo.getAllocation(),\n edge.target().getType(), mo.getContainerMethod().orElse(null), mo.isFunctional()), o.getContext(), o.getIndex()));\n }\n }\n });\n append.forEach(input::addObject);\n }\n return input;\n }\n}\n\nand invoke in the plugin\n\nsolver.addPFGEdge(new PointerFlowEdge(FlowKind.LOCAL_ASSIGN, from, to), new ThisTransfer(solver.getHeapModel()));\n\n \n[]: /name -> [[]:MergedObj{ }, []:TaintObj{alloc= /0,type=java.lang.String}]\n\nFrom the log I can ensure the callee %this is tainted with correct type, however, the call site is\n \n\nThere is still no tainted object here. How can I notify or add the taint object to this? I think this should be handled by Tai-e automatically but something must be wrong.","author_login":"MXWXZ","author_association":"NONE","created_at":"2024-05-28T04:50:44+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2318719027,"issue_number":109,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/109","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2134417176","fragment_type":"issue_comment","sequence":3,"text":"What you do is `User.setName/%this /$r0 -> [NewObj]\n /%this -> [NewObj, TaintObj]\n\n`$r0` and `%this` are two variables in different methods' IR. The `$r0` will propagate to `%this`; it is because `[2@L9] invokevirtual $r0. (r1);` create a PFG Edge from `Main.process/$r0` to `User.setName/%this`. However, `%this` will not backpropagate to `$r0`.","author_login":"zhangt2333","author_association":"COLLABORATOR","created_at":"2024-05-28T06:10:48+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2318719027,"issue_number":109,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/109","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2095930435","fragment_type":"issue_description","sequence":0,"text":"Can the configuration of source and sink support wildcard characters, such as using * to match？\n### Clear and concise description of the problem\n\nCan the configuration of source and sink support wildcard characters, such as using * to match\n\n### Impact Analysis\n\n_No response_\n\n### Suggested Solution\n\n_No response_\n\n### Alternative\n\n_No response_\n\n### Intention to submit PR\n\nNo\n\n### Additional Context\n\n_No response_","author_login":"SEC-fsq","author_association":"NONE","created_at":"2024-01-23T12:01:58+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2095930435,"issue_number":86,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1905989941","fragment_type":"issue_comment","sequence":1,"text":"Oh, it is a very valuable and funny issue.\n\nAs it happens, We're working on a more convenient and dedicated mechanism for describing class/method/field in taint configuration; the hard part is we're trying to balance readability and functionality when designing the \"wildcard\" expression mechanism. For example, regular expressions are powerful, but they are less readable; maybe we need support for describing subclasses, but more is not better, it depends.\n\nAnyway, we will support it. Stay tuned for next release milestone.","author_login":"zhangt2333","author_association":"COLLABORATOR","created_at":"2024-01-23T12:48:21+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2095930435,"issue_number":86,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907312003","fragment_type":"issue_comment","sequence":2,"text":"Can we consider opening up an inheritable abstract class that can use Java to write rules, so that users can override and implement the logic in DeserializeSources, DeserializeSinks, DeserializeSanitizers, and DeserializeTransfers according to their needs?","author_login":"SEC-fsq","author_association":"NONE","created_at":"2024-01-24T03:56:30+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2095930435,"issue_number":86,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907358255","fragment_type":"issue_comment","sequence":3,"text":"Writing taint configuration programmatically is our future plan. It's being incubated.","author_login":"zhangt2333","author_association":"COLLABORATOR","created_at":"2024-01-24T04:29:35+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2095930435,"issue_number":86,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225675249","fragment_type":"issue_comment","sequence":4,"text":"Support for signature wildcards is now available. Documentation is currently in progress.\n\nHere's a preview: URL","author_login":"zhangt2333","author_association":"MEMBER","created_at":"2024-07-12T14:13:13+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2095930435,"issue_number":86,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566244031","fragment_type":"issue_comment","sequence":5,"text":"The taint rules with wildcard support are now released in v0.5.1. For details on using wildcards in signatures, please refer to our documentation on signature patterns.","author_login":"zhangt2333","author_association":"MEMBER","created_at":"2024-12-31T08:38:47+08:00","repo_name":"pascal-lab/Tai-e","issue_id":2095930435,"issue_number":86,"issue_url":"https://github.com/pascal-lab/Tai-e/issues/86","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0094","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Docker container update status and update action?","query_context":"**Is your feature request related to a problem? Please describe.**\nI keep opening the Unraid interface mainly for the docker container updates. I have over 100 running at the moment so there is pretty much daily something to update, but I also want to be selective and not update something that I rely on at that moment in time. So I want to create some automations using Home Assistant.\n\n**Describe the solution you'd like**\n- A boolean flag in the attributes of a docker container if there is an update avaialble.\n- An action that can be called on that container to update it.\n\n**Additional context**\nThis would allow me to create automations for updating containers I know are not problematic automatically and show the ones that I need to time it right in some list on a daskboard for myself where I can hit a button and have them updated. If there is something I can do to help with this, please let me know (also a software dev here).","known_context_document_ids":["gh_issue_2712014721"],"reference_answer":"@marcokreeft87 I created a docker insights module for the integration. \n\nThe following sensors gets created\n\n1. Container CPU Usage\n2. Container Memory Usage\n3. Container Network Download / Upload\n4. Total Containers \n5. Running Containers\n6. Paused Containers\n\nFeel free to checkout the experimental feature and let me know what you think\n\nYou will need to copy the unraid folder from experiment/docker-insights branch to your home assistant instance.\n\nYou can only enable docker insights after the initial configuration setup and it takes about a minute to initialise and create the sensors.\n\nScreenshot 2024-11-24 at 4 53 54 pm\n\nYou will see 2 device entries after initialisation \n\nScreenshot 2024-11-24 at 4 55 05 pm\n\nI'll look if its possible to get docker uptime data","answer_document_id":"gh_comment_2495843577","silver_evidence_path":["gh_comment_2513383971","gh_issue_2672517941","gh_comment_2495843577"],"evidence_issue_ids":[2712014721,2672517941],"source_repo_name":"domalab/ha-unraid","source_issue_id":2712014721,"source_issue_number":23,"source_issue_url":"https://github.com/domalab/ha-unraid/issues/23","target_repo_name":"domalab/ha-unraid","target_issue_id":2672517941,"target_issue_number":17,"target_issue_url":"https://github.com/domalab/ha-unraid/issues/17","reference_anchor_document_id":"gh_comment_2513383971","reference_answer_author":"domalab","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1282,"anchor_target_overlap":0.3333,"target_answer_overlap":0.2609},"issue_created_at":"2024-12-02T13:50:14+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_2712014721","fragment_type":"issue_description","sequence":0,"text":"Docker container update status and update action\n**Is your feature request related to a problem? Please describe.**\nI keep opening the Unraid interface mainly for the docker container updates. I have over 100 running at the moment so there is pretty much daily something to update, but I also want to be selective and not update something that I rely on at that moment in time. So I want to create some automations using Home Assistant.\n\n**Describe the solution you'd like**\n- A boolean flag in the attributes of a docker container if there is an update avaialble.\n- An action that can be called on that container to update it.\n\n**Additional context**\nThis would allow me to create automations for updating containers I know are not problematic automatically and show the ones that I need to time it right in some list on a daskboard for myself where I can hit a button and have them updated. If there is something I can do to help with this, please let me know (also a software dev here).","author_login":"ChristianRiesen","author_association":"NONE","created_at":"2024-12-02T13:50:14+08:00","repo_name":"domalab/ha-unraid","issue_id":2712014721,"issue_number":23,"issue_url":"https://github.com/domalab/ha-unraid/issues/23","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2513383971","fragment_type":"issue_comment","sequence":1,"text":"@ChristianRiesen Thanks for the feature request. I'm actually experimenting with a docker insights feature that's listed in URL \n\nI could look at extending it to provide what you are after.\n\nFeel free to try it out just remember to install the dockersocket proxy container on your unraid server first with network set to host. Also make sure to clear your browser cache if you see some sensors not showing correct data.","author_login":"domalab","author_association":"OWNER","created_at":"2024-12-03T02:08:15+08:00","repo_name":"domalab/ha-unraid","issue_id":2712014721,"issue_number":23,"issue_url":"https://github.com/domalab/ha-unraid/issues/23","linked_issue_ids":[2672517941],"is_known_query_context":false},{"document_id":"gh_comment_2568749052","fragment_type":"issue_comment","sequence":2,"text":"I tried to extend the docker socket proxy feature but that didn't work. Caused a lot of stability issues. So much that I'm removing docker insights and docker socket proxy. \n\nMight be able to do it with docker commands but will increase the load on unraid and HA a lot.","author_login":"domalab","author_association":"OWNER","created_at":"2025-01-03T06:29:50+08:00","repo_name":"domalab/ha-unraid","issue_id":2712014721,"issue_number":23,"issue_url":"https://github.com/domalab/ha-unraid/issues/23","linked_issue_ids":[2672517941],"is_known_query_context":false},{"document_id":"gh_comment_2569204117","fragment_type":"issue_comment","sequence":3,"text":"You could use the docker engine API. Here is a SDK for it: URL \nThat way you can use it directly and much leaner then if you were to spawn commands over and over.","author_login":"ChristianRiesen","author_association":"NONE","created_at":"2025-01-03T13:13:06+08:00","repo_name":"domalab/ha-unraid","issue_id":2712014721,"issue_number":23,"issue_url":"https://github.com/domalab/ha-unraid/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2574353093","fragment_type":"issue_comment","sequence":4,"text":"Feel free to fork the repo and try and implement this feature. If you can get it to work without causing HA instability issues then can merge it into main","author_login":"domalab","author_association":"OWNER","created_at":"2025-01-07T04:08:35+08:00","repo_name":"domalab/ha-unraid","issue_id":2712014721,"issue_number":23,"issue_url":"https://github.com/domalab/ha-unraid/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2672517941","fragment_type":"issue_description","sequence":0,"text":"Add docker containers stats\nCan you please add information about the docker containers running in Unraid?\nLike state, name ofcourse, CPU usage and such.\n\nNo rush :)\n\nPS. My end goal is make a dashboard like this with your integration:\n\n URL","author_login":"marcokreeft87","author_association":"NONE","created_at":"2024-11-19T15:10:27+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2490147546","fragment_type":"issue_comment","sequence":1,"text":"@marcokreeft87 I think I'll create a seperate docker monitoring module that pulls these metrics and have it as an option in the integration setup / configuration. Just in case no one else wants to see this type of metrics and extra sensors.\n\n - version\n - containers_running\n - containers_paused\n - containers_stopped\n - containers_cpu_percentage\n - containers_memory_percentage\n - cpu_percentage\n - health\n - uptime\n - memory\n - memory_percentage\n - network_speed_up\n - network_speed_down","author_login":"domalab","author_association":"OWNER","created_at":"2024-11-21T06:02:03+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495843577","fragment_type":"issue_comment","sequence":2,"text":"@marcokreeft87 I created a docker insights module for the integration. \n\nThe following sensors gets created\n\n1. Container CPU Usage\n2. Container Memory Usage\n3. Container Network Download / Upload\n4. Total Containers \n5. Running Containers\n6. Paused Containers\n\nFeel free to checkout the experimental feature and let me know what you think\n\nYou will need to copy the unraid folder from experiment/docker-insights branch to your home assistant instance.\n\nYou can only enable docker insights after the initial configuration setup and it takes about a minute to initialise and create the sensors.\n\nScreenshot 2024-11-24 at 4 53 54 pm\n\nYou will see 2 device entries after initialisation \n\nScreenshot 2024-11-24 at 4 55 05 pm\n\nI'll look if its possible to get docker uptime data","author_login":"domalab","author_association":"OWNER","created_at":"2024-11-24T06:58:07+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495858925","fragment_type":"issue_comment","sequence":3,"text":"Just installed it. But first issue I see is I have all new entities now for the old values:\n\nimage\n\nAnd some are not working anymore:\n\nimage","author_login":"marcokreeft87","author_association":"NONE","created_at":"2024-11-24T07:52:56+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495869270","fragment_type":"issue_comment","sequence":4,"text":"I made updates to the code to fix a unique ID issue with sensors and it also now gets the unraid hostname to use with naming convention of sensors. This allows you to add multiple unraid servers without issues. \n\nUnfortunately the update doesn't migrate existing entities to new ones. \n\nBest is to remove the integration and start fresh. Sorry about that","author_login":"domalab","author_association":"OWNER","created_at":"2024-11-24T08:24:24+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2499869612","fragment_type":"issue_comment","sequence":5,"text":"I updated the sensors to look like this. 1 sensor per container with attributes.\n\nScreenshot 2024-11-26 at 5 26 02 pm\n\nI updated the code to use dockersocket container as it provides better results so you need to have dockersocket container running on unraid.\nScreenshot 2024-11-26 at 5 29 51 pm","author_login":"domalab","author_association":"OWNER","created_at":"2024-11-26T07:30:06+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2507784918","fragment_type":"issue_comment","sequence":6,"text":"Im trying the latest version right now. The CPU temp was my fault btw :)","author_login":"marcokreeft87","author_association":"NONE","created_at":"2024-11-29T13:06:19+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2507810745","fragment_type":"issue_comment","sequence":7,"text":"Do I need special settings for dockersocket? \nimage\nIts not working currently \n\nimage","author_login":"marcokreeft87","author_association":"NONE","created_at":"2024-11-29T13:21:28+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2508205225","fragment_type":"issue_comment","sequence":8,"text":"Oh stupid me. That coming from a guy that works with docker daily xD Thnx it's working now","author_login":"marcokreeft87","author_association":"NONE","created_at":"2024-11-29T17:47:28+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2524748366","fragment_type":"issue_comment","sequence":9,"text":"I have resolved this now and docker insights feature will be available in next update. Pre-reqs will be to have dockersocket proxy container running on unraid.\n\nI have also added fixes that it will load and unload faster without holding HA back from starting / restarting","author_login":"domalab","author_association":"OWNER","created_at":"2024-12-07T01:38:46+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2565023611","fragment_type":"issue_comment","sequence":10,"text":"I have decided to remove this Frankenstein of a feature as its causing too many stability issues and sleepless nights.\n\nThis integration achieves the same but has more options if someone wants have detailed container metrics.\n\n URL","author_login":"domalab","author_association":"OWNER","created_at":"2024-12-30T04:50:41+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2565139560","fragment_type":"issue_comment","sequence":11,"text":"But in the latest release the docker feature is working right?","author_login":"marcokreeft87","author_association":"NONE","created_at":"2024-12-30T07:57:13+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566970841","fragment_type":"issue_comment","sequence":12,"text":"Thanks for the 'frank' response and suggestion, I was having a nightmare with running out of sessions due to the number of queries being spawned (large unraid docker setup) thanks again. I think it is sensible to keep docker integration separate, if for only troubleshooting advantages.","author_login":"twistedsanity","author_association":"NONE","created_at":"2025-01-01T11:37:22+08:00","repo_name":"domalab/ha-unraid","issue_id":2672517941,"issue_number":17,"issue_url":"https://github.com/domalab/ha-unraid/issues/17","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0097","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Time zone problem?","query_context":"Depuis l'installation de la dernière mise à jour, les rendez-vous créés dans Google sont décalés d'une heure dans Outlook.\nPar exemple, si je crée un rendez-vous à 10 h, il apparaît à 9 h dans Outlook. Par contre, la synchronisation dans l'autre sens fonctionne bien.\n\nSince installing the latest update, appointments created in Google are shifted by one hour in Outlook.\nFor example, if I create an appointment at 10am, it will appear at 9am in Outlook. However, synchronisation in the other direction works fine.","known_context_document_ids":["gh_issue_2835266022"],"reference_answer":"@buckaroo54 You're running a full sync or a delta sync? Either press `Shift` and click `Sync`, or use the dropdown on the Sync button...","answer_document_id":"gh_comment_2667171743","silver_evidence_path":["gh_comment_2643480408","gh_issue_2797842193","gh_comment_2667171743"],"evidence_issue_ids":[2835266022,2797842193],"source_repo_name":"phw198/OutlookGoogleCalendarSync","source_issue_id":2835266022,"source_issue_number":2065,"source_issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2065","target_repo_name":"phw198/OutlookGoogleCalendarSync","target_issue_id":2797842193,"target_issue_number":2047,"target_issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","reference_anchor_document_id":"gh_comment_2643480408","reference_answer_author":"phw198","reference_answer_author_association":"OWNER","quality_score":94.83,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.0833,"target_answer_overlap":0.1818},"issue_created_at":"2025-02-06T11:28:29+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_2835266022","fragment_type":"issue_description","sequence":0,"text":"Time zone problem\nDepuis l'installation de la dernière mise à jour, les rendez-vous créés dans Google sont décalés d'une heure dans Outlook.\nPar exemple, si je crée un rendez-vous à 10 h, il apparaît à 9 h dans Outlook. Par contre, la synchronisation dans l'autre sens fonctionne bien.\n\nSince installing the latest update, appointments created in Google are shifted by one hour in Outlook.\nFor example, if I create an appointment at 10am, it will appear at 9am in Outlook. However, synchronisation in the other direction works fine.","author_login":"Beth-Salem","author_association":"NONE","created_at":"2025-02-06T11:28:29+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2835266022,"issue_number":2065,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2065","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2640620923","fragment_type":"issue_comment","sequence":1,"text":"Having the same problem here in the Netherlands (time zone Amsterdam; UTC +1). **Not only new Google meetings are shifted one hour back in Outlook, but also excisting ones!!**\n\nChecked time zones in Outlook and Google, also the time zone mapping in OGCS. They all use UTC +1. No alterations made in the systems timezone settings. \n\nCan't retrieve the date I upgraded to 2.11.2.0. \n\nPls, pls, pls advice! Happy OGCS user for years!\n\nOGcalsync.log","author_login":"JoopHofland","author_association":"NONE","created_at":"2025-02-06T18:05:12+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2835266022,"issue_number":2065,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2065","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2642829151","fragment_type":"issue_comment","sequence":2,"text":"Dear Paul @phw198 , thank you very much! It runs like clockwork again! 👍 #veryhappy","author_login":"JoopHofland","author_association":"NONE","created_at":"2025-02-07T12:50:17+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2835266022,"issue_number":2065,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2065","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2643480408","fragment_type":"issue_comment","sequence":3,"text":"Thanks a lot…\n\n \n\nJean-Michel LÉVÊQUE\n\n14 rue des Caves Basses\n\n34210 CESSERAS\n\n \n\n*06 45 52 06 47\n\n \n\n***@***.*** ***@***.***> \n\n \n\nDe : Paul Woolcock ***@***.***> \nEnvoyé : jeudi 6 février 2025 19:14\nÀ : phw198/OutlookGoogleCalendarSync ***@***.***>\nCc : Beth-Salem ***@***.***>; Author ***@***.***>\nObjet : Re: [phw198/OutlookGoogleCalendarSync] Time zone problem (Issue #2065)\n\n \n\nDuplicate of #2047 >","author_login":"Beth-Salem","author_association":"NONE","created_at":"2025-02-07T16:57:07+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2835266022,"issue_number":2065,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2065","linked_issue_ids":[2797842193],"is_known_query_context":false},{"document_id":"gh_issue_2797842193","fragment_type":"issue_description","sequence":0,"text":"v2.11.2 falsely detecting start/end time changed (by number of hours offset from UTC)\n**OGCS Version**: v2.11.2 \n\n**Bug Description** \nOGCS incorrectly detects changes in start and end times for Google events, due to comparisons in UTC not localtime.\n\n**Steps to Reproduce the Issue** \nFull or delta syncs report a change in start and/or end time when there is none. The difference in time is the offset between localtime and UTC.","author_login":"phw198","author_association":"OWNER","created_at":"2025-01-19T21:34:43+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2601036533","fragment_type":"issue_comment","sequence":1,"text":":package: This should now be resolved with hotfix v2.11.2.1.zip (see instructions for applying).\n      CRCs: Zip = `F6A3BA15` Exe = `8197E679`\n\nPlease let me know how it goes, if you apply the hotfix.","author_login":"phw198","author_association":"OWNER","created_at":"2025-01-19T21:56:40+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2601267787","fragment_type":"issue_comment","sequence":2,"text":"I know I'm not the original reporter, but I too had this issue on 2 recurring meetings and 2 seperate meetings I'd added after moving to the new Aplha. \nThe fix has resolved the issue for me. The meetings have returned to their correct time.","author_login":"TheJacksonian","author_association":"NONE","created_at":"2025-01-20T03:44:39+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603459115","fragment_type":"issue_comment","sequence":3,"text":"I can also confirm hotfix resolved this issue. Needed to do a full sync to revert to the correct times.","author_login":"timothy-holmes","author_association":"NONE","created_at":"2025-01-21T01:42:41+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610298853","fragment_type":"issue_comment","sequence":4,"text":"I have an additional problem described here: URL \nEven after the full sync, I still get these offset errors.\nAlso I think the time shift is sometimes still wrong. But have to check that again tomorrow. Will add more information, if it's really still wrong.","author_login":"lemonbutter","author_association":"NONE","created_at":"2025-01-23T16:23:30+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610493880","fragment_type":"issue_comment","sequence":5,"text":"The hotfix corrected the bug for me. Thanks for all your hard work!","author_login":"emotionstudy4","author_association":"NONE","created_at":"2025-01-23T17:26:19+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610909230","fragment_type":"issue_comment","sequence":6,"text":"Thanks everyone for confirming the fix 👍🏻 \n\nAs this is a high impact bug, I've quietly patched the ZIP and setup.exe on v2.11.2.0 for new installers; unfortunately upgraders will have to apply the hotfix on this page.\n\n@lemonbutter we'll track your issue over on #1978, as it predates the bug that caused the problem on this issue.","author_login":"phw198","author_association":"OWNER","created_at":"2025-01-23T20:03:29+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[2797842193],"is_known_query_context":false},{"document_id":"gh_comment_2636947026","fragment_type":"issue_comment","sequence":7,"text":"Hi, this has fixed the problem when viewing items in the calendar that are synced from google cal to outlook cal. \nThe entries are now at the correct time - so amazing and Thankyou!\n\nBut there may still bepart of the bug not fixed - ie. in the csv's produced and in the OGCS sync verbose output, the timestamp on the text displayed/logged is still incorrect. \nIt seems to be not respecting the timezone offset - eg. in the outlook_create.csv, the \"starttime\" and \"Endtime\" shows eg. \"5/02/2025 6:50:00 AM +00:00\" which maybe in my example should really likely read as something like \"5/02/2025 6:50:00 AM +08:00\"?\nAnd the sync log shows \"And the OGCS app sync log tab (with verbose logging ticked) shows \"5/02/2025 6:50:00 AM \" but should show \"5/02/2025 2:50:00 PM \".","author_login":"joedotbloggs","author_association":"NONE","created_at":"2025-02-05T14:06:09+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2640621060","fragment_type":"issue_comment","sequence":8,"text":"@joedotbloggs You are indeed correct and I had already coded a fix, but just not built a hotfix for it as no one had spotted it yet!\n\n:package: If you would like to confirm hotfix v2.11.2.6.zip does indeed resolve it, it would appreciated though (see instructions for applying).\n      CRCs: Zip = `7BFFA637` Exe = `6A844883`","author_login":"phw198","author_association":"OWNER","created_at":"2025-02-06T18:05:15+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2641812192","fragment_type":"issue_comment","sequence":9,"text":"This hotfix (2.11.2.6) works - fixes both the CSV's and the Verbose Log! \nThank you :)","author_login":"joedotbloggs","author_association":"NONE","created_at":"2025-02-07T02:52:32+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665609049","fragment_type":"issue_comment","sequence":10,"text":"The hotfix is not fixing the issue for EXISTING items in Google. ONLY if I am changing them a bit - like adding 5 minutes and re-syncing - it is fixing the wrong entry in outlook!","author_login":"rafi-d","author_association":"NONE","created_at":"2025-02-18T12:43:00+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665713981","fragment_type":"issue_comment","sequence":11,"text":"@rafi-d For fixing already syncing items you either need to edit the Outlook item(s), or run a full sync from O->G.","author_login":"phw198","author_association":"OWNER","created_at":"2025-02-18T13:26:20+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665776225","fragment_type":"issue_comment","sequence":12,"text":"What about from G to O? Your bug was in Outlook times (in my use case)","author_login":"rafi-d","author_association":"NONE","created_at":"2025-02-18T13:50:01+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2666701211","fragment_type":"issue_comment","sequence":13,"text":"I'm still having the issue that @rafi-d had, with past appointments not updating. I tried hotfixes 2.11.2.1, 2.11.2.3, 2.11.2.4, and 2.11.2.6. It comparies all of the entries and says that none of them need to be updated, even though the past Google Calendar entries are in the correct time and the same past Outlook entries are not. The sync is set Outlook <-- Google. Any ideas?","author_login":"buckaroo54","author_association":"NONE","created_at":"2025-02-18T19:15:22+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667171743","fragment_type":"issue_comment","sequence":14,"text":"@buckaroo54 You're running a full sync or a delta sync? Either press `Shift` and click `Sync`, or use the dropdown on the Sync button...","author_login":"phw198","author_association":"OWNER","created_at":"2025-02-18T23:43:28+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667209607","fragment_type":"issue_comment","sequence":15,"text":"I was _not_ running a full sync 🙃 Thank you for the guidance, all's well now! 😁👍","author_login":"buckaroo54","author_association":"NONE","created_at":"2025-02-19T00:15:37+08:00","repo_name":"phw198/OutlookGoogleCalendarSync","issue_id":2797842193,"issue_number":2047,"issue_url":"https://github.com/phw198/OutlookGoogleCalendarSync/issues/2047","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0098","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Support working with query string and JSON body?","query_context":"### Preflight checklist\n\n- [X] I could not find a solution in the existing issues, docs, nor discussions.\n- [X] I agree to follow this project's Code of Conduct.\n- [X] I have read and am following this repository's Contribution Guidelines.\n- [ ] This issue affects my Ory Cloud project.\n- [ ] I have joined the Ory Community Slack.\n- [ ] I am signed up to the Ory Security Patch Newsletter.\n\n### Describe your problem\n\nSupport working with query string and JSON body\n\n### Describe your ideal solution\n\n1. Mutating and hydrating query string and JSON body (e.g. adding/replacing/removing a query string parameter or a JSON body path)\n2. Extracting data from query string and JSON body for keto_engine_acp_ory (e.g. data from a query string parameter or a JSON body path)\n3. Support autherizer rules for query string parameters and JSON body paths (e.g. allowing or disallowing specific values)\n\n### Workarounds or alternatives\n\n-\n\n### Version\n\n-\n\n### Additional Context\n\n_No response_","known_context_document_ids":["gh_issue_1239529653"],"reference_answer":"Thank you, could you give some example API requests and flows you have? I have a bit of a hard time following because I don’t know Centrifugo","answer_document_id":"gh_comment_932914654","silver_evidence_path":["gh_comment_1250206030","gh_issue_1013337990","gh_comment_932914654"],"evidence_issue_ids":[1239529653,1013337990],"source_repo_name":"ory/oathkeeper","source_issue_id":1239529653,"source_issue_number":964,"source_issue_url":"https://github.com/ory/oathkeeper/issues/964","target_repo_name":"ory/oathkeeper","target_issue_id":1013337990,"target_issue_number":843,"target_issue_url":"https://github.com/ory/oathkeeper/issues/843","reference_anchor_document_id":"gh_comment_1250206030","reference_answer_author":"aeneasr","reference_answer_author_association":"MEMBER","quality_score":86.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.2308,"target_answer_overlap":0.2},"issue_created_at":"2022-05-18T07:13:00+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1239529653","fragment_type":"issue_description","sequence":0,"text":"Support working with query string and JSON body\n### Preflight checklist\n\n- [X] I could not find a solution in the existing issues, docs, nor discussions.\n- [X] I agree to follow this project's Code of Conduct.\n- [X] I have read and am following this repository's Contribution Guidelines.\n- [ ] This issue affects my Ory Cloud project.\n- [ ] I have joined the Ory Community Slack.\n- [ ] I am signed up to the Ory Security Patch Newsletter.\n\n### Describe your problem\n\nSupport working with query string and JSON body\n\n### Describe your ideal solution\n\n1. Mutating and hydrating query string and JSON body (e.g. adding/replacing/removing a query string parameter or a JSON body path)\n2. Extracting data from query string and JSON body for keto_engine_acp_ory (e.g. data from a query string parameter or a JSON body path)\n3. Support autherizer rules for query string parameters and JSON body paths (e.g. allowing or disallowing specific values)\n\n### Workarounds or alternatives\n\n-\n\n### Version\n\n-\n\n### Additional Context\n\n_No response_","author_login":"renom","author_association":"NONE","created_at":"2022-05-18T07:13:00+08:00","repo_name":"ory/oathkeeper","issue_id":1239529653,"issue_number":964,"issue_url":"https://github.com/ory/oathkeeper/issues/964","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1250206030","fragment_type":"issue_comment","sequence":1,"text":"Any updates on that? It seems like #843 is related to this. \nWe are more interesting in query params right now, will a PR will be accepted here?","author_login":"omerlh","author_association":"NONE","created_at":"2022-09-18T06:58:22+08:00","repo_name":"ory/oathkeeper","issue_id":1239529653,"issue_number":964,"issue_url":"https://github.com/ory/oathkeeper/issues/964","linked_issue_ids":[1013337990],"is_known_query_context":false},{"document_id":"gh_comment_1251886904","fragment_type":"issue_comment","sequence":2,"text":"I found a workaround for query params: \n\n{{ .MatchContext.URL.Query.Get \\\"a\\\" }}\n\nNo code change is requires in oathkeeper to support it, just the power of Go templates 💪","author_login":"omerlh","author_association":"NONE","created_at":"2022-09-20T06:15:00+08:00","repo_name":"ory/oathkeeper","issue_id":1239529653,"issue_number":964,"issue_url":"https://github.com/ory/oathkeeper/issues/964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307873386","fragment_type":"issue_comment","sequence":3,"text":"Like this idea: @omerlh Did you find any issues with this at scale?","author_login":"ViswanathB","author_association":"NONE","created_at":"2022-11-08T21:50:12+08:00","repo_name":"ory/oathkeeper","issue_id":1239529653,"issue_number":964,"issue_url":"https://github.com/ory/oathkeeper/issues/964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1721391915","fragment_type":"issue_comment","sequence":4,"text":"Have you had a chance to get the way how to extract some values from original request body?","author_login":"denysandriyanov","author_association":"NONE","created_at":"2023-09-15T14:39:48+08:00","repo_name":"ory/oathkeeper","issue_id":1239529653,"issue_number":964,"issue_url":"https://github.com/ory/oathkeeper/issues/964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722737683","fragment_type":"issue_comment","sequence":5,"text":"If you use the `remote` authorizer the full request body is sent to this service so you can use the request body for authZ. We built a small service that handle authZ so it also handles this part.","author_login":"omerlh","author_association":"CONTRIBUTOR","created_at":"2023-09-18T04:27:42+08:00","repo_name":"ory/oathkeeper","issue_id":1239529653,"issue_number":964,"issue_url":"https://github.com/ory/oathkeeper/issues/964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1013337990","fragment_type":"issue_description","sequence":0,"text":"Working with query parameters\n** Is your feature request related to a problem? Please describe. **\n\nWe use the so called Centrifugo subscription server. It can authenticate socket or SSE subscription requests to a proxy such as this one. But it makes requests with a list of channels to subscribe only in parameters, not in path.\n\n** Describe the solution you'd like **\n\nSo that the outkeeper accepts channel parameters from the request and can use them in the request to the authorizer.\nFor example, a GET request came / path / parameters (chanel1, chanel2). The outkeeper mutates such a request (if required) and you can or cannot contact the authorizer using the parameter values ​​to obtain approval.\n\n** Describe alternatives you've considered **\n\nDefine channels in the form of paths on the outkeeper, mutate them if the request passed the check, make the request further through the hydrator.","author_login":"sash2222","author_association":"NONE","created_at":"2021-10-01T13:17:59+08:00","repo_name":"ory/oathkeeper","issue_id":1013337990,"issue_number":843,"issue_url":"https://github.com/ory/oathkeeper/issues/843","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_932914654","fragment_type":"issue_comment","sequence":1,"text":"Thank you, could you give some example API requests and flows you have? I have a bit of a hard time following because I don’t know Centrifugo","author_login":"aeneasr","author_association":"MEMBER","created_at":"2021-10-03T10:36:30+08:00","repo_name":"ory/oathkeeper","issue_id":1013337990,"issue_number":843,"issue_url":"https://github.com/ory/oathkeeper/issues/843","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_932986316","fragment_type":"issue_comment","sequence":2,"text":"api example.\n\nWe have next config structure:\nmatch:\n url: URL \n\nauthorizer:\n handler: remote_json\n payload: {channels: \"{{ .RegexpCaptureGroups 1 }}\"}\n\nAnd for request: \n URL channel2, channel3]\n\nAuthorizer gets object: {channels: \"channel1, channel2, channel3\"}","author_login":"semichkin","author_association":"NONE","created_at":"2021-10-03T16:48:23+08:00","repo_name":"ory/oathkeeper","issue_id":1013337990,"issue_number":843,"issue_url":"https://github.com/ory/oathkeeper/issues/843","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253902726","fragment_type":"issue_comment","sequence":3,"text":"Would the workaround described here solve/close this issue? \n URL","author_login":"vinckr","author_association":"MEMBER","created_at":"2022-09-21T15:52:49+08:00","repo_name":"ory/oathkeeper","issue_id":1013337990,"issue_number":843,"issue_url":"https://github.com/ory/oathkeeper/issues/843","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0099","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Add automated test for Epinio UI?","query_context":"We have to find a way to do automated tests on the Epinio UI.\n\nThere is multiple ways to do this:\n- only the API (like other Rancher products)\n- as a real user (with something like Selenium)\n- both\n\nLet's discuss the pros and cons of all and anyone can add his ideas here also ;-)","known_context_document_ids":["gh_issue_1056212763"],"reference_answer":"First steps are done, one test was triggered last night and all was green!\n URL \nLet's create other small cards to avoid this one to become too big.\nFixed by URL","answer_document_id":"gh_comment_1026563834","silver_evidence_path":["gh_comment_1019907686","gh_issue_1105497695","gh_comment_1026563834"],"evidence_issue_ids":[1056212763,1105497695],"source_repo_name":"epinio/epinio","source_issue_id":1056212763,"source_issue_number":1000,"source_issue_url":"https://github.com/epinio/epinio/issues/1000","target_repo_name":"epinio/epinio-end-to-end-tests","target_issue_id":1105497695,"target_issue_number":55,"target_issue_url":"https://github.com/epinio/epinio-end-to-end-tests/issues/55","reference_anchor_document_id":"gh_comment_1019907686","reference_answer_author":"juadk","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1429,"target_answer_overlap":0.381},"issue_created_at":"2021-11-17T14:42:18+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1056212763","fragment_type":"issue_description","sequence":0,"text":"Add automated test for Epinio UI\nWe have to find a way to do automated tests on the Epinio UI.\n\nThere is multiple ways to do this:\n- only the API (like other Rancher products)\n- as a real user (with something like Selenium)\n- both\n\nLet's discuss the pros and cons of all and anyone can add his ideas here also ;-)","author_login":"ldevulder","author_association":"COLLABORATOR","created_at":"2021-11-17T14:42:18+08:00","repo_name":"epinio/epinio","issue_id":1056212763,"issue_number":1000,"issue_url":"https://github.com/epinio/epinio/issues/1000","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1008616640","fragment_type":"issue_comment","sequence":1,"text":"Good progress last week, we are close to the end of the first version I think (improvements will be needed):\nCypress_ok\nWe are now more familiar Cypress so coding new scenarios is faster.","author_login":"juadk","author_association":"COLLABORATOR","created_at":"2022-01-10T07:57:22+08:00","repo_name":"epinio/epinio","issue_id":1056212763,"issue_number":1000,"issue_url":"https://github.com/epinio/epinio/issues/1000","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019907686","fragment_type":"issue_comment","sequence":2,"text":"I think we can close this epic, upgrade and CI will be done in there own cards.","author_login":"juadk","author_association":"COLLABORATOR","created_at":"2022-01-24T09:46:47+08:00","repo_name":"epinio/epinio","issue_id":1056212763,"issue_number":1000,"issue_url":"https://github.com/epinio/epinio/issues/1000","linked_issue_ids":[1105497695],"is_known_query_context":false},{"document_id":"gh_issue_1105497695","fragment_type":"issue_description","sequence":0,"text":"Epinio UI test - Cypress CI integration\nWe have to configure CI for our Cypress tests:\n\n1. What components versions we have to test?\nIn a first time: main branch everywhere, last stable rancher-dashboard\n\n2. When do we want to run tests?\nEvery night: URL \n\n3. Which repo can trigger tests?\nepinio-server? helm-chart? e2e?\nLet's start with epinio/epinio, it's the faster way to start (self runners already there etc...)\n**EDIT:** Some runners are not shared across the Epinio organization, so let's try in epinio-end-to-end-tests repo.\n\n4. Which web browsers to test?\nFirefox, Chrome, Safari (mac runner?), headless mode\n\n5. One workflow by scenario\n\n6. Linter to check Cypress code? \n\n URL \nRancher + Epinio in the same node for using only one runner (self hosted), Cypress runs through Docker images (on self hosted runners too).","author_login":"juadk","author_association":"COLLABORATOR","created_at":"2022-01-17T07:59:13+08:00","repo_name":"epinio/epinio-end-to-end-tests","issue_id":1105497695,"issue_number":55,"issue_url":"https://github.com/epinio/epinio-end-to-end-tests/issues/55","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1025901148","fragment_type":"issue_comment","sequence":1,"text":"Today, I've pushed a first test and all is green!\n URL \nNow I have to add more scenarios and improve workflows.","author_login":"juadk","author_association":"COLLABORATOR","created_at":"2022-01-31T15:32:40+08:00","repo_name":"epinio/epinio-end-to-end-tests","issue_id":1105497695,"issue_number":55,"issue_url":"https://github.com/epinio/epinio-end-to-end-tests/issues/55","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026563834","fragment_type":"issue_comment","sequence":2,"text":"First steps are done, one test was triggered last night and all was green!\n URL \nLet's create other small cards to avoid this one to become too big.\nFixed by URL","author_login":"juadk","author_association":"COLLABORATOR","created_at":"2022-02-01T07:57:23+08:00","repo_name":"epinio/epinio-end-to-end-tests","issue_id":1105497695,"issue_number":55,"issue_url":"https://github.com/epinio/epinio-end-to-end-tests/issues/55","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0100","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Symmetries of a C2v system inconsistent with PySCF 2.0 and NWChem?","query_context":"See issue #1464. . The snippet from that issue, on the current master branch, returns:\n\n['A1' 'A1' 'B2' 'A1' 'B1' 'A1' 'B2']\n['A1' 'A1' 'B2' 'A1' 'B1' 'A1' 'B2']\n\nThe output for the unshifted and shifted molecule is the same, but it is the \"incorrect\" output, i.e. what Harry got for the \"unshifted\" molecule and not consistent with NWChem (or PySCF 2.0). \n\nPR URL changes the behaviour to be inconsistent with previous versions of PySCF and with NWChem.","known_context_document_ids":["gh_issue_1667906283"],"reference_answer":"Using the testing script from #1464 , it's not hard to see that the px orbitals of the oxygen atom is assigned to B1 symmetry, and py orbitals are assigned to B2 symmetry. I believe the irreps are correctly labelled. I'll mark this issue as solved for the moment. Feel free to reopen the issue to continue the discussion.","answer_document_id":"gh_comment_2294995122","silver_evidence_path":["gh_comment_2294994494","gh_issue_1376637896","gh_comment_2294995122"],"evidence_issue_ids":[1667906283,1376637896],"source_repo_name":"pyscf/pyscf","source_issue_id":1667906283,"source_issue_number":1705,"source_issue_url":"https://github.com/pyscf/pyscf/issues/1705","target_repo_name":"pyscf/pyscf","target_issue_id":1376637896,"target_issue_number":1430,"target_issue_url":"https://github.com/pyscf/pyscf/issues/1430","reference_anchor_document_id":"gh_comment_2294994494","reference_answer_author":"sunqm","reference_answer_author_association":"COLLABORATOR","quality_score":78.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.4194,"target_answer_overlap":0.0},"issue_created_at":"2023-04-14T09:38:34+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1667906283","fragment_type":"issue_description","sequence":0,"text":"Symmetries of a C2v system inconsistent with PySCF 2.0 and NWChem\nSee issue #1464. . The snippet from that issue, on the current master branch, returns:\n\n['A1' 'A1' 'B2' 'A1' 'B1' 'A1' 'B2']\n['A1' 'A1' 'B2' 'A1' 'B1' 'A1' 'B2']\n\nThe output for the unshifted and shifted molecule is the same, but it is the \"incorrect\" output, i.e. what Harry got for the \"unshifted\" molecule and not consistent with NWChem (or PySCF 2.0). \n\nPR URL changes the behaviour to be inconsistent with previous versions of PySCF and with NWChem.","author_login":"mkrompiec","author_association":"CONTRIBUTOR","created_at":"2023-04-14T09:38:34+08:00","repo_name":"pyscf/pyscf","issue_id":1667906283,"issue_number":1705,"issue_url":"https://github.com/pyscf/pyscf/issues/1705","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1637945471","fragment_type":"issue_comment","sequence":1,"text":"@sunqm can you comment? Is the new behavior preferred, even though it is inconsistent with previous versions and with NWChem?","author_login":"mkrompiec","author_association":"CONTRIBUTOR","created_at":"2023-07-17T11:33:20+08:00","repo_name":"pyscf/pyscf","issue_id":1667906283,"issue_number":1705,"issue_url":"https://github.com/pyscf/pyscf/issues/1705","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2294994494","fragment_type":"issue_comment","sequence":2,"text":"The symmetry detection code in PySCF 2.0 and older versions incorrectly assigns the axes for C2v molecules. It was fixed in #1201. I don't know which convention NWChem follows. I'm sure the symmetry irreps in PySCF 2.1 and newer versions are consistent with the C2v character tables from various sources, such as URL , URL . See also the discussion in the issue #1430 .\n\nI'll mark this issue as solved for the moment. Feel free to reopen the issue to continue the discussion","author_login":"sunqm","author_association":"COLLABORATOR","created_at":"2024-08-17T21:48:28+08:00","repo_name":"pyscf/pyscf","issue_id":1667906283,"issue_number":1705,"issue_url":"https://github.com/pyscf/pyscf/issues/1705","linked_issue_ids":[1376637896],"is_known_query_context":false},{"document_id":"gh_issue_1376637896","fragment_type":"issue_description","sequence":0,"text":"Character table of C2v group seems incorrect\nIn here, it seems B1 and B2 need to be swapped.","author_login":"fishjojo","author_association":"COLLABORATOR","created_at":"2022-09-17T02:20:39+08:00","repo_name":"pyscf/pyscf","issue_id":1376637896,"issue_number":1430,"issue_url":"https://github.com/pyscf/pyscf/issues/1430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250027499","fragment_type":"issue_comment","sequence":1,"text":"From Housecroft 'Introduction to Molecular Symmetry' \nimage\n\nA quick look at other sources confirms that you are right and the table in pyscf is wrong.","author_login":"pwborthwick","author_association":"NONE","created_at":"2022-09-17T08:18:24+08:00","repo_name":"pyscf/pyscf","issue_id":1376637896,"issue_number":1430,"issue_url":"https://github.com/pyscf/pyscf/issues/1430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1474782757","fragment_type":"issue_comment","sequence":2,"text":"sx in the code means the plane perpendicular to x axis. So it is consistent with your table. I've added some comments in param.py .","author_login":"sunqm","author_association":"COLLABORATOR","created_at":"2023-03-18T09:11:16+08:00","repo_name":"pyscf/pyscf","issue_id":1376637896,"issue_number":1430,"issue_url":"https://github.com/pyscf/pyscf/issues/1430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1673898473","fragment_type":"issue_comment","sequence":3,"text":"@fishjojo , thanks for raising this issue. Has it been resolved?","author_login":"verena-neufeld","author_association":"CONTRIBUTOR","created_at":"2023-08-10T20:49:12+08:00","repo_name":"pyscf/pyscf","issue_id":1376637896,"issue_number":1430,"issue_url":"https://github.com/pyscf/pyscf/issues/1430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2294995122","fragment_type":"issue_comment","sequence":4,"text":"Using the testing script from #1464 , it's not hard to see that the px orbitals of the oxygen atom is assigned to B1 symmetry, and py orbitals are assigned to B2 symmetry. I believe the irreps are correctly labelled. I'll mark this issue as solved for the moment. Feel free to reopen the issue to continue the discussion.","author_login":"sunqm","author_association":"COLLABORATOR","created_at":"2024-08-17T21:52:04+08:00","repo_name":"pyscf/pyscf","issue_id":1376637896,"issue_number":1430,"issue_url":"https://github.com/pyscf/pyscf/issues/1430","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0101","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: Current integ tests workflow fails on version incompatibility?","query_context":"### Describe the bug\n\nThe current OS integ tests fails on importing module because `urllib` only supports `OpenSSL` 1.1.1+. Current ssl version is `1.0.2`\n\nLink: URL \nFull context: \n\nRunning ./src/run_integ_test.py manifests/2.8.0/opensearch-2.8.0-test.yml --component job-scheduler --test-run-id 4980 --paths opensearch=/var/jenkins/workspace/integ-test/tar --base-path URL ...\n\nTraceback (most recent call last):\n\n File \"./src/run_integ_test.py\", line 13, in \n\n from test_workflow.integ_test.integ_test_runners import IntegTestRunners\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/integ_test_runners.py\", line 11, in \n\n from test_workflow.integ_test.integ_test_runner_opensearch import IntegTestRunnerOpenSearch\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/integ_test_runner_opensearch.py\", line 15, in \n\n from test_workflow.integ_test.integ_test_suite_opensearch import IntegTestSuiteOpenSearch\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/integ_test_suite_opensearch.py\", line 22, in \n\n from test_workflow.integ_test.topology import NodeEndpoint, Topology\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/topology.py\", line 16, in \n\n from test_workflow.integ_test.local_test_cluster import LocalTestCluster\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/local_test_cluster.py\", line 13, in \n\n from test_workflow.integ_test.service import Service\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/service.py\", line 14, in \n\n import requests\n\n File \"/usr/share/opensearch/.local/share/virtualenvs/integ-test-B5RGX0jA/lib/python3.7/site-packages/requests/__init__.py\", line 43, in \n\n import urllib3\n\n File \"/usr/share/opensearch/.local/share/virtualenvs/integ-test-B5RGX0jA/lib/python3.7/site-packages/urllib3/__init__.py\", line 39, in \n\n \"urllib3 v2.0 only supports OpenSSL 1.1.1+, currently \"\n\nImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips 26 Jan 2017. See: URL \n\nscript returned exit code 1\n\n### To reproduce\n\n URL \n\n### Expected behavior\n\n_No response_\n\n### Screenshots\n\nIf applicable, add screenshots to help explain your problem.\n\n### Host / Environment\n\n_No response_\n\n### Additional context\n\n_No response_\n\n### Relevant log output\n\n_No response_","known_context_document_ids":["gh_issue_1724654911"],"reference_answer":"The cmake upgrade to 3.23.3 version was initially setup as a follow up in the al2023 upgrade/nodejs upgrade, tho now it seems like a 2.9.0 dependencies thus it needs to be updated soon.\n\nThanks.","answer_document_id":"gh_comment_1629803672","silver_evidence_path":["gh_comment_1562083333","gh_issue_1115629364","gh_comment_1629803672"],"evidence_issue_ids":[1724654911,1115629364],"source_repo_name":"opensearch-project/opensearch-build","source_issue_id":1724654911,"source_issue_number":3554,"source_issue_url":"https://github.com/opensearch-project/opensearch-build/issues/3554","target_repo_name":"opensearch-project/opensearch-build","target_issue_id":1115629364,"target_issue_number":1563,"target_issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","reference_anchor_document_id":"gh_comment_1562083333","reference_answer_author":"peterzhuamazon","reference_answer_author_association":"MEMBER","quality_score":91.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0417,"anchor_target_overlap":0.25,"target_answer_overlap":0.2778},"issue_created_at":"2023-05-24T19:59:50+08:00","valid_comment_count":30,"fragments":[{"document_id":"gh_issue_1724654911","fragment_type":"issue_description","sequence":0,"text":"[Bug]: Current integ tests workflow fails on version incompatibility\n### Describe the bug\n\nThe current OS integ tests fails on importing module because `urllib` only supports `OpenSSL` 1.1.1+. Current ssl version is `1.0.2`\n\nLink: URL \nFull context: \n\nRunning ./src/run_integ_test.py manifests/2.8.0/opensearch-2.8.0-test.yml --component job-scheduler --test-run-id 4980 --paths opensearch=/var/jenkins/workspace/integ-test/tar --base-path URL ...\n\nTraceback (most recent call last):\n\n File \"./src/run_integ_test.py\", line 13, in \n\n from test_workflow.integ_test.integ_test_runners import IntegTestRunners\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/integ_test_runners.py\", line 11, in \n\n from test_workflow.integ_test.integ_test_runner_opensearch import IntegTestRunnerOpenSearch\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/integ_test_runner_opensearch.py\", line 15, in \n\n from test_workflow.integ_test.integ_test_suite_opensearch import IntegTestSuiteOpenSearch\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/integ_test_suite_opensearch.py\", line 22, in \n\n from test_workflow.integ_test.topology import NodeEndpoint, Topology\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/topology.py\", line 16, in \n\n from test_workflow.integ_test.local_test_cluster import LocalTestCluster\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/local_test_cluster.py\", line 13, in \n\n from test_workflow.integ_test.service import Service\n\n File \"/var/jenkins/workspace/integ-test/src/test_workflow/integ_test/service.py\", line 14, in \n\n import requests\n\n File \"/usr/share/opensearch/.local/share/virtualenvs/integ-test-B5RGX0jA/lib/python3.7/site-packages/requests/__init__.py\", line 43, in \n\n import urllib3\n\n File \"/usr/share/opensearch/.local/share/virtualenvs/integ-test-B5RGX0jA/lib/python3.7/site-packages/urllib3/__init__.py\", line 39, in \n\n \"urllib3 v2.0 only supports OpenSSL 1.1.1+, currently \"\n\nImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips 26 Jan 2017. See: URL \n\nscript returned exit code 1\n\n### To reproduce\n\n URL \n\n### Expected behavior\n\n_No response_\n\n### Screenshots\n\nIf applicable, add screenshots to help explain your problem.\n\n### Host / Environment\n\n_No response_\n\n### Additional context\n\n_No response_\n\n### Relevant log output\n\n_No response_","author_login":"zelinh","author_association":"MEMBER","created_at":"2023-05-24T19:59:50+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1724654911,"issue_number":3554,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/3554","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1561888849","fragment_type":"issue_comment","sequence":1,"text":"This seems like an upgrade on urllib3 libs due to not supporting openssl version lower than 1.1.1+, where centos7 does not have now. We would need to speed up the process to upgrade to rockylinux8.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-24T20:32:04+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1724654911,"issue_number":3554,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/3554","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1562081906","fragment_type":"issue_comment","sequence":2,"text":"The newer version of requests cause a requirement update on openssl, from 1.1.0 to 1.1.1+, this means CentOS7 is not able to run newer version of request on any activities related to our python code.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-25T00:09:57+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1724654911,"issue_number":3554,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/3554","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1562083333","fragment_type":"issue_comment","sequence":3,"text":"Hi,\n\nOption 1: Revert #3544 and keep using CentOS7 for this release\nOption 2: Move all the changes to RockyLinux8 and remove CentOS7 support.\n\nConsider our decision on the AL2023/NodeJS18/PythonUpgrade 3.9 has already made in this comment: URL \n\nWe will go ahead with option 1 and revert #3544.\n\ncc: @bbarani @gaiksaya \n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-25T00:12:21+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1724654911,"issue_number":3554,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/3554","linked_issue_ids":[1115629364],"is_known_query_context":false},{"document_id":"gh_comment_1562088293","fragment_type":"issue_comment","sequence":4,"text":"Our test in #3544 is running in ubuntu-latest thus does not have the openssl issue in centos7, therefore, not caught.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-25T00:20:26+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1724654911,"issue_number":3554,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/3554","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1115629364","fragment_type":"issue_description","sequence":0,"text":"[Proposal] Support AL2023/NodeJS18 for OpenSearch/Dashboards Releases\nWith the announcement of Amazon Linux 2023 Preview available for testing, we want to setup some notes here for the support of AL2023 once it is fully released to public.\n URL \n URL \n\n* Evaluate the compatibility of AL2023 when running OpenSearch/Dashboards\n * OpenSearch/Dashboards latest binary can run on AL2023 with the same expected behaviors on AL2\n * Working alongside plugin teams to ensure all the plugins are running as expected\n * Performance testing to ensure there is no performance regression\n * Evaluate the package/dependencies availability on AL2023 default repository\n * Evaluate the size of the image vs contents integrity\n* Evaluate AL2023 availability\n * AL2023 available on docker for both x64 and arm64\n * AL2023 available on EC2 for both x64 and arm64 for testing\n* Evaluate Build Process\n * What level of changes do we need to support AL2023 with current build process and scripts\n * Can we support both AL2 and AL2023 in the same system\n * Build tool related libs/packages/dependencies availability on AL2023\n* Evaluate deprecation plan for older OS\n * When would we deprecate AL2 while supporting AL2023\n * Will this introduce breaking changes to customer\n * Would we support older version of OpenSearch/Dashboards with new OS?\n\nWe welcome more discussion on this.\n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2022-01-27T00:17:04+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1530445979","fragment_type":"issue_comment","sequence":1,"text":"Hi @nknize @dblock what do you think about this change?\n\nFrom our teams perspective it makes sense to upgrade the main docker image from AL2 to AL2023 starting 3.0.0. It also make sense that we use this opportunities to upgrade other OS such as Ubuntu and Rockylinux to their latest versions.\n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-01T22:27:24+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1531960304","fragment_type":"issue_comment","sequence":2,"text":"I really don't know enough about this @peterzhuamazon. What are pros/cons?","author_login":"dblock","author_association":"MEMBER","created_at":"2023-05-02T18:36:02+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1550421568","fragment_type":"issue_comment","sequence":3,"text":"Now with this issue on the horizon, we need to also think about how to proceed with the changes:\n* opensearch-project/opensearch-dashboards#3601 \n\nThis means:\n* We have to deprecate ci image that uses centos7 or al2.\n* Our ci and release docker images have to move from al2 to al2023\n* #3351 \n * Python upgrade from 3.7 to 3.9 must follow as al2023 is default to newer version of python\n * AL2 has python 3.7 by default but AL2023 is already bundled with 3.9. It would take longer time just try to compile Python 3.7 on AL2023.\n* KNN will 100% break for certain old OS users if we still use the same docker image for 1.x / 2.x / 3.x, as centos7 is the pinnacle of KNN, as it has the oldest glibc version which does not support Node18. \n * URL \n * Unless we add a new jenkinsfile just for 1.x, we cannot tweak the existing dist-build-dashboards jenkinsfile too much as it is near the size limit of Jenkinsfile max size.\n * Adding a new jenkinsfile just for 1.x will break a lot of the internal hardcoded folder structure on S3\n * One way to avoid this is that OS has to use centos7 to build and OSD has to use al2023 to build, which is very unformalized and hard to maintain.\n* This has to happen after Jenkins Upgrade complete\n * URL \n* This is a major breaking change and seems like they are trying to backport to 2.x as well due to node14 is deprecated and we cannot ship a deprecated product.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-16T22:11:24+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1553500121","fragment_type":"issue_comment","sequence":4,"text":"For the Node 18 upgrade, we're targeting 2.8. This is important as Node 14 no longer will receive security updates (as of April 2023). Is there an ask to delay to solve the above?","author_login":"seanneumann","author_association":"MEMBER","created_at":"2023-05-18T18:58:29+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1555015178","fragment_type":"issue_comment","sequence":5,"text":"KNN support on the native code compilation:\n\nnode: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by node)\nnode: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by node)\nnode: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by node)\nnode: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by node)\nnode: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by node)\nnode: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by node)\n\n# CentOS8/RockyLinux8\nldd (GNU libc) 2.28\n\n# CentOS7\nldd (GNU libc) 2.17\n\n# AL2\nldd (GNU libc) 2.26\n\n# AL2023\nldd (GNU libc) 2.34\n\nSeems like if we want to switch from CentOS7 to CentOS8, we will need to remove support of CentOS7 and AL2 from our support matrix on our website as well, since CentOS8/RockyLinux8 is the baseline of node18 with glibc 2.28.\n URL \n\n URL \ncc: @krisfreedain","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-19T17:36:23+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1555020461","fragment_type":"issue_comment","sequence":6,"text":"I would agree @peterzhuamazon - if we test on CentOS8/RockyLinux8 the compatibility matrix needs to be updated to accurately reflect that for the community","author_login":"krisfreedain","author_association":"MEMBER","created_at":"2023-05-19T17:41:58+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1555147645","fragment_type":"issue_comment","sequence":7,"text":"Hi @peterzhuamazon we will bump the node.js to version `18.16.0`","author_login":"ananzh","author_association":"MEMBER","created_at":"2023-05-19T19:41:15+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1557980867","fragment_type":"issue_comment","sequence":8,"text":"@peterzhuamazon want to clarify, you are saying that node 18 requires 2.28, correct? Then doesn't this break compatibility with AL2 and centos 7? So, regardless of k-NN libs, upgrading to Node 18 would require us to remove centos 7 and AL2 from the compatibility matrix.\n\nIf this is not the case, we could also elect to compile k-NN libs in separate docker image to maintain compatibility.","author_login":"jmazanec15","author_association":"MEMBER","created_at":"2023-05-22T20:55:52+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558017434","fragment_type":"issue_comment","sequence":9,"text":"@peterzhuamazon not sure if you saw this URL \n\nunlike chromium, it is possible to do a custom build of nodejs on centos 7 to lower glibc dependencies (I also saw musl builds somewhere, which can be another possibility to workaround this issue). I've not looked into performance or other issues might be caused by downgrading glibc, but if OS upgrade is difficult maybe this would be easier?","author_login":"joshuali925","author_association":"MEMBER","created_at":"2023-05-22T21:15:17+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558018869","fragment_type":"issue_comment","sequence":10,"text":"Did anyone confirm node 18 with AL2? @seanneumann \n\nWe noticed some glibc related compatibility issues. Not sure if it's an isolated incident.","author_login":"anirudha","author_association":"CONTRIBUTOR","created_at":"2023-05-22T21:16:15+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558025022","fragment_type":"issue_comment","sequence":11,"text":"That is likely not an option because CentOS7 is going to be out of support in 1 year, and we are also on track to move to al2023 anyway. Manually rebuild nodejs18 would add another dep on our side, which is not going to scale on the long run.\n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-22T21:19:37+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558091096","fragment_type":"issue_comment","sequence":12,"text":"Node 18 will not run on AL2; I tried it.\n\nOSD 2.8 will be compatible with Node 14, 16, and 18. OSD 2.8 will also bundle Node 18 and a Node 14 for fallback; with this OSD 2.8 can run on AL2 by using the bundled Node 14.","author_login":"AMoo-Miki","author_association":"CONTRIBUTOR","created_at":"2023-05-22T22:06:22+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558110065","fragment_type":"issue_comment","sequence":13,"text":"1. It does, al2/centos7 have older libs than 2.28.\n2. Agreed that we need to move out of centos7 and al2 at some point.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-22T22:23:30+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558110698","fragment_type":"issue_comment","sequence":14,"text":"If node14 out of support can we even bundle a 14 alongside 18 together?","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-22T22:24:24+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1558193665","fragment_type":"issue_comment","sequence":15,"text":"@peterzhuamazon I hate it but being a minor release, we have to.","author_login":"AMoo-Miki","author_association":"CONTRIBUTOR","created_at":"2023-05-22T23:38:02+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1561890339","fragment_type":"issue_comment","sequence":16,"text":"Need to move the integTest runner to rockylinux8 as well: \n* URL","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-24T20:33:33+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1563209700","fragment_type":"issue_comment","sequence":17,"text":"These three will need to get baseOS change to rockylinux8 before adding node18.\nThese are the only ones do not have node18 on docker images, AMI not affected.\n\ndocker/ci/dockerfiles/current/build.centos7.opensearch-dashboards.x64.arm64.dockerfile\ndocker/ci/dockerfiles/current/release.centos.clients.x64.arm64.dockerfile\ndocker/ci/dockerfiles/current/test.centos7.performance-test.x64.arm64.dockerfile","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-25T16:44:02+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1570621194","fragment_type":"issue_comment","sequence":18,"text":"Rockylinux:8\n\ngcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-18)\nCopyright (C) 2018 Free Software Foundation, Inc.\nThis is free software; see the source for copying conditions. There is NO\nwarranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n\nWill switch to devtooset8 on centos7 to match with rockylinux:8 which we will eventually switch to.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-31T17:23:24+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1570655193","fragment_type":"issue_comment","sequence":19,"text":"Using scl and devtoolset might be a problem because it requires running `source scl_source enable devtoolset8` either through rc or through profile.\n\nWith us locking docker images to non-interactive shell this is not the best option.\nExploring manually compile gcc 8 from source.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-05-31T17:47:27+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588162950","fragment_type":"issue_comment","sequence":20,"text":"Hi All,\n\nWe are going to stay with node16 for 2.9, and plan to move to node18 for 2.10.\nThis would ensure us to have enough time for the upgrade.\nAs well as compensate the changes for multiple teams.\n\nWe can also start the Python3.9 upgrade process as Python3.7 is about to be eol by 2023/06/23.\n\nOnce we go to node18 in 2.10, the support matrix of our product will need to remove these OSes:\n\n* RHEL7&CentOS7 / AmazonLinux2 (glibc2.17 / glibc2.26)\n* Ubuntu 16.04 / Ubuntu 18.04 (glibc2.23 / glibc2.27)\n(Note: we still bundle node14 as fallback so technically above can still run, but 14 is eol and we do not officially support them anymore)\n\nThis also requires that the 2.x branch stays on 16.20.0 in .nvmrc, and have no node18 specific code committed until 2.9.0 is released to the public.\n\nInfra will take care of the node18 upgrade once after 2.9.0.\n\nThanks.\n\ncc: @CEHENKLE @dblock @seanneumann @AMoo-Miki @ananzh @seraphjiang @vamshin @jmazanec15 @bbarani @hdhalter","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-06-12T21:59:53+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1629803672","fragment_type":"issue_comment","sequence":21,"text":"The cmake upgrade to 3.23.3 version was initially setup as a follow up in the al2023 upgrade/nodejs upgrade, tho now it seems like a 2.9.0 dependencies thus it needs to be updated soon.\n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-07-10T22:15:52+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1660829002","fragment_type":"issue_comment","sequence":22,"text":"## 20230801 Update: (AL2023/NodeJS18 on 2.10.0 Release)\n\n### Required Steps\n\n* Update all AMIs to have NodeJS14/16/18 support.\n* Update all CI docker images to have NodeJS14/16/18 support.\n* Update all Release docker images to use NodeJS18 as the base node version for OSD.\n* Deprecate all CentOS7 images in build systems and replace with the RockyLinux8 images (Except client release image as it does not require nodejs18 by default for now).\n* Work with OSD team members to ensure all OSD core and plugins are locking to NodeJS 18.16.0 at least on 2.x/2.10 branches. 1.x can pending.\n* Since KNN already update the dependencies such as gcc to v7 and cmake to 3.23.3, it is easier for us to bring them onto either Rockylinux8 or AL2023. Starting from now k-NN will not be able to run on OS with glibc version lower than 2.28 (previously 2.17)\n* Work with doc team to update the doc compatibility charts to remove CentOS7 support and add AL2023.\n* Test all the pipelines on the new servers.\n\n### Optional Steps\n* Need to discuss after the 2.10.0 release whether or not 1.x line need to upgrade as well.\n* Have separate pipeline to test NodeJS14 bc abilities.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-08-01T18:01:08+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1694153501","fragment_type":"issue_comment","sequence":23,"text":"What is the status of the separate pipeline to test node 14 backward compatibility? There are going to be users using old linux versions who can't go past node 14 yet, and it would be useful to know what fixes we can do so as to not unnecessarily break things for those users.","author_login":"wbeckler","author_association":"NONE","created_at":"2023-08-26T04:17:20+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1697015510","fragment_type":"issue_comment","sequence":24,"text":"@wbeckler We do not have plans to create a separate pipeline in public Jenkins infra for EOL versions of Node. If needed, this needs to be tackled at repo level.","author_login":"bbarani","author_association":"MEMBER","created_at":"2023-08-29T08:41:00+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1701514107","fragment_type":"issue_comment","sequence":25,"text":"Have quick talk with OSD @AMoo-Miki about core, and we are planning to switch 2.x to 18.16.0 next week to start testing on the 2.10.0 build with newer nodejs.\n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-08-31T17:57:08+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1743760348","fragment_type":"issue_comment","sequence":26,"text":"The majority of the tasks in this issue is resolved and implemented.\nWe will issue new tickets whenever new tasks coming up.\n\nThanks.","author_login":"peterzhuamazon","author_association":"MEMBER","created_at":"2023-10-02T21:02:10+08:00","repo_name":"opensearch-project/opensearch-build","issue_id":1115629364,"issue_number":1563,"issue_url":"https://github.com/opensearch-project/opensearch-build/issues/1563","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0102","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Automatically creates a replication of nodes in the scene when the game is closed?","query_context":"### Tested versions\n\nthe master version\n\n### System information\n\nwindows 10\n\n### Issue description\n\n URL \n\n### Steps to reproduce\n\nFollow the actions in the video\n\n### Minimal reproduction project (MRP)\n\ntest1.zip","known_context_document_ids":["gh_issue_2237740030"],"reference_answer":"At a glance I suspect the issue is that the change in timing means the scene editor adds a preview environment or similar incorrectly and then doesn't restore it, could be related to incorrectly not checking ownership as well","answer_document_id":"gh_comment_2017882964","silver_evidence_path":["gh_comment_2049912281","gh_issue_2205441058","gh_comment_2017882964"],"evidence_issue_ids":[2237740030,2205441058],"source_repo_name":"godotengine/godot","source_issue_id":2237740030,"source_issue_number":90533,"source_issue_url":"https://github.com/godotengine/godot/issues/90533","target_repo_name":"godotengine/godot","target_issue_id":2205441058,"target_issue_number":89877,"target_issue_url":"https://github.com/godotengine/godot/issues/89877","reference_anchor_document_id":"gh_comment_2049912281","reference_answer_author":"AThousandShips","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.6,"anchor_target_overlap":0.6,"target_answer_overlap":0.2105},"issue_created_at":"2024-04-11T13:32:47+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2237740030","fragment_type":"issue_description","sequence":0,"text":"Automatically creates a replication of nodes in the scene when the game is closed\n### Tested versions\n\nthe master version\n\n### System information\n\nwindows 10\n\n### Issue description\n\n URL \n\n### Steps to reproduce\n\nFollow the actions in the video\n\n### Minimal reproduction project (MRP)\n\ntest1.zip","author_login":"Aishengmin","author_association":"NONE","created_at":"2024-04-11T13:32:47+08:00","repo_name":"godotengine/godot","issue_id":2237740030,"issue_number":90533,"issue_url":"https://github.com/godotengine/godot/issues/90533","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2049904308","fragment_type":"issue_comment","sequence":1,"text":"Your video doesn't work, and please specify what version you are on specifically","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-04-11T15:02:46+08:00","repo_name":"godotengine/godot","issue_id":2237740030,"issue_number":90533,"issue_url":"https://github.com/godotengine/godot/issues/90533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049912281","fragment_type":"issue_comment","sequence":2,"text":"Also sounds like:\n* URL \n\nFrom just the description, without the video","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-04-11T15:05:30+08:00","repo_name":"godotengine/godot","issue_id":2237740030,"issue_number":90533,"issue_url":"https://github.com/godotengine/godot/issues/90533","linked_issue_ids":[2205441058],"is_known_query_context":false},{"document_id":"gh_comment_2049931541","fragment_type":"issue_comment","sequence":3,"text":"I don't know why the video won't play, it's just a simple mp4 video, but it can be played after downloading","author_login":"Aishengmin","author_association":"NONE","created_at":"2024-04-11T15:13:27+08:00","repo_name":"godotengine/godot","issue_id":2237740030,"issue_number":90533,"issue_url":"https://github.com/godotengine/godot/issues/90533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049979036","fragment_type":"issue_comment","sequence":4,"text":"Then this problem is solved in the latest version, try building the latest version\n\nIf you're still having problems please comment and we can investigate if further","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-04-11T15:35:15+08:00","repo_name":"godotengine/godot","issue_id":2237740030,"issue_number":90533,"issue_url":"https://github.com/godotengine/godot/issues/90533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2205441058","fragment_type":"issue_description","sequence":0,"text":"Switching scene tabs duplicates nodes in the scene and eventually also leads to an editor crash.\n### Tested versions\n\n- Reproducible: 4.3dev master[99ff024f78f65ba0bc54fb409cfeca43ba2008fe]\n- Not reproducible: 4.3 dev5\n\n### System information\n\nWindows 11 - Vulkan - Nvidia RTX 4070 - intel i5 13600KF\n\n### Issue description\n\nWhen switching scene tabs while running the project some nodes in the scene tree get duplicated and stay in, eventually leading to a crash after couple times of repeating.\n\n**Video:** URL \n\n### Steps to reproduce\n\n1. Open the MRP.\n2. Open the Test.tscn to have two tabs (main and test).\n3. Go to main and press save and reload the project (this step is just in case, might not be necessary).\n4. Play the project and keep the play window somewhere (doesn't matter).\n5. In the editor switch from main to test tab and then back to the main tab.\n6. Observe some nodes got duplicated.\n(7. Repeat this proces to duplicate more - you might need to always press the stop and play buttons for every duplication - and observe after couple duplications the editor hard crashes)\n\n### Minimal reproduction project (MRP)\n\nMrp.zip\n\nEDIT(@lyuma + @Illauriel): simpler MRP and repro steps:\nAnother MRP: node-dupe-bug.zip\nSteps to reproduce:\n1. Open node3d.tscn.\n2. Open the nested scene.\n3. Save the nested scene\n4. Return to the original node3d.tscn. it will contain duplicate nodes.\n\nThe reason play duplicates nodes is because the play button saves all scenes. Therefore saving is sufficient.","author_login":"viksl","author_association":"CONTRIBUTOR","created_at":"2024-03-25T10:45:01+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017836709","fragment_type":"issue_comment","sequence":1,"text":"Regression from:\n* URL \n\nUnsure if this *caused* it or just exposed an existing issue that didn't fire without this\n\nCC @ajreckof @KoBeWi","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-03-25T11:55:34+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017882964","fragment_type":"issue_comment","sequence":2,"text":"At a glance I suspect the issue is that the change in timing means the scene editor adds a preview environment or similar incorrectly and then doesn't restore it, could be related to incorrectly not checking ownership as well","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-03-25T12:21:58+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017887110","fragment_type":"issue_comment","sequence":3,"text":"You don't need to play the project. Just save the instance scene and go back to the parent scene. This causes reloading the scene (to update the instance) and leads to the mentioned bug.\n\nAfter enough repeats, I got the editor to freeze while spamming `Object was deleted while awaiting a callback.` in the console.","author_login":"KoBeWi","author_association":"MEMBER","created_at":"2024-03-25T12:24:34+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017920986","fragment_type":"issue_comment","sequence":4,"text":"In my own project (not the MRP) it duplicates several nodes as seen here (check the Time label is the only one without @ in the name but it was also duplicated).\nimage","author_login":"viksl","author_association":"CONTRIBUTOR","created_at":"2024-03-25T12:44:09+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017930909","fragment_type":"issue_comment","sequence":5,"text":"Well the crash seems specific to your scene. The bug is that nodes get duplicated, but depending on nodes, the end result might be different.","author_login":"KoBeWi","author_association":"MEMBER","created_at":"2024-03-25T12:49:47+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017942798","fragment_type":"issue_comment","sequence":6,"text":"It's due to an incorrect deletion sequence in the PR, writing a fix right now:\n URL","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-03-25T12:56:42+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017951617","fragment_type":"issue_comment","sequence":7,"text":"Indeed, this should go from last to first.\n\nBut this approach feels hacky in the first place, maybe we could add a bool to `replace_by` to not copy child nodes?","author_login":"akien-mga","author_association":"MEMBER","created_at":"2024-03-25T12:59:54+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2029352714","fragment_type":"issue_comment","sequence":8,"text":"@Illauriel and I confirmed a bisect of #89447\nAnother MRP: node-dupe-bug.zip\n\nSteps to reproduce:\n1. Open node3d.tscn.\n2. Open the nested scene.\n3. Save the nested scene\n4. Return to the original node3d.tscn. it will contain duplicate nodes.\n\nI also had a suspicion that an internal node somewhere could cause an issue: I recall from debugging a different issue that the core function `Node::replace_by` may be buggy in the presence of internal nodes (off-by-n error), since it does not properly check indexing, so seeing `replace_by` in the regression PR is setting off that alarm bell as well.\n\nFrom my notes about replace_by:\n\nAll nodes have to be added and moved to the same index, one by one. This might make files with thousands of nodes slow.\nCalling replace_by on an internal node will malfunction because it does not preserve the internal_node in the add_child call\nI do think there's a core bug in that replace_by is incorrect for internal nodes\n\nI should try and repro + file the bug about replace_by, since it's probably a separate issue, but wanted to bring it up anyway just in case.","author_login":"lyuma","author_association":"CONTRIBUTOR","created_at":"2024-04-01T08:04:04+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2035649874","fragment_type":"issue_comment","sequence":9,"text":"Moving a `GDScript` from one folder to another also reproduced this bug for me.","author_login":"Maran23","author_association":"CONTRIBUTOR","created_at":"2024-04-03T21:41:32+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2035809241","fragment_type":"issue_comment","sequence":10,"text":"It seems that it will appear as long as you save the sub-scene and switch to the main scene.\n\nNodes will be duplicated only when the nodes meet the following conditions:\n1. Is a direct non-internal child node of the main scene root;\n2. The node index is an even number.","author_login":"Rindbee","author_association":"CONTRIBUTOR","created_at":"2024-04-03T23:35:38+08:00","repo_name":"godotengine/godot","issue_id":2205441058,"issue_number":89877,"issue_url":"https://github.com/godotengine/godot/issues/89877","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0103","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Python 3.13 not support?","query_context":"Hi there!\n\nSomething got updated on my system, and I am unable to build master, as well as branches that I have been able to build before. \n\nIn all cases, the error message is this:\n\n[ 10%] Building CXX object CMakeFiles/vegastrike_python.dir/src/python/config/python_utils.cpp.o\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp: In function ‘const std::string GetPythonPath()’:\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp:44:37: warning: ‘wchar_t* Py_GetPath()’ is deprecated [-Wdeprecated-declarations]\n 44 | wchar_t* w_path_ptr = Py_GetPath();\n | ~~~~~~~~~~^~\nIn file included from /usr/include/python3.13/Python.h:123,\n from /usr/include/boost/python/detail/wrap_python.hpp:178,\n from /usr/include/boost/python/detail/prefix.hpp:13,\n from /usr/include/boost/python/args.hpp:8,\n from /usr/include/boost/python.hpp:11,\n from /mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp:31:\n/usr/include/python3.13/pylifecycle.h:46:43: note: declared here\n 46 | Py_DEPRECATED(3.13) PyAPI_FUNC(wchar_t *) Py_GetPath(void);\n | ^~~~~~~~~~\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp: In function ‘PyObject* GetClassFromPython(std::string, std::string, std::string, std::string)’:\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp:76:5: error: ‘Py_SetPath’ was not declared in this scope; did you mean ‘Py_GetPath’?\n 76 | Py_SetPath(python_path);\n | ^~~~~~~~~~\n | Py_GetPath\nmake[2]: *** [CMakeFiles/vegastrike_python.dir/build.make:79: CMakeFiles/vegastrike_python.dir/src/python/config/python_utils.cpp.o] Error 1\nmake[1]: *** [CMakeFiles/Makefile2:224: CMakeFiles/vegastrike_python.dir/all] Error 2\nmake: *** [Makefile:156: all] Error 2\n==> ERROR: A failure occurred in build().\n Aborting...\n\nNormally I have makeflags -j32, so this failure got jumbled among all the other jobs that are running, but for this build single jobs were specified.","known_context_document_ids":["gh_issue_2760451153"],"reference_answer":"Issue gh-88279 was in 2021.\n\nI wrote it in this issue description in 2023:\n \n\nWhat changed in that the PyConfig API is now widely available and is a better API than the deprecated one.","answer_document_id":"gh_comment_1893788333","silver_evidence_path":["gh_comment_2563369707","gh_issue_1734409208","gh_comment_1893788333"],"evidence_issue_ids":[2760451153,1734409208],"source_repo_name":"vegastrike/Vega-Strike-Engine-Source","source_issue_id":2760451153,"source_issue_number":941,"source_issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","target_repo_name":"python/cpython","target_issue_id":1734409208,"target_issue_number":105145,"target_issue_url":"https://github.com/python/cpython/issues/105145","reference_anchor_document_id":"gh_comment_2563369707","reference_answer_author":"vstinner","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.4615},"issue_created_at":"2024-12-27T06:13:32+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2760451153","fragment_type":"issue_description","sequence":0,"text":"Python 3.13 not support\nHi there!\n\nSomething got updated on my system, and I am unable to build master, as well as branches that I have been able to build before. \n\nIn all cases, the error message is this:\n\n[ 10%] Building CXX object CMakeFiles/vegastrike_python.dir/src/python/config/python_utils.cpp.o\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp: In function ‘const std::string GetPythonPath()’:\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp:44:37: warning: ‘wchar_t* Py_GetPath()’ is deprecated [-Wdeprecated-declarations]\n 44 | wchar_t* w_path_ptr = Py_GetPath();\n | ~~~~~~~~~~^~\nIn file included from /usr/include/python3.13/Python.h:123,\n from /usr/include/boost/python/detail/wrap_python.hpp:178,\n from /usr/include/boost/python/detail/prefix.hpp:13,\n from /usr/include/boost/python/args.hpp:8,\n from /usr/include/boost/python.hpp:11,\n from /mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp:31:\n/usr/include/python3.13/pylifecycle.h:46:43: note: declared here\n 46 | Py_DEPRECATED(3.13) PyAPI_FUNC(wchar_t *) Py_GetPath(void);\n | ^~~~~~~~~~\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp: In function ‘PyObject* GetClassFromPython(std::string, std::string, std::string, std::string)’:\n/mnt/int/system/aur/vegastrike-engine-git/src/Vega-Strike-Engine-Source/engine/src/python/config/python_utils.cpp:76:5: error: ‘Py_SetPath’ was not declared in this scope; did you mean ‘Py_GetPath’?\n 76 | Py_SetPath(python_path);\n | ^~~~~~~~~~\n | Py_GetPath\nmake[2]: *** [CMakeFiles/vegastrike_python.dir/build.make:79: CMakeFiles/vegastrike_python.dir/src/python/config/python_utils.cpp.o] Error 1\nmake[1]: *** [CMakeFiles/Makefile2:224: CMakeFiles/vegastrike_python.dir/all] Error 2\nmake: *** [Makefile:156: all] Error 2\n==> ERROR: A failure occurred in build().\n Aborting...\n\nNormally I have makeflags -j32, so this failure got jumbled among all the other jobs that are running, but for this build single jobs were specified.","author_login":"evertvorster","author_association":"CONTRIBUTOR","created_at":"2024-12-27T06:13:32+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2563369707","fragment_type":"issue_comment","sequence":1,"text":"With a little Googling, it seems related to this commit:\n\n URL","author_login":"evertvorster","author_association":"CONTRIBUTOR","created_at":"2024-12-27T06:26:37+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[1734409208],"is_known_query_context":false},{"document_id":"gh_comment_2563967531","fragment_type":"issue_comment","sequence":2,"text":"Hi there...\nI could change the way that vegastrike builds on Arch linux, and link to an older version of python, probably. However, this is an issue that needs fixing sooner or later, as other distributions of Linux will be following suit and also updating their version of Python to 3.13. \n\nKeeping this in mind, is there any point in making a special package that uses an older python?\n\nI guess it boils down to how long and involved this issue is to fix. I'm not a good enough coder to know, does anyone else have an idea?","author_login":"evertvorster","author_association":"CONTRIBUTOR","created_at":"2024-12-27T19:19:18+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2563989616","fragment_type":"issue_comment","sequence":3,"text":"@evertvorster agreed; though it may be a week or so before we get to it. You might be able to temporarily.","author_login":"BenjamenMeyer","author_association":"MEMBER","created_at":"2024-12-27T19:52:00+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566105625","fragment_type":"issue_comment","sequence":4,"text":"Okay, so I just looked at the code. This bug appears to be fairly limited in scope, with no more than 4 or 5 lines of code calling any of the deprecated or removed Python APIs from that deprecation. All of these lines of code were introduced in two of your commits, @royfalk , one from 2024-10-02 and the other from 2024-11-01. Filenames:\n\n1. init.cpp\n2. python_tests.cpp\n3. python_utils.cpp\n4. python_utils.h\n\nThe calls in question are Py_GetPath and Py_SetPath. No other deprecated APIs are involved here.\n\nIt looks like these two APIs can be replaced using URL","author_login":"stephengtuggy","author_association":"CONTRIBUTOR","created_at":"2024-12-31T03:40:17+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566106063","fragment_type":"issue_comment","sequence":5,"text":"Please note, also, that this problem does not exist on the 0.9.x branch, since the Py_GetPath and Py_SetPath calls hadn't been introduced yet.","author_login":"stephengtuggy","author_association":"CONTRIBUTOR","created_at":"2024-12-31T03:41:31+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586206706","fragment_type":"issue_comment","sequence":6,"text":"Not sure what changed, but git master compiles again. \nThere are a LOT of warnings, but it does compile.","author_login":"evertvorster","author_association":"CONTRIBUTOR","created_at":"2025-01-13T05:36:51+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587694571","fragment_type":"issue_comment","sequence":7,"text":"Sweet! Yeah, I thought I had fixed it, sometime in the last week I believe. That's good to get confirmation that it is fixed.","author_login":"stephengtuggy","author_association":"CONTRIBUTOR","created_at":"2025-01-13T17:07:56+08:00","repo_name":"vegastrike/Vega-Strike-Engine-Source","issue_id":2760451153,"issue_number":941,"issue_url":"https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/941","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1734409208","fragment_type":"issue_description","sequence":0,"text":"C API: Remove legacy API functions to configure Python initialization\nThe following C API functions were deprecated in Python 3.11 by issue #88279:\n\n* ``PySys_AddWarnOptionUnicode()``\n* ``PySys_AddWarnOption()``\n* ``PySys_AddXOption()``\n* ``PySys_HasWarnOptions()``\n* ``PySys_SetArgvEx()``\n* ``PySys_SetArgv()``\n* ``PySys_SetPath()``\n* ``Py_SetPath()``\n* ``Py_SetProgramName()``\n* ``Py_SetPythonHome()``\n* ``Py_SetStandardStreamEncoding()``\n* ``_Py_SetProgramFullPath()``\n\nIMO it's now time to remove them: the new PyConfig API is available since Python 3.8: URL \n\n \n### Linked PRs\n* gh-105154\n* gh-105179","author_login":"vstinner","author_association":"MEMBER","created_at":"2023-05-31T14:50:07+08:00","repo_name":"python/cpython","issue_id":1734409208,"issue_number":105145,"issue_url":"https://github.com/python/cpython/issues/105145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1570503911","fragment_type":"issue_comment","sequence":1,"text":"Oh no, too bad, I forgot to deprecate PySys_ResetWarnOptions() in Python 3.11.","author_login":"vstinner","author_association":"MEMBER","created_at":"2023-05-31T15:57:54+08:00","repo_name":"python/cpython","issue_id":1734409208,"issue_number":105145,"issue_url":"https://github.com/python/cpython/issues/105145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1893788333","fragment_type":"issue_comment","sequence":2,"text":"Issue gh-88279 was in 2021.\n\nI wrote it in this issue description in 2023:\n \n\nWhat changed in that the PyConfig API is now widely available and is a better API than the deprecated one.","author_login":"vstinner","author_association":"MEMBER","created_at":"2024-01-16T13:54:18+08:00","repo_name":"python/cpython","issue_id":1734409208,"issue_number":105145,"issue_url":"https://github.com/python/cpython/issues/105145","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0105","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"design: is the buffer of a string or a bytes value required to terminate with a 0 ?","query_context":"[Update:] This started as a bug issue assuming that the the answer was \"yes\". Turns out that we are not settled on the answer.\n\nTherefore this issue now requests to determine the answer and to adjust our implementation to comply with it. If the answer is \"yes\", users can create non-compliant strings (see below). If the answer is \"no\", we likely have code that will malfunction when passed a non-0-terminating string.\n\n[Previous contents:] Our convention today for the underlying buffer of a string, i.e., `_string.buff` (source), is that it is zero-terminated. Therefore, s.buffSize should be at least s.buffLen+1.\n\nNeither condition is checked in `createStringWithBorrowedBuffer(x: c_ptr(?t), length: int, size: int)` (source). Therefore users can invoke this function in a way that creates a string with our convention violated.\n\nThe test `test/library/standard/IO/readAll/readBytesArray.chpl` (source)does exactly that. It invokes createStringWithBorrowedBuffer() passing it a buffer of size 1032 and length == size == 1032. The violation of both conditions goes unnoticed because nothing in that test relies on the invariant to hold. Whether or not the string is 0-terminated is immaterial because the buffer `a_signed` does not have room for that final zero.\n\nIf we switch the test to invoke createBytesWithBorrowedBuffer(), it will have the same violation.\n\nChapel version: 4d5379da31","known_context_document_ids":["gh_issue_1474596091"],"reference_answer":"I agree with what Michael says (and think it's consistent with `writef()/readf()` where ultimately we want to do more compile-time checking for param formatting strings, but having any checking is better than none).\n\nI don't think there should be a back door for users, but that having a \"prevalidated\" code path for internal use makes sense.\n\nI don't have a strong feeling about validating within the I/O system vs. at string creation time at present. Whatever we do, I'd like to not have to support three different string validation pieces of code. Ideally, they'd all use the same code (which might suggest doing the validation in C so that it can be reused in the compiler and via the runtime?).","answer_document_id":"gh_comment_547036055","silver_evidence_path":["gh_comment_1439241061","gh_issue_500412725","gh_comment_547036055"],"evidence_issue_ids":[1474596091,500412725],"source_repo_name":"chapel-lang/chapel","source_issue_id":1474596091,"source_issue_number":21160,"source_issue_url":"https://github.com/chapel-lang/chapel/issues/21160","target_repo_name":"chapel-lang/chapel","target_issue_id":500412725,"target_issue_number":14177,"target_issue_url":"https://github.com/chapel-lang/chapel/issues/14177","reference_anchor_document_id":"gh_comment_1439241061","reference_answer_author":"bradcray","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1383,"anchor_target_overlap":0.3645,"target_answer_overlap":0.3929},"issue_created_at":"2022-12-04T08:26:46+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_1474596091","fragment_type":"issue_description","sequence":0,"text":"design: is the buffer of a string or a bytes value required to terminate with a 0 ?\n[Update:] This started as a bug issue assuming that the the answer was \"yes\". Turns out that we are not settled on the answer.\n\nTherefore this issue now requests to determine the answer and to adjust our implementation to comply with it. If the answer is \"yes\", users can create non-compliant strings (see below). If the answer is \"no\", we likely have code that will malfunction when passed a non-0-terminating string.\n\n[Previous contents:] Our convention today for the underlying buffer of a string, i.e., `_string.buff` (source), is that it is zero-terminated. Therefore, s.buffSize should be at least s.buffLen+1.\n\nNeither condition is checked in `createStringWithBorrowedBuffer(x: c_ptr(?t), length: int, size: int)` (source). Therefore users can invoke this function in a way that creates a string with our convention violated.\n\nThe test `test/library/standard/IO/readAll/readBytesArray.chpl` (source)does exactly that. It invokes createStringWithBorrowedBuffer() passing it a buffer of size 1032 and length == size == 1032. The violation of both conditions goes unnoticed because nothing in that test relies on the invariant to hold. Whether or not the string is 0-terminated is immaterial because the buffer `a_signed` does not have room for that final zero.\n\nIf we switch the test to invoke createBytesWithBorrowedBuffer(), it will have the same violation.\n\nChapel version: 4d5379da31","author_login":"vasslitvinov","author_association":"MEMBER","created_at":"2022-12-04T08:26:46+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1336348757","fragment_type":"issue_comment","sequence":1,"text":"We have the choice to introduce the checks in createStringWithBorrowedBuffer / createBytesWithBorrowedBuffer vs. `initWithBorrowedBuffer(ref x: ?t, other: bufferType, length:int, size:int)` (source) . I suggest the latter if it is user-facing. Note that the former (the string version) already validates for UTF8-ness.\n\nWe also have the choice to disable this validation upon --fast / --no-checks. I can go either way, given that it is constant-time. Although checking for the terminating zero may be a cache miss.","author_login":"vasslitvinov","author_association":"MEMBER","created_at":"2022-12-04T08:27:08+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336354583","fragment_type":"issue_comment","sequence":2,"text":"While there... we may want to optimize getHash() to return 0 if x.buffLen == 0 and countNumCodepoints() to return buffLen if it is <= 1, to avoid potentially going cross-locales in these cases.","author_login":"vasslitvinov","author_association":"MEMBER","created_at":"2022-12-04T09:03:12+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1337473319","fragment_type":"issue_comment","sequence":3,"text":"It's my understanding that we are trying to null-terminate all of our strings in memory, but I don't think it's necessarily the case that we should guarantee that property in a user-facing way.\n\nIn the long term, the main issue with null-terminating all strings in memory is that it prevents us from having a string slice that refers to another string's memory. (See also #11222 and #12670 about how we might one day add \"borrowed strings\" which would make this relevant). But, even in that case, if we are willing to add a bit to the string record, we could arrange for the string to manage allocating a copy of itself that is null terminated (and deleting it when the string is deleted). Relatedly, today we use `someString.localize().c_str()`; here the temporary copy of the string (if needed) is created because `someString.localize()` returns a new string by value. Perhaps we could generalize this pattern to effectively do `someString.localizeAndZeroTerminate().c_str()`.","author_login":"mppf","author_association":"MEMBER","created_at":"2022-12-05T14:32:28+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1338065066","fragment_type":"issue_comment","sequence":4,"text":"I updated the issue to determine whether we require null-termination and to adjust our implementation to comply with the answer.","author_login":"vasslitvinov","author_association":"MEMBER","created_at":"2022-12-05T19:45:55+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435446793","fragment_type":"issue_comment","sequence":5,"text":"Still catching up on December, I'm tagging @e-kayrakli as string-/bytes-master to get his read on this.","author_login":"bradcray","author_association":"MEMBER","created_at":"2023-02-18T01:48:54+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439058340","fragment_type":"issue_comment","sequence":6,"text":"I don't have strong opinions on the matter.\n\nFirst, I certainly hope that none of our methods on string/bytes rely on null-termination. I know that the way we have nulls at the end is a bit haphazard.\n\nSome cases where enforcing null-termination can be problematic:\n- As Michael pointed out string views can be a little difficult to implement when/if we need them,\n- Related but, cases where we want to borrow a part of a raw buffer as a Chapel string/bytes\n - e.g., here we don't get the null-terminator from qio interface, but it is fine. Should we allocate a new buffer and add null at the end? But that's not borrowing. So should we not be able to create \"borrowed\" strings: URL \n - e.g., do we need to avoid null-termination for exporting string/bytes arguments? I can't explain what's going on here, but it is another case where a non-null-terminated \"borrowed\" string is created: URL \n\nI don't think these cases are without solutions should we enforce null-termination. But the design around creating \"borrowed\" strings from raw data would have to change.\n\nHowever, having null-termination guarantee can make C interop easier. I am curious whether there's any internal case where we have to add/ensure null termination before calling an extern C function.","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2023-02-21T20:34:47+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439080692","fragment_type":"issue_comment","sequence":7,"text":"Arguably, `.c_str()` does rely on the string being null terminated.","author_login":"mppf","author_association":"MEMBER","created_at":"2023-02-21T20:55:51+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439205633","fragment_type":"issue_comment","sequence":8,"text":"True. I meant more from an algorithmic standpoint. We shouldn't be relying on a terminating null to determine the end of a string. It should all be based on the length.","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2023-02-21T23:03:35+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439215430","fragment_type":"issue_comment","sequence":9,"text":"Are you suggesting that it is OK for a Chapel string to lack the terminating 0? I am game for that. In this case, how to implement .c_str() ?","author_login":"vasslitvinov","author_association":"MEMBER","created_at":"2023-02-21T23:14:41+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439241061","fragment_type":"issue_comment","sequence":10,"text":"I was merely saying that the implementation of string algorithms do not rely on the null termination, but instead they work with the a priori knowledge of string's length.\n\nThinking about this more, one of the main points that I was thinking about is that `0x00` is legal UTF-8 byte ( URL Granted, it is only used for the null codepoint and no other codepoints. So, another way to ask the question this issue is asking is \"can Chapel strings contain `0x00` byte?\"\n\nCurrently, the answer to that question is \"yes\". This is consistent with python, which was the main example while we were converting our strings to unicode-only. However, this is not good for C interop, at least not today. `\"AAA\\x00AAA\"` will not be usable with C interop:\n\nchapel\nextern proc printf(s...);\nvar s = \"AAA\\x00AAA\";\n\nwriteln(s); // AAAAAA (my terminal doesn't show null bytes)\nprintf(\"%s\\n\", s.c_str()); // AAA\n\nOptions as far as I can see:\n\n1. Make an exception for `0x00` and not support it within Chapel strings\n **Con:** This might hurt python interop\n **Pro:** Better C interop\n\n2. We can make all our string null-terminate *and* keep a field as to whether the buffer contains `0x00`, in which case `c_str()` halts\n **Con:** Potentially costly, especially for `bytes` for which there is no validation today.\n **Pro:** Can interact with C and Python well\n\n3. Make `c_str` return a copy of the buffer with `0x00` filtered out except the terminating one\n **Con:** `c_str` will be costly\n **Pro:** Not breaking\n 3a. Same as 3, but do filtering only if a field like in (2) says the string contains null byte\n **Con:** Costly for `bytes`, like (2)\n **Pro:** Not breaking, not bad for `c_str` performance \n\n4. Keep the status quo\n **Con:** buggy C interop\n **Pro:** ?","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2023-02-21T23:55:06+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[500412725],"is_known_query_context":false},{"document_id":"gh_comment_1439345684","fragment_type":"issue_comment","sequence":11,"text":"Of those I'd go with the status quo. I think C programmers are used to the limitation that C strings cannot contain null bytes (other than the null terminator). They can use a pointer + length strategy when the code needs to handle nulls. We can support calling `extern procs` with a pointer + a length for our C strings (e.g. `c_ptrTo(myString)` can return a pointer to the buffer; and we have a function to get the length in bytes already, I think).\n\nI *am* suggesting that Chapel strings should not be required to always be null-terminated. My best ideas for adding the null for `.c_str()` are:\n 1. `someString.localizeAndZeroTerminate().c_str()` or\n 2. the proposal in #21233","author_login":"mppf","author_association":"MEMBER","created_at":"2023-02-22T02:22:42+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439417285","fragment_type":"issue_comment","sequence":12,"text":"Does it, or does it do a deep copy of the string? (at which point it could add the null). I was wondering about this while trying to figure out how Scott's NetCDF code today, and couldn't easily come to a conclusion by just reading the code, though it seemed like it might be a deep copy (unless `const` intent means `const in`, which I doubt).","author_login":"bradcray","author_association":"MEMBER","created_at":"2023-02-22T04:19:41+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439486091","fragment_type":"issue_comment","sequence":13,"text":"It does not. It returns the pointer to the beginner of the data buffer. It only casts it to `c_string`. (Where do you see `const`?)","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2023-02-22T06:06:04+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439506426","fragment_type":"issue_comment","sequence":14,"text":"The `const` was in Scott's blog article—I couldn't figure out how his code could work if something wasn't making a deep copy, either `.c_str()` or `const`.","author_login":"bradcray","author_association":"MEMBER","created_at":"2023-02-22T06:32:54+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2218134881","fragment_type":"issue_comment","sequence":15,"text":"closing as we decided to **not require** null termination on string/bytes buffers","author_login":"arezaii","author_association":"CONTRIBUTOR","created_at":"2024-07-09T16:24:39+08:00","repo_name":"chapel-lang/chapel","issue_id":1474596091,"issue_number":21160,"issue_url":"https://github.com/chapel-lang/chapel/issues/21160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_500412725","fragment_type":"issue_description","sequence":0,"text":"UTF-8 validation for strings\nChapel strings are UTF-8 encoded. However, currently we don't check whether a given byte buffer is a valid UTF-8 sequence while creating a string.\n\nThe general consensus is that we should add this check during string creation. Interestingly, doing so can allow us to cache some properties of the string (number of codepoints, whether it is all ASCII etc) to improve performance for some common operations.\n\nExactly when should we validate?\n--------------------------------\n\nThere are two main ways a string is generated in Chapel. String literals, and\nI/O. They both end up calling an appropriate string factory function at the end.\nSo there are two alternatives on implementing UTF-8 validation.\n\n1. String creation time: This is in the common path for both ways. So, it means\nless implementation and maintanance effort. Another benefit is that if we want\nto piggyback some metadata caching about the string (whether it is ASCII, or\nsome information about multibyte codepoints).\n\n2. Separately in I/O and parser: This has the advantage of giving an error early if\nnecessary. Arguably, long string literals are unlikely so maybe it doesn't make\nmuch difference for parsing string literals. But it may matter if you are\nreading a long file and there are invalid bytes right in the beginning. Another\nadvantage may be giving a compile time error if the source file contains strings\nliterals with non-UTF-8 bytes.\n\nGoing through some of the past discussions, it seems that the agreement was that\nwe are going with the first option.\n\nWhat is the behavior for when there are invalid bytes in a string?\n------------------------------------------------------------------\n\nIf we are going with option 1, then we'll need to throw an error. Currently we\nhave a `DecodeError` which is thrown when you attempt to decode a `bytes` with\ninvalid byte sequence to `string`. Should we use the same error type? Or do we\nsee UTF-8 validation as a different (more intrinsic to the language may be?)\nerror and should create a different error type.\n\nOne other alternative is to rename it so that it explains the issue more clearly\nfor either case. `StringDecodeError` can be an option and I don't think it'll\ncreate any confusion if it comes from `bytes.decode`\n\nShould we add a \"back door\"?\n----------------------------\n\nWe may consider allowing the users to opt out from validation. Most obviously\nthis can allow them to get rid of the validation overhead if they know the input\nstring to be UTF-8 in the first place. But can we support something like that\nfor string literals? If so how? We can consider adding an environment variable\nto control the overall behavior. This is also related to #12728 and to some \nextent adjusting the Chapel environment to use UTF-8 encoding.\n\nNote about NULL bytes\n------------------------\nNULL byte is valid ASCII and therefore UTF-8 and Chapel strings and bytes\ncurrently can contain NULL bytes. Strings will continue to do so even after\nvalidation is implemented. C (and maybe other) interoperability layers should\navoid using `strlen`, `strcmp` etc functions that rely on NULL-terminated\nstrings.\n\nCaveats\n-------\n\n- `string.localize()` creates a copy of the string. If the string was local to\n begin with, this is done through calling `createStringWithBorrowedBuffer`\n which re-validates the string. We may want to do something better than\n `localize` in the future. For now I see three alternatives:\n\n 1. If we do not have a back door, then, a string is validated already.\n Therefore, we don't call validate if `createStringWithBorrowedBuffer` is\n called with a `string`\n\n 2. If we add a back door, then, we should keep a `var valid: bool` in string\n record.\n\n 3. Do nothing and accept that we may validate a buffer that has already been\n validated. (I am not a big fan of this option)\n\n- It looks like the current QIO decode logic we have may not support some UTF-8\n sequences. This may need to be adjusted. One example that I bumped into is the\n replacement character `\\uFFFD`.","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2019-09-30T17:24:46+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_536664286","fragment_type":"issue_comment","sequence":1,"text":"#12723 suggests a test which can probably be part of this effort","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2019-09-30T17:26:47+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_545684505","fragment_type":"issue_comment","sequence":2,"text":"#14325 Makes some changes to the `bytes` implementation that are necessary for this to move forward","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2019-10-23T23:59:06+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_545908295","fragment_type":"issue_comment","sequence":3,"text":"Re where to validate:\n \n \n\nIt seems obvious to me that somebody creating a string literal containing invalid UTF-8 would want the error to occur at compile-time. Having program start-up fail and instead throw an error due to invalid UTF-8 in a literal seems unfortunate.\n\nHere I think that neither of the options presented are sufficient. I think that the compiler should arrange to call an internal/private function for the string literals which does not do validation. Other than that, I think that we should start by doing the validation in the string validation functions. Since not all string creating happens through I/O, this covers more cases than 2. describes.\n\nIn the future, we might have the I/O system take on the task of ensuring that any read data is valid UTF-8. Arguably it already tries to do that (but we would need to do more testing and make adjustments - the issue above already noted an issue with the UTF-8 replacement character). If that happens, I would expect the I/O system also to use an internal/private function to create the strings in a way that does not do validation in order to avoid redundancy. However, the user-facing string factory functions would still do validation in that event.\n\nSumming it up - I think validating in the string factory functions is a great starting point, and from there we should validate literals/param strings at compile-time and then validate read string data in the I/O code (and then arrange to avoid redundant validation if there is any benefit to doing so).","author_login":"mppf","author_association":"MEMBER","created_at":"2019-10-24T13:05:23+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_547036055","fragment_type":"issue_comment","sequence":4,"text":"I agree with what Michael says (and think it's consistent with `writef()/readf()` where ultimately we want to do more compile-time checking for param formatting strings, but having any checking is better than none).\n\nI don't think there should be a back door for users, but that having a \"prevalidated\" code path for internal use makes sense.\n\nI don't have a strong feeling about validating within the I/O system vs. at string creation time at present. Whatever we do, I'd like to not have to support three different string validation pieces of code. Ideally, they'd all use the same code (which might suggest doing the validation in C so that it can be reused in the compiler and via the runtime?).","author_login":"bradcray","author_association":"MEMBER","created_at":"2019-10-28T16:41:18+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_549477703","fragment_type":"issue_comment","sequence":5,"text":"Just to be clear, the following is not a back door (simply because it is not documented) right?\n\nchapel\nvar x: string;\nx.buff = my_c_arr_that_contains_non_utf8_sequences;\n\nArguably you can break many things if you play around with the internals of types and UTF8 validation will only be an example of that?\n\nI think more or less this is something that we can use internally to avoid redundant validation. For example, when we are returning from `bytes.decode()` we don't need to validate the string because we expect the decoded buffer to be valid utf8.","author_login":"e-kayrakli","author_association":"CONTRIBUTOR","created_at":"2019-11-04T18:08:57+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_549481738","fragment_type":"issue_comment","sequence":6,"text":"Right, I'm saying that I don't think the language should support an officially sanctioned back door (at least, I haven't been convinced of that yet). If we have one for our own development purposes, don't document it, and a user chooses to step into it, I don't think that's a problem (for us... it may be a problem for them if we change things down the road). In this case, I assume it's relying on the existence of a `.buff` member within string that is undocumented and therefore arguably being abused (?).","author_login":"bradcray","author_association":"MEMBER","created_at":"2019-11-04T18:18:23+08:00","repo_name":"chapel-lang/chapel","issue_id":500412725,"issue_number":14177,"issue_url":"https://github.com/chapel-lang/chapel/issues/14177","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0106","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Does this component support encryption and decryption for big data, Hive, hbase and other components?","query_context":"## Question\n\n**For English only**, other languages will not accept.\n\nBefore asking a question, make sure you have:\n\n- Googled your question.\n- Searched open and closed GitHub issues.\n- Read documentation: ShardingSphere Doc.\n\nPlease pay attention on issues you submitted, because we maybe need more details. \nIf no response anymore and we cannot reproduce it on current information, we will **close it**.","known_context_document_ids":["gh_issue_1380200488"],"reference_answer":"# Change Scope\nI check the documents and the source code, and I may miss something, feel free to let me know.\n## Parser\n### Add a new module shardingsphere-sql-parser-hbase\n- antlr4: don't need to write all rules, can add more rules if needed\n- hbase parser package: \n - `HBaseLexer` \n - `HBaseParser`\n - `HBaseParserFacade` \n- hbase visitor package: \n - `HBaseDMLStatementSQLVisitor`: only support DML in phase1\n - `HBaseStatementSQLVisitorFacade`\n- resources: HBase SPI config\n\n### Add a new package in shardingsphere-sql-parser-statement\nParse statements and segments\n\n## Add a new DataType\n- Implement `DatabaseType`\n- Implement `DialectTableMetaDataLoader`\n\n## Proxy\n- Implement `DatabaseProtocolFrontendEngine`\n- Implement `JDBCDriverURLRecognizer`\n\n# Questions\nI don't know if we can use some frameworks like Apache Phoenix to help us convert the SQL to HBase queries. But if we choose to use Apache Phoenix, it looks like shardingsphere only need to do a few things. Or shardingsphere has to \"compiles it into a series of HBase scans, and orchestrates the running of those scans to produce regular JDBC result sets\"","answer_document_id":"gh_comment_998815517","silver_evidence_path":["gh_comment_1253115429","gh_issue_1077742095","gh_comment_998815517"],"evidence_issue_ids":[1380200488,1077742095],"source_repo_name":"apache/shardingsphere","source_issue_id":1380200488,"source_issue_number":21101,"source_issue_url":"https://github.com/apache/shardingsphere/issues/21101","target_repo_name":"apache/shardingsphere","target_issue_id":1077742095,"target_issue_number":14061,"target_issue_url":"https://github.com/apache/shardingsphere/issues/14061","reference_anchor_document_id":"gh_comment_1253115429","reference_answer_author":"flycash","reference_answer_author_association":"MEMBER","quality_score":86.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.1923,"target_answer_overlap":0.1739},"issue_created_at":"2022-09-21T01:56:55+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1380200488","fragment_type":"issue_description","sequence":0,"text":"Does this component support encryption and decryption for big data, Hive, hbase and other components?\n## Question\n\n**For English only**, other languages will not accept.\n\nBefore asking a question, make sure you have:\n\n- Googled your question.\n- Searched open and closed GitHub issues.\n- Read documentation: ShardingSphere Doc.\n\nPlease pay attention on issues you submitted, because we maybe need more details. \nIf no response anymore and we cannot reproduce it on current information, we will **close it**.","author_login":"2013650523","author_association":"NONE","created_at":"2022-09-21T01:56:55+08:00","repo_name":"apache/shardingsphere","issue_id":1380200488,"issue_number":21101,"issue_url":"https://github.com/apache/shardingsphere/issues/21101","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1253115429","fragment_type":"issue_comment","sequence":1,"text":"- HBase should be allowed to use only SQL92, but such unit tests have never existed, nor have antlr4 files that deal with Hbase's proprietary syntax. \n\n- I think this issue is blocked by URL . If you're happy to submit some PRs to push for better unit tests, it may be resolved sooner.","author_login":"linghengqian","author_association":"CONTRIBUTOR","created_at":"2022-09-21T02:03:54+08:00","repo_name":"apache/shardingsphere","issue_id":1380200488,"issue_number":21101,"issue_url":"https://github.com/apache/shardingsphere/issues/21101","linked_issue_ids":[1077742095],"is_known_query_context":false},{"document_id":"gh_comment_1253122684","fragment_type":"issue_comment","sequence":2,"text":"I do not understand the principle of ShardingSphere. May I ask whether using ShardingSphere can achieve seamless interception of agents directly from the bottom layer, or do I need to change the service configuration or code to access the agent layer?","author_login":"2013650523","author_association":"NONE","created_at":"2022-09-21T02:17:03+08:00","repo_name":"apache/shardingsphere","issue_id":1380200488,"issue_number":21101,"issue_url":"https://github.com/apache/shardingsphere/issues/21101","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253128595","fragment_type":"issue_comment","sequence":3,"text":"- For a general RDBMS, ShardingSphere Proxy will virtualize a data source, and whether it uses the MySQL dialect or the PostgreSQL dialect depends on your choice. ShardingSphere JDBC does the same, but the dialect used depends on the connected database. \n\n- For HBase, I have the impression that the master branch never existed unit tests. For Apache Phoenix unit tests, everything with NoSQL is a bit unknown.","author_login":"linghengqian","author_association":"CONTRIBUTOR","created_at":"2022-09-21T02:28:02+08:00","repo_name":"apache/shardingsphere","issue_id":1380200488,"issue_number":21101,"issue_url":"https://github.com/apache/shardingsphere/issues/21101","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1407599889","fragment_type":"issue_comment","sequence":4,"text":"This issue has been inactive for a long time, so I will close it.\nPlease pay attention to #14061 for future updates.","author_login":"RaigorJiang","author_association":"CONTRIBUTOR","created_at":"2023-01-29T08:39:47+08:00","repo_name":"apache/shardingsphere","issue_id":1380200488,"issue_number":21101,"issue_url":"https://github.com/apache/shardingsphere/issues/21101","linked_issue_ids":[1077742095],"is_known_query_context":false},{"document_id":"gh_issue_1077742095","fragment_type":"issue_description","sequence":0,"text":"shardingSphere For HBase\n## Feature Request\n\nIt is hoped that proxy is the only SQL entry. Businesses only need to access proxy and deal with various databases later. For example, HBase is supported. In the process of use, there is no need to use HBase protocol to operate the back-end database\n### Describe the feature you would like.\nSupport SQL statements\n\nSQL HBase\nshow /*+ hbase */ databases -> cluster\nshow /*+ hbase */ tables -> list\nshow /*+ hbase */ create table t_test -> describe \"t_test\"\nselect /*+ hbase */ * from t_test -> scan \"t_test\"\nselect /*+ hbase */ count(*) from t_test -> count \"t_test\" \nupdate /*+ hbase */ t_test set age = 18 where rowKey = 1 -> put \"t_test\" \ndelete /*+ hbase */ from t_test -> deleteall \"t_test\"\ninsert /*+ hbase */ into t_test (rowKey, v1, v2) values(1, 2, 3) -> put \"t_test\",1,'rowKey:v1', 3\n...","author_login":"galaxylqx","author_association":"CONTRIBUTOR","created_at":"2021-12-12T07:55:14+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_991853318","fragment_type":"issue_comment","sequence":1,"text":"Great! \nIt is very exciting to explore OLAP integrate with ShardingSphere.","author_login":"terrymanu","author_association":"MEMBER","created_at":"2021-12-12T08:17:02+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_991858436","fragment_type":"issue_comment","sequence":2,"text":"I'd like to join building this feature. But it's a big feature, can you guys help to split it into several tasks? So I can help to do these tasks step by step.","author_login":"flycash","author_association":"MEMBER","created_at":"2021-12-12T08:59:52+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_991893116","fragment_type":"issue_comment","sequence":3,"text":"Some initial tasks:\n\n1. SQL parser of HBase SQL dialect\n2. Recognize HBase JDBC url and driver\n3. Parse hint by `/+ hbase */` from SQL\n4. Route hinted SQL to HBase cluster\n\nWe can complete the more tasks here.","author_login":"terrymanu","author_association":"MEMBER","created_at":"2021-12-12T12:52:37+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_992588579","fragment_type":"issue_comment","sequence":4,"text":"ok, I will try the first task, but it's a hard job for me, so it will take some time.","author_login":"flycash","author_association":"MEMBER","created_at":"2021-12-13T15:23:47+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_998815517","fragment_type":"issue_comment","sequence":5,"text":"# Change Scope\nI check the documents and the source code, and I may miss something, feel free to let me know.\n## Parser\n### Add a new module shardingsphere-sql-parser-hbase\n- antlr4: don't need to write all rules, can add more rules if needed\n- hbase parser package: \n - `HBaseLexer` \n - `HBaseParser`\n - `HBaseParserFacade` \n- hbase visitor package: \n - `HBaseDMLStatementSQLVisitor`: only support DML in phase1\n - `HBaseStatementSQLVisitorFacade`\n- resources: HBase SPI config\n\n### Add a new package in shardingsphere-sql-parser-statement\nParse statements and segments\n\n## Add a new DataType\n- Implement `DatabaseType`\n- Implement `DialectTableMetaDataLoader`\n\n## Proxy\n- Implement `DatabaseProtocolFrontendEngine`\n- Implement `JDBCDriverURLRecognizer`\n\n# Questions\nI don't know if we can use some frameworks like Apache Phoenix to help us convert the SQL to HBase queries. But if we choose to use Apache Phoenix, it looks like shardingsphere only need to do a few things. Or shardingsphere has to \"compiles it into a series of HBase scans, and orchestrates the running of those scans to produce regular JDBC result sets\"","author_login":"flycash","author_association":"MEMBER","created_at":"2021-12-21T14:17:36+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1007099722","fragment_type":"issue_comment","sequence":6,"text":"Yes, we can use Apache Phoenix to convert the SQL if needed.\nCould you provide the design if we using Apache Phoenix in ShardingSphere?","author_login":"terrymanu","author_association":"MEMBER","created_at":"2022-01-07T02:53:58+08:00","repo_name":"apache/shardingsphere","issue_id":1077742095,"issue_number":14061,"issue_url":"https://github.com/apache/shardingsphere/issues/14061","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0107","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Cannot add liquidity with asymmetric ratio?","query_context":"Give a description of the bug! Include things like how to reproduce it, what you expected to happen, and what actually happened.\n\nCannot add to pool ROWAN/UFO. \"There was an unknown error.\" Error failed to execute message; message index: 0: Cannot add liquidity with asymmetric ratio.","known_context_document_ids":["gh_issue_1322946989"],"reference_answer":"closing as asymmetric adds are currently disabled. Flat fees is introduced in order to re-enable asymmetric adds. The issue is not expected to appear once asymmetric adds are re-enabled","answer_document_id":"gh_comment_1233176242","silver_evidence_path":["gh_comment_1200126109","gh_issue_1267796922","gh_comment_1233176242"],"evidence_issue_ids":[1322946989,1267796922],"source_repo_name":"Sifchain/Support-Tickets","source_issue_id":1322946989,"source_issue_number":401,"source_issue_url":"https://github.com/Sifchain/Support-Tickets/issues/401","target_repo_name":"Sifchain/Support-Tickets","target_issue_id":1267796922,"target_issue_number":389,"target_issue_url":"https://github.com/Sifchain/Support-Tickets/issues/389","reference_anchor_document_id":"gh_comment_1200126109","reference_answer_author":"lufa23","reference_answer_author_association":"COLLABORATOR","quality_score":94.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.4167,"target_answer_overlap":0.0625},"issue_created_at":"2022-07-30T09:28:52+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1322946989","fragment_type":"issue_description","sequence":0,"text":"Cannot add liquidity with asymmetric ratio\nGive a description of the bug! Include things like how to reproduce it, what you expected to happen, and what actually happened.\n\nCannot add to pool ROWAN/UFO. \"There was an unknown error.\" Error failed to execute message; message index: 0: Cannot add liquidity with asymmetric ratio.","author_login":"sifchain-support-bot","author_association":"NONE","created_at":"2022-07-30T09:28:52+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1322946989,"issue_number":401,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/401","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1200124134","fragment_type":"issue_comment","sequence":1,"text":"hey, can you try again? it's a known issue, and it's due to the fact that we disabled asymmetric adds","author_login":"lufa23","author_association":"COLLABORATOR","created_at":"2022-07-30T09:29:47+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1322946989,"issue_number":401,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200126109","fragment_type":"issue_comment","sequence":2,"text":"this is the same issue as:\n395 and 389.\n\nWhat's our strategy here? @bksifchain (My understanding is that we won't re-enable asymmetric liquidity adds anytime soon)","author_login":"lufa23","author_association":"COLLABORATOR","created_at":"2022-07-30T09:45:33+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1322946989,"issue_number":401,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/401","linked_issue_ids":[1267796922],"is_known_query_context":false},{"document_id":"gh_comment_1200126966","fragment_type":"issue_comment","sequence":3,"text":"@hungng157 i have flagged this issue on the **eng-support** slack channel","author_login":"lufa23","author_association":"COLLABORATOR","created_at":"2022-07-30T09:52:37+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1322946989,"issue_number":401,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1267796922","fragment_type":"issue_description","sequence":0,"text":"Unable to add Liquidity Addition on Cosmostation\n**Description:**\nUnable to add liquidity symmetrically in Cosmostation for the SHIB pool, as an error log is triggered as the liquidity addition is asymmetric\nScreenshot_20220610-015152\n\n**Ways to reproduce it:**\nAdding liquidity symmetrically on the SHIB - ROWAN pool","author_login":"sifchain-support-bot","author_association":"NONE","created_at":"2022-06-10T16:57:55+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1267796922,"issue_number":389,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173971227","fragment_type":"issue_comment","sequence":1,"text":"the enabling of asymmetric liquidity adds is on pause at the moment. To tackle this issue, it is suggested to try multiple times","author_login":"lufa23","author_association":"COLLABORATOR","created_at":"2022-07-04T16:07:17+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1267796922,"issue_number":389,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1222260407","fragment_type":"issue_comment","sequence":2,"text":"to check if Formula has been updated in order to tackle the issue for Low Liquidity Pools","author_login":"lufa23","author_association":"COLLABORATOR","created_at":"2022-08-22T12:04:07+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1267796922,"issue_number":389,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/389","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1233176242","fragment_type":"issue_comment","sequence":3,"text":"closing as asymmetric adds are currently disabled. Flat fees is introduced in order to re-enable asymmetric adds. The issue is not expected to appear once asymmetric adds are re-enabled","author_login":"lufa23","author_association":"COLLABORATOR","created_at":"2022-08-31T16:43:34+08:00","repo_name":"Sifchain/Support-Tickets","issue_id":1267796922,"issue_number":389,"issue_url":"https://github.com/Sifchain/Support-Tickets/issues/389","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0108","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[New game]: ShootOut?","query_context":"### 🎮 Game Request\n\nThis is a one-player shooting game made with HTML, CSS, and JavaScript. You will get four difficulty levels, and with each increasing difficulty, the speed and number of enemies will increase. With the help of three different weapons, you can kill enemies and score points. According to the number of enemies killed and weapons used score will be awarded.\n \nI am further looking to improve this game but as of now I want to contribute this to GameZone \n\n### Point down the features\n\n- Made with HTML, CSS, and JavaScript. \n- Animations and Sound Effects\n- Four different difficulty levels\n- Three different weapons\n- Score Board \n\n### Select program in which you are contributing\n\nGSSoC23\n\n### Code of Conduct\n\n- [X] I follow CONTRIBUTING GUIDELINE of this project.","known_context_document_ids":["gh_issue_1788862578"],"reference_answer":"Hey @kunjgit ! Thank you so much for your raising the issue💗 \n It’s all yours, you can come anytime again and make some contributions! 🚀 \n Alone, we can do little, but together we can do so much! 😇","answer_document_id":"gh_comment_1851204988","silver_evidence_path":["gh_comment_1744307759","gh_issue_1923331532","gh_comment_1851204988"],"evidence_issue_ids":[1788862578,1923331532],"source_repo_name":"kunjgit/GameZone","source_issue_id":1788862578,"source_issue_number":2276,"source_issue_url":"https://github.com/kunjgit/GameZone/issues/2276","target_repo_name":"kunjgit/GameZone","target_issue_id":1923331532,"target_issue_number":2944,"target_issue_url":"https://github.com/kunjgit/GameZone/issues/2944","reference_anchor_document_id":"gh_comment_1744307759","reference_answer_author":"kunjgit","reference_answer_author_association":"OWNER","quality_score":89.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.2692,"target_answer_overlap":0.1176},"issue_created_at":"2023-07-05T06:29:24+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1788862578","fragment_type":"issue_description","sequence":0,"text":"[New game]: ShootOut\n### 🎮 Game Request\n\nThis is a one-player shooting game made with HTML, CSS, and JavaScript. You will get four difficulty levels, and with each increasing difficulty, the speed and number of enemies will increase. With the help of three different weapons, you can kill enemies and score points. According to the number of enemies killed and weapons used score will be awarded.\n \nI am further looking to improve this game but as of now I want to contribute this to GameZone \n\n### Point down the features\n\n- Made with HTML, CSS, and JavaScript. \n- Animations and Sound Effects\n- Four different difficulty levels\n- Three different weapons\n- Score Board \n\n### Select program in which you are contributing\n\nGSSoC23\n\n### Code of Conduct\n\n- [X] I follow CONTRIBUTING GUIDELINE of this project.","author_login":"apurva-1403","author_association":"NONE","created_at":"2023-07-05T06:29:24+08:00","repo_name":"kunjgit/GameZone","issue_id":1788862578,"issue_number":2276,"issue_url":"https://github.com/kunjgit/GameZone/issues/2276","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1621108747","fragment_type":"issue_comment","sequence":1,"text":"Hey @apurva-1403 ! \n Thank you for raising an issue 💗 \n You can self assign the issue by commenting /assign in comment 😀 \n Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀 \n Don’t Forget to ⭐ our GameZone🎮\n Make sure you join our Discord🕹️","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-07-05T06:29:59+08:00","repo_name":"kunjgit/GameZone","issue_id":1788862578,"issue_number":2276,"issue_url":"https://github.com/kunjgit/GameZone/issues/2276","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1733377824","fragment_type":"issue_comment","sequence":2,"text":"Hey @apurva-1403 👋!\n \n @kunjgit here, \n Hope you are doing extremely well 😇 \n It's confirmed 🥳, GameZone is taking part in hacktoberfest and ready to have another 💥 \n Ready to have some amazing contributions once again also thank you for you support in GSSoC23 you have took us on top 5 ❤️‍🔥 \n if you still haven't joined us join us on ⁠Discord \n See you soon 😊","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-09-25T10:19:45+08:00","repo_name":"kunjgit/GameZone","issue_id":1788862578,"issue_number":2276,"issue_url":"https://github.com/kunjgit/GameZone/issues/2276","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744307759","fragment_type":"issue_comment","sequence":3,"text":"Hey @apurva-1403 👋!\n \n @kunjgit here, \n Hope you are enjoying this hacktober 😀 \n We are excited to share that we are opening issue from our side where you will be going to add games on our website 🚀 \n Work on this issue 🔥 \n and help us building GameZone 💗 \n if you still haven't joined us join us on ⁠Discord \n See you soon 😊","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-10-03T06:45:45+08:00","repo_name":"kunjgit/GameZone","issue_id":1788862578,"issue_number":2276,"issue_url":"https://github.com/kunjgit/GameZone/issues/2276","linked_issue_ids":[1923331532],"is_known_query_context":false},{"document_id":"gh_comment_1902524378","fragment_type":"issue_comment","sequence":4,"text":"Hello @apurva-1403, Time's Uppp!⏰ \n Sorry for closing your issue! \n But it's more than a week since we haven't received anything from your side 😢 . \n Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥 \n All the best! 🚀 \n Happy Hacking! 💗","author_login":"kunjgit","author_association":"OWNER","created_at":"2024-01-21T05:54:49+08:00","repo_name":"kunjgit/GameZone","issue_id":1788862578,"issue_number":2276,"issue_url":"https://github.com/kunjgit/GameZone/issues/2276","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1902524434","fragment_type":"issue_comment","sequence":5,"text":"Hey @apurva-1403 ! Thank you so much for your raising the issue💗 \n It’s all yours, you can come anytime again and make some contributions! 🚀 \n Alone, we can do little, but together we can do so much! 😇","author_login":"kunjgit","author_association":"OWNER","created_at":"2024-01-21T05:55:02+08:00","repo_name":"kunjgit/GameZone","issue_id":1788862578,"issue_number":2276,"issue_url":"https://github.com/kunjgit/GameZone/issues/2276","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1923331532","fragment_type":"issue_description","sequence":0,"text":"[Enhancement]: Adding Games on Website 🔥\n### **You have to add all the games which is there on GameZone and not added in website :smile:** \nStep to complete this task :blush: \n\n1. Finding all the data of games that are not added in website till the time you are adding it (you have to refer included_games and also the README )\n2. Getting the data of games through the pr they made to add that game (tip just refer to that game you will find the pr )\n3. Extracting the data for each game you want to add and add it in the GameData\n\n\"1\": {\n \"gameTitle\": \"Master Typing\",\n \"gameUrl\": \"Master_Typing\",\n \"thumbnailUrl\": \"Master_Typing.webp\"\n },\n\n- make sure you are adding the image and gameurl properly there \n\n4. update the counter value in card_generator\n5. **run everything locally and check website for the same and make sure that everything is working perfectly** :fire: \n\nAnd.......................... you are good to goo :partying_face: \nmake a PR for the same and we will review and merge it sooonnnnn :rocket:","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-10-03T05:18:16+08:00","repo_name":"kunjgit/GameZone","issue_id":1923331532,"issue_number":2944,"issue_url":"https://github.com/kunjgit/GameZone/issues/2944","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744227778","fragment_type":"issue_comment","sequence":1,"text":"Hey @kunjgit ! \n Thank you for raising an issue 💗 \n You can self assign the issue by commenting /assign in comment 😀 \n Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀 \n Don’t Forget to ⭐ our GameZone🎮\n Make sure you join our Discord🕹️","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-10-03T05:18:50+08:00","repo_name":"kunjgit/GameZone","issue_id":1923331532,"issue_number":2944,"issue_url":"https://github.com/kunjgit/GameZone/issues/2944","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744306999","fragment_type":"issue_comment","sequence":2,"text":"Hey @kunjgit 👋!\n \n @kunjgit here, \n Hope you are enjoying this hacktober 😀 \n We are excited to share that we are opening issue from our side where you will be going to add games on our website 🚀 \n Work on this issue 🔥 \n and help us building GameZone 💗 \n if you still haven't joined us join us on ⁠Discord \n See you soon 😊","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-10-03T06:45:02+08:00","repo_name":"kunjgit/GameZone","issue_id":1923331532,"issue_number":2944,"issue_url":"https://github.com/kunjgit/GameZone/issues/2944","linked_issue_ids":[1923331532],"is_known_query_context":false},{"document_id":"gh_comment_1851204988","fragment_type":"issue_comment","sequence":3,"text":"Hey @kunjgit ! Thank you so much for your raising the issue💗 \n It’s all yours, you can come anytime again and make some contributions! 🚀 \n Alone, we can do little, but together we can do so much! 😇","author_login":"kunjgit","author_association":"OWNER","created_at":"2023-12-12T02:30:50+08:00","repo_name":"kunjgit/GameZone","issue_id":1923331532,"issue_number":2944,"issue_url":"https://github.com/kunjgit/GameZone/issues/2944","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0109","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Community Standards?","query_context":"I just stumbled upon the Community Standards page of this repository. There are some good ideas in there (which we already want to implement @MatteoSalvador, @alisonmarsden), with examples:\n- Code of conduct\n- Contributing (in addition to the examples we have from openCARP and OpenFoam)\n- Issue templates\n- Pull request template\n\nWe can start adding those to this repository and then adapt them for \"larger\" projects (like `svFSI+/-`).","known_context_document_ids":["gh_issue_1916572696"],"reference_answer":"Yes, please!\n \n\nThey come up now when you open a new issue or pull request. You can give it a try and just click through it without adding anything.\n \n\nI'm all for it! Unfortunately, we have ~1500 Doxygen warning in `svFSI+` so we can't do that anytime soon. But we could try implementing something that the number of warnings must go down in every pull request.\n\nWe could do the same for coverage. StanfordSpezi uses Codecov, which @MatteoSalvador and I briefly looked into. However, it's only free for public repositories (`svFSI+` is still private).","answer_document_id":"gh_comment_1753268323","silver_evidence_path":["gh_comment_1751477653","gh_issue_1909635083","gh_comment_1753268323"],"evidence_issue_ids":[1916572696,1909635083],"source_repo_name":"StanfordCBCL/svZeroDPlus","source_issue_id":1916572696,"source_issue_number":47,"source_issue_url":"https://github.com/StanfordCBCL/svZeroDPlus/issues/47","target_repo_name":"SimVascular/simvascular.github.io","target_issue_id":1909635083,"target_issue_number":8,"target_issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","reference_anchor_document_id":"gh_comment_1751477653","reference_answer_author":"mrp089","reference_answer_author_association":"MEMBER","quality_score":84.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2727,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2023-09-28T01:38:16+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1916572696","fragment_type":"issue_description","sequence":0,"text":"Community Standards\nI just stumbled upon the Community Standards page of this repository. There are some good ideas in there (which we already want to implement @MatteoSalvador, @alisonmarsden), with examples:\n- Code of conduct\n- Contributing (in addition to the examples we have from openCARP and OpenFoam)\n- Issue templates\n- Pull request template\n\nWe can start adding those to this repository and then adapt them for \"larger\" projects (like `svFSI+/-`).","author_login":"mrp089","author_association":"MEMBER","created_at":"2023-09-28T01:38:16+08:00","repo_name":"StanfordCBCL/svZeroDPlus","issue_id":1916572696,"issue_number":47,"issue_url":"https://github.com/StanfordCBCL/svZeroDPlus/issues/47","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1740116567","fragment_type":"issue_comment","sequence":1,"text":"Yes agreed - we can develop these here and then migrate to other projects.","author_login":"alisonmarsden","author_association":"NONE","created_at":"2023-09-28T23:20:40+08:00","repo_name":"StanfordCBCL/svZeroDPlus","issue_id":1916572696,"issue_number":47,"issue_url":"https://github.com/StanfordCBCL/svZeroDPlus/issues/47","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1751477653","fragment_type":"issue_comment","sequence":2,"text":"Closing this. Community standards will automatically be adopted once this repository moves to URL (see URL","author_login":"mrp089","author_association":"MEMBER","created_at":"2023-10-06T22:47:55+08:00","repo_name":"StanfordCBCL/svZeroDPlus","issue_id":1916572696,"issue_number":47,"issue_url":"https://github.com/StanfordCBCL/svZeroDPlus/issues/47","linked_issue_ids":[1909635083],"is_known_query_context":false},{"document_id":"gh_issue_1909635083","fragment_type":"issue_description","sequence":0,"text":"Add developer guidelines to the website\nWe need to a page to the website covering guidelines for developers and contributors to SimVascular. This should include: \n1) code of conduct \n2) contribution guidelines","author_login":"alisonmarsden","author_association":"NONE","created_at":"2023-09-23T00:10:28+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1751477180","fragment_type":"issue_comment","sequence":1,"text":"I added the following Community Standards:\n- Code of conduct\n- Contributing guidelines\n- Issue templates\n- Pull request template\n- Introduction to SimVascular GitHub\n- License\n\nPlease have a look, @alisonmarsden, @MatteoSalvador, @menon-karthik, @ktbolt. These are meant to be a first draft so we have something to start with. The files can be easily edited in the browser.\n\nThe files are all in a separate .github repository within SimVascular. This way, all repositories default to those standards (but can overwrite them with their own).\n\nAll files are heavily inspired by BioDesign's StanfordSpezi software project (with community files here). **Many thanks to @PSchmiedmayer for the inspiration and GitHub guidance!** 😄","author_login":"mrp089","author_association":"MEMBER","created_at":"2023-10-06T22:47:01+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1751767357","fragment_type":"issue_comment","sequence":2,"text":"It will be great to have these up on our website before the CZ software grant is due on Oct 17th. This is one of the items they ask about.\n\nFrom: Martin R. Pfaller ***@***.***>\nDate: Friday, October 6, 2023 at 3:47 PM\nTo: SimVascular/simvascular.github.io ***@***.***>\nCc: Alison Lesley Marsden ***@***.***>, Mention ***@***.***>\nSubject: Re: [SimVascular/simvascular.github.io] Add developer guidelines to the website (Issue #8)\n\nI added the following Community Standards:\n\n * Code of conduct","author_login":"alisonmarsden","author_association":"NONE","created_at":"2023-10-07T16:47:06+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[1909635083],"is_known_query_context":false},{"document_id":"gh_comment_1751825712","fragment_type":"issue_comment","sequence":3,"text":"I will rewrite the `Contributing Guidelines` , get rid of all this\n\nThe keywords \"MUST\", \"MUST NOT\", \"REQUIRED\", \"SHALL\", \"SHALL NOT\", \"SHOULD\", \"SHOULD NOT\", \"RECOMMENDED\", \"MAY\", and \"OPTIONAL\" in this document are to be interpreted as described in [RFC 2119]\n\nand remove all of the words using all capital letters like `MUST` below\n\nYou MUST follow our Code of Conduct.\n\nwriting in all capital letters is like shouting","author_login":"ktbolt","author_association":"CONTRIBUTOR","created_at":"2023-10-07T21:50:24+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1752207710","fragment_type":"issue_comment","sequence":4,"text":"Thanks @mrp089! I went through all the community standards. I just have a few suggestions for the moment:\n- **Issue templates:** it might be useful to give the possibility to the user to attach several types of files (pictures, scripts, meshes, `XML` configurations) in order to ease the bug fixing process.\n- **Pull request templates:** I would clearly state that adding tests for each new feature implemented is mandatory. I would also mention the importance of code coverage during testing, which should ideally always increase after any PR.\n- **License:** I have always reported this type of MIT license at the beginning of each `.h`/`.cpp` file. I am particularly referring to the sentence \n \n\nI am of course happy to keep discussing this!","author_login":"MatteoSalvador","author_association":"NONE","created_at":"2023-10-09T00:25:10+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1752222185","fragment_type":"issue_comment","sequence":5,"text":"This looks like a really great first draft @mrp089, thanks for doing this! \n\nI noticed some typos in the `Contributing Guidelines`. Should the rest of us fork/edit/merge the usual way or does this repository work differently?\n\nAbout the issue and pull request templates, this is probably just me being dumb, but it's not clear to me how this actually works. When a new pull request/issue is created does it automatically open up in the specified template format for the user or does a user have to do something to get that format? If the latter, maybe we should provide instructions.\n\nI like @MatteoSalvador's idea about adding specific instructions for tests and code coverage, but I also think we should actually enforce it by using Doxygen to prevent merging undocumented code. And mention that we are doing this in the instructions. See discussion here. What does everyone else think?","author_login":"menon-karthik","author_association":"MEMBER","created_at":"2023-10-09T00:59:55+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1753249881","fragment_type":"issue_comment","sequence":6,"text":"Thank you very much for the constructive feedback, @MatteoSalvador and @menon-karthik! I'll add my replies below. I'm closing this issue so we can continue the discussion in URL \n\n@alisonmarsden, I've added a brief `Contributing` section to the SimVascular homepage and linked the Contributing Guidelines and the Code of Conduct (#10).","author_login":"mrp089","author_association":"MEMBER","created_at":"2023-10-09T15:42:36+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1753259494","fragment_type":"issue_comment","sequence":7,"text":"Great idea, please add!\n \n\nAlso great idea, please add!\n \n \n \n \n \n\nHappy to discuss in URL","author_login":"mrp089","author_association":"MEMBER","created_at":"2023-10-09T15:48:59+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1753268323","fragment_type":"issue_comment","sequence":8,"text":"Yes, please!\n \n\nThey come up now when you open a new issue or pull request. You can give it a try and just click through it without adding anything.\n \n\nI'm all for it! Unfortunately, we have ~1500 Doxygen warning in `svFSI+` so we can't do that anytime soon. But we could try implementing something that the number of warnings must go down in every pull request.\n\nWe could do the same for coverage. StanfordSpezi uses Codecov, which @MatteoSalvador and I briefly looked into. However, it's only free for public repositories (`svFSI+` is still private).","author_login":"mrp089","author_association":"MEMBER","created_at":"2023-10-09T15:54:21+08:00","repo_name":"SimVascular/simvascular.github.io","issue_id":1909635083,"issue_number":8,"issue_url":"https://github.com/SimVascular/simvascular.github.io/issues/8","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0110","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Backend tests with the \"force-dynamic\" mode are not executed by \"cmake check-onnx-backend-dynamic\"?","query_context":"(Updated in March 6th, 2024)\nCurrently \"make check-onnx-backend-dynamic\" does not test dynamic cases but tests static cases, because \"test/backend/common.py\" sets the \"TEST_IMPORTER_FORCE_DYNAMIC\" environment variable, but \"test/backend/variables.py\" does not process it.\n\nPR#2735 fixes this issue, and dynamic backend tests are enabled.\nIt also disabled the following 27 backend tests to pass the Jenkins backend tests temporally.\n\nYour supports to fix these issues are very welcome!\nIf you fix some issues or find some unnecessary tests, please report the results at this Issue. Thanks.\n\n1. test_instancenorm_epsilon_cpu\n2. test_instancenorm_example_cpu\n3. test_gathernd_example_float32_cpu\n4. test_gathernd_example_int32_batch_dim1_cpu\n5. test_gathernd_example_int32_cpu\n6. test_castlike_DOUBLE_to_FLOAT_cpu\n7. test_castlike_FLOAT_to_DOUBLE_cpu\n8. test_convtranspose_3d_cpu\n9. test_convtranspose_cpu\n10. test_constant_pad_cpu\n11. test_convtranspose_pad_cpu\n12. test_convtranspose_kernel_shape_cpu\n13. test_convtranspose_output_shape_cpu\n14. test_einsum_transpose_cpu\n15. test_einsum_inner_prod_cpu\n16. test_depthtospace_example_cpu\n17. test_convtranspose_1d_cpu\n18. test_convtranspose_dilations_cpu\n19. test_convtranspose_autopad_same_cpu\n20. test_convtranspose_pads_cpu\n21. test_einsum_batch_diagonal_cpu\n22. test_depthtospace_crd_mode_example_cpu\n23. test_einsum_batch_matmul_cpu\n24. test_einsum_sum_cpu\n25. test_edge_pad_cpu\n26. ~~test_onnxmlir_top_k_float16_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic.\n27. ~~test_onnxmlir_top_k_smallest_float16_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic\n28. test_reflect_pad_cpu\n29. test_spacetodepth_example_cpu\n30. ~~test_top_k_smallest_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic\n31. ~~test_top_k_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic\n32. ~~test_top_k_negative_axis_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic","known_context_document_ids":["gh_issue_2009083033"],"reference_answer":"I am closing this issue, since ll issues errors with dynamic backend tests (on CPU) are fixed. Thanks!","answer_document_id":"gh_comment_2099520818","silver_evidence_path":["gh_comment_1982231896","gh_issue_2172819255","gh_comment_2099520818"],"evidence_issue_ids":[2009083033,2172819255],"source_repo_name":"onnx/onnx-mlir","source_issue_id":2009083033,"source_issue_number":2639,"source_issue_url":"https://github.com/onnx/onnx-mlir/issues/2639","target_repo_name":"onnx/onnx-mlir","target_issue_id":2172819255,"target_issue_number":2743,"target_issue_url":"https://github.com/onnx/onnx-mlir/issues/2743","reference_anchor_document_id":"gh_comment_1982231896","reference_answer_author":"negiyas","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.4,"anchor_target_overlap":0.4,"target_answer_overlap":0.9091},"issue_created_at":"2023-11-24T04:37:02+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2009083033","fragment_type":"issue_description","sequence":0,"text":"Backend tests with the \"force-dynamic\" mode are not executed by \"cmake check-onnx-backend-dynamic\"\n(Updated in March 6th, 2024)\nCurrently \"make check-onnx-backend-dynamic\" does not test dynamic cases but tests static cases, because \"test/backend/common.py\" sets the \"TEST_IMPORTER_FORCE_DYNAMIC\" environment variable, but \"test/backend/variables.py\" does not process it.\n\nPR#2735 fixes this issue, and dynamic backend tests are enabled.\nIt also disabled the following 27 backend tests to pass the Jenkins backend tests temporally.\n\nYour supports to fix these issues are very welcome!\nIf you fix some issues or find some unnecessary tests, please report the results at this Issue. Thanks.\n\n1. test_instancenorm_epsilon_cpu\n2. test_instancenorm_example_cpu\n3. test_gathernd_example_float32_cpu\n4. test_gathernd_example_int32_batch_dim1_cpu\n5. test_gathernd_example_int32_cpu\n6. test_castlike_DOUBLE_to_FLOAT_cpu\n7. test_castlike_FLOAT_to_DOUBLE_cpu\n8. test_convtranspose_3d_cpu\n9. test_convtranspose_cpu\n10. test_constant_pad_cpu\n11. test_convtranspose_pad_cpu\n12. test_convtranspose_kernel_shape_cpu\n13. test_convtranspose_output_shape_cpu\n14. test_einsum_transpose_cpu\n15. test_einsum_inner_prod_cpu\n16. test_depthtospace_example_cpu\n17. test_convtranspose_1d_cpu\n18. test_convtranspose_dilations_cpu\n19. test_convtranspose_autopad_same_cpu\n20. test_convtranspose_pads_cpu\n21. test_einsum_batch_diagonal_cpu\n22. test_depthtospace_crd_mode_example_cpu\n23. test_einsum_batch_matmul_cpu\n24. test_einsum_sum_cpu\n25. test_edge_pad_cpu\n26. ~~test_onnxmlir_top_k_float16_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic.\n27. ~~test_onnxmlir_top_k_smallest_float16_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic\n28. test_reflect_pad_cpu\n29. test_spacetodepth_example_cpu\n30. ~~test_top_k_smallest_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic\n31. ~~test_top_k_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic\n32. ~~test_top_k_negative_axis_cpu~~ # Test condition fixed. K should be a1D tensor, cannot be dynamic","author_login":"negiyas","author_association":"COLLABORATOR","created_at":"2023-11-24T04:37:02+08:00","repo_name":"onnx/onnx-mlir","issue_id":2009083033,"issue_number":2639,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2639","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1977731039","fragment_type":"issue_comment","sequence":1,"text":"@cjvolzka GroupnormalizeOp was just an error example. Other tests also failed before the PR#2725, too.","author_login":"negiyas","author_association":"COLLABORATOR","created_at":"2024-03-05T00:34:11+08:00","repo_name":"onnx/onnx-mlir","issue_id":2009083033,"issue_number":2639,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2639","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1982231896","fragment_type":"issue_comment","sequence":2,"text":"Closing this issue, because it is replaced by a new Issue #2743.","author_login":"negiyas","author_association":"COLLABORATOR","created_at":"2024-03-07T02:38:28+08:00","repo_name":"onnx/onnx-mlir","issue_id":2009083033,"issue_number":2639,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2639","linked_issue_ids":[2172819255],"is_known_query_context":false},{"document_id":"gh_issue_2172819255","fragment_type":"issue_description","sequence":0,"text":"Dynamic backend tests cause errors.\n(Updated in 2024/05/08)\nAll issues errors with dynamic backend tests (on CPU) are fixed. Thanks!\n\n(Updated in 2024/03/26)\n\nPR #2735 enables dynamic backend tests, but the following backend tests still fail.\nAccordingly PR #2735 temporally disables these failed dynamic backend tests to pass the Jenkins tests.\n\nPlease look at the failed tests if you have time. We may have to (1) fix the issues, (2) change the test conditions, or (3) remove the tests if we can confirm that they are not supported.\n\nPlease check the following marks if fixed some of them. Thanks.\nPR #2753 executes the failed dynamic backend tests, and you can look at the error log at URL .\n\n[X] 1. \"test_castlike_FLOAT_to_DOUBLE_cpu\" # Fixed by PR#2762\n[X] 2. \"test_castlike_DOUBLE_to_FLOAT_cpu\" # Fixed by PR#2762\n[X] 3. \"test_castlike_FLOAT_to_FLOAT16_cpu\" # Fixed by PR#2762\n[X] 4. \"test_castlike_FLOAT16_to_FLOAT_cpu\" # Fixed by PR#2762\n[X] 5. \"test_castlike_FLOAT16_to_DOUBLE_cpu\" # Fixed by PR#2762\n[X] 6. \"test_castlike_DOUBLE_to_FLOAT16_cpu\" # Fixed by PR#2762\n[X] 7. \"test_convtranspose_1d_cpu\"\n[X] 8. \"test_convtranspose_3d_cpu\"\n[X] 9. \"test_convtranspose_autopad_same_cpu\"\n[X] 10. \"test_convtranspose_cpu\"\n[X] 11. \"test_convtranspose_dilations_cpu\"\n[X] 12. \"test_convtranspose_kernel_shape_cpu\"\n[X] 13. \"test_convtranspose_output_shape_cpu\"\n[X] 14. \"test_convtranspose_pad_cpu\"\n[X] 15. \"test_convtranspose_pads_cpu\"\n[X] 16. \"test_depthtospace_example_cpu\"\n[X] 17. \"test_depthtospace_crd_mode_example_cpu\"\n[X] 18. \"test_einsum_batch_diagonal_cpu\"\n[X] 19. \"test_einsum_batch_matmul_cpu\"\n[X] 20. \"test_einsum_inner_prod_cpu\"\n[X] 21. \"test_einsum_sum_cpu\"\n[X] 22. \"test_einsum_transpose_cpu\"\n[X] 23. \"test_gathernd_example_int32_cpu\" # Fixed by PR#2748\n[X] 24. \"test_gathernd_example_float32_cpu\" # Fixed by PR#2748\n[X] 25. \"test_gathernd_example_int32_batch_dim1_cpu\" # Fixed by PR#2748\n[X] 26. \"test_instancenorm_example_cpu\" # Fixed by PR#2763\n[X] 27. \"test_instancenorm_epsilon_cpu\" # Fixed by PR#2763\n[X] 28. \"test_constant_pad_cpu\" # Fixed by PR#2754\n[X] 29. \"test_edge_pad_cpu\" # Fixed by PR#2754\n[X] 30. \"test_reflect_pad_cpu\" # FIxed by PR#2754\n[X] 31. \"test_spacetodepth_example_cpu\"\n[X] 32. \"test_top_k_cpu\" # Fixed by PR#2735\n[X] 33. \"test_top_k_smallest_cpu\" # Fixed by PR#2735\n[X] 34. \"test_top_k_negative_axis_cpu\" # Fixed by PR#2735\n[X] 35. \"test_onnxmlir_top_k_float16_cpu\" # Fixed by PR#2735\n[X] 36. \"test_onnxmlir_top_k_smallest_float16_cpu\" # Fixed by PR#2735\n\n(This issue replaces the issue #2639 , since the situation is changed by PR #2735.)","author_login":"negiyas","author_association":"COLLABORATOR","created_at":"2024-03-07T02:37:12+08:00","repo_name":"onnx/onnx-mlir","issue_id":2172819255,"issue_number":2743,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2743","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007216865","fragment_type":"issue_comment","sequence":1,"text":"Update on the 2 instance norm failing tests. When I compile a model with dynamic shape, and then set the shapes at runtime, it works. But when we compile a model with dynamic shape AND set the size of these shapes by a compiler option, the compiler exit with an error. @chentong319 has a similar problem with another program, and he will test his solution (setting the output type to the same as the original type). Once Tong confirms that this work on his case, will do the same on these 2 cases of instance norm.","author_login":"AlexandreEichenberger","author_association":"COLLABORATOR","created_at":"2024-03-19T13:43:30+08:00","repo_name":"onnx/onnx-mlir","issue_id":2172819255,"issue_number":2743,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2743","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007942867","fragment_type":"issue_comment","sequence":2,"text":"@chentong319 thanks for the suggested fix, it worked. PR #2763 implements the change for instance norm cases (added also group norm which needs the same pattern, even if it may not be tested at this time).","author_login":"AlexandreEichenberger","author_association":"COLLABORATOR","created_at":"2024-03-19T19:15:31+08:00","repo_name":"onnx/onnx-mlir","issue_id":2172819255,"issue_number":2743,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2743","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2099520818","fragment_type":"issue_comment","sequence":3,"text":"I am closing this issue, since ll issues errors with dynamic backend tests (on CPU) are fixed. Thanks!","author_login":"negiyas","author_association":"COLLABORATOR","created_at":"2024-05-08T00:31:37+08:00","repo_name":"onnx/onnx-mlir","issue_id":2172819255,"issue_number":2743,"issue_url":"https://github.com/onnx/onnx-mlir/issues/2743","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0111","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Bottom standoffs - Bug or user?","query_context":"OS: OpenSUSE Leap 15.6\nOpenSCAD: 2021.01\nSBC_Case_Builder 3.0 - current github. \n\nFirst let me thank you for this great tool! I very much enjoy working with it, although I'm new to it an just started with my first project.\n\nI designed an Extended Case for a Radxa 4c+ v1.41 using the base case design „shell“. \nHere’s my workflow:\n 1) Created a new model for the 4c+ based upon rpi4b in SBC_Model_Framework/sbc_models.cfg.\n 2) „Integrated“ it following the instructions using get_customized_values.scad\n 3) Verified the model by 3D printing a regular shell case.\n\nBut the bottom standoff support is cutting out material from the wall which results in a thinner wall up to the height of the full standoff. The workaround is changing the bottom standoff size support from 10,00 to 9,00. Cause the position of the standoff is defined by the pcb it’s not moving anywhere => problem fixed. \n\nIn the case of extended case bottom standoff this doesn’t work. Changing the ex case bottom standoff size, say from 10,00 to 8,00 moves the whole standoff closer to the corner still cutting material from the wall.\n\nThis is not happening with the top standoffs for both sbc and extended. Changing the model i.e. to rpi4b or c1+ shows the same behavior. \n\nIs this a bug or is it me? It looks like a boolean operation should be union but is cut. Can I fix this in one of the OpenSCAD files? If yes, where. \n\nI also would like to contribute the Radxa 4c+ v1.41 model. What’s the process?","known_context_document_ids":["gh_issue_2818722937"],"reference_answer":"The predefined case pull down is not meant to hold all possible cases. With thousands of possible cases that is not practical or possible with the limitations of the Customizer UI within OpenSCAD. The pull down menu of predefined cases are custom cases or ones that have additional changes from the accessories subsystem. In addition, a reference shell case is included as a benefit for all SBC from the OEMs that support this project by supplying SBC samples, Hard Kernel and Pine64.\n\nThis tool is meant to autonomously build cases for any supported SBC by selecting the SBC and base case design under the View tab. It will automatically create the smallest possible symmetrical case using the current default tab settings. Any additional changes desired can also be made from the respective tab default settings e.g. the type of standoff fasteners to use for the top and bottom. \n\nThis is explained in the README.md file and I would strongly recommend you pay special attention to the notes-tips-and-things-to-check section for other suggestions of things to consider when setting up a case. Any case you create can then be saved in the predefined case pull down menu by pressing the + sign next to the 'save preset' button near the top of the GUI. The + sign creates a new entry and the 'save preset' button saves the current selected preset. There is also an area in the README.md that covers what each GUI tab and its parameters accomplish.\n\nSo if you want an OrangePi shell case select the correct SBC under the View tab and then select the case design. It will be automatically created and any other changes you want can be selected from the appropriate tab for the default presets. It's that simple. FYI, What you are calling the default RPI case is not the default case. It is an example of a custom RPI5 case incorporating a M2 HAT accessory.\n\nIf you need further assistance reopen this issue or create another.","answer_document_id":"gh_comment_2586008224","silver_evidence_path":["gh_comment_2624986458","gh_issue_2782750050","gh_comment_2586008224"],"evidence_issue_ids":[2818722937,2782750050],"source_repo_name":"hominoids/SBC_Case_Builder","source_issue_id":2818722937,"source_issue_number":42,"source_issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/42","target_repo_name":"hominoids/SBC_Case_Builder","target_issue_id":2782750050,"target_issue_number":41,"target_issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/41","reference_anchor_document_id":"gh_comment_2624986458","reference_answer_author":"hominoids","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1731,"anchor_target_overlap":0.1538,"target_answer_overlap":0.2963},"issue_created_at":"2025-01-29T16:43:16+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_2818722937","fragment_type":"issue_description","sequence":0,"text":"Bottom standoffs - Bug or user\nOS: OpenSUSE Leap 15.6\nOpenSCAD: 2021.01\nSBC_Case_Builder 3.0 - current github. \n\nFirst let me thank you for this great tool! I very much enjoy working with it, although I'm new to it an just started with my first project.\n\nI designed an Extended Case for a Radxa 4c+ v1.41 using the base case design „shell“. \nHere’s my workflow:\n 1) Created a new model for the 4c+ based upon rpi4b in SBC_Model_Framework/sbc_models.cfg.\n 2) „Integrated“ it following the instructions using get_customized_values.scad\n 3) Verified the model by 3D printing a regular shell case.\n\nBut the bottom standoff support is cutting out material from the wall which results in a thinner wall up to the height of the full standoff. The workaround is changing the bottom standoff size support from 10,00 to 9,00. Cause the position of the standoff is defined by the pcb it’s not moving anywhere => problem fixed. \n\nIn the case of extended case bottom standoff this doesn’t work. Changing the ex case bottom standoff size, say from 10,00 to 8,00 moves the whole standoff closer to the corner still cutting material from the wall.\n\nThis is not happening with the top standoffs for both sbc and extended. Changing the model i.e. to rpi4b or c1+ shows the same behavior. \n\nIs this a bug or is it me? It looks like a boolean operation should be union but is cut. Can I fix this in one of the OpenSCAD files? If yes, where. \n\nI also would like to contribute the Radxa 4c+ v1.41 model. What’s the process?","author_login":"origin2000","author_association":"NONE","created_at":"2025-01-29T16:43:16+08:00","repo_name":"hominoids/SBC_Case_Builder","issue_id":2818722937,"issue_number":42,"issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/42","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2623342865","fragment_type":"issue_comment","sequence":1,"text":"Thanks for opening an issue. Looking at the code there is a bug in the Extended Case Standoff placement. As you already figured out, the PCB Standoffs are fixed to the PCB hole locations and work as designed. Changing the PCB Standoff Support Size is the way to address the issue you encountered.\n\nThe extended case standoffs were originally fixed as well, at 10mm from the corners. When variable standoff sizes(3mm, 2.5mm, etc) were implemented their location was changed to be relative to the Standoff Support Size. This change allowed them to be placed closer to the corner of the case and why they move when you change the support size. I 'll make any corrections that are needed for the Extended Standoff placement and post the fix once completed and tested. It's late evening here now so I anticipate 24 hours time should be sufficient unless I run into some unforeseen problem.\n\nRegarding the Union verse Subtraction, a hole is first created in the case that is slightly smaller then the Standoff Support Size and then the standoff geometry is placed at the same location. This is required so that the type of fastener end( blind, countersunk, recessed, etc) can be accommodated in the case geometry, otherwise they would be covered by the case geometry and not visible.\n\nRegarding contributing your Rock 4c+ model, that would be welcomed and appreciated. Knowing that Radxa doesn't do a very good job with their documentation IMO, I am confused. There is already a Rock 4c+ in SBC Model Framework which I thought was version 1.4. So are these corrections to the existing model, a new model version or something else? If I remember correctly the current model was created based on the STEP model from their Wiki and is unverified(yellow) and may need corrections. Regardless, it would be good to have a verified model of the Radxa 4c+ since I don't own one, so your help in adding or updating the current version would be appreciated. The program sbc_models_viewer.scad within SBC Model Framework can be used to view the current models using a customizer GUI.\n\nRegarding the process, SBC models for SBC Case Builder are added to SBC Model Framework in a separate repository. The technical process to add a model you seemed to have figured out already, add appropriate entries to sbc_models.cfg. For reference, there is information in the README.md for SBC Model Framework that explicitly explains the technical process.\n\nSo to add or update a model, start by forking SBC Model Framework, add or modify the SBC model in sbc_models.cfg and then issue a Pull Request. I'll handle the changes necessary for SBC Case Builder and update along with the sub-module linkage to pull the latest version of SBC Model Framework. Once this is done any one that installs either will get the updated models. Those with existing SBCCB installations will need to update SBC Case Builder and it's sub-module SBC Model Framework, as noted in the SBC Case Builder README.md. If it is easier for you, instead of a PR you can open an issue in SBC Model Framework and post your entry from sbc_model.cfg for the Rock 4c+. The only down side with this approach is you wouldn't be shown as a contributor to the project.","author_login":"hominoids","author_association":"OWNER","created_at":"2025-01-30T01:52:32+08:00","repo_name":"hominoids/SBC_Case_Builder","issue_id":2818722937,"issue_number":42,"issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/42","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2624986458","fragment_type":"issue_comment","sequence":2,"text":"Ok, I changed the code so as not to interfere with case side wall geometry for any of the standoffs. Don't forget to save your case entry in the sbc_case_builder.json file, if you saved it, otherwise it will be over written when you update SBC Case Builder.\n\nAlso let me know if you have any more problems and the answers to my questions above about the Rock4c+ model. If your print is good I'll change the status to verified(green) based on the answer to the model questions. If you haven't found the current Rock 4c+ model in SBC Case Builder take a look at my response to this past closed issue.","author_login":"hominoids","author_association":"OWNER","created_at":"2025-01-30T16:33:32+08:00","repo_name":"hominoids/SBC_Case_Builder","issue_id":2818722937,"issue_number":42,"issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/42","linked_issue_ids":[2782750050],"is_known_query_context":false},{"document_id":"gh_comment_2629155009","fragment_type":"issue_comment","sequence":3,"text":"Many thanks for the incredible fast reply and fix! Just saw it on my mobile. I will test tomorrow ;-) In regard to adding the 4c+ v1.4 model I will give it a try as you described. I will also check the .step file they provided. The major difference though was a few mm here and there plus the stacked USB ports being on the wrong side. Stay tuned ;-) Thanks again!","author_login":"origin2000","author_association":"NONE","created_at":"2025-02-01T23:12:42+08:00","repo_name":"hominoids/SBC_Case_Builder","issue_id":2818722937,"issue_number":42,"issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/42","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2782750050","fragment_type":"issue_description","sequence":0,"text":"Case selection very limited\nI have just installed the lastest version of OpenSCAD for Windows (tried by 32- and 64-bit) and cloned the SBC project, did the init and the update. However, I have a VERY limited selected of SBCs. There's probably about 25-30 or so showing in the drop-down. There are no RPi (other than the default) and no OrangePi, for example.","author_login":"sstainba","author_association":"NONE","created_at":"2025-01-12T23:21:05+08:00","repo_name":"hominoids/SBC_Case_Builder","issue_id":2782750050,"issue_number":41,"issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586008224","fragment_type":"issue_comment","sequence":1,"text":"The predefined case pull down is not meant to hold all possible cases. With thousands of possible cases that is not practical or possible with the limitations of the Customizer UI within OpenSCAD. The pull down menu of predefined cases are custom cases or ones that have additional changes from the accessories subsystem. In addition, a reference shell case is included as a benefit for all SBC from the OEMs that support this project by supplying SBC samples, Hard Kernel and Pine64.\n\nThis tool is meant to autonomously build cases for any supported SBC by selecting the SBC and base case design under the View tab. It will automatically create the smallest possible symmetrical case using the current default tab settings. Any additional changes desired can also be made from the respective tab default settings e.g. the type of standoff fasteners to use for the top and bottom. \n\nThis is explained in the README.md file and I would strongly recommend you pay special attention to the notes-tips-and-things-to-check section for other suggestions of things to consider when setting up a case. Any case you create can then be saved in the predefined case pull down menu by pressing the + sign next to the 'save preset' button near the top of the GUI. The + sign creates a new entry and the 'save preset' button saves the current selected preset. There is also an area in the README.md that covers what each GUI tab and its parameters accomplish.\n\nSo if you want an OrangePi shell case select the correct SBC under the View tab and then select the case design. It will be automatically created and any other changes you want can be selected from the appropriate tab for the default presets. It's that simple. FYI, What you are calling the default RPI case is not the default case. It is an example of a custom RPI5 case incorporating a M2 HAT accessory.\n\nIf you need further assistance reopen this issue or create another.","author_login":"hominoids","author_association":"OWNER","created_at":"2025-01-13T00:59:34+08:00","repo_name":"hominoids/SBC_Case_Builder","issue_id":2782750050,"issue_number":41,"issue_url":"https://github.com/hominoids/SBC_Case_Builder/issues/41","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0116","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[AR] ASSISTENZA: allegati?","query_context":"### Il caricamento degli allegati nn rispecchia il componente previsto del design system (variante Trascina e rilascia) \nche mostra il tipo di file e il peso (elementi da mostrare per accessibilità), e quindi porta a vari problemi:\n\n- testo placeholder dentro il campo input > Seleziona il file\n- una volta caricato il file il campo Descrizione è uguale al nome del file e se molto lungo porta la tabella a scrollare in orizzontale e nascondere la CTA di eliminazione\n- [x] Se carico più di 3 file dovrebbe essere **nascosto**/disabilitato l'input per selezionare file successivi invece che lasciar selezionare il 4 file e poi mandare in errore\n\nLa richiesta è di implementare il corretto componente da design system\n\nimage","known_context_document_ids":["gh_issue_2542300262"],"reference_answer":"Riapro la issue perchè non vedo risolto il `BUG` sul caricamento dei png, o ora anche dei PDF. Ho provato sia con screenshot nominati corretti che con immagini scaricate native png senza problemi nel nome e:\n- o blocca il caricamento stesso\n- l'antivirus dice file corrotto\n\nAllego i file caricati come allegati\nimage","answer_document_id":"gh_comment_2522634588","silver_evidence_path":["gh_comment_2368093294","gh_issue_2519880349","gh_comment_2522634588"],"evidence_issue_ids":[2542300262,2519880349],"source_repo_name":"teamdigitale/anagrafenazionale.interno.it-site","source_issue_id":2542300262,"source_issue_number":249,"source_issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/249","target_repo_name":"teamdigitale/anagrafenazionale.interno.it-site","target_issue_id":2519880349,"target_issue_number":240,"target_issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","reference_anchor_document_id":"gh_comment_2368093294","reference_answer_author":"steps88","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.25,"target_answer_overlap":0.2727},"issue_created_at":"2024-09-23T11:04:46+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2542300262","fragment_type":"issue_description","sequence":0,"text":"[AR] ASSISTENZA: allegati\n### Il caricamento degli allegati nn rispecchia il componente previsto del design system (variante Trascina e rilascia) \nche mostra il tipo di file e il peso (elementi da mostrare per accessibilità), e quindi porta a vari problemi:\n\n- testo placeholder dentro il campo input > Seleziona il file\n- una volta caricato il file il campo Descrizione è uguale al nome del file e se molto lungo porta la tabella a scrollare in orizzontale e nascondere la CTA di eliminazione\n- [x] Se carico più di 3 file dovrebbe essere **nascosto**/disabilitato l'input per selezionare file successivi invece che lasciar selezionare il 4 file e poi mandare in errore\n\nLa richiesta è di implementare il corretto componente da design system\n\nimage","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-09-23T11:04:46+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2542300262,"issue_number":249,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/249","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2368093294","fragment_type":"issue_comment","sequence":1,"text":"Sarebbe coerente mantenere lo stesso approccio ogni qual volta ci siano allegati da caricare, vedi #240 e #229","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-09-23T12:37:42+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2542300262,"issue_number":249,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/249","linked_issue_ids":[2519880349],"is_known_query_context":false},{"document_id":"gh_comment_2435190352","fragment_type":"issue_comment","sequence":2,"text":"@sguerra issue completata, non posso cambiare lo stato \"In stage\" con questo utente\nncapozzi","author_login":"anpr-opendata-team","author_association":"NONE","created_at":"2024-10-24T12:41:57+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2542300262,"issue_number":249,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/249","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2531303213","fragment_type":"issue_comment","sequence":3,"text":"Chiudo la issue ma la questione sul design system rimane aperta.","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-12-10T11:28:07+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2542300262,"issue_number":249,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/249","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2519880349","fragment_type":"issue_description","sequence":0,"text":"[AR] CAMBIO RESIDENZA: tab Allegati\nNel momento in cui provo a caricare un allegato PNG derivato da uno screenshot, il caricamento non funziona. \nPNG scaricati da internet invece funzionano.\n\n URL","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-09-11T14:15:21+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2382441521","fragment_type":"issue_comment","sequence":1,"text":"Questo uno dei file derivati da screenshot e che ora va in errore proprio. \nanscval-int anpr interno it_serviziCittadino_privacy (29)","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-09-30T08:26:53+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2382633596","fragment_type":"issue_comment","sequence":2,"text":"Buongiorno @steps88,\nil problema è dovuto alla presenza del carattere \".\" nel nome del file che può stare solo prima dell'estensione \".png\". Pensiamao di aggiungere una frase nella form del tipo \"Nel nome del file non sono ammessi i caratteri punto ...\"","author_login":"ncapozzi","author_association":"COLLABORATOR","created_at":"2024-09-30T09:41:44+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2382716985","fragment_type":"issue_comment","sequence":3,"text":"va bene, meglio ancora se si può aggiungere un controllo del nome una volta caricato il file, e nel messaggio d'errore","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-09-30T10:20:53+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2522634588","fragment_type":"issue_comment","sequence":4,"text":"Riapro la issue perchè non vedo risolto il `BUG` sul caricamento dei png, o ora anche dei PDF. Ho provato sia con screenshot nominati corretti che con immagini scaricate native png senza problemi nel nome e:\n- o blocca il caricamento stesso\n- l'antivirus dice file corrotto\n\nAllego i file caricati come allegati\nimage","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-12-06T09:27:58+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2522638871","fragment_type":"issue_comment","sequence":5,"text":"20241021-design-system-italia\nserviziCittadino_servizi_richiesta_cambioresidenza_130165\ncertificato_22014428.pdf","author_login":"steps88","author_association":"COLLABORATOR","created_at":"2024-12-06T09:30:16+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2557271175","fragment_type":"issue_comment","sequence":6,"text":"@steps88 attualmente non ci risultano problemi nel caricamento allegati e verifica antivirus sia per pdf che png. Il giorno della segnalazione c'era un problema sull'antivirus ed in più uno dei file .png che cercavi di caricare non era veramente .png, ma .avif. (quello con l'immagine di design system Italia) Comunque puoi riprovare e farci sapere","author_login":"ncapozzi","author_association":"COLLABORATOR","created_at":"2024-12-20T15:57:52+08:00","repo_name":"teamdigitale/anagrafenazionale.interno.it-site","issue_id":2519880349,"issue_number":240,"issue_url":"https://github.com/teamdigitale/anagrafenazionale.interno.it-site/issues/240","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0118","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Cannot print layout cards?","query_context":"**Describe the bug**\nI'm trying to print the layout cards but when I type ctrl-P in Chrysalis 10.5.351 it disconnects my Atreus so all I can print is the 'connect' screen. Not sure if it's related but I'm also getting frequent 'communication timeout's when trying to connect. I'm connecting the keyboard directly to my laptop, not to a USB hub.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Select 'layout cards' to display the layouts\n2. Type 'control+P'\n3. Chrysalis window refreshes, shows the keyboard 'connect' screen, OS print dialog appears, if I print it prints the connect screen.\n\n**Expected behavior**\nWindow continues to show layout cards, print dialog appears, I print the layout cards.\n\n**Desktop (please complete the following information):**\n - OS: Win 10\n - Chrysalis Version: 10.5.321\nchrysalis-debug.bundle.zip","known_context_document_ids":["gh_issue_1305757115"],"reference_answer":"I was thinking about this the other day, and I think I have a solution that'd work nicely: a `CustomNames` plugin on the Kaleidoscope side, which we could use to store custom names for keys or layers, in eeprom or in progmem. Chrysalis would simply query the names, and use those instead of the built-in ones.\n\nFor storage in EEPROM, I'd use the following format: 4 bits for the type of name, 4 bits for the number of names (N). Then we have N index->name mappings, where the index size depends on the type, and names are NULL terminated. Initially, we'd have two types: layer & key names. For layers, the index is 1 byte, for keys, its two bytes. If we need to have more than 16 names of the same type stored, we can store multiple series of the same type. The serialization ends when the number of names is 0.\n\nSo, for example, to have a custom name for layer #0 and #1, and a custom name for Dynamic Macro #0, we'd encode it as:\n\n \"QWERTY\\0\" \"FUN\\0\"\n \"Greet\\0\"\n \n\nFor PROGMEM, it's a bit tougher, doing this kind of encoding at compile-time is more difficult. I'm not sure what the best approach would be there.\n\nMaybe if we separated type and length... that'd allow 255 custom names per type, should be a plenty, even if we disallow multiple series of the same type (but we could have multiple series anyway). But maybe I can fit the bit fiddling into a macro. We'll see.\n\nIn any case, to keep up with the spirit of storing keymap and keyboard settings on the keyboard, I'd store the custom names there, too, rather than somewhere on the Chrysalis side.","answer_document_id":"gh_comment_1165491294","silver_evidence_path":["gh_comment_1291962869","gh_issue_365267342","gh_comment_1165491294"],"evidence_issue_ids":[1305757115,365267342],"source_repo_name":"keyboardio/Chrysalis","source_issue_id":1305757115,"source_issue_number":992,"source_issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","target_repo_name":"keyboardio/Chrysalis","target_issue_id":365267342,"target_issue_number":3,"target_issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","reference_anchor_document_id":"gh_comment_1291962869","reference_answer_author":"algernon","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.2222,"target_answer_overlap":0.2449},"issue_created_at":"2022-07-15T08:44:32+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1305757115","fragment_type":"issue_description","sequence":0,"text":"Cannot print layout cards\n**Describe the bug**\nI'm trying to print the layout cards but when I type ctrl-P in Chrysalis 10.5.351 it disconnects my Atreus so all I can print is the 'connect' screen. Not sure if it's related but I'm also getting frequent 'communication timeout's when trying to connect. I'm connecting the keyboard directly to my laptop, not to a USB hub.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Select 'layout cards' to display the layouts\n2. Type 'control+P'\n3. Chrysalis window refreshes, shows the keyboard 'connect' screen, OS print dialog appears, if I print it prints the connect screen.\n\n**Expected behavior**\nWindow continues to show layout cards, print dialog appears, I print the layout cards.\n\n**Desktop (please complete the following information):**\n - OS: Win 10\n - Chrysalis Version: 10.5.321\nchrysalis-debug.bundle.zip","author_login":"cobblepot1","author_association":"NONE","created_at":"2022-07-15T08:44:32+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1195863237","fragment_type":"issue_comment","sequence":1,"text":"I'm having trouble reproducing this. On my Windows VM, printing to a file or a printer works without an issue. I suspect that the problem here is not with printing itself, but with the disconnect. I'll keep looking, though.","author_login":"algernon","author_association":"MEMBER","created_at":"2022-07-26T18:55:55+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1196308054","fragment_type":"issue_comment","sequence":2,"text":"Yes, I agree that it seems there is some reason that ctrl+P is causing a refresh of the connection. Let me know if I can do anything else to help troubleshoot.","author_login":"cobblepot1","author_association":"NONE","created_at":"2022-07-27T06:15:09+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1263037546","fragment_type":"issue_comment","sequence":3,"text":"I also can't print the layout on OSX and getting the red error message `Error encountered while printing.` without any information why 🤷","author_login":"dnagir","author_association":"NONE","created_at":"2022-09-30T02:42:06+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264970097","fragment_type":"issue_comment","sequence":4,"text":"I've hit a similar issue on Linux trying to print the layout cards. Hitting `ctrl-P` crashes Chrysalis with:\n\nCrashing due to FD ownership violation:\n#0 0x55c46cb0ba93 \n#1 0x55c46cbb919c \n#2 0x55c46cbb9161 \n#3 0x7fb467d51ef3 \nTrace/breakpoint trap\n\n- OS: Ubuntu GNU/Linux 22.04 kernel 5.15\n- Chrysalis version 0.11.5","author_login":"edysli","author_association":"NONE","created_at":"2022-10-03T05:59:10+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[365267342],"is_known_query_context":false},{"document_id":"gh_comment_1267986897","fragment_type":"issue_comment","sequence":5,"text":"I tried again with Chrysalis version 0.11.6 using the print button, unfortunately the issue is still present. The OS print dialogue briefly appears, then the application crashes.","author_login":"edysli","author_association":"NONE","created_at":"2022-10-05T06:11:04+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291962869","fragment_type":"issue_comment","sequence":6,"text":"I've got exactly the same issue on Linux Pop!_OS.\n\n- OS: Pop!_OS 22.04 LTS\n- Chrysalis version 0.11.9","author_login":"MacNetron","author_association":"NONE","created_at":"2022-10-26T12:31:46+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[365267342],"is_known_query_context":false},{"document_id":"gh_comment_1292440825","fragment_type":"issue_comment","sequence":7,"text":"I've tried with `Chrysalis-pr-1194.AppImage` as you suggested and the crash no longer happens. :) The print dialogue appeared after hitting `Ctrl-P` and it let me print to a file.","author_login":"edysli","author_association":"NONE","created_at":"2022-10-26T18:32:58+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1293188345","fragment_type":"issue_comment","sequence":8,"text":"Print dialog is showing but everything is completely frozen and unresponsive after that.\n\n➜ ~/Applications/beta ./Chrysalis-pr-1194.AppImage \nLogging to /home/marco/.config/chrysalis/logs/1666859674647.json\nChecking for update\nError: Error: No published versions on GitHub\n at Object.newError (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/builder-util-runtime/src/index.ts:55:17)\n at GitHubProvider.getLatestVersion (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/electron-updater/src/providers/GitHubProvider.ts:104:13)\n at processTicksAndRejections (node:internal/process/task_queues:96:5)\n at AppImageUpdater.getUpdateInfoAndProvider (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:368:13)\n at AppImageUpdater.doCheckForUpdates (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:385:20)\n at /tmp/.mount_ChrysaiJjInA/resources/app.asar/webpack:/src/main/ipc_autoupdate.js:42:29\n at node:electron/js2c/browser_init:193:551\nError occurred in handler for 'auto-update.check-for-updates': Error: No published versions on GitHub\n at Object.newError (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/builder-util-runtime/src/index.ts:55:17)\n at GitHubProvider.getLatestVersion (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/electron-updater/src/providers/GitHubProvider.ts:104:13)\n at processTicksAndRejections (node:internal/process/task_queues:96:5)\n at AppImageUpdater.getUpdateInfoAndProvider (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:368:13)\n at AppImageUpdater.doCheckForUpdates (/tmp/.mount_ChrysaiJjInA/resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:385:20)\n at /tmp/.mount_ChrysaiJjInA/resources/app.asar/webpack:/src/main/ipc_autoupdate.js:42:29\n at node:electron/js2c/browser_init:193:551 {\n1666859674647.json.zip\n\n code: 'ERR_UPDATER_NO_PUBLISHED_VERSIONS'\n}\nCrashing due to FD ownership violation:\n#0 0x5580119e1b33 \n#1 0x558011a59bdc \n#2 0x558011a59ba1 \n#3 0x7f7e49ab3ef3","author_login":"MacNetron","author_association":"NONE","created_at":"2022-10-27T08:40:22+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[365267342],"is_known_query_context":false},{"document_id":"gh_comment_1341642072","fragment_type":"issue_comment","sequence":9,"text":"I get a program crash (SIGTRAP) when I try to print the layout card on Ubuntu 22.04.1 LTS with Chrysalis-0.12.0.AppImage.\nSometimes I can see the Print dialog for fractions of a second, sometimes it crashes before showing the dialog.\n\n[879168:1207/223600.451822:ERROR:cursor_loader.cc(116)] Failed to load a platform cursor of type kNull\n[879226:1207/223600.640541:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process.\nChecking for update\nUpdate for version 0.12.0 is not available (latest version: 0.12.0, downgrade is disallowed).\n\nWhen trying to print layout card:\n\nCrashing due to FD ownership violation:\n#0 0x55cce79c7a93 \n#1 0x55cce7a7519c \n#2 0x55cce7a75161 \n#3 0x7f3d3b5c8ef3 \n\nProgram terminated with signal SIGTRAP, Trace/breakpoint trap.","author_login":"bomm","author_association":"NONE","created_at":"2022-12-07T21:52:48+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[365267342],"is_known_query_context":false},{"document_id":"gh_comment_1965244017","fragment_type":"issue_comment","sequence":10,"text":"Chrysalis now runs in-browser using WebSerial and WebUSB, so I'm closing out this issue as obsolete.","author_login":"obra","author_association":"MEMBER","created_at":"2024-02-26T20:51:04+08:00","repo_name":"keyboardio/Chrysalis","issue_id":1305757115,"issue_number":992,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_365267342","fragment_type":"issue_description","sequence":0,"text":"Custom names layers\nThe firmware does not save custom names given to macros, tap-dance, or leader keys, nor layer names. Yet, those are all interesting and useful information. Since we want to support saving a layout, and importing them too, we could also allow the user to name the layers, and give custom names to any of the keys on the board. Custom names would be displayed on the keymap instead of the normal label.\n\nOne restriction I'd add, is that this would only affect the `primaryLabel`; `extraLabel` would still come from `DisplayTransformer`. At least, for keys. For layers, there should be no such restrictions.","author_login":"algernon","author_association":"MEMBER","created_at":"2018-09-30T22:18:51+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_456507202","fragment_type":"issue_comment","sequence":1,"text":"Is it out of scope for this issue to also have the language setting act as a big custom key name import? Of course with the user defined key names overriding. Currently it is quite confusing to configure a non-US layout where the OS remaps the scancodes to another symbol than the one assumed by Chrysalis. Should I file a separate i18n issue?","author_login":"hnrklssn","author_association":"NONE","created_at":"2019-01-22T18:21:45+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_595550614","fragment_type":"issue_comment","sequence":2,"text":"Mistakenly closed, the @chrysalis-api merge confused GitHub.","author_login":"algernon","author_association":"MEMBER","created_at":"2020-03-06T01:27:22+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1165491294","fragment_type":"issue_comment","sequence":3,"text":"I was thinking about this the other day, and I think I have a solution that'd work nicely: a `CustomNames` plugin on the Kaleidoscope side, which we could use to store custom names for keys or layers, in eeprom or in progmem. Chrysalis would simply query the names, and use those instead of the built-in ones.\n\nFor storage in EEPROM, I'd use the following format: 4 bits for the type of name, 4 bits for the number of names (N). Then we have N index->name mappings, where the index size depends on the type, and names are NULL terminated. Initially, we'd have two types: layer & key names. For layers, the index is 1 byte, for keys, its two bytes. If we need to have more than 16 names of the same type stored, we can store multiple series of the same type. The serialization ends when the number of names is 0.\n\nSo, for example, to have a custom name for layer #0 and #1, and a custom name for Dynamic Macro #0, we'd encode it as:\n\n \"QWERTY\\0\" \"FUN\\0\"\n \"Greet\\0\"\n \n\nFor PROGMEM, it's a bit tougher, doing this kind of encoding at compile-time is more difficult. I'm not sure what the best approach would be there.\n\nMaybe if we separated type and length... that'd allow 255 custom names per type, should be a plenty, even if we disallow multiple series of the same type (but we could have multiple series anyway). But maybe I can fit the bit fiddling into a macro. We'll see.\n\nIn any case, to keep up with the spirit of storing keymap and keyboard settings on the keyboard, I'd store the custom names there, too, rather than somewhere on the Chrysalis side.","author_login":"algernon","author_association":"MEMBER","created_at":"2022-06-24T11:41:08+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173127204","fragment_type":"issue_comment","sequence":4,"text":"Going to split this in two, because they will be implemented separately: custom layer names (this issue), and custom key labels.","author_login":"algernon","author_association":"MEMBER","created_at":"2022-07-03T16:01:57+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1185326932","fragment_type":"issue_comment","sequence":5,"text":"I just wanted to encourage continued work on this issue. I'm trying Miryoku on the Atreus, and it has 6 layers, and it's really hard to remember the main purpose of each layer without custom layer names such as Mouse, Function, Numbers, etc. This is true both for mapping the keys initially and for having the layer names on the layout cards I want to print for reference to learn the layout.","author_login":"cobblepot1","author_association":"NONE","created_at":"2022-07-15T08:51:26+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1185345857","fragment_type":"issue_comment","sequence":6,"text":"The Chrysalis side of this is pretty much complete. We just need to figure out how to approach the firmware-side, and we're good to go. It's coming soon™!","author_login":"algernon","author_association":"MEMBER","created_at":"2022-07-15T09:12:54+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1185475729","fragment_type":"issue_comment","sequence":7,"text":"Honestly, I would love it if you just released the Chrysalis part and stored the information in a file on the computer while working on a solution to store it in firmware also. I bet most people are like me and do their keyboard configuration on one main computer, so for those people having the info in a way that can be viewed in Chrysalis and printed out solves 98% of the issue. Storing the custom names for the layers in firmware is nice also but doesn't seem as necessary. Just IMHO.","author_login":"cobblepot1","author_association":"NONE","created_at":"2022-07-15T12:00:31+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193061663","fragment_type":"issue_comment","sequence":8,"text":"This is now available in the latest snapshot build, and will be part of the next Chrysalis release.","author_login":"algernon","author_association":"MEMBER","created_at":"2022-07-23T05:07:41+08:00","repo_name":"keyboardio/Chrysalis","issue_id":365267342,"issue_number":3,"issue_url":"https://github.com/keyboardio/Chrysalis/issues/3","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0119","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Upgrade from 2024.07.0 to 2025.02.07 failed?","query_context":"After upgrading from 2024.07.0 to 2025.02.07, the UI eventually starts up but complains that it's unable to connect to local DNS (cloudflared running in the same portainer stack). Clicking around in the interface, a few of the screens don't work (clients, groups, etc). Most notably, DNS is **NOT** working. Local testing of cloudflared indicates that it appears to be working fine.\n\n dig @192.168.1.4 -p 5053 google.com\n\n; > DiG 9.18.30-0ubuntu0.24.04.2-Ubuntu > @192.168.1.4 -p 5053 google.com\n; (1 server found)\n;; global options: +cmd\n;; Got answer:\n;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 20839\n;; flags: qr aa rd ra; QUERY: 1, ANSWER: 6, AUTHORITY: 0, ADDITIONAL: 1\n\n;; OPT PSEUDOSECTION:\n; EDNS: version: 0, flags:; udp: 1232\n; COOKIE: a704732a048cdcaf (echoed)\n;; QUESTION SECTION:\n;google.com. IN A\n\n;; ANSWER SECTION:\ngoogle.com. 298 IN A 142.251.116.138\ngoogle.com. 298 IN A 142.251.116.139\ngoogle.com. 298 IN A 142.251.116.113\ngoogle.com. 298 IN A 142.251.116.100\ngoogle.com. 298 IN A 142.251.116.101\ngoogle.com. 298 IN A 142.251.116.102\n\n;; Query time: 0 msec\n;; SERVER: 192.168.1.4#5053(192.168.1.4) (UDP)\n;; WHEN: Mon Mar 03 14:34:50 CST 2025\n;; MSG SIZE rcvd: 207\n\nAfter reverting to 2024.07.0 which had been working, it complains about unexpected DB changes (understandable), as this ends up in my logs:\n\n [i] Creating new gravity databases...\n\n [✗] Unable to copy data from /etc/pihole/gravity.db to /etc/pihole/gravity.db_temp\n\n Parse error near line 18: table adlist has 10 columns but 12 values were supplied\n\nRuntime error near line 20: FOREIGN KEY constraint failed (19)\n\n [✗] Unable to create gravity database. Please try again later. If the problem persists, please contact support.\n\n \n\n \n\n \nBug\n\n## Details\n \n\n## Related Issues\n- [ ] I have searched this repository/Pi-hole forums for existing issues and pull requests that look similar \n \n\n \n \n\n## How to reproduce the issue \n\n1. Environment data\n * Operating System: DSM 7.2.2-72806 Update 3\n * Hardware: Synology DS 1019+\n * Kernel Architecture: \n * Docker Install Info and version: \n - Software source: Sy\n - Supplimentary Software: portainer 2.21.2\n * Hardware architecture: x86\n\n2. docker-compose.yml contents, docker run shell command, or paste a screenshot of any UI based configuration of containers here\n\nversion: \"3.6\"\n\nservices:\n cloudflared:\n container_name: cloudflared\n restart: unless-stopped\n image: cloudflare/cloudflared:2024.12.1\n command: proxy-dns\n environment:\n - \"TUNNEL_DNS_UPSTREAM= URL \n - \"TUNNEL_METRICS=0.0.0.0:49312\"\n - \"TUNNEL_DNS_ADDRESS=0.0.0.0\"\n - \"TUNNEL_DNS_PORT=5053\"\n # sysctls:\n # - net.ipv4.ip_unprivileged_port_start=53\n networks:\n pihole_lan:\n ipv4_address: 192.168.1.4\n pihole_bridge:\n ipv4_address: 192.168.10.4\n \n pihole:\n cap_add:\n - NET_ADMIN # required if you are using Pi-hole as your DHCP server\n container_name: pihole\n restart: unless-stopped\n image: pihole/pihole:2025.02.7\n ports:\n - 443/tcp\n - 53/tcp\n - 53/udp\n - 67/udp # required if you are using Pi-hole as your DHCP server\n - 80/tcp \n networks:\n pihole_lan:\n ipv4_address: 192.168.1.5\n pihole_bridge:\n ipv4_address: 192.168.10.2\n\n environment:\n - \"TZ=America/Chicago\"\n - \"DNS1=192.168.1.4#5053\"\n - \"DNS2=no\"\n - \"DNSMASQ_LISTENING=all\"\n - \"DNSMASQ_USER=xxxx\"\n - \"WEBPASSWORD=xxxx\"\n volumes:\n - '/volume1/docker/pihole/pihole/:/etc/pihole/'\n - '/volume1/docker/pihole/dnsmasq.d/:/etc/dnsmasq.d/'\n\nnetworks:\n pihole_lan:\n external: true\n name: dns\n pihole_bridge:\n external: true\n name: dns_bridge\n\n4. any additional info to help reproduce\nI was really hoping to not have to nuke all of my historical data and configuration. I see that the old configs were backed up, but it looks like it doesn't auto backup the DBs.\n\n## These common fixes didn't work for my issue\n \n- [ ] I have tried removing/destroying my container, and re-creating a new container\n- [ ] I have tried fresh volume data by backing up and moving/removing the old volume data\n- [ ] I have tried running the stock `docker run` example(s) in the readme (removing any customizations I added)\n- [x] I have tried a newer or older version of Docker Pi-hole (depending what version the issue started in for me)\n- [ ] I have tried running without my volume data mounts to eliminate volumes as the cause\n\nIf the above debugging / fixes revealed any new information note it here.\nAdd any other debugging steps you've taken or theories on root cause that may help.","known_context_document_ids":["gh_issue_2892277240"],"reference_answer":"We've seen reports where Pi-hole v6 with the lastest `dnsmasq` core using `0x20` encoding to generate mixed-case queries don't play well with `cloudflared`. \n\nTry to disable it by running adding `no-0x20-encode` to misc.dnsmasq_lines in Settings > All Settings > Misc","answer_document_id":"gh_comment_2672719266","silver_evidence_path":["gh_comment_2695509727","gh_issue_2867296167","gh_comment_2672719266"],"evidence_issue_ids":[2892277240,2867296167],"source_repo_name":"pi-hole/docker-pi-hole","source_issue_id":2892277240,"source_issue_number":1774,"source_issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/1774","target_repo_name":"pi-hole/pi-hole","target_issue_id":2867296167,"target_issue_number":5943,"target_issue_url":"https://github.com/pi-hole/pi-hole/issues/5943","reference_anchor_document_id":"gh_comment_2695509727","reference_answer_author":"yubiuser","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4444,"anchor_target_overlap":0.6667,"target_answer_overlap":0.1667},"issue_created_at":"2025-03-03T20:48:22+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2892277240","fragment_type":"issue_description","sequence":0,"text":"Upgrade from 2024.07.0 to 2025.02.07 failed\nAfter upgrading from 2024.07.0 to 2025.02.07, the UI eventually starts up but complains that it's unable to connect to local DNS (cloudflared running in the same portainer stack). Clicking around in the interface, a few of the screens don't work (clients, groups, etc). Most notably, DNS is **NOT** working. Local testing of cloudflared indicates that it appears to be working fine.\n\n dig @192.168.1.4 -p 5053 google.com\n\n; > DiG 9.18.30-0ubuntu0.24.04.2-Ubuntu > @192.168.1.4 -p 5053 google.com\n; (1 server found)\n;; global options: +cmd\n;; Got answer:\n;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 20839\n;; flags: qr aa rd ra; QUERY: 1, ANSWER: 6, AUTHORITY: 0, ADDITIONAL: 1\n\n;; OPT PSEUDOSECTION:\n; EDNS: version: 0, flags:; udp: 1232\n; COOKIE: a704732a048cdcaf (echoed)\n;; QUESTION SECTION:\n;google.com. IN A\n\n;; ANSWER SECTION:\ngoogle.com. 298 IN A 142.251.116.138\ngoogle.com. 298 IN A 142.251.116.139\ngoogle.com. 298 IN A 142.251.116.113\ngoogle.com. 298 IN A 142.251.116.100\ngoogle.com. 298 IN A 142.251.116.101\ngoogle.com. 298 IN A 142.251.116.102\n\n;; Query time: 0 msec\n;; SERVER: 192.168.1.4#5053(192.168.1.4) (UDP)\n;; WHEN: Mon Mar 03 14:34:50 CST 2025\n;; MSG SIZE rcvd: 207\n\nAfter reverting to 2024.07.0 which had been working, it complains about unexpected DB changes (understandable), as this ends up in my logs:\n\n [i] Creating new gravity databases...\n\n [✗] Unable to copy data from /etc/pihole/gravity.db to /etc/pihole/gravity.db_temp\n\n Parse error near line 18: table adlist has 10 columns but 12 values were supplied\n\nRuntime error near line 20: FOREIGN KEY constraint failed (19)\n\n [✗] Unable to create gravity database. Please try again later. If the problem persists, please contact support.\n\n \n\n \n\n \nBug\n\n## Details\n \n\n## Related Issues\n- [ ] I have searched this repository/Pi-hole forums for existing issues and pull requests that look similar \n \n\n \n \n\n## How to reproduce the issue \n\n1. Environment data\n * Operating System: DSM 7.2.2-72806 Update 3\n * Hardware: Synology DS 1019+\n * Kernel Architecture: \n * Docker Install Info and version: \n - Software source: Sy\n - Supplimentary Software: portainer 2.21.2\n * Hardware architecture: x86\n\n2. docker-compose.yml contents, docker run shell command, or paste a screenshot of any UI based configuration of containers here\n\nversion: \"3.6\"\n\nservices:\n cloudflared:\n container_name: cloudflared\n restart: unless-stopped\n image: cloudflare/cloudflared:2024.12.1\n command: proxy-dns\n environment:\n - \"TUNNEL_DNS_UPSTREAM= URL \n - \"TUNNEL_METRICS=0.0.0.0:49312\"\n - \"TUNNEL_DNS_ADDRESS=0.0.0.0\"\n - \"TUNNEL_DNS_PORT=5053\"\n # sysctls:\n # - net.ipv4.ip_unprivileged_port_start=53\n networks:\n pihole_lan:\n ipv4_address: 192.168.1.4\n pihole_bridge:\n ipv4_address: 192.168.10.4\n \n pihole:\n cap_add:\n - NET_ADMIN # required if you are using Pi-hole as your DHCP server\n container_name: pihole\n restart: unless-stopped\n image: pihole/pihole:2025.02.7\n ports:\n - 443/tcp\n - 53/tcp\n - 53/udp\n - 67/udp # required if you are using Pi-hole as your DHCP server\n - 80/tcp \n networks:\n pihole_lan:\n ipv4_address: 192.168.1.5\n pihole_bridge:\n ipv4_address: 192.168.10.2\n\n environment:\n - \"TZ=America/Chicago\"\n - \"DNS1=192.168.1.4#5053\"\n - \"DNS2=no\"\n - \"DNSMASQ_LISTENING=all\"\n - \"DNSMASQ_USER=xxxx\"\n - \"WEBPASSWORD=xxxx\"\n volumes:\n - '/volume1/docker/pihole/pihole/:/etc/pihole/'\n - '/volume1/docker/pihole/dnsmasq.d/:/etc/dnsmasq.d/'\n\nnetworks:\n pihole_lan:\n external: true\n name: dns\n pihole_bridge:\n external: true\n name: dns_bridge\n\n4. any additional info to help reproduce\nI was really hoping to not have to nuke all of my historical data and configuration. I see that the old configs were backed up, but it looks like it doesn't auto backup the DBs.\n\n## These common fixes didn't work for my issue\n \n- [ ] I have tried removing/destroying my container, and re-creating a new container\n- [ ] I have tried fresh volume data by backing up and moving/removing the old volume data\n- [ ] I have tried running the stock `docker run` example(s) in the readme (removing any customizations I added)\n- [x] I have tried a newer or older version of Docker Pi-hole (depending what version the issue started in for me)\n- [ ] I have tried running without my volume data mounts to eliminate volumes as the cause\n\nIf the above debugging / fixes revealed any new information note it here.\nAdd any other debugging steps you've taken or theories on root cause that may help.","author_login":"jimmywan","author_association":"NONE","created_at":"2025-03-03T20:48:22+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":2892277240,"issue_number":1774,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/1774","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2695509727","fragment_type":"issue_comment","sequence":1,"text":"Regarding the cloudflared issues, try if disabling `0x20` encoding helps.\n\n URL","author_login":"yubiuser","author_association":"MEMBER","created_at":"2025-03-03T20:52:47+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":2892277240,"issue_number":1774,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/1774","linked_issue_ids":[2867296167],"is_known_query_context":false},{"document_id":"gh_comment_2695593844","fragment_type":"issue_comment","sequence":2,"text":"I was able to get things kinda fixed by doing the following:\n- > Regarding the cloudflared issues, try if disabling `0x20` encoding helps.suggestion @yubiuser posted (TY!) \n- I found URL while my home DNS was down and in the process of trying to get that configuration to take, I also found that there was a single DHCP lease entry that had the MAC address specified using hyphens instead of colons that apparently was causing things to break.\n-","author_login":"jimmywan","author_association":"NONE","created_at":"2025-03-03T21:28:04+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":2892277240,"issue_number":1774,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/1774","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2867296167","fragment_type":"issue_description","sequence":0,"text":"Issue using DoH via Cloudflared since v6 upgrade\n### Versions\n \n- Pi-hole: Core version is v6.0.1 (Latest: v6.0.1)\n- AdminLTE: Web version is v6.0 (Latest: v6.0)\n- FTL: FTL version is v6.0 (Latest: v6.0)\n\n### Platform\n \n- OS and version: Debian 12 lite\n \n- Platform: Proxmox LXC Privileged container\n\n### Expected behavior\n\nDNS over HTTPS (DoH) using cloudflared installed via this guide: URL should work without any issues as it did prior to v6\n\n### Actual behavior / bug\n\nSince upgrading to v6 have had intermittent issues with Cloudflared connecting. When setting 127.0.0.1#53 as the only upstream DNS server, this results in total network loss due to no DNS resolving. prior to upgrading to v6 i have been running this fine for several months with not a single issue. the error from running systemctl status cloudflared.service results in a bunch of errors of either 2 outcomes:\n1. cloudflared[152]: 2025-02-20T20:42:37Z ERR failed to connect to an HTTPS backend \" URL error=\"failed to perform an HTTPS request: Post \\\" URL context deadline exceeded\"\n2. cloudflared[152]: 2025-02-20T20:42:37Z ERR failed to connect to an HTTPS backend \" URL error=\"failed to perform an HTTPS request: Post \\\" URL request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)\"\n\n### Steps to reproduce\n\nSteps to reproduce the behavior:\n\n1. install cloudflared via guide\n2. wait for it to fail\n3. run systemctl status cloudflared.service\n\n## Debug Token\n\n- URL: \n\n URL","author_login":"gioc116","author_association":"NONE","created_at":"2025-02-20T21:20:52+08:00","repo_name":"pi-hole/pi-hole","issue_id":2867296167,"issue_number":5943,"issue_url":"https://github.com/pi-hole/pi-hole/issues/5943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2672719266","fragment_type":"issue_comment","sequence":1,"text":"We've seen reports where Pi-hole v6 with the lastest `dnsmasq` core using `0x20` encoding to generate mixed-case queries don't play well with `cloudflared`. \n\nTry to disable it by running adding `no-0x20-encode` to misc.dnsmasq_lines in Settings > All Settings > Misc","author_login":"yubiuser","author_association":"MEMBER","created_at":"2025-02-20T21:25:49+08:00","repo_name":"pi-hole/pi-hole","issue_id":2867296167,"issue_number":5943,"issue_url":"https://github.com/pi-hole/pi-hole/issues/5943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673070646","fragment_type":"issue_comment","sequence":2,"text":"i just got done setting this up on another few machines and each one works perfect (as far as i can tell) with just a normal install, i used that very same guide you linked, word for word - the only difference is the ports, I used 5053 like the guide did soo maybe thats the secret sauce to making it work? - posted my output to demonstrate it working - you'll have more A records returned than me when you get it working, Korean ip an all that lol unless google just hates me xD\n\n---\nubuntu@ip-172-26-6-59:~$ dig @127.0.0.1 -p 5053 google.com\n\n; > DiG 9.18.30-0ubuntu0.24.04.2-Ubuntu > @127.0.0.1 -p 5053 google.com\n; (1 server found)\n;; global options: +cmd\n;; Got answer:\n;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 63316\n;; flags: qr aa rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1\n\n;; OPT PSEUDOSECTION:\n; EDNS: version: 0, flags:; udp: 1232\n; COOKIE: 923a031c8dd45af5 (echoed)\n;; QUESTION SECTION:\n;google.com.INA\n\n;; ANSWER SECTION:\ngoogle.com.229INA142.250.76.142\n\n;; Query time: 0 msec\n;; SERVER: 127.0.0.1#5053(127.0.0.1) (UDP)\n;; WHEN: Fri Feb 21 00:39:13 UTC 2025\n;; MSG SIZE rcvd: 77","author_login":"kaic2025","author_association":"NONE","created_at":"2025-02-21T00:47:33+08:00","repo_name":"pi-hole/pi-hole","issue_id":2867296167,"issue_number":5943,"issue_url":"https://github.com/pi-hole/pi-hole/issues/5943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675280455","fragment_type":"issue_comment","sequence":3,"text":"Update: I added this line in at that point, and after 24 hours service has been stable with no downtime, so this seems to have resolved it for me. Not sure whether to close this or to update it to be added to documentation, I will let maintainers decide! thanks again!","author_login":"gioc116","author_association":"NONE","created_at":"2025-02-21T18:37:04+08:00","repo_name":"pi-hole/pi-hole","issue_id":2867296167,"issue_number":5943,"issue_url":"https://github.com/pi-hole/pi-hole/issues/5943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675282970","fragment_type":"issue_comment","sequence":4,"text":"I will add, I don't think ports are an issue - was using 5053 before upgrading to v6, and it appears the encoding seems to have been an issue.","author_login":"gioc116","author_association":"NONE","created_at":"2025-02-21T18:38:31+08:00","repo_name":"pi-hole/pi-hole","issue_id":2867296167,"issue_number":5943,"issue_url":"https://github.com/pi-hole/pi-hole/issues/5943","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0122","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[BUG] Websockets hang on recv()?","query_context":"Please check the following items and answer all the questions when reporting a bug, \notherwise it will be closed immediately.\n\n- [x] **This is NOT a site-related \"bugs\"**, e.g. some site blocks me when using curl_cffi,\n UNLESS it has been verified that the reason is missing pieces in the impersonation.\n- [x] A code snippet that can reproduce this bug is provided, even if it's a one-liner.\n- [x] Version information will be pasted as below.\n\n**Describe the bug**\n\nUsing websockets, when iterating through received messages, websockets hang on recv() most of the time. This occurs for both async and non-async implementations.\n\nWhen running the code below, call either `asyncio.run(ws_curl_cffi_async())` or `ws_curl_cffi()` multiple times to discover the issue, as occasionally it works as expected (usually on the first run).\n\nThe code also includes a snippet using Python's websocket-client library, which reliably works each time.\n\nSeparately, it would be great if a message timeout could be configured, such that `recv()` doesn't hang indefinitely.\n\n**To Reproduce**\n\npy\nimport asyncio\n\nfrom curl_cffi.requests import AsyncSession, WebSocket\n\nasync def ws_curl_cffi_async():\n async with AsyncSession() as s:\n ws = await s.ws_connect(\"wss://echo.websocket.org\")\n await asyncio.gather(*[ws.send_str(f\"Hello {i}\") for i in range(20)])\n async for message in ws:\n print(message)\n\ndef ws_curl_cffi():\n ws = WebSocket().connect(\"wss://echo.websocket.org\")\n for i in range(20):\n ws.send(f\"Hello {i}\")\n for i in range(20):\n print(ws.recv())\n ws.close()\n\nif __name__ == \"__main__\":\n # asyncio.run(ws_curl_cffi_async())\n ws_curl_cffi()\n\nThe example below uses the websocket-client library to demonstrate the expected behavior. It works reliably each time.\n\n`pip install websocket-client==1.6.4`\n\npy\nfrom websocket import create_connection\n\ndef ws_websocket():\n ws = create_connection(\"wss://echo.websocket.org\")\n for i in range(20):\n ws.send(f\"Hello {i}\")\n \n for i in range(20):\n print(ws.recv())\n\n ws.close()\n\nif __name__ == \"__main__\":\n ws_websocket()\n\n**Expected behavior**\n\nAll 19 messages should be received and printed.\n\n**Versions**\n - OS: Linux aarch64 (python:3.12.2 Docker image)\n - curl-cffi==v0.8.1b9\n\n**Additional Information**\n\nThis is possibly an issue related to queuing of response messages. If each message is read immediately after the `send`, it works more reliably, but this is only applicable to this \"echo\" example. For example\n\npy\ndef ws_websocket():\n ws = create_connection(\"wss://echo.websocket.org\")\n for i in range(20):\n ws.send(f\"Hello {i}\")\n print(ws.recv())\n\n ws.close()","known_context_document_ids":["gh_issue_2805676093"],"reference_answer":"Have you encountered any issues when using other websockets client? like `websocket_client` or `websockets`.","answer_document_id":"gh_comment_2719809530","silver_evidence_path":["gh_comment_2668614674","gh_issue_2829732293","gh_comment_2719809530"],"evidence_issue_ids":[2805676093,2829732293],"source_repo_name":"lexiforest/curl_cffi","source_issue_id":2805676093,"source_issue_number":487,"source_issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","target_repo_name":"lexiforest/curl_cffi","target_issue_id":2829732293,"target_issue_number":495,"target_issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","reference_anchor_document_id":"gh_comment_2668614674","reference_answer_author":"lexiforest","reference_answer_author_association":"OWNER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4,"anchor_target_overlap":0.1,"target_answer_overlap":0.0},"issue_created_at":"2025-01-23T01:18:09+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_2805676093","fragment_type":"issue_description","sequence":0,"text":"[BUG] Websockets hang on recv()\nPlease check the following items and answer all the questions when reporting a bug, \notherwise it will be closed immediately.\n\n- [x] **This is NOT a site-related \"bugs\"**, e.g. some site blocks me when using curl_cffi,\n UNLESS it has been verified that the reason is missing pieces in the impersonation.\n- [x] A code snippet that can reproduce this bug is provided, even if it's a one-liner.\n- [x] Version information will be pasted as below.\n\n**Describe the bug**\n\nUsing websockets, when iterating through received messages, websockets hang on recv() most of the time. This occurs for both async and non-async implementations.\n\nWhen running the code below, call either `asyncio.run(ws_curl_cffi_async())` or `ws_curl_cffi()` multiple times to discover the issue, as occasionally it works as expected (usually on the first run).\n\nThe code also includes a snippet using Python's websocket-client library, which reliably works each time.\n\nSeparately, it would be great if a message timeout could be configured, such that `recv()` doesn't hang indefinitely.\n\n**To Reproduce**\n\npy\nimport asyncio\n\nfrom curl_cffi.requests import AsyncSession, WebSocket\n\nasync def ws_curl_cffi_async():\n async with AsyncSession() as s:\n ws = await s.ws_connect(\"wss://echo.websocket.org\")\n await asyncio.gather(*[ws.send_str(f\"Hello {i}\") for i in range(20)])\n async for message in ws:\n print(message)\n\ndef ws_curl_cffi():\n ws = WebSocket().connect(\"wss://echo.websocket.org\")\n for i in range(20):\n ws.send(f\"Hello {i}\")\n for i in range(20):\n print(ws.recv())\n ws.close()\n\nif __name__ == \"__main__\":\n # asyncio.run(ws_curl_cffi_async())\n ws_curl_cffi()\n\nThe example below uses the websocket-client library to demonstrate the expected behavior. It works reliably each time.\n\n`pip install websocket-client==1.6.4`\n\npy\nfrom websocket import create_connection\n\ndef ws_websocket():\n ws = create_connection(\"wss://echo.websocket.org\")\n for i in range(20):\n ws.send(f\"Hello {i}\")\n \n for i in range(20):\n print(ws.recv())\n\n ws.close()\n\nif __name__ == \"__main__\":\n ws_websocket()\n\n**Expected behavior**\n\nAll 19 messages should be received and printed.\n\n**Versions**\n - OS: Linux aarch64 (python:3.12.2 Docker image)\n - curl-cffi==v0.8.1b9\n\n**Additional Information**\n\nThis is possibly an issue related to queuing of response messages. If each message is read immediately after the `send`, it works more reliably, but this is only applicable to this \"echo\" example. For example\n\npy\ndef ws_websocket():\n ws = create_connection(\"wss://echo.websocket.org\")\n for i in range(20):\n ws.send(f\"Hello {i}\")\n print(ws.recv())\n\n ws.close()","author_login":"dleber","author_association":"NONE","created_at":"2025-01-23T01:18:09+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2612455116","fragment_type":"issue_comment","sequence":1,"text":"I've isolated the issue to this line of code\n\n`rlist, _, _ = select([sock_fd], [], [], 5.0)`\n\nSelect starts off detecting some of the received messages, allowing the subsequent calls to `self.recv_fragment()`. However it usually reaches a point where it fails to detect the remaining messages in the socket buffer, and hangs forever.\n\nIf I comment out `rlist, _, _ = select([sock_fd], [], [], 5.0)` and `if rlist:`, the previously posted example (`ws_curl_cffi()`) works correctly every time. I'm in no way suggesting this as a solution, it merely demonstrates that all messages are being received.\n\nI've tried replacing select with other event listeners including `select.poll()` and `selectors.DefaultSelector()` (I believe this uses `select.epoll()` on Linux), however the same issues were present.\n\nI also came across `curl_multi_wait` but didn't try it.","author_login":"dleber","author_association":"NONE","created_at":"2025-01-24T12:48:43+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2612516542","fragment_type":"issue_comment","sequence":2,"text":"We will revisit the ws implementation later, perhaps adding your case to the unit tests, thanks for your experiments.","author_login":"lexiforest","author_association":"OWNER","created_at":"2025-01-24T13:20:15+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613939597","fragment_type":"issue_comment","sequence":3,"text":"Not a problem, looking forward to the updates.\n\nSeparately, adding an optional message timeout parameter to the `WebSocket` class would be very useful. When dealing with the `select` bug, it would prevent indefinite hanging. More generally, if a server isn't sending data, I wouldn't want my scripts waiting too long. Let me know if you would like me to create a feature request for this.","author_login":"dleber","author_association":"NONE","created_at":"2025-01-25T11:48:52+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667996912","fragment_type":"issue_comment","sequence":4,"text":"for me commenting these lines prevented the hanging issue:\n URL","author_login":"rudyrdx","author_association":"NONE","created_at":"2025-02-19T09:10:46+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2668614674","fragment_type":"issue_comment","sequence":5,"text":"I’ve added a fix for this and issue **#495** on my fork. You can check if it works for you. \n\n**Before video:** \nBefore \n\n**After video:** \nAfter","author_login":"rudyrdx","author_association":"NONE","created_at":"2025-02-19T13:11:20+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[2829732293],"is_known_query_context":false},{"document_id":"gh_comment_2676573279","fragment_type":"issue_comment","sequence":6,"text":"Hey @lexiforest, I'm unfortunately very busy with midterms right now :(\nI can probably take a look next month if it's still unfixed","author_login":"dolfies","author_association":"CONTRIBUTOR","created_at":"2025-02-23T04:59:04+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2805676093,"issue_number":487,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/487","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2829732293","fragment_type":"issue_description","sequence":0,"text":"Websocket recv() limited bytes returned\n**The question**\n\nI have an issue with the websocket implementation, it seems that the recv() function can only return a maximum of 8192 bytes but I have a connection where the receive message is larger than this, I was wondering if there was a parameter I could use to increase/ignore that maximum?\n\n**Versions**\n\n - OS: Windows 11\n - curl_cffi version 0.7.1","author_login":"johnraysimpson","author_association":"NONE","created_at":"2025-02-04T10:26:56+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2635619052","fragment_type":"issue_comment","sequence":1,"text":"Hi, can you have a look at #487, is this the same kind of issue?","author_login":"lexiforest","author_association":"OWNER","created_at":"2025-02-05T03:25:07+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2636147852","fragment_type":"issue_comment","sequence":2,"text":"Hey, I don't think so, my script doesn't really have points where `recv()` hangs and I'm utilising `Websocket.run_forever()` (I could try to see what happens when I use Websocket.recv() in a for loop to see if it's the same issue). I've traced it back to `Curl.ws_recv()` in `curl.py` where it chunks data up into 1024 bytes and collates them, but I can't see anything that is restricting the whole message. It just seems to gather the first 8192 bytes (which would be 8 iterations of `Curl.ws_recv()`), waits a while then sends the rest of the same message.\nFortunately this only happens at the start of my script, I can send some of it but it's a UK site and I'm not sure if it has location blocking.","author_login":"johnraysimpson","author_association":"NONE","created_at":"2025-02-05T09:10:24+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2639312729","fragment_type":"issue_comment","sequence":3,"text":"Looking into this a bit further, what I've found is that if another, separate message comes through then the end of the last message is attached to the start of the new message, it comes through quicker but can be a bit irritating separating it all and making sure I have full messages","author_login":"johnraysimpson","author_association":"NONE","created_at":"2025-02-06T09:44:51+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2666491991","fragment_type":"issue_comment","sequence":4,"text":"Yea I am also facing this same issue, after the message reaches a certain size, the order of the messages changes, the messages gets chunked at random positions etc any fix or potential clues where I can look into to try to fix this issue?","author_login":"rudyrdx","author_association":"NONE","created_at":"2025-02-18T18:03:29+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2703535760","fragment_type":"issue_comment","sequence":5,"text":"I think this is the same issue as #487, a fix is on the way.","author_login":"lexiforest","author_association":"OWNER","created_at":"2025-03-06T11:09:44+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2718355600","fragment_type":"issue_comment","sequence":6,"text":"Hey, I'm still facing this issue after upgrading to 0.10.0, just wondering if there's ssomething I'm missing?\n\nhere's a sample of my code, you might be able to run it but since it's UK based I'm not sure\n\nfrom curl_cffi.requests import Session\n\ndef create_send_message(msg_command, msg_dict) -> str:\n \"\"\"\n creates a send message for subscriptions and connections using a message command and message dict\n \"\"\"\n msg_dict_to_str = msg_command\n for msg_key, msg_value in msg_dict.items():\n msg_dict_to_str = f\"{msg_dict_to_str}\\n{msg_key}:{msg_value}\"\n\n msg_dict_to_str = f\"{msg_dict_to_str}\\n\\n\\u0000\"\n\n msg_to_send = msg_dict_to_str\n\n return msg_to_send\n\ndef send_connect_message(ws):\n \"\"\"sends initial connect message\"\"\"\n connect_msg_dict = {\"protocol-version\": \"1.5\", \"accept-version\": \"1.0,1.1,1.2\", \"heart-beat\": \"10000,10000\"}\n connect_msg_command = \"CONNECT\"\n\n msg_to_send = create_send_message(connect_msg_command, connect_msg_dict)\n\n ws.send_str(msg_to_send)\n\ndef send_request_response_message(ws):\n \"\"\"sends initial request response message\"\"\"\n allow_requests_msg_dict = {\"id\": \"/user/request-response\", \"destination\": \"/user/request-response\"}\n\n allow_requests_msg_command = \"SUBSCRIBE\"\n\n msg_to_send = create_send_message(allow_requests_msg_command, allow_requests_msg_dict)\n\n ws.send_str(msg_to_send)\n\ndef send_event_message(ws):\n \"\"\"sends initial request response message\"\"\"\n allow_requests_msg_dict = {\"id\": \"/api/events/18272183\", \"locale\": \"en\", \"destination\": \"/api/events/18272183\"}\n\n allow_requests_msg_command = \"SUBSCRIBE\"\n\n msg_to_send = create_send_message(allow_requests_msg_command, allow_requests_msg_dict)\n\n ws.send_str(msg_to_send)\n\ndef send_country_comp_message(ws):\n \"\"\"sends subscription message to get all the countries and competitions on 10bet\"\"\"\n get_competitions_msg_dict = {\n \"id\": \"/api/container/football-competitions\",\n \"locale\": \"en\",\n \"destination\": \"/api/container/football-competitions\",\n }\n\n get_competitions_msg_command = \"SUBSCRIBE\"\n\n msg_to_send = create_send_message(get_competitions_msg_command, get_competitions_msg_dict)\n\n ws.send(msg_to_send)\n\nheaders = {\n 'Upgrade': 'websocket',\n 'Origin': ' URL \n 'Cache-Control': 'no-cache',\n 'Accept-Language': 'en-GB,en-US;q=0.9,en;q=0.8',\n 'Pragma': 'no-cache',\n 'Connection': 'Upgrade',\n 'Sec-WebSocket-Key': 'VlPJgHU6nfbTamJRRMLtEA==',\n 'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36',\n 'Sec-WebSocket-Version': '13',\n 'Sec-WebSocket-Protocol': 'v12.stomp, v11.stomp, v10.stomp',\n # 'Sec-WebSocket-Extensions': 'permessage-deflate; client_max_window_bits',\n}\n\nsession = Session(headers=headers)\nws = session.ws_connect(\n \"wss://sportswidget.10bet.co.uk/api/websocket\",\n)\n\nsend_connect_message(ws)\nwhile True:\n recv_msg = ws.recv_str()\n print(recv_msg)\n print(len(recv_msg))\n if \"CONNECTED\" in recv_msg:\n send_request_response_message(ws)\n if \"READY\" in recv_msg:\n send_country_comp_message(ws)","author_login":"johnraysimpson","author_association":"NONE","created_at":"2025-03-12T15:54:57+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2719809530","fragment_type":"issue_comment","sequence":7,"text":"Have you encountered any issues when using other websockets client? like `websocket_client` or `websockets`.","author_login":"lexiforest","author_association":"OWNER","created_at":"2025-03-13T04:02:29+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2721162703","fragment_type":"issue_comment","sequence":8,"text":"I hadn't, this scrape was previously running with `websocket_client` but due to bot detection I changed to `curl_cffi`, I haven't replicated this issue with any other endpoint either but then again I haven't converted much to the `curl_cffi` websocket handling","author_login":"johnraysimpson","author_association":"NONE","created_at":"2025-03-13T12:55:36+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730034831","fragment_type":"issue_comment","sequence":9,"text":"I don't know if it is connected, but I have found another issue where the message returned when using `.run_forever()` is missing the first part of the message and returns a part of it at the end. First example is with `curl_cffi` and second example is with `websocket_client`\n\n`curl_cffi`\n\nfrom curl_cffi import WebSocket\nimport json\nimport time\n\ndef on_message(ws: WebSocket, msg: str):\n print(msg)\n if \"Connection established\" in msg:\n send_first_message(ws)\n\ndef send_first_message(ws: WebSocket):\n initial_query = {\n \"market.display\": True,\n \"state\": \"open\",\n \"sport\": [\"football\"],\n \"sportReplace\": [\n {\n \"from\": \"internationalhorseracing\",\n \"to\": \"horseracing\",\n },\n {\n \"from\": \"horseracingantepost\",\n \"to\": \"horseracing\",\n },\n {\n \"from\": \"internationalgreyhoundracing\",\n \"to\": \"greyhoundracing\",\n },\n ],\n }\n\n initial_message = {\n \"type\": \"SubscriptionValue\",\n \"data\": [\n {\n \"id\": {\n \"type\": \"QueryEvents\",\n \"query\": json.dumps(initial_query).replace(\" \", \"\"),\n },\n \"active\": True,\n }\n ],\n }\n\n initial_message[\"data\"][0][\"active\"] = True # comes back to parse_countries_comps_events\n ws.send_str(json.dumps(initial_message))\n time.sleep(2)\n initial_message[\"data\"][0][\"active\"] = False\n ws.send_str(json.dumps(initial_message))\n\nheaders = {\n 'Upgrade': 'websocket',\n 'Origin': ' URL \n 'Cache-Control': 'no-cache',\n 'Accept-Language': 'en-GB,en-US;q=0.9,en;q=0.8',\n 'Pragma': 'no-cache',\n 'Connection': 'Upgrade',\n 'Sec-WebSocket-Key': 'WyNFaM45nzYcdtAbmLGz5Q==',\n 'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36',\n 'Sec-WebSocket-Version': '13',\n}\n\nws = WebSocket(on_message=on_message)\n\nws.run_forever(\"wss://webapi.akbets.bet/ins/socket/ws\", headers=headers)\n\n`websocket_client`\n\nimport websocket\nimport json\nimport time\n\ndef on_message(ws: websocket.WebSocketApp, msg: str):\n print(msg)\n if \"Connection established\" in msg:\n send_first_message(ws)\n\ndef send_first_message(ws: websocket.WebSocketApp):\n initial_query = {\n \"market.display\": True,\n \"state\": \"open\",\n \"sport\": [\"football\"],\n \"sportReplace\": [\n {\n \"from\": \"internationalhorseracing\",\n \"to\": \"horseracing\",\n },\n {\n \"from\": \"horseracingantepost\",\n \"to\": \"horseracing\",\n },\n {\n \"from\": \"internationalgreyhoundracing\",\n \"to\": \"greyhoundracing\",\n },\n ],\n }\n\n initial_message = {\n \"type\": \"SubscriptionValue\",\n \"data\": [\n {\n \"id\": {\n \"type\": \"QueryEvents\",\n \"query\": json.dumps(initial_query).replace(\" \", \"\"),\n },\n \"active\": True,\n }\n ],\n }\n\n initial_message[\"data\"][0][\"active\"] = True # comes back to parse_countries_comps_events\n ws.send(json.dumps(initial_message))\n time.sleep(2)\n initial_message[\"data\"][0][\"active\"] = False\n ws.send(json.dumps(initial_message))\n\nheaders = {\n 'Upgrade': 'websocket',\n 'Origin': ' URL \n 'Cache-Control': 'no-cache',\n 'Accept-Language': 'en-GB,en-US;q=0.9,en;q=0.8',\n 'Pragma': 'no-cache',\n 'Connection': 'Upgrade',\n 'Sec-WebSocket-Key': 'WyNFaM45nzYcdtAbmLGz5Q==',\n 'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36',\n 'Sec-WebSocket-Version': '13',\n}\n\nws = websocket.WebSocketApp(\"wss://webapi.akbets.bet/ins/socket/ws\", on_message=on_message, header=headers)\n\nws.run_forever()","author_login":"johnraysimpson","author_association":"NONE","created_at":"2025-03-17T15:53:24+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2802372816","fragment_type":"issue_comment","sequence":10,"text":"I have the same issue - the first part of the response is sometimes missing when the returned message is long.","author_login":"wimpie3","author_association":"NONE","created_at":"2025-04-14T17:16:16+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2875465313","fragment_type":"issue_comment","sequence":11,"text":"The chunks in the run_forever function are not handled correctly.\nHere is the code after the AI ​​fixed it.\n\npython\n def run_forever(self, url: str, **kwargs):\n \"\"\"Run the WebSocket forever. See :meth:`connect` for details on parameters.\n\n libcurl automatically handles pings and pongs.\n ref: URL \n \"\"\"\n self.connect(url, **kwargs)\n sock_fd = self.curl.getinfo(CurlInfo.ACTIVESOCKET)\n if sock_fd == CURL_SOCKET_BAD:\n raise WebSocketError(\n \"Invalid active socket\", CurlECode.NO_CONNECTION_AVAILABLE\n )\n\n self._emit(\"open\")\n\n # Keep reading the messages and invoke callbacks\n # TODO: Reconnect logic\n chunks = []\n keep_running = True\n while keep_running:\n try:\n msg, frame = self.recv_fragment()\n flags = frame.flags\n self._emit(\"data\", msg, frame)\n\n chunks.append(msg)\n \n if not (frame.bytesleft == 0 and flags & CurlWsFlag.CONT == 0):\n continue\n\n complete_msg = b\"\".join(chunks)\n # Avoid unnecessary computation\n if \"message\" in self._emitters:\n if (flags & CurlWsFlag.TEXT) and not self.skip_utf8_validation:\n try:\n complete_msg = complete_msg.decode() # type: ignore \n except UnicodeDecodeError as e:\n self._close_code = WsCloseCode.INVALID_DATA\n self.close(WsCloseCode.INVALID_DATA)\n raise WebSocketError(\n \"Invalid UTF-8\", WsCloseCode.INVALID_DATA\n ) from e\n if (flags & CurlWsFlag.BINARY) or (flags & CurlWsFlag.TEXT):\n # self._emit(\"message\", msg)\n self._emit(\"message\", complete_msg)\n chunks = [] \n if flags & CurlWsFlag.CLOSE:\n keep_running = False\n self._emit(\"close\", self._close_code or 0, self._close_reason or \"\")\n except CurlError as e:\n if e.code == CurlECode.AGAIN:\n _, _, _ = select([sock_fd], [], [], 5.0)\n else:\n self._emit(\"error\", e)\n if not self.closed:\n code = 1000\n if isinstance(e, WebSocketError):\n code = e.code\n self.close(code)\n raise","author_login":"larryteal","author_association":"NONE","created_at":"2025-05-13T08:07:32+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2993642741","fragment_type":"issue_comment","sequence":12,"text":"i have the same problem with the `AsyncWebsocket` it only returns the first 8192 bytes when the message is longer than that.","author_login":"DarkWingMcQuack","author_association":"NONE","created_at":"2025-06-21T15:44:24+08:00","repo_name":"lexiforest/curl_cffi","issue_id":2829732293,"issue_number":495,"issue_url":"https://github.com/lexiforest/curl_cffi/issues/495","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0123","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"initfromthreadtest fail on Ubuntu 22 x64?","query_context":"Source: master (c94898ba7)\nBuild: URL \nHost: Ubuntu 22.04.1 LTS (Jammy) x64\nCompiler: gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0\nOccurrence: always\nHow to reproduce: ./configure --enable-gc-assertions --enable-cplusplus && make -j check CFLAGS_EXTRA=\"-D _FORTIFY_SOURCE=2 -D FIND_LEAK -D SKIP_LEAKED_OBJECTS_PRINTING\"","known_context_document_ids":["gh_issue_1648675529"],"reference_answer":"Source: master ( URL \nHost: Ubuntu 22.04.1 LTS (Jammy) x64\nOccurrence: always\nHow to reproduce: ./configure --enable-gc-assertions --enable-cplusplus && make -j check CFLAGS_EXTRA=\"-D _FORTIFY_SOURCE=2 -D FIND_LEAK -D SKIP_LEAKED_OBJECTS_PRINTING\"\nReproduced locally:\n\nThis test program is not designed for leak detection mode\nSUCCEEDED\nFound 40 leaked objects:\nAssertion failure: extra/../pthread_support.c:691\nassertion failure","answer_document_id":"gh_comment_1493294310","silver_evidence_path":["gh_comment_1497062313","gh_issue_1609646591","gh_comment_1493294310"],"evidence_issue_ids":[1648675529,1609646591],"source_repo_name":"ivmai/bdwgc","source_issue_id":1648675529,"source_issue_number":542,"source_issue_url":"https://github.com/ivmai/bdwgc/issues/542","target_repo_name":"ivmai/bdwgc","target_issue_id":1609646591,"target_issue_number":533,"target_issue_url":"https://github.com/ivmai/bdwgc/issues/533","reference_anchor_document_id":"gh_comment_1497062313","reference_answer_author":"ivmai","reference_answer_author_association":"OWNER","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.125,"target_answer_overlap":0.8333},"issue_created_at":"2023-03-31T05:04:24+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1648675529","fragment_type":"issue_description","sequence":0,"text":"initfromthreadtest fail on Ubuntu 22 x64\nSource: master (c94898ba7)\nBuild: URL \nHost: Ubuntu 22.04.1 LTS (Jammy) x64\nCompiler: gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0\nOccurrence: always\nHow to reproduce: ./configure --enable-gc-assertions --enable-cplusplus && make -j check CFLAGS_EXTRA=\"-D _FORTIFY_SOURCE=2 -D FIND_LEAK -D SKIP_LEAKED_OBJECTS_PRINTING\"","author_login":"ivmai","author_association":"OWNER","created_at":"2023-03-31T05:04:24+08:00","repo_name":"ivmai/bdwgc","issue_id":1648675529,"issue_number":542,"issue_url":"https://github.com/ivmai/bdwgc/issues/542","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1493293729","fragment_type":"issue_comment","sequence":1,"text":"Also, fail in threadkeytest (always, reproduced locally):\nThis test program is not designed for leak detection mode\nSUCCEEDED\nFound 40 leaked objects:\nAssertion failure: extra/../pthread_support.c:691\nassertion failure","author_login":"ivmai","author_association":"OWNER","created_at":"2023-04-02T10:37:26+08:00","repo_name":"ivmai/bdwgc","issue_id":1648675529,"issue_number":542,"issue_url":"https://github.com/ivmai/bdwgc/issues/542","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1495973172","fragment_type":"issue_comment","sequence":2,"text":"The scenario of the failure (on Linux):\n- Find-leak mode is on\n- pthread_create/join primitives are not redirected\n- GC is initialized from a thread other than primordial\n- that thread is terminated (but not unregistered as the 1st one in GC)\n- the primordial thread exits and launches GC_exit_check\n- GC_gcollect tries to suspend the terminated thread by sending a signal\n- the signal is not delivered but pthread_kill just returns zero\n- the signal sending is retried until aborting with the proper message.\n\nThe proposed solution (workaround) is not to call GC_gcollect at\nthe process exit (in the find-leak mode) if GC_init was called from\na thread other than primordial one.","author_login":"ivmai","author_association":"OWNER","created_at":"2023-04-04T13:27:15+08:00","repo_name":"ivmai/bdwgc","issue_id":1648675529,"issue_number":542,"issue_url":"https://github.com/ivmai/bdwgc/issues/542","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1496498418","fragment_type":"issue_comment","sequence":3,"text":"Such behavior is first observed on Ubuntu 22.04 (Jammy) x64.","author_login":"ivmai","author_association":"OWNER","created_at":"2023-04-04T19:39:12+08:00","repo_name":"ivmai/bdwgc","issue_id":1648675529,"issue_number":542,"issue_url":"https://github.com/ivmai/bdwgc/issues/542","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497062313","fragment_type":"issue_comment","sequence":4,"text":"The solution should also solve #533 (because no need to modify GC_in_thread_creation inside GC_exit_check).","author_login":"ivmai","author_association":"OWNER","created_at":"2023-04-05T07:45:23+08:00","repo_name":"ivmai/bdwgc","issue_id":1648675529,"issue_number":542,"issue_url":"https://github.com/ivmai/bdwgc/issues/542","linked_issue_ids":[1609646591],"is_known_query_context":false},{"document_id":"gh_issue_1609646591","fragment_type":"issue_description","sequence":0,"text":"GC_in_thread_creation assert violation in GC_new_thread\nSource: master (6a283de1)\nBuild: URL \nHost: Ubuntu 16.04.7 LTS (x64)\nCompiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609\nHow to build: ./autogen.sh && ./configure --enable-gc-assertions --enable-cplusplus && make -j check CFLAGS_EXTRA=\"-D _FORTIFY_SOURCE=2 -D FIND_LEAK -D SKIP_LEAKED_OBJECTS_PRINTING\"\nOutput (threadkeytest.log):\n\nFound 40 leaked objects:\nAssertion failure: extra/../pthread_support.c:724\nassertion failure\nThis test program is not designed for leak detection mode\nSUCCEEDED\nFAIL threadkeytest (exit status: 134)","author_login":"ivmai","author_association":"OWNER","created_at":"2023-03-04T06:59:19+08:00","repo_name":"ivmai/bdwgc","issue_id":1609646591,"issue_number":533,"issue_url":"https://github.com/ivmai/bdwgc/issues/533","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1493294310","fragment_type":"issue_comment","sequence":1,"text":"Source: master ( URL \nHost: Ubuntu 22.04.1 LTS (Jammy) x64\nOccurrence: always\nHow to reproduce: ./configure --enable-gc-assertions --enable-cplusplus && make -j check CFLAGS_EXTRA=\"-D _FORTIFY_SOURCE=2 -D FIND_LEAK -D SKIP_LEAKED_OBJECTS_PRINTING\"\nReproduced locally:\n\nThis test program is not designed for leak detection mode\nSUCCEEDED\nFound 40 leaked objects:\nAssertion failure: extra/../pthread_support.c:691\nassertion failure","author_login":"ivmai","author_association":"OWNER","created_at":"2023-04-02T10:39:20+08:00","repo_name":"ivmai/bdwgc","issue_id":1609646591,"issue_number":533,"issue_url":"https://github.com/ivmai/bdwgc/issues/533","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0124","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"How to add commander's high priority tasks for a settlement?","query_context":"**Is your feature request related to a problem? Please describe.**\n- The player commander is interested in constructing a building.\n- The first construction phase is constructing a foundation.\n- To pour a foundation, it needs, say 80 kg, concrete.\n- However, the concrete demand is only 490 and no one is automatically Digging Local Regolith.\n- If player can emphasize the need for the whole settlement to get on the task of Digging Local Regolith, it won't have issues getting enough regolith to mix concrete in near future.\n\n**Describe the rationale**\n- Player lacks the ability to post tasks or customize the task priority of the settlement \n\n**Describe the solution you desire to see**\n- Direct the player to use Command Dashboard's resource tab\n- In resource tab, build an UI control so that the player may adjust the **push** points (say from -3.0 to +3.0) on his top five priority task \n\n**Describe alternatives you've considered**\n- Use Monitor Tool's Task backlog\n- Add an UI control to allow player to add a task to the list and/or adjust the priority score of this task\n\n**Screenshots**\nimage\n\n**Specifications (please complete the following information):**\n - pre 3.6.0 build 8145\n\n**Additional context**\n- It's also very important to be more transparent and reveal to player what priority (in terms of showcasing scores) the settlement has in what tasks and missions are more likely to do.\n- For instance, under each space agency's mission agenda, there are particular push for certain science subjects and certain missions.","known_context_document_ids":["gh_issue_1744908845"],"reference_answer":"No. It was to add something to how we use the secondary Vehicle Status. I was sure I created an issue. I will look through my stuff and try and find it","answer_document_id":"gh_comment_2169224426","silver_evidence_path":["gh_comment_1582950594","gh_issue_1719040123","gh_comment_2169224426"],"evidence_issue_ids":[1744908845,1719040123],"source_repo_name":"mars-sim/mars-sim","source_issue_id":1744908845,"source_issue_number":908,"source_issue_url":"https://github.com/mars-sim/mars-sim/issues/908","target_repo_name":"mars-sim/mars-sim","target_issue_id":1719040123,"target_issue_number":890,"target_issue_url":"https://github.com/mars-sim/mars-sim/issues/890","reference_anchor_document_id":"gh_comment_1582950594","reference_answer_author":"bevans2000","reference_answer_author_association":"MEMBER","quality_score":93.24,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.1667,"target_answer_overlap":0.0714},"issue_created_at":"2023-06-07T02:14:22+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_1744908845","fragment_type":"issue_description","sequence":0,"text":"How to add commander's high priority tasks for a settlement\n**Is your feature request related to a problem? Please describe.**\n- The player commander is interested in constructing a building.\n- The first construction phase is constructing a foundation.\n- To pour a foundation, it needs, say 80 kg, concrete.\n- However, the concrete demand is only 490 and no one is automatically Digging Local Regolith.\n- If player can emphasize the need for the whole settlement to get on the task of Digging Local Regolith, it won't have issues getting enough regolith to mix concrete in near future.\n\n**Describe the rationale**\n- Player lacks the ability to post tasks or customize the task priority of the settlement \n\n**Describe the solution you desire to see**\n- Direct the player to use Command Dashboard's resource tab\n- In resource tab, build an UI control so that the player may adjust the **push** points (say from -3.0 to +3.0) on his top five priority task \n\n**Describe alternatives you've considered**\n- Use Monitor Tool's Task backlog\n- Add an UI control to allow player to add a task to the list and/or adjust the priority score of this task\n\n**Screenshots**\nimage\n\n**Specifications (please complete the following information):**\n - pre 3.6.0 build 8145\n\n**Additional context**\n- It's also very important to be more transparent and reveal to player what priority (in terms of showcasing scores) the settlement has in what tasks and missions are more likely to do.\n- For instance, under each space agency's mission agenda, there are particular push for certain science subjects and certain missions.","author_login":"mokun","author_association":"MEMBER","created_at":"2023-06-07T02:14:22+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1581510466","fragment_type":"issue_comment","sequence":1,"text":"@bevans2000 \n\nHow would you enable a player commander to adjust the weight of certain tasks to take place in a settlement ?","author_login":"mokun","author_association":"MEMBER","created_at":"2023-06-07T21:04:45+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1581993496","fragment_type":"issue_comment","sequence":2,"text":"Two things. Firstly the demand calculation may be wrong and in your example above it should have a higher value.\n\nI would look to define a \"weights\" ability to the Settlement class. Then when scoring Task in the TaskMeta classes a weight can be applied to the Task score. Weights greater than 1 obviously become a multiplier. But I would look to define the weights as a Map and not explicitly use any Task property. Then we could use the weights for many things but just have a single table, e.g. for Missions as well. We could potentially create a dedicated \nWeightKey\n class containing a tuple of _key type_ & _key name_. where key type is Mission, Type, Trading etc etc. You get the idea. \nUse the TaskMeta name as the key in this situation.\nThen add a new Tab to the Settlement UI that maintains/displays the weight. When adding offer the user a list of OnShift Tasks. There is no point showing the OffShift Task since these are about Persons/Robots having \"me\" time.\n\nSounds a nice feature to influence how a Settlement behaves and is reusable elsewhere.\n\nPotentially, could pre-fill the weights based on the Objectives of the Reporting Authority. Now that is cool.","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-06-08T06:57:49+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1582088593","fragment_type":"issue_comment","sequence":3,"text":"I've plowed through the supply chain to find out why concrete is not being produced in the last couple commits.\n\nIt works reasonably well now in response to constructing foundation.\n\nStill the concept of having commander's high priority tasks would be a great addition in near future.\n \n\nFor now, I use assignTask() in BuildingConstructionMission to add a task to a person. It's not a good way.\n\nRoverMission is using assignTask() as well.\n\nCan you show me how to implement your approach in RoverMission and/or BuildingConstructionMission ?","author_login":"mokun","author_association":"MEMBER","created_at":"2023-06-08T07:59:04+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1582914283","fragment_type":"issue_comment","sequence":4,"text":"Yes, good idea. It is a Settlement based score so a good match. I'll do it under the control of #910","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-06-08T15:59:26+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1582950594","fragment_type":"issue_comment","sequence":5,"text":"Assigning a Task directly to a Worker as part of the Mission is fine. THe Worker would not be calling the Mission methods if they have a Task already assigned.\n \n\nSure, why don't I try and put something together tonight/tomorrow. I can put #890 on hold; a change would be good as that is hard going.","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-06-08T16:11:17+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[1719040123],"is_known_query_context":false},{"document_id":"gh_comment_1583340848","fragment_type":"issue_comment","sequence":6,"text":"We can combine the science and mission modifiers on the ReportingAuthority into this same single solution. This will have the advantage of all these being editable as well. \nSecondly, the enabled Mission flags in Settlement can be handled by the logic, setting the weight to zero will disable the mission for that Settlement.\nI've got a simple version working and need to add an editable UI screen","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-06-08T21:04:15+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583362997","fragment_type":"issue_comment","sequence":7,"text":"But say we define the base score as non-sero. Then when we modify this score by multiplication, it won't result in zero.\n\nSay if the base score is 1, and your modifier is 0.5. Then 1 x 0.5 is 0.5","author_login":"mokun","author_association":"MEMBER","created_at":"2023-06-08T21:25:01+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583389038","fragment_type":"issue_comment","sequence":8,"text":"Can we add this to under one of 7 division tabs in Command Dashboard ?","author_login":"mokun","author_association":"MEMBER","created_at":"2023-06-08T21:34:37+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583431461","fragment_type":"issue_comment","sequence":9,"text":"We could but it is per Settlement and prefilled according to the objective of the Reporting Authority.","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-06-08T21:45:45+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585818766","fragment_type":"issue_comment","sequence":10,"text":"@bevans2000\n\nThis tab is awesome. I'm playing with the modifier score below for \"Digging Local Ice\" TASK : \nimage\n\n@Urwumpe How do you like this new UI ?\n\nI was gonna say one thing I'll like to see in future is to clearly disclose to players how each MISSION/TASK/SCIENCE score is computed. \n\nAnd we know this sort of transparency is needed and highly desired in strategy games out there. \n\nFor instance, say the birth rate of a city is -0.7. Why would it be negative ? That means people in this city won't give birth to babies and it would be disaster for growth. So the player would like to know how this composite penalty score of -0.7 is computed. \n\nIt turns out \n1. the city only allocates 80% of funding (thus -0.2; say, each 1% is -0.01 penalty) for the medical category needs of this city.\n2. the road to medical clinic is broken (thus -0.1) in this city.\n3. the city only has one clinic while there are 10,000 population. Say each 2,000 pop needs one clinic. So it's missing 4 clinics and thus the penalty of -0.4 (=4 * -0.1) \n\nSimilarly, we could show in the detail breakdown of each row of score with a short individual reason with a sub-score in the form of tooltip or other UI elements.\n\nCan we do that ?","author_login":"mokun","author_association":"MEMBER","created_at":"2023-06-10T21:21:07+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585827622","fragment_type":"issue_comment","sequence":11,"text":"I first want to say \"Hell, no!\". Sorry. \n\nEspecially since attribution science is one of the hardest and interpretation rich sciences in the world.\n\nThinking a bit further, maybe we can simplify things in our simulated world enough to \"gamify\" it. I have no good answer there yet, but for now, maybe the following idea is not as crazy as it sounds. \n\n1. There are multiple different approaches to write a study, which are limited by the field of science. Social sciences vs natural sciences vs engineering...\n2. The scientist picks one approach for a new study.\n3. Depending on approach, there can be one or more data sources.\n4. Also there are one or more methods to interact with the data sources\n5. There are also methods that turn objects (e.g. soil samples, interviews with settlers) into data sources, which might be the usage of certain tools\n6. The data sources have an interface that fits to the method\n7. Methods can create new derived data sources\n8. Data sources can be interpreted according to models/theories/collaries/etc.\n9. Interpretations on input data and derived data can classify these and with a interpretations of the results turned into a new theory/model.\n10. Models can be tested by other science projects, especially if there might be different methods/tools available to produce the same kind of data source used.\n11. Still a lot of magic happening there, this is no good algorithm.","author_login":"Urwumpe","author_association":"CONTRIBUTOR","created_at":"2023-06-10T22:02:01+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585833640","fragment_type":"issue_comment","sequence":12,"text":"You are one step ahead of me. \n\nActually I mean: Telling that a certain change has a clear root cause. Like creating a fishbone diagram and interpreting it.","author_login":"Urwumpe","author_association":"CONTRIBUTOR","created_at":"2023-06-10T22:16:27+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585846226","fragment_type":"issue_comment","sequence":13,"text":"Glad you like it. I feel it consolidates and cleans up a few different areas into a single approach. And it uses the the ReportingAuthority to load it to start with which I like.\nPlus I've done it so we could add other types later.","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-06-10T23:16:34+08:00","repo_name":"mars-sim/mars-sim","issue_id":1744908845,"issue_number":908,"issue_url":"https://github.com/mars-sim/mars-sim/issues/908","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1719040123","fragment_type":"issue_description","sequence":0,"text":"Create a new TestDrive Mission\nCreate a new Mission instance based on the new Mission Project approach. This will cover the basic steps of a Mission:\n\n1. Review\n2. Load Vehicle\n3. Embark\n4. Drive \n5. Disembark","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-05-22T07:07:02+08:00","repo_name":"mars-sim/mars-sim","issue_id":1719040123,"issue_number":890,"issue_url":"https://github.com/mars-sim/mars-sim/issues/890","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560008398","fragment_type":"issue_comment","sequence":1,"text":"Sounds good. \n\nAnd can we demonstrate how to use it to create, say, a division or department meeting, where all Engineering specialists are invited ?","author_login":"mokun","author_association":"MEMBER","created_at":"2023-05-23T19:25:40+08:00","repo_name":"mars-sim/mars-sim","issue_id":1719040123,"issue_number":890,"issue_url":"https://github.com/mars-sim/mars-sim/issues/890","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560071675","fragment_type":"issue_comment","sequence":2,"text":"Yes we can build on it. A test drive mission encapsulates the key parts of a generic Mission.","author_login":"bevans2000","author_association":"CONTRIBUTOR","created_at":"2023-05-23T20:21:09+08:00","repo_name":"mars-sim/mars-sim","issue_id":1719040123,"issue_number":890,"issue_url":"https://github.com/mars-sim/mars-sim/issues/890","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560325454","fragment_type":"issue_comment","sequence":3,"text":"Can you put together an example by codes on how to create a team meeting ?","author_login":"mokun","author_association":"MEMBER","created_at":"2023-05-24T01:17:23+08:00","repo_name":"mars-sim/mars-sim","issue_id":1719040123,"issue_number":890,"issue_url":"https://github.com/mars-sim/mars-sim/issues/890","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2169224426","fragment_type":"issue_comment","sequence":4,"text":"No. It was to add something to how we use the secondary Vehicle Status. I was sure I created an issue. I will look through my stuff and try and find it","author_login":"bevans2000","author_association":"MEMBER","created_at":"2024-06-15T08:56:14+08:00","repo_name":"mars-sim/mars-sim","issue_id":1719040123,"issue_number":890,"issue_url":"https://github.com/mars-sim/mars-sim/issues/890","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0125","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"C variable array length?","query_context":"Since the C99 version, arrays can be declared with a dimension from a variable. For example:\nint length = 12;\nchar myArray[length];\n\nThe plugin detects this C feature as an error:\nthe expression must have a constant value C / C ++ (28)\n\nThere are so many differences between C and C ++ that, possibly, different extensions should be created according to the peculiarities of each language.","known_context_document_ids":["gh_issue_1091825691"],"reference_answer":"It looks like the remaining two issues blocking this have been fixed. Maybe we can enable MS extensions for Cygwin and MinGW by default now?","answer_document_id":"gh_comment_1428985420","silver_evidence_path":["gh_comment_1016803328","gh_issue_1041516788","gh_comment_1428985420"],"evidence_issue_ids":[1091825691,1041516788],"source_repo_name":"microsoft/vscode-cpptools","source_issue_id":1091825691,"source_issue_number":8620,"source_issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","target_repo_name":"microsoft/vscode-cpptools","target_issue_id":1041516788,"target_issue_number":8353,"target_issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8353","reference_anchor_document_id":"gh_comment_1016803328","reference_answer_author":"Colengms","reference_answer_author_association":"COLLABORATOR","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.0667,"target_answer_overlap":0.2143},"issue_created_at":"2022-01-01T14:14:11+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1091825691","fragment_type":"issue_description","sequence":0,"text":"C variable array length\nSince the C99 version, arrays can be declared with a dimension from a variable. For example:\nint length = 12;\nchar myArray[length];\n\nThe plugin detects this C feature as an error:\nthe expression must have a constant value C / C ++ (28)\n\nThere are so many differences between C and C ++ that, possibly, different extensions should be created according to the peculiarities of each language.","author_login":"Ak4n0","author_association":"NONE","created_at":"2022-01-01T14:14:11+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1003654234","fragment_type":"issue_comment","sequence":1,"text":"@TheJoshuaTerry With GCC and the -std=c11 switch it compiles well, but VSCode marks it as an error.","author_login":"Ak4n0","author_association":"NONE","created_at":"2022-01-02T02:36:25+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004361772","fragment_type":"issue_comment","sequence":2,"text":"Yes, this is the same as URL and should be fixed in our next insiders and the root cause is being tracked by an internal bug (see URL","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2022-01-03T21:11:57+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[1041516788],"is_known_query_context":false},{"document_id":"gh_comment_1004362339","fragment_type":"issue_comment","sequence":3,"text":"You should be able to work around it by adding a compilerArg of -fno-ms-extensions","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2022-01-03T21:12:56+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004363952","fragment_type":"issue_comment","sequence":4,"text":"@bobbrow We could ship 1.8.0-insiders3 this week instead of next week if we think a lot of users are hitting this (or related regressions).","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2022-01-03T21:15:35+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1004372025","fragment_type":"issue_comment","sequence":5,"text":"There's a lot of stuff in flight for insiders3 so I'd like to wait until @Colengms is back and do it next week. There is a known work around for this issue (or folks can jump back to the stable release if it's severely impacting). We'll be in a much better place to do quick insiders updates when we start using the Marketplace features next week.","author_login":"bobbrow","author_association":"MEMBER","created_at":"2022-01-03T21:29:43+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016803328","fragment_type":"issue_comment","sequence":6,"text":"Fixed with URL or 1.8.0 (via using VS Code's \"Pre-Release Version\" UI or URL ).\n\nUnless you're explicitly adding -fms-extensions, in which case that bug fix is still pending ( URL ).","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2022-01-19T19:36:42+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1091825691,"issue_number":8620,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8620","linked_issue_ids":[1041516788],"is_known_query_context":false},{"document_id":"gh_issue_1041516788","fragment_type":"issue_description","sequence":0,"text":"MS extensions should be enabled by default for Cygwin\nThis is derived from: URL \n\nApparently (based on experimentation), Cygwin supports MS Extensions despite not returning the associated define (`_MSC_EXTENSIONS`).\n\nOpening this issue to track enabling MS Extensions for Cygwin gcc, by default.","author_login":"Colengms","author_association":"COLLABORATOR","created_at":"2021-11-01T19:29:57+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1041516788,"issue_number":8353,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_993039320","fragment_type":"issue_comment","sequence":1,"text":"Re-opening and using to track re-enabling of `ms_extensions` by default for Cygwin and MinGW.\n\nWe have some known bugs (internally: 1447675, 1450571) with `ms_extensions` on gcc, which we'd like to address before enabling this by default. Users can manually enable it by adding `-fms_extensions` as a compiler arg.","author_login":"Colengms","author_association":"COLLABORATOR","created_at":"2021-12-14T00:31:48+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1041516788,"issue_number":8353,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8353","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1428985420","fragment_type":"issue_comment","sequence":2,"text":"It looks like the remaining two issues blocking this have been fixed. Maybe we can enable MS extensions for Cygwin and MinGW by default now?","author_login":"Colengms","author_association":"COLLABORATOR","created_at":"2023-02-14T01:49:02+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":1041516788,"issue_number":8353,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/8353","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0126","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Enhance NFS Mount Efficiency with Stage/Unstage Volume Capability?","query_context":"**Is your feature request related to a problem?/Why is this needed**\n \n\n**Describe the solution you'd like in detail**\n \n\nI would like to propose an enhancement that focuses on optimizing NFS mount operations. This feature aims to improve resource utilization and reduce startup times for pods accessing NFS servers. A similar mounting behaviour exists on the ebs csidriver or juicefs csidriver. \n\nThe core idea is to introduce an option that leverages the stage and unstage volume capabilities of the CSI driver. The proposed changes include:\n\n* Single NFS Server Mount: Mount the NFS server only once for each unique combination of server name, export name, and mount options.\n\n* Bind Mounts for Pods: Implement actual bind mounts for each pod accessing the NFS server. This approach should also support subpaths for each pod.\n\n* Mount Management: Ensure that the mount operation occurs once per unique combination mentioned above, preventing redundant mounts (or simply the volumeid of the pv).\n\nThis enhancement brings several key benefits:\n\n* Reduced Mount Operations: By mounting the NFS server less frequently, we can significantly reduce the number of mount operations that the NFS server has to handle.\n\n* Improved Cache Utilization: With fewer mounts, cache usage becomes more efficient, enhancing overall system performance.\n\n* Faster Startup Times for Pods: Pods accessing the NFS server will experience quicker startup times, leading to more efficient deployments and scaling operations.\n\n**Describe alternatives you've considered**\n \n\nAn alternative could be using a daemonset which mounts the nfs servers to the host, which then are bind mounted via hostpath into the pod. The problem is here that it hides the fact in the pod that a nfs is used and could be less reliable. \n\n**Additional context**","known_context_document_ids":["gh_issue_2054692269"],"reference_answer":"@gnufied for `fsGroupChangePolicy` support, I figured out why I made such implementation for NFS at that time, this driver(including smb and nfs) Supports CSIVolumeMountGroup, while CSIVolumeMountGroup is mainly for smb, not for nfs, but nfs shares the same driver config as smb, and due to this code snippet:\n\nif !driverSupportsCSIVolumeMountGroup && c.supportsFSGroup(fsType, mounterArgs.FsGroup, fsGroupPolicy) {\n\n URL \n\nI have to make some workaround, otherwise `volume.SetVolumeOwnership` would never happen on azure file nfs volume. Current azure file nfs & smb volume mount actually happens in `NodeStageVolume` interface, so this `fsGroupChangePolicy` property is already a per volume property now, the implementation is already slightly different from URL which only implements `NodePublishVolume` interface","answer_document_id":"gh_comment_1517861487","silver_evidence_path":["gh_comment_1868413313","gh_issue_1676507860","gh_comment_1517861487"],"evidence_issue_ids":[2054692269,1676507860],"source_repo_name":"kubernetes-csi/csi-driver-nfs","source_issue_id":2054692269,"source_issue_number":573,"source_issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","target_repo_name":"kubernetes-sigs/azurefile-csi-driver","target_issue_id":1676507860,"target_issue_number":1224,"target_issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","reference_anchor_document_id":"gh_comment_1868413313","reference_answer_author":"andyzhangx","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1591,"anchor_target_overlap":0.2727,"target_answer_overlap":0.1176},"issue_created_at":"2023-12-23T06:33:05+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2054692269","fragment_type":"issue_description","sequence":0,"text":"Enhance NFS Mount Efficiency with Stage/Unstage Volume Capability\n**Is your feature request related to a problem?/Why is this needed**\n \n\n**Describe the solution you'd like in detail**\n \n\nI would like to propose an enhancement that focuses on optimizing NFS mount operations. This feature aims to improve resource utilization and reduce startup times for pods accessing NFS servers. A similar mounting behaviour exists on the ebs csidriver or juicefs csidriver. \n\nThe core idea is to introduce an option that leverages the stage and unstage volume capabilities of the CSI driver. The proposed changes include:\n\n* Single NFS Server Mount: Mount the NFS server only once for each unique combination of server name, export name, and mount options.\n\n* Bind Mounts for Pods: Implement actual bind mounts for each pod accessing the NFS server. This approach should also support subpaths for each pod.\n\n* Mount Management: Ensure that the mount operation occurs once per unique combination mentioned above, preventing redundant mounts (or simply the volumeid of the pv).\n\nThis enhancement brings several key benefits:\n\n* Reduced Mount Operations: By mounting the NFS server less frequently, we can significantly reduce the number of mount operations that the NFS server has to handle.\n\n* Improved Cache Utilization: With fewer mounts, cache usage becomes more efficient, enhancing overall system performance.\n\n* Faster Startup Times for Pods: Pods accessing the NFS server will experience quicker startup times, leading to more efficient deployments and scaling operations.\n\n**Describe alternatives you've considered**\n \n\nAn alternative could be using a daemonset which mounts the nfs servers to the host, which then are bind mounted via hostpath into the pod. The problem is here that it hides the fact in the pod that a nfs is used and could be less reliable. \n\n**Additional context**","author_login":"woehrl01","author_association":"CONTRIBUTOR","created_at":"2023-12-23T06:33:05+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1868413313","fragment_type":"issue_comment","sequence":1,"text":"@woehrl01 thanks for raising this issue. I agree add `NodeStageVolume` support would reduce the nfs mount since it's per pv mount per node, while it would raise the other issue, e.g. `NodeStageVolume` does not respect `fsGroupChangePolicy` (SecurityConext support), `NodePublishVolume` does, you could find more details here: URL \n\nThere is a performance and k8s compliance tradeoff between whether supports `NodeStageVolume` or not, I am not sure what's the right way for such requirement.\n\ncc @jsafrane @gnufied any ideas whether we need to implement `NodeStageVolume` or not?","author_login":"andyzhangx","author_association":"MEMBER","created_at":"2023-12-24T02:02:16+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[1676507860],"is_known_query_context":false},{"document_id":"gh_comment_1868456380","fragment_type":"issue_comment","sequence":2,"text":"@andyzhangx thank you for mentioning this problem, I wasn't aware of this discussions, yet.\n\nI'm curious if this actually is an issue in that case. If the stage volume is only creating the initial mount for the export root of the nfs server. The publish volume step can still set the fsgroup on the actual (sub) mount point which is created by the bind mount.\n\nAs I'm not an expert in fsgroup, what am I missing in that case?","author_login":"woehrl01","author_association":"CONTRIBUTOR","created_at":"2023-12-24T07:57:07+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868458004","fragment_type":"issue_comment","sequence":3,"text":"@woehrl01 support you have a nfs mount with gid=x, and then set gid=y in bind mount path, then the original nfs mount would also have gid=y","author_login":"andyzhangx","author_association":"MEMBER","created_at":"2023-12-24T08:05:26+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868465590","fragment_type":"issue_comment","sequence":4,"text":"@andyzhangx I see, thank you. That's an interesting behaviour I wasn't aware about.\n\nI found URL which could be a possible solution for that bind mount behaviour.\n\nIt still would be great to have this option as a featureflag, if this behaviour of fsgroup is documented.","author_login":"woehrl01","author_association":"CONTRIBUTOR","created_at":"2023-12-24T08:49:20+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016428016","fragment_type":"issue_comment","sequence":5,"text":"The Kubernetes project currently lacks enough contributors to adequately respond to all issues.\n\nThis bot triages un-triaged issues according to the following rules:\n- After 90d of inactivity, `lifecycle/stale` is applied\n- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied\n- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed\n\nYou can:\n- Mark this issue as fresh with `/remove-lifecycle stale`\n- Close this issue with `/close`\n- Offer to help out with [Issue Triage][1]\n\nPlease send feedback to sig-contributor-experience at kubernetes/community.\n\n/lifecycle stale\n\n[1]: URL","author_login":"k8s-triage-robot","author_association":"NONE","created_at":"2024-03-23T09:42:53+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2182448816","fragment_type":"issue_comment","sequence":6,"text":"The Kubernetes project currently lacks enough contributors to adequately respond to all issues.\n\nThis bot triages un-triaged issues according to the following rules:\n- After 90d of inactivity, `lifecycle/stale` is applied\n- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied\n- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed\n\nYou can:\n- Mark this issue as fresh with `/remove-lifecycle stale`\n- Close this issue with `/close`\n- Offer to help out with [Issue Triage][1]\n\nPlease send feedback to sig-contributor-experience at kubernetes/community.\n\n/lifecycle stale\n\n[1]: URL","author_login":"k8s-triage-robot","author_association":"NONE","created_at":"2024-06-21T10:11:56+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2373956325","fragment_type":"issue_comment","sequence":7,"text":"The Kubernetes project currently lacks enough contributors to adequately respond to all issues.\n\nThis bot triages un-triaged issues according to the following rules:\n- After 90d of inactivity, `lifecycle/stale` is applied\n- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied\n- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed\n\nYou can:\n- Mark this issue as fresh with `/remove-lifecycle stale`\n- Close this issue with `/close`\n- Offer to help out with [Issue Triage][1]\n\nPlease send feedback to sig-contributor-experience at kubernetes/community.\n\n/lifecycle stale\n\n[1]: URL","author_login":"k8s-triage-robot","author_association":"NONE","created_at":"2024-09-25T12:32:26+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438530441","fragment_type":"issue_comment","sequence":8,"text":"Based on our production experince with the NFS CSI driver over the past month, this is not necessary in my opinion.","author_login":"woehrl01","author_association":"CONTRIBUTOR","created_at":"2024-10-25T18:15:04+08:00","repo_name":"kubernetes-csi/csi-driver-nfs","issue_id":2054692269,"issue_number":573,"issue_url":"https://github.com/kubernetes-csi/csi-driver-nfs/issues/573","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1676507860","fragment_type":"issue_description","sequence":0,"text":"NFS support violates CSI spec\nThe NFS support in CSI driver directly violates CSI spec:\n\n/ If SP has VOLUME_MOUNT_GROUP node capability and CO provides\n // this field then SP MUST ensure that the volume_mount_group\n // parameter is passed as the group identifier to the underlying\n // operating system mount system call, \n\nThe above wording makes it clear that provided `volume_mount_group` should be used as a mount option for `mount` system call. But NFS driver instead uses it to recurively `chown` and `chmod` volumes.\n\nThe support in CSI driver also breaks several Kubernetes conventions. The `file` or `mount` properties of CSI driver should be configurable via `CSIDriver` object. The `fsGroupChangePolicy` should come from pod object (instead of being configurable in StorageClass).","author_login":"gnufied","author_association":"CONTRIBUTOR","created_at":"2023-04-20T11:07:15+08:00","repo_name":"kubernetes-sigs/azurefile-csi-driver","issue_id":1676507860,"issue_number":1224,"issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1516189012","fragment_type":"issue_comment","sequence":1,"text":"@gnufied thanks for raising the issue.\n1. `volume_mount_group` issue: since nfs mount does not support gid setting, use `chown` and `chmod` is the only way\n2. I think it's discussed here for `fsGroupChangePolicy` : URL `CSIDriver` object is a managed (immutable) object on managed k8s cluster(.e.g. AKS), fields in `CSIDriver` cannot be changed, and providing a `fsGroupChangePolicy` parameter is more feasible for different user requirements since `CSIDriver` can only use one fixed value.","author_login":"andyzhangx","author_association":"MEMBER","created_at":"2023-04-20T11:46:38+08:00","repo_name":"kubernetes-sigs/azurefile-csi-driver","issue_id":1676507860,"issue_number":1224,"issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1516316949","fragment_type":"issue_comment","sequence":2,"text":"Let me clarify why it is important that we don't duplicate what kubelet is supposed to do in the driver. It is because several of internal k8s bits depends on kubelet's behaviour. Take subpath support for example, that code subtley depends on `sgid` bit set on the parent directory.\n\nThen there is integration with CRI for id-mapped mounts etc being proposed. All of this depends on letting kubelet do its own things and not duplicate the functionality.","author_login":"gnufied","author_association":"CONTRIBUTOR","created_at":"2023-04-20T13:19:53+08:00","repo_name":"kubernetes-sigs/azurefile-csi-driver","issue_id":1676507860,"issue_number":1224,"issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1517861487","fragment_type":"issue_comment","sequence":3,"text":"@gnufied for `fsGroupChangePolicy` support, I figured out why I made such implementation for NFS at that time, this driver(including smb and nfs) Supports CSIVolumeMountGroup, while CSIVolumeMountGroup is mainly for smb, not for nfs, but nfs shares the same driver config as smb, and due to this code snippet:\n\nif !driverSupportsCSIVolumeMountGroup && c.supportsFSGroup(fsType, mounterArgs.FsGroup, fsGroupPolicy) {\n\n URL \n\nI have to make some workaround, otherwise `volume.SetVolumeOwnership` would never happen on azure file nfs volume. Current azure file nfs & smb volume mount actually happens in `NodeStageVolume` interface, so this `fsGroupChangePolicy` property is already a per volume property now, the implementation is already slightly different from URL which only implements `NodePublishVolume` interface","author_login":"andyzhangx","author_association":"MEMBER","created_at":"2023-04-21T13:47:46+08:00","repo_name":"kubernetes-sigs/azurefile-csi-driver","issue_id":1676507860,"issue_number":1224,"issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1520348803","fragment_type":"issue_comment","sequence":4,"text":"One thing I was thinking about to get out of this situation is to have two CSI drivers, one for NFS and second for CIFS. They can be handled by the same azurefile-csi-driver binary, just with a different cmdline options to set their own respective driver name + CSIDriver instance with their own fsGroupPolicy. As downside, there would be two DaemonSets + Deployments with the controllers.\n\nIn the future, I could imagine even one Pod (driver + sidecars) handling two or more CSI drivers, but that would probably need bigger changes in the sidecars - the driver would expose two sockets + a sidecar would connect to both of them + route all CSI calls to the right one.","author_login":"jsafrane","author_association":"CONTRIBUTOR","created_at":"2023-04-24T15:02:34+08:00","repo_name":"kubernetes-sigs/azurefile-csi-driver","issue_id":1676507860,"issue_number":1224,"issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1540222195","fragment_type":"issue_comment","sequence":5,"text":"@jsafrane the nfs one should run as `--set feature.enableVolumeMountGroup=false --set feature.fsGroupPolicy=File`, maintaining two drivers would cost more efforts while it should be more compliant, since you are the openshift owner, it's up to you.","author_login":"andyzhangx","author_association":"MEMBER","created_at":"2023-05-09T14:19:25+08:00","repo_name":"kubernetes-sigs/azurefile-csi-driver","issue_id":1676507860,"issue_number":1224,"issue_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1224","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0127","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Shortened output registration or signing phase disrupts round?","query_context":"Together with @szymonlesisz we found the following issue.\n\nThe WabiSabi coordinator implements the following mechanism:\n * If the connection confirmation phase of a round has expired, there exists an Alice who has not confirmed her input and there are enough Alices in the round, then the output registration phase is shortened from 6 to 3 minutes.\n * If the output registration confirmation phase of a round has expired, there exists an Alice who has not sent the ready-to-sign request, then the signing phase is shortened from 4 to 1 minute.\n\nThe mechanism doesn't work properly for the following reasons:\n * Wasabi wallet registers outputs from the time when the reissuance is finished to the time when 80 % of the expected duration of the output registration phase has passed. The problem is the coordinator does not notify clients that the output registration phase was shortened. As a result, many clients don't manage to register their outputs, they refuse to sign the final transaction, their inputs are banned and the round is disrupted.\n * The signing phase which lasts for one minute may be too short for Trezor users. I don't have exact number, but signing coinjoin transaction on Trezor can take 30 seconds. If the TOR is laggy, the remaining 30 seconds is not enough for delivery of the signature.","known_context_document_ids":["gh_issue_1760722819"],"reference_answer":"Guys, do you have any plans on how to continue with this? Either get into consensus or conclusion or closing, maybe modify the scope to be more accurate?","answer_document_id":"gh_comment_1667694321","silver_evidence_path":["gh_comment_1596749649","gh_issue_1760706300","gh_comment_1667694321"],"evidence_issue_ids":[1760722819,1760706300],"source_repo_name":"zkSNACKs/WalletWasabi","source_issue_id":1760722819,"source_issue_number":10901,"source_issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","target_repo_name":"zkSNACKs/WalletWasabi","target_issue_id":1760706300,"target_issue_number":10900,"target_issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","reference_anchor_document_id":"gh_comment_1596749649","reference_answer_author":"molnard","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1509,"anchor_target_overlap":0.1321,"target_answer_overlap":0.0},"issue_created_at":"2023-06-16T14:12:41+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1760722819","fragment_type":"issue_description","sequence":0,"text":"Shortened output registration or signing phase disrupts round\nTogether with @szymonlesisz we found the following issue.\n\nThe WabiSabi coordinator implements the following mechanism:\n * If the connection confirmation phase of a round has expired, there exists an Alice who has not confirmed her input and there are enough Alices in the round, then the output registration phase is shortened from 6 to 3 minutes.\n * If the output registration confirmation phase of a round has expired, there exists an Alice who has not sent the ready-to-sign request, then the signing phase is shortened from 4 to 1 minute.\n\nThe mechanism doesn't work properly for the following reasons:\n * Wasabi wallet registers outputs from the time when the reissuance is finished to the time when 80 % of the expected duration of the output registration phase has passed. The problem is the coordinator does not notify clients that the output registration phase was shortened. As a result, many clients don't manage to register their outputs, they refuse to sign the final transaction, their inputs are banned and the round is disrupted.\n * The signing phase which lasts for one minute may be too short for Trezor users. I don't have exact number, but signing coinjoin transaction on Trezor can take 30 seconds. If the TOR is laggy, the remaining 30 seconds is not enough for delivery of the signature.","author_login":"onvej-sl","author_association":"CONTRIBUTOR","created_at":"2023-06-16T14:12:41+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760722819,"issue_number":10901,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1595694069","fragment_type":"issue_comment","sequence":1,"text":"Wasabi Wallet heavily relies on rapid blame rounds happening one after another. The current speed is already much worse than it should be.\n \n\nClients behave properly. Excuse me for not digging into the code, but when we worked it out, the only issue remaining was the UI feedback, the clients do not mess up their registrations, because the request randomization does not fill out the entire phase time, but only the beginning of it.\n \n\nThere are some, sometimes. Which is not a bug, but a feature, because clients those have unreliable connections (be it Tor or local) are more likely to disrupt rounds later on, so penalization is in order.\n \n\nIf you get the exact numbers, then we can potentially increase this with that number. It would probably not slow things down much.","author_login":"nopara73","author_association":"COLLABORATOR","created_at":"2023-06-17T09:44:32+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760722819,"issue_number":10901,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1596039945","fragment_type":"issue_comment","sequence":2,"text":"according to CoinjoinClient.cs randomization takes 80% of the time:\n\nvar remainingTime = roundParameters.OutputRegistrationTimeout - RoundStatusUpdater.Period;\nvar outputRegistrationEndTime = now + (remainingTime * 0.8); // 80% of the time.\nvar outputRegistrationScheduledDates = GetScheduledDates(outputTxOuts.Length, outputRegistrationEndTime, MaximumRequestDelay);\n\nwhich in case of 6 minutes of OutputRegistrationTimeout is 4:48 min. \nand this value exceeds shortened timeout by 1:48 min (more than 50% of FailFastOutputRegistrationTimeout)\n \n\nWe were debugging specific round (`eebc32ea...` see integrations chat) and noticed that almost 10% of the amount from the sum of all registered inputs didn't managed to register their outputs leading to 23 banned inputs at the end of that round.\nI'm not sure if they might be considered as some and sometimes.\nWe could assume that all of them are trezor/suite users which didnt deliver final signatures because of missing affiliate data at the end, but are they really? 🤷 \n\nRound (eebc32ea8208ba6ca1389a75f395e76ed403e6d322ba0e64b56bb8949d701c15): Removed 23 alices, because they didn't sign. Remaining: 169\n\n \n\nMaybe coordinator should end this round and immediately create a blame round instead of using \"FailFast timeouts\" and forcing clients to sign \"reasonable transactions\" which most likely will not be broadcasted anyway?","author_login":"szymonlesisz","author_association":"NONE","created_at":"2023-06-18T08:52:23+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760722819,"issue_number":10901,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1596586354","fragment_type":"issue_comment","sequence":3,"text":"Check out how those things are used. Every random scheduling is corrected to maximum 10 seconds:\n\ncs\nprivate static readonly TimeSpan MaximumRequestDelay = TimeSpan.FromSeconds(10);\nvar outputRegistrationScheduledDates = GetScheduledDates(outputTxOuts.Length, outputRegistrationEndTime, MaximumRequestDelay);\n\nWith this information in mind. I assume you're not doing this? If so, then your \"banned issue\" can be easily solved by starting to do this as well?","author_login":"nopara73","author_association":"COLLABORATOR","created_at":"2023-06-19T06:28:59+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760722819,"issue_number":10901,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1596749649","fragment_type":"issue_comment","sequence":4,"text":"well, to be honest trezor suite currently has (intentionally) disabled output-registration delays (with a todo to enable them)\nbut i wasn't aware that the delay is limited to 10 sec. only, thanks for explanation, we will implement the same mechanism :+1: \n\nin mentioned round suite instance which provided the logs was able to successfully finish the whole process in ~17 seconds (5x credential-issuance, 5x output-registration, 3 ready-to-sign) and at the end it was banned only because of missing affiliate data issue\n\nit was someone else who didn't managed to register mentioned outputs (either other suite or wasabiwallet) and this is why we focused on your code","author_login":"szymonlesisz","author_association":"NONE","created_at":"2023-06-19T08:33:31+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760722819,"issue_number":10901,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","linked_issue_ids":[1760706300],"is_known_query_context":false},{"document_id":"gh_comment_1598901749","fragment_type":"issue_comment","sequence":5,"text":"Thank you, this is what we were doing wrong. \n\nClosing this issue in favour of URL and URL","author_login":"onvej-sl","author_association":"CONTRIBUTOR","created_at":"2023-06-20T14:27:18+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760722819,"issue_number":10901,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10901","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1760706300","fragment_type":"issue_description","sequence":0,"text":"Removing Alices who have already spent their inputs doesn't work\nTogether with @szymonlesisz we found the following issue. Part of the issue is a special case of URL that was discovered a few months ago.\n\nBefore the output registration phase starts, the WabiSabi coordinator removes the Alices who have already spent their inputs. I can see two bugs in this piece of code:\n\n * These Alices are removed only if the connection confirmation phase has expired and there exists an Alice that did not confirmed her input. I think the Alices who have already spent their inputs should be removed even if all Alices confirmed their inputs.\n * When an Alice confirms her input, the input is appended to the coinjoin transaction that is being coordinated. Although the coordinator removes the Alices who have already spent their inputs, they don't remove the corresponding inputs from the transaction. This fact has these two consequences :\n\n * The transaction can never be broadcasted because it double spends an input.\n * The discrepancy between the list of Alices and the transaction results in throwing the following exception while finalizing the transaction:\n \n\n 2023-06-14 15:01:27.364 [735] ERROR EventHandlerExtensions.SafeInvoke (15) System.Collections.Generic.KeyNotFoundException: The given key *** was not present in the dictionary.\n \n\n As a result, the coordinator never sends the coinjoin notification to affiliate servers, which means Trezor users don't sign the transaction and their inputs are banned.","author_login":"onvej-sl","author_association":"CONTRIBUTOR","created_at":"2023-06-16T14:04:45+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1640351721","fragment_type":"issue_comment","sequence":1,"text":"We don't remove Alices anymore and when someone spent we cancel the round.","author_login":"lontivero","author_association":"COLLABORATOR","created_at":"2023-07-18T14:35:46+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642016581","fragment_type":"issue_comment","sequence":2,"text":"This is just nitpicking about my statement. You rely too much on correct wording. Let me rephrase it:\n\nIn my opinion, a round should be cancelled if\n * there is an Alice that spent her input.\n\nThe current state is that a round is cancelled if\n * there is an Alice that didn't confirmed her input _and_\n * there is an Alice that spent her input.","author_login":"onvej-sl","author_association":"CONTRIBUTOR","created_at":"2023-07-19T12:44:10+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642165745","fragment_type":"issue_comment","sequence":3,"text":"No, this is not about wording, this is about the scope of the change. The scope of this change is to avoid having inconsistent data structures (Round::Alices and CoinJoinState::Inputs) because that results in all kind of problems. The only way to do it just by not removing alices. That's what #10914 does.\n\nOnce we have these two lists onsync we can tackle the next problem: what to do when an alice spends. That's a different discussion, one that we still didn't have. In #10914 we cancel the rounds but that's something that is still under discussion. Finally, the detection of double spending coins participating in coinjoins is something we are working on right now and in case we decide to abort a round when a participating coin is spent that policy should apply not only for connection confirmation but for all the phases, except input registration.","author_login":"lontivero","author_association":"COLLABORATOR","created_at":"2023-07-19T14:12:04+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642290899","fragment_type":"issue_comment","sequence":4,"text":"I don't want to be excessively argumentative but the scope was given by the first post in this issue. In this post, I wrote there were _two_ problems. One of them was solved by URL @molnard asked if it was ok to close this issue. I said the other problem hadn't been addressed yet.\n\nDo you understand what I meant by what I wrote here? Do you agree with it?","author_login":"onvej-sl","author_association":"CONTRIBUTOR","created_at":"2023-07-19T15:20:01+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[1760706300],"is_known_query_context":false},{"document_id":"gh_comment_1644068983","fragment_type":"issue_comment","sequence":5,"text":"Yes I understand what you say and agree with that. However, we define the scope of our tasks as better suit us and I have explained that we are addressing the second problem as part of a bigger task that is the DoS prevention.","author_login":"lontivero","author_association":"COLLABORATOR","created_at":"2023-07-20T14:51:24+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1667694321","fragment_type":"issue_comment","sequence":6,"text":"Guys, do you have any plans on how to continue with this? Either get into consensus or conclusion or closing, maybe modify the scope to be more accurate?","author_login":"molnard","author_association":"COLLABORATOR","created_at":"2023-08-07T11:37:32+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1669439835","fragment_type":"issue_comment","sequence":7,"text":"Can you please direct me to the pull request where it is implemented? Before marking this issue as completed, I wanted to ensure that the second part of this issue has been fixed as well.","author_login":"onvej-sl","author_association":"CONTRIBUTOR","created_at":"2023-08-08T11:30:42+08:00","repo_name":"zkSNACKs/WalletWasabi","issue_id":1760706300,"issue_number":10900,"issue_url":"https://github.com/zkSNACKs/WalletWasabi/issues/10900","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0128","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools**?","query_context":"This package depends on (depends, imports or suggests) **raster** and one or more of the retiring packages **rgdal**, **rgeos** or **maptools** ( URL Since **raster** `3.6.3`, all use of external FOSS library functionality has been transferred to **terra**, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.","known_context_document_ids":["gh_issue_1496139118"],"reference_answer":"Thanks Dr. Bivand. I just finished building my house, moved in, and found my laptop chord the other day. I will get working on this in the mornings. Shall I use this channel to ask questions?","answer_document_id":"gh_comment_1737201400","silver_evidence_path":["gh_comment_1523096967","gh_issue_1649524120","gh_comment_1737201400"],"evidence_issue_ids":[1496139118,1649524120],"source_repo_name":"adokter/bioRad","source_issue_id":1496139118,"source_issue_number":545,"source_issue_url":"https://github.com/adokter/bioRad/issues/545","target_repo_name":"ssefick/StreamMetabolism","target_issue_id":1649524120,"target_issue_number":2,"target_issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","reference_anchor_document_id":"gh_comment_1523096967","reference_answer_author":"ssefick","reference_answer_author_association":"OWNER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.2222,"target_answer_overlap":0.0},"issue_created_at":"2022-12-14T09:15:12+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1496139118","fragment_type":"issue_description","sequence":0,"text":"Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools**\nThis package depends on (depends, imports or suggests) **raster** and one or more of the retiring packages **rgdal**, **rgeos** or **maptools** ( URL Since **raster** `3.6.3`, all use of external FOSS library functionality has been transferred to **terra**, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.","author_login":"rsbivand","author_association":"NONE","created_at":"2022-12-14T09:15:12+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1357918871","fragment_type":"issue_comment","sequence":1,"text":"Thanks @rsbivand for the heads up, updating all our spatial libraries is at the top of our to-do list for 203","author_login":"adokter","author_association":"OWNER","created_at":"2022-12-19T16:24:30+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1492014817","fragment_type":"issue_comment","sequence":2,"text":"This package has strong dependence on at least one of `rgdal`, `rgeos` or `maptools`, but does not seem to use any functionality in code. The usage may have been in `raster`, which now uses `terra` instead, or may be in examples or vignettes. Please move all use of `rgdal`, `rgeos` or `maptools` to Suggests: and protect any use against these packages not being present. The packages will be archived in October 2023. See URL and URL and perhaps view URL","author_login":"rsbivand","author_association":"NONE","created_at":"2023-03-31T14:30:35+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1522228560","fragment_type":"issue_comment","sequence":3,"text":"@rsbivand thanks, we will move this up in priority. Do you have plans for maptools::crepuscule() to be migrated to a different package? If not, would it be ok if we integrate that piece of code into bioRad under the GPL license used by maptools? Or would you recommend a different option?","author_login":"adokter","author_association":"OWNER","created_at":"2023-04-25T18:28:27+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523096967","fragment_type":"issue_comment","sequence":4,"text":"That would of course be fine. I took the functions out as URL in connection with contacts with other package maintainers:\n\n packages `birdscanR` URL `EMbC` `FLightR` URL `incR` URL `PWFSLSmoke` URL `shadow` URL `StreamMetabolism` URL","author_login":"rsbivand","author_association":"NONE","created_at":"2023-04-26T09:33:30+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[1649524120],"is_known_query_context":false},{"document_id":"gh_comment_1579404202","fragment_type":"issue_comment","sequence":5,"text":"Add `suntools` package as a dependency once it is published on CRAN","author_login":"iskandari","author_association":"COLLABORATOR","created_at":"2023-06-06T20:29:46+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1584534117","fragment_type":"issue_comment","sequence":6,"text":"CRAN bioRad_0.6.2.tar.gz fails CMD check with `_R_CHECK_SUGGESTS_ONLY_=true` and forthcoming `sp` 2.0-0; adding `sf` to Suggests: remedies. I couldn't test properly with your Github HEAD which has `sf` because I don't have `vol2birdR`. `sp` 2.0-0 is coming during June.","author_login":"rsbivand","author_association":"NONE","created_at":"2023-06-09T12:56:30+08:00","repo_name":"adokter/bioRad","issue_id":1496139118,"issue_number":545,"issue_url":"https://github.com/adokter/bioRad/issues/545","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1649524120","fragment_type":"issue_description","sequence":0,"text":"Remove use of maptools\nThis package has strong dependence on at least one of `rgdal`, `rgeos` or `maptools`, but does not seem to use any functionality in code. The usage may have been in `raster`, which now uses `terra` instead, or may be in examples or vignettes. Please move all use of `rgdal`, `rgeos` or `maptools` to Suggests: and protect any use against these packages not being present. The packages will be archived in October 2023. See URL and URL and perhaps view URL","author_login":"rsbivand","author_association":"NONE","created_at":"2023-03-31T15:00:03+08:00","repo_name":"ssefick/StreamMetabolism","issue_id":1649524120,"issue_number":2,"issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1635517326","fragment_type":"issue_comment","sequence":1,"text":"@ssefick See also URL and URL Please take urgent steps to resolve this issue. No positive changes appear in the repository. Less than three months remain to retain this package on CRAN","author_login":"rsbivand","author_association":"NONE","created_at":"2023-07-14T08:44:27+08:00","repo_name":"ssefick/StreamMetabolism","issue_id":1649524120,"issue_number":2,"issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1737201400","fragment_type":"issue_comment","sequence":2,"text":"Thanks Dr. Bivand. I just finished building my house, moved in, and found my laptop chord the other day. I will get working on this in the mornings. Shall I use this channel to ask questions?","author_login":"ssefick","author_association":"OWNER","created_at":"2023-09-27T11:20:48+08:00","repo_name":"ssefick/StreamMetabolism","issue_id":1649524120,"issue_number":2,"issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1737239354","fragment_type":"issue_comment","sequence":3,"text":"I believe that sunrise is the only map tools function the package uses in the.\n\nThe suntools package seems to have this function.\n\nI will migrate in the next week.","author_login":"ssefick","author_association":"OWNER","created_at":"2023-09-27T11:49:26+08:00","repo_name":"ssefick/StreamMetabolism","issue_id":1649524120,"issue_number":2,"issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1752938997","fragment_type":"issue_comment","sequence":4,"text":"@ssefick R spatial infrastructure packages maptools, rgdal and rgeos will be archived by CRAN on Monday, October 16, 2023. Your package does not pass CMD check when these packages are not available. Expect your package to be archived by CRAN October 17-18 as CRAN checks feed through and your package fails, if not updated by Monday, October 16, 2023. \n\nNo grace period is anticipated, as you have had sufficient time to update your package to remove dependencies on maptools, rgdal and/or rgeos.","author_login":"rsbivand","author_association":"NONE","created_at":"2023-10-09T12:41:44+08:00","repo_name":"ssefick/StreamMetabolism","issue_id":1649524120,"issue_number":2,"issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1770868792","fragment_type":"issue_comment","sequence":5,"text":"@ssefick Thanks for your patience! I sometimes think that we've got used to systems sending push notifications, memory seems to need more support.","author_login":"rsbivand","author_association":"NONE","created_at":"2023-10-19T12:27:15+08:00","repo_name":"ssefick/StreamMetabolism","issue_id":1649524120,"issue_number":2,"issue_url":"https://github.com/ssefick/StreamMetabolism/issues/2","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0130","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug] verifyImages from GCR Fails with Permission Denied -- imagePullSecret not Respected?","query_context":"### Kyverno Version\n\n1.10.1\n\n### Kubernetes Version\n\n1.25.x\n\n### Kubernetes Platform\n\nGKE\n\n### Kyverno Rule Type\n\nverifyImages\n\n### Description\n\nHaving a policy that verifies image signatures from Google Artifact registry fails with the following error\n\n[kyverno-reports-controller-574cf8d8d9-hj8xj] I0723 21:24:43.520443 1 cosign.go:62]\ncosign \"msg\"=\"image verification failed\"\"error\"=\n\"GET URL \nDENIED: Permission \\\"artifactregistry.repositories.downloadArtifacts\\\" denied on resource\n\\\"projects/my-registry/locations/europe/repositories/eu.gcr.io\\\" (or it may not exist)\"\n\nI know the credentials have this permission because\n\ncosign login eu.gcr.io -u _json_key -p \"$(cat ./service-account-key-file.json)\"\ncosign download signature eu.gcr.io/my-registry/ : | jq\n\nwork. (and if I remove the \"Artifact Registry Reader\" role from the IAM User of this service account key it fails)\n\nI feel like I am missing something trivial but could not exactly pinpoint what. The steps to reproduce are below:\n\n### Steps to reproduce\n\n1. Install Kyverno on GCP via the Helm chart\n2. Add a Policy with a verifyImages rule that checks images from Google Artifact Registry (for Europe eu.gcr.io):\n\napiVersion: kyverno.io/v1\nkind: ClusterPolicy\nmetadata:\n name: check-image\nspec:\n validationFailureAction: Audit\n background: true\n webhookTimeoutSeconds: 30\n failurePolicy: Fail\n rules:\n - name: check-image\n match:\n any:\n - resources:\n kinds:\n - Pod\n names:\n - \"foo-test*\"\n exclude:\n any:\n - resources:\n namespaces:\n - kube-system\n verifyImages:\n - mutateDigest: false\n imageReferences:\n - \"eu.gcr.io/my-registry/foo*\"\n attestors:\n - count: 1\n entries:\n - keys:\n publicKeys: |-\n KEY\n\n3. This policy obviously fails with Permission Denied as Kyverno knows nothing about GCR credentials.\n4. Create the credentials using:\n\nkubectl create secret docker-registry regcred \\\n --docker-server=eu.gcr.io \\\n --docker-username=_json_key \\\n --docker-password=\"$(cat ./service-account-key-file.json)\"\n\n and of course add `--imagePullSecrets=regcred` to `admission-controller` and `reports-controller`.\n \n \n\n I0723 21:55:05.082293 1 registry.go:17] setup/registry-client \"msg\"=\"setup registry client...\" \"insecure\"=false \"secrets\"=\"regcred\"\n\n5. Kyverno still fails with the same error.\n6. `kubectl delete secrets/regcred && kubectl rollout restart deploy` for testing purposes (basically deleting the secret `imagePullSecrets` argument refers to) and still the same error. I was expecting an error that denotes the missing `Secret` resource. \n\n---\n\nI have also tried annotating the service accounts under `kyverno` namespace as such\n\nkubectl annotate serviceaccounts --all iam.gke.io/gcp-service-account=kyverno-service-account@my-registry.iam.gserviceaccount.com\n\nWhich expectedly did not have any effect.\n\n---\n\ncurl \" URL \n\nfails with the same error.\n\ncurl -u \"_json_key:`cat ./service-account-key-file.json`\" \" URL \n\n**Actually returns a token. Which leads me to believe that there is a problem with how we are providing basic auth to `go-containerregistry`.**\n\n---\n\nThe docker-registry secret also looks legit. Confirmed using this\n\nk get secrets/regcred -o json | jq '.data.\".dockerconfigjson\"' -r | base64 -D | jq\n\nand\n\nsh\n \n --imagePullSecrets=regcred\n --imagePullSecrets=regcred\n --imagePullSecrets=regcred\n\n---\n\nCreated a small program to test `go-containerregistry` with what I have\n\ngolang\npackage main\n\nimport (\n \"context\"\n \"encoding/base64\"\n \"fmt\"\n\n kauth \"github.com/google/go-containerregistry/pkg/authn/kubernetes\"\n \"github.com/google/go-containerregistry/pkg/name\"\n \"github.com/google/go-containerregistry/pkg/v1/remote\"\n corev1 \"k8s.io/api/core/v1\"\n)\n\nfunc main() {\n ref, err := name.ParseReference(\"eu.gcr.io/my-registry/foo:latest\")\n if err != nil {\n panic(err)\n }\n\n // Output of `k get secret/regcred -o json | jq '.data.\".dockerconfigjson\"' -r`\n secBase64 := \"OUTPUT\"\n secData, err := base64.StdEncoding.DecodeString(secBase64)\n if err != nil {\n panic(err)\n }\n\n // Secret itself\n secrets := []corev1.Secret{\n {\n Type: corev1.SecretTypeDockerConfigJson,\n Data: map[string][]byte{\n \".dockerconfigjson\": secData,\n },\n },\n }\n\n // Pull secret to auth keychain\n authsec, err := kauth.NewFromPullSecrets(context.TODO(), secrets)\n if err != nil {\n panic(err)\n }\n\n // Fetch the manifest using default credentials.\n img, err := remote.Get(ref, remote.WithAuthFromKeychain(authsec))\n if err != nil {\n panic(err)\n }\n\n // Prints the digest\n fmt.Println(img.Digest)\n}\n\nIt works.\n\n### Expected behavior\n\nKyverno using the provided secrets to access Google Artifact registry.\n\n### Screenshots\n\n_No response_\n\n### Kyverno logs\n\nshell\nShared in description\n\n### Slack discussion\n\n_No response_\n\n### Troubleshooting\n\n- [X] I have read and followed the documentation AND the troubleshooting guide.\n- [X] I have searched other issues in this repository and mine is not recorded.","known_context_document_ids":["gh_issue_1817341226"],"reference_answer":"@rsavage-nozominetworks - can you please try setting `verifyDigest: false` for the `Audit` mode policy rule?","answer_document_id":"gh_comment_1619787412","silver_evidence_path":["gh_comment_1647513724","gh_issue_1777069177","gh_comment_1619787412"],"evidence_issue_ids":[1817341226,1777069177],"source_repo_name":"kyverno/kyverno","source_issue_id":1817341226,"source_issue_number":7887,"source_issue_url":"https://github.com/kyverno/kyverno/issues/7887","target_repo_name":"kyverno/kyverno","target_issue_id":1777069177,"target_issue_number":7684,"target_issue_url":"https://github.com/kyverno/kyverno/issues/7684","reference_anchor_document_id":"gh_comment_1647513724","reference_answer_author":"JimBugwadia","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.3,"target_answer_overlap":0.6},"issue_created_at":"2023-07-23T23:32:06+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1817341226","fragment_type":"issue_description","sequence":0,"text":"[Bug] verifyImages from GCR Fails with Permission Denied -- imagePullSecret not Respected\n### Kyverno Version\n\n1.10.1\n\n### Kubernetes Version\n\n1.25.x\n\n### Kubernetes Platform\n\nGKE\n\n### Kyverno Rule Type\n\nverifyImages\n\n### Description\n\nHaving a policy that verifies image signatures from Google Artifact registry fails with the following error\n\n[kyverno-reports-controller-574cf8d8d9-hj8xj] I0723 21:24:43.520443 1 cosign.go:62]\ncosign \"msg\"=\"image verification failed\"\"error\"=\n\"GET URL \nDENIED: Permission \\\"artifactregistry.repositories.downloadArtifacts\\\" denied on resource\n\\\"projects/my-registry/locations/europe/repositories/eu.gcr.io\\\" (or it may not exist)\"\n\nI know the credentials have this permission because\n\ncosign login eu.gcr.io -u _json_key -p \"$(cat ./service-account-key-file.json)\"\ncosign download signature eu.gcr.io/my-registry/ : | jq\n\nwork. (and if I remove the \"Artifact Registry Reader\" role from the IAM User of this service account key it fails)\n\nI feel like I am missing something trivial but could not exactly pinpoint what. The steps to reproduce are below:\n\n### Steps to reproduce\n\n1. Install Kyverno on GCP via the Helm chart\n2. Add a Policy with a verifyImages rule that checks images from Google Artifact Registry (for Europe eu.gcr.io):\n\napiVersion: kyverno.io/v1\nkind: ClusterPolicy\nmetadata:\n name: check-image\nspec:\n validationFailureAction: Audit\n background: true\n webhookTimeoutSeconds: 30\n failurePolicy: Fail\n rules:\n - name: check-image\n match:\n any:\n - resources:\n kinds:\n - Pod\n names:\n - \"foo-test*\"\n exclude:\n any:\n - resources:\n namespaces:\n - kube-system\n verifyImages:\n - mutateDigest: false\n imageReferences:\n - \"eu.gcr.io/my-registry/foo*\"\n attestors:\n - count: 1\n entries:\n - keys:\n publicKeys: |-\n KEY\n\n3. This policy obviously fails with Permission Denied as Kyverno knows nothing about GCR credentials.\n4. Create the credentials using:\n\nkubectl create secret docker-registry regcred \\\n --docker-server=eu.gcr.io \\\n --docker-username=_json_key \\\n --docker-password=\"$(cat ./service-account-key-file.json)\"\n\n and of course add `--imagePullSecrets=regcred` to `admission-controller` and `reports-controller`.\n \n \n\n I0723 21:55:05.082293 1 registry.go:17] setup/registry-client \"msg\"=\"setup registry client...\" \"insecure\"=false \"secrets\"=\"regcred\"\n\n5. Kyverno still fails with the same error.\n6. `kubectl delete secrets/regcred && kubectl rollout restart deploy` for testing purposes (basically deleting the secret `imagePullSecrets` argument refers to) and still the same error. I was expecting an error that denotes the missing `Secret` resource. \n\n---\n\nI have also tried annotating the service accounts under `kyverno` namespace as such\n\nkubectl annotate serviceaccounts --all iam.gke.io/gcp-service-account=kyverno-service-account@my-registry.iam.gserviceaccount.com\n\nWhich expectedly did not have any effect.\n\n---\n\ncurl \" URL \n\nfails with the same error.\n\ncurl -u \"_json_key:`cat ./service-account-key-file.json`\" \" URL \n\n**Actually returns a token. Which leads me to believe that there is a problem with how we are providing basic auth to `go-containerregistry`.**\n\n---\n\nThe docker-registry secret also looks legit. Confirmed using this\n\nk get secrets/regcred -o json | jq '.data.\".dockerconfigjson\"' -r | base64 -D | jq\n\nand\n\nsh\n \n --imagePullSecrets=regcred\n --imagePullSecrets=regcred\n --imagePullSecrets=regcred\n\n---\n\nCreated a small program to test `go-containerregistry` with what I have\n\ngolang\npackage main\n\nimport (\n \"context\"\n \"encoding/base64\"\n \"fmt\"\n\n kauth \"github.com/google/go-containerregistry/pkg/authn/kubernetes\"\n \"github.com/google/go-containerregistry/pkg/name\"\n \"github.com/google/go-containerregistry/pkg/v1/remote\"\n corev1 \"k8s.io/api/core/v1\"\n)\n\nfunc main() {\n ref, err := name.ParseReference(\"eu.gcr.io/my-registry/foo:latest\")\n if err != nil {\n panic(err)\n }\n\n // Output of `k get secret/regcred -o json | jq '.data.\".dockerconfigjson\"' -r`\n secBase64 := \"OUTPUT\"\n secData, err := base64.StdEncoding.DecodeString(secBase64)\n if err != nil {\n panic(err)\n }\n\n // Secret itself\n secrets := []corev1.Secret{\n {\n Type: corev1.SecretTypeDockerConfigJson,\n Data: map[string][]byte{\n \".dockerconfigjson\": secData,\n },\n },\n }\n\n // Pull secret to auth keychain\n authsec, err := kauth.NewFromPullSecrets(context.TODO(), secrets)\n if err != nil {\n panic(err)\n }\n\n // Fetch the manifest using default credentials.\n img, err := remote.Get(ref, remote.WithAuthFromKeychain(authsec))\n if err != nil {\n panic(err)\n }\n\n // Prints the digest\n fmt.Println(img.Digest)\n}\n\nIt works.\n\n### Expected behavior\n\nKyverno using the provided secrets to access Google Artifact registry.\n\n### Screenshots\n\n_No response_\n\n### Kyverno logs\n\nshell\nShared in description\n\n### Slack discussion\n\n_No response_\n\n### Troubleshooting\n\n- [X] I have read and followed the documentation AND the troubleshooting guide.\n- [X] I have searched other issues in this repository and mine is not recorded.","author_login":"Akaame","author_association":"NONE","created_at":"2023-07-23T23:32:06+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1646994888","fragment_type":"issue_comment","sequence":1,"text":"I am also fine with using the default GCP Keychain (cloud-aware) and thought simply annotating the Service Accounts with `iam.gke.io/gcp-service-account=kyverno-service-account@my-registry.iam.gserviceaccount.com` should have been enough. But it is not. Found the following issues/PRs regarding that:\n\n URL \n URL \n URL \n\nMaybe adding documentation regarding `registryCredentialHelpers` and cloud-aware pull secret extraction is necessary here (or if there is already one, please point me to it).","author_login":"Akaame","author_association":"NONE","created_at":"2023-07-23T23:55:49+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1647023318","fragment_type":"issue_comment","sequence":2,"text":"Passing the manually created `imagePullSecret` to cosign package also works:\n\ngolang\npackage main\n\nimport (\n \"context\"\n \"encoding/base64\"\n \"fmt\"\n\n kauth \"github.com/google/go-containerregistry/pkg/authn/kubernetes\"\n \"github.com/google/go-containerregistry/pkg/name\"\n gcrremote \"github.com/google/go-containerregistry/pkg/v1/remote\"\n \"github.com/sigstore/cosign/cmd/cosign/cli/options\"\n \"github.com/sigstore/cosign/pkg/cosign\"\n \"github.com/sigstore/cosign/pkg/oci/remote\"\n corev1 \"k8s.io/api/core/v1\"\n)\n\nfunc main() {\n ref, err := name.ParseReference(\"eu.gcr.io/my-registry/foo:latest\")\n if err != nil {\n panic(err)\n }\n\n // Output of `k get secret/regcred -o json | jq '.data.\".dockerconfigjson\"' -r`\n secBase64 := \"OUTPUT\"\n secData, err := base64.StdEncoding.DecodeString(secBase64)\n if err != nil {\n panic(err)\n }\n\n // Secret itself\n secrets := []corev1.Secret{\n {\n Type: corev1.SecretTypeDockerConfigJson,\n Data: map[string][]byte{\n \".dockerconfigjson\": secData,\n },\n },\n }\n\n // Pull secret to auth keychain\n authsec, err := kauth.NewFromPullSecrets(context.TODO(), secrets)\n if err != nil {\n panic(err)\n }\n\n // Fetch the manifest using default credentials.\n img, err := gcrremote.Get(ref, gcrremote.WithAuthFromKeychain(authsec))\n if err != nil {\n panic(err)\n }\n\n // Prints the digest\n fmt.Println(img.Digest)\n\n ctx := context.TODO()\n\n var remoteOpts []remote.Option\n ro := options.RegistryOptions{}\n remoteOpts, err = ro.ClientOpts(ctx)\n if err != nil {\n panic(err)\n }\n remoteOpts = append(remoteOpts, remote.WithRemoteOptions(\n gcrremote.WithAuthFromKeychain(authsec),\n ))\n\n signedPayload, err := cosign.FetchSignaturesForReference(ctx, ref, remoteOpts...)\n if err != nil {\n panic(err)\n }\n fmt.Println(signedPayload)\n}","author_login":"Akaame","author_association":"NONE","created_at":"2023-07-24T00:28:05+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1647331732","fragment_type":"issue_comment","sequence":3,"text":"@Akaame Thank you for opening the issue. Is this related to URL \n \n\nCan you please confirm","author_login":"vishal-chdhry","author_association":"MEMBER","created_at":"2023-07-24T07:05:04+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1647354069","fragment_type":"issue_comment","sequence":4,"text":"@vishal-chdhry Thanks for the quick response. And, no, the second time around it fails with the same error. I do not think the issues are related. Should I still install the tip of main branch and try?","author_login":"Akaame","author_association":"NONE","created_at":"2023-07-24T07:22:49+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1647413501","fragment_type":"issue_comment","sequence":5,"text":"@Akaame That would be great!\n\nPlease follow the instructions here to try this out","author_login":"vishal-chdhry","author_association":"MEMBER","created_at":"2023-07-24T08:03:58+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1647513724","fragment_type":"issue_comment","sequence":6,"text":"@Akaame I believe the cause of the issue is `validateFailureAction` being set to `Audit`.: URL \nIt will be fixed in 1.10.2\n\nTo fix it right now, you can set `validateFailureAction` to `Enforce` (Setting it to `Enforce` once and then setting it back to `Audit` will also fix it for now, you won't have to do it in 1.10.2)\n\nLet me know if this fixes the issue","author_login":"vishal-chdhry","author_association":"MEMBER","created_at":"2023-07-24T09:06:38+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[1777069177],"is_known_query_context":false},{"document_id":"gh_comment_1647689484","fragment_type":"issue_comment","sequence":7,"text":"helm uninstall kyverno\nkubectl create -f URL \n\nPatched the deployment with `--imagePullSecrets=regcred`\nand changed the `ClusterPolicy` to have `Enforce` as failure action. IT WORKED!. Then, reverted it back to `Audit`. It still works for both Policy Failure and Pass cases.\n\n@vishal-chdhry Thanks!","author_login":"Akaame","author_association":"NONE","created_at":"2023-07-24T10:58:52+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1647694390","fragment_type":"issue_comment","sequence":8,"text":"Duplicate of URL \nClosed in URL \nWill be in the v1.10.2\n\nI am closing this issue.","author_login":"Akaame","author_association":"NONE","created_at":"2023-07-24T11:02:14+08:00","repo_name":"kyverno/kyverno","issue_id":1817341226,"issue_number":7887,"issue_url":"https://github.com/kyverno/kyverno/issues/7887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1777069177","fragment_type":"issue_description","sequence":0,"text":"[Bug] verifyImage Audit mode policies broken\n### Kyverno Version\n\n1.10.0\n\n### Description\n\n**Problem Summary**\n\nI have a use case to run Kyverno in `Audit` mode for image verification. However I am completely unable to have image verification working as it always fails with:\n\nI0627 00:23:32.974836 1 imageverifier.go:424] engine.verify \"msg\"=\"image attestors verification failed\" \"errors\"=\".attestors[0].entries[0].keys: GET URL UNAUTHORIZED: authentication required\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=0\nI0627 00:23:33.279255 1 imageverifier.go:424] engine.verify \"msg\"=\"image attestors verification failed\" \"errors\"=\".attestors[0].entries[0].keys: GET URL UNAUTHORIZED: authentication required\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=0\nI0627 00:23:33.570684 1 imageverifier.go:424] engine.verify \"msg\"=\"image attestors verification failed\" \"errors\"=\".attestors[0].entries[0].keys: GET URL UNAUTHORIZED: authentication required\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=0\n\nWhat is interesting is that, when I switch the policy from `Audit` mode to `Enforce` mode, or I simply add another image verification policy with `Enforce` mode, any existing `Audit` mode policy begins to work. (Even after I remove the Enforce policy completely). And when I say work, I mean it passes `image attestors verification succeede`. I still have very inaccurate reporting and most of the time a lack of reporting which is important to us.\n\nI0627 00:27:28.181460 1 imageverifier.go:415] engine.verify \"msg\"=\"image attestors verification succeeded\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=1\nI0627 00:27:29.693570 1 imageverifier.go:415] engine.verify \"msg\"=\"image attestors verification succeeded\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=1\nI0627 00:27:36.341651 1 imageverifier.go:415] engine.verify \"msg\"=\"image attestors verification succeeded\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=1\nI0627 00:27:37.852787 1 imageverifier.go:415] engine.verify \"msg\"=\"image attestors verification succeeded\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=1\nI0627 00:27:51.743091 1 imageverifier.go:415] engine.verify \"msg\"=\"image attestors verification succeeded\" \"new.kind\"=\"Pod\" \"new.name\"=\"\" \"new.namespace\"=\"myns\" \"policy.apply\"=\"All\" \"policy.name\"=\"verify-image\" \"policy.namespace\"=\"\" \"requiredCount\"=1 \"rule.name\"=\"verify-image\" \"verifiedCount\"=1\n\nExample `Audit` Policy used:\n\nyaml\napiVersion: kyverno.io/v1\nkind: ClusterPolicy\nmetadata:\n annotations:\n policies.kyverno.io/minversion: 1.10.0\n policies.kyverno.io/subject: Pod\n policies.kyverno.io/title: Verify Image\n name: verify-image\nspec:\n background: true\n failurePolicy: Fail\n rules:\n - match:\n any:\n - resources:\n kinds:\n - Pod\n name: verify-image\n verifyImages:\n - attestors:\n - count: 1\n entries:\n - keys:\n secret:\n name: my-cosign-key\n namespace: kyverno\n signatureAlgorithm: sha256\n imageReferences:\n - \"ghcr.io/mycompany/*\"\n mutateDigest: false\n required: true\n type: Cosign\n verifyDigest: true\n validationFailureAction: Audit\n webhookTimeoutSeconds: 30\n\nExample `Enforce` Policy used: \n\nyaml\napiVersion: kyverno.io/v1\nkind: ClusterPolicy\nmetadata:\n annotations:\n policies.kyverno.io/minversion: 1.10.0\n policies.kyverno.io/subject: Pod\n policies.kyverno.io/title: Verify Image\n generation: 5\n name: verify-image\nspec:\n background: true\n failurePolicy: Fail\n rules:\n - match:\n any:\n - resources:\n kinds:\n - Pod\n name: verify-image\n verifyImages:\n - attestors:\n - count: 1\n entries:\n - keys:\n secret:\n name: my-cosign-key\n namespace: kyverno\n signatureAlgorithm: sha256\n imageReferences:\n - ghcr.io/mycompany/*\n mutateDigest: true\n required: true\n type: Cosign\n verifyDigest: true\n validationFailureAction: Enforce\n webhookTimeoutSeconds: 30\n \n\n **Additional Details**\nMy images are signed with `cosign` and can be manually validated. We do NOT use transparency logs as by default our private ghcr repo names would be saved in a public `sigstore` repository which is unacceptable for us.\n \n\n cosign verify --insecure-ignore-tlog --key cosign.pub ghcr.io/mycompany/awesome-service:0eec8 | jq .\nWARNING: Skipping tlog verification is an insecure practice that lacks of transparency and auditability verification for the signature.\n\nVerification for ghcr.io/mycompany/awesome-service:0eec8 --\nThe following checks were performed on each of these signatures:\n - The cosign claims were validated\n - The signatures were verified against the specified public key\n[\n {\n \"critical\": {\n \"identity\": {\n \"docker-reference\": \"ghcr.io/mycompany/awesome-service\"\n },\n \"image\": {\n \"docker-manifest-digest\": \"sha256:a3334ba2630e7bex9493810fc61rc3041c94d34f981612253f01acx08e19cd7e\"\n },\n \"type\": \"cosign container image signature\"\n },\n \"optional\": null\n }\n]\n \n\n \nI can confirm Kyverno's admission controller has access to the repository secret\n\n~/code/sandbox/ghcr-auth/kyverno ᐅ kubectl auth can-i get secrets --as system:serviceaccount:kyverno:kyverno-admission-controller\nyes\n\nI could be totally wrong, but what I believe is happening is the lack of `mutateDigest` in kyverno 1.10.0 for `Audit` mode. While I fully understand most people will jump straight into using `Enforce` mode, for a use case I have, I need this cluster only performing `Audits`. According to what I understand about `mutateDigest` - taken from here: \n\n\"...The rule mutates matching images to add the image digest, when mutateDigest is set to true (which is the default), if the digest is not already specified...\"\n\nTherefore, because of the missing mutated annotation in the Pod, my Audits fail. When I turn on Enforce mode, they get mutated, and allow existing Audits to work. I could be wrong, but... something is definitely off here. This also co-insides with the recent disabling of `mutateDigest` in Audit mode.\n\n### Slack discussion\n\n_No response_\n\n### Troubleshooting\n\n- [X] I have read and followed the documentation AND the troubleshooting guide.\n- [X] I have searched other issues in this repository and mine is not recorded.","author_login":"rsavage-nozominetworks","author_association":"NONE","created_at":"2023-06-27T14:06:37+08:00","repo_name":"kyverno/kyverno","issue_id":1777069177,"issue_number":7684,"issue_url":"https://github.com/kyverno/kyverno/issues/7684","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1619644346","fragment_type":"issue_comment","sequence":1,"text":"Hey folks 👋🏻. \nI would like to work on this issue. Since I'm relatively new to this project and cloud native in general, it would really help if you could tell me from where to get started, as in where particularly I should look for in the code-base?","author_login":"prady0t","author_association":"NONE","created_at":"2023-07-04T07:11:27+08:00","repo_name":"kyverno/kyverno","issue_id":1777069177,"issue_number":7684,"issue_url":"https://github.com/kyverno/kyverno/issues/7684","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1619787412","fragment_type":"issue_comment","sequence":2,"text":"@rsavage-nozominetworks - can you please try setting `verifyDigest: false` for the `Audit` mode policy rule?","author_login":"JimBugwadia","author_association":"MEMBER","created_at":"2023-07-04T08:29:41+08:00","repo_name":"kyverno/kyverno","issue_id":1777069177,"issue_number":7684,"issue_url":"https://github.com/kyverno/kyverno/issues/7684","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0131","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"containerOpen is too strong a precondition for transparent and/or enterable objects?","query_context":"Certain actions have a `containerOpen` precondition when that precondition is too strong:\n\n1. It's inappropriate for transparent containers. `LOOK IN GLASS CASE` should not require opening the case.\n2. It's inappropriate for booths that the player is inside. `LOOK IN CAR` or `PUT WIDGET IN CAR` should require opening the car door only if the player is not already in the car.","known_context_document_ids":["gh_issue_2765247509"],"reference_answer":"I’ve now pulled your fix for this, made another couple of tweaks, and pushed them up to GitHub.\n\nOne tweak was to define the origVocabLikelihood property on SubComponent (the compiler gave me a warning it was undefined).\n\nThe other was to make a enterable container SubComponent and its parent facets of each other during preinit so that the same pronoun will still work should which of the two is favoured by the parser change over successive turns, e.g. ENTER IT, CLOSE IT, X IT.\n\nSo far as I can tell from the testing I’ve done it all works okay, except that when I define SubComponents as separate objects I get a pointless and misleading disambiguation prompt with the LOOK IN command. I think giving a slightly higher vocabLikelihood to the SubComponent may fix it, but I’m still working on it.\n\nFrom: Daniel Fox Franke ***@***.***>\nSent: 06 January 2025 16:51\nTo: EricEve/adv3lite ***@***.***>\nCc: Eric Eve ***@***.***>; Comment ***@***.***>\nSubject: Re: [EricEve/adv3lite] SubComponent vocabulary assignment doesn't work correctly for transparent booths (Issue #24)\n\nNo. I think fixing this requires at least most of changes I made in #27","answer_document_id":"gh_comment_2575679505","silver_evidence_path":["gh_comment_2567263526","gh_issue_2765368889","gh_comment_2575679505"],"evidence_issue_ids":[2765247509,2765368889],"source_repo_name":"EricEve/adv3lite","source_issue_id":2765247509,"source_issue_number":23,"source_issue_url":"https://github.com/EricEve/adv3lite/issues/23","target_repo_name":"EricEve/adv3lite","target_issue_id":2765368889,"target_issue_number":24,"target_issue_url":"https://github.com/EricEve/adv3lite/issues/24","reference_anchor_document_id":"gh_comment_2567263526","reference_answer_author":"EricEve","reference_answer_author_association":"OWNER","quality_score":81.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.0,"target_answer_overlap":0.2791},"issue_created_at":"2025-01-01T20:30:38+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2765247509","fragment_type":"issue_description","sequence":0,"text":"containerOpen is too strong a precondition for transparent and/or enterable objects\nCertain actions have a `containerOpen` precondition when that precondition is too strong:\n\n1. It's inappropriate for transparent containers. `LOOK IN GLASS CASE` should not require opening the case.\n2. It's inappropriate for booths that the player is inside. `LOOK IN CAR` or `PUT WIDGET IN CAR` should require opening the car door only if the player is not already in the car.","author_login":"dfoxfranke","author_association":"CONTRIBUTOR","created_at":"2025-01-01T20:30:38+08:00","repo_name":"EricEve/adv3lite","issue_id":2765247509,"issue_number":23,"issue_url":"https://github.com/EricEve/adv3lite/issues/23","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2567263526","fragment_type":"issue_comment","sequence":1,"text":"I need to double-check whether the `containerOpen` precondition is actually responsible for the second problem I listed or whether that's actually because of #24. The first problem is definitely caused by the precondition, however.","author_login":"dfoxfranke","author_association":"CONTRIBUTOR","created_at":"2025-01-02T03:55:42+08:00","repo_name":"EricEve/adv3lite","issue_id":2765247509,"issue_number":23,"issue_url":"https://github.com/EricEve/adv3lite/issues/23","linked_issue_ids":[2765368889],"is_known_query_context":false},{"document_id":"gh_comment_2573179701","fragment_type":"issue_comment","sequence":2,"text":"I've fixed this by defining a new `containerInteriorVisible1 precondition for use by `LOOK IN` to cater for transparent containers and those enclosing the actor.\n\nFixing this bug revealed another: `LOOK IN BOOTH` failed to list the contents of a closed opaque Booth. I've now fixed this is well..\n\nI've tested both fixes and they seem to work okay. Would you like to check them out before we close this issue?","author_login":"EricEve","author_association":"OWNER","created_at":"2025-01-06T14:04:43+08:00","repo_name":"EricEve/adv3lite","issue_id":2765247509,"issue_number":23,"issue_url":"https://github.com/EricEve/adv3lite/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573483741","fragment_type":"issue_comment","sequence":3,"text":"I haven't tested this yet, but code review LGTM so far as LOOK IN is concerned. I think PUT IN also needs to addressed, though, so that PUT WIDGET IN BOOTH doesn't require opening the booth if the actor is inside.","author_login":"dfoxfranke","author_association":"CONTRIBUTOR","created_at":"2025-01-06T16:39:40+08:00","repo_name":"EricEve/adv3lite","issue_id":2765247509,"issue_number":23,"issue_url":"https://github.com/EricEve/adv3lite/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573589584","fragment_type":"issue_comment","sequence":4,"text":"I've just added a `containerInteriorVisible` precondition to handle the `PUT IN` case. Testing seems to indicate it does he job, but turned up another listing bug that I've now also fixed (Looking around within a closed opaque container wasn't listing the contents of the container). I've now pushed the results up to GitHub.","author_login":"EricEve","author_association":"OWNER","created_at":"2025-01-06T17:36:44+08:00","repo_name":"EricEve/adv3lite","issue_id":2765247509,"issue_number":23,"issue_url":"https://github.com/EricEve/adv3lite/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2579381346","fragment_type":"issue_comment","sequence":5,"text":"Further testing has thrown up no issues with the fixes described above, so I think we can regard this issue as closed.","author_login":"EricEve","author_association":"OWNER","created_at":"2025-01-09T07:58:29+08:00","repo_name":"EricEve/adv3lite","issue_id":2765247509,"issue_number":23,"issue_url":"https://github.com/EricEve/adv3lite/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2765368889","fragment_type":"issue_description","sequence":0,"text":"SubComponent vocabulary assignment doesn't work correctly for transparent booths\nThe logic in URL assumes that the object's exterior is in scope iff the subcomponent is closed, but this is often not the case. Transparent containers are the most common exception, but scope could also be affected by specials, changes in light status, etc. Also, the initial state will be incorrect if the container is initially closed and is the player's starting location. A more robust means of disambiguating between the parent and subcomponent is needed.","author_login":"dfoxfranke","author_association":"CONTRIBUTOR","created_at":"2025-01-02T02:22:10+08:00","repo_name":"EricEve/adv3lite","issue_id":2765368889,"issue_number":24,"issue_url":"https://github.com/EricEve/adv3lite/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2567286414","fragment_type":"issue_comment","sequence":1,"text":"I have a fix for this working locally. Basically, just leave the SubComponent's vocab alone and add a matchName() method which works the same way as the matchNameDisambig() method already implemented. Pull request coming shortly.","author_login":"dfoxfranke","author_association":"CONTRIBUTOR","created_at":"2025-01-02T04:56:35+08:00","repo_name":"EricEve/adv3lite","issue_id":2765368889,"issue_number":24,"issue_url":"https://github.com/EricEve/adv3lite/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573194063","fragment_type":"issue_comment","sequence":2,"text":"Would a simple fix be to replace:\n\nif(lexicalParent != nil && gPlayerChar.isIn(self)) \n\nwith:\n\nif(lexicalParent != nil && gActor.isIn(self) && !gActor.canSee(lexicalParent)\n\n?","author_login":"EricEve","author_association":"OWNER","created_at":"2025-01-06T14:12:16+08:00","repo_name":"EricEve/adv3lite","issue_id":2765368889,"issue_number":24,"issue_url":"https://github.com/EricEve/adv3lite/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573504914","fragment_type":"issue_comment","sequence":3,"text":"No. I think fixing this requires at least most of changes I made in #27. Anything that relies on `makeOpen` to switch vocabulary around can't possibly be correct, because there are so many other things that could lead either the parent or its subcomponent dropping in or out of scope. And basing anything on `canSee` neglects other senses. If the actor is inside a complex container that has a closed, transparent `remapIn` component, then both outside and the inside are visible, but `TOUCH BOOTH` needs to be interpreted as referring to the inside to prevent the player from being told \"You can't reach the booth through the booth\".","author_login":"dfoxfranke","author_association":"CONTRIBUTOR","created_at":"2025-01-06T16:50:28+08:00","repo_name":"EricEve/adv3lite","issue_id":2765368889,"issue_number":24,"issue_url":"https://github.com/EricEve/adv3lite/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2574784515","fragment_type":"issue_comment","sequence":4,"text":"I think you're right we shouldn't rely on the makeOpen mechanism here. So later today I'll pull your suggested changes and try them out (while keeping a copy of my original code to hand just in case).","author_login":"EricEve","author_association":"OWNER","created_at":"2025-01-07T09:22:47+08:00","repo_name":"EricEve/adv3lite","issue_id":2765368889,"issue_number":24,"issue_url":"https://github.com/EricEve/adv3lite/issues/24","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2575679505","fragment_type":"issue_comment","sequence":5,"text":"I’ve now pulled your fix for this, made another couple of tweaks, and pushed them up to GitHub.\n\nOne tweak was to define the origVocabLikelihood property on SubComponent (the compiler gave me a warning it was undefined).\n\nThe other was to make a enterable container SubComponent and its parent facets of each other during preinit so that the same pronoun will still work should which of the two is favoured by the parser change over successive turns, e.g. ENTER IT, CLOSE IT, X IT.\n\nSo far as I can tell from the testing I’ve done it all works okay, except that when I define SubComponents as separate objects I get a pointless and misleading disambiguation prompt with the LOOK IN command. I think giving a slightly higher vocabLikelihood to the SubComponent may fix it, but I’m still working on it.\n\nFrom: Daniel Fox Franke ***@***.***>\nSent: 06 January 2025 16:51\nTo: EricEve/adv3lite ***@***.***>\nCc: Eric Eve ***@***.***>; Comment ***@***.***>\nSubject: Re: [EricEve/adv3lite] SubComponent vocabulary assignment doesn't work correctly for transparent booths (Issue #24)\n\nNo. I think fixing this requires at least most of changes I made in #27","author_login":"EricEve","author_association":"OWNER","created_at":"2025-01-07T16:10:20+08:00","repo_name":"EricEve/adv3lite","issue_id":2765368889,"issue_number":24,"issue_url":"https://github.com/EricEve/adv3lite/issues/24","linked_issue_ids":[2765368889],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0132","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"as_proxy substantially slower?","query_context":"### Description\n\nI use `FastMCP.as_proxy` all the time, but recently I built a new server and made it with acting as a proxy. For certain servers (http streamable at least), Tool execution is substantially slower. Repo:\n\n1. Launch server as is.\n2. Open inspector with `npx @modelcontextprotocol/inspector`\n3. Connect via Streamable HTTP to ` URL \n4. List tools\n5. Run the single tool.\n\nResponse is instant.\n\nNow swap lines 15 and 16 (so `FastMCP.as_proxy...` is active).\n\nCreate an `mcp_test.json` in the same directory as the script, then run the same test. Every tool (local and remote) will be **much** slower to respond.\n\njson\n{\n \"mcpServers\": {\n \"deepwiki\": {\n \"url\": \" URL \n \"transport\": \"http\"\n },\n \"time\": {\n \"command\": \"uvx\",\n \"args\": [\n \"mcp-server-time\"\n ]\n }\n }\n}\n\n### Example Code\n\nPython\nimport json\nfrom datetime import datetime\nfrom pathlib import Path\nfrom zoneinfo import ZoneInfo\n\nfrom fastmcp import FastMCP\n\n# MARK: Config\nconfig_path = Path(\"mcp_test.json\")\nwith config_path.open(encoding=\"utf-8\") as f:\n config = json.load(f)\n\n# MARK: FastMCP\n# mcp = FastMCP.as_proxy(config, name=\"Slow MCP\", include_fastmcp_meta=False)\nmcp = FastMCP(name=\"Fast MCP\", include_fastmcp_meta=False)\n\n@mcp.tool\ndef custom_get_current_time():\n \"\"\"Get current time in LA with DST information.\"\"\"\n now = datetime.now(ZoneInfo(\"America/Los_Angeles\"))\n is_dst = bool(now.dst() and now.dst().total_seconds() != 0) if now.dst() else False\n result = {\"timezone\": \"America/Los_Angeles\", \"datetime\": now.isoformat(), \"is_dst\": is_dst}\n return json.dumps(result, indent=2)\n\nif __name__ == \"__main__\":\n mcp.run(transport=\"http\", host=\"127.0.0.1\", port=8000)\n\n### Version Information\n\nText\nFastMCP version: 2.11.3\nMCP version: 1.13.1\nPython version: 3.12.10\nPlatform: Windows-11-10.0.26100-SP0","known_context_document_ids":["gh_issue_3346526627"],"reference_answer":"/marvin can you make a PR where we add a random id to the server name if the server name is not provided to the FastMCP object and can you change the server logs to include the server name? Can you also add a name field to the Client class and do the same there? Also cover proxy classes?\n\nCan you also add a method onto the FastMCP server which outputs a mermaid diagram of the hierarchy of servers, mounted servers, proxys clients and transports under a server?","answer_document_id":"gh_comment_3217517216","silver_evidence_path":["gh_comment_3218273476","gh_issue_3348979016","gh_comment_3217517216"],"evidence_issue_ids":[3346526627,3348979016],"source_repo_name":"jlowin/fastmcp","source_issue_id":3346526627,"source_issue_number":1583,"source_issue_url":"https://github.com/jlowin/fastmcp/issues/1583","target_repo_name":"jlowin/fastmcp","target_issue_id":3348979016,"target_issue_number":1601,"target_issue_url":"https://github.com/jlowin/fastmcp/issues/1601","reference_anchor_document_id":"gh_comment_3218273476","reference_answer_author":"strawgate","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.15,"anchor_target_overlap":0.2,"target_answer_overlap":0.2308},"issue_created_at":"2025-08-22T19:55:09+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_3346526627","fragment_type":"issue_description","sequence":0,"text":"as_proxy substantially slower\n### Description\n\nI use `FastMCP.as_proxy` all the time, but recently I built a new server and made it with acting as a proxy. For certain servers (http streamable at least), Tool execution is substantially slower. Repo:\n\n1. Launch server as is.\n2. Open inspector with `npx @modelcontextprotocol/inspector`\n3. Connect via Streamable HTTP to ` URL \n4. List tools\n5. Run the single tool.\n\nResponse is instant.\n\nNow swap lines 15 and 16 (so `FastMCP.as_proxy...` is active).\n\nCreate an `mcp_test.json` in the same directory as the script, then run the same test. Every tool (local and remote) will be **much** slower to respond.\n\njson\n{\n \"mcpServers\": {\n \"deepwiki\": {\n \"url\": \" URL \n \"transport\": \"http\"\n },\n \"time\": {\n \"command\": \"uvx\",\n \"args\": [\n \"mcp-server-time\"\n ]\n }\n }\n}\n\n### Example Code\n\nPython\nimport json\nfrom datetime import datetime\nfrom pathlib import Path\nfrom zoneinfo import ZoneInfo\n\nfrom fastmcp import FastMCP\n\n# MARK: Config\nconfig_path = Path(\"mcp_test.json\")\nwith config_path.open(encoding=\"utf-8\") as f:\n config = json.load(f)\n\n# MARK: FastMCP\n# mcp = FastMCP.as_proxy(config, name=\"Slow MCP\", include_fastmcp_meta=False)\nmcp = FastMCP(name=\"Fast MCP\", include_fastmcp_meta=False)\n\n@mcp.tool\ndef custom_get_current_time():\n \"\"\"Get current time in LA with DST information.\"\"\"\n now = datetime.now(ZoneInfo(\"America/Los_Angeles\"))\n is_dst = bool(now.dst() and now.dst().total_seconds() != 0) if now.dst() else False\n result = {\"timezone\": \"America/Los_Angeles\", \"datetime\": now.isoformat(), \"is_dst\": is_dst}\n return json.dumps(result, indent=2)\n\nif __name__ == \"__main__\":\n mcp.run(transport=\"http\", host=\"127.0.0.1\", port=8000)\n\n### Version Information\n\nText\nFastMCP version: 2.11.3\nMCP version: 1.13.1\nPython version: 3.12.10\nPlatform: Windows-11-10.0.26100-SP0","author_login":"wbste","author_association":"NONE","created_at":"2025-08-22T19:55:09+08:00","repo_name":"jlowin/fastmcp","issue_id":3346526627,"issue_number":1583,"issue_url":"https://github.com/jlowin/fastmcp/issues/1583","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3215464253","fragment_type":"issue_comment","sequence":1,"text":"How much of a slowdown are you seeing? A proxy server dynamically generates an entire additional MCP handshake between your client and the server so some overhead is normal. It is not a passthrough.","author_login":"jlowin","author_association":"OWNER","created_at":"2025-08-22T19:56:58+08:00","repo_name":"jlowin/fastmcp","issue_id":3346526627,"issue_number":1583,"issue_url":"https://github.com/jlowin/fastmcp/issues/1583","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3215950720","fragment_type":"issue_comment","sequence":2,"text":"I think this may be a consequence of the low-level SDK now making multiple `list_tools()` calls for every tool call. IIRC it uses `list_tools()` to get the input schema prior to calling the tool and the output schema after calling the tool. I think this is a really poor design decision; in this case it results in multiple remote HTTP calls for each tool call. It is supposed to cache the results so I'd be curious if you see the slowdown on a second call. I have really been hoping we won't have to design around this (it's one thing to build on top of the SDK, quite another to forcibly remove its functionality)","author_login":"jlowin","author_association":"OWNER","created_at":"2025-08-22T23:39:24+08:00","repo_name":"jlowin/fastmcp","issue_id":3346526627,"issue_number":1583,"issue_url":"https://github.com/jlowin/fastmcp/issues/1583","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3218273476","fragment_type":"issue_comment","sequence":3,"text":"I do want to audit the flow with #1601 and make sure there aren't any unnecessary calls happening and it's likely we'll want to update the docs to better reflect the impact of a slow mounted server / mcp server","author_login":"strawgate","author_association":"COLLABORATOR","created_at":"2025-08-24T18:01:23+08:00","repo_name":"jlowin/fastmcp","issue_id":3346526627,"issue_number":1583,"issue_url":"https://github.com/jlowin/fastmcp/issues/1583","linked_issue_ids":[3348979016],"is_known_query_context":false},{"document_id":"gh_comment_3237854767","fragment_type":"issue_comment","sequence":4,"text":"I think there's some excessive calling going on as each call ends up in its own proxyclient which means its own session which means its own output tool cache which means extra calls to list_tools.\n\n/marvin can you propose an update to the documentation which indicates that one of the downsides of mounted servers is that operations like `list_tools` will be impacted by the speed of the slowest mounted server","author_login":"strawgate","author_association":"COLLABORATOR","created_at":"2025-08-29T18:24:09+08:00","repo_name":"jlowin/fastmcp","issue_id":3346526627,"issue_number":1583,"issue_url":"https://github.com/jlowin/fastmcp/issues/1583","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3305163557","fragment_type":"issue_comment","sequence":5,"text":"Yeah I think we can close this\n\nFyi -- I'm also working on response caching middleware which might be a nice balance between importing and mounting\n\n URL","author_login":"strawgate","author_association":"COLLABORATOR","created_at":"2025-09-18T02:22:47+08:00","repo_name":"jlowin/fastmcp","issue_id":3346526627,"issue_number":1583,"issue_url":"https://github.com/jlowin/fastmcp/issues/1583","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3348979016","fragment_type":"issue_description","sequence":0,"text":"Improve debugging nested servers\n### Enhancement\n\nwe really need to figure out a better way to debug when there are multiple servers/clients at play. Perhaps handler logs should include the server name and we should do a better job providing server names (or generating a server name) in more cases.","author_login":"strawgate","author_association":"COLLABORATOR","created_at":"2025-08-24T00:58:00+08:00","repo_name":"jlowin/fastmcp","issue_id":3348979016,"issue_number":1601,"issue_url":"https://github.com/jlowin/fastmcp/issues/1601","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3217517216","fragment_type":"issue_comment","sequence":1,"text":"/marvin can you make a PR where we add a random id to the server name if the server name is not provided to the FastMCP object and can you change the server logs to include the server name? Can you also add a name field to the Client class and do the same there? Also cover proxy classes?\n\nCan you also add a method onto the FastMCP server which outputs a mermaid diagram of the hierarchy of servers, mounted servers, proxys clients and transports under a server?","author_login":"strawgate","author_association":"COLLABORATOR","created_at":"2025-08-24T01:01:21+08:00","repo_name":"jlowin/fastmcp","issue_id":3348979016,"issue_number":1601,"issue_url":"https://github.com/jlowin/fastmcp/issues/1601","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0136","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[bug #43577] Extended address not sent with avr109?","query_context":"Arne Rossius \nTue 11 Nov 2014 02:14:43 PM UTC\n\nWhen programming the ATxmega256a3 with avrdude 6.1 (windows version), the extended address is not sent when jumping across a 128 KiB boundary. I have created a text hexfile which only contains data for flash pages 0 (word address 0x00000) and 511 (word address 0x1FF00). However as can be seen from the attached log, after programming the first page only a 16-bit address command ('A') is sent instead of the 24-bit address command ('H'), resulting in an address of 0x0FF00 instead of 0x1FF00. Verify doesn't fail because the same happens when reading, but does fail when programming an actual application (without a gap) larger than 128 KiB.\n\nThe programmer is the \"xboot\" bootloader < URL The avrdude.conf is unchanged.\n\nProgramming the attached hex file does work with the older avrdude 5.11 because this version programs pages 1 to 510 with 0xFF, only sending the address once before the first page and then relying on the bootloader's auto-increment to reach the high addresses. As can be expected, it takes a very long time though.\n\nAlso, as can be seen from the xboot source, it resets the extended address byte to zero when receiving an 'A' command. I'm not sure if this behaviour is correct, but if it is, this means that avrdude must send an 'H' command for all flash pages above 128 KiB (unless no address is sent at all between adjacent pages).\n\nfile #32418: napftest.hex\nfile #32419: avrdude-error.txt\n\nThis issue was migrated from URL","known_context_document_ids":["gh_issue_1077285457"],"reference_answer":"I just got an ATxmega32A4U breakout (from MCUZone) and there is no issue to program the flash using AVRISP mkii clone. And the device works fine after the programming (it has two buttons and two LEDs).\n\nPS C:\\work\\avr\\avrdude_test\\avrdude_bin> .\\avrdude.exe -c avrispmkii -p x32a4u \n-U flash:r:atxmega32a4udemo_mcuzone.hex:i\n\navrdude.exe: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.01s\n\navrdude.exe: Device signature = 0x1e9541 (probably x32a4u)\navrdude.exe: NOTE: Programmer supports page erase for Xmega devices.\n Each page will be erased before programming it, but no chip erase is performed.\n To disable page erases, specify the -D option; for a chip-erase, use the -e option.\navrdude.exe: reading flash memory ...\n\nReading | ################################################## | 100% 0.67s\n\navrdude.exe: writing output file atxmega32a4udemo_mcuzone.hex\n\navrdude.exe done. Thank you.\n\nPS C:\\work\\avr\\avrdude_test\\avrdude_bin> .\\avrdude.exe -c avrispmkii -p x32a4u -e\n\navrdude.exe: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.01s\n\navrdude.exe: Device signature = 0x1e9541 (probably x32a4u)\navrdude.exe: erasing chip\n\navrdude.exe done. Thank you.\n\nPS C:\\work\\avr\\avrdude_test\\avrdude_bin> .\\avrdude.exe -c avrispmkii -p x32a4u\n -U flash:w:atxmega32a4udemo_mcuzone.hex:i\n\navrdude.exe: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.01s\n\navrdude.exe: Device signature = 0x1e9541 (probably x32a4u)\navrdude.exe: NOTE: Programmer supports page erase for Xmega devices.\n Each page will be erased before programming it, but no chip erase is performed.\n To disable page erases, specify the -D option; for a chip-erase, use the -e option.\navrdude.exe: reading input file atxmega32a4udemo_mcuzone.hex for flash\navrdude.exe: writing 36786 bytes flash ...\n\nWriting | ################################################## | 100% 3.00s\n\navrdude.exe: 36786 bytes of flash written\navrdude.exe: verifying flash memory against atxmega32a4udemo_mcuzone.hex\n\nReading | ################################################## | 100% 0.67s\n\navrdude.exe: 36786 bytes of flash verified\n\navrdude.exe done. Thank you.","answer_document_id":"gh_comment_1218039420","silver_evidence_path":["gh_comment_1162491284","gh_issue_1077189799","gh_comment_1218039420"],"evidence_issue_ids":[1077285457,1077189799],"source_repo_name":"avrdudes/avrdude","source_issue_id":1077285457,"source_issue_number":360,"source_issue_url":"https://github.com/avrdudes/avrdude/issues/360","target_repo_name":"avrdudes/avrdude","target_issue_id":1077189799,"target_issue_number":289,"target_issue_url":"https://github.com/avrdudes/avrdude/issues/289","reference_anchor_document_id":"gh_comment_1162491284","reference_answer_author":"mcuee","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1846},"issue_created_at":"2021-12-10T22:36:56+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1077285457","fragment_type":"issue_description","sequence":0,"text":"[bug #43577] Extended address not sent with avr109\nArne Rossius \nTue 11 Nov 2014 02:14:43 PM UTC\n\nWhen programming the ATxmega256a3 with avrdude 6.1 (windows version), the extended address is not sent when jumping across a 128 KiB boundary. I have created a text hexfile which only contains data for flash pages 0 (word address 0x00000) and 511 (word address 0x1FF00). However as can be seen from the attached log, after programming the first page only a 16-bit address command ('A') is sent instead of the 24-bit address command ('H'), resulting in an address of 0x0FF00 instead of 0x1FF00. Verify doesn't fail because the same happens when reading, but does fail when programming an actual application (without a gap) larger than 128 KiB.\n\nThe programmer is the \"xboot\" bootloader < URL The avrdude.conf is unchanged.\n\nProgramming the attached hex file does work with the older avrdude 5.11 because this version programs pages 1 to 510 with 0xFF, only sending the address once before the first page and then relying on the bootloader's auto-increment to reach the high addresses. As can be expected, it takes a very long time though.\n\nAlso, as can be seen from the xboot source, it resets the extended address byte to zero when receiving an 'A' command. I'm not sure if this behaviour is correct, but if it is, this means that avrdude must send an 'H' command for all flash pages above 128 KiB (unless no address is sent at all between adjacent pages).\n\nfile #32418: napftest.hex\nfile #32419: avrdude-error.txt\n\nThis issue was migrated from URL","author_login":"avrs-admin","author_association":"NONE","created_at":"2021-12-10T22:36:56+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1162491284","fragment_type":"issue_comment","sequence":1,"text":"Ref: xmega relared issues\n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL \n* URL (but also affect other AVR chips).\n* URL \n* URL \n* URL","author_login":"mcuee","author_association":"COLLABORATOR","created_at":"2022-06-22T00:27:41+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[1077189799],"is_known_query_context":false},{"document_id":"gh_comment_1207377699","fragment_type":"issue_comment","sequence":2,"text":"My test results in #454 show that the writing is good but not verification. But that is based on ATmega2560 with xboot, not ATxmega256a3. So ATxmega256a3 may get more issues (need to get some one to help testing as I do not have ATxmega256a3).\n\n* URL","author_login":"mcuee","author_association":"COLLABORATOR","created_at":"2022-08-07T10:32:28+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1256813701","fragment_type":"issue_comment","sequence":3,"text":"@MCUdude \n\nNow that you have access to the ATxmega256A3BU Xplained board, please take a look at this one and #404 when you got a chance. Thanks.","author_login":"mcuee","author_association":"COLLABORATOR","created_at":"2022-09-24T00:23:29+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257026039","fragment_type":"issue_comment","sequence":4,"text":"I compiled xboot for ATxmega256A3BU, and I'm able to communicate with Avrdude using the bootloader:\n\n$ ./avrdude -cavr109 -p atxmega256a3bu -b 115200 -P /dev/cu.usbserial-1410 \n\nConnecting to programmer: .\nFound programmer: Id = \"XBoot++\"; type = S\n Software Version = 1.7; No Hardware Version given.\nProgrammer supports auto addr increment.\nProgrammer supports buffered memory access with buffersize=512 bytes.\n\nProgrammer supports the following devices:\n Device code: 0x7b\n\navrdude: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.00s\n\navrdude: Device signature = 0x1e9843 (probably x256a3bu)\n\navrdude done. Thank you.\n\nI can also read from flash:\n\n$ ./avrdude -cavr109 -p atxmega256a3bu -b 115200 -P /dev/cu.usbserial-1410 -Uflash:r:-:I\n\nConnecting to programmer: .\nFound programmer: Id = \"XBoot++\"; type = S\n Software Version = 1.7; No Hardware Version given.\nProgrammer supports auto addr increment.\nProgrammer supports buffered memory access with buffersize=512 bytes.\n\nProgrammer supports the following devices:\n Device code: 0x7b\n\navrdude: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.00s\n\navrdude: Device signature = 0x1e9843 (probably x256a3bu)\navrdude: NOTE: Programmer supports page erase for Xmega devices.\n Each page will be erased before programming it, but no chip erase is performed.\n To disable page erases, specify the -D option; for a chip-erase, use the -e option.\navrdude: reading flash memory ...\n\nReading | ################################################## | 100% 26.46s\n\navrdude: flash is empty, resulting file has no contents\navrdude: writing output file \n:00000001FF\n\navrdude done. Thank you.\n\nHowever, I'm not able to write:\n\n$ ./avrdude -cavr109 -p atxmega256a3bu -b 115200 -P /dev/cu.usbserial-1410 -Uflash:w:/Users/hans/Downloads/XMEGA_A3BU_XPLAINED_DEMO1.hex:i\n\nConnecting to programmer: .\nFound programmer: Id = \"XBoot++\"; type = S\n Software Version = 1.7; No Hardware Version given.\nProgrammer supports auto addr increment.\nProgrammer supports buffered memory access with buffersize=512 bytes.\n\nProgrammer supports the following devices:\n Device code: 0x7b\n\navrdude: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.00s\n\navrdude: Device signature = 0x1e9843 (probably x256a3bu)\navrdude: NOTE: Programmer supports page erase for Xmega devices.\n Each page will be erased before programming it, but no chip erase is performed.\n To disable page erases, specify the -D option; for a chip-erase, use the -e option.\navrdude: reading input file /Users/hans/Downloads/XMEGA_A3BU_XPLAINED_DEMO1.hex for flash\navrdude: writing 35062 bytes flash ...\n\nWriting | # | 1% 0.00s ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n\n...\n\n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \n ***failed; \nWriting | ################################################## | 100% 0.10s\n\navrdude: 35062 bytes of flash written\navrdude: verifying flash memory against /Users/hans/Downloads/XMEGA_A3BU_XPLAINED_DEMO1.hex\n\nReading | ################################################## | 100% 3.46s\n\navrdude: verification error, first mismatch at byte 0x0000\n 0xff != 0xec\navrdude: verification error; content mismatch\n\navrdude done. Thank you.","author_login":"MCUdude","author_association":"COLLABORATOR","created_at":"2022-09-24T17:36:53+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257029587","fragment_type":"issue_comment","sequence":5,"text":"It turns out that I forgot to add the `-e` flag. Now I can get the bootloader to work. I'll try with a bigger file soon.\n\n$ ./avrdude -cavr109 -p atxmega256a3bu -b 115200 -P /dev/cu.usbserial-1410 -e -Uflash:w:/Users/hans/Downloads/XMEGA_A3BU_XPLAINED_DEMO1.hex:i\n\nConnecting to programmer: .\nFound programmer: Id = \"XBoot++\"; type = S\n Software Version = 1.7; No Hardware Version given.\nProgrammer supports auto addr increment.\nProgrammer supports buffered memory access with buffersize=512 bytes.\n\nProgrammer supports the following devices:\n Device code: 0x7b\n\navrdude: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.00s\n\navrdude: Device signature = 0x1e9843 (probably x256a3bu)\navrdude: erasing chip\navrdude: reading input file /Users/hans/Downloads/XMEGA_A3BU_XPLAINED_DEMO1.hex for flash\navrdude: writing 35062 bytes flash ...\n\nWriting | ################################################## | 100% 4.29s\n\navrdude: 35062 bytes of flash written\navrdude: verifying flash memory against /Users/hans/Downloads/XMEGA_A3BU_XPLAINED_DEMO1.hex\n\nReading | ################################################## | 100% 3.46s\n\navrdude: 35062 bytes of flash verified\n\navrdude done. Thank you.","author_login":"MCUdude","author_association":"COLLABORATOR","created_at":"2022-09-24T17:51:46+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257030840","fragment_type":"issue_comment","sequence":6,"text":"@mcuee I can confirm that there's an issue writing to addresses above 128kiB.\n\n$ ./avrdude -cavr109 -p atxmega256a3bu -b 115200 -P /dev/cu.usbserial-1410 -e -Uflash:w:0x55_256kib.hex \n\nConnecting to programmer: .\nFound programmer: Id = \"XBoot++\"; type = S\n Software Version = 1.7; No Hardware Version given.\nProgrammer supports auto addr increment.\nProgrammer supports buffered memory access with buffersize=512 bytes.\n\nProgrammer supports the following devices:\n Device code: 0x7b\n\navrdude: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.00s\n\navrdude: Device signature = 0x1e9843 (probably x256a3bu)\navrdude: erasing chip\navrdude: reading input file 0x55_256kib.hex for flash\navrdude: writing 262143 bytes flash ...\n\nWriting | ################################################## | 100% 31.83s\n\navrdude: 262143 bytes of flash written\navrdude: verifying flash memory against 0x55_256kib.hex\n\nReading | ################################################## | 100% 25.66s\n\navrdude: verification error, first mismatch at byte 0x1ffff\n 0xff != 0x55\navrdude: verification error; content mismatch\n\navrdude done. Thank you.","author_login":"MCUdude","author_association":"COLLABORATOR","created_at":"2022-09-24T17:57:27+08:00","repo_name":"avrdudes/avrdude","issue_id":1077285457,"issue_number":360,"issue_url":"https://github.com/avrdudes/avrdude/issues/360","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1077189799","fragment_type":"issue_description","sequence":0,"text":"[bug #39033] Support for ATxmegaXXXA4U devices\nBrian Mayton \nTue 21 May 2013 06:30:25 PM UTC\n\navrdude appears to be able to communicate with an ATxmega128A4U in PDI mode, but an attempt to program flash memory fails at verification; the memory appears to read back as 0xFF.\n\nIt looks like avrdude can read the flash correctly; if I program the chip using Atmel Studio, a quick glance at 'dump flash' in avrdude's terminal mode looks like an intact interrupt table.  A chip erase from avrdude also appears to work; the flash reads back as 0xff after executing avrdude -e.\n\nI captured the attached traces from Atmel Studio successfully programming (and then reading back) the flash memory.  The hex file used is the appropriate xmega DFU bootloader image from AVR1916.  The files were captured with Atmel Studio 6 running in VMware and wireshark on Linux capturing with the usbmon facility.  I would be happy to capture additional operations if it would be useful.\n\nfile #28129: atxmega128a4u_dumps.tar.bz2\n\nThis issue was migrated from URL","author_login":"avrs-admin","author_association":"NONE","created_at":"2021-12-10T20:08:10+08:00","repo_name":"avrdudes/avrdude","issue_id":1077189799,"issue_number":289,"issue_url":"https://github.com/avrdudes/avrdude/issues/289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_991261716","fragment_type":"issue_comment","sequence":1,"text":"Joerg Wunsch \nFri 13 Sep 2013 02:16:15 PM UTC\n\nAfter someone just got me an Xmega-A3BU Xplained board, I\ngave it a try, and had no troubles (beyond the rather\ncomplicated board setup) to talk PDI to it, using a JTAGICE3.","author_login":"avrdude-admin","author_association":"NONE","created_at":"2021-12-10T20:09:11+08:00","repo_name":"avrdudes/avrdude","issue_id":1077189799,"issue_number":289,"issue_url":"https://github.com/avrdudes/avrdude/issues/289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1149288606","fragment_type":"issue_comment","sequence":2,"text":"@dl8dtl There are many xmega related issues, not so sure this one (as well as others) is still relevant or not.\n\nI have tried to link the xmega related issues here:\n* URL","author_login":"mcuee","author_association":"NONE","created_at":"2022-06-08T00:03:23+08:00","repo_name":"avrdudes/avrdude","issue_id":1077189799,"issue_number":289,"issue_url":"https://github.com/avrdudes/avrdude/issues/289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1218039420","fragment_type":"issue_comment","sequence":3,"text":"I just got an ATxmega32A4U breakout (from MCUZone) and there is no issue to program the flash using AVRISP mkii clone. And the device works fine after the programming (it has two buttons and two LEDs).\n\nPS C:\\work\\avr\\avrdude_test\\avrdude_bin> .\\avrdude.exe -c avrispmkii -p x32a4u \n-U flash:r:atxmega32a4udemo_mcuzone.hex:i\n\navrdude.exe: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.01s\n\navrdude.exe: Device signature = 0x1e9541 (probably x32a4u)\navrdude.exe: NOTE: Programmer supports page erase for Xmega devices.\n Each page will be erased before programming it, but no chip erase is performed.\n To disable page erases, specify the -D option; for a chip-erase, use the -e option.\navrdude.exe: reading flash memory ...\n\nReading | ################################################## | 100% 0.67s\n\navrdude.exe: writing output file atxmega32a4udemo_mcuzone.hex\n\navrdude.exe done. Thank you.\n\nPS C:\\work\\avr\\avrdude_test\\avrdude_bin> .\\avrdude.exe -c avrispmkii -p x32a4u -e\n\navrdude.exe: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.01s\n\navrdude.exe: Device signature = 0x1e9541 (probably x32a4u)\navrdude.exe: erasing chip\n\navrdude.exe done. Thank you.\n\nPS C:\\work\\avr\\avrdude_test\\avrdude_bin> .\\avrdude.exe -c avrispmkii -p x32a4u\n -U flash:w:atxmega32a4udemo_mcuzone.hex:i\n\navrdude.exe: AVR device initialized and ready to accept instructions\n\nReading | ################################################## | 100% 0.01s\n\navrdude.exe: Device signature = 0x1e9541 (probably x32a4u)\navrdude.exe: NOTE: Programmer supports page erase for Xmega devices.\n Each page will be erased before programming it, but no chip erase is performed.\n To disable page erases, specify the -D option; for a chip-erase, use the -e option.\navrdude.exe: reading input file atxmega32a4udemo_mcuzone.hex for flash\navrdude.exe: writing 36786 bytes flash ...\n\nWriting | ################################################## | 100% 3.00s\n\navrdude.exe: 36786 bytes of flash written\navrdude.exe: verifying flash memory against atxmega32a4udemo_mcuzone.hex\n\nReading | ################################################## | 100% 0.67s\n\navrdude.exe: 36786 bytes of flash verified\n\navrdude.exe done. Thank you.","author_login":"mcuee","author_association":"COLLABORATOR","created_at":"2022-08-17T13:51:35+08:00","repo_name":"avrdudes/avrdude","issue_id":1077189799,"issue_number":289,"issue_url":"https://github.com/avrdudes/avrdude/issues/289","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0137","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Nil response?","query_context":"We are using OPA in a k8s environment.\n* OPA version: 0.56.0\n* Response is nil\n* flags\n* \"run\",\n \"--server\",\n \"--config-file=/config/config.yaml\",\n \"--log-level=info\",\n \"--log-format=json\",\n \"--authentication=token\",\n \"--authorization=basic\",\n \"/authz/authz.rego\",\n \"/authz/bearer.rego\",\n \"--ignore=.*\",\n \"--addr= URL \n\n## Steps To Reproduce\nThe error happen over time. No discernible pattern other than a restart of OPA fixes it.\n\nWhen the \"nil\" response starts happening it is reproducible until OPA is restarted.\nIs there a way to gather more information when this happens?","known_context_document_ids":["gh_issue_2130553300"],"reference_answer":"I would recommend using bundles for policy and data distribution. Here's an example tutorial.","answer_document_id":"gh_comment_2341376213","silver_evidence_path":["gh_comment_2749925035","gh_issue_2492948054","gh_comment_2341376213"],"evidence_issue_ids":[2130553300,2492948054],"source_repo_name":"open-policy-agent/opa","source_issue_id":2130553300,"source_issue_number":6585,"source_issue_url":"https://github.com/open-policy-agent/opa/issues/6585","target_repo_name":"open-policy-agent/opa","target_issue_id":2492948054,"target_issue_number":6972,"target_issue_url":"https://github.com/open-policy-agent/opa/issues/6972","reference_anchor_document_id":"gh_comment_2749925035","reference_answer_author":"ashutosh-narkar","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.125,"target_answer_overlap":0.2857},"issue_created_at":"2024-02-12T16:54:00+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2130553300","fragment_type":"issue_description","sequence":0,"text":"Nil response\nWe are using OPA in a k8s environment.\n* OPA version: 0.56.0\n* Response is nil\n* flags\n* \"run\",\n \"--server\",\n \"--config-file=/config/config.yaml\",\n \"--log-level=info\",\n \"--log-format=json\",\n \"--authentication=token\",\n \"--authorization=basic\",\n \"/authz/authz.rego\",\n \"/authz/bearer.rego\",\n \"--ignore=.*\",\n \"--addr= URL \n\n## Steps To Reproduce\nThe error happen over time. No discernible pattern other than a restart of OPA fixes it.\n\nWhen the \"nil\" response starts happening it is reproducible until OPA is restarted.\nIs there a way to gather more information when this happens?","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-02-12T16:54:00+08:00","repo_name":"open-policy-agent/opa","issue_id":2130553300,"issue_number":6585,"issue_url":"https://github.com/open-policy-agent/opa/issues/6585","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1939165533","fragment_type":"issue_comment","sequence":1,"text":"@kirk-patton closing this for now. Feel free to re-open with more details about the issue and steps to reproduce it. Thanks!","author_login":"ashutosh-narkar","author_association":"MEMBER","created_at":"2024-02-12T17:07:02+08:00","repo_name":"open-policy-agent/opa","issue_id":2130553300,"issue_number":6585,"issue_url":"https://github.com/open-policy-agent/opa/issues/6585","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939167046","fragment_type":"issue_comment","sequence":2,"text":"@ashutosh-narkar the details were hidden as they had been provided as part of the comment included in the template. I edited the issue to unhide that.","author_login":"anderseknert","author_association":"MEMBER","created_at":"2024-02-12T17:07:54+08:00","repo_name":"open-policy-agent/opa","issue_id":2130553300,"issue_number":6585,"issue_url":"https://github.com/open-policy-agent/opa/issues/6585","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939173863","fragment_type":"issue_comment","sequence":3,"text":"@kirk-patton I would recommend using the latest version of OPA and try to repro with that. Also it would help if you could share the policy, input etc. There were some issues around OPA returning a \"nil\" response in an older version which we fixed. Not sure if you're seeing the same issue but using the latest OPA version would help to figure that out.","author_login":"ashutosh-narkar","author_association":"MEMBER","created_at":"2024-02-12T17:12:02+08:00","repo_name":"open-policy-agent/opa","issue_id":2130553300,"issue_number":6585,"issue_url":"https://github.com/open-policy-agent/opa/issues/6585","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2749925035","fragment_type":"issue_comment","sequence":4,"text":"Looks like this was resolved in URL please re-open if that isn't the case.","author_login":"sspaink","author_association":"CONTRIBUTOR","created_at":"2025-03-25T02:56:41+08:00","repo_name":"open-policy-agent/opa","issue_id":2130553300,"issue_number":6585,"issue_url":"https://github.com/open-policy-agent/opa/issues/6585","linked_issue_ids":[2492948054],"is_known_query_context":false},{"document_id":"gh_issue_2492948054","fragment_type":"issue_description","sequence":0,"text":"OPA response is nil issue\n@kirk-patton I would recommend using the latest version of OPA and try to repro with that. Also it would help if you could share the policy, input etc. There were some issues around OPA returning a \"nil\" response in an older version which we fixed. Not sure if you're seeing the same issue but using the latest OPA version would help to figure that out.\n\n_Originally posted by @ashutosh-narkar in URL","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-08-28T20:37:11+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2316222703","fragment_type":"issue_comment","sequence":1,"text":"I have updated the clusters to opa 0.66.0. Things were quite for a few weeks. The issue has resurfaced though. I tried asking in the community slack channel, but so far no response. \n\nThe decision logger we use does not return the admission review when the response from OPA is nil. When the response is nil, should be possible to get the admissionReview? I would like to be able to provide more specifics, but I am having trouble getting any information at the time of the issue. I do know that doing a rollout restart of the opa deployment alleviates the issue for a time hours/a couple days. The issue seems more prevalent in certain clusters.","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-08-28T20:46:18+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2316390382","fragment_type":"issue_comment","sequence":2,"text":"If you could provide some details that help repro the issue that would be really helpful.","author_login":"ashutosh-narkar","author_association":"MEMBER","created_at":"2024-08-28T23:11:25+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2317988670","fragment_type":"issue_comment","sequence":3,"text":"If only I could reproduce the issue :-)\n\nWe use OPA as and admission webhook in multiple k8s clusters. We load our policies using kube-mgmt. We have a decision logger configured to log OPA policy success/fail with some details to aid in troubleshooting. If OPA returns a true/false response, we can see the k8s admissionReview just fine. But, if OPA returns a nil response, the admissionReview is also nil.\n\nGiven that the decision logger does not return any useful information when the response from OPA is nil, there is not much to go on.\n\nDoes OPA expose the k8s admission review details when OPA response is nil? Or is there some other recommended way to get useful information to help \n\nFrom our decision logger..\n\ntype DiagnosticsResponseElementV1 struct {\n Revision string `json:\"revision,omitempty\"`\n DecisionID string `json:\"decision_id,omitempty\"`\n RemoteAddr string `json:\"remote_addr\"`\n Query string `json:\"query\"`\n Path string `json:\"path\"`\n Timestamp string `json:\"timestamp\"`\n Input v1beta1.AdmissionReview `json:\"input,omitempty\"`\n Result *v1beta1.AdmissionReview `json:\"result,omitempty\"`. <====\n Error *types.ErrorV1 `json:\"error,omitempty\"`\n Explanation types.TraceV1 `json:\"explanation,omitempty\"`\n Metrics types.MetricsV1 `json:\"metrics,omitempty\"`\n}\n\nWe are not running into any issues when we run the unit tests on our policies. We alert when OPA returns a nil response, as it impacts the users submitting to the cluster. Performing a k8s rolling restart of the OPA deployment temporarily resolves the issue. Jobs submitted that encounter the `OPA response is nil`, submit fine after OPA is restarted.","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-08-29T14:59:24+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2318418440","fragment_type":"issue_comment","sequence":4,"text":"I have only looked at the decision-logger side-car when the issue has surfaced. I will make a point to examine OPA logs to see if there are any clues there.\n \nThank you for confirming that! I will update the decision logger to spew.Dump to the console and see what that gets me","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-08-29T17:16:00+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2332152802","fragment_type":"issue_comment","sequence":5,"text":"I am working on gathering more information to help diagnose this issue.","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-09-05T16:19:32+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2339420688","fragment_type":"issue_comment","sequence":6,"text":"Looks like the issue we are seeing is the same as URL \n\nOPA is getting restarted on our AWS cluster, possible dues to Karpenter. kube-mgmt does not reload the policies. The response we get back just contains the decision-id and nothing else.\n\nWe are planning on adding a livenessProbe to the `mgmt` side-car","author_login":"kirk-patton","author_association":"CONTRIBUTOR","created_at":"2024-09-10T01:15:06+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2341376213","fragment_type":"issue_comment","sequence":7,"text":"I would recommend using bundles for policy and data distribution. Here's an example tutorial.","author_login":"ashutosh-narkar","author_association":"MEMBER","created_at":"2024-09-10T16:08:15+08:00","repo_name":"open-policy-agent/opa","issue_id":2492948054,"issue_number":6972,"issue_url":"https://github.com/open-policy-agent/opa/issues/6972","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0138","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"选项卡菜单item名错误?","query_context":"### Description\n\nimage\n\n### DBeaver Version\n\nCommunity 22.1.5.202208211008\n\n### Operating System\n\nWindows11\n\n### Database and driver\n\n_No response_\n\n### Steps to reproduce\n\n_No response_\n\n### Additional context\n\n_No response_","known_context_document_ids":["gh_issue_1359849094"],"reference_answer":"Babel 2022-12 is still not released (link above contains only 2021-12 version).\nHowever we can see it in update sites: URL \n\nThe roblem is that we can't use update site, we need archived zip with all translations. I think we need to contct Babel team and ask to publich the release.","answer_document_id":"gh_comment_1404587242","silver_evidence_path":["gh_comment_1274825085","gh_issue_1380184601","gh_comment_1404587242"],"evidence_issue_ids":[1359849094,1380184601],"source_repo_name":"dbeaver/dbeaver","source_issue_id":1359849094,"source_issue_number":17536,"source_issue_url":"https://github.com/dbeaver/dbeaver/issues/17536","target_repo_name":"dbeaver/dbeaver","target_issue_id":1380184601,"target_issue_number":17697,"target_issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","reference_anchor_document_id":"gh_comment_1274825085","reference_answer_author":"serge-rider","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3333,"target_answer_overlap":0.2},"issue_created_at":"2022-09-02T08:06:42+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1359849094","fragment_type":"issue_description","sequence":0,"text":"选项卡菜单item名错误\n### Description\n\nimage\n\n### DBeaver Version\n\nCommunity 22.1.5.202208211008\n\n### Operating System\n\nWindows11\n\n### Database and driver\n\n_No response_\n\n### Steps to reproduce\n\n_No response_\n\n### Additional context\n\n_No response_","author_login":"shawnWXN","author_association":"NONE","created_at":"2022-09-02T08:06:42+08:00","repo_name":"dbeaver/dbeaver","issue_id":1359849094,"issue_number":17536,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17536","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1235215180","fragment_type":"issue_comment","sequence":1,"text":"Hello @shawnWXN,\n\nPlease use English and provide more information about the issue.\n\nIf the localization is incorrect, then please suggest a better translation.","author_login":"ShadelessFox","author_association":"MEMBER","created_at":"2022-09-02T08:21:19+08:00","repo_name":"dbeaver/dbeaver","issue_id":1359849094,"issue_number":17536,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17536","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1274825085","fragment_type":"issue_comment","sequence":2,"text":"Closed as duplicate of URL \n\nThis is the bug from the Eclipse site","author_login":"LonwoLonwo","author_association":"MEMBER","created_at":"2022-10-11T14:50:18+08:00","repo_name":"dbeaver/dbeaver","issue_id":1359849094,"issue_number":17536,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17536","linked_issue_ids":[1380184601],"is_known_query_context":false},{"document_id":"gh_issue_1380184601","fragment_type":"issue_description","sequence":0,"text":"Update Babel version\n### Description\n\n<img width=\"249\" alt=\"image\" src=\" URL \n\n### DBeaver Version\n\n22.2.0.202209051344\n\n### Operating System\n\n_No response_\n\n### Database and driver\n\n_No response_\n\n### Steps to reproduce\n\n_No response_\n\n### Additional context\n\n_No response_","author_login":"lastares","author_association":"NONE","created_at":"2022-09-21T01:29:28+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1254596242","fragment_type":"issue_comment","sequence":1,"text":"Hello @lastares \n\nThis is a translating issue from the Eclipse side: URL \n\nProbably, we need to find or create a ticket on the Eclipse bug tracker.","author_login":"LonwoLonwo","author_association":"MEMBER","created_at":"2022-09-22T06:41:58+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1325080163","fragment_type":"issue_comment","sequence":2,"text":"We probably need to update Eclipse Babel from our side first.","author_login":"LonwoLonwo","author_association":"MEMBER","created_at":"2022-11-23T13:37:10+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1351023885","fragment_type":"issue_comment","sequence":3,"text":"We need to wait for the new babel build to have correct translation.","author_login":"E1izabeth","author_association":"MEMBER","created_at":"2022-12-14T11:18:34+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1404587242","fragment_type":"issue_comment","sequence":4,"text":"Babel 2022-12 is still not released (link above contains only 2021-12 version).\nHowever we can see it in update sites: URL \n\nThe roblem is that we can't use update site, we need archived zip with all translations. I think we need to contct Babel team and ask to publich the release.","author_login":"serge-rider","author_association":"MEMBER","created_at":"2023-01-26T05:48:50+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427306601","fragment_type":"issue_comment","sequence":5,"text":"OK\n\n蓝笑灵晨\n***@***.***\n\n \n\n------------------ 原始邮件 ------------------\n发件人: \"dbeaver/dbeaver\" ***@***.***>;\n发送时间: 2023年1月17日(星期二) 晚上7:59\n***@***.***>;\n***@***.******@***.***>;\n主题: Re: [dbeaver/dbeaver] close tab repeated (Issue #17697)\n\n \nThe latest build contains correct translation.\n \n—\nReply to this email directly, view it on GitHub, or unsubscribe.\nYou are receiving this because you were mentioned.Message ID: ***@***.***>","author_login":"lastares","author_association":"NONE","created_at":"2023-02-13T04:04:00+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[1380184601],"is_known_query_context":false},{"document_id":"gh_comment_1754592163","fragment_type":"issue_comment","sequence":6,"text":"I found a temporary solution to this problem. \n\nTaking the latest version 23.2.2 as an example, find following jar file:\n \n\n, and use decompression software to extract the Chinese localization attribute file from it: \n \n\n, and then change the value corresponding to the key `menuCloseAll` to `\\u5173\\u95ed\\u5168\\u90e8(&A)`,\n\nThen, replace the original file in the Jar package with the modified file.\n\n<img width=\"743\" alt=\"2023-10-10_145621\" src=\" URL","author_login":"bianyun","author_association":"CONTRIBUTOR","created_at":"2023-10-10T07:38:34+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1921879860","fragment_type":"issue_comment","sequence":7,"text":"So I used the latest language pack from official update site (pls see the screenshot), \nimage\n\nthe unpacked .jar already contains required fix \nimage","author_login":"serjiokov","author_association":"CONTRIBUTOR","created_at":"2024-02-01T17:48:07+08:00","repo_name":"dbeaver/dbeaver","issue_id":1380184601,"issue_number":17697,"issue_url":"https://github.com/dbeaver/dbeaver/issues/17697","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0139","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Performance issue on IntelliSense after the verion 1.18.5?","query_context":"### Environment\n\n- OS and Version: \nLocal mode: mac\nRemote mode: mac-client, linux-server\n- VS Code Version: 1.18.9 dc96b837cf6bb4af9cd736aa3af08cf8279f7685\n- C/C++ Extension Version: after 1.18.5\n- If using SSH remote, specify OS of remote machine: centos 7.9 (or on mac locally)\n\n### Bug Summary and Steps to Reproduce\n\nBug Summary:\nIntelliSense is rather slowly, prevent the functions which are dependent on IntelliSense. Whatever file I open, the IntelliSense process is spining for even a minute, and before it finished I can do nothing about the functions which are dependent on the IntelliSense.\n\nSteps to reproduce:\n1. Run vscode on mac locally or a linux server remotely, checkout the project: URL master branch is ok.\n2. install the c++ extension pack (which contains cpptools of version greatter than 1.18.5)\n3. Open a file under the forder $project-root/be/sre.\n4. Try the functions releated with IntelliSense.\n\nExpected behavior:\nIntelliSense is extremlly slow, and prevent you using the functions which are denpendent on the IntelliSense.\n\n### Configuration and Logs\n\nshell\n/\n\n### Other Extensions\n\n_No response_\n\n### Additional context\n\nI try the cpptools extension version by version, and I found that the IntelliSense is smooth at (and before) the version 1.18.5, if I update the extesion to version which is greater than 1.18.5, the issue will appear.\n\nSo it may be helpful that checkout the changes between 1.18.5 and 1.19.5.","known_context_document_ids":["gh_issue_2332556923"],"reference_answer":"@Colengms @LittleFatHero The performance issue started with 1.19.x -- it looks like it may be \"by design\" due to the workspace symbol search changes. I'm seeing roughly it take roughly twice the amount of time to parse/update the database and the database is roughly 50% bigger. We'll look into whether that can be improved.","answer_document_id":"gh_comment_2206887084","silver_evidence_path":["gh_comment_2206893380","gh_issue_2287051471","gh_comment_2206887084"],"evidence_issue_ids":[2332556923,2287051471],"source_repo_name":"microsoft/vscode-cpptools","source_issue_id":2332556923,"source_issue_number":12348,"source_issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","target_repo_name":"microsoft/vscode-cpptools","target_issue_id":2287051471,"target_issue_number":12292,"target_issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12292","reference_anchor_document_id":"gh_comment_2206893380","reference_answer_author":"sean-mcmanus","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.2,"target_answer_overlap":0.1538},"issue_created_at":"2024-06-04T05:01:44+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2332556923","fragment_type":"issue_description","sequence":0,"text":"Performance issue on IntelliSense after the verion 1.18.5\n### Environment\n\n- OS and Version: \nLocal mode: mac\nRemote mode: mac-client, linux-server\n- VS Code Version: 1.18.9 dc96b837cf6bb4af9cd736aa3af08cf8279f7685\n- C/C++ Extension Version: after 1.18.5\n- If using SSH remote, specify OS of remote machine: centos 7.9 (or on mac locally)\n\n### Bug Summary and Steps to Reproduce\n\nBug Summary:\nIntelliSense is rather slowly, prevent the functions which are dependent on IntelliSense. Whatever file I open, the IntelliSense process is spining for even a minute, and before it finished I can do nothing about the functions which are dependent on the IntelliSense.\n\nSteps to reproduce:\n1. Run vscode on mac locally or a linux server remotely, checkout the project: URL master branch is ok.\n2. install the c++ extension pack (which contains cpptools of version greatter than 1.18.5)\n3. Open a file under the forder $project-root/be/sre.\n4. Try the functions releated with IntelliSense.\n\nExpected behavior:\nIntelliSense is extremlly slow, and prevent you using the functions which are denpendent on the IntelliSense.\n\n### Configuration and Logs\n\nshell\n/\n\n### Other Extensions\n\n_No response_\n\n### Additional context\n\nI try the cpptools extension version by version, and I found that the IntelliSense is smooth at (and before) the version 1.18.5, if I update the extesion to version which is greater than 1.18.5, the issue will appear.\n\nSo it may be helpful that checkout the changes between 1.18.5 and 1.19.5.","author_login":"XuPengfei-1020","author_association":"NONE","created_at":"2024-06-04T05:01:44+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2148092157","fragment_type":"issue_comment","sequence":1,"text":"@XuPengfei-1020 Can you set C_Cpp.loggingLevel to \"Debug\" and look at the C/C++ logging after opening a file logging text that indicates what is blocking the IntelliSense operation? In particulary, what does it show for \"Update IntelliSense time (sec):\" or mentions of a filename cache.","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2024-06-04T17:51:52+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2148895762","fragment_type":"issue_comment","sequence":2,"text":"I have tried clangd extension, I am sorry to say that there has a long way for cpptools extension to go. \nClangd is far more smooth than cpptolls(even 1.17.5 version) on IntelliSense, just for now (may be caused by the project I opend is a bit large, it contains more than 3k cpp/h files).\n\nNow I have to use clangd extension.\nI will switch to cpptools later after this bug has been fixed.\nThank you.","author_login":"XuPengfei-1020","author_association":"NONE","created_at":"2024-06-05T05:36:28+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2150168320","fragment_type":"issue_comment","sequence":3,"text":"LSP: Sending response (id: 158)\nLSP: Sending response (id: 154)\nLSP: Sending response (id: 157)\n**Update IntelliSense time (sec): 26.648**\nLSP: (received) cpptools/getFoldingRanges: file:///root/palo/be/src/olap/cumulative_compaction_time_series_policy.h (id: 159)\nLSP: (invoked) cpptools/getFoldingRanges: file:///root/palo/be/src/olap/cumulative_compaction_time_series_policy.h (id: 159)","author_login":"heartacker","author_association":"NONE","created_at":"2024-06-05T14:26:21+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2150592747","fragment_type":"issue_comment","sequence":4,"text":"Hi @XuPengfei-1020 , @heartacker . Can you be more specific about the version number that introduced the issue, by trying out the available 'insiders' versions between 1.18.5 and 1.19.5?\n \n\nThis number indicates when IntelliSense processing has gone idle for all open files. This will have increased in 1.19.2 due to IntelliSense improvements to update files 'progressively'. IntelliSense will be functional, and the currently visible portion of the file(s) on screen will be updated, colorized, etc., _much_ more quickly than previously. This number is not a representation of how quickly IntelliSense is usable or results are available for any particular file. This number is not an indicator of IntelliSense performance. IntelliSense will be fully functional before this is logged.\n\nIf you enable `\"C_Cpp.loggingLevel\": \"7\"`, you can see individual progressive updates. As soon as you see the first such update, the visible portion of the file should be fully updated and IntelliSense ready to use. The remaining updates, up until `Update IntelliSense time` indicate work to populate colorization, errors, etc., outside of the currently visible range of the file, asynchronously.\n\nOpening the doris project at the suggested path, with that log level set, and no other configuration (as none was mentioned in the issue), IntelliSense does not appear to be configured for me. It's necessary to configure the C/C++ Extension with the same information used to build the code, for the same reason that it's needed to build the code - IntelliSense is a front-end C++ compiler. It needs to know the defines and include paths necessary to parse/build the code. Without this, the C/C++ Extension may perform an excessive amount of work trying to access files it's unable to find and try to parse code it's not been configured to parse correctly. When using a large project without a configuration, I would not expect most IntelliSense functionality to work properly or quickly.\n\nI don't think we yet have enough information to investigate this issue. Could either of you please provide concise repro steps with a project that is configured for IntelliSense? The doris project does appear to include CMakeLists.txt files, so the C/C++ Extension could potentially be configured using the CMake Tools extension. But this did not appear to get configured for me 'out of the box', given the complex directory structure of that project.\n\nI'm unable to reproduce any obvious performance issue with files in the doris project. To investigate further, I think we'll need more information, such as an example project and an associated correct IntelliSense configuration, specific files to open, and other specific steps on what operations to perform and what is not as expected. If we're not able to repro locally, we may also need detailed logs from your own repro(s). How to collect that information is in our new issue template, and would generally include the results of the `C/C++: Log Diagnostics` command (with the reproing file open), setting and configuration details, and C/C++ output logs with `C_Cpp.loggingLevel` set to `Debug`. The C/C++ Extension may function very different depending on how/if it's been configured and what features are used, so we really do need very specific information to investigate repros.","author_login":"Colengms","author_association":"COLLABORATOR","created_at":"2024-06-05T17:30:05+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2151091454","fragment_type":"issue_comment","sequence":5,"text":"名称: C/C++\nID: ms-vscode.cpptools\n说明: C/C++ IntelliSense, debugging, and code browsing.\n版本: 1.20.5 @Colengms \n发布者: Microsoft\nVS Marketplace 链接: URL","author_login":"heartacker","author_association":"NONE","created_at":"2024-06-05T22:53:27+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2151323805","fragment_type":"issue_comment","sequence":6,"text":"\"This number is not an indicator of IntelliSense performance. IntelliSense will be fully functional before this is logged.\"\n@Colengms Very appreciate for your patient explanation.\n\nDoes the IntelliSence dependent the cmake-tools extension?\nAfter I config the cmake-tools and run it, I got a warn msg: , see:\n”Using 'DEBUG' for CMAKE_BUILD_TYPE instead of 'Debug' to ensure that IntelliSense configurations can be found.“\nI don`t know whether the IntelliSense issue is related with this.\nDetails about it in this issue I posted to cmake-took extension: URL \n\nEnv of project Doris and the step of producing the issue:\n1. Clone the doris project from URL checkout the tag: [2.1.0-release]\n2. Pull the doris dev docker image: apache/doris:build-env-ldb-toolchain-latest, either linux or windows docker-desktop is ok.\n3. Run the docker image, mount the doris project root folder on the ~/doris in container (Or pull the doris project in containers, anyway is ok).\n4. Start vscode(latest version is ok), connect into the container(either by ssh or local-container-extension is ok), run the vscode as remote mode.\n5. Install the c++-extension-pack(latest version is ok), and config the cmake-tools (compiler is /var/local/ldb-toolchain/bin/clang, src is $doris/be/).\n6. Try to open some files under the folder $project/be/src/olap/(such as tablet.cpp, table.h)\n7. Try to go to the definition of the included files using cmd/ctrl + left-click on .\n8. Try to go to the definition of the functions/symbols which defined in other cpp/h file and referenced by current file.","author_login":"XuPengfei-1020","author_association":"NONE","created_at":"2024-06-06T02:58:21+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206893380","fragment_type":"issue_comment","sequence":7,"text":"I think this is a duplicate of URL and a regression caused by adding more stuff to the database for 1.19.x. This might get fixed/improved by not blocking IntelliSense on tag parsing with 1.21.2+.","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2024-07-03T17:49:23+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2332556923,"issue_number":12348,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12348","linked_issue_ids":[2287051471],"is_known_query_context":false},{"document_id":"gh_issue_2287051471","fragment_type":"issue_description","sequence":0,"text":"IntelliSense Updating and Parsing Workspace speed is much slower after 1.18.5\n### Environment\n\n- OS and Version: windows 10\n- VS Code Version: 1.89.0\n- C/C++ Extension Version: 1.20.5\n- If using SSH remote, specify OS of remote machine: ubuntu 20.04\n\n### Bug Summary and Steps to Reproduce\n\nBug Summary:\nMy vscode is running in windows 10 and I connected to remote machine ubuntu 20.04 which has installed vscode server and cpptools using the ssh remote-SSH extensions. when I open a C source file and go to definition of a function， it could not jump to the definition because cpptools is Updating IntelliSense and Parsing Workspace. So I wait for cpptools to finish the job, but I found that it Parsing Workspace is extremely slower than previous version. My workSpace has about 100000 C source files.\n1. Why cpptools 1.20.5 verison feels slow than previous version?\n2. what is strategy of when Updating IntelliSense and Parsing Workspace? will it updating of the file on the workspace or only update the and parse the open file?\n3. Would it be possible to add a setting that allows the user to specify number of thread to use for parsing?\n\nSteps to reproduce:\n1. Open the workspce which has about 100000 C source Files using vscode 1.89.0 and cpptools 1.20.5\n3. Count the time it takes to finish update Intellisense and Parsing workspace.\n4. compare the time with privous version of vscode and cpptools\n\nExpected behavior:\nupdate Intellisense and Parsing workspace faster\n\n### Configuration and Logs\n\nshell\ndefault config\n\n### Other Extensions\n\n_No response_\n\n### Additional context\n\n_No response_","author_login":"LittleFatHero","author_association":"NONE","created_at":"2024-05-09T07:12:00+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2287051471,"issue_number":12292,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105083569","fragment_type":"issue_comment","sequence":1,"text":"Hi @LittleFatHero . Would you be able to try out the various versions (including prerelease versions) between 1.89 and 1.20.5, to isolate which version seems to introduce the performance regression?","author_login":"Colengms","author_association":"COLLABORATOR","created_at":"2024-05-10T18:30:09+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2287051471,"issue_number":12292,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2199086719","fragment_type":"issue_comment","sequence":2,"text":"Hi @Colengms , I'm sorry, I have been busy doing other thing and has no time to do this action. When the cpptools release a new version , is there any performance test about parse and intellisense? if not , maybe the team can do this when a new version is going to release. When there is a performance regression, the new version should not release?","author_login":"LittleFatHero","author_association":"NONE","created_at":"2024-07-01T02:55:59+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2287051471,"issue_number":12292,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12292","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206887084","fragment_type":"issue_comment","sequence":3,"text":"@Colengms @LittleFatHero The performance issue started with 1.19.x -- it looks like it may be \"by design\" due to the workspace symbol search changes. I'm seeing roughly it take roughly twice the amount of time to parse/update the database and the database is roughly 50% bigger. We'll look into whether that can be improved.","author_login":"sean-mcmanus","author_association":"COLLABORATOR","created_at":"2024-07-03T17:44:57+08:00","repo_name":"microsoft/vscode-cpptools","issue_id":2287051471,"issue_number":12292,"issue_url":"https://github.com/microsoft/vscode-cpptools/issues/12292","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0142","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Media location for a folder per post?","query_context":"What's the configuration for a setup like this? All what I have tried so far didn't work and keeps assuming I have one folder for ALL my media, which is very chaotic.\n\nFolder structure is simply like this\n\ncontent/\n posts/\n post1/\n index.md\n image1.png\n post2/\n index.md\n image1.png\n post3/\n index.md\n image1.png","known_context_document_ids":["gh_issue_2157757648"],"reference_answer":"Doesn't mean I won't get something sorted out ultimately. I just need time to sit down and figure out how I would handle it.\n\nThe main issue with this Hugo flow is that you need to define the name of the folder (and thus the slug) before you upload the assets. But in Pages CMS, for new entries, the slug/filename is set up on saving the entry.\n\nIf you have suggestions, let me know.","answer_document_id":"gh_comment_2525074904","silver_evidence_path":["gh_comment_2525384034","gh_issue_2724513079","gh_comment_2525074904"],"evidence_issue_ids":[2157757648,2724513079],"source_repo_name":"pages-cms/pages-cms","source_issue_id":2157757648,"source_issue_number":29,"source_issue_url":"https://github.com/pages-cms/pages-cms/issues/29","target_repo_name":"pages-cms/pages-cms","target_issue_id":2724513079,"target_issue_number":129,"target_issue_url":"https://github.com/pages-cms/pages-cms/issues/129","reference_anchor_document_id":"gh_comment_2525384034","reference_answer_author":"hunvreus","reference_answer_author_association":"MEMBER","quality_score":93.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.0667,"target_answer_overlap":0.2},"issue_created_at":"2024-02-27T22:59:38+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2157757648","fragment_type":"issue_description","sequence":0,"text":"Media location for a folder per post\nWhat's the configuration for a setup like this? All what I have tried so far didn't work and keeps assuming I have one folder for ALL my media, which is very chaotic.\n\nFolder structure is simply like this\n\ncontent/\n posts/\n post1/\n index.md\n image1.png\n post2/\n index.md\n image1.png\n post3/\n index.md\n image1.png","author_login":"itstamimi","author_association":"NONE","created_at":"2024-02-27T22:59:38+08:00","repo_name":"pages-cms/pages-cms","issue_id":2157757648,"issue_number":29,"issue_url":"https://github.com/pages-cms/pages-cms/issues/29","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2001954216","fragment_type":"issue_comment","sequence":1,"text":"I second this.\n\nI really prefer keeping assets (images mostly, but sometimes other file types) in the same place as the text content using them.","author_login":"nhoizey","author_association":"NONE","created_at":"2024-03-16T11:19:22+08:00","repo_name":"pages-cms/pages-cms","issue_id":2157757648,"issue_number":29,"issue_url":"https://github.com/pages-cms/pages-cms/issues/29","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2001954701","fragment_type":"issue_comment","sequence":2,"text":"I think this is related to what's been asked in another issue:\n- #14","author_login":"nhoizey","author_association":"NONE","created_at":"2024-03-16T11:21:38+08:00","repo_name":"pages-cms/pages-cms","issue_id":2157757648,"issue_number":29,"issue_url":"https://github.com/pages-cms/pages-cms/issues/29","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2027881163","fragment_type":"issue_comment","sequence":3,"text":"I think to enable this I would probably need to do 2 things:\n\n1. Enable saving posts in a subfolder, meaning that rather than saving an entry as `posts/my-entry.md` I would save it as `posts/my-entry/index.md`.\n2. For new content, force the user to save the entry before uploading any asset.\n\nThe issue with the first point is that this will likely require a lot more work as to retrieve all the entries in a collection I'll need to run an individual query to the GitHub API for each entry as I don't think I can recursively fetch files with the GitHub GraphQL API. To make it manageable, I'll likely need to aggressively cache entries. That's probably more of a 1.0.0 version to be honest.","author_login":"hunvreus","author_association":"MEMBER","created_at":"2024-03-30T02:14:37+08:00","repo_name":"pages-cms/pages-cms","issue_id":2157757648,"issue_number":29,"issue_url":"https://github.com/pages-cms/pages-cms/issues/29","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2364313558","fragment_type":"issue_comment","sequence":4,"text":"@itstamimi @nhoizey how do you think the approach would work with media choosers or re-used images?\n\nI sometimes re-use images on multiple pages, I may have list and detail pages that re-use imagery although often at different sizes. Some times I just want to open a media browser and pick an image to use. It's easy with a git backend to list a folder and a few children, it's harder when the media browser has to look all over the repo to build it's collection.","author_login":"dopry","author_association":"NONE","created_at":"2024-09-20T18:37:34+08:00","repo_name":"pages-cms/pages-cms","issue_id":2157757648,"issue_number":29,"issue_url":"https://github.com/pages-cms/pages-cms/issues/29","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525384034","fragment_type":"issue_comment","sequence":5,"text":"Discussed in other threads. I'll keep this in mind in the future, but others seem to have been able to make their Astro or Hugo setup work without this (e.g. #129).","author_login":"hunvreus","author_association":"MEMBER","created_at":"2024-12-08T02:18:15+08:00","repo_name":"pages-cms/pages-cms","issue_id":2157757648,"issue_number":29,"issue_url":"https://github.com/pages-cms/pages-cms/issues/29","linked_issue_ids":[2724513079],"is_known_query_context":false},{"document_id":"gh_issue_2724513079","fragment_type":"issue_description","sequence":0,"text":"How to set up featured-image paths in Hugo\nHello! My Hugo blog files are all in individual folders under `content/posts`, and the blog images are in the same folder as the Markdown files. I have already solved the issue of uploading and referencing images in the body text, but the automatically generated featured image payh cannot be rendered by Hugo due to incorrect paths. I am unable to resolve this path issue by modifying the Hugo template because there are already hundreds of articles using the original method.\n\n## Pages CMS setting\n\nmedia:\n input: content/posts\n output: /content/posts \ncontent:\n ...\n - name: image\n label: Image\n type: image\n list: true\n options:\n input: content/posts\n output: /content/posts\n\n## Hugo Blog Needed\n\n---\ntitle: \"test\"\nimage:\n - 1.webp # featured-image\n---\n\n## Pages CMS Output Now\n\n---\ntitle: \"test\"\nimage:\n - content/editor/test/1.webp\n---","author_login":"h2dcc","author_association":"NONE","created_at":"2024-12-07T09:52:02+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525068181","fragment_type":"issue_comment","sequence":1,"text":"It's been asked a few times for this (for Hugo specifically).\n\nI've not yet figured out a way to handle this gracefully in Pages CMS. The expectation right now is that you upload all media in the same folders, not individual folders for your content.","author_login":"hunvreus","author_association":"MEMBER","created_at":"2024-12-07T10:45:24+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525070327","fragment_type":"issue_comment","sequence":2,"text":"Thank you, I'm completely heartbroken. I'll just keep using some IDE tools like VSCode, but it's really inconvenient on a phone.","author_login":"h2dcc","author_association":"NONE","created_at":"2024-12-07T10:54:11+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525074904","fragment_type":"issue_comment","sequence":3,"text":"Doesn't mean I won't get something sorted out ultimately. I just need time to sit down and figure out how I would handle it.\n\nThe main issue with this Hugo flow is that you need to define the name of the folder (and thus the slug) before you upload the assets. But in Pages CMS, for new entries, the slug/filename is set up on saving the entry.\n\nIf you have suggestions, let me know.","author_login":"hunvreus","author_association":"MEMBER","created_at":"2024-12-07T11:12:46+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525101765","fragment_type":"issue_comment","sequence":4,"text":"After hearing you describe the issue, I actually came up with a solution. I set up a dedicated area for adding images, which uploads images to the same directory as the Markdown file, and then set the featured image as a string, manually filling in the image address. I didn't expect it to be so simple.\n\nThat's great!\n\nmedia:\n input: content/post\n output: /content/post\n categories: [image]\ncontent:\n - name: posts\n label: Posts\n type: collection\n path: content/post\n filename: index.md\n view:\n fields: [ title, date, draft ]\n fields:\n - { name: title, label: Title, type: string, required: true }\n - { name: draft, label: Draft, type: boolean, default: true }\n - { name: slug, label: Slug, type: string, required: true }\n - name: date\n label: Date\n type: date\n options:\n format: yyyy-MM-dd'T'HH:mm:ss\n time: true\n - name: categories\n label: Categories\n type: select\n list: true\n options:\n values:\n - legal\n - cases\n - name: tags\n label: Tags\n type: string\n list:\n min: 1\n max: 5\n - name: uploadimage\n label: Uploadimage\n type: object\n list: true\n fields:\n - name: newimage\n label: newimage\n type: image\n options:\n input: content/post\n output: content/post\n categories: [image]\n - { name: image, label: image, type: string, required: true }\n - name: body\n label: Body\n type: rich-text","author_login":"h2dcc","author_association":"NONE","created_at":"2024-12-07T12:44:18+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525176147","fragment_type":"issue_comment","sequence":5,"text":"Great to hear that. I'll close this issue for now, I'll still have a look at supporting a more complex setup for Hugo if possible.","author_login":"hunvreus","author_association":"MEMBER","created_at":"2024-12-07T14:03:05+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2527883742","fragment_type":"issue_comment","sequence":6,"text":"I believe I have fully resolved the issue with the Hugo directory structure. \n\nThere are three settings that need to be adjusted:\n\n 1. In the Pages CMS, do not fill in the media output path with \"content\"; just keep it as \"posts\". \n\n2. Set Hugo's permalink configuration to the default format, which uses the name of the folder containing index.md as the slug. \n\nThe purpose of these two steps is to ensure that the image URLs in Pages CMS and the default Hugo format of a both output the same URL after Hugo's rendering. \n\n3. Customize an image hook in Hugo to extract only the filename part from the automatically generated a link in Pages CMS and render the file. \n\nThis is done so that Hugo treats a and a as the same element for rendering. \n\nUltimately, the problem has been successfully resolved.","author_login":"h2dcc","author_association":"NONE","created_at":"2024-12-09T13:09:41+08:00","repo_name":"pages-cms/pages-cms","issue_id":2724513079,"issue_number":129,"issue_url":"https://github.com/pages-cms/pages-cms/issues/129","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0144","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"VMs don't boot on 4Kn drive?","query_context":"How to file a helpful issue\n\n### Qubes OS release\n\nR4.1.1 **TESTING**\n\n### Brief summary\n\nUsing default \"LVM\" installation layout.\nWhen I install Qubes with \"LVM\" disk layout, the default pool is varlibqubes.\nThe VMs are all based on stock templates that are shipped with the iso. I didn't build 4Kn templates.\nAll my VMs don't boot after I upgrade dom0 to tesing-latest.\nWithout enabling testing, things are fine.\n\n### Steps to reproduce\n\n0. Find a NVMe drive using LBA sector size 4096.\n1. Install Qubes using \"LVM\" disk layout, and upgrade Qubes to latest (xen 4.14.5-7).\n2. Find that VMs do boot.\n3. Upgrade Qubes to testing-latest (without kernel latest) (xen 4.14.5-9).\n4. Find that no VM wants to boot.\n\n### Expected behavior\n\nVMs boot as usual.\n\n### Actual behavior\n\nAn error message, asserting \"Start failed: internal error: libxenlight failed to create new domain xxx\"\n\nHere are the logs in /var/log/libvirt/libxl/libxl-driver.log:\n\n2022-10-20 12:23:19.476+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5543] exited with error status 1\n2022-10-20 12:23:19.476+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on /dev/loop8 /var/lib/qubes/appvms/sys-net/private-dirty.img failed\n2022-10-20 12:23:19.570+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5542] exited with error status 1\n2022-10-20 12:23:19.570+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on /dev/loop9 /var/lib/qubes/appvms/sys-net/root-dirty.img failed\n2022-10-20 12:23:19.666+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5548] exited with error status 1\n2022-10-20 12:23:19.666+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on -r /dev/loop10 /var/lib/qubes/vm-kernels/5.15.74-1.fc32/modules.img failed\n2022-10-20 12:23:19.775+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5545] exited with error status 1\n2022-10-20 12:23:19.775+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on /dev/loop11 /var/lib/qubes/appvms/sys-net/volatile-dirty.img failed\n2022-10-20 12:23:19.775+0000: libxl: libxl_create.c:1686:domcreate_launch_dm: Domain 3:unable to add disk devices\n2022-10-20 12:23:19.828+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5805] exited with error status 1\n2022-10-20 12:23:19.829+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.\n2022-10-20 12:23:19.839+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5804] exited with error status 1\n2022-10-20 12:23:19.839+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.\n2022-10-20 12:23:19.849+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5807] exited with error status 1\n2022-10-20 12:23:19.849+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.\n2022-10-20 12:23:19.858+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5810] exited with error status 1\n2022-10-20 12:23:19.859+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.","known_context_document_ids":["gh_issue_1415750847"],"reference_answer":"Sector size is advertised by the block backend in xenstore (`xenstore-ls /local/domain/0/backend/vbd/$DOMID/51712`), but I don't see any option to force specific value.\n\nThis issue is really unfortunate, because a lot of places in Qubes assume you can freely transfer disk image and it will work just fine. This include cloning VMs (including cloning to a different storage pool), backup/restore etc. So, the solution here should be either:\n- find a way to construct a disk image to work on both 4k and 512 sector size\n- force VM to see 512 sector size\n\nThe second one may come with a performance penalty. The first one would not have this problem, but not sure if it's possible. I'm fine with making partition table 4K aligned, as long as it will also work with 512 sector size. But it isn't clear to me it would be enough.\n\nPartition table and filesystem are built here: URL \n\nAnother idea would be to revert to a filesystem directly on /dev/xvda (without any partition table). This may not be as simple as it sounds, because we need to fit grub somewhere (with HVM with in-VM kernel case).\n\nBut this all may not work for other cases, including other OS. Imagine installing some OS (Linux, Windows, whatever) in a standalone HVM and then moving it to another storage pool (or restoring a backup on another machine). Those cases may require emulating constant sector size.\n\nSadly, I don't have any hardware with 4k physical sector size to test on. I'll try to find a way to emulate one.\n\nBTW, another issue from 4k sector size is 8GB of swap, instead of 1GB. But this should be easy to fix in this script","answer_document_id":"gh_comment_482894704","silver_evidence_path":["gh_comment_1287796015","gh_issue_432903853","gh_comment_482894704"],"evidence_issue_ids":[1415750847,432903853],"source_repo_name":"QubesOS/qubes-issues","source_issue_id":1415750847,"source_issue_number":7828,"source_issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","target_repo_name":"QubesOS/qubes-issues","target_issue_id":432903853,"target_issue_number":4974,"target_issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","reference_anchor_document_id":"gh_comment_1287796015","reference_answer_author":"marmarek","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1216,"anchor_target_overlap":0.3243,"target_answer_overlap":0.3136},"issue_created_at":"2022-10-20T00:55:07+08:00","valid_comment_count":54,"fragments":[{"document_id":"gh_issue_1415750847","fragment_type":"issue_description","sequence":0,"text":"VMs don't boot on 4Kn drive\nHow to file a helpful issue\n\n### Qubes OS release\n\nR4.1.1 **TESTING**\n\n### Brief summary\n\nUsing default \"LVM\" installation layout.\nWhen I install Qubes with \"LVM\" disk layout, the default pool is varlibqubes.\nThe VMs are all based on stock templates that are shipped with the iso. I didn't build 4Kn templates.\nAll my VMs don't boot after I upgrade dom0 to tesing-latest.\nWithout enabling testing, things are fine.\n\n### Steps to reproduce\n\n0. Find a NVMe drive using LBA sector size 4096.\n1. Install Qubes using \"LVM\" disk layout, and upgrade Qubes to latest (xen 4.14.5-7).\n2. Find that VMs do boot.\n3. Upgrade Qubes to testing-latest (without kernel latest) (xen 4.14.5-9).\n4. Find that no VM wants to boot.\n\n### Expected behavior\n\nVMs boot as usual.\n\n### Actual behavior\n\nAn error message, asserting \"Start failed: internal error: libxenlight failed to create new domain xxx\"\n\nHere are the logs in /var/log/libvirt/libxl/libxl-driver.log:\n\n2022-10-20 12:23:19.476+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5543] exited with error status 1\n2022-10-20 12:23:19.476+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on /dev/loop8 /var/lib/qubes/appvms/sys-net/private-dirty.img failed\n2022-10-20 12:23:19.570+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5542] exited with error status 1\n2022-10-20 12:23:19.570+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on /dev/loop9 /var/lib/qubes/appvms/sys-net/root-dirty.img failed\n2022-10-20 12:23:19.666+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5548] exited with error status 1\n2022-10-20 12:23:19.666+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on -r /dev/loop10 /var/lib/qubes/vm-kernels/5.15.74-1.fc32/modules.img failed\n2022-10-20 12:23:19.775+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block add [5545] exited with error status 1\n2022-10-20 12:23:19.775+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: losetup --direct-io=on /dev/loop11 /var/lib/qubes/appvms/sys-net/volatile-dirty.img failed\n2022-10-20 12:23:19.775+0000: libxl: libxl_create.c:1686:domcreate_launch_dm: Domain 3:unable to add disk devices\n2022-10-20 12:23:19.828+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5805] exited with error status 1\n2022-10-20 12:23:19.829+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.\n2022-10-20 12:23:19.839+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5804] exited with error status 1\n2022-10-20 12:23:19.839+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.\n2022-10-20 12:23:19.849+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5807] exited with error status 1\n2022-10-20 12:23:19.849+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.\n2022-10-20 12:23:19.858+0000: libxl: libxl_exec.c:117:libxl_report_child_exitstatus: /etc/xen/scripts/block remove [5810] exited with error status 1\n2022-10-20 12:23:19.859+0000: libxl: libxl_device.c:1302:device_hotplug_child_death_cb: script: /etc/xen/scripts/block failed; error detected.","author_login":"SurFlurer","author_association":"NONE","created_at":"2022-10-20T00:55:07+08:00","repo_name":"QubesOS/qubes-issues","issue_id":1415750847,"issue_number":7828,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1284835857","fragment_type":"issue_comment","sequence":1,"text":"The fix will be in repo soon. In the meantime, you can recover by editing `/etc/xen/scripts/block` and removing `--direct-io=on` parameter from `losetup` call.","author_login":"marmarek","author_association":"MEMBER","created_at":"2022-10-20T02:44:34+08:00","repo_name":"QubesOS/qubes-issues","issue_id":1415750847,"issue_number":7828,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1284840866","fragment_type":"issue_comment","sequence":2,"text":"Whoops! I had not considered that at all. Glad this got caught in testing!","author_login":"DemiMarie","author_association":"NONE","created_at":"2022-10-20T02:51:56+08:00","repo_name":"QubesOS/qubes-issues","issue_id":1415750847,"issue_number":7828,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1285386392","fragment_type":"issue_comment","sequence":3,"text":"This is fixed in util-linux v2.38+, although we'd also have to pass an explicit `--sector-size=512` argument to ensure that the incompatible case is automatically resolved in favor of turning direct I/O off (as opposed to changing the logical block size).\n\n@SurFlurer did you by any chance manually set up a 4k dm-crypt sector size? The old `cryptsetup` in the R4.1.x installer defaults to 512 byte sectors even on drives with 4k logical sectors, so normally your LVM Thin pool should have arrived at 512 byte sectors as well and avoided this bug.","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-20T11:45:49+08:00","repo_name":"QubesOS/qubes-issues","issue_id":1415750847,"issue_number":7828,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287655350","fragment_type":"issue_comment","sequence":4,"text":"@rustybird \n\nIn fact, I'm using LVM thick pool, because if I choose to use the LVM thin layout in the installer, there will be an error message and no new partition will be created.\n \n\nWhoops, I forgot to explicitly emphasize that \"LVM\" is different from LVM-thin. \n \n\nHowever, if my memory is correct, the default pool in LVM thin layout is “vm”.","author_login":"SurFlurer","author_association":"NONE","created_at":"2022-10-22T07:09:27+08:00","repo_name":"QubesOS/qubes-issues","issue_id":1415750847,"issue_number":7828,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287796015","fragment_type":"issue_comment","sequence":5,"text":"Oh man, I always assumed that dm-crypt with sector_size 512 (the default on R4.1.x) would \"shield\" the upper storage layers from the 4Kn drive's logical block size. But actually it only works the other way around, which is sector_size 4096 bumping up a physical or logical block size of 512 on the underlying device to 4096 on the dm device.\n\nThat explains why this bug was able to affect your system.\n\nGeneral summary: People with 4Kn drives currently can't use lvm_thin pools (#4974), unless they're doing esoteric things like building custom template image files etc. And people who set up 4K dm-crypt on 512e drives have the same problem. But installation layouts compatible with the file-reflink driver are okay: \"Btrfs\", \"Standard Partition\", or \"LVM\" that's not \"Thin\". The latter two use XFS for the varlibqubes pool and are somewhat less tested, as you noticed :wink:","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-22T13:34:59+08:00","repo_name":"QubesOS/qubes-issues","issue_id":1415750847,"issue_number":7828,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/7828","linked_issue_ids":[432903853],"is_known_query_context":false},{"document_id":"gh_issue_432903853","fragment_type":"issue_description","sequence":0,"text":"Support 4k storage\n**Qubes OS version**\n\nR4.0\n\n**Affected component(s) or functionality**\n\nVMs not working/starting right from a fresh install.\n\n**Brief summary**\n\nRight after a fresh install, all VMs fail to mount root and therefore fails to start beyond the point where they expect /dev/xvda3 available. This happens on a device that has 4kB logical and physical block sizes (NVMe drive). This was not problem in R3.2 (as it used files by default for VM storage).\n\n**To Reproduce**\n\nSteps to reproduce the behavior:\n1. Install Qubes to a drive with 4kB sector size (both logical / physical); (I put /boot to a SATA drive with 512B sectors to avoid BIOS/NVMe boot challenges, rest of the system is on the NVMe with 4kB sectors).\n2. Firstboot stuff fails\n3. After clicking \"finish\" for firstboot, find out that no VM will start successfully (which explains firstboot failures I guess)\n4. Look to the VM logs, and find this from there:\n\n...\n[ 0.887548] blkfront: xvda: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled;\n[ 0.902355] blkfront: xvdb: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled;\n[ 0.924386] blkfront: xvdc: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled;\n[ 0.940325] blkfront: xvdd: flush diskcache: enabled; persistent grants: enabled; indirect descriptors: enabled;\nWaiting for /dev/xvda* devices...\nQubes: Doing R/W setup for TemplateVM...\n[ 1.049451] random: sfdisk: uninitialized urandom read (4 bytes read)\n[ 1.052481] xvdc: xvdc1\n[ 1.060250] random: mkswap: uninitialized urandom read (16 bytes read)\nSetting up swapspace version 1, size = 8 GiB (8589930496 bytes)\nno label, UUID=...\nQubes: done.\nmount: wrong fs type, bad option, bad superblock on /dev/xvda,\n missing codepage or helper program, or other error\n\n In some cases useful info is found in syslog - try\n dmesg | tail or so.\nWaiting for /dev/xvdd device...\nmount: /dev/xvdd is write-protected, mounting read-only\n[ 1.099814] EXT4-fs (xvdd): mounting ext3 file system using the ext4 subsystem\n[ 1.106796] EXT4-fs (xvdd): mounted filesystem with ordered data mode. Opts: (null)\nmount: /sysroot not mounted or bad option\n\n In some cases useful info is found in syslog - try\n dmesg | tail or so.\n[ 1.119049] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x1e335a008d5, max_idle_ns: 440795216613 ns\nmount: /sysroot not mounted or bad option\n\n In some cases useful info is found in syslog - try\n dmesg | tail or so.\nswitch_root: failed to mount moving /sysroot to /: Invalid argument\nswitch_root: failed. Sorry.\n[ 1.217841] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100\n...\n\n**Expected behavior**\n\nVMs would start. Firstboot stuff would work. Drives with 4kB sector size would work.\n\n**Additional context**\n\nI've tracked this down to the handling of the partition table. With 512B sectors the location of the GPT differs from that of with 4kB sectors and therefore VMs fail to find the correct partition table from xvda. Obviously also the partition start/end values will be off by the factor of 8 because the templates are built(?) with an assumption of 512B sector size.\n\nI'm not sure if there are other assumptions based on 512B sectors with the other /dev/xvd* drives.\n\n**Solutions you've tried**\n\nI cloned a template and I tried to manually fix the partition table of the clone (in dom0 through /dev/qubes_dom0/...). There's was plenty of space before the first partition, however, at the end the drive is so tight on space that the GPT secondary table won't fit so the xvda3 partition's tail was truncated slightly and I didn't try to resize its filesystem first (this probably causes some problems, potentially corruption?). With such a fixed partition table, I could start VMs (but there are then some other problems/oddities that might be due to incomplete firstboot or non-fixed fedora template, I only fixed the debian one which I mainly use normally). I could possibly enlarge the relevant LV slightly to avoid the truncate problem at the tail of xvda3 but I've not tried that yet.\n\nI tried to look if I could somehow force pv/vg/lv chain to fake the logical sector size but couldn't find anything from the manpages.\n\nLibvirt *might* be able to fake the \nlogical_block_size\n but I've not yet tried that.\n\n**Relevant documentation you've consulted**\n\nDuring install, I used the custom install steps to create manual partitioning (but I think it is irrelevant).\n\n**Related, non-duplicate issues**\n\nNone I could find, some other issues included failure to mount root successfully but the causes are different.\n\n**Decided solution**\n\nAdd a partition table conversion to initramfs. Specifically, write a tool that would check if partition table matches current block size. If it matches, do nothing. If not, convert it to the right block size format before mounting anything. And destroy the wrong partition table (if isn't directly overridden by the converted one) to prevent confusion which one is the current one.\n\nReferences:\n URL \n URL","author_login":"ij1","author_association":"NONE","created_at":"2019-04-13T21:39:09+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_482894704","fragment_type":"issue_comment","sequence":1,"text":"Sector size is advertised by the block backend in xenstore (`xenstore-ls /local/domain/0/backend/vbd/$DOMID/51712`), but I don't see any option to force specific value.\n\nThis issue is really unfortunate, because a lot of places in Qubes assume you can freely transfer disk image and it will work just fine. This include cloning VMs (including cloning to a different storage pool), backup/restore etc. So, the solution here should be either:\n- find a way to construct a disk image to work on both 4k and 512 sector size\n- force VM to see 512 sector size\n\nThe second one may come with a performance penalty. The first one would not have this problem, but not sure if it's possible. I'm fine with making partition table 4K aligned, as long as it will also work with 512 sector size. But it isn't clear to me it would be enough.\n\nPartition table and filesystem are built here: URL \n\nAnother idea would be to revert to a filesystem directly on /dev/xvda (without any partition table). This may not be as simple as it sounds, because we need to fit grub somewhere (with HVM with in-VM kernel case).\n\nBut this all may not work for other cases, including other OS. Imagine installing some OS (Linux, Windows, whatever) in a standalone HVM and then moving it to another storage pool (or restoring a backup on another machine). Those cases may require emulating constant sector size.\n\nSadly, I don't have any hardware with 4k physical sector size to test on. I'll try to find a way to emulate one.\n\nBTW, another issue from 4k sector size is 8GB of swap, instead of 1GB. But this should be easy to fix in this script","author_login":"marmarek","author_association":"MEMBER","created_at":"2019-04-13T22:24:50+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_482897265","fragment_type":"issue_comment","sequence":2,"text":"A lot of useful info: URL \nThere is also a script to parse 512-byte GPT on 4k disk (and map it using loop devices).\nUsing this, one workaround would be to adjust `init.sh` to rewrite GPT if sector mismatch is detected (in either direction). This require the partitions to be 4k aligned before, but it should be doable.\nBut this is far from a complete solution, given non-template-based Linux use cases.","author_login":"marmarek","author_association":"MEMBER","created_at":"2019-04-13T23:12:40+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483032991","fragment_type":"issue_comment","sequence":3,"text":"There's not much to worry about 4k alignment, it is already there in the template: what I gathered, the partition table tools nowadays will enforce at least 4k alignment and they will warn if that would be violated (some might do even larger alignment). This is why I managed to rewrite the template's partition table in the first place so easily (except the truncate issue).\n\nI don't think forcing 512 sector size itself would come with a large penalty as in practice the filesystems inside will use something larger than 512 (depending on how all relevant block stuff handles the larger continuous units of course but I'd guess that would not cause performance problems). So it would be mostly relevant for booting up correctly. What I'd rather avoid though, is forcing my drive's firmware to use 512 sector size as it would explore less tested corners of the firmware and possibly have significant performance impact too (I know my NVMe drive could do 512 but I don't know if all 4k drives are able so this needs to be handled anyway).\n\nBtw, the USB HDDs might expose 4kB when not behind the SATA-to-USB converter, perhaps you have one of them which you can disassemble to get such a device?\n\nLike I said, libvirt supposedly has a way to configure \nlogical_block_size\n but I don't know if that is able to fake it for real:\n URL \n...or is that only for KVM?\n\nI'll probably try to use the file backend (that's what was used in R3.2 right?) for the main system for now (the NVMe drive should clone fast anyway :-) so the biggest downside I know of is a non-issue). Can the installer do that automatically if I simply reinstall (that is, how it chooses which type of storage pool to use by default) or do I have to manually setup everything afterwards skipping the firstboot stuff to avoid it failing? I can then look into the 4k stuff while other stuff keeps working fine with 512. That would also allow me to easily test cross 512 and 4k copying but that looks rather scary to begin with, so far about nothing seems portable from one sector size to another from what I've read.\n\nIf the partition table would be removed from xvda, the grub might have a similar 4k vs 512 issue anyway so that might not solve anything (sector was mentioned somewhere when I tried to look into what kind of information format it uses which sound bad) but this needs a deeper investigation.","author_login":"ij1","author_association":"NONE","created_at":"2019-04-14T18:14:13+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483060550","fragment_type":"issue_comment","sequence":4,"text":"Yes, I think it's KVM only.\n \n\nIf you choose btrfs during installation, Qubes will use that instead of LVM.","author_login":"marmarek","author_association":"MEMBER","created_at":"2019-04-14T21:39:13+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483222153","fragment_type":"issue_comment","sequence":5,"text":"Could not the faking be done other way around? I'd feel by intuition that in block code log4096 -> phy512 is far simpler than log512 -> phy4096.\n\nOr is there some particular reason why 512 is still needed for the VM disk format that is almost internal to Qubes. VMs will obviously see the end result but they should have little reason to change how the sector size is defined by the \"internal\" format. Or is there some other OS that only works with 512?\n\nThat would leave just a few things to address:\n- block support for log4096 -> phy512 (or any 2^n to be more generic).\n- Template building code to create 4k GPT (sfdisk doesn't seem to support forcing sector size unlike some other partition tools but losetup could be used to fake it).\n- Fix the 512 assumptions (such as the one with swap partition sizing), hopefully not that many\n- One-time migration (at new release?) which would be at most as complex as a GPT rewrite workaround needed for supporting both sizes, probably somewhat less.","author_login":"ij1","author_association":"NONE","created_at":"2019-04-15T11:58:21+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483253355","fragment_type":"issue_comment","sequence":6,"text":"I'm not sure about disks emulated by QEMU. And then windows PV drivers. Recently I've seen some patches flying around fixing 512 sector size assumption somewhere there, so there still may be more issues like this.\nGiven various elements involved, I think 512 is simply safer in terms of compatibility.","author_login":"marmarek","author_association":"MEMBER","created_at":"2019-04-15T13:33:41+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_509276545","fragment_type":"issue_comment","sequence":7,"text":"Can I throw in another alignment data point to consider: the LVM chunk_size, which can range from 64KB to 1MB.\n\nPolicy-wise, Qubes may want to consider ensuring that any physical partitions (or partitions inside lvm LVs), that are created by qubes tools, are 1MB aligned, primarily for performance reasons. Probably not as critical as the baseline fixes to ensure 4K logical sector drives work, but since that requires changes, consider enforcing a much more strict alignment going forward (see the volatile volume issue #5151).\n\nBrendan","author_login":"brendanhoar","author_association":"NONE","created_at":"2019-07-08T15:35:59+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_575955927","fragment_type":"issue_comment","sequence":8,"text":"If anyone needs 4Kn templates right now, can use my patch from URL \n\nI have also found that ``partprobe`` will fail to spawn the partitions on loop devices created with the custom sector size (losetup: -b / --sector-size) not corresponding to the sector size of the backing disk on Linux `< 4.18-rc4``.","author_login":"arno01","author_association":"NONE","created_at":"2020-01-19T01:30:40+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287808999","fragment_type":"issue_comment","sequence":9,"text":"This will become a bigger problem with R4.2, where cryptsetup >= 2.4.0 (Fedora >= 35) will automatically create dm-crypt with 4K logical sectors even on 512e drives.\n\nIdeas:\n\n- Invoke `cryptsetup luksFormat` with an explicit `--sector-size=512` argument for the LVM Thin installation layout (fix for 512e drives)\n\n- Attach thin volumes via a loop devices (fix for 4Kn and 512e drives)","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-22T14:21:53+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287845404","fragment_type":"issue_comment","sequence":10,"text":"I wonder if Qubes pools should specify the sector size of their underlying storage technology, and whether importing volumes should involve a conversion step?\n\nB","author_login":"brendanhoar","author_association":"NONE","created_at":"2022-10-22T16:24:24+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287848914","fragment_type":"issue_comment","sequence":11,"text":"Conversion during import would mean parsing VM data in dom0 😬","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-22T16:32:27+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287867612","fragment_type":"issue_comment","sequence":12,"text":"Ok someone should definitely write a DisposableVM-powered converter for common volume contents.\n\nBut automatic conversion won't be possible in all cases (like standalone HVMs where a volume could contain anything, e.g. bs dependent filesystems that might not be straightforward to upgrade), so even with a very good converter there's still a need for\n\n- per-volume metadata recording the appropriate bs for its current content\n- a mechanism to present the volume to the VM with that bs, even if the storage pool's ideal bs is different, e.g. after restoring from a backup","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-22T17:44:22+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287887619","fragment_type":"issue_comment","sequence":13,"text":"I'm kinda curious too about how writes really work for kernel -> 512e drive communication.\n\nPure speculation: Since both the kernel and the drive know that the drive's physical block size is 4K, maybe the kernel just always writes batches of 8 * 512B logical blocks - and when the drive sees logical blocks coming in fast enough, one immediately following another, it figures out that read-modify-write can be avoided? Or there could be some explicit way for the kernel to signal to the drive that it's aware of 512e and that it guarantees to send 4K blocks merely encoded as batches of 512B blocks.\n \n\nHuh. Thanks! Wonder if that's better than a loop device.","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-22T19:11:09+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287940307","fragment_type":"issue_comment","sequence":14,"text":"I can think of at least two solutions:\n\n1. Place the partition table for a 512e device between the protective MBR and the 4Kn GPT. There are 7 512-byte sectors in this space, which allows for up to 6 partitions. This is enough to fit all three partitions used by Qubes OS, plus one extra covering the 4Kn partition table. The only problem with this approach is that if the block size is 4K, the protective MBR will appear to extend past the end of the device. I suspect this is harmless.\n2. Use a partition table that is not part of the image, but instead is overlayed on it at runtime. This can be done by using `dm-linear`.","author_login":"DemiMarie","author_association":"NONE","created_at":"2022-10-22T22:59:24+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1288952119","fragment_type":"issue_comment","sequence":15,"text":"@DemiMarie I don't get (1). Would there be some script in the VM's initrd to rewrite the partition table (\"activating\" the stashed away 512B version) depending on xvda's current logical block size?\n\nDynamically switching back and forth between 512B and 4K partitioning seems like it could make resizing the volume (`resize-rootfs-if-needed.sh` and `resize-rootfs`) a little scary...","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-24T12:21:23+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1288972609","fragment_type":"issue_comment","sequence":16,"text":"Generally, I'd try to avoid any kind of conversion at startup and go for emulation when necessary. That means:\n - recording expected block size by the volume\n - emulating it, if the underlying pool has different block size\n\nAnd then, either build templates with two flavors, or convert at the install time (as part of `qvm-template-postprocess`), if reasonably easy.\n\nCan we get away without emulating 4k bs on 512 bs devices?","author_login":"marmarek","author_association":"MEMBER","created_at":"2022-10-24T12:38:27+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289037476","fragment_type":"issue_comment","sequence":17,"text":"Once there's a way to attach a volume as 4K, why even bother building (or converting to) 512B templates.\n \n\nForcing `--sector-size=4096` for `luksFormat` in the installer (or `reencrypt` in the upgrade script) even on drives reporting 512B physical sectors would have the same effect.\n\nI'd guess almost all of those drives (that make sense to install a Qubes storage pool on) actually have 4K physical sectors anyway, but it's misreported by shoddy firmware or an adapter.","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-24T13:29:03+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289053181","fragment_type":"issue_comment","sequence":18,"text":"Ah wait, I haven't tested if `reencrypt --sector-size=4096` would work to bump up an *existing* LVM Thin pool. I'll try it today or tomorrow.","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-24T13:40:14+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289229075","fragment_type":"issue_comment","sequence":19,"text":"Thanks :roll_eyes: Samsung! I just checked `/sys/block/DEVICE/queue/*_block_size` for an older consumer 850 Pro and indeed it's 512 logical / 512 physical where my daily driver, a datacentery PM883 says 512/4096. Both SATA.\n\nBut a consumer NVMe by Western Digital also said 512/4096.\n \n\nCome to think of it, was that ever something to be relied on? Like, even in a pure 512B world of ancient spinning rust - partially written or otherwise corrupted blocks are legal (and not unusual) in case of a power outage, no? And block device users like filesystems must cope with this through journals or other suitable data structures.","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-24T15:41:44+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289232198","fragment_type":"issue_comment","sequence":20,"text":"Almost all storage primary devices produced today are (at least internally) logically 4096 and present externally as either 512e (emulated logical 512) or 4Kn (native). \n\nPhysically it's even weirder since now both flash *and spinning platters* on primary storage can have larger physical minimal write sizes under some/all circumstances (and much larger physical erase/zeroing sizes for flash, such as 1MB or 4MB). Also the SMR disks are super-super-weird.\n\nBut we mostly have to worry about whether the pool is on a 512n, 512e or 4096 device.\n\nI think the safest thing to do is force everything (partitions, crypto overlays, pools, templates\nVolumes, filesystems) to aligned, 4K block sizes up and down the stack. \n\nFor better erase-block-faster-after-discard support, keeping partitions/overlays/volumes 1MB or 4MB aligned might be even better.\n\nPossibly keep around a 512 pool (or allow creation of an ephemeral 512 pool before conversion) for restoring/importing 512-based VMs but with the knowledge that those will run non-optimally until converted. And direct-io would be disabled for such a pool on a 4Kn device.\n\nI think the future is 4Kn. Near future anyway.\n\nB","author_login":"brendanhoar","author_association":"NONE","created_at":"2022-10-24T15:44:06+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289325054","fragment_type":"issue_comment","sequence":21,"text":"No, both partition tables would be present at all times. The logical block size determines which one the kernel will parse.","author_login":"DemiMarie","author_association":"NONE","created_at":"2022-10-24T16:56:16+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289438761","fragment_type":"issue_comment","sequence":22,"text":"I recommend checking that at least Linux and systemd-gpt-generator handle it properly. We will of course need to implement our own code for _writing_ these hybrid partition tables, but existing tools should have no problems _reading_ them, at least if I understood the GPT specification correctly.\n \n \n \n\nSome more information:\n\n- ext4 blindly assumes that 4K overwrites are atomic, no matter what the logical sector size is.\n- XFS is aware of the logical vs physical sector size distinction. It will try to use physical-sector writes where possible, but only assumes atomicity of logical-sector writes.\n- I am not sure about BTRFS, ZFS, LVM, or dm-thin. With BTRFS and ZFS at a minimum one should get an error instead of wrong data.","author_login":"DemiMarie","author_association":"NONE","created_at":"2022-10-24T18:37:03+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289452559","fragment_type":"issue_comment","sequence":23,"text":"There was a paper (I will try to find a link later) that found that on some NVMe devices, 512B writes were atomic while 4096B writes were not.","author_login":"DemiMarie","author_association":"NONE","created_at":"2022-10-24T18:49:09+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289454405","fragment_type":"issue_comment","sequence":24,"text":"Overall, I think these kind of problems are a good reason to switch to BTRFS-by-default, at least if BTRFS actually solves them. Since BTRFS is copy-on-write, it can (at least in theory) provide atomicity guarantees for arbitrary-sized writes, and I hope that it provides them for 4K writes at a minimum.","author_login":"DemiMarie","author_association":"NONE","created_at":"2022-10-24T18:50:51+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289598814","fragment_type":"issue_comment","sequence":25,"text":"Moving an existing LVM Thin pool from a logical 512B block device to a logical 4K block device appears to work fine and *does* bump up the logical block size - but uh oh (#5685):","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-24T20:48:07+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1290891792","fragment_type":"issue_comment","sequence":26,"text":"Here's a written down concrete proposal of the sketched out transition to 4K storage, so my head doesn't explode. \n\nIt would fix 4Kn drive incompatiblity (this issue), prevent the upcoming 512e drive incompatibilty, and accomodate the corner case of unencrypted (or otherwise unable to be reencrypted to 4K) lvm_thin pools on 512B drives.\n\nLet me know what I've missed.\n\n## 1. Add `Volume.logical_block_size` property\n\n- default value 512\n- distinguish between default value 512 and explicitly assigned value 512\n- volume cloning preserves source value (default vs. assigned still distinguished)\n- expose via Admin API\n - `qvm-volume config`\n- `qvm-template(-postprocess)` support\n - assign value for 'root' from template package metadata (512 if missing)\n- backup/restore support\n - preserve value (still distinguished) for 'root' and for 'private'\n - if feasible, preserve assigned value for 'volatile' object (see \"rare case\" in section 4)\n - Wyng?\n- forum: notify existing users of custom built 4K templates that they should assign 4096 in preparation\n - also after they restore already backed up (before property implementation) custom built 4K templates in the future\n\n## 2. Storage driver support for `Volume.logical_block_size`\n\n- file(-reflink): `losetup --sector-size=...` in `/etc/xen/scripts/block`\n - old `losetup` triggers a race in old kernels with that argument\n- lvm_thin: dm-ebs (can emulate in either direction)\n- `Volume.ephemeral_volatile`\n - call `cryptsetup --type=plain` with `--sector-size=4096` (fc32 manpage is outdated, it works)\n - optional optimization for 512 as 4K: skip dm-ebs layer, 4K dm-crypt is enough\n - 'volatile' size must be a multiple of 4K (neither dm-ebs nor dm-crypt allow unaligned size)\n - lvm_thin: looks like LVM Thin already aligns size to 4 MiB\n - file-(reflink): loop device always aligns size to 512\n\n## 3. Optimize Qubes OS installation\n\n- hardcode `cryptsetup luksFormat --sector-size=4096` in installer\n - raw device size must be a multiple of 4K or `cryptsetup` will fail\n - `cryptsetup --device-size=...` appears to be broken for this purpose\n - report bug\n - work around somehow or patch\n- `qubes-dist-upgrade`: optional final `cryptsetup reencrypt --sector-size=4096` phase where feasible\n - not if XFS is dom0 fs\n - tricky if raw device size isn't a multiple of 4K\n - steal bytes from the old LUKS2 header?\n - offline reencryption instructions for old LUKS1 users coming from R4.0?\n\n## 4. Move to 4K volumes\n\n- assign 4096 to all default valued volume objects (existing or newly created) named 'kernel'\n- assign 4096 to all default valued volume objects (existing or newly created) named 'volatile'\n - dependency on new enough kernel-(latest-)qubes-vm / qubes-kernel-vm-support\n - rare case: standalone HVMs etc. doing custom partitioning of 'volatile' on startup\n - it's just 'volatile' - might be okay to break, and require user to assign 512 or fix their custom script?\n- assign 4096 to all newly created volume objects (cloning/restoring might then assign something else)\n- build 4K Templates\n- everything else: handle easy cases, provide user guidance and converters\n - existing 'private'\n - could be custom incompatible filesystem (XFS) etc.\n - VM init script advertising `volume-private-supports-logical-block-size=4096` feature if standard filesystem detected?\n - mass assignment command for people who know they're only using normal 'private' volumes\n - existing 'root' in TemplateVMs and StandaloneVMs\n - converter scripts","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-25T17:20:42+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291376967","fragment_type":"issue_comment","sequence":27,"text":"That is partly covered here: URL \n\nWhich requires manual alignment and lead to open URL for misalignment issues and needs for manual calculation since sfdisk and other tools were not properly dealing with partition table and partition alignments.","author_login":"tlaurion","author_association":"CONTRIBUTOR","created_at":"2022-10-26T01:48:34+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291407825","fragment_type":"issue_comment","sequence":28,"text":"Heh, as an aside, I'm fairly certain this cross-manufacturer usb-SATA bridge behavior (stealing the last sector) exists in some chipsets to support saving state (likely not used by most variations of the bridges, even, but e.g. encryption/password) without having to include eeprom or NOR flash on the chipset. Possibly to ensure portability of that state with the drive (within the chipset anyway).\n\nThe amount of chaos it was to cause, however, was likely not forecast by the original engineers...\n\nIf not done already, it would be wise to ensure the remnant non-alignment friendly tails at the end of the storage devices are always excluded from usage via partitioning excluding them.\n\nB","author_login":"brendanhoar","author_association":"NONE","created_at":"2022-10-26T02:22:31+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291810472","fragment_type":"issue_comment","sequence":29,"text":"Thanks! Latest updates to the proposal:\n\n- workaround for `cryptsetup` is to ensure good partitioning\n- clarified default value mechanism for the property, it was too vague\n- legacy 'file' driver doesn't use `/etc/xen/scripts/block`, but linux-kernel driver does","author_login":"rustybird","author_association":"NONE","created_at":"2022-10-26T10:15:53+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1295866835","fragment_type":"issue_comment","sequence":30,"text":"Here is openQA run with 4kn emulated disk: URL \nfdisk there reports:\n\nfdisk -l /dev/nvme0n1\nfdisk -l /dev/nvme0n1\nDisk /dev/nvme0n1: 80 GiB, 85899345920 bytes, 20971520 sectors\nDisk model: QEMU NVMe Ctrl \nUnits: sectors of 1 * 4096 = 4096 bytes\nSector size (logical/physical): 4096 bytes / 4096 bytes\nI/O size (minimum/optimal): 4096 bytes / 4096 bytes\n\nAnd every VM fails to start, as expected.","author_login":"marmarek","author_association":"MEMBER","created_at":"2022-10-29T15:13:40+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1499871550","fragment_type":"issue_comment","sequence":31,"text":"Given the failure mode on 4.2 is worse than on 4.1, I think we should have it in 4.2. The plan outlined by @rustybird in URL looks good. @rustybird are you up for implementing this?","author_login":"marmarek","author_association":"MEMBER","created_at":"2023-04-07T02:42:44+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[432903853],"is_known_query_context":false},{"document_id":"gh_comment_1499910553","fragment_type":"issue_comment","sequence":32,"text":"@marmarek: what about write tearing? 4K sector writes on a 512e driver are not guaranteed to be atomic, and IIRC are _not_ atomic on some low-end SSDs in the event of power failure. XFS takes precautions against this.","author_login":"DemiMarie","author_association":"NONE","created_at":"2023-04-07T04:06:17+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1500995681","fragment_type":"issue_comment","sequence":33,"text":"Maybe we should get the R4.2 regression affecting 512e disks out of the way first, by hacking the installer to use `cryptsetup luksFormat --sector-size=512` whenever the LVM Thin layout has been selected and the destination disk has a 512-byte logical block size.\n\nBut yes I'm also still interested in starting on the proposal's phase 1 and 2 at least, to fix the existing lvm_thin (and zfs driver too?) incompatibility with 4Kn drives. Not sure how long it will take though.\n\nPhase 3 and 4 is where things would get spicy with the whole atomicity question. If a Qubes storage volume is exposed to the VM as a 4K block device even if the disk hardware might not provide atomic 4K writes, will this cause the filesystem on the volume to falsely *rely on* 4K writes being atomic *when it otherwise wouldn't have* - either for its own purposes in attempting to preserve its data structures' integrity, or as some sort of ineffective guarantee to an application writing data into a file? Tbd... There's an interesting writeup: URL","author_login":"rustybird","author_association":"NONE","created_at":"2023-04-08T23:19:15+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[432903853],"is_known_query_context":false},{"document_id":"gh_comment_1677074420","fragment_type":"issue_comment","sequence":34,"text":"I tried in URL \nBut it didn't worked: URL \n\n[2023-08-14 05:27:22] Waiting for /dev/xvda* devices...\n\n[2023-08-14 05:27:22] Qubes: Doing R/W setup for TemplateVM...\n\n[2023-08-14 05:27:23] [ 2.836815] xvdc: xvdc1 xvdc3\n\n[2023-08-14 05:27:23] Setting up swapspace version 1, size = 1073737728 bytes\n\n[2023-08-14 05:27:24] [ 3.052640] random: crng init done\n\n[2023-08-14 05:27:24] UUID=50685a9b-25ff-4cb6-b107-7170602a08e6\n\n[2023-08-14 05:27:24] Qubes: done.\n\n[2023-08-14 05:27:24] mount: mounting /dev/mapper/dmroot on /sysroot failed: Invalid argument\n\n[2023-08-14 05:27:24] Waiting for /dev/xvdd device...\n\n[2023-08-14 05:27:24] [ 3.086464] /dev/xvdd: Can't open blockdev\n\n[2023-08-14 05:27:24] [ 3.086937] EXT4-fs (xvdd): mounting ext3 file system using the ext4 subsystem\n\n[2023-08-14 05:27:24] [ 3.089277] EXT4-fs (xvdd): mounted filesystem with ordered data mode. Quota mode: none.\n\n[2023-08-14 05:27:24] mount: mounting none on /sysroot/lib/modules failed: No such file or directory\n\n[2023-08-14 05:27:24] [ 3.172895] EXT4-fs (xvdd): unmounting filesystem.\n\n[2023-08-14 05:27:24] mount: can't read '/proc/mounts': No such file or directory\n\n[2023-08-14 05:27:24] BusyBox v1.36.0 (2023-01-10 00:00:00 UTC) multi-call binary.\n\n[2023-08-14 05:27:24] \n[2023-08-14 05:27:24] Usage: switch_root [-c CONSOLE_DEV] NEW_ROOT NEW_INIT [ARGS]\n\n[2023-08-14 05:27:24] \n[2023-08-14 05:27:24] Free initramfs and switch to another root fs:\n\n[2023-08-14 05:27:24] chroot to NEW_ROOT, delete all in /, move NEW_ROOT to /,\n\n[2023-08-14 05:27:24] execute NEW_INIT. PID must be 1. NEW_ROOT must be a mountpoint.\n\n[2023-08-14 05:27:24] \n[2023-08-14 05:27:24] -c DEV Reopen stdio to DEV after switch\n\n[2023-08-14 05:27:24] [ 3.193656] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100\n\nI think I did set it correctly:\n\nroot# cryptsetup luksDump /dev/nvme0n1p3; echo efDdj-$?-\nLUKS header information\nVersion: 2\nEpoch: 3\nMetadata area: 16384 [bytes]\nKeyslots area: 16744448 [bytes]\nUUID: c51bf27f-c7e1-443b-917d-b95db5145101\nLabel: (no label)\nSubsystem: (no subsystem)\nFlags: (no flags)\n\nData segments:\n 0: crypt\n offset: 16777216 [bytes]\n length: (whole device)\n cipher: aes-xts-plain64\n sector: 512 [bytes]\n...\n\nAny ideas?","author_login":"marmarek","author_association":"MEMBER","created_at":"2023-08-14T10:28:59+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1677214554","fragment_type":"issue_comment","sequence":35,"text":"@marmarek:\n \n\nThe test had `HDDMODEL` configured with `physical_block_size=4096,logical_block_size=4096`, so it's emulating a 4Kn drive. To test 512e (in the sense that's causing the R4.2 regression due to new cryptsetup) it should be `physical_block_size=4096,logical_block_size=512`\n\n(Hardcoding `--sector-size=512` doesn't help with 4Kn drives, because dm-crypt cannot shrink the logical block size, it can only avoid enlarging it.)","author_login":"rustybird","author_association":"NONE","created_at":"2023-08-14T12:18:31+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1677356693","fragment_type":"issue_comment","sequence":36,"text":"Is it only partition table issue? What about the filesystem?\nBut also, the remark about dynamic resize is a valid one. Only one partition table will be updated, so if you migrate to a disk with a different logical block size, you'll get truncated partition.\nBut if that's _just_ about partition table, maybe we can do the conversion in initramfs before mounting anything? Assuming everything is 4k-aligned, it should be technically possible, right?","author_login":"marmarek","author_association":"MEMBER","created_at":"2023-08-14T13:51:43+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[432903853],"is_known_query_context":false},{"document_id":"gh_comment_1677366957","fragment_type":"issue_comment","sequence":37,"text":"Yup, it’s just about partition table, and we can avoid the dynamic resize problem by changing the partition table with our own tools that understand the different layout.","author_login":"DemiMarie","author_association":"NONE","created_at":"2023-08-14T13:57:41+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[432903853],"is_known_query_context":false},{"document_id":"gh_comment_1677417926","fragment_type":"issue_comment","sequence":38,"text":"@rustybird what do you think about adjusting partition table in initramfs?","author_login":"marmarek","author_association":"MEMBER","created_at":"2023-08-14T14:23:04+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1677478687","fragment_type":"issue_comment","sequence":39,"text":"I like the simplicity of it, especially compared to my 4-phase slog of a proposal.\n\nThe adjustment script should probably bail out early if the root volume looks too nonstandard? E.g. if xvda3 is not an ext4 filesystem (or another filesystem type that's whitelisted as known to be logical-block-size agnostic).","author_login":"rustybird","author_association":"NONE","created_at":"2023-08-14T14:52:21+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868135422","fragment_type":"issue_comment","sequence":40,"text":"Setting aside the question of what a good default would be for Qubes OS, using btrfs instead of LVM + ext4 actually does work around this issue on my 1 TB NVMe SSD (the model is a Sandisk Corp WD Blue SN570). It reports 4096 for both logical and physical sector size due to me following the instructions in the ArchWiki entry for Advanced Format a while back.[^1]\n\nAnyway, I ran into the same issue that OP mentioned while installing R4.2 on my desktop using the default disk configuration scheme, but everything works OK so far on a reinstall using btrfs. I wouldn't have even thought to do this if not for this issue and this comment on a duplicate issue.\n\nIt makes me wonder whether using other filesystems that have similar properties to btrfs would work, such as ZFS. Seems like adjusting the drive to emulate a sector size of 512 again may not be a viable workaround based on others' comments here, but I haven't tested it.\n\n[^1]: I'm aware that Advanced Format is a hard drive specific thing, but that's what the wiki entry is called.","author_login":"3uryd1ce","author_association":"NONE","created_at":"2023-12-22T23:51:17+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868138956","fragment_type":"issue_comment","sequence":41,"text":"That’s really interesting, but it actually makes sense: since BTRFS is copy-on-write, it can (at the expense of performance) make arbitrarily small writes atomic.","author_login":"DemiMarie","author_association":"NONE","created_at":"2023-12-22T23:57:23+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2448999767","fragment_type":"issue_comment","sequence":42,"text":"I currently plan to use the rust-gptman crate for this, as it is packaged in Fedora 41 and actually has things like test suites. It can be backported to older distros by bundling it.","author_login":"DemiMarie","author_association":"NONE","created_at":"2024-10-31T04:42:25+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2458358479","fragment_type":"issue_comment","sequence":43,"text":"Looks like _both_ `gptman` and `gpt` have the same bug: neither includes necessary calls to `fsync()`, and so both risk leaving the system unbootable in the event of power loss!","author_login":"DemiMarie","author_association":"NONE","created_at":"2024-11-05T23:04:42+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2461037762","fragment_type":"issue_comment","sequence":44,"text":"@marmarek: can the tool that converts from 512 to 4K and back be provided with the previous sector size (perhaps from metadata somewhere), or does it need to guess the previous sector size? The latter could be problematic if there are multiple GPTs on the disk.","author_login":"DemiMarie","author_association":"NONE","created_at":"2024-11-07T00:00:06+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2461047445","fragment_type":"issue_comment","sequence":45,"text":"You can get the current sector size (from sysfs?) and check if the current GPT matches. If not, do the conversion.","author_login":"marmarek","author_association":"MEMBER","created_at":"2024-11-07T00:04:51+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2483550922","fragment_type":"issue_comment","sequence":46,"text":"For those coming to this issue, if the device supports going back to 512 bytes then you can apply the commands in URL as a temporary solution until this is fixed (currently using it myself and don't notice any performance issues, so far it has been even faster than 4k and btrfs)","author_login":"ejose19","author_association":"NONE","created_at":"2024-11-18T16:36:41+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495255615","fragment_type":"issue_comment","sequence":47,"text":"Note to self: if we ever put something on the EFI partition of the template's root volume, create filesystem there with 4k block size.","author_login":"marmarek","author_association":"MEMBER","created_at":"2024-11-23T03:03:08+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3067019970","fragment_type":"issue_comment","sequence":48,"text":"Does this apply to every Template and dom0 automatically (also ones on BTRFS) or does the user need to do something (once r4.3 drops)?","author_login":"Atrate","author_association":"NONE","created_at":"2025-07-13T12:30:05+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3067048931","fragment_type":"issue_comment","sequence":49,"text":"@Atrate:\n\nThe changes (thanks to @DemiMarie) generally make up-to-date template-derived VMs compatible with volume data exposed to the VM as having 4K logical sectors. This is done by rewriting the partition table inside of the \"root\" volume's data on early VM startup, because partition tables are typically the only kind of volume data that is not agnostic to the logical sector size.\n\nHowever, the exposure of volumes to the VM as having 4K logical sectors currently only happens if it's required by the underlying storage. Automatically, it only happens for LVM on native 4K drives (drives with a 4K logical, not just physical sectors), a scenario that was previously incompatible with Qubes OS.\n\nAs a performance optimization, it would now be possible to use 4K sectors for the underlying dm-crypt storage layer in more cases:\n\n- For LVM, it might make sense now to remove the installer patch that tries to set up 512B logical sectors for dm-crypt even if the drive reports 4K physical sectors. This would then also use 4K logical sectors for dom0.\n\n- For Btrfs/XFS, 4K logical sectors for dm-crypt are already used if the the drive reports 4K physical sectors. However this only benefits dom0 at the moment. VMs still see 512B logical sectors, because the `qubes-block` utility always sets up loop devices with 512B logical sectors. It could be changed to use 4K logical sectors, through explicit configuration (e.g. by an environment variable) or ideally detected automatically.","author_login":"rustybird","author_association":"NONE","created_at":"2025-07-13T13:27:33+08:00","repo_name":"QubesOS/qubes-issues","issue_id":432903853,"issue_number":4974,"issue_url":"https://github.com/QubesOS/qubes-issues/issues/4974","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0146","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Liferay packages not loading from @liferay/cli generated remote app when using live development?","query_context":"### Issue type (mark with `x`)\n\n- [ ] :thinking: Question\n- [x] :bug: Bug report\n- [ ] :gift: Feature request\n- [ ] :woman_shrugging: Other\n\n### Version (mark with `x`)\n\n- [ ] :two: v2.x\n- [x] :three: v3.x\n\n### Description\n\n**Desired behavior:**\nDeployed/Live session remote app generated via `liferay@cli` shows correctly.\n\n**Current behavior:**\nGenerated project using `liferay@cli`, choosing Portal 7.4 and Remote App with React.\nWhen using `liferay start` the remote app is deployed but can't load external scripts (for example `react.js`). It tries to load them from the webpack server (`localhost:8081/o/frontend-js-react-web/__liferay__/exports/react.js`) where it looks like they dont exist instead of Liferay (`localhost:8080/o/frontend-js-react-web/__liferay__/exports/react.js`). Thanks to these remote app doesnt show at all.\n\nMy workaround for now is to use absolute url in `liferay.json` such as ` URL instead of provided `/o/frontend-js-react-web/__liferay__/exports/react.js`. \n\n**Repro instructions (if applicable):**\n1. Generate project using `liferay new`, targeting Portal 7.4, Remote App with React.\n2. Run `liferay start`\n3. Add remote widget to page\n4. Remote widget does not show at all\n**Other information (environment, versions etc):**\nPortal 7.4 49GA\nNode 16.18.0","known_context_document_ids":["gh_issue_1461289709"],"reference_answer":"The problem is in this line\n\nIt should say:\n\njavascript\n{\n include: project.assetsDir.asNative\n}\n\ninstead.","answer_document_id":"gh_comment_1375535500","silver_evidence_path":["gh_comment_1375329707","gh_issue_1461766437","gh_comment_1375535500"],"evidence_issue_ids":[1461289709,1461766437],"source_repo_name":"liferay/liferay-frontend-projects","source_issue_id":1461289709,"source_issue_number":1048,"source_issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","target_repo_name":"liferay/liferay-frontend-projects","target_issue_id":1461766437,"target_issue_number":1049,"target_issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1049","reference_anchor_document_id":"gh_comment_1375329707","reference_answer_author":"izaera","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2778,"anchor_target_overlap":0.2222,"target_answer_overlap":0.0},"issue_created_at":"2022-11-23T08:44:50+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_1461289709","fragment_type":"issue_description","sequence":0,"text":"Liferay packages not loading from @liferay/cli generated remote app when using live development\n### Issue type (mark with `x`)\n\n- [ ] :thinking: Question\n- [x] :bug: Bug report\n- [ ] :gift: Feature request\n- [ ] :woman_shrugging: Other\n\n### Version (mark with `x`)\n\n- [ ] :two: v2.x\n- [x] :three: v3.x\n\n### Description\n\n**Desired behavior:**\nDeployed/Live session remote app generated via `liferay@cli` shows correctly.\n\n**Current behavior:**\nGenerated project using `liferay@cli`, choosing Portal 7.4 and Remote App with React.\nWhen using `liferay start` the remote app is deployed but can't load external scripts (for example `react.js`). It tries to load them from the webpack server (`localhost:8081/o/frontend-js-react-web/__liferay__/exports/react.js`) where it looks like they dont exist instead of Liferay (`localhost:8080/o/frontend-js-react-web/__liferay__/exports/react.js`). Thanks to these remote app doesnt show at all.\n\nMy workaround for now is to use absolute url in `liferay.json` such as ` URL instead of provided `/o/frontend-js-react-web/__liferay__/exports/react.js`. \n\n**Repro instructions (if applicable):**\n1. Generate project using `liferay new`, targeting Portal 7.4, Remote App with React.\n2. Run `liferay start`\n3. Add remote widget to page\n4. Remote widget does not show at all\n**Other information (environment, versions etc):**\nPortal 7.4 49GA\nNode 16.18.0","author_login":"nitramek","author_association":"NONE","created_at":"2022-11-23T08:44:50+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1375324672","fragment_type":"issue_comment","sequence":1,"text":"I have created a project with the latest version of `@liferay/cli` and it works seamlessly for me:\n\nimage\n\nSee in the attached screenshot how `npm run start` starts and correctly reports that it will be fetching `react` and `react-dom` from Liferay Portal.\n\nAlso, see in Firefox (inside the screenshot) how the path to the .js files in the top import statements is correctly pointing to `/o/frontend-js-react-web/__liferay__/exports/....`, which is the path where those .js files live inside Liferay Portal.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T09:26:42+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375329707","fragment_type":"issue_comment","sequence":2,"text":"Can you please follow the same steps to see how the built `index.js` looks like in your case?\n\nYou just need to execute `npm run start`, then open ` URL in a browser. That will show how `@liferay/cli` (and webpack) is generating that file and how the imports from `react` and `react-dom` look like.\n\nAlternatively, you can run `npm run build` and see how the generated zip file looks like (though I'm afraid you will be affected by URL :-/ ).","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T09:31:12+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[1461766437],"is_known_query_context":false},{"document_id":"gh_comment_1375334356","fragment_type":"issue_comment","sequence":3,"text":"I can check whenever I will have a moment. Should be today.\n\nBut I remember the problem wasn't about the js file itself. It was when I placed the remote app widget into liferay page. It tried to load from the `/o/frontend-js-react-web` from ` URL not from the liferay which resides in `localhost:8080` by default. And it didnt load from the webpack server.","author_login":"nitramek","author_association":"NONE","created_at":"2023-01-09T09:35:33+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375394137","fragment_type":"issue_comment","sequence":4,"text":"Yes, but that's very strange, because if you look at the screenshot, the generated `index.js` imports `react` from `/o/frontend-js-react-web/...` without anchoring it to any host or port.\n\nThus, when you include that `index.js` file inside Liferay Portal and fetch it from, say, ` URL the unanchored `import` must be fetched from the page base URL (` URL not from ` URL as it is not the address you are using in the browser address bar.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T10:23:32+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375396808","fragment_type":"issue_comment","sequence":5,"text":"In other words, `import` URLs are relative to the page (address bar URL), not to the URL from where the script was fetched. So there's no way the browser can use ` URL instead of ` URL unless:\n\n1. It is specifically specified in the .js file \n2. You are fetching a proxied Liferay Portal from ` URL","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T10:25:28+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375507055","fragment_type":"issue_comment","sequence":6,"text":"Allright, I tried newly generated project on Windows with `liferay new`.\n\nTarget platform: Liferay Portal CE 7.4\nShadow dom: No\n\n`npm install`, then `npm run start` with the same versions reported on top.\n\nThen I removed all rules from `styles.css` to work around the bug.\n\nAfter that I dragged the remote widget to home page and it just tries to load from `localhost:8081` \n\nThis is `localhost:8081/index.js`\nindex.js\nSome more info\nimage\n\nIn terminal everything is green webpack compiled successfully.","author_login":"nitramek","author_association":"NONE","created_at":"2023-01-09T11:47:23+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375569979","fragment_type":"issue_comment","sequence":7,"text":"I've downloaded your version of Liferay Portal and I'm able to reproduce it too :+1: .","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T12:41:47+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375575900","fragment_type":"issue_comment","sequence":8,"text":"Which makes me think this statement is wrong:\n \n\nBut how has it worked until now, then? :thinking:","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T12:47:42+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375579045","fragment_type":"issue_comment","sequence":9,"text":"From MDN:\n \n \n\nWhich is ambiguous, because \"site root\" can be the page's site root or the .js module site root when two servers are involved.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T12:50:43+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375729860","fragment_type":"issue_comment","sequence":10,"text":"I can make it fail with master too (in Linux). I suppose this has never worked, then :shrug: \n\nHowever, I would have sworn that I saw this working before. Maybe we've been deploying projects using the _agnostic_ platform only.\n\nOr maybe we haven't tested this feature since we stopped using import maps.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T14:44:45+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375732246","fragment_type":"issue_comment","sequence":11,"text":"The problem with this is that it not only affects `npm run start`, but in theory, also any remote app wishing to consume `react` from Portal and being served from an external server.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T14:46:27+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375787049","fragment_type":"issue_comment","sequence":12,"text":"Interesting - that is true they would need to provide absolute URLs as a workaround.","author_login":"nitramek","author_association":"NONE","created_at":"2023-01-09T15:21:59+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1376859850","fragment_type":"issue_comment","sequence":13,"text":"So, after reflecting about this a bit, I think the only possible solutions to this are:\n\n1. Use import maps (but we can't because some browsers still don't support them and the shim produces double executions of some modules due to the way it works).\n2. Specify the base URL of external imports at build time\n\nThe best solution would be number 1, because sometimes it is not possible to know where different things will be deployed at runtime and import maps lets us wire things together at deploy (or even run) time.\n\nThe thing is that, in a distributed setup, you may want to import external modules not only from portal, but also from other hosts. Imagine, for example, that you have three servers:\n\n1. myportal.com\n2. mycustomelements.com\n3. mysharedlibs.com\n\nAnd you want to host custom elements at number 2, and some utility libraries at number 3, then use `react` from the Portal. In this scenario, there's no way to make this work without either import maps, or hardcoding the server URLs at build time in the produced artifacts so that the browser knows where to get the libs, custom elements, and `react` from.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-10T07:54:33+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377333626","fragment_type":"issue_comment","sequence":14,"text":"After some internal brainstorming, for now we think this is only a problem with `npm run start` and not a problem with real production deployments as explained in my two previous comments. \n\nThis is because 99% of the production setups will be using a unique domain name for the host (whether or not they use a CDN) since otherwise, they will need to take care of CORS, https certs, and make sure to wire things properly which, AFAIK, apart from webpack federated builds, nobody is doing on a regular basis, because there are no tools aimed at that.\n\nIf, in the future, we think that a multihost setup makes sense, we can either tell users to tweak their liferay.json files or implement some feature in @liferay/cli to make those setups easier.\n\n----\n\nAs to the `npm run start` feature, we will probably need to ask for the URL of the local Liferay installation (in addition to the deployment directory) and either:\n\n1. Make a specific build for live development that prepends that URL to the external imports\n2. Proxy the Portal through webpack dev server so that everything comes from the same host (that would be `localhost:8081` instead of a mix of `localhost:8080` and `localhost:8081`).\n\nSolution 2 may be better because it would also prevent any possible CORS issue that could arise because of using two different hosts in the same page.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-10T14:04:43+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1385569165","fragment_type":"issue_comment","sequence":15,"text":"This may be fixed once we find out how to share code between client extensions, which is being investigated at URL","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-17T15:06:33+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461289709,"issue_number":1048,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1461766437","fragment_type":"issue_description","sequence":0,"text":"Liferay/CLI project fails on scss files on Windows\n### Issue type (mark with `x`)\n\n- [ ] :thinking: Question\n- [x] :bug: Bug report\n- [ ] :gift: Feature request\n- [ ] :woman_shrugging: Other\n\n### Version (mark with `x`)\n\n- [ ] :two: v2.x\n- [x] :three: v3.x\n\n### Description\nNewly generated project with `liferay new project-name` choosing Portal 7.4 CE, remote app with react.\nWhen I run `liferay build` I get an error. \n\nYou may need an appropriate loader to handle this file type, currently no loaders are configured to process this file\n\nI skimmed through the building code and I suspect this has to do with webpack configuration and paths. I suspect it has to do with \ngetWebpackConfiguration and with the `getScssEntryPoints` function.\n\nOn WSL (Windows Subsystem For Linux) it runs fine.\n\n**Desired behavior:**\nBuild completes.\n\n**Current behavior:**\nBuild doesnt complete.\n\n**Other information (environment, versions etc):**\nWindows 10\nNode 16.18.0","author_login":"nitramek","author_association":"NONE","created_at":"2022-11-23T13:27:55+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461766437,"issue_number":1049,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1049","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375317714","fragment_type":"issue_comment","sequence":1,"text":"I've been able to reproduce this bug inside `npm run start` (should be equivalent to `npm run build`):\n\nimage\n\n(Sorry for the screenshot, but I cannot copy text from my virtual machine :-( )","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T09:20:52+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461766437,"issue_number":1049,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1049","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1375535500","fragment_type":"issue_comment","sequence":2,"text":"The problem is in this line\n\nIt should say:\n\njavascript\n{\n include: project.assetsDir.asNative\n}\n\ninstead.","author_login":"izaera","author_association":"MEMBER","created_at":"2023-01-09T12:11:45+08:00","repo_name":"liferay/liferay-frontend-projects","issue_id":1461766437,"issue_number":1049,"issue_url":"https://github.com/liferay/liferay-frontend-projects/issues/1049","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0148","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Using print_rich on a text containing a newline wrapped in the [color] BBcode tag doesn't strip away the closing tag.","query_context":"### Tested versions\n\n- Reproducible in Godot v4.3.stable (bce457cec)\n\n### System information\n\nGodot v4.3.stable (bce457cec) - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 SUPER (NVIDIA; 31.0.15.2802) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)\n\n### Issue description\n\nWhen using `print_rich` to print a string that contains a [color] BBcode tag - if the string wrapped in that tag contains a newline (\"\\n\"), the closing `[/color]` tag won't be stripped away, resulting in an output where the color works, but the \"[/color]\" tag remains as part of the printed string.\n\n### Steps to reproduce\n\n1. Create a string that has a \"\\n\" in it.\n2. Wrap it in a color tag like `[color=yellow]`.\n3. Output it with print_rich.\n\n### Minimal reproduction project (MRP)\n\nI guess there's no need to upload a whole MRP, this can be tested with 1 line of code, try it out:\n\ngdscript\nfunc _ready() -> void:\n print_rich(\"[color=yellow]Test\\ncolor tag with newline.[/color]\")\n\nimage","known_context_document_ids":["gh_issue_2572526543"],"reference_answer":"Docs are correct, `color=tomato` will only show in the editor log (since it's RichTextLabel and support all colors), but won't show in the OS terminal.","answer_document_id":"gh_comment_1925328655","silver_evidence_path":["gh_comment_2405032488","gh_issue_2116489950","gh_comment_1925328655"],"evidence_issue_ids":[2572526543,2116489950],"source_repo_name":"godotengine/godot","source_issue_id":2572526543,"source_issue_number":97965,"source_issue_url":"https://github.com/godotengine/godot/issues/97965","target_repo_name":"godotengine/godot","target_issue_id":2116489950,"target_issue_number":87899,"target_issue_url":"https://github.com/godotengine/godot/issues/87899","reference_anchor_document_id":"gh_comment_2405032488","reference_answer_author":"bruvzg","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1212,"anchor_target_overlap":0.2424,"target_answer_overlap":0.4667},"issue_created_at":"2024-10-08T08:46:12+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2572526543","fragment_type":"issue_description","sequence":0,"text":"Using print_rich on a text containing a newline wrapped in the [color] BBcode tag doesn't strip away the closing tag.\n### Tested versions\n\n- Reproducible in Godot v4.3.stable (bce457cec)\n\n### System information\n\nGodot v4.3.stable (bce457cec) - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 SUPER (NVIDIA; 31.0.15.2802) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)\n\n### Issue description\n\nWhen using `print_rich` to print a string that contains a [color] BBcode tag - if the string wrapped in that tag contains a newline (\"\\n\"), the closing `[/color]` tag won't be stripped away, resulting in an output where the color works, but the \"[/color]\" tag remains as part of the printed string.\n\n### Steps to reproduce\n\n1. Create a string that has a \"\\n\" in it.\n2. Wrap it in a color tag like `[color=yellow]`.\n3. Output it with print_rich.\n\n### Minimal reproduction project (MRP)\n\nI guess there's no need to upload a whole MRP, this can be tested with 1 line of code, try it out:\n\ngdscript\nfunc _ready() -> void:\n print_rich(\"[color=yellow]Test\\ncolor tag with newline.[/color]\")\n\nimage","author_login":"Shiva-Shadowsong","author_association":"NONE","created_at":"2024-10-08T08:46:12+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2404228130","fragment_type":"issue_comment","sequence":1,"text":"Also reproducible in Godot 4.0.4\n\nI am going to try to fix it","author_login":"dustdfg","author_association":"CONTRIBUTOR","created_at":"2024-10-10T07:07:53+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2404309860","fragment_type":"issue_comment","sequence":2,"text":"Funny fact. It doesn't strip BBcode if it is printed into Godot Console but it is stripped when it is printed into OS console \nscreen-1728545875","author_login":"dustdfg","author_association":"CONTRIBUTOR","created_at":"2024-10-10T07:38:27+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2404340190","fragment_type":"issue_comment","sequence":3,"text":"It is not only not stripped away but also isn't considered as fallback to white text which affects following text...\n\nscreen-1728546548\n\nThe os console still shows correct results:\nscreen-1728546564","author_login":"dustdfg","author_association":"CONTRIBUTOR","created_at":"2024-10-10T07:51:33+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405032488","fragment_type":"issue_comment","sequence":4,"text":"The editor Output panel uses the BBCode implementation from RichTextLabel to display it, while terminal output uses a custom BBCode-to-ANSI conversion routine that only supports a subset of BBCode and behaves differently. See URL \n \n\nI wouldn't say it's correct behavior, it's just that the BBCode-to-ANSI conversion routine *always* replaces `[/color]` with a \"reset color\" tag, even if `[color]` was never opened.","author_login":"Calinou","author_association":"MEMBER","created_at":"2024-10-10T13:01:18+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[2116489950],"is_known_query_context":false},{"document_id":"gh_comment_2405119198","fragment_type":"issue_comment","sequence":5,"text":"Likely not intended behaviour, the code inside that custom parser explicitly tries to replace `[/color]`.\n\nif (p_string_ansi.contains(\"[color\")) {\n p_string_ansi = p_string_ansi.replace(\"[color=black]\", \"\\u001b[30m\");\n ...\n p_string_ansi = p_string_ansi.replace(\"[/color]\", \"\\u001b[39m\"); // On this line\n}","author_login":"elchukc","author_association":"NONE","created_at":"2024-10-10T13:37:25+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405226109","fragment_type":"issue_comment","sequence":6,"text":"While auto-close behavior is \"correct\" for single color print, it isn't correct in multi color print like in my example because user will expect to see white printed in white color.","author_login":"dustdfg","author_association":"CONTRIBUTOR","created_at":"2024-10-10T14:18:37+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405250393","fragment_type":"issue_comment","sequence":7,"text":"Looks like it is intended. As I understand the line you pointed resets color to default when sees closing tag so it is likely normal because if color is already default nothing changes","author_login":"dustdfg","author_association":"CONTRIBUTOR","created_at":"2024-10-10T14:28:08+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405662649","fragment_type":"issue_comment","sequence":8,"text":"I just meant that it looks like it's trying to replace the closing tag, but somehow the closing tag is still showing in the output.","author_login":"elchukc","author_association":"NONE","created_at":"2024-10-10T17:21:42+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405681469","fragment_type":"issue_comment","sequence":9,"text":"The code that prints to os terminal is different from code that prints to godot console. And here you are viewing the code that prints to os terminal. If you will comment the line of code you commented, your is terminal will print the same result as in godot console. `\"\\u001b[39m\"` is an escape code for terminals","author_login":"dustdfg","author_association":"CONTRIBUTOR","created_at":"2024-10-10T17:32:07+08:00","repo_name":"godotengine/godot","issue_id":2572526543,"issue_number":97965,"issue_url":"https://github.com/godotengine/godot/issues/97965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2116489950","fragment_type":"issue_description","sequence":0,"text":"Add support for converting arbitrary BBCode colors to truecolor ANSI escape codes in `print_rich()`\n### Tested versions\n\nPresent in all 4.x docs,\nhaven't checked 3.x.\n\n### System information\n\nN/A\n\n### Issue description\n\nThe docs explicitly say only these colors are supported in `print_rich`:\nGodot_v4 3-dev2_win64_PzIxbWjGiJ\neven though all others also seem to be working fine.\n\n### Steps to reproduce\n\n`print_rich('[color=tomato]tomato color![/color]')` - Works fine\n\n### Minimal reproduction project (MRP)\n\nN/A","author_login":"Swarkin","author_association":"CONTRIBUTOR","created_at":"2024-02-03T13:50:05+08:00","repo_name":"godotengine/godot","issue_id":2116489950,"issue_number":87899,"issue_url":"https://github.com/godotengine/godot/issues/87899","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925328655","fragment_type":"issue_comment","sequence":1,"text":"Docs are correct, `color=tomato` will only show in the editor log (since it's RichTextLabel and support all colors), but won't show in the OS terminal.","author_login":"bruvzg","author_association":"MEMBER","created_at":"2024-02-03T13:57:31+08:00","repo_name":"godotengine/godot","issue_id":2116489950,"issue_number":87899,"issue_url":"https://github.com/godotengine/godot/issues/87899","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925342115","fragment_type":"issue_comment","sequence":2,"text":"I was working on implementing arbitrary color code conversion to truecolor ANSI escape codes, but I couldn't get it to work yet.","author_login":"Calinou","author_association":"MEMBER","created_at":"2024-02-03T14:25:06+08:00","repo_name":"godotengine/godot","issue_id":2116489950,"issue_number":87899,"issue_url":"https://github.com/godotengine/godot/issues/87899","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925369827","fragment_type":"issue_comment","sequence":3,"text":"Oh okay I wasn't aware that this was related to the terminal! The fact about bbcode to ansi conversion is only mentioned a bunch of lines below so I thought that it applied to the Godot output.","author_login":"Swarkin","author_association":"CONTRIBUTOR","created_at":"2024-02-03T16:11:09+08:00","repo_name":"godotengine/godot","issue_id":2116489950,"issue_number":87899,"issue_url":"https://github.com/godotengine/godot/issues/87899","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0149","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Segmentation fault 11 on macOS M1 machine running pwsh -c or -file?","query_context":"### Prerequisites\n\n- [X] Write a descriptive title.\n- [X] Make sure you are able to repro it on the latest released version\n- [X] Search the existing issues.\n- [X] Refer to the FAQ.\n- [X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.\n\n### Steps to reproduce\n\nI'm not entirely sure this would be easily reproducible on somebody else's M1. My M1 build machine was working just fine as a Jenkins build agent until I rebooted it this evening. Then my builds started hanging on this node where it first tries to run a PowerShell script. After some debugging, I found out that trying to launch `pwsh -c ' '` causes a segmentation fault. Same with `-file`. What's odd is that I can start `pwsh` just fine:\n\nimage\n\n### Expected behavior\n\nconsole\nWell, PowerShell should not crash, right?\n\n### Actual behavior\n\nconsole\nI'm seeing a segmentation fault.\n\n### Error details\n\nconsole\n% pwsh -nop -c 'get-date'\nzsh: segmentation fault pwsh -nop -c 'get-date'\n\n### Environment data\n\npowershell\nName Value\n---- -----\nPSVersion 7.3.1\nPSEdition Core\nGitCommitId 7.3.1\nOS Darwin 21.6.0 Darwin Kernel Version 21.6.0: Sun Nov 6 23:29:57 PST 2022; root:xnu-8020…\nPlatform Unix\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}\nPSRemotingProtocolVersion 2.3\nSerializationVersion 1.1.0.1\nWSManStackVersion 3.0\n\nAlso:\n\n % which pwsh\n/usr/local/bin/pwsh\n\n% ls -al /usr/local/bin/pwsh\nlrwxr-xr-x 1 root wheel 38 Jan 20 21:42 /usr/local/bin/pwsh -> /usr/local/microsoft/powershell/7/pwsh\n\n# I also have several versions of the .NET SDK and Runtime installed on this system. That shouldn't matter, right?\n\n% dotnet --info\n.NET SDK:\n Version: 7.0.100\n Commit: e12b7af219\n\nRuntime Environment:\n OS Name: Mac OS X\n OS Version: 12.6\n OS Platform: Darwin\n RID: osx.12-arm64\n Base Path: /usr/local/share/dotnet/sdk/7.0.100/\n\nHost:\n Version: 7.0.0\n Architecture: arm64\n Commit: d099f075e4\n\n.NET SDKs installed:\n 6.0.403 [/usr/local/share/dotnet/sdk]\n 6.0.404 [/usr/local/share/dotnet/sdk]\n 7.0.100 [/usr/local/share/dotnet/sdk]\n\n.NET runtimes installed:\n Microsoft.AspNetCore.App 6.0.11 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]\n Microsoft.AspNetCore.App 6.0.12 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]\n Microsoft.AspNetCore.App 7.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]\n Microsoft.NETCore.App 6.0.11 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]\n Microsoft.NETCore.App 6.0.12 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]\n Microsoft.NETCore.App 7.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]\n\nOther architectures found:\n x64 [/usr/local/share/dotnet/x64]\n registered at [/etc/dotnet/install_location_x64]\n\nEnvironment variables:\n Not set\n\nglobal.json file:\n Not found\n\nLearn more:\n URL \n\nDownload .NET:\n URL \n\n### Visuals\n\nimage","known_context_document_ids":["gh_issue_1551700349"],"reference_answer":"The repro appears to be simple enough, if we have the right profile data file to cause the seg fault. When the seg fault is seen, and is reproducible with a simple pwsh command, could you please collect the profile data file and share it? I figure it may be reproducible elsewhere too with the same profile data file.","answer_document_id":"gh_comment_1486151122","silver_evidence_path":["gh_comment_1577099328","gh_issue_1575217448","gh_comment_1486151122"],"evidence_issue_ids":[1551700349,1575217448],"source_repo_name":"PowerShell/PowerShell","source_issue_id":1551700349,"source_issue_number":18998,"source_issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","target_repo_name":"dotnet/runtime","target_issue_id":1575217448,"target_issue_number":81799,"target_issue_url":"https://github.com/dotnet/runtime/issues/81799","reference_anchor_document_id":"gh_comment_1577099328","reference_answer_author":"kouvel","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2941,"anchor_target_overlap":0.4706,"target_answer_overlap":0.2917},"issue_created_at":"2023-01-21T05:22:49+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1551700349","fragment_type":"issue_description","sequence":0,"text":"Segmentation fault 11 on macOS M1 machine running pwsh -c or -file\n### Prerequisites\n\n- [X] Write a descriptive title.\n- [X] Make sure you are able to repro it on the latest released version\n- [X] Search the existing issues.\n- [X] Refer to the FAQ.\n- [X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.\n\n### Steps to reproduce\n\nI'm not entirely sure this would be easily reproducible on somebody else's M1. My M1 build machine was working just fine as a Jenkins build agent until I rebooted it this evening. Then my builds started hanging on this node where it first tries to run a PowerShell script. After some debugging, I found out that trying to launch `pwsh -c ' '` causes a segmentation fault. Same with `-file`. What's odd is that I can start `pwsh` just fine:\n\nimage\n\n### Expected behavior\n\nconsole\nWell, PowerShell should not crash, right?\n\n### Actual behavior\n\nconsole\nI'm seeing a segmentation fault.\n\n### Error details\n\nconsole\n% pwsh -nop -c 'get-date'\nzsh: segmentation fault pwsh -nop -c 'get-date'\n\n### Environment data\n\npowershell\nName Value\n---- -----\nPSVersion 7.3.1\nPSEdition Core\nGitCommitId 7.3.1\nOS Darwin 21.6.0 Darwin Kernel Version 21.6.0: Sun Nov 6 23:29:57 PST 2022; root:xnu-8020…\nPlatform Unix\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}\nPSRemotingProtocolVersion 2.3\nSerializationVersion 1.1.0.1\nWSManStackVersion 3.0\n\nAlso:\n\n % which pwsh\n/usr/local/bin/pwsh\n\n% ls -al /usr/local/bin/pwsh\nlrwxr-xr-x 1 root wheel 38 Jan 20 21:42 /usr/local/bin/pwsh -> /usr/local/microsoft/powershell/7/pwsh\n\n# I also have several versions of the .NET SDK and Runtime installed on this system. That shouldn't matter, right?\n\n% dotnet --info\n.NET SDK:\n Version: 7.0.100\n Commit: e12b7af219\n\nRuntime Environment:\n OS Name: Mac OS X\n OS Version: 12.6\n OS Platform: Darwin\n RID: osx.12-arm64\n Base Path: /usr/local/share/dotnet/sdk/7.0.100/\n\nHost:\n Version: 7.0.0\n Architecture: arm64\n Commit: d099f075e4\n\n.NET SDKs installed:\n 6.0.403 [/usr/local/share/dotnet/sdk]\n 6.0.404 [/usr/local/share/dotnet/sdk]\n 7.0.100 [/usr/local/share/dotnet/sdk]\n\n.NET runtimes installed:\n Microsoft.AspNetCore.App 6.0.11 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]\n Microsoft.AspNetCore.App 6.0.12 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]\n Microsoft.AspNetCore.App 7.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]\n Microsoft.NETCore.App 6.0.11 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]\n Microsoft.NETCore.App 6.0.12 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]\n Microsoft.NETCore.App 7.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]\n\nOther architectures found:\n x64 [/usr/local/share/dotnet/x64]\n registered at [/etc/dotnet/install_location_x64]\n\nEnvironment variables:\n Not set\n\nglobal.json file:\n Not found\n\nLearn more:\n URL \n\nDownload .NET:\n URL \n\n### Visuals\n\nimage","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2023-01-21T05:22:49+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1404007235","fragment_type":"issue_comment","sequence":1,"text":"After 4 days of using 7.3.0 in my Jenkins pipeline (pwsh -c), 7.3.0 is now seg faulting on this command!\n\nimage\n\nWTF? @SteveL-MSFT Any suggestions on a potential workaround - other than uninstalling and installing a different version? That only seems to work for a few days. This is impacting our product devops because we use PowerShell to orchestrate build & test on Mac M1.","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2023-01-25T17:51:36+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1404014338","fragment_type":"issue_comment","sequence":2,"text":"I removed 7.3.0 and installed 7.3.2 (that must be pretty new) and now `pwsh -c` works again. Let's see how long 7.3.2 can go before it starts seg faulting. :-)","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2023-01-25T17:57:45+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1407021708","fragment_type":"issue_comment","sequence":3,"text":"Unfortunately, not able to repro this. Was able to find two PRs in dotnet/runtime that is related to the area given the stacktrace (thanks!) URL Need to look deeper next week.","author_login":"SteveL-MSFT","author_association":"MEMBER","created_at":"2023-01-27T20:06:49+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1409173263","fragment_type":"issue_comment","sequence":4,"text":"The puzzling part in the report is that the crash doesn't happen consistently -- it started to happen after using 7.3.0 for 4 days.\n\nThe stack trace suggests the crash happened when JIT start profile kicks in, which does early compilation on the methods that were used the last time `pwsh` going through the same code path -- in this case for `pwsh -c` or `pwsh -file`, non-interactive execution (_ProfileOptimization.StartProfile(\"StartupProfileData-NonInteractive\")_).\n\nSo, it makes sense that running `pwsh` itself works, because that will be interactive execution, which will be using a different profile: _ProfileOptimization.StartProfile(\"StartupProfileData-Interactive\")_.\n\n@rkeithhill-keysight Can you please try the following when `pwsh -c \"get-date\"` results in segment fault, and see if the next run of `pwsh -c` works:\n- remove the `StartupProfileData-NonInteractive` file under `/home/ /.cache/powershell`\n\nHaving this file removed will make CLR not attempt to do the early method compilation, so if this theory is correct, the next run of `pwsh -c \"get-date\"` should work again. If you can verify this is the case, I will open an issue on this in the .NET repo.","author_login":"daxian-dbw","author_association":"MEMBER","created_at":"2023-01-30T19:04:34+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1409179152","fragment_type":"issue_comment","sequence":5,"text":"@daxian-dbw Yes, I'll give that a try if/when we encounter the seg fault again.","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2023-01-30T19:07:54+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575124827","fragment_type":"issue_comment","sequence":6,"text":"And now 7.3.2 has started to gen seg faults ~5 1/2 months after installing 7.3.2. 🤷‍♂️ \n\nI tried @daxian-dbw suggestion to remove the `StartupProfileData-NonInteractive` file and that fixes it. Not sure how long the fix will last but my CI/CD builds are running again on this M1 mini.","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2023-06-03T18:48:49+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1577099328","fragment_type":"issue_comment","sequence":7,"text":"@rkeithhill-keysight The root cause is in .NET, see URL Please try collecting a dump when the crash happens, and share the dump in the .NET issue -- they need a dump to further investigate the issue (see URL","author_login":"daxian-dbw","author_association":"MEMBER","created_at":"2023-06-05T16:19:12+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[1575217448],"is_known_query_context":false},{"document_id":"gh_comment_1577130914","fragment_type":"issue_comment","sequence":8,"text":"I read the .NET issue **after** I had fixed it. 🤦‍♂️ Next time this happens, I'll collect a dump and post it there.","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2023-06-05T16:43:03+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1632780598","fragment_type":"issue_comment","sequence":9,"text":"Just ran into this after updating powershell on CentOS:\n\npwsh 7.3.5 (old was 7.3.4)\n\ncommands:\n\n# update powershell\nsudo yum update powershell \n\n# Set permissions for powershell to run commands\nsudo setcap cap_net_raw=eip /opt/microsoft/powershell/7/pwsh # real binary, not symlink\n\n# rename offending config file\n mv /home/user/.cache/powershell/StartupProfileData-NonInteractive /home/user/.cache/powershell/StartupProfileData-NonInteractive.disable","author_login":"GordonVi","author_association":"NONE","created_at":"2023-07-12T15:43:43+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2364611474","fragment_type":"issue_comment","sequence":10,"text":"FWIW it appears this issue was fixed in .NET. Here's the .NET issue and here's the PR that fixes it.","author_login":"rkeithhill-keysight","author_association":"NONE","created_at":"2024-09-20T21:01:07+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[1575217448],"is_known_query_context":false},{"document_id":"gh_comment_2681063421","fragment_type":"issue_comment","sequence":11,"text":"Can this be re-opend please?\nI had the same issue on 7.5.0. \n\nDisabling the file: `mv ~/.cache/powershell/StartupProfileData-NonInteractive ~/.cache/powershell/StartupProfileData-NonInteractive.disable` solved it, as suggested by @GordonVi \n\n$psversiontable\n\nName Value\n---- -----\nPSVersion 7.5.0\nPSEdition Core\nGitCommitId 7.5.0\nOS Ubuntu 22.04.5 LTS\nPlatform Unix\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}\nPSRemotingProtocolVersion 2.3\nSerializationVersion 1.1.0.1\nWSManStackVersion 3.0","author_login":"pregress","author_association":"NONE","created_at":"2025-02-25T08:15:42+08:00","repo_name":"PowerShell/PowerShell","issue_id":1551700349,"issue_number":18998,"issue_url":"https://github.com/PowerShell/PowerShell/issues/18998","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1575217448","fragment_type":"issue_description","sequence":0,"text":"Segmentation fault when .NET starts JIT compilation of previous recorded methods triggered by `ProfileOptimization.StartProfile`\n### Description\n\nWe PowerShell team got 2 reports about `Segmentation fault` when starting PowerShell by `pwsh -command` or `pwsh -file` on Redhat 7.9 and macOS M1 machine.\n\n- URL \n- URL \n\nThe stack trace for the report on macOS M1 machine is attached below.\nThe stack trace suggests the crash happened when .NET starts JIT compilation of the previous recorded methods, which is triggered by the ProfileOptimization.StartProfile call in PowerShell.\n\nWe asked the user to delete the profile data file and try launch `pwsh -c` or `pwsh -file` again, and the user reported back that it began to work after removing the profile data file: URL So, it's confirmed that this is an issue with the .NET profile optimization.\n\nimage\n\n### Reproduction Steps\n\nThe issue doesn't happen consistently. Even for the users who reported the issue, it was not consistent. They started with using PowerShell 7.3.1, which worked for a few days and then started to fail. Then they switched to PowerShell 7.3.0, which worked for a few days and started to fail again.\n\nPowerShell 7.3.1 and PowerShell 7.3.0 are both on top of .NET 7.0.0\n\n### Expected behavior\n\nNo segmentation fault.\n\n### Actual behavior\n\nSegmentation fault was reported.\n\n### Regression?\n\nIt's a regression, given that we don't have the problem in PowerShell 7.2.x versions, which are on top of .NET 6.\n\n### Known Workarounds\n\nDeleting the profile data file, then `pwsh -c` and `pwsh -file` will start to work again.\n\n### Configuration\n \n.NET 7.0.0\n \nRedhat 7.9 and macOS M1 machine\n \nFor Redhat 7.9: Linux 3.10.0-1160.81.1.el7.x86_64\nFor macOS: ARM64\n\n### Other information\n\n_No response_","author_login":"daxian-dbw","author_association":"CONTRIBUTOR","created_at":"2023-02-07T23:57:42+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1440449196","fragment_type":"issue_comment","sequence":1,"text":"Any updates? We got another report of the issue in PowerShell repo, and this time it's on Ubuntu 22.04","author_login":"daxian-dbw","author_association":"CONTRIBUTOR","created_at":"2023-02-22T17:13:43+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1462373054","fragment_type":"issue_comment","sequence":2,"text":"@davidwrighton @kouvel. Does Powershell use multicore JIT functionality? @daxian-dbw, is there a dump available to look at?","author_login":"mangod9","author_association":"MEMBER","created_at":"2023-03-09T16:33:23+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1462468663","fragment_type":"issue_comment","sequence":3,"text":"Yes, PowerShell calls `ProfileOptimization.SetProfileRoot/StartProfile` at the entry point.\nWe don't have a dump available. If you can provide steps to collect a dump in this particular case, I think @bobrozelle may be able to help with that when the issue happens again in their environment.","author_login":"daxian-dbw","author_association":"CONTRIBUTOR","created_at":"2023-03-09T17:29:14+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1486151122","fragment_type":"issue_comment","sequence":4,"text":"The repro appears to be simple enough, if we have the right profile data file to cause the seg fault. When the seg fault is seen, and is reproducible with a simple pwsh command, could you please collect the profile data file and share it? I figure it may be reproducible elsewhere too with the same profile data file.","author_login":"kouvel","author_association":"MEMBER","created_at":"2023-03-28T03:29:46+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1532531400","fragment_type":"issue_comment","sequence":5,"text":"@mangod9 \n\nAs this is a production system our focus is to not have any segfaults :-)\n\nBut i ll try to reproduce the issue on the coming weekend. Maybe i can get both, a core dump and a \"corrupted\" profile file.\n\nI'll keep you up to date\n\nRegards","author_login":"AdminValida","author_association":"NONE","created_at":"2023-05-03T06:53:36+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536254559","fragment_type":"issue_comment","sequence":6,"text":"@mangod9 \n\nI just reverted the permissions like described above and cache files are written now. I already got the first segfault but don't know where the dumps are, can you help me out here? I am on Ubuntu 22\n\nRegards","author_login":"AdminValida","author_association":"NONE","created_at":"2023-05-05T13:21:11+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537121171","fragment_type":"issue_comment","sequence":7,"text":"I wasn't able to fully crash pwsh but some segfaults popped up:\n\n` kernel: [187481.441049] pwsh[1565713]: segfault at 28 ip 00007f76eff09c30 sp 00007f76e8ffe8e0 error 4 in libcoreclr.so[7f76efdd7000+383000]`\n\nMaybe i am able to test this again next weekend.\n\nRegards","author_login":"AdminValida","author_association":"NONE","created_at":"2023-05-06T11:26:58+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1650244983","fragment_type":"issue_comment","sequence":8,"text":"I was not able to acquire a crash or coredump, however, we have recently seen this issue occurring on a Redhat server running pwsh version 7.2.7. Removing the write permissions to the cache directory and deleting the cache files resolved the issue.\n\nSo this is also seems to be an issue for Powershell 7.2.x","author_login":"Dmbob","author_association":"NONE","created_at":"2023-07-25T17:27:12+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1752861826","fragment_type":"issue_comment","sequence":9,"text":"Ran into this issue on AlmaLinux release 8.6, running Powershell 7.2.6. I upgraded to 7.3.6 and the issue went away for about a month, now the problem is back. This is also on a server running Nagios so pwsh is being called 100+ times per minute. I do have a copy of the corrupt StartupProfileData-NonInteractive file as I simply renamed it go get things working, if that would be of help.","author_login":"nitroed01","author_association":"NONE","created_at":"2023-10-09T11:50:32+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1753252114","fragment_type":"issue_comment","sequence":10,"text":"Just emailed that profile data file. It does not seem to matter what is run, I'm running .ps1 files directly from bash that have a #!/usr/bin/pwsh in the first line. But even running a simple command fails: \n`pwsh -command Write-Output \"ok\"\nSegmentation fault (core dumped)`","author_login":"nitroed01","author_association":"NONE","created_at":"2023-10-09T15:44:04+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766880207","fragment_type":"issue_comment","sequence":11,"text":"Thanks for the data @nitroed01, I'm able to reproduce the issue. Not clear yet where the problems are, I'll investigate.","author_login":"kouvel","author_association":"MEMBER","created_at":"2023-10-17T17:42:33+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826440063","fragment_type":"issue_comment","sequence":12,"text":"I believe I'm seeing this with Paint.NET.\n\nSteps to repro:\n1) Download and install Paint.NET v5.0.11, or use the portable version. Both available here: URL . That version of Paint.NET is using .NET 7.0.12\n\n2) Place the two files in this ZIP into `%LOCALAPPDATA%\\paint.net\\Optimization`: \nStartup.profiles.bad.zip\n<img width=\"733\" alt=\"image\" src=\" URL \n\n3) Try to start Paint.NET, either by double-clicking its icon or running `paintdotnet.exe` at the command-line\n\nExpected: It works\n\nActual: App does not start, and you see errors in the event viewer like so:\nimage\n\nIf this isn't the same issue then I can file a new issue for it, but this is causing misery for a non-trivial number of people who use my app 😢 In the short-term I can just disable the use of `ProfileOptimization` and release a hotfix for the app","author_login":"rickbrew","author_association":"CONTRIBUTOR","created_at":"2023-11-25T23:15:43+08:00","repo_name":"dotnet/runtime","issue_id":1575217448,"issue_number":81799,"issue_url":"https://github.com/dotnet/runtime/issues/81799","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0151","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"FaroRoutes support for RouterProvider react router v6?","query_context":"## Description\n\nReact Router v6 now uses a RouterProvider component that is passed an object from createBrowserRouter(). \n\n URL \n\nTrying to wrap the RouterProvider in FaroRoutes, \n\nimport { FaroRoutes } from \"@grafana/faro-react\";\n\n \n \n \n\nleads to the following error:\n\n`Uncaught Error: useLocation() may be used only in the context of a component.`\n\n## Proposed solution\n\nSupport the newest style of React Router definition.\n\n## Context\n\n URL","known_context_document_ids":["gh_issue_1812397066"],"reference_answer":"Hi @riboher thansk a lot for the quick testing. I can confirm the issue. \nwe fixed a problem in regards to data routers which were also having type issues. \nI'll see hat `createRoutesFromChildren`as causing problems as well. \n\nWe'll fix it.","answer_document_id":"gh_comment_2095930379","silver_evidence_path":["gh_comment_2115760370","gh_issue_2280362978","gh_comment_2095930379"],"evidence_issue_ids":[1812397066,2280362978],"source_repo_name":"grafana/faro-web-sdk","source_issue_id":1812397066,"source_issue_number":235,"source_issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","target_repo_name":"grafana/faro-web-sdk","target_issue_id":2280362978,"target_issue_number":582,"target_issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","reference_anchor_document_id":"gh_comment_2115760370","reference_answer_author":"codecapitano","reference_answer_author_association":"COLLABORATOR","quality_score":85.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.4545,"target_answer_overlap":0.0435},"issue_created_at":"2023-07-19T17:33:08+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_1812397066","fragment_type":"issue_description","sequence":0,"text":"FaroRoutes support for RouterProvider react router v6\n## Description\n\nReact Router v6 now uses a RouterProvider component that is passed an object from createBrowserRouter(). \n\n URL \n\nTrying to wrap the RouterProvider in FaroRoutes, \n\nimport { FaroRoutes } from \"@grafana/faro-react\";\n\n \n \n \n\nleads to the following error:\n\n`Uncaught Error: useLocation() may be used only in the context of a component.`\n\n## Proposed solution\n\nSupport the newest style of React Router definition.\n\n## Context\n\n URL","author_login":"nosvalds","author_association":"NONE","created_at":"2023-07-19T17:33:08+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1653435951","fragment_type":"issue_comment","sequence":1,"text":"Thanks a lot @nosvalds. Would you mind adding the version of the Web-SDK you found the issue on?\n\nCheers,\nMarco","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2023-07-27T11:33:58+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1879924895","fragment_type":"issue_comment","sequence":2,"text":"is this is intended solution: URL \nreadme says support for rhr v6","author_login":"barrykaplan","author_association":"NONE","created_at":"2024-01-07T03:21:08+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1989575296","fragment_type":"issue_comment","sequence":3,"text":"hi folks - sorry for the delay on this. this should get some attention in the coming weeks as we are moving to react router V6 for our internal plugin platform. \n\nagain, sorry for the delay - we will discuss this in our prioritization meeting tomorrow.","author_login":"eskirk","author_association":"COLLABORATOR","created_at":"2024-03-11T22:46:50+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091383923","fragment_type":"issue_comment","sequence":4,"text":"I was going to try and update, but can't build this project. I can't seem to find any developer docs. Are they somewhere other than this repo?","author_login":"barrykaplan","author_association":"NONE","created_at":"2024-05-02T19:27:53+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091411821","fragment_type":"issue_comment","sequence":5,"text":"Looks like this the top level block\n\n Types of property 'action' are incompatible.\n Type 'boolean | ActionFunction ' is not assignable to type '(...args: any[]) => any'.\n Type 'boolean' is not assignable to type '(...args: any[]) => any'.","author_login":"barrykaplan","author_association":"NONE","created_at":"2024-05-02T19:37:32+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091433403","fragment_type":"issue_comment","sequence":6,"text":"I rolled back to react-router-dom 6.6.2 and still the types don't match. Looking thru the code in this repo there no test or example that uses `withFaroRouterInstrumentation`. Is it possible that this never worked? The type `ActionFunction` has been in the react-router-dom from before this PR was created.","author_login":"barrykaplan","author_association":"NONE","created_at":"2024-05-02T19:48:06+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2092477106","fragment_type":"issue_comment","sequence":7,"text":"Hey @barrykaplan we tested it with our Faro demo app and everything worked well.\nThere's a playground branch available.\n\nI'll reopen this issue.","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-03T07:42:16+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2092526153","fragment_type":"issue_comment","sequence":8,"text":"@barrykaplan I can not reproduce the type issue.\n\nWhat router are you using?\n\nI tested all data routers again but it's working as expected.\n\ncreateHashRouter,\ncreateMemoryRouter,\ncreateBrowserRouter\ncreateMemoryRouter\n\nFaro's `withFaroRouterInstrumentation` only subcribes to router events and returns the provided router.\n\nexample:\n\n<img width=\"528\" alt=\"image\" src=\" URL \n\nRouter version: `\"react-router-dom\": \"6.6.2\",`","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-03T08:12:26+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2115595034","fragment_type":"issue_comment","sequence":9,"text":"@codecapitano Sorry for the late reply, but thanks for looking into this. Anything you need from me at this point?","author_login":"barrykaplan","author_association":"NONE","created_at":"2024-05-16T15:46:03+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2115760370","fragment_type":"issue_comment","sequence":10,"text":"Hi @barrykaplan We released an update which fixed the issues with the typings (v1.7.2).\nSee this issue.\n\nDo you still have this problem?","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-16T16:54:05+08:00","repo_name":"grafana/faro-web-sdk","issue_id":1812397066,"issue_number":235,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/235","linked_issue_ids":[2280362978],"is_known_query_context":false},{"document_id":"gh_issue_2280362978","fragment_type":"issue_description","sequence":0,"text":"Add support for new versions of react-router-dom\n## Description\n\nAfter updating `react-router-dom` to its last version `v6.23.0`, some `grafana-react` setup fails due to type errors.\nWhen using `withFaroRouterInstrumentation`, types of expected `Router` don't match.\n\nTypes of property 'routes' are incompatible.\n Type 'AgnosticDataRouteObject[]' is not assignable to type 'ReactRouterV6RouteObject[]'.\n Type 'AgnosticDataRouteObject' is not assignable to type 'ReactRouterV6RouteObject'.\n Type 'AgnosticDataIndexRouteObject' is not assignable to type 'ReactRouterV6RouteObject'.\n Type 'AgnosticDataIndexRouteObject' is not assignable to type 'ReactRouterV6BaseRouteObject & { children?: undefined; index: true; }'.\n Type 'AgnosticDataIndexRouteObject' is not assignable to type 'ReactRouterV6BaseRouteObject'.\n Types of property 'action' are incompatible.\n Type 'boolean | ActionFunction | undefined' is not assignable to type '((...args: any[]) => any) | undefined'.\n Type 'boolean' is not assignable to type '(...args: any[]) => any'.\n\n## Proposed solution\n\nUpdate the necessary dependencies so `faro-react` works with most recent `react-router-dom` versions","author_login":"riboher","author_association":"NONE","created_at":"2024-05-06T08:46:29+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095816417","fragment_type":"issue_comment","sequence":1,"text":"Hi @riboher the tab got auto closed.\nPlease let us know if you still tun into any problems.","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-06T11:41:10+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095850913","fragment_type":"issue_comment","sequence":2,"text":"Hey @codecapitano - I encountered this issue while your release was still going through the pipeline. Talk about responsive support! :)\n\nBut unless I'm mistaken, this does not seem to have fixed the issue, I'm still seeing it with 1.7.1:\n\n`TS2322: Type '(children: ReactNode, parentPath?: number[] | undefined) => RouteObject[]' is not assignable to type 'ReactRouterV6CreateRoutesFromChildren'.\n Type 'RouteObject[]' is not assignable to type 'ReactRouterV6RouteObject[]'.\n Type 'RouteObject' is not assignable to type 'ReactRouterV6RouteObject'.\n Type 'IndexRouteObject' is not assignable to type 'ReactRouterV6RouteObject'.\n Type 'IndexRouteObject' is not assignable to type 'ReactRouterV6BaseRouteObject & { children?: undefined; index: true; }'.\n Type 'IndexRouteObject' is not assignable to type 'ReactRouterV6BaseRouteObject'.\n Types of property 'action' are incompatible.\n Type 'boolean | ActionFunction | undefined' is not assignable to type '((...args: any[]) => any) | undefined'.\n Type 'boolean' is not assignable to type '(...args: any[]) => any'.`","author_login":"toresbe","author_association":"NONE","created_at":"2024-05-06T12:00:53+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095930379","fragment_type":"issue_comment","sequence":3,"text":"Hi @riboher thansk a lot for the quick testing. I can confirm the issue. \nwe fixed a problem in regards to data routers which were also having type issues. \nI'll see hat `createRoutesFromChildren`as causing problems as well. \n\nWe'll fix it.","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-06T12:41:46+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095935258","fragment_type":"issue_comment","sequence":4,"text":"One question:\nDo you use data routers or standard routers?\n\nAsking because if you use data routers you don't need provide `createRoutesFromChildrenas`.\n\nts\nimport { matchRoutes } from 'react-router-dom';\n\nimport { getWebInstrumentations, initializeFaro, ReactIntegration, ReactRouterVersion } from '@grafana/faro-react';\n\ninitializeFaro({\n // ...\n\n instrumentations: [\n // Load the default Web instrumentations\n ...getWebInstrumentations(),\n\n new ReactIntegration({\n router: {\n version: ReactRouterVersion.V6_data_router,\n dependencies: {\n matchRoutes,\n },\n },\n }),\n ],\n});","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-06T12:44:35+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095971219","fragment_type":"issue_comment","sequence":5,"text":"Hi @codecapitano! I think you tagged me by mistake 😅 . Let me try the new fix and I'll let you know if at least I run into any issues. Thanks for the quick solution!","author_login":"riboher","author_association":"NONE","created_at":"2024-05-06T13:03:28+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095983746","fragment_type":"issue_comment","sequence":6,"text":"@riboher \n\nOh that's awesome thank you so much ❤️ \n\nI added the link to the PR so that you are aware we are working on it.","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-06T13:09:35+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2095987763","fragment_type":"issue_comment","sequence":7,"text":"Hi @codecapitano, unfortunately the error still shows up 😞 . Let me show you my faro initialization code as well as the use of `withFaroRouterInstrumentation`\n\ninit({\n apiKey,\n app: {\n environment: config.appEnv,\n name: 'app-name',\n version: config.appVersion,\n },\n ignoreErrors: [],\n instrumentations: [\n ...getWebInstrumentations(),\n // Enable this back again once this issue is resolved URL \n // new TracingInstrumentation(),\n new ReactIntegration({\n router: {\n dependencies: {\n matchRoutes,\n },\n version: ReactRouterVersion.V6_data_router,\n },\n }),\n ],\n url,\n });\n \n\n \n \n\nconst routes = getRoutes({ query: { client: queryClient } });\nconst router = createBrowserRouter(routes, { basename });\nconst browserRouter = withFaroRouterInstrumentation(router);\n\nconst AppRoot = withFaroProfiler(() => {\n return (\n \n \n \n \n \n );\n});\n \n\n \n Same error as before\n \n \n\n Types of property 'routes' are incompatible.\n Type 'AgnosticDataRouteObject[]' is not assignable to type 'ReactRouterV6RouteObject[]'.\n Type 'AgnosticDataRouteObject' is not assignable to type 'ReactRouterV6RouteObject'.\n Type 'AgnosticDataIndexRouteObject' is not assignable to type 'ReactRouterV6RouteObject'.\n Type 'AgnosticDataIndexRouteObject' is not assignable to type 'ReactRouterV6BaseRouteObject & { children?: undefined; index: true; }'.\n Type 'AgnosticDataIndexRouteObject' is not assignable to type 'ReactRouterV6BaseRouteObject'.\n Types of property 'action' are incompatible.\n Type 'boolean | ActionFunction | undefined' is not assignable to type '((...args: any[]) => any) | undefined'.\n Type 'boolean' is not assignable to type '(...args: any[]) => any'.ts(2345)","author_login":"riboher","author_association":"NONE","created_at":"2024-05-06T13:11:32+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2096013310","fragment_type":"issue_comment","sequence":8,"text":"Thanks so much for your help @riboher 🙏 \n\nIt seems that for some reason it's still pulling the old `ReactRouterV6RouteObject`\n\nWith 1.7.1 `withFaroRouterInstrumentation` uses `RouteObjectV6DataRouter[]` [[1]]( URL \n\nWhich is referencing the Index/NonIndex routers [[2]]( URL","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-06T13:23:52+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2096029093","fragment_type":"issue_comment","sequence":9,"text":"That definitely fixed the issue @codecapitano! Thanks a lot for the suggestion. What a rookie mistake 😅 . You can close the issue if you want, everything seems fine on my side. Thank you again!","author_login":"riboher","author_association":"NONE","created_at":"2024-05-06T13:31:24+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2096086370","fragment_type":"issue_comment","sequence":10,"text":"Perfect glad it's working now.\nThen I can release the second fix.\n\nThanks again for reporting and testing 🙏","author_login":"codecapitano","author_association":"COLLABORATOR","created_at":"2024-05-06T13:59:32+08:00","repo_name":"grafana/faro-web-sdk","issue_id":2280362978,"issue_number":582,"issue_url":"https://github.com/grafana/faro-web-sdk/issues/582","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0152","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Error when selecting existing SDKs during onboarding?","query_context":"We are still seeing an error in PROD if the user selects existing SDKs. See error message in screenshot. Also, the UI is a difficult to use. When I search by name a subset of options do show but when I select one then I am returned to the entire list again. Is it possible for the subset of options to show a little longer so that I can select all that apply from the search? \n\n<img width=\"961\" alt=\"image\" src=\" URL","known_context_document_ids":["gh_issue_1917869454"],"reference_answer":"Removed package selection option and we no longer need to save SDK packages in data verse when onboarding a product to release plan.","answer_document_id":"gh_comment_1766633296","silver_evidence_path":["gh_comment_1758267949","gh_issue_1894703819","gh_comment_1766633296"],"evidence_issue_ids":[1917869454,1894703819],"source_repo_name":"Azure/azure-sdk-tools","source_issue_id":1917869454,"source_issue_number":7022,"source_issue_url":"https://github.com/Azure/azure-sdk-tools/issues/7022","target_repo_name":"Azure/azure-sdk-tools","target_issue_id":1894703819,"target_issue_number":6961,"target_issue_url":"https://github.com/Azure/azure-sdk-tools/issues/6961","reference_anchor_document_id":"gh_comment_1758267949","reference_answer_author":"praveenkuttappan","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.1667,"target_answer_overlap":0.2667},"issue_created_at":"2023-09-28T16:20:27+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_1917869454","fragment_type":"issue_description","sequence":0,"text":"Error when selecting existing SDKs during onboarding\nWe are still seeing an error in PROD if the user selects existing SDKs. See error message in screenshot. Also, the UI is a difficult to use. When I search by name a subset of options do show but when I select one then I am returned to the entire list again. Is it possible for the subset of options to show a little longer so that I can select all that apply from the search? \n\n<img width=\"961\" alt=\"image\" src=\" URL","author_login":"ladonnaq","author_association":"MEMBER","created_at":"2023-09-28T16:20:27+08:00","repo_name":"Azure/azure-sdk-tools","issue_id":1917869454,"issue_number":7022,"issue_url":"https://github.com/Azure/azure-sdk-tools/issues/7022","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1739643669","fragment_type":"issue_comment","sequence":1,"text":"FYI - Engineering opened issue related to usability of the UI for selecting existing SDKs. URL","author_login":"ladonnaq","author_association":"MEMBER","created_at":"2023-09-28T16:22:29+08:00","repo_name":"Azure/azure-sdk-tools","issue_id":1917869454,"issue_number":7022,"issue_url":"https://github.com/Azure/azure-sdk-tools/issues/7022","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1758267949","fragment_type":"issue_comment","sequence":2,"text":"Dup of URL as this was happening with previous UI and keeps happening in new UI","author_login":"maririos","author_association":"MEMBER","created_at":"2023-10-11T18:29:35+08:00","repo_name":"Azure/azure-sdk-tools","issue_id":1917869454,"issue_number":7022,"issue_url":"https://github.com/Azure/azure-sdk-tools/issues/7022","linked_issue_ids":[1894703819],"is_known_query_context":false},{"document_id":"gh_issue_1894703819","fragment_type":"issue_description","sequence":0,"text":"Scenario Tested: Onboard a product by selecting the SDK Package and verify the confirmation message on screen\nScenario Tested: Onboard a product by selecting the SDK Package and verify the confirmation message on screen\n\nExpected Result: Product should be onboarded and confirmation message should be displayed\n\nActual Result: Product is onboarded, confirmation message is displayed along with error message \"Network error when using Patch function: You dont't\nhave permission to create this row\n\nDetails:\n\nDevOps Product details: URL \n\nEnvironment: PPE\nApplication: Release Planner\nUser Release Planner Admin\nURL URL \nTriage Query Triage Query - All - Boards (azure.com)\nURL: URL \n\nimage\nimage","author_login":"yogananda0517","author_association":"NONE","created_at":"2023-09-13T14:50:22+08:00","repo_name":"Azure/azure-sdk-tools","issue_id":1894703819,"issue_number":6961,"issue_url":"https://github.com/Azure/azure-sdk-tools/issues/6961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766633296","fragment_type":"issue_comment","sequence":1,"text":"Removed package selection option and we no longer need to save SDK packages in data verse when onboarding a product to release plan.","author_login":"praveenkuttappan","author_association":"MEMBER","created_at":"2023-10-17T15:17:29+08:00","repo_name":"Azure/azure-sdk-tools","issue_id":1894703819,"issue_number":6961,"issue_url":"https://github.com/Azure/azure-sdk-tools/issues/6961","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0153","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Where to get more demo body？?","query_context":"Hi, this is a truly impressive piece of work. I'd like to try out more models. Could you please let me know where I can find similar human body models for experimentation, like those in the demo folder?\n\nThank you.","known_context_document_ids":["gh_issue_2153411915"],"reference_answer":"@qaz8788817 It seems like your error is not due to using windows as it works for loreofblasius .\n\n`cp950` is a code page used traditionally by Chinese Windows systems, maybe changing your system language to one that supports UTF-8 (like english) can help but no guarranty here.\n\n If you can't fix it I suggest you set up a Ubuntu Virtual Machine.","answer_document_id":"gh_comment_1972865651","silver_evidence_path":["gh_comment_1972399925","gh_issue_2157025683","gh_comment_1972865651"],"evidence_issue_ids":[2153411915,2157025683],"source_repo_name":"MarilynKeller/OSSO","source_issue_id":2153411915,"source_issue_number":14,"source_issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","target_repo_name":"MarilynKeller/aitviewer-skel","target_issue_id":2157025683,"target_issue_number":2,"target_issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","reference_anchor_document_id":"gh_comment_1972399925","reference_answer_author":"MarilynKeller","reference_answer_author_association":"OWNER","quality_score":87.76,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2308,"target_answer_overlap":0.0952},"issue_created_at":"2024-02-26T07:08:31+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2153411915","fragment_type":"issue_description","sequence":0,"text":"Where to get more demo body？\nHi, this is a truly impressive piece of work. I'd like to try out more models. Could you please let me know where I can find similar human body models for experimentation, like those in the demo folder?\n\nThank you.","author_login":"qaz8788817","author_association":"NONE","created_at":"2024-02-26T07:08:31+08:00","repo_name":"MarilynKeller/OSSO","issue_id":2153411915,"issue_number":14,"issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1963873630","fragment_type":"issue_comment","sequence":1,"text":"Hi, you can find a large variety of SMPL bodies and sequences in the AMASS Dataset\n\nIn the download section, click on SMPL+H G\n<img width=\"1058\" alt=\"image\" src=\" URL \n\nTo vizualize those sequences of bodies in motion, you can use AitViewer.\n\nPlease also note that OSSO is a project from 2022, we now have a new body+skeleton model called SKEL that supports more applications: URL","author_login":"MarilynKeller","author_association":"OWNER","created_at":"2024-02-26T11:06:43+08:00","repo_name":"MarilynKeller/OSSO","issue_id":2153411915,"issue_number":14,"issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1965718418","fragment_type":"issue_comment","sequence":2,"text":"Hi, thanks for your reply.\nAfter I downloaded and decompressed one of the AMASS dataset, I got multiple sets of npz files. Should I use osso/utils/fit_osso.py to convert these files into ply files? Or there is a mistake in my understanding. \n\nThank you.","author_login":"qaz8788817","author_association":"NONE","created_at":"2024-02-27T03:23:10+08:00","repo_name":"MarilynKeller/OSSO","issue_id":2153411915,"issue_number":14,"issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970653048","fragment_type":"issue_comment","sequence":3,"text":"I'm not sure if it's appropriate to ask this question, and I apologize if it causes any inconvenience. I followed the instruction to download the CMU dataset from AMASS, and after extracting it, I obtained npz files containing different actions from various subjects. I used numpy to read one of the files, and the contents are as follows:\nimage\nHere is no `vertices` and `faces` in these files.\nI would like to convert these files into ply or obj format so that I can use main.py to generate skeletons. Is there any method to convert these npz files into obj or ply files?\nThank you.","author_login":"qaz8788817","author_association":"NONE","created_at":"2024-02-29T08:34:12+08:00","repo_name":"MarilynKeller/OSSO","issue_id":2153411915,"issue_number":14,"issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970890274","fragment_type":"issue_comment","sequence":4,"text":"The AMASS files contain sequences of parameters defining for each frame the pose (poses), body shape (betas) and translation (trans) of a human body.\nTo generate a 3D mesh out of them, you need to use SMPL. You can use it through the smplx library ( URL \n\nIn your more recent project SKEL, we have a demo where we directly fit the SKEL skeleton model to an AMASS sequence. You can see an example of how we get the SMPL mesh vertices from the .npz dictionary here","author_login":"MarilynKeller","author_association":"OWNER","created_at":"2024-02-29T10:59:05+08:00","repo_name":"MarilynKeller/OSSO","issue_id":2153411915,"issue_number":14,"issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1972399925","fragment_type":"issue_comment","sequence":5,"text":"Thanks. I follow the SKEL installation steps to install aitviewer, and I cannot install it successfully. I have commented my error and question here: URL \n\nThanks.","author_login":"qaz8788817","author_association":"NONE","created_at":"2024-03-01T03:17:52+08:00","repo_name":"MarilynKeller/OSSO","issue_id":2153411915,"issue_number":14,"issue_url":"https://github.com/MarilynKeller/OSSO/issues/14","linked_issue_ids":[2157025683],"is_known_query_context":false},{"document_id":"gh_issue_2157025683","fragment_type":"issue_description","sequence":0,"text":"Unable to install aitviewer-skel on Windows\nI try to install aitviewer-skel following your instructions, I get the following error:\n\nERROR: Could not find a version that satisfies the requirement nimblephysics==0.10.32 (from aitviewer) (from versions: none)\nERROR: No matching distribution found for nimblephysics==0.10.32\n\nOS: Windows 11 on amd64\nPython: 3.9","author_login":"markus-albis","author_association":"NONE","created_at":"2024-02-27T16:20:25+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968218127","fragment_type":"issue_comment","sequence":1,"text":"According to nimblephysics'document , \"We do not currently support Windows. Windows users are recommended to use the Windows Subsystem for Linux.\"","author_login":"hwy1992129","author_association":"NONE","created_at":"2024-02-28T04:42:16+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968395404","fragment_type":"issue_comment","sequence":2,"text":"aitviewer is a set of tools to visualize and interact with sequences of 3D data with cross-platform support on Windows, Linux, and macOS. It would be nice if aitviewer-skel is also cross-platform.","author_login":"markus-albis","author_association":"NONE","created_at":"2024-02-28T07:36:58+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970823326","fragment_type":"issue_comment","sequence":3,"text":"As the error says, nimblephisics is not supported on windows. It is only used to visualize the BSM.osim model. If you are not using BSM , you can remove the nimblephysics line in setup.py (here) and try to install again. You will still be able to visualize markers and SKEL.","author_login":"MarilynKeller","author_association":"OWNER","created_at":"2024-02-29T10:17:56+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1972709534","fragment_type":"issue_comment","sequence":4,"text":"Installation without nimblephysics was successful. I think you can close the issue.","author_login":"loreofblasius","author_association":"NONE","created_at":"2024-03-01T08:12:29+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1972865651","fragment_type":"issue_comment","sequence":5,"text":"@qaz8788817 It seems like your error is not due to using windows as it works for loreofblasius .\n\n`cp950` is a code page used traditionally by Chinese Windows systems, maybe changing your system language to one that supports UTF-8 (like english) can help but no guarranty here.\n\n If you can't fix it I suggest you set up a Ubuntu Virtual Machine.","author_login":"MarilynKeller","author_association":"OWNER","created_at":"2024-03-01T09:51:58+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3061412852","fragment_type":"issue_comment","sequence":6,"text":"When try install on windows, if see\n[UnicodeDecodeError: 'gbk' codec can't decode byte 0xa7 in position 817: illegal multibyte sequence]\n\nJust modify the setup.py:\nlong_description=open(\"README.md\").read() -> long_description=open(\"README.md\", encoding='utf-8').read(),","author_login":"ZuoCX1996","author_association":"NONE","created_at":"2025-07-11T09:12:06+08:00","repo_name":"MarilynKeller/aitviewer-skel","issue_id":2157025683,"issue_number":2,"issue_url":"https://github.com/MarilynKeller/aitviewer-skel/issues/2","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0154","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Question regarding precipitation values?","query_context":"Is precipitation and precipitation_sum always the water equivalent?\n\nSo will 7cm snow (=10 mm water) and 10 mm rain yield 20 mm?\n\nOr is it 80mm?\n\nThat should be made a bit more clear in the description of parameters\n\ne.g. Total precipitation (**water equivalent of** rain, showers, snow) sum of the preceding hour","known_context_document_ids":["gh_issue_1590575204"],"reference_answer":"Freezing rain calculation is deployed. It will take a couple of hours, before the new CFRZR is downloaded and available on the API nodes","answer_document_id":"gh_comment_1499413742","silver_evidence_path":["gh_comment_1497239151","gh_issue_1654451623","gh_comment_1499413742"],"evidence_issue_ids":[1590575204,1654451623],"source_repo_name":"open-meteo/open-meteo","source_issue_id":1590575204,"source_issue_number":226,"source_issue_url":"https://github.com/open-meteo/open-meteo/issues/226","target_repo_name":"open-meteo/open-meteo","target_issue_id":1654451623,"target_issue_number":283,"target_issue_url":"https://github.com/open-meteo/open-meteo/issues/283","reference_anchor_document_id":"gh_comment_1497239151","reference_answer_author":"patrick-zippenfenig","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.1667,"target_answer_overlap":0.2857},"issue_created_at":"2023-02-19T05:56:04+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1590575204","fragment_type":"issue_description","sequence":0,"text":"Question regarding precipitation values\nIs precipitation and precipitation_sum always the water equivalent?\n\nSo will 7cm snow (=10 mm water) and 10 mm rain yield 20 mm?\n\nOr is it 80mm?\n\nThat should be made a bit more clear in the description of parameters\n\ne.g. Total precipitation (**water equivalent of** rain, showers, snow) sum of the preceding hour","author_login":"woheller69","author_association":"CONTRIBUTOR","created_at":"2023-02-19T05:56:04+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1436621379","fragment_type":"issue_comment","sequence":1,"text":"Right now, yes. 7cm is equivalent to 10mm snow water. Weather models typically offer a variable snowfall water equivalent. If you look for `snowfall_water_equivalent` you will find it in the code. Within one hours, it is also possible to have mixed snowfall and rain.\n\nShowers are not available for all weather models. For example HRRR does not indicate showers explicitly, while GFS has dedicated fields. `Weathercode` uses CAPE and lifted index to indicate convective conditions.\n\nHRRR is a convection permitting model and tries to simulate the processes behind convective precipitations. GFS with ~13 km resolution cannot do that and parameterises convection. E.g. if there is enough thermal energy and humidity in the atmosphere there \"should\" be convective precipitation.\n\nFor the documentation I could phrase it: `Total precipitation (rain, showers, water equivalent of snow)` to make it clear that only snow is converted to liquid precipitation","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-02-20T09:28:33+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445173746","fragment_type":"issue_comment","sequence":2,"text":"Are you using a 1mm/h threshold before showing a weather id with light rain or snow?\nI have a lot of overcast clouds symbols with 0.x mm precipitation hourly.","author_login":"woheller69","author_association":"NONE","created_at":"2023-02-25T18:15:51+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445272527","fragment_type":"issue_comment","sequence":3,"text":"that is what I mean: Precipitation sum > 0 all day but no weathercode containing precipitation\n\nScreenshot_20230226-062250_omWeather_1","author_login":"woheller69","author_association":"NONE","created_at":"2023-02-26T05:28:39+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445428923","fragment_type":"issue_comment","sequence":4,"text":"Which locations are you looking at? Central Europe with ICON-D2 data?\n\nICON offer weather code directly. For other weather models, I am calculating it manually.","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-02-26T18:29:15+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1451665376","fragment_type":"issue_comment","sequence":5,"text":"just found that sometimes the sum of rain+showers+swnowfall is 0 but precipitation is something small like 0.1mm and the icon is just overcast clouds, like in the example above","author_login":"woheller69","author_association":"CONTRIBUTOR","created_at":"2023-03-02T10:47:23+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1451668180","fragment_type":"issue_comment","sequence":6,"text":"That helps... I am suspecting that snow showers could cause those inconsistencies","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-03-02T10:49:37+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1451687594","fragment_type":"issue_comment","sequence":7,"text":"but there are also overcast icons (weathercode 3) where snow is not 0\n\ne.g. here\n URL","author_login":"woheller69","author_association":"CONTRIBUTOR","created_at":"2023-03-02T11:04:08+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1451716183","fragment_type":"issue_comment","sequence":8,"text":"are snow showers included in showers, and if so are they included as water equivalent or snow amount?","author_login":"woheller69","author_association":"CONTRIBUTOR","created_at":"2023-03-02T11:26:33+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1455912656","fragment_type":"issue_comment","sequence":9,"text":"Snowfall is always water equivalent in weather model outputs. I assumed that convective snowfall is not included in convective precipitation, but it could be possible. It could also be different in different weather models","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-03-06T10:57:29+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484124794","fragment_type":"issue_comment","sequence":10,"text":"@phillipseamore do you know if ICON is using CAP, LPI and lifted index for weather codes?","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-03-26T15:06:31+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497239151","fragment_type":"issue_comment","sequence":11,"text":"Closing for cleanup. Feel free to reopen if you have more questions\n\nAs a follow up, Freezing rain will be added to GFS #283","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-04-05T10:07:32+08:00","repo_name":"open-meteo/open-meteo","issue_id":1590575204,"issue_number":226,"issue_url":"https://github.com/open-meteo/open-meteo/issues/226","linked_issue_ids":[1654451623],"is_known_query_context":false},{"document_id":"gh_issue_1654451623","fragment_type":"issue_description","sequence":0,"text":"Freezing Rain Weathercode Not Being Calculated\nTomorrow for my location there is going to be a prolonged period of freezing rain and there are freezing rain warnings for my location currently but when looking at the Open-Meteo API during the same time period it is returning rain instead of freezing rain.\n\nI took a look at the weathercode calculation and there currently isn't anything which is returning freezing rain and the only model which returns freezing rain is the DWD Icon model which supplies their own weathercodes.\n\nBest Match:\nimage\n\nDWD Icon:\nimage","author_login":"Acraeus","author_association":"NONE","created_at":"2023-04-04T19:25:47+08:00","repo_name":"open-meteo/open-meteo","issue_id":1654451623,"issue_number":283,"issue_url":"https://github.com/open-meteo/open-meteo/issues/283","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497228063","fragment_type":"issue_comment","sequence":1,"text":"It should be possible to use \"Categorical Freezing Rain\" CFRZR from GFS and HRRR to adjust the weather code. \n\nWith now almost all data available from the 13 km resolution GFS version (except visibility), weather codes could be pre-calculated. Right now, weather codes are calculated in the API code on-demend and performance limits how much data I can process for weather codes calculation","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-04-05T09:59:23+08:00","repo_name":"open-meteo/open-meteo","issue_id":1654451623,"issue_number":283,"issue_url":"https://github.com/open-meteo/open-meteo/issues/283","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1499413742","fragment_type":"issue_comment","sequence":2,"text":"Freezing rain calculation is deployed. It will take a couple of hours, before the new CFRZR is downloaded and available on the API nodes","author_login":"patrick-zippenfenig","author_association":"MEMBER","created_at":"2023-04-06T17:45:13+08:00","repo_name":"open-meteo/open-meteo","issue_id":1654451623,"issue_number":283,"issue_url":"https://github.com/open-meteo/open-meteo/issues/283","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0155","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[QUESTION] XL LED Strips dim after a few minutes. Why? And will RGB be enabled at some point?","query_context":"Why do the LED strips dim, and why isnt it controllable? Also, in the demos they are RGB strips. Are these RGB, and if so will colors be unlocked at some point?","known_context_document_ids":["gh_issue_1867350963"],"reference_answer":"Thanks for your suggestion.\n\nSome sort of customization should be possible in the future.\n\nMichele Moramarco\nPrusa Research","answer_document_id":"gh_comment_1726637632","silver_evidence_path":["gh_comment_1726638018","gh_issue_1780849424","gh_comment_1726637632"],"evidence_issue_ids":[1867350963,1780849424],"source_repo_name":"prusa3d/Prusa-Firmware-Buddy","source_issue_id":1867350963,"source_issue_number":3225,"source_issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","target_repo_name":"prusa3d/Prusa-Firmware-Buddy","target_issue_id":1780849424,"target_issue_number":3118,"target_issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3118","reference_anchor_document_id":"gh_comment_1726638018","reference_answer_author":"Prusa-Support","reference_answer_author_association":"COLLABORATOR","quality_score":75.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.7333,"target_answer_overlap":0.0},"issue_created_at":"2023-08-25T16:30:42+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1867350963","fragment_type":"issue_description","sequence":0,"text":"[QUESTION] XL LED Strips dim after a few minutes. Why? And will RGB be enabled at some point?\nWhy do the LED strips dim, and why isnt it controllable? Also, in the demos they are RGB strips. Are these RGB, and if so will colors be unlocked at some point?","author_login":"hatesyourface","author_association":"NONE","created_at":"2023-08-25T16:30:42+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1694350360","fragment_type":"issue_comment","sequence":1,"text":"I can confirm they are RGB, because when the XL detects a crash, they turn red. :-)","author_login":"ulab","author_association":"NONE","created_at":"2023-08-26T14:14:57+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1726638018","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your suggestion.\n\nSome sort of customization should be possible in the future.\nAlso, this issue partially duplicates URL \n\nMichele Moramarco\nPrusa Research","author_login":"Prusa-Support","author_association":"COLLABORATOR","created_at":"2023-09-19T22:45:55+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[1780849424],"is_known_query_context":false},{"document_id":"gh_comment_1726826745","fragment_type":"issue_comment","sequence":3,"text":"Michele, is it intentional that the light strips dim at 120 seconds even when printing?","author_login":"hatesyourface","author_association":"NONE","created_at":"2023-09-20T03:26:02+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1758626532","fragment_type":"issue_comment","sequence":4,"text":"Yes. I don't know the ultimate reason why it is so but it is intentional indeed.\nI'm not sure how long it takes to dim out exactly either but it may take a couple of minutes.\nHowever, I seem to understand that the behavior may change in various circumstances.\nUnfortunately, I don't have access to specific information at the moment but the described behavior is expected.\n\nMichele Moramarco\nPrusa Research","author_login":"Prusa-Support","author_association":"COLLABORATOR","created_at":"2023-10-11T22:20:14+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2028010984","fragment_type":"issue_comment","sequence":5,"text":"Light strips dimming can be disabled in FW 6.0.0 which is currently available for _alpha_ testing.\n URL \n\nMichele Moramarco\nPrusa Research","author_login":"Prusa-Support","author_association":"COLLABORATOR","created_at":"2024-03-30T10:52:23+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2079736863","fragment_type":"issue_comment","sequence":6,"text":"The final release 6.0.0 is out and strip light dimming can be disabled with it.\n URL \n\nThis issue will be closed as solved now.\n\nMichele Moramarco\nPrusa Research","author_login":"Prusa-Support","author_association":"COLLABORATOR","created_at":"2024-04-26T16:44:38+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1867350963,"issue_number":3225,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3225","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1780849424","fragment_type":"issue_description","sequence":0,"text":"[ENHANCEMENT] XL RBG Lights Auto On/Off\n**Printer type** - XL\n\n**Describe the expected functionality**\nI would like the RBG light strips to automatically turn on and off. For example, the print starts and the RBG light strips turn on. As soon as the print finishes, the lights automatically shut off. Also would be nice to have a timeout on the lights. Maybe they shut off at configurable time AFTER the print finishes.","author_login":"chrishilbert","author_association":"NONE","created_at":"2023-06-29T13:44:18+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1780849424,"issue_number":3118,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3118","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1726637632","fragment_type":"issue_comment","sequence":1,"text":"Thanks for your suggestion.\n\nSome sort of customization should be possible in the future.\n\nMichele Moramarco\nPrusa Research","author_login":"Prusa-Support","author_association":"COLLABORATOR","created_at":"2023-09-19T22:45:24+08:00","repo_name":"prusa3d/Prusa-Firmware-Buddy","issue_id":1780849424,"issue_number":3118,"issue_url":"https://github.com/prusa3d/Prusa-Firmware-Buddy/issues/3118","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0156","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Crawler mixes up content from different files?","query_context":"**Describe the bug**\nAn empty document is crawled, the content and file node in the index are filled with the data of probably the previous parsed document.\nThis bug is a combination of another bug, documents starting with ~ are being included. In our text corpus it is going through.\n\n**Job Settings**\n\nyml\n# required\nname: \"abc\"\n\n# required\nfs:\n # define a \"local\" file path crawler, if running inside a docker container this must be the path INSIDE the container\n url: \"/tmp/es\"\n follow_symlink: false\n remove_deleted: false\n continue_on_error: true\n update_rate: \"5m\"\n includes:\n - \"*.pdf\"\n - \"*.doc\"\n - \"*.docx\"\n - \"*.xsl\"\n - \"*.xslx\"\n - \"*.msg\"\n - \"*.txt\"\n - \"*.md\"\n excludes:\n - \"*.exclude\"\n - \"~*\"\n # optional: do not send big files to TIKA\n ignore_above: \"512mb\"\n\n # special handling of JSON files, should only be used if ALL files are JSON\n json_support: false\n add_as_inner_object: false\n xml_support: false\n filename_as_id: false\n add_filesize: true\n # inlcude user/group of file only if needed\n attributes_support: false\n # do you REALLY want to store every file as a copy in the index ? Then set this to true\n store_source: false\n # you may want to store (partial) content of the file (see indexed_chars)\n index_content: true\n # how much data from the content of the file should be indexed (and stored inside the index), set to 0 if you need checksum, but no content at all to be indexed\n #indexed_chars: \"0\"\n # TODO what is the tradeoff here, if set to 0 all seems to work still\n indexed_chars: \"1000000\"\n # usually file metadata will be stored in separate fields, if you want to keep the original set, set this to true\n raw_metadata: false\n # optional: add checksum meta (requires index_content to be set to true)\n checksum: \"MD5\"\n # recommmended, but will create another index\n index_folders: false\n lang_detect: true\n\n ocr.pdf_strategy: noocr\n #ocr:\n # language: \"eng\"\n # path: \"/path/to/tesseract/if/not/available/in/PATH\"\n # data_path: \"/path/to/tesseract/tessdata/if/needed\"\n\n# optional: only required if you want to SSH to another server to index documents from there\n#server:\n# hostname: \"localhost\"\n# port: 22\n# username: \"dadoonet\"\n# password: \"password\"\n# protocol: \"SSH\"\n# pem_path: \"/path/to/pemfile\"\n\n# required\nelasticsearch:\n nodes:\n # With Cloud ID\n # - cloud_id: \"CLOUD_ID\"\n # With URL\n - url: \" URL \n bulk_size: 1000\n flush_interval: \"5s\"\n byte_size: \"10mb\"\n username: \"elastic\"\n password: \"changeme\"\n # optional, defaults to \"docs\"\n index: \"tldr_index_docs\"\n # optional, defaults to \"test_folders\", used when es.index_folders is set to true\n # index_folder: \"test_fold\"\n ssl_verification: true\n pipeline: \"fscrawler\"\nrest:\n # only is started with --rest option\n url: \" URL \n enable_cors: true\n\n**Logs**\n\nFULL FSCrawler LOGS HERE\n\n**Expected behavior**\nMake sure data of files are not being mixed up.\n\n**Versions:**\nMac\nversion 10\n\n**Attachment**\n\nIf the bug is related to a given file, please share this file, so we can reuse it in tests\nto reproduce the problem and may be use it in our integration tests.","known_context_document_ids":["gh_issue_2078308987"],"reference_answer":"So I found the problem.\n\n`~*` does not match a filename like `/~foo`.\nThe right syntax to use here is `*/~*` which should match. \n\nThat's BTW the default value used for exclusions.\n\nSo it's not a bug to me but a misconfiguration.\n\nClosing but feel free to reopen if needed.","answer_document_id":"gh_comment_1890962523","silver_evidence_path":["gh_comment_1889255553","gh_issue_2072402604","gh_comment_1890962523"],"evidence_issue_ids":[2078308987,2072402604],"source_repo_name":"dadoonet/fscrawler","source_issue_id":2078308987,"source_issue_number":1798,"source_issue_url":"https://github.com/dadoonet/fscrawler/issues/1798","target_repo_name":"dadoonet/fscrawler","target_issue_id":2072402604,"target_issue_number":1794,"target_issue_url":"https://github.com/dadoonet/fscrawler/issues/1794","reference_anchor_document_id":"gh_comment_1889255553","reference_answer_author":"dadoonet","reference_answer_author_association":"OWNER","quality_score":85.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.0588,"target_answer_overlap":0.1},"issue_created_at":"2024-01-12T08:17:38+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2078308987","fragment_type":"issue_description","sequence":0,"text":"Crawler mixes up content from different files\n**Describe the bug**\nAn empty document is crawled, the content and file node in the index are filled with the data of probably the previous parsed document.\nThis bug is a combination of another bug, documents starting with ~ are being included. In our text corpus it is going through.\n\n**Job Settings**\n\nyml\n# required\nname: \"abc\"\n\n# required\nfs:\n # define a \"local\" file path crawler, if running inside a docker container this must be the path INSIDE the container\n url: \"/tmp/es\"\n follow_symlink: false\n remove_deleted: false\n continue_on_error: true\n update_rate: \"5m\"\n includes:\n - \"*.pdf\"\n - \"*.doc\"\n - \"*.docx\"\n - \"*.xsl\"\n - \"*.xslx\"\n - \"*.msg\"\n - \"*.txt\"\n - \"*.md\"\n excludes:\n - \"*.exclude\"\n - \"~*\"\n # optional: do not send big files to TIKA\n ignore_above: \"512mb\"\n\n # special handling of JSON files, should only be used if ALL files are JSON\n json_support: false\n add_as_inner_object: false\n xml_support: false\n filename_as_id: false\n add_filesize: true\n # inlcude user/group of file only if needed\n attributes_support: false\n # do you REALLY want to store every file as a copy in the index ? Then set this to true\n store_source: false\n # you may want to store (partial) content of the file (see indexed_chars)\n index_content: true\n # how much data from the content of the file should be indexed (and stored inside the index), set to 0 if you need checksum, but no content at all to be indexed\n #indexed_chars: \"0\"\n # TODO what is the tradeoff here, if set to 0 all seems to work still\n indexed_chars: \"1000000\"\n # usually file metadata will be stored in separate fields, if you want to keep the original set, set this to true\n raw_metadata: false\n # optional: add checksum meta (requires index_content to be set to true)\n checksum: \"MD5\"\n # recommmended, but will create another index\n index_folders: false\n lang_detect: true\n\n ocr.pdf_strategy: noocr\n #ocr:\n # language: \"eng\"\n # path: \"/path/to/tesseract/if/not/available/in/PATH\"\n # data_path: \"/path/to/tesseract/tessdata/if/needed\"\n\n# optional: only required if you want to SSH to another server to index documents from there\n#server:\n# hostname: \"localhost\"\n# port: 22\n# username: \"dadoonet\"\n# password: \"password\"\n# protocol: \"SSH\"\n# pem_path: \"/path/to/pemfile\"\n\n# required\nelasticsearch:\n nodes:\n # With Cloud ID\n # - cloud_id: \"CLOUD_ID\"\n # With URL\n - url: \" URL \n bulk_size: 1000\n flush_interval: \"5s\"\n byte_size: \"10mb\"\n username: \"elastic\"\n password: \"changeme\"\n # optional, defaults to \"docs\"\n index: \"tldr_index_docs\"\n # optional, defaults to \"test_folders\", used when es.index_folders is set to true\n # index_folder: \"test_fold\"\n ssl_verification: true\n pipeline: \"fscrawler\"\nrest:\n # only is started with --rest option\n url: \" URL \n enable_cors: true\n\n**Logs**\n\nFULL FSCrawler LOGS HERE\n\n**Expected behavior**\nMake sure data of files are not being mixed up.\n\n**Versions:**\nMac\nversion 10\n\n**Attachment**\n\nIf the bug is related to a given file, please share this file, so we can reuse it in tests\nto reproduce the problem and may be use it in our integration tests.","author_login":"j-a-a-p","author_association":"NONE","created_at":"2024-01-12T08:17:38+08:00","repo_name":"dadoonet/fscrawler","issue_id":2078308987,"issue_number":1798,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1798","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1889210926","fragment_type":"issue_comment","sequence":1,"text":"So I tried to reproduce the issue but with no luck so far.\n\nI'm indexing a first document `01-not-empty.txt` which contains `Hello world` and then a second one `02-empty.txt` which is empty.\n\nAs a result, I'm seeing:\n\nGET fscrawler_fs_crawler_test_empty_files_i_t_test_empty_files/_search\n\njson\n{\n \"took\": 1,\n \"timed_out\": false,\n \"_shards\": {\n \"total\": 1,\n \"successful\": 1,\n \"skipped\": 0,\n \"failed\": 0\n },\n \"hits\": {\n \"total\": {\n \"value\": 2,\n \"relation\": \"eq\"\n },\n \"max_score\": 1,\n \"hits\": [\n {\n \"_index\": \"fscrawler_fs_crawler_test_empty_files_i_t_test_empty_files\",\n \"_id\": \"23f5da98a61d207ac02723f85414c0\",\n \"_score\": 1,\n \"_source\": {\n \"content\": \"\"\"Hello world\n\n\"\"\",\n \"file\": {\n \"extension\": \"txt\",\n \"content_type\": \"text/plain; charset=ISO-8859-1\",\n \"created\": \"2024-01-12T13:24:24.000+00:00\",\n \"last_modified\": \"2024-01-12T13:24:24.346+00:00\",\n \"last_accessed\": \"2024-01-12T13:24:24.356+00:00\",\n \"indexing_date\": \"2024-01-12T13:24:24.606+00:00\",\n \"filesize\": 12,\n \"filename\": \"01-not-empty.txt\",\n \"url\": \"file:///var/folders/xn/47mdpxd12vq4zrjhkwbhd5_r0000gn/T/junit307035750893341835/resources/test_empty_files/01-not-empty.txt\"\n },\n \"path\": {\n \"root\": \"c794792f386a076532c97ad368d4c1\",\n \"virtual\": \"/01-not-empty.txt\",\n \"real\": \"/var/folders/xn/47mdpxd12vq4zrjhkwbhd5_r0000gn/T/junit307035750893341835/resources/test_empty_files/01-not-empty.txt\"\n }\n }\n },\n {\n \"_index\": \"fscrawler_fs_crawler_test_empty_files_i_t_test_empty_files\",\n \"_id\": \"7ce7eff2d74c1c8f753917afe8645ae9\",\n \"_score\": 1,\n \"_source\": {\n \"file\": {\n \"extension\": \"txt\",\n \"content_type\": \"text/plain\",\n \"created\": \"2024-01-12T13:24:24.000+00:00\",\n \"last_modified\": \"2024-01-12T13:24:24.345+00:00\",\n \"last_accessed\": \"2024-01-12T13:24:24.345+00:00\",\n \"indexing_date\": \"2024-01-12T13:24:24.761+00:00\",\n \"filesize\": 0,\n \"filename\": \"02-empty.txt\",\n \"url\": \"file:///var/folders/xn/47mdpxd12vq4zrjhkwbhd5_r0000gn/T/junit307035750893341835/resources/test_empty_files/02-empty.txt\"\n },\n \"path\": {\n \"root\": \"c794792f386a076532c97ad368d4c1\",\n \"virtual\": \"/02-empty.txt\",\n \"real\": \"/var/folders/xn/47mdpxd12vq4zrjhkwbhd5_r0000gn/T/junit307035750893341835/resources/test_empty_files/02-empty.txt\"\n }\n }\n }\n ]\n }\n}\n\n \n\nCould you share 2 documents which reproduce the problem?","author_login":"dadoonet","author_association":"OWNER","created_at":"2024-01-12T13:29:47+08:00","repo_name":"dadoonet/fscrawler","issue_id":2078308987,"issue_number":1798,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1889255553","fragment_type":"issue_comment","sequence":2,"text":"I see... `~should-exclude.docx` is actually not an empty document IMO but a word document being edited. It DOES contain the content.\n\nSo I think the issue is only due because we are not ignoring the `~*` pattern (#1794).","author_login":"dadoonet","author_association":"OWNER","created_at":"2024-01-12T13:48:36+08:00","repo_name":"dadoonet/fscrawler","issue_id":2078308987,"issue_number":1798,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1798","linked_issue_ids":[2072402604],"is_known_query_context":false},{"document_id":"gh_comment_1889256290","fragment_type":"issue_comment","sequence":3,"text":"Ah, sorry my bad,\n\nI have several should-exclude docs in my test set. Normally they have a text like \"This document shpuld not exclude\", but somehow I managed to have the contents of another document of the test set","author_login":"j-a-a-p","author_association":"NONE","created_at":"2024-01-12T13:48:56+08:00","repo_name":"dadoonet/fscrawler","issue_id":2078308987,"issue_number":1798,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1889258369","fragment_type":"issue_comment","sequence":4,"text":"Correct, It is not fscrawler, but me who is mixing up documents...","author_login":"j-a-a-p","author_association":"NONE","created_at":"2024-01-12T13:49:47+08:00","repo_name":"dadoonet/fscrawler","issue_id":2078308987,"issue_number":1798,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2072402604","fragment_type":"issue_description","sequence":0,"text":"excludes setting only works for endsWith wildcards / and files being edited with ~ are indexed\n**Describe the bug**\n\nAny exclude like\n\nyml\nexcludes:\n- \"~*\"\n\nwill not work\n\nThe code is doing this a lazy replacement for the filter:\n\njava\nString regex = exclude.toLowerCase().replace(\"?\", \".?\").replace(\"*\", \".*?\");\n\nIF this is replaced by:\n\njava\nString regex = exclude.toLowerCase().replace(\"?\", \".?\").replace(\"*\", \".*\");\n\nthe bug will be solved. Perhaps do this only when the exclude ends with '*'","author_login":"j-a-a-p","author_association":"NONE","created_at":"2024-01-09T13:46:57+08:00","repo_name":"dadoonet/fscrawler","issue_id":2072402604,"issue_number":1794,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1794","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1890962523","fragment_type":"issue_comment","sequence":1,"text":"So I found the problem.\n\n`~*` does not match a filename like `/~foo`.\nThe right syntax to use here is `*/~*` which should match. \n\nThat's BTW the default value used for exclusions.\n\nSo it's not a bug to me but a misconfiguration.\n\nClosing but feel free to reopen if needed.","author_login":"dadoonet","author_association":"OWNER","created_at":"2024-01-14T14:06:05+08:00","repo_name":"dadoonet/fscrawler","issue_id":2072402604,"issue_number":1794,"issue_url":"https://github.com/dadoonet/fscrawler/issues/1794","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0157","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Request: Use Semantic Versioning for Releases?","query_context":"Hi, I've noticed that the releases for `TheBoringNotch` on GitHub do not follow semantic versioning (e.g., `v1.2.3`). Instead, you use random strings, which makes it difficult to manage version tracking for package managers like Homebrew. See this PR.\n\nThis lack of a structured versioning scheme complicates the process of creating and maintaining a Homebrew cask for `TheBoringNotch`, as Homebrew expects versioned releases to track updates properly.\n\nWould it be possible to adopt a versioning format such as `vX.Y.Z` (e.g., `v1.0.0`, `v1.1.0`, etc.) for future releases? This change would make integration with package managers and automation tools much smoother.\n\nThanks for your consideration!","known_context_document_ids":["gh_issue_2895023155"],"reference_answer":"You can't add it due to the lack of paid Apple dev account. I have already set up the homebrew cask, I just cannot publish it.","answer_document_id":"gh_comment_2443951803","silver_evidence_path":["gh_comment_3124185916","gh_issue_2582346102","gh_comment_2443951803"],"evidence_issue_ids":[2895023155,2582346102],"source_repo_name":"TheBoredTeam/boring.notch","source_issue_id":2895023155,"source_issue_number":421,"source_issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/421","target_repo_name":"TheBoredTeam/boring.notch","target_issue_id":2582346102,"target_issue_number":127,"target_issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","reference_anchor_document_id":"gh_comment_3124185916","reference_answer_author":"richardkunkli","reference_answer_author_association":"MEMBER","quality_score":95.36,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2727,"anchor_target_overlap":0.0909,"target_answer_overlap":0.2857},"issue_created_at":"2025-03-04T17:49:46+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2895023155","fragment_type":"issue_description","sequence":0,"text":"Request: Use Semantic Versioning for Releases\nHi, I've noticed that the releases for `TheBoringNotch` on GitHub do not follow semantic versioning (e.g., `v1.2.3`). Instead, you use random strings, which makes it difficult to manage version tracking for package managers like Homebrew. See this PR.\n\nThis lack of a structured versioning scheme complicates the process of creating and maintaining a Homebrew cask for `TheBoringNotch`, as Homebrew expects versioned releases to track updates properly.\n\nWould it be possible to adopt a versioning format such as `vX.Y.Z` (e.g., `v1.0.0`, `v1.1.0`, etc.) for future releases? This change would make integration with package managers and automation tools much smoother.\n\nThanks for your consideration!","author_login":"singularitti","author_association":"NONE","created_at":"2025-03-04T17:49:46+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2895023155,"issue_number":421,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/421","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2699267996","fragment_type":"issue_comment","sequence":1,"text":"Hi, Homebrew maintainer here 👋\nWe would actually be able to include the application with the current version scheme, the roadblock for the moment is that we require applications to be codesigned and notarized.","author_login":"bevanjkay","author_association":"NONE","created_at":"2025-03-04T23:40:48+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2895023155,"issue_number":421,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/421","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3124185916","fragment_type":"issue_comment","sequence":2,"text":"I am going to close this for now as we are now using semantic version tags. There are other issues related to adding homebrew (#37 and #127)","author_login":"Alexander5015","author_association":"MEMBER","created_at":"2025-07-27T07:54:45+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2895023155,"issue_number":421,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/421","linked_issue_ids":[2582346102],"is_known_query_context":false},{"document_id":"gh_issue_2582346102","fragment_type":"issue_description","sequence":0,"text":"Homebrew Support? and why no Apple Developer account?\nAny reason for not being a Cask? \nWould try and add it myself. \n\nIs it because no Apple Developer account? \nWhy no account, seem a little dodgy?","author_login":"KirinVittel","author_association":"NONE","created_at":"2024-10-11T23:50:09+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2582346102,"issue_number":127,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416555339","fragment_type":"issue_comment","sequence":1,"text":"Hi,\nThanks for the feedback. As you can see it is an open-source app, we just started the development in August. A developer account costs $99/yr. I know, there are open-source apps that are signed, but note that their development team (contributors) includes an individual that has a dev account because of work or etc. Homebrew requires all the casks to be signed. We are planning to enroll and sign it, but please be more understanding.","author_login":"richardkunkli","author_association":"MEMBER","created_at":"2024-10-16T11:37:45+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2582346102,"issue_number":127,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2416560659","fragment_type":"issue_comment","sequence":2,"text":"Also, this topic clearly does not belong in the issues section. Feel free to join our Discord server if you have further questions.","author_login":"richardkunkli","author_association":"MEMBER","created_at":"2024-10-16T11:40:07+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2582346102,"issue_number":127,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2443913771","fragment_type":"issue_comment","sequence":3,"text":"I was tried to add this to Homebrew, but there is no dedicated version naming and it is not easy to match the version with the file name.","author_login":"daeho-ro","author_association":"NONE","created_at":"2024-10-29T11:07:47+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2582346102,"issue_number":127,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2443951803","fragment_type":"issue_comment","sequence":4,"text":"You can't add it due to the lack of paid Apple dev account. I have already set up the homebrew cask, I just cannot publish it.","author_login":"richardkunkli","author_association":"MEMBER","created_at":"2024-10-29T11:27:16+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2582346102,"issue_number":127,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2916749250","fragment_type":"issue_comment","sequence":5,"text":"this ^^^^ is possible to do! (I was on the core team for Ferdium, and we were able to publish as a cask even though it was unsigned)","author_login":"vraravam","author_association":"NONE","created_at":"2025-05-28T15:23:21+08:00","repo_name":"TheBoredTeam/boring.notch","issue_id":2582346102,"issue_number":127,"issue_url":"https://github.com/TheBoredTeam/boring.notch/issues/127","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0158","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Icebreaker has stopped working!","query_context":"The logic app reports that\n\n \"message\": \"An error has occurred.\",\n \"exceptionMessage\": \"Failed to acquire token for client credentials.\",\n \nand that the secret keys for the app expired. \nI created new keys ( URL but I still see a similar error. Do I need to add the new secret key to any other configuration file? I don't remember using any keys in the .json file**","known_context_document_ids":["gh_issue_1355979676"],"reference_answer":"Hi @frank-brandt ,\nThanks for raising the issue and will get back to you with proper response soon.","answer_document_id":"gh_comment_1233118947","silver_evidence_path":["gh_comment_1234345393","gh_issue_1357129093","gh_comment_1233118947"],"evidence_issue_ids":[1355979676,1357129093],"source_repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","source_issue_id":1355979676,"source_issue_number":263,"source_issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","target_repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","target_issue_id":1357129093,"target_issue_number":264,"target_issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/264","reference_anchor_document_id":"gh_comment_1234345393","reference_answer_author":"gsv022","reference_answer_author_association":"COLLABORATOR","quality_score":76.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2022-08-30T15:52:06+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1355979676","fragment_type":"issue_description","sequence":0,"text":"Icebreaker has stopped working!\nThe logic app reports that\n\n \"message\": \"An error has occurred.\",\n \"exceptionMessage\": \"Failed to acquire token for client credentials.\",\n \nand that the secret keys for the app expired. \nI created new keys ( URL but I still see a similar error. Do I need to add the new secret key to any other configuration file? I don't remember using any keys in the .json file**","author_login":"paulmitchell507","author_association":"NONE","created_at":"2022-08-30T15:52:06+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1233117213","fragment_type":"issue_comment","sequence":1,"text":"Hi @paulmitchell507 ,\nThanks for logging the issue and will get back to you with proper response soon.","author_login":"gsv022","author_association":"COLLABORATOR","created_at":"2022-08-31T15:49:24+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1234345393","fragment_type":"issue_comment","sequence":2,"text":"@paulmitchell507 Sounds like you have the same problem that I had. Check my steps to resolve the problem in URL","author_login":"frank-brandt","author_association":"NONE","created_at":"2022-09-01T14:16:18+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[1357129093],"is_known_query_context":false},{"document_id":"gh_comment_1234535540","fragment_type":"issue_comment","sequence":3,"text":"Hi @paulmitchell507 ,\n\n- It seems that new secret has been created. To confirm whether it has been updated or not. Go to keyvaults -->Secrets-->if don't have permission to view-->Go to Access policies-->Select checkboxes as shown below.-->Add you Id under principal tab-->Create-->Go to Secret whether the new secret has been applied or not.\n\n<img width=\"899\" alt=\"image\" src=\" URL \n\nimage\n\nimage\n\n- To test open the logic app and click run. \n\nHope it helps","author_login":"gsv022","author_association":"COLLABORATOR","created_at":"2022-09-01T16:50:18+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1237687385","fragment_type":"issue_comment","sequence":4,"text":"Hi @paulmitchell507 ,\nIt seems that the secret ID has been updated instead of secret value. Could you please update with secret value(highlighted one).\n<img width=\"725\" alt=\"image\" src=\" URL","author_login":"gsv022","author_association":"COLLABORATOR","created_at":"2022-09-06T05:51:08+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1239128223","fragment_type":"issue_comment","sequence":5,"text":"I re-created a secret value and updated the MicrosoftAppPassword in the keyvault but I still see the same error. Do you think MS support can help?","author_login":"csgdeskgithub","author_association":"NONE","created_at":"2022-09-07T09:16:13+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1243478703","fragment_type":"issue_comment","sequence":6,"text":"As mentioned, 5 days ago, I re-created the secret value, but the error was still showing, and the app was failing. The app continued to fail until this morning when it started working.\nI don't know what to say but thank you for your help!","author_login":"csgdeskgithub","author_association":"NONE","created_at":"2022-09-12T09:41:12+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1355979676,"issue_number":263,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1357129093","fragment_type":"issue_description","sequence":0,"text":"Oauth Secret expired\nOur OAuth secret expired. What is the easiest way to replace it without loosing the database with all the pairing that already happened?\nI can generate a new secret, but even if I grant myself permissions in the KeyVault, i cannot replace the secret in the variable MicrosoftAppPassword. Can we just create a new entry with the name MicrosoftAppPassword and the new secret or is the secret referenced with the ID of the key vault entry somewhere else?","author_login":"frank-brandt","author_association":"NONE","created_at":"2022-08-31T10:24:15+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1357129093,"issue_number":264,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1233118947","fragment_type":"issue_comment","sequence":1,"text":"Hi @frank-brandt ,\nThanks for raising the issue and will get back to you with proper response soon.","author_login":"gsv022","author_association":"COLLABORATOR","created_at":"2022-08-31T15:51:00+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1357129093,"issue_number":264,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1234343796","fragment_type":"issue_comment","sequence":2,"text":"I found the solution. Here are the steps that I took:\n1) I created a new secret in the IceBreaker OAuth App in Azure AD\n2) I granted myself permissions in the IceBreaker key vault to edit secrets\n3) I added a new version with the new client secret for secret MicrosoftAppPassword.\n4) I removed my permissions in key vault.\n5) To test open the logic app and click run or choose adapt the schedule","author_login":"frank-brandt","author_association":"NONE","created_at":"2022-09-01T14:15:11+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1357129093,"issue_number":264,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1449677985","fragment_type":"issue_comment","sequence":3,"text":"FYI, I followed @frank-brandt 's solution (thank you!), and additionally had to restart the app service before it would pick up the new secret version as suggested here","author_login":"annatindall","author_association":"NONE","created_at":"2023-03-01T09:26:20+08:00","repo_name":"OfficeDev/microsoft-teams-apps-icebreaker","issue_id":1357129093,"issue_number":264,"issue_url":"https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/issues/264","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0160","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Embedded end-user feedback?","query_context":"# QGIS Enhancement: end-user feedback and workflow\n\n**Date** 2024/03/2~~1~~2 \n**Author** Julien Moura (@guts) and Julien Cabièces (@troopa81) \n**Contact** julien.moura@oslandia.com \n**Version** QGIS 3.40\n\n## Summary\n\nReporting bugs and other feature requests is quite difficult for average QGIS end-users, who are more geomatics than IT oriented. \nAs GitHub's interface is not internationalized and oriented towards developer collaboration, there is a challenge in enabling end-users to interact more easily with the developer community.\n\nThis QEP proposes to ship a feedback form/widgets as a QGIS in-app tool in order to improve the way we gather end-user feedback.\n\nFunctionally, this would take the form of a reporting form fully integrated in Qt, with input fields corresponding to the issue forms\n\nFeatures envisaged :\n\n- localized form with an extensive helping text\n- authenticated using the a Github token with a wizard to help end-user create one\n- choice of ticket type (bug or feature request). It may be necessary to make the existing template issue evolve in order to make it consistent with the embedded form: specific labels, specific fields, etc.\n- embedded markdown editor with preview\n- a button to easily create a new debug profile where to try to reproduce\n- automatic integration of debug information (About menu, log messages, plugins list, etc). Ideally, the end-user can check/uncheck which information is sent (SQL logs, networks logs...).\n- think a way to obfuscate potential sensible information logs\n- lookup in existing Github issues (through API calls)\n- mandatory commitment to devote time to following up the ticket\n- attach some extra data: images, zip, logs... everything which is compatible with Github form\n- allow user store consistent informations to reuse accross different reports and avoid him to rewrite evertytime the same thing\n- notify the end-user directly in QGIS if an answer has been posted in one of his issues, by polling/websocket the github API (twice a day, opt-in feature) and displaying a message bar with a button redirecting to the web browser\n\nTo give an idea, here is a quick and dirty form:\n\nimage\n\nQGIS currently includes a crash management mechanism (called crash handler) that generates pre-filled issues with information about the environment. The aim is to reuse the existing code and extend it to handle more use cases.\n\n### Example(s) and inspirations\n\nThere is already some plugins that implement a report workflow for the plugins ecosystem:\n\n- URL \n- URL \n\n### Affected Files\n\n- file where the github token is managed in QGIS settings (console_settings.py --> feature \"share on gist\") --> rewrite into Qt\n\nimage\n\n## Votes\n\n(required)","known_context_document_ids":["gh_issue_2202132623"],"reference_answer":"@m-kuhn To avoid any doubt, please add a note to the QEP that indicates the deviations between the submitted proposal and the (potentially larger) full extent of the QEP. As in previous years, the voting members make their decisions based on the short summaries and the QEPs.","answer_document_id":"gh_comment_1568941278","silver_evidence_path":["gh_comment_2016526206","gh_issue_1638897563","gh_comment_1568941278"],"evidence_issue_ids":[2202132623,1638897563],"source_repo_name":"qgis/QGIS-Enhancement-Proposals","source_issue_id":2202132623,"source_issue_number":295,"source_issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","target_repo_name":"qgis/PSC","target_issue_id":1638897563,"target_issue_number":58,"target_issue_url":"https://github.com/qgis/PSC/issues/58","reference_anchor_document_id":"gh_comment_2016526206","reference_answer_author":"anitagraser","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1429},"issue_created_at":"2024-03-22T10:01:41+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2202132623","fragment_type":"issue_description","sequence":0,"text":"Embedded end-user feedback\n# QGIS Enhancement: end-user feedback and workflow\n\n**Date** 2024/03/2~~1~~2 \n**Author** Julien Moura (@guts) and Julien Cabièces (@troopa81) \n**Contact** julien.moura@oslandia.com \n**Version** QGIS 3.40\n\n## Summary\n\nReporting bugs and other feature requests is quite difficult for average QGIS end-users, who are more geomatics than IT oriented. \nAs GitHub's interface is not internationalized and oriented towards developer collaboration, there is a challenge in enabling end-users to interact more easily with the developer community.\n\nThis QEP proposes to ship a feedback form/widgets as a QGIS in-app tool in order to improve the way we gather end-user feedback.\n\nFunctionally, this would take the form of a reporting form fully integrated in Qt, with input fields corresponding to the issue forms\n\nFeatures envisaged :\n\n- localized form with an extensive helping text\n- authenticated using the a Github token with a wizard to help end-user create one\n- choice of ticket type (bug or feature request). It may be necessary to make the existing template issue evolve in order to make it consistent with the embedded form: specific labels, specific fields, etc.\n- embedded markdown editor with preview\n- a button to easily create a new debug profile where to try to reproduce\n- automatic integration of debug information (About menu, log messages, plugins list, etc). Ideally, the end-user can check/uncheck which information is sent (SQL logs, networks logs...).\n- think a way to obfuscate potential sensible information logs\n- lookup in existing Github issues (through API calls)\n- mandatory commitment to devote time to following up the ticket\n- attach some extra data: images, zip, logs... everything which is compatible with Github form\n- allow user store consistent informations to reuse accross different reports and avoid him to rewrite evertytime the same thing\n- notify the end-user directly in QGIS if an answer has been posted in one of his issues, by polling/websocket the github API (twice a day, opt-in feature) and displaying a message bar with a button redirecting to the web browser\n\nTo give an idea, here is a quick and dirty form:\n\nimage\n\nQGIS currently includes a crash management mechanism (called crash handler) that generates pre-filled issues with information about the environment. The aim is to reuse the existing code and extend it to handle more use cases.\n\n### Example(s) and inspirations\n\nThere is already some plugins that implement a report workflow for the plugins ecosystem:\n\n- URL \n- URL \n\n### Affected Files\n\n- file where the github token is managed in QGIS settings (console_settings.py --> feature \"share on gist\") --> rewrite into Qt\n\nimage\n\n## Votes\n\n(required)","author_login":"Guts","author_association":"NONE","created_at":"2024-03-22T10:01:41+08:00","repo_name":"qgis/QGIS-Enhancement-Proposals","issue_id":2202132623,"issue_number":295,"issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2016526206","fragment_type":"issue_comment","sequence":1,"text":"Thank you for submitting your proposal to the 2024 QGIS Grant Programme. The 2 week discussion period starts today. At the end of the discussion, the proposal author has to provide a 3-line pitch of their proposal for the voter information material. (For an example from last year check URL","author_login":"anitagraser","author_association":"MEMBER","created_at":"2024-03-23T15:33:09+08:00","repo_name":"qgis/QGIS-Enhancement-Proposals","issue_id":2202132623,"issue_number":295,"issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","linked_issue_ids":[1638897563],"is_known_query_context":false},{"document_id":"gh_comment_2016791687","fragment_type":"issue_comment","sequence":2,"text":"I totally agree, raising an issue is still hard for non english and non tech users. \nBeing able to push issues from QGIS, and being able to keep the context is interesting too. \n\nI've done this in a corporate environnement, where users could just push a simple issue descriptions, and we kept a screenshot and all technical context under the hood. \n\nHowever, I feel like this can be something not totally sustainable. Here is why :\n\n- In my organization, this tool was not used much, even with a lot of training and human proximity. I'm not sure users afraid by Github are real contributors (speaking population wide)\n- We create a hard dependency on Github API, which we don't manage. If it changes, QGIS feature will stop working. \n- Users have to create a token, but they expire at least yearly. How to help them renew them?\n- We will have more issues, which is good, but maybe harder to triage and manage. And we will have more non english issues, reducing the pool of possible triagers. \n- We don't educate users to go themselves learn GitHub, so the load of adaptating to Github's changes will be on our shoulders. \n- Our **current limiting factor is our ability to triage them**. Increasing the input flow as we havent' adressed the **growing 4K opened issues ** problem, might be some bad gift to our already overwhelmed triager's team. \n- We currently have 500K QGIS opening's a day. Polling he API for answers, similar issues etc, will probably lead to 5 - 30 API call per day. Everything with the same QGIS user agent. I'm afraid GitHub will start to at least identify us, and maybe block us. Which would lead to a broken core feature without any way to fix. That can be dealt by discussion with them. \n\nI feel like the really issue is that Github is non-english unfriendly. In beta version, translation of comments is on its way. UI not yet \n URL \n\nIt is already possible to auto translate interface, but it is ugly : \n URL \n\nI'm don't think we can solve this by making a proxy of github on our side, this is too big to maintain in the long run. \n\nAnd last point, when rewriting QGIS' website, PSC decided to **not** translate it. The workload for translator teams is too high and we bet that AI translation tools are solving the issue for us. \nI know this will be an issue in France, but this has a massive cost, and we are at a point of history of having partial translations deserve the project. \n\nHowever, pivoting this proposal to a generic plugin that organizations could parameterize to their internal git forge would be excellent, I dream of it. Then the GIS admin can extract its critical issues to QGIS upstream (and hopefully fund fixes) .","author_login":"haubourg","author_association":"MEMBER","created_at":"2024-03-24T12:20:51+08:00","repo_name":"qgis/QGIS-Enhancement-Proposals","issue_id":2202132623,"issue_number":295,"issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2016974965","fragment_type":"issue_comment","sequence":3,"text":"I also have concerns about this leading to more non-English bug reports. \n\nI just don't think we have the people power available to manage these effectively and ensure that the relevant information is accessible to developers with the ability to actually fix the bugs. \n\nI don't know if it's just an idea in the mockup, but I'm also strongly against collecting the social handles of the users (ie the linked in / twitter details). I can't see any reason we'd want this or in which it would be valuable for us. (More broadly, I'm extremely against **any** sign of \"official\" QGIS endorsement/support to Twitter in any way, given the disgusting cesspool of intolerance and extremism that it's become under Musk's guidance).\n\nLastly, if the user has to sign up to Github and then go through the hassle of creating a token themselves, that seems to me to be much more complex then just signing up to Github and filing the issue directly :laughing: . I realise it alleviates non-English use of Github, but creating a token is a scary/complex process for anyone completely new to Github regardless of how nicely we wrap it up in a wizard on QGIS' side... Maybe there's ways to avoid the user requiring their own key, eg through some custom service hosted on QGIS infrastructure which handles the actual GitHub API portion and issue filing using an internal hidden QGIS token?","author_login":"nyalldawson","author_association":"CONTRIBUTOR","created_at":"2024-03-24T22:52:07+08:00","repo_name":"qgis/QGIS-Enhancement-Proposals","issue_id":2202132623,"issue_number":295,"issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2023137575","fragment_type":"issue_comment","sequence":4,"text":"Thanks for your interest and for taking time to write here @haubourg and @nyalldawson.\n \n\nI think there is some confusion here. To create the issue, no call to the Github API is necessary. It's just a URL with query parameters corresponding to the issue form. Click me to have an issue with prefilled fields.\n\nAbout adherence to a platform (and a proprietary one!), the risk is not important here:\n\n- issues are so intensively and widely used that Github is unlikely to break things suddenly\n- if it happens (probability still > 0), the feedback form won't be the first concern I guess\n- similar mechanisms exist in other forges (even in Gitea) so the change would be quite affordable\n\nOn the other hand, I find it more questionable that QGIS embeds a hard-coded dependency on the fonts.google.com service (in the fonts downloader), which is certainly handy but also serves as a tracker for the world's leading advertiser.\n \n\nIs educating users to raise their Github skills a goal or even a mission for the QGIS project? I don't think so. Why not educate developers to learn using QGIS on Windows 11 for a mapping work expected for the next week? Just kidding obviously but in my opinion, this comment is emblematic of a developer's posture and how much the project can be more developer's centric, and we can look at things from another angle: why should a QGIS user learn to use a software forge, which is the developers' software?\n \n\nSorry for that, I was in a hurry and wanted to give a graphical view of the idea and, as the dialog's title reveals it, I just quickly modify a form used in QTribu (Geotribu's plugin) where social accounts are used in the publication workflow. So, yes it's definitely just an idea. No worries and sorry for that.","author_login":"Guts","author_association":"NONE","created_at":"2024-03-27T16:00:44+08:00","repo_name":"qgis/QGIS-Enhancement-Proposals","issue_id":2202132623,"issue_number":295,"issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566742357","fragment_type":"issue_comment","sequence":5,"text":"This QEP is being archived in order to empty the issue tracker on this repository. Previous discussion and voting on the QEP remains valid and unchanged.","author_login":"nyalldawson","author_association":"CONTRIBUTOR","created_at":"2024-12-31T22:48:13+08:00","repo_name":"qgis/QGIS-Enhancement-Proposals","issue_id":2202132623,"issue_number":295,"issue_url":"https://github.com/qgis/QGIS-Enhancement-Proposals/issues/295","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1638897563","fragment_type":"issue_description","sequence":0,"text":"Grant programme 2023\nProcess description: \n URL \n\n* [x] Update process description with new timeline\n 2023-04-04: Call for proposals (4 weeks)\n 2023-05-02: QEP discussion period (2 weeks)\n 2023-05-16: Writing discussion summaries (1 week)\n ~~2023-05-23~~ 2023-05-30: Voting starts (2 weeks)\n ~~2023-06-06~~ 2023-06-26: Publication of results \n --- 6 months of project work ---\n ~~2023-12-06~~ 2023-12-26: Deadline for follow-up reports\n* [x] Post call for proposals\n* [x] Compile proposal information for voters\n* [x] Run voting\n* [x] Publish voting results / winning projects\n* [x] Report results from winning projects:\n **Round 1:** \n * [x] URL URL \n * [x] URL URL \n * [x] URL URL \n * [x] URL URL \n **Round 2:** \n * [x] URL (repurposed, see URL \n * [x] URL URL","author_login":"anitagraser","author_association":"MEMBER","created_at":"2023-03-24T07:52:50+08:00","repo_name":"qgis/PSC","issue_id":1638897563,"issue_number":58,"issue_url":"https://github.com/qgis/PSC/issues/58","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1549570333","fragment_type":"issue_comment","sequence":1,"text":"@3nids would you be willing to compile the QEP discussions this year again?","author_login":"anitagraser","author_association":"MEMBER","created_at":"2023-05-16T12:29:21+08:00","repo_name":"qgis/PSC","issue_id":1638897563,"issue_number":58,"issue_url":"https://github.com/qgis/PSC/issues/58","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1568544363","fragment_type":"issue_comment","sequence":2,"text":"Dear devs, please have a look at the mini summaries of your proposals above and let me know if any need to be changed. \n\ncc @gioman @elpaso @nyalldawson @m-kuhn @Koyaani @lbartoletti @wonder-sk @alexbruy","author_login":"anitagraser","author_association":"MEMBER","created_at":"2023-05-30T14:32:59+08:00","repo_name":"qgis/PSC","issue_id":1638897563,"issue_number":58,"issue_url":"https://github.com/qgis/PSC/issues/58","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1568941278","fragment_type":"issue_comment","sequence":3,"text":"@m-kuhn To avoid any doubt, please add a note to the QEP that indicates the deviations between the submitted proposal and the (potentially larger) full extent of the QEP. As in previous years, the voting members make their decisions based on the short summaries and the QEPs.","author_login":"anitagraser","author_association":"MEMBER","created_at":"2023-05-30T19:10:21+08:00","repo_name":"qgis/PSC","issue_id":1638897563,"issue_number":58,"issue_url":"https://github.com/qgis/PSC/issues/58","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0161","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Custom micrometer tags are not displayer on actuator/prometheus page.","query_context":"**spring-kafka version** \norg.springframework.kafka:spring-kafka:jar:3.0.10\n\n**micrometer version**\nio.micrometer:micrometer-core:jar:1.11.3\nio.micrometer:micrometer-registry-prometheus:jar:1.11.3\nio.micrometer:micrometer-observation:jar:1.11.3\n\n**Custom micrometer tags are not displayer on `actuator/prometheus` page.**\n\nI'm using autoconfigured kafka with a simple listener:\n\nyaml\nspring:\n kafka:\n bootstrap-servers: localhost:29092\n consumer:\n group-id: 'some.value'\n enable-auto-commit: false\n auto-offset-reset: latest\n max-poll-records: 1\n key-deserializer: org.apache.kafka.common.serialization.StringDeserializer\n value-deserializer: org.apache.kafka.common.serialization.StringDeserializer\n producer:\n bootstrap-servers: localhost:29092\n key-serializer: org.apache.kafka.common.serialization.StringSerializer\n value-serializer: org.apache.kafka.common.serialization.StringSerializer\n\njava\n@KafkaListener(topics = \"pike\")\npublic void listen(ConsumerRecord record) {\n System.out.println(record.topic());\n}\n\njava\n@Bean\nDefaultKafkaConsumerFactoryCustomizer kafkaConsumerFactoryCustomizer(MeterRegistry meterRegistry) {\n return consumerFactory -> consumerFactory.addListener(\n new MicrometerConsumerListener<>(meterRegistry));\n}\n\njava\n@Component\nclass ConcurrentKafkaListenerContainerFactoryCustomizer {\n\n // autoconfigured kafkaListenerContainerFactory customizer\n public ConcurrentKafkaListenerContainerFactoryCustomizer(\n ConcurrentKafkaListenerContainerFactory kafkaListenerContainerFactory,\n Function , Map > micrometerTagsProvider) {\n kafkaListenerContainerFactory.setContainerCustomizer(\n container -> {\n container.getContainerProperties().setMicrometerTagsProvider(micrometerTagsProvider);\n });\n }\n }\n\nIn IDE debug I see that my micrometerTagsProvider gets called (tags are generated) as well as the code in `MicrometerHolder.java` \n\njava\nprivate Timer buildTimer(String exception, @Nullable Object record) {\n Builder builder = Timer.builder(this.timerName)\n .description(this.timerDesc)\n .tag(\"name\", this.name)\n .tag(\"result\", exception.equals(NONE_EXCEPTION_METERS_KEY) ? \"success\" : \"failure\")\n .tag(\"exception\", exception);\n Map extra = this.tagsProvider.apply(record);\n if (extra != null && !extra.isEmpty()) {\n extra.forEach(builder::tag);\n }\n Timer registeredTimer = builder.register(this.registry);\n if (record == null) {\n this.meters.put(exception, registeredTimer);\n }\n return registeredTimer;\n }\n\nI see that custom tags are added to builder, I see `spring.kafka.listener` metrics on `actuator/prometheus` page but no custom tags are displayed.\n\n**expected result**\ncustom tags must be displayed on `actuator/prometheus` page along with their metrics","known_context_document_ids":["gh_issue_2152840382"],"reference_answer":"@angry-cellophane Sorry, using the word 'drop' was confusing, you are correct that the SDK, Scraping, and Prometheus storage won't drop the unmatched metrics. \n\nI was referring to how PromQL queries work. I have a feeling (though my understand is incomplete) that PromQL queries will exclude some metrics from calculations when labels don't match, requiring a user to use the `without` or `by` to get a complete result.\n\nIf you have done any work in regards to ensuring that PromQL queries make sense when the underlying meter labels aren't all aligned, I would love to hear about your methods and approach.","answer_document_id":"gh_comment_879875784","silver_evidence_path":["gh_comment_1966698518","gh_issue_364078172","gh_comment_879875784"],"evidence_issue_ids":[2152840382,364078172],"source_repo_name":"spring-projects/spring-kafka","source_issue_id":2152840382,"source_issue_number":3070,"source_issue_url":"https://github.com/spring-projects/spring-kafka/issues/3070","target_repo_name":"micrometer-metrics/micrometer","target_issue_id":364078172,"target_issue_number":877,"target_issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","reference_anchor_document_id":"gh_comment_1966698518","reference_answer_author":"checketts","reference_answer_author_association":"COLLABORATOR","quality_score":95.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0833},"issue_created_at":"2024-02-25T16:29:01+08:00","valid_comment_count":32,"fragments":[{"document_id":"gh_issue_2152840382","fragment_type":"issue_description","sequence":0,"text":"Custom micrometer tags are not displayer on actuator/prometheus page.\n**spring-kafka version** \norg.springframework.kafka:spring-kafka:jar:3.0.10\n\n**micrometer version**\nio.micrometer:micrometer-core:jar:1.11.3\nio.micrometer:micrometer-registry-prometheus:jar:1.11.3\nio.micrometer:micrometer-observation:jar:1.11.3\n\n**Custom micrometer tags are not displayer on `actuator/prometheus` page.**\n\nI'm using autoconfigured kafka with a simple listener:\n\nyaml\nspring:\n kafka:\n bootstrap-servers: localhost:29092\n consumer:\n group-id: 'some.value'\n enable-auto-commit: false\n auto-offset-reset: latest\n max-poll-records: 1\n key-deserializer: org.apache.kafka.common.serialization.StringDeserializer\n value-deserializer: org.apache.kafka.common.serialization.StringDeserializer\n producer:\n bootstrap-servers: localhost:29092\n key-serializer: org.apache.kafka.common.serialization.StringSerializer\n value-serializer: org.apache.kafka.common.serialization.StringSerializer\n\njava\n@KafkaListener(topics = \"pike\")\npublic void listen(ConsumerRecord record) {\n System.out.println(record.topic());\n}\n\njava\n@Bean\nDefaultKafkaConsumerFactoryCustomizer kafkaConsumerFactoryCustomizer(MeterRegistry meterRegistry) {\n return consumerFactory -> consumerFactory.addListener(\n new MicrometerConsumerListener<>(meterRegistry));\n}\n\njava\n@Component\nclass ConcurrentKafkaListenerContainerFactoryCustomizer {\n\n // autoconfigured kafkaListenerContainerFactory customizer\n public ConcurrentKafkaListenerContainerFactoryCustomizer(\n ConcurrentKafkaListenerContainerFactory kafkaListenerContainerFactory,\n Function , Map > micrometerTagsProvider) {\n kafkaListenerContainerFactory.setContainerCustomizer(\n container -> {\n container.getContainerProperties().setMicrometerTagsProvider(micrometerTagsProvider);\n });\n }\n }\n\nIn IDE debug I see that my micrometerTagsProvider gets called (tags are generated) as well as the code in `MicrometerHolder.java` \n\njava\nprivate Timer buildTimer(String exception, @Nullable Object record) {\n Builder builder = Timer.builder(this.timerName)\n .description(this.timerDesc)\n .tag(\"name\", this.name)\n .tag(\"result\", exception.equals(NONE_EXCEPTION_METERS_KEY) ? \"success\" : \"failure\")\n .tag(\"exception\", exception);\n Map extra = this.tagsProvider.apply(record);\n if (extra != null && !extra.isEmpty()) {\n extra.forEach(builder::tag);\n }\n Timer registeredTimer = builder.register(this.registry);\n if (record == null) {\n this.meters.put(exception, registeredTimer);\n }\n return registeredTimer;\n }\n\nI see that custom tags are added to builder, I see `spring.kafka.listener` metrics on `actuator/prometheus` page but no custom tags are displayed.\n\n**expected result**\ncustom tags must be displayed on `actuator/prometheus` page along with their metrics","author_login":"tbarabanov","author_association":"NONE","created_at":"2024-02-25T16:29:01+08:00","repo_name":"spring-projects/spring-kafka","issue_id":2152840382,"issue_number":3070,"issue_url":"https://github.com/spring-projects/spring-kafka/issues/3070","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1964477450","fragment_type":"issue_comment","sequence":1,"text":"@tbarabanov Could you provide us with a small sample application where we can reproduce this issue? Please include some instructions to run the app as well.","author_login":"sobychacko","author_association":"CONTRIBUTOR","created_at":"2024-02-26T15:53:18+08:00","repo_name":"spring-projects/spring-kafka","issue_id":2152840382,"issue_number":3070,"issue_url":"https://github.com/spring-projects/spring-kafka/issues/3070","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966690693","fragment_type":"issue_comment","sequence":2,"text":"If problem is not on Spring for Apache Kafka side, consider to close this issue and open a new one in Micormeter or Prometheus .","author_login":"artembilan","author_association":"MEMBER","created_at":"2024-02-27T14:35:27+08:00","repo_name":"spring-projects/spring-kafka","issue_id":2152840382,"issue_number":3070,"issue_url":"https://github.com/spring-projects/spring-kafka/issues/3070","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966698518","fragment_type":"issue_comment","sequence":3,"text":"@artembilan sure, but just to let the spring-kafka team to know, that there is the issue","author_login":"tbarabanov","author_association":"NONE","created_at":"2024-02-27T14:38:56+08:00","repo_name":"spring-projects/spring-kafka","issue_id":2152840382,"issue_number":3070,"issue_url":"https://github.com/spring-projects/spring-kafka/issues/3070","linked_issue_ids":[364078172],"is_known_query_context":false},{"document_id":"gh_issue_364078172","fragment_type":"issue_description","sequence":0,"text":"PrometheusMeterRegistry requires meters with the same name to have same set of tag keys\nIn connection with `PrometheusMeterRegistry` and the new `KafkaConsumerMetrics` (thanks to @jkschneider) I have a problem that metrics won´t register correctly because of `PrometheusMeterRegistry` complaining about metrics with same name but different set of key tags. It claims that metrics of same name are required in prometheus to have same set of tags.\n\nI believe the error thrown at URL is wrong. Prometheus perfectly accepts metrics of same name with disjunct set of tags (the metrics name itself is just a tag `__name__`). We have in our prometheus production instance metrics like `up{application=\"xyz\", job=\"abc\"}` and `up{application=\"abc\", job=\"123\", host=\"prometheus\"}` coexisting without any issue whatsoever.\n\nExample of exception text, stacktrace below:\n \n\nContext of variables\n\nid = MeterId{name='kafka.consumer.records.lag.max', tags=[ImmutableTag{key='application', value='heimdall'}, ImmutableTag{key='client.id', value='consumer-1'}, ImmutableTag{key='topic', value='probe_t'}]}\nexistingCollector = MeterId{name='kafka.consumer.records.lag.max', tags=[ImmutableTag{key='application', value='heimdall'}, ImmutableTag{key='client.id', value='consumer-1'}]}\n\nStacktrace:\n\ncollectorByName:348, PrometheusMeterRegistry (io.micrometer.prometheus)\nnewGauge:225, PrometheusMeterRegistry (io.micrometer.prometheus)\nlambda$gauge$1:244, MeterRegistry (io.micrometer.core.instrument)\napply:-1, 4552198 (io.micrometer.core.instrument.MeterRegistry$$Lambda$373)\nlambda$registerMeterIfNecessary$5:514, MeterRegistry (io.micrometer.core.instrument)\napply:-1, 491928400 (io.micrometer.core.instrument.MeterRegistry$$Lambda$338)\ngetOrCreateMeter:563, MeterRegistry (io.micrometer.core.instrument)\nregisterMeterIfNecessary:525, MeterRegistry (io.micrometer.core.instrument)\nregisterMeterIfNecessary:514, MeterRegistry (io.micrometer.core.instrument)\ngauge:244, MeterRegistry (io.micrometer.core.instrument)\nregister:128, Gauge$Builder (io.micrometer.core.instrument)\nregisterGaugeForObject:149, KafkaConsumerMetrics (io.micrometer.core.instrument.binder.kafka)\nregisterGaugeForObject:153, KafkaConsumerMetrics (io.micrometer.core.instrument.binder.kafka)\nlambda$bindTo$0:79, KafkaConsumerMetrics (io.micrometer.core.instrument.binder.kafka)\naccept:-1, 1260340889 (io.micrometer.core.instrument.binder.kafka.KafkaConsumerMetrics$$Lambda$328)\nlambda$registerMetricsEventually$11:205, KafkaConsumerMetrics (io.micrometer.core.instrument.binder.kafka)\nhandleNotification:-1, 820539250 (io.micrometer.core.instrument.binder.kafka.KafkaConsumerMetrics$$Lambda$329)\nhandleNotification:1754, DefaultMBeanServerInterceptor$ListenerWrapper (com.sun.jmx.interceptor)\nhandleNotification:275, NotificationBroadcasterSupport (javax.management)\nrun:352, NotificationBroadcasterSupport$SendNotifJob (javax.management)\nexecute:337, NotificationBroadcasterSupport$1 (javax.management)\nsendNotification:248, NotificationBroadcasterSupport (javax.management)\nsendNotification:209, MBeanServerDelegate (javax.management)\nsendNotification:1498, DefaultMBeanServerInterceptor (com.sun.jmx.interceptor)\nregisterWithRepository:1911, DefaultMBeanServerInterceptor (com.sun.jmx.interceptor)\nregisterDynamicMBean:966, DefaultMBeanServerInterceptor (com.sun.jmx.interceptor)\nregisterObject:900, DefaultMBeanServerInterceptor (com.sun.jmx.interceptor)\nregisterMBean:324, DefaultMBeanServerInterceptor (com.sun.jmx.interceptor)\nregisterMBean:522, JmxMBeanServer (com.sun.jmx.mbeanserver)\nreregister:167, JmxReporter (org.apache.kafka.common.metrics)\nmetricChange:85, JmxReporter (org.apache.kafka.common.metrics)\nregisterMetric:545, Metrics (org.apache.kafka.common.metrics)\nadd:256, Sensor (org.apache.kafka.common.metrics)\nadd:241, Sensor (org.apache.kafka.common.metrics)\nrecordTopicFetchMetrics:1291, Fetcher$FetchManagerMetrics (org.apache.kafka.clients.consumer.internals)\naccess$3200:1246, Fetcher$FetchManagerMetrics (org.apache.kafka.clients.consumer.internals)\nrecord:1230, Fetcher$FetchResponseMetricAggregator (org.apache.kafka.clients.consumer.internals)\ndrain:982, Fetcher$PartitionRecords (org.apache.kafka.clients.consumer.internals)\nnextFetchedRecord:1033, Fetcher$PartitionRecords (org.apache.kafka.clients.consumer.internals)\nfetchRecords:1095, Fetcher$PartitionRecords (org.apache.kafka.clients.consumer.internals)\naccess$1200:949, Fetcher$PartitionRecords (org.apache.kafka.clients.consumer.internals)\nfetchRecords:570, Fetcher (org.apache.kafka.clients.consumer.internals)\nfetchedRecords:531, Fetcher (org.apache.kafka.clients.consumer.internals)\npollOnce:1178, KafkaConsumer (org.apache.kafka.clients.consumer)\npoll:1111, KafkaConsumer (org.apache.kafka.clients.consumer)\nrun:699, KafkaMessageListenerContainer$ListenerConsumer (org.springframework.kafka.listener)\ncall:511, Executors$RunnableAdapter (java.util.concurrent)\nrun:266, FutureTask (java.util.concurrent)\nrun:748, Thread (java.lang)","author_login":"j0xaf","author_association":"NONE","created_at":"2018-09-26T15:05:24+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_425102772","fragment_type":"issue_comment","sequence":1,"text":"This actually is enforced by the underlying Prometheus client that Micrometer is delegating to. It's possible for distinct _processes_ to send metrics with different sets of tag keys, but Prometheus does not allow it from a single process.","author_login":"jkschneider","author_association":"CONTRIBUTOR","created_at":"2018-09-27T13:57:46+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_456672232","fragment_type":"issue_comment","sequence":2,"text":"So basically this is expected? Kafka metrics as configured by `KafkaConsumerMetrics` is incompatible with Prometheus-based registry? I'm getting\n\njava.lang.IllegalArgumentException: Prometheus requires that all meters with the same name have the same set of tag keys. There is already an existing meter named 'kafka_consumer_records_lag_records' containing tag keys [client_id, topic]. The meter you are attempting to register has keys [client_id].","author_login":"flozano","author_association":"NONE","created_at":"2019-01-23T05:09:15+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_464907442","fragment_type":"issue_comment","sequence":3,"text":"@flozano Try the latest version if you haven’t done yet as there were updates on the Kafka binder recently.","author_login":"izeye","author_association":"COLLABORATOR","created_at":"2019-02-18T22:36:47+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_594130460","fragment_type":"issue_comment","sequence":4,"text":"If the meter tags are different, could we `unregister` then `register` the meter with a combined list of tags?\n\nAlso, am I looking at the right prometheus client implementation?\n URL","author_login":"jdbranham","author_association":"NONE","created_at":"2020-03-03T19:38:39+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_606958333","fragment_type":"issue_comment","sequence":5,"text":"Hi @jdbranham, have you been able to fix or work around this? I have a similar problem that `PrometheusMeterRegistry` is in conflict with something else, but instead of `KafkaConsumerMetrics`, it's because I'm using Spring Boot actuator.\n\nIf I annotate the controller method with just @Timed() with no parameters, there is no error. However, if I use @Timed with a name argument, like this:\n\n @Timed(\"some-operation\")\n public void someOperation() {}\n\n... then it errors when someOperation() is called. Hypothesis: both Actuator and Prometheus are trying to use the annotation to create a metric (each with their own set of tags), but Prometheus requires the name be unique.\n\nStack trace:\n\njava.lang.IllegalArgumentException: Prometheus requires that all meters with the same name have the same set of tag keys. There is already an existing meter named 'some_operation_seconds' containing tag keys [class, exception, method]. The meter you are attempting to register has keys [exception, method, outcome, status, uri].\n at io.micrometer.prometheus.PrometheusMeterRegistry.lambda$collectorByName$9(PrometheusMeterRegistry.java:382) ~[micrometer-registry-prometheus-1.3.5.jar:1.3.5]\n...\norg.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.getTimer(WebMvcMetricsFilter.java:185) ~[spring-boot-actuator-2.2.5.RELEASE.jar:2.2.5.RELEASE]\n\nI've also tried to upgrade to a newer version of micrometer (1.4.1), but the result is the same.","author_login":"cschuyle","author_association":"NONE","created_at":"2020-04-01T00:30:08+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647430400","fragment_type":"issue_comment","sequence":6,"text":"A bit more information: After I looked to tweak `KafkaMetrics` this to solve my issue, I noticed it has some logic to remove and add existing metres if the tags are different (as was suggested in this thread), however it only does this if the clients are the same. In my above case the clients are different as i have multiple consumers with differing client ID, given that the remove/add logic wasn't run. The logic in question: \n URL \n\nIf I remove `if (differentClient(tags)) break;` everything appears is fine. Would like to understand the impact of this.","author_login":"KeithWoods","author_association":"NONE","created_at":"2020-06-22T10:28:25+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_651354264","fragment_type":"issue_comment","sequence":7,"text":"Okay, I am running into this issue as well.\n\nI copied and pasted the registry and modified the offending code so that it creates a new collector instead.\n\nI have written a functional test that proves that URL is no longer true.\n\n URL \n\nI have also written an integration test that proves that Prometheus can handle scraping metrics that have the same name but varying labels.\n\n URL \n\nI feel like we could easily replace\n\n URL \n\nwith\n\njava \n private MicrometerCollector collectorByName(Meter.Id id) {\n return collectorMap.compute(\n getConventionName(id),\n (name, existingCollector) -> {\n List tagKeys = getConventionTags(id).stream().map(Tag::getKey).collect(toList());\n if (existingCollector != null && existingCollector.getTagKeys().equals(tagKeys)) {\n return existingCollector;\n }\n return new MicrometerCollector(id, config().namingConvention(), prometheusConfig)\n .register(registry);\n });\n }\n\nAnd eliminate the source of this developer friction when using this registry.","author_login":"fieldju","author_association":"NONE","created_at":"2020-06-29T20:45:43+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[364078172],"is_known_query_context":false},{"document_id":"gh_comment_651356213","fragment_type":"issue_comment","sequence":8,"text":"Okay, I am running into this issue as well.\n\nI copied and pasted the registry and modified the offending code so that it creates a new collector instead.\n\nI have written a functional test that proves that URL is no longer true.\n\n URL \n\nI have also written an integration test that proves that Prometheus can handle scraping metrics that have the same name but varying labels.\n\n URL \n\nI feel like we could easily replace\n\n URL \n\nwith\n\njava \n private MicrometerCollector collectorByName(Meter.Id id) {\n return collectorMap.compute(\n getConventionName(id),\n (name, existingCollector) -> {\n List tagKeys = getConventionTags(id).stream().map(Tag::getKey).collect(toList());\n if (existingCollector != null && existingCollector.getTagKeys().equals(tagKeys)) {\n return existingCollector;\n }\n return new MicrometerCollector(id, config().namingConvention(), prometheusConfig)\n .register(registry);\n });\n }\n\nAnd eliminate the source of this developer friction when using this registry.","author_login":"fieldju","author_association":"NONE","created_at":"2020-06-29T20:48:50+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[364078172],"is_known_query_context":false},{"document_id":"gh_comment_655502154","fragment_type":"issue_comment","sequence":9,"text":"Hi, I have encountered the issue as I add some tags (like error name) basing on the result of an operation.\n \n \n \n\nI have checked Prometheus documentation and there is no information about such requirement - looks like the metric name can be associated with varying number of tags/labels:\n \nSource: URL","author_login":"dnowak-wrldrmt","author_association":"NONE","created_at":"2020-07-08T12:57:25+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_655598760","fragment_type":"issue_comment","sequence":10,"text":"Thanks for checking the documentation!\n\nUnfortunately, the underlying Prometheus client isn't implemented to that specification. See URL \n\nSo you could open a ticket with that repo to try to get it improved, or if you can think of a good way to work around that limitation that would also be welcome.","author_login":"checketts","author_association":"COLLABORATOR","created_at":"2020-07-08T15:42:07+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_693579526","fragment_type":"issue_comment","sequence":11,"text":"I got hit by this too and was baffled because I saw that `JvmMemoryMetrics` in Micrometer produces tagged metrics like:\n\njvm_memory_used_bytes{area=\"nonheap\",id=\"CodeHeap 'profiled nmethods'\",} 1.8733824E7\njvm_memory_used_bytes{area=\"heap\",id=\"G1 Survivor Space\",} 2.9360128E7\njvm_memory_used_bytes{area=\"heap\",id=\"G1 Old Gen\",} 1.1652344E7\njvm_memory_used_bytes{area=\"nonheap\",id=\"Metaspace\",} 5.4593912E7\njvm_memory_used_bytes{area=\"nonheap\",id=\"CodeHeap 'non-nmethods'\",} 1369344.0\njvm_memory_used_bytes{area=\"heap\",id=\"G1 Eden Space\",} 2.78921216E8\njvm_memory_used_bytes{area=\"nonheap\",id=\"Compressed Class Space\",} 6206336.0\njvm_memory_used_bytes{area=\"nonheap\",id=\"CodeHeap 'non-profiled nmethods'\",} 5494784.0\n\nThe trick seems to be in using builder:\n URL \n\nI tried that with `Timer` and `Counter` and it works fine.","author_login":"vladak","author_association":"NONE","created_at":"2020-09-16T18:22:58+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_694666831","fragment_type":"issue_comment","sequence":12,"text":"@vladak This is not a solution for the problem as the problem is that you change the set of labels assigned to a meter. It happens to me in two cases:\n* common tags are added to meter registry on application initialization (Spring Boot) \n`registry.config().commonTags(tags)`\n* dynamic tags calculation -> I only add `error` tag with the type of an error when an operation fails - every time I register a new meter with a set of tags that are based on the execution result.","author_login":"dnowak-wrldrmt","author_association":"NONE","created_at":"2020-09-18T05:46:17+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_694709846","fragment_type":"issue_comment","sequence":13,"text":"I see, it just shares the same symptom.\n\nDne pá 18. 9. 2020 7:46 uživatel dnowak-wrldrmt \nnapsal:","author_login":"vladak","author_association":"NONE","created_at":"2020-09-18T07:37:18+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[364078172],"is_known_query_context":false},{"document_id":"gh_comment_717177433","fragment_type":"issue_comment","sequence":14,"text":"I feel like this is a bug in Micrometer:\n\n for (Meter other : registry.find(meterName).meters()) {\n List tags = other.getId().getTags();\n // Only consider meters from the same client before filtering\n if (differentClient(tags)) break;\n if (tags.size() < meterTagsWithCommonTags.size()) registry.remove(other);\n // Check if already exists\n else if (tags.size() == meterTagsWithCommonTags.size())\n if (tags.equals(meterTagsWithCommonTags)) return;\n else break;\n else hasLessTags = true;\n }\n\nAbove is the logic to remove the meter with less tags but it's conditional on:\n\nif (differentClient(tags)) break;\n\nI'm using `ConcurrentKafkaListenerContainerFactory` from Spring Kafka that has 5 `clientIds`, therefore if first clientId happens not to match clientId being registered the removal rule doesn't work and I get instead:\n\njava.lang.IllegalArgumentException: Prometheus requires that all meters with the same name have the same set of tag keys. \nThere is already an existing meter named 'kafka_consumer_fetch_manager_fetch_size_max' containing tag keys [client_id, kafka_version, spring_id]. The meter you are attempting to register has keys [client_id, kafka_version, spring_id, topic].\n\n:grey_question: My question is, should `break` be replaced with `continue`, like this:\n\nif (differentClient(tags)) continue;\n\nI don't fully understand the logic but feel like that would allow correctly replace the meters with fewer tags. Thoughts?","author_login":"borowis","author_association":"NONE","created_at":"2020-10-27T11:27:11+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_766681697","fragment_type":"issue_comment","sequence":15,"text":"@dnowak-wrldrmt How we dealt with this in, for example, Spring Web MVC metrics is always having an `exception` tag; the value is `none` if there was no exception.\n\nI'm reopening this for some more consideration as this keeps coming up and we've made recent changes to not throw an exception anymore by default in these cases. The current state is still that the scrape will not contain metrics with different labels, though. I'm reopening to see if we can make that happen somehow.\n\nAfter some investigation into this, I will echo what @checketts said in URL that the Prometheus Java client does not seem to support this by design. That being said, it is indeed true that the Prometheus server can and will scrape metrics with different labels, with no problem as far as I can tell.\n\n@fieldju thank you for the tests. That was useful to look at. The modifications, however, are causing meters to end up as different metrics with the same name, which violates the Prometheus scrape format, even though the Prometheus server seems to have no problem scraping this.\n\nSpecifically, your modifications result in a scrape like:\n\n# HELP foo_total \n# TYPE foo_total counter\nfoo_total{hostname=\"localhost\",optionalExtraMetadata=\"my-cool-value\",} 1.0\n# HELP foo_total \n# TYPE foo_total counter\nfoo_total{hostname=\"localhost\",} 1.0\n\nThe above violates the following snippets from the Prometheus scrape format:\n \n \n\nSo my understanding is that the scrape should be like:\n\n# HELP foo_total \n# TYPE foo_total counter\nfoo_total{hostname=\"localhost\",optionalExtraMetadata=\"my-cool-value\",} 1.0\nfoo_total{hostname=\"localhost\",} 1.0\n\nTrying to register things with the Prometheus client so this happens results in the aforementioned exception. We need to find a way to properly register them, which may not be currently exist. In that case, we would need to see if the Prometheus Java client is willing to make changes to support this, as suggested by @checketts. For example, here is a pure Prometheus Java client unit test that fails trying to do what this issue asks to support:\n\njava\n@Test\nvoid promClientSameMetricNameDifferentLabels() throws IOException {\n CollectorRegistry registry = new CollectorRegistry();\n Counter counter = Counter.build().name(\"my_counter\").labelNames(\"hi\").help(\"unhelpful string\")\n .register(registry);\n Counter counter1 = Counter.build().name(\"my_counter\").labelNames(\"hello\").help(\"unhelpful string\")\n .register(registry); // fails with \"Collector already registered that provides name: my_counter\"\n\n counter.labels(\"world\").inc(2);\n counter1.labels(\"world\").inc(3);\n\n StringWriter writer = new StringWriter();\n TextFormat.write004(writer, registry.metricFamilySamples());\n System.out.println(writer.toString());\n}","author_login":"shakuzen","author_association":"COLLABORATOR","created_at":"2021-01-25T09:31:47+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[364078172],"is_known_query_context":false},{"document_id":"gh_comment_767677710","fragment_type":"issue_comment","sequence":16,"text":"I finally ran into this same problem in my own application code. Spring was configuring caches using the cacheManager so half of my caches were being registered with a `cacheManager` tag, however I had several other caches that were being registered via a different mechanism. I worked around the Prometheus limitation by adding a filter that added the extra empty tag like so:\n\nregistry.config().meterFilter(new MeterFilter() {\n @NotNull\n @Override\n public Meter.Id map(@NotNull Meter.Id id) {\n if (id.getName().startsWith(\"cache\") && id.getTag(\"cacheManager\") == null) {\n return id.withTags(Tags.of(\"cacheManager\", \"\", \"name\", \"\"));\n }\n return id;\n }\n });","author_login":"checketts","author_association":"COLLABORATOR","created_at":"2021-01-26T16:52:00+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_773380530","fragment_type":"issue_comment","sequence":17,"text":"I have 7 apps I've instrumented and I finally ran into this error on only one of them... specifically wiht \n\n`jam_gc_pause_seconds`","author_login":"jeeftor","author_association":"NONE","created_at":"2021-02-04T15:10:44+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_773401403","fragment_type":"issue_comment","sequence":18,"text":"So I came up with a workaround.\n\nI was registering an `application` tag on all my meters (I thought) but apparently the GC got instantiated prior to me actually doing this... so the fix I found was to use a `MeterRegistryCustomizer` bean:\n\njava\n @Value(\"${spring.application.name}\")\n String appName;\n\n @Bean\n MeterRegistryCustomizer metricsCommonTags() {\n return registry -> registry.config().commonTags(\"application\", appName);\n }\n\nkotlin\n @Value(\"\\${spring.application.name}\")\n val appName: String? = null\n\n @Bean\n fun metricsCommonTags(): MeterRegistryCustomizer {\n return MeterRegistryCustomizer { registry: MeterRegistry ->\n registry.config().commonTags(\"application\", appName)\n }\n }\n\nThis got my errors to go away","author_login":"jeeftor","author_association":"NONE","created_at":"2021-02-04T15:39:37+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_860269180","fragment_type":"issue_comment","sequence":19,"text":"@shakuzen I have an idea how to address this issue and curious what you think about it.\n\nSo it is not possible to register several metrics with the same name in prometheus' `io.prometheus.client.CollectorRegistry` indeed as you mentioned before.\nit checks if the name is already registered\n\njava\n public void register(Collector m) {\n List names = collectorNames(m);\n synchronized (namesCollectorsLock) {\n for (String name : names) {\n if (namesToCollectors.containsKey(name)) {\n throw new IllegalArgumentException(\"Collector already registered that provides name: \" + name);\n }\n }\n for (String name : names) {\n namesToCollectors.put(name, m);\n }\n collectorsToNames.put(m, names);\n }\n }\n\nSo it is not possible to register multiple collectors with the same metric name but why not to change the collector then?\nThe main goal of a collector is to return a list of samples\n\njava\n @Override\n public List collect() {\n /// ...\n }\n\neach sample has label keys and values, so it is possible to modify the collector to support dynamic label keys and values.\nCurrently it takes the keys in the constructor \n\nMy idea is not to store label keys in the collector and instead add them dynamically with label values like it does now.\n\nSo I've built simple PoC to verify if it makes sense, I didn't want to fork the micrometer repo and created mine. \nI copied `MeterCollector` and `PrometheusMeterRegistry`, made some small changes in them and wrote simple tests to verify if it works.\n\nThe repo URL \nMy new collector that stores label keys and values dynamically URL \n\nPrometheus output looks like this\n\n# HELP counter_total \n# TYPE counter_total counter\ncounter_total{type=\"success\",version=\"1\",} 1.0\ncounter_total{code=\"500\",type=\"error\",version=\"1\",} 1.0\n\nlet me know what you think about it, if there are any issues I've missed, and if this idea makes sense to you.","author_login":"angry-cellophane","author_association":"NONE","created_at":"2021-06-13T20:57:49+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_878131547","fragment_type":"issue_comment","sequence":20,"text":"@angry-cellophane \nThanks. Good idea. This limitation is really annoying. Hoping to see it's eliminated.","author_login":"MSDehghan","author_association":"NONE","created_at":"2021-07-12T09:42:58+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_878266421","fragment_type":"issue_comment","sequence":21,"text":"@angry-cellophane I agree this is a frustration, and I would love for it to be something that 'just works for users', however I have a continuing concern around the PromQL implications. I'm by no means a PromQL master, but my understanding is that, unlike SQL, **Prometheus automatically joins like time series, as long as all tags match**. \n\nThat means that opposite is also true: Prometheus will drop metrics that don't all match. So I'm worried about how Prometheus will treat the mis-matched tags when doing graphs and aggregations.\n\nSince that is a fundamental way that Prometheus works, they have rejected suggestions on how to work around it in the underlying data model and instead have insisted that clients publish matching tags.\n\nI don't have a specific recommendation currently, just wanted to raise the data model concerns in case others have investigated that aspect further and can offer insight.","author_login":"checketts","author_association":"COLLABORATOR","created_at":"2021-07-12T13:10:42+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_879455508","fragment_type":"issue_comment","sequence":22,"text":"@checketts \n \n\nPrometheus (the database + scraper) doesn't drop metrics, it works fine with different sets of label names and values by creating a new time series for each unique combination of key-value labels. The only downside is disk space.\nThe metrics schema is not defined upfront, labels can be added or dropped if required not impacting existing data (a new time series).\n\nPrometheus java sdk lets clients aggregate metrics in memory and return current values when Prometheus scrapes data.\n\nPrometheus java sdk provides:\n1. Collectors - an abstraction that returns metric samples when called. It's like a `java.util.function.Supplier` that returns a list of metric samples. Each sample has a list of label names and values associated with it.\n2. CollectorRegistry - collector-aggregator. It doesn't store any metrics, instead it stores other collectors and returns their results when called. It's like an iterator of iterators.\n3. Counters, gauages, histograms, summaries - pre-baked collectors, keep the current state in memory and return metrics samples when called.\n\n#2 has no restriction on label names and values\n#3 has a restriction, label names are immutable and defined when the object (e.g. a Counter) is being built. Label names cannot change after the object is built. This only applies to prometheus objects (`io.prometheus.client.Counter`, `io.prometheus.client.Gauge`, etc). \n\nSo micrometer doesn't really use #3, only #1 and #2. Every micrometer collector (e.g. `io.micrometer.core.instrument.Counter`) is registered as a collector (`io.micrometer.prometheus.MicrometerCollector`) in `CollectorRegistry`. When `CollectorRegistry` is called out, it goes through all registered collectors, calls them out and returns the result. It doesn't check label names and values, it simply returns what collectors return.\nThere's no any restriction on the prometheus side besides #3 I mentioned above but micrometer doesn't use anyway. Micrometer doesn't support different label names due to the way `io.micrometer.prometheus.MicrometerCollector` has been implemented. It makes label names immutable and label values dynamic. I raised a PR (linked to this issue) to make label names dynamic too.\n\nIf this issue is critical for anyone, you can copy the changed classes from my PR in put them in your project. I did the same about a month ago and get all metrics as expected since then.","author_login":"angry-cellophane","author_association":"NONE","created_at":"2021-07-13T22:48:29+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_879875784","fragment_type":"issue_comment","sequence":23,"text":"@angry-cellophane Sorry, using the word 'drop' was confusing, you are correct that the SDK, Scraping, and Prometheus storage won't drop the unmatched metrics. \n\nI was referring to how PromQL queries work. I have a feeling (though my understand is incomplete) that PromQL queries will exclude some metrics from calculations when labels don't match, requiring a user to use the `without` or `by` to get a complete result.\n\nIf you have done any work in regards to ensuring that PromQL queries make sense when the underlying meter labels aren't all aligned, I would love to hear about your methods and approach.","author_login":"checketts","author_association":"COLLABORATOR","created_at":"2021-07-14T13:07:26+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_880999397","fragment_type":"issue_comment","sequence":24,"text":"@checketts it depends on the query and how it groups data but generally no issue. Prometheus creates a separate time series for each unique combination of key-labels.\nThe user, who writes prom queries, need to keep in mind that there's more than 1 set of label names and that's it.\n\nSome simple examples:\n\nmetrics\n\n# HELP responses\n# TYPE app_responses counter\napp_responses{uri=\"/\", outcome=\"SUCCESS\", clientId=\"123\"} 10\napp_responses{uri=\"/\", outcome=\"SUCCESS\", clientId=\"456\"} 5\napp_responses{uri=\"/\", outcome=\"FAILURE\", error=\"INVALID_REQUEST\", clientId=\"123\"} 2\napp_responses{uri=\"/\", outcome=\"FAILURE\", error=\"DATA_NOT_FOUND\", clientId=\"456\"} 3\n\n \n\n1. Percent of failed requests in past 10 mins\n`sum(increase(app_responses{outcome=\"FAILURE\"}[10m])) / sum(increase(app_responses[10m]))` returns 0.25 as expected\n\n2. For each error to show its percent of all requests in past 10 mins. \n`sum(increase(app_responses{outcome=\"FAILURE\"}[10m])) by (error) / ignoring(error) group_left sum(increase(app_responses[10m]))` returns 0.1 and 0.15 as expected.","author_login":"angry-cellophane","author_association":"NONE","created_at":"2021-07-15T20:41:44+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_881038410","fragment_type":"issue_comment","sequence":25,"text":"seems like my PR with the fix got stuck. For anyone, who's eager to try the fix, I created an example of how it can be used, you'll need to copy two classes into your project URL","author_login":"angry-cellophane","author_association":"NONE","created_at":"2021-07-15T21:57:49+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_920145996","fragment_type":"issue_comment","sequence":26,"text":"I've opened URL in the repository for the official Java client for Prometheus to get some input from the Prometheus experts on this.","author_login":"shakuzen","author_association":"MEMBER","created_at":"2021-09-15T15:55:06+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_944894069","fragment_type":"issue_comment","sequence":27,"text":"Note that the observed behavior is that when adding new meters with the same name but differing in the _keys_ (number or name) of the Tags, the later registrations are ignored. When only the _value_ of the Tags are changed, it works correctly. Therefore, a \"fix\" is to make both sets of meters (having the same name) also have the same set of Tags, where the irrelevant tags of each subset having a fixed dummy value.","author_login":"stolsvik","author_association":"NONE","created_at":"2021-10-16T10:27:58+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1531305180","fragment_type":"issue_comment","sequence":28,"text":"this issue keeps coming back, not only in kafka but for example in micrometer apache client interceptor(async instrumentation) + executor (sync instrumentation)- if you use both, you get slightly different set of tags (sync version includes \"outcome\", async version does not), and your async metrics are gone.","author_login":"flozano","author_association":"NONE","created_at":"2023-05-02T11:27:40+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1727297553","fragment_type":"issue_comment","sequence":29,"text":"Thanks @stolsvik! With your input I at least have a workaround.","author_login":"rdehuyss","author_association":"NONE","created_at":"2023-09-20T09:08:45+08:00","repo_name":"micrometer-metrics/micrometer","issue_id":364078172,"issue_number":877,"issue_url":"https://github.com/micrometer-metrics/micrometer/issues/877","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0164","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"New warnings on non-editable build?","query_context":"@bryevdv does anything look concerning?\n\n -- Installing: /home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-install/lib/liblegion_canonical_python.so\n '/home/mpapadakis/noneditable/env/bin/python3' '-m' 'pip' 'install' '--global-option=--cmake-build-dir' '--global-option=/home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-build/_deps/legion-build/runtime' '--global-option=--prefix' '--global-option=/home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-install' '--ignore-installed' '--root' '/' '--prefix' '/home/mpapadakis/noneditable/env' '.'\n DEPRECATION: --build-option and --global-option are deprecated. pip 24.0 will enforce this behaviour change. A possible replacement is to use --config-settings. Discussion can be found at URL \n WARNING: Implying --no-binary=:all: due to the presence of --build-option / --global-option.\n\n /home/mpapadakis/noneditable/env/lib/python3.10/site-packages/setuptools/command/build_py.py:204: _Warning: Package 'legate.core._lib' is absent from the `packages` configuration.\n !!\n\n ********************************************************************************\n ############################\n # Package would be ignored #\n ############################\n Python recognizes 'legate.core._lib' as an importable package[^1],\n but it is absent from setuptools' `packages` configuration.\n\n This leads to an ambiguous overall configuration. If you want to distribute this\n package, please make sure that 'legate.core._lib' is explicitly added\n to the `packages` configuration field.\n\n Alternatively, you can also rely on setuptools' discovery methods\n (for example by using `find_namespace_packages(...)`/`find_namespace:`\n instead of `find_packages(...)`/`find:`).\n\n You can read more about \"package discovery\" on setuptools documentation page:\n\n - URL \n\n If you don't want 'legate.core._lib' to be distributed and are\n already explicitly excluding 'legate.core._lib' via\n `find_namespace_packages(...)/find_namespace` or `find_packages(...)/find`,\n you can try to use `exclude_package_data`, or `include-package-data=False` in\n combination with a more fine grained `package-data` configuration.\n\n You can read more about \"package data files\" on setuptools documentation page:\n\n - URL \n\n [^1]: For Python, any directory (with suitable naming) can be imported,\n even if it does not contain any `.py` files.\n On the other hand, currently there is no concept of package data\n directory, all directories are treated like packages.\n ********************************************************************************\n\n !!\n\nWARNING: There was an error checking the latest version of pip.\nSee below for error\nTraceback (most recent call last):\n File \"/home/mpapadakis/noneditable/env/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py\", line 227, in pip_self_version_check\n upgrade_prompt = _self_version_check_logic(\n File \"/home/mpapadakis/noneditable/env/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py\", line 188, in _self_version_check_logic\n remote_version_str = state.get(current_time)\n File \"/home/mpapadakis/noneditable/env/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py\", line 76, in get\n last_check = datetime.datetime.fromisoformat(self._state[\"last_check\"])\nValueError: Invalid isoformat string: '2023-08-30T23:44:26Z'","known_context_document_ids":["gh_issue_1946202985"],"reference_answer":"As a workaround, setting a `PIP_DISABLE_PIP_VERSION_CHECK=1` environment variable may help.","answer_document_id":"gh_comment_1765844404","silver_evidence_path":["gh_comment_1766763976","gh_issue_1944100772","gh_comment_1765844404"],"evidence_issue_ids":[1946202985,1944100772],"source_repo_name":"nv-legate/legate.core","source_issue_id":1946202985,"source_issue_number":862,"source_issue_url":"https://github.com/nv-legate/legate.core/issues/862","target_repo_name":"pypa/pip","target_issue_id":1944100772,"target_issue_number":12357,"target_issue_url":"https://github.com/pypa/pip/issues/12357","reference_anchor_document_id":"gh_comment_1766763976","reference_answer_author":"sbidoul","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.2941,"target_answer_overlap":0.0},"issue_created_at":"2023-10-16T22:27:28+08:00","valid_comment_count":27,"fragments":[{"document_id":"gh_issue_1946202985","fragment_type":"issue_description","sequence":0,"text":"New warnings on non-editable build\n@bryevdv does anything look concerning?\n\n -- Installing: /home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-install/lib/liblegion_canonical_python.so\n '/home/mpapadakis/noneditable/env/bin/python3' '-m' 'pip' 'install' '--global-option=--cmake-build-dir' '--global-option=/home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-build/_deps/legion-build/runtime' '--global-option=--prefix' '--global-option=/home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-install' '--ignore-installed' '--root' '/' '--prefix' '/home/mpapadakis/noneditable/env' '.'\n DEPRECATION: --build-option and --global-option are deprecated. pip 24.0 will enforce this behaviour change. A possible replacement is to use --config-settings. Discussion can be found at URL \n WARNING: Implying --no-binary=:all: due to the presence of --build-option / --global-option.\n\n /home/mpapadakis/noneditable/env/lib/python3.10/site-packages/setuptools/command/build_py.py:204: _Warning: Package 'legate.core._lib' is absent from the `packages` configuration.\n !!\n\n ********************************************************************************\n ############################\n # Package would be ignored #\n ############################\n Python recognizes 'legate.core._lib' as an importable package[^1],\n but it is absent from setuptools' `packages` configuration.\n\n This leads to an ambiguous overall configuration. If you want to distribute this\n package, please make sure that 'legate.core._lib' is explicitly added\n to the `packages` configuration field.\n\n Alternatively, you can also rely on setuptools' discovery methods\n (for example by using `find_namespace_packages(...)`/`find_namespace:`\n instead of `find_packages(...)`/`find:`).\n\n You can read more about \"package discovery\" on setuptools documentation page:\n\n - URL \n\n If you don't want 'legate.core._lib' to be distributed and are\n already explicitly excluding 'legate.core._lib' via\n `find_namespace_packages(...)/find_namespace` or `find_packages(...)/find`,\n you can try to use `exclude_package_data`, or `include-package-data=False` in\n combination with a more fine grained `package-data` configuration.\n\n You can read more about \"package data files\" on setuptools documentation page:\n\n - URL \n\n [^1]: For Python, any directory (with suitable naming) can be imported,\n even if it does not contain any `.py` files.\n On the other hand, currently there is no concept of package data\n directory, all directories are treated like packages.\n ********************************************************************************\n\n !!\n\nWARNING: There was an error checking the latest version of pip.\nSee below for error\nTraceback (most recent call last):\n File \"/home/mpapadakis/noneditable/env/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py\", line 227, in pip_self_version_check\n upgrade_prompt = _self_version_check_logic(\n File \"/home/mpapadakis/noneditable/env/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py\", line 188, in _self_version_check_logic\n remote_version_str = state.get(current_time)\n File \"/home/mpapadakis/noneditable/env/lib/python3.10/site-packages/pip/_internal/self_outdated_check.py\", line 76, in get\n last_check = datetime.datetime.fromisoformat(self._state[\"last_check\"])\nValueError: Invalid isoformat string: '2023-08-30T23:44:26Z'","author_login":"manopapad","author_association":"CONTRIBUTOR","created_at":"2023-10-16T22:27:28+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1765466035","fragment_type":"issue_comment","sequence":1,"text":"Based on some replies at URL and URL it seems like this might be a current workaround:\n\n --config-setting=\"--global-option=--verbose\" .\n\nwhich seems pretty unpleasant but at a glance at least it doesn't look like there would be any delicate quoting issues. \n\nI guess a longer term solution would be to try to switch to use `build` instead, but I am not sure up front how involved that would be.","author_login":"bryevdv","author_association":"CONTRIBUTOR","created_at":"2023-10-17T00:22:07+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1765467330","fragment_type":"issue_comment","sequence":2,"text":"This seem like maybe just a change to `find_packages` config, e.g. just add `legate.core._lib`. Right now there is a wildcard but maybe that does not (or recently does not) include \"private\" underscore dirs by default (speculation at this point)","author_login":"bryevdv","author_association":"CONTRIBUTOR","created_at":"2023-10-17T00:23:57+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766763976","fragment_type":"issue_comment","sequence":3,"text":"@manopapad regarding the error from the datetime check in `pip`, this comment suggests setting `PIP_DISABLE_PIP_VERSION_CHECK=1` as an immediate workaround (and also maybe a good setting for CI environments in any case)","author_login":"bryevdv","author_association":"CONTRIBUTOR","created_at":"2023-10-17T16:26:27+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[1944100772],"is_known_query_context":false},{"document_id":"gh_comment_1766799431","fragment_type":"issue_comment","sequence":4,"text":"Regarding the `global-option` I don't see where we are setting that ourselves anywhere, and it looks like the immediate preceding command is \n\n [220/221] cd /home/mpapadakis/noneditable/legate.core/_skbuild/linux-x86_64-3.10/cmake-build && /home/mpapadakis/noneditable/env/bin/cmake -P cmake_install.cmake\n\nso I suspect this issue may actually originating in scikit-build","author_login":"bryevdv","author_association":"CONTRIBUTOR","created_at":"2023-10-17T16:46:25+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766855751","fragment_type":"issue_comment","sequence":5,"text":"No, AFAIK these should all be used exclusively by cython. \n \n\nDo you mind making a PR with this, and asking @Jacobfaib to verify it's good?\n \n\nPresumably the bug has been fixed URL so I'm inclined to just leave this alone.","author_login":"manopapad","author_association":"CONTRIBUTOR","created_at":"2023-10-17T17:24:09+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[1944100772],"is_known_query_context":false},{"document_id":"gh_comment_1769000475","fragment_type":"issue_comment","sequence":6,"text":"You're right, here it is URL \n\nIf you know how to fix this, can you please submit a PR against Legion?","author_login":"manopapad","author_association":"CONTRIBUTOR","created_at":"2023-10-18T17:20:01+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1769060163","fragment_type":"issue_comment","sequence":7,"text":"I've already been looking at a few different approached but unfortunately no success yet, the build dir is not getting communicated and results in a compilation error for a missing header","author_login":"bryevdv","author_association":"CONTRIBUTOR","created_at":"2023-10-18T17:58:25+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1769117632","fragment_type":"issue_comment","sequence":8,"text":"I have tried a bunch of various incantations with `--config-settings` but none have worked. AFAICT it comes down to this bit inside `legion/bindings/python/setup.py`\n\npython\n# Hack: I can't get initialize/finalize_option to work, so just parse\n# the arguments here...\nparser = argparse.ArgumentParser()\nparser.add_argument('--cmake-build-dir', required=False)\nparser.add_argument('--prefix', required=False)\nargs, unknown = parser.parse_known_args()\nsys.argv[1:] = unknown\n\n*What I think the case is*: to the extent that `--config-setting` can be used to tunnel `--global-setting` through to `setuptools`, that *won't happen via command line options* to an actually invoked-as-script `setup.py` (i.e. handling `sys.argv` here would no longer be effective). \n\nprinting `sys.argv` in the the `setup.py` seems to confirm this:\n\n ['setup.py', 'bdist_wheel', '--dist-dir', '/tmp/pip-wheel-4nb3s7fa/.tmp-i2j3txai']\n\nOne way to work around this would be to rely on env vars instead of command line options. This is actually what the folks on DPO Packaging advised me on another project in the last year. But before embarking on that, I guess I'd like to know if there is any expected movement on larger efforts, i.e. IIRC there was some talk of switching legion to `scikit-build` or something.","author_login":"bryevdv","author_association":"CONTRIBUTOR","created_at":"2023-10-18T18:40:24+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1769751242","fragment_type":"issue_comment","sequence":9,"text":"There is an ongoing discussion about transitioning Legion to a more standards-compliant build workflow URL so let's hold off on doing drastic changes.\n\nIn that case, I think all the warnings have been sufficiently addressed (or punted), so I'll close this.","author_login":"manopapad","author_association":"CONTRIBUTOR","created_at":"2023-10-19T01:35:08+08:00","repo_name":"nv-legate/legate.core","issue_id":1946202985,"issue_number":862,"issue_url":"https://github.com/nv-legate/legate.core/issues/862","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1944100772","fragment_type":"issue_description","sequence":0,"text":"Warning \"There was an error checking the latest version of pip\"\n### Description\n\nPip issues the warning message \"WARNING: There was an error checking the latest version of pip\" when running \"pip list -o\" on Python 3.10 running inside Windows 11.\n\nIf I run \"pip list -o -vv\", the following stack trace is generated:\n\nSee below for error\nTraceback (most recent call last):\n File \"C:\\Development\\Data_Science\\Projects\\semantic_qa\\venv\\lib\\site-packages\\pip\\_internal\\self_outdated_check.py\", line 227, in pip_self_version_check\n upgrade_prompt = _self_version_check_logic(\n File \"C:\\Development\\Data_Science\\Projects\\semantic_qa\\venv\\lib\\site-packages\\pip\\_internal\\self_outdated_check.py\", line 188, in _self_version_check_logic\n remote_version_str = state.get(current_time)\n File \"C:\\Development\\Data_Science\\Projects\\semantic_qa\\venv\\lib\\site-packages\\pip\\_internal\\self_outdated_check.py\", line 76, in get\n last_check = datetime.datetime.fromisoformat(self._state[\"last_check\"])\nValueError: Invalid isoformat string: '2023-10-12T09:17:22Z'\n\nMight this be the underlying cause?\n URL \n\n### Expected behavior\n\nNo warning message appears\n\n### pip version\n\n23.3\n\n### Python version\n\n3.10\n\n### OS\n\nWindows 11\n\n### How to Reproduce\n\n1. In Windows, create and activate a new virtualenv\n2. Upgrade pip to version 23.3 running \"python.exe -m pip install pip==23.3\"\n3. Run \"pip list -o\" and get the WARNING: There was an error checking the latest version of pip.\n4. Run \"pip list -o -vv\" and get the warning, plus the stack trace\n\n### Output\n\nWARNING: There was an error checking the latest version of pip.\nSee below for error\nTraceback (most recent call last):\n File \"C:\\Development\\test_pip\\venv\\lib\\site-packages\\pip\\_internal\\self_outdated_check.py\", line 227, in pip_self_version_check\n upgrade_prompt = _self_version_check_logic(\n File \"C:\\Development\\test_pip\\venv\\lib\\site-packages\\pip\\_internal\\self_outdated_check.py\", line 188, in _self_version_check_logic\n remote_version_str = state.get(current_time)\n File \"C:\\Development\\test_pip\\venv\\lib\\site-packages\\pip\\_internal\\self_outdated_check.py\", line 76, in get\n last_check = datetime.datetime.fromisoformat(self._state[\"last_check\"])\nValueError: Invalid isoformat string: '2023-10-15T23:25:56Z'\n\n### Code of Conduct\n\n- [X] I agree to follow the PSF Code of Conduct.","author_login":"jgbustos","author_association":"NONE","created_at":"2023-10-15T23:29:26+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763820954","fragment_type":"issue_comment","sequence":1,"text":"I can confirm this, I upgraded to pip 23.3 this morning, and get the same log with `pip -o -vv`:\n\nWARNING: There was an error checking the latest version of pip.\nSee below for error\nTraceback (most recent call last):\n File \"/home/steffen/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py\", line 227, in pip_self_version_check\n upgrade_prompt = _self_version_check_logic(\n File \"/home/steffen/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py\", line 188, in _self_version_check_logic\n remote_version_str = state.get(current_time)\n File \"/home/steffen/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py\", line 76, in get\n last_check = datetime.datetime.fromisoformat(self._state[\"last_check\"])\nValueError: Invalid isoformat string: '2023-10-10T08:32:05Z'","author_login":"SteffenBauer","author_association":"NONE","created_at":"2023-10-16T06:37:23+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763845870","fragment_type":"issue_comment","sequence":2,"text":"This is due to #12006 and was apparently discussed in the PR.","author_login":"sbidoul","author_association":"MEMBER","created_at":"2023-10-16T06:56:33+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763927363","fragment_type":"issue_comment","sequence":3,"text":"I'm assigning this to 23.3 to keep track of it as an issue caused by the release. This does not mean I intent to do a patch release for this at this point.","author_login":"sbidoul","author_association":"MEMBER","created_at":"2023-10-16T07:54:25+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1764043631","fragment_type":"issue_comment","sequence":4,"text":"Hi folks. Please don't add \"me too\" style comments here. If you are affected by this issue, add a 👍🏽 reaction to the first comment.","author_login":"pradyunsg","author_association":"MEMBER","created_at":"2023-10-16T09:06:41+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1764865483","fragment_type":"issue_comment","sequence":5,"text":"Another case this error happens but isn't described here is when you downgrade from 23.3 to 23.2.1.\n\nWhich I had to do today to test an issue I am facing today to see if it's the Pip upgrade or something else, and reading the PR I predicted would be an issue.","author_login":"notatallshaw","author_association":"CONTRIBUTOR","created_at":"2023-10-16T16:37:51+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1765320096","fragment_type":"issue_comment","sequence":6,"text":"Also, just a pedantic suggestion... If it is a warning, do not put \"error\" in the message.\nI do some error detection when installing Python packages and the \"error\" text in the warning caused other issues.","author_login":"SoftologyPro","author_association":"NONE","created_at":"2023-10-16T21:39:02+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1765842065","fragment_type":"issue_comment","sequence":7,"text":"Our team is also facing issues due to this, our CICD pipelines are failing. We have to downgrade pip for reasons but when we do, it throws that error message when we are using devops ubuntu agent.\nEven when I tried to pin the version to 23.0.1 both in Devops agent and in our \"requirements.txt\" to install for our internal library, I faced this error message (which is strange as this approach worked when I tried it locally):\nimage","author_login":"Arisukun","author_association":"NONE","created_at":"2023-10-17T07:39:04+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1765844404","fragment_type":"issue_comment","sequence":8,"text":"As a workaround, setting a `PIP_DISABLE_PIP_VERSION_CHECK=1` environment variable may help.","author_login":"sbidoul","author_association":"MEMBER","created_at":"2023-10-17T07:40:43+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766319616","fragment_type":"issue_comment","sequence":9,"text":"I would recommend in CI/CD pipelines anyway, the chance of this failing is non-zero and not useful when it does.\n\nI think, although haven't checked specifically, the issue when you downgrade is the new datetime format is trying to be parsed by the old parsing logic. I believe running `pip cache purge` will delete the offending cached version but obviously cleans everything else, you can also go into the Pip cache directory and manually delete the JSON file.","author_login":"notatallshaw","author_association":"CONTRIBUTOR","created_at":"2023-10-17T12:29:12+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766680555","fragment_type":"issue_comment","sequence":10,"text":"Thanks, this worked for now as a workaround at least to unblock pipelines.","author_login":"Arisukun","author_association":"NONE","created_at":"2023-10-17T15:40:18+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1767050283","fragment_type":"issue_comment","sequence":11,"text":"Another workaround is to delete the pip cache - on Linux this is in `~/.cache/pip`. Pip 23.3 works fine with no warning after you do this.","author_login":"owainkenwayucl","author_association":"NONE","created_at":"2023-10-17T19:38:21+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1767789699","fragment_type":"issue_comment","sequence":12,"text":"As there are several easy workarounds I'm not rushing a patch release.\n\nI plan to do one after the fix for #12361 has landed.","author_login":"sbidoul","author_association":"MEMBER","created_at":"2023-10-18T06:55:29+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1770989768","fragment_type":"issue_comment","sequence":13,"text":"You can use `pip cache info` to get details and `pip cache purge` to clear the cache, no need to hunt for the location 🙂","author_login":"merwok","author_association":"NONE","created_at":"2023-10-19T13:27:28+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771612840","fragment_type":"issue_comment","sequence":14,"text":"`pip cache purge` doesn't completely purge my pip cache:\n\nubuntu@raspberrypi1:~$ pip cache purge\nFiles removed: 208\nubuntu@raspberrypi1:~$ ls -la ~/.cache/pip/\ndrwxrwxr-x - ubuntu 8 Aug 2021 http\ndrwxrwxr-x - ubuntu 16 Oct 09:17 http-v2\ndrwxrwxr-x - ubuntu 13 Oct 17:27 selfcheck\ndrwxrwxr-x - ubuntu 10 Sep 14:22 wheels\n\nHowever, `rm -rf ~/.cache/pip` did completely purge the cache and it also fixed the pip version check warning (error).","author_login":"derekmahar","author_association":"NONE","created_at":"2023-10-19T19:51:35+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771714845","fragment_type":"issue_comment","sequence":15,"text":"FWIW, the targeted cleanup step here is to delete the selfcheck directory within the cache.\n\nrm -r $(pip cache dir)/selfcheck","author_login":"pradyunsg","author_association":"MEMBER","created_at":"2023-10-19T21:13:40+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771721096","fragment_type":"issue_comment","sequence":16,"text":"The underlying issue is that a key-value pair in a JSON object, placed in a JSON file in that directory contains a value that can't be parsed by this version of pip, when generated by a sufficiently old version.\n\nDeleting the directory removes specifically the problematic files, which resolves this issue.","author_login":"pradyunsg","author_association":"MEMBER","created_at":"2023-10-19T21:19:33+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771725213","fragment_type":"issue_comment","sequence":17,"text":"I think I can guess the reason. The state file in the selfcheck directory must have contained an \"invalid\" ISO date and time format that included a trailing Z time zone.\n\nI no longer have a copy of the old selfcheck state file, but the new state file contains an ISO date and time format that has a trailing \"+00:00\" time zone that Python 3.10 can interpret:\n\nubuntu@raspberrypi1:~$ \\cat ~/.cache/pip/selfcheck/241e69162522ccf5846a2f42ebc24b17464915a155679666b89a9f31\n{\"key\":\"/usr\",\"last_check\":\"2023-10-19T19:47:38.472420+00:00\",\"pypi_version\":\"23.3\"}","author_login":"derekmahar","author_association":"NONE","created_at":"2023-10-19T21:22:56+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1782779978","fragment_type":"issue_comment","sequence":18,"text":"Hi All , try below command . replace package name with required package\n\npip install xxx -vv --disable-pip-version-check --no-cache-dir --trusted-host pypi.org --trusted-host files.pythonhosted.org","author_login":"shubhamsaraf26","author_association":"NONE","created_at":"2023-10-27T11:49:09+08:00","repo_name":"pypa/pip","issue_id":1944100772,"issue_number":12357,"issue_url":"https://github.com/pypa/pip/issues/12357","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0165","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Hot Water Service Red Pipe?","query_context":"The res Hot water pipe was leaking and Greg Hall cut the leaky bit off (about 35mm) and re-joined it.\nAs a result the shortened pipework was not able to be re-fixed to the adjacent panel.\nThe red pipe should be either replaced or otherwise re-fixed to the adjacent panel. See Pics\n\nHWS N3 1\nHWS N3 2","known_context_document_ids":["gh_issue_1441475677"],"reference_answer":"Problem fixed. Several attempts at repair resulted in a very short tube, which split during Peter Wain's booking \nCompression supports were inserted into old 2' length and reinserted. After a couple of attempts, the connector sealed and leaks were no longer present. A day so far with no leakage. \nIssue CLOSED.","answer_document_id":"gh_comment_1903691712","silver_evidence_path":["gh_comment_1901714744","gh_issue_1185415812","gh_comment_1903691712"],"evidence_issue_ids":[1441475677,1185415812],"source_repo_name":"CanberraOceanRacingClub/namadgi3","source_issue_id":1441475677,"source_issue_number":583,"source_issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/583","target_repo_name":"CanberraOceanRacingClub/namadgi3","target_issue_id":1185415812,"target_issue_number":522,"target_issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","reference_anchor_document_id":"gh_comment_1901714744","reference_answer_author":"pcbaston","reference_answer_author_association":"COLLABORATOR","quality_score":78.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2,"target_answer_overlap":0.0},"issue_created_at":"2022-11-09T06:39:10+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1441475677","fragment_type":"issue_description","sequence":0,"text":"Hot Water Service Red Pipe\nThe res Hot water pipe was leaking and Greg Hall cut the leaky bit off (about 35mm) and re-joined it.\nAs a result the shortened pipework was not able to be re-fixed to the adjacent panel.\nThe red pipe should be either replaced or otherwise re-fixed to the adjacent panel. See Pics\n\nHWS N3 1\nHWS N3 2","author_login":"delcosta","author_association":"NONE","created_at":"2022-11-09T06:39:10+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1441475677,"issue_number":583,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/583","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1308281953","fragment_type":"issue_comment","sequence":1,"text":"See that the junction is held in place with a bit of cardboard.","author_login":"delcosta","author_association":"NONE","created_at":"2022-11-09T06:39:54+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1441475677,"issue_number":583,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/583","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353927516","fragment_type":"issue_comment","sequence":2,"text":"These connectors are held in under pressure. They are designed to be kept straight (enter with no bends). Bending the pipe at the connector will allow leakage to occur. I had the privilege of fixing a leak nearby this location in the blue (cold water) line. \nR-All pipes should be long enough to be supported and restrained near the connections to prevent movement.","author_login":"pcbaston","author_association":"COLLABORATOR","created_at":"2022-12-16T00:17:18+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1441475677,"issue_number":583,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/583","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1901714744","fragment_type":"issue_comment","sequence":3,"text":"Issue now duplicated by (and is relevant to) #522 -- closing this issue","author_login":"smr547","author_association":"CONTRIBUTOR","created_at":"2024-01-20T03:30:12+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1441475677,"issue_number":583,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/583","linked_issue_ids":[1185415812],"is_known_query_context":false},{"document_id":"gh_issue_1185415812","fragment_type":"issue_description","sequence":0,"text":"Water leak near hot water unit -- system depressurised\nPersistent spray from inlet pipe. This may explain the periodic unexpected operation of the cold water pressure pump.\nIMG-0145\nIMG-0144","author_login":"smr547","author_association":"CONTRIBUTOR","created_at":"2022-03-29T21:08:26+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1369429058","fragment_type":"issue_comment","sequence":1,"text":"This problem has not been observed in several months. We will leave the issue open for regular checking.","author_login":"smr547","author_association":"CONTRIBUTOR","created_at":"2023-01-03T06:20:18+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1534039819","fragment_type":"issue_comment","sequence":2,"text":"Piping repaired/replaced. Refer Issue #680 for more details.\nIssue CLOSED.","author_login":"pcbaston","author_association":"COLLABORATOR","created_at":"2023-05-04T03:27:26+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1901714034","fragment_type":"issue_comment","sequence":3,"text":"Hi @pcbaston \n\nUnfortunately this problem has happened again to @pjwain. Just yesterday water water was found spraying from a leak near the hot water system and, once again, there has been minor flooding of fresh water into under floor compartments. The pressurised water system is now out of actions. \n\nIn previous posts @delcosta and yourself have suggested ways of fixing the problem including re-plumbing the system, keeping lines long, fixing pipes to bulkhead to ensure that they do not vibrate and are maintained in proper alignment with the fitting. \n\nIn recent weeks @allister-polkinghorne has had to fix an leak in the same area and has recent relevant experience. Once again by trimming the split end and refitting. Yesterdays fault appeared to be the short, blind, blue drain hose which is now only 100mm long. This was the same pipe that leaked for Allister.\n\nCould we all please workshop a permanent solution to this problem? Chris Smith, our new found plumber, is on standby to work on this problem in the week after Australia Day if we don't fix it in the meantime. If we do proceed with Chris, he will need instructions. @SamMcDonald2538 knows an excellent plumber who might be able to help us while the boat is in Bateman's bay.\n\nnoting that issues #680 #522 #426 #583 #748 are records of this problem repeating itself. All these issues have relevant and productive comments.\n\nMaking this priority 1 as it is damaging the boat and spoiling peoples time on it.\n\n@CORCpete will be interested not only because he has an upcoming booking.","author_login":"smr547","author_association":"CONTRIBUTOR","created_at":"2024-01-20T03:27:26+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[1185415812],"is_known_query_context":false},{"document_id":"gh_comment_1901779030","fragment_type":"issue_comment","sequence":4,"text":"Interesting that the drain hose fitting is really the only problem child.\nPerhaps it's the fitting or seal that needs replacing. 15mm diam from\nmemory, unlike RV stuff that's only 10mm. Found a shop in QBYN that only\nsells online, but offers pickup previously for spare pipe I took to NZ.\nMight be worth a look.\n\nHere's the link to part:\n URL \n$12.\nI thought I also bought the cheap cutter previously to avoid frayed edges\nthat lead to leaks.....\n\nPaul Baston\n\nOn Sat, 20 Jan 2024, 14:27 Steven Ring, ***@***.***> wrote:","author_login":"pcbaston","author_association":"COLLABORATOR","created_at":"2024-01-20T06:15:55+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[1185415812],"is_known_query_context":false},{"document_id":"gh_comment_1901860805","fragment_type":"issue_comment","sequence":5,"text":"I had a closer look this afternoon and the leak appears to be in the short\npipe itself, about half way along its length, not at the connector. Peter W.\n\nOn Sat, 20 Jan 2024, 5:16 pm Paul Baston, ***@***.***> wrote:","author_login":"pjwain","author_association":"NONE","created_at":"2024-01-20T07:33:04+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[1185415812],"is_known_query_context":false},{"document_id":"gh_comment_1903691712","fragment_type":"issue_comment","sequence":6,"text":"Problem fixed. Several attempts at repair resulted in a very short tube, which split during Peter Wain's booking \nCompression supports were inserted into old 2' length and reinserted. After a couple of attempts, the connector sealed and leaks were no longer present. A day so far with no leakage. \nIssue CLOSED.","author_login":"pcbaston","author_association":"COLLABORATOR","created_at":"2024-01-22T10:30:11+08:00","repo_name":"CanberraOceanRacingClub/namadgi3","issue_id":1185415812,"issue_number":522,"issue_url":"https://github.com/CanberraOceanRacingClub/namadgi3/issues/522","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0166","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Elasticsearch crashes/dumps core on Apple M4 Processor?","query_context":"(Confirmed with at least M4 Max - possibly affecting other M4s and maybe other M series)\n\nRoot issue is this: URL \n\nConfirmed a fix with a student that adding the following to `/etc/default/elasticsearch` seems to work, allowing elasticsearch to start:\n\nES_JAVA_OPTS=-XX:UseSVE=0\nCLI_JAVA_OPTS=-XX:UseSVE=0\n\nI also confirmed the above options do not PREVENT the service from starting on an M2 Max. So it's possible this is an acceptable fix for the ARM VM, but we'll need more testing before shipping a change.","known_context_document_ids":["gh_issue_2895590263"],"reference_answer":"Hello - this is a known issue. running `sudo sof-elk_update.sh` will address it - see URL","answer_document_id":"gh_comment_2604044888","silver_evidence_path":["gh_comment_2854738707","gh_issue_2800151821","gh_comment_2604044888"],"evidence_issue_ids":[2895590263,2800151821],"source_repo_name":"philhagen/sof-elk","source_issue_id":2895590263,"source_issue_number":362,"source_issue_url":"https://github.com/philhagen/sof-elk/issues/362","target_repo_name":"philhagen/sof-elk","target_issue_id":2800151821,"target_issue_number":351,"target_issue_url":"https://github.com/philhagen/sof-elk/issues/351","reference_anchor_document_id":"gh_comment_2854738707","reference_answer_author":"philhagen","reference_answer_author_association":"OWNER","quality_score":86.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.1538,"target_answer_overlap":0.1111},"issue_created_at":"2025-03-04T22:26:34+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2895590263","fragment_type":"issue_description","sequence":0,"text":"Elasticsearch crashes/dumps core on Apple M4 Processor\n(Confirmed with at least M4 Max - possibly affecting other M4s and maybe other M series)\n\nRoot issue is this: URL \n\nConfirmed a fix with a student that adding the following to `/etc/default/elasticsearch` seems to work, allowing elasticsearch to start:\n\nES_JAVA_OPTS=-XX:UseSVE=0\nCLI_JAVA_OPTS=-XX:UseSVE=0\n\nI also confirmed the above options do not PREVENT the service from starting on an M2 Max. So it's possible this is an acceptable fix for the ARM VM, but we'll need more testing before shipping a change.","author_login":"philhagen","author_association":"OWNER","created_at":"2025-03-04T22:26:34+08:00","repo_name":"philhagen/sof-elk","issue_id":2895590263,"issue_number":362,"issue_url":"https://github.com/philhagen/sof-elk/issues/362","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2854285523","fragment_type":"issue_comment","sequence":1,"text":"Hello there! I have the same issue also on M4 Pro and I can confirm the fix mentioned there is working. Anyway I have find out also issue with ssh service which I'm not able to make it works. I'm commenting here as I think the ARM version is kinda buggy.","author_login":"Jurkiseczek","author_association":"NONE","created_at":"2025-05-06T11:50:56+08:00","repo_name":"philhagen/sof-elk","issue_id":2895590263,"issue_number":362,"issue_url":"https://github.com/philhagen/sof-elk/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2854738707","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the confirmation! This is super helpful. I suspect the SSH issue is fixed upstream but documented in #351. Updating the VM will correct that error.","author_login":"philhagen","author_association":"OWNER","created_at":"2025-05-06T14:13:59+08:00","repo_name":"philhagen/sof-elk","issue_id":2895590263,"issue_number":362,"issue_url":"https://github.com/philhagen/sof-elk/issues/362","linked_issue_ids":[2800151821],"is_known_query_context":false},{"document_id":"gh_comment_3020676698","fragment_type":"issue_comment","sequence":3,"text":"finally got time and access to an M4 Mac to test this. Several-fold fixes needed:\n- likely best to detect M4 first and only make these changes if needed via systems pre-exec. ensures minimal impact to anything else.\n\nThe logstash fix does not seem to work at all with version 8.17.0. However, after updating to 8.18.3, the service starts.\n\nIf running on an M4, do the following:\n- elasticsearch: add the `ES_JAVA_OPTS` and `CLI_JAVA_OPTS` to `/etc/default/elasticsearch`\n- logstash: add `LS_JAVA_OPTS` with the same value as the two above to `/etc/default/logstash`","author_login":"philhagen","author_association":"OWNER","created_at":"2025-06-30T20:53:58+08:00","repo_name":"philhagen/sof-elk","issue_id":2895590263,"issue_number":362,"issue_url":"https://github.com/philhagen/sof-elk/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3027943284","fragment_type":"issue_comment","sequence":4,"text":"I've tested a build with ES v9.0.3 components and with their stock installation, the services all start on both the M2 and M4. I'm inclined to \"fix\" this with a new release rather than patching fixes into the current one. That'll require a little more regression testing, but should not take too long. Will aim for a release candidate within about a week.","author_login":"philhagen","author_association":"OWNER","created_at":"2025-07-02T13:43:57+08:00","repo_name":"philhagen/sof-elk","issue_id":2895590263,"issue_number":362,"issue_url":"https://github.com/philhagen/sof-elk/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3124774157","fragment_type":"issue_comment","sequence":5,"text":"closing since the ES v9 version is in release candidate testing","author_login":"philhagen","author_association":"OWNER","created_at":"2025-07-27T22:52:57+08:00","repo_name":"philhagen/sof-elk","issue_id":2895590263,"issue_number":362,"issue_url":"https://github.com/philhagen/sof-elk/issues/362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2800151821","fragment_type":"issue_description","sequence":0,"text":"SSH not working after initial download\nHello :) \n\nAfter downloading the latest release of SOF-ELK today it seems there is an issue with the SSH service. It keeps crashing when trying to setup the SSH connection. Redownloading the file has been attempted but did not lead to other results. What can I do to fix this issue?\n\nThe following SSH attempts were attempted: \n\nssh elk_user@192.168.126.128 -L 9200:localhost:9200\nssh elk_user@192.168.126.128\n\nThe attached screenshot shows the ssh error: \n\nImage\n\nVMware Workstation 17 Pro build 17.6.2 build 24409262 was used","author_login":"Fierry137","author_association":"NONE","created_at":"2025-01-20T19:30:01+08:00","repo_name":"philhagen/sof-elk","issue_id":2800151821,"issue_number":351,"issue_url":"https://github.com/philhagen/sof-elk/issues/351","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2604044888","fragment_type":"issue_comment","sequence":1,"text":"Hello - this is a known issue. running `sudo sof-elk_update.sh` will address it - see URL","author_login":"philhagen","author_association":"OWNER","created_at":"2025-01-21T08:58:46+08:00","repo_name":"philhagen/sof-elk","issue_id":2800151821,"issue_number":351,"issue_url":"https://github.com/philhagen/sof-elk/issues/351","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0167","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Slightly blurry fonts?","query_context":"### Describe the bug\n\nshell\nI find the bold fonts in the tabs to be a bit difficult to read. I don't know if it's an anti-aliasing issue or something else but wanted to raise the issue in case there is a way to make the font rendering in Warp crisper overall!\n\n### To Reproduce\n\nJust opening the application.\n\n### Expected behaviour\n\nshell\nI would love the fonts in Warp to be more legible by default.\n\n### Screenshots\n\n<img width=\"298\" alt=\"image\" src=\" URL \n\n### Operating System\n\nMacOS\n\n### OS Version\n\n10.5.7\n\n### Additional context\n\n_No response_","known_context_document_ids":["gh_issue_1022987620"],"reference_answer":"Sharing this across various color related issues. The team fixed one of the core issues with colors and there's a new toggle under Settings > Appearance that let's you configure whether to enforce a minimum contrast (one of the issues). Please check if you're still having color issues again and test tweaking the toggle:\n\n<img width=\"505\" alt=\"CleanShot 2022-11-10 at 15 17 22@2x\" src=\" URL","answer_document_id":"gh_comment_1311037988","silver_evidence_path":["gh_comment_1130611806","gh_issue_1037528968","gh_comment_1311037988"],"evidence_issue_ids":[1022987620,1037528968],"source_repo_name":"warpdotdev/Warp","source_issue_id":1022987620,"source_issue_number":261,"source_issue_url":"https://github.com/warpdotdev/Warp/issues/261","target_repo_name":"warpdotdev/Warp","target_issue_id":1037528968,"target_issue_number":317,"target_issue_url":"https://github.com/warpdotdev/Warp/issues/317","reference_anchor_document_id":"gh_comment_1130611806","reference_answer_author":"elviskahoro","reference_answer_author_association":"MEMBER","quality_score":92.39,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1373,"anchor_target_overlap":0.125,"target_answer_overlap":0.0278},"issue_created_at":"2021-10-11T18:12:45+08:00","valid_comment_count":29,"fragments":[{"document_id":"gh_issue_1022987620","fragment_type":"issue_description","sequence":0,"text":"Slightly blurry fonts\n### Describe the bug\n\nshell\nI find the bold fonts in the tabs to be a bit difficult to read. I don't know if it's an anti-aliasing issue or something else but wanted to raise the issue in case there is a way to make the font rendering in Warp crisper overall!\n\n### To Reproduce\n\nJust opening the application.\n\n### Expected behaviour\n\nshell\nI would love the fonts in Warp to be more legible by default.\n\n### Screenshots\n\n<img width=\"298\" alt=\"image\" src=\" URL \n\n### Operating System\n\nMacOS\n\n### OS Version\n\n10.5.7\n\n### Additional context\n\n_No response_","author_login":"slifty","author_association":"NONE","created_at":"2021-10-11T18:12:45+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1006846416","fragment_type":"issue_comment","sequence":1,"text":"+1, the type rendering is really bad, and as typography is the principal interface element of a terminal, it's hard to get excited to try using it, when my perfectly rendered Terminal.app is sitting right there.","author_login":"daniloc","author_association":"NONE","created_at":"2022-01-06T19:10:07+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1012621688","fragment_type":"issue_comment","sequence":2,"text":"I too have noticed this issue -- it's notable because I think it's only appearing when the Warp window is on an external Monitor, the fonts don't look blurry on the main laptop display, so I'm wondering if a Screen-flag isn't being updated properly per display.","author_login":"fbartho","author_association":"NONE","created_at":"2022-01-13T23:49:02+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1087052375","fragment_type":"issue_comment","sequence":3,"text":"Also having this issue running Warp on a 2015 Macbook Air with Big Sur.","author_login":"allyouaskfor","author_association":"NONE","created_at":"2022-04-04T02:42:35+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1089155812","fragment_type":"issue_comment","sequence":4,"text":"Also happening to me - this gives a feeling of old Java interfaces that would do their own custom anti-aliasing or something. \nGreat product btw, congrats. Regular terminal feels very dated in comparison.","author_login":"hugows","author_association":"NONE","created_at":"2022-04-05T18:25:35+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091632775","fragment_type":"issue_comment","sequence":5,"text":"Tried Warp now, and the font rendering in the application parts (that is, not the actual terminal but for example in the settings and similar) is very bad. I initially thought something must be wrong with the installation. Here is a screenshot of the sidebar menu in settings as an example.\nScreenshot 2022-04-07 at 13 32 47","author_login":"zayenz","author_association":"NONE","created_at":"2022-04-07T11:41:46+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1102953870","fragment_type":"issue_comment","sequence":6,"text":"The same on MacOS Monterey:\n<img width=\"294\" alt=\"Screenshot 2022-04-19 at 21 23 12\" src=\" URL \nCommon terminal on left, Warp on right.","author_login":"igorgoroun","author_association":"NONE","created_at":"2022-04-19T18:24:13+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1103550236","fragment_type":"issue_comment","sequence":7,"text":"Glad it's not just me ;-) - the blurry fonts make it unusable for my eyes","author_login":"stooboo","author_association":"NONE","created_at":"2022-04-20T07:14:05+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120962261","fragment_type":"issue_comment","sequence":8,"text":"For me the font rendering is perfect on MacBook Pro built-in retina display, but the fonts become blurry when I close the laptop and use 2x full hd monitor via DisplayLink","author_login":"grzegorzkycsw","author_association":"NONE","created_at":"2022-05-09T11:10:29+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124688670","fragment_type":"issue_comment","sequence":9,"text":"<img width=\"350\" alt=\"image\" src=\" URL \nI've also noticed blurry fonts and bad kerning. For example here, the spacing between `p y` in Copy, `l e` in select, `u s` in user's. For some people I've shown this to they can't even see it and for others a deal breaker, including me unfortunately.","author_login":"jonohill","author_association":"NONE","created_at":"2022-05-12T08:32:04+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130611806","fragment_type":"issue_comment","sequence":10,"text":"General note - we're delegating to CoreText for glyph rasterization, so rendering in the terminal grid should be largely the same as other Mac apps. Rendering of proportional fonts is definitely off, as we're not currently respecting fractional pixel advances between glyphs (things get forced to pixel boundaries). This may also be what's leading to low-quality font rendering on non-retina displays, as that forcing would be moving glyphs further from the desired location (in mm/inches).\n\nI'm working on improving kerning this week. :) (FYI @jonohill)\n\nThe comments about glyphs appearing bolder is due to iTerm (and, presumably, Terminal.app) using a private API to render glyphs with thinner outlines on retina displays. When you disable that functionality, glyphs for Warp should be pixel-identical to iTerm (as of today's release).\n\nSimilarly to kerning, I'm working on addressing the too-bold issue this week. :)\n\nIf you want some more details about known issues with our font rendering, or a visual comparison with iTerm, see my comment here: URL","author_login":"vorporeal","author_association":"NONE","created_at":"2022-05-18T22:14:15+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[1037528968],"is_known_query_context":false},{"document_id":"gh_comment_1224312128","fragment_type":"issue_comment","sequence":11,"text":"Closing this out as @vorporeal made a bunch of improvements to our text rendering. Please reopen if you are still seeing blurry fonts!","author_login":"alokedesai","author_association":"MEMBER","created_at":"2022-08-23T16:29:16+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311037950","fragment_type":"issue_comment","sequence":12,"text":"Sharing this across various color related issues. The team fixed one of the core issues with colors and there's a new toggle under Settings > Appearance that let's you configure whether to enforce a minimum contrast (one of the issues). Please check if you're still having color issues again and test tweaking the toggle:\n\n<img width=\"505\" alt=\"CleanShot 2022-11-10 at 15 17 22@2x\" src=\" URL","author_login":"elviskahoro","author_association":"MEMBER","created_at":"2022-11-10T23:26:52+08:00","repo_name":"warpdotdev/Warp","issue_id":1022987620,"issue_number":261,"issue_url":"https://github.com/warpdotdev/Warp/issues/261","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1037528968","fragment_type":"issue_description","sequence":0,"text":"Text Rendering / Line height weird\n### Describe the bug\n\nshell\nText rendering in Warp doesn't look great yet.\n\nThere is no emoji support yet (yeah, sorry 😄)\n\nBut especially the line height seems off. The line height is a lot higher than the text and the text is positioned at the top.\n\nSame font, same font size in iTerm 2 looks more balanced.\nAlso there is sometimes a small gap between the lines, which doesn't look great when for example rendering tables\n\n### To Reproduce\n\nSteps to reproduce:\n1. Use Font `FireCode NF` / medium / font-size 14\n2. then you should be able see the issues\n\n### Expected behaviour\n\nshell\nYou should be able to draw beautiful UIs in your CLI\n\n### Screenshots\n\n### Warp:\n\nCapture 2021-10-27_16-53-12\n\n### iTerm 2:\nCapture 2021-10-27_16-54-22\n\n### Line height visualization in Warp:\nCapture 2021-10-27_16-56-13\n\n### Operating System\n\nMacOS\n\n### OS Version\n\n11.6\n\n### Additional context\n\n_No response_","author_login":"apfelbox","author_association":"NONE","created_at":"2021-10-27T14:58:45+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019084225","fragment_type":"issue_comment","sequence":1,"text":"### Describe the solution you'd like?\n\nshell\nTo configure the text line height.\nDiscord - feature-requests - 2021.11.03:\n\"FR: Reduce the line-height (or add an option). I don't mind the UI taking up more space than a normal terminal, but you lose too much space to each line. I would accept whatever line-height: normal is for the current font. Based on the Fira Code repo, it's still substantially tighter than in Warp.\"\n\n### Is your feature request related to a problem? Please describe.\n\nshell\nN/A\n\n### Additional context\n\n URL","author_login":"elviskahoro","author_association":"MEMBER","created_at":"2022-01-22T07:31:21+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019084311","fragment_type":"issue_comment","sequence":2,"text":"From @pf1gura via #352\n\nI like to set my line height to something bigger than the standard. I find too much text in one view to be distracting. In iTerm, my preferable value is 200. I suppose I am not alone in this and it would be nice to have that option.\n\nCleanShot 2021-11-05 at 21 13 52","author_login":"elviskahoro","author_association":"MEMBER","created_at":"2022-01-22T07:31:50+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019084396","fragment_type":"issue_comment","sequence":3,"text":"From @argai via #352\n\nI've just downloaded warp and have the same issue, line height needs to be configurable.\n\nimage\nOn the left there is warp, on the right iterm. While this might be ok on a desktop and big screen, on a 13\" laptop its way too much space wasted.","author_login":"elviskahoro","author_association":"MEMBER","created_at":"2022-01-22T07:32:16+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019084457","fragment_type":"issue_comment","sequence":4,"text":"From @lnking81 via #352\n\nNot only the line height but also all font rendering options: name, size, the interval between letters, ligatures, anti-aliasing, etc.","author_login":"elviskahoro","author_association":"MEMBER","created_at":"2022-01-22T07:32:39+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079598892","fragment_type":"issue_comment","sequence":5,"text":"The extreme line height in combination with the font being positioned at the very top with ``FiraCode Nerd Font Mono`` is also problematic when using a custom status line in vim / neovim, as there is a huge padding like space below the text.\n<img width=\"200\" alt=\"スクリーンショット 2022-03-26 13 22 10\" src=\" URL","author_login":"Theo-Steiner","author_association":"NONE","created_at":"2022-03-26T04:22:40+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1109586827","fragment_type":"issue_comment","sequence":6,"text":"Same issue here.\n\nLeft warp, right iTerm2:\n<img width=\"1438\" alt=\"image\" src=\" URL","author_login":"eyeKill","author_association":"NONE","created_at":"2022-04-26T09:47:16+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1111859618","fragment_type":"issue_comment","sequence":7,"text":"Came here for the same. Line height needs to be configureable and also it would be nice to be able to get some of that iTerm 2 anti aliasing.🤓","author_login":"SebDanielsson","author_association":"NONE","created_at":"2022-04-28T07:46:56+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114114778","fragment_type":"issue_comment","sequence":8,"text":"There seems to have been some sort of line height related issues with Warp v0.2022.04.25.09.59.stable_03, although it is still not configurable","author_login":"Theo-Steiner","author_association":"NONE","created_at":"2022-05-01T03:09:07+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114590876","fragment_type":"issue_comment","sequence":9,"text":"version v0.2022.04.25.09.59.stable_03 seems a bit normal?\n<img width=\"1147\" alt=\"截屏2022-05-02 15 53 11\" src=\" URL","author_login":"samurai00","author_association":"NONE","created_at":"2022-05-02T07:55:16+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114623273","fragment_type":"issue_comment","sequence":10,"text":"Can confirm that it looks way better now. The line height is pretty narrow now though, so it would be great if we could configure it.\n\nThe important part however is that the text should be centered in the line height and not at the top of it. Otherwise we will just reproduce the issue from before.","author_login":"apfelbox","author_association":"NONE","created_at":"2022-05-02T08:36:35+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114630729","fragment_type":"issue_comment","sequence":11,"text":"It's much better. Still would like more options for fonts. I would like to have some AA + configure font weight.","author_login":"SebDanielsson","author_association":"NONE","created_at":"2022-05-02T08:47:23+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1119075732","fragment_type":"issue_comment","sequence":12,"text":"Yeah, line height was fixed but there were a couple other issues introduced so it got temporarily rolled back. I'm actively working on font rendering issues, so things should be improving soon.\n\nOne note about anti-aliasing, since many people seem to comment on it - we do actually use AA for font rendering, and my pixel-level comparisons with iTerm on both retina and non-retina displays indicates that both terminals render glyphs the same way (Courier New, 13pt, with \"Use thin strokes for anti-aliased text\" in iTerm set to \"Never\"), with a couple notable differences that I'm working on:\n * Warp computes cell sizes differently (this is the line height issue y'all have been discussing, and can be seen in the horizontal spacing of glyphs in the screenshots below)\n * Warp cuts the top row of pixels off of some glyphs (you can see this in the \"l\" below)\n * Warp occasionally renders glyphs at fractional y-values, leading to different/fuzzy glyph rendering\n * Warp doesn't render glyphs with thinner outlines on retina displays (hence disabling that in iTerm to make pixel-level comparisons)\n * Warp doesn't allow users to customize font metrics (e.g.: line density/spacing) - this is something I'd like to fix but will likely come after fixing core rendering issues\n\nScreenshots of Warp (top, blue bg) and iTerm (bottom, black bg) on a non-retina external display:\nimage\nimage\n\nIf you're finding that Warp and iTerm have different pixel-level glyph rendering, I'd love it if you would reply with the following info:\n * A screenshot or two highlighting the differences\n * Which version of Warp you're running\n * Which font you're using and which font size\n * Whether you're using Warp on your laptop screen (which model?) or an external monitor (what resolution?)\n\nGetting this right is important to us (and all of you, clearly!) :)","author_login":"vorporeal","author_association":"NONE","created_at":"2022-05-05T21:46:18+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1121634733","fragment_type":"issue_comment","sequence":13,"text":"@samurai00 As mentioned above, the fix for line height was rolled back temporarily while we fix a regression. A handful of font rendering improvements should go out next week. :)","author_login":"vorporeal","author_association":"NONE","created_at":"2022-05-09T22:11:55+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130610869","fragment_type":"issue_comment","sequence":14,"text":"Update: today's release (now live) re-introduces the fix for too-large line heights. We're working on adding customizable vertical/horizontal spacing to settings; should be live in the next week or two.\n\nPlease let me know if you still encounter issues with incorrect line heights after updating!","author_login":"vorporeal","author_association":"NONE","created_at":"2022-05-18T22:13:39+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1132758983","fragment_type":"issue_comment","sequence":15,"text":"the line-height looks good now. lunarvim looks normal now.. except that the text doesn't hide behind menus (not related to the line-height)","author_login":"luxus","author_association":"NONE","created_at":"2022-05-20T10:48:45+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152930126","fragment_type":"issue_comment","sequence":16,"text":"The vertical problem does not happen if you use the default font, but if you change to Monaco, for example, it starts to happen:\n\nDefault font\n<img width=\"1136\" alt=\"Captura de Tela 2022-06-11 às 10 41 10\" src=\" URL \n\nMonaco\n<img width=\"1136\" alt=\"Captura de Tela 2022-06-11 às 10 41 28\" src=\" URL","author_login":"ronisbr","author_association":"NONE","created_at":"2022-06-11T13:41:36+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311037988","fragment_type":"issue_comment","sequence":17,"text":"Sharing this across various color related issues. The team fixed one of the core issues with colors and there's a new toggle under Settings > Appearance that let's you configure whether to enforce a minimum contrast (one of the issues). Please check if you're still having color issues again and test tweaking the toggle:\n\n<img width=\"505\" alt=\"CleanShot 2022-11-10 at 15 17 22@2x\" src=\" URL","author_login":"elviskahoro","author_association":"MEMBER","created_at":"2022-11-10T23:26:57+08:00","repo_name":"warpdotdev/Warp","issue_id":1037528968,"issue_number":317,"issue_url":"https://github.com/warpdotdev/Warp/issues/317","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0168","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"some games are missing?","query_context":"### Describe the bug\n\nsome games like daemon x machina and genshin impact from the EGS are missing from my library in the launcher but present in the official client (I'm on windows)\n\n### Add logs\n\n(02:17:20) INFO: [Legendary]: Location: C:\\Users\\Shiroe\\AppData\\Local\\Programs\\heroic\\resources\\app.asar.unpacked\\build\\bin\\win32\\legendary.exe\n(02:17:20) INFO: [Gog]: Location: C:\\Users\\Shiroe\\AppData\\Local\\Programs\\heroic\\resources\\app.asar.unpacked\\build\\bin\\win32\\gogdl.exe\n(02:17:24) INFO: [Backend]: \n Heroic Version: 2.2.2 Oden\n Legendary Version: 0.20.25 Our Benefactors\n OS: Microsoft Windows 10 Enterprise KERNEL: 10.0.19044 ARCH: x64\n CPU: Intel Core™ i7-8700K @3.7 \n RAM: Total: 34.3 GB Available: 22.5 GB\n GRAPHICS: GPU0: Intel(R) UHD Graphics 630 VRAM: 1024MB DRIVER: GPU1: NVIDIA GeForce RTX 3080 VRAM: 10240MB DRIVER: 511.79 \n \n \n(02:17:24) INFO: [Backend]: User Not Found, removing it from Store\n(02:17:24) INFO: [Gog]: Getting data about the user\n(02:17:24) WARNING: [Backend]: Protocol already registered.\n(02:17:25) INFO: [Gog]: Saved user data to config\n(02:17:25) INFO: [Frontend]: Refreshing Library\n(02:17:25) INFO: [Gog]: Getting GOG library\n(02:17:26) INFO: [Gog]: Number of library pages: 2\n(02:17:26) INFO: [Gog]: Getting data for page 2\n(02:17:26) INFO: [Gog]: Saved games data\n(02:17:26) INFO: [Legendary]: Refreshing library...\n(02:17:26) INFO: [Frontend]: No cache found, getting data from legendary...\n(02:17:26) INFO: [Legendary]: Refreshing library...\n(02:17:26) INFO: [Gog]: Found 0 game(s) to update\n(02:17:30) INFO: [Backend]: checking for heroic updates\n(02:17:45) INFO: [Legendary]: \n(02:17:45) ERROR: [Legendary]: [cli] ERROR: Legendary is missing game metadata, please login (if not already) and use the \"status\" command to fetch necessary information to set-up syncing.\n\n(02:18:05) INFO: [Backend]: Changing Language to: en\n(02:18:14) INFO: [Backend]: Changing Tray icon Color...\n(02:22:58) INFO: [Frontend]: Refreshing Library\n(02:22:58) INFO: [Gog]: Getting GOG library\n(02:22:59) INFO: [Gog]: Number of library pages: 2\n(02:22:59) INFO: [Gog]: Getting data for page 2\n(02:22:59) INFO: [Gog]: Saved games data\n(02:22:59) INFO: [Legendary]: Refreshing library...\n(02:22:59) INFO: [Frontend]: No cache found, getting data from legendary...\n(02:22:59) INFO: [Legendary]: Refreshing library...\n\n### Steps to reproduce\n\n1. Go to library \n2 games are missing \n\n### Expected behavior\n\nthe previously mentioned games to show up in the list\n\n### Screenshots\n\nScreenshot_342\n\n### System Information\n\n- OS windows\n- Heroic Version 2.2.2 Oden\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_1162120415"],"reference_answer":"We are aware of the issue. This is related to Windows and MacOS. For now downgrade to 2.2.1, hotfix for that will be released tomorrow.","answer_document_id":"gh_comment_1061210606","silver_evidence_path":["gh_comment_1061349304","gh_issue_1161803259","gh_comment_1061210606"],"evidence_issue_ids":[1162120415,1161803259],"source_repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","source_issue_id":1162120415,"source_issue_number":1055,"source_issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","target_repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","target_issue_id":1161803259,"target_issue_number":1053,"target_issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","reference_anchor_document_id":"gh_comment_1061349304","reference_answer_author":"imLinguin","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.1},"issue_created_at":"2022-03-08T01:42:56+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_1162120415","fragment_type":"issue_description","sequence":0,"text":"some games are missing\n### Describe the bug\n\nsome games like daemon x machina and genshin impact from the EGS are missing from my library in the launcher but present in the official client (I'm on windows)\n\n### Add logs\n\n(02:17:20) INFO: [Legendary]: Location: C:\\Users\\Shiroe\\AppData\\Local\\Programs\\heroic\\resources\\app.asar.unpacked\\build\\bin\\win32\\legendary.exe\n(02:17:20) INFO: [Gog]: Location: C:\\Users\\Shiroe\\AppData\\Local\\Programs\\heroic\\resources\\app.asar.unpacked\\build\\bin\\win32\\gogdl.exe\n(02:17:24) INFO: [Backend]: \n Heroic Version: 2.2.2 Oden\n Legendary Version: 0.20.25 Our Benefactors\n OS: Microsoft Windows 10 Enterprise KERNEL: 10.0.19044 ARCH: x64\n CPU: Intel Core™ i7-8700K @3.7 \n RAM: Total: 34.3 GB Available: 22.5 GB\n GRAPHICS: GPU0: Intel(R) UHD Graphics 630 VRAM: 1024MB DRIVER: GPU1: NVIDIA GeForce RTX 3080 VRAM: 10240MB DRIVER: 511.79 \n \n \n(02:17:24) INFO: [Backend]: User Not Found, removing it from Store\n(02:17:24) INFO: [Gog]: Getting data about the user\n(02:17:24) WARNING: [Backend]: Protocol already registered.\n(02:17:25) INFO: [Gog]: Saved user data to config\n(02:17:25) INFO: [Frontend]: Refreshing Library\n(02:17:25) INFO: [Gog]: Getting GOG library\n(02:17:26) INFO: [Gog]: Number of library pages: 2\n(02:17:26) INFO: [Gog]: Getting data for page 2\n(02:17:26) INFO: [Gog]: Saved games data\n(02:17:26) INFO: [Legendary]: Refreshing library...\n(02:17:26) INFO: [Frontend]: No cache found, getting data from legendary...\n(02:17:26) INFO: [Legendary]: Refreshing library...\n(02:17:26) INFO: [Gog]: Found 0 game(s) to update\n(02:17:30) INFO: [Backend]: checking for heroic updates\n(02:17:45) INFO: [Legendary]: \n(02:17:45) ERROR: [Legendary]: [cli] ERROR: Legendary is missing game metadata, please login (if not already) and use the \"status\" command to fetch necessary information to set-up syncing.\n\n(02:18:05) INFO: [Backend]: Changing Language to: en\n(02:18:14) INFO: [Backend]: Changing Tray icon Color...\n(02:22:58) INFO: [Frontend]: Refreshing Library\n(02:22:58) INFO: [Gog]: Getting GOG library\n(02:22:59) INFO: [Gog]: Number of library pages: 2\n(02:22:59) INFO: [Gog]: Getting data for page 2\n(02:22:59) INFO: [Gog]: Saved games data\n(02:22:59) INFO: [Legendary]: Refreshing library...\n(02:22:59) INFO: [Frontend]: No cache found, getting data from legendary...\n(02:22:59) INFO: [Legendary]: Refreshing library...\n\n### Steps to reproduce\n\n1. Go to library \n2 games are missing \n\n### Expected behavior\n\nthe previously mentioned games to show up in the list\n\n### Screenshots\n\nScreenshot_342\n\n### System Information\n\n- OS windows\n- Heroic Version 2.2.2 Oden\n\n### Additional information\n\n_No response_","author_login":"Shiroe93","author_association":"NONE","created_at":"2022-03-08T01:42:56+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1061349304","fragment_type":"issue_comment","sequence":1,"text":"This is a current issue (see #1053). Until this is fixed use v2.2.1.","author_login":"8Bitz0","author_association":"CONTRIBUTOR","created_at":"2022-03-08T02:44:55+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[1161803259],"is_known_query_context":false},{"document_id":"gh_comment_1062623733","fragment_type":"issue_comment","sequence":2,"text":"No I don't think so because, unlike the issue you linked me to, I can see certain games but not others","author_login":"Shiroe93","author_association":"NONE","created_at":"2022-03-09T07:20:27+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1062696125","fragment_type":"issue_comment","sequence":3,"text":"Because I used the search to show you the game that didn't show up but some others do appear","author_login":"Shiroe93","author_association":"NONE","created_at":"2022-03-09T08:59:27+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1062765455","fragment_type":"issue_comment","sequence":4,"text":"Because I used the search to show you the game that didn't show up but some others do appear Il 9 mar 2022 08:59, Flávio F Lima ***@***.***> ha scritto:\nI cannot see any game on your library.\n\n—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>","author_login":"Shiroe93","author_association":"NONE","created_at":"2022-03-09T10:16:57+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1077952579","fragment_type":"issue_comment","sequence":5,"text":"Daemon X Machina is also not showing for me in Heroic but also in the main client, also having this issue with Tiny Tina's Wonderlands","author_login":"livejamie","author_association":"NONE","created_at":"2022-03-24T19:03:56+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079388489","fragment_type":"issue_comment","sequence":6,"text":"After the last update (done a few minutes ago) the issue seems to be solved","author_login":"Shiroe93","author_association":"NONE","created_at":"2022-03-25T19:57:00+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101866910","fragment_type":"issue_comment","sequence":7,"text":"@flavioislima I think this can be closed, issue seems to be solved.","author_login":"arielj","author_association":"COLLABORATOR","created_at":"2022-04-19T00:02:25+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1162120415,"issue_number":1055,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1055","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1161803259","fragment_type":"issue_description","sequence":0,"text":"No longer seeing Library after upgrading to 2.2.2\n### Describe the bug\n\nI just upgraded to 2.2.2 after being prompted to upgrade, and now I cant seem to get anything after logging in to Epic games.\n\n### Add logs\n\n(10:55:30) INFO: [Legendary]: Logging with Legendary...\n(10:55:30) INFO: [Legendary]: Logging with Legendary...\n(10:55:30) INFO: [Legendary]: stderr: [cli] INFO: Testing existing login data if present...\n\n(10:55:30) INFO: [Legendary]: stderr: [Core] INFO: Trying to re-use existing login session...\n\n(10:55:30) INFO: [Legendary]: stderr: [cli] INFO: Testing existing login data if present...\n[Core] INFO: Trying to re-use existing login session...\n\n(10:55:31) INFO: [Legendary]: Logging with Legendary...\n(10:55:31) INFO: [Legendary]: stderr: [cli] INFO: Stored credentials are still valid, if you wish to switch to a different account, run \"legendary auth --delete\" and try again.\n\n(10:55:31) INFO: [Legendary]: stderr: [cli] INFO: Stored credentials are still valid, if you wish to switch to a different account, run \"legendary auth --delete\" and try again.\n\n(10:55:31) INFO: [Legendary]: finished login\n(10:55:31) INFO: [Legendary]: finished login\n(10:55:31) INFO: [Legendary]: stderr: [cli] INFO: Testing existing login data if present...\n\n(10:55:31) INFO: [Legendary]: stderr: [Core] INFO: Trying to re-use existing login session...\n\n(10:55:31) INFO: [Legendary]: stderr: [cli] INFO: Stored credentials are still valid, if you wish to switch to a different account, run \"legendary auth --delete\" and try again.\n\n(10:55:31) INFO: [Legendary]: finished login\n(10:55:36) INFO: [Frontend]: Refreshing Library\n(10:55:36) INFO: [Legendary]: Refreshing library...\n(10:55:36) INFO: [Frontend]: No cache found, getting data from legendary...\n(10:55:36) INFO: [Legendary]: Refreshing library...\n\n### Steps to reproduce\n\n1. Go to App\n2. Log in\n3. No library\n\n### Expected behavior\n\nGo to App\nLog in\nSee Library\n\n### Screenshots\n\n_No response_\n\n### System Information\n\n- Mac OS Monterey\n- Heroic 2.2.2\n\n### Additional information\n\n_No response_","author_login":"bearcatjamboree","author_association":"NONE","created_at":"2022-03-07T19:00:23+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1161803259,"issue_number":1053,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061029865","fragment_type":"issue_comment","sequence":1,"text":"Or maybe go to Manage Accounts and click continue. I thought this bug was fixed but maybe it wasn't on Mac.","author_login":"flavioislima","author_association":"COLLABORATOR","created_at":"2022-03-07T19:05:29+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1161803259,"issue_number":1053,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061111698","fragment_type":"issue_comment","sequence":2,"text":"I had a similar issue, i just had to select epic games under library.","author_login":"Henry-Hiles","author_association":"NONE","created_at":"2022-03-07T20:36:04+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1161803259,"issue_number":1053,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061208888","fragment_type":"issue_comment","sequence":3,"text":"I can't access my library as well. Tried uninstalling and installing again and nothing happenned. I'm using macOS Monterey on Mac Mini M1.","author_login":"raulcraveiro","author_association":"NONE","created_at":"2022-03-07T22:33:31+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1161803259,"issue_number":1053,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061210606","fragment_type":"issue_comment","sequence":4,"text":"We are aware of the issue. This is related to Windows and MacOS. For now downgrade to 2.2.1, hotfix for that will be released tomorrow.","author_login":"imLinguin","author_association":"MEMBER","created_at":"2022-03-07T22:35:57+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1161803259,"issue_number":1053,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061317765","fragment_type":"issue_comment","sequence":5,"text":"I tried but it is the same after I log in\n\nSent from my iPhone\n\nOn Mar 7, 2022, at 11:03 AM, Flávio F Lima ***@***.***> wrote:\n\n\n\nThats pretty weird. Can you try to Logout and Login Again?\n\n—\nReply to this email directly, view it on GitHub","author_login":"bearcatjamboree","author_association":"NONE","created_at":"2022-03-08T01:39:17+08:00","repo_name":"Heroic-Games-Launcher/HeroicGamesLauncher","issue_id":1161803259,"issue_number":1053,"issue_url":"https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/1053","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0170","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Allow for custom AgroalDataSourceListener?","query_context":"### Description\n\nI would like to be able to configure a custom AgroalDataSourceListener.\n\nI found the following issue from 2019, but the change only allowed for a custom AgroalPoolInterceptor:\n\"Allow addition of AgroalDataSourceListener implementations during run-time production of DataSources.\"\n URL \n\n### Implementation ideas\n\nI would propose to have a similar solution for custom AgroalDataSourceListener as there currently is for AgroalPoolInterceptor.\n\nA custom AgroalPoolInterceptor can be defined by making an ApplicationScoped implementation of the interface.\nIt is also possible to annotate the interceptor class with the @DataSource qualifier.\n\nThe exact same setup could be done for custom AgroalDataSourceListener.\nThe change would have to be done in io.quarkus.agroal.runtime.DataSources.\n\nprivate final Instance agroalPoolInterceptors; // existing\nprivate final Instance agroalDataSourceListeners; // to be added\n\nCurrently there is only 1 hard-coded listener for logging\nThis part should be adapted to include the custom agroalDataSourceListeners as well\n\nAgroalDataSource dataSource = new io.agroal.pool.DataSource(agroalConfiguration,\n new AgroalEventLoggingListener(dataSourceName,\n agroalConfiguration.connectionPoolConfiguration()\n .transactionRequirement() == TransactionRequirement.WARN));","known_context_document_ids":["gh_issue_1924062576"],"reference_answer":"I think we should aim at fixing this thing for the next LTS, either by going Yoann's way ^. It's not the first time that we had issues with shutdown ordering so taking a step back and listing all the issues to find a global solution would be awesome.\n\nIn the meantime, I wonder if we should include URL in the `quarkus-jdbc-oracle` extension.\n\nI will create a PR with ^ to get the ball rolling.","answer_document_id":"gh_comment_2563849378","silver_evidence_path":["gh_comment_1846875053","gh_issue_1924112701","gh_comment_2563849378"],"evidence_issue_ids":[1924062576,1924112701],"source_repo_name":"quarkusio/quarkus","source_issue_id":1924062576,"source_issue_number":36263,"source_issue_url":"https://github.com/quarkusio/quarkus/issues/36263","target_repo_name":"quarkusio/quarkus","target_issue_id":1924112701,"target_issue_number":36265,"target_issue_url":"https://github.com/quarkusio/quarkus/issues/36265","reference_anchor_document_id":"gh_comment_1846875053","reference_answer_author":"gsmet","reference_answer_author_association":"MEMBER","quality_score":94.03,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.3,"target_answer_overlap":0.0606},"issue_created_at":"2023-10-03T12:40:39+08:00","valid_comment_count":37,"fragments":[{"document_id":"gh_issue_1924062576","fragment_type":"issue_description","sequence":0,"text":"Allow for custom AgroalDataSourceListener\n### Description\n\nI would like to be able to configure a custom AgroalDataSourceListener.\n\nI found the following issue from 2019, but the change only allowed for a custom AgroalPoolInterceptor:\n\"Allow addition of AgroalDataSourceListener implementations during run-time production of DataSources.\"\n URL \n\n### Implementation ideas\n\nI would propose to have a similar solution for custom AgroalDataSourceListener as there currently is for AgroalPoolInterceptor.\n\nA custom AgroalPoolInterceptor can be defined by making an ApplicationScoped implementation of the interface.\nIt is also possible to annotate the interceptor class with the @DataSource qualifier.\n\nThe exact same setup could be done for custom AgroalDataSourceListener.\nThe change would have to be done in io.quarkus.agroal.runtime.DataSources.\n\nprivate final Instance agroalPoolInterceptors; // existing\nprivate final Instance agroalDataSourceListeners; // to be added\n\nCurrently there is only 1 hard-coded listener for logging\nThis part should be adapted to include the custom agroalDataSourceListeners as well\n\nAgroalDataSource dataSource = new io.agroal.pool.DataSource(agroalConfiguration,\n new AgroalEventLoggingListener(dataSourceName,\n agroalConfiguration.connectionPoolConfiguration()\n .transactionRequirement() == TransactionRequirement.WARN));","author_login":"segersb","author_association":"NONE","created_at":"2023-10-03T12:40:39+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1744979240","fragment_type":"issue_comment","sequence":1,"text":"Hi. Is this different from URL ?\n\n@barreiro , the person most likely to approve such a feature, had concern with the approach: URL \nDo you have ideas to address those concerns?","author_login":"yrodiere","author_association":"MEMBER","created_at":"2023-10-03T13:27:39+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1745022100","fragment_type":"issue_comment","sequence":2,"text":"All valid concerns, I guess it's the responsibility of the developer to know what they are doing.\n\nThe AgroalPoolInterceptor that can be used now also gives access to the underlying connection.\nMaybe it has less room for errors, but I'd say there are infinite ways to mess up if not careful :)\n\nFor context, I need to make sure that connections are rolled back before they are closed.\nOracle seems to perform a commit when a connection is closed.\nWe have an issue when quarkus is shut down gracefully while there are long-running tasks running.\nI created an issue for this specific problem as well: URL","author_login":"segersb","author_association":"NONE","created_at":"2023-10-03T13:50:23+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[1924112701],"is_known_query_context":false},{"document_id":"gh_comment_1846875053","fragment_type":"issue_comment","sequence":3,"text":"Would it be possible to get an update on this, we currently have to resort to pretty ugly code to have a custom AgroalDataSourceListener so that transaction management for Oracle works properly under Quarkus.\nSee URL for more details on that","author_login":"segersb","author_association":"NONE","created_at":"2023-12-08T09:49:07+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[1924112701],"is_known_query_context":false},{"document_id":"gh_comment_1886687588","fragment_type":"issue_comment","sequence":4,"text":"@barreiro\nWould it be possible to look at this issue?\nWe currently have to rely on a dirty workaround to have transaction integrity. This would allow us to have proper code.\n\nAlternatively, Quarkus could have a built-in datasource listener that does the rollback before close. (needed for Oracle)\n\n @Override\n public void beforeConnectionDestroy(Connection connection) {\n try {\n connection.rollback();\n } catch (SQLException e) {\n // ignore\n }\n }","author_login":"segersb","author_association":"NONE","created_at":"2024-01-11T09:15:25+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936810497","fragment_type":"issue_comment","sequence":5,"text":"@segersb Agroal 2.3 adds `onConnectionCreate` / `onConnectionDestroy` methods to `AgroalPoolInterceptor`. \n\nThis will support you use case (if Agroal prevents the rollback, you'll need to unwrap the connection and call `rollback` on the raw connection).\n\nThis methods run on Agroal housekeeping thread and therefore should not be abused.","author_login":"barreiro","author_association":"CONTRIBUTOR","created_at":"2024-02-10T02:01:42+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945787779","fragment_type":"issue_comment","sequence":6,"text":"@barreiro\nThanks, that would already be a much better solution than what we have now!\n\nIs that something that Quarkus would implement by default?\nIt doesn't seem right that transactions are not safe by default when using Oracle.","author_login":"segersb","author_association":"NONE","created_at":"2024-02-15T10:30:03+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1980764415","fragment_type":"issue_comment","sequence":7,"text":"Changed the title to clarify that the solution was not to allow custom `AgroalDataSourceListener` in the end, but this:","author_login":"yrodiere","author_association":"MEMBER","created_at":"2024-03-06T12:29:05+08:00","repo_name":"quarkusio/quarkus","issue_id":1924062576,"issue_number":36263,"issue_url":"https://github.com/quarkusio/quarkus/issues/36263","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1924112701","fragment_type":"issue_description","sequence":0,"text":"Unexpected commit of transaction using Oracle\n### Describe the bug\n\nThe Oracle JDBC driver performs a commit when a connection is closed without an explicit commit or rollback.\nWhen Quarkus is shut down gracefully, connections are closed properly, and this causes unfinished transactions to be committed.\n\nConsider the following simple rest endpoint.\nWe insert a record in the database, wait 2 minutes and then throw an exception.\n\n@PermitAll\n@Path(\"/test\")\npublic class TestResource {\n @Inject\n EntityManager entityManager;\n\n @GET\n @Transactional\n @SneakyThrows\n public Response test() {\n entityManager.createNativeQuery(\"insert into TEST_TABLE (TEST_COLUMN) values (1)\").executeUpdate();\n\n System.out.println(\"shut down app now\");\n Thread.sleep(120000);\n\n if (true) {\n throw new RuntimeException(\"app was not shut down, throwing exception to avoid transaction commit\");\n }\n\n return Response.ok().build();\n }\n}\n\n### Expected behavior\n\nI would expect that nothing is inserted in the database.\n\n### Actual behavior\n\nWhen doing a graceful shutdown during the wait period, the insert is committed.\n\n### How to Reproduce?\n\nSee code above for the simple rest endpoint.\n\nTo perform a graceful shutdown locally we need to start quarkus-dev via a java command, and not `mvn quarkus:dev`.\nFortunately when I execute quarkus-dev via IntelliJ, the java command is the first line of the output.\nThis allows us to use CTRL-C, which will do a graceful shutdown.\n\n1. run the java command to start quarkus:dev\n2. call the rest endpoint\n3. wait for the quarkus console to output \"shut down app now\"\n4. press CTRL-C and wait for the Quarkus to shut down\n5. check the database\n\n### Output of `uname -a` or `ver`\n\n_No response_\n\n### Output of `java -version`\n\n_No response_\n\n### GraalVM version (if different from Java)\n\n_No response_\n\n### Quarkus version or git rev\n\n_No response_\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\n_No response_\n\n### Additional information\n\n_No response_","author_login":"segersb","author_association":"NONE","created_at":"2023-10-03T13:05:26+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750528098","fragment_type":"issue_comment","sequence":1,"text":"I didn't try this locally yet (have to download an Oracle container on a low-bandwidth connection...), but IIUC the main problem is that the interceptor doesn't trigger a rollback before Agroal gets stopped (and connections get closed).\n\nI wonder if the root cause isn't simply that your thread gets interrupted, leading `Thread.sleep` to throw an `InterruptedException`, which, crucially, isn't a `RuntimeException` and thus doesn't trigger a rollback...\n\nSee URL \n \n\n(And yes I agree it's a crazily dangerous default, but that's the spec.)\n\nCould you try annotating your method with this instead, and tell me if it solves your problem?\n\njava\n@Transactional(rollbackOn={Exception.class})","author_login":"yrodiere","author_association":"MEMBER","created_at":"2023-10-06T12:05:40+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750603240","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your reply!\n\nThe result is still the same.\nI used Thread.sleep in a rest endpoint here to make a simple example.\nWe noticed the issue with longer running processes combined with redeployment on Openshift.\n\nI also verified this \"commit on close\" behavior with basic JDBC.\nIf I don't explicitly roll back, then the insert is committed when closing the connection.\nMy guess is that Oracle is the only database provider that behaves like this.\n\n try {\n Class.forName(\"oracle.jdbc.driver.OracleDriver\");\n conn = DriverManager.getConnection(jdbcUrl, username, password);\n conn.setAutoCommit(false);\n\n String insertSQL = \"INSERT INTO D00SREFTPB01.TEST_TABLE (TEST_COLUMN) VALUES (?)\";\n try (PreparedStatement pstmt = conn.prepareStatement(insertSQL)) {\n pstmt.setLong(1, System.currentTimeMillis());\n pstmt.executeUpdate();\n System.out.println(\"Dummy data inserted into TEST_TABLE\");\n }\n\n// conn.rollback();\n } catch (SQLException | ClassNotFoundException e) {\n e.printStackTrace();\n } finally {\n if (conn != null) {\n try {\n conn.close();\n } catch (SQLException e) {\n e.printStackTrace();\n }\n }\n }","author_login":"segersb","author_association":"NONE","created_at":"2023-10-06T12:43:04+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750632017","fragment_type":"issue_comment","sequence":3,"text":"That's for sure, and from what I can see it's well-known to Oracle users; found this in particular.\n\nI'm not too worried about Oracle's behavior though, more about the fact that the transaction wasn't rolled back by the interceptor (so, before the connection was closed), especially with `@Transactional(rollbackOn={Exception.class})`.\n\nThere must be something wrong on shutdown, maybe Agroal stopping before application threads, I don't know. Needs further investigation.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2023-10-06T12:55:53+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750652882","fragment_type":"issue_comment","sequence":4,"text":"Note I did fix the issue with a workaround by using a AgroalDataSourceListener.\n\nThe code is dirty as there is no out-of-the-box solution to set a custom AgroalDataSourceListener in Quarkus.\nI also created a feature request to allow for that ( URL \n\nBut in essence I just do a rollback in `beforeConnectionDestroy`\nNormally if the transaction was successful, Quarkus should have performed the commit and there would be nothing to roll back.\n\n@ApplicationScoped\npublic class CustomOracleRollback implements StartupInitializer, AgroalDataSourceListener {\n @Inject\n DataSources dataSources;\n\n @Override\n @SneakyThrows\n @SuppressWarnings(\"all\")\n public void initialize() {\n DataSource dataSource = (DataSource) dataSources.getDataSource(\" \");\n\n Field connectionPoolField = DataSource.class.getDeclaredField(\"connectionPool\");\n connectionPoolField.setAccessible(true);\n ConnectionPool connectionPool = (ConnectionPool) connectionPoolField.get(dataSource);\n\n Field listenersField = ConnectionPool.class.getDeclaredField(\"listeners\");\n listenersField.setAccessible(true);\n AgroalDataSourceListener[] listeners = (AgroalDataSourceListener[]) listenersField.get(connectionPool);\n\n List newListeners = new ArrayList<>(Arrays.asList(listeners));\n newListeners.add(this);\n\n Field theUnsafeField = Unsafe.class.getDeclaredField(\"theUnsafe\");\n theUnsafeField.setAccessible(true);\n Unsafe unsafe = (Unsafe) theUnsafeField.get(null);\n\n long offset = unsafe.objectFieldOffset(listenersField);\n AgroalDataSourceListener[] newListenersArray = newListeners.toArray(new AgroalDataSourceListener[0]);\n unsafe.putObject(connectionPool, offset, newListenersArray);\n }\n\n @Override\n public void beforeConnectionDestroy(Connection connection) {\n try {\n connection.rollback();\n } catch (SQLException e) {\n // ignore\n }\n }\n}","author_login":"segersb","author_association":"NONE","created_at":"2023-10-06T13:07:23+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750661423","fragment_type":"issue_comment","sequence":5,"text":"Note the issue is only happening on graceful shutdowns.\nI'm not sure how this is handled by Quarkus, but my guess is that the interceptor you are referring to never gets executed.\nMaybe the executor thread pool is just shut down with a timeout and threads are killed if they take too long to finish.","author_login":"segersb","author_association":"NONE","created_at":"2023-10-06T13:12:39+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750720778","fragment_type":"issue_comment","sequence":6,"text":"That's the thing: if threads are killed, the call to `Thread.sleep` should throw an `InterruptedException`, and if you put `@Transactional(rollbackOn={Exception.class})` on your method, that should trigger a rollback.\n\nAnd all that should happen before the DB connection gets closed, because why on earth would Quarkus stop DB connection pools before killing application threads...\n\nIf it doesn't happen that way, there's something wrong...\n\nAnother theory would be that `@SneakyThrows` somehow confuses Quarkus and leads to the interceptor misbehaving. While unlikely, I suppose that's possible.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2023-10-06T13:53:38+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1846910321","fragment_type":"issue_comment","sequence":7,"text":"Unfortunately I didn't have time to make progress on this.\n \n \n \n\nI had to work on the Agroal code recently, and noticed this:\n\n URL \n\nIf Vert.x threads are killed in the same way, there's indeed a chance the order is undetermined (vertx threads may be killed before or after agroal connection pools, depending on who knows what)","author_login":"yrodiere","author_association":"MEMBER","created_at":"2023-12-08T10:15:18+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1848401459","fragment_type":"issue_comment","sequence":8,"text":"Maybe killing the applications threads don't cause an explicit rollback of the transaction?\n\nI can't really comment on Quarkus internals, but the root cause of my issue is that Oracle commits on close.\nThe dirty workaround I have now simply makes sure there is always an explicit rollback before the close.\nI believe the custom listener I made is triggered by the `dataSource.close()` in the code you mentioned.\n\nI'm not sure what the best solution is for Quarkus.\nThe \"explicit rollback before close\" solution seems pretty robust to me.\nBut you could argue it's redundant and should be handled by the code behind @Transactional and the shutdown order.","author_login":"segersb","author_association":"NONE","created_at":"2023-12-09T12:52:41+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1849497304","fragment_type":"issue_comment","sequence":9,"text":"If you used `@Transactional(rollbackOn={Exception.class})` (and you said earlier you did try that), then `InterruptedException` definitely should cause a rollback, at least that's how I understand the spec.\nBut yes, maybe the bug is there, we'll need to check.\n \n\nYeah that... is really a dubious design choice. I guess we could override this behavior by default if there's a setting in the JDBC driver, but then if you had to resort to complicated listeners, I guess there isn't such a setting.\n \n\nExactly. Because there might be other, similar problems caused by this (still hypothetical) wrong shutdown order.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2023-12-11T07:53:51+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1861096132","fragment_type":"issue_comment","sequence":10,"text":"HI!\n\nProbably, we also encountered the mentioned unexpected commit.\n\nThis commit occurred for us when we tried to shut down Wildfly(27) gracefully. At that time, we noticed that in some cases, only a part of the tables was committed to the Oracle database (we experienced the same on PostgreSQL).\n\nsee: \n URL \n\nThere exists a property in version 1.5.9.Final ironjacamar jdbc where this can be set, and after that, the cleanup function handles the commit as expected for us (checked the main branch, its also looks good to me):\n\n URL \n(JAVA_OPTS: \"-Dironjacamar.jdbc.setautocommitoncleanup=false\")\n\nWithout this, we also observed that records appeared in the database that shouldn't have.\nI think Quarkus also uses similar libraries; perhaps it will help.\n\nSome tickets we started from:\n URL \n URL","author_login":"czenczl","author_association":"NONE","created_at":"2023-12-18T17:13:59+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1861628867","fragment_type":"issue_comment","sequence":11,"text":"Thanks for the input!\n\nI tried looking for some property to set before, but didn't find any.\nMaybe the Quarkus devs can work with this.\n\nIn sqlplus it's the same behavior and you can turn it off with `set exitcommit off` (it's on by default)\nHowever I was unable to find the same setting on the OJBDC driver.","author_login":"segersb","author_association":"NONE","created_at":"2023-12-18T21:01:11+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1905734093","fragment_type":"issue_comment","sequence":12,"text":"Hey @segersb , while working on something else I stumbled upon this: URL \n\nCould you confirm that when you talk about graceful shutdowns, you mean it in this specific sense (you set `quarkus.shutdown.timeout` in your app), not in a more general, technology-agnostic sense? Because apparently Quarkus shutdowns are not, by default, graceful.\n\nThis probably doesn't change the problem, but would be interesting to know.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2024-01-23T10:21:47+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930468023","fragment_type":"issue_comment","sequence":13,"text":"Hello @yrodiere \n\nWe haven't set anything specific for that parameter, so we just use the default.\n\nWe detected the issue when running our Quarkus app on OpenShift.\nWe have a batch with a long transaction that inserts records in a database.\nOf course we expect that either all the records or none are inserted.\n\nWhen a redeploy is done in OpenShift while this batch is running, we end up having partial data.\n\nWhen running the standard `mvn quarkus-dev` + CTRL-C locally, we could not replicate this issue.\nWhen pressing CTRL-C the process is terminated and the prompt is shown instantly.\n\nWhen running the quarkus:dev via java.exe + CTRL-C locally, we were able to replicate the issue.\nWhen pressing CTRL-C it takes a while before the process is terminated and the prompt is shown.\n\nThis led us to the conclusion that the shutdown method is somehow involved.\nWhen the issue occurs it seems that the connection is explicitly closed, causing Oracle to commit on close.\nWhen the application is instantly terminated there is no issue since Oracle does no commit when the connection is lost.","author_login":"segersb","author_association":"NONE","created_at":"2024-02-06T17:51:43+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936171196","fragment_type":"issue_comment","sequence":14,"text":"Hi, we also have this exact issue. First observed in our Kubernetes-based test environment, where Kubernetes sends a SIGTERM to the Quarkus app, after which a partial transaction got committed to the Oracle DB.\n\nI can reliably reproduce it using Quarkus dev mode and pressing `CTRL+C` or `q` during a large transaction with 100k+ inserts to multiple tables. Then, some thousands of table entries are visible, but not all.\n\nUsing the workaround from @segersb above ( URL almost, but not quite, fixes the issue. The call to rollback happens without throwing an exception, but a SINGLE table entry is still inserted anyway.\n\nOne thing I've noted is that \"Arjuna\" also tries to rollback the transaction, but fails because the connection was already closed:\n\n`[co.ar.at.jta] (database-worker-saving-entities-1) ARJUNA016045: attempted rollback of (io.agroal.narayana.LocalXAResource@5158e0b4) failed with exception code XAException.XAER_RMERR: javax.transaction.xa.XAException: Error trying to transactionRollback local transaction: ORA-17008: Closed connection\n`\n\nI'd be very happy if Quarkus could reliably rollback all open transactions BEFORE closing the connections.\nWe're currently using Quarkus 3.6.8, graceful shutdown timeout not enabled.","author_login":"ivu-mawi","author_association":"NONE","created_at":"2024-02-09T15:52:55+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[1924112701],"is_known_query_context":false},{"document_id":"gh_comment_1936264954","fragment_type":"issue_comment","sequence":15,"text":"Hi @ivu-mawi, \n\nThanks for your input!\n\nDoes your project maybe have multiple datasources?\nI'm hoping that might explain why the workaround is not fully working on your end.\nIt was specifically made for our use case with only the default datasource:\n`DataSource dataSource = (DataSource) dataSources.getDataSource(\" \");`\n\nIf not I'm a bit worried we'll also encounter issues in our projects.","author_login":"segersb","author_association":"NONE","created_at":"2024-02-09T16:53:29+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936297408","fragment_type":"issue_comment","sequence":16,"text":"Hi, also thanks for reporting this and the workaround.\n\nI'm afraid we also use a single, default datasource.\n\nThe single inserted entry doesn't always occur. But I'm guessing it only doesn't occur when I press `CTRL+C` too quickly before hibernate has decided to actually send statements to the driver or something.","author_login":"ivu-mawi","author_association":"NONE","created_at":"2024-02-09T17:16:16+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936362914","fragment_type":"issue_comment","sequence":17,"text":"I think my workaround now will be to simply `Thread.sleep` in a method that `@Observes ShutdownEvent` and only returns when all currently active transactions have finished. (We have some code that wraps all relevant transactions, so I'll keep a counter there and sleep until it reaches zero.)\n\nThis might mean waiting too long, so Kubernetes will SIGKILL our app. But this leaves no chance to properly close the oracle connections, and even Oracle does a rollback then in my tests, same as `CTRL+C` on Windows as you mentioned.\n\nBut I don't know how this would interact with any other ShutdownEvent Observers, if we had any. Would this delay the other ones, preventing their graceful shutdown until SIGKILL happens? Not a good solution in that case.","author_login":"ivu-mawi","author_association":"NONE","created_at":"2024-02-09T17:57:51+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936414035","fragment_type":"issue_comment","sequence":18,"text":"That's a creative workaround!\n\nNormally you should be able to use @Priority annotation to make sure other shutdown listeners go first.\nWe used that in the past for startup listeners, so I guess it will also work for shutdown.\n\nSIGKILL always worked for me as well because Oracle only commits when connections are closed properly.\nI guess a shutdown listener that sleeps forever could also work, effectively forcing kube/oc to kill the pods.\n\nAnother approach might be to combine the Quarkus property `quarkus.shutdown.timeout` and the kube property `terminationGracePeriodSeconds`\n`quarkus.shutdown.timeout=30S` would make sure Quarkus does not start closing connections after 30S to be sure\n`terminationGracePeriodSeconds: 0` would cause kube to kill the pods","author_login":"segersb","author_association":"NONE","created_at":"2024-02-09T18:30:27+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1943435771","fragment_type":"issue_comment","sequence":19,"text":"Thanks, `@Priority` works!\n\nI agree with the rest.\n\nI'll stick with my \"dynamic\" delay, because it allows a normal graceful shutdown if no transactions are running, or very short transactions, which I expect is the much more likely scenario for our app. So the SIGKILL from Kubernetes would only be a rare last resort kind of thing, if someone happens to trigger a restart during one of those rare long transactions.\n\nStill, would be much nicer if Quarkus rolls back before close of course :)","author_login":"ivu-mawi","author_association":"NONE","created_at":"2024-02-14T10:04:30+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945905466","fragment_type":"issue_comment","sequence":20,"text":"Great it helped!\n\nInterestingly the doc for using `quarkus.shutdown.timeout` says: \"Setting this timeout will incur a small performance penalty, as it requires active requests to be tracked.\" I guess they have a similar code to yours to track the open transactions.\n\nIf you still have issues, you could also play with the values of those properties.\n`terminationGracePeriodSeconds` can be set to maybe 30 second or so while `quarkus.shutdown.timeout` could be set to a minute.\nIn a \"normal\" redeploy Quarkus should be able to shut down within the grace period op kube.","author_login":"segersb","author_association":"NONE","created_at":"2024-02-15T11:28:04+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1971026593","fragment_type":"issue_comment","sequence":21,"text":"@yrodiere @gsmet \nSince I'm not alone having this issue, would it be possible to have a solution in Quarkus?\nThe fact that we risk having partial transactions committed when using Oracle is not reassuring.\nWhen updating Quarkus we always have doubts that out dirty workaround keeps working properly.","author_login":"segersb","author_association":"NONE","created_at":"2024-02-29T12:23:19+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1971063601","fragment_type":"issue_comment","sequence":22,"text":"I agree it's a problem, and I agree it should be solved. It's on my todo-list, but that todo-list is long and does not include just Quarkus.\n\nIf you want this to be solved quicker, feel free to send a PR or report this through paid support (on RHBQ, ...).\n\nFailing that, you can rely on workarounds (I think a few were mentioned?) and I guess you can hope that the upgrade of Agroal #39072 will change something.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2024-02-29T12:44:02+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2135184594","fragment_type":"issue_comment","sequence":23,"text":"Stumbling across this after days of investigating a swath of lost data that was a consequence of some intermittent state being erroneously committed, I am thankful to have found this discussion and being able to present the workaround originally presented by @segersb in URL with the new capabilities added by URL incorporated to simplify it:\n\njava\n/**\n * Oracle has the weird behavior that it performs an implicit commit on normal connection closure (even with auto-commit disabled),\n * which happens on application shutdown. To prevent whatever intermittent state we have during shutdown from being committed,\n * we add an explicit rollback to each connection closure. If the connection has already received a COMMIT, the rollback will not work, which is fine.\n * \n * The code unwraps the {@link Connection} so that we perform the rollback directly on the underlying database connection,\n * and not on e.g. Agroal's {@link ConnectionWrapper} which can prevent the rollback from actual being executed due to some safeguards.\n */\n@ApplicationScoped\npublic class CustomOracleRollback implements AgroalPoolInterceptor {\n @Override\n public void onConnectionDestroy(Connection connection) {\n try {\n connection.unwrap(Connection.class).rollback();\n } catch (SQLException e) {\n Log.tracef(e, \"Ignoring exception during rollback on connection close\");\n }\n }\n}","author_login":"Felk","author_association":"CONTRIBUTOR","created_at":"2024-05-28T13:11:52+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[1924112701],"is_known_query_context":false},{"document_id":"gh_comment_2135220398","fragment_type":"issue_comment","sequence":24,"text":"Hello @Felk \n\nI also did the same on our side, though I did have to add an extra check before doing the rollback.\nNot sure you need this, but mentioning it just in case.\nWe also use flyway on our side, and if I always did the rollback, the migration failed.\n\nThe `connection.isClosed()` check was just to avoid exception logging.\nThe `connection.getAutoCommit()` check was the important one that fixed the flyway migrations.\n\n @SneakyThrows\n @Override\n public void onConnectionDestroy(Connection connection) {\n if (connection.isClosed() || connection.getAutoCommit()) {\n return;\n }\n\n OracleConnection oracleConnection = connection.unwrap(OracleConnection.class);\n oracleConnection.rollback();\n }","author_login":"segersb","author_association":"NONE","created_at":"2024-05-28T13:28:06+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2135230659","fragment_type":"issue_comment","sequence":25,"text":"Good point, thanks! I edited my comment to include those two conditions","author_login":"Felk","author_association":"CONTRIBUTOR","created_at":"2024-05-28T13:32:46+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2288174650","fragment_type":"issue_comment","sequence":26,"text":"This is starting to look like the most likely explanation given what I learned in URL \n \n \n \n\nSo a possible fix would be to make sure Agroal shuts down after Vertx... that probably means the Vertx extension needs to use `ShutdownEvent`. We'd need to check if that's already the case; if so, then the problem is elsewhere.","author_login":"yrodiere","author_association":"MEMBER","created_at":"2024-08-14T08:37:09+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2295290210","fragment_type":"issue_comment","sequence":27,"text":"Vert.x should be the last to shut down. Otherwise, many things would not be functional. \n\nWe can imagine an SPI indicating when Vert.x has been shut down (it's an async operation so after completion) for the cases where things must happen after (it should be rare and used with a lot of caution)","author_login":"cescoffier","author_association":"MEMBER","created_at":"2024-08-18T14:54:53+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2310383444","fragment_type":"issue_comment","sequence":28,"text":"I see, and yes I understand, as Hibernate Reactive for example would no longer work after vertx shut down. And may not be able to shut down, as shutdown in Hibernate Reactive may imply executing SQL statements...\n\nCould we perhaps have an event after vertx has stopped accepting new incoming requests and finished processing existing requests? That's more or less what we need here: the guarantee that nothing external will attempt to initiate use of datasources.\n\nThough I suppose other components unrelated to vertx (Cron? other servers with more exotic protocols?) could be triggering something similar. We may want a different form of synchronization... a two-step shutdown perhaps?","author_login":"yrodiere","author_association":"MEMBER","created_at":"2024-08-26T14:40:25+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2563849378","fragment_type":"issue_comment","sequence":29,"text":"I think we should aim at fixing this thing for the next LTS, either by going Yoann's way ^. It's not the first time that we had issues with shutdown ordering so taking a step back and listing all the issues to find a global solution would be awesome.\n\nIn the meantime, I wonder if we should include URL in the `quarkus-jdbc-oracle` extension.\n\nI will create a PR with ^ to get the ball rolling.","author_login":"gsmet","author_association":"MEMBER","created_at":"2024-12-27T16:25:23+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[1924112701],"is_known_query_context":false},{"document_id":"gh_comment_2563887841","fragment_type":"issue_comment","sequence":30,"text":"I created URL for discussion. Thanks for all the good discussions in this issue!","author_login":"gsmet","author_association":"MEMBER","created_at":"2024-12-27T17:18:01+08:00","repo_name":"quarkusio/quarkus","issue_id":1924112701,"issue_number":36265,"issue_url":"https://github.com/quarkusio/quarkus/issues/36265","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0171","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Add Allocs page enabling Jobs -> Allocs -> Tasks flow.","query_context":"**Is your feature request related to a problem? Please describe.**\nI'm running my blockchain nodes on Nomad and many chains are run with many sidecars (tasks) together.\nMy interaction with them is always focused on a particular alloc and particular task. They're pets and not cattle.\n\ntasks-allocs-merged-view\n\nfocused-on-single-alloc\n\nHence I value the ability to focus on Allocs and then Tasks associated with it. The merged view is distracting and\nrequires extra work to filter out the noise.\n\n**Describe the solution you'd like**\nIf I can drill down from Jobs -> Allocs -> Tasks, it would be a great UX.\nPeace of mind, less noise.\n\n**Describe alternatives you've considered**\nI can use the filter, but it's not as intuitive as the drill down. Besides, it has a nagging bug; after the initial filter\nif I move to next filtered row, after the tick, the selection jumps back to the first filtered row. Also it doesn't hide\nthe unfiltered rows.\n\nBut even if the filter works perfectly, it's not as intuitive as the drill down.\n\n**Additional context**\nI've played around and implemented the drill down version along with alloc restart in in #126. Would be great to have it in the mainline.","known_context_document_ids":["gh_issue_2116927303"],"reference_answer":"@cshintov this should be fixed in `next` (`go install github.com/robinovitch61/wander@next`) now. Mind giving it a shot when you get the chance and letting me know if there is any other undesirable behavior?","answer_document_id":"gh_comment_1925816932","silver_evidence_path":["gh_comment_1925802734","gh_issue_2117160877","gh_comment_1925816932"],"evidence_issue_ids":[2116927303,2117160877],"source_repo_name":"robinovitch61/wander","source_issue_id":2116927303,"source_issue_number":127,"source_issue_url":"https://github.com/robinovitch61/wander/issues/127","target_repo_name":"robinovitch61/wander","target_issue_id":2117160877,"target_issue_number":128,"target_issue_url":"https://github.com/robinovitch61/wander/issues/128","reference_anchor_document_id":"gh_comment_1925802734","reference_answer_author":"robinovitch61","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1159,"anchor_target_overlap":0.1569,"target_answer_overlap":0.1667},"issue_created_at":"2024-02-04T07:35:35+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2116927303","fragment_type":"issue_description","sequence":0,"text":"Add Allocs page enabling Jobs -> Allocs -> Tasks flow.\n**Is your feature request related to a problem? Please describe.**\nI'm running my blockchain nodes on Nomad and many chains are run with many sidecars (tasks) together.\nMy interaction with them is always focused on a particular alloc and particular task. They're pets and not cattle.\n\ntasks-allocs-merged-view\n\nfocused-on-single-alloc\n\nHence I value the ability to focus on Allocs and then Tasks associated with it. The merged view is distracting and\nrequires extra work to filter out the noise.\n\n**Describe the solution you'd like**\nIf I can drill down from Jobs -> Allocs -> Tasks, it would be a great UX.\nPeace of mind, less noise.\n\n**Describe alternatives you've considered**\nI can use the filter, but it's not as intuitive as the drill down. Besides, it has a nagging bug; after the initial filter\nif I move to next filtered row, after the tick, the selection jumps back to the first filtered row. Also it doesn't hide\nthe unfiltered rows.\n\nBut even if the filter works perfectly, it's not as intuitive as the drill down.\n\n**Additional context**\nI've played around and implemented the drill down version along with alloc restart in in #126. Would be great to have it in the mainline.","author_login":"cshintov","author_association":"CONTRIBUTOR","created_at":"2024-02-04T07:35:35+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1925802734","fragment_type":"issue_comment","sequence":1,"text":"Thanks for opening this for discussion @cshintov . To summarize, wander currently has 2 levels of drill-down: 1) jobs and 2) allocations and tasks combined in one table. This proposal would change that to 3 levels: 1) jobs, 2) allocations and 3) tasks, more similar to the web ui's model.\n\nI'm interested in getting more data before proceeding with this change, as I personally see the 2 level model as an advantage, but am open to shifting to 3 level if there's broader support.\n \n\nAh, that's super annoying behavior! Broke it out into a bug issue here: URL \n \n\nIf you run wander with `--filter-with-context=false` or the equivalent env var/config option, it will only show matching rows\n \n\nIf you want to extract out the alloc restart functionality and PR just that against `next` right now in a separate PR, we should be able to get that merged quickly regardless of the outcome of this drill-down discussion!","author_login":"robinovitch61","author_association":"OWNER","created_at":"2024-02-04T15:54:06+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[2117160877],"is_known_query_context":false},{"document_id":"gh_comment_1925804750","fragment_type":"issue_comment","sequence":2,"text":"@coderigo @classabbyamp @qwo @viniciusartur @Antse @sheridanvk @ghthor @yuankaiyu @hoppel @chuckyz @foozmeat @neomantra @bbarg @dbalan @beakman @moyiz ,\n\nYou've all contributed to or opened issues in wander before. Assuming you are or were users of it, what do you think of this proposal:","author_login":"robinovitch61","author_association":"OWNER","created_at":"2024-02-04T16:00:40+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1927354180","fragment_type":"issue_comment","sequence":3,"text":"I'm personally a fan of the existing drill down levels, though I haven't run into a case as the OP where it is hindering any of my workflows.\n\nMy question to the @cshintov. If you could group/sort by the alloc ID in the combined view, would that improve your workflow? That's an additional sorting mode, where the current sorting mode is based on the task name only.","author_login":"ghthor","author_association":"NONE","created_at":"2024-02-05T16:14:18+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928725710","fragment_type":"issue_comment","sequence":4,"text":"I too like the current drill-down levels, I don't know that layering it one\nextra level adds much from when I've used it as by the time I get to a job\nthings tend to easily fit on one screen without paginating and it's obvious\nwhich alloc belongs to which task.\n\nOn Tue, Feb 6, 2024 at 3:14 AM Will Owens ***@***.***> wrote:","author_login":"coderigo","author_association":"NONE","created_at":"2024-02-06T03:36:16+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928780557","fragment_type":"issue_comment","sequence":5,"text":"Ya, this could work if combined with `--filter-with-context=false`, **but still more work - more key presses and brain cycles**.","author_login":"cshintov","author_association":"CONTRIBUTOR","created_at":"2024-02-06T04:50:34+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929599968","fragment_type":"issue_comment","sequence":6,"text":"Although I understand why the Web GUI is that way, I find myself jumping a lot between the Alloc/Task windows in the Web GUI. And very often I want to check out the `alloc` files but that's not directly available from the `task` so you have to jump around, etc. But then for an alloc you often need some minor task info and need to pop into the task page.\n\nSo I like how `wander` does it currently, but I don't have as many allocs/tasks as OP.\n\nI thus appreciate that one drills down from Allocs into a Task; but I'd still want the current display at the Alloc level.\n\nThe power of TUI is that you can get to the where you want very easily -- enter/escape into a Task view is consistent with this. That said, if a filter/sort helps achieve the same, then that might be simpler.\n\nIs there any particular content/UX in a Task pane that would be different than the Alloc-focused pane? In OPs example, they look identical.","author_login":"neomantra","author_association":"CONTRIBUTOR","created_at":"2024-02-06T13:26:52+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930494251","fragment_type":"issue_comment","sequence":7,"text":"This is a great idea. What if we sorted such that the \"all tasks for job\" page's first rows were the first task in each allocation, eg\n\nAlloc A Task 1\nAlloc B Task 1\nAlloc C Task 1\nAlloc A Task 2\n...\n\nAnd pressing \"t\" on one of these rows brings you to a \"tasks only for this allocation\" page. Do you think this is a nice middleground @cshintov ?","author_login":"robinovitch61","author_association":"OWNER","created_at":"2024-02-06T18:07:39+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1931273788","fragment_type":"issue_comment","sequence":8,"text":"I think this is the reason why I want a focused view, and others don't. At small numbers (without many sidecars) it doesn't matter much. \n\nYa, the above proposal might work, but I don't think it's needed, because without `filter with context` there's already a middle ground.\n\nBut if the majority of users are fine with the current view, it's OK. \n\nBesides, I can maintain my own version for my use case; that's the beauty and purpose of open source, isn't it?","author_login":"cshintov","author_association":"CONTRIBUTOR","created_at":"2024-02-07T04:44:56+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932299094","fragment_type":"issue_comment","sequence":9,"text":"| Besides, I can maintain my own version for my use case; that's the beauty and purpose of open source, isn't it?\n\nThe other beauty is that the openness allows us to have broader awareness so that we can all be more powerful together. I certainly want large Nomad installations to exist and operate well, even though I don't have a large one myself...\n\nIf you do experiment with your idea and make a PR or fork, please note it on this issue =)","author_login":"neomantra","author_association":"CONTRIBUTOR","created_at":"2024-02-07T15:32:27+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932436523","fragment_type":"issue_comment","sequence":10,"text":"Sweet, thanks all for the discussion here. Sounds like `--filter-with-context=false` is a good enough middle ground for now. I'd be happy to add the \"t for allocation-specific tasks\" implementation here if desired in the future, but will close this issue for now as it seems like no one needs it yet. Anyone feel free to reopen or open a new issue referencing this one if you want to.","author_login":"robinovitch61","author_association":"OWNER","created_at":"2024-02-07T16:36:44+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1933300232","fragment_type":"issue_comment","sequence":11,"text":"@neomantra \n \n\nI had first raised the PR and then opened the issue 🙂\nYou can find it here: #126","author_login":"cshintov","author_association":"CONTRIBUTOR","created_at":"2024-02-08T03:18:06+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1935645097","fragment_type":"issue_comment","sequence":12,"text":"Glad to hear that you loved Kerala. Seems like you are fond of India. Your profile pic, the handle, etc! 🙏","author_login":"cshintov","author_association":"CONTRIBUTOR","created_at":"2024-02-09T10:06:13+08:00","repo_name":"robinovitch61/wander","issue_id":2116927303,"issue_number":127,"issue_url":"https://github.com/robinovitch61/wander/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2117160877","fragment_type":"issue_description","sequence":0,"text":"Search selection jumps back to first result on page reload/refresh\n**Describe the bug**\nSearch selection jumps back to first result on page reload/refresh\n\n**To reproduce**\nRun `wander -u 1` in \"filter with context\" mode on (the default), filter for results, hit `n` to see the next result, and wait. Selection will jump back on page refresh\n\n**Expected behavior**\nFilter selection should be preserved after refresh to the best ability (if result disappears on refresh, should be as close as possible to result)\n\n**Additional context**\nReported in URL","author_login":"robinovitch61","author_association":"OWNER","created_at":"2024-02-04T15:49:35+08:00","repo_name":"robinovitch61/wander","issue_id":2117160877,"issue_number":128,"issue_url":"https://github.com/robinovitch61/wander/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925816932","fragment_type":"issue_comment","sequence":1,"text":"@cshintov this should be fixed in `next` (`go install github.com/robinovitch61/wander@next`) now. Mind giving it a shot when you get the chance and letting me know if there is any other undesirable behavior?","author_login":"robinovitch61","author_association":"OWNER","created_at":"2024-02-04T16:24:30+08:00","repo_name":"robinovitch61/wander","issue_id":2117160877,"issue_number":128,"issue_url":"https://github.com/robinovitch61/wander/issues/128","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0172","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Segfault when importing sklearn as well, osx-arm64?","query_context":"### Solution to issue cannot be found in the documentation.\n\n- [X] I checked the documentation.\n\n### Issue\n\nThis issue affects the conda-forge version too.\n\nThe solution is `export PACKAGE_TYPE=\"conda\"` in the recipe. This was the change that introduced the bug. It puts an openmp into the site-packages directory and uses that one, if the above env variable isn't set.\n\nSome more info:\notool -L on the libraries to see what they’re linking against:\n\npytorch v2.2:\n\n/Users/dpetry/miniconda3/envs/test_torch_torchonly/lib/python3.12/site-packages/torch/lib/libtorch_cpu.dylib:\n ...\n @rpath/libomp.dylib (compatibility version 5.0.0, current version 5.0.0)\n ...\n\npytorch v.2.3:\n\n/Users/dpetry/miniconda3/envs/test_torch_torchonly/lib/python3.12/site-packages/torch/lib/libomp.dylib:\n @rpath/libomp.dylib (compatibility version 5.0.0, current version 5.0.0)\n ...\n \n/Users/dpetry/miniconda3/envs/test_torch_torchonly/lib/python3.12/site-packages/torch/lib/libtorch_cpu.dylib:\n ...\n @loader_path/libomp.dylib (compatibility version 5.0.0, current version 5.0.0)\n ...\n\n### Installed packages\n\nshell\nn/a\n\n### Environment info\n\nshell\nn/a","known_context_document_ids":["gh_issue_2514714042"],"reference_answer":"They seem to bundle `libomp.dylib`.\n\nFollowing should fix this issue\n\ndiff --git a/recipe/build_pytorch.sh b/recipe/build_pytorch.sh\nindex cd27be0..c6cb567 100644\n--- a/recipe/build_pytorch.sh\n+++ b/recipe/build_pytorch.sh\n@@ -1,13 +1,9 @@\n set -x\n-if [[ \"$megabuild\" == true ]]; then\n- source $RECIPE_DIR/build.sh\n- pushd $SP_DIR/torch\n- for f in bin/* lib/* share/* include/*; do\n- if [[ -e \"$PREFIX/$f\" ]]; then\n- rm -rf $f\n- ln -sf $PREFIX/$f $PWD/$f\n- fi\n- done\n-else\n- $PREFIX/bin/python -m pip install torch-*.whl\n-fi\n+source $RECIPE_DIR/build.sh\n+pushd $SP_DIR/torch\n+for f in bin/* lib/* share/* include/*; do\n+ if [[ -e \"$PREFIX/$f\" ]]; then\n+ rm -rf $f\n+ ln -sf $PREFIX/$f $PWD/$f\n+ fi\n+done","answer_document_id":"gh_comment_2189236625","silver_evidence_path":["gh_comment_2347385188","gh_issue_2368579864","gh_comment_2189236625"],"evidence_issue_ids":[2514714042,2368579864],"source_repo_name":"conda-forge/pytorch-cpu-feedstock","source_issue_id":2514714042,"source_issue_number":260,"source_issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","target_repo_name":"conda-forge/pytorch-cpu-feedstock","target_issue_id":2368579864,"target_issue_number":243,"target_issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","reference_anchor_document_id":"gh_comment_2347385188","reference_answer_author":"isuruf","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1304,"anchor_target_overlap":0.3261,"target_answer_overlap":0.1176},"issue_created_at":"2024-09-09T19:10:21+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_2514714042","fragment_type":"issue_description","sequence":0,"text":"Segfault when importing sklearn as well, osx-arm64\n### Solution to issue cannot be found in the documentation.\n\n- [X] I checked the documentation.\n\n### Issue\n\nThis issue affects the conda-forge version too.\n\nThe solution is `export PACKAGE_TYPE=\"conda\"` in the recipe. This was the change that introduced the bug. It puts an openmp into the site-packages directory and uses that one, if the above env variable isn't set.\n\nSome more info:\notool -L on the libraries to see what they’re linking against:\n\npytorch v2.2:\n\n/Users/dpetry/miniconda3/envs/test_torch_torchonly/lib/python3.12/site-packages/torch/lib/libtorch_cpu.dylib:\n ...\n @rpath/libomp.dylib (compatibility version 5.0.0, current version 5.0.0)\n ...\n\npytorch v.2.3:\n\n/Users/dpetry/miniconda3/envs/test_torch_torchonly/lib/python3.12/site-packages/torch/lib/libomp.dylib:\n @rpath/libomp.dylib (compatibility version 5.0.0, current version 5.0.0)\n ...\n \n/Users/dpetry/miniconda3/envs/test_torch_torchonly/lib/python3.12/site-packages/torch/lib/libtorch_cpu.dylib:\n ...\n @loader_path/libomp.dylib (compatibility version 5.0.0, current version 5.0.0)\n ...\n\n### Installed packages\n\nshell\nn/a\n\n### Environment info\n\nshell\nn/a","author_login":"danpetry","author_association":"NONE","created_at":"2024-09-09T19:10:21+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2339037093","fragment_type":"issue_comment","sequence":1,"text":"The referenced issue ( URL ) points to a user recreating the bug with \"anaconda's default channel\". We do not use \"anaconda default channel\" packages.\n\nIf you can recreate with conda-forge only channel:\n\nplease provide all the requested outputs from the issue template. they are critical when troubleshooting this.\n\nconda create --name pt python=3.11 pytorch scikit-learn --channel conda-forge --override-cannels\n\nthen we can start to investigate.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-09-09T20:34:32+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2339041973","fragment_type":"issue_comment","sequence":2,"text":"I also worked on a similar issue 2 months ago\n URL \n\nso getting the full output from you would really help troubleshoot things.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-09-09T20:37:20+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2347346433","fragment_type":"issue_comment","sequence":3,"text":"yes, can recreate with c-f channel. will provide more shortly","author_login":"danpetry","author_association":"NONE","created_at":"2024-09-12T22:24:41+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2347385188","fragment_type":"issue_comment","sequence":4,"text":"Thank you for the detailed installation and recreation.\n\nSo from your experiments I can see that:\n\n* Pytorch 2.4.0 no issue\n* Pytorch 2.3.0 issue\n\nCan you try to see if \n\npython -c \"import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)\"\n\nrecreates things with pytorch 2.3.0 build 0. \n\nI think I hit this issue with: URL \n\nWe fixed it in 2.3.1 build 1 URL \n\nI'm honestly not sure how far back to mark the pytorch M1 builds as broken.\n\nIf you do the investigation, all with the conda-forge channel channel only, and show your work, I can try to merge in a PR that you make \n URL \n\nI unfortunately do not have an OSX arm machine, so it isn't easy for me to test.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-09-12T23:03:25+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[2368579864],"is_known_query_context":false},{"document_id":"gh_comment_2349359607","fragment_type":"issue_comment","sequence":5,"text":"ok, cool. I can do this if you feel it's useful to your users? I maintain the pytorch recipe at anaconda, so this wouldn't be work that benefits me directly - I just thought making you aware of it might be helpful. But I'm happy to do it if you feel it's valuable. If it's low-priority and it's just making more work for you then no worries. Let me know :)","author_login":"danpetry","author_association":"NONE","created_at":"2024-09-13T16:35:48+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2349363707","fragment_type":"issue_comment","sequence":6,"text":"And in general, let me know to what extent collaboration would be welcome from you.","author_login":"danpetry","author_association":"NONE","created_at":"2024-09-13T16:37:08+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2349743161","fragment_type":"issue_comment","sequence":7,"text":"its not low priority as much as \"I can't really test it\".\n \n\nit is, but it might not be worth your time.\n \n\nGenerally speaking, i miss the days where the recipes were similar between conda-forge and anaconda. sharing ideas was much simpler. However, with things diverging, i'm not sure the extent that it is possible. Where is your pytorch recipe stored today?\n\nMy general understanding was that collaboration was still happening on the `python-channel` which introduced some small compatibility shims:\n URL \n\nI'm open to adding such shims. We have been having trouble with the aarch64 builds and that has been weighing me down.\n\nHelp there would be greatly appreciated! See URL","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-09-13T18:11:36+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2350461986","fragment_type":"issue_comment","sequence":8,"text":"Our recipe is here. It diverges a fair amount but there's some stuff in common too (I want to pull across the single building of libtorch stuff).\nIt'd be great to collaborate on v2.5.0 of pytorch, and I can have a look at the aarch issue if I get time before then.","author_login":"danpetry","author_association":"NONE","created_at":"2024-09-13T22:12:09+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438938326","fragment_type":"issue_comment","sequence":9,"text":"@hmaarrfk what was the aarch64 issue you were having specifically? I couldn't really tell from a glance over the issue. Are you still having them?","author_login":"danpetry","author_association":"NONE","created_at":"2024-10-25T21:58:48+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438939073","fragment_type":"issue_comment","sequence":10,"text":"\"\"PyTorch was compiled without NumPy support\" error when running on Linux aarch64 + CUDA (on NVIDIA GH200) using the conda-forge build of PyTorch 2.4.0.\"\nwas it this?","author_login":"danpetry","author_association":"NONE","created_at":"2024-10-25T21:59:27+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438952803","fragment_type":"issue_comment","sequence":11,"text":"Thanks. We heard about pytorch dropping their conda package builds. How's the support for win and triton at the moment? as I understand you don't have either, we can help with that if you need.","author_login":"danpetry","author_association":"NONE","created_at":"2024-10-25T22:14:21+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438964618","fragment_type":"issue_comment","sequence":12,"text":"You can find a list of issues URL \n\nI've tagged them all. I mean its all volunteer led. Comment on the appriopriate one, make a PR if you want to see it improve.\n\nSo help where you can. To companies that are interested in windows support, I simply suggest volunteering to build things. It goes a long way.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-10-25T22:26:45+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2441716605","fragment_type":"issue_comment","sequence":13,"text":"Oh, the conda-forge CI can't handle the pytorch build for windows? hmm ok.","author_login":"danpetry","author_association":"NONE","created_at":"2024-10-28T14:15:51+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2517260989","fragment_type":"issue_comment","sequence":14,"text":"Can one mark only the `macosx-arm64` builds for 2.3.0 as broken? If so, that seems like the one action item left here. If not, probably best to close this as fixed.","author_login":"rgommers","author_association":"NONE","created_at":"2024-12-04T12:50:12+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2517312919","fragment_type":"issue_comment","sequence":15,"text":"I'm happy to click the merge green button if one makes the PR listing the exact package names.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-12-04T13:13:30+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2517907162","fragment_type":"issue_comment","sequence":16,"text":"the bug is that users with osx-arm can accidentally install 2.3.0 and crash their system.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-12-04T16:14:59+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2517967355","fragment_type":"issue_comment","sequence":17,"text":"I've filed URL ; hope I got it right.\n\nUsed the following to get the package list:\n\nconda search 'libtorch=2.3.0[subdir=osx-arm64]' | awk '{ print \"osx-arm64/\" $1 \"-\" $2 \"-\" $3 \".conda\" }'\nconda search 'pytorch=2.3.0[subdir=osx-arm64]' | awk '{ print \"osx-arm64/\" $1 \"-\" $2 \"-\" $3 \".conda\" }'\nconda search 'pytorch-cpu=2.3.0[subdir=osx-arm64]' | awk '{ print \"osx-arm64/\" $1 \"-\" $2 \"-\" $3 \".conda\" }'","author_login":"mgorny","author_association":"CONTRIBUTOR","created_at":"2024-12-04T16:33:48+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2514714042,"issue_number":260,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/260","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2368579864","fragment_type":"issue_description","sequence":0,"text":"Segfault on M1 Macbook\n### Solution to issue cannot be found in the documentation.\n\n- [X] I checked the documentation.\n\n### Issue\n\nmamba create --name pytorch python=3.10 pytorch numpy --channel conda-forge --override-channels\nmamba activate pytorch\npython -c \"import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)\"\n\n### Installed packages\n\nshell\n% mamba list\n# packages in environment at /Users/mark/miniforge3/envs/pytorch:\n#\n# Name Version Build Channel\nbzip2 1.0.8 h93a5062_5 conda-forge\nca-certificates 2024.6.2 hf0a4a13_0 conda-forge\nfilelock 3.15.4 pyhd8ed1ab_0 conda-forge\nfsspec 2024.6.0 pyhff2d567_0 conda-forge\ngmp 6.3.0 h7bae524_2 conda-forge\ngmpy2 2.1.5 py310h3bc658a_1 conda-forge\njinja2 3.1.4 pyhd8ed1ab_0 conda-forge\nlibabseil 20240116.2 cxx17_hebf3989_0 conda-forge\nlibblas 3.9.0 22_osxarm64_openblas conda-forge\nlibcblas 3.9.0 22_osxarm64_openblas conda-forge\nlibcxx 17.0.6 he7857fb_1 conda-forge\nlibffi 3.4.2 h3422bc3_5 conda-forge\nlibgfortran 5.0.0 13_2_0_hd922786_3 conda-forge\nlibgfortran5 13.2.0 hf226fd6_3 conda-forge\nliblapack 3.9.0 22_osxarm64_openblas conda-forge\nlibopenblas 0.3.27 openmp_h6c19121_0 conda-forge\nlibprotobuf 4.25.3 hbfab5d5_0 conda-forge\nlibsqlite 3.46.0 hfb93653_0 conda-forge\nlibtorch 2.3.1 cpu_generic_hf1facdc_0 conda-forge\nlibuv 1.48.0 h93a5062_0 conda-forge\nlibzlib 1.3.1 hfb2fe0b_1 conda-forge\nllvm-openmp 18.1.8 hde57baf_0 conda-forge\nmarkupsafe 2.1.5 py310hd125d64_0 conda-forge\nmpc 1.3.1 h91ba8db_0 conda-forge\nmpfr 4.2.1 h41d338b_1 conda-forge\nmpmath 1.3.0 pyhd8ed1ab_0 conda-forge\nncurses 6.5 hb89a1cb_0 conda-forge\nnetworkx 3.3 pyhd8ed1ab_1 conda-forge\nnomkl 1.0 h5ca1d4c_0 conda-forge\nnumpy 2.0.0 py310h52bbd9b_0 conda-forge\nopenssl 3.3.1 hfb2fe0b_0 conda-forge\npip 24.0 pyhd8ed1ab_0 conda-forge\npython 3.10.14 h2469fbe_0_cpython conda-forge\npython_abi 3.10 4_cp310 conda-forge\npytorch 2.3.1 cpu_generic_py310hb190f2a_0 conda-forge\nreadline 8.2 h92ec313_1 conda-forge\nsetuptools 70.1.0 pyhd8ed1ab_0 conda-forge\nsleef 3.5.1 h156473d_2 conda-forge\nsympy 1.12.1 pypyh2585a3b_103 conda-forge\ntk 8.6.13 h5083fa2_1 conda-forge\ntyping_extensions 4.12.2 pyha770c72_0 conda-forge\ntzdata 2024a h0c530f3_0 conda-forge\nwheel 0.43.0 pyhd8ed1ab_1 conda-forge\nxz 5.2.6 h57fd34a_0 conda-forge\n\n### Environment info\n\nshell\n% conda info\n\n active environment : pytorch\n active env location : /Users/mark/miniforge3/envs/pytorch\n shell level : 2\n user config file : /Users/mark/.condarc\n populated config files : /Users/mark/miniforge3/.condarc\n /Users/mark/.condarc\n conda version : 24.5.0\n conda-build version : not installed\n python version : 3.10.14.final.0\n solver : libmamba (default)\n virtual packages : __archspec=1=m1\n __conda=24.5.0=0\n __osx=14.5=0\n __unix=0=0\n base environment : /Users/mark/miniforge3 (writable)\n conda av data dir : /Users/mark/miniforge3/etc/conda\n conda av metadata url : None\n channel URLs : URL \n URL \n package cache : /Users/mark/miniforge3/pkgs\n /Users/mark/.conda/pkgs\n envs directories : /Users/mark/miniforge3/envs\n /Users/mark/.conda/envs\n platform : osx-arm64\n user-agent : conda/24.5.0 requests/2.32.3 CPython/3.10.14 Darwin/23.5.0 OSX/14.5 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8\n UID:GID : 503:20\n netrc file : None\n offline mode : False","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-06-23T14:05:40+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2368579864,"issue_number":243,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2185004893","fragment_type":"issue_comment","sequence":1,"text":"Recreatable with:\n\n* Pytorch 2.3.1 + numpy 1.26.4\n* Pytorch 2.3.0 + numpy 1.26.4\n* Does not happen with 2.1.2 + numpy 1.26.4","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-06-23T14:08:54+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2368579864,"issue_number":243,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2185009415","fragment_type":"issue_comment","sequence":2,"text":"And now with lldb\n\n% lldb -- python -c \"import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)\"\n(lldb) target create \"python\"\nCurrent executable set to '/Users/mark/miniforge3/envs/pt/bin/python' (arm64).\n(lldb) settings set -- target.run-args \"-c\" \"import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)\"\n(lldb) run\nProcess 58336 launched: '/Users/mark/miniforge3/envs/pt/bin/python' (arm64)\nProcess 58336 stopped\n* thread #2, stop reason = EXC_BAD_ACCESS (code=1, address=0x540)\n frame #0: 0x000000010086ef94 libomp.dylib`__kmp_suspend_initialize_thread + 32\nlibomp.dylib`:\n-> 0x10086ef94 : ldr w8, [x0, #0x540]\n 0x10086ef98 : nop \n 0x10086ef9c : ldr w9, 0x1008a1308 ; _MergedGlobals + 8\n 0x10086efa0 : add w20, w9, #0x1\n thread #3, stop reason = EXC_BAD_ACCESS (code=1, address=0x540)\n frame #0: 0x000000010086ef94 libomp.dylib`__kmp_suspend_initialize_thread + 32\nlibomp.dylib`:\n-> 0x10086ef94 : ldr w8, [x0, #0x540]\n 0x10086ef98 : nop \n 0x10086ef9c : ldr w9, 0x1008a1308 ; _MergedGlobals + 8\n 0x10086efa0 : add w20, w9, #0x1\n thread #4, stop reason = EXC_BAD_ACCESS (code=1, address=0x540)\n frame #0: 0x000000010086ef94 libomp.dylib`__kmp_suspend_initialize_thread + 32\nlibomp.dylib`:\n-> 0x10086ef94 : ldr w8, [x0, #0x540]\n 0x10086ef98 : nop \n 0x10086ef9c : ldr w9, 0x1008a1308 ; _MergedGlobals + 8\n 0x10086efa0 : add w20, w9, #0x1\n thread #5, stop reason = EXC_BAD_ACCESS (code=1, address=0x540)\n frame #0: 0x000000010086ef94 libomp.dylib`__kmp_suspend_initialize_thread + 32\nlibomp.dylib`:\n-> 0x10086ef94 : ldr w8, [x0, #0x540]\n 0x10086ef98 : nop \n 0x10086ef9c : ldr w9, 0x1008a1308 ; _MergedGlobals + 8\n 0x10086efa0 : add w20, w9, #0x1\n thread #8, stop reason = EXC_BAD_ACCESS (code=1, address=0x540)\n frame #0: 0x000000010086ef94 libomp.dylib`__kmp_suspend_initialize_thread + 32\nlibomp.dylib`:\n-> 0x10086ef94 : ldr w8, [x0, #0x540]\n 0x10086ef98 : nop \n 0x10086ef9c : ldr w9, 0x1008a1308 ; _MergedGlobals + 8\n 0x10086efa0 : add w20, w9, #0x1\nTarget 0: (python) stopped.\n(lldb)","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-06-23T14:20:48+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2368579864,"issue_number":243,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2185009915","fragment_type":"issue_comment","sequence":3,"text":"OMP_NUM_THREADS=1 python -c \"import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)\"\n\nseems to be ok with things.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-06-23T14:22:35+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2368579864,"issue_number":243,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2185048045","fragment_type":"issue_comment","sequence":4,"text":"I'm somewhat afraid of setting package type conda due to the fact that their commit says that it is needed for torch compile......\n\nBut I would rather avoid this disastrous failure mode for others.\n\nI expect that many simply haven't been able to update to 2.3.0 due to some ecosystem in compatibility because of multiple ongoing migrations, but I was able to by carefully picking and choosing packages and some on my team had reported the failure last week","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-06-23T15:30:21+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2368579864,"issue_number":243,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2189236625","fragment_type":"issue_comment","sequence":5,"text":"They seem to bundle `libomp.dylib`.\n\nFollowing should fix this issue\n\ndiff --git a/recipe/build_pytorch.sh b/recipe/build_pytorch.sh\nindex cd27be0..c6cb567 100644\n--- a/recipe/build_pytorch.sh\n+++ b/recipe/build_pytorch.sh\n@@ -1,13 +1,9 @@\n set -x\n-if [[ \"$megabuild\" == true ]]; then\n- source $RECIPE_DIR/build.sh\n- pushd $SP_DIR/torch\n- for f in bin/* lib/* share/* include/*; do\n- if [[ -e \"$PREFIX/$f\" ]]; then\n- rm -rf $f\n- ln -sf $PREFIX/$f $PWD/$f\n- fi\n- done\n-else\n- $PREFIX/bin/python -m pip install torch-*.whl\n-fi\n+source $RECIPE_DIR/build.sh\n+pushd $SP_DIR/torch\n+for f in bin/* lib/* share/* include/*; do\n+ if [[ -e \"$PREFIX/$f\" ]]; then\n+ rm -rf $f\n+ ln -sf $PREFIX/$f $PWD/$f\n+ fi\n+done","author_login":"isuruf","author_association":"MEMBER","created_at":"2024-06-25T15:16:55+08:00","repo_name":"conda-forge/pytorch-cpu-feedstock","issue_id":2368579864,"issue_number":243,"issue_url":"https://github.com/conda-forge/pytorch-cpu-feedstock/issues/243","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0173","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"N64 Smash Bros Character select bug?","query_context":"### BlueRetro firmware version\n\n25.01\n\n### BlueRetro firmware specification\n\nHW1\n\n### BlueRetro firmware variant\n\nSystem specific\n\n### BlueRetro hardware type\n\nExternal adapter dongle (1 port only)\n\n### Manufacturer\n\nRetroTime\n\n### System used\n\nNintendo 64\n\n### Bluetooth controller brand & name\n\nNSO N64 Controller, PS4 Controller\n\n### What is the problem? (only list ONE problem per report)\n\nDuring character selection in Smash Bros. or Smash Remix, whether using an everdrive or original cartridge, the player character selection will spontaneously reset, clearing your currently selected character and instantly returning the \"P1\" coin to your floating hand, and returning the floating hand to the bottom left of the screen. It happens often enough that character selection is very difficult and can only be accomplished after multiple attempts and moving on to stage selection faster than the issue can occur. This is the only scenario I see this kind of behavior, and the issue is nonexistent with a standard controller.\n\n### What did you expect to happen?\n\nto be able to select a character normally\n\n### Attach BlueRetro debug trace here\n\n_No response_","known_context_document_ids":["gh_issue_2840938880"],"reference_answer":"For those that will not fix their N64 Digital install and that liked the imperfect workaround here a build of v1.8 that reintegrate it.\n\nv1.8-push_pull_port1_hw1_n64.zip","answer_document_id":"gh_comment_1353453810","silver_evidence_path":["gh_comment_2661414597","gh_issue_1222127929","gh_comment_1353453810"],"evidence_issue_ids":[2840938880,1222127929],"source_repo_name":"darthcloud/BlueRetro","source_issue_id":2840938880,"source_issue_number":1164,"source_issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","target_repo_name":"darthcloud/BlueRetro","target_issue_id":1222127929,"target_issue_number":264,"target_issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","reference_anchor_document_id":"gh_comment_2661414597","reference_answer_author":"darthcloud","reference_answer_author_association":"OWNER","quality_score":86.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0625,"anchor_target_overlap":0.0,"target_answer_overlap":0.1667},"issue_created_at":"2025-02-09T20:36:25+08:00","valid_comment_count":63,"fragments":[{"document_id":"gh_issue_2840938880","fragment_type":"issue_description","sequence":0,"text":"N64 Smash Bros Character select bug\n### BlueRetro firmware version\n\n25.01\n\n### BlueRetro firmware specification\n\nHW1\n\n### BlueRetro firmware variant\n\nSystem specific\n\n### BlueRetro hardware type\n\nExternal adapter dongle (1 port only)\n\n### Manufacturer\n\nRetroTime\n\n### System used\n\nNintendo 64\n\n### Bluetooth controller brand & name\n\nNSO N64 Controller, PS4 Controller\n\n### What is the problem? (only list ONE problem per report)\n\nDuring character selection in Smash Bros. or Smash Remix, whether using an everdrive or original cartridge, the player character selection will spontaneously reset, clearing your currently selected character and instantly returning the \"P1\" coin to your floating hand, and returning the floating hand to the bottom left of the screen. It happens often enough that character selection is very difficult and can only be accomplished after multiple attempts and moving on to stage selection faster than the issue can occur. This is the only scenario I see this kind of behavior, and the issue is nonexistent with a standard controller.\n\n### What did you expect to happen?\n\nto be able to select a character normally\n\n### Attach BlueRetro debug trace here\n\n_No response_","author_login":"SGTgopher","author_association":"NONE","created_at":"2025-02-09T20:36:25+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2840938880,"issue_number":1164,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2646606045","fragment_type":"issue_comment","sequence":1,"text":"Did that adapter ever work? or it's something new after you changed something?","author_login":"darthcloud","author_association":"OWNER","created_at":"2025-02-09T21:20:24+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2840938880,"issue_number":1164,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2646612172","fragment_type":"issue_comment","sequence":2,"text":"I’ve had the adapter since ‘23 and I’ve always had this issue with every firmware I’ve used","author_login":"SGTgopher","author_association":"NONE","created_at":"2025-02-09T21:38:38+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2840938880,"issue_number":1164,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2650999381","fragment_type":"issue_comment","sequence":3,"text":"Ok I just tried Smash on my Everdrive and I don't have this issue.\n\nDo you some kind of HDMI mod with a OSD? Those are known to create inteference with BlueRetro.","author_login":"darthcloud","author_association":"OWNER","created_at":"2025-02-11T14:33:36+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2840938880,"issue_number":1164,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2661411285","fragment_type":"issue_comment","sequence":4,"text":"Ahh yes I do. I have the N64 digital hdmi/RGB mod installed. Is that something unlikely to be fixed down the line through a firmware update? (Either blueretro or retro GEM)","author_login":"SGTgopher","author_association":"NONE","created_at":"2025-02-16T12:32:27+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2840938880,"issue_number":1164,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2661414597","fragment_type":"issue_comment","sequence":5,"text":"See this post\n URL \n\nYou can do as a document it or try get a replacement flex from the hdmi mod vendor.\nOr you can simply disconnect the OSD line going to the pif","author_login":"darthcloud","author_association":"OWNER","created_at":"2025-02-16T12:41:13+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2840938880,"issue_number":1164,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1164","linked_issue_ids":[1222127929],"is_known_query_context":false},{"document_id":"gh_issue_1222127929","fragment_type":"issue_description","sequence":0,"text":"Gitches on Nintendo 64 with N64 Digital while using Controller/Rumble Pak / F-Zero\nI’ve enabled the controller pak manager through the web interface and formatted it but a number of games prompt that there is a problem with the pak on launch. One example is Tony Hawk Pro Skater 1. As a separate issue, F-Zero does not detect the blueretro device as a controller. \n\nConsole is modded with N64 digital and using latest version of the blueretro firmware. Unrelated, but with two NSO 64 controllers the number returned from the controller test tool for the right axis seems to be a bit higher than the benchmark. What setting in the advanced config should I adjust? Two different NSO 64 controllers return different values on the test tool, so there must be some variance at the factory with those sticks.","author_login":"Taurus1099","author_association":"NONE","created_at":"2022-05-01T11:44:32+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114424810","fragment_type":"issue_comment","sequence":1,"text":"Try to format via a laptop if you used a phone, or just let tony hawk format it when prompted.\n\nIf detection fail you can simply press reset on console, also games give up too fast.\n\nPlay with the LX, RX maximum value in web config to fine tune joystick.\n\nIMHO this is a waste of time, that test tool make people paranoid. Most games are programmed with a good play room.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-02T01:55:20+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118115697","fragment_type":"issue_comment","sequence":2,"text":"Thanks for replying! I've tried the suggestions but F-Zero does not work at all with a blueretro device and Tony Hawk will not recognize the controller pak. Testing a random sample of other controller pak games shows a major issue with the current integration. I've also experienced odd rumble behavior. On Goldeney 007, the rumble will not work correctly when firing. It gives a brief rumble and then stops when firing, when it should continue to rumble when firing. This is a great product, and hopefully you'll be able to circle back around to the N64 to finish polishing the feature set. Thank you!","author_login":"Taurus1100","author_association":"NONE","created_at":"2022-05-05T02:53:41+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118365048","fragment_type":"issue_comment","sequence":3,"text":"You might have some build related issues because I personally got none of those issues.\n\nSound like your data line is glitching somehow.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-05T09:44:24+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118427609","fragment_type":"issue_comment","sequence":4,"text":"This was confirmed from others using the adapter purchased from Tindie so it is likely the build. I’ll follow up with the seller.","author_login":"Taurus1100","author_association":"NONE","created_at":"2022-05-05T11:07:34+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118439917","fragment_type":"issue_comment","sequence":5,"text":"If you can ask others to report feedback in this GitHub issues.\n\nEveryone with issue should list the following information if possible:\n* N64 motherboard revision\n* List of internal mods installed\n* Other external peripheral used\n\nIt could be problem with the dongle itself but it could also be some interoperability issue with some motherboard or some other mods.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-05T11:24:14+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118609472","fragment_type":"issue_comment","sequence":6,"text":"I had mempak issues myself before, but they were resolved when I used a PC instead of a phone to change the config. These issues occured both on my adaptor as well as on an ESP32 Devkit which I used to compare functionality.\nRegarding the other issues, both with a ESP32 Devkit as well as my own Adaptors I had sporadic rumble issues, close to the ones that you described. \nNothing gamebreaking though, the core functionality always worked. To be honest I always accepted it as minor issues in a great open source project, maybe depending on different controllers, console revisions and mods used. In the issues section on GitHub there are also several topics related to these small issues, so I did not look more into it and accepted it as small software bugs that don't really affect me.\n\nNow of course I don't want to blame you @darthcloud for anything in your amazing project and I want to offer the most for everyone who bought my Adaptor, so I will look further into it. \n\nBecause I just moved last week, it will take more time than usual, I barely even have a TV set up at the moment, and my N64 consoles as well as the Adaptors are still in boxes.\n\nI will try to get to it this weekend.","author_login":"bixxewoscht","author_association":"NONE","created_at":"2022-05-05T14:16:05+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118655790","fragment_type":"issue_comment","sequence":7,"text":"@bixxewoscht Anything is possible off course but the N64 is the original system BlueRetro was developed for and that I actually use myself a lot. I gone though GoldenEye a few time ever the last 3 years and never noticed any rumble issues. The way it is implemented makes the interface very robust as it is using the ESP RMT peripheral, (so no software bit bang). What you guys describe should not happen at all.\n\nI'm using my own BlueRetro Devkit when playing but I did test with a few clone ESP-DevKit-C in December and this spring and didn't got any controller pak error myself. Controller pak was tested by going through Turok 1 and Tony Hawk 1.\n\nThe issue sound like the data line is glitching.\n\nMy own board got ESD protection on each line using a TPD6F002DSVR chip. This got an equivalent resistance of 100ohm. No idea if this help or not.\n\nMaybe chip me one of your dongle for me to test.\n\nI play with early N64 rev mostly but got a few more now that I could try on too. I got no mod in my console.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-05T14:54:53+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1129316659","fragment_type":"issue_comment","sequence":8,"text":"@Taurus1100 / @Taurus1099 I got your adapter today and made some quick test and it look to be working fine for me.\n\nSee video:\n URL \n\nI tested with your F-Zero X and TH1 cartridge with a NUS-CPU-04 and NUS-CPU-08-01 motherboards. Both work fine.\n\nI got others N64 mobo in storage will dig them this weekend and report back.\n\nMeanwhile can you confirm which mobo your N64 got? Did you install any mods? Are you using an original AC adapter?","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-17T21:05:14+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130563399","fragment_type":"issue_comment","sequence":9,"text":"Thanks for taking a look. My console revisions is NUS-CPU-08-01 (modded with N64 Digital) and I'm using the original power supply. I also tested with an additional power supply and no change. When you are able to do further testing, are you able to get into a game on F-Zero? I've seen the game respond to controller inputs for 10-15 seconds but eventually it stops completely. The N64 Digital menu is still accessible however. Also, any issues with the rumble in Goldeneye?","author_login":"taurus1101","author_association":"NONE","created_at":"2022-05-18T21:20:38+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130600226","fragment_type":"issue_comment","sequence":10,"text":"I think its likely the N64 digital that interferes with the pad data lines. I can test more this weekend but its likely all fine.\n\nI don't know much about N64 digital but I think you could remove the one connection for pad and it would likely work fine. But you would lose the OSD access.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-18T22:05:48+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130671668","fragment_type":"issue_comment","sequence":11,"text":"Must be related to the N64 Digital. I noticed a similar issue on another open source project: \n\n URL","author_login":"taurus1101","author_association":"NONE","created_at":"2022-05-18T22:52:17+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1131190088","fragment_type":"issue_comment","sequence":12,"text":"I tested with my N64 with N64 Digital and had the same issue with F-Zero. Could not test with my stock N64 yet. But in my other tests I remember there were no issues with the game on a stock N64.\n\nThank you both for investigating further.\n\nHolen Sie sich Outlook für Android \nSent: Thursday, May 19, 2022 12:52:29 AM\nTo: darthcloud/BlueRetro ***@***.***>\nCc: bixxewoscht ***@***.***>; Mention ***@***.***>\nSubject: Re: [darthcloud/BlueRetro] bixxewoscht's dongle gitches Nintendo 64 Controller Pak / F-Zero (Issue #264)\n\nMust be related to the N64 Digital. I noticed a similar issue on another open source project:\n\nRyzee119/usb64#42","author_login":"bixxewoscht","author_association":"NONE","created_at":"2022-05-19T04:30:54+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[1222127929],"is_known_query_context":false},{"document_id":"gh_comment_1132833192","fragment_type":"issue_comment","sequence":13,"text":"n64_test_push_pull.zip\n\nThis is untested but it change the data line from open-drain, to push-pull. Maybe that will help if the issue is on the TX side.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-05-20T12:15:34+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133312864","fragment_type":"issue_comment","sequence":14,"text":"Everything is now working perfectly! The added ability to get vibration feedback on switching between rumble/memory pak is very helpful. Is there any functionality lost by changing the data line?","author_login":"taurus1101","author_association":"NONE","created_at":"2022-05-20T20:12:23+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133456026","fragment_type":"issue_comment","sequence":15,"text":"Hi @darthcloud, I'm the guy that slid into your DM's. Similar to the above user, I can confirm that the new firmware fixes all of the issues I was having. I played with it for quite a while today and exercised all of the main functionality and everything worked great. Thaks for finding a workaround so quickly... I was excited, then super bummed, and now excited again... this is a really neat implementation and will be my goto N64 setup going forward!\n________________________________________________________________________________________________________________\nJust in case it is useful info for future reference, when I _was_ having problems it was the following setup:\nNUS-CPU-08-01 with N64Digital mod\nstock PSU\nSwitch Pro controller\nv1.5.1 of your firmware\n@bixxewoscht receiver\n\nWhat was happening (this was only for P1 on my modded system; P2 worked fine and my stock NUS-CPU-08-01 worked fine)\nController pak emualation wasn't working at all (games either wouldn't recognize it or would report it corrupted)\nEvery few seconds an uncommanded controller input [Dpad down + Dpad right + main joystick (1,-1)] would register","author_login":"astro187","author_association":"NONE","created_at":"2022-05-20T23:14:37+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1134032725","fragment_type":"issue_comment","sequence":16,"text":"I can confirm this firmware seems to resolve the issues I was having on my n64digital console as well, both with F-Zero X and overall memory pak issues.","author_login":"mario-64","author_association":"NONE","created_at":"2022-05-23T00:25:12+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214224340","fragment_type":"issue_comment","sequence":17,"text":"I got an N64 digital this week and was finally able to investigate first hand.\n\nI wasn't really a fan of the workaround I made to fix it, the N64 SI is means to have device with open drain IO. So switching to push-pull is not really ideal IMHO.\n\nThis is really an issue caused by the N64 Digital mode and I think the fix should be an HW on it.\n\nTo fix it I added a 74AHCT125N buffer between the the PIF pin 16 and the N64D ribbon COM pad\n\nThis did the trick F-Zero X menu doesn't glitch with BlueRetro and the N64D OSD still work as before.\nkicad_qEtttH5Odq\n\nThe best would be to design a ribbon with a pad for the tiny 1 gate variant 74AHCT1G125W5-7\n\nPXL_20220813_205732992\nPXL_20220813_205811684","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-08-13T21:23:42+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214226478","fragment_type":"issue_comment","sequence":18,"text":"Will you please leave the software fix in place for those of us without skills to mod our systems? I would have to pay for this work to be done :-(","author_login":"mario-64","author_association":"NONE","created_at":"2022-08-13T21:42:56+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214229269","fragment_type":"issue_comment","sequence":19,"text":"Problem is this fix doesn't work for everybody, and it actually break it for some people without a N64D.\n\nOld FW stay available so you can keep what you currently have, and if any major update occur I can always post a special version in this thread","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-08-13T22:09:43+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1272395741","fragment_type":"issue_comment","sequence":20,"text":"Quick update PixelFX designed a small flex to fix this issue. I tested it and it work great.\nPXL_20220927_000325996\n\nI'll update this issue once info on how to get it is available.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-10-08T20:53:12+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1272396315","fragment_type":"issue_comment","sequence":21,"text":"@darthcloud Is this fix the same for both HW1 and HW2? ie for both external and internal (with detection) installs?","author_login":"timotchee","author_association":"NONE","created_at":"2022-10-08T20:57:46+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1272397128","fragment_type":"issue_comment","sequence":22,"text":"@darthcloud If I'm reading correctly, you prefer Dan's flex cable fix to your 74AHCT125N buffer method for electrical reasons?","author_login":"timotchee","author_association":"NONE","created_at":"2022-10-08T21:03:26+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1272402619","fragment_type":"issue_comment","sequence":23,"text":"They are both using 125 buffer, it's same thing except flex look nicer","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-10-08T21:48:55+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276043054","fragment_type":"issue_comment","sequence":24,"text":"Hello there, is there also a fix planned for UltraHDMI users? I updated to the latest firmware and now the system does not detect the controller at all anymore","author_login":"BassXX","author_association":"NONE","created_at":"2022-10-12T11:58:46+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1280367243","fragment_type":"issue_comment","sequence":25,"text":"Yikes! I have just ordered one of the dev kit chip to do an internal install on my UltraHDMI modded N64. Has anyone reported a similar issue bundled with that mod? If so, a new flex cable will have to be developed, and as nice as Marshal is, he's only one guy and has a busy life. The chances of him developing one is slim, unless someone else steps in and develops one of their own. But again, has anyone with a UltraHDMI mod had this problem? Should this deveate into a different thread?","author_login":"Sowden","author_association":"NONE","created_at":"2022-10-17T06:43:28+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335357142","fragment_type":"issue_comment","sequence":26,"text":"This flex doesn't seem available anymore?\n\nI am having an issue with my N64 digital modded system along with the blue retro external mod. My NSO and 64 controller will sync. And then randomly will disconnect mid game. Any work around?","author_login":"pixelherogaming","author_association":"NONE","created_at":"2022-12-02T14:49:50+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335963712","fragment_type":"issue_comment","sequence":27,"text":"Dan of pixelfx/blackdogtech said there will be more flex cables in the future, but without a date. I would guess in the next 5 months. Or you can build your own circuit w/buffer with the info above. If you go the FFC route, you will need to solder surface mount components onto the FFC. Below I've listed the component to DIY, and the SMD components Dan originally specified for his flex cables, but he removed the FFC web pages so it's possible they change in the future. There's no difference between the two, the FFC simply looks nicer if you're into staring at the innards of your console. The DIY option will be easier to solder.\n\nBuffer for DIY circuit - TI SN74AHCT125N: URL or URL \nFFC N64 Buffer - Nexperia 74AHC1G17GVH: URL or URL \nFFC N64/PS1 Ceramic Capacitor(s) - 0.1uF 10V 0402: URL or URL \nFFC PS1 Buffer - TI SN74HCS125QPWRQ1: URL or URL \n\nPlease double check above and the FFC listing whenever it returns to ensure I made no mistakes.","author_login":"timotchee","author_association":"NONE","created_at":"2022-12-02T23:43:21+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335971539","fragment_type":"issue_comment","sequence":28,"text":"So I should just need to order the buffer for diy (since i dont care what it looks like) and them just solder like example above? Or do I also need capacitor(s)","author_login":"pixelherogaming","author_association":"NONE","created_at":"2022-12-02T23:56:29+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335973114","fragment_type":"issue_comment","sequence":29,"text":"Yeah, DIY is easiest and fastest. I don't see any caps in the circuit, but @darthcloud is the expert, if he sees this.","author_login":"timotchee","author_association":"NONE","created_at":"2022-12-03T00:00:27+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336009388","fragment_type":"issue_comment","sequence":30,"text":"My recommendation is to avoid firmware 1.8 and above or, alternatively, stop using BlueRetro for N64. We shouldn’t have to further mod our consoles.","author_login":"mario-64","author_association":"NONE","created_at":"2022-12-03T01:58:04+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1346683580","fragment_type":"issue_comment","sequence":31,"text":"I had a customer send me in the flex kit and his N64 that I put the HDMI kit in. This flex seems to kill the ability for a normal N64 controller to enter the OSD?","author_login":"L10N37","author_association":"NONE","created_at":"2022-12-12T15:17:02+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1346687875","fragment_type":"issue_comment","sequence":32,"text":"@L10N37 It shouldn't do that, probably problem with flex install.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-12-12T15:19:55+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1347553550","fragment_type":"issue_comment","sequence":33,"text":"ah it was like 3/ 4am and pulled 2 all nighters in a row, i just missed the 5v connection","author_login":"L10N37","author_association":"NONE","created_at":"2022-12-13T00:07:09+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353453810","fragment_type":"issue_comment","sequence":34,"text":"For those that will not fix their N64 Digital install and that liked the imperfect workaround here a build of v1.8 that reintegrate it.\n\nv1.8-push_pull_port1_hw1_n64.zip","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-12-15T17:27:28+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353466465","fragment_type":"issue_comment","sequence":35,"text":"Any latency or disadvantage to this work around as opposed to adding a buffer?","author_login":"pixelherogaming","author_association":"NONE","created_at":"2022-12-15T17:37:45+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353889188","fragment_type":"issue_comment","sequence":36,"text":"The fix is integrated in firmwares prior to 1.8 but it was removed in the main branch.","author_login":"mario-64","author_association":"NONE","created_at":"2022-12-15T23:52:22+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353907040","fragment_type":"issue_comment","sequence":37,"text":"Its a hardware bug and the workaround only work for half people with n64 digital, and break half people without one.\n\nThe real fix is the pixelfx patch cable.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-12-16T00:04:34+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1354022259","fragment_type":"issue_comment","sequence":38,"text":"n64 digital hardware bug, this is why they provide a flex patch","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-12-16T00:57:05+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1354337624","fragment_type":"issue_comment","sequence":39,"text":"As an ultra hdmi user, I suffer the same problem. \n\nAnd I know for sure that there won’t be a fixed flex cable, at least not from the mod creator.\n\nso basically I have no choice but to either switch to N64Digital or use those workarounds. I hope those will be provided in the future versions as well. Thank you","author_login":"BassXX","author_association":"NONE","created_at":"2022-12-16T07:43:13+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1354357752","fragment_type":"issue_comment","sequence":40,"text":"You could also look at the Flex/DIY fix documentation and adapt it for Ultra HDMI. There shouldn't be too much of a difference. But I don't know it exactly since I've never looked at Ultra HDMI.","author_login":"bixxewoscht","author_association":"NONE","created_at":"2022-12-16T08:06:38+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1354590696","fragment_type":"issue_comment","sequence":41,"text":"You just need to do as I explained in my previous post in this thread\n URL","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-12-16T11:24:00+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[1222127929],"is_known_query_context":false},{"document_id":"gh_comment_1358807522","fragment_type":"issue_comment","sequence":42,"text":"@darthcloud Ok, let me see if I get this one strait. The only wire you are intermediating is the N64D ribbon cable to the PIF 16. You aren't messing with any of the other connections? I'm asking because I'm finding the similarities between the N64D and the UltraHDMI. The UHDMI has a ribbon cable that I believe you attach to the same spots as the CON connection on the N64D. \n\nezgif com-gif-maker\n(not my photo, taken to show example)\nSo would that mean that you would connect the UHDMI ribbon -> Pin 2 Pin 3 -> (whatever pin depending on your motherboard)? Cause that might be the solution for the select few that own UltraHDMI sets.","author_login":"Sowden","author_association":"NONE","created_at":"2022-12-20T03:55:36+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1359331962","fragment_type":"issue_comment","sequence":43,"text":"@Sowden Yeah just piggy-back a 74AHCT125N on top of the PIF chip like I did (connect 3V3 & GND to pif pin directly) then the pin label N64D_COM (pin3 ) is the one you plug your ultra HDMI cable to. and pin 2 goes to the pif controller 1 pin. Don't forget to GND all the needed pins as done in my schematic.","author_login":"darthcloud","author_association":"OWNER","created_at":"2022-12-20T13:12:23+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1359613290","fragment_type":"issue_comment","sequence":44,"text":"Oh, GND Pin 1 -> PIF 14 and 3.3 v Pin 14 -> PIF 28? So the 74AHCT125N has four connections in total, is that correct?","author_login":"Sowden","author_association":"NONE","created_at":"2022-12-20T16:00:57+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1569658949","fragment_type":"issue_comment","sequence":45,"text":"Just wanted to pop in here and see if my issue might be related. I've got an N64 with the Gamebox Systems 64HD. When I try to use my BlueRetro adapter (from Retrotime) in controller slot 1, I am getting graphical glitches only on my HDMI out (regular composite output is unaffected). Other controller slots do not have the issue. It's almost as if (and this is just a guess) the OSD menu is being interacted with even though I haven't brought it up. I haven't tried your firmware posted here yet though, I'll give it a try tomorrow.","author_login":"nortakales","author_association":"NONE","created_at":"2023-05-31T07:39:50+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1569718833","fragment_type":"issue_comment","sequence":46,"text":"From what I heard from other users (I don't have a 64HD) the Gamebox 64HD definitely has the same issue as N64Digital and other mods that tap into the controller lines. Unfortunately the known fix was not implemented from the get go on the N64HD.","author_login":"bixxewoscht","author_association":"NONE","created_at":"2023-05-31T08:20:10+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1571194379","fragment_type":"issue_comment","sequence":47,"text":"I updated my device with v1.8-push_pull_port1_hw1_n64.zip and it did not resolve the graphical glitches :(","author_login":"nortakales","author_association":"NONE","created_at":"2023-06-01T01:34:38+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1571287397","fragment_type":"issue_comment","sequence":48,"text":"To be clear, with the 64HD I am NOT getting issues with F-Zero or Tony Hawk as reported here for N64 Digital and Ultra HDMI mods.\n\nI am just getting graphical glitches when my BlueRetro adapter is in controller port one. The glitches usually look like a bunch of random colors flash across the bottom half of the screen. The game I have found it most noticeable on is Snowboard Kids. Here is a video: URL","author_login":"nortakales","author_association":"NONE","created_at":"2023-06-01T03:43:01+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1574142973","fragment_type":"issue_comment","sequence":49,"text":"I heard from people with a N64 HD that it has problems with signal integrity as it is, without using blueretro simultaneously. Reason is most likely the flex-pcb design thats not up to industry standards (ground return path). So likely when using blueretro this amplifies the issue.","author_login":"bixxewoscht","author_association":"NONE","created_at":"2023-06-02T18:25:33+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1574200213","fragment_type":"issue_comment","sequence":50,"text":"Yea, I have noticed very infrequently some visual issues, but mostly it is fine. BlueRetro is increasing the frequency by like 100x or 1000x though.","author_login":"nortakales","author_association":"NONE","created_at":"2023-06-02T19:13:40+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639925743","fragment_type":"issue_comment","sequence":51,"text":"I've ordered the flex cable, I am having issues where the OSD is occasionally inaccessible. Where can I find the installation instructions? I have a friend who is experienced at soldering, hope he can help.","author_login":"s-taylor","author_association":"NONE","created_at":"2023-07-18T10:06:26+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1698985415","fragment_type":"issue_comment","sequence":52,"text":"I get graphical glitches, video desync, and signal loss from my N64 Digital via HDMI using Blue Retro. Is this problem related?","author_login":"Z3R0XZ","author_association":"NONE","created_at":"2023-08-30T11:31:19+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1767386911","fragment_type":"issue_comment","sequence":53,"text":"Anyone know if this issue was resolved with the Retro Gem? I would assume it was but haven't read anything to confirm.","author_login":"browntownington","author_association":"NONE","created_at":"2023-10-18T00:13:54+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1767467459","fragment_type":"issue_comment","sequence":54,"text":"Doubt it. N64 RetroGem = N64 digital. Same device just different branding.","author_login":"mario-64","author_association":"NONE","created_at":"2023-10-18T01:36:09+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1767479810","fragment_type":"issue_comment","sequence":55,"text":"From what I saw in this thread it was confirmed issue was a n64 digital hardware bug. Pixelfx were selling a flex cable specifically for n64digtal, but i see no mention of it for the retrogem. \nAs for N64 RetroGem = N64 digital. They use different firmware. Also the hardware design and components are not exactly the same. Pixelfx were aware of this bug. Hence why I'm curious if it was taken into consideration. I'll ask on their discord.","author_login":"browntownington","author_association":"NONE","created_at":"2023-10-18T01:49:13+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1890172080","fragment_type":"issue_comment","sequence":56,"text":"@darthcloud I know this is a workaround and not a real fix, but any chance of getting a firmware 1.9.1 with the same modification to change the data line from open-drain to push-pull? I was hoping to use my 8BitDo Mod Kit controller with my BlueRetro HW1 adapter, and there were some related fixes in 1.9 that I was hoping to take advantage of.\n\nI have an N64Digital HW1, and besides not being able to find the flex cable that fixes the core problem, my soldering skills are horrendous and I'd rather not pay more to have someone do the installation (the original N64Digital mod and install was already pretty expensive).\n\nI understand if this use-case isn't something you can keep supporting. Thanks!","author_login":"teconmoon","author_association":"NONE","created_at":"2024-01-13T00:18:40+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2489123058","fragment_type":"issue_comment","sequence":57,"text":"This is my quick'n'dirty implementation:\nPIF N64Digital fix \nIMG_5688","author_login":"ottelo9","author_association":"NONE","created_at":"2024-11-20T17:01:47+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708498208","fragment_type":"issue_comment","sequence":58,"text":"For anyone else with an N64Digital, I found the BlueRetro flex still available on PixelFX's site. It's just under the legacy replacement parts page here: URL \n\nI haven't bought it myself and honestly, I'm unsure if I will since I know I'll have to send it again for an install. I got mine installed back in Summer 2022 by Rainy Day Retro (wonderful mod shop, highly recommend), but at this point... I think I may just resort to playing Controller Pak games on my Mister Pi.\nAnd I don't trust myself with installing it after a botched GBA SP USB-c mod install in which I ripped some pads in pursuit of better alignment. and the high temps needed for lead-free solder.","author_login":"Kitocco","author_association":"NONE","created_at":"2025-03-08T21:44:16+08:00","repo_name":"darthcloud/BlueRetro","issue_id":1222127929,"issue_number":264,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/264","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0174","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Script file directive to select scope during import.","query_context":"### Prerequisites\n\n- [X] I have written a descriptive issue title.\n- [X] I have searched all issues to ensure it has not already been reported.\n\n### Summary\n\nA module provides a single \"script\" scope for the module that's shared even if the module spans multiple files. Non-module scripts do not have such a shared, non-global scope. Also, a script can be loaded into the current scope (dot sourced) or a new script scope (not dot sourced). The script might not be designed to work correctly with both load methods. There should be a means either to use the desired scope or to raise an error if loading into the incorrect scope. \n\n### Proposed Design\n\nAdd an optional \"#RequiresScope\" directive to control the scope into which a file loads. A SCOPE parameter will, if required, override the scope that would be selected by the method of the load (dot sourced or not dot sourced). A FORCE directive parameter could control if the desired scope is always selected automatically or if an error is raised if the default scope does not match that required. \n\n#RequiresScope Default - uses the either the current or script scope as if the directive was not present\n#RequiresScope Global Force - uses the global scope when loaded\n#RequiresScope Current Force - uses the current scope when loaded (always behaves as if dot sourced)\n#RequiresScope Script Force - uses a new scope when loaded (always behaves as if not dot source)\n#RequiresScope Scripts Force - uses a non-global named scope 'scripts' to be the parent one or more script scopes.\n\nThe \"Scripts\" scope would have global as a parent. All scripts added using the \"Scripts\" directive would be added to this one scope. Basically, it's a special place to dot source scripts other than to global or into another script file's scope. It's sort of like treating one or more non-module scripts as being in a \"non-module\" module under global. \n\nI don't think there is any value to allowing additional named 'scripts' scopes. \"MyScopeForThese5Scripts\" and \"MyScopeForThose10Scripts\"?","known_context_document_ids":["gh_issue_2058973412"],"reference_answer":"As a general rule, non-terminating errors tend to be something that comes from an individual object input in the pipeline. If one bad piece of data is received, you don't necessarily want to cancel processing the next 10,000 bits of input. On the other hand, if the error comes from bad / unusable input as the result of a fixed (non-pipeline) parameter input, you can deduce that processing all 10,000 bits of input will yield with the same result (say, for example, the cmldet requires authentication, and the authentication provider you're using indicates that the credentials specified are invalid) -- then you can throw a terminating error to avoid wasting time trying the known-bad credentials 10,000 times.","answer_document_id":"gh_comment_734360025","silver_evidence_path":["gh_comment_1872582406","gh_issue_250051780","gh_comment_734360025"],"evidence_issue_ids":[2058973412,250051780],"source_repo_name":"PowerShell/vscode-powershell","source_issue_id":2058973412,"source_issue_number":4873,"source_issue_url":"https://github.com/PowerShell/vscode-powershell/issues/4873","target_repo_name":"PowerShell/PowerShell","target_issue_id":250051780,"target_issue_number":4568,"target_issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","reference_anchor_document_id":"gh_comment_1872582406","reference_answer_author":"vexx32","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1296},"issue_created_at":"2023-12-29T01:07:31+08:00","valid_comment_count":44,"fragments":[{"document_id":"gh_issue_2058973412","fragment_type":"issue_description","sequence":0,"text":"Script file directive to select scope during import.\n### Prerequisites\n\n- [X] I have written a descriptive issue title.\n- [X] I have searched all issues to ensure it has not already been reported.\n\n### Summary\n\nA module provides a single \"script\" scope for the module that's shared even if the module spans multiple files. Non-module scripts do not have such a shared, non-global scope. Also, a script can be loaded into the current scope (dot sourced) or a new script scope (not dot sourced). The script might not be designed to work correctly with both load methods. There should be a means either to use the desired scope or to raise an error if loading into the incorrect scope. \n\n### Proposed Design\n\nAdd an optional \"#RequiresScope\" directive to control the scope into which a file loads. A SCOPE parameter will, if required, override the scope that would be selected by the method of the load (dot sourced or not dot sourced). A FORCE directive parameter could control if the desired scope is always selected automatically or if an error is raised if the default scope does not match that required. \n\n#RequiresScope Default - uses the either the current or script scope as if the directive was not present\n#RequiresScope Global Force - uses the global scope when loaded\n#RequiresScope Current Force - uses the current scope when loaded (always behaves as if dot sourced)\n#RequiresScope Script Force - uses a new scope when loaded (always behaves as if not dot source)\n#RequiresScope Scripts Force - uses a non-global named scope 'scripts' to be the parent one or more script scopes.\n\nThe \"Scripts\" scope would have global as a parent. All scripts added using the \"Scripts\" directive would be added to this one scope. Basically, it's a special place to dot source scripts other than to global or into another script file's scope. It's sort of like treating one or more non-module scripts as being in a \"non-module\" module under global. \n\nI don't think there is any value to allowing additional named 'scripts' scopes. \"MyScopeForThese5Scripts\" and \"MyScopeForThose10Scripts\"?","author_login":"drstonephd","author_association":"NONE","created_at":"2023-12-29T01:07:31+08:00","repo_name":"PowerShell/vscode-powershell","issue_id":2058973412,"issue_number":4873,"issue_url":"https://github.com/PowerShell/vscode-powershell/issues/4873","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1872582406","fragment_type":"issue_comment","sequence":1,"text":"@drstonephd Thanks for your submission! Can you clarify how you think the vscode-powershell extesnion would solve this problem? This seems like it's already covered in URL and would need to be implemented in PS and not the extension. Thanks.","author_login":"JustinGrote","author_association":"COLLABORATOR","created_at":"2023-12-30T18:46:07+08:00","repo_name":"PowerShell/vscode-powershell","issue_id":2058973412,"issue_number":4873,"issue_url":"https://github.com/PowerShell/vscode-powershell/issues/4873","linked_issue_ids":[250051780],"is_known_query_context":false},{"document_id":"gh_comment_1874391460","fragment_type":"issue_comment","sequence":2,"text":"@JustinGrote You are correct that this is a PS feature request, not a vscode extension request. \n\nIt's not a solution to issue 4568, but a work around. Don't assume modules honor preferences... set them in global. If PS had the directive, then we could use the global scope to set module preferences. At the same time, we could use a special scope for the preferences of other non-module scripts. \n\nThere is value in such a directive to make sure scripts are loaded into the correct scope. The author can define the scope in which the script is design to work... if it makes a difference. \n\nTrying to control this in the vscode extension might not be a good idea. Is the choice defined in vscode file by file or for as setting that applies to all files? If I have scripts that load other scripts, it can get pretty tricky if they are not run in the correct order. As it is, I need a special wrapper script to call my scripts if I want the initial script scope in vscode. When using F5, is the choice of global or script enough? I'm confused.","author_login":"drstonephd","author_association":"NONE","created_at":"2024-01-02T18:28:53+08:00","repo_name":"PowerShell/vscode-powershell","issue_id":2058973412,"issue_number":4873,"issue_url":"https://github.com/PowerShell/vscode-powershell/issues/4873","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1874464335","fragment_type":"issue_comment","sequence":3,"text":"Moved to PS.\n\nScript file directive to select scope during import. #20988","author_login":"drstonephd","author_association":"NONE","created_at":"2024-01-02T19:40:22+08:00","repo_name":"PowerShell/vscode-powershell","issue_id":2058973412,"issue_number":4873,"issue_url":"https://github.com/PowerShell/vscode-powershell/issues/4873","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_250051780","fragment_type":"issue_description","sequence":0,"text":"Need straightforward way to honor the caller's preference-variable values / inherited common parameters in functions defined in script modules\nThis is a longstanding issue that @dlwyatt explained in detail in this 2014 blog post, and he has even published module `PreferenceVariables` with advanced function `Get-CallerPreference` to ease the pain, via a hard-coded list of preference variable names.\n\nIn short: A _script_ module's functions do not see the preference-variable values set in the _caller's_ context (except if that context happens to be the _global_ one), which means that **the caller's preferences are not honored**.\n\n_Update: Since implicitly setting preference variables is PowerShell's method for propagating (inheriting) common parameters such as `-WhatIf`, such parameters are ultimately not honored in calls to script-module functions when passed via an advanced function - see #3106, #6556, and #6342. In short: **the common-parameter inheritance mechanism is fundamentally broken for advanced functions across module scopes, which also affects standard modules such as `NetSecurity` and `Microsoft.PowerShell.Archive`**_ .\n\n* From a user's perspective this is (a) surprising and (b), once understood, inconvenient. \nAdditionally, given that _compiled_ cmdlets do not have the same problem, it is not easy to tell in advance which cmdlets / advanced functions are affected. In a similar vein, compiled cmdlets proxied via implicitly remoting modules also do not honor the caller's preferences.\n\n* From a developer's perspective, it is (a) not easy to keep the problem in mind, and (b) addressing the problem requires a *workaround* that is currently quite cumbersome, exacerbated by currently not having a _programmatic_ way identify _all_ preference variables in order to copy their values to the callee's namespace - see #4394.\n\nA simple demonstration of the problem:\n\npowershell\n# Define an in-memory module with a single function Foo() that provokes\n# a non-terminating error.\n$null = New-Module {\n function Foo {\n [CmdletBinding()] param()\n # Provoke a non-terminating error.\n Get-Item /Nosuch\n }\n}\n\n# Set $ErrorActionPreference in the *script* context:\n# Request that errors be silenced.\n# (Note: Only if you defined this in the *global* context would the module see it.)\n$ErrorActionPreference = 'SilentlyContinue'\n\n# Because the module in which Foo() is defined doesn't see this script's\n# variables, it cannot honor the $ErrorActionPreference setting, and \n# the error message still prints.\nFoo\n\nDesired behavior \n-----------------\n\nNo output.\n\nCurrent behavior\n---------------\n\nnone\nGet-Item : Cannot find path '/Nosuch' because it does not exist.\n...\n\nEnvironment data\n----------------\n\npowershell\nPowerShell Core v6.0.0-beta.5 on macOS 10.12.6\nPowerShell Core v6.0.0-beta.5 on Ubuntu 16.04.3 LTS\nPowerShell Core v6.0.0-beta.5 on Microsoft Windows 10 Pro (64-bit; v10.0.15063)\nWindows PowerShell v5.1.15063.483 on Microsoft Windows 10 Pro (64-bit; v10.0.15063)","author_login":"mklement0","author_association":"CONTRIBUTOR","created_at":"2017-08-14T14:40:45+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_364140304","fragment_type":"issue_comment","sequence":1,"text":"I found that specifying `$global:` addresses this for progress bar issues. \n\n`$global:ProgressPreference = 'silentlycontinue'` at the top of a script suppresses the performance killing progress indicator when downloading things.","author_login":"StingyJack","author_association":"NONE","created_at":"2018-02-08T15:08:02+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_369366936","fragment_type":"issue_comment","sequence":2,"text":"It seems to me that when considering code inside a script module there are two distinct kinds of code to which preference variables (eg. `$ErrorActionPreference`, etc) and common parameters (eg. `-ErrorAction`, etc) might apply:\n - business logic implemented within the module\n * The cause of errors arising from such code are bugs (ie. \"boneheaded\" errors per Eric Lippert's taxonomy). Accordingly, such code should be run with `$ErrorActionPreference='Stop'`.\n * Deciding the conditions for and quantity of verbose messages output from the business logic requires the good judgment of the module author. This probably involves careful consideration of what should happen when the module is called with the different values of `$VerbosePreference` and `-Verbose` at the call site of module entry points.\n * `$DebugPreference`, `$WarningPreference`, and `$InformationPreference` for such code should probably be the PowerShell defaults regardless of what the caller's values of those variable are.\n - calls made to outside the module\n * Such code is subject to all sorts of untidy unpredictable external realities that cause errors (Eric Lippert calls these \"exogenous\"). The user of the module should be the party deciding what to do when such an error arises. Accordingly,\n * the value of common parameters and preference variables for such calls should be the same as they were at the call site of the _entry point_ to the module.\n\nThe above points aren't hard and fast, but I think they're a reasonable starting point for most modules involving a mix of business logic and calls made to outside the module. PowerShell, of course, does not behave this way by default. To implement a module that is consistent with the above points requires two things to happen as follows:\n\n 1. Capture preference variables and common parameters at the call site of the entry point to the module.\n 2. Apply those preference variables and common parameters to the calls made to outside the module.\n\nI suspect that these tasks can be handled reasonably well by a utility module. I wrote an annotated proof-of-concept of such a module. The entry points to a user module that uses the utility module would look, for example, like this:\n\nPowerShell\nfunction Get-MyItem {\n param(\n [Parameter(Position=1)] $Path\n )\n HonorCallerPrefs {\n Get-MyItemImpl $Path\n }\n}\n\nfunction New-MyItem {\n param(\n [Parameter(Position=1)] $Path,\n [switch] $WhatIf,\n [switch] $Confirm\n )\n HonorCallerPrefs {\n New-MyItemImpl $Path\n }\n}\n\nThe corresponding sites that call out of the user module would look like this:\n\nPowerShell\nInvokeWithCallerPrefs {\n Get-Item $path @CallerCommonArgs\n}\n\nInvokeWithCallerPrefs {\n New-Item $path @CallerCommonArgs\n}\n\n`HonorCallerPrefs{}` and `InvokeWithCallerPrefs{}` are implemented by the utility module and capture and apply the preference variables and common parameters, respectively. The concept should work even if the call stack between `HonorCallerPrefs{}` and `InvokeWithCallerPrefs{}` is deep and complicated, as long as they are in the same module.","author_login":"alx9r","author_association":"NONE","created_at":"2018-02-28T20:09:53+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_378720064","fragment_type":"issue_comment","sequence":3,"text":"The recent #6556 is a more pernicious manifestation of the problem discussed here:\n\nBecause CDXML-based cmdlets are seemingly _advanced functions_ rather than binary cmdlets, the functions in the `NetSecurity` module such as `Enable-NetFirewallRule` do not honor the `-WhatIf` switch if invoked via an advanced function that itself supports `-WhatIf`; \nditto for an explicitly set `$WhatIfPreference` value, as discussed.\n\nRevisiting @lzybkr's comment:\n \n\nFrom what I gather, PowerShell _implicitly_ translating a common parameter such as `-WhatIf` into the equivalent locally scoped preference variable such as `$WhatIfPreference` is _the_ mechanism for automatically propagating common parameters to calls to other cmdlets inside an advanced function.\n\n@alx9r: As commendable as starting scripts / functions with `$ErrorActionPreference = 'Stop'` is (it is what I usually do in my own code), it actually interferes with that mechanism (I have yet to take a look at your proof of concept).","author_login":"mklement0","author_association":"CONTRIBUTOR","created_at":"2018-04-04T19:37:31+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_378735997","fragment_type":"issue_comment","sequence":4,"text":"#6342 is a similar manifestation of the problem, in the context of `Expand-Archive`.","author_login":"mklement0","author_association":"CONTRIBUTOR","created_at":"2018-04-04T20:33:59+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_378746377","fragment_type":"issue_comment","sequence":5,"text":"@mklement0 \n \n\nJust to be clear. I did not suggest (or if I did, I did so unintentionally) \"starting scripts / functions with `$ErrorActionPreference = 'Stop'`\" in the proof-of-concept I proposed. The proof-of-concept is specific to advanced functions in modules. I do suggest that, for advanced functions in modules, the code internal to the module be run with `$ErrorActionPreference = 'Stop'`. But that is quite a different thing from, in general, \"starting scripts / functions with `$ErrorActionPreference = 'Stop'`\".\n \n\nThat is my understanding too. I think, though, that that mechanism alone produces inadequate results. \n FWIW, the proof-of-concept currently doesn't do any refereeing based on the impact of `-WhatIf`, etc. I see no reason why such a library couldn't be expanded deal correctly with that matter as well.","author_login":"alx9r","author_association":"NONE","created_at":"2018-04-04T21:10:42+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[250051780],"is_known_query_context":false},{"document_id":"gh_comment_483706680","fragment_type":"issue_comment","sequence":6,"text":"This issue seems stalled, but it's such an important one, and with the upcoming PowerShell 7.0 milestone it would be really, really great if people put their heads together and come up with a model that makes sense for the caller, has the right default behavior, and that gives the developer the flexibility they need to override the default behavior if necessary.","author_login":"KirkMunro","author_association":"CONTRIBUTOR","created_at":"2019-04-16T15:18:19+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483727275","fragment_type":"issue_comment","sequence":7,"text":"Agreed. If we can come to a conclusion on this it would be great to get a more consistent model in place.","author_login":"vexx32","author_association":"CONTRIBUTOR","created_at":"2019-04-16T16:08:25+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483775469","fragment_type":"issue_comment","sequence":8,"text":"We could move forward if we created examples of the desired behavior in the form of Perter tests.","author_login":"iSazonov","author_association":"COLLABORATOR","created_at":"2019-04-16T17:46:39+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_483793003","fragment_type":"issue_comment","sequence":9,"text":"The expectation from my POV is that caller preferences that do not affect the script or module execution paths are replicated out to every script or module that gets involved, as a default, without having to opt-in (other than `[CmdletBinding()]` ofc).\n\nThis would be things like Verbose, Debug, Information, and Progress, but not something like ErrorActionPreference, PSEmailServer, or ModuleAutoLoadingPreference.","author_login":"StingyJack","author_association":"CONTRIBUTOR","created_at":"2019-04-16T18:34:36+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_490958634","fragment_type":"issue_comment","sequence":10,"text":"Thinking about the last paragraph in my previous comment a little more, I'm inclined to push for the following to address this (and yes, I'll log this as a separate issue):\n\nAny `ShouldProcess` command that works with PowerShell entities in the current scope (e.g. any of the following commands invoked without `-Scope`: `Clear-Variable`, `New-Variable`, `Set-Variable`, `Remove-Variable`, `Import-Alias`, `New-Alias`, `Set-Alias`, along with any of their corresponding `New-Item`, `Set-Item`, or `Remove-Item` commands) should run without checking `$PSCmdlet.ShouldProcess`. i.e. If `-Scope` is not used, or if `-Scope` is 0, just do it regardless of WhatIf or Confirm preferences. Local scope operations for these commands should be considered safe, because they have no bearing on any parent scopes whatsoever, and are therefore non-destructive. This model should be followed for any command that supports `ShouldProcess` for both actions that may be destructive as well as actions that are non-destructive -- just because `ShouldProcess` is supported in the command, doesn't mean it should be the gatekeeper to all actions taken by that command.\n\nThis creates an exception, but one worth having because some commands should only cause WhatIf or Confirm to change how they run some of the time. For example, there are cases where you want to create a set of variables with dynamic names in a loop without ShouldProcess preferences getting in the way of invocation, and while you can do this using APIs, it should be possible to do this using cmdlets since that's what they are for. End users shouldn't have to learn by trial and error which one they should be using -- the cmdlets should just do the right thing.\n\nIf that gets accepted, then the last paragraph in my previous post in this discussion becomes a non-issue.","author_login":"KirkMunro","author_association":"CONTRIBUTOR","created_at":"2019-05-09T15:45:47+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_500437188","fragment_type":"issue_comment","sequence":11,"text":"FYI, I opened a set of RFCs to address error handling issues in PowerShell, this one included. If you're keen and you don't want to wait for the RFCs to reach the draft stage, you can find the PR with those RFCs here.","author_login":"KirkMunro","author_association":"CONTRIBUTOR","created_at":"2019-06-10T14:28:24+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_547586715","fragment_type":"issue_comment","sequence":12,"text":"For anyone who has tripped on this issue and is following this discussion, please do share your feedback in URL That PR, the way it is currently written, talks about adopting optional features in PowerShell (described in another RFC: URL \n\nThere is some pushback on the optional feature idea because it requires time/resources to properly manage, and it may be too risky to be worth it to the PowerShell Team (see discussion in optional features RFC), in which case you need to ask yourself: is the current problem with how execution preferences do not propagate beyond module or script scope worth fixing even if it may result in breaking changes?\n\nBreaking changes may occur because you would be changing how execution preferences influence existing code without specifically testing that code to make sure that it still works as intended.\n\nFrom my perspective, I think it is worth it, because the current behavior is the root cause of many issues that show up in different modules. If folks agree, and if the optional feature idea is officially rejected, I can at least set up an experimental feature (these are different from optional features) to allow folks to try it out with their modules and make sure things still work the way they intended with execution preferences properly propagating beyond module or script scope.","author_login":"KirkMunro","author_association":"CONTRIBUTOR","created_at":"2019-10-29T19:17:25+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_600755498","fragment_type":"issue_comment","sequence":13,"text":"I assume this behavior is the root of the issue where ShouldProcess doesn't do verbose output even if VerbosePreference is set? Or should this be a separate issue?\n\npowershell\nfunction Test-Whatif {\n [CmdletBinding(SupportsShouldProcess)]\n param (\n $String = 'Thing to do'\n )\n $target = 'Thing to Target'\n $VerbosePreference ='continue'\n if ($PSCmdlet.ShouldProcess($target,$string)){\n \"Did $string to $target\"\n }\n}\n\nimage","author_login":"JustinGrote","author_association":"NONE","created_at":"2020-03-18T17:12:24+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_600770465","fragment_type":"issue_comment","sequence":14,"text":"Couldn't say off the top of my head, but given that you're setting $VerbosePreference immediately before it, I would be inclined to say that it's likely a separate issue, something to do with how WhatIf only see verbose set by the switch and not an in-session variable.","author_login":"vexx32","author_association":"COLLABORATOR","created_at":"2020-03-18T17:42:12+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_733985144","fragment_type":"issue_comment","sequence":15,"text":"Sorry if this has already been mentioned, but this thread is quite long so I mostly just skimmed it.\n\nI believe there isn't a single \"right answer\" here:\n\nFor `$ErrorActionPreference`, I personally use\n\npowershell\nSet-StrictMode -Version Latest\n$ErrorActionPreference = \"Stop\"\n\nas a header in every module I write, because I want to fail hard when an unhandled error occurs, and my code is written with this in mind. So just blindly copying the variable from caller scope is imo not a good approach, because scripts that do not declare the variable themselves will work differently in different sessions.\n\nFor output level preference variables (`$VerbosePreference`, `$InformationPreference`,...), I think the current situation where the output is controlled in each scope separately (so the effective output is the minimum of all set preference variables in all scopes the output passes through) is quite nice and I'd like to keep it both as a module writer and a user.","author_login":"MatejKafka","author_association":"NONE","created_at":"2020-11-25T23:09:59+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_733987816","fragment_type":"issue_comment","sequence":16,"text":"@MatejKafka: There are two separate aspects, which are _independent_ of one another:\n\n* Designing your module so that it reports the _appropriate_ type of error, based on the official guidelines, summarized here (by me). The same applies to using the other output streams, such as the one for verbose output.\n\n* Respecting the _caller's_ preference variables so as to _modify_ the module's _default_ behavior _on demand_. For that, there's no justification for distinguishing between (a) functions (and scripts) _outside_ a module scope, (b) functions _inside_ a module, and (c) cmdlets.\n * (a) and (c) properly respect the caller's preferences, whereas (b) doesn't. This distinction doesn't make sense, and no user should ever have to think about the _implementation details_ of a given command, i.e. whether they _happen to be_ implemented as (a), (b), or (c).","author_login":"mklement0","author_association":"CONTRIBUTOR","created_at":"2020-11-25T23:20:47+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_733992067","fragment_type":"issue_comment","sequence":17,"text":"@mklement0 I agree that the behavior being inconsistent is an issue, but it seems we partially disagree in which direction they should be unified.\n\nAd 1) - I'm more of a programmer than sysadmin - the concept of a non-terminating error seems like something terrifying to me - an error occurred, meaning that something bad happened and I did not correctly anticipate it and handle it, and the program is in an undefined state. Continuing ahead instead of panicking is imo irresponsible, as I cannot safely reason about the behavior of my own program. Non-terminating error should imo either be a terminating error, or a warning, not a weird mix of both.\n\nI also edited my previous comment, as I found out that my assumption in the last paragraph aren't correct.","author_login":"MatejKafka","author_association":"NONE","created_at":"2020-11-25T23:37:32+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_734274016","fragment_type":"issue_comment","sequence":18,"text":"It shouldn't do. There's a difference between errors and exceptions. Whether an error is \"exceptional\" depends on the context. If you've correctly functionally decomposed your code into a series of small pipeline functions each function by itself can't determine if an error is an exception, because it can't own that policy because it doesn't know why it's being called. Errors from that function should bubble through the pipeline to the creator of the pipeline who can, in that context, determine whether the error is exceptional in that context/pipeline.","author_login":"wisemoth","author_association":"NONE","created_at":"2020-11-26T12:36:18+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_734360025","fragment_type":"issue_comment","sequence":19,"text":"As a general rule, non-terminating errors tend to be something that comes from an individual object input in the pipeline. If one bad piece of data is received, you don't necessarily want to cancel processing the next 10,000 bits of input. On the other hand, if the error comes from bad / unusable input as the result of a fixed (non-pipeline) parameter input, you can deduce that processing all 10,000 bits of input will yield with the same result (say, for example, the cmldet requires authentication, and the authentication provider you're using indicates that the credentials specified are invalid) -- then you can throw a terminating error to avoid wasting time trying the known-bad credentials 10,000 times.","author_login":"vexx32","author_association":"COLLABORATOR","created_at":"2020-11-26T15:27:36+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_734362716","fragment_type":"issue_comment","sequence":20,"text":"I would prefer we do not use this Issue to discuss/debate PowerShell's error handling models. There are existing Issues you can pile onto, or start a new one.","author_login":"jazzdelightsme","author_association":"CONTRIBUTOR","created_at":"2020-11-26T15:32:52+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040846976","fragment_type":"issue_comment","sequence":21,"text":"Having just fallen foul of this one myself, a *good-enough* syntax (for me), as an occasional AF-author would simply be...\n\n`\nGet-Variable -Preference | Set-Variable -Scope Local\n\n`\n\n...where `-Preference` was a new switch added to `Get-Variable` which limited the output of that command to the known preference variables and supplied *the correctly-resolved value for whatever the current scope intended, apropos of any magic that might apply to that preference variable*.\n\nI *think* the intent of such a call would be clear and idiomatic, and—given `-Preference` doesn't exist yet—shouldn't break any backward compatibility, but I've of course only spent a minimal amount of time looking into it, so I am sure there are all manner of cases that I am not considering. I don't *think* it requires alteration to `Set-Variable`, since both `-Name` and `-Value` accept the pipeline input that `Get-Variable` outputs, and `-Scope` does not.\n\nI suppose it might be open to global scope abuse (but, surely so is `$global:*Preference`, so I'm not going to lose sleep over it).","author_login":"jimbobmcgee","author_association":"NONE","created_at":"2022-02-15T22:10:28+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368035880","fragment_type":"issue_comment","sequence":22,"text":"I hit this problem writing my first module. I'm going to revert back to sourcing scripts directly (`. .\\foo.ps1`), and not use advanced-function modules going forward.\n\n9+ years for a problem of this impact seems like a long time. Are advanced-function modules considered second-class citizens in PowerShell? Are developers writing binary modules instead? Or is there just very little developer involvement at the module level in general?","author_login":"mc-ganduron","author_association":"NONE","created_at":"2022-12-30T18:05:10+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368039340","fragment_type":"issue_comment","sequence":23,"text":"@mc-ganduron most likely the issue is complexity of implementation vs. relatively easy workarounds (passing the preference thru to child functions). \n\nI would say abandoning advanced functions for just this is a little dramatic don't you think?","author_login":"JustinGrote","author_association":"CONTRIBUTOR","created_at":"2022-12-30T18:14:28+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368054542","fragment_type":"issue_comment","sequence":24,"text":"Not at all. First, I have a prior solution available with no workarounds required (sourcing scripts directly). Second, it's reasonable to take first impressions into account. My first experience with advanced-function modules led me to a 9+ year-old bug. I'm not willing to march ahead into other old bugs when I have options available, within PowerShell and without.","author_login":"mc-ganduron","author_association":"NONE","created_at":"2022-12-30T19:04:13+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368094695","fragment_type":"issue_comment","sequence":25,"text":"@mc-ganduron - All software has bugs. Lots of them are old. This one bothered me as well until the day I was troubleshooting a problem with my module and I only wanted to have verbose output from my module and did not want all of the verbose output noise from all of the other modules and functions my module called. This current way does not seem as convenient or consistent at first, but it does represent an \"opt-in\" style choice that is more useful than opting out for many troubleshooting scenarios.","author_login":"StingyJack","author_association":"CONTRIBUTOR","created_at":"2022-12-30T21:24:03+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368136166","fragment_type":"issue_comment","sequence":26,"text":"Actually I noticed that for errors `$PSCmdlet.ThrowTerminatingError()` works exactly like compiled cmdlet and honor the caller's preference:\n\npowershell\n$null = New-Module {\n $ErrorActionPreference = 'Stop'\n function Foo {\n [CmdletBinding()] param()\n trap { $PSCmdlet.ThrowTerminatingError($_) }\n Get-Item /Nosuch\n }\n}\n\n$ErrorActionPreference = 'SilentlyContinue'\nFoo\n\nI think that it's the most reliable way to handle errors from modules.\nI wish the default behavior was like the example above without needing to re-throw the errors. And maybe a way to do the same thing for streams other then errors.","author_login":"ili101","author_association":"NONE","created_at":"2022-12-31T00:45:05+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368158271","fragment_type":"issue_comment","sequence":27,"text":"I do wish the syntax for $PSCmdlet.WriteError and ThrowTerminating error was more terse, it looks like black magic when it really should be the way to do it, something like `throwUser` keyword.","author_login":"JustinGrote","author_association":"CONTRIBUTOR","created_at":"2022-12-31T03:43:29+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1816637424","fragment_type":"issue_comment","sequence":28,"text":"I have been scratching my head for months why I didn't get my Debug, Verbose and Information messages in my output when calling Functions in Modules. It's funny when they advise us to move from Write-Host to Write-Information and then make InformationPreference SilentlyContinue the default.\n\nBy accident I found this thread and I now prefix DebugPreference, VerbosePreference and InformationPreference with $Global and suddenly I get everything I've been missing, all the feedback I had programmed into my functions but could only see when running from my local system.\n\nSo this is absolutely still a thing on PowerShell 7, Mr. Bot.","author_login":"PowerCoder","author_association":"NONE","created_at":"2023-11-17T15:30:18+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869858231","fragment_type":"issue_comment","sequence":29,"text":"This is so ugly. I want my debug messages and have no problem getting them. Somehow a module gets the preference. I try as I might to disable the module messages, but to no avail. I don't know if it's the module code trying to get the preference via some tricky means because of this issue or something else. Really, perhaps leave this as version 1 of messaging and create a completely new implementation. And make the new implementation easy to use. A transcript option would be nice if we don't want to liter code with write-debug when we want to see everything. A message level instead many preferences. Multiple targets. Bite the bullet and think of something both easy and useful. Don't make it so we are stuck with backward compatible horrors. I'm sick of this thing.","author_login":"drstonephd","author_association":"NONE","created_at":"2023-12-27T01:18:57+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1870555981","fragment_type":"issue_comment","sequence":30,"text":"Please reopen this. Looks like the bot closed it. (Sweeping it under the carpet?)","author_login":"drstonephd","author_association":"NONE","created_at":"2023-12-27T19:02:33+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1870565995","fragment_type":"issue_comment","sequence":31,"text":"After that lengthy example, I have to wonder if all I needed to do was like below. In this case Set-StandardDatabaseMail would not have the \"hack\" code to set the private and global preference values. I don't know if it would handle Debug or Verbose switches as desired. I wish I knew the right way to handle this. If there is no fix, then perhaps a detailed document that explains how we should handle this? \n\n$private:DebugPreference = 'Continue'\n$private:VerbosePreference = 'Continue'\n$global:DebugPreference = 'SilentlyContinue'\n$global:VerbosePreference = 'SilentlyContinue'\n\nSet-StandardDatabaseMail -SqlInstance XXX -WhatIf -InformationAction Continue\n\nIf I was using several modules and want to control them individually, this could become very cumbersome. Should preference variables be private by default scoped by fn and module?","author_login":"drstonephd","author_association":"NONE","created_at":"2023-12-27T19:18:56+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1871485259","fragment_type":"issue_comment","sequence":32,"text":"Here's a trick to create a new scope if the file was dot sourced. It's not the script scope, but might be okay for a simple call. \n\n& {\n$DebugPreference = 'Break'\nTest-ScriptScope\n}\n\nHost : Visual Studio Code Host - 2023.8.0\nCommand Origin : Internal (dot sourced?)\nCommand : C:\\Users\\rstone\\Documents\\GitHub\\sql-server-maintenance\\Test-ScriptScope.ps1\nScript Name : Test-ScriptScope.ps1\n[Test-ScriptScope.ps1] $global:DebugPreference=SilentlyContinue\n[Test-ScriptScope.ps1] $script:DebugPreference=SilentlyContinue\n[Test-ScriptScope.ps1] $local:DebugPreference=SilentlyContinue\n[Test-ScriptScope.ps1] $DebugPreference=SilentlyContinue\nTesting Test-ScriptScop\n[Test-ScriptScope] $global:DebugPreference=SilentlyContinue\n[Test-ScriptScope] $script:DebugPreference=SilentlyContinue\n[Test-ScriptScope] $local:DebugPreference=\n[Test-ScriptScope] $DebugPreference=SilentlyContinue\nTesting &{} with Test-ScriptScop\n[Test-ScriptScope] $global:DebugPreference=SilentlyContinue\n[Test-ScriptScope] $script:DebugPreference=SilentlyContinue\n[Test-ScriptScope] $local:DebugPreference=\n[Test-ScriptScope] $DebugPreference=Break","author_login":"drstonephd","author_association":"NONE","created_at":"2023-12-28T20:58:44+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2044613088","fragment_type":"issue_comment","sequence":33,"text":"So many years and no change - we are still struggling with this. mklement0 was pretty spot on from the beginning, and it is hard to grasp the perspectives that has been put onto this, attempting to justify inconsistent behavior with user vs developer perspectives. We're not developing to match everyones expectation, but to produce consistent outcomes and predictable behavior.\n\nImho - whether you are looking at this from a user perspective, or developer perspective, either one wants consistent behavior, independent of the source of the function thei're invoking. By having a requirement for detailed knowledge of the call stack from start to end, to be able to predict the outcome of preferences, does exactly complicate it for users and developers alike, and especially -WhatIf is a problematic preference variable/common parameter, since it can incur devastating consequences, which ultimately can't be predicted in the current state of affairs, if implemented in an advanced module function.\n\nKeep in mind that in module development, we often call other functions in the module, to deal with specific tasks a greater function needs to accomplish, but at the same time the user/another developer may have the option to call those functions directly.\n\nUsers and developers alike would expect e.g. -WhatIf to perform as intended, regardless of how deep the function call is in the call stack. It could be catastrophic if we forgot to import preference variables from the callers scope, and even if we do remember it, the inheritance may have been severed by a module function somewhere else in the call stack that didn't do it - which btw. is completely out of our control, and not fixable by an opt-in change. This leaves the WhatIf parameter risky, and thereby imo useless in a module advanced function, as you cannot guarantee its propagation from parent scopes.\n\nPropagating preference variables to descendent scopes should always have been the way, but the proposed option of adding a CmdletBindingAttribute for opting in to this, is however a truly elegant solution, that would solve part of the problem, and it won't even introduce breaking changes. You may even add more attributes, for more granular control - so one may wonder what is wrong with at least giving us this?","author_login":"sharzas","author_association":"NONE","created_at":"2024-04-09T09:56:47+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2048513316","fragment_type":"issue_comment","sequence":34,"text":"In my modules I have found that you can parse the command that called your module load so you can take action on that....\n`[System.Management.Automation.Language.Parser]::ParseInput($MyInvocation.Statement, [ref]$ParsedTokens, [ref]$ParsedErrors)`\nThis will let you parse the import-module command and the parameters. Since you are using your own invocation statement you do not have to validate the module that is loading is yours.\n\nThis is a quick sample of how to do it, incase you are like me and need to see code to understand what these words mean. Drop the following code into a module and when you load it use Verbose switch on the import, it should let you know... you can play with it as you see fit. But I was thinking that it should be able to actually implement this in the import command somehow. I wonder if a proxy command would work... you could do it and throw the parameters that you want into a set order for the 'args' array.... or even modify the bound parameters I guess to do it... thats an idea I haven't thought about... I'll go have some fun with that idea this weekend. Anyways, the code:\n\n`[System.Management.Automation.Language.Token[]]$local:ParsedTokens = @()\n[System.Management.Automation.Language.ParseError[]]$local:ParsedErrors = @()\n[System.Management.Automation.Language.ScriptBlockAst]$local:LastStatementAst = [System.Management.Automation.Language.Parser]::ParseInput($MyInvocation.Statement, [ref]$ParsedTokens, [ref]$ParsedErrors) # statement should only contain the import-module command\n[System.Management.Automation.Language.CommandAst]$local:LastImportCommand = @($local:LastStatementAst.Find({$args[0] -is [System.Management.Automation.Language.CommandAst] -and ([System.Management.Automation.Language.CommandAst]$args[0]).GetCommandName() -eq 'Import-Module'}, $false))[0]\n[System.Collections.ObjectModel.ReadOnlyCollection[System.Management.Automation.Language.CommandParameterAst]]$local:LastImportParameters = $local:LastImportCommand.CommandElements | Where-Object {$_ -is [System.Management.Automation.Language.CommandParameterAst]}\n[System.Management.Automation.Language.ParameterAst]$local:CalledVerboseAst = @($local:LastImportParameters | Where-Object {$_ -is [System.Management.Automation.Language.ParameterAst] -and $_.ParameterName -eq 'Verbose'})[0]\n[bool]$Script:IsVerbose = $false # default state\n# update the IsVerbose variable based on the value of the 'Verbose' parameter\nif (-not $null -eq $local:CalledVerboseAst.Argument) { # means 'Verbose:[Variable | Value]' was used\n try {\n $script:IsVerbose = $local:CalledVerboseAst.Argument.SafeGetValue($true)\n } catch [System.InvalidOperationException] { # the extent is unsafe\n try { # fallback to extract value from string but compare it to a known valid value to determine the state\n $script:IsVerbose = $local:CalledVerboseAst.Argument.Extent.Text.Replace('$','').ToUpper() -eq 'TRUE'\n } catch { # ya, that extent is really unsafe\n $script:IsVerbose = $false # no hope so we just say false\n }\n }\n} else { # else only the switch is present, which means true for the value\n $script:IsVerbose = $true\n}\n\nWrite-Host \"Verbose was $(($Script:IsVerbose ? \"used with a resolved value of $IsVerbose\" : \"not used\"))\"\n`\nI just wish I could make it cleaner and more compact that it would be not so distracting at the top of a module.","author_login":"JosephColvin","author_association":"NONE","created_at":"2024-04-10T22:03:13+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2104805488","fragment_type":"issue_comment","sequence":35,"text":"This was closed as 'completed' in Nov 2023, but seems to still be an issue. It's frustrating having to work around this issue with `-Verbose:($PSBoundParameters['Verbose'] -eq $true)` everywhere.","author_login":"wpcoc","author_association":"NONE","created_at":"2024-05-10T15:26:46+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2110894420","fragment_type":"issue_comment","sequence":36,"text":"@SteveL-MSFT this is a bot-closed issue that is still active and should be reopened.","author_login":"JustinGrote","author_association":"CONTRIBUTOR","created_at":"2024-05-14T18:43:20+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2627820102","fragment_type":"issue_comment","sequence":37,"text":"Maybe this is helpful. It would be nice to have something baked in but this `Sync-ModulePreferences`. It solves the original issue and is pretty flexible. No way that I know of to automatically grab the full list of preference variables but hard coded works. You could even pass `Sync-ModulePreferences *` if you wanted to cover all loaded modules but like others, I'm a bit skittish going that far.\n\npowershell\nfunction Sync-ModulePreferences {\n [CmdletBinding(DefaultParameterSetName='Names')]\n param(\n [Parameter(Mandatory,ValueFromPipeline,ParameterSetName='Names')]\n [ValidateNotNullOrEmpty()]\n [string[]] $ModuleName,\n\n [Parameter(Mandatory,ValueFromPipeline,ParameterSetName='Objects')]\n [System.Management.Automation.PSModuleInfo[]] $ModuleObject,\n\n [Parameter(HelpMessage='Subset of preferences to sync')]\n [string[]] $Include,\n\n [Parameter(HelpMessage='Subset of preferences to exclude from sync')]\n [string[]] $Exclude,\n\n [ValidateNotNull()]\n [System.Management.Automation.SessionState] $SessionState = $ExecutionContext.SessionState\n )\n\n $Preferences = @(\n 'ConfirmPreference', 'DebugPreference', 'ErrorActionPreference'\n 'ErrorView', 'FormatEnumerationLimit', 'InformationPreference'\n 'Log*Event', 'MaximumHistoryCount', 'OFS'\n 'OutputEncoding', 'ProgressPreference', 'PSDefaultParameterValues'\n 'PSEmailServer', 'PSModuleAutoloadingPreference', 'PSNativeCommandArgumentPassing'\n 'PSSessionApplicationName', 'PSSessionConfigurationName', 'PSSessionOption'\n 'PSStyle', 'Transcript', 'VerbosePreference'\n 'WarningPreference', 'WhatIfPreference', 'PSNativeCommandUseErrorActionPreference'\n ) |\n Where-Object {\n $IsIncluded = if ($Include) { $_ -in $Include } else { $True }\n $IsExcluded = if ($Exclude) { $_ -in $Exclude } else { $False }\n $IsIncluded -and -not $IsExcluded\n }\n\n $Preferences\n\n $Modules = if ($PSCmdlet.ParameterSetName -eq 'Names') { Get-Module $ModuleName } else { $ModuleObject }\n\n foreach($Module in $Modules) {\n Write-Verbose \"Updating Module '$Module'\"\n foreach ($Preference in $Preferences) {\n $CallerValue = $SessionState.PSVariable.GetValue($Preference)\n $ModuleValue = $Module.SessionState.PSVariable.GetValue($Preference)\n \n if ($CallerValue -is [Hashtable]) {\n foreach ($CallPair in $CallerValue.GetEnumerator()) {\n $ModPairValue = if ($ModuleValue.($CallPair.Name)) { $ModuleValue.($CallPair.Name) }\n\n if ($CallPair.Value -ne $ModPairValue) {\n Write-Verbose \"Updating Preference '$Preference.$($CallPair.Name)' from '$ModPairValue' to '$($CallPair.Value)'\"\n $ModuleValue[$CallPair.Name] = $CallPair.Value\n }\n }\n } elseif ($CallerValue -ne $ModuleValue) {\n Write-Verbose \"Updating Preference '$Preference' from '$ModuleValue' to '$CallerValue'\"\n $Module.SessionState.PSVariable.Set($Preference, $CallerValue)\n }\n }\n }\n}\n\n# Define an in-memory module with a single function Foo() that provokes\n# a non-terminating error.\n$Mod = New-Module {\n function Foo {\n [CmdletBinding()] param()\n Write-Host \"NoNewLine\"\n\n # Provoke a non-terminating error.\n Get-Item /Nosuch\n\n Write-Verbose \"Foo\"\n }\n}\n\n$ErrorActionPreference = 'SilentlyContinue'\n$VerbosePreference = 'Continue'\n$PSDefaultParameterValues.Add('Write-Host:NoNewLine', $True)\n\nSync-ModulePreferences `\n -Verbose `\n -ModuleObject $Mod `\n -Include @('ErrorActionPreference', 'VerbosePreference', 'PSDefaultParameterValues', 'ConfirmPreference') `\n -Exclude ('ConfirmPreference')\n\nFoo\n\n## Update modules on import\n# Import-Module Pester -PassThru | Sync-ModulePreferences\n\n## Example Output\n#VERBOSE: Updating Module 'Pester'\n#VERBOSE: Updating Preference 'ErrorActionPreference' from 'Continue' to 'SilentlyContinue'\n#VERBOSE: Updating Preference 'PSDefaultParameterValues.Write-Host:NoNewLine' from '' to 'True'\n#VERBOSE: Updating Preference 'VerbosePreference' from 'SilentlyContinue' to 'Continue'","author_login":"RiverHeart","author_association":"NONE","created_at":"2025-01-31T17:03:22+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2836598685","fragment_type":"issue_comment","sequence":38,"text":"@RiverHeart You could remove any variable ending with \"preference\" from being hardcoded by changing your variable definition of Preferences to:\n\n`powershell\n$Preferences = @(\n 'ErrorView', 'FormatEnumerationLimit', 'Log*Event'\n 'MaximumHistoryCount', 'OFS', 'OutputEncoding',\n 'PSDefaultParameterValues', 'PSEmailServer', 'PSNativeCommandArgumentPassing'\n 'PSSessionApplicationName', 'PSSessionConfigurationName', 'PSSessionOption'\n 'PSStyle', 'Transcript'\n ) + @(\n Get-ChildItem -Path \"Variable:*preference\" | Select-Object -ExpandProperty 'Name' \n ) | \n Where-Object {\n $IsIncluded = if ($Include) { $_ -in $Include } else { $True }\n $IsExcluded = if ($Exclude) { $_ -in $Exclude } else { $False }\n $IsIncluded -and -not $IsExcluded\n }\n\n`\nIf you would rather, you could also use \n` Get-Variable -Scope 'Global' | Where-Object { $_.Name -ilike '*preference' } | Select-Object -ExpandProperty 'Name' \n` to do the same thing instead of the \n` Get-ChildItem -Path \"Variable:*preference\" | Select-Object -ExpandProperty 'Name' \n` This of course does have the side effect of picking up any variable ending in the word \"Preference\" which I see why one wouldn't want to and why you would want to.\n\nThank you though @RiverHeart for sharing as that has proven to be far better than what I have been doing!","author_login":"JosephColvin","author_association":"NONE","created_at":"2025-04-28T20:58:46+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3048603124","fragment_type":"issue_comment","sequence":39,"text":"I tested the demonstration block from the first post and it seems to work as intended, i.e. no output is produced (as opposed to when I define `$ErrorActionPreference = 'Stop'`.\n\nHas this been fixed already?\n \n\n \n\nName Value\n---- -----\nPSVersion 7.5.2\nPSEdition Core\nGitCommitId 7.5.2\nOS Microsoft Windows 10.0.22621\nPlatform Win32NT\nPSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}\nPSRemotingProtocolVersion 2.3\nSerializationVersion 1.1.0.1\nWSManStackVersion 3.0","author_login":"boernsen-development","author_association":"NONE","created_at":"2025-07-08T11:53:13+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3048962104","fragment_type":"issue_comment","sequence":40,"text":"I don't think so. If you run the example from the terminal it works since `$ErrorActionPreference = 'Stop` also sets `$Global:ErrorActionPreference` which the module can see but if you put that code in a script and call it (eg `./CallPrefTest.ps1`) instead of using ISE or VSCode it behaves as described since only script scope is changed.","author_login":"RiverHeart","author_association":"NONE","created_at":"2025-07-08T13:24:27+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3083508999","fragment_type":"issue_comment","sequence":41,"text":"Even worse with `-WhatIf`:\n\npowershell\n$null = New-Module {\n function main {\n [CmdletBinding(SupportsShouldProcess)]\n param ()\n destructive\n }\n}\n\n$null = New-Module {\n function destructive {\n [CmdletBinding(SupportsShouldProcess)]\n param ()\n \n if ($PSCmdlet.ShouldProcess(\"sub\", \"destructive process\")) {\n Write-Host \"applying destructive process\"\n }\n }\n}\n\nmain -WhatIf\n\nExpected output: `What if: Performing the operation \"destructive process\" on target \"sub\".`\nActual output: `applying destructive process`","author_login":"boernsen-development","author_association":"NONE","created_at":"2025-07-17T10:25:03+08:00","repo_name":"PowerShell/PowerShell","issue_id":250051780,"issue_number":4568,"issue_url":"https://github.com/PowerShell/PowerShell/issues/4568","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0175","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Tutorial around building a wireless hotspot to bypass captive portals?","query_context":"i have the actual Raspi OS `2022-09-22-raspios-bullseye-armhf.img` version installed to my RPi Zero W and tried to set it up as an AP+STA.\nfor the AP part i watched the guide for Setting up a Routed Wireless Access Point.\nbut it looks this guide is outdated.\n\nthere it is written `Buster` is the newest version instead of `Bullseye`.\n\nand they use `iptables` but in the current Raspi OS `iptables` is not installed anymore.\n`sudo: iptables: command not found`\nand its transformation from `iptables` to `nftables` from the earlier version of RaspiOS Bullseye seems to be gone as well.","known_context_document_ids":["gh_issue_1436977258"],"reference_answer":"**Note:** Documentation should be updated to reflect the *latest* version of the OS. So we're going to go through and make sure it all works with Bookworm. We may need some NOTE blocks that mention \"for previous versions of Raspberry Pi OS\" from time to time, but these need to be kept short (a couple of medium-length paragraphs at most). We do not have the availability to support multiple versions of the OS in the documentation going forward with breaking changes like Wayland and Network Manager happening.","answer_document_id":"gh_comment_1525376109","silver_evidence_path":["gh_comment_1304547464","gh_issue_1073476151","gh_comment_1525376109"],"evidence_issue_ids":[1436977258,1073476151],"source_repo_name":"raspberrypi/documentation","source_issue_id":1436977258,"source_issue_number":2687,"source_issue_url":"https://github.com/raspberrypi/documentation/issues/2687","target_repo_name":"raspberrypi/documentation","target_issue_id":1073476151,"target_issue_number":2314,"target_issue_url":"https://github.com/raspberrypi/documentation/issues/2314","reference_anchor_document_id":"gh_comment_1304547464","reference_answer_author":"aallan","reference_answer_author_association":"COLLABORATOR","quality_score":87.82,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0455,"anchor_target_overlap":0.0455,"target_answer_overlap":0.2564},"issue_created_at":"2022-11-05T11:22:59+08:00","valid_comment_count":24,"fragments":[{"document_id":"gh_issue_1436977258","fragment_type":"issue_description","sequence":0,"text":"Tutorial around building a wireless hotspot to bypass captive portals\ni have the actual Raspi OS `2022-09-22-raspios-bullseye-armhf.img` version installed to my RPi Zero W and tried to set it up as an AP+STA.\nfor the AP part i watched the guide for Setting up a Routed Wireless Access Point.\nbut it looks this guide is outdated.\n\nthere it is written `Buster` is the newest version instead of `Bullseye`.\n\nand they use `iptables` but in the current Raspi OS `iptables` is not installed anymore.\n`sudo: iptables: command not found`\nand its transformation from `iptables` to `nftables` from the earlier version of RaspiOS Bullseye seems to be gone as well.","author_login":"beta-tester","author_association":"NONE","created_at":"2022-11-05T11:22:59+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1304547464","fragment_type":"issue_comment","sequence":1,"text":"Honestly somewhat tempted to remove this section, and the following section as well. Feels like something that can be better deal with with the new tutorials section of the site.\n\n<img width=\"1505\" alt=\"Screenshot 2022-11-05 at 13 28 46\" src=\" URL \n\nSee also #2314.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2022-11-05T13:31:29+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[1073476151],"is_known_query_context":false},{"document_id":"gh_comment_1305385733","fragment_type":"issue_comment","sequence":2,"text":"Right. I think we should yank this, and the bridge mode section, and rewrite as a tutorial for the main site. Assigning it to @tobybroberts.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2022-11-07T10:14:44+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1305820382","fragment_type":"issue_comment","sequence":3,"text":"Primarily using `NetworkManager` 'cause it's the new hotness and that's what people will have (ping @tobybroberts), but potentially both I guess depending on how much overhead of extra effort (and awkwardness) it adds to the tutorials.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2022-11-07T15:56:49+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1305825603","fragment_type":"issue_comment","sequence":4,"text":"@tobybroberts wrt our conversation earlier today, we should merge the routed and bridged tutorials together into one \"setting up a wireless access point\".","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2022-11-07T16:00:43+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306128171","fragment_type":"issue_comment","sequence":5,"text":"`NetworkManager` is the new standard then i am fine when there is only a tutorial for that available. thank you in advanced,\n\nwhen i can add some wishes, please also try to make a tutorial for AP + STA mode.\ne.g. for the RPi Zero W it would be nice to have STA and AP simultanuosly on its wlan.\nthere are some old uncomplete guides out there, but none is using `NetworkManager` to do that yet.","author_login":"beta-tester","author_association":"NONE","created_at":"2022-11-07T20:08:17+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374733423","fragment_type":"issue_comment","sequence":6,"text":"but the tutorial section hasn't changed and is still outdated","author_login":"beta-tester","author_association":"NONE","created_at":"2023-01-08T07:01:12+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374872375","fragment_type":"issue_comment","sequence":7,"text":"It's actually more or less at the top of the to do list, someone should be looking at it next week.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-01-08T16:15:48+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1687810916","fragment_type":"issue_comment","sequence":8,"text":"@lurch Talking to @jehlers42 right now and this part of the docs (highlighted in red) still seem to be present on the `bookworm` branch. Shouldn't all this stuff be deleted from the branch at this point. The tutorials still need to be written but I thought you'd told me you'd deleted the text from the branch at this point? If not everything in the red box needs to go. \n\n@jehlers42 can you figure out what text needs to go, and get rid of it from the `bookworm` branch. Post the commit back to this thread, and leave the issue open, 'cause we still need to write the updated tutorial(s) which will end up in Wordpress.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-08-22T09:23:52+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1687820584","fragment_type":"issue_comment","sequence":9,"text":"...and they are no longer in the branch. Leaving this issue open because someone (me, @tobybroberts, Nate perhaps when he joins) needs to write replacement tutorials (in Wordpress).","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-08-22T09:29:56+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1687834676","fragment_type":"issue_comment","sequence":10,"text":"Nope, I don't ever remember claiming that. I was leaving the text in-situ in case it'd be a useful reference for whoever ends up writing the replacement tutorials? But you're right, they should definitely be removed from the `bookworm` branch before it gets merged :+1: \n\nOn a vaguely-related note, I wonder if it'd be useful to have a \"link-to-tutorial boxout\" (like @nelliemckesson has done for PIP and the RPi Press books) that we could use to link from the documentation to the tutorials? :thinking:","author_login":"lurch","author_association":"COLLABORATOR","created_at":"2023-08-22T09:37:51+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1705608234","fragment_type":"issue_comment","sequence":11,"text":"@nathan-contino So this is us yanking tutorial content that shouldn't live here and writing a new one in Wordpress (and then we can use that tutorial macro stuff, see #3082 to link back to it the documentation in the right place)","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-09-04T18:35:19+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750700881","fragment_type":"issue_comment","sequence":12,"text":"@nathan-contino Going to reopen this issue as there is still a Wordpress tutorial associated with it to write!","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-10-06T13:40:02+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1757334756","fragment_type":"issue_comment","sequence":13,"text":"Live at URL \n\nThere will also be a tutorial going into URL at some point soon.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-10-11T10:17:32+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1858775752","fragment_type":"issue_comment","sequence":14,"text":"is the RPi onboard WiFi able to do AP + STA at the same time? and if so, how to do this to get AP + STA running?","author_login":"beta-tester","author_association":"NONE","created_at":"2023-12-16T09:44:35+08:00","repo_name":"raspberrypi/documentation","issue_id":1436977258,"issue_number":2687,"issue_url":"https://github.com/raspberrypi/documentation/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1073476151","fragment_type":"issue_description","sequence":0,"text":"Update documentation for ahead of Bookworm\n~We now offer both Bullseye and Buster (Legacy) releases of Raspberry Pi OS. However some features work in one but not the other, and vice-versa.~\n\n~@JamesH65 has an internal document which is probably a useful starting point for this.~\n\n(edit by @aallan) We need to update the documentation for Bookworm. Online documentation will focus on supporting Bookworm only. There will be NOTE blocks referencing that \"things worked differently\" in the previous (legacy) version if that's appropriate/needed. We'll try and keep those blocks short.","author_login":"lurch","author_association":"COLLABORATOR","created_at":"2021-12-07T15:19:12+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_988027178","fragment_type":"issue_comment","sequence":1,"text":"And perhaps URL and/or URL ought to mention the different versions too?","author_login":"lurch","author_association":"CONTRIBUTOR","created_at":"2021-12-07T15:22:47+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_996936576","fragment_type":"issue_comment","sequence":2,"text":"This is already underway internally, but it's a private repo.","author_login":"JamesH65","author_association":"CONTRIBUTOR","created_at":"2021-12-17T18:37:14+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1107827453","fragment_type":"issue_comment","sequence":3,"text":"Should stay open. Still some updating needed. See also #2398.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2022-04-24T12:04:50+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1107828905","fragment_type":"issue_comment","sequence":4,"text":"@aallan \nAre you simply updating the vlc and omx examples according to the version?","author_login":"RuffaloLavoisier","author_association":"CONTRIBUTOR","created_at":"2022-04-24T12:13:09+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1107829770","fragment_type":"issue_comment","sequence":5,"text":"OMX Player no longer works under Bullseye. All the examples using it in the documentation need to be replaced with an equivalent invocation for VLC (or other relevant software), see #2398 which is the linked issue.\n\nHowever this issue is the more general \"other things that Bullseye broke\" issue. There are some other things beyond the OMX Player issue that haven't yet been fixed.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2022-04-24T12:18:28+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1107841250","fragment_type":"issue_comment","sequence":6,"text":"If there is something to be done externally, I would be happy to contribute.","author_login":"RuffaloLavoisier","author_association":"CONTRIBUTOR","created_at":"2022-04-24T13:22:16+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1525369999","fragment_type":"issue_comment","sequence":7,"text":"Headline things:\n\n \n* X goes away and is replaced by Wayland\n - nominally a big thing, but there has been a lot of work to keep the user experience the same\n - but some change is inevitable\n* dhcpcd goes away and is replaced by Network Manager\n* random bookworm stuff","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-04-27T10:12:49+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1525376109","fragment_type":"issue_comment","sequence":8,"text":"**Note:** Documentation should be updated to reflect the *latest* version of the OS. So we're going to go through and make sure it all works with Bookworm. We may need some NOTE blocks that mention \"for previous versions of Raspberry Pi OS\" from time to time, but these need to be kept short (a couple of medium-length paragraphs at most). We do not have the availability to support multiple versions of the OS in the documentation going forward with breaking changes like Wayland and Network Manager happening.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-04-27T10:15:14+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1525561412","fragment_type":"issue_comment","sequence":9,"text":"Current tasks associated with this issue:\n\n[tasklist]\n### Bookworm Issues\n- [ ] URL \n- [ ] URL \n- [ ] URL \n\nthis task list will expand rapidly when @lurch does the documentation audio.","author_login":"aallan","author_association":"COLLABORATOR","created_at":"2023-04-27T11:56:56+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1620128288","fragment_type":"issue_comment","sequence":10,"text":"Child-issues:\n* #2999 \n* #2947 \n* #2948 \n* #2949 \n* #2950 \n* #2951 \n* #2952 \n* #2953","author_login":"lurch","author_association":"COLLABORATOR","created_at":"2023-07-04T12:08:07+08:00","repo_name":"raspberrypi/documentation","issue_id":1073476151,"issue_number":2314,"issue_url":"https://github.com/raspberrypi/documentation/issues/2314","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0176","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"make_fx fails under TorchRefsMode context?","query_context":"### 🐛 Describe the bug\n\nRun into this issue with torchdynamo/benchmarks/huggingface.py with a custom stack (nvprim).\n\nTried to get a small repro but failed. However, I did manage to get a different failure in this small example vvv:\n\nimport torch\n\nx = torch.empty(1024, 1, device=\"cuda\")\ntarget = torch.empty(1024, device=\"cuda\").long()\n\ndef func(x, target, index):\n nll_loss_forward = torch.ops.aten.nll_loss_forward.default(x, target, None, 1, index)\n\nfrom torch.fx.experimental.proxy_tensor import make_fx\n\nfrom torch._decomp import get_decompositions\ndecomp_table = get_decompositions({torch.ops.aten.nll_loss_forward})\ngm = make_fx(func, decomposition_table=decomp_table)(x, target, 512) # tracing with decomposition works\nprint(gm.graph)\n\nfrom torch._prims.context import TorchRefsMode\nwith TorchRefsMode():\n gm = make_fx(func)(x, target, 512) # somehow tracing here with decomposition breaks.\n print(gm.graph)\n\nOutput\n\ngraph():\n %x_1 : [#users=1] = placeholder[target=x_1]\n %target_1 : [#users=3] = placeholder[target=target_1]\n %index_1 : [#users=0] = placeholder[target=index_1]\n %unsqueeze : [#users=1] = call_functiontarget=torch.ops.aten.unsqueeze.default, kwargs = {})\n %gather : [#users=1] = call_functiontarget=torch.ops.aten.gather.default, kwargs = {})\n %squeeze : [#users=1] = call_functiontarget=torch.ops.aten.squeeze.dim, kwargs = {})\n %neg : [#users=1] = call_functiontarget=torch.ops.aten.neg.default, kwargs = {})\n %ne : [#users=1] = call_functiontarget=torch.ops.aten.ne.Scalar, kwargs = {})\n %scalar_tensor : [#users=1] = call_functiontarget=torch.ops.aten.scalar_tensor.default, kwargs = {dtype: torch.float32, layout: torch.strided, device: cuda:0})\n %where : [#users=1] = call_functiontarget=torch.ops.aten.where.self, kwargs = {})\n %ne_1 : [#users=1] = call_functiontarget=torch.ops.aten.ne.Scalar, kwargs = {})\n %sum_1 : [#users=1] = call_functiontarget=torch.ops.aten.sum.default, kwargs = {})\n %_to_copy : [#users=1] = call_functiontarget=torch.ops.aten._to_copy.default, kwargs = {dtype: torch.float32, device: cuda:0})\n %sum_2 : [#users=1] = call_functiontarget=torch.ops.aten.sum.default, kwargs = {})\n %div : [#users=0] = call_functiontarget=torch.ops.aten.div.Tensor, kwargs = {})\n return None\nTraceback (most recent call last):\n File \"/jiej/playground/repro_control_flow.py\", line 19, in \n gm = make_fx(func)(x, target, 512)\n File \"/opt/pytorch/pytorch/torch/fx/experimental/proxy_tensor.py\", line 622, in wrapped\n t = dispatch_trace(wrap_key(func, args, fx_tracer), tracer=fx_tracer, concrete_args=tuple(phs))\n File \"/opt/pytorch/pytorch/torch/fx/experimental/proxy_tensor.py\", line 392, in dispatch_trace\n graph = tracer.trace(root, concrete_args)\n File \"/opt/pytorch/pytorch/torch/fx/_symbolic_trace.py\", line 739, in trace\n (self.create_arg(fn(*args)),),\n File \"/opt/pytorch/pytorch/torch/fx/experimental/proxy_tensor.py\", line 406, in wrapped\n out = f(*tensors)\n File \"/jiej/playground/repro_control_flow.py\", line 7, in func\n nll_loss_forward = torch.ops.aten.nll_loss_forward.default(x, target, None, 1, index)\n File \"/opt/pytorch/pytorch/torch/_ops.py\", line 60, in __call__\n return self._op(*args, **kwargs or {})\n File \"/opt/pytorch/pytorch/torch/overrides.py\", line 1778, in wrapped\n return f(self, *args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_prims/context.py\", line 187, in __torch_function__\n return func(*args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_decomp/decompositions.py\", line 1740, in nll_loss_forward\n total_weight = (target != ignore_index).sum().to(self)\n File \"/opt/pytorch/pytorch/torch/overrides.py\", line 1778, in wrapped\n return f(self, *args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_prims/context.py\", line 187, in __torch_function__\n return func(*args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_refs/__init__.py\", line 1697, in to\n return prims.convert_element_type(a, dtype)\n File \"/opt/pytorch/pytorch/torch/_ops.py\", line 60, in __call__\n return self._op(*args, **kwargs or {})\n File \"/opt/pytorch/pytorch/torch/overrides.py\", line 1778, in wrapped\n return f(self, *args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_prims/context.py\", line 168, in __torch_function__\n return orig_func(*args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_ops.py\", line 60, in __call__\n return self._op(*args, **kwargs or {})\nRuntimeError: prims::convert_element_type() Expected a value of type 'int' for argument 'dtype' but instead found type 'Tensor'.\nPosition: 1\nValue: tensor([[0.],\n [0.],\n [0.],\n ...,\n [0.],\n [0.],\n [0.]], device='cuda:0')\nDeclaration: prims::convert_element_type(Tensor a, int dtype) -> Tensor\nCast error details: Unable to cast Python instance to C++ type (#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in debug mode for details)\n\nThe original error I'm getting is `It appears that you're trying to get value out of a tracing tensor - erroring out! It's likely that this is caused by data-dependent control flow or similar.`\nwhich seems to be originated from tracing with decomposition inside `TorchRefsNvfuserCapabilityMode`\n\nTo repro the original issue: running with torchdynamo code from here: URL \nrun it with `python benchmarks/huggingface.py --training -d cuda --fast --nvprims-nvfuser --skip-accuracy-check --generate-aot-autograd-stats --dump-raw-metrics --float32 -k AlbertForQuestionAnswering`\n\n### Versions\n\nRunning with pytorch\n\ncommit 9addeccb6b1ec9fed0246ba18fdb70550c813a90 (HEAD, origin/master, origin/HEAD, master)\nAuthor: kshitij12345 \nDate: Thu Sep 8 06:23:12 2022 +0000\n\n [functorch] vmapvjpvjp (re-enable test with skips and xfails) (#83999)\n \n Enable `vmapvjpvjp` test and add relevant skips and xfails.\n Pull Request resolved: URL \n Approved by: URL \n\ntorchdynamo commit\n\ncommit cad8185c937f2396ba1c683b86844c0248f2f538 (ivan/nvprims-backend)\nMerge: dcd88d1 11873be\nAuthor: Ivan Yashchuk \nDate: Thu Sep 1 10:13:19 2022 +0300\n\n Merge remote-tracking branch 'upstream/main' into nvprims-backend\n\ncc @ezyang @mruberry @ngimel @SherlockNoMad @soumith","known_context_document_ids":["gh_issue_1367207931"],"reference_answer":"Looks like there's some example of how `var.X` overloads are handled in refs. I'll follow that pattern and get overloads of Tensor.to plumbed through.","answer_document_id":"gh_comment_1242515274","silver_evidence_path":["gh_comment_1241628927","gh_issue_1355693540","gh_comment_1242515274"],"evidence_issue_ids":[1367207931,1355693540],"source_repo_name":"pytorch/pytorch","source_issue_id":1367207931,"source_issue_number":84734,"source_issue_url":"https://github.com/pytorch/pytorch/issues/84734","target_repo_name":"pytorch/pytorch","target_issue_id":1355693540,"target_issue_number":84264,"target_issue_url":"https://github.com/pytorch/pytorch/issues/84264","reference_anchor_document_id":"gh_comment_1241628927","reference_answer_author":"jjsjann123","reference_answer_author_association":"COLLABORATOR","quality_score":85.77,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.7255,"anchor_target_overlap":0.0682,"target_answer_overlap":0.1538},"issue_created_at":"2022-09-09T02:44:46+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1367207931","fragment_type":"issue_description","sequence":0,"text":"make_fx fails under TorchRefsMode context\n### 🐛 Describe the bug\n\nRun into this issue with torchdynamo/benchmarks/huggingface.py with a custom stack (nvprim).\n\nTried to get a small repro but failed. However, I did manage to get a different failure in this small example vvv:\n\nimport torch\n\nx = torch.empty(1024, 1, device=\"cuda\")\ntarget = torch.empty(1024, device=\"cuda\").long()\n\ndef func(x, target, index):\n nll_loss_forward = torch.ops.aten.nll_loss_forward.default(x, target, None, 1, index)\n\nfrom torch.fx.experimental.proxy_tensor import make_fx\n\nfrom torch._decomp import get_decompositions\ndecomp_table = get_decompositions({torch.ops.aten.nll_loss_forward})\ngm = make_fx(func, decomposition_table=decomp_table)(x, target, 512) # tracing with decomposition works\nprint(gm.graph)\n\nfrom torch._prims.context import TorchRefsMode\nwith TorchRefsMode():\n gm = make_fx(func)(x, target, 512) # somehow tracing here with decomposition breaks.\n print(gm.graph)\n\nOutput\n\ngraph():\n %x_1 : [#users=1] = placeholder[target=x_1]\n %target_1 : [#users=3] = placeholder[target=target_1]\n %index_1 : [#users=0] = placeholder[target=index_1]\n %unsqueeze : [#users=1] = call_functiontarget=torch.ops.aten.unsqueeze.default, kwargs = {})\n %gather : [#users=1] = call_functiontarget=torch.ops.aten.gather.default, kwargs = {})\n %squeeze : [#users=1] = call_functiontarget=torch.ops.aten.squeeze.dim, kwargs = {})\n %neg : [#users=1] = call_functiontarget=torch.ops.aten.neg.default, kwargs = {})\n %ne : [#users=1] = call_functiontarget=torch.ops.aten.ne.Scalar, kwargs = {})\n %scalar_tensor : [#users=1] = call_functiontarget=torch.ops.aten.scalar_tensor.default, kwargs = {dtype: torch.float32, layout: torch.strided, device: cuda:0})\n %where : [#users=1] = call_functiontarget=torch.ops.aten.where.self, kwargs = {})\n %ne_1 : [#users=1] = call_functiontarget=torch.ops.aten.ne.Scalar, kwargs = {})\n %sum_1 : [#users=1] = call_functiontarget=torch.ops.aten.sum.default, kwargs = {})\n %_to_copy : [#users=1] = call_functiontarget=torch.ops.aten._to_copy.default, kwargs = {dtype: torch.float32, device: cuda:0})\n %sum_2 : [#users=1] = call_functiontarget=torch.ops.aten.sum.default, kwargs = {})\n %div : [#users=0] = call_functiontarget=torch.ops.aten.div.Tensor, kwargs = {})\n return None\nTraceback (most recent call last):\n File \"/jiej/playground/repro_control_flow.py\", line 19, in \n gm = make_fx(func)(x, target, 512)\n File \"/opt/pytorch/pytorch/torch/fx/experimental/proxy_tensor.py\", line 622, in wrapped\n t = dispatch_trace(wrap_key(func, args, fx_tracer), tracer=fx_tracer, concrete_args=tuple(phs))\n File \"/opt/pytorch/pytorch/torch/fx/experimental/proxy_tensor.py\", line 392, in dispatch_trace\n graph = tracer.trace(root, concrete_args)\n File \"/opt/pytorch/pytorch/torch/fx/_symbolic_trace.py\", line 739, in trace\n (self.create_arg(fn(*args)),),\n File \"/opt/pytorch/pytorch/torch/fx/experimental/proxy_tensor.py\", line 406, in wrapped\n out = f(*tensors)\n File \"/jiej/playground/repro_control_flow.py\", line 7, in func\n nll_loss_forward = torch.ops.aten.nll_loss_forward.default(x, target, None, 1, index)\n File \"/opt/pytorch/pytorch/torch/_ops.py\", line 60, in __call__\n return self._op(*args, **kwargs or {})\n File \"/opt/pytorch/pytorch/torch/overrides.py\", line 1778, in wrapped\n return f(self, *args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_prims/context.py\", line 187, in __torch_function__\n return func(*args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_decomp/decompositions.py\", line 1740, in nll_loss_forward\n total_weight = (target != ignore_index).sum().to(self)\n File \"/opt/pytorch/pytorch/torch/overrides.py\", line 1778, in wrapped\n return f(self, *args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_prims/context.py\", line 187, in __torch_function__\n return func(*args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_refs/__init__.py\", line 1697, in to\n return prims.convert_element_type(a, dtype)\n File \"/opt/pytorch/pytorch/torch/_ops.py\", line 60, in __call__\n return self._op(*args, **kwargs or {})\n File \"/opt/pytorch/pytorch/torch/overrides.py\", line 1778, in wrapped\n return f(self, *args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_prims/context.py\", line 168, in __torch_function__\n return orig_func(*args, **kwargs)\n File \"/opt/pytorch/pytorch/torch/_ops.py\", line 60, in __call__\n return self._op(*args, **kwargs or {})\nRuntimeError: prims::convert_element_type() Expected a value of type 'int' for argument 'dtype' but instead found type 'Tensor'.\nPosition: 1\nValue: tensor([[0.],\n [0.],\n [0.],\n ...,\n [0.],\n [0.],\n [0.]], device='cuda:0')\nDeclaration: prims::convert_element_type(Tensor a, int dtype) -> Tensor\nCast error details: Unable to cast Python instance to C++ type (#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in debug mode for details)\n\nThe original error I'm getting is `It appears that you're trying to get value out of a tracing tensor - erroring out! It's likely that this is caused by data-dependent control flow or similar.`\nwhich seems to be originated from tracing with decomposition inside `TorchRefsNvfuserCapabilityMode`\n\nTo repro the original issue: running with torchdynamo code from here: URL \nrun it with `python benchmarks/huggingface.py --training -d cuda --fast --nvprims-nvfuser --skip-accuracy-check --generate-aot-autograd-stats --dump-raw-metrics --float32 -k AlbertForQuestionAnswering`\n\n### Versions\n\nRunning with pytorch\n\ncommit 9addeccb6b1ec9fed0246ba18fdb70550c813a90 (HEAD, origin/master, origin/HEAD, master)\nAuthor: kshitij12345 \nDate: Thu Sep 8 06:23:12 2022 +0000\n\n [functorch] vmapvjpvjp (re-enable test with skips and xfails) (#83999)\n \n Enable `vmapvjpvjp` test and add relevant skips and xfails.\n Pull Request resolved: URL \n Approved by: URL \n\ntorchdynamo commit\n\ncommit cad8185c937f2396ba1c683b86844c0248f2f538 (ivan/nvprims-backend)\nMerge: dcd88d1 11873be\nAuthor: Ivan Yashchuk \nDate: Thu Sep 1 10:13:19 2022 +0300\n\n Merge remote-tracking branch 'upstream/main' into nvprims-backend\n\ncc @ezyang @mruberry @ngimel @SherlockNoMad @soumith","author_login":"jjsjann123","author_association":"COLLABORATOR","created_at":"2022-09-09T02:44:46+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1241440636","fragment_type":"issue_comment","sequence":1,"text":"To clarify, #84735 is NOT a proper solution. I started that PR so we can at least avoid similar failures in torchbench. But there's probably some sharp corner in our tracing that we should get it properly fixed.","author_login":"jjsjann123","author_association":"COLLABORATOR","created_at":"2022-09-09T02:56:39+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241442642","fragment_type":"issue_comment","sequence":2,"text":"I still think y'all should be using TorchRefsMode to do decompositions...","author_login":"ezyang","author_association":"CONTRIBUTOR","created_at":"2022-09-09T03:00:36+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241468850","fragment_type":"issue_comment","sequence":3,"text":"hahaha, you are probably right from the beginning. But I don't know enough to comment on this, I'll let @IvanYashchuk make the right call~~","author_login":"jjsjann123","author_association":"COLLABORATOR","created_at":"2022-09-09T03:55:42+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241628927","fragment_type":"issue_comment","sequence":4,"text":"Here's what really happens:\n\npy\nimport torch\nfrom torch._prims.context import TorchRefsMode\na = torch.randn(3, 3, device='cuda')\nb = torch.randn(3, 3, device='cuda')\n\ndef func(a, b):\n return a.to(b)\nwith TorchRefsMode():\n func(a, b)\n\npy\nRuntimeError: prims::convert_element_type() Expected a value of type 'int' for argument 'dtype' but instead found type 'Tensor'.\nPosition: 1\nValue: tensor([[-0.0440, -0.6463, -1.2029],\n [ 0.8581, -0.1144, -0.2697],\n [ 0.3353, 0.1361, -1.8018]], device='cuda:0')\nDeclaration: prims::convert_element_type(Tensor a, int dtype) -> Tensor\nCast error details: Unable to cast Python instance to C++ type (#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in debug mode for details)\n\nIt's not a problem with `TorchRefsMode()` it's a problem with `torch._refs.to`. There are tests that are supposed to verify calling `tensor.to(tensor)`:\n URL \nAnd there's an issue for implementing this: URL \n\nClosing as duplicate.","author_login":"IvanYashchuk","author_association":"COLLABORATOR","created_at":"2022-09-09T07:50:57+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[1355693540],"is_known_query_context":false},{"document_id":"gh_comment_1241991146","fragment_type":"issue_comment","sequence":5,"text":"@kevinstephano The majority of decomps could be applied via the decompositions table that proxy tensor tracing respects (or you can apply yourself in a TorchDispatchMode). The key is that the decomposition happens later; instead of forcing yourself to accurately handle all Python frontend quirks, you can decompose after it's gotten through the Python arg parser and gotten normalized.","author_login":"ezyang","author_association":"CONTRIBUTOR","created_at":"2022-09-09T13:42:07+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1242034631","fragment_type":"issue_comment","sequence":6,"text":"PrimTorch targets implementing references for all Python frontend quirks. And we are working towards supporting PrimTorch.\n\nThere's a nice feature that for operations that overlap in ATen and Python's PyTorch it's possible to register the reference implementations to the decomposition table of `torch._decomp`. So that TorchDispatchMode users can benefit from increased PrimTorch coverage of references.\n URL \n\nThe requirement to support aten->refs mapping is a temporary workaround because backward rules are not yet implemented for prims and AOT Autograd produces a graph with `torch.ops.aten` calls by default. Soon when prims gain backward support we won't need aten->refs mapping.\n\nThank you, I've heard multiple times how targeting internal ATen CompositeExplicitAutograd functions is great. I will stick with PrimTorch though, supporting Python's user-facing interface, and I will not pivot towards making \"ATen CompositeExplicitAutograd\" (`torch._decomp.decomposition_table`) the primary target for nvFuser execution.","author_login":"IvanYashchuk","author_association":"COLLABORATOR","created_at":"2022-09-09T14:20:15+08:00","repo_name":"pytorch/pytorch","issue_id":1367207931,"issue_number":84734,"issue_url":"https://github.com/pytorch/pytorch/issues/84734","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1355693540","fragment_type":"issue_description","sequence":0,"text":"Support more overloads of Tensor.to in torch._refs.to\n### 🚀 The feature, motivation and pitch\n\nThere are multiple overloads of `to`, but currently only one overload is supported in `torch._refs.to`\naten/src/ATen/native/native_functions.yaml lists all overloads:\n URL \nMissing overloads:\n\n- [ ] to.dtype_layout\n- [ ] to.device\n- [ ] to.other\n\n### Alternatives\n\n_No response_\n\n### Additional context\n\n_No response_\n\ncc @ezyang @mruberry @ngimel @jjsjann123","author_login":"IvanYashchuk","author_association":"COLLABORATOR","created_at":"2022-08-30T12:30:18+08:00","repo_name":"pytorch/pytorch","issue_id":1355693540,"issue_number":84264,"issue_url":"https://github.com/pytorch/pytorch/issues/84264","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1242515274","fragment_type":"issue_comment","sequence":1,"text":"Looks like there's some example of how `var.X` overloads are handled in refs. I'll follow that pattern and get overloads of Tensor.to plumbed through.","author_login":"jjsjann123","author_association":"COLLABORATOR","created_at":"2022-09-09T22:05:18+08:00","repo_name":"pytorch/pytorch","issue_id":1355693540,"issue_number":84264,"issue_url":"https://github.com/pytorch/pytorch/issues/84264","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0177","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Error: detected space-or-tab-containing sequence?","query_context":"Hi, I am trying to run this pipeline through Anaconda and I am getting the following error:\n\n_Error! File: data/Nitens-and-Greg/GCF_021461395.2_iqSchAmer2.1_genomic.fna - detected space-or-tab-containing sequence:\nNC_060119.1 Schistocerca americana isolate TAMUIC-IGC-003095 chromosome 1, iqSchAmer2.1, whole genome shotgun sequence\nPlease exclude or fix sequences with spaces and tabs._\n\nFrom what I can tell, it is a problem with the formatting of the header in the fasta file as suggested in the GitHub. I have seen the script to rename after running but there is no script to rename before. do you have a script I can use or a suggestion on how to fix this error? I have included a screenshot of the full run below.\n\nI am trying to run this on very large RefSeq genomes (~8Gb) and I would appreciate any help you can offer!\n\nScreenshot 2024-06-18 163252","known_context_document_ids":["gh_issue_2360768421"],"reference_answer":"Hi Dong-Ha,\n\nI am sorry for that, just fixed the issue (I assigned updated chrome names to the wrong fields...) URL \n\nNow they are correct.\n\n- Bogdan","answer_document_id":"gh_comment_1273246194","silver_evidence_path":["gh_comment_2185328416","gh_issue_1403096227","gh_comment_1273246194"],"evidence_issue_ids":[2360768421,1403096227],"source_repo_name":"hillerlab/make_lastz_chains","source_issue_id":2360768421,"source_issue_number":63,"source_issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/63","target_repo_name":"hillerlab/make_lastz_chains","target_issue_id":1403096227,"target_issue_number":8,"target_issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/8","reference_anchor_document_id":"gh_comment_2185328416","reference_answer_author":"kirilenkobm","reference_answer_author_association":"MEMBER","quality_score":95.03,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1228,"anchor_target_overlap":0.0862,"target_answer_overlap":0.2857},"issue_created_at":"2024-06-18T21:36:12+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2360768421","fragment_type":"issue_description","sequence":0,"text":"Error: detected space-or-tab-containing sequence\nHi, I am trying to run this pipeline through Anaconda and I am getting the following error:\n\n_Error! File: data/Nitens-and-Greg/GCF_021461395.2_iqSchAmer2.1_genomic.fna - detected space-or-tab-containing sequence:\nNC_060119.1 Schistocerca americana isolate TAMUIC-IGC-003095 chromosome 1, iqSchAmer2.1, whole genome shotgun sequence\nPlease exclude or fix sequences with spaces and tabs._\n\nFrom what I can tell, it is a problem with the formatting of the header in the fasta file as suggested in the GitHub. I have seen the script to rename after running but there is no script to rename before. do you have a script I can use or a suggestion on how to fix this error? I have included a screenshot of the full run below.\n\nI am trying to run this on very large RefSeq genomes (~8Gb) and I would appreciate any help you can offer!\n\nScreenshot 2024-06-18 163252","author_login":"ecbaker7-tamu","author_association":"NONE","created_at":"2024-06-18T21:36:12+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":2360768421,"issue_number":63,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/63","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2185328416","fragment_type":"issue_comment","sequence":1,"text":"Hi, @MichaelHiller and @kirilenkobm. I just wanted to add details to this request. We understand this is probably an issue because we use the chromosome with \"NCXXX.Y,\" specified in issue #8 #3 and added in the README. Still, we would appreciate knowing what is the best method to rename here and being able to use your custom scripts to rename afterward `standalone_scripts/rename_chromosomes_back.py.` \n\nWe want to use `make_lastz_chain` and `TOGA` to check whether the ortholog detection using RefSeq on some of our genomes could be improved compared to OrthoFinder, so we want to keep the GCF type. I am sure the solution is very straightforward, and I am sorry for the silly question. Bioinformatics is hard, even after many years!! o(>.<)o \n\nThanks for your time!","author_login":"MaevaTecher","author_association":"NONE","created_at":"2024-06-23T21:27:42+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":2360768421,"issue_number":63,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/63","linked_issue_ids":[1403096227],"is_known_query_context":false},{"document_id":"gh_comment_2187200475","fragment_type":"issue_comment","sequence":2,"text":"I believe I've corrected it myself, the code I used is below. and was saved into a .sh file \n\n#!/bin/bash\n\n# Define the input and output files\ninput_file=\"input-name.fna\"\noutput_file=\"input-name_only_contig_name.fna\"\n\n# Use sed to process both headers and sequences in one pass\nsed -e 's/^\\(>\\S*\\).*/\\1/' \"$input_file\" > \"$output_file\"\n\necho \"Processing complete. Output written to $output_file.\"","author_login":"ecbaker7-tamu","author_association":"NONE","created_at":"2024-06-24T18:51:29+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":2360768421,"issue_number":63,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1403096227","fragment_type":"issue_description","sequence":0,"text":"Renaming sequence in the chain has an issue.\nHi again,\nI saw the update to deal with the sequence IDs with \".\" (per issue #3):\n \n\nSince it appears that you implemented a mechanism to deal with the \".*\" in sequence IDs, I downloaded the new version of the pipeline and ran it with the input genomes without modifying sequence IDs. \n\nThe pipeline started with creating a renamed `.fasta` file and a `.tsv` that contains the sequence ID conversion table. And at the end, the log says the pipeline is renaming chromosome names in the chain file.\n\nHowever, the resulting chain file does not look right. Most of all, the chain score field is gone, making it impossible to salvage the results:\n\n$ zgrep \"chain\" h38w5.m39w5.allfilled.chain.gz | head -n5 | column -t\nchain NC_000014.9 NC_000014 107043718 + 24687985 NC_000078.7 NC_000078 120092757 + 44683557 114519917 1\nchain NC_000004.12 NC_000004 190214555 + 1103677 NC_000071.7 NC_000071 151758149 + 33338229 105126044 2\nchain NC_000002.12 NC_000002 242193529 + 96496148 NC_000067.7 NC_000067 195154279 + 36305135 93990572 3\nchain NC_000001.11 NC_000001 248956422 + 930892 NC_000070.7 NC_000070 156860686 - 516431 53690008 4\nchain NC_000001.11 NC_000001 248956422 + 68121445 NC_000069.7 NC_000069 159745316 - 100601 72842298 5\n\n \n\nFor comparison, below is the chain file using a previous version of `make_lastz_chains`. Here, I supplied the input genomes with sequence IDs pre-modified: \n\n$ zgrep \"chain\" h38w4.m39w4.all.chain.gz | head -n5 | column -t \nchain 720570302 NC_000014__9 107043718 + 24687985 106824309 NC_000078__7 120092757 + 44683557 114419863 1\nchain 598452391 NC_000004__12 190214555 + 1104636 88140396 NC_000071__7 151758149 + 33339160 105126044 2\nchain 584782083 NC_000001__11 248956422 + 930892 58547094 NC_000070__7 156860686 - 516431 53690008 3\nchain 578674369 NC_000002__12 242193529 + 96496148 241869966 NC_000067__7 195154279 + 36305135 93989195 4\nchain 564776354 NC_000001__11 248956422 + 68121445 158184951 NC_000069__7 159745316 - 100601 72842298 5\n\nIs there any other part of the pipeline updated since July 6th, 2022? If not, we will revert back to the older version (make_lastz_chains) and use genome files with the modified sequence IDs. The current version has an issue. \n\nThanks, \nDong-Ha","author_login":"ohdongha","author_association":"NONE","created_at":"2022-10-10T12:28:26+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":1403096227,"issue_number":8,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273246194","fragment_type":"issue_comment","sequence":1,"text":"Hi Dong-Ha,\n\nI am sorry for that, just fixed the issue (I assigned updated chrome names to the wrong fields...) URL \n\nNow they are correct.\n\n- Bogdan","author_login":"kirilenkobm","author_association":"MEMBER","created_at":"2022-10-10T12:33:32+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":1403096227,"issue_number":8,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273249758","fragment_type":"issue_comment","sequence":2,"text":"Thanks, Bogdan, for the quick response. \n\nIs there anything else updated since July 6th, 2022, other than the renaming of sequence IDs? \n\n Dong-Ha","author_login":"ohdongha","author_association":"NONE","created_at":"2022-10-10T12:36:31+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":1403096227,"issue_number":8,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1276534887","fragment_type":"issue_comment","sequence":3,"text":"Thanks, Bogdan, for responding quickly. I have already submitted a round of runs using genomes renamed (\".\" -> \"__\") manually. I will test this fix in the next round and close the ticket when it goes through. \n\nDong-Ha","author_login":"ohdongha","author_association":"NONE","created_at":"2022-10-12T17:51:48+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":1403096227,"issue_number":8,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1288222894","fragment_type":"issue_comment","sequence":4,"text":"I tested the script downloaded on Oct. 10th (before the fix for #10 but after URL and it worked well with sequence IDs that contain \".\" and generated the correct `chain.gz` file.\n\nThanks!\nDong-Ha","author_login":"ohdongha","author_association":"NONE","created_at":"2022-10-23T23:04:26+08:00","repo_name":"hillerlab/make_lastz_chains","issue_id":1403096227,"issue_number":8,"issue_url":"https://github.com/hillerlab/make_lastz_chains/issues/8","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0178","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"What is the nullness signature of a multiply-inherited abstract method?","query_context":"[EDIT: this whole comment is about case 1, where the method is abstract because all inherited methods are abstract.]\n\nFirst consider a discrepancy in return types:\n\n// in null-marked context\n\ninterface Foo { @Nullable String get(); }\ninterface Bar { /*non-nullable*/ String get(); }\ninterface Qux extends Foo, Bar {}\n\nIn this case, we can probably just follow Java's lead. With a quick experiment it seems that it won't just happily gin up an arbitrary intersection type, but if one of the types is more specific than the other (as should always be the case for us), it seems to go with that. (Or maybe I've gotten it wrong, but whatever it does, we can probably(?) stay consistent with.)\n\n// in null-marked context\n\ninterface Foo { void accept(@Nullable String x); }\ninterface Bar { void accept(/*non-nullable*/ String x); }\ninterface Qux extends Foo, Bar {}\n\nHere, Java is no guide, because any discrepancy in the types results in both overloads existing separately in `Qux` which we obviously can't mirror. (Or if they have the same erasure it just complains.)\n\nIt seems reasonable to go with the broader type; implementing `Foo` requires it to accept null, whereas `Bar` doesn't care whether it does or not. But is this tantamount to supporting contravariant nullness in parameter overrides, which we've said in #49 we don't intend to do?","known_context_document_ids":["gh_issue_626812259"],"reference_answer":"**Revised Proposal**: As described in JSpecify Conformance: Questions and Answers, conformance tests will check that tools can recognize when a method's static return type is not a nullness subtype of that of the directly overridden method, or a parameter type is not a nullness supertype of that of its direct superparameter. JSpecify will impose no requirement on tools to report anything in particular to users in these cases.\n\nIs this enough to change your thumb's direction, @kevinb9n?","answer_document_id":"gh_comment_2166797011","silver_evidence_path":["gh_comment_1127190931","gh_issue_631188435","gh_comment_2166797011"],"evidence_issue_ids":[626812259,631188435],"source_repo_name":"jspecify/jspecify","source_issue_id":626812259,"source_issue_number":110,"source_issue_url":"https://github.com/jspecify/jspecify/issues/110","target_repo_name":"jspecify/jspecify","target_issue_id":631188435,"target_issue_number":111,"target_issue_url":"https://github.com/jspecify/jspecify/issues/111","reference_anchor_document_id":"gh_comment_1127190931","reference_answer_author":"netdpb","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3462,"anchor_target_overlap":0.3077,"target_answer_overlap":0.2857},"issue_created_at":"2020-05-28T21:02:34+08:00","valid_comment_count":37,"fragments":[{"document_id":"gh_issue_626812259","fragment_type":"issue_description","sequence":0,"text":"What is the nullness signature of a multiply-inherited abstract method?\n[EDIT: this whole comment is about case 1, where the method is abstract because all inherited methods are abstract.]\n\nFirst consider a discrepancy in return types:\n\n// in null-marked context\n\ninterface Foo { @Nullable String get(); }\ninterface Bar { /*non-nullable*/ String get(); }\ninterface Qux extends Foo, Bar {}\n\nIn this case, we can probably just follow Java's lead. With a quick experiment it seems that it won't just happily gin up an arbitrary intersection type, but if one of the types is more specific than the other (as should always be the case for us), it seems to go with that. (Or maybe I've gotten it wrong, but whatever it does, we can probably(?) stay consistent with.)\n\n// in null-marked context\n\ninterface Foo { void accept(@Nullable String x); }\ninterface Bar { void accept(/*non-nullable*/ String x); }\ninterface Qux extends Foo, Bar {}\n\nHere, Java is no guide, because any discrepancy in the types results in both overloads existing separately in `Qux` which we obviously can't mirror. (Or if they have the same erasure it just complains.)\n\nIt seems reasonable to go with the broader type; implementing `Foo` requires it to accept null, whereas `Bar` doesn't care whether it does or not. But is this tantamount to supporting contravariant nullness in parameter overrides, which we've said in #49 we don't intend to do?","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-05-28T21:02:34+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1127190931","fragment_type":"issue_comment","sequence":1,"text":"I do think this case is exactly #111, in different clothing.\n \n\nI think I agree? So to restate, then:\n\nTo find the signature of an abstract method inherited from multiple supertypes, use the intersection the supermethod return types, and the union of each set of corresponding parameter types.\n\nI think we can resolve this.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-05-16T04:04:14+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[631188435],"is_known_query_context":false},{"document_id":"gh_comment_1279468389","fragment_type":"issue_comment","sequence":2,"text":"Of course, we can't express union or intersection types. Where we said \"use the intersection of the supermethods' return types\", I think we meant the glb; likewise lub for parameter types, with both being restricted to what we can express.\n\nBut we're also limited by what javac will allow: we can't change the base type at all.\n\nI'm not sure we considered a case like this, where the nullness varies for a non-root type. What is the parameter type of `AB.foo`?\n\njava\n// null-marked code\ninterface SuperA { void foo(List bar); }\ninterface SuperB { void foo(List bar); }\ninterface AB implements SuperA, SuperB {}\n\nThe lub of these two types would be `List `, but we can't do that.\n\nIf we are analyzing AB itself, we can say: \"please override this method and choose which of the two signatures you want\". (Of course, whichever way they choose they'd still get a warning about the other one.)\n\nBut what about when AB is a dependency?\n\nOne option is: the answer is `List `, with the reasoning that type parameters are *more* likely covariant than contravariant, so we might as well behave as though `? extends` *were* there.\n\nSo, throughout all components of parameter types, *except* those that actually use `? super` (which we can handle normally), we would use the \"most nullable\" of the types. For return types, the least nullable.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-10-14T21:08:17+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1279845017","fragment_type":"issue_comment","sequence":3,"text":"Just to state that more directly: for this purpose only, treat wildcardless type arguments as if `? extends` is there. Would that resolve every case?\n\n@cpovirk floated an intriguing alternative: the inherited method gets the parameter type `List `. This seems to make a lot of sense to me: in order to specify it, we needed them to provide an explicit override, and they didn't, so it's unspecified.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-10-15T22:40:14+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1281586496","fragment_type":"issue_comment","sequence":4,"text":"TODO: check into what javac does with base types; write test-case-like code","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-10-17T22:43:14+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283169720","fragment_type":"issue_comment","sequence":5,"text":"I'm not sure what I meant to learn from javac. If there's any variation in parameter types at all, it just gives an error -- we knew that! I guess what it does with return types is a bit illustrative:\n\njava\nimport java.util.*;\n\nclass Issue110 {\n interface A { List foo(); }\n interface B { List foo(); }\n interface C extends A, B {}\n\n static {\n C c = null;\n List list = c.foo();\n }\n}\n\nThis does compile. In other words, it's happy to go ahead and pick the more specific type. But this is just further argument justifying the *original* decision here from way back when. If I take out all the `? extends` it refuses to compile `C` at all. Again though, we knew this.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-10-19T00:21:07+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1286171257","fragment_type":"issue_comment","sequence":6,"text":"As mentioned I will write out test cases, but they'll be... long. We'd normally not wait to mark this issue resolved until we do that, unless anyone feels that we don't even understand what we're deciding yet without writing all that out.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-10-20T21:24:42+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2075612823","fragment_type":"issue_comment","sequence":7,"text":"I had forgotten about this one! :)\n\nIt is a _little_ weird that someone might write...\n\njava\ninterface Foo { @Nullable String passThrough(@Nullable String s); }\ninterface Bar { String passThrough(String s); }\ninterface Qux extends Foo, Bar {}\n\n...and end up as if `Qux` had a signature like `String passThrough(@Nullable String s)`, which is presumably unsound.\n\nIn #67, I'd cited URL which appears to match kevinb9n's results. It's similar to our rule in that it picks the most specific return type.\n\nBut we go further by trying to perform a full on glb/lub of multiple types. For example, the JLS wouldn't \"merge\" `Iterable ` and `List ` into `List `, but we're effectively trying to do that. But we can make that happen because we know that the base types match—well, _mostly_.\n\nArguably a more JLS-like approach would be pick one of the _n_ signatures. Maybe it would make sense to pick the one with the more specific return type (since that's the part that the JLS allows to vary). Granted, even \"more specific return type\" isn't a well-defined concept: If we inherit both `@Nullable List ` and `List `, then neither is strictly more specific than the other. So we're back to glb/lub and possibly even unspecified nullness.\n\n(Maybe ideally a checker that analyzes _that class_ would produce an error to get the programmer to resolve the conflict. But programmers can avoid any such error by suppressing or at least by not running a checker in the first place. So there's no getting around defining behavior for a checker that analyzes _usages_ of such a method.)","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2024-04-24T18:50:54+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2075615951","fragment_type":"issue_comment","sequence":8,"text":"(I'm here because @kevinb9n just pointed out to me in chat that there's a related but separable issue: If `Qux` _declares_ some `passThrough(String)` method, then checkers should probably check it against _both_ of the supertypes' methods _separately_. The question of _this_ issue is what happens when there is no such declaration in `Qux`.)","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2024-04-24T18:52:55+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2075715299","fragment_type":"issue_comment","sequence":9,"text":"Hmm, URL has me thinking more about unspecified nullness.\n\nI've read the description there, and I'm not sure if it adds behavior beyond what glb/lub already does. I may be misunderstanding, though.\n\nOne possible goal could be to prefer to _ignore_ unspecified when we have \"better\" information:\n\njava\n@NullMarked\ninterface Foo {\n void use(String s);\n}\n\n@NullUnmarked\ninterface Bar {\n void use(String s);\n}\n\ninterface Qux extends Foo, Bar {}\n\nThere, the unspec rule from above and the glb/lub rule give us `void use(String*)`, I think? But we could instead say that the type is `void use(String!)`, since we have an affirmatively non-nullable type from `Foo`. Of course, someone could in the future annotate `Bar` with `@Nullable String`, in which case the type would become `String*` again because of the conflict. But maybe that's overall a better user experience, since the type probably is meant to be `String!`.\n\nThis spec-unspec mix may well be the most common kind of \"conflict\" that we'd see in practice, so we might want to err on the side of doing the \"right\" thing for it.","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2024-04-24T19:45:01+08:00","repo_name":"jspecify/jspecify","issue_id":626812259,"issue_number":110,"issue_url":"https://github.com/jspecify/jspecify/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_631188435","fragment_type":"issue_description","sequence":0,"text":"What to do when overriding method's annotations indicate weaker contract than overridden method [working decision: finding of distinct category]\nWe seem to lean toward allowing covariant return types and contravariant parameter types (in the nullness dimension). These are ordinary contractual refinements [EDIT: strengthenings]\n\nI want to discuss *backward* refinements [EDIT: contractual weakenings]: covariant parameters and contravariant returns. Surprisingly, I'm going to claim these are also valid.\n\nScenario A: `Foo.bar()` has a non-nullable return type. `SubFoo.bar()` _should_ not return null in any case, but for whatever reason, its author has decided to do so and no one will change their mind. (This situation could also arise from `Foo` changing after the fact.)\n\nFrom jspecify's point of view, I think that `@Nullable` is the only correct way to annotate the return type of `SubFoo.bar()`, and the user should absolutely do so. That way, at least consumers who _happen_ to have the static type `SubFoo` will behave correctly, and that is better than nothing.\n\nFrom the \"what our annotations mean as specification\" perspective, there is nothing wrong here. It's just that from the \"preventing bugs\" perspective, any reasonable checker is going to want to issue a warning on `SubFoo.bar()`, explaining that it risks causing an NPE for anyone using `SubFoo` _via_ its `Foo` supertype, and strongly recommending against doing this. It should also suggest considering modifying `Foo` itself, but we have to realize that such decisions tend to be made more on annoyance equilibrium than on correctness.\n\n(I would hope that if the user just changed the `SubFoo.bar()` return type but left the code alone, they would get louder/worse errors for that, as that's the worst case.)\n\nScenario B: a covariant parameter type. Foo promises to accept null, SubFoo doesn't want to. Perhaps this case is slightly different: SubFoo has the option of just still declaring `@Nullable`, since it's allowed to throw NPE or any other exception for any reason it wants to. However, it still _shouldn't_, because it's withholding useful information from the callers who happen to have the `SubFoo` static type. So I think it works out similarly the Scenario A anyway.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-04T22:33:37+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_639186904","fragment_type":"issue_comment","sequence":1,"text":"Let's please use standard terminology \"weakening\" and \"strengthening\" rather than making up new terms like \"contractual requirement\" and \"backward refinement\".\n\nWhen a subtype specification is weaker than a supertype specification, then the specification is ill-formed. This is one of the few situations where every tool should issue a warning, analogously to writing `@Nullable @NonNull`.","author_login":"mernst","author_association":"COLLABORATOR","created_at":"2020-06-05T00:21:12+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_639204489","fragment_type":"issue_comment","sequence":2,"text":"Thanks Mike; that works as an *assertion* of your position, but I've explained *why* I believe it is not ill-formed, so which part of my argument are you disagreeing with?\n\nI don't think the comparison to `@Nullable @NonNull` holds much water; that is a single type at war with itself, literally answering a single question \"yes no\". Simple \"well-formedness\" should, I think, be a very low bar, which that still manages not to clear.\n\nI don't see how this case is similar. It is a \"bad move\" to weaken a supertype contract, but it happens. Given our premise (that the user will not be talked out of their decision to sometimes return null), then the best outcome is for them to annotate their return type nullable. It can be both the best thing for them to do and ill-formed at the same time.\n\nI don't see a need to dictate that tools should warn; I would simply be _surprised_ if they didn't. If I was tempted to dictate anything, it would be \"make sure the warning is somehow less severe than if they declare a non-nullable return type but still return null anyway\", because I think that's the worst outcome.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-05T01:28:17+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_641334323","fragment_type":"issue_comment","sequence":3,"text":"This is going to be a contentious discussion in the best of times. And based on my own experience and what I've heard offline from others, I think that some of us bystanders have been confused about _what_ we're discussing here. So I'm going to take a stab at clarifying that.\n\nFor starters, we're talking about methods like `Collection.contains(Object)`. But I'll use a slightly different example, `Map.containsKey(Object)` (courtesy @PeteGillin). It makes a good example because at least one well-known overriding method, `ConcurrentHashMap.containsKey(Object)`, throws `NullPointerException` if called with a null value.\n\nHere are some things that I think we all agree on:\n\n1. Some users might like to pass a nullable parameter to the `containsKey` method of an object whose static type is `Map`. Those users might or might not want tools to issue warnings or errors when they do, and we might have our own disagreements about that. My only claim is that some users will ultimately want to have that call in their source code (perhaps with `@SuppressWarnings` applied to it). I contrast this case with...\n2. Users definitely never want to pass `null` to the `containsKey` method of an object whose static type is `ConcurrentHashMap`.\n3. Given (2), the parameter type for `ConcurrentHashMap.containsKey` that we'd recommend is `@NonNull Object`.\n4. Suppose that someone declares `ConcurrentHashMap.containsKey(@NonNull Object)`, as in (3). Now additionally suppose that that person declares **`Map`**`.containsKey` to have a parameter of **`@Nullable`**` Object`. In that case, when tools compile the annotated `ConcurrentHashMap` class, we would recommend issuing some kind of error/warning. This would inform the developer about the mismatch between the parent and child classes' signatures for the method.\n5. We also agree on the behavior we'd expect from tools when analyzing both _callers_ and _implementations_ of `containsKey`:\n - Callers of `containsKey(@NonNull Object)` are likely to see warnings/errors if they pass a nullable parameter. (And, if the parameter type is `@Nullable Object` instead, they aren't likely to see warnings/errors.)\n - Implementations of `containsKey(@Nullable Object)` are likely to see warnings/errors if they dereference the parameter without a null check. (And, if the parameter type is `@NonNull Object` instead, they aren't likely to see warnings/errors.)\n\nTo summarize all that: However developers annotate these methods, I think we all agree on how tools are likely to respond. (Aside: There is still disagreement about what exactly our spec/docs should _say_ to encourage such behavior without requiring it. But I think that disagreement is mostly unrelated to this current specific issue.)\n\nThe disagreement, then, is: How _should_ developers annotate the parameter of `Map.containsKey` -- `@Nullable` or `@NonNull`? Compared to the various things we agree on, this disagreement is either less fundamental or _more_ fundamental:\n\nThe argument that it's less fundamental: All we're debating is how we recommend that our users apply annotations. At most, we're debating how we'll apply annotations to `containsKey` specifically when we provide an annotated JDK. This is important, but it's mostly a discussion about what we suggest to users, not what we do in our specification and tools.\n\nThe argument that it's more fundamental: What we're really discussing here is the meaning of `@Nullable` (as previously discussed in various places). If we can't tell users when to use our most basic annotation, then how can we feel comfortable telling users _anything_?\n\nI have Opinions on this, but for now, I want to stop and see if this clarified anything for anyone.","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2020-06-09T14:28:38+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_641527840","fragment_type":"issue_comment","sequence":4,"text":"(To be clear, we're using `Map` and `CHM` as *examples* here, so don't be distracted by issues that come from their JDKness.)\n\nYour background looks spot on. But I think the question being asked *first* is not what `Map` should do, but rather, *assuming* that `Map` declares the parameter to be nullable, then what should `ConcurrentHashMap` do? And what will motivate it to do that?\n\nI think that non-nullable is the *right* way for it to go, because it is truthful. The specification will appear to violate substitutability because the implementation DOES violate substitutability. Also because for the users who happen to have the specific static type they will get proper behavior. (Of course, an implementer of such a method may mistakenly think they have some kind of assurance that the value can never be null, but that is already wrong anyway, since the caller might not be null-checked code.)\n\nSo I'm advocating that we view this as a well-formed expression of contract... which happens to be _bad contract_. The problem report that a user gets should explain the dangers, but the hope is that if the user tried to paper over the problem by just changing the annotation, they should get much scarier sounding errors then.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-09T19:37:43+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_641529623","fragment_type":"issue_comment","sequence":5,"text":"Then, the question you appear to be asking is, should `Map` have done this at all, if it knows there is even one implementation like this that won't adhere to the contract?\n\nAnd I think the answer can't be an absolute no (which doesn't erase the problem just discussed anyway). And in real life API owners will probably go whichever route seems to cause the least aggregate aggravation.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-09T19:41:16+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_641571816","fragment_type":"issue_comment","sequence":6,"text":"I agree that we could further discuss what `CHM` should do if it has to cope with `Map.containsKey(@Nullable)`. My belief, though, is that everyone already agrees on what it should do in that case. Specifically, our position seems to be that `CHM` should define `containsKey(@NonNull)`.\n\nI do think it's logically defensible to take a different position than that, and I invite anyone to do so. If not, that's fine, too: Easy issues are the best issues :) I just want to make sure that:\n1. We don't spend a lot of time violently agreeing with one another.\n2. We understand where the disagreements that do exist lie.\n\nI have been particularly concerned about (2). On that note: Bystanders, please do speak up if you disagree with anything that I've claimed \"everyone\" agrees with. I'm not trying to cut off any lines of discussion, only identify the discussions that someone wants to have.","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2020-06-09T21:04:19+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644393557","fragment_type":"issue_comment","sequence":7,"text":"I feel like we're descending into details that are making this question seem complex and specific, but I want to try to establish something more simple and general:\n\nI propose that it's valuable for us to separate the idea of \"invalid application of jspecify annotations\" from the idea of \"valid application of jspecify annotations, which correctly enables tools to see there's some problem in the code\".\n\nThe impact to the end user might seem slight -- they'd probably see a warning either way, and it might just be worded a little differently -- but I think *we* in this group need to differentiate carefully or it will get too hard to have these discussions.\n\nAn example of something that is definitely an invalid usage of jspecify would be annotating a type `@Nullable @NonNull`. There can be no possible reason to allow that. That is ill-formed on its face.\n\nI believe a parameter having some different nullness from its superparameter can never be put in that \"ill-formed\" bucket, because there is already code out there that is doing this. That code should be annotated truthfully. When it is, those annotations may reveal a deeper problem to tools or they may not. Was a parameter made *less* nullable than its superparameter -- a weaker contract? I expect roughly all tools would want to complain about this; the question we could consider is whether there is value in jspecify \"mandating\" anything about how they should react. I'm not sure whether there's a need for it.\n\nWhat if the contract is made stronger (parameter *more* nullable than superparameter)? If we could agree on the above, then the nature of issues like #49 changes a little. It's not about \"should we support parameter contravariance?\" because that just *is* supported by default. And I would be surprised if any tools cared enough to complain about it (unless it is a specific kotlin incompatibility that motivates them to do so). Seems like they are free to do what they want.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-15T21:13:41+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644396476","fragment_type":"issue_comment","sequence":8,"text":"To help make the distinction, maybe we can find words other than \"ill-formed\" and \"valid.\"\n\nPerhaps what you're proposing is that `@Nullable @NonNull String` _does not express a type_? In contrast, the case here with overrides definitely expresses types, just ones that, taken together, might be questionable in some way.\n\nWould \"does not express a type\" cover all the cases you're putting in your \"invalid application of jspecify annotations\" bucket?","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2020-06-15T21:20:06+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644402579","fragment_type":"issue_comment","sequence":9,"text":"That feels like an attempt to nail down exactly where the boundaries lie. That might be too hard to do all at once. I think it's enough if we can agree that the boundary should exist. And in trying to decide which side of that line this particular scenario falls on, some principles may start to emerge. For instance, I've suggested \"if there can already exist code for which a certain application of annotations is the most truthful expression possible, then we should never consider that ill-formed\".","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-15T21:34:23+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644413085","fragment_type":"issue_comment","sequence":10,"text":"I've taken a stab at an issue title that asks _whether_ there is a hierarchy of 2 levels of badness, since that seems to be the root issue. Alternatively, if you'd like to keep this issue specifically about which level we put contractual weakening into, we could open a separate issue for the \"2 levels\" question and then try to resolve that one first.","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2020-06-15T22:01:46+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644450270","fragment_type":"issue_comment","sequence":11,"text":"I'm not sure this is really a question of degree.\n\nThe goal of our annotations is to capture small pieces of information from the developer. `@Nullable @NonNull` fails to do this (even if we defined a precedence, it would still fail to be a proper and useful way to express whatever information we defined it to express). No matter how low we define the standard for well-formedness it still shouldn't meet it, because it is like answering a question \"yes no\". I hope this part is not controversial.\n\nIt's hard to debate and settle a question of \"is there another kind of badness\" per se. What we can do is talk about examples of other problematic scenarios and decide which bucket they fall into. If one by one they all fall into the same total-nonsense bucket then we would eventually say we only needed one category. So far we've discussed one example, and I've explained why it doesn't fit in the same bucket: we would be rendering some existing code impossible to annotate.\n\nDo you want to go through other examples too, or....?","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-06-15T23:55:41+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_644851203","fragment_type":"issue_comment","sequence":12,"text":"I'm now confused about the buckets. Maybe I'm envisioning that _every_ case that a checker might warn/error about goes into 1 of 2 buckets, while you're talking about only a subset of cases?\n\nThe 2 buckets I'm picturing are:\n\n**Bucket 1: \"the `@NonNull @Nullable Object` case\":**\n\nPossibly `@NonNull @Nullable` is the _only_ thing I see in this bucket currently. I could also imagine including cases like `@Nullable int`, which falls under the umbrella of \"structurally illegal\" (though that umbrella covers many of things): You were expected to provide either 0 or 1 annotation (or, in the case of `@Nullable int`, you were expected to provide 0), but you provided more.\n\nMaybe the key idea here is that this one single type declaration is wrong in isolation: Even if we know nothing else about any type in the program, we can identify the problem.\n\n**Bucket 2: \"type mismatches\":**\n\nThis is my \"everything else\" bucket:\n\n- returning `null` from an implementation of `toString()`\n- declaring `ImmutableList `\n- overriding a method that returns `List ` to return `List `\n- etc.\n\nThis bucket contains cases in which we applied some type check / conversion / predicate to 2 types, and it failed.\n\n---\n\nI sometimes have gotten the impression that you're picturing a third bucket. It sounds like it might take some things out of my second bucket on the grounds that \"we would be rendering some existing code impossible to annotate.\" I am also confused about the \"impossible to annotation\" question, but maybe we can get to the bottom of the buckets first?","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2020-06-16T15:51:32+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_681041397","fragment_type":"issue_comment","sequence":13,"text":"I feel hopeful that this conversation can get simpler than it has been, somehow. :-)\n\nWe don't have to come up with the whole unified theory of buckets right here. Let's just focus on what is well-formed and what isn't. And our guiding star on that, I suggest, is:\n\n\"The purpose of our annotations is to capture valid information from the developer (in a reasonable way).\"\n\n`@Nullable @NonNull` clearly fails to do this, and `@Nullable @Nullable` is a clearly bad way to do it. These should be considered not well-formed.\n\nI'd like to get this issue back to being just what it started out as, a discussion of whether subtypes can weaken a supertype contract. I argue that this succeeds in capturing valid information from the developer. That valid information allows tools to detect and report a problem, which may be a deeper design issue in the software.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2020-08-26T18:13:14+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_862976659","fragment_type":"issue_comment","sequence":14,"text":"I'll acknowledge that the observable consequence of our decision here _might_ not even be massive. Maybe it's just \"six of one\". But, if we can't get on the same page conceptually, that seems like ill portent to me. Cmon, we can do this. :-)\n\nMy claim is:\n\n1. Code exists, where SuperFoo.bar(Object) promises to accept null but SubFoo.bar(Object) throws on it.\n2. This code is problematic because it violates substitutability.\n3. Nevertheless, the most correct and useful application of JSpecify annotations to this code is that SuperFoo's parameter is @Nullable and SubFoo's is not.\n4. That is accurate, and also provides information that tools can use to report a problem: \"'SubFoo.bar(Object)' parameter #1 should be of type '@Nullable Object', because calls to overridden method 'SuperFoo.bar(Object)' will be permitted to pass 'null'.\"\n\nI believe the point I am making is simple, and I don't see it being _refuted_ either; however it seems as though each response above keeps branching the conversation hither and thither. (Truth be told, I just wanted to get to say \"hither and thither\".) Can you help me understand what's going on here? :-) Thanks","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2021-06-17T06:48:04+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_864154592","fragment_type":"issue_comment","sequence":15,"text":"I'm going to be thinking about this more today, but as a quick response:\n\nThe part of that that sits poorly with me is the phrasing \"promises to accept null\": Yes, we have a method whose parameter type includes null\\[*\\], but I'm nervous about describing that as a \"promise\": The method might do _anything_ when given null, including \"throw NullPointerException,\" just as it might do _anything_ when given `1` or `\"foo\"` or `Color.RED`. Now, the method should _have some defined behavior_ for those inputs. (Or, alternatively, it could explicitly call the behavior unspecified.) But I see that part of the contract as something to explain in Javadoc.\n\nFrom this point of view, a definitively _non_-null parameter is a way of saying that the behavior of the method on null inputs is undefined. (Analogy: If a method accepts an `Iterable `, its Javadoc doesn't need to talk about what happens if you manage to cram an `Iterable ` into it.) But if the parameter type can include null, then that isn't a \"promise\" of anything more than (ideally) to _explain_ what the behavior for that input is.\n\n\\[*\\]: Again, I think that there may be actual controversy over whether the parameter type _does_ include null. I am with you that it does. But I have forgotten the state of the wider conversation on this, so I say that there may be controversy because that's _not_ how the Checker Framework annotates its JDK.","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2021-06-18T16:33:28+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_864171989","fragment_type":"issue_comment","sequence":16,"text":"Correct that \"promises to accept\" is wrong. I reached for that word only to express that when we're annotating an overridable method, we aren't just making a choice for the method's own body, we're making contract that constrains overriders.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2021-06-18T17:09:20+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_864253280","fragment_type":"issue_comment","sequence":17,"text":"Still trying to understand what position I'm arguing against (i.e., where a 'no' to my proposal means we end up). My confused guess at it is \"there's no meaningful difference between 'wrong usage of JSpecify' and 'correct usage that highlights a problem', or we just don't need to care, or trying to care would get us into more trouble than it's worth\". Is that even it?","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2021-06-18T20:15:17+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_864260120","fragment_type":"issue_comment","sequence":18,"text":"[NOTE: my pushing on this is not proportional to its importance to the project. No urgency per se. It is just that *I* don't feel like my mental model is on solid foundations while it's unresolved.]\n\nThe following is NOT an actual argument. I'm just disclosing something that I \"hope\" will end up being the case in most tools. I don't have a guess how relevant it is here.\n\nSuppose we're retrofitting legacy code, and the below is now in null-marked scope:\n\ninterface SuperFoo { void bar(@Nullable Object o); }\n\nclass SubFoo implements SuperFoo {\n @Override void bar(/*1*/Object o) { ... }\n}\n\nWe assume most/all tools want to report a problem at 1. Suppose the user thinks \"It's saying this is wrong, and I have to add `@Nullable` to fix it\", then when they still get a problem reported in the body, they reason \"I'm trying not to change things, just annotate, so I'll suppress this for now.\"\n\nResult: now *no* problem reported at 2 here:\n\nanyClient(SubFoo subfoo) {\n subfoo.bar(/*2*/somethingNullable);\n}\n\nAnd that had represented a real bug, whereas the problem at 1 was \"you are doing something super bogus that *risks* real bugs\".\n\nI've hoped that the spec will lead tool vendors to recognize these as two quite different cases (if we must say \"levels of badness\", okay :-)). Because then it's even *possible* that they will surface them in correspondingly different ways (maybe 1 as warning, 2 as error, or whatever).","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2021-06-18T20:32:37+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_867774005","fragment_type":"issue_comment","sequence":19,"text":"I'd expect tools very well may report /*2*/, since a nullable argument is\npassed to a method declared to expect a non-null parameter. Seemingly it\nwould be more work not to report something here, and reporting seems better\nthan not reporting in this case, but ultimately it's a tool decision what\nto report in implementation code.","author_login":"kevin1e100","author_association":"COLLABORATOR","created_at":"2021-06-24T16:19:25+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_867833090","fragment_type":"issue_comment","sequence":20,"text":"My scenario is that the parameter _had_ been non-null once, but it was changed to nullable in a half-hearted attempt to \"make the tools happy\".\n\nNote, the scenario is also contrived, and not posed as an argument that \"some terrible thing will happen 100,000 times per day to users!\". Only illustrating why the conceptual treatment in URL \"sits right\" with me.\n \n\nThis is what I believed I was addressing when I said:\n \n\nWe may have to say this over and over, \"we are not dictating what tools must do. but our choices have consequences on what they will want to do, and that matters.\"","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2021-06-24T17:48:17+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[631188435],"is_known_query_context":false},{"document_id":"gh_comment_1162383664","fragment_type":"issue_comment","sequence":21,"text":"At this point I feel pretty satisfied just having this be a distinct category of finding, \"override conflict\" -- distinct from \"irrelevant annotation\" and from \"types not assignable\". Does that make this issue resolved?","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2022-06-21T21:24:53+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1163169275","fragment_type":"issue_comment","sequence":22,"text":"Having another category of finding sounds eminently inoffensive :)\n\nI imagine that we'll have more to discuss around:\n\n- any user-facing docs about this\n- the more general question of whether the _spec_ makes these sorts of distinctions\n\nBut it sounds like the high-order bit is the \"just\" in your proposal: We get most of what we want by calling this \"another category\" without additionally trying to take positions on whether a particular way of annotating is \"correct,\" what tools should do, etc.?","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2022-06-22T14:23:33+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2045968820","fragment_type":"issue_comment","sequence":23,"text":"**Current decision**: JSpecify-compliant tools must be able to recognize when a method that returns a nullable type overrides a method that returns a non-null type (contravariant return) or one that accepts a non-null parameter overrides one that accepts a nullable parameter (contravariant parameters). Tools are free to report those to users at whatever severity they wish, suppressibly or not. When a compliant tool analyzes calls to such methods, the nullability of the method associated with the static type of the receiver should be applied. This approach preserves the ability of compliant tools to be strict or lenient.\n\n**Argument for changing**: Such overriding methods are incorrect, and like Java, JSpecify should consider them invalid and require tools to report them as such.\n\nHowever, the current decision preserves the ability of tools to report such overriding methods as strictly incorrect, but it does not prevent tools from interpreting such methods in any case.\n\n**Timing**: This must be decided before version 1.0 of the spec.\n\n**Proposal for 1.0: Finalize the current decision.** If you agree, please add a thumbs-up emoji (👍) to this comment. If you disagree, please add a thumbs-down emoji (👎) to this comment and briefly explain your disagreement. Please only add a thumbs-down if you feel you can make a strong case why this decision will be materially worse for users or tool providers than an alternative.","author_login":"netdpb","author_association":"COLLABORATOR","created_at":"2024-04-09T20:08:26+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2099290885","fragment_type":"issue_comment","sequence":24,"text":"I've made that edit, with some small changes.\n\n1. I removed the reference to a distinct category, since we haven't formalized anything about that.\n2. I moved the point about _direct_ supermethods into the main paragraph, and made the second paragraph only about analyzing calls to such methods.","author_login":"netdpb","author_association":"COLLABORATOR","created_at":"2024-05-07T20:52:38+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2099726598","fragment_type":"issue_comment","sequence":25,"text":"The \"distinct category\" has been the whole point, so I'm a firm thumbs-down for now.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2024-05-08T04:39:41+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100974015","fragment_type":"issue_comment","sequence":26,"text":"I have taken \"category\" to be a well-defined concept _in the conformance tests_ (not that we have a system fully fleshed out, but I think we understand what a different category _means_ there), but there is some ambiguity as to whether we're also talking about things like `@SuppressWarnings` strings. (Presumably we can all agree that we're _not_ saying that a tool has to decide either (a) to report to users every finding of a particular \"category\" or (b) to not report to users every finding of a particular \"category.\")","author_login":"cpovirk","author_association":"COLLABORATOR","created_at":"2024-05-08T16:38:22+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2166797011","fragment_type":"issue_comment","sequence":27,"text":"**Revised Proposal**: As described in JSpecify Conformance: Questions and Answers, conformance tests will check that tools can recognize when a method's static return type is not a nullness subtype of that of the directly overridden method, or a parameter type is not a nullness supertype of that of its direct superparameter. JSpecify will impose no requirement on tools to report anything in particular to users in these cases.\n\nIs this enough to change your thumb's direction, @kevinb9n?","author_login":"netdpb","author_association":"COLLABORATOR","created_at":"2024-06-13T21:07:01+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168453804","fragment_type":"issue_comment","sequence":28,"text":"Yes, wonderful! We can refine the category descriptions separately.","author_login":"kevinb9n","author_association":"COLLABORATOR","created_at":"2024-06-14T17:17:48+08:00","repo_name":"jspecify/jspecify","issue_id":631188435,"issue_number":111,"issue_url":"https://github.com/jspecify/jspecify/issues/111","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0179","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Request] Compile version for 32bit - armv7l?","query_context":"Tool Manager: Installing earlephilhower/toolchain-rp2040-earlephilhower @ 5.100300.220714\nINFO Installing earlephilhower/toolchain-rp2040-earlephilhower @ 5.100300.220714\nError: Could not find the package with 'earlephilhower/toolchain-rp2040-earlephilhower @ 5.100300.220714' requirements for your system 'linux_armv7l'\n\nSome users will be wanting to compile pico projects from their raspberry pis, some of which are 32bit only. And even on 64bit devices 32bit Raspbian is the default install by the r-pi foundation - URL \n\nAs such it would be great to have a 32bit version of the toolchain.\n\nRelated issue: URL","known_context_document_ids":["gh_issue_1472674034"],"reference_answer":"It probably would work fine with pico-arduino but isn't something I can guarantee or test. You'd need to make adjustments to the platform.txt to use the system `arm-eabi-gcc` instead of the packaged one.","answer_document_id":"gh_comment_1112596619","silver_evidence_path":["gh_comment_1363090006","gh_issue_1196574962","gh_comment_1112596619"],"evidence_issue_ids":[1472674034,1196574962],"source_repo_name":"earlephilhower/pico-quick-toolchain","source_issue_id":1472674034,"source_issue_number":22,"source_issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","target_repo_name":"earlephilhower/pico-quick-toolchain","target_issue_id":1196574962,"target_issue_number":8,"target_issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","reference_anchor_document_id":"gh_comment_1363090006","reference_answer_author":"earlephilhower","reference_answer_author_association":"OWNER","quality_score":86.54,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0645,"anchor_target_overlap":0.0323,"target_answer_overlap":0.0625},"issue_created_at":"2022-12-02T10:51:59+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_1472674034","fragment_type":"issue_description","sequence":0,"text":"[Request] Compile version for 32bit - armv7l\nTool Manager: Installing earlephilhower/toolchain-rp2040-earlephilhower @ 5.100300.220714\nINFO Installing earlephilhower/toolchain-rp2040-earlephilhower @ 5.100300.220714\nError: Could not find the package with 'earlephilhower/toolchain-rp2040-earlephilhower @ 5.100300.220714' requirements for your system 'linux_armv7l'\n\nSome users will be wanting to compile pico projects from their raspberry pis, some of which are 32bit only. And even on 64bit devices 32bit Raspbian is the default install by the r-pi foundation - URL \n\nAs such it would be great to have a 32bit version of the toolchain.\n\nRelated issue: URL","author_login":"HarvsG","author_association":"NONE","created_at":"2022-12-02T10:51:59+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1335382772","fragment_type":"issue_comment","sequence":1,"text":"Can you run `gcc -dumpmachine; gcc -v` on your system and paste the output? It should be trivial to add, but I need to know the tuple...","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-12-02T15:04:48+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335422702","fragment_type":"issue_comment","sequence":2,"text":"pi@greenpi:~ $ gcc -dumpmachine; gcc -v\narm-linux-gnueabihf\nUsing built-in specs.\nCOLLECT_GCC=gcc\nCOLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabihf/8/lto-wrapper\nTarget: arm-linux-gnueabihf\nConfigured with: ../src/configure -v --with-pkgversion='Raspbian 8.3.0-6+rpi1' --with-bugurl=file:///usr/share/doc/gcc-8/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-8 --program-prefix=arm-linux-gnueabihf- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libitm --disable-libquadmath --disable-libquadmath-support --enable-plugin --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-sjlj-exceptions --with-arch=armv6 --with-fpu=vfp --with-float=hard --disable-werror --enable-checking=release --build=arm-linux-gnueabihf --host=arm-linux-gnueabihf --target=arm-linux-gnueabihf\nThread model: posix\ngcc version 8.3.0 (Raspbian 8.3.0-6+rpi1)","author_login":"HarvsG","author_association":"NONE","created_at":"2022-12-02T15:29:12+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335505719","fragment_type":"issue_comment","sequence":3,"text":"This is already there in the Makefile, and the existing binary will work (but P.Io won't install until I re-upload the entire chain.)\n\nSee URL \n\nIt'll be in the next toolchain build, no actual compilation changes/etc. required...","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-12-02T16:29:43+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1335556535","fragment_type":"issue_comment","sequence":4,"text":"Great that is good news. When is the next build likely to be?","author_login":"HarvsG","author_association":"NONE","created_at":"2022-12-02T17:16:09+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1362697533","fragment_type":"issue_comment","sequence":5,"text":"@earlephilhower sorry to ping you directly, are the packages already uploaded and are just waiting for manual review by the PIO team, or has the push not happened","author_login":"maxgerhardt","author_association":"NONE","created_at":"2022-12-22T10:58:15+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363090006","fragment_type":"issue_comment","sequence":6,"text":"Running the Arduino toolchain on a RPi 32bit (I assume only RPi3) must really be a test of patience, ouch.\n\n@maxgerhardt it's not been rebuilt yet. Since it's a big D/L for folks I wanted to also get URL and maybe URL in as far as changes before the update.\n\nWorst case I'll do a build by year's end...","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-12-22T16:48:40+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1472674034,"issue_number":22,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/22","linked_issue_ids":[1196574962],"is_known_query_context":false},{"document_id":"gh_issue_1196574962","fragment_type":"issue_description","sequence":0,"text":"ARM64 macOS builds\nAt the moment it looks like there are no ARM64 (Apple Silicon) builds available from the release page. It would be nice to have these available so I don't need to build them myself.","author_login":"tjhorner","author_association":"NONE","created_at":"2022-04-07T21:12:22+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092234051","fragment_type":"issue_comment","sequence":1,"text":"There's an aarch64 build for 64-bit ARM. I don't know if MacOS supports a Linux compat layer, though, to use it. I'm also pretty sure the Arduino IDE doesn't know what to do w/64b Mac on ARM, either (i.e. even for Win64 is still installs the 32b binaries!).\n\nI do everything via a cross build process and haven't had a Mac since 1996, so if this is important I'll need some assistabnce.\n\nIf you look at URL and can add in something that will let Linux x64 build Mac64ARM bits, I'd be happy to include it in the standard release process.","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-04-07T21:43:15+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092257912","fragment_type":"issue_comment","sequence":2,"text":"macOS does not support ELF binaries, unfortunately, so those builds won't work.\n \n\nSure, I can take a look.\n\nFWIW, I am using PlatformIO and followed the instructions, but it just hung there for a while not doing anything, so I thought something went wrong due to platform architecture. It turns out I was just impatient, and everything took a while to clone and install.\n\nThe existing x86_64 builds do work on ARM64 (probably using Rosetta to translate it), so in the meantime that will work. But would be nice to have native builds Eventually™️","author_login":"tjhorner","author_association":"NONE","created_at":"2022-04-07T22:09:45+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112442212","fragment_type":"issue_comment","sequence":3,"text":"Hello am looking to build for the pico on Mac. There is support for arm-eabi-gcc on macOS with a package from Homebrew . but it only supports gcc 11. Would GCC 11.3 support be possible? Thanks in advance.","author_login":"louisadamian","author_association":"NONE","created_at":"2022-04-28T16:56:17+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112596619","fragment_type":"issue_comment","sequence":4,"text":"It probably would work fine with pico-arduino but isn't something I can guarantee or test. You'd need to make adjustments to the platform.txt to use the system `arm-eabi-gcc` instead of the packaged one.","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-04-28T19:51:34+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1154076395","fragment_type":"issue_comment","sequence":5,"text":"Thanks, @LeSuedois. Unfortunately, I don't think it's an M1 owner I need assistance from here. The issue is that I cross-compile everything, from Raspberry Pi to Win32 to Mac x64 to AARCH64, all in a Docker container on a Linux system. So what needs to be done is figure out how to cross-compile for the M1/MacOS, not actually run builds on one.\n\nIt's been a while since I built the container, but IIRC it depends on a manually cross-built XCode. If Apple is still doing XCode, then it's probably a matter of doing the same to the latest bundle.","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-06-13T15:36:33+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1159014885","fragment_type":"issue_comment","sequence":6,"text":"In the meantime we should try to get Mac x64 version running on M1. Right now it just blows up with \n`Could not find the package with 'earlephilhower/toolchain-rp2040-earlephilhower @ ~5.100300.0' requirements for your system 'darwin_arm64'`\nRosetta emulation works pretty well for most apps. Is there a flag or a way to force PlatformIO to just use the X64 version of the toolchain package?","author_login":"zjwhitehead","author_association":"NONE","created_at":"2022-06-17T15:55:14+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1159018169","fragment_type":"issue_comment","sequence":7,"text":"Yup, that'd be the problem right there...it is looking for `darwin_**arm64**` and not falling back to `darwin`. What app are you running?","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-06-17T15:59:15+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1159479464","fragment_type":"issue_comment","sequence":8,"text":"I'm running PlatformIO with the latest config that looks like \n\n[env:OpenPPG-CRP2040-SP140]\nplatform = URL \nboard = sparkfun_promicrorp2040\nframework = arduino\nboard_build.core = earlephilhower\n\nboard_build.filesystem_size = 14M ; 14 Mbyte for filesystem and 2 Mbyte for program\n\nI see on the PIO registry that as expected its not showing a version for Mac Arm64\n URL","author_login":"zjwhitehead","author_association":"NONE","created_at":"2022-06-18T15:01:50+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1159533854","fragment_type":"issue_comment","sequence":9,"text":"Ah, I see. Arduino doesn't know what `darwin_amd64` is...it doesn't even know what `winx64` is and that's waaaay older. :(\n\nIs there an override to specify the PIO architecture? the Mac x64 binaries are good and should run (as they do in the IDE) but just a little slower since evidently Rosetta 2 is pretty good stuff.\n\nAlternatively, I might be able to publisy the Mac x64 binaries as Mac ARM64 but that seems like cheating and might cause some grief upstream...","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-06-18T18:34:16+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1329999295","fragment_type":"issue_comment","sequence":10,"text":"I did some exploration and while I can build most tools for the M1 using the latest `osxcross`, GCC itself isn't yet compatible as a host on the Apple M1 as of now (we need an Apple ARM M1 host, a ARM M0+ target build to make RP2040 binaries). See URL \n\nIt looks like only 12.X will support it, and as far as I can see on the GCC changelogs there is no Apple M1 support in as of the 12.2 release. If we move forward to 12.X and the M1 support is merged, I'll revisit. For now, though, unfortunately it's a \"hurry up and wait\" operation.","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-11-29T02:39:24+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1331202505","fragment_type":"issue_comment","sequence":11,"text":"FWIW heres what my M1 Pro shows currently\n\n➜ ~ gcc --version\nApple clang version 13.1.6 (clang-1316.0.21.2.5)\nTarget: arm64-apple-darwin21.4.0","author_login":"zjwhitehead","author_association":"NONE","created_at":"2022-11-29T19:45:33+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1331225167","fragment_type":"issue_comment","sequence":12,"text":"Yup, that's `clang` disingenuously pretending to be `gcc`. I'm sure GCC will be brought to the M1 eventually, it'll just take some time...","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-11-29T19:59:06+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1346959734","fragment_type":"issue_comment","sequence":13,"text":"The patching is done with in this Ruby file URL but when I try to build this from source I get an error. There are also binaries available which is what is installed by default and what I am using now and they are available here URL","author_login":"louisadamian","author_association":"NONE","created_at":"2022-12-12T17:57:21+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1351795385","fragment_type":"issue_comment","sequence":14,"text":"Thanks! I looked at it and it seems like no patching is needed on the 12.2 release of GCC. `darwin20` or `darwin21` looks like it's been added.\n\nUnfortunately that's only 1/2 of what I need. Because I build on Linux I actually need *2* cross-compilers built.\n1. Linux x86_64 **host**, AARCH64-darwin20 **target**\n2. Using (1), build a AARCH64-darwin20 **host**, Cortex-M0+ **target** compiler.\n\n(1) comes from OSXCross which presently only builds `clang` for the Arm, not `gcc`. I'm not sure that `clang` can be used as the compiler for GCC (it's not used in any of the other cross-builds I do). Will need to see if that's supported.","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-12-14T17:14:46+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363464877","fragment_type":"issue_comment","sequence":15,"text":"It turns out there **are** many patches required to make GCC be able to target `aarch-apple-darwin2x`. The Ruby file downloads a clean tarball and then applies patches a **20K++ line patch** from URL \n\nOnly GCC 11.3, 12.1, and 12.2 are patched, so the GCC 10 we're using is not supported at all.\n\nI attempted to apply the patch and run an `osxcross` build for GCC 12.2, and it throws massive amounts of compile warnings and fails while build a GCC prerequisite. (On the existing cross builds I don't believe there are more than a handful of warnings thrown for the entire process).\n\nSo, that means that even (1) above isn't available,yet.\n\nI'll leave this open but I think this is not going to happen until GH enables their own M1 hosted runners so I can special-case the M1 build...","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-12-23T00:22:55+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363572092","fragment_type":"issue_comment","sequence":16,"text":"It looks like there is a arm64 host version of the arm baremetal toolchain available now URL so that might be a better option.","author_login":"louisadamian","author_association":"NONE","created_at":"2022-12-23T03:15:14+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363573506","fragment_type":"issue_comment","sequence":17,"text":"No, I already build `aarch64-linux` just fine. It's the Apple specific one (`aarch64-apple-darwinXX`) which is the problem, sadly.","author_login":"earlephilhower","author_association":"OWNER","created_at":"2022-12-23T03:18:39+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1369837760","fragment_type":"issue_comment","sequence":18,"text":"Maybe this URL \ndoes help, espressif used my cumulative patch to build the native esp32x M1 toolchains for gcc 8.4. Built with URL","author_login":"Jason2866","author_association":"NONE","created_at":"2023-01-03T14:34:20+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1476360213","fragment_type":"issue_comment","sequence":19,"text":"I'm getting this error:\nReading symbols from /Users/niccoloperra/Projects/tesla-hud/.pio/build/pico/firmware.elf...\nPlatformIO Unified Debugger -> URL \nPlatformIO: debug_tool = cmsis-dap\nPlatformIO: Initializing remote target...\ndyld[11467]: Library not loaded: /usr/local/opt/libusb/lib/libusb-1.0.0.dylib\n Referenced from: /Users/niccoloperra/.platformio/packages/tool-openocd-rp2040-earlephilhower/bin/openocd\n Reason: tried: '/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/usr/local/opt/libusb/lib/libusb-1.0.0.dylib' (no such file), '/usr/local/lib/libusb-1.0.0.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), '/usr/lib/libusb-1.0.0.dylib' (no such file, not in dyld cache)\n \n Did you have any similar issues?","author_login":"nicco","author_association":"NONE","created_at":"2023-03-20T14:41:52+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1476403111","fragment_type":"issue_comment","sequence":20,"text":"You need the Intel format USB library and only have the ARM64 version.\n\nBack in the day, when going from 68k->PPC and IIRC PPC->x86, the Mac had \"fat binaries\" with code for both architectures in it, so a library or app could run on either architecture. Does it have it for the x86_64->arm64 transition? Can you install x86_64 versions of libraries in some other directorylike /usr/local/opt/x86_64 or something (like Linux uses for multiarch)?","author_login":"earlephilhower","author_association":"OWNER","created_at":"2023-03-20T15:06:14+08:00","repo_name":"earlephilhower/pico-quick-toolchain","issue_id":1196574962,"issue_number":8,"issue_url":"https://github.com/earlephilhower/pico-quick-toolchain/issues/8","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0180","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"E523 when using clever-f?","query_context":"Hello,\nI am using clever-f and I got this issue\n\n<img width=\"1715\" alt=\"image\" src=\" URL \n\nIt happens during the initialization of LSP server and after the initialization, the issue is gone. To reproduce, open any `lua` file (using `lua` because `lua` server needs longer time to initialize, so it will be easier to reproduce), then before the finish of the LSP server initialization, press `f` plus some char, then this issue appears. \n\nThank you very much.","known_context_document_ids":["gh_issue_1200197927"],"reference_answer":"In `:h map- `\n\nBe very careful about side effects! The expression is evaluated while\nobtaining characters, you may very well make the command dysfunctional.\nTherefore the following is blocked for mappings:\n- Changing the buffer text |textlock|.\n- Editing another buffer.\n- The |:normal| command.\n- Moving the cursor is allowed, but it is restored afterwards.\n- If the cmdline is changed, the old text and cursor position are restored.\nIf you want the mapping to do any of these let the returned characters do\nthat. (Or use a | | mapping instead.)","answer_document_id":"gh_comment_965430824","silver_evidence_path":["gh_comment_1095302204","gh_issue_1049981393","gh_comment_965430824"],"evidence_issue_ids":[1200197927,1049981393],"source_repo_name":"j-hui/fidget.nvim","source_issue_id":1200197927,"source_issue_number":68,"source_issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","target_repo_name":"neovim/neovim","target_issue_id":1049981393,"target_issue_number":16278,"target_issue_url":"https://github.com/neovim/neovim/issues/16278","reference_anchor_document_id":"gh_comment_1095302204","reference_answer_author":"zeertzjq","reference_answer_author_association":"MEMBER","quality_score":86.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3571,"anchor_target_overlap":0.0714,"target_answer_overlap":0.1818},"issue_created_at":"2022-04-11T16:08:07+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_1200197927","fragment_type":"issue_description","sequence":0,"text":"E523 when using clever-f\nHello,\nI am using clever-f and I got this issue\n\n<img width=\"1715\" alt=\"image\" src=\" URL \n\nIt happens during the initialization of LSP server and after the initialization, the issue is gone. To reproduce, open any `lua` file (using `lua` because `lua` server needs longer time to initialize, so it will be easier to reproduce), then before the finish of the LSP server initialization, press `f` plus some char, then this issue appears. \n\nThank you very much.","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-11T16:08:07+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1095283251","fragment_type":"issue_comment","sequence":1,"text":"@rockyzhang24 it looks like your figet.nvim is outdated, because L216 does not read like `vim.schedule`. Are you sure it is on the latest version?","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-11T16:36:58+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095285459","fragment_type":"issue_comment","sequence":2,"text":"Thanks. \nNo, it is the latest fidget. I update my plugins everyday. My neovim is the latest nightly (NVIM v0.7.0-dev+1439-gda31e953b)","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-11T16:39:13+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095299898","fragment_type":"issue_comment","sequence":3,"text":"Btw, the issue info is not the same for different filetype. \n\nIn a `go` file, I got\n<img width=\"1715\" alt=\"image\" src=\" URL","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-11T16:54:08+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095300077","fragment_type":"issue_comment","sequence":4,"text":"Sorry, I misread the stacktrace. You are right -- I can also reproduce the bug.\n\nIndeed `vim.schedule` is from L386 (the bottommost line) and L216 reads\n\napi.nvim_win_set_option(self.winid, \"winblend\", options.window.blend)\n\nThe problem is that the \"deferred\" `fidget:fmt()` call can still be executed by the event loop during the execution of `getchar()` (see URL I am looking into why.","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-11T16:54:22+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095302204","fragment_type":"issue_comment","sequence":5,"text":"Thank you so much. I am not sure whether this issue is caused by `clever-f`. I already opened an issue there ( URL Also, I am not sure whether this issue is related to URL i.e., caused by ` ` and `getchar()`. I have no ideas.","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-11T16:56:47+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[1049981393],"is_known_query_context":false},{"document_id":"gh_comment_1095304467","fragment_type":"issue_comment","sequence":6,"text":"Also worth checking out a comment by @kevinhwang91 ( URL -- I use a similar plugin that maps `f`, namely `quick-scope`. Or @kevinhwang91's `nvim-fFHighlight` might be another alternative. \n\nClever-f is not actively maintained these days, so you might want to switch to another similar plugin as a workaround. It's a bug that clever-f needs to fix, or neovim might be responsible for scheduling as `vim.schedule` is supposed to defer the execution *when it is available*.","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-11T16:59:21+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095307758","fragment_type":"issue_comment","sequence":7,"text":"Okay. Thank you for your suggestions. \nI know this new plugin `nvim-fFHighlight` but it not supports `tT` highlight. \nFor `quick-scope`, I tried it shortly before and I am worried its performance because it analyze each word in a line, not just the char I want to jump to.","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-11T17:02:51+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1096154186","fragment_type":"issue_comment","sequence":8,"text":"@wookayin Thank you so much for your investigation. Both fidget and clever-f are my must-have. Hope this can be fixed soon. Thanks again.","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-12T06:27:05+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1096232656","fragment_type":"issue_comment","sequence":9,"text":"Yes, it is perfectly fine. Because E523 errors happens due to a 'textlock' (see `:h textlock`) and it only pertains to drawing of the fidget windows. Any internal states and data will remain intact. As you could test out, the fidget windows will simply won't be updated nor be spinning while it is in the operator-pending mode.","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-12T07:19:13+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1096274534","fragment_type":"issue_comment","sequence":10,"text":"@wookayin Okay, thank you for explaining it in detail. I just tested it, and I found another glitch. \n\nTo reproduce it:\n1. Open a `lua` file (because `lua` LSP takes longer to initialize)\n2. Press `d` followed by `f`, now we are entering `Operator Pending` mode\n3. Wait here without giving a char to `f`. We can see that fidget progress update and spinning pause as expect. Keep waiting, and we can see fidget left some ghost chars even though it has finished in background.4. \n\n ` immediately after the ghost chars appear. The ghost will still be there and won't be removed any more. However, if we press ` ` after a while, the error shows again\n\n<img width=\"1721\" alt=\"image\" src=\" URL \n\nThank you!","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-12T07:42:08+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1096282990","fragment_type":"issue_comment","sequence":11,"text":"@rockyzhang24 Good catch. Can you try again in the updated PR?","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-12T07:47:11+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1096283531","fragment_type":"issue_comment","sequence":12,"text":"Because `nvim_get_mode` is only for RPC API, `blocking = true` is always for Lua.\n\nI don't think it's appropriate for fidget to fix this bug. There're maybe a lot of other async functions to encounter this issue. From the upstream is too hard to fix. From the clever-f avoid using must be refactored the cost is too expensive.","author_login":"kevinhwang91","author_association":"NONE","created_at":"2022-04-12T07:47:32+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101106353","fragment_type":"issue_comment","sequence":13,"text":"Again, the problem is that a function deferred by `vim.schedule(..)` will still be executed while operator is pending. We could safely skipping rendering, but when it comes to kill or closing, this workaround doesn't seem to work because it will lead to resource leakage or weird race condition. Fidget cannot easily tell when it is really available, despite the use of `vim.schedule`.\n\nI think this requires an upstream fix, so no good solution for now. For the time being, I think #69 can be still merged to avoid most of E523 errors, and we can later improve the remaining case when fidget is trying to close.\n\n@j-hui Any thoughts?","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-18T05:22:33+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101128784","fragment_type":"issue_comment","sequence":14,"text":"@rockyzhang24 I rewrote the logic and we can ignore the error when fidgets would be closed as well. This will make the annoying error not happen any more. However it cannot 100% eliminate \"ghost chars\" as I explained earlier; but we have some workaround like `:FidgetClose` so this should be usable enough.","author_login":"wookayin","author_association":"CONTRIBUTOR","created_at":"2022-04-18T06:11:30+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101138285","fragment_type":"issue_comment","sequence":15,"text":"@wookayin Thank you so much for digging deeper into this issue and trying to come up with solutions. It looks like we have to wait for the upstream fix to make this issue solved completely. Could you please open an issue upstream? If I do, I'm afraid I cannot describe it clearly.","author_login":"rockyzhang24","author_association":"NONE","created_at":"2022-04-18T06:26:16+08:00","repo_name":"j-hui/fidget.nvim","issue_id":1200197927,"issue_number":68,"issue_url":"https://github.com/j-hui/fidget.nvim/issues/68","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1049981393","fragment_type":"issue_description","sequence":0,"text":"`nvim_buf_set_lines` reported E523 in map-expr\n### Neovim version (nvim -v)\n\nNVIM v0.5.0\n\n### Vim (not Nvim) behaves the same?\n\nno\n\n### Operating system/version\n\nmacOS 11.0.1\n\n### Terminal name/version\n\nkitty 0.18.1\n\n### $TERM environment variable\n\nscreen-256color\n\n### Installation\n\nhomebrew\n\n### How to reproduce the issue\n\n1. open neovim `nvim`\n2. define a function that uses \n \n\n :function X()\n : let buf = nvim_create_buf(v:false, v:true)\n : call nvim_buf_set_lines(buf, 0, -1, v:true, [\"test\", \"text\"])\n : let opts = {'relative': 'cursor', 'width': 10, 'height': 2, 'col': 0, 'row': 1, 'anchor': 'NW', 'style': 'minimal'}\n : let win = nvim_open_win(buf, 0, opts)\n :endfunction\n \n\n3. define an `expr` mapping by `:map x X()`\n4. enter normal mode and press `x` key.\n\n### Expected behavior\n\nNo error occurs\n\n### Actual behavior\n\nError occurs:\n\nError detected while processing function X:\nline 2:\nE5555: API call: E523: Not allowed here\nPress ENTER or type command to continue\n\nNote that with \"normal\" bindings like `:map t :call X() ` actually works.","author_login":"lotabout","author_association":"NONE","created_at":"2021-11-10T15:32:51+08:00","repo_name":"neovim/neovim","issue_id":1049981393,"issue_number":16278,"issue_url":"https://github.com/neovim/neovim/issues/16278","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_965430824","fragment_type":"issue_comment","sequence":1,"text":"In `:h map- `\n\nBe very careful about side effects! The expression is evaluated while\nobtaining characters, you may very well make the command dysfunctional.\nTherefore the following is blocked for mappings:\n- Changing the buffer text |textlock|.\n- Editing another buffer.\n- The |:normal| command.\n- Moving the cursor is allowed, but it is restored afterwards.\n- If the cmdline is changed, the old text and cursor position are restored.\nIf you want the mapping to do any of these let the returned characters do\nthat. (Or use a | | mapping instead.)","author_login":"zeertzjq","author_association":"MEMBER","created_at":"2021-11-10T15:41:08+08:00","repo_name":"neovim/neovim","issue_id":1049981393,"issue_number":16278,"issue_url":"https://github.com/neovim/neovim/issues/16278","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_966028955","fragment_type":"issue_comment","sequence":2,"text":"@zeertzjq Thanks for clarification.\n\nI was actually trying to port an input method plugin ywvim's calling to vim's popup window to floating window. The plugin would use popup window to display the choices around the cursor, and popup window's APIs are called(and legitimate) in there `map-expr` functions. e.g.\n\nimage\n\nIs there any workaround in neovim for implementing this?","author_login":"lotabout","author_association":"NONE","created_at":"2021-11-11T06:32:33+08:00","repo_name":"neovim/neovim","issue_id":1049981393,"issue_number":16278,"issue_url":"https://github.com/neovim/neovim/issues/16278","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0181","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Tooltip for TV bottom left not appearing anymore at some time?","query_context":"When playtesting with the version built by Ronny here it happened at some time that the tooltip for the TV on the bottom left didn't appear anymore.\n\nScreenshot from 2023-03-09 18-57-55\n\nIt happened only once, and I guess it's very rare. But I don't know how to reproduce. I made a savegame but it wasn't reproducing that effect, the tooltip worked again after restart.","known_context_document_ids":["gh_issue_1618367818"],"reference_answer":"I might have remembered wrong about old TVs... But for me they are simply 5 \"switches\". Press one and the others are deactivated.\nSo power off will switch off other buttons too etc.\n\nOf course this can be changed. Guess that code is around 15 yrs old now ;-)","answer_document_id":"gh_comment_1792360129","silver_evidence_path":["gh_comment_1786283422","gh_issue_1969462371","gh_comment_1792360129"],"evidence_issue_ids":[1618367818,1969462371],"source_repo_name":"TVTower/TVTower","source_issue_id":1618367818,"source_issue_number":943,"source_issue_url":"https://github.com/TVTower/TVTower/issues/943","target_repo_name":"TVTower/TVTower","target_issue_id":1969462371,"target_issue_number":1044,"target_issue_url":"https://github.com/TVTower/TVTower/issues/1044","reference_anchor_document_id":"gh_comment_1786283422","reference_answer_author":"GWRon","reference_answer_author_association":"MEMBER","quality_score":84.44,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0556,"anchor_target_overlap":0.2778,"target_answer_overlap":0.125},"issue_created_at":"2023-03-10T05:04:57+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1618367818","fragment_type":"issue_description","sequence":0,"text":"Tooltip for TV bottom left not appearing anymore at some time\nWhen playtesting with the version built by Ronny here it happened at some time that the tooltip for the TV on the bottom left didn't appear anymore.\n\nScreenshot from 2023-03-09 18-57-55\n\nIt happened only once, and I guess it's very rare. But I don't know how to reproduce. I made a savegame but it wasn't reproducing that effect, the tooltip worked again after restart.","author_login":"scr0llbaer9000","author_association":"CONTRIBUTOR","created_at":"2023-03-10T05:04:57+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1463642152","fragment_type":"issue_comment","sequence":1,"text":"If this happens again: can you check if you cannot open up the ESC-Menu in that case?\n\nthe ESC-Menu thing is something rarely happening too - I even added a debug-logging for it but was not motivated enough to track it down (means trying often enough to make it fail :D).","author_login":"GWRon","author_association":"MEMBER","created_at":"2023-03-10T11:05:16+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774140564","fragment_type":"issue_comment","sequence":2,"text":"I have never encountered this problem. I assume the other tooltips in the lower region (audience, betty...) do not stop working at this point? Basically, they are all treated identically wrt. update and rendering...\nEven if you turn off the TV, you don't get the tooltip for \"turning it on again\"?","author_login":"nittka","author_association":"CONTRIBUTOR","created_at":"2023-10-22T16:43:11+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1786283422","fragment_type":"issue_comment","sequence":3,"text":"It happened again.\n \n\nESC menu is still working as usual.\n \n\nThe other tooltips in the lower center info region are working.\n \n\n*That* led me to another bug: URL","author_login":"scr0llbaer9000","author_association":"CONTRIBUTOR","created_at":"2023-10-31T01:17:14+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[1969462371],"is_known_query_context":false},{"document_id":"gh_comment_1789031301","fragment_type":"issue_comment","sequence":4,"text":"The error is caused by very long programme titles, e.g. \"Dynamit - Das Magazin Spezial: Prince Carl und Lady Dee (5/5): Dynamit Prince Carl und Lady Dee Spezial - Schlussfolge (Block 1/1)\".\n\nIf the tooltip width exceeds the screen width, the tooltip is moved to the left (base.framework.tooltip line 154). There is no guard that the resulting x position remains positive. And possibly the calculation of the delta is also buggy, because with x-position 41, tooltip width 830 and screen width 800 the resulting tooltip x-position after moving is -3839.\n\nPotential TODOs:\n* check and possibly fix calculation of tooltip-deltas\n* improve framework, so that original x-position is stored and is restored if title/content change (moving tooltip is only temporary)\n* tooltip title is single line, so programme tooltip should possibly ensure the title passed has a maximum length","author_login":"nittka","author_association":"CONTRIBUTOR","created_at":"2023-11-01T14:14:11+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1789230250","fragment_type":"issue_comment","sequence":5,"text":"While this of course is a bug in the framework I have to ask: \n \n\nSeriously? I mean ... seriously? Titles should be way way shorter - so that the ellipsis (...) does not cut away important parts and the title is still distinguishable from other elements of that series/franchise.","author_login":"GWRon","author_association":"MEMBER","created_at":"2023-11-01T16:07:21+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1789279370","fragment_type":"issue_comment","sequence":6,"text":"I guess the length of the title is due to it's being a series episode. I would not extend the framework to allow multi-line tooltip headers! This is an absolute border case. Ensuring that the tooltip does not permanently disappear from the screen should be enough. (Making sure the resulting x coordinate is not smaller than 0 and restoring it to its original value should be enough).","author_login":"nittka","author_association":"CONTRIBUTOR","created_at":"2023-11-01T16:34:25+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792337204","fragment_type":"issue_comment","sequence":7,"text":"Yeah sure that is redundant in that case here and can be shortened.\n\nBut in general, such long titles (especially in series when combining general and episode title) can exist.","author_login":"scr0llbaer9000","author_association":"CONTRIBUTOR","created_at":"2023-11-03T12:18:04+08:00","repo_name":"TVTower/TVTower","issue_id":1618367818,"issue_number":943,"issue_url":"https://github.com/TVTower/TVTower/issues/943","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1969462371","fragment_type":"issue_description","sequence":0,"text":"Lower left TV breaks when switching off and on again\n\"Have you tried switching it off and on again?\"\n\nSure, but that's exactly when the TV breaks indefinitely.\n\nThe TV just remains off, and can't be switched on again.\n*However*, when hovering over the channel buttons, the TV picture for that program will still be shown. Which may be an additional bug, I'm not sure.\n\nEven after saving and reloading a game, the situation is still the same.\n\nShould be easily reproducible, seems the functionality is broken in general. If not, I'll provide the savegame.\n\nJust astonishing that no-one reported this feature. Who ever needs to switch off the TV after all? I wondered about that \"feature\" that you can switch off the TV at all already back then in Mad TV. What's the purpose? Less distraction so you can \"focus\" better? `:)`","author_login":"scr0llbaer9000","author_association":"CONTRIBUTOR","created_at":"2023-10-31T01:16:13+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1787322112","fragment_type":"issue_comment","sequence":1,"text":"So far, I cannot reproduce the problem (Linux). For a newly started game turning the TV on/off does not break the hover (note that switching on is not done using the off-button, but using a channel button).\n\nMy assumption is that even a savegame might not help. I don't know if I can make myself clear. The savegame does not contain absolutely all data and not all game status is persisted and taken from that data. That is, if something is broken internally and not \"repaired\" by loading the game, it remains broken (e.g. maybe the broken hover for the TV). Likewise, not everything broken is transferred to the savegame. So maybe the hover status is not persisted and loading in a freshly started game will not have the problem anymore.","author_login":"nittka","author_association":"CONTRIBUTOR","created_at":"2023-10-31T14:23:43+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1787654352","fragment_type":"issue_comment","sequence":2,"text":"The channel tooltip is only visible when the game is not \"paused\".\n\nIf the game is not paused the game logic for \"button reaction\" is a simple check of the \"mouse position\" (for hover) and \"click\" (for activation)\n\nMaybe that \"paused\" thing is what borks it for @scr0llbaer9000","author_login":"GWRon","author_association":"MEMBER","created_at":"2023-10-31T17:21:22+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792343670","fragment_type":"issue_comment","sequence":3,"text":"But not when clicking the power button, right?\n\nIs there a misunderstanding here?\n\nThe expectation is absolutely that, just as in real life, when you switch the TV off with the main black power button, you can also switch it on again with the black button (as was the case in Mad TV afair). And I figure it is still reproducible that this doesn't work?\n\nI indeed was wrong in OP that the TV was broken \"indefinitely\", as it can be switched on again by clicking on one of the channel buttons. For some reason it didn't dawn on me to try that. `:)`","author_login":"scr0llbaer9000","author_association":"CONTRIBUTOR","created_at":"2023-11-03T12:22:49+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792360129","fragment_type":"issue_comment","sequence":4,"text":"I might have remembered wrong about old TVs... But for me they are simply 5 \"switches\". Press one and the others are deactivated.\nSo power off will switch off other buttons too etc.\n\nOf course this can be changed. Guess that code is around 15 yrs old now ;-)","author_login":"GWRon","author_association":"MEMBER","created_at":"2023-11-03T12:34:31+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1792380657","fragment_type":"issue_comment","sequence":5,"text":"yeah the 4 channel buttons can be switches, but the power button is its own thing.\n\nWhen switching on with the power button, the last \"active\" channel can be shown again.\n(In real life, channel buttons on most TVs weren't switches either though, the last \"state\" was not remembered, and channel 1 was shown when switching on.)","author_login":"scr0llbaer9000","author_association":"CONTRIBUTOR","created_at":"2023-11-03T12:48:55+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793354253","fragment_type":"issue_comment","sequence":6,"text":"For simplicity, my suggestion would be to show the channel of the \"active\" player when switching on, again.","author_login":"nittka","author_association":"CONTRIBUTOR","created_at":"2023-11-04T05:59:52+08:00","repo_name":"TVTower/TVTower","issue_id":1969462371,"issue_number":1044,"issue_url":"https://github.com/TVTower/TVTower/issues/1044","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0182","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"I have a lot of things I want you to improve?","query_context":"### Is your feature request related to a problem? Please describe.\n\n1.[pc] The minimized icon in the lower right corner should be changed to: left click to open directly, right click to pop up options\n\n2.[pc] Add shortcut send in the right-click menu\n\n3.[pc, android] When there is one device connected, it will be sent directly without confirming the device. When the device is larger than one or there is no device, a pop-up window will appear to select the device\n\n4.[pc, android] After sending \"A\" file and then sending \"B\" file, you need to delete the previously added a, I think you need a switch that does not keep the history added\n\n5.[pc, android] show real-time transfer speed\n\n6.[android] Android client save location can be set\n\n### Describe the solution you'd like\n\nThe software looks good overall, but many functions are still unsatisfactory\n\n### Describe alternatives you've considered\n\n_No response_\n\n### Additional context\n\n_No response_","known_context_document_ids":["gh_issue_1594502998"],"reference_answer":"@tahayparker you need to start the app at least once, optionally there is a setting hidden under the \"advanced\" toggle where you can enable context menu.\nAlso, LocalSend is available under \"Send to\" not as an share option in Windows 10/11","answer_document_id":"gh_comment_2228687858","silver_evidence_path":["gh_comment_1455092729","gh_issue_1569519534","gh_comment_2228687858"],"evidence_issue_ids":[1594502998,1569519534],"source_repo_name":"localsend/localsend","source_issue_id":1594502998,"source_issue_number":192,"source_issue_url":"https://github.com/localsend/localsend/issues/192","target_repo_name":"localsend/localsend","target_issue_id":1569519534,"target_issue_number":115,"target_issue_url":"https://github.com/localsend/localsend/issues/115","reference_anchor_document_id":"gh_comment_1455092729","reference_answer_author":"Tienisto","reference_answer_author_association":"MEMBER","quality_score":85.44,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0556,"anchor_target_overlap":0.0,"target_answer_overlap":0.2143},"issue_created_at":"2023-02-22T05:53:23+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_1594502998","fragment_type":"issue_description","sequence":0,"text":"I have a lot of things I want you to improve\n### Is your feature request related to a problem? Please describe.\n\n1.[pc] The minimized icon in the lower right corner should be changed to: left click to open directly, right click to pop up options\n\n2.[pc] Add shortcut send in the right-click menu\n\n3.[pc, android] When there is one device connected, it will be sent directly without confirming the device. When the device is larger than one or there is no device, a pop-up window will appear to select the device\n\n4.[pc, android] After sending \"A\" file and then sending \"B\" file, you need to delete the previously added a, I think you need a switch that does not keep the history added\n\n5.[pc, android] show real-time transfer speed\n\n6.[android] Android client save location can be set\n\n### Describe the solution you'd like\n\nThe software looks good overall, but many functions are still unsatisfactory\n\n### Describe alternatives you've considered\n\n_No response_\n\n### Additional context\n\n_No response_","author_login":"bearcloney","author_association":"NONE","created_at":"2023-02-22T05:53:23+08:00","repo_name":"localsend/localsend","issue_id":1594502998,"issue_number":192,"issue_url":"https://github.com/localsend/localsend/issues/192","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1443616889","fragment_type":"issue_comment","sequence":1,"text":"5. Real time speed is always shown as soon as 5 MB has been sent, the speed is too volatile for small transfers.","author_login":"Tienisto","author_association":"CONTRIBUTOR","created_at":"2023-02-24T12:26:53+08:00","repo_name":"localsend/localsend","issue_id":1594502998,"issue_number":192,"issue_url":"https://github.com/localsend/localsend/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1455092729","fragment_type":"issue_comment","sequence":2,"text":"1. Added in `v1.8.0`\n2. Duplicate of #115 \n3. I don't know if this is confusing / unexpected behaviour\n4. Added in `v1.8.0`\n5. See previous comment\n6. This is technically difficult because of the new scoped storage permissions.","author_login":"Tienisto","author_association":"CONTRIBUTOR","created_at":"2023-03-05T13:29:45+08:00","repo_name":"localsend/localsend","issue_id":1594502998,"issue_number":192,"issue_url":"https://github.com/localsend/localsend/issues/192","linked_issue_ids":[1569519534],"is_known_query_context":false},{"document_id":"gh_issue_1569519534","fragment_type":"issue_description","sequence":0,"text":"Windows context menu (right click menu)\nHi, I love the application. This is a feature request.\n\nCan you add this program into the Windows 10/11 context menu so you can quickly right click a file and share?","author_login":"dr-baba","author_association":"NONE","created_at":"2023-02-03T09:28:38+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435670356","fragment_type":"issue_comment","sequence":1,"text":"yes pls add this option then finally i can switch from send anywhere .. btw love ur work i tried many but ur app was the one i ws looking for :) keep it up bro","author_login":"techgamers2","author_association":"NONE","created_at":"2023-02-18T13:31:55+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1836779267","fragment_type":"issue_comment","sequence":2,"text":"Flutter currently doesn't offer an easy way to add context menus.","author_login":"Tienisto","author_association":"MEMBER","created_at":"2023-12-01T21:08:29+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852184573","fragment_type":"issue_comment","sequence":3,"text":"This could possibly be implemented by adding a shortcut to the app in the SendTo folder, and reading the path to the file/folder from the command line arguments (in the `main` function).","author_login":"dancojocaru2000","author_association":"NONE","created_at":"2023-12-12T14:49:17+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1859220137","fragment_type":"issue_comment","sequence":4,"text":"I came to open a issue specifically asking for this implementation. Big support","author_login":"TSnatch72","author_association":"NONE","created_at":"2023-12-17T16:42:15+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1986775645","fragment_type":"issue_comment","sequence":5,"text":"any update on this? this issue has been stale for 4 months now","author_login":"tahayparker","author_association":"NONE","created_at":"2024-03-09T07:23:15+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2219876701","fragment_type":"issue_comment","sequence":6,"text":"Hi Tien, when can we expect this feature to be part of a release?","author_login":"tahayparker","author_association":"NONE","created_at":"2024-07-10T08:27:10+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220089139","fragment_type":"issue_comment","sequence":7,"text":"Thank you very much Tien\nI would like to express my gratitude, and I recognize the effort that goes into implementing such a feature.","author_login":"tahayparker","author_association":"NONE","created_at":"2024-07-10T10:08:57+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2227719726","fragment_type":"issue_comment","sequence":8,"text":"能否支持Win11新版右键菜单的系统分享？\nCan the system sharing of the new right-click menu of Win11 be supported?\nimage","author_login":"PandaFiredoge","author_association":"NONE","created_at":"2024-07-15T05:21:45+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2228660154","fragment_type":"issue_comment","sequence":9,"text":"Hi @Tienisto\nI believe that this issue was fixed and is part of v1.15.0\nHowever, I do not see the context menu entry","author_login":"tahayparker","author_association":"NONE","created_at":"2024-07-15T14:36:39+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2228687858","fragment_type":"issue_comment","sequence":10,"text":"@tahayparker you need to start the app at least once, optionally there is a setting hidden under the \"advanced\" toggle where you can enable context menu.\nAlso, LocalSend is available under \"Send to\" not as an share option in Windows 10/11","author_login":"Tienisto","author_association":"MEMBER","created_at":"2024-07-15T14:49:07+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2231383481","fragment_type":"issue_comment","sequence":11,"text":"i see, i had disabled the \"send to\" as i didn't need it\nwould it be possible to create the entry in the \"main\" context menu rather than in the \"send to\" submenu?","author_login":"tahayparker","author_association":"NONE","created_at":"2024-07-16T16:46:44+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2282344415","fragment_type":"issue_comment","sequence":12,"text":"localsend_2024-08-11_09-28-25\ni enable it, but Shortcuts in the \"Send To\" folder not appearing in the menu.","author_login":"lsq","author_association":"NONE","created_at":"2024-08-11T01:40:24+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2397611709","fragment_type":"issue_comment","sequence":13,"text":"You can try manually modifying the registry to add LocalSend's sending function to the main context menu of the right-click.","author_login":"Downmars","author_association":"NONE","created_at":"2024-10-07T18:30:37+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2398830154","fragment_type":"issue_comment","sequence":14,"text":"I have tried to modify the registration expression to put the send directive in the context menu, you can try to create a txt document type the following (if you localsend is the default installation address) and change the txt suffix to reg.\n:Windows Registry Editor Version 5.00\n\n[HKEY_CLASSES_ROOT\\*\\shell\\LocalSend]\n@=\"Send with LocalSend\"\n\"Icon\"=\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\"\n\n[HKEY_CLASSES_ROOT\\*\\shell\\LocalSend\\command]\n@=\"\\\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\\\" \\\"%1\\\"\"\n\n[HKEY_CLASSES_ROOT\\Directory\\shell\\LocalSend]\n@=\"Send with LocalSend\"\n\"Icon\"=\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\"\n\n[HKEY_CLASSES_ROOT\\Directory\\shell\\LocalSend\\command]\n@=\"\\\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\\\" \\\"%V\\\"\"\n\n[HKEY_CLASSES_ROOT\\Directory\\Background\\shell\\LocalSend]\n@=\"Send with LocalSend\"\n\"Icon\"=\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\"\n\n[HKEY_CLASSES_ROOT\\Directory\\Background\\shell\\LocalSend\\command]\n@=\"\\\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\\\" \\\"%V\\\"\"","author_login":"Downmars","author_association":"NONE","created_at":"2024-10-08T04:50:51+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2398830904","fragment_type":"issue_comment","sequence":15,"text":"I have tried to modify the registration expression to put the send directive in the context menu, you can try to create a txt document type the following (if you localsend is the default installation address) and change the txt suffix to reg.\n:Windows Registry Editor Version 5.00\n\n[HKEY_CLASSES_ROOT\\*\\shell\\LocalSend]\n@=\"Send with LocalSend\"\n\"Icon\"=\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\"\n\n[HKEY_CLASSES_ROOT\\*\\shell\\LocalSend\\command]\n@=\"\\\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\\\" \\\"%1\\\"\"\n\n[HKEY_CLASSES_ROOT\\Directory\\shell\\LocalSend]\n@=\"Send with LocalSend\"\n\"Icon\"=\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\"\n\n[HKEY_CLASSES_ROOT\\Directory\\shell\\LocalSend\\command]\n@=\"\\\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\\\" \\\"%V\\\"\"\n\n[HKEY_CLASSES_ROOT\\Directory\\Background\\shell\\LocalSend]\n@=\"Send with LocalSend\"\n\"Icon\"=\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\"\n\n[HKEY_CLASSES_ROOT\\Directory\\Background\\shell\\LocalSend\\command]\n@=\"\\\"C:\\\\Program Files\\\\LocalSend\\\\localsend_app.exe\\\" \\\"%V\\\"\"","author_login":"Downmars","author_association":"NONE","created_at":"2024-10-08T04:51:33+08:00","repo_name":"localsend/localsend","issue_id":1569519534,"issue_number":115,"issue_url":"https://github.com/localsend/localsend/issues/115","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0183","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Zero injection?","query_context":"I'm specifically interested in whether it's feasible to control the microinverter's zero injection mode via the ESP ECU. Thanks.","known_context_document_ids":["gh_issue_2449559561"],"reference_answer":"@kiss81 It should be possible if we knew the zigbee commands for it. Sadly we don't. Someone with an official ECU can provide this data with a zigbee sniffer, so far no volunteer has come forward.","answer_document_id":"gh_comment_1567543985","silver_evidence_path":["gh_comment_2278173004","gh_issue_1728918976","gh_comment_1567543985"],"evidence_issue_ids":[2449559561,1728918976],"source_repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","source_issue_id":2449559561,"source_issue_number":145,"source_issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/145","target_repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","target_issue_id":1728918976,"target_issue_number":118,"target_issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/118","reference_anchor_document_id":"gh_comment_2278173004","reference_answer_author":"patience4711","reference_answer_author_association":"OWNER","quality_score":72.78,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2,"target_answer_overlap":0.0556},"issue_created_at":"2024-08-05T22:07:56+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2449559561","fragment_type":"issue_description","sequence":0,"text":"Zero injection\nI'm specifically interested in whether it's feasible to control the microinverter's zero injection mode via the ESP ECU. Thanks.","author_login":"JMMarquezL","author_association":"NONE","created_at":"2024-08-05T22:07:56+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":2449559561,"issue_number":145,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/145","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2273753984","fragment_type":"issue_comment","sequence":1,"text":"If you know the zigbee command it would be doable via the console. Sadly i don't know the command.","author_login":"patience4711","author_association":"OWNER","created_at":"2024-08-07T15:32:59+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":2449559561,"issue_number":145,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274026994","fragment_type":"issue_comment","sequence":2,"text":"How can I acquire the command? What was your method for decoding the Zigbee data? Thank you very much.","author_login":"JMMarquezL","author_association":"NONE","created_at":"2024-08-07T17:58:36+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":2449559561,"issue_number":145,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2278173004","fragment_type":"issue_comment","sequence":3,"text":"This question has been asked before.\nread here and\nto get an idea how the reversed-engineering went, read here\n\nIn short: Someone with an official ECU needs to sniff the communication ecu inverter.","author_login":"patience4711","author_association":"OWNER","created_at":"2024-08-09T15:09:22+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":2449559561,"issue_number":145,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/145","linked_issue_ids":[1728918976],"is_known_query_context":false},{"document_id":"gh_issue_1728918976","fragment_type":"issue_description","sequence":0,"text":"feature request: turn off / turn on (export limit)\nNot sure if this is possible, but some inverters support a temporary export limit. (turn off the inverter)\nIs there any chance this could work? In the Netherlands we sometimes have negative prices an hour a day so you have to pay for producing electricity. \nI am using this on a qs1 by the way.","author_login":"kiss81","author_association":"NONE","created_at":"2023-05-27T20:05:16+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":1728918976,"issue_number":118,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/118","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1567543985","fragment_type":"issue_comment","sequence":1,"text":"@kiss81 It should be possible if we knew the zigbee commands for it. Sadly we don't. Someone with an official ECU can provide this data with a zigbee sniffer, so far no volunteer has come forward.","author_login":"patience4711","author_association":"OWNER","created_at":"2023-05-29T21:56:29+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":1728918976,"issue_number":118,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/118","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1632674120","fragment_type":"issue_comment","sequence":2,"text":"I asked on a forum that's working on integration of the official ecu. I do hope one has a sniffer...","author_login":"kiss81","author_association":"NONE","created_at":"2023-07-12T14:49:04+08:00","repo_name":"patience4711/read-APSystems-YC600-QS1-DS3","issue_id":1728918976,"issue_number":118,"issue_url":"https://github.com/patience4711/read-APSystems-YC600-QS1-DS3/issues/118","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0184","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"JDBC database shutdown on disconnect.","query_context":"A duckdb connector has been implemented recently on DBeaver. However, the database does not shutdown on disconnect.\nIs there a JDBC driver feature similar to the R package where we can say `shutdown = TRUE`?","known_context_document_ids":["gh_issue_868789586"],"reference_answer":"Thanks for raising this! There were a number of changes around automatically closing JDBC connections and caching them in the 0.6.0 release, so it's possible something broke","answer_document_id":"gh_comment_1316175876","silver_evidence_path":["gh_comment_1317954048","gh_issue_1450655723","gh_comment_1316175876"],"evidence_issue_ids":[868789586,1450655723],"source_repo_name":"duckdb/duckdb","source_issue_id":868789586,"source_issue_number":1683,"source_issue_url":"https://github.com/duckdb/duckdb/issues/1683","target_repo_name":"duckdb/duckdb","target_issue_id":1450655723,"target_issue_number":5371,"target_issue_url":"https://github.com/duckdb/duckdb/issues/5371","reference_anchor_document_id":"gh_comment_1317954048","reference_answer_author":"Mause","reference_answer_author_association":"MEMBER","quality_score":85.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0625,"anchor_target_overlap":0.3684,"target_answer_overlap":0.2857},"issue_created_at":"2021-04-27T12:19:02+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_868789586","fragment_type":"issue_description","sequence":0,"text":"JDBC database shutdown on disconnect.\nA duckdb connector has been implemented recently on DBeaver. However, the database does not shutdown on disconnect.\nIs there a JDBC driver feature similar to the R package where we can say `shutdown = TRUE`?","author_login":"travis-leith","author_association":"CONTRIBUTOR","created_at":"2021-04-27T12:19:02+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1197266229","fragment_type":"issue_comment","sequence":1,"text":"I also ran into this bug and couldn't open my duckdb from Python, not even with `read_only=True`.\n\nDisconnect in DBeaver didn't help, only closing the DBeaver application completely resolved the issue.\n\nIs there anyone that can fix the DBeaver connector to disconnect properly?\n\nIn [82]: con = duckdb.connect(\"my-db.duckdb\", read_only=True)\n---------------------------------------------------------------------------\nRuntimeError Traceback (most recent call last)\nInput In [82], in ()\n----> 1 con = duckdb.connect(\"my-db.duckdb\", read_only=True)\n\nRuntimeError: IO Error: Could not set lock on file \"my-db.duckdb\": Resource temporarily unavailable","author_login":"cdeil","author_association":"NONE","created_at":"2022-07-27T19:20:48+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1283713318","fragment_type":"issue_comment","sequence":2,"text":"@cdeil are you able to test if this still occurs with the latest master build? We now shutdown the database instance when the last connection is closed","author_login":"Mause","author_association":"MEMBER","created_at":"2022-10-19T09:36:07+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1287186869","fragment_type":"issue_comment","sequence":3,"text":"I'm not sure how easy it would be for me to reproduce the issue and then build and try the master.\nIf you or others in the dev team can't easily do that, I could try, let me know.\nOr alternatively - when is your next stable release? Could also wait for that and try again.","author_login":"cdeil","author_association":"NONE","created_at":"2022-10-21T16:28:47+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316444061","fragment_type":"issue_comment","sequence":4,"text":"@cdeil are you able to confirm if this behaves as expected for you with 0.6.0?","author_login":"Mause","author_association":"MEMBER","created_at":"2022-11-16T06:29:39+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317265407","fragment_type":"issue_comment","sequence":5,"text":"I updated the Python version as well as the driver in DBeaver to duckdb 0.6.0.\n\nI can confirm that after closing the DB connection in DBeaver, I can now open the file from Python. So that bug is not there any more.\n\n---\n\nHowever I'm still seeing that after opening a DuckDB in DBeaver, I still can't open it in Python in read-only mode:\n\nIn [2]: duckdb.connect(\"/Users/cdeil/code/hc/hpred/data/cache/sensor.duckdb\", read_only=True)\n---------------------------------------------------------------------------\nIOException Traceback (most recent call last)\nInput In [2], in ()\n----> 1 duckdb.connect(\"/Users/cdeil/code/hc/hpred/data/cache/sensor.duckdb\", read_only=True)\n\nIOException: IO Error: Could not set lock on file \"/Users/cdeil/code/hc/hpred/data/cache/sensor.duckdb\": Resource temporarily unavailable\n\n---\n\nAnd now I noticed a purely DBeaver-related bug (without Python) which can be reproduced like this:\n\n1. Open a DuckDB (works).\n2. Disconnect (works).\n3. Try to connect again - fails with error:\n\nConnection Error: Instance with path: /Users/cdeil/code/hc/hpred/data/cache/sensor.duckdb already exists.\n\nSo it's still the case that I completely have to close the DBeaver app to continue working. Somehow the JDBC driver is left in a bad state after disconnecting that prevents it to re-connect later.","author_login":"cdeil","author_association":"NONE","created_at":"2022-11-16T16:08:41+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317357469","fragment_type":"issue_comment","sequence":6,"text":"Are you opening the database in read only mode in DBeaver when you open it in Python (also in read only)?\n\nWe've had a couple of reports of that DBeaver issue yes, there were a number of changes that might have caused it so I'll need to do some investigation","author_login":"Mause","author_association":"MEMBER","created_at":"2022-11-16T17:03:22+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317534593","fragment_type":"issue_comment","sequence":7,"text":"I was using normal read/write mode in DBeaver and read-only mode in Python.","author_login":"cdeil","author_association":"NONE","created_at":"2022-11-16T19:08:29+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317954048","fragment_type":"issue_comment","sequence":8,"text":"Unfortunately you can only have one client connected to a database if you're using a write connection. Multiple connections is only (presently) supported in read only mode\n\nLooks like your other issue is a duplicate of #5371","author_login":"Mause","author_association":"MEMBER","created_at":"2022-11-17T02:08:02+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[1450655723],"is_known_query_context":false},{"document_id":"gh_comment_1318184919","fragment_type":"issue_comment","sequence":9,"text":"OK then I think this issue should be closed.\n\n@travis-leith as original reporter - do you agree?\n\n---\n\nIs it a known or valid feature request for DuckDB to allow other readers even if a writer has a connection open? Or will it never be possible with how DuckDB works?\n\nMy use case is simply that I use DBeaver as a DB GUI to check content, while I have a Python script writing to it, that's when I ran into these issues.","author_login":"cdeil","author_association":"NONE","created_at":"2022-11-17T07:07:35+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1318449549","fragment_type":"issue_comment","sequence":10,"text":"I have not had the pleasure of using duckdb for a while now. But going by the above discussion, looks like this can be closed, and possibly a feature request for read only connections in the presence of a read/write connection.","author_login":"travis-leith","author_association":"CONTRIBUTOR","created_at":"2022-11-17T10:50:47+08:00","repo_name":"duckdb/duckdb","issue_id":868789586,"issue_number":1683,"issue_url":"https://github.com/duckdb/duckdb/issues/1683","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1450655723","fragment_type":"issue_description","sequence":0,"text":"Instance caching prevents multiple connections, closing and re-opening with JDBC\n### What happens?\n\nIt looks like the instance caching is failing to allow either multiple connections, or closing the connection and subsequently opening the database again.\n\n### To Reproduce\n\nThis throws an error:\n\nimport java.sql.Connection;\nimport java.sql.DriverManager;\n\nclass duckdb {\n public static void main(String[] args) {\n try {\n Connection conn = DriverManager.getConnection(\"jdbc:duckdb:test-temp.db\");\n Connection conn2 = DriverManager.getConnection(\"jdbc:duckdb:test-temp.db\");\n\n conn.close();\n conn2.close();\n } catch (Exception e) {\n System.out.println(e);\n e.printStackTrace();\n }\n }\n}\n\nThe error thrown:\n\njava.sql.SQLException: Connection Error: Instance with path: /Users/pellsworth/test-duckdb/test-temp.db already exists.\n at org.duckdb.DuckDBNative.duckdb_jdbc_startup(Native Method)\n at org.duckdb.DuckDBDatabase. (DuckDBDatabase.java:28)\n at org.duckdb.DuckDBDriver.connect(DuckDBDriver.java:36)\n at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:677)\n at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:251)\n at duckdb.main(duckdb.java:8)\n at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n at java.base/java.lang.reflect.Method.invoke(Method.java:566)\n at jdk.compiler/com.sun.tools.javac.launcher.Main.execute(Main.java:404)\n at jdk.compiler/com.sun.tools.javac.launcher.Main.run(Main.java:179)\n at jdk.compiler/com.sun.tools.javac.launcher.Main.main(Main.java:119)\n\n(it also will throw the same error if you try to close the first connection before opening the second).\n\n### OS:\n\nOSX, x64\n\n### DuckDB Version:\n\n0.6.0\n\n### DuckDB Client:\n\nJava\n\n### Full Name:\n\nPaul Ellsworth\n\n### Affiliation:\n\nTenable\n\n### Have you tried this on the latest `master` branch?\n\n- [X] I agree\n\n### Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?\n\n- [X] I agree","author_login":"paulewog","author_association":"NONE","created_at":"2022-11-16T01:24:53+08:00","repo_name":"duckdb/duckdb","issue_id":1450655723,"issue_number":5371,"issue_url":"https://github.com/duckdb/duckdb/issues/5371","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316154664","fragment_type":"issue_comment","sequence":1,"text":"(I might also just be totally missing how it's supposed to work :) )","author_login":"paulewog","author_association":"NONE","created_at":"2022-11-16T01:39:35+08:00","repo_name":"duckdb/duckdb","issue_id":1450655723,"issue_number":5371,"issue_url":"https://github.com/duckdb/duckdb/issues/5371","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316175876","fragment_type":"issue_comment","sequence":2,"text":"Thanks for raising this! There were a number of changes around automatically closing JDBC connections and caching them in the 0.6.0 release, so it's possible something broke","author_login":"Mause","author_association":"MEMBER","created_at":"2022-11-16T02:00:04+08:00","repo_name":"duckdb/duckdb","issue_id":1450655723,"issue_number":5371,"issue_url":"https://github.com/duckdb/duckdb/issues/5371","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317952442","fragment_type":"issue_comment","sequence":3,"text":"Looks like this is a bug introduced in URL maybe @Mytherin can take a look?","author_login":"Mause","author_association":"MEMBER","created_at":"2022-11-17T02:05:59+08:00","repo_name":"duckdb/duckdb","issue_id":1450655723,"issue_number":5371,"issue_url":"https://github.com/duckdb/duckdb/issues/5371","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0185","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"nixos/glance: glance-start-pre: install: invalid user 'glance'?","query_context":"### Nixpkgs version\n\n- Unstable (25.05)\n\n### Describe the bug\n\nAfter URL was merged glance module does not start and throws an error message. (see relevant log output)\n\nMy configuration does not use any secrets.\n\nIt seems that when this PR was implemented it was not tested with a configuration that uses no secrets at all and therefore does not create a `glance` user owned secrets with sops-nix or other methods.\n\n### Steps to reproduce\n\nUse glance nixos module with no secrets while having no `glance` user on your system\n\n### Expected behaviour\n\nThe glance module works with no secrets defined and no 'glance' user created using the means outside of the `nixos/glance` module.\n\n### Screenshots\n\n_No response_\n\n### Relevant log output\n\nconsole\nkgl3a8vqw0ly5k0ff86y0k1kz3aw0g61-glance-start-pre[261578]: install: invalid user 'glance'\n\n### Additional context\n\n_No response_\n\n### System metadata\n\n - system: `\"x86_64-linux\"`\n - host os: `Linux 6.12.29, NixOS, 25.11 (Xantusia), 25.11.20250520.2795c50`\n - multi-user?: `yes`\n - sandbox: `yes`\n - version: `nix-env (Nix) 2.28.3`\n - nixpkgs: `/nix/store/p893dkrzm5rxvhnqh092prgi1a7dzmcy-source`\n\n### Notify maintainers\n\n@drupol @gepbird\n\n---\n\n**Note for maintainers:** Please tag this issue in your pull request description. (i.e. `Resolves #ISSUE`.)\n\n### I assert that this issue is relevant for Nixpkgs\n\n- [x] I assert that this is a bug and not a support request.\n- [x] I assert that this is not a duplicate of an existing issue. \n- [x] I assert that I have read the NixOS Code of Conduct and agree to abide by it.\n\n### Is this issue important to you?\n\nAdd a :+1: [reaction] to [issues you find important].\n\n[reaction]: URL \n[issues you find important]: URL","known_context_document_ids":["gh_issue_3079622866"],"reference_answer":"@pinpox The `-q` was already there, and I'm just removing the `-s`. Sorry I didn't make that clearer.\n\nWith the extra configuration:\n\nini\n$ systemctl cat NetworkManager-wait-online.service\n# /etc/systemd/system/NetworkManager-wait-online.service\n[Unit]\nDescription=Network Manager Wait Online\nDocumentation=man:nm-online(1)\nRequires=NetworkManager.service\nAfter=NetworkManager.service\nBefore=network-online.target\n\n[Service]\n# `nm-online -s` waits until the point when NetworkManager logs\n# \"startup complete\". That is when startup actions are settled and\n# devices and profiles reached a conclusive activated or deactivated\n# state. It depends on which profiles are configured to autoconnect and\n# also depends on profile settings like ipv4.may-fail/ipv6.may-fail,\n# which affect when a profile is considered fully activated.\n# Check NetworkManager logs to find out why wait-online takes a certain\n# time.\n\nType=oneshot\nExecStart=/nix/store/r7fwxkxbgmwyrff5n03r9nchzskj59n9-networkmanager-1.40.16/bin/nm-online -s -q\nRemainAfterExit=yes\n\n# Set $NM_ONLINE_TIMEOUT variable for timeout in seconds.\n# Edit with `systemctl edit NetworkManager-wait-online`.\n#\n# Note, this timeout should commonly not be reached. If your boot\n# gets delayed too long, then the solution is usually not to decrease\n# the timeout, but to fix your setup so that the connected state\n# gets reached earlier.\nEnvironment=NM_ONLINE_TIMEOUT=60\n\n[Install]\nWantedBy=network-online.target\n\n# /nix/store/2ma3yvlqmj94dr6v24nkwmspgxfpfnmq-system-units/NetworkManager-wait-online.service.d/overrides.conf\n[Unit]\n\n[Service]\nEnvironment=\"LOCALE_ARCHIVE=/nix/store/g135laybfk1c7bm2zhrh7x6dv884qxal-glibc-locales-2.35-224/lib/locale/locale-archive\"\nEnvironment=\"PATH=/nix/store/l6jgwxkc3jhr029vfzfwzcy28iyckwsj-coreutils-9.1/bin:/nix/store/gn1s1s5z19cf0wiir2cd38jckcjc6kn6-findutils-4.9.0/bin:/nix/store/pvb117r7fhwb08717ks21a6y>\nEnvironment=\"TZDIR=/nix/store/z0kg1c0f8fx6r4rgg5bdy01lb2b9izqg-tzdata-2023a/share/zoneinfo\"\n\nExecStart=\nExecStart=/nix/store/r7fwxkxbgmwyrff5n03r9nchzskj59n9-networkmanager-1.40.16/bin/nm-online -q","answer_document_id":"gh_comment_1660635001","silver_evidence_path":["gh_comment_2907020804","gh_issue_1293615234","gh_comment_1660635001"],"evidence_issue_ids":[3079622866,1293615234],"source_repo_name":"NixOS/nixpkgs","source_issue_id":3079622866,"source_issue_number":409348,"source_issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","target_repo_name":"NixOS/nixpkgs","target_issue_id":1293615234,"target_issue_number":180175,"target_issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","reference_anchor_document_id":"gh_comment_2907020804","reference_answer_author":"neilmayhew","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2025,"anchor_target_overlap":0.2532,"target_answer_overlap":0.2783},"issue_created_at":"2025-05-21T09:47:46+08:00","valid_comment_count":80,"fragments":[{"document_id":"gh_issue_3079622866","fragment_type":"issue_description","sequence":0,"text":"nixos/glance: glance-start-pre: install: invalid user 'glance'\n### Nixpkgs version\n\n- Unstable (25.05)\n\n### Describe the bug\n\nAfter URL was merged glance module does not start and throws an error message. (see relevant log output)\n\nMy configuration does not use any secrets.\n\nIt seems that when this PR was implemented it was not tested with a configuration that uses no secrets at all and therefore does not create a `glance` user owned secrets with sops-nix or other methods.\n\n### Steps to reproduce\n\nUse glance nixos module with no secrets while having no `glance` user on your system\n\n### Expected behaviour\n\nThe glance module works with no secrets defined and no 'glance' user created using the means outside of the `nixos/glance` module.\n\n### Screenshots\n\n_No response_\n\n### Relevant log output\n\nconsole\nkgl3a8vqw0ly5k0ff86y0k1kz3aw0g61-glance-start-pre[261578]: install: invalid user 'glance'\n\n### Additional context\n\n_No response_\n\n### System metadata\n\n - system: `\"x86_64-linux\"`\n - host os: `Linux 6.12.29, NixOS, 25.11 (Xantusia), 25.11.20250520.2795c50`\n - multi-user?: `yes`\n - sandbox: `yes`\n - version: `nix-env (Nix) 2.28.3`\n - nixpkgs: `/nix/store/p893dkrzm5rxvhnqh092prgi1a7dzmcy-source`\n\n### Notify maintainers\n\n@drupol @gepbird\n\n---\n\n**Note for maintainers:** Please tag this issue in your pull request description. (i.e. `Resolves #ISSUE`.)\n\n### I assert that this issue is relevant for Nixpkgs\n\n- [x] I assert that this is a bug and not a support request.\n- [x] I assert that this is not a duplicate of an existing issue. \n- [x] I assert that I have read the NixOS Code of Conduct and agree to abide by it.\n\n### Is this issue important to you?\n\nAdd a :+1: [reaction] to [issues you find important].\n\n[reaction]: URL \n[issues you find important]: URL","author_login":"jaredmontoya","author_association":"NONE","created_at":"2025-05-21T09:47:46+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2897592509","fragment_type":"issue_comment","sequence":1,"text":"It uses `$USER` which is provided by systemd using DynamicUser IIUC, I expect it to work without secrets too\n\nThe NixOS test, which had a machine with only `services.glance.enable = true` config also passes\n\nCan you the config for a minimal repro please? I'll try to look into this more deeply a few days later, I'm a bit busy right now","author_login":"gepbird","author_association":"CONTRIBUTOR","created_at":"2025-05-21T11:25:51+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2901331381","fragment_type":"issue_comment","sequence":2,"text":"I tried to reproduce it in a VM but couldn't, this is what I tried:\n- add some glance config from the example\n\n glance config \n\nnix\n services.glance = {\n enable = true;\n settings = {\n pages = [\n {\n columns = [\n {\n size = \"full\";\n widgets = [\n {\n type = \"calendar\";\n }\n ];\n }\n ];\n name = \"Calendar\";\n }\n ];\n };\n };\n\n \n\n- build with nixpkgs at b4667dba16e62bd6f589383d1d23c4084545ad6c (before the glance secret PR), switch to the config\n- observe new glance service starting without issues\n- build with nixpkgs at aaf817bb5b0d2c7bb7892fb158292805f8927d65 (after the glance secret PR), switch to the config\n- observe that glance-start-pre and replace-secret packages were added (via nvd) as expected, but the glance systemd service is still running without errors\n\nIt's also possible that not URL is causing the issue but something else (for example systemd changes, I haven't done any search for these), it would be helpful if you could share the old and new nixpkgs revision that caused this issue @jaredmontoya @wyndon. The best would be to link the commit to your config where you found this bug.","author_login":"gepbird","author_association":"CONTRIBUTOR","created_at":"2025-05-22T13:57:23+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2901502443","fragment_type":"issue_comment","sequence":3,"text":"github:nixos/nixpkgs/nixos-unstable\n\nBefore: d89fc19e405cb2d55ce7cc114356846a0ee5e956\nAfter: 2795c506fe8fb7b03c36ccb51f75b6df0ab2553f","author_login":"jaredmontoya","author_association":"CONTRIBUTOR","created_at":"2025-05-22T14:44:10+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2901698380","fragment_type":"issue_comment","sequence":4,"text":"Thanks, but unfortunately I still couldn't reproduce it :(\n\nWhen I switched from your before revision to your after, I saw glance getting updated (0.8.1 -> 0.7.13), but nothing else relevant really and the service restarted successfully. Also on your before revision, the glance secret PR is already included, so it wasn't introduced between the 2 commits","author_login":"gepbird","author_association":"CONTRIBUTOR","created_at":"2025-05-22T15:38:21+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903662123","fragment_type":"issue_comment","sequence":5,"text":"Maybe it really is caused by systemd changes or something else like that.","author_login":"jaredmontoya","author_association":"CONTRIBUTOR","created_at":"2025-05-23T08:19:51+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2907020804","fragment_type":"issue_comment","sequence":6,"text":"Good news, I could finally reproduce it. However it's inconsistent, it only failed 3 out of 10 times. Switching to a system built with a bad commit (2c8d3f48d33929642c1c12cd243df4cc7d2ce434, 2025-04-02, I picked a way older one than y'all reported just to be sure) then a good commit (063f43f2dbdef86376cc29ad646c45c46e93234c, 2025-05-23).\n\nWhen trying to reproduce this between the suspected PR and a commit right before it, the issue wasn't there 20 out of 20 times. It's possible that it depends on the timing: when I can repro it sometimes, the activation script runs for a few seconds as months of changes require many services to be restarted, but switching between PR and right before it is very fast and the issue doesn't have enough time to manifest\n\nI hope this is not another URL \n\ncc @NixOS/systemd, is there wrong with URL Sometimes when updating nixpkgs to a newer version we get `kgl3a8vqw0ly5k0ff86y0k1kz3aw0g61-glance-start-pre[261578]: install: invalid user 'glance'` for the first time, after that restarting the service works fine forever™ (unless we downgrade to an older nixpkgs and upgrade again)","author_login":"gepbird","author_association":"CONTRIBUTOR","created_at":"2025-05-24T21:04:36+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[1293615234],"is_known_query_context":false},{"document_id":"gh_comment_2907655494","fragment_type":"issue_comment","sequence":7,"text":"I'm going to bet on some kind ofrace condition with `nsncd` . As that's the way we provide NSS resolution in NixOS. But it's a bit odd as it's socket activated. \n\nAnything in the logs about nsncd when you reproduce it? Maybe switch-to-configuration also restarting it?","author_login":"arianvp","author_association":"MEMBER","created_at":"2025-05-25T07:06:20+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2907686499","fragment_type":"issue_comment","sequence":8,"text":"Yes, `nscd` service is restarted when switching from that months old nixpkgs to an up-to-date one, here are the logs with precise time stamps:\n\n log of glance.service \n\nconsole\nMay 25 10:11:27.441753 gepvm systemd[1]: Stopping Glance feed dashboard server...\n░░ Subject: A stop job for unit glance.service has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit glance.service has begun execution.\n░░\n░░ The job identifier is 8443.\nMay 25 10:11:27.449282 gepvm systemd[1]: glance.service: Deactivated successfully.\n░░ Subject: Unit succeeded\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit glance.service has successfully entered the 'dead' state.\nMay 25 10:11:27.450093 gepvm systemd[1]: Stopped Glance feed dashboard server.\n░░ Subject: A stop job for unit glance.service has finished\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit glance.service has finished.\n░░\n░░ The job identifier is 8443 and the job result is done.\nMay 25 10:11:31.498145 gepvm systemd[1]: Starting Glance feed dashboard server...\n░░ Subject: A start job for unit glance.service has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A start job for unit glance.service has begun execution.\n░░\n░░ The job identifier is 9158.\nMay 25 10:11:31.541156 gepvm rv53hcsa0v4r61wi4wvgc9qf4asj9165-glance-start-pre[7906]: install: invalid user 'glance'\nMay 25 10:11:31.543474 gepvm systemd[1]: glance.service: Control process exited, code=exited, status=1/FAILURE\n░░ Subject: Unit process exited\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ An ExecStartPre= process belonging to unit glance.service has exited.\n░░\n░░ The process' exit code is 'exited' and its exit status is 1.\nMay 25 10:11:31.543676 gepvm systemd[1]: glance.service: Failed with result 'exit-code'.\n░░ Subject: Unit failed\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit glance.service has entered the 'failed' state with result 'exit-code'.\nMay 25 10:11:31.545265 gepvm systemd[1]: Failed to start Glance feed dashboard server.\n░░ Subject: A start job for unit glance.service has failed\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A start job for unit glance.service has finished with a failure.\n░░\n░░ The job identifier is 9158 and the job result is failed.\n\n \n\n log of nscd.service \n\nconsole\nMay 25 10:11:27.428515 gepvm systemd[1]: Stopping Name Service Cache Daemon (nsncd)...\n░░ Subject: A stop job for unit nscd.service has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit nscd.service has begun execution.\n░░\n░░ The job identifier is 8436.\nMay 25 10:11:27.430064 gepvm systemd[1]: nscd.service: Deactivated successfully.\n░░ Subject: Unit succeeded\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ The unit nscd.service has successfully entered the 'dead' state.\nMay 25 10:11:27.431271 gepvm systemd[1]: Stopped Name Service Cache Daemon (nsncd).\n░░ Subject: A stop job for unit nscd.service has finished\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A stop job for unit nscd.service has finished.\n░░\n░░ The job identifier is 8436 and the job result is done.\nMay 25 10:11:31.515812 gepvm systemd[1]: Starting Name Service Cache Daemon (nsncd)...\n░░ Subject: A start job for unit nscd.service has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A start job for unit nscd.service has begun execution.\n░░\n░░ The job identifier is 8955.\nMay 25 10:11:31.545377 gepvm nsncd[7889]: May 25 08:11:31.545 INFO started, config: Config { ignored_request_types: {}, worker_count: 8, handoff_timeout: 10s }, path: \"/var/run/nscd/sock>\nMay 25 10:11:31.548892 gepvm systemd[1]: Started Name Service Cache Daemon (nsncd).\n░░ Subject: A start job for unit nscd.service has finished successfully\n░░ Defined-By: systemd\n░░ Support: URL \n░░\n░░ A start job for unit nscd.service has finished successfully.\n░░\n░░ The job identifier is 8955.","author_login":"gepbird","author_association":"CONTRIBUTOR","created_at":"2025-05-25T08:21:41+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3405791681","fragment_type":"issue_comment","sequence":9,"text":"As expected, nothing changed since then with how ns(n)cd get started.","author_login":"flokli","author_association":"NONE","created_at":"2025-10-15T10:40:36+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3406512142","fragment_type":"issue_comment","sequence":10,"text":"Oh, ok.\nI thought atomic updates were part of the `nixos-rebuild switch` functionality.\nBut I guess it's all `deploy-rs` magic rollback's doing in my case.","author_login":"jaredmontoya","author_association":"NONE","created_at":"2025-10-15T13:41:47+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3412174299","fragment_type":"issue_comment","sequence":11,"text":"Somehow I didn't know about it (even though it's widely used in docker, systemd and nixpkgs), I opened a PR, thanks for your idea!\n\nI think we should keep this issue open for tracking the purposes of the root cause.","author_login":"gepbird","author_association":"NONE","created_at":"2025-10-16T18:07:38+08:00","repo_name":"NixOS/nixpkgs","issue_id":3079622866,"issue_number":409348,"issue_url":"https://github.com/NixOS/nixpkgs/issues/409348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1293615234","fragment_type":"issue_description","sequence":0,"text":"NetworkManager's nm-online kills nixos-rebuild\n### Describe the bug\n\nThe systemd service `NetworkManager-wait-online.service` can prevent `nixos-rebuild` from succeeding:\n\nwarning: the following units failed: NetworkManager-wait-online.service\n\n× NetworkManager-wait-online.service - Network Manager Wait Online\n Loaded: loaded (/etc/systemd/system/NetworkManager-wait-online.service; enabled; vendor preset: enabled)\n Drop-In: /nix/store/k5yq51spcggip2h6aq1y0bydkpr4zahc-system-units/NetworkManager-wait-online.service.d\n └─overrides.conf\n Active: failed (Result: exit-code) since Tue 2022-07-05 10:18:52 NZST; 36ms ago\n Docs: man:nm-online(1)\n Process: 1258376 ExecStart=/nix/store/b4yhg54s70i0v0k1qnnv8vnja6018yrh-networkmanager-1.38.2/bin/nm-online -s -q (code=exited, status=1/FAILURE)\n Main PID: 1258376 (code=exited, status=1/FAILURE)\n IP: 0B in, 0B out\n CPU: 22ms\n\nJul 05 10:17:52 nixos systemd[1]: Starting Network Manager Wait Online...\nJul 05 10:18:52 nixos systemd[1]: NetworkManager-wait-online.service: Main process exited, code=exited, status=1/FAILURE\nJul 05 10:18:52 nixos systemd[1]: NetworkManager-wait-online.service: Failed with result 'exit-code'.\n\nThis service runs `nm-online -s -q`, and the `nm-online` man page says:\n\n-s | --wait-for-startup\n Wait for NetworkManager startup to complete, rather than waiting for network connectivity specifically. Startup is\n considered complete once NetworkManager has activated (or attempted to activate) every auto-activate connection\n which is available given the current network state. This corresponds to the moment when NetworkManager logs \"startup\n complete\". This mode is generally only useful at boot time. After startup has completed, nm-online -s will just\n return immediately, regardless of the current network state.\n\n There are various ways to affect when startup complete is reached. For details see NetworkManager-wait-\n online.service(8).\n\n \n\nI am not familiar with this tool, but my experience is that after my laptop has been up for some time (e.g. days), `nm-online` will often return an error code rather than correctly determine the network is up, thus killing any future `nixos-rebuild` commands.\n\n### Steps To Reproduce\nSteps to reproduce the behavior:\n\n1. Get your machine in a state where `nm-online -s -q` does not return success (not sure how to do this on demand).\n2. Witness `nixos-rebuild` failure.\n\n### Expected behavior\n\n`nixos-rebuild` should not fail due to an erroneous network check.\n\n### Additional context\n\nThis is tricky as it is not a `nix` issue per se but rather an issue with a presumably flaky systemd service. It is easy enough to disable this service manually:\n\nnix\nsystemd.services.NetworkManager-wait-online.enable = false;\n\nAnd perhaps this is the best solution. But a number of my coworkers all ran into this issue independently, so I thought it merited an issue for discoverability, if nothing else. My gut reaction is that a flaky check should probably not be required by default, but I don't know enough about this service's importance/fragility to say.\n\nThis issue was noticed only recently, both on `nixos-unstable` and `nixos-22.05`.\n\n### Notify maintainers\n\n### Metadata\nPlease run `nix-shell -p nix-info --run \"nix-info -m\"` and paste the result.\n\nconsole\n[user@system:~]$ nix-shell -p nix-info --run \"nix-info -m\"\n - system: `\"x86_64-linux\"`\n - host os: `Linux 5.15.47, NixOS, 22.05 (Quokka)`\n - multi-user?: `yes`\n - sandbox: `yes`\n - version: `nix-env (Nix) 2.8.1`\n - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`\n\nThanks!","author_login":"tbidne","author_association":"CONTRIBUTOR","created_at":"2022-07-04T22:45:25+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1176816121","fragment_type":"issue_comment","sequence":1,"text":"This issue has been mentioned on **NixOS Discourse**. There might be relevant details there:\n\n URL","author_login":"nixos-discourse","author_association":"NONE","created_at":"2022-07-06T22:29:24+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1186152020","fragment_type":"issue_comment","sequence":2,"text":"This is related to udev not initializing devices. NetworkManager never completes startup because a WireGuard interface is never initialized by udev. A workaround is just putting the affected device into `networking.networkmanager.unmanaged`.","author_login":"lorenz","author_association":"CONTRIBUTOR","created_at":"2022-07-16T10:56:52+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1209710061","fragment_type":"issue_comment","sequence":3,"text":"I'm wondering if there is any solution to this. Since this triggers for me always. So, I'm not even sure if my `nixos-rebuild switch` does actually complete.\n\nAs mentioned in the initial description of the issue:\n \n\nThis never seems to be the case, since the actual message is \"Started Network Manager.\".\nApart from that I'm wondering why it relies on a log message string, when the status of `NetworkManager.service` would be way less prone to errors.","author_login":"DeskworkTrickster","author_association":"NONE","created_at":"2022-08-09T18:09:35+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1222385709","fragment_type":"issue_comment","sequence":4,"text":"I think I'm running into this.\n\n`systemd-networkd-wait-online.service`\n\nAug 22 08:38:49 erin-laptop systemd[1]: Starting Wait for Network to be Configured...\nAug 22 08:40:49 erin-laptop systemd-networkd-wait-online[26249]: Timeout occurred while waiting for network connectivity.\nAug 22 08:40:49 erin-laptop systemd[1]: systemd-networkd-wait-online.service: Main process exited, code=exited, status=1/FAILURE\nAug 22 08:40:49 erin-laptop systemd[1]: systemd-networkd-wait-online.service: Failed with result 'exit-code'.\nAug 22 08:40:49 erin-laptop systemd[1]: Failed to start Wait for Network to be Configured.\n\nIt only happens after I've connected my USB-C dock with an ethernet connection at least once after boot. (Note: I'm running tmpfs on root, so my system should \"forget\" everything about my dock on reboot.)","author_login":"oati","author_association":"CONTRIBUTOR","created_at":"2022-08-22T13:45:18+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273814285","fragment_type":"issue_comment","sequence":5,"text":"I don't use NetworkManager so I wouldn't know, but in the case of systemd-networkd there are relevant options under `systemd.network.wait-online`: `anyInterface` and `ignoredInterfaces`. I recommend at least setting the former to `true` on laptops.\n \n\nWarning about failed units is pretty much the last thing that the activation script does, so it's probably fine (but the failure should be fixed, of course).","author_login":"ncfavier","author_association":"MEMBER","created_at":"2022-10-10T20:59:09+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273827251","fragment_type":"issue_comment","sequence":6,"text":"BTW I've \"fixed\" this by setting\n\nnix\n# udev 250 doesn't reliably reinitialize devices after restart\nsystemd.services.systemd-udevd.restartIfChanged = false;\n\nBut this is really an upstream systemd bug.","author_login":"lorenz","author_association":"CONTRIBUTOR","created_at":"2022-10-10T21:14:38+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306051129","fragment_type":"issue_comment","sequence":7,"text":"My Ubuntu has:\n\n❯ systemctl cat NetworkManager-wait-online.service\n# /lib/systemd/system/NetworkManager-wait-online.service\n[Unit]\nDescription=Network Manager Wait Online\nDocumentation=man:nm-online(1)\nRequires=NetworkManager.service\nAfter=NetworkManager.service\nBefore=network-online.target\n\n[Service]\n# `nm-online -s` waits until the point when NetworkManager logs\n# \"startup complete\". That is when startup actions are settled and\n# devices and profiles reached a conclusive activated or deactivated\n# state. It depends on which profiles are configured to autoconnect and\n# also depends on profile settings like ipv4.may-fail/ipv6.may-fail,\n# which affect when a profile is considered fully activated.\n# Check NetworkManager logs to find out why wait-online takes a certain\n# time.\n\nType=oneshot\nExecStart=/usr/bin/nm-online -s -q\nRemainAfterExit=yes\n\n# Set $NM_ONLINE_TIMEOUT variable for timeout in seconds.\n# Edit with `systemctl edit NetworkManager-wait-online`.\n#\n# Note, this timeout should commonly not be reached. If your boot\n# gets delayed too long, then the solution is usually not to decrease\n# the timeout, but to fix your setup so that the connected state\n# gets reached earlier.\nEnvironment=NM_ONLINE_TIMEOUT=60\n\n[Install]\n\nMy latest NixOS config has:\n\n \n{ after = [ ... ]; aliases = [ ... ]; before = [ ... ]; bindsTo = [ ... ]; confinement = { ... }; conflicts = [ ... ]; description = \"\"; documentation = [ ... ]; enable = false; environment = { ... }; jobScripts = [ ... ]; onFailure = [ ... ]; partOf = [ ... ]; path = [ ... ]; postStart = \"\"; postStop = \"\"; preStart = \"\"; preStop = \"\"; reload = \"\"; reloadIfChanged = false; reloadTriggers = [ ... ]; requiredBy = [ ... ]; requires = [ ... ]; requisite = [ ... ]; restartIfChanged = true; restartTriggers = [ ... ]; runner = error: attribute 'ExecStart' missing\n\n at /nix/store/6dgpkrc0gxlndr4j2524ihlsr8209ph7-source/nixos/modules/testing/service-runner.nix:65:9:\n\n 64| my $cmd = <<END_CMD;\n 65| ${service.serviceConfig.ExecStart}\n | ^\n 66| END_CMD\n«derivation\n\nbased on this definition:\n\nconsole\n systemd.services.NetworkManager-wait-online = {\n wantedBy = [ \"network-online.target\" ];\n };\n\nWhere is this `ExecStart` coming from in your configurations?","author_login":"blaggacao","author_association":"CONTRIBUTOR","created_at":"2022-11-07T18:59:28+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306101038","fragment_type":"issue_comment","sequence":8,"text":"@blaggacao: The reference to `nm-online` comes from upstream service unit `NetworkManager-wait-online.service`, not from nixpkgs itself.","author_login":"bjornfor","author_association":"CONTRIBUTOR","created_at":"2022-11-07T19:43:36+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1473408913","fragment_type":"issue_comment","sequence":9,"text":"I've been tripping over this bug for quite some time now and it is annoying for users. As mentioned above, the error can be worked around with:\n\nnix\nsystemd.services.NetworkManager-wait-online.enable = lib.mkForce false;\nsystemd.services.systemd-networkd-wait-online.enable = lib.mkForce false;\n\nI was concernd if there might be other dependencies or services that require this to be enabled, so I grepped through nixpkgs for both. These are the mentions:\n\n### NetworkManager-wait-online.service\n- modules/networkmanager The actual definition of this service\n- pkgs.hqplayerd can probably be removed\n\n### systemd-networkd-wait-online.service\n- modules/system/boot/networkd Service devinition\n- Used in various nixos tests, which should not be relevant to normal operation of the system (?)\n - nixos/tests/systemd-networkd-dhcpserver-static-leases.nix\n - nixos/tests/kea.nix\n - nixos/tests/systemd-networkd.nix\n - nixos/tests/systemd-bpf.nix\n - nixos/tests/systemd-networkd-dhcpserver.nix\n\n### TL;DR\n\nUpon first look the usage of these two services seem minimal to me and they are causing more problems that doing good. Agreeing with @domenkozar's proposal, I'd vote to disable them per default. If this is agreed upon, I can submit a PR","author_login":"pinpox","author_association":"MEMBER","created_at":"2023-03-17T08:40:44+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1473472385","fragment_type":"issue_comment","sequence":10,"text":"I've been running with that service disabled for 6 months now and have not experienced a single issue. Don't count my voice too heavily, though :wink: ! :+1:","author_login":"matthiasbeyer","author_association":"CONTRIBUTOR","created_at":"2023-03-17T09:11:00+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1473732009","fragment_type":"issue_comment","sequence":11,"text":"If we're going to work around this I'd still prefer `systemd.services.systemd-udevd.restartIfChanged = false;` as the other workaround just masks the issue while udev's still half-broken.","author_login":"lorenz","author_association":"CONTRIBUTOR","created_at":"2023-03-17T12:05:08+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479289684","fragment_type":"issue_comment","sequence":12,"text":"For some reason, that didn't work for me. On rebuild it said \"not restarting service\"","author_login":"pinpox","author_association":"MEMBER","created_at":"2023-03-22T10:24:08+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1502421373","fragment_type":"issue_comment","sequence":13,"text":"Yep confirming what @pinpox said: \n\nupdating GRUB 2 menu...\nNOT restarting the following changed units: systemd-udevd.service\n\nStill seeing the issue on HEAD. Disabling wait-online like mentioned previously fixes nixos-rebuild.\n\nsystemd.services.NetworkManager-wait-online.enable = lib.mkForce false;\nsystemd.services.systemd-networkd-wait-online.enable = lib.mkForce false;","author_login":"supermarin","author_association":"CONTRIBUTOR","created_at":"2023-04-10T22:33:40+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537225778","fragment_type":"issue_comment","sequence":14,"text":"`NetworkManager-wait-online.service` is a dependency of `network-online.target`:\n\nconsole\n$ systemctl list-dependencies --reverse NetworkManager-wait-online.service\nNetworkManager-wait-online.service\n● └─network-online.target\n● ├─dnscrypt-proxy2.service\n● ├─wireguard-wg-intra-peer-[...].service\n● └─multi-user.target\n\nconsole\n$ systemctl cat NetworkManager-wait-online.service | grep network-online.target\nBefore=network-online.target\nWantedBy=network-online.target\n\nAs others pointed out, the `-s` (aka. `--wait-for-startup`) flag is causing some deadlock:\n\n# `nm-online -s` waits until the point when NetworkManager logs\n# \"startup complete\". That is when startup actions are settled and\n# devices and profiles reached a conclusive activated or deactivated\n# state. It depends on which profiles are configured to autoconnect and\n# also depends on profile settings like ipv4.may-fail/ipv6.may-fail,\n# which affect when a profile is considered fully activated.\n# Check NetworkManager logs to find out why wait-online takes a certain\n# time.\n\nI guess using `-s` is a more accurate notification than simply waiting for `NetworkManager.service` to be up, and I don't know why it sometimes fails to notice that the startup is complete, nor whether removing it has any significant drawbacks, but keeping it causes `switch-to-configuration test` to fail often enough to bother me, so until a more correct fix is available, I'm personally removing it:\n\nnix\n{ pkgs, ... }: {\n systemd.services.NetworkManager-wait-online = {\n serviceConfig.ExecStart = [ \"\" \"${pkgs.networkmanager}/bin/nm-online -q\" ];\n };\n}","author_login":"ju1m","author_association":"CONTRIBUTOR","created_at":"2023-05-06T21:23:48+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1544387711","fragment_type":"issue_comment","sequence":15,"text":"Also running into these deadlocks on recent versions of nixpkgs.","author_login":"darkone23","author_association":"NONE","created_at":"2023-05-11T17:17:13+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585298926","fragment_type":"issue_comment","sequence":16,"text":"This has been happening to me consistently for over a year. The cause seems to be due to what I've described in URL \n\nI used (a simplified version of) @ju1m's workaround, but using the workaround from URL seems to be even better. However, I don't know how to include that in my system configuration rather than running it manually when needed.","author_login":"neilmayhew","author_association":"MEMBER","created_at":"2023-06-10T00:12:14+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1595743529","fragment_type":"issue_comment","sequence":17,"text":"My instance of this issue is indeed caused by a wireguard interface, but adding the interface to `networking.networkmanager.unmanaged` (via name or `type:wireguard`) did not change a thing. Having done some more digging online, I believe I know why: prior to udev initialization completing for a link, NM cannot be sure what the name or type of the link will be (as udev may make changes), and so it is *not possible* to filter a device prior to udev marking it as configured.\n\nI'm still looking for a workaround.","author_login":"Shados","author_association":"CONTRIBUTOR","created_at":"2023-06-17T12:59:22+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1636822608","fragment_type":"issue_comment","sequence":18,"text":"I have the issue on the MacBook Pro 2019 16,1 with t2 patches after switching to iwd, because of network issues.","author_login":"martin-braun","author_association":"NONE","created_at":"2023-07-15T16:43:45+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1644312756","fragment_type":"issue_comment","sequence":19,"text":"I'm new to NixOS, I have this error as well:\n\nbash\njul 20 19:19:13 nixos systemd[1]: Starting Network Manager Wait Online...\njul 20 19:20:13 nixos systemd[1]: NetworkManager-wait-online.service: Main process exited, code=exited, status=1/FAILURE\njul 20 19:20:13 nixos systemd[1]: NetworkManager-wait-online.service: Failed with result 'exit-code'.\njul 20 19:20:13 nixos systemd[1]: Failed to start Network Manager Wait Online.\nwarning: error(s) occurred while switching to the new configuration\n\n I put this line in my configuration.nix (`systemd.services.NetworkManager-wait-online.enable = lib.mkForce false;`), but then I get this error:\n\nbash\n$ sudo nixos-rebuild switch --upgrade\nunpacking channels...\nerror: undefined variable 'lib'\n\n at /etc/nixos/configuration.nix:16:56:\n\n 15| boot.loader.systemd-boot.enable = true;\n 16| systemd.services.NetworkManager-wait-online.enable = lib.mkForce false;\n | ^\n 17| boot.loader.efi.canTouchEfiVariables = true;\n(use '--show-trace' to show detailed location information)\nbuilding Nix...\n\nAnd I can't update anymore, so I am stuck and a fairly recent clean NixOS install. Is there a way to force the update for now? What is the best structural solution?\n\nThank you!","author_login":"freekvh","author_association":"NONE","created_at":"2023-07-20T17:27:02+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1644392870","fragment_type":"issue_comment","sequence":20,"text":"Looks like `nixos-generate-config` adds this in the beginning of /etc/nixos/configuration.nix:\n\n[...snip comment block...]\n\n{ config, pkgs, ... }:\n\nwhereas most people eventually modify that to `{ config, pkgs, lib, ... }:`, providing configuration.nix with the missing `lib` argument.\n\nI think nixos-generate-config should be updated to include `lib` by default. Although the default config doesn't need/use `lib`, it quickly becomes something new NixOS users want to use.","author_login":"bjornfor","author_association":"CONTRIBUTOR","created_at":"2023-07-20T18:25:06+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1644414521","fragment_type":"issue_comment","sequence":21,"text":"Thanx for the quic reply.\n\nI have added { config, pkgs, **lib**, ... }:\n\nIn the first line of my configuration.nix, but I get the same error...","author_login":"freekvh","author_association":"NONE","created_at":"2023-07-20T18:39:18+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1644444473","fragment_type":"issue_comment","sequence":22,"text":"Then please open a new issue or post on URL asking for help.","author_login":"bjornfor","author_association":"CONTRIBUTOR","created_at":"2023-07-20T19:00:13+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1644616049","fragment_type":"issue_comment","sequence":23,"text":"This issue has been mentioned on **NixOS Discourse**. There might be relevant details there:\n\n URL","author_login":"nixos-discourse","author_association":"NONE","created_at":"2023-07-20T21:12:21+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1645442729","fragment_type":"issue_comment","sequence":24,"text":"Ok, this solved it for me: URL \n\nJust dit `sudo nixos-rebuild boot --upgrade` and rebooted. I left the lib in the `{ config, pkgs, lib, ... }:`.\n\nThanx for the support!","author_login":"freekvh","author_association":"NONE","created_at":"2023-07-21T11:34:17+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655787774","fragment_type":"issue_comment","sequence":25,"text":"So, to summarise, the actual error seems to be that NM waits for startup of some interfaces it thinks it should manage but they're never communicated as up to NM because NM was never supposed manage that interface?\n\nWhen I say `nmcli`, NM thinks it does not manage my tailscale0 interface:\n\ntailscale0: unmanaged\n \"tailscale0\"\n tun, sw, mtu 1280\n\nWhy would it be waiting on it then? The other interfaces are up and I'm sending you this message via one of them, so it can't be waiting on those.\n\nI'll try to explicitly add it to `networking.networkmanager.unmanaged` and report back after a few rebuilds in a few weeks.","author_login":"Atemu","author_association":"MEMBER","created_at":"2023-07-28T14:28:35+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655789703","fragment_type":"issue_comment","sequence":26,"text":"No, `nm-online` is just weirdly broken and locks up if you try to do it on an already running system. It's probably an easy code fix but I'm not familiar with the codebase at all.","author_login":"K900","author_association":"CONTRIBUTOR","created_at":"2023-07-28T14:30:05+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1657895833","fragment_type":"issue_comment","sequence":27,"text":"Is that something that has to be fixed upstream? If so, could you create an issue for it?","author_login":"pinpox","author_association":"MEMBER","created_at":"2023-07-31T08:19:39+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1657906143","fragment_type":"issue_comment","sequence":28,"text":"Reading through those. Are we using the mentioned `-s` flag? If so, maybe we can remove it? Running `nm-online -s` manually hangs for me, while `nm-online` (without `-s`) seems to work correctly.","author_login":"pinpox","author_association":"MEMBER","created_at":"2023-07-31T08:26:47+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1657918014","fragment_type":"issue_comment","sequence":29,"text":"Alright, I'll stick with my workaround then for now. I would like to contribute a real fix for this or sort it out properly, but don't know how to continue.","author_login":"pinpox","author_association":"MEMBER","created_at":"2023-07-31T08:34:41+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1658731959","fragment_type":"issue_comment","sequence":30,"text":"I had this problem for well over a year, but since I added this to my `configuration.nix` the problem has not reoccurred:\n\nnix\nsystemd.services.NetworkManager-wait-online = {\n serviceConfig = {\n ExecStart = [ \"\" \"${pkgs.networkmanager}/bin/nm-online -q\" ];\n };\n};\n\nNor have I had any other network problems.\n\nAlso,\n\nshellsession\n$ nm-online -s\nConnecting............... 30s [started]\n$ journalctl -b -u NetworkManager-dispatcher.service\nJul 10 16:24:41 melchizedek systemd[1]: Starting Network Manager Script Dispatcher Service...\nJul 10 16:24:41 melchizedek systemd[1]: Started Network Manager Script Dispatcher Service.\nJul 10 16:24:51 melchizedek systemd[1]: NetworkManager-dispatcher.service: Deactivated successfully.\nJul 11 17:43:59 melchizedek systemd[1]: Starting Network Manager Script Dispatcher Service...\nJul 11 17:43:59 melchizedek systemd[1]: Started Network Manager Script Dispatcher Service.\nJul 11 17:44:09 melchizedek systemd[1]: NetworkManager-dispatcher.service: Deactivated successfully.\nJul 14 18:41:15 melchizedek systemd[1]: Starting Network Manager Script Dispatcher Service...\nJul 14 18:41:15 melchizedek systemd[1]: Started Network Manager Script Dispatcher Service.\nJul 14 18:41:25 melchizedek systemd[1]: NetworkManager-dispatcher.service: Deactivated successfully.\n...\n$ last reboot -1\nreboot system boot 5.15.119 Mon Jul 10 16:24 still running\n\n`NetworkManager-dispatcher.service` seems to run at various times that aren't related to reboots or `nixos-upgrade switch`","author_login":"neilmayhew","author_association":"MEMBER","created_at":"2023-07-31T16:29:35+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1659147455","fragment_type":"issue_comment","sequence":31,"text":"@neilmayhew what does that exactly do? If I understand the man page correctly, `-q` only omits the output, without changing any functionality","author_login":"pinpox","author_association":"MEMBER","created_at":"2023-07-31T20:54:43+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1660635001","fragment_type":"issue_comment","sequence":32,"text":"@pinpox The `-q` was already there, and I'm just removing the `-s`. Sorry I didn't make that clearer.\n\nWith the extra configuration:\n\nini\n$ systemctl cat NetworkManager-wait-online.service\n# /etc/systemd/system/NetworkManager-wait-online.service\n[Unit]\nDescription=Network Manager Wait Online\nDocumentation=man:nm-online(1)\nRequires=NetworkManager.service\nAfter=NetworkManager.service\nBefore=network-online.target\n\n[Service]\n# `nm-online -s` waits until the point when NetworkManager logs\n# \"startup complete\". That is when startup actions are settled and\n# devices and profiles reached a conclusive activated or deactivated\n# state. It depends on which profiles are configured to autoconnect and\n# also depends on profile settings like ipv4.may-fail/ipv6.may-fail,\n# which affect when a profile is considered fully activated.\n# Check NetworkManager logs to find out why wait-online takes a certain\n# time.\n\nType=oneshot\nExecStart=/nix/store/r7fwxkxbgmwyrff5n03r9nchzskj59n9-networkmanager-1.40.16/bin/nm-online -s -q\nRemainAfterExit=yes\n\n# Set $NM_ONLINE_TIMEOUT variable for timeout in seconds.\n# Edit with `systemctl edit NetworkManager-wait-online`.\n#\n# Note, this timeout should commonly not be reached. If your boot\n# gets delayed too long, then the solution is usually not to decrease\n# the timeout, but to fix your setup so that the connected state\n# gets reached earlier.\nEnvironment=NM_ONLINE_TIMEOUT=60\n\n[Install]\nWantedBy=network-online.target\n\n# /nix/store/2ma3yvlqmj94dr6v24nkwmspgxfpfnmq-system-units/NetworkManager-wait-online.service.d/overrides.conf\n[Unit]\n\n[Service]\nEnvironment=\"LOCALE_ARCHIVE=/nix/store/g135laybfk1c7bm2zhrh7x6dv884qxal-glibc-locales-2.35-224/lib/locale/locale-archive\"\nEnvironment=\"PATH=/nix/store/l6jgwxkc3jhr029vfzfwzcy28iyckwsj-coreutils-9.1/bin:/nix/store/gn1s1s5z19cf0wiir2cd38jckcjc6kn6-findutils-4.9.0/bin:/nix/store/pvb117r7fhwb08717ks21a6y>\nEnvironment=\"TZDIR=/nix/store/z0kg1c0f8fx6r4rgg5bdy01lb2b9izqg-tzdata-2023a/share/zoneinfo\"\n\nExecStart=\nExecStart=/nix/store/r7fwxkxbgmwyrff5n03r9nchzskj59n9-networkmanager-1.40.16/bin/nm-online -q","author_login":"neilmayhew","author_association":"MEMBER","created_at":"2023-08-01T16:07:05+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1710860169","fragment_type":"issue_comment","sequence":33,"text":"Adding `tailscale0` to `networking.networkmanager.unmanaged` on my system that's currently experiencing this issue did not resolve the problem.","author_login":"lilyball","author_association":"MEMBER","created_at":"2023-09-07T22:52:59+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1905894217","fragment_type":"issue_comment","sequence":34,"text":"This issue has been mentioned on **NixOS Discourse**. There might be relevant details there:\n\n URL","author_login":"nixos-discourse","author_association":"NONE","created_at":"2024-01-23T12:02:53+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2056181168","fragment_type":"issue_comment","sequence":35,"text":"Not on the NixOS side; we'd have to fix it upstream I imagine.","author_login":"Atemu","author_association":"MEMBER","created_at":"2024-04-15T08:33:09+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2132051333","fragment_type":"issue_comment","sequence":36,"text":"Is the problem that `nm-online` with `-s` on an already-up system hangs (what this thread seems to think)?\n\nIs the problem that `NetworkManager-wait-online.service` _should_ not have `-s` (what upstream seems to think)?","author_login":"charmoniumQ","author_association":"CONTRIBUTOR","created_at":"2024-05-26T03:46:41+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2132268871","fragment_type":"issue_comment","sequence":37,"text":"I do not see any confusion about this from the upstream side; they did not claim that distros should not use `-s` at any point in the thread you linked. \n\nWe want a flag that does what `-s` is currently documented to supposedly do:\n\n -s | --wait-for-startup\n Wait for NetworkManager startup to complete, rather than waiting for network connectivity specifically. Startup is considered complete once NetworkManager has activated (or\n attempted to activate) every auto-activate connection which is available given the current network state. This corresponds to the moment when NetworkManager logs \"startup\n complete\". This mode is generally only useful at boot time. After startup has completed, nm-online -s will just return immediately, regardless of the current network state.\n\n There are various ways to affect when startup complete is reached. For details see NetworkManager-wait-online.service(8).\n\nThe manual even explicitly clarifies behaviour after bootup is complete.\n\nThis is precisely what we want but `nm-online` simply does not work as documented. Instead of returning immediately, it blocks indefinitely under certain conditions.","author_login":"Atemu","author_association":"MEMBER","created_at":"2024-05-26T15:54:10+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2134468184","fragment_type":"issue_comment","sequence":38,"text":"Is this related to kernel/firmware upgrade? This problem just occurred on my machine after a `nixos-rebuild switch`, manually invoking `nm-online -s` also waited 30s and timed out, but after a reboot I can no longer reproduce this, even with another `nixos-rebuild switch`. I updated my kernel and firmware in the first `nixos-rebuild switch`, updating from linux 6.8 to 6.9.","author_login":"inmaldrerah","author_association":"NONE","created_at":"2024-05-28T06:50:40+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2134547782","fragment_type":"issue_comment","sequence":39,"text":"I noted that `tailscaled.service` is restarted before `NetworkManager.service` and `NetworkManager-wait-online.service`.\n\nrestarting the following units: home-manager-inme.service, home-manager-root.service, nix-daemon.service, polkit.service, systemd-journald.service, tailscaled.service\nstarting the following units: NetworkManager-wait-online.service, NetworkManager.service, audit.service, bluetooth.service, kmod-static-nodes.service, logrotate-checkconf.service, mount-pstore.service, network-local-commands.service, network-setup.service, persist-\\x27-nix-persist-etc-machine\\x2did\\x27.service, persist-\\x27-nix-persist-home-inme-.bash_history\\x27.service, persist-\\x27-nix-persist-home-inme-.gitconfig\\x27.service, persist-\\x27-nix-persist-home-inme-.repo_.gitconfig.json\\x27.service, power-profiles-daemon.service, resolvconf.service, rtkit-daemon.service, systemd-hostnamed.service, systemd-modules-load.service, systemd-oomd.socket, systemd-sysctl.service, systemd-timesyncd.service, systemd-udevd-control.socket, systemd-udevd-kernel.socket, systemd-update-done.service, systemd-vconsole-setup.service, waydroid-container.service, wpa_supplicant.service, xray.service\n\nAlso confirmed in journalctl:\n \n\nMay 28 07:26:58 thinkbook-16-plus-nixos systemd[1]: Started Tailscale node agent.\n░░ Subject: A start job for unit tailscaled.service has finished successfully\n░░ Defined-By: systemd\n░░ Support: URL \n░░ \n░░ A start job for unit tailscaled.service has finished successfully.\n░░ \n░░ The job identifier is 3587.\n...\nMay 28 07:26:58 thinkbook-16-plus-nixos systemd[1]: Starting Network Manager...\n░░ Subject: A start job for unit NetworkManager.service has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░ \n░░ A start job for unit NetworkManager.service has begun execution.\n░░ \n░░ The job identifier is 3744.\n...\nMay 28 07:26:58 thinkbook-16-plus-nixos systemd[1]: Starting Network Manager Wait Online...\n░░ Subject: A start job for unit NetworkManager-wait-online.service has begun execution\n░░ Defined-By: systemd\n░░ Support: URL \n░░ \n░░ A start job for unit NetworkManager-wait-online.service has begun execution.\n░░ \n░░ The job identifier is 3743.\n\n \n\nAnd if I `systemctl stop tailscaled` before `nixos-rebuild switch`, `tailscaled.service` will be started after `NetworkManager.service` is started, and then `NetworkManager-wait-online.service` will exit gracefully.","author_login":"inmaldrerah","author_association":"NONE","created_at":"2024-05-28T07:41:15+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2134786890","fragment_type":"issue_comment","sequence":40,"text":"Big if true.\n\nThat feels like something that should be solvable using a few systemd Before/After directives in the right places.\n\nThough tailscaled.service already contains\n\nAfter=network-pre.target NetworkManager.service systemd-resolved.service\n\nIIRC `After` should be applied in reverse when stopping/restarting.","author_login":"Atemu","author_association":"MEMBER","created_at":"2024-05-28T09:44:10+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2148099221","fragment_type":"issue_comment","sequence":41,"text":"for me\n\nsh\nsudo nixos-rebuild boot --flake .#nixos\n\ninstead of \n\nsh\nsudo nixos-rebuild switch --flake .#nixos\n\ndid the trick..","author_login":"Vaisakhkm2625","author_association":"NONE","created_at":"2024-06-04T17:56:21+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2148222790","fragment_type":"issue_comment","sequence":42,"text":"@atemu could you challenge upstream about the `-s` flag and its documented behavior ?","author_login":"AkechiShiro","author_association":"CONTRIBUTOR","created_at":"2024-06-04T19:11:18+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2251302776","fragment_type":"issue_comment","sequence":43,"text":"Just to add a +1 to the tailscale discussion - I did not have this issue at all prior to installing tailscale, and now have it any time a rebuild needs to restart NetworkManager.","author_login":"jbury","author_association":"NONE","created_at":"2024-07-25T20:03:46+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2301321572","fragment_type":"issue_comment","sequence":44,"text":"It seems currently the switching script (the Perl version) doesn't have such mechanisms, neither does the Rust version. For the Perl script, it just `systemctl restart`s and then `systemctl start`s. Meanwhile the Rust version seems to be waiting all `restart` threads to finish before starting the `start` threads.\n\nA probable solution to this is to use combine these two commands into one `systemctl restart`, as stopped services will just get started on `systemctl restart`, and systemctl/systemd should be able (?) to resolve these Before/After relations if we invoke the command in one go. For the rust version, maybe removing that `block_on_jobs` and changing accordingly will be sufficient.\n\n—— in case this is really the cause of the problem.","author_login":"inmaldrerah","author_association":"NONE","created_at":"2024-08-21T07:22:00+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2367400297","fragment_type":"issue_comment","sequence":45,"text":"Thank you for this observation - adding `systemd.services.tailscaled.after = [\"NetworkManager-wait-online.service\"]` seem to have solved the issue for me","author_login":"howyay","author_association":"NONE","created_at":"2024-09-23T07:16:40+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2370126587","fragment_type":"issue_comment","sequence":46,"text":"I'd invite everyone to try this out on their machines and report back.\n\nIf this works, that'd be a quick and easy one-line patch to the tailscale NixOS module; fixing this for everyone.","author_login":"Atemu","author_association":"MEMBER","created_at":"2024-09-24T04:28:36+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2372605766","fragment_type":"issue_comment","sequence":47,"text":"Can confirm this fixes it. @Atemu +1 for including the fix in the tailscale module","author_login":"supermarin","author_association":"CONTRIBUTOR","created_at":"2024-09-25T00:09:10+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380648024","fragment_type":"issue_comment","sequence":48,"text":"Is this only fixed when using tailscaled, for users not using tailscaled, they should apply the workaround mentioned ? Is this really a good solution for new users?","author_login":"AkechiShiro","author_association":"CONTRIBUTOR","created_at":"2024-09-28T13:52:56+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380652796","fragment_type":"issue_comment","sequence":49,"text":"@AkechiShiro have you observed this without using Tailscale? \n\nAs far as I understand the issue is tied down to the combination of Tailscale firing up before NetworkManager and depending on it being online, ending up in a deadlock essentially","author_login":"supermarin","author_association":"CONTRIBUTOR","created_at":"2024-09-28T14:09:06+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380654768","fragment_type":"issue_comment","sequence":50,"text":"The same issue happened to me with wireguard in the past. I'll try the suggested fix","author_login":"pinpox","author_association":"MEMBER","created_at":"2024-09-28T14:15:34+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380657333","fragment_type":"issue_comment","sequence":51,"text":"Mind posting your configuration.nix in a gist?\nWe should be able to create a minimal flake and reproduce this with build-vm. Maybe cut out the VM's network access on purpose.\n\nWe should reopen this issue then if this happens outside of just Tailscale & NM","author_login":"supermarin","author_association":"CONTRIBUTOR","created_at":"2024-09-28T14:25:41+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380717758","fragment_type":"issue_comment","sequence":52,"text":"I do use Wireguard yes, so it could be I have the same issue as @pinpox","author_login":"AkechiShiro","author_association":"CONTRIBUTOR","created_at":"2024-09-28T15:55:30+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380724461","fragment_type":"issue_comment","sequence":53,"text":"Can anyone confirm whether they still experience this issue without using tailscaled?","author_login":"Atemu","author_association":"MEMBER","created_at":"2024-09-28T16:18:24+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2382734182","fragment_type":"issue_comment","sequence":54,"text":"As recently as two years ago, I had this issue without knowingly using tailscaled. (Posted to #59603.)\nSince then, I'm using the workaround from the OP and have lived happily ever since.\n\nThe problem is perhaps that tailscaled is not *the only* service that activates `NetworkManager-wait-online.service`, so it doesn't make sense to fix this issue in tailscaled.\n\nPerhaps this issue has since been fixed by an unrelated patch upstream (however that would happen), but I'm not optimistic. Let me try to get rid of the workaround and see if it is still an issue.","author_login":"sgraf812","author_association":"CONTRIBUTOR","created_at":"2024-09-30T10:29:33+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2383097130","fragment_type":"issue_comment","sequence":55,"text":"Thanks @sgraf812 I may try to reach out to systemd/udev maintainers about issue #182449 hopefully we can nail this issue down once and for all","author_login":"AkechiShiro","author_association":"CONTRIBUTOR","created_at":"2024-09-30T12:48:58+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2383222208","fragment_type":"issue_comment","sequence":56,"text":"We did receive an answer from Poettering but I don't know how to properly answer back, if anyone more experienced could pitch in : URL","author_login":"AkechiShiro","author_association":"CONTRIBUTOR","created_at":"2024-09-30T13:37:55+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2412874568","fragment_type":"issue_comment","sequence":57,"text":"This issue has been mentioned on **NixOS Discourse**. There might be relevant details there:\n\n URL","author_login":"nixos-discourse","author_association":"NONE","created_at":"2024-10-15T04:31:59+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2417385903","fragment_type":"issue_comment","sequence":58,"text":"@Atemu ran into it as well, but already had a running system with tailscale up. Manually shut down tailscale, and rebuild succeeded (and tailscale was back up). Tested with several rebuilds and restarts, works ok so far","author_login":"supermarin","author_association":"CONTRIBUTOR","created_at":"2024-10-16T16:49:38+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2417420750","fragment_type":"issue_comment","sequence":59,"text":"An idea I had on this is that we could perhaps hack around this using a systemd unit that `Conflicts` the units which appear to block nm-online.target such as tailscaled. It'd be `Require`d by the nm-online target and we'd then have another target which wants all those units and is wanted by the network-online target but `After` the nm-online target.","author_login":"Atemu","author_association":"MEMBER","created_at":"2024-10-16T17:04:56+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2434493691","fragment_type":"issue_comment","sequence":60,"text":"Maybe this would help? (I closed because earlier I thought it was obsolete)\n\nAnd I've made a small flake version for testing purpose: URL \n\nAt least last time I used this, I didn't have to `systemd stop tailscaled` beforehand when tailscale was updated.","author_login":"inmaldrerah","author_association":"NONE","created_at":"2024-10-24T07:21:29+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2436052017","fragment_type":"issue_comment","sequence":61,"text":"I can try testing with it.\nThink the repro steps are:\n1. Have a system with Tailscale and NM-wait-online \n2. Disable nm-wait-online with the hack above\n3. Put nm-wait-online back in\n\nOn the next rebuild it should get stuck. I'll try this later today and report back if it reproduces consistently. Note: the Tailscale fix was backported to 24.05 so need to pin nixpkgs to a commit prior to that","author_login":"supermarin","author_association":"CONTRIBUTOR","created_at":"2024-10-24T18:15:53+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2517303641","fragment_type":"issue_comment","sequence":62,"text":"Also still experiencing this with tailscaled on nixpkgs unstable `bc947f541ae55e999ffdb4013441347d83b00feb` (I think that's the right sha.)\n\nIf I stop the tailscaled unit I can then rebuild OK, and the service comes back up again.","author_login":"JonnieCache","author_association":"NONE","created_at":"2024-12-04T13:09:36+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541381489","fragment_type":"issue_comment","sequence":63,"text":"I'm still running into this problem. However, I'm not using NetworkManager, but systemd-networkd. Adding the following line to my config seemed to fix things:\n\nnix\nsystemd.services.tailscaled.after = [\"systemd-networkd-wait-online.service\"];\n\nPerhaps we should also add that line to the tailscale service definition?","author_login":"Munksgaard","author_association":"CONTRIBUTOR","created_at":"2024-12-13T12:42:16+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2550110662","fragment_type":"issue_comment","sequence":64,"text":"Well, I haven't been using it for a while as I am no longer experiencing this problem on the unstable branch until `a73246e2eef4c6ed172979932bc80e1404ba2d56`. Which commit are you on now?\n\nThat flake can be used by making an overlay over nixpkgs, disable `system.switch.enable` and enable `system.switch.enableNg` in the `configuration.nix`.","author_login":"inmaldrerah","author_association":"NONE","created_at":"2024-12-18T01:52:08+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2563508211","fragment_type":"issue_comment","sequence":65,"text":"This issue has been mentioned on **NixOS Discourse**. There might be relevant details there:\n\n URL","author_login":"nixos-discourse","author_association":"NONE","created_at":"2024-12-27T09:33:50+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2677466605","fragment_type":"issue_comment","sequence":66,"text":"Are the only current workaround is:\n\nnix\n# /etc/nixos/configuration.nix\nsystemd.network.wait-online.enable = false;","author_login":"afifurrohman-id","author_association":"NONE","created_at":"2025-02-24T05:26:54+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2731401156","fragment_type":"issue_comment","sequence":67,"text":"Hitting the same issue here. Adding `systemd.services.tailscaled.after = [ \"systemd-networkd-wait-online.service\" ];` fixed it for me too.","author_login":"ndarilek","author_association":"NONE","created_at":"2025-03-18T02:09:40+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2828637422","fragment_type":"issue_comment","sequence":68,"text":"`systemd.services.tailscaled.after = [\"NetworkManager-wait-online.service\"]` stopped working for me today; just had a switch fail on me despite verifying that NetworkManager-wait-online.service was listed in the systemd override file. The earlier workaround removing `-s` from the ExecStart continues to work fine.\n\nI'm highly suspicious that this has to do with NetworkManager being updated; I'm not sure what dependency caused a rebuild in this particular case, but the NetworkManager hash did change for me between generations. That might be the trigger to actually reproducing this.","author_login":"esibun","author_association":"NONE","created_at":"2025-04-24T19:20:30+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3001847402","fragment_type":"issue_comment","sequence":69,"text":"I am also hitting this issue on `25.05` despite using\n\nnix\n systemd.services.NetworkManager-wait-online.enable = false;\n systemd.services.tailscaled.after = [ \"systemd-networkd-wait-online.service\" ];","author_login":"ahydronous","author_association":"NONE","created_at":"2025-06-24T21:01:16+08:00","repo_name":"NixOS/nixpkgs","issue_id":1293615234,"issue_number":180175,"issue_url":"https://github.com/NixOS/nixpkgs/issues/180175","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0186","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"1.4 Hangs server on Version checking?","query_context":"Recently updated to 1.4 and now the server hangs during Neoforge version checking stage. Reverting this mod to the last version fixed the issue.","known_context_document_ids":["gh_issue_2781486587"],"reference_answer":"You need to be more specific than \"my save game was corrupted\". Can you not enter your world anymore with a warning about safe mode or are there things like chunk errors?","answer_document_id":"gh_comment_2581445202","silver_evidence_path":["gh_comment_2585702468","gh_issue_2778924440","gh_comment_2581445202"],"evidence_issue_ids":[2781486587,2778924440],"source_repo_name":"Apollounknowndev/lithostitched","source_issue_id":2781486587,"source_issue_number":26,"source_issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/26","target_repo_name":"Apollounknowndev/lithostitched","target_issue_id":2778924440,"target_issue_number":23,"target_issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","reference_anchor_document_id":"gh_comment_2585702468","reference_answer_author":"Apollounknowndev","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2222,"target_answer_overlap":0.125},"issue_created_at":"2025-01-11T01:12:10+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2781486587","fragment_type":"issue_description","sequence":0,"text":"1.4 Hangs server on Version checking\nRecently updated to 1.4 and now the server hangs during Neoforge version checking stage. Reverting this mod to the last version fixed the issue.","author_login":"Skypony94","author_association":"NONE","created_at":"2025-01-11T01:12:10+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2781486587,"issue_number":26,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/26","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2585088069","fragment_type":"issue_comment","sequence":1,"text":"Here was the last log before I reverted back to 1.3.10\ndebug-5.log.gz","author_login":"Skypony94","author_association":"NONE","created_at":"2025-01-11T05:54:08+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2781486587,"issue_number":26,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/26","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585702468","fragment_type":"issue_comment","sequence":2,"text":"I take a look at the log it's the same as #23. \nInstruction: Wait for new update from CTOV!","author_login":"ChoiceTheorem","author_association":"NONE","created_at":"2025-01-12T11:53:03+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2781486587,"issue_number":26,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/26","linked_issue_ids":[2778924440],"is_known_query_context":false},{"document_id":"gh_issue_2778924440","fragment_type":"issue_description","sequence":0,"text":"CTOV incompatible with 1.4\nupdated today adn minecraft suddenly said my save game was corrupted. did some trial and error and found out it was the new version of litho that caused this","author_login":"tenshiiclone","author_association":"NONE","created_at":"2025-01-09T23:04:15+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2581445202","fragment_type":"issue_comment","sequence":1,"text":"You need to be more specific than \"my save game was corrupted\". Can you not enter your world anymore with a warning about safe mode or are there things like chunk errors?","author_login":"Apollounknowndev","author_association":"OWNER","created_at":"2025-01-09T23:30:13+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2581584573","fragment_type":"issue_comment","sequence":2,"text":"I had a the same thing happen to me. Wouldn't load world saying it was corrupted, going back to previous version fixed the issue.\nIt also caused Minecraft to crash completely when clicking on Singleplayer with no saved worlds or deleting the last world in the single player list. Here are some crash reports for both scenarios.\ncrash-2025-01-09_19.53.40-client.txt\ncrash-2025-01-09_19.57.29-client.txt","author_login":"Ossirian1","author_association":"NONE","created_at":"2025-01-10T02:00:01+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2581603144","fragment_type":"issue_comment","sequence":3,"text":"CTOV is incompatible with Lithostitched 1.4 until they update to a new format for some internal files.","author_login":"Apollounknowndev","author_association":"OWNER","created_at":"2025-01-10T02:11:31+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2581861820","fragment_type":"issue_comment","sequence":4,"text":"Yup, I can confirm this crash. I have been trying to fix this problem for 2 hours, and found out that \nWhen I disabled (lithostitched-neoforge-1.21.1-1.4) and I revert to v1.3.10 the crash does not happen.\n\nSo because my particular world depends on the CTOV, I will revert back to v1.3.10 of Lithostitched,\nuntil CTOV updates their mod. 2 hours of frustrations trying to figure out what it was. My head hurts. 🤦‍♂️\n\nLithostitched Crash","author_login":"SirTwsted","author_association":"NONE","created_at":"2025-01-10T06:17:40+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2583722745","fragment_type":"issue_comment","sequence":5,"text":"A page on the wiki has now been made for that. It's a small change for consistency with other worldgen modifiers and I have no plans for future breaking changes right now.","author_login":"Apollounknowndev","author_association":"OWNER","created_at":"2025-01-10T19:23:56+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585939090","fragment_type":"issue_comment","sequence":6,"text":"CTOV has updated to Lithostitched 1.4. Issues with other mods not working with 1.4 should be moved to their own issue page(s).","author_login":"Apollounknowndev","author_association":"OWNER","created_at":"2025-01-12T22:16:08+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585983239","fragment_type":"issue_comment","sequence":7,"text":"@Apollounknowndev Why did you delete my comment? I was simply wondering if your project follows semantic versioning so I can watch out for these breaking changes in the future.","author_login":"nnmrts","author_association":"NONE","created_at":"2025-01-13T00:18:26+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2586031849","fragment_type":"issue_comment","sequence":8,"text":"Semver will be followed going forwards. In the future, please keep unrelated questions in their own reports.","author_login":"Apollounknowndev","author_association":"OWNER","created_at":"2025-01-13T01:40:12+08:00","repo_name":"Apollounknowndev/lithostitched","issue_id":2778924440,"issue_number":23,"issue_url":"https://github.com/Apollounknowndev/lithostitched/issues/23","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0187","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Hervorhebungen ausschalten?","query_context":"Wir bräuchten für die Hervorhebungen eine \"Ausschalten\"-Möglichkeit. Unsere Idee ist es, beim Auswählen der zu hervohebenden Stelle (z.B: beim Trigger) im Dropdown-Menü noch eine \"Hervorhebungen ausschalten\"-Option hinzuzufügen.","known_context_document_ids":["gh_issue_2299779782"],"reference_answer":"In Player 1.28.3 habe ich den gegenteiligen Wunsch implementiert!\nSeid ihr sicher, dass ihr wieder zurück wollt?","answer_document_id":"gh_comment_2127006487","silver_evidence_path":["gh_comment_2144448694","gh_issue_2299775052","gh_comment_2127006487"],"evidence_issue_ids":[2299779782,2299775052],"source_repo_name":"iqb-berlin/verona-modules-aspect","source_issue_id":2299779782,"source_issue_number":646,"source_issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/646","target_repo_name":"iqb-berlin/verona-modules-aspect","target_issue_id":2299775052,"target_issue_number":645,"target_issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/645","reference_anchor_document_id":"gh_comment_2144448694","reference_answer_author":"jojohoch","reference_answer_author_association":"COLLABORATOR","quality_score":70.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1,"target_answer_overlap":0.0},"issue_created_at":"2024-05-16T08:56:38+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_2299779782","fragment_type":"issue_description","sequence":0,"text":"Hervorhebungen ausschalten\nWir bräuchten für die Hervorhebungen eine \"Ausschalten\"-Möglichkeit. Unsere Idee ist es, beim Auswählen der zu hervohebenden Stelle (z.B: beim Trigger) im Dropdown-Menü noch eine \"Hervorhebungen ausschalten\"-Option hinzuzufügen.","author_login":"helfjama","author_association":"NONE","created_at":"2024-05-16T08:56:38+08:00","repo_name":"iqb-berlin/verona-modules-aspect","issue_id":2299779782,"issue_number":646,"issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/646","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2114725720","fragment_type":"issue_comment","sequence":1,"text":"Ich habe ein älteres Ticket gefunden, dass sehr ähnlich klingt: #516\nKann eins davon zu?","author_login":"rhenck","author_association":"COLLABORATOR","created_at":"2024-05-16T09:47:26+08:00","repo_name":"iqb-berlin/verona-modules-aspect","issue_id":2299779782,"issue_number":646,"issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2144448694","fragment_type":"issue_comment","sequence":2,"text":"Ja, ich habe das alte Ticket geschlossen. Dieses Ticket hier hängt aber auch mit URL zusammen - beide Tickets sollten am besten zusammen bearbeitet werden.","author_login":"helfjama","author_association":"NONE","created_at":"2024-06-03T07:16:28+08:00","repo_name":"iqb-berlin/verona-modules-aspect","issue_id":2299779782,"issue_number":646,"issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/646","linked_issue_ids":[2299775052],"is_known_query_context":false},{"document_id":"gh_issue_2299775052","fragment_type":"issue_description","sequence":0,"text":"mehrere Hervorhebungen gleichzeitig\nWäre es möglich bei Triggern und normalen Hervorhebungen die Möglichkeit zu geben, mehrere Hervorhebungen gleichzeitig zu aktivieren?","author_login":"helfjama","author_association":"NONE","created_at":"2024-05-16T08:54:38+08:00","repo_name":"iqb-berlin/verona-modules-aspect","issue_id":2299775052,"issue_number":645,"issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2127006487","fragment_type":"issue_comment","sequence":1,"text":"In Player 1.28.3 habe ich den gegenteiligen Wunsch implementiert!\nSeid ihr sicher, dass ihr wieder zurück wollt?","author_login":"jojohoch","author_association":"COLLABORATOR","created_at":"2024-05-23T12:39:20+08:00","repo_name":"iqb-berlin/verona-modules-aspect","issue_id":2299775052,"issue_number":645,"issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2144450229","fragment_type":"issue_comment","sequence":2,"text":"Jein - also ja, wir sind uns sicher, dass wir es wollen, aber nur wenn wir weiterhin eine Funktionalität haben auch mit Triggern Hervorhebungen zu überschreiben / auszuschalten (siehe URL","author_login":"helfjama","author_association":"NONE","created_at":"2024-06-03T07:17:21+08:00","repo_name":"iqb-berlin/verona-modules-aspect","issue_id":2299775052,"issue_number":645,"issue_url":"https://github.com/iqb-berlin/verona-modules-aspect/issues/645","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0188","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"New re-verify endpoint specifications?","query_context":"We often need to fix contracts data due to misaligned data. Currently, we lack a generic method to replace an existing misaligned contract in our database, so we’ve been forced to create custom scripts to address specific issues (#1974).\n\nIn this issue, I propose introducing a new private endpoint—callable only by the Sourcify instance maintainer—that allows replacing an existing contract. To improve the performance of this endpoint, we can optimize it by skipping compilation and RPC-based on-chain data fetching, instead relying on information already stored in the database. Two properties, getCompilationFromDatabase and getOnchainDataFromDatabase, can be used to specify that the data should be retrieved from the database.\n\n### `/private/replace-contract`\n\n### Parameters\n- **chainId** \n- **address** \n- **creation_txhash**\n- **getCompilationFromDatabase: bool**. If set to true it skips compilation and queries compilation information from the database\n- **[if(getCompilationFromDatabase==false)] jsonInput**: optionally pass jsonInput, if it's passed it uses the passed one. if it's not passed it uses the jsonInput stored in the database (but it will recompile to get the jsonOutput)\n- **getOnchainDataFromDatabase: bool**. If set to true it skips calling rpc to find onchain information and queries onchain information from the database\n\n### Process\n1. fetch onchain information from the database if specified in the request's parameter, otherwise call the rpc\n2. fetch compiled information from the database if specified in the request's parameter, otherwise compile the contract\n3. call lib-sourcify verification flow\n4. if successful \n 4.1. delete existing `sourcify_match` and all linked rows in foreign tables, only if those rows are dangling. If there are non-dangling rows then return an error and we manually have to evaluate the case.\n 4.2. insert the new verification\n5. if not successful, return an error\n\n### lib-sourcify refactoring\n\nSuggestion from @manuelwedler: we could implement a new class in lib-sourcify `DatabaseCompilation` that follows the `AbstractCompilation` interface and gets the compiled bytecode and compilation artifacts as constructor arguments. That could be useful for skipping the compilation and avoiding the monkey patching we do at the current `upgradeContract` endpoint.\n\nWe an potentially do something similar for `SourcifyChain`.","known_context_document_ids":["gh_issue_3079463986"],"reference_answer":"During a recent call, we raised the question of what happens to contracts verified with a bugged Sourcify version when the same contract is later inserted with a major (correct) version. Someone suggested periodically pruning the database, but we realized this could be a problem for our Parquet exports: we cannot edit parquet exports already created, so bugged sourcify contracts will be included in the exports.\n\nHowever, I don’t think this will actually be a problem. When importing contracts from a Parquet export, users can filter out contracts verified with bugged Sourcify versions, or replace them once a version with a major fix appears in a subsequent export file.\n\nThe open questions are:\n* Does it make sense to prune?\n* When should we prune?\n* Should we also prune the VerA database?","answer_document_id":"gh_comment_2900246047","silver_evidence_path":["gh_comment_2900166621","gh_issue_3002665079","gh_comment_2900246047"],"evidence_issue_ids":[3079463986,3002665079],"source_repo_name":"ethereum/sourcify","source_issue_id":3079463986,"source_issue_number":2166,"source_issue_url":"https://github.com/ethereum/sourcify/issues/2166","target_repo_name":"ethereum/sourcify","target_issue_id":3002665079,"target_issue_number":2089,"target_issue_url":"https://github.com/ethereum/sourcify/issues/2089","reference_anchor_document_id":"gh_comment_2900166621","reference_answer_author":"marcocastignoli","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2444,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1636},"issue_created_at":"2025-05-21T08:54:21+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_3079463986","fragment_type":"issue_description","sequence":0,"text":"New re-verify endpoint specifications\nWe often need to fix contracts data due to misaligned data. Currently, we lack a generic method to replace an existing misaligned contract in our database, so we’ve been forced to create custom scripts to address specific issues (#1974).\n\nIn this issue, I propose introducing a new private endpoint—callable only by the Sourcify instance maintainer—that allows replacing an existing contract. To improve the performance of this endpoint, we can optimize it by skipping compilation and RPC-based on-chain data fetching, instead relying on information already stored in the database. Two properties, getCompilationFromDatabase and getOnchainDataFromDatabase, can be used to specify that the data should be retrieved from the database.\n\n### `/private/replace-contract`\n\n### Parameters\n- **chainId** \n- **address** \n- **creation_txhash**\n- **getCompilationFromDatabase: bool**. If set to true it skips compilation and queries compilation information from the database\n- **[if(getCompilationFromDatabase==false)] jsonInput**: optionally pass jsonInput, if it's passed it uses the passed one. if it's not passed it uses the jsonInput stored in the database (but it will recompile to get the jsonOutput)\n- **getOnchainDataFromDatabase: bool**. If set to true it skips calling rpc to find onchain information and queries onchain information from the database\n\n### Process\n1. fetch onchain information from the database if specified in the request's parameter, otherwise call the rpc\n2. fetch compiled information from the database if specified in the request's parameter, otherwise compile the contract\n3. call lib-sourcify verification flow\n4. if successful \n 4.1. delete existing `sourcify_match` and all linked rows in foreign tables, only if those rows are dangling. If there are non-dangling rows then return an error and we manually have to evaluate the case.\n 4.2. insert the new verification\n5. if not successful, return an error\n\n### lib-sourcify refactoring\n\nSuggestion from @manuelwedler: we could implement a new class in lib-sourcify `DatabaseCompilation` that follows the `AbstractCompilation` interface and gets the compiled bytecode and compilation artifacts as constructor arguments. That could be useful for skipping the compilation and avoiding the monkey patching we do at the current `upgradeContract` endpoint.\n\nWe an potentially do something similar for `SourcifyChain`.","author_login":"marcocastignoli","author_association":"MEMBER","created_at":"2025-05-21T08:54:21+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2897693734","fragment_type":"issue_comment","sequence":1,"text":"Note that the `verification_jobs` table references the `verified_contracts` table. Due to that, you won't have any dangling rows after deleting a `sourcify_match` (for contracts verified with API v2).","author_login":"manuelwedler","author_association":"CONTRIBUTOR","created_at":"2025-05-21T12:00:19+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2898350174","fragment_type":"issue_comment","sequence":2,"text":"Should `DatabaseCompilation` be in the lib-sourcify or rather in sourcify-server next to this private endpoint, but following the `AbstractCompilation` spec?","author_login":"kuzdogan","author_association":"MEMBER","created_at":"2025-05-21T15:19:25+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2898696940","fragment_type":"issue_comment","sequence":3,"text":"Imo, it could also be in lib-sourcify. This functionality might also be interesting for others.","author_login":"manuelwedler","author_association":"CONTRIBUTOR","created_at":"2025-05-21T17:19:04+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2898733231","fragment_type":"issue_comment","sequence":4,"text":"Currently, we have this contraint on `verification_jobs` table:\n\nCONSTRAINT verification_jobsverif_ied_contract_id_fk FOREIGN KEY (verified_contract_id) REFERENCES verified_contracts(id) ON DELETE RESTRICT ON UPDATE RESTRICT\n\nThis means it will prevent to delete the `verified_contracts` row, if it is still referenced inside `verification_jobs`. \nGenerally, I think it is fine when the `verification_jobs` row does not reference any `verified_contract`, but we would need to adapt the constraint.\n\nI also wonder what we do with VerA in this endpoint. I guess this is only for the Sourcify database. It still feels a bit inconsistent to not update VerA to me.","author_login":"manuelwedler","author_association":"CONTRIBUTOR","created_at":"2025-05-21T17:35:15+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2900166621","fragment_type":"issue_comment","sequence":5,"text":"Mmmh, so you’re thinking of a generic `ConstructorCompilation` (meaning we pass everything through the constructor), not something specifically tailored to our database? In that case, I think it makes sense.\n\nMy original idea—which I now realize I didn’t actually write down—was to have a `DatabaseCompilation` built specifically for our database. That way, we could just pass the address and chain, and it would fill in all the details for us. The two proposals are actually compatible by having a `DatabaseCompilation.createCompilation` similar to `SolidityMetadataContract.createCompilation` that creates a `ConstructorCompilation`.\n \n\nI think this falls under the topic of #2089","author_login":"marcocastignoli","author_association":"MEMBER","created_at":"2025-05-22T07:15:14+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[3002665079],"is_known_query_context":false},{"document_id":"gh_comment_2900187194","fragment_type":"issue_comment","sequence":6,"text":"Exactly. Just take a standard json output as constructor parameter. We can already easily generate the standard json output from the database.\n \n\nI agree. That also makes sense.\n \n\nYes, we would need the verifier version column. Still, wanted to raise that topic. Would you update the endpoint once we have the verifier version, and add the functionality to upgrade contracts in VerA?","author_login":"manuelwedler","author_association":"CONTRIBUTOR","created_at":"2025-05-22T07:25:03+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[3002665079],"is_known_query_context":false},{"document_id":"gh_comment_2901048562","fragment_type":"issue_comment","sequence":7,"text":"I don't like the name `DatabaseCompilation`, esp. for lib-sourcify. What we want to do is kind of \"mocking\" the `compile()` (so maybe `MockCompilation` ?) method of the `...Compilation` classes, given we have a compiler output. This compiler output can come from the database or anywhere. In our private endpoint this would be fetched from the DB and formatted accordingly. \n\nSimilarly the \"`MockVerification`\" would have its bytecodes and other onchain info filled when constructed, but will have the same interface as `Verification`. We're probably talking about the same thing but just wanted to make it clear.","author_login":"kuzdogan","author_association":"MEMBER","created_at":"2025-05-22T12:27:43+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2935464137","fragment_type":"issue_comment","sequence":8,"text":"Yeah actually let's make it a generic compilation with required fields (we should do some validation), and it should be straightforward to format an output from the DB to that generic format.","author_login":"kuzdogan","author_association":"MEMBER","created_at":"2025-06-03T14:11:35+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2941458128","fragment_type":"issue_comment","sequence":9,"text":"Yes, totally right. We should not change the order of bytecode fetching, then compiling. I missed that when I made my proposal.\n\nThe only solution I see to this is also separating bytecode fetching into its own class as suggested in URL We could keep the order of first bytecode fetching, second compiling, and only pass the results of both to the `Verification` class.\n\nThe other points of your comment seem manageable / fine to me.\n\nNevertheless, my proposal seems like a quite big refactoring. I tend to say just go with the original idea. If you still see value in my new proposal, we can still target it later. Otherwise, just scrap it.","author_login":"manuelwedler","author_association":"CONTRIBUTOR","created_at":"2025-06-04T21:04:33+08:00","repo_name":"ethereum/sourcify","issue_id":3079463986,"issue_number":2166,"issue_url":"https://github.com/ethereum/sourcify/issues/2166","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3002665079","fragment_type":"issue_description","sequence":0,"text":"Find a solution for UNIQUE constraint blocking re‑verification of contracts originally verified by a buggy Sourcify server\nCopying the comment: URL \n\n### Root Cause\n- Our general Vera policy is “**INSERT only, never UPDATE**”. \n- We didn’t anticipate a scenario where a **newer** verifier could succeed on a contract that an **older** version failed.\n\n### Current state of the affected contracts\n- The values in `verified_contracts.compilation_id` and `verified_contracts.deployment_id` are correct. \n- The old, bugged Sourcify server simply couldn’t find the creation match.\n\n### Problem\n- When we re‑verify these contracts with the latest Sourcify's server, it tries to INSERT the new `verified_contracts` row (with the creation match) with the same `compilation_id` and `deployment_id`. \n- A **UNIQUE** constraint on `(compilation_id, deployment_id)` prevents this, so the upgrade—fails.\n\n### Proposed solution\n1. **Add** a new column: \n \nsql\n ALTER TABLE verified_contracts\n ADD COLUMN verifier_version TEXT NOT NULL;\n \n \n2. Extend the UNIQUE constraint to include this column.\n3. Populate verifier_version with, for example, \"sourcify@1.0.0\" (or similar).\n\nThis lets us INSERT a fresh row whenever a newer verifier succeeds on a previously failed contract.","author_login":"marcocastignoli","author_association":"MEMBER","created_at":"2025-04-17T14:25:43+08:00","repo_name":"ethereum/sourcify","issue_id":3002665079,"issue_number":2089,"issue_url":"https://github.com/ethereum/sourcify/issues/2089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2842274494","fragment_type":"issue_comment","sequence":1,"text":"Well, looking at this again why don't we add \"runtime_match\" \"creation_match\" \"runtime_metadata_match\" \"creation_metadata_match\" to the unique constraint?","author_login":"kuzdogan","author_association":"MEMBER","created_at":"2025-04-30T14:57:21+08:00","repo_name":"ethereum/sourcify","issue_id":3002665079,"issue_number":2089,"issue_url":"https://github.com/ethereum/sourcify/issues/2089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2842282212","fragment_type":"issue_comment","sequence":2,"text":"It's not enough to add these fields. We would have to add also transformations to the constraints (since they can change between different sourcify versions), I don't even know if it's possible and if it makes sense...","author_login":"marcocastignoli","author_association":"MEMBER","created_at":"2025-04-30T14:59:54+08:00","repo_name":"ethereum/sourcify","issue_id":3002665079,"issue_number":2089,"issue_url":"https://github.com/ethereum/sourcify/issues/2089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2850665744","fragment_type":"issue_comment","sequence":3,"text":"I think I prefer the first option because keeping the \"INSERT only, never UPDATE\" policy can gibe us some benefit for the parquet export. We could work on that for having append only export.\n\nThe issue I see with the verifier version column is that we need to check all columns and only insert if something changed (apart from the verifier version).","author_login":"manuelwedler","author_association":"CONTRIBUTOR","created_at":"2025-05-05T11:13:57+08:00","repo_name":"ethereum/sourcify","issue_id":3002665079,"issue_number":2089,"issue_url":"https://github.com/ethereum/sourcify/issues/2089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2900246047","fragment_type":"issue_comment","sequence":4,"text":"During a recent call, we raised the question of what happens to contracts verified with a bugged Sourcify version when the same contract is later inserted with a major (correct) version. Someone suggested periodically pruning the database, but we realized this could be a problem for our Parquet exports: we cannot edit parquet exports already created, so bugged sourcify contracts will be included in the exports.\n\nHowever, I don’t think this will actually be a problem. When importing contracts from a Parquet export, users can filter out contracts verified with bugged Sourcify versions, or replace them once a version with a major fix appears in a subsequent export file.\n\nThe open questions are:\n* Does it make sense to prune?\n* When should we prune?\n* Should we also prune the VerA database?","author_login":"marcocastignoli","author_association":"MEMBER","created_at":"2025-05-22T07:48:51+08:00","repo_name":"ethereum/sourcify","issue_id":3002665079,"issue_number":2089,"issue_url":"https://github.com/ethereum/sourcify/issues/2089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2901067765","fragment_type":"issue_comment","sequence":5,"text":"We haven't commited ourselves to maintaining immutable (append only) databases yet. It was just a suggestion. \n\nIMO pruning at this stage makes sense. I wouldn't expect users to be able to correctly filter out contracts with buggy Sourcify versions. \n\nSince our DB is not extremely large at the moment, it should be ok to modify data. It would require people to re-download everything and re-import, if they want to instantiate a DB.\n\nWe should regardless have an idea to how long it takes to download everything and to initialize a DB instance. We also need instructions and maybe a script for people to do this. The issue already exists: #2038 Maybe something for the next sprint.\n\nFinally, I think over time we can find a compromise between a mutable database vs. an append only DB. We should look how people in general such a problem. Maybe some kind of versioning of the exports etc.","author_login":"kuzdogan","author_association":"MEMBER","created_at":"2025-05-22T12:34:39+08:00","repo_name":"ethereum/sourcify","issue_id":3002665079,"issue_number":2089,"issue_url":"https://github.com/ethereum/sourcify/issues/2089","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0189","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"TypeError in diff view of viewvc 1.3.0 master if hr_intraline is set?","query_context":"**_Edit 2_: looks like the exceptions are thrown only when hr_intraline is set.**\n\nRecently, we upgraded a Subversion installation to 1.14.1 on a CentOS 7 server.\n\nFrom what we can tell, Subversion 1.14.1 no longer has bindings for Python 2 meaning we had to switch to the development branch (\"master\") of ViewVC 1.3.0 at commit f97ea61 of Dec 1, 2021.\n\nEverything appears to be working except the \"diff\" views where we're seeing the following error when checking the changes to a text file using a \"colored diff\":\n\nAn Exception Has Occurred\nPython Traceback\nTypeError: a bytes-like object is required, not 'str'\n\nA \"unidiff\" is also broken but the error is different (the reverse?):\n\nAn Exception Has Occurred\nPython Traceback\nTypeError: must be str, not bytes\n\nDiff views in \"context diff\" and \"side by side\" don't throw an exception but are much harder to parse by a person, of course.\n\nPygments is installed:\n\n# pip3 show Pygments | grep Version\nVersion: 2.2.0\n#\n\nWe don't know if this is a known issue with ViewVC 1.3.0 or if we have a missing dependency.\n\n_Edit 1_: below are the system details as requested by @futatuki.\nCentOS 7.9.2009, Apache 2.4.6, Python 3.6.8, Pygments 2.2.0, GNU diffutils 3.3, Subversion 1.14.1\n\n[general]\nroot_parents = /var/svn/repos: svn\n[utilities]\ndiff = /usr/bin/diff\n[options]\nallowed_views = annotate, diff, markup, roots, tar\nauthorizer = svnauthz\ncustom_log_formatting =\n bug ([0-9]+) : URL \n ([A-Z]+\\-[0-9]+) : URL \n \\[([3-7]{1}[0-9]{3})\\] : URL \n (rev|revs)\\.\\s*([0-9]+) : URL \ndefault_file_view = markup\nmax_filesize_kbytes = 1024\nlog_sort = none\nhr_intraline = 1\ntemplate_dir = templates/classic\ndocroot = /viewvc/static\nenable_syntax_coloration = 1\ntabsize = 0\nlog_pagesize = 75\nlog_pagesextra = 10\n[templates]\n[cvsdb]\n[vhosts]\n[authz-forbidden]\n[authz-forbiddenre]\n[authz-svnauthz]\nauthzfile = /var/svn/etc/svnaccessfile","known_context_document_ids":["gh_issue_1098073178"],"reference_answer":"Backporting PR #297 is easy, but backporting PR #296 is troublesome because of `_diff_fp` implementation using `popen` API. Of course, we can backport whole `_diff_fp` implementation using subprocess.Popen, though.","answer_document_id":"gh_comment_1281926583","silver_evidence_path":["gh_comment_1275582166","gh_issue_1405143857","gh_comment_1281926583"],"evidence_issue_ids":[1098073178,1405143857],"source_repo_name":"viewvc/viewvc","source_issue_id":1098073178,"source_issue_number":275,"source_issue_url":"https://github.com/viewvc/viewvc/issues/275","target_repo_name":"viewvc/viewvc","target_issue_id":1405143857,"target_issue_number":293,"target_issue_url":"https://github.com/viewvc/viewvc/issues/293","reference_anchor_document_id":"gh_comment_1275582166","reference_answer_author":"futatuki","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.1111,"target_answer_overlap":0.0},"issue_created_at":"2022-01-10T16:04:35+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1098073178","fragment_type":"issue_description","sequence":0,"text":"TypeError in diff view of viewvc 1.3.0 master if hr_intraline is set\n**_Edit 2_: looks like the exceptions are thrown only when hr_intraline is set.**\n\nRecently, we upgraded a Subversion installation to 1.14.1 on a CentOS 7 server.\n\nFrom what we can tell, Subversion 1.14.1 no longer has bindings for Python 2 meaning we had to switch to the development branch (\"master\") of ViewVC 1.3.0 at commit f97ea61 of Dec 1, 2021.\n\nEverything appears to be working except the \"diff\" views where we're seeing the following error when checking the changes to a text file using a \"colored diff\":\n\nAn Exception Has Occurred\nPython Traceback\nTypeError: a bytes-like object is required, not 'str'\n\nA \"unidiff\" is also broken but the error is different (the reverse?):\n\nAn Exception Has Occurred\nPython Traceback\nTypeError: must be str, not bytes\n\nDiff views in \"context diff\" and \"side by side\" don't throw an exception but are much harder to parse by a person, of course.\n\nPygments is installed:\n\n# pip3 show Pygments | grep Version\nVersion: 2.2.0\n#\n\nWe don't know if this is a known issue with ViewVC 1.3.0 or if we have a missing dependency.\n\n_Edit 1_: below are the system details as requested by @futatuki.\nCentOS 7.9.2009, Apache 2.4.6, Python 3.6.8, Pygments 2.2.0, GNU diffutils 3.3, Subversion 1.14.1\n\n[general]\nroot_parents = /var/svn/repos: svn\n[utilities]\ndiff = /usr/bin/diff\n[options]\nallowed_views = annotate, diff, markup, roots, tar\nauthorizer = svnauthz\ncustom_log_formatting =\n bug ([0-9]+) : URL \n ([A-Z]+\\-[0-9]+) : URL \n \\[([3-7]{1}[0-9]{3})\\] : URL \n (rev|revs)\\.\\s*([0-9]+) : URL \ndefault_file_view = markup\nmax_filesize_kbytes = 1024\nlog_sort = none\nhr_intraline = 1\ntemplate_dir = templates/classic\ndocroot = /viewvc/static\nenable_syntax_coloration = 1\ntabsize = 0\nlog_pagesize = 75\nlog_pagesextra = 10\n[templates]\n[cvsdb]\n[vhosts]\n[authz-forbidden]\n[authz-forbiddenre]\n[authz-svnauthz]\nauthzfile = /var/svn/etc/svnaccessfile","author_login":"NMGo","author_association":"NONE","created_at":"2022-01-10T16:04:35+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1009173579","fragment_type":"issue_comment","sequence":1,"text":"I cannot reproduce it in my environment, FreeBSD 13, Python 3.9.8, Pygments 2.7.2, GNU diff 3.8, with standalone server.\n\nMy viewvc.conf:\n\n[general]\ncvs_roots = irregular-rcs-test: /home/cvs/irregular-rcs-test\nsvn_roots = test_repo: /home/futatuki/tmp/svn-test/testrepo,\n svn_cython: /home/futatuki/tmp/svn-test/svn_cython,\n (ommit some repos for privacy)\n bad-utf8-test: /home/futatuki/tmp/svn-test/bad-utf8-test\n[utilities]\ndiff = /usr/local/bin/gdiff\n[options]\nallowed_views = annotate, co, diff, markup, roots, tar\nuse_rcsparse = 1\nstacktraces = 1\n[templates]\n[cvsdb]\n[vhosts]\n[authz-forbidden]\n[authz-forbiddenre]\n[authz-svnauthz]\n\nCould you tell us about your environment in detail?\n\nP.S.\n \n\nIt is not correct. Subversion 1.14.x still supports Python 2 bindings, although it needs SWIG and extra steps for building. I also personally provide a Subversion 1.14.x package for el7 with both of Python 2 and Python 3 bindings, on URL (but no warranty).","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-01-10T17:47:36+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1009181355","fragment_type":"issue_comment","sequence":2,"text":"... however, I found \"full color diff\" does not work correctly in my environment. It shows \"- No changes -\" even other formats show changes.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-01-10T17:57:19+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1009207031","fragment_type":"issue_comment","sequence":3,"text":"Thanks for looking into this, @futatuki. I have edited by original post above with the system details and the stripped down ViewCS configuration file.\n \n \n \nThanks for the link to your site. We will be reviewing the information.","author_login":"NMGo","author_association":"NONE","created_at":"2022-01-10T18:24:49+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1009236229","fragment_type":"issue_comment","sequence":4,"text":"Just noticed @futatuki is using the \"stacktraces\" option.\n\nHere's the full \"trackback\" for the \"colored\" diffs:\n\nPython Traceback\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 5521, in main\n request.run_viewvc()\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 457, in run_viewvc\n self.view_func(self)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 4117, in view_diff\n generate_page(request, \"diff\", data)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 1024, in generate_page\n template.generate(server_fp, data)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 347, in generate\n self._execute(self.program, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 582, in _cmd_if_any\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 625, in _cmd_for\n self._execute(section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 604, in _cmd_is\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 624, in _cmd_for\n for item in list:\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/idiff.py\", line 32, in sidebyside\n fromlines = list(map(_stripnl, fromlines))\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/idiff.py\", line 30, in _stripnl\n return line.rstrip(\"\\n\")\nTypeError: a bytes-like object is required, not 'str'\n\nWe had to switch to the \"default\" template to get the stacktraces option to work.\n\nFor the \"unidiff\" view, the full traces are as follows:\n\nPython Traceback\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 5521, in main\n request.run_viewvc()\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 457, in run_viewvc\n self.view_func(self)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 4117, in view_diff\n generate_page(request, \"diff\", data)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/viewvc.py\", line 1024, in generate_page\n template.generate(server_fp, data)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 347, in generate\n self._execute(self.program, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 582, in _cmd_if_any\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 625, in _cmd_for\n self._execute(section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 604, in _cmd_is\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/ezt.py\", line 624, in _cmd_for\n for item in list:\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/idiff.py\", line 86, in unified\n for row in _trim_context(diff, context):\n File \"/usr/local/viewvc-1.3.0-dev-f97ea61/lib/idiff.py\", line 123, in _trim_context\n for line in lines:\n File \"/usr/lib64/python3.6/difflib.py\", line 907, in compare\n yield from g\n File \"/usr/lib64/python3.6/difflib.py\", line 1014, in _fancy_replace\n yield from self._qformat(aelt, belt, atags, btags)\n File \"/usr/lib64/python3.6/difflib.py\", line 1059, in _qformat\n yield \"- \" + aline\nTypeError: must be str, not bytes","author_login":"NMGo","author_association":"NONE","created_at":"2022-01-10T18:44:11+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1009251236","fragment_type":"issue_comment","sequence":5,"text":"Looks like hr_intraline needs to be set to reproduce the errors. I've edited my original post once more.","author_login":"NMGo","author_association":"NONE","created_at":"2022-01-10T19:03:58+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1009292437","fragment_type":"issue_comment","sequence":6,"text":"Thank you for finding out it. With `hr_intraline = 1`, I can reproduce the issue in \"full color diff\". However, in \"unidiff\" view, I got another exception:\n\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 5521, in main\n request.run_viewvc()\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 457, in run_viewvc\n self.view_func(self)\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 4117, in view_diff\n generate_page(request, \"diff\", data)\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 1024, in generate_page\n template.generate(server_fp, data)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 347, in generate\n self._execute(self.program, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 582, in _cmd_if_any\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 625, in _cmd_for\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 604, in _cmd_is\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 624, in _cmd_for\n for item in list:\n File \"/home/futatuki/work/viewvc/lib/idiff.py\", line 86, in unified\n for row in _trim_context(diff, context):\n File \"/home/futatuki/work/viewvc/lib/idiff.py\", line 123, in _trim_context\n for line in lines:\n File \"/usr/local/lib/python3.9/difflib.py\", line 872, in compare\n yield from g\n File \"/usr/local/lib/python3.9/difflib.py\", line 979, in _fancy_replace\n yield from self._qformat(aelt, belt, atags, btags)\n File \"/usr/local/lib/python3.9/difflib.py\", line 1015, in _qformat\n atags = _keep_original_ws(aline, atags).rstrip()\n File \"/usr/local/lib/python3.9/difflib.py\", line 717, in _keep_original_ws\n return ''.join(\n File \"/usr/local/lib/python3.9/difflib.py\", line 718, in \n c if tag_c == \" \" and c.isspace() else tag_c\nAttributeError: 'int' object has no attribute 'isspace'\n\nbut it seems the root cause of the exception is same.\n\nI'll investigate it.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-01-10T19:59:13+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1013714921","fragment_type":"issue_comment","sequence":7,"text":"The root cause of this issue is ambiguous specification of DiffDescription._get_diff() interface: `get_lines` is a function to obtain a list of strings, and `get_fp` is a function to obtain a IOstream. However when I rewrote for Python 3, I didn't determine explicitly which the IOstream and string are, bytes or str.\n\nPerhaps they should be str, which might contain surrogate-escaped non-unicode sequences, for raw diff output (view=patch) needs it.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-01-15T16:50:27+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193796898","fragment_type":"issue_comment","sequence":8,"text":"I'm sorry, but I've had no solid block of time to focus this issue since then.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-07-25T09:19:05+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1275582166","fragment_type":"issue_comment","sequence":9,"text":"This was another issue that caused by the change of behaviour on diff 3.8. I opend a new issue #293 for this.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-10-12T04:45:43+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[1405143857],"is_known_query_context":false},{"document_id":"gh_comment_1279708623","fragment_type":"issue_comment","sequence":10,"text":"In case `hr_intraline = 1`, and diff format is \"colored\" or \"unified\", `DiffDescription._get_diff` uses only `get_lines` and it uses `idiff` module to get diffs.\n\nThe cause of `TypeError` was get_lines function returns a list of `bytes`, instead of a list of `str`. This will be fixed a patch below:\n\nindex 1bccb86a..2bf92475 100644\n--- a/lib/viewvc.py\n+++ b/lib/viewvc.py\n@@ -4021,7 +4021,8 @@ class DiffDescription:\n def _content_lines(self, side, propname):\n f = self.request.repos.openfile(side.path_comp, side.rev, {})[0]\n try:\n- lines = f.readlines()\n+ lines = [l.decode(self.request.repos.encoding,'surrogateescape')\n+ for l in f.readlines()]\n finally:\n f.close()\n return lines\n@@ -4033,8 +4034,7 @@ class DiffDescription:\n \n def _prop_lines(self, side, propname):\n val = side.properties.get(propname, \"\")\n- # FIXME: dirty hack for Python 3: we need bytes as return value\n- return val.encode(\"utf-8\", \"surrogateescape\").splitlines()\n+ return val.splitlines()\n \n def _prop_fp(self, left, right, propname, diff_options):\n fn_left = self._temp_file(left.properties.get(propname))\n\nHowever, there still exists something wrong. It causes another exception like this.\n\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 5539, in main\n request.run_viewvc()\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 452, in run_viewvc\n self.view_func(self)\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 4138, in view_diff\n generate_page(request, \"diff\", data)\n File \"/home/futatuki/work/viewvc/lib/viewvc.py\", line 1019, in generate_page\n template.generate(server_fp, data)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 347, in generate\n self._execute(self.program, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 582, in _cmd_if_any\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 625, in _cmd_for\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 604, in _cmd_is\n self._do_if(value, t_section, f_section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 615, in _do_if\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 625, in _cmd_for\n self._execute(section, fp, ctx)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 524, in _execute\n method(method_args, fp, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 602, in _cmd_is\n left_value = _get_value(left_ref, ctx, filename, line_number)\n File \"/home/futatuki/work/viewvc/lib/ezt.py\", line 710, in _get_value\n ob = list[idx]\nTypeError: 'generator' object is not subscriptable\n\nI'll continue reading the code....","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-10-15T09:51:15+08:00","repo_name":"viewvc/viewvc","issue_id":1098073178,"issue_number":275,"issue_url":"https://github.com/viewvc/viewvc/issues/275","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1405143857","fragment_type":"issue_description","sequence":0,"text":"Full Colored Diff no longer works with GNU diff >= 3.8\nIn diff view, \"Full Colored Diff\" depends on the feature of GNU diff that it treat minus value of context lines as max context lines. However, GNU diffutils removed this feature as a bug in the commit 8d26b1403e8607811ccebdfe2822f2dad42a36d3 between 3.7 release and 3.8 release. `diff -U-1 foo bar` is now invalid since diff 3.8.\n\nMoreover, as we didn't check exit code and stderr output from diff command in vclib._diff_fp, in case diff exits with error without output to stdout, we treat it as \"- No changes -\".\n\nSo we can't get \"Full Colored Diff\" correctly.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-10-11T19:45:42+08:00","repo_name":"viewvc/viewvc","issue_id":1405143857,"issue_number":293,"issue_url":"https://github.com/viewvc/viewvc/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1277816899","fragment_type":"issue_comment","sequence":1,"text":"It's disappointing that diffutils no longer allows us to exploit the signed integer overflow with `-1` context ... do we just pass `65535` (or some other reasonable guess at `MAXINT`) instead and document our limitations?","author_login":"cmpilato","author_association":"CONTRIBUTOR","created_at":"2022-10-13T15:40:56+08:00","repo_name":"viewvc/viewvc","issue_id":1405143857,"issue_number":293,"issue_url":"https://github.com/viewvc/viewvc/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278043314","fragment_type":"issue_comment","sequence":2,"text":"Quick note: \"omission\" has but one \"m\".\n\nAnd honestly, this comment has waaaaaaaay too much geeky detail. I don't even think it's necessary to mentioned `-1` or the large numbers. Perhaps merely point out that GNU diff doesn't have a way to indicate that we want all the context so we approximate it using a number sufficiently large enough for most files whose diffs anyone might care to see in a web browser yet small enough to avoid crippling performance.","author_login":"cmpilato","author_association":"CONTRIBUTOR","created_at":"2022-10-13T18:53:20+08:00","repo_name":"viewvc/viewvc","issue_id":1405143857,"issue_number":293,"issue_url":"https://github.com/viewvc/viewvc/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1279150282","fragment_type":"issue_comment","sequence":3,"text":"I see. Then I'll make a PR with accepting your advice today (in UTC).","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-10-14T15:23:41+08:00","repo_name":"viewvc/viewvc","issue_id":1405143857,"issue_number":293,"issue_url":"https://github.com/viewvc/viewvc/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1281926583","fragment_type":"issue_comment","sequence":4,"text":"Backporting PR #297 is easy, but backporting PR #296 is troublesome because of `_diff_fp` implementation using `popen` API. Of course, we can backport whole `_diff_fp` implementation using subprocess.Popen, though.","author_login":"futatuki","author_association":"COLLABORATOR","created_at":"2022-10-18T07:24:11+08:00","repo_name":"viewvc/viewvc","issue_id":1405143857,"issue_number":293,"issue_url":"https://github.com/viewvc/viewvc/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1282835632","fragment_type":"issue_comment","sequence":5,"text":". o O ( We *neeeeeed* to get a 1.3.0 release out the door and call 1.2.x security-fixes-only. )","author_login":"cmpilato","author_association":"CONTRIBUTOR","created_at":"2022-10-18T18:27:51+08:00","repo_name":"viewvc/viewvc","issue_id":1405143857,"issue_number":293,"issue_url":"https://github.com/viewvc/viewvc/issues/293","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0190","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Signs responsive description heard when signs not checked?","query_context":"Related to URL \n\nWe should only hear the description of the signs when the are visible. This would affect Voicig design as well, but I don't think I have a design yet for Voicing.","known_context_document_ids":["gh_issue_3053043857"],"reference_answer":"Note: due to the merge hiccup, this change was temporarily deleted, but I restored it with cherry-picks referenced above.","answer_document_id":"gh_comment_2843155090","silver_evidence_path":["gh_comment_2877824941","gh_issue_3011299366","gh_comment_2843155090"],"evidence_issue_ids":[3053043857,3011299366],"source_repo_name":"phetsims/membrane-transport","source_issue_id":3053043857,"source_issue_number":167,"source_issue_url":"https://github.com/phetsims/membrane-transport/issues/167","target_repo_name":"phetsims/membrane-transport","target_issue_id":3011299366,"target_issue_number":103,"target_issue_url":"https://github.com/phetsims/membrane-transport/issues/103","reference_anchor_document_id":"gh_comment_2877824941","reference_answer_author":"samreid","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.25,"anchor_target_overlap":0.5,"target_answer_overlap":0.1818},"issue_created_at":"2025-05-09T19:43:03+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_3053043857","fragment_type":"issue_description","sequence":0,"text":"Signs responsive description heard when signs not checked\nRelated to URL \n\nWe should only hear the description of the signs when the are visible. This would affect Voicig design as well, but I don't think I have a design yet for Voicing.","author_login":"terracoda","author_association":"NONE","created_at":"2025-05-09T19:43:03+08:00","repo_name":"phetsims/membrane-transport","issue_id":3053043857,"issue_number":167,"issue_url":"https://github.com/phetsims/membrane-transport/issues/167","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2867736038","fragment_type":"issue_comment","sequence":1,"text":"Actually, those Context responses are supposed to be connected to the Signs checkbox, not the membrane voltage potential radio buttons.","author_login":"terracoda","author_association":"NONE","created_at":"2025-05-09T19:46:36+08:00","repo_name":"phetsims/membrane-transport","issue_id":3053043857,"issue_number":167,"issue_url":"https://github.com/phetsims/membrane-transport/issues/167","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2875096181","fragment_type":"issue_comment","sequence":2,"text":"Is the design:\n\n(a) When the user launches the sim, then uses the keyboard to enable the \"signs\", there should be a response: \"Positive outside and negative inside; signs densely packed along membrane.\"\n(b) While the \"signs\" checkbox remains checked: When the user uses the keyboard to change the radio button selection, there is no context or object response alert.\n\n?","author_login":"samreid","author_association":"MEMBER","created_at":"2025-05-13T05:32:08+08:00","repo_name":"phetsims/membrane-transport","issue_id":3053043857,"issue_number":167,"issue_url":"https://github.com/phetsims/membrane-transport/issues/167","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2877824941","fragment_type":"issue_comment","sequence":3,"text":"URL is how I interpret the design. We initially added these context response to the radio buttons in URL but I think that was a misunderstanding of the design from URL","author_login":"jessegreenberg","author_association":"CONTRIBUTOR","created_at":"2025-05-13T20:11:49+08:00","repo_name":"phetsims/membrane-transport","issue_id":3053043857,"issue_number":167,"issue_url":"https://github.com/phetsims/membrane-transport/issues/167","linked_issue_ids":[3011299366],"is_known_query_context":false},{"document_id":"gh_comment_2877867696","fragment_type":"issue_comment","sequence":4,"text":"Done in the above commit. Id like to take a look with @samreid and make sure that `fromRecord` usage is OK. keys of the record are strings while the membranePotentialProperty value type is number.","author_login":"jessegreenberg","author_association":"CONTRIBUTOR","created_at":"2025-05-13T20:29:57+08:00","repo_name":"phetsims/membrane-transport","issue_id":3053043857,"issue_number":167,"issue_url":"https://github.com/phetsims/membrane-transport/issues/167","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2878011708","fragment_type":"issue_comment","sequence":5,"text":"We took a look and improved the pattern by using square brakcets instead of string notation. That completes this issue, closing.","author_login":"jessegreenberg","author_association":"CONTRIBUTOR","created_at":"2025-05-13T21:37:05+08:00","repo_name":"phetsims/membrane-transport","issue_id":3053043857,"issue_number":167,"issue_url":"https://github.com/phetsims/membrane-transport/issues/167","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3011299366","fragment_type":"issue_description","sequence":0,"text":"Transport Proteins Panel - Updates to description in the tool box/ tool panel\nThis issue is tracking all the updated notes in red text in the \"Transport Proteins\" panel in the description design.\nAssigning @samreid. I have a feeling most of these changes and additions are straightforward. Let me know if you have questions. I will note this issue in the design doc.\n\n- [x] Accessible help text for all proteins in panel. goes under the main H3\n- Change: \"Grab proteins from toolboxes. Add up to 7 to membrane. Use keyboard shortcuts to grab, move, and release proteins in membrane.\"\n- To: \"Add up to 7 proteins to membrane. Use keyboard shortcuts to grab, sort, and release proteins into membrane.\"\n\n- [x] Accessible help text for each group of protein buttons\n- Change from: \"Grab to pull protein to the membrane.\"\n- To: \"Grab protein to pull to membrane.\"\n- AND: Remove duplicates. We only need one accessible help text per pair of protein buttons. Keep the help text under the second button and remove the help text from the first button in each pair.\n\n- [x] Signs Checkbox - Accessible help text.\n- Add: \"Explore with or without signs showing membrane voltage potential along inside and outside.\"\n- Context Response upon unchecking: \"Voltage potential signs, hidden.\"\n- Three context response connected to the actual selected voltage issue: \n - When -70: \"Positive outside and negative inside; signs densely packed along membrane. \"\n - When checked at -50: \"Positive outside and negative inside; signs lightly packed along membrane.\"\n - When checked at +30: \"Negative outside and positive inside; signs sparse along membrane.\"\n\n- [x] Add Ligands button - Update Context Response\n- Change from: \"Several ligands added to outside.\"\n- To: \"Ligands flood outside area of cell membrane.\"\n\n- [x] Add/Remove Ligands buttons - Update accessible help text\n- Change from: \"Add two types of ligands to outside of membrane.\"\n- To: \"Add or remove two types of ligands to outside of membrane.\"\n \n- [x] Active Transporters have different help text than other pairs of transport proteins.\n- Change from: \"Grab to pull protein to membrane.\"\n- To: \"Grab transporter to pull to membrane.\"\n- AND: Put help text on second transporter, and no help text on first transporter in pair.\n\nEDIT NOte: I removed \"Two types of\" from ligand context response because I have that wording in the help text.","author_login":"terracoda","author_association":"NONE","created_at":"2025-04-22T14:38:55+08:00","repo_name":"phetsims/membrane-transport","issue_id":3011299366,"issue_number":103,"issue_url":"https://github.com/phetsims/membrane-transport/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2839256842","fragment_type":"issue_comment","sequence":1,"text":"It is possible for phet-io clients to remove one of the pair. If they remove the 2nd of the pair, would the help text move over to the 1st one? Or is that over complicating it?","author_login":"samreid","author_association":"MEMBER","created_at":"2025-04-29T15:01:21+08:00","repo_name":"phetsims/membrane-transport","issue_id":3011299366,"issue_number":103,"issue_url":"https://github.com/phetsims/membrane-transport/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2843155090","fragment_type":"issue_comment","sequence":2,"text":"Note: due to the merge hiccup, this change was temporarily deleted, but I restored it with cherry-picks referenced above.","author_login":"samreid","author_association":"MEMBER","created_at":"2025-04-30T20:08:42+08:00","repo_name":"phetsims/membrane-transport","issue_id":3011299366,"issue_number":103,"issue_url":"https://github.com/phetsims/membrane-transport/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2843300227","fragment_type":"issue_comment","sequence":3,"text":"These charges were all lovely @samreid.\nWith changes in #24, I have a two more wording changes for the ligand button. I put more details in the help text so I could make the context response shorter.\n\n**New accessible help text:** Add or remove triangle- and star-shaped ligands to outside area of cell.\n**New context response when adding ligands:** Ligands flood outside area.","author_login":"terracoda","author_association":"NONE","created_at":"2025-04-30T21:14:48+08:00","repo_name":"phetsims/membrane-transport","issue_id":3011299366,"issue_number":103,"issue_url":"https://github.com/phetsims/membrane-transport/issues/103","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0191","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Apple Silicon Support?","query_context":"Since there are going to be more and more Apple Silicon computers in the wild, it would make sense to make a JAR for macosx-aarch64","known_context_document_ids":["gh_issue_964754180"],"reference_answer":"I've introduced `macosx-x86_64` builds in commit URL \nPlease give it a try with the snapshots: URL","answer_document_id":"gh_comment_1018182190","silver_evidence_path":["gh_comment_1033538116","gh_issue_1000252574","gh_comment_1018182190"],"evidence_issue_ids":[964754180,1000252574],"source_repo_name":"bytedeco/javacpp-presets","source_issue_id":964754180,"source_issue_number":1069,"source_issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","target_repo_name":"bytedeco/javacv","target_issue_id":1000252574,"target_issue_number":1696,"target_issue_url":"https://github.com/bytedeco/javacv/issues/1696","reference_anchor_document_id":"gh_comment_1033538116","reference_answer_author":"saudet","reference_answer_author_association":"MEMBER","quality_score":81.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.2,"target_answer_overlap":0.0},"issue_created_at":"2021-08-10T09:01:30+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_964754180","fragment_type":"issue_description","sequence":0,"text":"Apple Silicon Support\nSince there are going to be more and more Apple Silicon computers in the wild, it would make sense to make a JAR for macosx-aarch64","author_login":"peterrojs","author_association":"NONE","created_at":"2021-08-10T09:01:30+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1018182855","fragment_type":"issue_comment","sequence":1,"text":"I've introduced `macosx-arm64` builds for FFmpeg in commit URL \nPlease give it a try with the snapshots: URL","author_login":"saudet","author_association":"MEMBER","created_at":"2022-01-21T05:02:46+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1033538116","fragment_type":"issue_comment","sequence":2,"text":"Hi,\n\nI'm currently experiencing more or less the same issue as the author of the ticket URL . \nI'm compiling a project in Kotlin through gradle while using your libs\n\n javacpp_version = '1.5.7-SNAPSHOT'\n ffmpeg_version = \"4.4.1-$javacpp_version\"\n\n runtimeOnly \"org.bytedeco:ffmpeg:$ffmpeg_version:macosx-x86_64\"\n runtimeOnly \"org.bytedeco:javacpp:$javacpp_version:macosx-arm64\"\n\nI also tried with other mixes of version (4.4-1.5.6/ 4.3.1-1.5.4)\n\nThe project used to run perfectly on intel Macs with version 4.3.1-1.5.4\nBut now, on a Mac M1 whatever the versions used I always get the same error\n\n├─ org.bytedeco.ffmpeg.global.avutil. (avutil.java:14)\n├─ org.bytedeco.javacpp.Loader.load(Loader.java:1123)\n├─ org.bytedeco.javacpp.Loader.load(Loader.java:1300)\n├─ org.bytedeco.javacpp.Loader.loadLibrary(Loader.java:1683)\n├─ java.lang.System.loadLibrary(System.java:1989)\n├─ java.lang.Runtime.loadLibrary0(Runtime.java:818)\n├─ java.lang.ClassLoader.loadLibrary(ClassLoader.java:2429)\n│\n↑ no jniavutil in java.library.path: /Users/faw/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:. (UnsatisfiedLinkError) \n├─ java.lang.ClassLoader.loadLibrary(ClassLoader.java:2429)\n\nI was wondering if you had directions to provide to fix this issue? Specific versions to use or different packages to use?\n\nFor reference here is the java version I currently use : \n\nopenjdk 17.0.2 2022-01-18\nOpenJDK Runtime Environment (build 17.0.2+8-86)\nOpenJDK 64-Bit Server VM (build 17.0.2+8-86, mixed mode, sharing)","author_login":"Faz95210","author_association":"NONE","created_at":"2022-02-09T09:23:38+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[1000252574],"is_known_query_context":false},{"document_id":"gh_comment_1034614977","fragment_type":"issue_comment","sequence":3,"text":"All right, I changed the FFmpeg versions for the project and adapted it from v4 to v5, but then I have a new error : \n\n├─ org.bytedeco.ffmpeg.global.postproc. (postproc.java:182)\n│ org.bytedeco.ffmpeg.global.postproc.LIBPOSTPROC_VERSION_INT(postproc.java:-2)\n│\n↑ 'int org.bytedeco.ffmpeg.global.postproc.LIBPOSTPROC_VERSION_INT()' (UnsatisfiedLinkError)\n\nMy FFmpeg -version output : \n\nffmpeg version 5.0 Copyright (c) 2000-2022 the FFmpeg developers\nbuilt with Apple clang version 13.0.0 (clang-1300.0.29.30)\nconfiguration: --prefix=/opt/homebrew/Cellar/ffmpeg/5.0 --enable-shared --enable-pthreads --enable-version3 --cc=clang --host-cflags= --host-ldflags= --enable-ffplay --enable-gnutls --enable-gpl --enable-libaom --enable-libbluray --enable-libdav1d --enable-libmp3lame --enable-libopus --enable-librav1e --enable-librist --enable-librubberband --enable-libsnappy --enable-libsrt --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libxvid --enable-lzma --enable-libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libspeex --enable-libsoxr --enable-libzmq --enable-libzimg --disable-libjack --disable-indev=jack --enable-videotoolbox --enable-neon\nlibavutil 57. 17.100 / 57. 17.100\nlibavcodec 59. 18.100 / 59. 18.100\nlibavformat 59. 16.100 / 59. 16.100\nlibavdevice 59. 4.100 / 59. 4.100\nlibavfilter 8. 24.100 / 8. 24.100\nlibswscale 6. 4.100 / 6. 4.100\nlibswresample 4. 3.100 / 4. 3.100\nlibpostproc 56. 3.100 / 56. 3.100\n\nlibpostproc seems to be installed correctly","author_login":"Faz95210","author_association":"NONE","created_at":"2022-02-10T08:17:02+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1034616588","fragment_type":"issue_comment","sequence":4,"text":"I've fixed that in the just released version. Try again with \"5.0-1.5.7\" (without \"-SNAPSHOT\"):\n URL","author_login":"saudet","author_association":"MEMBER","created_at":"2022-02-10T08:19:01+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141553406","fragment_type":"issue_comment","sequence":5,"text":"Thanks!\nCurrently getting\n\njava\n'int org.bytedeco.libffi.global.ffi.FFI_TYPE_SMALL_STRUCT_1B()'\njava.lang.UnsatisfiedLinkError: 'int org.bytedeco.libffi.global.ffi.FFI_TYPE_SMALL_STRUCT_1B()'\n at org.bytedeco.libffi.global.ffi.FFI_TYPE_SMALL_STRUCT_1B(Native Method)\n at org.bytedeco.libffi.global.ffi. (ffi.java:109)\n at java.base/java.lang.Class.forName0(Native Method)\n at java.base/java.lang.Class.forName(Class.java:467)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1282)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1227)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1203)\n at org.bytedeco.libffi.ffi_cif. (ffi_cif.java:16)\n\n`\n\nwhen calling `new ffi_cif();` on `org.bytedeco:libffi-platform:3.4.2-1.5.8-SNAPSHOT`","author_login":"TheMode","author_association":"NONE","created_at":"2022-05-31T00:19:15+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141576935","fragment_type":"issue_comment","sequence":6,"text":"I see, those values are not available on that platform, but they only seem to be used internally, so we probably don't need them. I've fixed that by commenting them out in commit URL Please give it another try! Thanks for testing @TheMode","author_login":"saudet","author_association":"MEMBER","created_at":"2022-05-31T01:22:02+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1383167927","fragment_type":"issue_comment","sequence":7,"text":"A fresh build of org.bytedeco.ffmpeg-platform via maven worked properly for me with either version `5.0-1.5.7` or `5.1.2-1.5.8` as the ffmpeg-platform version.","author_login":"lannybroo","author_association":"NONE","created_at":"2023-01-15T14:41:07+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477504662","fragment_type":"issue_comment","sequence":8,"text":"I tried to complete onnx M1 Silicon Support manually, packaged and compiled without problems, and generated the jar files without problems, but when I used it, Throw an exception.\n\nmacosx-arm64/libjnionnx.dylib, 0x0001): symbol not found in flat namespace '_onnxGetBackendCompatibility'\n\nthe following exception occurred and I was hoping for help. thanks\n\nException in thread \"main\" java.lang.UnsatisfiedLinkError: no jnionnx in java.library.path: /Users/ouyubin/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:.\n at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2423)\n at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:808)\n at java.base/java.lang.System.loadLibrary(System.java:1893)\n at org.bytedeco.javacpp.Loader.loadLibrary(Loader.java:1825)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1416)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1227)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1203)\n at org.bytedeco.onnx.global.onnx. (onnx.java:14)\n at java.base/java.lang.Class.forName0(Native Method)\n at java.base/java.lang.Class.forName(Class.java:466)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1282)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1227)\n at org.bytedeco.javacpp.Loader.load(Loader.java:1203)\n at org.bytedeco.onnx.ISchemaRegistry. (ISchemaRegistry.java:16)\n at onnx.LoadModel.main(LoadModel.java:9)\nCaused by: java.lang.UnsatisfiedLinkError: /Users/ouyubin/.javacpp/cache/onnx-1.12.0-1.5.8-macosx-arm64.jar/org/bytedeco/onnx/macosx-arm64/libjnionnx.dylib: dlopen(/Users/ouyubin/.javacpp/cache/onnx-1.12.0-1.5.8-macosx-arm64.jar/org/bytedeco/onnx/macosx-arm64/libjnionnx.dylib, 0x0001): symbol not found in flat namespace '_onnxGetBackendCompatibility'\n at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)\n at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:383)\n at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:227)\n at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:169)\n at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2383)\n at java.base/java.lang.Runtime.load0(Runtime.java:746)\n at java.base/java.lang.System.load(System.java:1857)\n at org.bytedeco.javacpp.Loader.loadLibrary(Loader.java:1772)","author_login":"OuYuBin","author_association":"NONE","created_at":"2023-03-21T09:21:23+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477633317","fragment_type":"issue_comment","sequence":9,"text":"We can most likely fix that with an `Info.skip(\"onnxGetBackendCompatibility\")`:\n URL","author_login":"saudet","author_association":"MEMBER","created_at":"2023-03-21T10:58:37+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477736007","fragment_type":"issue_comment","sequence":10,"text":"Done,Thanks:)\n.put(new Info(\"onnxGetBackendCompatibility\",\"onnxGetBackendIDs\",\"onnxGetBackendInfo\",\"onnxGetEventState\",\"onnxInitBackend\",\"onnxInitEvent\",\"onnxInitGraph\",\"onnxReleaseBackend\",\"onnxReleaseBackendID\",\"onnxReleaseEvent\",\"onnxReleaseGraph\",\"onnxRunGraph\",\"onnxSetGraphIO\",\"onnxSignalEvent\",\"onnxWaitEvent\").skip());","author_login":"OuYubin","author_association":"NONE","created_at":"2023-03-21T12:14:58+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1486103337","fragment_type":"issue_comment","sequence":11,"text":"Intel doesn't provide an ARM version of MKL, that's normal. Please use OpenBLAS instead:\n URL","author_login":"saudet","author_association":"MEMBER","created_at":"2023-03-28T02:08:35+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1486103789","fragment_type":"issue_comment","sequence":12,"text":"javacpp haven 1.5.5 version for macosx-arm64, but javacpp-presets‘ sub-modules haven't any for macosx-arm64","author_login":"shouriken","author_association":"NONE","created_at":"2023-03-28T02:09:19+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1922484172","fragment_type":"issue_comment","sequence":13,"text":"Looks like GitHub Actions now has free M1 runners. That should make it easier to get builds running: URL","author_login":"saudet","author_association":"MEMBER","created_at":"2024-02-01T23:35:24+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1938747681","fragment_type":"issue_comment","sequence":14,"text":"They need to run on macOS 14 though. If you choose a `macos-14` runner, it will automatically run on M1, while `macos-11/12/13` runners are provisioned on Intel. Also many paths are different due to homebrew installing under `/opt/` instead of `/usr/local` on ARM. I guess we'll either have to create a new action or put a lot of conditionals into the existing one.","author_login":"sbrunk","author_association":"CONTRIBUTOR","created_at":"2024-02-12T14:07:49+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939792698","fragment_type":"issue_comment","sequence":15,"text":"Let's not create a new action, let's add branches and what not to deploy-macosx, yes. From what I understand GCC isn't available at all on Apple Silicon, so we can skip all that, and no need to worry about /usr/local paths there.","author_login":"saudet","author_association":"MEMBER","created_at":"2024-02-12T23:40:01+08:00","repo_name":"bytedeco/javacpp-presets","issue_id":964754180,"issue_number":1069,"issue_url":"https://github.com/bytedeco/javacpp-presets/issues/1069","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1000252574","fragment_type":"issue_description","sequence":0,"text":"Apple M1 doesn't work properly\nVer 1.5.6 (release version)\n\n16:46:15.544 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.presets.javacpp\n16:46:15.546 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.Loader\n16:46:15.559 [main] DEBUG org.bytedeco.javacpp.Loader - Loading /Users/lubaba/.javacpp/cache/javacpp-macosx-arm64.jar/org/bytedeco/javacpp/macosx-arm64/libjnijavacpp.dylib\n16:46:15.566 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.presets.javacpp\n16:46:15.567 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.Pointer\n16:46:15.571 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.presets.javacpp\n16:46:15.571 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.ffmpeg.global.avutil\n16:46:15.573 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.presets.javacpp\n16:46:15.573 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.ffmpeg.global.avutil\n16:46:15.606 [main] DEBUG org.bytedeco.javacpp.Loader - Loading library avutil\n16:46:15.607 [main] DEBUG org.bytedeco.javacpp.Loader - Failed to load for avutil@.56: java.lang.UnsatisfiedLinkError: no avutil in java.library.path\n16:46:15.643 [main] DEBUG org.bytedeco.javacpp.Loader - Loading library jniavutil\n16:46:15.643 [main] DEBUG org.bytedeco.javacpp.Loader - Failed to load for jniavutil: java.lang.UnsatisfiedLinkError: no jniavutil in java.library.path\n16:46:15.645 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.javacpp.presets.javacpp\n16:46:15.645 [main] DEBUG org.bytedeco.javacpp.Loader - Loading class org.bytedeco.ffmpeg.global.avutil\nException in thread \"main\" java.lang.NoClassDefFoundError: Could not initialize class org.bytedeco.ffmpeg.global.avutil\nat java.lang.Class.forName0(Native Method)\nat java.lang.Class.forName(Class.java:348)\nat org.bytedeco.javacpp.Loader.load(Loader.java:1212)\nat org.bytedeco.javacpp.Loader.load(Loader.java:1157)\nat org.bytedeco.javacpp.Loader.load(Loader.java:1133)\nat org.bytedeco.ffmpeg.avformat.Read_packet_Pointer_BytePointer_int. (Read_packet_Pointer_BytePointer_int.java:45)\nat org.bytedeco.javacv.FFmpegFrameGrabber. (FFmpegFrameGrabber.java:363)","author_login":"lunima618","author_association":"NONE","created_at":"2021-09-19T08:50:06+08:00","repo_name":"bytedeco/javacv","issue_id":1000252574,"issue_number":1696,"issue_url":"https://github.com/bytedeco/javacv/issues/1696","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018182190","fragment_type":"issue_comment","sequence":1,"text":"I've introduced `macosx-x86_64` builds in commit URL \nPlease give it a try with the snapshots: URL","author_login":"saudet","author_association":"MEMBER","created_at":"2022-01-21T05:01:16+08:00","repo_name":"bytedeco/javacv","issue_id":1000252574,"issue_number":1696,"issue_url":"https://github.com/bytedeco/javacv/issues/1696","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0193","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"help manage my disk space?","query_context":"Bazel workspaces can occupy a lot of space. `bazel clean` will fix that, but first you have to know that Bazel is the reason you're low on disk, and how big each Bazel workspace is.","known_context_document_ids":["gh_issue_1000172388"],"reference_answer":"There were two important questions for our design of the garbage collector:\n\n1. How to decided which blob in the disk cache should be removed?\n2. How/when to run the garbage collection for a shared disk cache?\n\nThe answer to the first question is similar to the workaround you have posted here: use `mtime`. However, since we now have the lease service which will extend the leases of blobs required by Bazel during the invocation, we can let disk cache update the `mtime` of referenced blobs during lease extension. This allows us to do the garbage collection based on the real access pattern. And combining with `--experimental_remote_cache_ttl`, we won't delete blobs that are still needed by Bazel. On that other hand, even if the blobs were accidentally deleted causing remote cache eviction error, lease server can help Bazel recover from it.\n\nWe don't want the garbage collection have impact on the build performance, nor users should be aware of it. So it happens in the background between invocations. The garbage collection should be interruptible and resumable, so that upon a new invocation, we can cancel it immediately without blocking the invocation and continue it afterwards. Since the CAS is sharded by the first byte of the blobs' digest, we define the unit of work for the garbage collection as shard, i.e. we can resume the garbage collection on the shard basis.\n\nWe don't want to run garbage collection after every invocation. We store the global state (e.g. when did last garbage collection finish) in the disk cache and schedule the garbage collection based on that (e.g. once per day).\n\nWe want to continue supporting the use case that multiple Bazel instances share the same disk cache. To prevent from having concurrent garbage collections, we use a lockfile created inside the disk cache by `open(O_CREAT | O_EXCL)` (and equivalent one on Windows. However, it might not work on some `NFS`s. We do have a plan B for that but we don't want to make it complicate now. Consider using a real remote cache server if you want to share cache across machines). The `mtime` of the lockfile is updated continuously during the garbage collection to indicate it is still in progress in case of Bazel server crashed (or `Ctrl-C`ed).\n\ncc @tjgq in case I missed something.","answer_document_id":"gh_comment_1602610638","silver_evidence_path":["gh_comment_1043262516","gh_issue_319514234","gh_comment_1602610638"],"evidence_issue_ids":[1000172388,319514234],"source_repo_name":"aspect-build/aspect-cli","source_issue_id":1000172388,"source_issue_number":32,"source_issue_url":"https://github.com/aspect-build/aspect-cli/issues/32","target_repo_name":"bazelbuild/bazel","target_issue_id":319514234,"target_issue_number":5139,"target_issue_url":"https://github.com/bazelbuild/bazel/issues/5139","reference_anchor_document_id":"gh_comment_1043262516","reference_answer_author":"coeuvre","reference_answer_author_association":"MEMBER","quality_score":92.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0588,"anchor_target_overlap":0.2941,"target_answer_overlap":0.303},"issue_created_at":"2021-09-19T00:59:52+08:00","valid_comment_count":68,"fragments":[{"document_id":"gh_issue_1000172388","fragment_type":"issue_description","sequence":0,"text":"help manage my disk space\nBazel workspaces can occupy a lot of space. `bazel clean` will fix that, but first you have to know that Bazel is the reason you're low on disk, and how big each Bazel workspace is.","author_login":"alexeagle","author_association":"MEMBER","created_at":"2021-09-19T00:59:52+08:00","repo_name":"aspect-build/aspect-cli","issue_id":1000172388,"issue_number":32,"issue_url":"https://github.com/aspect-build/aspect-cli/issues/32","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1017794347","fragment_type":"issue_comment","sequence":1,"text":"- Dont want to parse the entire disk if we can avoid it\n- A large number of bazel workspaces will be siblings to the bazel repo you are working on right now. Should be able to easily see those caches without checking the entire disk\n- Want to remove some combination of largest / \"longest since last used\" bazel caches first\n- Prompt user before removing anything\n- Will need to support windows as well but can be done as a separate pass later. Make sure to make a ticket for tracking purposes","author_login":"JesseTatasciore","author_association":"CONTRIBUTOR","created_at":"2022-01-20T18:23:26+08:00","repo_name":"aspect-build/aspect-cli","issue_id":1000172388,"issue_number":32,"issue_url":"https://github.com/aspect-build/aspect-cli/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1043262516","fragment_type":"issue_comment","sequence":2,"text":"I think we can land this without the repository cache, and without looking for \"other\" disk cache. The current disk cache is fine.\n\nComment on the upstream bazelbuild issue where the disk-cache has no eviction. URL","author_login":"alexeagle","author_association":"MEMBER","created_at":"2022-02-17T18:14:49+08:00","repo_name":"aspect-build/aspect-cli","issue_id":1000172388,"issue_number":32,"issue_url":"https://github.com/aspect-build/aspect-cli/issues/32","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_issue_319514234","fragment_type":"issue_description","sequence":0,"text":"Implement automatic garbage collection for the disk cache\nBreak out from URL \n\nBazel can use a local directory as a remote cache via the `--disk_cache` flag.\nWe want it to also be able to automatically clean the cache after a size threshold\nhas been reached. It probably makes sense to clean based on least recently used\nsemantics.\n\n@RNabel would you want to work on this?\n\n@RNabel @davido","author_login":"buchgr","author_association":"CONTRIBUTOR","created_at":"2018-05-02T11:28:03+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_385965341","fragment_type":"issue_comment","sequence":1,"text":"I will look into into implementing this, unless someone else is faster then me.","author_login":"davido","author_association":"CONTRIBUTOR","created_at":"2018-05-02T12:46:22+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_385969337","fragment_type":"issue_comment","sequence":2,"text":"I currently don't have time to work on this. @davido, if you don't get around to working on this in the next 2-3 weeks, I'm happy to pick this up.","author_login":"RNabel","author_association":"CONTRIBUTOR","created_at":"2018-05-02T13:00:21+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_420169617","fragment_type":"issue_comment","sequence":3,"text":"Hi, I would also very much like to see this feature implemented! @davido , @RNabel did you get anywhere with your experiments?","author_login":"daghub","author_association":"NONE","created_at":"2018-09-11T07:04:00+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_420221831","fragment_type":"issue_comment","sequence":4,"text":"Not finished, but had an initial stab: URL (this is mostly plumbing and figuring out where to put the logic it definitely doesn't work)\n\nI figured the simplest solution is an LRU relying on the file system for access times and modification times. Unfortunately, access times are not available on windows through Bazel's file system abstraction. One alternative would be a simple database, but that feels like overkill here. @davido, what do you think is the best solution here? Also happy to write up a brief design doc for discussion.","author_login":"RNabel","author_association":"CONTRIBUTOR","created_at":"2018-09-11T10:14:03+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_420242157","fragment_type":"issue_comment","sequence":5,"text":"What do you guys think about just running a local proxy service that has this functionality already implemented? I.e. URL or URL","author_login":"buchgr","author_association":"CONTRIBUTOR","created_at":"2018-09-11T11:34:28+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_420253884","fragment_type":"issue_comment","sequence":6,"text":"I think @aehlig solved this problem for the repository cache. Maybe you can\nborrow his implementation here as well.\n@buchgr, I feel this is core Bazel functionality and in my humble opinion\noutsourcing it isn’t the right direction. People at my company are often\namazed Bazel doesn’t have this fully supported out of the box.\nOn Tue, 11 Sep 2018 at 13:14 Robin Nabel wrote:","author_login":"ittaiz","author_association":"MEMBER","created_at":"2018-09-11T12:20:04+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_comment_420263652","fragment_type":"issue_comment","sequence":7,"text":"@ittaiz, what solution are you talking about? What we have so far for the repository cache is that the file gets touched on every cache hit (see e0d80356eed), so that deleting the oldest files would be a cleanup; the latter, however, is not yet implemented, for lack of time.\n\nFor the repository cache, it is also a slightly different story, as clean up should always be manual; upstream might have disappeared, to the cache might be last copy of the archive available to the user—and we don't want to remove that on the fly.","author_login":"aehlig","author_association":"MEMBER","created_at":"2018-09-11T12:54:09+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_420294983","fragment_type":"issue_comment","sequence":8,"text":"@aehlig sorry, my bad. You are indeed correct.\n@buchgr,\nI think so because I think a disk cache is a really basic feature of Bazel\nand the fact that it doesn’t work like this by default is IMHO a leaky\nabstraction (of how exactly the cached work) and influenced greatly by the\nfact that googlers work mainly (almost exclusively?) with remote execution.\nI’ve explained bazel to tens maybe hundreds of people. All of them were\nsurprised disk cache isn’t out of the box (eviction wise and also plans\nwise like we discussed).\nOn Tue, 11 Sep 2018 at 16:24 Jakob Buchgraber \nwrote:","author_login":"ittaiz","author_association":"MEMBER","created_at":"2018-09-11T14:31:07+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_comment_421132801","fragment_type":"issue_comment","sequence":9,"text":"@ittaiz \nthe disk cache is indeed a leaky abstraction that was mainly added because\nit was easy to do so. I agree that if Bazel should have a disk cache in the long\nterm, then it should also support read/write through to a remote cache and\ngarbage collection.\n\nHowever, I am not convinced that Bazel should have a disk cache built in but\ninstead this functionality could also be handled by another program running\nlocally. So I am trying to better understand why this should be part of Bazel.\nPlease note that there are no immediate plans to remove it and we will not do\nso without a design doc of an alternative. I am mainly interested in kicking off\na discussion.","author_login":"buchgr","author_association":"CONTRIBUTOR","created_at":"2018-09-13T19:56:31+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_421168163","fragment_type":"issue_comment","sequence":10,"text":"Thanks for the clarification and I appreciate the discussion.\nI think that users don’t want to operate many different tools and servers\nlocally. They want a build tool that works.\nThe main disadvantage I see is that it sounds like you’re offering a\ncleaner design at the user’s expense.\nOn Thu, 13 Sep 2018 at 22:56 Jakob Buchgraber \nwrote:","author_login":"ittaiz","author_association":"MEMBER","created_at":"2018-09-13T22:05:52+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_comment_421316327","fragment_type":"issue_comment","sequence":11,"text":"I partly agree. I'd argue in many companies that would change as you would typically have an IT department configuring workstations and laptops.\n \n\nI think that also depends. I'd say that if one only wants to use the local disk cache then I agree that providing two flags is as friction less as it gets. However, I think it's possible that most disk cache users will also want to do remote caching/execution and that for them this might not be noteworthy additional work.\n\nSo I think there are two possible future scenarios for the disk cache:\n\n1. Add garbage collection to the disk cache and be done with it.\n2. Add garbage collection, remote read fallback, remote write and async remote writes.\n\nI think 1) makes sense if we think that the disk cache will be a standalone feature that a lot of people will find useful on its own and if so I think its worth the effort to implement this in Bazel. For 2) I am not so sure as I can see several challenges that might be better solved in a separate process:\n\n- Async remote writes are the idea that Bazel writes blobs to the disk cache and then asynchronously (to the build) writes them to the remote cache thereby removing the upload time from the build's critical path. This is difficult to implement in Bazel, partly because there are no guarantees about the lifetime of the server process and partly because of lots of edge cases.\n- We might want to move authentication for remote caching/execution out of Bazel in the long term. We currently support Google Cloud authentication, we are about to add AWS and if we are successful I think its likely that we will need to add many more in the future and these authentication SDKs are quite large and increase the binary size. So we might end up with a separate proxy process *anyway*.\n- It's unconventional and potentially insecure that one has to pass authentication flags and secrets to Bazel itself. It seems to me that a separate process running as a different user that hides the authentication secrets from the rest of the system using OS security mechanisms is a better idea.\n- Once we implement a virtual remote filesystem (planned for Q4) in Bazel and then Bazel does not need to download cached artifacts anymore then the combination of a local disk cache and remote cache might become less attractive because downloads should no longer be a bottleneck (if it works out as expected).\n\nSo I think it might make sense for us to think about having a standard local caching proxy that's a separate process and that can be operated independently and/or that Bazel can launch automatically for improved usability might be an idea worth thinking about.","author_login":"buchgr","author_association":"CONTRIBUTOR","created_at":"2018-09-14T10:39:59+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_456928778","fragment_type":"issue_comment","sequence":12,"text":"Is there any plan to roll out the \"virtual remote filesystem\" soon? I am interested to learn more about it and can help if needed. We are hitting network speed bottleneck.","author_login":"bayareabear","author_association":"NONE","created_at":"2019-01-23T19:12:01+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584866283","fragment_type":"issue_comment","sequence":13,"text":"any plan of implementing the max size feature or a garbage collector for the local cache?","author_login":"thekyz","author_association":"NONE","created_at":"2020-02-11T21:39:32+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584896912","fragment_type":"issue_comment","sequence":14,"text":"This is a much needed feature in order to use Remote Builds without the Bytes, since naively cleaning up the disk cache results in build failures.","author_login":"brentleyjones","author_association":"NONE","created_at":"2020-02-11T22:52:36+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_661634649","fragment_type":"issue_comment","sequence":15,"text":"+1 on this, I had to write a script to keep my local disk from filling up.\n(by doing this I also discovered that something creates non-writable directories in `.cache/bazel` which seems bad in general)","author_login":"mr-salty","author_association":"NONE","created_at":"2020-07-21T05:02:22+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_663379675","fragment_type":"issue_comment","sequence":16,"text":"+1 on this feature require. I need it so I can run it inside a docker container.","author_login":"tkbrex","author_association":"NONE","created_at":"2020-07-24T07:10:12+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_821227627","fragment_type":"issue_comment","sequence":17,"text":"Some of you have mentioned that you have implemented your own workarounds, it would be great to post them in this thread. Because mine is just terrible; when my OS complains that it has 0 bytes left, I delete `~/.cache` and the next build will be very slow.","author_login":"TamaMcGlinn","author_association":"NONE","created_at":"2021-04-16T14:43:57+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_821236676","fragment_type":"issue_comment","sequence":18,"text":"On linux, I was using the find command to delete the oldest files. I use something like:\n\n find /PATH_TO_DIRECTORY -type f -mtime +60 -delete\n\nThe `+60` mean to delete files not changed in the last 60 days. So depending how quickly it fill, adjust this value.\n\nTake care with that command. It is dangerous! It can easily delete foo much files too.","author_login":"nouiz","author_association":"NONE","created_at":"2021-04-16T14:57:40+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_821307916","fragment_type":"issue_comment","sequence":19,"text":"I had a workaround similar to @nouiz but on a crontab\n\nshell\n@daily find /usr/local/google/home/gcmn/.cache/bazel* -mtime +12 -type f -delete\n\n**but it ended up causing really hard to debug issues** (see URL \n\nNote that there are two Bazel caches here.\n\nThe one stored in `~/.cache/bazel` by default is not the disk cache referenced in this bug. It's the output directory for builds (see URL This will contain:\n\n- `install/`, unpacked data files from the Bazel binary (0.5G on my machine)\n- `cache/`, which is not mentioned anywhere in the documentation and I have no idea what it does but based on the file paths like `cache/repos/v1/content_addressable/sha256/` is I guess some kind of content addressable indexing of repos :shrug: (300M on my machine)\n- One directory per workspace root from which you've invoked Bazel (as in the path to the workspace on your machine). Each of these is an \"output base\" On my machine these are typically a 0.5-1.5G each, but it's going to depend on what you're building.\n\nProbably you don't want to delete the first two directories (well, as I said, I have no idea what the second one is for, but best not to touch it). They don't seem to grow in size over time either. Based on my experience in URL the cache entries for the individual workspace roots are not at the file-level, however. That is, you can't just delete a single file in this \"cache\" and expect a correct build. They're at some directory level that is more granular than the whole directory, but I'm honestly not sure how much more. To make things more interesting, the timestamps of files are stubbed out in some places, so mtime is going to behave poorly on them. So I think the thing to do here is to look at the mtime of `$OUTPUT_BASE/lock`. This should contain the last time this entire directory was actually used and would help you clean up old directories. I'm pretty sure you could delete things in a more granular fashion, but it would require more investigation to see how to do so safely. Like some of these are fetches of entire external repositories that Bazel will refetch if they're not present (but will get very upset if only part of them is present).\n\nNow moving to the Bazel disk cache, which is actually what's referenced in this bug. You determine the location of this directory based on `--disk_cache`. Personally, I set `build --disk_cache=~/.cache/bazel-disk-cache` in `~/.bazelrc` so it always goes there. I think my aforementioned cron was behaving fine with this cache, for which individual files are entire cache entries (at least I didn't notice anything like the other issue). For now, I've disabled my cron and will reinvestigate it the next time Bazel brings my machine to a screeching halt by using all my disk space.\n\nThe general theme here is that Bazel has caches, but they're missing a pretty key feature of caches: eviction. Without them, users are left implementing weird and hacky workarounds. I wish someone from the Bazel team could at least endorse some workaround (like a safe script to run on a cron).","author_login":"GMNGeoffrey","author_association":"CONTRIBUTOR","created_at":"2021-04-16T16:52:47+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_821716065","fragment_type":"issue_comment","sequence":20,"text":"`~/.cache/bazel` was definitely growing (apparently without bound?) for me.\n\nI changed jobs so I'm not using bazel anymore, but this is the script I was running from cron: URL \n\nIt's mostly just `find` but takes case of some subtle issues. I never did track down how I ended up with non-writable directories in my cache, maybe something involving docker... so most people may not need that. Feel free to use it as needed, but bazel should really take care of this itself.","author_login":"mr-salty","author_association":"NONE","created_at":"2021-04-16T23:08:23+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_823990023","fragment_type":"issue_comment","sequence":21,"text":"@nouiz thank you for the valiant effort; but at least on my machine, I can see from this command that some if not all my bazel files were made on january 1st 1970.\n\nfind ~/.cache/bazel/ -type f -mtime +12000 | xargs ls -la\n\nIf anyone wants to use find mtime to get old files, run something like that first to check that you are not just going to delete everything.","author_login":"TamaMcGlinn","author_association":"NONE","created_at":"2021-04-21T11:32:23+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_824068338","fragment_type":"issue_comment","sequence":22,"text":"Thanks for the warning. I do not recall having such problem with the dates of times. It is good to know!","author_login":"nouiz","author_association":"NONE","created_at":"2021-04-21T13:38:17+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_824208164","fragment_type":"issue_comment","sequence":23,"text":"I think you want to use access time `-atime` instead of modified time `-mtime`, there could be older files that don't change frequently but are still used during each build.","author_login":"nkoroste","author_association":"CONTRIBUTOR","created_at":"2021-04-21T16:48:37+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_824230643","fragment_type":"issue_comment","sequence":24,"text":"Good point. But atime doesn't always works. On NFS server, most of the time the update of atime is disabled.\nI do not recall all the detail of why I used mtime. I found one that works well enough for me and used it ;)\n\nTF frequently force the rebuild of the everything. So for me it wouldn't have helped.","author_login":"nouiz","author_association":"NONE","created_at":"2021-04-21T17:25:12+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_824232522","fragment_type":"issue_comment","sequence":25,"text":"Yeah this is what I mentioned above\n \n\napparently they do this to avoid build dependence on the timestamp of the file (and therefore loss in hermeticness/caching)","author_login":"GMNGeoffrey","author_association":"CONTRIBUTOR","created_at":"2021-04-21T17:28:31+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_862900573","fragment_type":"issue_comment","sequence":26,"text":"Pulling back to the `--disk_cache` aspect itself...\n\nI find the boring use of a disk cache without any remote caching pretty awesome. It is essentially `ccache` but substantially better and more powerful. I would really love to see some way to bound the size / GC the old entries.\n\nI'll note that GitHub's new, fancy action system has a built-in and very nice way to persist caches from run-to-run for things like CI. Using this in conjunction with the disk cache of Bazel results in a very clean way to have very fast CI builds with very minimal risk of corruption by keeping the cached state extremely small and focused. However, it needs *some* way to GC things.\n\nCurrently, for CI I use a terrible hack of manually setting all the `atime`s back by several years for the entire disk cache before running the build, and then deleting any parts of the disk cache whose `atime` isn't updated during the build. This has the rough effect of working even with Linux-style `relatime`. It of course won't work on file systems without `atime` or places like Windows I suspect. Something from Bazel itself would be fantastic.","author_login":"chandlerc","author_association":"NONE","created_at":"2021-06-17T03:53:48+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_943542170","fragment_type":"issue_comment","sequence":27,"text":"It allows you to specify a max size instead of a max age, which is pretty nice. Definitely users doing their own cleanup with random scripts is not ideal in general","author_login":"GMNGeoffrey","author_association":"CONTRIBUTOR","created_at":"2021-10-14T16:55:25+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_962303486","fragment_type":"issue_comment","sequence":28,"text":"I ran into issues with partial cache content deletions, as we have potentially continuous use of the cache with no downtime. We now just rename the cache directory and then delete all of it. This is unfortunate.\n\nSee issues like \n URL and URL","author_login":"jscheid-ventana","author_association":"NONE","created_at":"2021-11-06T01:15:03+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1330433214","fragment_type":"issue_comment","sequence":29,"text":"I came up to this issue when trying to find if there is some `bazel clean` parameter in order to clean the disk cache. I find great the proposal of this ticket, but woudn't make sense to implement it on bazel clean? At least additionally, it does not have to be instead.\nThe reason for that is that you could have more control and what and when to delete. You could decide for example that every night you do a bazel clean of the disk cache and afterwards execute a build.\nI could see a command similar to this very handy:\n`bazel clean --disk_cache_last_access_older_than= `\nWith an example\n`bazel clean --disk_cache_last_access_older_than=30`\nwould delete the artifacts of the cache that have not been accessed in the last 30 days.\n\nIf you find this proposal interesting just let me know if we should continue the discussion here or just create another ticket to not mix topics. I find it relevant to post the initial thoughts here because I think it is closely related.","author_login":"limdor","author_association":"CONTRIBUTOR","created_at":"2022-11-29T10:45:22+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413101257","fragment_type":"issue_comment","sequence":30,"text":"I think this is a fine implementation strategy, but it should really be an implementation detail IMO -- something Bazel does transparently behind the scenes.\n\nI think the real goal for user experience should be a configured max size for the disk cache, just like ccache and other tools provide that users set and \"forget\".","author_login":"chandlerc","author_association":"NONE","created_at":"2023-02-02T03:30:17+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1428102784","fragment_type":"issue_comment","sequence":31,"text":"Seems that with URL implemented, this can be done pretty easily by Bazel now?","author_login":"brentleyjones","author_association":"COLLABORATOR","created_at":"2023-02-13T15:08:12+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1550795494","fragment_type":"issue_comment","sequence":32,"text":"Even with a remote cache, if someone is running bazel locally and running bazel test would continue to generate runfiles right?\n\nThese runfiles would then accumulate and eventually bazel would halt? If anyone has a workaround besides pruning based on mtime and using a remote cache, would greatly appreciate the suggestion!","author_login":"Ryang20718","author_association":"NONE","created_at":"2023-05-17T06:11:11+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1601698082","fragment_type":"issue_comment","sequence":33,"text":"+1 to this issue as well, I'm trying to POC out bazel as a new build system on my team, and setting up a cache server for a prototype seems overkill","author_login":"snakethatlovesstaticlibs","author_association":"NONE","created_at":"2023-06-21T21:23:24+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1602517157","fragment_type":"issue_comment","sequence":34,"text":"@tjgq and I had several brainstorm sessions about garbage collection for disk cache in the past days and we now have a solid design for that! We don't have a timeline to work on the implementation yet, but Q3 looks like a reasonable slot.","author_login":"coeuvre","author_association":"MEMBER","created_at":"2023-06-22T12:03:01+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1602610638","fragment_type":"issue_comment","sequence":35,"text":"There were two important questions for our design of the garbage collector:\n\n1. How to decided which blob in the disk cache should be removed?\n2. How/when to run the garbage collection for a shared disk cache?\n\nThe answer to the first question is similar to the workaround you have posted here: use `mtime`. However, since we now have the lease service which will extend the leases of blobs required by Bazel during the invocation, we can let disk cache update the `mtime` of referenced blobs during lease extension. This allows us to do the garbage collection based on the real access pattern. And combining with `--experimental_remote_cache_ttl`, we won't delete blobs that are still needed by Bazel. On that other hand, even if the blobs were accidentally deleted causing remote cache eviction error, lease server can help Bazel recover from it.\n\nWe don't want the garbage collection have impact on the build performance, nor users should be aware of it. So it happens in the background between invocations. The garbage collection should be interruptible and resumable, so that upon a new invocation, we can cancel it immediately without blocking the invocation and continue it afterwards. Since the CAS is sharded by the first byte of the blobs' digest, we define the unit of work for the garbage collection as shard, i.e. we can resume the garbage collection on the shard basis.\n\nWe don't want to run garbage collection after every invocation. We store the global state (e.g. when did last garbage collection finish) in the disk cache and schedule the garbage collection based on that (e.g. once per day).\n\nWe want to continue supporting the use case that multiple Bazel instances share the same disk cache. To prevent from having concurrent garbage collections, we use a lockfile created inside the disk cache by `open(O_CREAT | O_EXCL)` (and equivalent one on Windows. However, it might not work on some `NFS`s. We do have a plan B for that but we don't want to make it complicate now. Consider using a real remote cache server if you want to share cache across machines). The `mtime` of the lockfile is updated continuously during the garbage collection to indicate it is still in progress in case of Bazel server crashed (or `Ctrl-C`ed).\n\ncc @tjgq in case I missed something.","author_login":"coeuvre","author_association":"MEMBER","created_at":"2023-06-22T13:08:29+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603071891","fragment_type":"issue_comment","sequence":36,"text":"It's really awesome to see progress on this issue :)\n \n\nWould that work in the context of continuous integration / Github Actions? In that context, there isn't really any or much time \"between invocations\": a VM comes up, downloads the cache, builds a bunch of stuff, and uploads the updated cache. Example workflow.\n\nThis seems to be a common use case cited in this thread, e.g. see @chandlerc's commented I linked.","author_login":"smolkaj","author_association":"NONE","created_at":"2023-06-22T17:43:24+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_comment_1604233009","fragment_type":"issue_comment","sequence":37,"text":"I guess a flag that forces a GC run after invocation could work for this case.","author_login":"coeuvre","author_association":"MEMBER","created_at":"2023-06-23T12:45:48+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1604239517","fragment_type":"issue_comment","sequence":38,"text":"Alternatively, we could provide a simple script that does disk cache GC following the same algorithm (based on `mtime`) outside of the Bazel process. Then your CI run could call that before or after the build.","author_login":"meisterT","author_association":"MEMBER","created_at":"2023-06-23T12:51:23+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1604333720","fragment_type":"issue_comment","sequence":39,"text":"A parameter of the bazel clean would already be helpful for a lot of users. A lot of people cares about disk space only when is full but with the current clean you can not clean only what is not being used.","author_login":"limdor","author_association":"CONTRIBUTOR","created_at":"2023-06-23T14:05:10+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1604378412","fragment_type":"issue_comment","sequence":40,"text":"@limdor we also discussed this but don't really like it because we do not want to teach users to run `bazel clean` - this is something they should not need to do.","author_login":"meisterT","author_association":"MEMBER","created_at":"2023-06-23T14:38:50+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1604382509","fragment_type":"issue_comment","sequence":41,"text":"That is a very good point. I understand and I agree, until now this is the only reason why I have to run bazel clean","author_login":"limdor","author_association":"CONTRIBUTOR","created_at":"2023-06-23T14:41:57+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1604635414","fragment_type":"issue_comment","sequence":42,"text":"I wrote a script like that, feel free to do as you please with it: URL","author_login":"mr-salty","author_association":"NONE","created_at":"2023-06-23T17:56:56+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_comment_1608306331","fragment_type":"issue_comment","sequence":43,"text":"It's really good that the discussion has kicked in again, one of our developers posted this today in our Slack and I'm gonna post it here to show the scale of the issue\n\nimage","author_login":"artem-zinnatullin","author_association":"CONTRIBUTOR","created_at":"2023-06-26T21:41:16+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1608467418","fragment_type":"issue_comment","sequence":44,"text":"Over 8 years of being a user of these type of build tools I have heard this statement many times from different tool teams/developers. The reality users (not only users but pipelines that do builds in resource constrained environments) won't be taught to use `bazel clean`, they have already learned todo that, the cat is out of the bag folks. I'm not advocating for that idea or saying that its a bad north start to shoot for, but the reality is most tooling has not gotten it right and continue to push the burden onto the user and the user sends up blowing away environments depending on context. \n\nPersonally, I'm a huge fan of being able to set a quota here based on hard limits or resource %, I think in practice LRU/accessed purging is probably best if a feature like this is enabled. Using background process daemon to clean up is probably the way to go. \n\nFrom the context which we have (I'm no longer at twitter) used bazel, a considerable amount of effort and issues where solely around resource clean up depending on the environment (remote execution systems, local laptops, deployment pipelines, ci pipelines), each one having their own thresholds of limitations and SLA to purge/delete data. \n\nA commonly used code repo where a user build a lot of different targets or was building targets with frequent change, could easily amass +500GB of cached objects, we would use some preamble script wrappers to check for such things and schedule background cleaning jobs `bazel clean --async`, sometimes that would fail and leave a huge amount of state we would then do a secondary check to hard GC their sandbox.\n\nGetting a tighter and cleaner caching story (including the situations around remote cache/execution) will be huge for bazel, large companies hit issues in this area every time they reach for bazel and have a considerable large code base.","author_login":"adam-singer","author_association":"CONTRIBUTOR","created_at":"2023-06-26T23:40:37+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1874134400","fragment_type":"issue_comment","sequence":45,"text":"I'm working on this now. I expect this feature to ship in 7.1 or (more likely) 7.2.","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-01-02T14:59:38+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1874672691","fragment_type":"issue_comment","sequence":46,"text":"I recently made a change in the DiskCache class to write to a pipe all the files that bazel uses and then have a separate process clean that up, was working well for my use case.","author_login":"nikhilkalige","author_association":"NONE","created_at":"2024-01-02T23:12:24+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1994941328","fragment_type":"issue_comment","sequence":47,"text":"The design doc at URL has been significantly reworked. The most notable change is that we're switching to an \"online\" garbage collection strategy, in response to feedback that \"offline\" collection would not satisfy the need to keep the cache under the target size at all times, including during builds.\n\nAlthough no code has been submitted yet, I've been working on a prototype for this new strategy and I'm still expecting to get it productionized and submitted in time for the 7.2.0 release.","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-03-13T16:43:42+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2075716393","fragment_type":"issue_comment","sequence":48,"text":"@tjgq are there any updates on this? It is still not listed as 7.2.0 deliverable according to URL","author_login":"dkashyn-sfdc","author_association":"NONE","created_at":"2024-04-24T19:45:32+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2079493304","fragment_type":"issue_comment","sequence":49,"text":"@dkashyn-sfdc I added it to the milestone just now - there is some progress and we expect to land a first usable version by the 7.2 release the latest.","author_login":"meisterT","author_association":"MEMBER","created_at":"2024-04-26T14:20:45+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105369494","fragment_type":"issue_comment","sequence":50,"text":"How far are we from getting this done? rc1 is scheduled for next Monday, but judging by the urgency and remaining work, we can push it out a bit.","author_login":"Wyverald","author_association":"MEMBER","created_at":"2024-05-10T23:09:57+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107629459","fragment_type":"issue_comment","sequence":51,"text":"Unfortunately, I ran into some difficulties and this is not ready yet. I'm aiming to build up to a minimally useful implementation within the next few days.\n\nIf this FR is the only reason we would delay rc1, it would be fine to get it out today, under the (not so unreasonable?) assumption that there will be an rc2 that the remaining changes can still make it into.","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-05-13T13:48:36+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2117349097","fragment_type":"issue_comment","sequence":52,"text":"Here is my workaround.\n\nsh\nfind /path/to/bazel-cache -amin +1440 -delete 2>/dev/null || true\n\nThe command searches for files in the /path/to/bazel-cache directory that have not been accessed in the last 1440 minutes (24 hours) and deletes them.","author_login":"peaceiris","author_association":"NONE","created_at":"2024-05-17T11:16:04+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2117425851","fragment_type":"issue_comment","sequence":53,"text":"It won't help you to \"trim to size\" if you need to fit cache below a certain threshold of disk space.","author_login":"dkashyn-sfdc","author_association":"NONE","created_at":"2024-05-17T11:50:35+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2118618958","fragment_type":"issue_comment","sequence":54,"text":"@peaceiris I don't know for certain, but our experience strongly suggests that *any* process that deletes files directly from the cache like that is doomed to cause strange failures sooner or later. It may depend on specifically what tasks bazel runs; we've found that code coverage jobs are especially brittle.","author_login":"ceejatec","author_association":"NONE","created_at":"2024-05-18T03:21:04+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2118667936","fragment_type":"issue_comment","sequence":55,"text":"Yes, I think that's right. So we're looking forward to implementing this feature in Bazel.","author_login":"peaceiris","author_association":"NONE","created_at":"2024-05-18T06:53:19+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2125403479","fragment_type":"issue_comment","sequence":56,"text":"Unfortunately we won't have enough time for this in 7.2.0; postponing to 7.3.0","author_login":"Wyverald","author_association":"MEMBER","created_at":"2024-05-22T17:40:16+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2162097922","fragment_type":"issue_comment","sequence":57,"text":"Thx, but this is not a good walkaround for this problem because you cannot promise what files you will delete here and different cache files have connections. If somebody plans to try it, please stay careful.","author_login":"withtimesgo1115","author_association":"NONE","created_at":"2024-06-12T04:47:43+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2197656556","fragment_type":"issue_comment","sequence":58,"text":"7.3.0 is not that far as we think. Is there a way to try this with nightly builds or so?","author_login":"dkashyn-sfdc","author_association":"NONE","created_at":"2024-06-28T21:02:30+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2246411943","fragment_type":"issue_comment","sequence":59,"text":"Unfortunately we didn't have time for this in 7.3.0 either -- @tjgq has been occupied by other work. This may need to wait until 7.4.0 or even 8.0.\n \n\nWe do have rolling releases, which are cut every ~2 weeks. But I'm not sure if this feature in particular is ready for even preliminary testing.","author_login":"Wyverald","author_association":"MEMBER","created_at":"2024-07-23T22:24:34+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2272063932","fragment_type":"issue_comment","sequence":60,"text":"I really appreciate everyone who looking into this, and I left comments in the design doc.\n\nI am in a similar boat as @ittaiz and trying to help a 100-person company improve their build infrastructure. Having a default local cache, with GC, enabled by default, is all very valuable for Bazel in this environment. I was also surprised that it doesn't already work this way.","author_login":"lexspoon","author_association":"NONE","created_at":"2024-08-06T20:10:13+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2379368397","fragment_type":"issue_comment","sequence":61,"text":"Status update: Bazel 8 is going to ship with built-in garbage collection, with knobs to set a maximum size in bytes, a maximum age for cache entries, or both.\n\nHowever, contrary to previously announced plans, we're going to provide an **offline** implementation, whereby garbage collection occurs in the background while the Bazel server is idle. It therefore remains possible for the set limits to be exceeded during the course of a build, which is a necessary tradeoff to preserve build performance. We will also provide an official tool to run a garbage collection manually, for users who prefer to have more control. The documentation page at URL will soon be updated with the details.\n\nThe more sophisticated **online** implementation described in URL is, unfortunately, extremely challenging to implement across all supported operating systems, while providing hard size guarantees, allowing multiple Bazel processes to share the same disk cache, and preserving current build performance in all scenarios. It's unclear to me at this point that all of these goals can be simultaneously fulfilled.","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-09-27T14:07:02+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[319514234],"is_known_query_context":false},{"document_id":"gh_comment_2379421223","fragment_type":"issue_comment","sequence":62,"text":"Thanks for the update.\nAs a B plan, can we have a suggested way to handle a hard disk space constraint?\nA documentation like:\n\nIf you have a hard disk space contraint of size X, setting bazel max cache sizes of X-Y% should be safe if your binary size is under Z bytes.\n\nAnd maybe document what will happen if the sizes isn't set right. Hopefully something like, \"he current upload will be lost, but there won't be any curruption and nothing will crash. So the only consequence is the recomputation of some entry\".","author_login":"nouiz","author_association":"NONE","created_at":"2024-09-27T14:30:56+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2379443625","fragment_type":"issue_comment","sequence":63,"text":"I think the best rule of thumb we can give is: prior to starting a build, you must have enough disk space to fit the entirety of the build outputs twice (one time for the contents of `bazel-out`, another for the copies uploaded to the disk cache). That's obviously an overestimation, and obviously dependent on what your build does; the actual number can't be computed except by actually running the build.\n\nIf you do run out of space during a build, it's always safe to retry it after you have (manually) recovered some space. Bazel is designed to produce a correct build result regardless of the starting conditions.","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-09-27T14:42:15+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2379570251","fragment_type":"issue_comment","sequence":64,"text":"+1 to this general perspective. Developers will generally maintain enough free disk space that they don't need to be right at the limit all the time. As such, Bazel doesn't need to go overboard on the disk space limit, whenever it cuts into other desiderata.","author_login":"lexspoon","author_association":"NONE","created_at":"2024-09-27T15:39:57+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2391936140","fragment_type":"issue_comment","sequence":65,"text":"@dkashyn-sfdc Correct. I experimented with speeding up filesystem scans by using a sqlite database as an index, but it's very tricky to do while observing all of the constraints I mentioned above, and in the end I felt that it had an unfavorable complexity/utility ratio (so it will ship without an index, just a parallelized filesystem scan).","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-10-03T17:20:30+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2429127109","fragment_type":"issue_comment","sequence":66,"text":"To close the loop: in addition to shipping in 8.0.0, this feature has also been cherry-picked into 7.4.0, and the documentation has been updated accordingly.","author_login":"tjgq","author_association":"CONTRIBUTOR","created_at":"2024-10-22T12:18:25+08:00","repo_name":"bazelbuild/bazel","issue_id":319514234,"issue_number":5139,"issue_url":"https://github.com/bazelbuild/bazel/issues/5139","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0194","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Garage Door Opens but does not close?","query_context":"As per the title, I can use the webpage to open/stop but not close the garage door, any help would be appreciated.","known_context_document_ids":["gh_issue_2246708079"],"reference_answer":"I don't see anything unusual in the logs, other than the fact that your GDO seems to be completely ignoring the close command. \n\nWe might need to add a \"quirks\" feature flag or something like that for cases like this... such as `USE_TOGGLE_FOR_CLOSE` in this particular case.\n\nP.S. If you feel like experimenting you can see if maybe there's another value for `DOOR_CLOSE` that works for your GDO. You'll need to change the constant here URL and recompile/re-flash to test.","answer_document_id":"gh_comment_1865161974","silver_evidence_path":["gh_comment_2059805648","gh_issue_2045162770","gh_comment_1865161974"],"evidence_issue_ids":[2246708079,2045162770],"source_repo_name":"Kaldek/rat-ratgdo","source_issue_id":2246708079,"source_issue_number":100,"source_issue_url":"https://github.com/Kaldek/rat-ratgdo/issues/100","target_repo_name":"ratgdo/esphome-ratgdo","target_issue_id":2045162770,"target_issue_number":146,"target_issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","reference_anchor_document_id":"gh_comment_2059805648","reference_answer_author":"mariusmuja","reference_answer_author_association":"COLLABORATOR","quality_score":94.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.2973,"target_answer_overlap":0.125},"issue_created_at":"2024-04-16T19:03:22+08:00","valid_comment_count":48,"fragments":[{"document_id":"gh_issue_2246708079","fragment_type":"issue_description","sequence":0,"text":"Garage Door Opens but does not close\nAs per the title, I can use the webpage to open/stop but not close the garage door, any help would be appreciated.","author_login":"Stuart5851","author_association":"NONE","created_at":"2024-04-16T19:03:22+08:00","repo_name":"Kaldek/rat-ratgdo","issue_id":2246708079,"issue_number":100,"issue_url":"https://github.com/Kaldek/rat-ratgdo/issues/100","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2059799394","fragment_type":"issue_comment","sequence":1,"text":"What firmware are you running, and do you have obstruction sensors attached? Does the `Toggle` command work to close the door rather than the discrete `Close` command?","author_login":"foreverimagining","author_association":"NONE","created_at":"2024-04-16T19:37:53+08:00","repo_name":"Kaldek/rat-ratgdo","issue_id":2246708079,"issue_number":100,"issue_url":"https://github.com/Kaldek/rat-ratgdo/issues/100","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2059805648","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the reply, seems like it is a known issue with certain GDO's that don't have obstruction sensors attached as they are optional. \nYes toggle command works. \nLooks to be a couple of solutions, buy obstructions sensors or potentially wait to see if it can be bypassed. Going to close the issue as I forgot to check the main ratgdo page first and its already reported under URL","author_login":"Stuart5851","author_association":"NONE","created_at":"2024-04-16T19:42:31+08:00","repo_name":"Kaldek/rat-ratgdo","issue_id":2246708079,"issue_number":100,"issue_url":"https://github.com/Kaldek/rat-ratgdo/issues/100","linked_issue_ids":[2045162770],"is_known_query_context":false},{"document_id":"gh_comment_2059834783","fragment_type":"issue_comment","sequence":3,"text":"Yup, that's about the sum of it. \n\nIt seemed that at least one person was able to make it work, but for most, it's either add obstruction sensors, or you could use a workaround like the MQTT code where you toggle the door conditionally on whether it is open when you need to specifically close it. Of course, that requires that the RATGDO or RAT-RATGDO always have accurate statuses, so it is a little sketchy sometimes.","author_login":"foreverimagining","author_association":"NONE","created_at":"2024-04-16T20:02:50+08:00","repo_name":"Kaldek/rat-ratgdo","issue_id":2246708079,"issue_number":100,"issue_url":"https://github.com/Kaldek/rat-ratgdo/issues/100","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2045162770","fragment_type":"issue_description","sequence":0,"text":"Door close command does not work all others do\nI have a chamberlain ML700EV with 8 terminals and a ratgdo 2.5i with latest esp software.\nMy setup features no wall buttons and i previously only used the radio remotes. Type TX2REV with only one button for open and close.\nimage\n\nI got the ratgdo to work with the wiring setup for the 14 terminal setup (use green 0 iso of red terminal for the serial line).\n\nThe status is read correctly and commands work, except the close command. Open, stop, toggle,light work ok. Just close results in no action. \n\nAny clues what is going on here or what might be the cause? Could it maybe use a different close command byte than other models?\nAny logs i could run to help provide more insight?","author_login":"alrassia","author_association":"NONE","created_at":"2023-12-17T10:29:54+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1865135160","fragment_type":"issue_comment","sequence":1,"text":"I hope this covers the requested logs (VERY_VERBOSE log level), otherwise please let me know what else to do.\n\nlogs_ratgdov25i-f614ca_logs.txt","author_login":"alrassia","author_association":"NONE","created_at":"2023-12-20T21:03:47+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1865161974","fragment_type":"issue_comment","sequence":2,"text":"I don't see anything unusual in the logs, other than the fact that your GDO seems to be completely ignoring the close command. \n\nWe might need to add a \"quirks\" feature flag or something like that for cases like this... such as `USE_TOGGLE_FOR_CLOSE` in this particular case.\n\nP.S. If you feel like experimenting you can see if maybe there's another value for `DOOR_CLOSE` that works for your GDO. You'll need to change the constant here URL and recompile/re-flash to test.","author_login":"mariusmuja","author_association":"COLLABORATOR","created_at":"2023-12-20T21:27:37+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1866207486","fragment_type":"issue_comment","sequence":3,"text":"To experiment quicker you can add this to your yaml under `api:` and then call the service from HA developer tools.\n\n services:\n - service: service_send_door_command\n variables:\n door_data: int\n then:\n - lambda: !lambda |-\n if(door_data >= 0) {\n id($id_prefix).door_command(door_data); \n\nI tried 0x4 to 0xF and 0xFF on my gdo with door open. No response","author_login":"mulcmu","author_association":"CONTRIBUTOR","created_at":"2023-12-21T13:02:48+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869798875","fragment_type":"issue_comment","sequence":4,"text":"Thx I will try to give\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nI tried to copy in the quoted text but get mapping values are not allowed in this context in \" \", line 13, column 16. Line 13 being the line starting with - lambda. \n\nMy yaml looks like:\n\nsubstitutions:\n name: ratgdov25i-f614ca\n friendly_name: ratgdov2.5i f614ca\npackages:\n ratgdo.esphome: github://ratgdo/esphome-ratgdo/v25iboard.yaml@main\nesphome:\n name: ${name}\n name_add_mac_suffix: false\n friendly_name: ${friendly_name}\napi:\n services:\n - service: service_send_door_command\n variables:\n door_data: int\n then:\n - lambda: !lambda |-\n if(door_data >= 0) {\n id($id_prefix).door_command(door_data);\n\nwifi:\n ssid: !secret wifi_ssid\n password: !secret wifi_password","author_login":"alrassia","author_association":"NONE","created_at":"2023-12-26T22:19:13+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1871434349","fragment_type":"issue_comment","sequence":5,"text":"Never mind figured it out, some reformatting and a missing bracket and got it to work","author_login":"alrassia","author_association":"NONE","created_at":"2023-12-28T19:23:16+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873340429","fragment_type":"issue_comment","sequence":6,"text":"I tried 0x4 to 0xf no response, it seems the command is one byte only though as with a second byte the behaviour is the same as with a single one. (0x$1-3 behave like expected, 0 does nothing as expected).","author_login":"alrassia","author_association":"NONE","created_at":"2024-01-01T14:01:46+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873353540","fragment_type":"issue_comment","sequence":7,"text":"...sounds plausible, but I would have thought the gdo response should be the same to the TX2REV button presses to close. Do you have the obstruction sensors still to test if ratgdo will close the door when they are hooked back up? Alternatively, do you have a factory wall control to hook up to see if it closes the door?\n\nIt appears that the wall controls have a press and hold feature to close door in event of obstruction sensor malfunction. I'll take a look at my setup and see what commands the wall control sends to make this happen.","author_login":"mulcmu","author_association":"CONTRIBUTOR","created_at":"2024-01-01T14:39:08+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873381623","fragment_type":"issue_comment","sequence":8,"text":"I tested a bit more:\n\nWhen a command is received by the door an orange led blinks, so all commands are received.\n\nwith the close command when the door is idle (flood light in opener turned itself off) sending the close command does turn on the floodlight but the door does not act. For other incorrect commands this does not happen. This makes it seem there is some sort of interlock at work, that prevent the door from closing.\n\ni have a loose button supplied with the door, however this is a single button device which probably acts like a toggle switch. I will test though but dont expect much.","author_login":"alrassia","author_association":"NONE","created_at":"2024-01-01T16:01:12+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873387198","fragment_type":"issue_comment","sequence":9,"text":"I noticed that the door also signals obstruction on on the webpage (state obstruction in ha). Is that normal?","author_login":"alrassia","author_association":"NONE","created_at":"2024-01-01T16:17:57+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873469222","fragment_type":"issue_comment","sequence":10,"text":"So i did some digging, for the opener i have the ml800ev. To use myq you need an external gateway type 830REV, this comes together with a mandatory obstruction sensor type 771REV. \n\nSo that probably explains it why the door wont close by command, it needs the obstruction sensors to function.","author_login":"alrassia","author_association":"NONE","created_at":"2024-01-01T20:29:33+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1886904069","fragment_type":"issue_comment","sequence":11,"text":"Hi! First of all, a million thanks to @PaulWieland for making this. Just got my RatGDO hardware a couple of days ago, installed it and had it running perfectly in no-time with the ESPHome port of the software. Really awesome, and just the way I would like things to be!!\n\nI came over this issue and wanted to chime in and say I observe the same behavior as you @alrassia. My opener is a Liftmaster LM100EVS produced in 2016. I had to use the leftmost terminal 0 (green) for my \"red\" wire too, and everything seems to work well except I am not allowed to close the door. Opening works fine, light is ok, and all statuses as far as I've been able to see. I also see that it reports an obstruction every time the door is open, so I assume that's causing a close block.\n\nI do not have any obstruction sensors, so I cannot connect any. Manual says it is internally protected so I assume it is some kind of torque or force limitation that will stop the door in case it hits something. First thought that came to my mind was if it could be possible to connect a \"fake sensor\" so that there is never any obstruction observed. Do you guys know what kind of sensor it is? Read somewhere that it may be a resistor bridge with specific ohmic values, but not sure where I got that info. Or is it just a plain dry contact?\n\nOriginally I have four wireless remotes, two small one that lives in the cars and two wall mounted. They continue to work fine together with the RatGDO, and they do allow closing the door also after the RatGDO installation. So I'm not quite sure why they opener is ok with closing, just not from RatGDO. Perhaps it is possible to adapt software somehow to work around this?\n\nAnyway, I will be following the topic. Kindly let me know if I can provide further test/info to support the work.\n\nMy connections and opener model:\n\nimage","author_login":"tmjo","author_association":"NONE","created_at":"2024-01-11T11:10:06+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1900083803","fragment_type":"issue_comment","sequence":12,"text":"I have a similar door (different model but same terminals), and have the same issue with door close not working. I initially had mine wired the same as yours (I presume looking at the terminals in the picture, and had an obstruction warning. I removed the terminal from BLK OBSTR to terminal 3 (grey) and it went away. All other functions appeared to work with no issues (albeit still couldn't close without using the door toggle. I am not sure if the obstruction is the cause of the issue, as I cleared mine and I still can't close.\n\nI can do some testing also if needed. \n\nMine is a different model, but similar looking. URL","author_login":"damaar666","author_association":"NONE","created_at":"2024-01-19T09:49:37+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1904864117","fragment_type":"issue_comment","sequence":13,"text":"I had the same issue with model LM130EVS and ratgdo. All functions worked except close. I can confirm that after connecting Failsafe infrared safety sensor kit (771EV), close function works fine also!","author_login":"jacobpoder","author_association":"NONE","created_at":"2024-01-22T21:37:49+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1905135061","fragment_type":"issue_comment","sequence":14,"text":"I am having the same issues, couldn't close without using toggle:\nimage\nI disconnected the black wire but the close still doesn't work. Let me know if any test I can do to help.","author_login":"tonyma","author_association":"NONE","created_at":"2024-01-23T01:37:00+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907689763","fragment_type":"issue_comment","sequence":15,"text":"I was having the exact same problem, with the exact same model (ML700EV).\n\nI did some testing and bought the cheapest pair of sensors I could find, connected them in, and the ratgdo is now capable of both opening and closing. So it looks like the ratgdo is incompatible with this model of GDO (unable to bypass the lack of sensor, which the GDO itself can do with the wall buttons/remotes).\n\nMay be that the ratgdo team just needs to update something in the code to allow the bypass? Not sure.","author_login":"Rossaluss","author_association":"NONE","created_at":"2024-01-24T09:07:22+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907775052","fragment_type":"issue_comment","sequence":16,"text":"What sensor did you find? In NZ, you can only buy the senors with the MyQ WiFi module, and even in AU it is quite expensive.","author_login":"damaar666","author_association":"NONE","created_at":"2024-01-24T09:49:26+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907860993","fragment_type":"issue_comment","sequence":17,"text":"If you don't need/want the sensors, a resistor can possible be used instead. When I get home, I can measure the voltage across the two terminals with and without the sensors connected and also the current drawn. With that information, we should be able to find a resistor to put in-between the terminals to fake the actual sensors...","author_login":"jacobpoder","author_association":"NONE","created_at":"2024-01-24T10:37:42+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907867960","fragment_type":"issue_comment","sequence":18,"text":"I was reading about this, and I don't believe that will work, as apparently the GDO is expecting some sort of pulsing input that the sensors output, rather than a standard voltage reading. Though do let us know if you do have any luck!","author_login":"Rossaluss","author_association":"NONE","created_at":"2024-01-24T10:41:37+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907882591","fragment_type":"issue_comment","sequence":19,"text":"Would it be easier to fix the firmware other than adding the fake sensor?\n\nGet Outlook for iOS \nSent: Wednesday, January 24, 2024 9:41:47 PM\nTo: ratgdo/esphome-ratgdo ***@***.***>\nCc: Ma, Tony ***@***.***>; Comment ***@***.***>\nSubject: Re: [ratgdo/esphome-ratgdo] Door close command does not work all others do (Issue #146)\n\n[External Email] This email was sent from outside the organisation – be cautious, particularly with links and attachments.\n\nIf you don't need/want the sensors, a resistor can possible be used instead. When I get home, I can measure the voltage across the two terminals with and without the sensors connected and also the current drawn. With that information, we should be able to find a resistor to put in-between the terminals to fake the actual sensors...\n\nI was reading about this, and I don't believe that will work, as apparently the GDO is expecting some sort of pulsing input that the sensors output, rather than a standard voltage reading. Though do let us know if you do have any luck!\n\n—\nReply to this email directly, view it on GitHub","author_login":"tonyma","author_association":"NONE","created_at":"2024-01-24T10:50:43+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[2045162770],"is_known_query_context":false},{"document_id":"gh_comment_1907903310","fragment_type":"issue_comment","sequence":20,"text":"This seems to be a security feature built into the GDO, so unless it can be overridden by a command on the serial interface, it can't be \"fixed\" in the firmware.","author_login":"jacobpoder","author_association":"NONE","created_at":"2024-01-24T11:03:02+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1907915041","fragment_type":"issue_comment","sequence":21,"text":"I may be wrong, but I only recall seeing the pulsing signal when the sensors were obstructed, which is not the state we want to emulate. I'll check later...","author_login":"jacobpoder","author_association":"NONE","created_at":"2024-01-24T11:10:11+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1913618616","fragment_type":"issue_comment","sequence":22,"text":"If you have a ROW opener with an eserial terminal AND all of the following are true:\n\n- you are running the latest version of ratgdo ESP Home\n- you do not have obstruction sensors connected to the door\n- you have disconnected the black ratgdo wire from the door opener\n- the door **does not** respond to the close command from the ratgdo ESP Home Web UI\n- the door **does** close when you click the toggle door command\n\nThen please give this comment a thumbs up.\n\nIf you are experiencing a different issue, please leave a reply explaining what is different from the above.","author_login":"PaulWieland","author_association":"CONTRIBUTOR","created_at":"2024-01-28T14:37:26+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915545928","fragment_type":"issue_comment","sequence":23,"text":"I measured the voltage between sensor terminals to 6.6 VDC without sensors connected and 5.2 VDC with sensors. The current drain was 32 mAh.\n6.6/.032 - (6.6-5.2)/0.032 = 162,5 Ohms\nTested with a 150 Ohm resistor, which resulted in 4.98 VDC across the terminals - didn't work!\nI will see if I can find a resistor to get closer to the 5.2 V target and test again...","author_login":"jacobpoder","author_association":"NONE","created_at":"2024-01-29T20:53:50+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915569495","fragment_type":"issue_comment","sequence":24,"text":"@jacobpoder \n\nA resistor is not going to work. The GDO provides a voltage on the line and the sensors clamp the line to ground at at certain frequency for a certain duration (I can't remember the values, would have to put the oscilloscope on the wire again to look). Anyway, that's why you measure a lower voltage with the sensors on, but it's not a DC voltage, it's a square signal.\n\nYou could emulate it with a microcontroller and a transitor to clamp the line to ground for `x` ms every `y` ms.","author_login":"mariusmuja","author_association":"COLLABORATOR","created_at":"2024-01-29T21:07:31+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915590117","fragment_type":"issue_comment","sequence":25,"text":"@mariusmuja Sounds like the PWM used to detect faulty bulbs in my car... IIRC my multimeter does have a mode to detect duty cycle, so I guess I can try that...","author_login":"jacobpoder","author_association":"NONE","created_at":"2024-01-29T21:19:14+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918333864","fragment_type":"issue_comment","sequence":26,"text":"Hi - I have this exact same issue, also have no sensors, and with the black wire disconnect, close command doesn't work.\n\nIf needed, my logs are at URL \n\nAlso, happy to provide any additional logging if it will help?\n\nIs there an interim solution, where the \"toggle\" command could be sent in place of \"close\"?\n\nThnx","author_login":"danps1","author_association":"NONE","created_at":"2024-01-31T03:52:28+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925020867","fragment_type":"issue_comment","sequence":27,"text":"I forgot to mention earlier - that due to the issues with the esphome firmware, I have been running the MQTT version. MQTT appears to work with cover.close in home assistant. Unsure if the command \"close\" actually uses toggle internally or not, but sending the cover.close command from home assistant does close the garage door via MQTT. Unsure if that means that the GDO is receiving a close command correctly or not, as MQTT may be received and simply toggle. \n\nMay not be useful information but in case, I thought I would comment.","author_login":"damaar666","author_association":"NONE","created_at":"2024-02-03T02:09:19+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925285214","fragment_type":"issue_comment","sequence":28,"text":"I have almost the same problem, but with a strange twist. IF i connect the black wire then my problem is exactly like the one described earlier, aka. everything else works except \"CLOSE\". If I disconnect the black wire as is instructed (I don't have obstruction sensors) also OPEN function stops working! However \"TOGGLE\" still works.","author_login":"mvannas","author_association":"NONE","created_at":"2024-02-03T11:22:23+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925290397","fragment_type":"issue_comment","sequence":29,"text":"As for the people trying to emulate obstruction sensor, it is surprisingly difficult, I tried with manually adjustable electronics circuit without success. \n\nWith a microchip controlled oscillation it works... for a time. It seems I have a bug in control software and it eventually somehow goes off sync because it stops working. I haven't continued with this as it seems to be really difficult to emulate the obstruction sensors and was hoping for an easier and more reliable solution with ratgdo :)","author_login":"mvannas","author_association":"NONE","created_at":"2024-02-03T11:27:40+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928277096","fragment_type":"issue_comment","sequence":30,"text":"That's because the mqtt version only uses toggle commands.\n\nIf you click close, and the door is already closed, the mqtt firmware won't send any wireline command at all (and vice versa with open). \n\nThe ESPHome version sends a command no matter what and lets the GDO decide if it should ignore it depending on the state. The problem here is that ROW openers which have optional obstruction sensors (they are mandatory in NA) ignore the explicit close command if no sensor is connected.","author_login":"PaulWieland","author_association":"CONTRIBUTOR","created_at":"2024-02-05T22:24:58+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928435388","fragment_type":"issue_comment","sequence":31,"text":"I thought that may be the case. Interestingly chamberlain make a point of saying the obstruction sensor is optional in nz, and it has an obstruction reverse feature built in if the GDO senses an obstruction. It is really effective.\n\n@PaulWieland Is it likely to work around it in firmware? I am holding off getting the obstruction sensor, but if you think it is a while odd or very hard to do/a compromise functionality wise, I will order them in from the US. Ones available in nz are super expensive. :)\n\nThanks I advance!","author_login":"damaar666","author_association":"NONE","created_at":"2024-02-05T22:47:56+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928468572","fragment_type":"issue_comment","sequence":32,"text":"The advantage of using a close command vs a toggle command is that the result is a closed door even if ratgdo has the incorrect door state. The disadvantage is that some (all?) GDOs ignore it if no obstruction sensors are connected.\n\nWe could add a feature flag allowing the user to select the behaviour they want.","author_login":"mariusmuja","author_association":"COLLABORATOR","created_at":"2024-02-05T23:08:34+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928826853","fragment_type":"issue_comment","sequence":33,"text":"Is the ratgdo hardware capable of controlling the 6v output of the obstruction pin-out, or is it just passthrough? I noticed that there is a loop function to check the high-low transformation on the obstruction signal which could possibly be also used to emulate the high-low transition every 6.5 ms?","author_login":"mvannas","author_association":"NONE","created_at":"2024-02-06T05:46:50+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1940460025","fragment_type":"issue_comment","sequence":34,"text":"Hi all, thought I would provide a quick update. I have bought and installed some sensors (many thanks @Rossaluss for the recommendation). Now they are installed and everything works reasonably well with the esphome ratgdo firmware and ROW garage door opener.\n\nI did notice one thing: When I close the door (through the close command) on either Home Assistant with cover.close or through the web interface on the device, the light flashes 4 times (roughly 4 seconds) then starts to close. There is no obstruction or issue. It appears that the firmware counts this as it's close time so a door close command is about 4-5seconds longer than it really is. that means if I try to set the door to say, 50%, it doesn't go too far down as it includes the first 4 seconds or so of flashing light. Looking at the logs, it appears to start closing at around 70-65% closed according to the learnt time.\n\nIs that expected behavior? I didn't see anything obvious in the manual. Will do some further investigation. \n\nThanks all for the support. I am glad I have it working now, shame the obstruction sensors were needed, however I will look to mount them properly to get the use out of them, currently just looking at each other on the roof to get things going. \n\n(side note: If anyone buys the Amazon linked ones above, you need to reverse the wires based on the instructions. instructions are terrible and the wires are not very long, so you will need to buy additional connecting wiring. Mounting kit seems good too. Pretty happy considering the cheap price)","author_login":"damaar666","author_association":"NONE","created_at":"2024-02-13T05:40:30+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1975251484","fragment_type":"issue_comment","sequence":35,"text":"Hello, read through this thread as I'm having a similar issue where everything BUT close works. The slight variation to my situation is a I can use the door OPEN command it will close the door. I'm using MQTT and this seems to be working as a toggle.\n\nI'm also quite certain this used to work normally as I have an automation setup the automatically close my GDO after 15 minutes.","author_login":"Nevets77x","author_association":"NONE","created_at":"2024-03-03T18:20:25+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1975727094","fragment_type":"issue_comment","sequence":36,"text":"Could you please share your revised yaml? I'm getting the same error as you were and am not able to figure it out.","author_login":"TesLocker","author_association":"NONE","created_at":"2024-03-04T04:53:27+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2078844344","fragment_type":"issue_comment","sequence":37,"text":"I've bought some cheap obstruction sensors but struggling to get them wired correctly. 2 wires from each, white/black and white. What terminals would you connect these to? Assuming the black wire stays in terminal 3?","author_login":"Stuart5851","author_association":"NONE","created_at":"2024-04-26T08:01:53+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2079811552","fragment_type":"issue_comment","sequence":38,"text":"What terminals do you have? What model GDO? What does it look like?\n\nThis might work for your GDO URL \n\n1. Strip 7/16-inch of insulation from each of the two wires on each sensor—each sensor has two wires, a solid white one and one white with a black stripe, for a total of four wires.\n2. Twist together the two white-with-black-stripe wires from both sensors.\n3. Twist together the two white solid wires from both sensors.\n4. Connect the two white-with-black-stripe wires in the gray terminal on the motor unit.\n5. Connect the two white solid wires in the white terminal next to the gray on the motor unit.","author_login":"rlowens","author_association":"CONTRIBUTOR","created_at":"2024-04-26T17:38:04+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2089591282","fragment_type":"issue_comment","sequence":39,"text":"Experiencing the same issue with the Close button on HA with my Merlin MS65MYQ. No obstruction sensors, and black RATGDO wire is disconnected from the door opener.","author_login":"timsuley","author_association":"NONE","created_at":"2024-05-02T05:08:58+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2138139128","fragment_type":"issue_comment","sequence":40,"text":"I'm running into the same issue at this point as well.\n- Running with ratgdov2.5i e45c76\n- There are **no** obstruction sensors installed.\n- With an opened door when connecting to the dry contact for door close to ground it is registered in the web UI, but the door **won't** close\n- With a closed door when connecting the dry contact for door open the door opens.\n- Using home assistant everything works fine (I believe this uses the toggle action as there only is a single button for open and close)\n- Using the web UI the commands for Door open, Stop and Toggle **work** without issues. Door close has **no** result for the door.\n\nI'm happy to help debug, try-out or any other means that could help would just need a few pointers on what is needed. I would also believe having the door close command to be configured to use the toggle command (as mentioned by @mariusmuja) would be a good option.","author_login":"DannyvdSluijs","author_association":"NONE","created_at":"2024-05-29T19:41:36+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2139226021","fragment_type":"issue_comment","sequence":41,"text":"I believe only real solution to this problem would be emulation of obstruction sensor signal (see my suggestion ealier). Using toggle-function is a workaround. It does work well when you have other remote controls also (meaning that the opening/closing status of the door is unrealiable) or when you want to make sure that the door closes without seeing it (automatic closing). Of course this is the reason it actually doesn't work without obstruction sensors to prevent accidents.","author_login":"mvannas","author_association":"NONE","created_at":"2024-05-30T10:12:22+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2139302502","fragment_type":"issue_comment","sequence":42,"text":"I can see your reasoning but I think the situation can differ from person to person. \n \nFor me the toggle is actually they way my other remotes work. My Chamberlain remote is using a toggle button (there is no explicit open or close button on the remote). And my HomeAssistant also only offers a single button using the toggle function\n \nWhich is logical but not how my specific garage door works. Using RATGDO obviously you can open de door from everywhere in the world. This isn't my use case however, I use RATGDO as an alternative to the physical remotes I dont feel like carrying with me.\n\nAs you can see situations can differ and I'm not advocating for changing the defaults, but I think you can make people happy if the product would allow for a config/setting change in either firmware of in the web UI to match their specific needs. \nHope this explanation helps in understanding.","author_login":"DannyvdSluijs","author_association":"NONE","created_at":"2024-05-30T10:59:25+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2197286820","fragment_type":"issue_comment","sequence":43,"text":"Hey fellas. Any updates with this? I've been using an automation to query the door status every few seconds but that comes with its own issues...","author_login":"chatz86","author_association":"NONE","created_at":"2024-06-28T16:37:38+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2200931908","fragment_type":"issue_comment","sequence":44,"text":"I bought the cheaper obstruction sensors of Amazon a while back. It did fix the closing issue (being blocked and not closing), but I find the ratgdo to be quite poor at opening and closing the garage. I need to investigate more but I consistently get issues with having the right state or responding to open/close events. Unsure why, could be something else but it seems to be very unreliable. So much so I have reinstalled my opengarage controller. I need to investigate more. Unsure if it is related to this model model or not and how it handles open/close service. But overall, has been a bit underwhelming. Will look through other issues and spend more time on it soon(ish).","author_login":"damaar666","author_association":"NONE","created_at":"2024-07-01T20:05:17+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2422907623","fragment_type":"issue_comment","sequence":45,"text":"Sorry for opening up this issue again, but I have this exact issue for some reason while using the latest version. Any tips?","author_login":"GroteGehaktBal","author_association":"NONE","created_at":"2024-10-18T17:13:09+08:00","repo_name":"ratgdo/esphome-ratgdo","issue_id":2045162770,"issue_number":146,"issue_url":"https://github.com/ratgdo/esphome-ratgdo/issues/146","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0195","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Cannot test QER policies with iperf3 (DL)?","query_context":"### TLDR: \nCannot use iperf3 with eUPF. By default, the client isn't able to establish a connection with the server. If i disable the tcp offloading on the gw, the connection is established but I always get 0.00 bits/sec. The result is that i canno test the enforcment of QER in downlink.\n\n### Deployment architecture\n\nmermaid\ngraph LR\n UE[\"UE\"] -->|192.168.60.100| ue1[\"ue1\"]\n ue1 -->|192.168.60.50| gneth2[\"gneth2\"]\n gneth2 --> GNB[\"GNB\"]\n GNB -->|192.168.80.50| gnb_gneth0[\"gneth0\"]\n gnb_gneth0 -->|192.168.80.200| eUPF_eth0[\"eth0\"]\n eUPF_eth0 --> eUPF[\"eUPF\"]\n eUPF -->|192.168.90.200| eUPF_eth2[\"eth2\"]\n eUPF_eth2 -->|192.168.90.100| GW_eth0[\"eth0\"]\n GW_eth0 --> GW[\"GW\"]\n\n style UE fill:#f1c40f,stroke:#333,stroke-width:2px\n style GNB fill:#f1c40f,stroke:#333,stroke-width:2px\n style eUPF fill:#f1c40f,stroke:#333,stroke-width:2px\n style GW fill:#f1c40f,stroke:#333,stroke-width:2px\n\n### Issue report\n#### Test\n* The UE has an active PDU session with the IP 10.45.0.2\n* The PDU Session has a flow with QFI (1), 5QI (9) and UL/DL limit (1Mbs).\n* From the UE, an iperf3 server is set `iperf3 -s`.\n* From the GW, the client is run `iperf3 -c 10.45.0.2`\n\n### UE iperf3 server log\n\n-----------------------------------------------------------\nServer listening on 5201\n-----------------------------------------------------------\nAccepted connection from 192.168.90.100, port 53198\n[ 5] local 10.45.0.2 port 5201 connected to 192.168.90.100 port 53202\n[ ID] Interval Transfer Bitrate\n[ 5] 0.00-1.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec\n- - - - - - - - - - - - - - - - - - - - - - - - -\n[ ID] Interval Transfer Bitrate\n[ 5] 0.00-10.06 sec 0.00 Bytes 0.00 bits/sec receiver\n\n### GW iperf3 client log\n\nConnecting to host 10.45.0.2, port 5201\n[ 5] local 192.168.90.100 port 53202 connected to 10.45.0.2 port 5201\n[ ID] Interval Transfer Bitrate Retr Cwnd\n[ 5] 0.00-1.00 sec 105 KBytes 856 Kbits/sec 1 1.41 KBytes\n[ 5] 1.00-2.01 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n[ 5] 2.01-3.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n[ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n[ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n- - - - - - - - - - - - - - - - - - - - - - - - -\n[ ID] Interval Transfer Bitrate Retr\n[ 5] 0.00-10.00 sec 105 KBytes 85.7 Kbits/sec 5 sender\n[ 5] 0.00-10.06 sec 0.00 Bytes 0.00 bits/sec receiver\n\niperf Done.\n\n### eUPF trace log\n\nsee attachment\n\nMany thanks for your help, and let me know if you need some additional info!\n\neupf_trace_log.txt","known_context_document_ids":["gh_issue_3008523562"],"reference_answer":"Hi @s5uishida,\n\nTry to disable tx offload on iperf server. `ethtool -K eth0 tx off`\n\nThere were several similar issues with iperf in our tests.\n\n URL \n URL \n\n-- BR Alex","answer_document_id":"gh_comment_2164752694","silver_evidence_path":["gh_comment_2819305569","gh_issue_2350212004","gh_comment_2164752694"],"evidence_issue_ids":[3008523562,2350212004],"source_repo_name":"edgecomllc/eupf","source_issue_id":3008523562,"source_issue_number":615,"source_issue_url":"https://github.com/edgecomllc/eupf/issues/615","target_repo_name":"edgecomllc/eupf","target_issue_id":2350212004,"target_issue_number":555,"target_issue_url":"https://github.com/edgecomllc/eupf/issues/555","reference_anchor_document_id":"gh_comment_2819305569","reference_answer_author":"pirog-spb","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.1176,"target_answer_overlap":0.1333},"issue_created_at":"2025-04-21T14:21:45+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_3008523562","fragment_type":"issue_description","sequence":0,"text":"Cannot test QER policies with iperf3 (DL)\n### TLDR: \nCannot use iperf3 with eUPF. By default, the client isn't able to establish a connection with the server. If i disable the tcp offloading on the gw, the connection is established but I always get 0.00 bits/sec. The result is that i canno test the enforcment of QER in downlink.\n\n### Deployment architecture\n\nmermaid\ngraph LR\n UE[\"UE\"] -->|192.168.60.100| ue1[\"ue1\"]\n ue1 -->|192.168.60.50| gneth2[\"gneth2\"]\n gneth2 --> GNB[\"GNB\"]\n GNB -->|192.168.80.50| gnb_gneth0[\"gneth0\"]\n gnb_gneth0 -->|192.168.80.200| eUPF_eth0[\"eth0\"]\n eUPF_eth0 --> eUPF[\"eUPF\"]\n eUPF -->|192.168.90.200| eUPF_eth2[\"eth2\"]\n eUPF_eth2 -->|192.168.90.100| GW_eth0[\"eth0\"]\n GW_eth0 --> GW[\"GW\"]\n\n style UE fill:#f1c40f,stroke:#333,stroke-width:2px\n style GNB fill:#f1c40f,stroke:#333,stroke-width:2px\n style eUPF fill:#f1c40f,stroke:#333,stroke-width:2px\n style GW fill:#f1c40f,stroke:#333,stroke-width:2px\n\n### Issue report\n#### Test\n* The UE has an active PDU session with the IP 10.45.0.2\n* The PDU Session has a flow with QFI (1), 5QI (9) and UL/DL limit (1Mbs).\n* From the UE, an iperf3 server is set `iperf3 -s`.\n* From the GW, the client is run `iperf3 -c 10.45.0.2`\n\n### UE iperf3 server log\n\n-----------------------------------------------------------\nServer listening on 5201\n-----------------------------------------------------------\nAccepted connection from 192.168.90.100, port 53198\n[ 5] local 10.45.0.2 port 5201 connected to 192.168.90.100 port 53202\n[ ID] Interval Transfer Bitrate\n[ 5] 0.00-1.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec\n[ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec\n- - - - - - - - - - - - - - - - - - - - - - - - -\n[ ID] Interval Transfer Bitrate\n[ 5] 0.00-10.06 sec 0.00 Bytes 0.00 bits/sec receiver\n\n### GW iperf3 client log\n\nConnecting to host 10.45.0.2, port 5201\n[ 5] local 192.168.90.100 port 53202 connected to 10.45.0.2 port 5201\n[ ID] Interval Transfer Bitrate Retr Cwnd\n[ 5] 0.00-1.00 sec 105 KBytes 856 Kbits/sec 1 1.41 KBytes\n[ 5] 1.00-2.01 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n[ 5] 2.01-3.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n[ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n[ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes\n[ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes\n- - - - - - - - - - - - - - - - - - - - - - - - -\n[ ID] Interval Transfer Bitrate Retr\n[ 5] 0.00-10.00 sec 105 KBytes 85.7 Kbits/sec 5 sender\n[ 5] 0.00-10.06 sec 0.00 Bytes 0.00 bits/sec receiver\n\niperf Done.\n\n### eUPF trace log\n\nsee attachment\n\nMany thanks for your help, and let me know if you need some additional info!\n\neupf_trace_log.txt","author_login":"xAlessandroC","author_association":"NONE","created_at":"2025-04-21T14:21:45+08:00","repo_name":"edgecomllc/eupf","issue_id":3008523562,"issue_number":615,"issue_url":"https://github.com/edgecomllc/eupf/issues/615","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2819305569","fragment_type":"issue_comment","sequence":1,"text":"Hi Alessandro @xAlessandroC \n\nMost of the problems we had with iperf were solved tuning drivers offloading features(because of incorrect checksum calculating) or MTU.\n\nSo using tcpdump please verify(if possible) that:\n\n1. Iperf server generates packets in DL direction\n2. These packets pass through eUPF\n3. Iperf client receives DL packets\n4. DL packets have valid checksum\n\nPlease see details from out iperf related cases here #555 \n\n--BR Alex","author_login":"pirog-spb","author_association":"COLLABORATOR","created_at":"2025-04-21T19:18:30+08:00","repo_name":"edgecomllc/eupf","issue_id":3008523562,"issue_number":615,"issue_url":"https://github.com/edgecomllc/eupf/issues/615","linked_issue_ids":[2350212004],"is_known_query_context":false},{"document_id":"gh_comment_2819464295","fragment_type":"issue_comment","sequence":2,"text":"Hi @pirog-spb,\nMany thanks for your response and help!\n\nI have attached the pcap file, captured using tcpdump + Wireshark, related to a single execution of the iperf3 tool (I had to change the extension). The settings are the same as explained above.\nAlso, I forgot to mention that, on the GW, I disabled the TCP offloading with `ethtool -K eth0 tx off`.\n\nIn general, I noticed a lot of retransmissions. The packets seem to flow in the correct direction since I have data flowing from 192.168.90.100 to 10.45.0.2. Also, they pass through the eUPF since I have a trace log similar to the one I attached in the previous comment.\n\nWith respect to the issues (#396 and #170), I'm not able to understand if it is a problem with checksums. These are the outputs of the `netstat -t -s` command.\n\n# UE (10.45.0.2)\n\nTcp:\n 1 active connection openings\n 2 passive connection openings\n 0 failed connection attempts\n 0 connection resets received\n 1 connections established\n 1856290 segments received\n 42463462 segments sent out\n 1055 segments retransmitted\n 0 bad segments received\n 0 resets sent\nUdpLite:\nTcpExt:\n 1 TCP sockets finished time wait in fast timer\n 50 packetes rejected in established connections because of timestamp\n 2 delayed acks sent\n Quick ack mode was activated 232 times\n 1181948 packet headers predicted\n 298585 acknowledgments not containing data payload received\n 129153 predicted acknowledgments\n TCPSackRecovery: 49\n Detected reordering 85 times using SACK\n Detected reordering 5 times using time stamp\n 7 congestion windows fully recovered without slow start\n 5 congestion windows partially recovered using Hoe heuristic\n TCPDSACKUndo: 6\n 1055 fast retransmits\n TCPLossProbes: 2\n TCPBacklogCoalesce: 10199\n TCPDSACKOldSent: 232\n TCPDSACKRecv: 43\n TCPDSACKIgnoredOld: 2\n TCPDSACKIgnoredNoUndo: 1\n TCPSackMerged: 117\n TCPSackShiftFallback: 79\n TCPRcvCoalesce: 367940\n TCPOFOQueue: 2898\n TCPSpuriousRtxHostQueues: 164\n TCPAutoCorking: 4816\n TCPOrigDataSent: 41955124\n TCPHystartTrainDetect: 1\n TCPHystartTrainCwnd: 42\n TCPACKSkippedPAWS: 12\n TCPACKSkippedSeq: 8\n TCPDelivered: 41956138\n TCPAckCompressed: 1202\n TCPDSACKRecvSegs: 1055\nIpExt:\n InOctets: 44945640067\n OutOctets: 60382288144\n InNoECTPkts: 31795937\n\n# GW (192.168.90.100)\n\nTcp:\n 7 active connection openings\n 0 passive connection openings\n 0 failed connection attempts\n 0 connection resets received\n 0 connections established\n 10931 segments received\n 6622 segments sent out\n 8 segments retransmitted\n 0 bad segments received\n 0 resets sent\nUdpLite:\nTcpExt:\n 6 TCP sockets finished time wait in fast timer\n 4 delayed acks sent\n 8802 packet headers predicted\n 8 acknowledgments not containing data payload received\n 18 predicted acknowledgments\n TCPLostRetransmit: 7\n TCPTimeouts: 9\n TCPLossProbes: 1\n TCPBacklogCoalesce: 10\n 1 connections aborted due to timeout\n TCPRcvCoalesce: 3253\n TCPOFOQueue: 1762\n TCPOrigDataSent: 53\n TCPDelivered: 49\n TCPAckCompressed: 963\n TcpTimeoutRehash: 8\nIpExt:\n InOctets: 44905467\n OutOctets: 400742\n InNoECTPkts: 30701\n\n# UPF (192.168.90.200)\n\nIcmpMsg:\n InType3: 19\n InType5: 3\n OutType3: 834\nTcp:\n 2 active connection openings\n 0 passive connection openings\n 0 failed connection attempts\n 2 connection resets received\n 0 connections established\n 820 segments received\n 452 segments sent out\n 0 segments retransmitted\n 0 bad segments received\n 2 resets sent\nUdpLite:\nTcpExt:\n 1 ICMP packets dropped because socket was locked\n 1 delayed acks sent\n 714 packet headers predicted\n 16 acknowledgments not containing data payload received\n 4 predicted acknowledgments\n TCPBacklogCoalesce: 1\n 2 connections reset due to early user close\n TCPRcvCoalesce: 399\n TCPOrigDataSent: 20\n TCPDelivered: 22\nIpExt:\n InOctets: 4534954\n OutOctets: 215624\n InNoECTPkts: 5656\n\nFinally, concerning issue #555, the guy had a fragmented IP and solved the issue by setting a proper MTU value. I think this is not the case.\n\nMany thanks again!\n\niperf3_eupf_test.pcap.txt","author_login":"xAlessandroC","author_association":"NONE","created_at":"2025-04-21T20:42:31+08:00","repo_name":"edgecomllc/eupf","issue_id":3008523562,"issue_number":615,"issue_url":"https://github.com/edgecomllc/eupf/issues/615","linked_issue_ids":[2350212004],"is_known_query_context":false},{"document_id":"gh_comment_2819492788","fragment_type":"issue_comment","sequence":3,"text":"for the filtering of the pcap I used \"gtp or iperf3\" on wireshark","author_login":"xAlessandroC","author_association":"NONE","created_at":"2025-04-21T20:58:27+08:00","repo_name":"edgecomllc/eupf","issue_id":3008523562,"issue_number":615,"issue_url":"https://github.com/edgecomllc/eupf/issues/615","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2829954921","fragment_type":"issue_comment","sequence":4,"text":"Hi @s5uishida,\nMany thanks for the answer. By setting the MTU to 1456 and disabling TX offloading, I'm able to run iperf3 without getting a 0 bitrate.","author_login":"xAlessandroC","author_association":"NONE","created_at":"2025-04-25T09:57:00+08:00","repo_name":"edgecomllc/eupf","issue_id":3008523562,"issue_number":615,"issue_url":"https://github.com/edgecomllc/eupf/issues/615","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2350212004","fragment_type":"issue_description","sequence":0,"text":"iperf3 doesn't work when connected to srsRAN\nHi Community,\n\nWhen eUPF was connected to either srsRAN 5G or 4G, iperf3 did not work properly.\n\nThe configuration tested for 5G is shown in the diagram below, with PacketRusher replaced with srsRAN_Project (gNodeB) and srsRAN_4G (UE).\n\n URL \n\nAlso, the configuration tested with 4G is shown below.\n\n URL \n\nA quick note on the results is as follows. This time the question is about the row where the combination of eUPF and srsRAN is NG.\n\n URL \n\nPing from UE to VM-DN (192.168.16.152) was successful.\n\n# ping 192.168.16.152 -c 10\nPING 192.168.16.152 (192.168.16.152) 56(84) bytes of data.\n64 bytes from 192.168.16.152: icmp_seq=1 ttl=64 time=43.7 ms\n64 bytes from 192.168.16.152: icmp_seq=2 ttl=64 time=66.6 ms\n64 bytes from 192.168.16.152: icmp_seq=3 ttl=64 time=57.3 ms\n64 bytes from 192.168.16.152: icmp_seq=4 ttl=64 time=54.6 ms\n64 bytes from 192.168.16.152: icmp_seq=5 ttl=64 time=52.5 ms\n64 bytes from 192.168.16.152: icmp_seq=6 ttl=64 time=50.8 ms\n64 bytes from 192.168.16.152: icmp_seq=7 ttl=64 time=44.9 ms\n64 bytes from 192.168.16.152: icmp_seq=8 ttl=64 time=44.0 ms\n64 bytes from 192.168.16.152: icmp_seq=9 ttl=64 time=47.0 ms\n64 bytes from 192.168.16.152: icmp_seq=10 ttl=64 time=48.3 ms\n\n--- 192.168.16.152 ping statistics ---\n10 packets transmitted, 10 received, 0% packet loss, time 9134ms\nrtt min/avg/max/mdev = 43.651/50.972/66.602/6.790 ms\n\nHowever, iperf3 from UE to VM-DN (192.168.16.152) does not work properly as follows. `Transfer` and `Bitrate` were zero.\n\n# iperf3 -B 10.45.0.2 -c 192.168.16.152\nConnecting to host 192.168.16.152, port 5201\n[ 5] local 10.45.0.2 port 53983 connected to 192.168.16.152 port 5201\n[ ID] Interval Transfer Bitrate Retr Cwnd\n[ 5] 0.00-1.00 sec 76.4 KBytes 625 Kbits/sec 2 1.41 KBytes \n[ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes \n[ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes \n[ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes \n[ 5] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes \n[ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes \n[ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes \n[ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes \n[ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes \n[ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes \n- - - - - - - - - - - - - - - - - - - - - - - - -\n[ ID] Interval Transfer Bitrate Retr\n[ 5] 0.00-10.00 sec 76.4 KBytes 62.5 Kbits/sec 5 sender\n[ 5] 0.00-10.07 sec 0.00 Bytes 0.00 bits/sec receiver\n\niperf Done.\n\nThe results were the same for both 5G and 4G.\n\nCould you know anything for the reason?\n\nBest regards,\n\n--Shigeru","author_login":"s5uishida","author_association":"NONE","created_at":"2024-06-13T05:50:17+08:00","repo_name":"edgecomllc/eupf","issue_id":2350212004,"issue_number":555,"issue_url":"https://github.com/edgecomllc/eupf/issues/555","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164752694","fragment_type":"issue_comment","sequence":1,"text":"Hi @s5uishida,\n\nTry to disable tx offload on iperf server. `ethtool -K eth0 tx off`\n\nThere were several similar issues with iperf in our tests.\n\n URL \n URL \n\n-- BR Alex","author_login":"pirog-spb","author_association":"COLLABORATOR","created_at":"2024-06-13T07:10:01+08:00","repo_name":"edgecomllc/eupf","issue_id":2350212004,"issue_number":555,"issue_url":"https://github.com/edgecomllc/eupf/issues/555","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2167170727","fragment_type":"issue_comment","sequence":2,"text":"Hi @pirog-spb \n\nAlthough it's different from the method you told me, I solved it in the following way:\n\n URL \n\nThank you very much for your useful information!","author_login":"s5uishida","author_association":"NONE","created_at":"2024-06-14T04:06:06+08:00","repo_name":"edgecomllc/eupf","issue_id":2350212004,"issue_number":555,"issue_url":"https://github.com/edgecomllc/eupf/issues/555","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0197","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Organizing reusable blocks with categories or similar?","query_context":"Creating shared blocks is awesome, but what happens when you start getting a fair amount of them?\n\nThings start to become hard to use, they take up screen space, finding that one block you wanted becomes a burden.\n\nAdding some way to categorize shared blocks will likely be necessary moving forward, especially if we wish to do more in line with adding sidebar control etc to the editor experience.\n\n#7606 looks like it might be a good stepping stone in that direction.\n\nOne might argue that naming your blocks to find them easier is the right choice, and using the block search after this to find them. Although that would be nice in a perfect world, with limited space for block names you just can't rely on naming alone.\n\nimage\nThe example above is possibly a bit extreme, possibly not, we don't know how users will choose to name things.","known_context_document_ids":["gh_issue_336646464"],"reference_answer":"Taxonomy is correct — the thing I'm worried about is the overlap between semantic template parts and pattern categories, specially given they are separate objects (`wp_template_part` and `wp_block`). Which would render a term of \"header\" associated only with wp_block ambiguous. We might need to share the taxonomy.","answer_document_id":"gh_comment_1671039875","silver_evidence_path":["gh_comment_1730067201","gh_issue_1828380168","gh_comment_1671039875"],"evidence_issue_ids":[336646464,1828380168],"source_repo_name":"WordPress/gutenberg","source_issue_id":336646464,"source_issue_number":7608,"source_issue_url":"https://github.com/WordPress/gutenberg/issues/7608","target_repo_name":"WordPress/gutenberg","target_issue_id":1828380168,"target_issue_number":53164,"target_issue_url":"https://github.com/WordPress/gutenberg/issues/53164","reference_anchor_document_id":"gh_comment_1730067201","reference_answer_author":"mtias","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2727,"anchor_target_overlap":0.3636,"target_answer_overlap":0.2308},"issue_created_at":"2018-06-28T14:30:10+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_336646464","fragment_type":"issue_description","sequence":0,"text":"Organizing reusable blocks with categories or similar\nCreating shared blocks is awesome, but what happens when you start getting a fair amount of them?\n\nThings start to become hard to use, they take up screen space, finding that one block you wanted becomes a burden.\n\nAdding some way to categorize shared blocks will likely be necessary moving forward, especially if we wish to do more in line with adding sidebar control etc to the editor experience.\n\n#7606 looks like it might be a good stepping stone in that direction.\n\nOne might argue that naming your blocks to find them easier is the right choice, and using the block search after this to find them. Although that would be nice in a perfect world, with limited space for block names you just can't rely on naming alone.\n\nimage\nThe example above is possibly a bit extreme, possibly not, we don't know how users will choose to name things.","author_login":"Clorith","author_association":"MEMBER","created_at":"2018-06-28T14:30:10+08:00","repo_name":"WordPress/gutenberg","issue_id":336646464,"issue_number":7608,"issue_url":"https://github.com/WordPress/gutenberg/issues/7608","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1633597592","fragment_type":"issue_comment","sequence":1,"text":"Just checking on this for opinions on whether the new Patterns interface in the Site Editor, and changes in the Block Inserter has resolved this issue - or if user-designated categorisation of patterns would be helpful?","author_login":"jordesign","author_association":"CONTRIBUTOR","created_at":"2023-07-13T05:57:10+08:00","repo_name":"WordPress/gutenberg","issue_id":336646464,"issue_number":7608,"issue_url":"https://github.com/WordPress/gutenberg/issues/7608","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1730067201","fragment_type":"issue_comment","sequence":2,"text":"Closing this out as we have converted reusable blocks to synced patterns and categories are now possible/slated for 6.4: URL","author_login":"annezazu","author_association":"CONTRIBUTOR","created_at":"2023-09-21T18:09:36+08:00","repo_name":"WordPress/gutenberg","issue_id":336646464,"issue_number":7608,"issue_url":"https://github.com/WordPress/gutenberg/issues/7608","linked_issue_ids":[1828380168],"is_known_query_context":false},{"document_id":"gh_issue_1828380168","fragment_type":"issue_description","sequence":0,"text":"Patterns: add categories to user created patterns\n## Overview\nCurrently, there is no way for users to categorize/arrange their synced and unsynced patterns, they all appear under the 'My patterns' category.\n\n### Proposed solution?\nAdd a WP custom taxonomy called `wp_pattern_category` for the `wp_block` CPT. \n\nThe .org and theme patterns have a category registry, but these categories are generated on load based on the .org and theme patterns that are currently available to the site. There is no way for users to add/save their own categories, or to assign them to the `wp_block` CPT.\n\nOptions were explored of adding the existing pattern slugs to the `wp_block` CPT postmeta, but there would be performance issues with retrieving all patterns with a given category with this approach, and this also does not allow users to add their own categories.\n\nWP taxonomies are a standard way to allow categorization of custom CPTs, and all the add/update/search functionality already exists, so this seems like the best way to add this functionality.\n\n**N.B.** Tasks 2-5 below should all go into the same release, so ideally should be merged only when all 6 are ready to go\n#53835 is the parent PR\n#53837 & #53933 are branched off #53835 \n#54007 is branched off #53933\n\nso merge order should be #54007, #53933, #53837, #53835 \n\n### Tasks\n\n- [x] 1. Add custom taxonomy - PR\n- [x] 2. Add UI to the create pattern modal to select a category - PR\n- [x] 3. Display the categories in the site editor patterns page - PR\n- [x] 4. Display categories in the post editor inserter patterns tab - PR\n- [x] 5. Merge the synced patterns into post editor inserter patterns tab - PR\n- [x] Once the above PRs are merge retest URL to make sure it is resolved\n- [x] Add additional filtering options to site editor patterns list page, eg. 'My synced patterns, My unsynced patterns, Theme patterns, etc.\n- [x] Get the category to save in add pattern model if user doesn't hit enter or `,` - PR merged into #53835\n- [x] Add ability to edit categories of existing patterns into site editor - PR","author_login":"glendaviesnz","author_association":"CONTRIBUTOR","created_at":"2023-07-31T04:27:01+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1657544657","fragment_type":"issue_comment","sequence":1,"text":"@aaronrobertshaw, @kevin940726, @youknowriad, @Mamaduka let me know if you have any thoughts on whether a standard WP custom taxonomy is the best approach for this.","author_login":"glendaviesnz","author_association":"CONTRIBUTOR","created_at":"2023-07-31T04:30:23+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1658128757","fragment_type":"issue_comment","sequence":2,"text":"Agreed, taxonomies are more suited for this and are more performant when querying the items vs. post meta.\n\nP.S. We should probably drop the `custom` from the name - `wp_pattern_category`. The entities that ship with WordPress are native.","author_login":"Mamaduka","author_association":"MEMBER","created_at":"2023-07-31T10:51:13+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1658270915","fragment_type":"issue_comment","sequence":3,"text":"I too think taxonomy is the way to go. The reason is that the template parts area is also registered as a taxonomy and I think the pattern should be able to have a similar design.","author_login":"t-hamano","author_association":"CONTRIBUTOR","created_at":"2023-07-31T12:24:42+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1659221004","fragment_type":"issue_comment","sequence":4,"text":"Have made that change on the PR. In my mind I was thinking of `custom` as being the user's custom patterns as opposed to the theme/.org patterns, but I can see how that wording would be confusing.","author_login":"glendaviesnz","author_association":"CONTRIBUTOR","created_at":"2023-07-31T21:44:29+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1661512083","fragment_type":"issue_comment","sequence":5,"text":"+1 to pattern categories via a taxonomy.\n\nThe querying performance, consistency with template parts, and leveraging of existing features are all compelling reasons to me.","author_login":"aaronrobertshaw","author_association":"CONTRIBUTOR","created_at":"2023-08-02T05:21:10+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1671039875","fragment_type":"issue_comment","sequence":6,"text":"Taxonomy is correct — the thing I'm worried about is the overlap between semantic template parts and pattern categories, specially given they are separate objects (`wp_template_part` and `wp_block`). Which would render a term of \"header\" associated only with wp_block ambiguous. We might need to share the taxonomy.","author_login":"mtias","author_association":"MEMBER","created_at":"2023-08-09T10:07:10+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1672535635","fragment_type":"issue_comment","sequence":7,"text":"Thanks for raising the concern about the crossover with template parts. This overlap was already an issue with the pattern categories that are assigned to .org/theme patterns. This is one of the main reasons the `Template parts` heading was put back in the `Patterns` section of the site editor as there were two entries of `header` and `footer` one for patterns and one for template parts, and no clear indication to users why they were duplicated.\n\n<img width=\"336\" alt=\"Screenshot 2023-08-10 at 4 05 11 PM\" src=\" URL \n\nIn the short term giving users the ability to add their own patterns to a `header` or `footer` category won't add any additional ambiguity to what is already there (the user pattern categories will be merged with the .org/theme pattern categories).\n\nI agree though that it would be good to have a shared taxonomy so users just see one `Header` or `Footer` category, which would then show them all the template parts & patterns related to headers and footers. Exactly how this might be achieved depends on how/when/if template parts might merge with patterns.\n\nWhile we could reuse the existing `wp_template_part_area` taxonomy for patterns it is an odd fit name-wise, and I am not sure about the risks of a rename in terms of database migrations, backwards compat with plugins, etc. \n\nIt seems like the lower-risk option is to proceed with adding the `wp_patterns_category`. Then the first step of removing the ambiguity could be to merge the template and pattern category results in the patterns page. Once the future of template parts in relation to patterns is decided decisions could then be made on how taxonomies could be further merged, and based on recent changes it seems like this is more likely to be template parts merging to patterns rather than the other way around, so the `wp_patterns_category` is more likely to be the taxonomy that is still needed.\n\nLet me know if you have any different views/thoughts on this.","author_login":"glendaviesnz","author_association":"CONTRIBUTOR","created_at":"2023-08-10T04:27:57+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1728591186","fragment_type":"issue_comment","sequence":8,"text":"This work has been completed and is in GB 16.7 which will be used in the 6.4 beta release","author_login":"glendaviesnz","author_association":"CONTRIBUTOR","created_at":"2023-09-21T00:28:15+08:00","repo_name":"WordPress/gutenberg","issue_id":1828380168,"issue_number":53164,"issue_url":"https://github.com/WordPress/gutenberg/issues/53164","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0200","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Inconsistency in Generic Inference for Private Properties?","query_context":"### 🔎 Search Terms\n\nd.ts, dts, private, type inference, generics\n\n### 🕗 Version & Regression Information\n\n- This is the behavior in every version\n\n### ⏯ Playground Link\n\n URL \n\n### 💻 Code\n\ntypescript\nclass MyClass1 {\n private a: A;\n constructor(a: A) {\n this.a = a\n }\n}\nclass MyClass1Sub extends MyClass1 {\n}\ntype X1 = MyClass1Sub extends MyClass1 ? x : never\n// X1 is number\n\n// when the TypeScript compiler generates the corresponding d.ts file\n// it omits the type annotation for the private member a in the MyClass1 definition:\n// (To avoid confusion, we are changing the name from MyClass1 to MyClass2)\ndeclare class MyClass2 {\n private a;\n constructor(a: A)\n}\nclass MyClass2Sub extends MyClass2 {\n}\ntype X2 = MyClass2Sub extends MyClass2 ? x : never\n// X2 is unknown\n\n### 🙁 Actual behavior\n\nBecause the type of a is lost after compilation, X2 is inferred as unknown.\n\n### 🙂 Expected behavior\n\nConsider I am writing a package, ProjectA, where I have MyClass1 defined.\nNow, after compiling and publishing ProjectA, I reference it in another package, ProjectB.\nIn ProjectA, I can infer the generics of MyClass1Sub, but not in ProjectB.\nI want the type inference to be consistent before and after code compilation.\n\n### Additional information about the issue\n\nI've noticed this issue: URL \nI can also understand the rationale behind it: since private properties aren't accessed externally, there might seem to be no need to annotate their types.\nHowever, I believe this viewpoint is one-sided. Besides external access, there are many situations where type annotation is necessary, such as the cases of inheritance and inference that I mentioned here.","known_context_document_ids":["gh_issue_2285551440"],"reference_answer":"To solve the `Endpoint` case, you'd use an intersection.\n\nPrivate fields appearing in a structural position where they can never be legally accessed, and would have fairly confusing semantics (are they allowed to merge via intersection? how?) is a sort of \"a screwdriver is a hammer if you hold it by the pointy end\" solution -- it *would* work, but the right fix is clearly nominal types.","answer_document_id":"gh_comment_1312086828","silver_evidence_path":["gh_comment_2100577302","gh_issue_1445809865","gh_comment_1312086828"],"evidence_issue_ids":[2285551440,1445809865],"source_repo_name":"microsoft/TypeScript","source_issue_id":2285551440,"source_issue_number":58470,"source_issue_url":"https://github.com/microsoft/TypeScript/issues/58470","target_repo_name":"microsoft/TypeScript","target_issue_id":1445809865,"target_issue_number":51489,"target_issue_url":"https://github.com/microsoft/TypeScript/issues/51489","reference_anchor_document_id":"gh_comment_2100577302","reference_answer_author":"RyanCavanaugh","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3571,"anchor_target_overlap":0.2857,"target_answer_overlap":0.1562},"issue_created_at":"2024-05-08T13:04:40+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2285551440","fragment_type":"issue_description","sequence":0,"text":"Inconsistency in Generic Inference for Private Properties\n### 🔎 Search Terms\n\nd.ts, dts, private, type inference, generics\n\n### 🕗 Version & Regression Information\n\n- This is the behavior in every version\n\n### ⏯ Playground Link\n\n URL \n\n### 💻 Code\n\ntypescript\nclass MyClass1 {\n private a: A;\n constructor(a: A) {\n this.a = a\n }\n}\nclass MyClass1Sub extends MyClass1 {\n}\ntype X1 = MyClass1Sub extends MyClass1 ? x : never\n// X1 is number\n\n// when the TypeScript compiler generates the corresponding d.ts file\n// it omits the type annotation for the private member a in the MyClass1 definition:\n// (To avoid confusion, we are changing the name from MyClass1 to MyClass2)\ndeclare class MyClass2 {\n private a;\n constructor(a: A)\n}\nclass MyClass2Sub extends MyClass2 {\n}\ntype X2 = MyClass2Sub extends MyClass2 ? x : never\n// X2 is unknown\n\n### 🙁 Actual behavior\n\nBecause the type of a is lost after compilation, X2 is inferred as unknown.\n\n### 🙂 Expected behavior\n\nConsider I am writing a package, ProjectA, where I have MyClass1 defined.\nNow, after compiling and publishing ProjectA, I reference it in another package, ProjectB.\nIn ProjectA, I can infer the generics of MyClass1Sub, but not in ProjectB.\nI want the type inference to be consistent before and after code compilation.\n\n### Additional information about the issue\n\nI've noticed this issue: URL \nI can also understand the rationale behind it: since private properties aren't accessed externally, there might seem to be no need to annotate their types.\nHowever, I believe this viewpoint is one-sided. Besides external access, there are many situations where type annotation is necessary, such as the cases of inheritance and inference that I mentioned here.","author_login":"lsby","author_association":"NONE","created_at":"2024-05-08T13:04:40+08:00","repo_name":"microsoft/TypeScript","issue_id":2285551440,"issue_number":58470,"issue_url":"https://github.com/microsoft/TypeScript/issues/58470","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2100577302","fragment_type":"issue_comment","sequence":1,"text":"Inherited classes should not access `private` members. Removing the type is/was necessary for compatibility/implementation-hiding reasons: URL \n\nThis is somewhat a duplicate of #51489.","author_login":"MartinJohns","author_association":"CONTRIBUTOR","created_at":"2024-05-08T13:27:54+08:00","repo_name":"microsoft/TypeScript","issue_id":2285551440,"issue_number":58470,"issue_url":"https://github.com/microsoft/TypeScript/issues/58470","linked_issue_ids":[1445809865],"is_known_query_context":false},{"document_id":"gh_comment_2100763071","fragment_type":"issue_comment","sequence":2,"text":"@MartinJohns \n\nAlright, after reviewing the information you provided, I understand the complexity of this issue.\n\nThere are indeed several ways to address this problem, such as using `protected` or using a symbol to retain the type.\n\ntypescript\nconst xxx: unique symbol = Symbol()\nclass MyClass1 {\n declare [xxx]: A\n private a: A;\n constructor(a: A) {\n this.a = a\n }\n}\n\nHowever, one concern is that I test my code in ProjectA, everything works fine, but only after compiling, publishing, and then importing into ProjectB do I encounter the issue. This situation is troublesome because I have to go back and modify ProjectA.\n\nIdeally, if such coding practices are not allowed, I would prefer to be notified of errors while writing ProjectA.\n\nI expect consistency in behavior before and after code compilation.","author_login":"lsby","author_association":"NONE","created_at":"2024-05-08T14:47:48+08:00","repo_name":"microsoft/TypeScript","issue_id":2285551440,"issue_number":58470,"issue_url":"https://github.com/microsoft/TypeScript/issues/58470","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100805438","fragment_type":"issue_comment","sequence":3,"text":"So even though the property is private, it has observable structural implications that are lost in the generated typings. \n\nWould the ideal be that private properties be hidden from inference machinery so that code like `type X2 = MyClass2Sub extends MyClass2 ? x : never` would always yield `never`?","author_login":"snarbies","author_association":"NONE","created_at":"2024-05-08T15:07:49+08:00","repo_name":"microsoft/TypeScript","issue_id":2285551440,"issue_number":58470,"issue_url":"https://github.com/microsoft/TypeScript/issues/58470","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1445809865","fragment_type":"issue_description","sequence":0,"text":"Make it possible to use private fields in type declarations\n# Suggestion\n\n## 🔍 Search Terms\n\nprivate field type declaration\n\n## ✅ Viability Checklist\n\nMy suggestion meets these guidelines:\n\n* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code\n* [x] This wouldn't change the runtime behavior of existing JavaScript code\n* [x] This could be implemented without emitting different JS based on the types of the expressions\n* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)\n* [x] This feature would agree with the rest of TypeScript's Design Goals.\n\n## ⭐ Suggestion\n\nMake it possible to use private fields in type declarations, like:\n\ntype MyType = { a: number; #marker: T };\ntype GetMarkerType = T extends { #marker: infer TResult } ? TResult : never;\n\nCurrently this gives an error saying that private fields can only be used inside classes. It is true that no code can be generated for private fields outside classes, but no code is generated when declaring a type.\n\n## 📃 Motivating Example\n\nSometimes it is nice to add markers to a type that define how the type can be used (`PhantomData ` in Rust).\n\nIn my case, I automatically generate endpoint definition like\n\ngetUser = { method: 'GET', path: '/something' } as Endpoint ;\n\nMy definition of `Endpoint` currently looks like\n\ntype Endpoint = { method: 'GET' | 'POST'; path: string; __markerBody: T }\n\nThis works, but the only thing that says that the body is fake is the ugly name. If I could instead write\n\ntype Endpoint = { method: 'GET' | 'POST'; path: string; #markerBody: T }\n\nno one could even possibly try to access the marker, and there would be no reason for the editor to ever show it.\n\nThis feature could also be used in libraries, where you might want opaque state objects to be passed between methods, like\n\ntype StateObject = { #marker: 'opaque' };\nfunction createStateObject(initial: string): StateObject {\n return { initial } as StateObject;\n}\n\nfunction getInitialValue(obj: StateObject) {\n const realObject = obj as { initial: string };\n return realObject.initial;\n}","author_login":"erik-kallen","author_association":"NONE","created_at":"2022-11-11T17:46:44+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312020208","fragment_type":"issue_comment","sequence":1,"text":"Since the use case is for branded types, you probably want URL","author_login":"fatcerberus","author_association":"NONE","created_at":"2022-11-11T18:12:22+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312046737","fragment_type":"issue_comment","sequence":2,"text":"#21625 seems unrelated. #202 seems to solve the use case with opaque types, but not the `Endpoint` case.","author_login":"erik-kallen","author_association":"NONE","created_at":"2022-11-11T18:24:37+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312086828","fragment_type":"issue_comment","sequence":3,"text":"To solve the `Endpoint` case, you'd use an intersection.\n\nPrivate fields appearing in a structural position where they can never be legally accessed, and would have fairly confusing semantics (are they allowed to merge via intersection? how?) is a sort of \"a screwdriver is a hammer if you hold it by the pointy end\" solution -- it *would* work, but the right fix is clearly nominal types.","author_login":"RyanCavanaugh","author_association":"MEMBER","created_at":"2022-11-11T19:13:53+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312137806","fragment_type":"issue_comment","sequence":4,"text":"I've been looking for an analogy for this sort of thing forever; this is perfect.","author_login":"fatcerberus","author_association":"NONE","created_at":"2022-11-11T19:46:22+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312413459","fragment_type":"issue_comment","sequence":5,"text":"I don't agree that it would be confusing, I expected it to work and got surprised by the error message. Private fields would work exactly like regular fields. As a matter of fact, they already kind of do, but you need to use `declare class C { #x: 'x' }` instead of just `type T { #x: 'x' }`, and they don't work when mapping types.\n\nBut sure, makes sense to not do this since it could have been solved by another issue that has been opened for 8 years with apparently no work on it. /s","author_login":"erik-kallen","author_association":"NONE","created_at":"2022-11-12T08:38:39+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312469527","fragment_type":"issue_comment","sequence":6,"text":"A non-class type with a private field would only be useful as an opaque type that you could cast something else to; you would never be able to directly construct an object that’s assignable to it, because you can’t write object literals with private fields in JS. I agree it would be confusing to have first-class support for an entire class of types for which no legal runtime values exist. Even if that were allowed, it’s semantically confusing because `class A { #foo: number }` is not assignable to any other class with the exact same signature, but now you’d be treating them as part of a structural check (”exactly like regular fields”)\n\nIf you’re instead proposing that `{ foo: 42 }` be directly assignable to `{ foo: number, #marker: T }` *without a cast*, with the private field only serving to differentiate it from other, similar objects, then you might as well skip the ceremony and just ask for nominal types (e.g. `unique { foo: number }`), because that’s what that boils down to, and is much simpler to explain to someone reading the code.","author_login":"fatcerberus","author_association":"NONE","created_at":"2022-11-12T12:35:05+08:00","repo_name":"microsoft/TypeScript","issue_id":1445809865,"issue_number":51489,"issue_url":"https://github.com/microsoft/TypeScript/issues/51489","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0201","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Document/automate how to migrate from a Wrangler 1 `webpack_config` / webpack integration to Wrangler 2?","query_context":"wrangler v2 deprecates the `type` and `webpack_config` configurations, and it's overall webpack integration story. \n\n- This has historically been a pain point both internally and externally. We haven't been able to update the webpack version (v4) because of breaking changes, and it scares away people from using wrangler in the first place. \n- The other two values for `type` - `javascript` and `rust` don't make much sense anymore since it's really the same thing backing it. And we're going to encourage development in multiple languages (Go, python, what have you) since we want to have the best `wasm` support ever. \n- Because we now ship esbuild, we can automatically provide support for a number of features that bundlers are typically used for: modules, jsx, typescript, etc. \n\nTODO: as part of the effort to be backward compatible, we should have a super low-effort transition guide to moving existing webpack projects to the new wrangler (ideally, we should be able to automate it with a single command/codemod).","known_context_document_ids":["gh_issue_1053837644"],"reference_answer":"I think we should keep esbuild as an internal implementation. Enabling esbuild specific plugins would make it harder to switch to an alterntaive build step.","answer_document_id":"gh_comment_1031195834","silver_evidence_path":["gh_comment_1066160531","gh_issue_1100033391","gh_comment_1031195834"],"evidence_issue_ids":[1053837644,1100033391],"source_repo_name":"cloudflare/wrangler2","source_issue_id":1053837644,"source_issue_number":8,"source_issue_url":"https://github.com/cloudflare/wrangler2/issues/8","target_repo_name":"cloudflare/wrangler2","target_issue_id":1100033391,"target_issue_number":234,"target_issue_url":"https://github.com/cloudflare/wrangler2/issues/234","reference_anchor_document_id":"gh_comment_1066160531","reference_answer_author":"petebacondarwin","reference_answer_author_association":"COLLABORATOR","quality_score":87.44,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.093,"anchor_target_overlap":0.1739,"target_answer_overlap":0.25},"issue_created_at":"2021-11-15T16:07:16+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1053837644","fragment_type":"issue_description","sequence":0,"text":"Document/automate how to migrate from a Wrangler 1 `webpack_config` / webpack integration to Wrangler 2\nwrangler v2 deprecates the `type` and `webpack_config` configurations, and it's overall webpack integration story. \n\n- This has historically been a pain point both internally and externally. We haven't been able to update the webpack version (v4) because of breaking changes, and it scares away people from using wrangler in the first place. \n- The other two values for `type` - `javascript` and `rust` don't make much sense anymore since it's really the same thing backing it. And we're going to encourage development in multiple languages (Go, python, what have you) since we want to have the best `wasm` support ever. \n- Because we now ship esbuild, we can automatically provide support for a number of features that bundlers are typically used for: modules, jsx, typescript, etc. \n\nTODO: as part of the effort to be backward compatible, we should have a super low-effort transition guide to moving existing webpack projects to the new wrangler (ideally, we should be able to automate it with a single command/codemod).","author_login":"threepointone","author_association":"CONTRIBUTOR","created_at":"2021-11-15T16:07:16+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1066043722","fragment_type":"issue_comment","sequence":1,"text":"In Wrangler 2, we use esbuild to bundle the code into a single file (more or less) for uploading to Cloudflare.\nSo for the majority of cases this completely replaces the webpack bundling in Wrangler 1.\nBut if you really need to use webpack then our recommended approach is to add it as a prepublish step. There a many ways to implement that but here is one...\n\nIn `package.json` use:\n\n\"scripts\" {\n \"publish\": \"webpack && wrangler publish\",\n \"dev\": \"concurrently -p --kill-others \\\"webpack --watch\\\" \\\"wrangler dev\\\"\"\n}","author_login":"petebacondarwin","author_association":"COLLABORATOR","created_at":"2022-03-13T07:27:52+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066130156","fragment_type":"issue_comment","sequence":2,"text":"Never heard about `esbuild` before. I have some questions.\nAbout `esbuild`....\n1. Does it have Some kind of command that gives the same functionality as `webpack`'s production mode?\n2. Do you guys allow config customization for `esbuild`?\nAbout the default behaviour of `wrangler2`...\n1. What is the default index file for `wrangler2`? `wrangler2 publish` throws errors.\n2. How to set default `wrangler2` index file. Previously custom webpack config file was used I think.\n3. Can I you guys make `wrangler2` save is output file? Like a customizable output path for testing it’s behaviour.\nAbout development Pipeline...\n1. I want to use Github Workflows for publishing my project. What Authentication method do you suggest? Surely `wrangler2 login` isn't an option. Or do you suggest Cloudflare API?","author_login":"touhidurrr","author_association":"NONE","created_at":"2022-03-13T15:56:19+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066160531","fragment_type":"issue_comment","sequence":3,"text":"The output of esbuild is a bundled file where imports have been inlined (mostly) similar to webpack. Currently we are not minifying the output. What production mode features of webpack are you looking for here?\n \n\nFor now we are treating the bundler as an internal implementation aspect of Wrangler 2. So at the moment we are not allowing the bundling to be extended. There is an issue to track this: URL \n \n\nThere is no default index file for Wrangler 2. It must be configured...\n \n\nYou can specify the entry-point index file for a Worker in a variety of ways:\n\n- In `wrangler publish` and `wrangler dev` the first positional command line argument is the path to the index file.\n- If not provided at the command line, you can specify it in the wrangler.toml via the `main` property. This is tracked here: URL \n \n\nCurrently we do not have a facility to save the output from the bundling to disk.\nWe would like to improve the testing and debugging story for Workers. There is this issue about improving debugging: URL \n\nI want to use Github Workflows for publishing my project. What Authentication method do you suggest? Surely wrangler2 login isn't an option. Or do you suggest Cloudflare API?\n\nIf you are publishing from a CI where you cannot have an interactive login, you can currently specify an API token via the `CLOUDFLARE_API_TOKEN` environment variable.","author_login":"petebacondarwin","author_association":"COLLABORATOR","created_at":"2022-03-13T18:49:13+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[1100033391],"is_known_query_context":false},{"document_id":"gh_comment_1066658544","fragment_type":"issue_comment","sequence":4,"text":"Ok also I read `esbuild` docs. If you are using `esbuild` treating as an internal package then I guess it doesn’t honor `esbuild` features like `browser` parameter in `package.json`. Or, does it do since it’s being executed from the same path as the `package.json` file?","author_login":"touhidurrr","author_association":"NONE","created_at":"2022-03-14T11:14:49+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066989460","fragment_type":"issue_comment","sequence":5,"text":"We pass all the options to esbuild programmatically, so it should not be reading anything from package.json. (And if it is then that is a bug!)","author_login":"petebacondarwin","author_association":"COLLABORATOR","created_at":"2022-03-14T15:57:12+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099497972","fragment_type":"issue_comment","sequence":6,"text":"@touhidurrr this should be fixed via #759, can you let us know if the webpack plugin works as expected?","author_login":"caass","author_association":"CONTRIBUTOR","created_at":"2022-04-14T18:19:36+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099583762","fragment_type":"issue_comment","sequence":7,"text":"Dunno actually. Already moved to `esbuild` cause the build time is much faster than webpack. 😅","author_login":"touhidurrr","author_association":"NONE","created_at":"2022-04-14T20:13:21+08:00","repo_name":"cloudflare/wrangler2","issue_id":1053837644,"issue_number":8,"issue_url":"https://github.com/cloudflare/wrangler2/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1100033391","fragment_type":"issue_description","sequence":0,"text":"Add esbuild plugins\nPossibility to enhance build step with `esbuild` plugins, for example, URL \n\nThis would enable to improve build outputs.","author_login":"huv1k","author_association":"NONE","created_at":"2022-01-12T08:33:12+08:00","repo_name":"cloudflare/wrangler2","issue_id":1100033391,"issue_number":234,"issue_url":"https://github.com/cloudflare/wrangler2/issues/234","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1010824851","fragment_type":"issue_comment","sequence":1,"text":"We're thinking about plugin systems, we'll probably do it in v2.1. It may or may not be esbuild plugins.","author_login":"threepointone","author_association":"CONTRIBUTOR","created_at":"2022-01-12T09:21:16+08:00","repo_name":"cloudflare/wrangler2","issue_id":1100033391,"issue_number":234,"issue_url":"https://github.com/cloudflare/wrangler2/issues/234","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1031195834","fragment_type":"issue_comment","sequence":2,"text":"I think we should keep esbuild as an internal implementation. Enabling esbuild specific plugins would make it harder to switch to an alterntaive build step.","author_login":"petebacondarwin","author_association":"COLLABORATOR","created_at":"2022-02-07T08:28:30+08:00","repo_name":"cloudflare/wrangler2","issue_id":1100033391,"issue_number":234,"issue_url":"https://github.com/cloudflare/wrangler2/issues/234","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1117178075","fragment_type":"issue_comment","sequence":3,"text":"I don't think we'll do this anytime soon. A workaround is to use a custom build using esbuild oneself, and then feed that to wrangler. Closing this.","author_login":"threepointone","author_association":"CONTRIBUTOR","created_at":"2022-05-04T10:57:55+08:00","repo_name":"cloudflare/wrangler2","issue_id":1100033391,"issue_number":234,"issue_url":"https://github.com/cloudflare/wrangler2/issues/234","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439249471","fragment_type":"issue_comment","sequence":4,"text":"For any future googlers: I have a fork that you can add using this git branch that adds support for esbuild plugins as a wrangler.toml option. You can use it like this:\n\ntoml\n# wrangler.toml\nesbuild_plugins = [\"./esbuild-plugins.js\", \"esbuild-plugin-glob-import\"] # supports local files and installed packages\n\nIf you need to specify configuration options (or if the plugin export isn’t detected correctly), you can create an `esbuild-plugins.js`:\n\njs\nimport globImport from \"esbuild-plugin-glob-import\";\n\nexport default function () {\n return [\n globImport({\n camelCase: false,\n entryPoint: null,\n entryPointMatch: null,\n }),\n ];\n}\n\n(This is for an ESM project, you might have to change it for commonjs)\n\nI made a PR for it, but I haven’t gotten a response after initial message. I’ve been using the fork for a while with multiple projects using `esbuild-plugin-glob-import`, and I haven’t had any issues.","author_login":"naturecodevoid","author_association":"NONE","created_at":"2023-02-22T00:05:15+08:00","repo_name":"cloudflare/wrangler2","issue_id":1100033391,"issue_number":234,"issue_url":"https://github.com/cloudflare/wrangler2/issues/234","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0203","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"My all extension off?","query_context":"Type: Bug \n\nAfter I use vs code for a while all my extensions turn off. but my RAM is also CUP ticked. \n\nimage\n\nVS Code version: Code 1.76.1 (5e805b79fcb6ba4c2d23712967df89a089da575b, 2023-03-08T16:48:08.231Z)\nOS version: Darwin arm64 22.3.0\nModes:\nSandboxed: No\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|Apple M1 Pro (8 x 24)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off|\n|Load (avg)|3, 3, 3|\n|Memory (System)|16.00GB (0.32GB free)|\n|Process Argv|. --crash-reporter-id 37b4c5ad-564b-4679-a877-40c9b6698903|\n|Screen Reader|yes|\n|VM|0%|\n Extensions (57) \n\nExtension|Author (truncated)|Version\n---|---|---\nbetter-comments|aar|3.0.2\nvscode-javascript-snippet-pack|aka|0.1.6\nauto-align|bla|0.0.13\nvscode-standardjs-snippets|cap|0.9.0\nturbo-console-log|Cha|2.7.1\nnpm-intellisense|chr|1.4.4\npath-intellisense|chr|2.8.4\njsrefactor|cms|3.0.1\nvscode-redis-client|cwe|6.2.5\ndscodegpt|Dan|2.0.1\nvscode-markdownlint|Dav|0.49.0\nvscode-eslint|dba|2.4.0\ngithistory|don|0.6.20\nvscode-babel-coloring|dza|0.0.4\ngitlens|eam|13.3.2\nEditorConfig|Edi|0.16.4\nvsc-material-theme-icons|equ|2.6.1\nprettier-vscode|esb|9.10.4\ncode-runner|for|0.12.0\ntoggle-zen-mode|fud|1.1.2\ncopilot|Git|1.77.9225\nvscode-pull-request-github|Git|0.60.0\nvscode-test-explorer|hbe|2.21.1\nvscode-drawio|hed|1.6.6\npath-autocomplete|ion|1.23.1\nsearch-node-modules|jas|1.3.0\nvscode-jest-test-adapter|kav|0.8.1\nauto-save|mcr|1.0.3\nrainbow-csv|mec|3.5.0\ngit-graph|mhu|1.30.0\ndotenv|mik|1.0.1\ndocument|min|2.2.1\nvscode-filesize|mkx|3.1.0\ninline-fold|moa|0.2.3\nvscode-docker|ms-|1.24.0\nremote-containers|ms-|0.282.0\ntest-adapter-converter|ms-|0.1.6\nvscode-typescript-next|ms-|5.1.20230313\nindent-rainbow|ode|8.3.1\nvscode-jest|Ort|5.2.3\nrefactor|p42|3.0.1\ntsimporter|pmn|2.0.1\nsubtle-brackets|raf|3.0.0\nvscode-yaml|red|1.12.1\nLiveServer|rit|5.7.9\nvscode-javascript-booster|sbu|14.0.1\nautoimport|ste|1.5.4\naddDocComments|ste|0.0.8\ncode-spell-checker|str|2.19.0\nmove-ts|str|1.12.0\ntabnine-vscode|Tab|3.6.42\nerrorlens|use|3.8.0\nintellicode-api-usage-examples|Vis|0.2.7\nvscodeintellicode|Vis|1.2.30\nfig|wit|0.0.7\nvscode-import-cost|wix|3.3.0\nJavaScriptSnippets|xab|1.8.0\n\n(2 theme extensions excluded)\n\n \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383:30185418\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\npythonvspyl392:30443607\nvserr242:30382549\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263:30335439\nvscoreces:30445986\npythondataviewer:30285071\nvscod805:30301674\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\ncmake_vspar411:30581797\nvsaa593:30376534\npythonvs932:30410667\ncppdebug:30492333\nvscaac:30438847\nvsclangdc:30486549\nc4g48928:30535728\ndsvsc012cf:30540253\npynewext54:30681850\nazure-dev_surveyone:30548225\nvsccc:30610678\npyindex848:30662994\nnodejswelcome1cf:30587006\n3biah626:30602489\npyind779:30671433\n89544117:30613380\nvscrpc:30673769\npythonsymbol12:30671437\na9j8j154:30646983\n6233i204:30672705\npythonb192cf:30669361\nfunwalk2:30682974\npythonms35:30686772","known_context_document_ids":["gh_issue_1624752703"],"reference_answer":"@Gerrnperl thanks, could you quit VS Code, run `code --verbose`, reproduce the issue and then send the logs as Zip from that session (e-mail is fine, its viewable on URL You can find the logs folder from this command:\n\n<img width=\"613\" alt=\"image\" src=\" URL \n\nAnd it would be the most recent folder entry (every session gets their own folder).","answer_document_id":"gh_comment_1470150459","silver_evidence_path":["gh_comment_1469796371","gh_issue_1615983657","gh_comment_1470150459"],"evidence_issue_ids":[1624752703,1615983657],"source_repo_name":"microsoft/vscode","source_issue_id":1624752703,"source_issue_number":177172,"source_issue_url":"https://github.com/microsoft/vscode/issues/177172","target_repo_name":"microsoft/vscode","target_issue_id":1615983657,"target_issue_number":176562,"target_issue_url":"https://github.com/microsoft/vscode/issues/176562","reference_anchor_document_id":"gh_comment_1469796371","reference_answer_author":"bpasero","reference_answer_author_association":"MEMBER","quality_score":92.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.2,"target_answer_overlap":0.0333},"issue_created_at":"2023-03-15T05:02:41+08:00","valid_comment_count":27,"fragments":[{"document_id":"gh_issue_1624752703","fragment_type":"issue_description","sequence":0,"text":"My all extension off\nType: Bug \n\nAfter I use vs code for a while all my extensions turn off. but my RAM is also CUP ticked. \n\nimage\n\nVS Code version: Code 1.76.1 (5e805b79fcb6ba4c2d23712967df89a089da575b, 2023-03-08T16:48:08.231Z)\nOS version: Darwin arm64 22.3.0\nModes:\nSandboxed: No\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|Apple M1 Pro (8 x 24)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off|\n|Load (avg)|3, 3, 3|\n|Memory (System)|16.00GB (0.32GB free)|\n|Process Argv|. --crash-reporter-id 37b4c5ad-564b-4679-a877-40c9b6698903|\n|Screen Reader|yes|\n|VM|0%|\n Extensions (57) \n\nExtension|Author (truncated)|Version\n---|---|---\nbetter-comments|aar|3.0.2\nvscode-javascript-snippet-pack|aka|0.1.6\nauto-align|bla|0.0.13\nvscode-standardjs-snippets|cap|0.9.0\nturbo-console-log|Cha|2.7.1\nnpm-intellisense|chr|1.4.4\npath-intellisense|chr|2.8.4\njsrefactor|cms|3.0.1\nvscode-redis-client|cwe|6.2.5\ndscodegpt|Dan|2.0.1\nvscode-markdownlint|Dav|0.49.0\nvscode-eslint|dba|2.4.0\ngithistory|don|0.6.20\nvscode-babel-coloring|dza|0.0.4\ngitlens|eam|13.3.2\nEditorConfig|Edi|0.16.4\nvsc-material-theme-icons|equ|2.6.1\nprettier-vscode|esb|9.10.4\ncode-runner|for|0.12.0\ntoggle-zen-mode|fud|1.1.2\ncopilot|Git|1.77.9225\nvscode-pull-request-github|Git|0.60.0\nvscode-test-explorer|hbe|2.21.1\nvscode-drawio|hed|1.6.6\npath-autocomplete|ion|1.23.1\nsearch-node-modules|jas|1.3.0\nvscode-jest-test-adapter|kav|0.8.1\nauto-save|mcr|1.0.3\nrainbow-csv|mec|3.5.0\ngit-graph|mhu|1.30.0\ndotenv|mik|1.0.1\ndocument|min|2.2.1\nvscode-filesize|mkx|3.1.0\ninline-fold|moa|0.2.3\nvscode-docker|ms-|1.24.0\nremote-containers|ms-|0.282.0\ntest-adapter-converter|ms-|0.1.6\nvscode-typescript-next|ms-|5.1.20230313\nindent-rainbow|ode|8.3.1\nvscode-jest|Ort|5.2.3\nrefactor|p42|3.0.1\ntsimporter|pmn|2.0.1\nsubtle-brackets|raf|3.0.0\nvscode-yaml|red|1.12.1\nLiveServer|rit|5.7.9\nvscode-javascript-booster|sbu|14.0.1\nautoimport|ste|1.5.4\naddDocComments|ste|0.0.8\ncode-spell-checker|str|2.19.0\nmove-ts|str|1.12.0\ntabnine-vscode|Tab|3.6.42\nerrorlens|use|3.8.0\nintellicode-api-usage-examples|Vis|0.2.7\nvscodeintellicode|Vis|1.2.30\nfig|wit|0.0.7\nvscode-import-cost|wix|3.3.0\nJavaScriptSnippets|xab|1.8.0\n\n(2 theme extensions excluded)\n\n \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383:30185418\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\npythonvspyl392:30443607\nvserr242:30382549\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263:30335439\nvscoreces:30445986\npythondataviewer:30285071\nvscod805:30301674\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\ncmake_vspar411:30581797\nvsaa593:30376534\npythonvs932:30410667\ncppdebug:30492333\nvscaac:30438847\nvsclangdc:30486549\nc4g48928:30535728\ndsvsc012cf:30540253\npynewext54:30681850\nazure-dev_surveyone:30548225\nvsccc:30610678\npyindex848:30662994\nnodejswelcome1cf:30587006\n3biah626:30602489\npyind779:30671433\n89544117:30613380\nvscrpc:30673769\npythonsymbol12:30671437\na9j8j154:30646983\n6233i204:30672705\npythonb192cf:30669361\nfunwalk2:30682974\npythonms35:30686772","author_login":"sourabhossain","author_association":"NONE","created_at":"2023-03-15T05:02:41+08:00","repo_name":"microsoft/vscode","issue_id":1624752703,"issue_number":177172,"issue_url":"https://github.com/microsoft/vscode/issues/177172","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1469493467","fragment_type":"issue_comment","sequence":1,"text":"Please use the Start Extension Bisect command to investigate which extension is causing the problem.\n\nBased on other recent issues my guess is Copilot.","author_login":"gjsjohnmurray","author_association":"CONTRIBUTOR","created_at":"2023-03-15T07:34:47+08:00","repo_name":"microsoft/vscode","issue_id":1624752703,"issue_number":177172,"issue_url":"https://github.com/microsoft/vscode/issues/177172","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469796371","fragment_type":"issue_comment","sequence":2,"text":"Thank you very much for opening this issue. We are currently investigating Copilot causing crashes and we are consolidating all the findings in URL \nWe believe this is an out of memory issue, and we can not yet reproduce it on our side. Thus it would be super helpful if you can share reproducible steps (what type of file opened, does this happen when Copilot is suggesting) here URL \n\nDue to the consolidation I am closing this as a duplicate.\n\nIf you can reproduce this issue after disabling Copilot do let us know and we can reopen this issue.","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-03-15T11:01:58+08:00","repo_name":"microsoft/vscode","issue_id":1624752703,"issue_number":177172,"issue_url":"https://github.com/microsoft/vscode/issues/177172","linked_issue_ids":[1615983657],"is_known_query_context":false},{"document_id":"gh_issue_1615983657","fragment_type":"issue_description","sequence":0,"text":"Extension host terminated unexpectedly due to GitHub copilot\nType: Bug \n\nMy extensions keep terminating. GitHub copilot seem to be the reason for the crash for myself and others. Disabling copilot stops the crashing for us, but we need a better solution\n\nVS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:25:16.105Z)\nOS version: Linux x64 6.1.12-1-MANJARO\nModes:\nSandboxed: No\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz (8 x 3292)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: disabled_software video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off|\n|Load (avg)|6, 4, 3|\n|Memory (System)|15.51GB (8.98GB free)|\n|Process Argv|code/projects/url_finder/v2 --crash-reporter-id 9ca28901-9313-4681-bac3-c399ba55c953|\n|Screen Reader|no|\n|VM|0%|\n|DESKTOP_SESSION|undefined|\n|XDG_CURRENT_DESKTOP|undefined|\n|XDG_SESSION_DESKTOP|undefined|\n|XDG_SESSION_TYPE|undefined|\n Extensions (89) \n\nExtension|Author (truncated)|Version\n---|---|---\nbetter-comments|aar|3.0.2\nBookmarks|ale|13.3.1\nproject-manager|ale|12.7.0\nscope-bar|amo|0.2.1\nchronicler|arc|0.1.16\nsvelte-intellisense|ard|0.7.1\nastro-vscode|ast|0.29.6\ntailwind-docs|aus|2.0.0\njsoncrack-vscode|Ayk|1.0.8\nvscode-tailwindcss|bra|0.9.7\nbuildt-vscode|Bui|0.2.5\nturbo-console-log|Cha|2.7.1\nregex|chr|0.4.0\nclippy-ai|cli|0.5.0\ngitignore|cod|0.9.0\nvscode-markdownlint|Dav|0.49.0\nvscode-eslint|dba|2.4.0\nvscode-faker|dee|2.0.0\nvscode-axe-linter|deq|4.6.0\ngit-extension-pack|don|0.1.3\ngithistory|don|0.6.20\nes7-react-js-snippets|dsz|4.4.3\ngitlens|eam|13.3.2\nvscode-html-css|ecm|1.13.1\nEditorConfig|Edi|0.16.4\njson-tools|eri|1.0.2\nprettier-vscode|esb|9.10.4\nvscode-svelte-snippets|fiv|0.5.0\ncode-runner|for|0.12.0\nshell-format|fox|7.2.5\ncopilot|Git|1.77.9225\ncopilot-labs|Git|0.12.791\ngc-excelviewer|Gra|4.2.56\ntodo-tree|Gru|0.0.224\nheadwind|hey|1.7.0\ncodesnap-plus|hui|1.4.1\noutput-colorizer|IBM|0.1.2\nnpm|ide|1.3.0\nvscode-edit-csv|jan|0.7.3\nvscode-text-pastry|jkj|1.3.1\nsvg|joc|1.5.0\nvsc-python-indent|Kev|1.18.0\nts-error-translator|mat|0.8.0\nweb-accessibility|Max|0.2.83\nrainbow-csv|mec|3.5.0\ngit-graph|mhu|1.30.0\nfluent-icons|mig|0.0.18\ndotenv|mik|1.0.1\nvscode-scss|mrm|0.10.0\nplaywright|ms-|1.0.8\nisort|ms-|2022.8.0\npython|ms-|2023.4.0\nvscode-pylance|ms-|2023.3.10\nremote-ssh|ms-|0.98.0\nremote-ssh-edit|ms-|0.84.0\nremote-explorer|ms-|0.2.0\nvscode-typescript-next|ms-|5.1.20230307\nsqltools|mtx|0.27.1\ncolor-highlight|nau|2.5.0\nplaywright-snippets|nit|1.0.1\nes6-css-minify|olb|3.3.3\nmaterial-icon-theme|PKi|4.24.0\nvscode-css-peek|pra|4.2.0\nquicktype|qui|12.0.46\nvscode-rapidapi-client|Rap|1.9.3\ntypescript-hero|rbb|3.0.0\nLiveServer|rit|5.7.9\npartial-diff|ryu|1.4.3\nvscode-fileutils|sle|3.10.0\nhtml-to-css-autocompletion|sol|1.1.2\nsonarlint-vscode|Son|3.15.1\nstepsize|Ste|1.0.13\ncode-spell-checker|str|2.19.0\nsvelte-vscode|sve|107.2.0\nts-quickfixes-extension|tam|1.15.0\nopen-in-browser|tec|2.0.0\nvscode-mdx|uni|1.2.5\nerrorlens|use|3.7.0\nintellicode-api-usage-examples|Vis|0.2.7\nvscodeintellicode|Vis|1.2.30\nconsole-ninja|Wal|0.0.81\nquokka-vscode|Wal|1.0.527\nwallaby-vscode|Wal|1.0.350\nvscode-todo-highlight|way|1.0.5\nvscode-import-cost|wix|3.3.0\nJavaScriptSnippets|xab|1.8.0\nmarkdown-all-in-one|yzh|3.5.0\nmaterial-theme|zhu|3.15.6\nvscode-open-in-github|ziy|1.3.6\n\n \n A/B Experiments \n\nvsliv368:30146709\nvsreu685:30147344\npython383cf:30185419\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\npythonvspyl392:30443607\nvserr242:30382549\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263cf:30335440\nvscoreces:30445986\npythondataviewer:30285071\nvscod805:30301674\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\ncmake_vspar411:30581797\nvsaa593cf:30376535\npythonvs932:30410667\ncppdebug:30492333\nvscaat:30438848\nvsclangdf:30486550\nc4g48928:30535728\ndsvsc012:30540252\npynewvextcfv2:30681851\nazure-dev_surveyone:30548225\npyindex848:30662994\nnodejswelcome1cf:30587006\n282f8724:30602487\npyind779:30671433\nf6dab269:30613381\npythonsymbol12:30671437\na9j8j154:30646983\nvsccsb:30677849\npythonms35:30680984","author_login":"edwardspresume","author_association":"NONE","created_at":"2023-03-08T21:39:50+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1462153614","fragment_type":"issue_comment","sequence":1,"text":"same here. Issue started happening today. Didn't install any new extensions in the last days. However Pylance seems to take a lot of memory 1GB. Using WSL2 backend.","author_login":"tunayokumus","author_association":"NONE","created_at":"2023-03-09T14:25:51+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1462943153","fragment_type":"issue_comment","sequence":2,"text":"Not sure, if this is relevant, but after I disabled Github Copilot extension, looks like the issue is gone (at least for the last couple of hours it's not crashing)\n\nI am on WSL2","author_login":"VladSez","author_association":"NONE","created_at":"2023-03-09T23:01:55+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1463707746","fragment_type":"issue_comment","sequence":3,"text":"It is so frustrating that I have to reload just to expect a crash with in 5 mins or less.\nplease fix this ASAP","author_login":"ghana7989","author_association":"NONE","created_at":"2023-03-10T12:03:24+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1467172681","fragment_type":"issue_comment","sequence":4,"text":"same here been having this issue for a week now, it's annoying","author_login":"Ali-AlDhamen","author_association":"NONE","created_at":"2023-03-14T00:40:12+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1467193702","fragment_type":"issue_comment","sequence":5,"text":"Related question on Stack Overflow: Extension host terminated unexpectedly 3 times within the last 5 minutes","author_login":"starball5","author_association":"NONE","created_at":"2023-03-14T01:11:08+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1468088742","fragment_type":"issue_comment","sequence":6,"text":"Same here. Having this issue for about a week. Quite unfortunate.","author_login":"TeddyCr","author_association":"NONE","created_at":"2023-03-14T13:17:58+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1468236893","fragment_type":"issue_comment","sequence":7,"text":"Can users provide the following 2 logs,\n\n1) Open `Developer: Toggle Developer Tools` and attach the generated log when extension host terminates\n2) Start the application following the steps at URL and attach the generated crash logs if available.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-03-14T14:45:47+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1468275831","fragment_type":"issue_comment","sequence":8,"text":"I get a log of things from the developer tool, unsure which one to share. Let me know if that one help\n\nabstractExtensionService.ts:931 Extension host (LocalProcess) terminated unexpectedly. Code: 7, Signal: unknown\n\n[Extension Host] (node:15816) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.\n(Use `Code Helper (Plugin) --trace-deprecation ...` to show where the warning was created)","author_login":"TeddyCr","author_association":"NONE","created_at":"2023-03-14T15:03:46+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1468342524","fragment_type":"issue_comment","sequence":9,"text":"`Code: 7` seems like an exit due to OOM, @TeddyCr can you launch the application with `code --verbose` and attach the logs once extension host terminates.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-03-14T15:40:47+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469617197","fragment_type":"issue_comment","sequence":10,"text":"It would be great if you can share all the logs printed to the terminal, if not can you check for a line that has the following `crashed with code 7 and reason ...`. I am mainly looking to confirm the value of `reason`.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-03-15T09:06:11+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469899159","fragment_type":"issue_comment","sequence":11,"text":"👋 , since we just merged a lot of issues into this one as duplicate: has anyone been able to figure out a pattern that reproduces this issue reliably? We in our team all use Copilot on the same version and so far have not yet hit this issue. \n\nIs it just using Copilot over some time in the editor when it randomly happens? Are there any settings configured around Copilot or editor suggest that might have an impact?","author_login":"bpasero","author_association":"MEMBER","created_at":"2023-03-15T12:15:45+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469945274","fragment_type":"issue_comment","sequence":12,"text":"For me the extension host always terminates when I do a git commit via vscode, when I disable Github Copilot (or just for 'git-commit'), the crash doesn't happen anymore.\n\nOf course, there will be a small probability of termination at other times\n\nPeek 2023-03-15 20-43","author_login":"Gerrnperl","author_association":"NONE","created_at":"2023-03-15T12:47:28+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470002888","fragment_type":"issue_comment","sequence":13,"text":"The same issue. It's related to a new version of the Copilot.\nTry to downgrade the Copilot version to 1.76.9071\nimage","author_login":"yegor-ch","author_association":"NONE","created_at":"2023-03-15T13:21:28+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470005536","fragment_type":"issue_comment","sequence":14,"text":"Can anyone reproduce this issue with the previous Copilot version `1.76.9071`? You can change extension version by opening the Extensions viewlet, right click on Copilot > Install Another Version.","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-03-15T13:23:21+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470055106","fragment_type":"issue_comment","sequence":15,"text":"@Gerrnperl thats a very nice small repro, which unfortunately I cannot reproduce. Curious, when you observe the memory used by \"utility process\" when the \"Process Explorer\" is opened (from \"Help\" menu), does that memory suddenly go to a very large value and then restart the process?\n\n<img width=\"912\" alt=\"Screenshot 2023-03-15 at 14 54 31\" src=\" URL","author_login":"bpasero","author_association":"MEMBER","created_at":"2023-03-15T13:55:42+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470080549","fragment_type":"issue_comment","sequence":16,"text":"@isidorn \nFor me, the previous version of Copilot didn't cause this issue.","author_login":"Gerrnperl","author_association":"NONE","created_at":"2023-03-15T14:10:22+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470099738","fragment_type":"issue_comment","sequence":17,"text":"Same for me `1.76.9071` works as expected. As soon as I upgrade to the latest version the extension host eventually crashes within a few minutes.","author_login":"TeddyCr","author_association":"NONE","created_at":"2023-03-15T14:22:44+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470145163","fragment_type":"issue_comment","sequence":18,"text":"ezgif-3-4149a38d1b\n\n\"utility process\" took up about 400 MB at the time of the crash\nI'm not sure if this is \"unusually large\", but with Copilot disabled, the utility process memory usage fluctuates between 100 MB and 350 MB (and sometimes rarely exceed 400 MB)","author_login":"Gerrnperl","author_association":"NONE","created_at":"2023-03-15T14:48:49+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470150459","fragment_type":"issue_comment","sequence":19,"text":"@Gerrnperl thanks, could you quit VS Code, run `code --verbose`, reproduce the issue and then send the logs as Zip from that session (e-mail is fine, its viewable on URL You can find the logs folder from this command:\n\n<img width=\"613\" alt=\"image\" src=\" URL \n\nAnd it would be the most recent folder entry (every session gets their own folder).","author_login":"bpasero","author_association":"MEMBER","created_at":"2023-03-15T14:51:36+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470179438","fragment_type":"issue_comment","sequence":20,"text":"@bpasero I have reproduced the bug with `--verbose` flag and sent you zip by email","author_login":"Baz00k","author_association":"NONE","created_at":"2023-03-15T15:09:05+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470630244","fragment_type":"issue_comment","sequence":21,"text":"for folks who saw this issue on Copilot version `1.77.*`, could you re-enable the latest version and check if the issue still persists ?\n\nif yes, would it be possible to send the logs using the steps mentioned by @bpasero above","author_login":"abgoswam","author_association":"MEMBER","created_at":"2023-03-15T19:07:48+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[1615983657],"is_known_query_context":false},{"document_id":"gh_comment_1470648900","fragment_type":"issue_comment","sequence":22,"text":"+1 for @abgoswam comment from above. We have identified a potential experiment that was causing the problem, and we have turned it off just now. We now believe the issue is fixed. Thus - please try again and let us know if you still see the problem. Thanks all!","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-03-15T19:12:51+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1471556872","fragment_type":"issue_comment","sequence":23,"text":"@a-r-j thanks for verifying.\n\nI am going ahead and closing this issue. If anybody is still seeing Extension Host crashes with Copilot do let us know and we will reopen this issue. Thank you all for your help!","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-03-16T09:02:12+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1485571248","fragment_type":"issue_comment","sequence":24,"text":"@verveguy do F1 > extension bisect. Most likely another extension is causing it, or it is another Copilot issue. In which case - fell free to open a new issue. Thanks","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-03-27T17:47:17+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1518971278","fragment_type":"issue_comment","sequence":25,"text":"I also had this issue mine was a complete breakdown of my WSL2 install due to windows refusing to mount the virtual disk anymore. I have no solution at this time but this is possibly caused by WSL2.","author_login":"ozjuly19","author_association":"NONE","created_at":"2023-04-23T07:04:37+08:00","repo_name":"microsoft/vscode","issue_id":1615983657,"issue_number":176562,"issue_url":"https://github.com/microsoft/vscode/issues/176562","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0204","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"UTF-8 unusable on windows with 1.14.4 - 1.14.5?","query_context":"### Solution to issue cannot be found in the documentation.\n\n- [x] I checked the documentation.\n\n### Issue\n\nSee URL for more details but basically:\n\n1. A patch in 1.14.4 broke UTF-8 filename support on windows.\n2. This is blocking h5py from being compiled on windows.\n\nI personally think UTF-8 is pretty important. I've seen users assume they can put any character they want (commas, quotes, colons, you name it.....) in their file names.\n\nHowever, today HDF5 is splitting the conda ecosystem making it more difficult to co-install packages.\n\nI think there are a few options for conda-forge:\n\n1. Downgrade to 1.14.3\n2. Dual build: 1.14.3 + 1.14.4 (heavy maintenance downstream)\n3. Ship 1.14.4 and say it is a known issue (h5py's pypi package might do this)\n4. Revert the offending patch on our version 1.14.4 URL \n\nI'm not sure what other maintainers have in mind, but it would be good to get to a decision and to unblock this by the end of the week.\n\n### Installed packages\n\nhdf5 1.14.4 and 1.14.5\n\n### Environment info\n\nWindows.","known_context_document_ids":["gh_issue_2635428486"],"reference_answer":"I'm fine to discuss the details in URL \n\nOTOH, the resource starvation caused by the current dual migration (which looks like it won't change for many months) is an issue for this repo, and IMO we need to completely delete (not just pause) that dual migrator until there's a sustainable solution for `hdf5>1.14.3` on windows.","answer_document_id":"gh_comment_2573013397","silver_evidence_path":["gh_comment_2574800136","gh_issue_2770445913","gh_comment_2573013397"],"evidence_issue_ids":[2635428486,2770445913],"source_repo_name":"conda-forge/hdf5-feedstock","source_issue_id":2635428486,"source_issue_number":240,"source_issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","target_repo_name":"conda-forge/conda-forge-pinning-feedstock","target_issue_id":2770445913,"target_issue_number":6900,"target_issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","reference_anchor_document_id":"gh_comment_2574800136","reference_answer_author":"h-vetinari","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1067,"anchor_target_overlap":0.1467,"target_answer_overlap":0.3333},"issue_created_at":"2024-11-05T13:12:49+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2635428486","fragment_type":"issue_description","sequence":0,"text":"UTF-8 unusable on windows with 1.14.4 - 1.14.5\n### Solution to issue cannot be found in the documentation.\n\n- [x] I checked the documentation.\n\n### Issue\n\nSee URL for more details but basically:\n\n1. A patch in 1.14.4 broke UTF-8 filename support on windows.\n2. This is blocking h5py from being compiled on windows.\n\nI personally think UTF-8 is pretty important. I've seen users assume they can put any character they want (commas, quotes, colons, you name it.....) in their file names.\n\nHowever, today HDF5 is splitting the conda ecosystem making it more difficult to co-install packages.\n\nI think there are a few options for conda-forge:\n\n1. Downgrade to 1.14.3\n2. Dual build: 1.14.3 + 1.14.4 (heavy maintenance downstream)\n3. Ship 1.14.4 and say it is a known issue (h5py's pypi package might do this)\n4. Revert the offending patch on our version 1.14.4 URL \n\nI'm not sure what other maintainers have in mind, but it would be good to get to a decision and to unblock this by the end of the week.\n\n### Installed packages\n\nhdf5 1.14.4 and 1.14.5\n\n### Environment info\n\nWindows.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-11-05T13:12:49+08:00","repo_name":"conda-forge/hdf5-feedstock","issue_id":2635428486,"issue_number":240,"issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2462338502","fragment_type":"issue_comment","sequence":1,"text":"I would like to move forward with Option 2:\n\n* Dual build 1.14.3 and 1.14.4/5/6\n\nwhile this gets resolved upstream.\n\nThis isn't too different than what we've done in the past with HDF5 updates. HDF5 updates often take time, and the libraries that consume them can be quite old (due to the strong history of HDF5) and makes it difficult for packages to migrate.\n\nI feel like 1.14.4/5 is actually quite disruptive to the ecosystem as a whole, while the UTF-8 issue isn't resolved.\n\nThoughts are welcome.\n\nI've rebuilt 1.14.3 with the new features that have been contributed.\n\nIf an other maintainer agrees I have a checklist of the next steps outlined in URL","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-11-07T14:11:31+08:00","repo_name":"conda-forge/hdf5-feedstock","issue_id":2635428486,"issue_number":240,"issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2507792161","fragment_type":"issue_comment","sequence":2,"text":"@conda-forge-admin please rerender\n\nso as to add a sacred branch","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2024-11-29T13:10:11+08:00","repo_name":"conda-forge/hdf5-feedstock","issue_id":2635428486,"issue_number":240,"issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2574800136","fragment_type":"issue_comment","sequence":3,"text":"Following from URL \n\nAs a maintainer of several of the heavy matrix feedstocks, the root of most of them is petsc, which I merged yesterday, launching the several really heavy ones (which add a Python matrix on top of the mpi + petsc scalar). I'm happy to close those PRs and revert the petsc PR, if that's what we should do. But it's not quite clear to me what action to take, other than don't merge the PRs the closed migrator already issued.\n\nA bit tangential, but I'm also totally open to input to trim the matrix on several of the heavy petsc dependents, but I don't know how to make those decisions. ppc is by far the most costly platform to support (both in terms of compute and maintainer time), and I am not aware of a single user. It appears to be ~entirely unused in this stack of packages, except for similarly unused ppc builds of downstream packages, at least from anaconda.org download counts. I don't know who the conda-forge ppc builds are for, so I don't know if/when it's appropriate to drop ppc support.","author_login":"minrk","author_association":"MEMBER","created_at":"2025-01-07T09:30:23+08:00","repo_name":"conda-forge/hdf5-feedstock","issue_id":2635428486,"issue_number":240,"issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","linked_issue_ids":[2770445913],"is_known_query_context":false},{"document_id":"gh_comment_2574853717","fragment_type":"issue_comment","sequence":4,"text":"You don't need to revert PRs, just ensure that the next respective PR rerenders the feedstock correctly (which will remove half the matrix; the ones for 1.14.4).\n \n\nYou're free to drop it from your feedstocks if it causes maintenance issues, but for the larger picture, this is a discussion for URL I think. I agree that whenever I looked at download counts, PPC is at least an order of magnitude behind the second-least-used platform, so I can see where you're coming from.\n\n \n example \n\nopenssl 3.4.0\n\n| artefact | uptime | downloads |\n| -- | -- | -- |\n| linux-64/openssl-3.4.0-hb9d3cd8_0.conda | 1 month and 26 days ago | 4'039'394 |\n| linux-aarch64/openssl-3.4.0-h86ecc28_0.conda | 1 month and 26 days ago | 134'917 |\n| linux-ppc64le/openssl-3.4.0-h190368a_0.conda | 1 month and 26 days ago | 10'885 |\n| osx-64/openssl-3.4.0-hd471939_0.conda | 1 month and 26 days ago | 186'830 |\n| osx-arm64/openssl-3.4.0-h39f12f2_0.conda | 1 month and 26 days ago | 215'090 |\n| win-64/openssl-3.4.0-h2466b09_0.conda | 1 month and 26 days ago | 507'144 |\n\nOTOH, 10k users isn't nothing either 🤷","author_login":"h-vetinari","author_association":"MEMBER","created_at":"2025-01-07T09:54:11+08:00","repo_name":"conda-forge/hdf5-feedstock","issue_id":2635428486,"issue_number":240,"issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742117495","fragment_type":"issue_comment","sequence":5,"text":"Yeah sorry for not referencing the reason. it was a stressful time with this UTF-8 stuff.\n\nThere is also URL that is ready but i want to see if we can do the cmake transition too!","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2025-03-21T02:49:39+08:00","repo_name":"conda-forge/hdf5-feedstock","issue_id":2635428486,"issue_number":240,"issue_url":"https://github.com/conda-forge/hdf5-feedstock/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2770445913","fragment_type":"issue_description","sequence":0,"text":"Close HDF5 dual migration; stay on 1.14.3 until 2.0 is out\nIn #6758, we started migrating hdf5 twice, due to a nasty regression in 1.14.4 on windows that upstream refuses to address until a putative v2.0.\n\nSince HDF5 is part of some very heavy feedstocks, the simple fact of hitting the dual migration on hdf5 causes massive resource starvation in our CI fleet. This is not related to the migration itself though - once merged, all other PRs to such feedstocks will be similarly blown up in impact. Examples from today:\n* URL \n* URL \n* URL \n* URL \n* URL \n\nGiven that upstream hdf5 plans to only fix this issue in 2.0, the practical reality is that we IMO need to drop everything post 1.14.3, then then bite the bullet to do a monster 2.0 migration if/once that is released and the issue is actually fixed.\n\nCC @conda-forge/hdf5 @conda-forge/core","author_login":"h-vetinari","author_association":"MEMBER","created_at":"2025-01-06T11:23:37+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2572927627","fragment_type":"issue_comment","sequence":1,"text":"Honestly given their responses that seemed to ignore the urgency of our requests I was going to suggest torevert their changes.","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2025-01-06T11:34:17+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2572944107","fragment_type":"issue_comment","sequence":2,"text":"You mean that we carry URL That seems problematic IMO - we then become responsible for a conda-forge-specific variant of `hdf5>1.14.3` that's not found anywhere else. CC @takluyver for the h5py-side\n\nI mean, all current available options are bad. I won't object to carrying a patch[^1], if other affected parties agree that this is the least bad option. But doing that in direct opposition to upstream needs to clear a very high bar in terms of consensus.\n\n[^1]: if it allows us to keep migrating for a single current hdf5; staying up-to-date is apparently even CVE-relevant - fun!","author_login":"h-vetinari","author_association":"MEMBER","created_at":"2025-01-06T11:45:12+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573013397","fragment_type":"issue_comment","sequence":3,"text":"I'm fine to discuss the details in URL \n\nOTOH, the resource starvation caused by the current dual migration (which looks like it won't change for many months) is an issue for this repo, and IMO we need to completely delete (not just pause) that dual migrator until there's a sustainable solution for `hdf5>1.14.3` on windows.","author_login":"h-vetinari","author_association":"MEMBER","created_at":"2025-01-06T12:28:05+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573019207","fragment_type":"issue_comment","sequence":4,"text":"The dual migration intent was to give us time to speak with upstream. But they aren’t willing to prioritize this. \n\nI’m ok deleting it and reconsidering our patching options more slowly. \n\nI wasn’t aware there were resources starvation issues","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2025-01-06T12:31:45+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573055934","fragment_type":"issue_comment","sequence":5,"text":"Check out the PRs I linked in the OP - I didn't take all of them, just the biggest ones. For example, fenics got 2 PRs which >60 jobs each (each one taking ~1h). And","author_login":"h-vetinari","author_association":"MEMBER","created_at":"2025-01-06T12:55:13+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573061601","fragment_type":"issue_comment","sequence":6,"text":"I mean the python matrix and openmpi matrix don’t help either…..","author_login":"hmaarrfk","author_association":"CONTRIBUTOR","created_at":"2025-01-06T12:58:46+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2573067864","fragment_type":"issue_comment","sequence":7,"text":"Definitely. Though those are somewhat irreducible, whereas the hdf5 would be avoidable.\n\nI'm reopening this issue in case other people still want to chime in (easier to see open rather than closed issues). We can close in 1-2 days if there's no further input.","author_login":"h-vetinari","author_association":"MEMBER","created_at":"2025-01-06T13:02:30+08:00","repo_name":"conda-forge/conda-forge-pinning-feedstock","issue_id":2770445913,"issue_number":6900,"issue_url":"https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6900","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0205","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"GroupingStep?","query_context":"{valid: ready, value: groupedPointList} // function to call when the ready state changes - after first render this needs to be called with true, but changes to false when the user is in the middle of a grouping \n/>\n\n- [x] Use a media query of width less than theme.condensedWidthBreakPoint to determine when to switch to 1 column mode (for smartphones). \n- [x] Update PointGroup component to have it display selected vstate.\n- [x] Update PointGroup component to accept a callback function to allow the grouping step know when the done button is clicked.\n\nStorybook\n- [ ] User 10 points for the test case\n- [ ] Create a story case for each state, progressively use play() to simulate the user interactions to get to each state. \n- [ ] Test the case when groupedPointList is already populated\n- [ ] Test the case when shared={}, and shared={startingPointList: undefined} and shared={startingPointList: []} \n\nStretch Goal\n- [ ] When point grouping is complete, use animation to show the points combining at the bottom, and the rest of the points moving into their new positions.","known_context_document_ids":["gh_issue_1958462714"],"reference_answer":"How does the GroupPoint Component get the values for dem-info like \"Republican, 45 ,UT\"? Are they in pointObj?","answer_document_id":"gh_comment_1851135967","silver_evidence_path":["gh_comment_1960731363","gh_issue_1909530919","gh_comment_1851135967"],"evidence_issue_ids":[1958462714,1909530919],"source_repo_name":"EnCiv/civil-pursuit","source_issue_id":1958462714,"source_issue_number":49,"source_issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","target_repo_name":"EnCiv/civil-pursuit","target_issue_id":1909530919,"target_issue_number":35,"target_issue_url":"https://github.com/EnCiv/civil-pursuit/issues/35","reference_anchor_document_id":"gh_comment_1960731363","reference_answer_author":"Boyuan-Yu","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.2169,"target_answer_overlap":0.2857},"issue_created_at":"2023-10-24T03:54:11+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1958462714","fragment_type":"issue_description","sequence":0,"text":"GroupingStep\n{valid: ready, value: groupedPointList} // function to call when the ready state changes - after first render this needs to be called with true, but changes to false when the user is in the middle of a grouping \n/>\n\n- [x] Use a media query of width less than theme.condensedWidthBreakPoint to determine when to switch to 1 column mode (for smartphones). \n- [x] Update PointGroup component to have it display selected vstate.\n- [x] Update PointGroup component to accept a callback function to allow the grouping step know when the done button is clicked.\n\nStorybook\n- [ ] User 10 points for the test case\n- [ ] Create a story case for each state, progressively use play() to simulate the user interactions to get to each state. \n- [ ] Test the case when groupedPointList is already populated\n- [ ] Test the case when shared={}, and shared={startingPointList: undefined} and shared={startingPointList: []} \n\nStretch Goal\n- [ ] When point grouping is complete, use animation to show the points combining at the bottom, and the rest of the points moving into their new positions.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2023-10-24T03:54:11+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1960727789","fragment_type":"issue_comment","sequence":1,"text":"1. In the spec you mentioned startingPointList, is that the same as the pointList passed in as props?\n2. What's the reason to initialize groupedPointList to deep-clone of startingPointList if it was empty? Assuming an empty groupedPointList means no grouping yet.\n3. What exactly is groupedPointList, is it a list of nested Point object? (edited) \n4. Is this GroupingStep responsible for rendering the header (the create group button, and the groups created counter ...)\n5. The shared prop is\nan object with data that can be manipulate (mutated) by the steps\nI am not too sure what manipulate by the steps means, I am suppose to have states that keep track of the current displayed points and grouped points correct?","author_login":"zilinfg","author_association":"CONTRIBUTOR","created_at":"2024-02-23T04:48:10+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1960731363","fragment_type":"issue_comment","sequence":2,"text":"@zilinfg \n \nYes. I will update the issue so that both are pointList\n \n\nIt means that this is the first time the user has come to this step (component). But the user might move forward and backward though different components. The shared object keeps the data as users move through the steps. \n \nIt is a list of pointObj, \n\nTake a look at this component, #35 I should have listed it as a dependency, but it's almost done, and you can see the code for it in one of the PR #85 . \n\nBut basically, the groupedPointList is a list of pointObj, but some of the pointObj will have the groupedPoints property, which is a list of pointObj.\n\nFor each point rendered in this component, the PointGroup should be used - it will render a Point if there are no groupedPoints\n \nYes. It's and it's also responsible for manage the states the user goes though as they preform the actions of these buttons. \nThere is a button component you should use, and there is a status-badge component. See both in storybook. \nAnd I am happy to do a call and talk through the UI of the GroupingStep. \n \n\"an object with data that can be manipulate (mutated) by the steps\"\nI am not too sure what manipulate by the steps means, I am suppose to have states that keep track of the current displayed points and grouped points correct?\n\nThere are several \"steps\" in the discussion process. Each step is a component. Later steps may use data generated by previous steps. The `shared` object is created by a parent component so that it persists, and the properties added to it persist as the user goes forward, and possible backward through the steps. If you go through the older version of civil-pursuit at URL you can see what the steps are like, and how you can go backward and forward through them. \n\nOther components are going to use the groupedPointList after this component creates it. But the user may decide to come back and change groupings.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-02-23T04:54:04+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[1909530919],"is_known_query_context":false},{"document_id":"gh_comment_1962264747","fragment_type":"issue_comment","sequence":3,"text":"That makes a lot more sense! Do I call onDone to update the groupPointList?","author_login":"zilinfg","author_association":"CONTRIBUTOR","created_at":"2024-02-24T05:39:39+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[1909530919],"is_known_query_context":false},{"document_id":"gh_comment_1962268476","fragment_type":"issue_comment","sequence":4,"text":"Yes. Call onDone everytime the user has made a change to the list. Value should be the list. Valid should be true if it's a valid list and fals if not. I don't know what would not be but you may run into a case. \n\n⁣Get BlueMail for Android ​\n\nOn Feb 23, 2024, 9:39 PM, at 9:39 PM, zilinfg ***@***.***> wrote:","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-02-24T05:57:56+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[1909530919],"is_known_query_context":false},{"document_id":"gh_comment_2035662303","fragment_type":"issue_comment","sequence":5,"text":"@zilinfg How is this going? By the conversations it seems like you've done a lot on this. If you don't have time to finish it, please consider pushing what you've got and I could find someone to start from there. It's getting to the point where things are coming together. Thanks.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-04-03T21:50:52+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2035702679","fragment_type":"issue_comment","sequence":6,"text":"Hi I just saw pointGroup was done and I'll be making progress on it. I do have time for this and will get it done asap.","author_login":"zilinfg","author_association":"MEMBER","created_at":"2024-04-03T22:20:23+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2039003808","fragment_type":"issue_comment","sequence":7,"text":"@ddfridley Quick question, Is this component responsible for rendering the step footer? Look at other steps I am assuming it doesn't.","author_login":"zilinfg","author_association":"MEMBER","created_at":"2024-04-05T05:55:33+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2039896818","fragment_type":"issue_comment","sequence":8,"text":"Correct. Thanks. \n\n⁣Get BlueMail for Android ​\n\nOn Apr 4, 2024, 10:55 PM, at 10:55 PM, zilinfg ***@***.***> wrote:","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-04-05T14:05:21+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2040964100","fragment_type":"issue_comment","sequence":9,"text":"@ddfridley Hi, I am a little confused on how to achieve this selected effect.\n\n<img width=\"527\" alt=\"Screenshot 2024-04-05 at 9 29 39 PM\" src=\" URL \n\nI am assuming the user can freely select and unselect the points and click create group to proceed with the selected points.\n\nAnd you mentioned to use pointGroup to render every point in this component. But for the default state in PointGroup, I cannot select and unselect the PointGroup.","author_login":"zilinfg","author_association":"MEMBER","created_at":"2024-04-06T04:42:20+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2040965640","fragment_type":"issue_comment","sequence":10,"text":"You are right. The expedient thing to do here is to use the Point component. The props are a little different, but the result will be the same UI.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-04-06T04:51:59+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2043284640","fragment_type":"issue_comment","sequence":11,"text":"I see there's no quick fix. You are right that the selected vState needs to be implemented in the PointGroup component. Please go ahead and do that as part of this issue, please also add a story to point-group.stories for the new state.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-04-08T17:24:18+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091884799","fragment_type":"issue_comment","sequence":12,"text":"@zilinfg I appreciate you work on this. This grouping step is one of the new features and I'm under pressure to get it out so we can have the UI reviewed, so I picked it up.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-05-02T23:03:30+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1958462714,"issue_number":49,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/49","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1909530919","fragment_type":"issue_description","sequence":0,"text":"Point Group Component\n- [ ] Create a PointGroup react component.\n\nThe Point Group component accepts pointObj and vState as props\n\nexport type pointObj = {\n _id: MongoId,\n subject: string,\n description: string,\n groupedPoints?: [pointObj]\n}\n\n<PointGroup\n pointObj: {}\n vState: '' // same as Point component\n \n\nTo each Point Component #23 it will pass a pointObj, it will add a Select as Lead component as an additional child - if necessary.\n\nfigma\nimage\n\nSee the figma design for the various states. This component covers the \"Edit Lead\" and \"Select Lead\" cases shown in figma.\n\nThe Point Components will render in a flex box that could be one or two columns wide - depending on the view port. \n\nThe Point Group component will render in it's various states bases on the value of state.\nFor example, collapsed and open.\n\n- [x] create a story that renders this component in each of its various states.\n- [x] default state\n- [x] edit state\n- [x] view state\n- [x] select lead state\n- [x] collapsed - The point component needs to render a \"collapsed\" vState that just renders the subject. See figma\n\nimage\n- [x] same vStates as pointComponent\n- [x] the component needs to implement the actions to move from state to state - for example - but in development this will need to be expanded:\n- [x] From the default state (showing only the lead item) if the user clicks on the chevron - change to the view state\n- [x] If the user clicks the edit button, move to the edit state","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2023-09-22T21:18:56+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1909530919,"issue_number":35,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1841565216","fragment_type":"issue_comment","sequence":1,"text":"@Boyuan-Yu You asked: Can you help me confirm the following?\nFirst - please also see the desktop layout - URL Orchid (the designer) created the components page, but we also need to look at the design page to see what's most up to date. The pointGroup component should be the same whether desktop or smartphone, but I want to make sure we pickup all the latest - which would be in the design page (rather than the components page looking at the column on the right of figma).\n\n1. The Point Group component has 3 states: Default, Edit, View. In Default, clicking ‘Edit’ button goes to Edit state, and Clicking arrow on the right top goes to View state.\n - What all the states are is a conclusion you will figure out as you are implementing. But I think there is one other state besides what you mention for choosing the lead item. \n\n3. The Point Group component takes a PointObj which is the lead point and the rest pointObjs are in the list of the lead PointObj.\n- The rest are in the groupedPoints of the lead PointObj\n\n4. I assume the Select Lead component takes a list of PointObj.\n- Select Lead is a Button, with an onDone function. The onDone function for each button should be associated to the object it references. Could be by object, or could be by _id in the object. Depends on how you implement it. When you get there I can help. \n\n- 5. Since there is no dark mode for Point, I assume no dark mode for PointGroup?\nCorrect.","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2023-12-05T20:29:29+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1909530919,"issue_number":35,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851135967","fragment_type":"issue_comment","sequence":2,"text":"How does the GroupPoint Component get the values for dem-info like \"Republican, 45 ,UT\"? Are they in pointObj?","author_login":"Boyuan-Yu","author_association":"COLLABORATOR","created_at":"2023-12-12T00:58:51+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1909530919,"issue_number":35,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915993284","fragment_type":"issue_comment","sequence":3,"text":"@Boyuan-Yu About one point having a longer description than another when 2 are in the same row, the designer says that we should have the point component fill the row, and pull down the Select as Lead button.\n\nYou can choose to take this on - but it's probably changes to the point component, or we can make a separate issue out of it and deal with it later. \n\nBasically do you think this is an quick change or a hard one?\n\n<img width=\"1353\" alt=\"image\" src=\" URL","author_login":"ddfridley","author_association":"CONTRIBUTOR","created_at":"2024-01-30T03:08:00+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1909530919,"issue_number":35,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1924548073","fragment_type":"issue_comment","sequence":4,"text":"@ddfridley It should be a quick fix. Let me see what I can do.","author_login":"Boyuan-Yu","author_association":"COLLABORATOR","created_at":"2024-02-02T19:30:12+08:00","repo_name":"EnCiv/civil-pursuit","issue_id":1909530919,"issue_number":35,"issue_url":"https://github.com/EnCiv/civil-pursuit/issues/35","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0206","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Tracking: MDIMs - Pending issues?","query_context":"⚠️**This issue is very general and helped kick off the discussion on various fronts. Read for the whole story, but you can also directly jump to the more scoped tracking issue that emerged:**\n- #3992\n\n--- \n\n**NOTE: Some of the issues raised in this thread involve design/engineering work, so we should probably raise them in URL Still, I think we can discuss here shorter-term solutions and help coordinate with progress in other repos**\n\n# One-liner\nMDIMs are almost ready to be used from a data perspective. However, there are some minor pending issues that would be nice to solve before they become a regular tool.\n\n## More context\nIn the last months, I’ve been working on various MDIMs for COVID-19 (tracking issue: URL ETL PR: #3949)… There are 13 in total! In this context, I’ve come across various issues with MDIMs. Some have been addressed and already fixed (👏), and others remain unresolved. \n\nMost of my COVID MDIMs are fine, but some (~10%) have special characteristics that current specs do not support. While these are exceptions, they still represent part of our work and products.\n\nSome of these issues involve design work, engineering work, data work, or a combination of these.\n\n# Issues\n## 1) If a view of an MDIM contains multiple indicators, not all metadata is shown.\n \n \n\nSometimes, we may want a view of the MDIM to show multiple indicators. In such cases, the metadata around the MDIM page should be adapted so that it shows all indicators present in the view.\n\nCurrently, only the metadata of one of all indicators is shown. Presumably, the first one?\n\n## 2) Support different default entities for different views\n \n \n\nSometimes, we may want different views to show different entities by default. The example above presents data disaggregated by income groups in the default view. A second view, uses indicators that don’t have these entities, hence I want to use other defaults. This is currently not supported.\n\nI think this is because MDIMs look at the top-level property `defaultSelection` and ignore the chart-config-level property. You can see the current config of the above MDIM here.\n\n## 3) Expand dimensions automatically\n \n \n\nWe should be able to generate very simple MDIMs without writing much in the accompanying YAML file. Simple MDIMs could be those where we just want to explore the dimensions of a certain indicator and show a view for each one. In such cases, we should be able to auto-generate them.\n\nThere have been two attempts at supporting this, but IMO, they both still have pain points:\n\n### Method `etl.multidim.expand_views`\n \n1. This method currently accesses the database to get the details on the dimensions in the table. \n2. This goes against our view on how MDIMs should work, which was recently discussed in #. Instead, the method should only rely on local files (ETL grapher datasets).\n\n### Method`etl.multidim.generate_views_for_dimensions`\n \n1. This function gets dimension information from local ETL grapher files\n2. This function assumes a particular, unstandardized naming convention of table column names.\n3. Currently, the only standard that is widely used in the team (by at least 5 of us) is different: \n - When using _long format_ In Garden, dimensions are part of the index. \n - Then, in Grapher, these are flattened out so that columns have names like `indicator__dimension1Name_dimension1Value__dimension2Name_dimension2Value`. Example: `population__sex_female__age_10`.","known_context_document_ids":["gh_issue_2849350202"],"reference_answer":"It's hard to say where to draw the line. Python uses under_score and MySQL & TS camelCase. ETL uses mix of both - in most cases underscore, but for instance `display` is in camelCase because it's directly inserted into db.\n\nAs far as I know, this hasn't caused that many problems, as most of them were caught by our YAML linter. I'll leave it up to @lucasrodes and other data managers to decide what is the preferred casing and whether it's worth changing it.","answer_document_id":"gh_comment_2662322215","silver_evidence_path":["gh_comment_2660926121","gh_issue_2854221975","gh_comment_2662322215"],"evidence_issue_ids":[2849350202,2854221975],"source_repo_name":"owid/etl","source_issue_id":2849350202,"source_issue_number":3969,"source_issue_url":"https://github.com/owid/etl/issues/3969","target_repo_name":"owid/etl","target_issue_id":2854221975,"target_issue_number":3977,"target_issue_url":"https://github.com/owid/etl/issues/3977","reference_anchor_document_id":"gh_comment_2660926121","reference_answer_author":"Marigold","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4211,"anchor_target_overlap":0.1579,"target_answer_overlap":0.1795},"issue_created_at":"2025-02-12T21:04:47+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_2849350202","fragment_type":"issue_description","sequence":0,"text":"Tracking: MDIMs - Pending issues\n⚠️**This issue is very general and helped kick off the discussion on various fronts. Read for the whole story, but you can also directly jump to the more scoped tracking issue that emerged:**\n- #3992\n\n--- \n\n**NOTE: Some of the issues raised in this thread involve design/engineering work, so we should probably raise them in URL Still, I think we can discuss here shorter-term solutions and help coordinate with progress in other repos**\n\n# One-liner\nMDIMs are almost ready to be used from a data perspective. However, there are some minor pending issues that would be nice to solve before they become a regular tool.\n\n## More context\nIn the last months, I’ve been working on various MDIMs for COVID-19 (tracking issue: URL ETL PR: #3949)… There are 13 in total! In this context, I’ve come across various issues with MDIMs. Some have been addressed and already fixed (👏), and others remain unresolved. \n\nMost of my COVID MDIMs are fine, but some (~10%) have special characteristics that current specs do not support. While these are exceptions, they still represent part of our work and products.\n\nSome of these issues involve design work, engineering work, data work, or a combination of these.\n\n# Issues\n## 1) If a view of an MDIM contains multiple indicators, not all metadata is shown.\n \n \n\nSometimes, we may want a view of the MDIM to show multiple indicators. In such cases, the metadata around the MDIM page should be adapted so that it shows all indicators present in the view.\n\nCurrently, only the metadata of one of all indicators is shown. Presumably, the first one?\n\n## 2) Support different default entities for different views\n \n \n\nSometimes, we may want different views to show different entities by default. The example above presents data disaggregated by income groups in the default view. A second view, uses indicators that don’t have these entities, hence I want to use other defaults. This is currently not supported.\n\nI think this is because MDIMs look at the top-level property `defaultSelection` and ignore the chart-config-level property. You can see the current config of the above MDIM here.\n\n## 3) Expand dimensions automatically\n \n \n\nWe should be able to generate very simple MDIMs without writing much in the accompanying YAML file. Simple MDIMs could be those where we just want to explore the dimensions of a certain indicator and show a view for each one. In such cases, we should be able to auto-generate them.\n\nThere have been two attempts at supporting this, but IMO, they both still have pain points:\n\n### Method `etl.multidim.expand_views`\n \n1. This method currently accesses the database to get the details on the dimensions in the table. \n2. This goes against our view on how MDIMs should work, which was recently discussed in #. Instead, the method should only rely on local files (ETL grapher datasets).\n\n### Method`etl.multidim.generate_views_for_dimensions`\n \n1. This function gets dimension information from local ETL grapher files\n2. This function assumes a particular, unstandardized naming convention of table column names.\n3. Currently, the only standard that is widely used in the team (by at least 5 of us) is different: \n - When using _long format_ In Garden, dimensions are part of the index. \n - Then, in Grapher, these are flattened out so that columns have names like `indicator__dimension1Name_dimension1Value__dimension2Name_dimension2Value`. Example: `population__sex_female__age_10`.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-12T21:04:47+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2655097825","fragment_type":"issue_comment","sequence":1,"text":"## On issue 3:\nI personally think that we should strive to converge and use the same standard. I think that the standard from point 3 is the closest we've gotten so far. It is used in several places now:\n - Fiona: Global Antimicrobial Resistance, IGME, ...\n - Veronika: Country Activity Tracker: Artificial Intelligence, WHO Mortality Database - Cancer Deaths, ...\n - Pablo Arriagada: Global Multidimensional Poverty index, ...\n - Lucas: UN WPP, UCDP, ...\n - Mojmir: Global Health Observatory - World Health Organization, ...\n\nHowever, it is not error-free. One issue it has is that sometimes there might be collisions since `__` (double underscore) is used to replace special characters! See the indicator URI of this example.\n\n### Possible solution\nWe could leverage the information stored in `tb.['column_name'].metadata.additional_info[\"dimensions\"]`, which contains the dimension information. This would prevent us from (i) accessing DB, and (ii) assuming any specific column naming.\n\npy\n \n \n \n{'originalShortName': 'trend',\n 'originalName': 'Trend - Place: Grocery and pharmacy',\n 'filters': [{'name': 'place', 'value': 'Grocery and pharmacy'}]}\n\nOne thing that we will need to solve is for those steps where long-format is not used. My guess is that this information on dimensions is not generated, since there is no place to look for it. In such cases, we should have some functions to manually add this information.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-12T23:46:39+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2655995138","fragment_type":"issue_comment","sequence":2,"text":"## On issue 1\nMartin shared a workaround for the time being. It consists on \"hacking\" the config fields for each view, so that they contain information on all the indicators present. \n\nFor this, we need to figure out how this combination should play out. I'd say, we have to implement some custom function that does this. Eventually, this is will no longer be needed because the MDIM page design will allow for multiple indicators shown.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T09:23:05+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656070186","fragment_type":"issue_comment","sequence":3,"text":"Hi @lucasrodes, thanks for this summary!\nI'd say issues 1 and 2 should possibly be moved to `owid-grapher`. Or is there anything that can be done from the ETL side?\n\nRegarding issue 3, as far as I know, we have never established a standard for naming indicators. However, I agree that over the years, certain ad-hoc criteria have emerged.\n\nYour suggestion is fine, but we have at least two problems:\n* As you pointed out, our `underscore` method creates `__` to replace punctuation (e.g. `,`, or `)`). This is unfortunate (and I remember I suggested long ago that we should avoid it). So this means we can't have a robust way to distinguish dimension using simply double underscores.\n* With this format, it's not particularly easy to visually discern the dimensions from the name (especially due to the previous problem). This is not a technical problem, but it would be more convenient to have short names that are easy for us to visually parse.\n\nMaybe we could consider other possibilities, e.g.:\n`indicator||dimension1Name|dimension1Value||dimension2Name|dimension2Value||...`\nThis is similar to what I've used for FAOSTAT. I think the pipes `|` help distinguish dimensions visually. And this would not depend on whether we use single or double underscores.\n\nIdeally, we would change our `underscore` function to use only `_`, but this would probably require a big refactor, which may not be worth it.\n\nWe can discuss it on our next call. But whatever we decide, I think adapting our function `generate_views_for_dimensions ` would be easy.","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-13T09:54:49+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656107048","fragment_type":"issue_comment","sequence":4,"text":"Thanks for weighing in, @pabloarosado !\n \nI agree that points 1 and 2 are suitable for `owid-grapher`. Still, I think is good that we discuss them here, and find some shorter-term solution for us. I'll add a clarification to the issue description.\n\nAn example is for point 1, I will start implementing some function to \"hack\" the config of the view to fit in all different metadata fields from indicators present in that view. This is not intended as a final solution, but my impression is that point 1 can be long before resolved (involves design and engineering work).\n \nMy suggestion is mostly motivated by trying to reduce the maintenance burden. I am not particularly attached to the status quo, but I think it is the best that we have at the moment. I don't particularly like your approach in having indicators named `indicator_dimension1Value_dimension2Value_...`, I think that is more susceptible to collisions, and it is also hard to distinguish indicator names from dimension values/names.\n\nNow, I totally agree that that using `__` comes with its own perks. It is also true that several parts of our tooling (e.g. long-to-wide format change functions) are based on this current naming. So, even if it has perks, it has become the closest thing we have to a standard. I think that if we all follow this criterion, even if suboptimal, it can make our lives easier (e.g., tooling maintenance). An example is your recent function `multidim.generate_views_for_dimensions`, which is a great resource but unsuitable for most of us. Instead, `multidim.expand_views` was suitable for most of us (even if accessing the DB, which I agree we shouldn't)\n\nHaving said all of this, again, I am very open to revisiting how the URIs are created for multidimensional indicators. I actually think we should use something else in the long term. I am unsure how these would affect existing charts, etc., so we should pay attention when doing that.\n \n\nAs per format examples, I personally would go with something easier to understand and closer to common standards (e.g. in query URLs):\n\nindicator_dimension1Name=dimension1Value_dimension2Name=dimension2Value\n\nor\n\nindicator&dimension1Name=dimension1Value&dimension2Name=dimension2Value\n\nFor that, I'd ban symbols like `=` and `&` from our indicator names (e.g., have a check in the pipeline to prevent their usage).","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T10:09:20+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656115060","fragment_type":"issue_comment","sequence":5,"text":"On issue 1, one possible solution from the ETL side would be to warn the user when a view uses multiple indicators, to ensure a combined metadata is used (unclear exactly how and whether this could be come annoying).","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-13T10:12:38+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656122589","fragment_type":"issue_comment","sequence":6,"text":"FWIW, I am currently working on solutions for points 1 and 3.\n\n1: Interim methods to combine metadata in views with multiple indicators\n3: update `expand_views` to use only ETL files, and exploit the internally stored information on dimensions.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T10:15:17+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656134954","fragment_type":"issue_comment","sequence":7,"text":"On issue 2, looking at this mdim page, I see your point, but I'm wondering if this is a common scenario, or whether this dropdown is showing two different indicators, and hence they should not be in the same mdim page (they have different entities). This may need some discussion.","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-13T10:20:19+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656148700","fragment_type":"issue_comment","sequence":8,"text":"@pabloarosado yup, it's an edge case. I can see this totally being an issue though. In this case, the two indicators are a bit different, but imagine the following example:\n\n- You plot an indicator in absolute and relative terms.\n- For absolute terms, you have values for regions. But for relative numbers you don't.\n- You want to show data for continents (or world) as default for absolute. In relative, you can't so you want to choose a set of countries / make map the default, etc.\n\nI see how you could try to choose default entities in both; but still, I think there could be instances (few ones) where there could be none.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T10:25:41+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656157650","fragment_type":"issue_comment","sequence":9,"text":"Mmh... I think it can be valuable to start drafting something. Otherwise I find it hard to tackle this problem. We can improve later on.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T10:29:16+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656269216","fragment_type":"issue_comment","sequence":10,"text":"Hey @lucasrodes, a few comments:\n1) In the energy prices multidim page I show a view with multiple indicators, and the way I handled that special case was quite manual and suboptimal. It would be great to figure out some generic function to combine metadata. I'm wondering what the default behaviour should be. For example, what should we do with key description points, combine them all, remove them all...?\n\n2) On the default entities, we also need to keep in mind user experience. If someone selects certain entities, it's odd if that choice is not respected. But I understand that, in some cases, it may be the best strategy. This may need further discussion (and it's more on the grapher or design side of things).\n\n3) Regarding the criterion for flattened short names, I think the (not ideal, but) least painful solution would be indeed what you proposed, which is to separate dimensions with `__`. There will be oddities, but hopefully it won't cause many headaches. We need to also keep in mind that these names should be URL-friendly, in case we want to surface them anywhere. So having pipes or other symbols could be problematic too. Feel free to change the function I created for this purpose (I designed it with only my current case in mind, so I'm happy to generalize it with a specific criterion). I'm happy to adapt the `energy_prices` step if needed, to adhere to this criterion.","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-13T11:11:02+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656282193","fragment_type":"issue_comment","sequence":11,"text":"1: description_key is a tricky one, unclear to me. I haven't yet started tackling it (I am looking at point 3), feel free to start drafting if you feel like. Otherwise i'll tackle it later.\n2: Agree, it can be confusing for end-user. \n3: I'm working on a solution to exploit the information from `tb.['column_name'].metadata.additional_info[\"dimensions\"]`. I think that's the most robust solution. I'll ping you when I have that ready so you can try it out.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T11:16:41+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656332052","fragment_type":"issue_comment","sequence":12,"text":"Feel free to break this tracking issue into smaller pieces as needed.\n\nRegarding the URL format for short names, I think they should meet two conditions:\n(i) They should be directly usable in a URL without requiring encoding (i.e., avoiding characters that need to be escaped).\n(ii) They should not conflict with standard URL behaviors. For example, using `&` in an indicator short name could cause issues when navigating pages. These choices should be aligned with Grapher's logic to avoid unintended behavior. A safer approach would be to restrict short names to symbols that don't have special meanings in URLs.\n\nOur current `underscore` method fulfils these criteria (with the unfortunate downside of arbitrary use of single and double underscores). I hope that makes sense!","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-13T11:38:13+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2656353957","fragment_type":"issue_comment","sequence":13,"text":"I see; mmh.\n\nAre you thinking of cases like \n\nurl/?indicator=...¶m1=...¶m2=...\n\nwhere having `&` and `=` in the value for `indicator` would conflict with other bits of the query in the url? I guess I am not sure this use case actually occurs at the moment. But I see your point.\n\nHaving said all of this, I am now thinking that maybe we don't really need to do anything at all here. Identifying the dimensions from the column names is not great, and we should instead use `tb.['column_name'].metadata.additional_info[\"dimensions\"]` as I mentioned above. As long as that field is present, we don't really care about the column name","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-13T11:48:00+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2658576915","fragment_type":"issue_comment","sequence":14,"text":"Absolutely, `additional_info[\"dimensions\"]` should contain everything we need. De-constructing underscored names would be too tricky. Just for some context - we went for alphanumeric & `_` to have valid SQL column names and to be able to query it. We haven't used it as much as we thought, but we should keep it in mind if we decide to switch (I personally don't have any issues with `_` and `__`.)","author_login":"Marigold","author_association":"COLLABORATOR","created_at":"2025-02-14T08:25:50+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2658691698","fragment_type":"issue_comment","sequence":15,"text":"Thanks for chiming in @Marigold. Yes, if we have dimensions info stored somewhere in the metadata, that's clearly a better option than extracting it from short names. This works well with the common approach e.g. in some of the datasets mentioned by Lucas above.\n\nThere's one downside, though. As far as I understand, this is generated **in the grapher step**. In principle, our goal has always been to keep our best data in garden, and let grapher be a step of minimal changes to adjust to our data viz needs. Using jinja templates in garden is shifting our best data to grapher (the resulting metadata is not human-readable in those garden steps). The consequence of this is that, currently, our best data is sometimes in garden, and sometimes in grapher. Maybe this is the direction we want to go, but we should be explicit about this choice, instead of letting our technical limitations make this decision for us.\n\nI know this goes beyond the scope of this issue, but maybe we should clarify as soon as possible our long-term vision of garden and grapher. I think it should be possible to achieve both: (1) having our best data in garden, and (2) handling multidimensional data.","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-14T09:13:34+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2658960090","fragment_type":"issue_comment","sequence":16,"text":"My two cents on your points, @pabloarosado:\n\nThis metadata on dimensions is generated automatically when formatting long-format (from Garden) to wide format (in Grapher), which occurs in the `grapher` step.\n\nI think it's totally fine to keep it like this. I don't see any problem in having Jinja in the YAML files of Garden. Someone that looks into our codebase, should expect to encounter things like that. For end consumers that are not interested in \"how we build\" things, they can just access the metadata that is exported to JSON files. That metadata is public-ready, and won't contain any Jinja templating.\n\nHaving said this, we need to find a way to ingest the metadata on dimensions whenever one uses a wide format. If using long-format, it will be automatically generated (since the dimensional information is already in the index), but it won't be the case otherwise. In those cases, I think you need some way to manually add this layer of information. I never use this structure, but I know you do, so it'd be very valuable if you come with a strategy to add the metadata on dimension in those cases. Happy to help!\n\nAlso, more than happy to discuss further steps any time.","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-14T10:46:28+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2659054289","fragment_type":"issue_comment","sequence":17,"text":"Thanks for the synthesis, @lucasrodes, you have phrased the situation very well, and I agree with your conclusions. Just one clarification: embracing long formats also implies additional tooling (they clash with our current data structure, where metadata is stored at the column level).\nSo let's try to allocate some time in our upcoming discussions to decide a roadmap on where to go in terms of (1) our preferred data (and metadata) structures, and (2) our data catalog.","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-02-14T11:25:13+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2660926121","fragment_type":"issue_comment","sequence":18,"text":"We've started to break down the remaining data work for MDIMs in smaller issues.\n\n**On issue 1:**\n- #3981\n\n**On issue 3:**\nThis is now possible! This still needs to be documented, but we have the following PR as a reference for now:\n\n- URL \n\n**Other issues**\n- #3976\n- #3977\n- #3979\n- #3980","author_login":"lucasrodes","author_association":"MEMBER","created_at":"2025-02-15T13:27:55+08:00","repo_name":"owid/etl","issue_id":2849350202,"issue_number":3969,"issue_url":"https://github.com/owid/etl/issues/3969","linked_issue_ids":[2854221975],"is_known_query_context":false},{"document_id":"gh_issue_2854221975","fragment_type":"issue_description","sequence":0,"text":"MDIMs: Standardize casing convention for indicator and metadata\nIndicators use snake_case\n\nMDIMs use camelCase\n\nCan I make it any more obvious?\n\nThis seems like a footgun. It means we can't easily share JSON schemas between the two, and will probably make mistakes involving copying YAML with the wrong casing into the wrong file.\n\nIMO there should only be one convention, but I'll leave that to @lucasrodes and the rest of the data engineers to decide 🙂","author_login":"ikesau","author_association":"MEMBER","created_at":"2025-02-14T16:38:13+08:00","repo_name":"owid/etl","issue_id":2854221975,"issue_number":3977,"issue_url":"https://github.com/owid/etl/issues/3977","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2662322215","fragment_type":"issue_comment","sequence":1,"text":"It's hard to say where to draw the line. Python uses under_score and MySQL & TS camelCase. ETL uses mix of both - in most cases underscore, but for instance `display` is in camelCase because it's directly inserted into db.\n\nAs far as I know, this hasn't caused that many problems, as most of them were caught by our YAML linter. I'll leave it up to @lucasrodes and other data managers to decide what is the preferred casing and whether it's worth changing it.","author_login":"Marigold","author_association":"COLLABORATOR","created_at":"2025-02-17T07:59:26+08:00","repo_name":"owid/etl","issue_id":2854221975,"issue_number":3977,"issue_url":"https://github.com/owid/etl/issues/3977","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2663806666","fragment_type":"issue_comment","sequence":2,"text":"Yeah it's a shame the 2 languages have different conventions here.\n\nI'm more than happy to close this immediately if it's not a problem for anyone - Lucas just suggested I create a ticket for it after I remarked on it in our DMs. I think the actually impactful thing is making sure that topic tags are validated consistently, but consistent casing isn't a requirement for that.","author_login":"ikesau","author_association":"MEMBER","created_at":"2025-02-17T18:01:21+08:00","repo_name":"owid/etl","issue_id":2854221975,"issue_number":3977,"issue_url":"https://github.com/owid/etl/issues/3977","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665596643","fragment_type":"issue_comment","sequence":3,"text":"Up to you, I don't mind having it on our eyes for some time. Either we figure it out or owidbot closes it.","author_login":"Marigold","author_association":"COLLABORATOR","created_at":"2025-02-18T12:37:53+08:00","repo_name":"owid/etl","issue_id":2854221975,"issue_number":3977,"issue_url":"https://github.com/owid/etl/issues/3977","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2703963624","fragment_type":"issue_comment","sequence":4,"text":"It seems difficult to have a convincing solution that doesn't become extremely complicated. Hopefully autocomplete helps. If this becomes an issue in the future we can reconsider :-/.","author_login":"pabloarosado","author_association":"CONTRIBUTOR","created_at":"2025-03-06T14:11:33+08:00","repo_name":"owid/etl","issue_id":2854221975,"issue_number":3977,"issue_url":"https://github.com/owid/etl/issues/3977","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0208","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"`centos2alma` script fails on '/etc/fstab' ordering pre-conversion check?","query_context":"**Describe the bug**\nWhen attempting to run the centos2alma script following the instructions in the README ( URL the process fails during the pre-conversion checks phase.\n\n**Environment:**\n\nOS: CentOS Linux 7.9.2009 (Core)\nPlesk Version: Plesk Obsidian 18.0.68 Update #2\n\nThe script halts execution with the following specific error message, indicating an issue with the order of mount points listed in the `/etc/fstab` file:\n\nDoing preparation checks...\nRequired pre-conversion condition 'checking if /etc/fstab is ordered properly' not met:\n The /etc/fstab file entries is not ordered properly.\n - Mount point /proc should be placed after /\n - Mount point /dev/pts should be placed after /\n - Mount point /dev/shm should be placed after /\n - Mount point /sys should be placed after /\n - Mount point /boot should be placed after /\nConversion can't be performed due to the problems noted above\n\n**Feedback archive**\n\ncentos2alma_feedback.zip","known_context_document_ids":["gh_issue_2966832312"],"reference_answer":"The issue seems to occur because the new kernel version changes the names of the RAID devices in the system.\n\nWe haven't encountered this issue previously, so I suggest manually setting the names of the RAID devices via the command line in the kernel. Alternatively, you could use the UUID of the RAID devices in the /etc/fstab file, which I believe is more reliable (as explained by Jeff Geerling, for example). Here’s how you can do it:\n1. Find out the UUID of the RAID device using the command `blkid /dev/md/125`.\n2. Replace `/dev/md/125` with the UUID in the `/etc/fstab` file.\n\nIt might also be a good idea to revert to a system snapshot taken before the conversion and modify the `/etc/fstab` before starting the conversion process.","answer_document_id":"gh_comment_2499718985","silver_evidence_path":["gh_comment_2775830167","gh_issue_2686014772","gh_comment_2499718985"],"evidence_issue_ids":[2966832312,2686014772],"source_repo_name":"plesk/centos2alma","source_issue_id":2966832312,"source_issue_number":437,"source_issue_url":"https://github.com/plesk/centos2alma/issues/437","target_repo_name":"plesk/centos2alma","target_issue_id":2686014772,"target_issue_number":388,"target_issue_url":"https://github.com/plesk/centos2alma/issues/388","reference_anchor_document_id":"gh_comment_2775830167","reference_answer_author":"SandakovMM","reference_answer_author_association":"COLLABORATOR","quality_score":95.9,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2162,"anchor_target_overlap":0.3514,"target_answer_overlap":0.098},"issue_created_at":"2025-04-02T15:42:42+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2966832312","fragment_type":"issue_description","sequence":0,"text":"`centos2alma` script fails on '/etc/fstab' ordering pre-conversion check\n**Describe the bug**\nWhen attempting to run the centos2alma script following the instructions in the README ( URL the process fails during the pre-conversion checks phase.\n\n**Environment:**\n\nOS: CentOS Linux 7.9.2009 (Core)\nPlesk Version: Plesk Obsidian 18.0.68 Update #2\n\nThe script halts execution with the following specific error message, indicating an issue with the order of mount points listed in the `/etc/fstab` file:\n\nDoing preparation checks...\nRequired pre-conversion condition 'checking if /etc/fstab is ordered properly' not met:\n The /etc/fstab file entries is not ordered properly.\n - Mount point /proc should be placed after /\n - Mount point /dev/pts should be placed after /\n - Mount point /dev/shm should be placed after /\n - Mount point /sys should be placed after /\n - Mount point /boot should be placed after /\nConversion can't be performed due to the problems noted above\n\n**Feedback archive**\n\ncentos2alma_feedback.zip","author_login":"andrefilsantos","author_association":"NONE","created_at":"2025-04-02T15:42:42+08:00","repo_name":"plesk/centos2alma","issue_id":2966832312,"issue_number":437,"issue_url":"https://github.com/plesk/centos2alma/issues/437","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2774678720","fragment_type":"issue_comment","sequence":1,"text":"Hello @andrefilsantos,\nPlease provide the `/etc/fstab` file from the host.","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2025-04-03T07:02:06+08:00","repo_name":"plesk/centos2alma","issue_id":2966832312,"issue_number":437,"issue_url":"https://github.com/plesk/centos2alma/issues/437","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2775830167","fragment_type":"issue_comment","sequence":2,"text":"The issue concerns the order of entries in the file. To resolve it, you need to move the following entry to the top line of the file:\n\n# /dev/md/2\nUUID=df552999-2da7-4602-8732-742fca11c0dc / ext4 defaults 0 0\n\nWe implemented the pre-checker witch was failed, because Leapp has a similar check and stops the conversion if \"child\" directories appear before the root directory.\nYou can find more information in issue #388.","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2025-04-03T13:40:24+08:00","repo_name":"plesk/centos2alma","issue_id":2966832312,"issue_number":437,"issue_url":"https://github.com/plesk/centos2alma/issues/437","linked_issue_ids":[2686014772],"is_known_query_context":false},{"document_id":"gh_issue_2686014772","fragment_type":"issue_description","sequence":0,"text":"Upgrade failue with centos2alma-1.4.3\n**Describe the bug**\nI fixed some of the issues in pre upgrade then it is started to do changes but it failed and I had to revert back otherwise server not responsive.\n\nHere is the last lines before exit from the process and I also attached the feedback file.\n\n2024-11-23 14:02:55,582 - INFO - stdout: Debug output written to /var/log/leapp/leapp-preupgrade.log\n2024-11-23 14:02:55,583 - ERROR - Command ['/usr/bin/leapp', 'preupgrade'] failed with return code 1\n2024-11-23 14:02:55,583 - ERROR - Failed: doing the conversion. The reason: Command '['/usr/bin/leapp', 'preupgrade']' returned non-zero exit status 1.\n\n*Please attach a feedback archive to the bug report.*\ncentos2alma_feedback.zip","author_login":"gokhand","author_association":"NONE","created_at":"2024-11-23T13:34:23+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2495742035","fragment_type":"issue_comment","sequence":1,"text":"Same here.\n2024-11-24 01:25:55,693 - INFO - stderr: File \"/usr/lib64/python2.7/multiprocessing/managers.py\", line 625, in _finalize_manager\n2024-11-24 01:25:55,693 - INFO - stderr: process.terminate()\n2024-11-24 01:25:55,882 - INFO - stderr: File \"/usr/lib64/python2.7/multiprocessing/process.py\", line 137, in terminate\n2024-11-24 01:25:55,882 - INFO - stderr: self._popen.terminate()\n2024-11-24 01:25:55,882 - INFO - stderr: File \"/usr/lib64/python2.7/multiprocessing/forking.py\", line 171, in terminate\n2024-11-24 01:25:55,882 - INFO - stderr: os.kill(self.pid, signal.SIGTERM)\n2024-11-24 01:25:56,206 - INFO - stdout: Creates the upgrade initramfs\n2024-11-24 01:25:56,206 - INFO - stderr: OSError: [Errno 3] No such process\n2024-11-24 01:25:56,207 - ERROR - Command ['/usr/bin/leapp', 'upgrade'] failed with return code 1\n2024-11-24 01:25:56,207 - ERROR - Failed: doing the conversion. The reason: Command '['/usr/bin/leapp', 'upgrade']' returned non-zero exit status 1.","author_login":"nmnsa","author_association":"NONE","created_at":"2024-11-24T01:39:38+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2496951493","fragment_type":"issue_comment","sequence":2,"text":"Hello @gokhand,\nI cannot find a specific reason for the failure of the preupgrade. Is it possible that there was a lack of available RAM, and the process was terminated by the OOM killer, for example?\nCould you please run `leapp preupgrade` manually and share the results with me? Please include the return code","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-11-25T06:14:33+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2497518097","fragment_type":"issue_comment","sequence":3,"text":"There appears to be an issue with your /etc/fstab configuration that is preventing conversion. Could you please share the file?\nI will add a pre-checker to verify the `/etc/fstab` file on our end. However, I believe we will not be able to automatically fix these types of problems (nor should we, as it might be unexpected for users).","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-11-25T10:11:03+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2497551690","fragment_type":"issue_comment","sequence":4,"text":"Automatically fix maybe not easy to do, but better to have suggestion could be helpful.\n\nHere is the fstab contents:\n\n`proc /proc proc defaults 0 0\ndevpts /dev/pts devpts gid=5,mode=620 0 0\ntmpfs /dev/shm tmpfs defaults 0 0\nsysfs /sys sysfs defaults 0 0\n/dev/md/0 none swap sw 0 0\n/dev/md/1 /boot ext3 defaults 0 0\n/dev/md/2 / ext4 defaults 0 0\n`","author_login":"gokhand","author_association":"NONE","created_at":"2024-11-25T10:23:03+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2497936441","fragment_type":"issue_comment","sequence":5,"text":"This problem is usually handled by centos2alma. Therefore, I suggest you try using centos2alma itself now to perform the conversion","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-11-25T12:50:05+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2498696370","fragment_type":"issue_comment","sequence":6,"text":"An update, I connected with KVM and it turns out the mounting process was messed up. It was in dracut emergency shell.\n\n`Warning: /dev/md/2 does not exist\nGenerating \"/run/initramfs/rdsosreport.txt\nEntering emergency mode. Exit the shell to continue.\nType \"journalctI\" to view system logs.\nYou might want to save \"/run/initramfs/rdsosreport.txt\" to a USB stick or /boot after mounting them and attach it to a bug report.\ndracut:/#`\n\nso when I check, I saw instead of md/2 - > md125 main raid (there is also md126, md127) exist on the system. I don't know centos2alma made these changes/ I temporarily mounted it and saw that everything was in there but I don't know why the md's names are changed. When I temporarily mounted I saw fstab file still md/2 . And tried to change it md125 and reboot it but at the end the issue still persists. \n\nThis is really bad situation that I am in right now, and trying to find a solution for this. If you have any idea how we can resolve it that will be awesome.","author_login":"gokhand","author_association":"NONE","created_at":"2024-11-25T18:02:55+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2499718985","fragment_type":"issue_comment","sequence":7,"text":"The issue seems to occur because the new kernel version changes the names of the RAID devices in the system.\n\nWe haven't encountered this issue previously, so I suggest manually setting the names of the RAID devices via the command line in the kernel. Alternatively, you could use the UUID of the RAID devices in the /etc/fstab file, which I believe is more reliable (as explained by Jeff Geerling, for example). Here’s how you can do it:\n1. Find out the UUID of the RAID device using the command `blkid /dev/md/125`.\n2. Replace `/dev/md/125` with the UUID in the `/etc/fstab` file.\n\nIt might also be a good idea to revert to a system snapshot taken before the conversion and modify the `/etc/fstab` before starting the conversion process.","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-11-26T05:50:05+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2505950144","fragment_type":"issue_comment","sequence":8,"text":"I can give an update, In the end, I tried a lot of different solutions but it ended up with the md 2 not found even though I changed it on /etc/fstab. Btw I changed /etc/fstab first mounting the md125 and all files there over the dracut shell. After reboot it is becoming again asking md2. I think this was the best approach because there is no /etc/fstab as you can imagine on Dracut shell status.\n\nSo, I am not a huge expert on these mounting issues and don't want to lose data from my server by accident. I have limited time for KVM and left 1 hour of access and time passing with the server down. So unfortunately I ended up deciding to add a new server preinstalled with Alma, connect my old one in rescue and move all data. It was the best, cleanest way and fastest approach in my situation.\n\nI left the old server open. Now I have 1 hour left for KVM, maybe I can try some fixes for the old one. But I don't think I can manage within 1 hour time frame.","author_login":"gokhand","author_association":"NONE","created_at":"2024-11-28T11:58:11+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2505989044","fragment_type":"issue_comment","sequence":9,"text":"I am grateful for your insights on the RAID issue.\nThe problem seems significant as there are many difficulties in fixing it. I intend to implement a pre-checker to prevent the conversion when the fstab is configured in this manner.\nIt may also be helpful to inform the developers of the Elevate tools about this issue. I will contact them as well.\nThank you again for the information","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-11-28T12:19:05+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2549152648","fragment_type":"issue_comment","sequence":10,"text":"Hey guys, I have the exact same issue like @gokhand today. Is your pre-check already deployed in `wget URL \n\nWhen you have the fucked up situation where there is no boot possible? What would you suggest to revert everything?\n\nThanks in advance!","author_login":"mamarx","author_association":"NONE","created_at":"2024-12-17T17:43:57+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2549187372","fragment_type":"issue_comment","sequence":11,"text":"Hey @mamarx,\n \n\nUnfortunately no. The pre-checker available since centos2alma-1.4.4","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-12-17T17:51:26+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2549219617","fragment_type":"issue_comment","sequence":12,"text":"I believe the best approach is to have a snapshot of your system before the conversion. However, this is not always possible.\nIf there is no snapshot, I could only suggest to fix /etc/fstab file from a recovery mode. However, @gokhand had issues changing the file before. I'm not sure if a solution was found.","author_login":"SandakovMM","author_association":"COLLABORATOR","created_at":"2024-12-17T18:05:42+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2550582334","fragment_type":"issue_comment","sequence":13,"text":"Thank you, @SandakovMM ! I was able to start from the old kernel with the help of an expert from Hetzner (my host). Now I am going to execute your 1.4.4 version","author_login":"mamarx","author_association":"NONE","created_at":"2024-12-18T07:43:47+08:00","repo_name":"plesk/centos2alma","issue_id":2686014772,"issue_number":388,"issue_url":"https://github.com/plesk/centos2alma/issues/388","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0209","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Erreur sur l'onglet service?","query_context":"Bonjour, \nSuite au passage à la version 2.101, nous avons un message d'erreur sur l'onglet service.\nEst-ce que ça vous parle ?\n\nimage\n\nInternal Server Error: /api/service/drf/services.datatables\n\nAttributeError at /api/service/drf/services.datatables\nGot AttributeError when attempting to get a value for field `name` on serializer `DatatablesSerializer`.\nThe serializer field might be named incorrectly and not match any attribute or key on the `Service` instance.\nOriginal exception text was: 'ServiceType' object has no attribute 'review'.","known_context_document_ids":["gh_issue_1937128499"],"reference_answer":"Fixed in release 2.100.0\n\nIt is now possible to filter the list by searching directly for the id of an object.","answer_document_id":"gh_comment_1706471324","silver_evidence_path":["gh_comment_1758081246","gh_issue_1632375982","gh_comment_1706471324"],"evidence_issue_ids":[1937128499,1632375982],"source_repo_name":"GeotrekCE/Geotrek-admin","source_issue_id":1937128499,"source_issue_number":3795,"source_issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","target_repo_name":"GeotrekCE/Geotrek-admin","target_issue_id":1632375982,"target_issue_number":3521,"target_issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3521","reference_anchor_document_id":"gh_comment_1758081246","reference_answer_author":"babastienne","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1163,"anchor_target_overlap":0.1944,"target_answer_overlap":0.0},"issue_created_at":"2023-10-11T08:13:26+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1937128499","fragment_type":"issue_description","sequence":0,"text":"Erreur sur l'onglet service\nBonjour, \nSuite au passage à la version 2.101, nous avons un message d'erreur sur l'onglet service.\nEst-ce que ça vous parle ?\n\nimage\n\nInternal Server Error: /api/service/drf/services.datatables\n\nAttributeError at /api/service/drf/services.datatables\nGot AttributeError when attempting to get a value for field `name` on serializer `DatatablesSerializer`.\nThe serializer field might be named incorrectly and not match any attribute or key on the `Service` instance.\nOriginal exception text was: 'ServiceType' object has no attribute 'review'.","author_login":"jeromesourdin","author_association":"NONE","created_at":"2023-10-11T08:13:26+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1758081246","fragment_type":"issue_comment","sequence":1,"text":"Bonjour,\n\nC'est assez étrange, je ne reproduit pas ce problème. \nLa 2.101.1 corrige un bug mais ce n'est pas celui-ci.\n\nIl y n'y a pas eu de modification particulière liée au services dans la 2.101. Par contre dans la 2.100 on a corrigé un bug justement lié à datatables et aux Services : URL \n\nTon erreur me fait un peu penser à ce bug, mais vu qu'il a été corrigé justement ça m'étonne.\n\nEst-ce que sur votre instance il y a un paramétrage particulier (dans le custom.py) lié aux colonnes affichées dans la vue liste ou à datatable ?","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-10-11T16:37:25+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[1632375982],"is_known_query_context":false},{"document_id":"gh_comment_1758515563","fragment_type":"issue_comment","sequence":2,"text":"Sinon ça peut justement être un problème de cache du navigateur ou du serveur ?","author_login":"camillemonchicourt","author_association":"MEMBER","created_at":"2023-10-11T20:48:33+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759042262","fragment_type":"issue_comment","sequence":3,"text":"Bonjour,\nJ'ai vidé tout les caches et ça ne résout pas le problème. Il y avait bien une config pour les colonnes dans le custom.py : \n\nCOLUMNS_LISTS['trek_view'] = ['structure', 'practice', 'length_2d']\n\nJe l'ai commenté et restart géotrek, et idem...","author_login":"jeromesourdin","author_association":"NONE","created_at":"2023-10-12T07:02:14+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759096491","fragment_type":"issue_comment","sequence":4,"text":"Après de multiple tests, j'ai réussi à résoudre le problème par la modification de la ligne URL en supprimant le 'name', et en ajoutant la ligne suivante au custom.py : \n\nCOLUMNS_LISTS[\"service_view\"] = [\"type\"]\n\nCe n'est surement pas la bonne méthode, mais je n'ai plus d'erreur. Si ça peut aider a résoudre le problème...","author_login":"jeromesourdin","author_association":"NONE","created_at":"2023-10-12T07:40:06+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759121474","fragment_type":"issue_comment","sequence":5,"text":"OK, en effet les services n'ont pas de champs NAME, mais seulement un id et un type.\nDonc peut-etre un truc à revoir car ça a en effet été modifié récemment : URL","author_login":"camillemonchicourt","author_association":"MEMBER","created_at":"2023-10-12T07:58:30+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759369153","fragment_type":"issue_comment","sequence":6,"text":"Oui en effet j'ai l'impression qu'il y a un lien avec ce commit. Mais ce qui est bizarre c'est que le problème ne survienne pas sur d'autres instances ... :thinking:","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-10-12T10:44:46+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759433224","fragment_type":"issue_comment","sequence":7,"text":"Est-ce que cela peu venir du fait d'avoir sauté plusieurs versions ?","author_login":"jeromesourdin","author_association":"NONE","created_at":"2023-10-12T11:31:39+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759435210","fragment_type":"issue_comment","sequence":8,"text":"Non. Lorsqu'on passe d'une ancienne version à une nouvelle la mise à jour repasse chaque migration de base une à une, comme si faisait chaque mise à jour l'une après l'autre, donc normalement ça n'engendre pas de problèmes.","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-10-12T11:33:11+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1764364978","fragment_type":"issue_comment","sequence":9,"text":"Ce n'est pas le champ 'name' qui pose probleme en temps que tel. Le serializer de la liste se sert de la proprieté name_display, qui affiche un lien et une icone en fonction de plusieurs attributs. le nom, le statut publié etc. dans le cas ou le service n'est pas publié, il va regarder la propriété self.type.review, Or un type de service n'a pas d'attribut review (différence entre PublishableMixin et BasePublishableMixin). Donc çà ne marche pas pour les instances ayant des services non publiés.","author_login":"submarcos","author_association":"MEMBER","created_at":"2023-10-16T12:26:10+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1765179994","fragment_type":"issue_comment","sequence":10,"text":"Oups, si je comprends bien c'est donc mon code qui a tout cassé ... :grimacing: \n\nL'idée du ticket #1669 c'était justement d'enlever cet attribut `review` qui n'avait pas de sens sur le model `servicetype`. Par contre ce que je réalise c'est que j'ai fais le travail à moitié, j'ai oublié de supprimer le code que tu as pointé dans ton commentaire @submarcos .","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-10-16T19:58:44+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766718063","fragment_type":"issue_comment","sequence":11,"text":"Bonjour, un fix est publié dans la version 2.101.2, merci d'avoir remonté le problème","author_login":"Chatewgne","author_association":"CONTRIBUTOR","created_at":"2023-10-17T16:00:41+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1937128499,"issue_number":3795,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3795","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1632375982","fragment_type":"issue_description","sequence":0,"text":"Bug : impossible de rechercher dans une liste de services\n**Démo :** \n\ngeotrek-bug-service$\n\nPiste de résolution : \n- il faut fixer cette ligne URL (Elle référence une colonne \"name\" qui n'existe pas sur ce modèle)\n- il faut changer aussi mandatory_columns","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-03-20T15:40:24+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1632375982,"issue_number":3521,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1674812046","fragment_type":"issue_comment","sequence":1,"text":"Vu qu'il n'y a pas de fonctionnalité de recherche sur ce module, est-ce qu'il serait préférable de masquer la barre de recherche ? (js + css) car sûrement pas possible via MapEntity view.","author_login":"Huquette","author_association":"CONTRIBUTOR","created_at":"2023-08-11T13:40:25+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1632375982,"issue_number":3521,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1676925987","fragment_type":"issue_comment","sequence":2,"text":"Si en effet tu as raison, on pourrait carrément cacher la barre de recherche car ça n'a pas de sens dans ce module.","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-08-14T08:43:58+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1632375982,"issue_number":3521,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3521","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1706471324","fragment_type":"issue_comment","sequence":3,"text":"Fixed in release 2.100.0\n\nIt is now possible to filter the list by searching directly for the id of an object.","author_login":"babastienne","author_association":"MEMBER","created_at":"2023-09-05T11:47:37+08:00","repo_name":"GeotrekCE/Geotrek-admin","issue_id":1632375982,"issue_number":3521,"issue_url":"https://github.com/GeotrekCE/Geotrek-admin/issues/3521","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0211","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Path with Fragment is not handled as expected?","query_context":"Consider this example spec:\n\nyaml\nopenapi: 3.1.0\ninfo:\n title: Test\n version: 0.1.0\nsecurity:\n - apiKeyAuth: []\npaths:\n /auth#basicAuth:\n post:\n operationId: basicAuth\n security:\n - basicAuth: []\n servers:\n - url: URL \n requestBody:\n content:\n application/json:\n schemas:\n type: object\n required: true\n responses:\n \"200\":\n description: OK\ncomponents:\n securitySchemes:\n basicAuth:\n type: http\n scheme: basic\n\nwiretap will return the below error when sending a request to `/auth`\n\njson\n{\"type\":\" URL to serve mocked response\",\"status\":404,\"detail\":\"Error: POST Path '/auth' not found, Reason: The POST request contains a path of '/auth' however that path, or the POST method for that path does not exist in the specification\"}\n\nUsing a fragment in the OpenAPI spec is a pretty common way of reusing a path multiple times ie `/auth#instance1` and `/auth#instance2` so for the same path & method combination a different schema can be provided instead of needing to use `oneOf` for example on the request/response bodies.","known_context_document_ids":["gh_issue_2080710689"],"reference_answer":"As mentioned in #96 \n\nAfter attempting to solve this, I was confused as to why the correct path could not be found. \n\nThe `http.Request.URL.Fragment` was always missing when making a curl request or via postman etc. I was unable to perform any kind of lookup when a fragment was used, because any request made to wiretap using a fragment was just missing the fragment each time. \n\nSo then I looked a little deeper. I found this: \n\n URL \n\nFragments are never sent in HTTP. They're purely a local browser concept.\n\nThere is no way for me determine which path is being requested when the OpenAPI specification uses a fragment as a delimiter. The fragment is never picked up by the standard library. \n\nWhich pulls into question the legitimacy of using fragments at all in OpenAPI specs. They are quite useless it seems and should not be used as delimiters for paths.\n\nMarking this as a wontfix, because there is nothing I can do to make it work.","answer_document_id":"gh_comment_2091660269","silver_evidence_path":["gh_comment_2092446450","gh_issue_2105205809","gh_comment_2091660269"],"evidence_issue_ids":[2080710689,2105205809],"source_repo_name":"pb33f/wiretap","source_issue_id":2080710689,"source_issue_number":78,"source_issue_url":"https://github.com/pb33f/wiretap/issues/78","target_repo_name":"pb33f/wiretap","target_issue_id":2105205809,"target_issue_number":88,"target_issue_url":"https://github.com/pb33f/wiretap/issues/88","reference_anchor_document_id":"gh_comment_2092446450","reference_answer_author":"daveshanley","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3077,"anchor_target_overlap":0.2308,"target_answer_overlap":0.1212},"issue_created_at":"2024-01-14T12:33:59+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2080710689","fragment_type":"issue_description","sequence":0,"text":"Path with Fragment is not handled as expected\nConsider this example spec:\n\nyaml\nopenapi: 3.1.0\ninfo:\n title: Test\n version: 0.1.0\nsecurity:\n - apiKeyAuth: []\npaths:\n /auth#basicAuth:\n post:\n operationId: basicAuth\n security:\n - basicAuth: []\n servers:\n - url: URL \n requestBody:\n content:\n application/json:\n schemas:\n type: object\n required: true\n responses:\n \"200\":\n description: OK\ncomponents:\n securitySchemes:\n basicAuth:\n type: http\n scheme: basic\n\nwiretap will return the below error when sending a request to `/auth`\n\njson\n{\"type\":\" URL to serve mocked response\",\"status\":404,\"detail\":\"Error: POST Path '/auth' not found, Reason: The POST request contains a path of '/auth' however that path, or the POST method for that path does not exist in the specification\"}\n\nUsing a fragment in the OpenAPI spec is a pretty common way of reusing a path multiple times ie `/auth#instance1` and `/auth#instance2` so for the same path & method combination a different schema can be provided instead of needing to use `oneOf` for example on the request/response bodies.","author_login":"TristanSpeakEasy","author_association":"NONE","created_at":"2024-01-14T12:33:59+08:00","repo_name":"pb33f/wiretap","issue_id":2080710689,"issue_number":78,"issue_url":"https://github.com/pb33f/wiretap/issues/78","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2091606446","fragment_type":"issue_comment","sequence":1,"text":"Supported is a strong term, after deeper investigation as a part of #96, it seems fragments cannot be supported as delimiters.","author_login":"daveshanley","author_association":"MEMBER","created_at":"2024-05-02T21:08:15+08:00","repo_name":"pb33f/wiretap","issue_id":2080710689,"issue_number":78,"issue_url":"https://github.com/pb33f/wiretap/issues/78","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2092446450","fragment_type":"issue_comment","sequence":2,"text":"As mentioned in this comment it could be technically possible to handle ie treat it as deserializing a oneOf of the two request bodies as an example URL","author_login":"TristanSpeakEasy","author_association":"NONE","created_at":"2024-05-03T07:18:17+08:00","repo_name":"pb33f/wiretap","issue_id":2080710689,"issue_number":78,"issue_url":"https://github.com/pb33f/wiretap/issues/78","linked_issue_ids":[2105205809],"is_known_query_context":false},{"document_id":"gh_comment_2093021834","fragment_type":"issue_comment","sequence":3,"text":"I would be willing to make the fragment work as a delimiter, if it wasn't just a browser concept (I never really gave it much thought to be honest). However because it is just a browser concept and isn't actually part of HTTP or even OpenAPI in any meaningful way, I think I am going to keep this as a wontfix for now, \n\nHappy to accept a contribution however.","author_login":"daveshanley","author_association":"MEMBER","created_at":"2024-05-03T13:27:34+08:00","repo_name":"pb33f/wiretap","issue_id":2080710689,"issue_number":78,"issue_url":"https://github.com/pb33f/wiretap/issues/78","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2105205809","fragment_type":"issue_description","sequence":0,"text":"wiretap fails to authenticate a operation that uses the same route but unique via a fragment\nThis is related to this new change I believe: URL \n\nFor this spec:\n\nyaml\nopenapi: 3.1.0\ninfo:\n title: Test\n version: 0.1.0\nsecurity:\n - apiKeyAuth: []\n - apiKeyAuthNew: []\n - oauth2: []\n - {}\npaths:\n /auth#basicAuth:\n post:\n operationId: basicAuthNew\n security:\n - basicAuth: []\n servers:\n - url: URL \n requestBody:\n content:\n application/json:\n schema:\n $ref: \"#/components/schemas/authServiceRequestBody\"\n required: true\n responses:\n \"200\":\n description: OK\n \"401\":\n description: Unsuccessful authentication.\n /auth#apiKeyAuthGlobal:\n post:\n operationId: apiKeyAuthGlobalNew\n servers:\n - url: URL \n requestBody:\n content:\n application/json:\n schema:\n $ref: \"#/components/schemas/authServiceRequestBody\"\n required: true\n responses:\n \"200\":\n description: OK\n \"401\":\n description: Unsuccessful authentication.\ncomponents:\n securitySchemes:\n basicAuth:\n type: http\n scheme: basic\n x-speakeasy-example: YOUR_USERNAME;YOUR_PASSWORD\n apiKeyAuth:\n type: apiKey\n in: header\n name: Authorization\n description: Authenticate using an API Key generated via our platform.\n x-speakeasy-example: Token YOUR_API_KEY\n bearerAuth:\n type: http\n scheme: bearer\n x-speakeasy-example: YOUR_JWT\n apiKeyAuthNew:\n type: apiKey\n in: header\n name: x-api-key\n x-speakeasy-example: Token \n oauth2:\n type: oauth2\n flows:\n implicit:\n authorizationUrl: URL \n scopes: {}\n x-speakeasy-example: Bearer YOUR_OAUTH2_TOKEN\n openIdConnect:\n type: openIdConnect\n openIdConnectUrl: URL \n x-speakeasy-example: Bearer YOUR_OPENID_TOKEN\n schemas:\n authServiceRequestBody:\n type: object\n properties:\n headerAuth:\n type: array\n items:\n type: object\n properties:\n headerName:\n type: string\n expectedValue:\n type: string\n required:\n - headerName\n - expectedValue\n basicAuth:\n type: object\n properties:\n username:\n type: string\n password:\n type: string\n required:\n - username\n - password\n\nTrying to do a request against the operation `apiKeyAuthGlobalNew` fails with the below error:\n\njson\n{\"type\":\" URL to serve mocked response\",\"status\":401,\"detail\":\"basic authentication failed: bearer token not found, no `Authorization` header found in request\"}\n\nIt looks to not be matching the right route and expecting the basic auth of the `basicAuthNew` operation","author_login":"TristanSpeakEasy","author_association":"NONE","created_at":"2024-01-29T10:49:53+08:00","repo_name":"pb33f/wiretap","issue_id":2105205809,"issue_number":88,"issue_url":"https://github.com/pb33f/wiretap/issues/88","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091660269","fragment_type":"issue_comment","sequence":1,"text":"As mentioned in #96 \n\nAfter attempting to solve this, I was confused as to why the correct path could not be found. \n\nThe `http.Request.URL.Fragment` was always missing when making a curl request or via postman etc. I was unable to perform any kind of lookup when a fragment was used, because any request made to wiretap using a fragment was just missing the fragment each time. \n\nSo then I looked a little deeper. I found this: \n\n URL \n\nFragments are never sent in HTTP. They're purely a local browser concept.\n\nThere is no way for me determine which path is being requested when the OpenAPI specification uses a fragment as a delimiter. The fragment is never picked up by the standard library. \n\nWhich pulls into question the legitimacy of using fragments at all in OpenAPI specs. They are quite useless it seems and should not be used as delimiters for paths.\n\nMarking this as a wontfix, because there is nothing I can do to make it work.","author_login":"daveshanley","author_association":"MEMBER","created_at":"2024-05-02T21:17:21+08:00","repo_name":"pb33f/wiretap","issue_id":2105205809,"issue_number":88,"issue_url":"https://github.com/pb33f/wiretap/issues/88","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2092441446","fragment_type":"issue_comment","sequence":2,"text":"@daveshanley a strategy we are seeing people using to deal with this is it effectively becomes a join of the two operations, on their servers the two routes or directed to the same handler but they are determining the operation based on the inputs, so it is effectively a `oneOf` between the request bodies/response bodies etc.\n\nTotally understand if you want to keep this as wontfix, we can find some other way to deal with this but it is theoretically possible","author_login":"TristanSpeakEasy","author_association":"NONE","created_at":"2024-05-03T07:14:26+08:00","repo_name":"pb33f/wiretap","issue_id":2105205809,"issue_number":88,"issue_url":"https://github.com/pb33f/wiretap/issues/88","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2093018433","fragment_type":"issue_comment","sequence":3,"text":"I think this strategy is a little bit odd to be honest, it means parsing the body to determine the schema, in order to figure out which fragment to use - which to me feels like a considerable hack. It feels like it's going against the spirit of the standard, in order to make it work.","author_login":"daveshanley","author_association":"MEMBER","created_at":"2024-05-03T13:25:46+08:00","repo_name":"pb33f/wiretap","issue_id":2105205809,"issue_number":88,"issue_url":"https://github.com/pb33f/wiretap/issues/88","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2093029874","fragment_type":"issue_comment","sequence":4,"text":"So technically yes it does look like the OpenAPI initiative has decided to not make this official URL but in the wild it is getting used to differentiate APIs that share a path but can accept different request bodies, we have come across a few cases of this and various tooling does seem to support it (including ours)","author_login":"TristanSpeakEasy","author_association":"NONE","created_at":"2024-05-03T13:31:45+08:00","repo_name":"pb33f/wiretap","issue_id":2105205809,"issue_number":88,"issue_url":"https://github.com/pb33f/wiretap/issues/88","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0212","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Update eth-json-rpc-middleware from 6.0.0 to latest version?","query_context":"Currently this repo uses an outdated version of the `eth-json-rpc-middleware` library as a dependency. This throws warnings regarding outdated dependencies and specifically causes an issue on Webpack 5 due to the middleware dependency's usage of the `safe-event-emitter` (requiring a node resolution of `util`) instead of the newer `@metamask/safe-event-emitter`.","known_context_document_ids":["gh_issue_1219350538"],"reference_answer":"Hi there,\nwe are very open to do a quick bugfix release on our side if this helps, even if this package is deprecated, I just haven't identified if we can do something on our side.\n\nIf you follow-up the dependency path and find the right place where to post the issue \"on the other side\" feel free to mention me, then we can coordinate on how to fix this and see if we can also do something from the EthereumJS side of things.","answer_document_id":"gh_comment_1269723438","silver_evidence_path":["gh_comment_1306483055","gh_issue_356043524","gh_comment_1269723438"],"evidence_issue_ids":[1219350538,356043524],"source_repo_name":"MetaMask/eth-json-rpc-filters","source_issue_id":1219350538,"source_issue_number":60,"source_issue_url":"https://github.com/MetaMask/eth-json-rpc-filters/issues/60","target_repo_name":"ethereumjs/ethereumjs-abi","target_issue_id":356043524,"target_issue_number":67,"target_issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","reference_anchor_document_id":"gh_comment_1306483055","reference_answer_author":"holgerd77","reference_answer_author_association":"MEMBER","quality_score":84.61,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2667,"anchor_target_overlap":0.2121,"target_answer_overlap":0.0323},"issue_created_at":"2022-04-28T21:56:09+08:00","valid_comment_count":43,"fragments":[{"document_id":"gh_issue_1219350538","fragment_type":"issue_description","sequence":0,"text":"Update eth-json-rpc-middleware from 6.0.0 to latest version\nCurrently this repo uses an outdated version of the `eth-json-rpc-middleware` library as a dependency. This throws warnings regarding outdated dependencies and specifically causes an issue on Webpack 5 due to the middleware dependency's usage of the `safe-event-emitter` (requiring a node resolution of `util`) instead of the newer `@metamask/safe-event-emitter`.","author_login":"jeongmincho","author_association":"NONE","created_at":"2022-04-28T21:56:09+08:00","repo_name":"MetaMask/eth-json-rpc-filters","issue_id":1219350538,"issue_number":60,"issue_url":"https://github.com/MetaMask/eth-json-rpc-filters/issues/60","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1306483055","fragment_type":"issue_comment","sequence":1,"text":"Just to second this. This outdated versin of `eth-json-rpc-middleware` depends on a very archaic version of a deprecated `ethereumjs` library (`ethereumjs-abi`) and references a github repo instead of an npm tarball that causes issues in a number of upstream consumers of `eth-json-rpc-middleware` as referenced by this thread. Would you accept a PR to bump this dependency (would likely require a breaking change).","author_login":"acolytec3","author_association":"NONE","created_at":"2022-11-08T01:29:42+08:00","repo_name":"MetaMask/eth-json-rpc-filters","issue_id":1219350538,"issue_number":60,"issue_url":"https://github.com/MetaMask/eth-json-rpc-filters/issues/60","linked_issue_ids":[356043524],"is_known_query_context":false},{"document_id":"gh_comment_1307679954","fragment_type":"issue_comment","sequence":2,"text":"Thanks for raising this issue. We're aware that this package uses some outdated dependencies. The main consumer of this package within our ecosystem is the codebase for our mobile app, which in general is a bit behind in terms of our JSON-RPC stack as compared with our extension codebase. What this means is that even if we upgrade this package, we would not be able to effectively test the upgrade in our stack (as it would introduce some breaking changes). We are working on upgrading the mobile app so that we can bring this package up to date, but in the meantime you may have better luck forking this repo, doing the upgrades yourself, and republishing this under your own scope. Sorry about that.","author_login":"mcmire","author_association":"CONTRIBUTOR","created_at":"2022-11-08T18:51:04+08:00","repo_name":"MetaMask/eth-json-rpc-filters","issue_id":1219350538,"issue_number":60,"issue_url":"https://github.com/MetaMask/eth-json-rpc-filters/issues/60","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307802360","fragment_type":"issue_comment","sequence":3,"text":"I understand the suggestion but unfortunately that likely won't solve the issues referenced in the thread I linked since the root issue is a reference to a library we don't maintain anymore. For better or worse, there are several consumers of this library outside of the Metamask namespace (e.g. `@coinbase/wallet-sdk`) and in some cases (that I haven't been able to reproduce), their install process breaks because of the outdated dependency tree here so not sure there's anything we can do about it. I guess for now we'll just keep encouraging teams who land here to use the `resolutions` property in package.json to point to a non-broken version of `ethereumjs-abi`.","author_login":"acolytec3","author_association":"NONE","created_at":"2022-11-08T20:43:20+08:00","repo_name":"MetaMask/eth-json-rpc-filters","issue_id":1219350538,"issue_number":60,"issue_url":"https://github.com/MetaMask/eth-json-rpc-filters/issues/60","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906940627","fragment_type":"issue_comment","sequence":4,"text":"Update: `eth-json-rpc-middleware` (now `@metamask/eth-json-rpc-middleware`) was upgraded to v9 in version 5.1.0, and the latest version (7.0.0) uses v12. `ethereumjs-abi` should no longer be in the dependency tree.","author_login":"mcmire","author_association":"CONTRIBUTOR","created_at":"2024-01-23T21:23:37+08:00","repo_name":"MetaMask/eth-json-rpc-filters","issue_id":1219350538,"issue_number":60,"issue_url":"https://github.com/MetaMask/eth-json-rpc-filters/issues/60","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_356043524","fragment_type":"issue_description","sequence":0,"text":"Error can not install\nHi, \n\nI am trying to install ethereumjs-abi but always got this issues:\nnpm ERR! code 1\nnpm ERR! Command failed: /usr/local/bin/git clone -q URL /Users/trnhgquan/.npm/_cacache/tmp/git-clone-e6ae2501\nnpm ERR! /Users/trnhgquan/.npm/_cacache/tmp/git-clone-e6ae2501/.git: Permission denied\nnpm ERR! \n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR! /Users/trnhgquan/.npm/_logs/2018-08-31T16_15_05_558Z-debug.log\n\nDoes anyone here can help me to fix?\n\nThanks.","author_login":"zeroXBami","author_association":"NONE","created_at":"2018-08-31T16:17:36+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423507071","fragment_type":"issue_comment","sequence":1,"text":"You doesn't seem to have the proper rights to write in your given directory. This is nevertheless no abi library related issue, will close.","author_login":"holgerd77","author_association":"MEMBER","created_at":"2018-09-21T11:57:46+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_681944008","fragment_type":"issue_comment","sequence":2,"text":"I faced the same problem and apparently there is a file that needs to be downloaded from git in \"git ssh mode\" not via https. Adding my github identity with ssh-add solved my issue. I don't think the pubkey is actually checked, it just needs to be non null.","author_login":"bloodybit","author_association":"NONE","created_at":"2020-08-27T13:19:13+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_808402339","fragment_type":"issue_comment","sequence":3,"text":"I am getting this Permission denied error on cypress github action while installing dependencies with the `npm ci` command\n\nThis is where the error occurs\n`/usr/bin/git ls-remote -h -t ssh://git@github.com/ethereumjs/ethereumjs-abi.git`\n\nThis error makes the project untestable on github action. Any idea to how solve?\n\nHere is the full log:\n\n/usr/local/bin/npm ci\nnpm ERR! Error while executing:\nnpm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/ethereumjs/ethereumjs-abi.git\nnpm ERR! \nnpm ERR! Warning: Permanently added the RSA host key for IP address '140.82.113.3' to the list of known hosts.\nnpm ERR! git@github.com: Permission denied (publickey).\nnpm ERR! fatal: Could not read from remote repository.\nnpm ERR! \nnpm ERR! Please make sure you have the correct access rights\nnpm ERR! and the repository exists.\nnpm ERR! \nnpm ERR! exited with error code: 128\n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR! /home/runner/.npm/_logs/2021-03-26T17_17_00_879Z-debug.log\nError: The process '/usr/local/bin/npm' failed with exit code 1","author_login":"Resoguy","author_association":"NONE","created_at":"2021-03-26T17:39:32+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_879698021","fragment_type":"issue_comment","sequence":4,"text":"I am getting the same error on Mac and Ubuntu. Have you solved this issue @Resoguy","author_login":"Andrea-Dispe","author_association":"NONE","created_at":"2021-07-14T08:22:52+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_880312590","fragment_type":"issue_comment","sequence":5,"text":"Thank you but I was able to solve this by updating npm to the latest version.","author_login":"Andrea-Dispe","author_association":"NONE","created_at":"2021-07-15T01:11:33+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[356043524],"is_known_query_context":false},{"document_id":"gh_comment_883925806","fragment_type":"issue_comment","sequence":6,"text":"I've noticed this occasionally happen when adding a new package with yarn. It will revert from the working:\n \n` \"resolved\": \" URL \n\nto the non-working:\n\n`\"resolved\": \"git+ssh://git@github.com/ethereumjs/ethereumjs-abi.git#ee3994657fa7a427238e6ba92a84d0b529bbcde0\"`\n\nManually switching back fixes this headache for me.","author_login":"RadioJulius","author_association":"NONE","created_at":"2021-07-21T06:23:40+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_981452202","fragment_type":"issue_comment","sequence":7,"text":"@Valentin-Seehausen hi there, I did a test clone + `npm i` on URL - assuming that that's the repository from where your issue originated - but I couldn't even find the dependency, `npm ls ethereumjs-abi` is giving me nothing.\n\nCan you give a short context description where the `ethereumjs-abi` dependency is actually coming from in your context?","author_login":"holgerd77","author_association":"MEMBER","created_at":"2021-11-29T09:34:01+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_981455307","fragment_type":"issue_comment","sequence":8,"text":"And for everyone reading along here: while we have deprecated this package if there is something with reasonable effort we can do here from our side we can very well do a bugfix release here.\n\nIt's generally helpful if you provide more context on where are you getting your errors. What Node version are you using? Are you using the `ethereumjs-abi` dependency directly or is it installed via another dependency? Optimally provide some reproduceable code example (or eventually some CLI command lineup in this context).\n\nThanks!\n\nWill reopen this issue for now until this is settled in some way.","author_login":"holgerd77","author_association":"MEMBER","created_at":"2021-11-29T09:38:16+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_981645453","fragment_type":"issue_comment","sequence":9,"text":"We also encountered this issue last week, it was a deprecated dependency from WalletConnect. \nThis was still the 1.0 version of WalletConnect.\nWe dropped support for WalletConnect for now.","author_login":"djmbritt","author_association":"NONE","created_at":"2021-11-29T13:42:10+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_982039111","fragment_type":"issue_comment","sequence":10,"text":"Yes, it originated from the WalletConnect library. I solved the issue by deleting my yarn.lock and reinstall.\nSorry that I cannot help to reproduce it. Super service, thanks a lot!","author_login":"Valentin-Seehausen","author_association":"NONE","created_at":"2021-11-29T21:28:02+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016447130","fragment_type":"issue_comment","sequence":11,"text":"@holgerd77\n- it is happened for me on Node v14.17.3\n- Installed via another dependency\n- Using `npm`\n\nimage\n\n└─┬ @amfi/connect-wallet@1.1.21\n └─┬ @walletconnect/web3-provider@1.7.1\n └─┬ web3-provider-engine@16.0.1\n └─┬ eth-sig-util@1.4.2\n └── ethereumjs-abi@0.6.8 (git+ssh://git@github.com/ethereumjs/ethereumjs-abi.git#ee3994657fa7a427238e6ba92a84d0b529bbcde0)\n\nI have just created new app on `heroku`, then made a setup via `github repository` to deploy, and then it showed me these logs\n \n Spoiler warning \n \n\n-----> Building on the Heroku-20 stack\n-----> Using buildpack: mars/create-react-app\n-----> React.js (create-react-app) multi app detected\n=====> Downloading Buildpack: URL \n=====> Detected Framework: Multipack\n=====> Downloading Buildpack: URL \n=====> Detected Framework: Node.js\n \n-----> Creating runtime environment\n \n NPM_CONFIG_LOGLEVEL=error\n NODE_VERBOSE=false\n NODE_ENV=production\n NODE_MODULES_CACHE=true\n \n-----> Installing binaries\n engines.node (package.json): unspecified\n engines.npm (package.json): unspecified (use default)\n \n Resolving node version 14.x...\n Downloading and installing node 14.18.3...\n Using default npm version: 6.14.15\n \n-----> Restoring cache\n - node_modules\n \n-----> Installing dependencies\n Installing node modules\n npm ERR! Error while executing:\n npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/ethereumjs/ethereumjs-abi.git\n npm ERR! \n npm ERR! Host key verification failed.\n npm ERR! fatal: Could not read from remote repository.\n npm ERR! \n npm ERR! Please make sure you have the correct access rights\n npm ERR! and the repository exists.\n npm ERR! \n npm ERR! exited with error code: 128\n \n npm ERR! A complete log of this run can be found in:\n npm ERR! /tmp/npmcache.3QAnL/_logs/2022-01-19T07_02_45_160Z-debug.log\n-----> Build failed\n \n We're sorry this build is failing! You can troubleshoot common issues here:\n URL \n \n Some possible problems:\n \n - Node version not specified in package.json\n URL \n \n Love,\n Heroku\n \n ! Push rejected, failed to compile React.js (create-react-app) multi app.\n ! Push failed\n \n\n \n \n \n No matter what it says, there is no problem with `buildpack`, it's just something that is here `git ls-remote -h -t ssh://git@github.com/ethereumjs/ethereumjs-abi.git`\n \n Anyway, you can try this command locally and it will show you this error.\n\nBut, if I run my project locally, everything is working (this could be the GitHub policy about SSH, dunno)\n\n#### // SOLVED: using `yarn` instead of `npm` will give you the pleasure","author_login":"Kamikozz","author_association":"NONE","created_at":"2022-01-19T13:05:57+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1071646951","fragment_type":"issue_comment","sequence":12,"text":"In my case, the problem comes from the `@web3-onboard/walletlink` package.","author_login":"nbeuchat","author_association":"NONE","created_at":"2022-03-17T22:24:08+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1077023364","fragment_type":"issue_comment","sequence":13,"text":"I had this issue as well, using when using @walletconnect/web3-provider and using npm as the package manager. \n\nI deleted package-lock.json and node_modules and used yarn to install the modules. Verified that the resolve url for the dependency ethereumjs-abi begins with ` URL instead of `git+ssh://` and everything works now","author_login":"ayudh37","author_association":"NONE","created_at":"2022-03-24T03:12:03+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1102903197","fragment_type":"issue_comment","sequence":14,"text":"For anybody struggling with this issue using pnpm, I fixed by adding an override to my root package.json:\n\n \n\"pnpm\": {\n \"overrides\": {\n \"ethereumjs-abi\": \" URL \n }\n }\n \n\nReference: URL","author_login":"mdarche","author_association":"NONE","created_at":"2022-04-19T17:24:30+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120791245","fragment_type":"issue_comment","sequence":15,"text":"I was having this issue specifically when installing and deploying within an AWS Amplify build pipeline. Of the suggested fixes, moving from `npm` to `yarn` was the only thing that solved it for me.","author_login":"georgeperry1","author_association":"NONE","created_at":"2022-05-09T08:18:57+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1129077521","fragment_type":"issue_comment","sequence":16,"text":"Yes I'm having this issue now trying to deploy my project on vercel. how do you solve the issue when deploying to vercel?","author_login":"akorede12","author_association":"NONE","created_at":"2022-05-17T16:29:03+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1154147277","fragment_type":"issue_comment","sequence":17,"text":"I'm using vercel cicd to deploy my project, has the same problem.\nremove `package.lock` & `yarn.lock`, and `yarn install` reinstall again, that's work for me!","author_login":"Hazelwu2","author_association":"NONE","created_at":"2022-06-13T16:41:45+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1172874612","fragment_type":"issue_comment","sequence":18,"text":"I am facing this issue while trying to build my app on Netlify. URL \n\nIn my packagelock.json I see the following:\n\n\"node_modules/ethereumjs-abi\": {\n \"version\": \"0.6.8\",\n \"resolved\": \"git+ssh://git@github.com/ethereumjs/ethereumjs-abi.git#ee3994657fa7a427238e6ba92a84d0b529bbcde0\",\n \"license\": \"MIT\",\n \"dependencies\": {\n \"bn.js\": \"^4.11.8\",\n \"ethereumjs-util\": \"^6.0.0\"\n }","author_login":"zubin-madon","author_association":"NONE","created_at":"2022-07-02T10:19:23+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1179864019","fragment_type":"issue_comment","sequence":19,"text":"I faced this issue while using yarn to get the dependences, I disabled SSL Verification by running:\n_git config --global http.sslVerify \"false\"_\nand it worked!\nErro (2)","author_login":"WanderKey","author_association":"NONE","created_at":"2022-07-11T01:34:57+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1201411574","fragment_type":"issue_comment","sequence":20,"text":"For yarn users, add this to the root of `package.json`:\n\njson\n \"resolutions\": {\n \"ethereumjs-abi\": \" URL \n }","author_login":"illepic","author_association":"NONE","created_at":"2022-08-01T16:13:18+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250061389","fragment_type":"issue_comment","sequence":21,"text":"Had the issue using vercel.\n\nRemoved `yarn.lock`, `package-lock.json` and used yarn. Dependencies fetching is now working.","author_login":"0xnogo","author_association":"NONE","created_at":"2022-09-17T12:18:22+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257872854","fragment_type":"issue_comment","sequence":22,"text":"if someone is using yarn monorepo I suggest adding it to the main package.json file","author_login":"sztadii","author_association":"NONE","created_at":"2022-09-26T11:14:45+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257874423","fragment_type":"issue_comment","sequence":23,"text":"If someone is using yarn workspaces I suggest adding it to the main package.json file. The children package.json files did not work for me.","author_login":"sztadii","author_association":"NONE","created_at":"2022-09-26T11:16:10+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1268332204","fragment_type":"issue_comment","sequence":24,"text":"same issue from wallet connect modules on my github actions.","author_login":"hiwa-kazu","author_association":"NONE","created_at":"2022-10-05T11:50:23+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1269360544","fragment_type":"issue_comment","sequence":25,"text":"did anyone figure out how to fix this when you're on a vercel env, where you can't easily add an .ssh key?\nmy dependency is coming from wagmi.sh \n\nwhich i have updated to the latest:\n\n$ yarn why ethereumjs-abi\nyarn why v1.22.19\n[1/4] 🤔 Why do we have the module \"ethereumjs-abi\"...?\n[2/4] 🚚 Initialising dependency graph...\n[3/4] 🔍 Finding dependency...\n[4/4] 🚡 Calculating file sizes...\n=> Found \"ethereumjs-abi@0.6.8\"\ninfo Reasons this module exists\n - \"wagmi#@coinbase#wallet-sdk#eth-json-rpc-filters#eth-json-rpc-middleware#eth-sig-util\" depends on it\n - Hoisted from \"wagmi#@coinbase#wallet-sdk#eth-json-rpc-filters#eth-json-rpc-middleware#eth-sig-util#ethereumjs-abi\"\ninfo Disk size without dependencies: \"456KB\"\ninfo Disk size with unique dependencies: \"780KB\"\ninfo Disk size with transitive dependencies: \"13.48MB\"\ninfo Number of shared dependencies: 19\n✨ Done in 0.22s.","author_login":"dcsan","author_association":"NONE","created_at":"2022-10-06T05:50:17+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1269394883","fragment_type":"issue_comment","sequence":26,"text":"ok so the solution of deleting the git+ssh entry and manually hacking the yarn.lock and reinstalling seems to work.\nbut how fragile is this? \nwhat are the cases that will cause the yarn.lock to be completely rebuilt?","author_login":"dcsan","author_association":"NONE","created_at":"2022-10-06T06:19:41+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1269398277","fragment_type":"issue_comment","sequence":27,"text":"also, what can we recommend upstream packages to do that depend on this? even tho this package is deprecated as of a year ago, it seems very recent other modules still depend on it.\n\nmy deps path:\n\n - \"wagmi#@coinbase#wallet-sdk#eth-json-rpc-filters#eth-json-rpc-middleware#eth-sig-util\" depends on it\n\nthis issue says in fact that `coinbase/wallet` is the RIGHT thing to use...\n\n URL","author_login":"dcsan","author_association":"NONE","created_at":"2022-10-06T06:22:27+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[356043524],"is_known_query_context":false},{"document_id":"gh_comment_1269723438","fragment_type":"issue_comment","sequence":28,"text":"Hi there,\nwe are very open to do a quick bugfix release on our side if this helps, even if this package is deprecated, I just haven't identified if we can do something on our side.\n\nIf you follow-up the dependency path and find the right place where to post the issue \"on the other side\" feel free to mention me, then we can coordinate on how to fix this and see if we can also do something from the EthereumJS side of things.","author_login":"holgerd77","author_association":"MEMBER","created_at":"2022-10-06T09:57:58+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1270513902","fragment_type":"issue_comment","sequence":29,"text":"thanks @holgerd77 someone tracked the deps tree here for wagmi.\nnot sure how you could fix it at this end - can you replace the module/version and replace the git with https?\n\n URL","author_login":"dcsan","author_association":"NONE","created_at":"2022-10-06T18:30:54+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1285327818","fragment_type":"issue_comment","sequence":30,"text":"What I've done to fix this on local and CI:\nReplace in **package-lock.json**:\n`\"ethereumjs-abi\": \"git+ URL \nWith:\n`\"ethereumjs-abi\": \"^0.6.8\"`\n\nReplace in **package-lock.json**:\n`\"resolved\": \"git+ URL \nWith: \n`\"resolved\": \" URL \n\n`\"ethereumjs-abi\": {\n \"version\": \"git+ URL \n \"from\": \"ethereumjs-abi@git+ URL \nWith: \n`\"ethereumjs-abi\": {\n \"version\": \"0.6.8\",\n \"resolved\": \" URL","author_login":"masterbd","author_association":"NONE","created_at":"2022-10-20T10:55:08+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1292934179","fragment_type":"issue_comment","sequence":31,"text":"Is there a non-fragile/definitive solution to this using npm?","author_login":"arshamg","author_association":"NONE","created_at":"2022-10-27T03:48:32+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1298534530","fragment_type":"issue_comment","sequence":32,"text":"Yes @arshamg. Delete your `package-lock.json` and `yarn.lock` files then simply add the below to your `package.json`. This will work regardless of npm/yarn.\n\n \"resolutions\": {\n \"ethereumjs-abi\": \" URL \n },","author_login":"eth0izzle","author_association":"NONE","created_at":"2022-11-01T13:45:42+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1304795331","fragment_type":"issue_comment","sequence":33,"text":"Why this damn problem hasn't been solved and it's holding the crypto industry back","author_login":"lazy1523","author_association":"NONE","created_at":"2022-11-06T12:54:11+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306277815","fragment_type":"issue_comment","sequence":34,"text":"Can someone on this thread who's encountered the issue provide an example repo where this issue occurs so I can reproduce locally? I've looked at the various dependencies in the stack that reference the old version of `ethereumjs-abi` that seems to be causing the issue and I'm not able to reproduce it. If I can indeed validate the issue (and which setup is causing it to break), I can try and work with whichever dependent module is causing things to break to update their deps. If I had to guess, I'd say it's most likely the `eth-json-rpc-filters` module since its most current version references older other libraries that in turn lead down to that git referenced version of `ethereumjs-abi`.","author_login":"acolytec3","author_association":"NONE","created_at":"2022-11-07T22:01:56+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1327072710","fragment_type":"issue_comment","sequence":35,"text":"Had the same issue, switching to yarn did the trick.\n\n1 - Install yarn : npm install -g yarn\n2 - Delete package lock file from root of project.\n3 - Run yarn in root of project.","author_login":"LintonAchmad","author_association":"NONE","created_at":"2022-11-25T06:33:01+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1347779524","fragment_type":"issue_comment","sequence":36,"text":"I try it by aboved answers and can not solve it , it cost about me 1.5days. I use next , it worked, share the website to help others.\nnpm i @truffle/hdwallet-provider@next\n URL","author_login":"algmir","author_association":"NONE","created_at":"2022-12-13T05:45:39+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1351335599","fragment_type":"issue_comment","sequence":37,"text":"I upgraded pnpm from 6.9 to 7.18 and then the bug was resolved","author_login":"Soecka","author_association":"NONE","created_at":"2022-12-14T13:15:20+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1784207063","fragment_type":"issue_comment","sequence":38,"text":"I have this same problem when I was trying to build my project via AWS Ampify. It is serverless so I guess there's no way for me to add my ssh key there. (The repo I used is a private repo of mine, though.) Does anyone have the solution for a serverless service like that?","author_login":"terryjiang2020","author_association":"NONE","created_at":"2023-10-29T19:42:55+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1829718861","fragment_type":"issue_comment","sequence":39,"text":"I had this problem when I logged to the server via SSH.\nI forgot to forward my agent via `-A` flag.\n\n`ssh -A $user:$host` \nI leave it here, probably for myself in the future and maybe for the others that encounter this issue","author_login":"blazejkrzak","author_association":"NONE","created_at":"2023-11-28T12:11:41+08:00","repo_name":"ethereumjs/ethereumjs-abi","issue_id":356043524,"issue_number":67,"issue_url":"https://github.com/ethereumjs/ethereumjs-abi/issues/67","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0213","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Undelete account?","query_context":"Hey,\n\nI was experimenting with a hachyderm account as I wasn’t sure whether to move my mastodon.social account to it. As I wasn’t sure I ended up deleting my account. \n\nI’ve since seen a lot of similar minded folk move over and so have decided I’d like to do the same, but am I able to reinstate the deleted account?\n\nI didn’t make any posts so it’s just bringing back the account/username I’m trying to do. Is this possible?\n\nThe username was @mattbrailsford","known_context_document_ids":["gh_issue_1457535685"],"reference_answer":"I don't understand if the account was deleted or suspended? Does the account still show up in the admin interface?\nNote that suspending an account also bans their email address.\n \n \n \n \n \n \n \n \n \n \n \n \n \n\nIt seems you're using a *different* username than that of the account which is to be re-used. If you want to re-use the email address but with a different name, you can delete the old account with `tootctl accounts delete USERNAME`.","answer_document_id":"gh_comment_903292147","silver_evidence_path":["gh_comment_1328178834","gh_issue_973319670","gh_comment_903292147"],"evidence_issue_ids":[1457535685,973319670],"source_repo_name":"hachyderm/community","source_issue_id":1457535685,"source_issue_number":76,"source_issue_url":"https://github.com/hachyderm/community/issues/76","target_repo_name":"mastodon/mastodon","target_issue_id":973319670,"target_issue_number":16626,"target_issue_url":"https://github.com/mastodon/mastodon/issues/16626","reference_anchor_document_id":"gh_comment_1328178834","reference_answer_author":"ClearlyClaire","reference_answer_author_association":"COLLABORATOR","quality_score":95.22,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1053,"anchor_target_overlap":0.0889,"target_answer_overlap":0.1538},"issue_created_at":"2022-11-21T08:38:22+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1457535685","fragment_type":"issue_description","sequence":0,"text":"Undelete account\nHey,\n\nI was experimenting with a hachyderm account as I wasn’t sure whether to move my mastodon.social account to it. As I wasn’t sure I ended up deleting my account. \n\nI’ve since seen a lot of similar minded folk move over and so have decided I’d like to do the same, but am I able to reinstate the deleted account?\n\nI didn’t make any posts so it’s just bringing back the account/username I’m trying to do. Is this possible?\n\nThe username was @mattbrailsford","author_login":"mattbrailsford","author_association":"NONE","created_at":"2022-11-21T08:38:22+08:00","repo_name":"hachyderm/community","issue_id":1457535685,"issue_number":76,"issue_url":"https://github.com/hachyderm/community/issues/76","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1324242815","fragment_type":"issue_comment","sequence":1,"text":"Anyone know if this is possible. From what I read it says deletion is permanent, but I’ve also seen user initiated deletions appear as suspensions to the admin.","author_login":"mattbrailsford","author_association":"NONE","created_at":"2022-11-22T21:11:40+08:00","repo_name":"hachyderm/community","issue_id":1457535685,"issue_number":76,"issue_url":"https://github.com/hachyderm/community/issues/76","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328178834","fragment_type":"issue_comment","sequence":2,"text":"👋 Hello! We actually were investigating this for another user with a similar issue. It looks like deleted accounts cannot be reactivated, not exactly. The issues that it causes with federation results in a \"zombie\" like state as other Mastodon servers will have stored the information that this account is deleted. \n\nThere is information about it on the mastodon/mastodon repo here:\n\n URL \n\nWe know this isn't ideal and have also submitted an issue to their tracker to see if there's anything in the 4.x releases that would allow us to do this. (We haven't had success thus far.)\n\nI know this isn't an ideal answer :(","author_login":"quintessence","author_association":"CONTRIBUTOR","created_at":"2022-11-27T06:07:15+08:00","repo_name":"hachyderm/community","issue_id":1457535685,"issue_number":76,"issue_url":"https://github.com/hachyderm/community/issues/76","linked_issue_ids":[973319670],"is_known_query_context":false},{"document_id":"gh_comment_1328196723","fragment_type":"issue_comment","sequence":3,"text":"Thanks @quintessence \n\nI thought this might be the case but I was reading mixed information so I really appreciated you clarifying. \n\nI’ll hold tight for a little while and keep track of the other issue to see if it’s something that can be resolved in a future update, otherwise I’ll go with a different username 👍🏻\n\nthanks again for your insight","author_login":"mattbrailsford","author_association":"NONE","created_at":"2022-11-27T08:37:39+08:00","repo_name":"hachyderm/community","issue_id":1457535685,"issue_number":76,"issue_url":"https://github.com/hachyderm/community/issues/76","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328219598","fragment_type":"issue_comment","sequence":4,"text":"i'm going to close this as there's nothing more i think we can do. feel free to reopen it if you learn something about undeletions.","author_login":"dmah42","author_association":"CONTRIBUTOR","created_at":"2022-11-27T10:50:06+08:00","repo_name":"hachyderm/community","issue_id":1457535685,"issue_number":76,"issue_url":"https://github.com/hachyderm/community/issues/76","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_973319670","fragment_type":"issue_description","sequence":0,"text":"Reactivate account\n### Pitch\n\nA user of my instance for trying / wrong ..etc, gave him to delete his account, I get in the admission, as a suspended account.\n\nI try later to register again and cannot. because your email is \"supposedly in use\".\n\nIs there any way to release that email?\n\n### Motivation\n\nReactivate account","author_login":"AnonymousWebHacker","author_association":"NONE","created_at":"2021-08-18T06:24:38+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903136724","fragment_type":"issue_comment","sequence":1,"text":"Read the official documentation: URL as mentioned from the *account* section:\n\nRAILS_ENV=production bin/tootctl accounts create USERNAME --email EMAIL@MAIL.LOL --reattach","author_login":"mthld","author_association":"NONE","created_at":"2021-08-21T15:55:36+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903207694","fragment_type":"issue_comment","sequence":2,"text":"@mthld Thanks for your answer, I was seeing the link, but it can't solve the problem \n\nmastodon@mastodon:~/live$ RAILS_ENV=production bin/tootctl accounts create USERNAME --email whoami@azeroth.website --reattach --force\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:66: warning: previous definition of ProtocRetryError was here\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:206: warning: already initialized constant Net::BufferedIO::BUFSIZE\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:206: warning: previous definition of BUFSIZE was here\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:503: warning: already initialized constant Net::NetPrivate::Socket\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:503: warning: previous definition of Socket was here\nFailure/Error: email\n has already been taken","author_login":"AnonymousWebHacker","author_association":"NONE","created_at":"2021-08-22T03:27:23+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903292147","fragment_type":"issue_comment","sequence":3,"text":"I don't understand if the account was deleted or suspended? Does the account still show up in the admin interface?\nNote that suspending an account also bans their email address.\n \n \n \n \n \n \n \n \n \n \n \n \n \n\nIt seems you're using a *different* username than that of the account which is to be re-used. If you want to re-use the email address but with a different name, you can delete the old account with `tootctl accounts delete USERNAME`.","author_login":"ClearlyClaire","author_association":"COLLABORATOR","created_at":"2021-08-22T16:11:07+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903317143","fragment_type":"issue_comment","sequence":4,"text":"### User data\nUsername: Skeep\nmail: whoami@azeroth.website\n\n### Deleting user\n\nmastodon@mastodon:~/live$ RAILS_ENV=production bin/tootctl accounts delete Skeep\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:66: warning: previous definition of ProtocRetryError was here\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:206: warning: already initialized constant Net::BufferedIO::BUFSIZE\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:206: warning: previous definition of BUFSIZE was here\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:503: warning: already initialized constant Net::NetPrivate::Socket\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:503: warning: previous definition of Socket was here\nDeleting user with 0 statuses, this might take a while...\nOK\n\nSupposedly it was erased and everything ok. When I check the moderation, it keeps coming out, it never goes away.\nI even try to register with his email and it goes out of use.\nCaptura de pantalla de 2021-08-22 15-11-42\nCaptura de pantalla de 2021-08-22 15-11-15\nCaptura de pantalla de 2021-08-22 15-10-51","author_login":"AnonymousWebHacker","author_association":"NONE","created_at":"2021-08-22T19:15:59+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903318106","fragment_type":"issue_comment","sequence":5,"text":"Run, `User.where(email: 'whoami@azeroth.website')` in `RAILS_ENV=production bundle exec rails c`","author_login":"ClearlyClaire","author_association":"COLLABORATOR","created_at":"2021-08-22T19:23:24+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903346249","fragment_type":"issue_comment","sequence":6,"text":"@ClearlyClaire \n\nmastodon@mastodon:~/live$ RAILS_ENV=production bundle exec rails c \n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:66: warning: previous definition of ProtocRetryError was here\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:206: warning: already initialized constant Net::BufferedIO::BUFSIZE\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:206: warning: previous definition of BUFSIZE was here\n/home/mastodon/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:503: warning: already initialized constant Net::NetPrivate::Socket\n/home/mastodon/live/vendor/bundle/ruby/2.7.0/gems/net-protocol-0.1.0/lib/net/protocol.rb:503: warning: previous definition of Socket was here\nUserChewy console strategy is `urgent`\nLoading production environment (Rails 6.1.3.2)\nirb(main):001:0> User.where(email: 'whoami@azeroth.website')\n=> # \n\nThe promt was left waiting as another command, I close it with exit, did not work","author_login":"AnonymousWebHacker","author_association":"NONE","created_at":"2021-08-22T23:19:01+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903512820","fragment_type":"issue_comment","sequence":7,"text":"Hm… alright, the email address has been blocked when you suspended it, then. Removing the block will be a bit annoying… open the Rails console (`RAILS_ENV=production bundle exec rails c`) and type the following:\n\nruby\nclass EmailBlockFinder\n include EmailHelper\n def find(email)\n CanonicalEmailBlock.where(canonical_email_hash: email_to_canonical_email_hash(email))\n end\nend\nEmailBlockFinder.new.find('whoami@azeroth.website').map(&:reference_account)\nEmailBlockFinder.new.find('whoami@azeroth.website').destroy_all\n\n(please copy the output, it will help me debug things)\n\nThis should be enough, but I'm surprised at a few things here:\n- I would have expected the error not to be “has already been taken” (but that is what the code does, it's a bit confusing)\n- I would have expected `tootctl accounts delete Skeep` to also remove the email block, but it does not… maybe it'd need an extra option\n- I would have expected an easy way to remove the email block… but there is none","author_login":"ClearlyClaire","author_association":"COLLABORATOR","created_at":"2021-08-23T07:25:52+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_903636024","fragment_type":"issue_comment","sequence":8,"text":"Oh, the root issue is #16498. I thought this would have been fixed in a release by now :grimacing:","author_login":"ClearlyClaire","author_association":"COLLABORATOR","created_at":"2021-08-23T10:18:06+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278570170","fragment_type":"issue_comment","sequence":9,"text":"Please note that reactivating a user account in this fashion will cause issues when federating with some other ActivityPub implementations.\n\nI reactivated an account on my Mastodon instance using `accounts create` with the `--reattach` flag as described above. The user was unable to interact with users on Pleroma instances that were aware of their account before the deletion. I had to contact the admins of those instances and ask them to manually re-enable the account in their instances, because Pleroma doesn't seem to allow for reactivation of deleted remote accounts.\n\nUnfortunately I'm not ActivityPub-savvy enough to discern whether this kind of user reactivation violates the spec and shouldn't be done, or whether this is a bug in implementations that behave this way.\n\nAnother note: the follower/followed counts for the reactivated user were wrong and wouldn't update until I ran `tootctl cache recount accounts`.","author_login":"Flisk","author_association":"NONE","created_at":"2022-10-14T06:59:19+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278720695","fragment_type":"issue_comment","sequence":10,"text":"It's not a spec violation nor a \"bug\" per se, but it is an unhandled case. Likely what implementations would need to do is detect somehow that the user has been recreated and invalidate their old cache.","author_login":"trwnh","author_association":"CONTRIBUTOR","created_at":"2022-10-14T09:12:46+08:00","repo_name":"mastodon/mastodon","issue_id":973319670,"issue_number":16626,"issue_url":"https://github.com/mastodon/mastodon/issues/16626","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0214","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"New release before end of 2023?","query_context":"Last one was from start of october 2023. Can we carve out a final release for this year before the end of the year?","known_context_document_ids":["gh_issue_2054628793"],"reference_answer":"@Drakonas @fernandofig @Xmetalfanx @elmuz @ms178 @pixelpicnic No it is NOT dead. Im going to be completely honest, I was in inpatient rehab for alcohol, something I have struggled with since 15 years old.\n\nI also happen to have covid right now too (i caught it at the facility, as did 10 others), but I will get a release out as soon as I can (because I want a new version too for tha security fixes)\n\nI will be making a note on the previous release and upcoming release to explain why I was \"dead\" for a month.","answer_document_id":"gh_comment_1855133359","silver_evidence_path":["gh_comment_1870964816","gh_issue_2036951702","gh_comment_1855133359"],"evidence_issue_ids":[2054628793,2036951702],"source_repo_name":"Alex313031/thorium","source_issue_id":2054628793,"source_issue_number":481,"source_issue_url":"https://github.com/Alex313031/thorium/issues/481","target_repo_name":"Alex313031/thorium","target_issue_id":2036951702,"target_issue_number":464,"target_issue_url":"https://github.com/Alex313031/thorium/issues/464","reference_anchor_document_id":"gh_comment_1870964816","reference_answer_author":"Alex313031","reference_answer_author_association":"OWNER","quality_score":77.38,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1538,"target_answer_overlap":0.0476},"issue_created_at":"2023-12-23T02:47:05+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_2054628793","fragment_type":"issue_description","sequence":0,"text":"New release before end of 2023?\nLast one was from start of october 2023. Can we carve out a final release for this year before the end of the year?","author_login":"rubyFeedback","author_association":"NONE","created_at":"2023-12-23T02:47:05+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1868465682","fragment_type":"issue_comment","sequence":1,"text":"@Alex313031 Keep this browser alive, It doesn't matter what people think. It doesn't matter the chromium version is not latest. Other browsers using latest can never beat this browser. Waiting for update sooner. Thanks.","author_login":"NewsonUpreti","author_association":"NONE","created_at":"2023-12-24T08:49:52+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868956109","fragment_type":"issue_comment","sequence":2,"text":"At this point we should just have LTS builds if there's such variant of Chromium, would be better to focus just on it.","author_login":"Kamey2024","author_association":"NONE","created_at":"2023-12-25T12:09:48+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869054622","fragment_type":"issue_comment","sequence":3,"text":"@Alex313031 This browser, was the best browser I ever used. It would be a real shame if it falls apart due to you leaving. I wish you a Mary Christmas and the best of luck. I genuinely don't care about \"images in the files\" if I don't got to mess with it. It did not effect me. Mary Christmas or whatever holiday you wish to celibate, or even none and all. And take your time. Be in a good head space before returning. Please and thank you.","author_login":"pazza2234","author_association":"NONE","created_at":"2023-12-25T16:58:12+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869892585","fragment_type":"issue_comment","sequence":4,"text":"LOL, bro just abandoned the project due to one stupid Chris Titus video, FINE XD","author_login":"ilyabumblebee","author_association":"NONE","created_at":"2023-12-27T02:37:34+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1870060274","fragment_type":"issue_comment","sequence":5,"text":"@ilyabumblebee And we are here using it until it works. Almost 2 months without an update for a browser, still rocks.","author_login":"NewsonUpreti","author_association":"NONE","created_at":"2023-12-27T08:16:42+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1870964816","fragment_type":"issue_comment","sequence":6,"text":"The owner/main dev said in this issue, that he unforatunately has health problems and for that reasons, he currently can't update the browser. But the project is **not dead**, he wants to take care of an update when he feels better again. We shouldn't rush him and give him time to recover.","author_login":"DMW007","author_association":"NONE","created_at":"2023-12-28T09:08:19+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[2036951702],"is_known_query_context":false},{"document_id":"gh_comment_1872244029","fragment_type":"issue_comment","sequence":7,"text":"@DMW007 @rubyFeedback @pazza2234 @NewsonUpreti @ilyabumblebee Project is NOT dead. Just rebased for M119! Building releases now.","author_login":"Alex313031","author_association":"OWNER","created_at":"2023-12-29T17:48:59+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1888126475","fragment_type":"issue_comment","sequence":8,"text":"I am so happy to hear this even If I am late. I will be switching back soon.","author_login":"pazza2234","author_association":"NONE","created_at":"2024-01-11T23:26:50+08:00","repo_name":"Alex313031/thorium","issue_id":2054628793,"issue_number":481,"issue_url":"https://github.com/Alex313031/thorium/issues/481","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2036951702","fragment_type":"issue_description","sequence":0,"text":"Is this project dead?\nThere haven't been any updates in any repo in weeks, 2 months for Windows. If the dev is dealing with life stuff, I understand, but an update would be nice while certain things are starting to break like site data being lost randomly and RAM leak issues popping up.\n\nIf it is abandoned, it'd be nice to state if you have no plans to develop it further so I can move to something else.\n\nHope Alex is ok, regardless.","author_login":"Drakonas","author_association":"NONE","created_at":"2023-12-12T04:30:20+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851562806","fragment_type":"issue_comment","sequence":1,"text":"I sure hope not - I'm late to the party, and I love this browser.\nI hope all is well!","author_login":"pixelpicnic","author_association":"NONE","created_at":"2023-12-12T08:56:07+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851832563","fragment_type":"issue_comment","sequence":2,"text":"@Drakonas This project is notorious for late updates to new releases or skipping several releases alltogether, sadly. Hence the period of time without committs is nothing new. While this doesn't mean that the project is dead, it also speaks for itself that the current team might not be up to the task of maintaining such a big project.\n\nAs Youtubers recently made quite a splash to push Thorium and that Google increased its release cadence, I fear that it collapses under the burden. No timely releases are a major security concern. And as I love Thorium, and its current state saddens me just as well as you.\n\nWhat this project is in dire need of:\n\n1) automated builds and releases\n2) timely updates\n\nFrom the answers I've seen before, it comes down to costs and time issues. The builds are made manually at the moment.","author_login":"ms178","author_association":"NONE","created_at":"2023-12-12T11:13:48+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851847959","fragment_type":"issue_comment","sequence":3,"text":"If you look at the author page you can see almost zero activity recently, not just about this project. Let's hope he'll come back.","author_login":"elmuz","author_association":"NONE","created_at":"2023-12-12T11:24:00+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1853114471","fragment_type":"issue_comment","sequence":4,"text":"If you look into his activity back in 2022, it seems that, much like this year, he was mostly inactive from november. Activity picked up again by January. Maybe he's on vacation?\n\nHonestly I don't care at this point. I've been watching this project and feeling pretty much the same as @ms178 , and now from what is transpiring from #463 , I think I'll jump ship altogether.","author_login":"fernandofig","author_association":"NONE","created_at":"2023-12-13T01:19:18+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1854847880","fragment_type":"issue_comment","sequence":5,"text":"I hope somebody remakes a similar project so it's under a significantly less concerning developer.","author_login":"SethbotStar","author_association":"NONE","created_at":"2023-12-13T23:23:57+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1855100451","fragment_type":"issue_comment","sequence":6,"text":"yeah ... i am going to have to go back to FIrefox ... the \"furry porn\" stuff i think should be removed and has no place in a project like this (not even \"offended\" or \"think of the children!\" about it) ... the other stuff i saw just now ... figuring some people were going overboard BUT THEN seeing proof ... I cant have anything by this dev on my PC ... i am done .... and this was the first non-bloated (looking at Brave and Vivaldi) Chromium based browser i liked ... ever ... but yeah ... forget all the good stuff .... now maybe if another dev does the same sort of work, removes all that crap and takes OVER the project ... I may come back \n\nthis dev may do great coding work but this content i have seen on his/her repos is not acceptable to me ... and yes i admit again i thought some users were going overboard ... just seeing one \"furry porn\" pic at first.","author_login":"Xmetalfanx","author_association":"NONE","created_at":"2023-12-14T04:13:20+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1855122786","fragment_type":"issue_comment","sequence":7,"text":"Yeah, honestly the furry porn shit was bad on its own, and that in it of itself got me to start pulling it from computers i installed it on. Even still, at that point i would have been willing to give it another shot in the future.\n\nWhen somebody archives a site titled the way that repo was titled, and has those types of images for _any_ reason, I no longer trust the main dev of this project, and so far i don't really trust any of the other devs I've seen so far, while i don't recall that they have done much to lose trust, they haven't done much to regain trust from a currently tainted project.\n\nIt would be nice if somebody else remakes a similar project, but with everything that has come out, it cannot be under the current main dev.","author_login":"SethbotStar","author_association":"NONE","created_at":"2023-12-14T04:47:08+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1855133359","fragment_type":"issue_comment","sequence":8,"text":"@Drakonas @fernandofig @Xmetalfanx @elmuz @ms178 @pixelpicnic No it is NOT dead. Im going to be completely honest, I was in inpatient rehab for alcohol, something I have struggled with since 15 years old.\n\nI also happen to have covid right now too (i caught it at the facility, as did 10 others), but I will get a release out as soon as I can (because I want a new version too for tha security fixes)\n\nI will be making a note on the previous release and upcoming release to explain why I was \"dead\" for a month.","author_login":"Alex313031","author_association":"OWNER","created_at":"2023-12-14T05:02:25+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1857170655","fragment_type":"issue_comment","sequence":9,"text":"@Xmetalfanx @SethbotStar You guys do know it was an archive of an anti circumcision website that was around for over a decade until the hosters shut down > URL","author_login":"Alex313031","author_association":"OWNER","created_at":"2023-12-15T02:25:10+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1865750216","fragment_type":"issue_comment","sequence":10,"text":"@Alex313031 \nAppreciate you and hope you're doing better. Thanks for sharing - that's big of you.\nfortify!","author_login":"pixelpicnic","author_association":"NONE","created_at":"2023-12-21T07:27:54+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868159726","fragment_type":"issue_comment","sequence":11,"text":"Truly.. I had no intention of sharing ill contempt.. I was honestly more worried something has happened to you.\n\nI hope you recover well... Sounds like such an awful thing to have to deal with during the holiday season.\n\nWishing you well mate. Rooting for you.","author_login":"Drakonas","author_association":"NONE","created_at":"2023-12-23T01:08:24+08:00","repo_name":"Alex313031/thorium","issue_id":2036951702,"issue_number":464,"issue_url":"https://github.com/Alex313031/thorium/issues/464","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0215","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"All databases are empty, possibly due to unintentional OrbStack reset?","query_context":"### Preliminary checklist\n\n- [x] I am using the latest stable version of DDEV (see upgrade guide)\n- [x] I have searched existing issues\n- [x] I have checked the troubleshooting guide\n- [x] I have run `ddev debug test` to include output below\n\n### Output of `ddev debug test`\n\nSince the upgrade to 1.24.5, all my databases are empty.\n\nUpgrade to 1.24.6 did not help.\n\nI run ddev debug test in one of my projects, here is th output.\n\n URL \n\n### Expected Behavior\n\nI expect that after upgrade all projects are still running with no problem (as it did all the uzpgrades before)\n\n### Actual Behavior\n\nAll databases are running and I can connect but are empty\n\n### Steps To Reproduce\n\n_No response_\n\n### Anything else?\n\n_No response_","known_context_document_ids":["gh_issue_3085301814"],"reference_answer":"Thank you for the feedback @MattWilcox.\n \n\nIt can be disabled completely:\n\nbash\nddev config --disable-settings-management","answer_document_id":"gh_comment_2893966568","silver_evidence_path":["gh_comment_2903595495","gh_issue_3019954269","gh_comment_2893966568"],"evidence_issue_ids":[3085301814,3019954269],"source_repo_name":"ddev/ddev","source_issue_id":3085301814,"source_issue_number":7328,"source_issue_url":"https://github.com/ddev/ddev/issues/7328","target_repo_name":"ddev/ddev","target_issue_id":3019954269,"target_issue_number":7233,"target_issue_url":"https://github.com/ddev/ddev/issues/7233","reference_anchor_document_id":"gh_comment_2903595495","reference_answer_author":"stasadev","reference_answer_author_association":"MEMBER","quality_score":87.8,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0976,"anchor_target_overlap":0.2683,"target_answer_overlap":0.1111},"issue_created_at":"2025-05-23T06:11:57+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_3085301814","fragment_type":"issue_description","sequence":0,"text":"All databases are empty, possibly due to unintentional OrbStack reset\n### Preliminary checklist\n\n- [x] I am using the latest stable version of DDEV (see upgrade guide)\n- [x] I have searched existing issues\n- [x] I have checked the troubleshooting guide\n- [x] I have run `ddev debug test` to include output below\n\n### Output of `ddev debug test`\n\nSince the upgrade to 1.24.5, all my databases are empty.\n\nUpgrade to 1.24.6 did not help.\n\nI run ddev debug test in one of my projects, here is th output.\n\n URL \n\n### Expected Behavior\n\nI expect that after upgrade all projects are still running with no problem (as it did all the uzpgrades before)\n\n### Actual Behavior\n\nAll databases are running and I can connect but are empty\n\n### Steps To Reproduce\n\n_No response_\n\n### Anything else?\n\n_No response_","author_login":"idleog","author_association":"NONE","created_at":"2025-05-23T06:11:57+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2903595495","fragment_type":"issue_comment","sequence":1,"text":"Hi @idleog,\n\nI see that you are using Craft CMS, in a recent release there were changes (requested by the Craft CMS team) in the arrangement of environment variables URL \n\nYou are most likely connected to a database defined in `.ddev/.env.web` instead of `.env`.\n\nSee the issue for more details:\n\n- #7233\n\n---\n\nDDEV didn't delete your databases, the volumes are here:\n\n======== docker system df ========\nTYPE TOTAL ACTIVE SIZE RECLAIMABLE\nImages 23 0 4.042GB 4.042GB (100%)\nContainers 0 0 0B 0B\nLocal Volumes 17 0 3.259GB 3.259GB (100%)\nBuild Cache 158 0 22.23MB 22.23MB","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-23T07:54:34+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[3019954269],"is_known_query_context":false},{"document_id":"gh_comment_2903723762","fragment_type":"issue_comment","sequence":2,"text":"Hi @stasadev\n\nThanks a lot for your answer.\n\nI was aware of the new .env file in .ddev, and it is setup correctly (the db settings in .ddev/.env.web are identical to the ones in web/.env)\nAnd I have two projects running with CakePHP, no CraftCMS, and I have the same problem there.\n\nWhen I open sequelace with 'ddev sequelace', I see the db called db, but there are no tables in it.\n\nIf you say DDEV didn't delete my databases, the volumes are here, is there another way to see all databases, including the ones CraftCMS used to use, and to dump them?\n\nCheers\nPeter","author_login":"idleog","author_association":"NONE","created_at":"2025-05-23T08:42:30+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903781778","fragment_type":"issue_comment","sequence":3,"text":"First, make sure it's not an issue with Sequel Ace.\n\nCheck for tables with:\n\nbash\nddev mysql -udb -pdb -e 'SHOW TABLES;'\n\nThen check your volumes (or use the OrbStack GUI):\n\nbash\ndocker volume ls\n\nThere’s a chance a Docker factory reset was done, and the 17 volumes (3.259 GB) I see could be just Mutagen volumes, not actual database data.\n\nThere’s also a chance a different Docker provider was used earlier, and databases are still there, but `docker context ls` shows only OrbStack, so that’s unlikely.\n\n---\n\nP.S. Always make backups: URL","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-23T09:04:55+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903794201","fragment_type":"issue_comment","sequence":4,"text":"And one more unrelated issue:\n\n======== OS Information ========\nDarwin MacBookPro.fritz.box \n\n======== ping attempt on ddev.site ========\nping: cannot resolve dkdkd.ddev.site: Unknown host\n\nDDEV is about to issue the command:\n sudo --preserve-env=HOME /opt/homebrew/bin/ddev hostname tryddevproject-31553.ddev.site 127.0.0.1\n\nYou're using Fritzbox, and `*.ddev.site` is not resolved by default, see URL","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-23T09:09:41+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903920589","fragment_type":"issue_comment","sequence":5,"text":"Thanks for your reply.\n\nIt is not an sequealace issue, ddev mysql -udb -pdb -e 'SHOW TABLES;' shows no result, and CraftCMS shows 503 whent starting the frontend, and wants to install CraftCMS when launching the backend.\n\n'docker volume ls' shows all current volumes, including the formation21-mariadb volume.\n\nwhen I import a backup, everything is up and running again, so it seems that the db is initially around and connected as it should, but it is empty (that's also the reason that CraftCMS trys to reinstall, becuase it sees an empty db).\n\nI did compare the db volumes of a project with empty db, and a project with re-imported backup, they looks quite different, but I do not understand what all the files are for at all, so maybe an expert can say sth. looking at the screenshots.\n\nproject, db-volume with reimported backup\n \n\nproject, db-volume with empty db\n \n\nCheers, -Peter","author_login":"idleog","author_association":"NONE","created_at":"2025-05-23T09:59:15+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903945666","fragment_type":"issue_comment","sequence":6,"text":"By the dates, were the new \"empty\" volumes data created recently?\n\nYou started using DDEV quite a while ago:\n\n======== mkcert information ========\n/opt/homebrew/bin/mkcert\nCAROOT= WSLENV= JAVA_HOME=\n/Users/goeldi/Library/Application Support/mkcert\ntotal 16\n-r-------- 1 goeldi staff 2484 24 Feb 2023 rootCA-key.pem\n-rw-r--r-- 1 goeldi staff 1777 24 Feb 2023 rootCA.pem\n\nBut the total number of images is small:\n\n======== docker system df ========\nTYPE TOTAL ACTIVE SIZE RECLAIMABLE\nImages 23 0 4.042GB 4.042GB (100%)\nContainers 0 0 0B 0B\nLocal Volumes 17 0 3.259GB 3.259GB (100%)\nBuild Cache 158 0 22.23MB 22.23MB\n\nIn most cases, users don’t manually clean up Docker resources, and images tend to accumulate.\n\nI assume a Docker factory reset may have occurred. DDEV itself can't do that.","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-23T10:09:08+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903971179","fragment_type":"issue_comment","sequence":7,"text":"All existing volumes are created recently, and only the ddev projects I started after the update to 1.24.5 are around at all. All other project volumes are gone.\n\n \n\nso this means that all docker files/volumes have been cleaned? So that must be happened in Orbstack? I for sure did not clean up any resources on purpose.","author_login":"idleog","author_association":"NONE","created_at":"2025-05-23T10:18:40+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903990865","fragment_type":"issue_comment","sequence":8,"text":"Correct, something happened with OrbStack.\nI can't say what exactly. Hope you have all needed backups.\nHere's the link again for anyone reading this: URL","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-23T10:27:11+08:00","repo_name":"ddev/ddev","issue_id":3085301814,"issue_number":7328,"issue_url":"https://github.com/ddev/ddev/issues/7328","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3019954269","fragment_type":"issue_description","sequence":0,"text":"Improve Craft CMS \"settings management\" (writing to project `.env`)\n### Is there an existing issue for this?\n\n- [x] I have searched the existing issues\n\n### Is your feature request related to a problem?\n\nThe Craft CMS project type writes a number of `CRAFT_*` vars to the project's `.env` file, which is not ideal for a few reasons:\n- Craft itself doesn't natively enforce .env usage, so it relys on someone using `vlucas/phpdotenv`\n- We've found it not uncommon for people to upload their local .env file to a server and use as a base for editing. Usually they are aware enough to change the `CRAFT_DB_` vars, but often times don't realize `CRAFT_WEB_ROOT` was added by DDEV, leave it in place, and break their remote app.\n\n### Describe your solution\n\nThe way things are implemented now seems to be somewhat by chance and a fundamental misunderstanding of how the \"settings management\" feature is intended to be used.\n\nIdeally, DDEV wouldn't touch the project's `.env` file, and instead inject the environment variables directly into the containers.\n\n### Describe alternatives\n\n It appears that writing `.ddev/.env` is one option for that, but writing to YAML may also be an option.\n\n### Additional context\n\n- URL \n- URL","author_login":"timkelty","author_association":"CONTRIBUTOR","created_at":"2025-04-25T12:40:43+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2830946109","fragment_type":"issue_comment","sequence":1,"text":"I would really like to see us use .ddev/.env. \n\nNote that environment variables defined in `.ddev/.env` are populated for all containers for the project.\n\nIt seems like just creating/managing `.ddev/.env` would solve the Craft problems ?","author_login":"rfay","author_association":"MEMBER","created_at":"2025-04-25T16:59:01+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2845208080","fragment_type":"issue_comment","sequence":2,"text":"@timkelty we'll need at least your reaction and followup on \n* URL \nto move this forward.","author_login":"rfay","author_association":"MEMBER","created_at":"2025-05-01T16:36:17+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2890340090","fragment_type":"issue_comment","sequence":3,"text":"While it's not required, it's used by the template URL \n\n---\n \n\nI opened the issue below for this:\n\n- #7309\n\n---\n\nFrom Discord URL \n\nUsing `.ddev/.env.web` may not be an obvious change for existing applications.\n\nIt might make sense to revert #7236 in favor of implementing #7309, especially while Craft CMS setup is still broken (see #7286) in DDEV v1.24.5, so the impact remains minimal for now.","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-19T09:36:43+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2891516646","fragment_type":"issue_comment","sequence":4,"text":"We're not reverting anything in v1.24.6.\n\nWe'll gather more feedback from the Craft CMS community on this.\n\nThe idea in #7309 is good and will improve things for all project types.","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-19T15:51:32+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2893954677","fragment_type":"issue_comment","sequence":5,"text":"Just adding in here as general feedback so it's not lost in Discord.\n\nThis change is something I just don't want in our projects, and all it's done in introduce a new thing I've had to add into the project's root level .gitignore file, and a level of confusion about what's actually happening.\n\nContext: I was working on our long-standing starter project, from which other web projects are built, and the new behaviour added the `.ddev/.env.web` file into that base project's Git repo - but that file has variable values specific to the instance (PRIMARY_SITE_URL).\n\nI appreciate this may be a little niche, but as a general thought - I was under the impression that .env anything should not be in GIT, because the purpose is that these are environmental data that changes, and shouldn't be in Git because those values differ based on where you're actually running the project.\n\nFrankly, for us, we don't want any of the stuff DDEV adds into `.env` as we just do not use those values in our projects. It's already set up and running. Likewise, we don't want or need the new `.ddev/.env.web` either - and now it's there, I don't actually understand _which .env files' values_ will be being used! The one in .ddev, or our standard one at the standard location.","author_login":"MattWilcox","author_association":"NONE","created_at":"2025-05-20T11:14:15+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2893966568","fragment_type":"issue_comment","sequence":6,"text":"Thank you for the feedback @MattWilcox.\n \n\nIt can be disabled completely:\n\nbash\nddev config --disable-settings-management","author_login":"stasadev","author_association":"MEMBER","created_at":"2025-05-20T11:17:41+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2894338620","fragment_type":"issue_comment","sequence":7,"text":"As you see @MattWilcox this was requested by @timkelty of Pixel & Tonic. We generally only do explicit CMS integrations in collaboration with the communities involved, and this one was done over time with collaboration from the Craft CMS folks.","author_login":"rfay","author_association":"MEMBER","created_at":"2025-05-20T13:06:01+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2895543089","fragment_type":"issue_comment","sequence":8,"text":"We just tagged new `craftcms/craft` releases for v4 and v5, which no longer include default `CRAFT_DB_*` env var values in `.env.example.dev` file (which the default `.env` file is copied from on `composer install`).\n\nTested installing Craft 4 and 5 on an older version of DDEV as well as v1.24.6, and all works as expected. Older versions will append the `CRAFT_DB_*` vars to `.env`, and v1.24.6 will add them to `.ddev/.env.web`. Either way, Craft is configured correctly and able to connect to the DB immediately after running `ddev create-project`.\n \n \n \n\n@MattWilcox That’s true for the root `.env` file, but this is a special case. DDEV isn’t adding any sensitive to `.ddev/.env.web`, or anything that would change from one dev environment to the next; it’s all just a replication of info that’s already being stored elsewhere in `.ddev/`.","author_login":"brandonkelly","author_association":"CONTRIBUTOR","created_at":"2025-05-20T19:18:08+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2895626495","fragment_type":"issue_comment","sequence":9,"text":"It's also worth noting that `.ddev/.env.web` and `.env` are fundamentally different: Vars in `.ddev/.env.web` are actually injected into the DDEV containers by docker, where `.env` is loaded by the `vlucas/phpdotenv` and the project itself.","author_login":"timkelty","author_association":"CONTRIBUTOR","created_at":"2025-05-20T19:30:58+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2897038485","fragment_type":"issue_comment","sequence":10,"text":"@timkelty @brandonkelly I'm figuring out how to address those changes in our existing projects and our Craft boilerplate. Removing the `CRAFT_DB_*` variables from the `.env` doesn't work for me because we only have a single `.env.example`, not three different examples files for dev/staging/production. So we're always copying `.env.example` to `.env` during `composer install`. That means we would have to manually add those variables to the `.env` in any staging or production system, which is awkward.\n\nI found a much better solution, in my opinion, is to switch from `Dotenv\\Dotenv::createUnsafeMutable` to `Dotenv\\Dotenv::createUnsafeImmutable` in our `bootstrap.php`. This means that existing environment variables can never be overridden. This is a saner default anyway. And it means I can still have the `CRAFT_DB_*` variables in my env, but they won't take effect if ddev has already set those variables, so the ddev-injected variables always have precedence and will always work, even if another colleague hasn't updated their `.env` yet.\n\nThis might be a good default for `craftcms/craft` as well?\n\nCorrect me if I'm missing something …\n\n---\n\n@MattWilcox I agree with you that even the env files in `.ddev` shouldn't be tracked in git, I've added this in my top-level `.gitignore` when we started using ddev:\n\ngitignore\n/.ddev/.env\n/.ddev/.env.*","author_login":"MoritzLost","author_association":"NONE","created_at":"2025-05-21T08:17:55+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2898964623","fragment_type":"issue_comment","sequence":11,"text":"@MoritzLost We used to use `createUnsafeImmutable()`, but changed it in response to URL \n\nWe just discussed whether it would make sense to switch back in light of this DDEV change, but decided to keep it as-is, as the (now) current behavior is more in line with expected behavior at first glance. (We expect it would confuse people to have environment variables defined in `.env` which aren’t getting picked up.)\n\nThat said, if you’d prefer to stick with a single `.env.example` and understand the effects of going with `createUnsafeImmutable()`, you are definitely free to go with that in your own projects!","author_login":"brandonkelly","author_association":"CONTRIBUTOR","created_at":"2025-05-21T19:12:00+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2900368703","fragment_type":"issue_comment","sequence":12,"text":"@brandonkelly Good to know the history, thanks! Yeah, it might be confusing for new devs if their `.env` doesn't take effect.\n\nWe'll stick with using `createUnsafeImmutable()` for now. ddev only sets the variables that are absolutely required for the web container to work correctly, so having those take precedence makes sense for us. But I can see that using the mutable approach is a more reasonable default for the starter project.\n\nI've added a note at the top of our `.env.example` to avoid future confusion:\n\n# Environment variables are loaded in `bootstrap.php` by vlucas/phpdotenv\n# Existing environment variables (e.g. provided by DDEV) always take precedence\n# and are not overridden by .env values. If a variable is already set in the\n# environment, the .env value is ignored.","author_login":"MoritzLost","author_association":"NONE","created_at":"2025-05-22T08:33:21+08:00","repo_name":"ddev/ddev","issue_id":3019954269,"issue_number":7233,"issue_url":"https://github.com/ddev/ddev/issues/7233","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0217","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Mes compteurs d'énergie ne fonctionnent pas - There is no state available for this entity?","query_context":"Est-ce que ca vous dit qqch?\n\nOn dirait que Home assistant force la définition de tyypes pour ces variables... mais j'y connais pas grand chose!\n\nJ'ai récemment dû réinstaller l'intégration après plusieurs problèmes bizarres. Tout semble enfin se connecter et je suis capable de contrôler mes thermostats à partir de Home Asssistant. Par contre, aucune donnée statistiques au niveau Énergie.\n\nimage\n\nQuand je regarde les stats dans Developers tools, je vois ceci: \n\nimage\n\nimage\n\nJe n'ai pas essayé de cliquer sur \"remove\", car je ne veux justement pas les enlever... mais peut-etre vont-ils se recréer ensuite?","known_context_document_ids":["gh_issue_1234069615"],"reference_answer":"Bon j'ai réessayé avec la version officielle 2022.5 qui sortait aujourd'hui et ca marche toujours pas.. j'ai l'impression que c'est vraiment un détail que @valleedelisle pourrait régler... as-tu des idées rapides? Merci\n\nSetup failed for custom integration hilo: Requirements for hilo not found: ['python-hilo>=2022.5.1'].\n14:55:43 – (ERROR) setup.py\n\nLogger: homeassistant.util.package\nSource: util/package.py:99\nFirst occurred: 14:52:30 (3 occurrences)\nLast logged: 14:55:43\n\nUnable to install package python-hilo>=2022.5.1: ERROR: Cannot install python-hilo==2022.5.1 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit URL WARNING: You are using pip version 22.0.3; however, version 22.0.4 is available. You should consider upgrading via the '/usr/local/bin/python3 -m pip install --upgrade pip' command.","answer_document_id":"gh_comment_1117701017","silver_evidence_path":["gh_comment_1127678480","gh_issue_1218055088","gh_comment_1117701017"],"evidence_issue_ids":[1234069615,1218055088],"source_repo_name":"dvd-dev/hilo","source_issue_id":1234069615,"source_issue_number":121,"source_issue_url":"https://github.com/dvd-dev/hilo/issues/121","target_repo_name":"dvd-dev/hilo","target_issue_id":1218055088,"target_issue_number":112,"target_issue_url":"https://github.com/dvd-dev/hilo/issues/112","reference_anchor_document_id":"gh_comment_1127678480","reference_answer_author":"FrancoLoco","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.3333,"target_answer_overlap":0.2174},"issue_created_at":"2022-05-12T14:27:38+08:00","valid_comment_count":38,"fragments":[{"document_id":"gh_issue_1234069615","fragment_type":"issue_description","sequence":0,"text":"Mes compteurs d'énergie ne fonctionnent pas - There is no state available for this entity\nEst-ce que ca vous dit qqch?\n\nOn dirait que Home assistant force la définition de tyypes pour ces variables... mais j'y connais pas grand chose!\n\nJ'ai récemment dû réinstaller l'intégration après plusieurs problèmes bizarres. Tout semble enfin se connecter et je suis capable de contrôler mes thermostats à partir de Home Asssistant. Par contre, aucune donnée statistiques au niveau Énergie.\n\nimage\n\nQuand je regarde les stats dans Developers tools, je vois ceci: \n\nimage\n\nimage\n\nJe n'ai pas essayé de cliquer sur \"remove\", car je ne veux justement pas les enlever... mais peut-etre vont-ils se recréer ensuite?","author_login":"RayLation","author_association":"NONE","created_at":"2022-05-12T14:27:38+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1127678480","fragment_type":"issue_comment","sequence":1,"text":"C'est réglé dans la plus récente version, sinon voir mes explications pour faire le ménage dans le dashboard energy: URL","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-16T13:30:28+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[1218055088],"is_known_query_context":false},{"document_id":"gh_comment_1214393775","fragment_type":"issue_comment","sequence":2,"text":"Y'a eu un gros remaniement du code chez HA pour tout ce qui est énergy dashboard et utility meters. Je vais devoir deepdive à nouveau ce code pour bien intégrer.","author_login":"valleedelisle","author_association":"CONTRIBUTOR","created_at":"2022-08-14T14:47:56+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1280047391","fragment_type":"issue_comment","sequence":3,"text":"Est-ce que dans l'intervalle, il est possible de désactiver l'ajout automatique des sensors dans l'onglet Energie pour que seulement nos entrées manuelles (qui fonctionnent) restent?\n\nJ'ai le même problème. J'avais tout cleané hier, mis les bons sensors, puis ce matin plus rien ne marchait et les sensors non fonctionnels étaient revenus.","author_login":"bobthebignose","author_association":"NONE","created_at":"2022-10-16T20:12:50+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1312829946","fragment_type":"issue_comment","sequence":4,"text":"Juste pour info, je viens tout juste de faire un fresh install de hass, la version avec URL \n\nJ'ai aucune données dans mes energy meters. L'hivers commence et j'aurais bien aimé suivre la consommation de mes 10 thermostats\nimage\n\nimage","author_login":"caublet","author_association":"NONE","created_at":"2022-11-13T21:45:27+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1324539501","fragment_type":"issue_comment","sequence":5,"text":"Je suis content de voir que c'est pas moi qui est fou... j'ai passé ma soirée a force-delete les donnees d'ergenie, re-installer le plugin Hilo, delete tous mes devices a la main... Puis au final, y'a rien qui marche :)\n\nMeme genre de setup, Proxmox + HAOS dans sa propre VM. Fresh install de HA (ma premiere motivation est d'utiliser le le plugin d'hilo!)\n\nLaisse-moi savoir si tu trouves une solution","author_login":"vincentleclerc","author_association":"NONE","created_at":"2022-11-23T04:36:14+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427109829","fragment_type":"issue_comment","sequence":6,"text":"Je viens d'avoir le même problème. Je me suis aperçu que ma config s'était vidée.\n\nAs-tu vérifié que tu avais de l'info dans le plan name et la case pour générer les sensors à ON?\nimage","author_login":"snaky69","author_association":"CONTRIBUTOR","created_at":"2023-02-12T19:11:41+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436079635","fragment_type":"issue_comment","sequence":7,"text":"J'ai finalement réussi a faire marcher les compteurs d'énergie. J'ai repris la doc dans ReadMe.md et ca s'est mis a marcher. CODE 18!\n\nNormalement, je fermerais cette issue. Je pense que c'est resolved.","author_login":"caublet","author_association":"NONE","created_at":"2023-02-19T20:01:18+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436080326","fragment_type":"issue_comment","sequence":8,"text":"As tu essayé ca? Ca pourrait confirmer que c'est resolved.\n\nimage","author_login":"caublet","author_association":"NONE","created_at":"2023-02-19T20:03:46+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1458040137","fragment_type":"issue_comment","sequence":9,"text":"Je regarde les screenshot de @caublet et c’est partielle réglé avec #230 \n\nLes sensors qui sont dans ton dashboard sont non fonctionnels. Il faut les enlever et suivre la méthode donnée par @skimaniac dans #160 \n\nje vais essayer d’ajouter ça dans le wiki","author_login":"ic-dev21","author_association":"CONTRIBUTOR","created_at":"2023-03-07T11:58:05+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1458044705","fragment_type":"issue_comment","sequence":10,"text":"As tu réglé ton problème? Voir ma réponse à @caublet \n\nFaites un update à la dernière version de Hilo ça va aider!","author_login":"ic-dev21","author_association":"CONTRIBUTOR","created_at":"2023-03-07T12:01:15+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1783782290","fragment_type":"issue_comment","sequence":11,"text":"Fix possible mergé. Je sais que c’est plate à faire mais clean install redonnes-moi des nouvelles?","author_login":"ic-dev21","author_association":"COLLABORATOR","created_at":"2023-10-28T11:18:38+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826808710","fragment_type":"issue_comment","sequence":12,"text":"Ca a l'air d'être OK mais je t'avoue que je check pu ca depuis un méchant bout, car je n'utilise plus les compteurs d'énergies fournis par l'intégration depuis que j'ai connecté mes thermostats hilo directement par zigbee. Mais bon, les compteurs ont l'air OK dans las section \"statistics\" présentement.","author_login":"RayLation","author_association":"NONE","created_at":"2023-11-26T15:07:57+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826894204","fragment_type":"issue_comment","sequence":13,"text":"Je vais fermer et suivre ça dans #319 comme c'est un duplicate plus récent. Merci de ta réponse!","author_login":"ic-dev21","author_association":"COLLABORATOR","created_at":"2023-11-26T20:55:29+08:00","repo_name":"dvd-dev/hilo","issue_id":1234069615,"issue_number":121,"issue_url":"https://github.com/dvd-dev/hilo/issues/121","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1218055088","fragment_type":"issue_description","sequence":0,"text":"Incompatibilité Home Assistant 2022.5\nNe marche pas bien avec 2022.5 présentement… updatez à vos risques et périls.. pour ma part j’ai rollbacké et j’ai encore des trucs qui ne marchent plus avec Hilo depuis…","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-04-28T01:16:32+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1116533946","fragment_type":"issue_comment","sequence":1,"text":"@FrancoLoco as-tu résolu tes problèmes avec 2022.5? La version officielle vient de sortir, peux-être qu'ils ont changé des choses depuis la beta?","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-03T20:07:43+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1116556355","fragment_type":"issue_comment","sequence":2,"text":"Non j'étais revenu à 2022.4 et j'ai pas réessayé 2022.5 depuis..","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-03T20:23:23+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1117521939","fragment_type":"issue_comment","sequence":3,"text":"@skimaniac as-tu essayé toi? est-ce que ca marche maintenant?","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-04T15:54:59+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1117701017","fragment_type":"issue_comment","sequence":4,"text":"Bon j'ai réessayé avec la version officielle 2022.5 qui sortait aujourd'hui et ca marche toujours pas.. j'ai l'impression que c'est vraiment un détail que @valleedelisle pourrait régler... as-tu des idées rapides? Merci\n\nSetup failed for custom integration hilo: Requirements for hilo not found: ['python-hilo>=2022.5.1'].\n14:55:43 – (ERROR) setup.py\n\nLogger: homeassistant.util.package\nSource: util/package.py:99\nFirst occurred: 14:52:30 (3 occurrences)\nLast logged: 14:55:43\n\nUnable to install package python-hilo>=2022.5.1: ERROR: Cannot install python-hilo==2022.5.1 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit URL WARNING: You are using pip version 22.0.3; however, version 22.0.4 is available. You should consider upgrading via the '/usr/local/bin/python3 -m pip install --upgrade pip' command.","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-04T19:02:26+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118503207","fragment_type":"issue_comment","sequence":5,"text":"Je viens d'upgrader mon container ce matin et je n'ai pas eu ce probleme. Par contre, j'ai une erreur similaire avec une autre de mes integration [1] et j'ai une autre erreur [2] plus loin qui semble liée à un changement dans l'integration sensor de home assistant\n\n[1]\n\n2022-05-05 08:38:21 ERROR (SyncWorker_2) [homeassistant.util.package] Unable to install package paho-mqtt==1.5.1: ERROR: Cannot install paho-mqtt==1.5.1 because these package versions have conflicting dependencies.\nERROR: ResolutionImpossible: for help visit URL \nWARNING: You are using pip version 22.0.3; however, version 22.0.4 is available.\nYou should consider upgrading via the '/usr/local/bin/python3 -m pip install --upgrade pip' command.\n2022-05-05 08:38:21 INFO (SyncWorker_3) [homeassistant.util.package] Attempting install of paho-mqtt==1.5.1\n2022-05-05 08:38:28 ERROR (SyncWorker_3) [homeassistant.util.package] Unable to install package paho-mqtt==1.5.1: ERROR: Cannot install paho-mqtt==1.5.1 because these package versions have conflicting dependencies.\nERROR: ResolutionImpossible: for help visit URL \nWARNING: You are using pip version 22.0.3; however, version 22.0.4 is available.\nYou should consider upgrading via the '/usr/local/bin/python3 -m pip install --upgrade pip' command.\n2022-05-05 08:38:28 INFO (SyncWorker_1) [homeassistant.util.package] Attempting install of paho-mqtt==1.5.1\n2022-05-05 08:38:31 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [281472852626640] Received invalid command: mobile_app/push_notification_channel\n2022-05-05 08:38:35 ERROR (SyncWorker_1) [homeassistant.util.package] Unable to install package paho-mqtt==1.5.1: ERROR: Cannot install paho-mqtt==1.5.1 because these package versions have conflicting dependencies.\nERROR: ResolutionImpossible: for help visit URL \nWARNING: You are using pip version 22.0.3; however, version 22.0.4 is available.\nYou should consider upgrading via the '/usr/local/bin/python3 -m pip install --upgrade pip' command.\n2022-05-05 08:38:35 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration jq300: Requirements for jq300 not found: ['paho-mqtt==1.5.1'].\n\n[2]\n\n2022-05-05 08:39:02 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up hilo platform for sensor\nTraceback (most recent call last):\n File \"/usr/src/homeassistant/homeassistant/helpers/entity_platform.py\", line 249, in _async_setup_platform\n await asyncio.shield(task)\n File \"/config/custom_components/hilo/sensor.py\", line 171, in async_setup_entry\n create_energy_entity(d)\n File \"/config/custom_components/hilo/sensor.py\", line 148, in create_energy_entity\n device._energy_entity = EnergySensor(device)\n File \"/config/custom_components/hilo/sensor.py\", line 264, in __init__\n super().__init__(\nTypeError: __init__() got an unexpected keyword argument 'unit_of_measurement'","author_login":"valleedelisle","author_association":"CONTRIBUTOR","created_at":"2022-05-05T12:45:11+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118507789","fragment_type":"issue_comment","sequence":6,"text":"@valleedelisle as tu vu ma pull request dans python-Hilo? J’ai l’impression que lousser les requirements aiderait..?","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-05T12:49:47+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118542305","fragment_type":"issue_comment","sequence":7,"text":"Non j'ai pas toucher à 2022.5 un peu à cause de ça, mais j'ai un home assistant (test) sur un docker lui je l'ai updater et j'ai tester Hilo sur lui ce matin et ça fonctionne pas (les mêmes erreurs que vous avez rapporter)\n\nDonc je toucherai pas à mon HA principal pour tout de suite ;)","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-05T13:21:00+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118545392","fragment_type":"issue_comment","sequence":8,"text":"Moi qui d'habitude upgrade 2 fois par année, j'me suis fait mettre de la pression en écrivant ça 🤣 J'ai pu d'environment de test alors j'viens de mettre ma 'prod' à terre pour faire marcher ça.","author_login":"valleedelisle","author_association":"CONTRIBUTOR","created_at":"2022-05-05T13:23:31+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118551152","fragment_type":"issue_comment","sequence":9,"text":"@valleedelisle c'est quoi ton autre intégration qui ne fonctionne plus? Si c'est un intégrationnistes assez populaire ça se peux que les dévelopeur de HA corrige le problème de python ou je sais pas trop... ;)","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-05T13:27:57+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118581352","fragment_type":"issue_comment","sequence":10,"text":"Un autre developpeur qui fix son integration sans pousser une release 🙄 (ca m'est arrived quelques fois)","author_login":"valleedelisle","author_association":"CONTRIBUTOR","created_at":"2022-05-05T13:51:50+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118594050","fragment_type":"issue_comment","sequence":11,"text":"All right je confirme que ca marche avec le nouveau release v2022.5.2, party d'update d'Home Assistant! 🎉 Merci!!","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-05T14:02:06+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118769366","fragment_type":"issue_comment","sequence":12,"text":"y a tu juste moi qui a ce bug là: dans HA SmartEnergyMeter Power 0w, dans l'app Hilo 0w, mais le total par heur dans l'app continu à monter. 🤨","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-05T16:24:57+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118842181","fragment_type":"issue_comment","sequence":13,"text":"Moi c'est ok ça se met à jour. Mais si tu as 0 dans l'app Hilo ta passerelle est probablement déconnecté du côté de l'antenne zigbee vers le compteur d'Hydro.\n\nLes thermostats répondent?\n\nSi oui reboot la paserelle.\n\nSi ça se règle pas dans Hilo : j'ai du le ouvrir un case pour la mienne qui parlait plus au compteur. 3-4,jours.\n\nObtenir Outlook pour Android \nSent: Thursday, May 5, 2022 12:25:08 PM\nTo: dvd-dev/hilo ***@***.***>\nCc: Fox350 ***@***.***>; Comment ***@***.***>\nSubject: Re: [dvd-dev/hilo] Incompatibilité Home Assistant 2022.5 (Issue #112)\n\ny a tu juste moi qui a ce bug là: dans HA SmartEnergyMeter Power 0w, dans l'app Hilo 0w, mais le total par heur dans l'app continu à monter. 🤨\n\n—\nReply to this email directly, view it on GitHub","author_login":"Fox350","author_association":"NONE","created_at":"2022-05-05T17:05:54+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[1218055088],"is_known_query_context":false},{"document_id":"gh_comment_1118845292","fragment_type":"issue_comment","sequence":14,"text":"J'avais aussi ce problème, je croyais à un problème Hilo, mais effectivement en rebootant la passerelle ca a fonctionné.","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-05T17:09:42+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118954629","fragment_type":"issue_comment","sequence":15,"text":"J'ai rien touché et c'est revenu. Mais la passerelle était verte et les données montaient quand même, donc elle devait être branché sur le compteur. Bizarre quand même 🤷🏻‍♂️","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-05T19:09:48+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1118959325","fragment_type":"issue_comment","sequence":16,"text":"C'est la faute à Jean Charest 😁\n\nObtenir Outlook pour Android \nSent: Thursday, May 5, 2022 3:09:59 PM\nTo: dvd-dev/hilo ***@***.***>\nCc: Fox350 ***@***.***>; Comment ***@***.***>\nSubject: Re: [dvd-dev/hilo] Incompatibilité Home Assistant 2022.5 (Issue #112)\n\nJ'ai rien touché et c'est revenu. Mais la passerelle était verte et les données montaient quand même, donc elle devait être branché sur le compteur. Bizarre quand même 🤷🏻‍♂️\n\n—\nReply to this email directly, view it on GitHub","author_login":"Fox350","author_association":"NONE","created_at":"2022-05-05T19:15:56+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[1218055088],"is_known_query_context":false},{"document_id":"gh_comment_1119003992","fragment_type":"issue_comment","sequence":17,"text":"J'ai un autre bug depuis que je suis à 2022.5, mes compteurs d'énergie ne se remplissent plus et je vois constamment cette erreur dans les logs: \n2022-05-05 16:11:02 WARNING (MainThread) [custom_components.hilo] check_tarif: Unable to find state for sensor.hilo_energy_total_daily_low","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-05T20:13:01+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1119080025","fragment_type":"issue_comment","sequence":18,"text":"C'est un peu poche ça que les update de HA brise des intégrations qui fonctionnaient :(","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-05T21:53:12+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1119082002","fragment_type":"issue_comment","sequence":19,"text":"Bah c'est un peu de ma faute, faudrait que je suive les updates de près mais j'ai pas le temps.\n\nEnsuite, c'est pas une intégration officielle, donc elle n'est pas testée. De plus, je n'ai pas écrit de functional et unit test. Par contre, je suis ouvert aux PR, si ça tente à quelqu'un.","author_login":"valleedelisle","author_association":"CONTRIBUTOR","created_at":"2022-05-05T21:56:29+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1119184225","fragment_type":"issue_comment","sequence":20,"text":"Moi j'ai dû changer tous mes energy sensors, mais je ne sais si j'ai remis me bon. Mes valeurs sont négatives. \n\nScreenshot_2022-05-05-21-27-54-26_c3a231c25ed346e59462e84656a70e50","author_login":"nickctn","author_association":"NONE","created_at":"2022-05-06T01:29:39+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120192749","fragment_type":"issue_comment","sequence":21,"text":"Bon finalement de mon côté j'ai réassocié manuellement mes energy meters dans les settings du dashboard energy car ca semblait lié à des trucs orphelins ou brisés (autant pour le compteur total que pour les devices individuels).. et avec le bout de code de la pull request ci-dessus, ca a réglé mon erreur (_check_tarif: Unable to find state for sensor.hilo_energy_total_daily_low_) et ca s'est remis à fonctionner correctement semblerait pour moi pour le moment.\n\nLes nouveaux compteurs non brisés sont ceux avec une petite icone à côté:\nimage","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-07T11:31:27+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1121171527","fragment_type":"issue_comment","sequence":22,"text":"@skimaniac moi aussi elles reviennent, pour le moment je les laisse là et les ignore...","author_login":"FrancoLoco","author_association":"COLLABORATOR","created_at":"2022-05-09T14:23:44+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1121176865","fragment_type":"issue_comment","sequence":23,"text":"Pour moi ça a arrêté de réapparaître après le 3e fois que je les ai enlevés.","author_login":"nickctn","author_association":"NONE","created_at":"2022-05-09T14:27:40+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1121177545","fragment_type":"issue_comment","sequence":24,"text":"@FrancoLoco je viens de voir dans la page des statistiques qu'elles apparaissent avec des erreurs, je vais les supprimer là aussi pour voir si ça corrige.\n\n<img width=\"1261\" alt=\"Capture d’écran, le 2022-05-09 à 10 26 18\" src=\" URL","author_login":"skimaniac","author_association":"NONE","created_at":"2022-05-09T14:28:11+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1123029547","fragment_type":"issue_comment","sequence":25,"text":"J'ai le même problème que toi ! Je viens tout juste d'installer cette intégration Hilo. Comment ça fonctionne pour réassocier manuellement mes energy meters ? Merci !","author_login":"gabdam","author_association":"NONE","created_at":"2022-05-11T00:05:48+08:00","repo_name":"dvd-dev/hilo","issue_id":1218055088,"issue_number":112,"issue_url":"https://github.com/dvd-dev/hilo/issues/112","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0219","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"IDE0251 error in error list has no title?","query_context":"_This issue has been moved from a ticket on Developer Community._\n\n[severity:It bothers me. A fix would be nice] I just opened my project and noticed in the Error List window I have two IDE0251 errors with no descriptions. If I click to go to the location of the error, I see code is fine. Also, the link to the documentation around that error seems to be broken, I get a 404 on it ( URL \n\n### Original Comments\n#### Feedback Bot on 3/16/2023, 05:46 PM:\n(private comment, text removed)\n\n#### Feedback Bot on 3/17/2023, 06:31 AM:\n(private comment, text removed)\n\n### Original Solutions\n(no solutions)","known_context_document_ids":["gh_issue_1682184961"],"reference_answer":"@DanTravison Apparently this was forgotten to be moved. I opened URL and will close this.","answer_document_id":"gh_comment_1520947345","silver_evidence_path":["gh_comment_1520947621","gh_issue_1644379241","gh_comment_1520947345"],"evidence_issue_ids":[1682184961,1644379241],"source_repo_name":"dotnet/roslyn","source_issue_id":1682184961,"source_issue_number":67949,"source_issue_url":"https://github.com/dotnet/roslyn/issues/67949","target_repo_name":"dotnet/roslyn-analyzers","target_issue_id":1644379241,"target_issue_number":6552,"target_issue_url":"https://github.com/dotnet/roslyn-analyzers/issues/6552","reference_anchor_document_id":"gh_comment_1520947621","reference_answer_author":"Youssef1313","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.5714,"anchor_target_overlap":0.5714,"target_answer_overlap":0.25},"issue_created_at":"2023-04-24T23:26:05+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1682184961","fragment_type":"issue_description","sequence":0,"text":"IDE0251 error in error list has no title\n_This issue has been moved from a ticket on Developer Community._\n\n[severity:It bothers me. A fix would be nice] I just opened my project and noticed in the Error List window I have two IDE0251 errors with no descriptions. If I click to go to the location of the error, I see code is fine. Also, the link to the documentation around that error seems to be broken, I get a 404 on it ( URL \n\n### Original Comments\n#### Feedback Bot on 3/16/2023, 05:46 PM:\n(private comment, text removed)\n\n#### Feedback Bot on 3/17/2023, 06:31 AM:\n(private comment, text removed)\n\n### Original Solutions\n(no solutions)","author_login":"Youssef1313","author_association":"MEMBER","created_at":"2023-04-24T23:26:05+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1520947621","fragment_type":"issue_comment","sequence":1,"text":"The original ticket was incorrectly moved to roslyn-analyzers repo URL","author_login":"Youssef1313","author_association":"MEMBER","created_at":"2023-04-24T23:27:04+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[1644379241],"is_known_query_context":false},{"document_id":"gh_comment_1522511958","fragment_type":"issue_comment","sequence":2,"text":"I saw a number of these with no description in my build and all were reporting for struct Properties with public get accessors . In all cases, the suggested fix is to make the member read-only. \n\nI tried refactoring to make the structure read-only which eliminated the warnings but implementation and usage becomes rather convoluted since the methods that normally updated the current instance in place now need to create a copy with the updated values. \n\nIs this an analyzer issue or am I missing something?\n\nThe project is configured with the following:\n true \n latest \n\nI'm building with Microsoft Visual Studio Community - Version 17.6.0 Preview 4.0\n\nI don't see these when I build with Microsoft Visual Studio Community - Version 17.5.4\n\nHere are a few examples:\n\npublic float X\n{\n get => _x; <--\n}\n\nget <--\n{\n return new PointF(_x, _y);\n}\n\npublic Color ToColor() <--\n{\n double chroma = Brightness * Saturation;\n double hue = Hue / 60;\n double x = chroma * (1 - Math.Abs((hue % 2) - 1));\n double m = Brightness - chroma;\n\n return HSLColor.ToColor(chroma, hue, x, m, Alpha);\n}","author_login":"DanTravison","author_association":"NONE","created_at":"2023-04-25T22:44:11+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1522553694","fragment_type":"issue_comment","sequence":3,"text":"@DanTravison can you update your code sample with \n` \n \n` markdown flags?","author_login":"CyrusNajmabadi","author_association":"CONTRIBUTOR","created_at":"2023-04-25T23:50:26+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1522554399","fragment_type":"issue_comment","sequence":4,"text":"Yes. Making the property readonly will help when calling it on a readonly instance of your struct. The compiler will now no longer have to copy the instance in that case as it can be sure that calling the property directly is safe (as it can't mutate the instance).","author_login":"CyrusNajmabadi","author_association":"CONTRIBUTOR","created_at":"2023-04-25T23:51:45+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1522607539","fragment_type":"issue_comment","sequence":5,"text":"I have few issues with the warning:\n1: The properties only have a get accessory. Isn't that, by definition, a readonly property? \n2: The underlying fields are explicitly declared as private. \nI don't see the reasoning behind adding readonly declaration to a read-only property. \n3: In one case, it is flagging a method that returns a value based on a calculation of a private field. I can't declare that read-only and the field cannot be declared readonly because it is used as an accumulator.","author_login":"DanTravison","author_association":"NONE","created_at":"2023-04-26T00:55:55+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1522639641","fragment_type":"issue_comment","sequence":6,"text":"Nope. Consider the following:\n\nc#\nint Prop { get { this.x++; return this.x; }\n\n \n\nThere's no cross symbol understanding. At the user site it has to assume the worst.\n \n\nTo ensure the compiler doesn't copy your structs when you access properties off of them if the instance is in a readonly location.\n \n\nWhy not? :) Looks fine to be made a readonly prop or method.","author_login":"CyrusNajmabadi","author_association":"CONTRIBUTOR","created_at":"2023-04-26T01:40:29+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1522642074","fragment_type":"issue_comment","sequence":7,"text":"That's a bug.\n \n\nAlso a bug. This issue tracks fixing those issues. I'm just trying to answer your personal questions about your scenario. :)","author_login":"CyrusNajmabadi","author_association":"CONTRIBUTOR","created_at":"2023-04-26T01:44:52+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523448260","fragment_type":"issue_comment","sequence":8,"text":"I must have missed that language change. Thanks for pointing that out.\n \n\nThis is what led to my confusion. When I see IDE0044 reported for class fields, I don't hesitate to use the guidance since the page clearly states why and I've confirmed it enough to trust the recommendation. With IDE0251, there is no explanation and I'm reluctant to make changes I don't understand.\n\nWith your explanation, it's obvious there's a case I didn't consider.\n\nThanks.","author_login":"DanTravison","author_association":"NONE","created_at":"2023-04-26T13:43:46+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1551271367","fragment_type":"issue_comment","sequence":9,"text":"cs\nrecord struct SomeRecord(int X)\n{\n // IDE0251: \n public bool Equals(CacheKey? other) => false;\n\n // IDE0251: \n public override int GetHashCode() => 0;\n}","author_login":"MaceWindu","author_association":"NONE","created_at":"2023-05-17T12:04:53+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1557208269","fragment_type":"issue_comment","sequence":10,"text":"I am affected by the same issue.\n\nUnity project\nVisual Studio Code 1.78.2\nC# for Visual Studio Code (powered by OmniSharp) 1.25.7\nMicrosoft.Unity.Analyzers 1.15.0\n\nEmpty text for IDE0251 in \"PROBLEMS\" window, see attached screenshot, caused by the following code:\n\npublic struct DummyStruct\n{\n public int DummyValue;\n\n // the \"get\" in the following line causes an IDE0251 notification\n public int GetDummyValue { get => DummyValue; set => DummyValue = value; }\n}\n\nIDE0251-empty-text","author_login":"PyrateAkananto","author_association":"NONE","created_at":"2023-05-22T13:18:00+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1565070576","fragment_type":"issue_comment","sequence":11,"text":"**REPRO:** I'm also getting the IDE0251 with no message, but no suggested fix after VS2022 upgrade to Version 17.6.2. This is the code fragment that's frowned upon (^^ mark the dotted underscores):\n\nc#\nrecord struct VoiceMarker(uint Start, uint Length) : IComparable {\n public uint End => Start + Length;\n// ^^\n public int CompareTo(VoiceMarker v) =>\n// ^^\n Comparer .Default.Compare(Start, v.Start); // Length is irrelevant.\n}\n\nThe project file is unremarkable:\n\nxml\n \n \n Exe \n net7.0 \n disable \n enable \n True \n False","author_login":"kkm000","author_association":"NONE","created_at":"2023-05-26T23:35:54+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1565070910","fragment_type":"issue_comment","sequence":12,"text":"To suppress the message, add to `.editorconfig`:\n\nini\n[*.cs]\n# URL \ndotnet_diagnostic.IDE0251.severity = none","author_login":"kkm000","author_association":"NONE","created_at":"2023-05-26T23:36:53+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1584226382","fragment_type":"issue_comment","sequence":13,"text":"Plus is emits the \"make it readonly\" for a property that **has a setter**. Making that one actually `readonly` surely makes IDE0251 go away, but gives \"CS1604 cannot set write protected field\" instead. \n\nTo me it looks pretty much as if the emitted IDE0251 is also incorrect in some cases ...","author_login":"Jens-G","author_association":"NONE","created_at":"2023-06-09T09:02:40+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646096655","fragment_type":"issue_comment","sequence":14,"text":"I think this was fixed by #67664, so it should be fixed in VS 17.7\nThe missing documentation page is tracked in dotnet/docs#30361","author_login":"cremor","author_association":"NONE","created_at":"2023-07-21T18:35:25+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1704554172","fragment_type":"issue_comment","sequence":15,"text":"Closing this out as the original issue reported here has been fixed with #67664. If there are any additional functional issues with this rule, kindly file separate issues. Thanks!","author_login":"mavasani","author_association":"CONTRIBUTOR","created_at":"2023-09-04T03:20:18+08:00","repo_name":"dotnet/roslyn","issue_id":1682184961,"issue_number":67949,"issue_url":"https://github.com/dotnet/roslyn/issues/67949","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1644379241","fragment_type":"issue_description","sequence":0,"text":"IDE0251 error in error list has no description\n_This issue has been moved from a ticket on Developer Community._\n\n---\n[severity:It bothers me. A fix would be nice]\nI just opened my project and noticed in the Error List window I have two IDE0251 errors with no descriptions. If I click to go to the location of the error, I see code is fine. Also, the link to the documentation around that error seems to be broken, I get a 404 on it ( URL \n\n---\n### Original Comments\n\n#### Feedback Bot on 3/16/2023, 05:46 PM: \n\n(private comment, text removed)\n#### Feedback Bot on 3/17/2023, 06:31 AM: \n\n(private comment, text removed)\n\n---\n### Original Solutions\n(no solutions)","author_login":"vsfeedback","author_association":"NONE","created_at":"2023-03-28T17:25:51+08:00","repo_name":"dotnet/roslyn-analyzers","issue_id":1644379241,"issue_number":6552,"issue_url":"https://github.com/dotnet/roslyn-analyzers/issues/6552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1491527919","fragment_type":"issue_comment","sequence":1,"text":"@CyrusNajmabadi I think this was unintentionally moved to this repo. It belongs to dotnet/roslyn.","author_login":"Youssef1313","author_association":"MEMBER","created_at":"2023-03-31T08:32:21+08:00","repo_name":"dotnet/roslyn-analyzers","issue_id":1644379241,"issue_number":6552,"issue_url":"https://github.com/dotnet/roslyn-analyzers/issues/6552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1520936764","fragment_type":"issue_comment","sequence":2,"text":"Is there a link to the issue in dotnet/Roslyn? I can't find it.","author_login":"DanTravison","author_association":"NONE","created_at":"2023-04-24T23:08:57+08:00","repo_name":"dotnet/roslyn-analyzers","issue_id":1644379241,"issue_number":6552,"issue_url":"https://github.com/dotnet/roslyn-analyzers/issues/6552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1520947345","fragment_type":"issue_comment","sequence":3,"text":"@DanTravison Apparently this was forgotten to be moved. I opened URL and will close this.","author_login":"Youssef1313","author_association":"MEMBER","created_at":"2023-04-24T23:26:33+08:00","repo_name":"dotnet/roslyn-analyzers","issue_id":1644379241,"issue_number":6552,"issue_url":"https://github.com/dotnet/roslyn-analyzers/issues/6552","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0220","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Migrated] #167: Add Dockerfiles, plain Docker deployment instructions and minor fixes?","query_context":"**Original Pull Request #167**\n**Original Author:** @discordianfish\n**Created:** 2014-06-19 12:52:56 UTC\n**Updated:** 2014-08-12 20:25:13 UTC\n**Closed:** 2014-08-12 20:25:13 UTC\n**PR State:** closed\n**Merged:** No\n**Base Branch:** master\n**Head Branch:** various-fixes\n**Commits:** 4\n**Changed Files:** 10\n**Additions:** +106\n**Deletions:** -18\n\n**Note:** This was originally a Pull Request. The code changes are preserved in the forked repository's branches.\n\n---\n\nHi,\n\nI've put all this in one PR, hope that's okay. It's basically what I had to change to get it working in my everything-is-dockerized environment.\nI've tried to come up with \"good commits\". Let me know if you prefer single PRs for each of them.\n\nSo the idea here is to run kubernetes itself in Docker containers, therefor I created three Dockerfiles. The documentation assumes that this will be added as automated builds in the Google account. Guess that's up for discussion so let me know if I should change that.\nThe Dockerfile in / will create a kubernetes 'base image' which just includes the code/binaries and is used by kubernetes-node and kubernetes-server. This might not fit all all deployments but it's a good start and easy to understand.\nTo make this possible I added a `-docker` flag to point to the docker address (since with the bind-mount we can't use /var/run/docker.sock in the container). Beside that I made kubelet use the client lib for pulling the image instead of the binary (which isn't installed in the container).","known_context_document_ids":["gh_issue_3291755480"],"reference_answer":"**Original comment by @proppy**\n**Posted:** 2014-06-14 17:11:39 UTC\n\n---\n\nNote of you just want to have a container to build the projects and get\nbinaries out.\n\nYou can also set the ENTRYPOINT to the build command.\n\ndocker build ; docker run # to build\ndocker cp # to get the file out of the container\nOn Jun 14, 2014 10:00 AM, \"Johan Euphrosine\" proppy@google.com wrote:","answer_document_id":"gh_comment_3153174964","silver_evidence_path":["gh_comment_3153654452","gh_issue_3291447575","gh_comment_3153174964"],"evidence_issue_ids":[3291755480,3291447575],"source_repo_name":"adamzwickey/kubernetes","source_issue_id":3291755480,"source_issue_number":168,"source_issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","target_repo_name":"adamzwickey/kubernetes","target_issue_id":3291447575,"target_issue_number":19,"target_issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","reference_anchor_document_id":"gh_comment_3153654452","reference_answer_author":"adamzwickey","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3333,"anchor_target_overlap":0.8333,"target_answer_overlap":0.2174},"issue_created_at":"2025-08-05T06:23:53+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_3291755480","fragment_type":"issue_description","sequence":0,"text":"[Migrated] #167: Add Dockerfiles, plain Docker deployment instructions and minor fixes\n**Original Pull Request #167**\n**Original Author:** @discordianfish\n**Created:** 2014-06-19 12:52:56 UTC\n**Updated:** 2014-08-12 20:25:13 UTC\n**Closed:** 2014-08-12 20:25:13 UTC\n**PR State:** closed\n**Merged:** No\n**Base Branch:** master\n**Head Branch:** various-fixes\n**Commits:** 4\n**Changed Files:** 10\n**Additions:** +106\n**Deletions:** -18\n\n**Note:** This was originally a Pull Request. The code changes are preserved in the forked repository's branches.\n\n---\n\nHi,\n\nI've put all this in one PR, hope that's okay. It's basically what I had to change to get it working in my everything-is-dockerized environment.\nI've tried to come up with \"good commits\". Let me know if you prefer single PRs for each of them.\n\nSo the idea here is to run kubernetes itself in Docker containers, therefor I created three Dockerfiles. The documentation assumes that this will be added as automated builds in the Google account. Guess that's up for discussion so let me know if I should change that.\nThe Dockerfile in / will create a kubernetes 'base image' which just includes the code/binaries and is used by kubernetes-node and kubernetes-server. This might not fit all all deployments but it's a good start and easy to understand.\nTo make this possible I added a `-docker` flag to point to the docker address (since with the bind-mount we can't use /var/run/docker.sock in the container). Beside that I made kubelet use the client lib for pulling the image instead of the binary (which isn't installed in the container).","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:23:53+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3153654369","fragment_type":"issue_comment","sequence":1,"text":"**Original comment by @brendanburns**\n**Posted:** 2014-06-19 15:48:14 UTC\n\n---\n\nAwesome! Thanks for doing this. I'll take a detailed look today. In the\nmeantime, can you sign our CLA?\n\nInstructions are in CONTRIB.md. It's basically identical to the Apache CLA\n\nThanks again.\nBrendan\n\nOn Thu, Jun 19, 2014, 5:53 AM, discordianfish notifications@github.com\nwrote:","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:23:56+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153654452","fragment_type":"issue_comment","sequence":2,"text":"**Original comment by @proppy**\n**Posted:** 2014-06-19 15:54:29 UTC\n\n---\n\nRelated: #19 and #141","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:23:57+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[3291447575],"is_known_query_context":false},{"document_id":"gh_comment_3153654716","fragment_type":"issue_comment","sequence":3,"text":"**Original comment by @discordianfish**\n**Posted:** 2014-06-19 17:24:53 UTC\n\n---\n\n(I've just moved cdd6b3c back in here so this branch can be built/used)","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:24:02+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153654803","fragment_type":"issue_comment","sequence":4,"text":"**Original comment by @brendandburns**\n**Posted:** 2014-06-30 19:10:04 UTC\n\n---\n\nWe got your CLA today.\n\nAny chance you can extract the Docker API calls for Image Pulling (rather than shelling out) into a separate PR?\n\nMany thanks!\n--brendan","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:24:03+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153654883","fragment_type":"issue_comment","sequence":5,"text":"**Original comment by @discordianfish**\n**Posted:** 2014-07-03 12:05:21 UTC\n\n---\n\nOK, I've created #351","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:24:05+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153655030","fragment_type":"issue_comment","sequence":6,"text":"**Original comment by @discordianfish**\n**Posted:** 2014-07-08 17:24:34 UTC\n\n---\n\nDo you guys have interest in anything else from this PR? I still would like to see a easy way to deploy kubernetes as docker images itself. Happy to help if you have concrete suggestions.","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:24:08+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153655209","fragment_type":"issue_comment","sequence":7,"text":"**Original comment by @brendandburns**\n**Posted:** 2014-07-14 14:42:48 UTC\n\n---\n\nKelsey,\nHave a look at the contents of the './build' directory, that does exactly\nwhat you suggest.\n\nIt would be great to centralize on on version of this stuff.\n\nBrendan\nOn Jul 14, 2014 7:29 AM, \"Kelsey Hightower\" notifications@github.com\nwrote:","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:24:11+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153655450","fragment_type":"issue_comment","sequence":8,"text":"**Original comment by @brendandburns**\n**Posted:** 2014-08-12 20:25:13 UTC\n\n---\n\nclosing this now, since its a little out of date at this point, and the docker pull stuff was integrated in a different PR.","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T06:24:16+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291755480,"issue_number":168,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/168","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3291447575","fragment_type":"issue_description","sequence":0,"text":"[Migrated] #19: Use Docker to host most server components\n**Original Issue #19**\n**Original Author:** @jbeda\n**Created:** 2014-06-08 05:36:00 UTC\n**Updated:** 2019-03-24 07:15:34 UTC\n**Closed:** 2016-03-19 19:37:36 UTC\n\n---\n\nRight now we use salt to distribute and start most of the server components for the cluster. \n\nInstead, we should do the following:\n- [x] Only support building on a linux machine with docker installed. Perhaps support local development on a mac with a local linux VM\n- [ ] Package each server component up as a Docker image, built with a Dockerfile\n - [ ] Support uploading these Docker images to either the public index or a GCS backed index with google/docker-registry. Or GCR?\n - [ ] Minimize docker image size by switching to single layer static golang binary docker images.\n - [ ] Support `docker save` to generate tars of the docker image(s) for dev/private development.\n- [ ] Use the kubelet to run/health check the components. This means the kubelet will manage a set of static tasks on each machine (including the master) and a set of dynamic tasks.\n- [ ] The only task that shouldn't run under the docker should be the kubelet itself. We may have to hack in something for (network mode = host) for the proxy.","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:50:44+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174485","fragment_type":"issue_comment","sequence":1,"text":"**Original comment by @proppy**\n**Posted:** 2014-06-08 06:04:40 UTC\n\n---\n\nOn Sat, Jun 7, 2014 at 10:35 PM, Joe Beda notifications@github.com wrote:\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n## \n\nJohan Euphrosine (proppy)\nDeveloper Programs Engineer\nGoogle Developer Relations","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:50:47+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174528","fragment_type":"issue_comment","sequence":2,"text":"**Original comment by @monnand**\n**Posted:** 2014-06-11 06:07:14 UTC\n\n---\n\nI have some questions just out of curious:\n- Does it mean that salt will not be used in the future?\n- About kubenetes docker containers, does it only contain compiled binary files, or contain source code? More precisely, are you going to put build process into the Dockerfile?\n\nThank you!","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:50:48+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174568","fragment_type":"issue_comment","sequence":3,"text":"**Original comment by @jbeda**\n**Posted:** 2014-06-11 17:24:17 UTC\n\n---\n\n@monnand I imagine that we will continue to use salt to bootstrap stuff. But we'll be able to reduce some of the more complex salt config.\n\nFor example, we currently ship and compile the source everywhere where it is run. If we start building docker images, we can precompile the binaries before they are run.\n\nI'm thinking that we'll follow the example of Docker itself and do the build process in docker containers. This, with boot2docker, could lead to a good dev flow for Mac OS X.","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:50:50+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174711","fragment_type":"issue_comment","sequence":4,"text":"**Original comment by @monnand**\n**Posted:** 2014-06-11 23:03:35 UTC\n\n---\n\n@jbeda Correct me if I'm wrong. (I'm not saying that kubelet should run inside a docker container. I'm just trying to see what are the technical difficulties here.)\n\nAs far as I know, kubelet only needs to communicate with docker through docker remote api, which is either trhough a unix socket or a remote IP/port pair. Does it need to read/write cgroup's filesystem? In either case, it seems that we could mount the /var/run onto the container and run kubelet inside that containers.\n\nWe are currently doing this in cadvisor, which runs inside a docker container but can communicate with docker daemon and read information from the cgroup filesystem. The container could still run inside its own namespace, but communicate with docker daemon through the mounted volume. We use the following command to run cadvisor inside a docker container:\n\nsudo docker run \\\n --volume=/var/run:/var/run:rw \\\n --volume=/sys/fs/cgroup/:/sys/fs/cgroup:ro \\\n --volume=/var/lib/docker/:/var/lib/docker:ro \\\n --publish=8080:8080 \\\n --detach=true \\\n google/cadvisor","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:50:55+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174801","fragment_type":"issue_comment","sequence":5,"text":"**Original comment by @brendanburns**\n**Posted:** 2014-06-11 23:49:19 UTC\n\n---\n\nThere was just a discussion of this in the plumbers meeting. The union bay\nnetworks folks want the ability to muck with the network from a container\ntoo.\n\nBrendan\nOn Jun 11, 2014 4:33 PM, \"Joe Beda\" notifications@github.com wrote:","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:50:57+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174895","fragment_type":"issue_comment","sequence":6,"text":"**Original comment by @jbeda**\n**Posted:** 2014-06-14 15:48:42 UTC\n\n---\n\nNotes of work in progress:\n- I'm starting out by moving our build process into Docker. A snapshot of a Dockerfile and a Makefile to automate some common stuff is here: URL \n- If we say everyone has to build on Linux, this is much easier. With the boot2docker on a Mac, you essentially have a remote machine that you are talking to through a local TCP pipe. That means with any `-v local-path:container-path` the `local-path` is really local to the boot2docker VM and not the local workstation.\n\nThis leaves us with 2 choices:\n1. Build in the boot2docker VM and copy results back out, either through stdout from the docker run or via `boot2docker ssh`\n2. Build the final docker images inside the boot2docker VM inside of a docker container. Yup, this means running docker in docker. This is supported with `dind` but it gets complicated. There is a repo ( URL with support but...\n - There is no license in that repo. Issue: URL \n - The Docker build process itself uses dind but has a forked script checked in to the Docker repo. These have diverged and I worry about continued support for the separate dind repo. Issue to harmonize these: URL \n\nRight now I'm leaning toward copying stuff in and out (option 1).","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:02+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174927","fragment_type":"issue_comment","sequence":7,"text":"**Original comment by @proppy**\n**Posted:** 2014-06-14 17:00:57 UTC\n\n---\n\nYou could have Dockerfile for individual binaries and have the resulting\ncontainer image launch it has its ENTRYPOINT.\n\nThat way you could leverage the fact sources are sent from your workstation\nto the VM as the /build payload (context) over the remote API (no need to\ncopy to the host) and the docker image is your artefact.\nOn Jun 14, 2014 8:48 AM, \"Joe Beda\" notifications@github.com wrote:","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:04+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153174964","fragment_type":"issue_comment","sequence":8,"text":"**Original comment by @proppy**\n**Posted:** 2014-06-14 17:11:39 UTC\n\n---\n\nNote of you just want to have a container to build the projects and get\nbinaries out.\n\nYou can also set the ENTRYPOINT to the build command.\n\ndocker build ; docker run # to build\ndocker cp # to get the file out of the container\nOn Jun 14, 2014 10:00 AM, \"Johan Euphrosine\" proppy@google.com wrote:","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:05+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153175065","fragment_type":"issue_comment","sequence":9,"text":"**Original comment by @proppy**\n**Posted:** 2014-06-15 01:47:44 UTC\n\n---\n\nFYI, I have a pending patch to docker that could provide an hacky\nalternative.\n URL \n\nThis would allow something like\n\ndocker build -t builder ; (docker run builder | docker build -t runner -)\n\nOn Jun 14, 2014 2:52 PM, \"Joe Beda\" notifications@github.com wrote:","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:10+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153175097","fragment_type":"issue_comment","sequence":10,"text":"**Original comment by @saad-ali**\n**Posted:** 2015-01-17 00:07:16 UTC\n\n---\n\nCC: @saad-ali","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:12+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153175124","fragment_type":"issue_comment","sequence":11,"text":"**Original comment by @bgrant0607**\n**Posted:** 2015-03-10 19:18:03 UTC\n\n---\n\nSee also #5011.","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:14+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153175174","fragment_type":"issue_comment","sequence":12,"text":"**Original comment by @errordeveloper**\n**Posted:** 2016-03-16 09:41:48 UTC\n\n---\n\nIsn't this mostly done already?","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:16+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3153175258","fragment_type":"issue_comment","sequence":13,"text":"**Original comment by @maicohjf**\n**Posted:** 2019-03-24 07:15:34 UTC\n\n---\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\n15.\nCheck to see how many nodes are ready (not including nodes tainted NoSchedule) and write the\nnumber to /opt/......\n\n首先用kubectl get node 查看总共node 数量，然后kubectl describe node 查看\n不包含污点值为NoSchedule 的node 数量\n\n16. \nFrom the Pod label name=cpu-utilizer, find pods running high CPU workloads and write the name\nof the Pod consuming most CPU to the file /opt/...... (which already exists)\n\n方法一：\n通过kubectl get pod -l name=cpu-utilizer -o wide 查看pod 所在的node\n之后kubectl describe node 查看哪个pod 请求的cpu 最多\n三个都是0，我就都写进去了\n方法二：\nkubectl top pod -l name=cpu-utilizer","author_login":"adamzwickey","author_association":"OWNER","created_at":"2025-08-05T03:51:19+08:00","repo_name":"adamzwickey/kubernetes","issue_id":3291447575,"issue_number":19,"issue_url":"https://github.com/adamzwickey/kubernetes/issues/19","linked_issue_ids":[3291447575],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0221","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"curl exited with code '6'?","query_context":"Hi antlafarge,\n\nI have tried to run your jdownloader container on a Raspi 4 with Bookworm arm64. Unfortunately the container does not come up. The Logfile says:\n\n2023-11-08T20:51:15+00:00| ________________________________________ CONTAINER STARTED _________________________________________\n2023-11-08T20:51:15+00:00| OS = \"Ubuntu 22.04.3 LTS\"\n2023-11-08T20:51:15+00:00| JAVA version = \"openjdk-17-jre-headless:arm64 17.0.8.1+1~us1-0ubuntu1~22.04\"\n2023-11-08T20:51:15+00:00| JAVA options = \"\"\n2023-11-08T20:51:15+00:00| Delete any existing JDownloader installation files\n2023-11-08T20:51:15+00:00| Download URL \n2023-11-08T20:51:31+00:00| JDownloader.jar download failed: curl exited with code '6'\n2023-11-08T20:51:31+00:00| Download URL \n2023-11-08T20:51:47+00:00| FATAL ERROR JDownloader.jar download failed: curl exited with code '6'\n2023-11-08T20:51:47+00:00| Get more informations here : URL \n2023-11-08T20:51:47+00:00| ________________________________________ CONTAINER EXITED __________________________________________\n\nI tried manually downloading JDownloader.jar on my network using the browser. It is working. Do you have any idea how to solve the problem?","known_context_document_ids":["gh_issue_1984392933"],"reference_answer":"Maybe you have some privileges issues with this docker host? Maybe try the `--privileged` flag ? URL","answer_document_id":"gh_comment_1730344023","silver_evidence_path":["gh_comment_1803107857","gh_issue_1905335251","gh_comment_1730344023"],"evidence_issue_ids":[1984392933,1905335251],"source_repo_name":"antlafarge/jdownloader","source_issue_id":1984392933,"source_issue_number":37,"source_issue_url":"https://github.com/antlafarge/jdownloader/issues/37","target_repo_name":"antlafarge/jdownloader","target_issue_id":1905335251,"target_issue_number":36,"target_issue_url":"https://github.com/antlafarge/jdownloader/issues/36","reference_anchor_document_id":"gh_comment_1803107857","reference_answer_author":"antlafarge","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1579,"anchor_target_overlap":0.1579,"target_answer_overlap":0.1},"issue_created_at":"2023-11-08T21:01:55+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1984392933","fragment_type":"issue_description","sequence":0,"text":"curl exited with code '6'\nHi antlafarge,\n\nI have tried to run your jdownloader container on a Raspi 4 with Bookworm arm64. Unfortunately the container does not come up. The Logfile says:\n\n2023-11-08T20:51:15+00:00| ________________________________________ CONTAINER STARTED _________________________________________\n2023-11-08T20:51:15+00:00| OS = \"Ubuntu 22.04.3 LTS\"\n2023-11-08T20:51:15+00:00| JAVA version = \"openjdk-17-jre-headless:arm64 17.0.8.1+1~us1-0ubuntu1~22.04\"\n2023-11-08T20:51:15+00:00| JAVA options = \"\"\n2023-11-08T20:51:15+00:00| Delete any existing JDownloader installation files\n2023-11-08T20:51:15+00:00| Download URL \n2023-11-08T20:51:31+00:00| JDownloader.jar download failed: curl exited with code '6'\n2023-11-08T20:51:31+00:00| Download URL \n2023-11-08T20:51:47+00:00| FATAL ERROR JDownloader.jar download failed: curl exited with code '6'\n2023-11-08T20:51:47+00:00| Get more informations here : URL \n2023-11-08T20:51:47+00:00| ________________________________________ CONTAINER EXITED __________________________________________\n\nI tried manually downloading JDownloader.jar on my network using the browser. It is working. Do you have any idea how to solve the problem?","author_login":"firewiremb","author_association":"NONE","created_at":"2023-11-08T21:01:55+08:00","repo_name":"antlafarge/jdownloader","issue_id":1984392933,"issue_number":37,"issue_url":"https://github.com/antlafarge/jdownloader/issues/37","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1803107857","fragment_type":"issue_comment","sequence":1,"text":"Hello,\nMany users reported me this problem for a long time, and most of the time there is a problem for the container to access to the DNS servers, and it's related to a misconfiguration or a bug in their docker installation.\nLook at this : URL","author_login":"antlafarge","author_association":"OWNER","created_at":"2023-11-09T03:30:09+08:00","repo_name":"antlafarge/jdownloader","issue_id":1984392933,"issue_number":37,"issue_url":"https://github.com/antlafarge/jdownloader/issues/37","linked_issue_ids":[1905335251],"is_known_query_context":false},{"document_id":"gh_comment_1806535998","fragment_type":"issue_comment","sequence":2,"text":"Hello,\nthank you very much for your help and information. I have now solved the problem by including the IP of a name server in the docker-compose.yml:\n\n jdownloader:\n image: antlafarge/jdownloader:latest\n container_name: jdownloader \n restart: on-failure:10\n hostname: jdownloader_dock\n dns: 8.8.8.8\n\nIt is working. :-)","author_login":"firewiremb","author_association":"NONE","created_at":"2023-11-10T22:54:32+08:00","repo_name":"antlafarge/jdownloader","issue_id":1984392933,"issue_number":37,"issue_url":"https://github.com/antlafarge/jdownloader/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1905335251","fragment_type":"issue_description","sequence":0,"text":"Fatal Error during Download\nAfter the Update to the latest version from 18.09.2023 i got the following error:\n\n2023-09-20T16:18:42+00:00| ________________________________________ CONTAINER STARTED _________________________________________\n2023-09-20T16:18:42+00:00| OS = \"Ubuntu 22.04.3 LTS\"\n./docker-entrypoint.sh: line 37: ii: command not found\n./docker-entrypoint.sh: line 37: ii: command not found\n2023-09-20T16:18:42+00:00| JAVA version = \" \"\n2023-09-20T16:18:42+00:00| JAVA options = \"\"\n2023-09-20T16:18:42+00:00| Delete any existing JDownloader installation files\n2023-09-20T16:18:42+00:00| Download URL \n2023-09-20T16:18:58+00:00| JDownloader.jar download failed: curl exited with code '6'\n2023-09-20T16:18:58+00:00| Download URL \n2023-09-20T16:19:14+00:00| FATAL ERROR JDownloader.jar download failed: curl exited with code '6'\n2023-09-20T16:19:14+00:00| Get more informations here : URL \n2023-09-20T16:19:14+00:00| ________________________________________ CONTAINER EXITED __________________________________________","author_login":"faro2023","author_association":"NONE","created_at":"2023-09-20T16:20:22+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1728874456","fragment_type":"issue_comment","sequence":1,"text":"Partial. I tried it on another Docker host, no problems here. Where the problems occur, I was able to remedy the situation by setting the network mode to host. In bridge mode it can not download the jdownloader.jar. I don't understand why. Other containers on the same host can access the internet in bridge mode without problems.\nI have completely removed the container and rebuilt it, always without success. only the network host mode works.","author_login":"faro2023","author_association":"NONE","created_at":"2023-09-21T05:24:49+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1730344023","fragment_type":"issue_comment","sequence":2,"text":"Maybe you have some privileges issues with this docker host? Maybe try the `--privileged` flag ? URL","author_login":"antlafarge","author_association":"OWNER","created_at":"2023-09-21T21:46:35+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1730806056","fragment_type":"issue_comment","sequence":3,"text":"its not an arm, its an i5 proxmox host with vm ubuntu 22.xx -> docker -> jdown\n\nthe privileged mode doesnt work. only the network host mode works for the moment","author_login":"faro2023","author_association":"NONE","created_at":"2023-09-22T05:04:36+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1732569057","fragment_type":"issue_comment","sequence":4,"text":"Or maybe a bug with m'y new release i will do some checks this night","author_login":"antlafarge","author_association":"OWNER","created_at":"2023-09-24T13:19:19+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1732733891","fragment_type":"issue_comment","sequence":5,"text":"I just want to notice I just fixed the logs with a new release","author_login":"antlafarge","author_association":"OWNER","created_at":"2023-09-25T00:49:44+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1733087542","fragment_type":"issue_comment","sequence":6,"text":"i try, but the same result, i pull the new releases, same error with latest and alpine.\nwhat i say, it works on this docker host until 1 wekk. my watchtower pull an update last week after this i have to use the netwprk host mode to run","author_login":"faro2023","author_association":"NONE","created_at":"2023-09-25T07:36:57+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1734430762","fragment_type":"issue_comment","sequence":7,"text":"I didn't change anything in network.\nMaybe a bug in this docker host or in the lastest alpine and ubuntu images I use to build this new releases?","author_login":"antlafarge","author_association":"OWNER","created_at":"2023-09-25T20:39:36+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1734952686","fragment_type":"issue_comment","sequence":8,"text":"first again many thanks to your support. i can't understand it yet, but i have redone the whole configuration of the docker with regard to ip and dns. now it works. what i don't understand is why the network host mode worked. i have in another docker pihole with unbound running, that also works great. only as soon as container wanted to access \"internally\" i.e. jdown -> pihole it came to problems. a reconfiguration helped. although in the end the settings are the same. it's currently inexplicable to me. have in any case many thanks","author_login":"faro2023","author_association":"NONE","created_at":"2023-09-26T07:07:55+08:00","repo_name":"antlafarge/jdownloader","issue_id":1905335251,"issue_number":36,"issue_url":"https://github.com/antlafarge/jdownloader/issues/36","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0222","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"The 1k context limit in Open-WebUI request is causing low-quality responses.","query_context":"### What is the issue?\n\nWhen using open-webui, I've noticed that long contextual messages sent to ollama consistently result in poor responses. After investigating the issue, it appears that the `/api/chat` and `/v1/chat/completions` endpoints are defaulting to a 1k context limit. This means that when the content exceeds this length, the system automatically discards the earlier portions, leading to subpar answers. What follows is the captured network request data for open-webui version 0.3.8.\n\ncurl ' URL \\\n-X POST \\\n-H 'Host: localhost:11434' \\\n-H 'Accept: */*' \\\n-H 'User-Agent: Python/3.11 aiohttp/3.9.5' \\\n-H 'Content-Type: text/plain; charset=utf-8' \\\n--data-raw '{\"model\": \"qwen1_5-4b-chat-q4_k_m\", \"messages\": [{\"role\": \"user\", \"content\": \" \"}], \"options\": {}, \"stream\": true}' \n\nBased on the final response, we can observe that the prompt_eval_count is 1026, which indicates that only approximately 1,000 tokens of context were processed. \n\n{\"role\":\"assistant\",\"content\":\"\"},\"done_reason\":\"stop\",\"done\":true,\"total_duration\":9987503333,\"load_duration\":28999667,\"prompt_eval_count\":1026,\"prompt_eval_duration\":1896469000,\"eval_count\":238,\"eval_duration\":8059779000}\n\nI'm uncertain whether I should submit an issue about this bug to the open-webui repository.\n\n### OS\n\nmacOS\n\n### GPU\n\nApple\n\n### CPU\n\nApple\n\n### Ollama version\n\n0.3.0","known_context_document_ids":["gh_issue_2433920762"],"reference_answer":"It should be noted that changing the context size of a model via the Modelfile is mentioned, but in the OpenAI doc , not the FAQ.","answer_document_id":"gh_comment_2503474699","silver_evidence_path":["gh_comment_2271443664","gh_issue_2431255789","gh_comment_2503474699"],"evidence_issue_ids":[2433920762,2431255789],"source_repo_name":"ollama/ollama","source_issue_id":2433920762,"source_issue_number":6026,"source_issue_url":"https://github.com/ollama/ollama/issues/6026","target_repo_name":"ollama/ollama","target_issue_id":2431255789,"target_issue_number":5965,"target_issue_url":"https://github.com/ollama/ollama/issues/5965","reference_anchor_document_id":"gh_comment_2271443664","reference_answer_author":"rick-github","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1852,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1818},"issue_created_at":"2024-07-28T12:57:42+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2433920762","fragment_type":"issue_description","sequence":0,"text":"The 1k context limit in Open-WebUI request is causing low-quality responses.\n### What is the issue?\n\nWhen using open-webui, I've noticed that long contextual messages sent to ollama consistently result in poor responses. After investigating the issue, it appears that the `/api/chat` and `/v1/chat/completions` endpoints are defaulting to a 1k context limit. This means that when the content exceeds this length, the system automatically discards the earlier portions, leading to subpar answers. What follows is the captured network request data for open-webui version 0.3.8.\n\ncurl ' URL \\\n-X POST \\\n-H 'Host: localhost:11434' \\\n-H 'Accept: */*' \\\n-H 'User-Agent: Python/3.11 aiohttp/3.9.5' \\\n-H 'Content-Type: text/plain; charset=utf-8' \\\n--data-raw '{\"model\": \"qwen1_5-4b-chat-q4_k_m\", \"messages\": [{\"role\": \"user\", \"content\": \" \"}], \"options\": {}, \"stream\": true}' \n\nBased on the final response, we can observe that the prompt_eval_count is 1026, which indicates that only approximately 1,000 tokens of context were processed. \n\n{\"role\":\"assistant\",\"content\":\"\"},\"done_reason\":\"stop\",\"done\":true,\"total_duration\":9987503333,\"load_duration\":28999667,\"prompt_eval_count\":1026,\"prompt_eval_duration\":1896469000,\"eval_count\":238,\"eval_duration\":8059779000}\n\nI'm uncertain whether I should submit an issue about this bug to the open-webui repository.\n\n### OS\n\nmacOS\n\n### GPU\n\nApple\n\n### CPU\n\nApple\n\n### Ollama version\n\n0.3.0","author_login":"anrgct","author_association":"NONE","created_at":"2024-07-28T12:57:42+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2254555930","fragment_type":"issue_comment","sequence":1,"text":"You also set a context length for a model in open-webui. Go to Workspace > Models > Create a model, choose the base model, scroll down to Model Params and under Advanced Params, set the context length.","author_login":"rick-github","author_association":"NONE","created_at":"2024-07-28T15:26:00+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2254565806","fragment_type":"issue_comment","sequence":2,"text":"Thank you for your response! I've also discovered another bug. When I add \"options\": {\"num_ctx\": 32000} to the `/v1/chat/completions` endpoint, it doesn't take effect and the context length remains at 1k. This option works correctly on the `/api/chat` and `/api/generate endpoints`.","author_login":"anrgct","author_association":"NONE","created_at":"2024-07-28T16:01:02+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2254569646","fragment_type":"issue_comment","sequence":3,"text":"Probably because the OpenAI API doesn't support specifying the context window, just `max_tokens`. So yes, that would be an appropriate feature request for ollama.","author_login":"rick-github","author_association":"NONE","created_at":"2024-07-28T16:13:57+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2255847161","fragment_type":"issue_comment","sequence":4,"text":"A bit more information is needed. If you supply a server log (`docker logs `) it can be checked for truncation messages. It would also be useful to see the actual HTTP request that open-webui is sending. Unfortunately that's not logged, so a tool needs to be installed to capture that:\n\n$ docker exec -it apt install -y tcpflow\n$ docker exec -it tcpflow -c 'src port 11434 or dst port 11434' > ollama-open-webui.log\n\nRun this, use open-webui for a long context conversation, ^C tcpflow, remove any PII from the log, and add it here.","author_login":"rick-github","author_association":"NONE","created_at":"2024-07-29T12:50:11+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2271443664","fragment_type":"issue_comment","sequence":5,"text":"@chris-31337 , \"prompt_eval_count\" refers to the actual length of the processed prompt, which is 934 in your ollama-open-webui.log, meaning only the last 934 tokens were used as the prompt. Didn't you modify the modelfile as suggested? It worked for me after I made the changes. Also, is this screenshot from openwebui? I haven't seen this option before.","author_login":"anrgct","author_association":"NONE","created_at":"2024-08-06T14:31:27+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[2431255789],"is_known_query_context":false},{"document_id":"gh_comment_2271475869","fragment_type":"issue_comment","sequence":6,"text":"From ollama-docker.log:\n\nINFO [update_slots] input truncated | n_ctx=2048 n_erase=19335 n_keep=4 n_left=2044 n_shift=1022 tid=\"133210613727232\" timestamp=1722942601\n\nFrom ollama-open-webui.log:\n\nhave ever known.\"}],\"options\":{},\"keep_alive\":\"15m\",\"sess\n\nThere's no `num_ctx` in the `options` field, so the input text of ~21k tokens is being whittled down to 2048 by throwing away 19335 of them. What version of open-webui are you using? I'll fire up a docker container with it and see if I can replicate.","author_login":"rick-github","author_association":"CONTRIBUTOR","created_at":"2024-08-06T14:45:39+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2277915109","fragment_type":"issue_comment","sequence":7,"text":"I just discovered this setting in open-webui. My version is v0.3.11, and it's actually working. I had no idea about it before... @chris-31337\n1723208848023","author_login":"anrgct","author_association":"NONE","created_at":"2024-08-09T13:11:23+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2280629841","fragment_type":"issue_comment","sequence":8,"text":"@anrgct interesting issue. As it is solved. Could you please close it to reduce the number of open issues?","author_login":"igorschlum","author_association":"NONE","created_at":"2024-08-10T09:36:25+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2282189032","fragment_type":"issue_comment","sequence":9,"text":"Thank you for your patient replies! @igorschlum @rick-github","author_login":"anrgct","author_association":"NONE","created_at":"2024-08-10T15:38:44+08:00","repo_name":"ollama/ollama","issue_id":2433920762,"issue_number":6026,"issue_url":"https://github.com/ollama/ollama/issues/6026","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2431255789","fragment_type":"issue_description","sequence":0,"text":"Bug Report: Context Loss\n### What is the issue?\n\n## Bug Report: Context Loss in `mistral-nemo` Model\n\n### Description\n\nI am using the `mistral-nemo` model in Ollama, which is supposed to have a 128k context window. However, I am observing issues with context loss with this model and the `llama3` model as well.\n\n### Steps to Reproduce\n\n1. Run the command `ollama run mistral-nemo`.\n2. Use the following prompt:\n\nplaintext\n'{id: 0, name: \"Alexander City\"}'\n'{id: 1, name: \"Andalusia\"}'\n'{id: 2, name: \"Anniston\"}'\n'{id: 3, name: \"Athens\"}'\n'{id: 4, name: \"Atmore\"}'\n'{id: 5, name: \"Auburn\"}'\n'{id: 6, name: \"Bessemer\"}'\n'{id: 7, name: \"Birmingham\"}'\n'{id: 8, name: \"Chickasaw\"}'\n'{id: 9, name: \"Clanton\"}'\n'{id: 10, name: \"Cullman\"}'\n'{id: 11, name: \"Decatur\"}'\n'{id: 12, name: \"Demopolis\"}'\n'{id: 13, name: \"Dothan\"}'\n'{id: 14, name: \"Enterprise\"}'\n'{id: 15, name: \"Eufaula\"}'\n'{id: 16, name: \"Florence\"}'\n'{id: 17, name: \"Fort Payne\"}'\n'{id: 18, name: \"Gadsden\"}'\n'{id: 19, name: \"Greenville\"}'\n'{id: 20, name: \"Guntersville\"}'\n'{id: 21, name: \"Huntsville\"}'\n'{id: 22, name: \"Jasper\"}'\n'{id: 23, name: \"Marion\"}'\n'{id: 24, name: \"Mobile\"}'\n'{id: 25, name: \"Montgomery\"}'\n'{id: 26, name: \"Opelika\"}'\n'{id: 27, name: \"Ozark\"}'\n'{id: 28, name: \"Phenix City\"}'\n'{id: 29, name: \"Prichard\"}'\n'{id: 30, name: \"Scottsboro\"}'\n'{id: 31, name: \"Selma\"}'\n'{id: 32, name: \"Sheffield\"}'\n'{id: 33, name: \"Sylacauga\"}'\n'{id: 34, name: \"Talladega\"}'\n'{id: 35, name: \"Troy\"}'\n'{id: 36, name: \"Tuscaloosa\"}'\n'{id: 37, name: \"Tuscumbia\"}'\n'{id: 38, name: \"Tuskegee\"}'\n'{id: 39, name: \"Alaska\"}'\n'{id: 40, name: \"Anchorage\"}'\n'{id: 41, name: \"Cordova\"}'\n'{id: 42, name: \"Fairbanks\"}'\n'{id: 43, name: \"Haines\"}'\n'{id: 44, name: \"Homer\"}'\n'{id: 45, name: \"Juneau\"}'\n'{id: 46, name: \"Ketchikan\"}'\n'{id: 47, name: \"Kodiak\"}'\n'{id: 48, name: \"Kotzebue\"}'\n'{id: 49, name: \"Nome\"}'\n'{id: 50, name: \"Palmer\"}'\n'{id: 51, name: \"Seward\"}'\n'{id: 52, name: \"Sitka\"}'\n'{id: 53, name: \"Skagway\"}'\n'{id: 54, name: \"Valdez\"}'\n'{id: 55, name: \"Arizona\"}'\n'{id: 56, name: \"Ajo\"}'\n'{id: 57, name: \"Avondale\"}'\n'{id: 58, name: \"Bisbee\"}'\n'{id: 59, name: \"Casa Grande\"}'\n'{id: 60, name: \"Chandler\"}'\n'{id: 61, name: \"Clifton\"}'\n'{id: 62, name: \"Douglas\"}'\n'{id: 63, name: \"Flagstaff\"}'\n'{id: 64, name: \"Florence\"}'\n'{id: 65, name: \"Gila Bend\"}'\n'{id: 66, name: \"Glendale\"}'\n'{id: 67, name: \"Globe\"}'\n'{id: 68, name: \"Kingman\"}'\n'{id: 69, name: \"Lake Havasu City\"}'\n'{id: 70, name: \"Mesa\"}'\n'{id: 71, name: \"Nogales\"}'\n'{id: 72, name: \"Oraibi\"}'\n'{id: 73, name: \"Phoenix\"}'\n'{id: 74, name: \"Prescott\"}'\n'{id: 75, name: \"Scottsdale\"}'\n'{id: 76, name: \"Sierra Vista\"}'\n'{id: 77, name: \"Tempe\"}'\n'{id: 78, name: \"Tombstone\"}'\n'{id: 79, name: \"Tucson\"}'\n'{id: 80, name: \"Walpi\"}'\n'{id: 81, name: \"Window Rock\"}'\n'{id: 82, name: \"Winslow\"}'\n'{id: 83, name: \"Yuma\"}'\n'{id: 84, name: \"Arkansas\"}'\n'{id: 85, name: \"Arkadelphia\"}'\n'{id: 86, name: \"Arkansas Post\"}'\n'{id: 87, name: \"Batesville\"}'\n'{id: 88, name: \"Benton\"}'\n'{id: 89, name: \"Blytheville\"}'\n'{id: 90, name: \"Camden\"}'\n'{id: 91, name: \"Conway\"}'\n'{id: 92, name: \"Crossett\"}'\n'{id: 93, name: \"El Dorado\"}'\n'{id: 94, name: \"Fayetteville\"}'\n'{id: 95, name: \"Forrest City\"}'\n'{id: 96, name: \"Fort Smith\"}'\n'{id: 97, name: \"Harrison\"}'\n'{id: 98, name: \"Helena\"}'\n'{id: 99, name: \"Hope\"}'\n'{id: 100, name: \"Hot Springs\"}'\n'{id: 101, name: \"Jacksonville\"}'\n'{id: 102, name: \"Jonesboro\"}'\n'{id: 103, name: \"Little Rock\"}'\n'{id: 104, name: \"Magnolia\"}'\n'{id: 105, name: \"Morrilton\"}'\n'{id: 106, name: \"Newport\"}'\n'{id: 107, name: \"North Little Rock\"}'\n'{id: 108, name: \"Osceola\"}'\n'{id: 109, name: \"Pine Bluff\"}'\n'{id: 110, name: \"Rogers\"}'\n'{id: 111, name: \"Searcy\"}'\n'{id: 112, name: \"Stuttgart\"}'\n'{id: 113, name: \"Van Buren\"}'\n'{id: 114, name: \"West Memphis\"}'\n'{id: 115, name: \"California\"}'\n'{id: 116, name: \"Alameda\"}'\n'{id: 117, name: \"Alhambra\"}'\n'{id: 118, name: \"Anaheim\"}'\n'{id: 119, name: \"Antioch\"}'\n'{id: 120, name: \"Arcadia\"}'\n'{id: 121, name: \"Bakersfield\"}'\n'{id: 122, name: \"Barstow\"}'\n'{id: 123, name: \"Belmont\"}'\n'{id: 124, name: \"Berkeley\"}'\n'{id: 125, name: \"Beverly Hills\"}'\n'{id: 126, name: \"Brea\"}'\n'{id: 127, name: \"Buena Park\"}'\n'{id: 128, name: \"Burbank\"}'\n'{id: 129, name: \"Calexico\"}'\n'{id: 130, name: \"Calistoga\"}'\n'{id: 131, name: \"Carlsbad\"}'\n'{id: 132, name: \"Carmel\"}'\n'{id: 133, name: \"Chico\"}'\n'{id: 134, name: \"Chula Vista\"}'\n'{id: 135, name: \"Claremont\"}'\n'{id: 136, name: \"Compton\"}'\n'{id: 137, name: \"Concord\"}'\n'{id: 138, name: \"Corona\"}'\n'{id: 139, name: \"Coronado\"}'\n'{id: 140, name: \"Costa Mesa\"}'\n'{id: 141, name: \"Culver City\"}'\n'{id: 142, name: \"Daly City\"}'\n'{id: 143, name: \"Davis\"}'\n'{id: 144, name: \"Downey\"}'\n'{id: 145, name: \"El Centro\"}'\n'{id: 146, name: \"El Cerrito\"}'\n'{id: 147, name: \"El Monte\"}'\n'{id: 148, name: \"Escondido\"}'\n'{id: 149, name: \"Eureka\"}'\n'{id: 150, name: \"Fairfield\"}\n\n3. Ask: \"What's the city with id 1?\"\n\nThe response is:\n\nplaintext\nThe city with id 1 is not included in the provided list. The smallest id number present is for Arkadelphia, which has an id of 85.\n\nThis indicates that the model is losing context since `Andalusia` should be the correct answer.\n\n### Temporary Solution\n\nI found that setting the `num_ctx` parameter to 120000 before the prompt resolves the issue. For example:\n\nplaintext\n/set parameter num_ctx 120000\n\nThen, when repeating the experiment, I receive the correct response:\n\nplaintext\nThe city with id 1 is \"Andalusia\".\n\n### Additional Information\n\nRunning `ollama show mistral-nemo` provides the following details:\n\nplaintext\nModel\n arch llama\n parameters 12.2B\n quantization Q4_0\n context length 1.024e+06\n embedding length 5120\n\nParameters\n stop \"[INST]\"\n stop \"[/INST]\"\n\nLicense\n \"Apache License\"\n\n### API Usage\n\nWhen using the API directly with `curl`, the problem persists even if I use:\n\njson\noptions = {\"num_ctx\": 120000}\n\nTo resolve this, I need to pass:\n\njson\n{\"role\": \"user\", \"content\": \"/set parameter num_ctx 120000\"}\n\nwithin `messages` during the request.\n\n### Conclusion\n\nThere is a bug in Ollama where the `mistral-nemo` (and `llama3`) model loses context unless the `num_ctx` parameter is explicitly set within the prompts.\n\n### OS\n\nLinux\n\n### GPU\n\nNvidia\n\n### CPU\n\nIntel\n\n### Ollama version\n\n0.2.8","author_login":"rodolfo-nobrega","author_association":"NONE","created_at":"2024-07-26T01:51:15+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2252354726","fragment_type":"issue_comment","sequence":1,"text":"As background, ollama API calls (and CLI prompts via `ollama run`) that don't specify a context length, use a context length of 2048 tokens. If you need more context, you either need to specify that in the API call or change the default. `options = {\"num_ctx\": 120000}` is the canonical way to do that, if it's not working that's a bug and it would be great if you could send server logs demontrating this issue. Adding `{\"role\": \"user\", \"content\": \"/set parameter num_ctx 120000\"}` to an API call will not change the context window because `/set parameter` is interpreted by the CLI (`ollama run`), which is not involved in inference during an API call.\n\nTo change the default context window of a model and so do away with having to add `options` to an API call, you need to create a new model. This is easy to do and if you follow the instructions, does not require more disk.\n\nFirst, get a copy of the current modelfile:\n\nollama show --modelfile mistral-nemo > Modelfile\n\nNow edit the file and do two things:\n1. Where it says `FROM` and a long file path, change the file path to the name of the model.\n eg, `FROM /root/.ollama/models/blobs/sha256-b559938ab7a0392fc9ea9675b82280f2a15669ec3e0e0fc491c9cb0a7681cf94`\n becomes `FROM mistral-nemo`\n2. Create a new line in the file and add `PARAMETER num_ctx 120000`\n\nCreate the new model:\n\nollama create -f Modelfile mistral-nemo-120k\n\nVerify the change in default context length, check num_ctx under paramaters:\n\n $ ollama show mistral-nemo-120k\n Model\n arch llama\n parameters 12.2B\n quantization Q4_0\n context length 1.024e+06\n embedding length 5120\n\n Parameters\n num_ctx 120000\n stop \"[INST]\"\n stop \"[/INST]\"\n\nThis should solve your context problem, if it persists please follow up with server logs.","author_login":"rick-github","author_association":"NONE","created_at":"2024-07-26T09:36:41+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2254106879","fragment_type":"issue_comment","sequence":2,"text":"this should be mentioned somewhere in the documentation, if not already.","author_login":"parth-mangtani-cerelabs","author_association":"NONE","created_at":"2024-07-27T10:28:28+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2327759879","fragment_type":"issue_comment","sequence":3,"text":"@rick-github thanks for the awesome explanation! Will close this for now. @rodolfo-nobrega @anubhav-agrawal-mu-sigma feel free to follow up if things still aren't working..","author_login":"jmorganca","author_association":"MEMBER","created_at":"2024-09-04T01:58:46+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2503446069","fragment_type":"issue_comment","sequence":4,"text":"the faq needs to be updated with your example as it took a lot of time to understand and configure the solution as it is NOT mentioned in faq - URL","author_login":"montvid","author_association":"NONE","created_at":"2024-11-27T10:02:52+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[2431255789],"is_known_query_context":false},{"document_id":"gh_comment_2503459854","fragment_type":"issue_comment","sequence":5,"text":"I agree, I have a WIP to update various bits of documentation but haven't pushed a PR yet.","author_login":"rick-github","author_association":"COLLABORATOR","created_at":"2024-11-27T10:08:33+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2503474699","fragment_type":"issue_comment","sequence":6,"text":"It should be noted that changing the context size of a model via the Modelfile is mentioned, but in the OpenAI doc , not the FAQ.","author_login":"rick-github","author_association":"COLLABORATOR","created_at":"2024-11-27T10:15:18+08:00","repo_name":"ollama/ollama","issue_id":2431255789,"issue_number":5965,"issue_url":"https://github.com/ollama/ollama/issues/5965","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0223","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[BUG] Compositor crash when using KVM and switching inputs with 2 monitors?","query_context":"Hey all,\n\nI finally got around to running the debug version of the compiler (really don't suggest running it like this all the time it's so slow :sob: ) and I was able to reproduce the crash I was seeing in URL Here's my logs for today after reproducing the issue:\n\ncosmic-comp-journal.log\n\nDisplay info:\n\n$ xrandr\nScreen 0: minimum 16 x 16, current 5120 x 1440, maximum 32767 x 32767\nDP-2 connected 2560x1440+0+0 (normal left inverted right x axis y axis) 600mm x 340mm\n 2560x1440 143.91*+\n 1920x1440 143.90\n 1600x1200 143.89\n 1440x1080 143.80\n 1400x1050 143.89\n 1280x1024 143.79\n 1280x960 143.86\n 1152x864 143.92\n 1024x768 143.87\n 800x600 143.83\n 640x480 143.85\n 320x240 142.05\n 1920x1200 143.89\n 1680x1050 143.88\n 1440x900 143.86\n 1280x800 143.84\n 1152x720 143.77\n 960x600 143.72\n 928x580 143.50\n 800x500 143.68\n 768x480 143.69\n 720x480 143.85\n 640x400 143.37\n 320x200 141.40\n 2048x1152 143.88\n 1920x1080 143.88\n 1600x900 143.93\n 1368x768 143.77\n 1280x720 143.85\n 1024x576 143.91\n 864x486 143.63\n 720x400 143.88\n 640x350 143.57\nDP-1 connected 2560x1440+2560+0 (normal left inverted right x axis y axis) 600mm x 340mm\n 2560x1440 59.91*+\n 1920x1440 59.90\n 1600x1200 59.87\n 1440x1080 59.87\n 1400x1050 59.86\n 1280x1024 59.89\n 1280x960 59.94\n 1152x864 59.78\n 1024x768 59.68\n 800x600 59.86\n 640x480 59.38\n 320x240 59.52\n 1920x1200 59.88\n 1680x1050 59.85\n 1440x900 59.89\n 1280x800 59.81\n 1152x720 59.75\n 960x600 59.63\n 928x580 59.88\n 800x500 59.50\n 768x480 59.38\n 720x480 59.71\n 640x400 59.20\n 320x200 58.96\n 2048x1152 59.90\n 1920x1080 59.88\n 1600x900 59.82\n 1368x768 59.88\n 1280x720 59.86\n 1024x576 59.90\n 864x486 59.45\n 720x400 59.55\n 640x350 59.77\n\n$ sudo lshw -C display\n *-display\n description: VGA compatible controller\n product: GA102 [GeForce RTX 3080 Ti]\n vendor: NVIDIA Corporation\n physical id: 0\n bus info: pci@0000:09:00.0\n version: a1\n width: 64 bits\n clock: 33MHz\n capabilities: pm msi pciexpress vga_controller bus_master cap_list rom\n configuration: driver=nvidia latency=0\n resources: iomemory:780-77f iomemory:7c0-7bf irq:80 memory:fb000000-fbffffff memory:7800000000-7bffffffff memory:7c00000000-7c01ffffff ioport:e000(size=128) memory:fc000000-fc07ffff\n\nI super appreciate y'all fixing the greeter in this aspect. If this can be fixed, I'll be able to go back to daily driving Cosmic! If you need more information from me, please let me know and I'll try to get it for you.","known_context_document_ids":["gh_issue_2695937947"],"reference_answer":"I am pretty confident the last variant of this issue has now been resolved with URL \n\nThanks @hayandev for debugging this. The missing piece was, that this only happens, when the last output is disconnected (even if just temporarily), which is why I wasn't able to reproduce this earlier.\n\nI bunch of this code was refactored when focus-follows-cursor was introduced, which caused some subtle regressions, which only surfaced after some other fixes to output hotplug. At last that logic should be sound now.","answer_document_id":"gh_comment_2546443005","silver_evidence_path":["gh_comment_2539746931","gh_issue_2567949374","gh_comment_2546443005"],"evidence_issue_ids":[2695937947,2567949374],"source_repo_name":"pop-os/cosmic-comp","source_issue_id":2695937947,"source_issue_number":1014,"source_issue_url":"https://github.com/pop-os/cosmic-comp/issues/1014","target_repo_name":"pop-os/cosmic-comp","target_issue_id":2567949374,"target_issue_number":906,"target_issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","reference_anchor_document_id":"gh_comment_2539746931","reference_answer_author":"Drakulix","reference_answer_author_association":"MEMBER","quality_score":86.66,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0732},"issue_created_at":"2024-11-26T20:03:09+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_2695937947","fragment_type":"issue_description","sequence":0,"text":"[BUG] Compositor crash when using KVM and switching inputs with 2 monitors\nHey all,\n\nI finally got around to running the debug version of the compiler (really don't suggest running it like this all the time it's so slow :sob: ) and I was able to reproduce the crash I was seeing in URL Here's my logs for today after reproducing the issue:\n\ncosmic-comp-journal.log\n\nDisplay info:\n\n$ xrandr\nScreen 0: minimum 16 x 16, current 5120 x 1440, maximum 32767 x 32767\nDP-2 connected 2560x1440+0+0 (normal left inverted right x axis y axis) 600mm x 340mm\n 2560x1440 143.91*+\n 1920x1440 143.90\n 1600x1200 143.89\n 1440x1080 143.80\n 1400x1050 143.89\n 1280x1024 143.79\n 1280x960 143.86\n 1152x864 143.92\n 1024x768 143.87\n 800x600 143.83\n 640x480 143.85\n 320x240 142.05\n 1920x1200 143.89\n 1680x1050 143.88\n 1440x900 143.86\n 1280x800 143.84\n 1152x720 143.77\n 960x600 143.72\n 928x580 143.50\n 800x500 143.68\n 768x480 143.69\n 720x480 143.85\n 640x400 143.37\n 320x200 141.40\n 2048x1152 143.88\n 1920x1080 143.88\n 1600x900 143.93\n 1368x768 143.77\n 1280x720 143.85\n 1024x576 143.91\n 864x486 143.63\n 720x400 143.88\n 640x350 143.57\nDP-1 connected 2560x1440+2560+0 (normal left inverted right x axis y axis) 600mm x 340mm\n 2560x1440 59.91*+\n 1920x1440 59.90\n 1600x1200 59.87\n 1440x1080 59.87\n 1400x1050 59.86\n 1280x1024 59.89\n 1280x960 59.94\n 1152x864 59.78\n 1024x768 59.68\n 800x600 59.86\n 640x480 59.38\n 320x240 59.52\n 1920x1200 59.88\n 1680x1050 59.85\n 1440x900 59.89\n 1280x800 59.81\n 1152x720 59.75\n 960x600 59.63\n 928x580 59.88\n 800x500 59.50\n 768x480 59.38\n 720x480 59.71\n 640x400 59.20\n 320x200 58.96\n 2048x1152 59.90\n 1920x1080 59.88\n 1600x900 59.82\n 1368x768 59.88\n 1280x720 59.86\n 1024x576 59.90\n 864x486 59.45\n 720x400 59.55\n 640x350 59.77\n\n$ sudo lshw -C display\n *-display\n description: VGA compatible controller\n product: GA102 [GeForce RTX 3080 Ti]\n vendor: NVIDIA Corporation\n physical id: 0\n bus info: pci@0000:09:00.0\n version: a1\n width: 64 bits\n clock: 33MHz\n capabilities: pm msi pciexpress vga_controller bus_master cap_list rom\n configuration: driver=nvidia latency=0\n resources: iomemory:780-77f iomemory:7c0-7bf irq:80 memory:fb000000-fbffffff memory:7800000000-7bffffffff memory:7c00000000-7c01ffffff ioport:e000(size=128) memory:fc000000-fc07ffff\n\nI super appreciate y'all fixing the greeter in this aspect. If this can be fixed, I'll be able to go back to daily driving Cosmic! If you need more information from me, please let me know and I'll try to get it for you.","author_login":"gmpinder","author_association":"NONE","created_at":"2024-11-26T20:03:09+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2695937947,"issue_number":1014,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/1014","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2501818168","fragment_type":"issue_comment","sequence":1,"text":"I should probably mention that, when switching, the 60Hz monitor takes a bit longer to connect than the 144Hz. Maybe that has something to do with this?","author_login":"gmpinder","author_association":"NONE","created_at":"2024-11-26T20:05:19+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2695937947,"issue_number":1014,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/1014","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2539746931","fragment_type":"issue_comment","sequence":2,"text":"This appears to be related to #906 (both panic at the same line in `mod.rs`).","author_login":"APCBoston","author_association":"NONE","created_at":"2024-12-12T18:36:06+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2695937947,"issue_number":1014,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/1014","linked_issue_ids":[2567949374],"is_known_query_context":false},{"document_id":"gh_comment_2549687785","fragment_type":"issue_comment","sequence":3,"text":"Appears to be fixed for me on\n\n$ rpm -q cosmic-comp\ncosmic-comp-1.0.0~alpha.4^git20241216.7ac204e-1.fc41.x86_64","author_login":"gmpinder","author_association":"NONE","created_at":"2024-12-17T21:36:00+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2695937947,"issue_number":1014,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/1014","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2567949374","fragment_type":"issue_description","sequence":0,"text":"Crash when disconnecting/reconnecting monitor\nDistro: Arch Linux\nVersion: cosmic-comp 1.0.0.alpha.2-1\n\nWhen reconnecting the monitor (happens when turning monitor back on according to timestamp) cosmic-comp crashes, taking all open programs with it.\n\nLogs:\n\nOct 05 13:45:24 cosmic cosmic-comp[1501]: thread 'main' panicked at 'called `Option::unwrap()` on a `None` value': src/shell/mod.rs:973\n 0: \n 1: \n 2: \n 3: \n 4: \n 5: \n 6: \n 7: \n 8: \n 9: \n 10: \n 11: \n 12: \n 13: \n 14: \n 15: \n 16: \n 17: \n 18: \n 19: \n 20: __libc_start_main\n 21: \nOct 05 13:45:24 cosmic cosmic-comp[1501]: thread 'surface-HDMI-A-1' panicked at 'called `Result::unwrap()` on an `Err` value: PoisonError { .. }': src/backend/kms/surface/mod.rs:1076\n 0: \n 1: \n 2: \n 3: \n 4: \n 5: \n 6: \n 7: \n 8: \n 9: \n 10: \n 11: \n 12: \n 13: \n 14: \n 15: \n 16: \n 17: \nOct 05 13:45:24 cosmic xdg-desktop-por[1752]: Error reading events from display: Broken pipe\nOct 05 13:45:24 cosmic cosmic-session[1476]: Io error: Broken pipe (os error 32)\nOct 05 13:45:24 cosmic systemd[1463]: xdg-desktop-portal-gtk.service: Main process exited, code=exited, status=1/FAILURE\nOct 05 13:45:24 cosmic systemd[1463]: xdg-desktop-portal-gtk.service: Failed with result 'exit-code'.\nOct 05 13:45:24 cosmic cosmic-session[1476]: process ' COSMIC_SESSION_SOCK=12 cosmic-comp ' failed with code 101\nOct 05 13:45:24 cosmic cosmic-session[1476]: cosmic-comp exited with error code 101\nOct 05 13:45:24 cosmic cosmic-session[1476]: draining stdin receiver before restarting process\nOct 05 13:45:24 cosmic cosmic-session[1476]: sleeping for 0ms before restarting process cosmic-comp (restart 0)\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(11v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(10v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(9v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(8v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(7v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(6v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(5v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(4v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(3v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(2v1)' cancelled\nOct 05 13:45:24 cosmic cosmic-session[1476]: RESTARTING: session restarted by request\nOct 05 13:45:24 cosmic cosmic-session[1476]: restarted process ' COSMIC_SESSION_SOCK=12 cosmic-comp ', now at 1 restarts\nOct 05 13:45:24 cosmic cosmic-session[1476]: process 'ProcessKey(1v1)' cancelled\nOct 05 13:45:26 cosmic systemd[1463]: Stopped target Cosmic Session Target.\nOct 05 13:45:26 cosmic systemd[1463]: Stopped target Current graphical user session.\nOct 05 13:45:26 cosmic systemd[1463]: Stopped target Session services which should run early before the graphical session is brought up.\nOct 05 13:45:26 cosmic systemd[1463]: Stopped target Startup of XDG autostart applications.\nOct 05 13:45:26 cosmic dbus-broker[1823]: Dispatched 20 messages @ 3(±4)μs / message.\nOct 05 13:45:26 cosmic cosmic-session[1476]: Restarting\nOct 05 13:45:26 cosmic systemd[1463]: Stopping Accessibility services bus...\nOct 05 13:45:26 cosmic systemd[1463]: Stopping Portal service...\nOct 05 13:45:26 cosmic systemd[1463]: Stopping flatpak document portal service...\nOct 05 13:45:26 cosmic systemd[1463]: Stopping sandboxed app permission store...\nOct 05 13:45:26 cosmic systemd[1463]: Stopped sandboxed app permission store.\nOct 05 13:45:26 cosmic cosmic-session[1476]: Starting cosmic-session","author_login":"rmrfbugs","author_association":"NONE","created_at":"2024-10-05T12:13:51+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2475284013","fragment_type":"issue_comment","sequence":1,"text":"Same here:\n\nlog\nNov 13 21:19:50 sisyphus .cosmic-comp-wrapped[2139]: thread 'main' panicked at 'called `Option::unwrap()` on a `None` value': src/shell/mod.rs:974\n 0: ::default\n 1: log_panics::Config::install_panic_hook::{{closure}}\n 2: std::panicking::rust_panic_with_hook\n 3: std::panicking::begin_panic_handler::{{closure}}\n 4: std::sys::backtrace::__rust_end_short_backtrace\n 5: rust_begin_unwind\n 6: core::panicking::panic_fmt\n 7: core::panicking::panic\n 8: core::option::unwrap_failed\n 9: cosmic_comp::shell::Workspaces::active\n 10: cosmic_comp::input:: ::surface_under\n 11: cosmic_comp::shell::focus:: ::refresh_focus\n 12: calloop::loop_logic::EventLoop ::run\n 13: cosmic_comp::main\n 14: std::sys::backtrace::__rust_begin_short_backtrace\n 15: main\n 16: __libc_start_call_main\n 17: __libc_start_main_alias_2\n 18: _start\nNov 13 21:19:50 sisyphus .cosmic-comp-wrapped[2139]: thread 'surface-DP-1' panicked at 'called `Result::unwrap()` on an `Err` value: PoisonError { .. }': src/backend/kms/surface/mod.rs:1124\n 0: ::default\n 1: log_panics::Config::install_panic_hook::{{closure}}\n 2: std::panicking::rust_panic_with_hook\n 3: std::panicking::begin_panic_handler::{{closure}}\n 4: std::sys::backtrace::__rust_end_short_backtrace\n 5: rust_begin_unwind\n 6: core::panicking::panic_fmt\n 7: core::result::unwrap_failed\n 8: cosmic_comp::backend::kms::surface::SurfaceThreadState::redraw\n 9: > as calloop::sources::EventDispatcher >::process_events\n 10: cosmic_comp::backend::kms::surface::surface_thread\n 11: std::sys::backtrace::__rust_begin_short_backtrace\n 12: core::ops::function::FnOnce::call_once{{vtable.shim}}\n 13: std::sys::pal::unix::thread::Thread::new::thread_start\n 14: start_thread\n 15: __GI___clone3\nNov 13 21:19:50 sisyphus .xdg-desktop-po[2723]: Error reading events from display: Broken pipe\nNov 13 21:19:50 sisyphus cosmic-session[2122]: Io error: Broken pipe (os error 32)\nNov 13 21:19:50 sisyphus systemd[2100]: xdg-desktop-portal-gtk.service: Main process exited, code=exited, status=1/FAILURE\nNov 13 21:19:50 sisyphus systemd[2100]: xdg-desktop-portal-gtk.service: Failed with result 'exit-code'.\nNov 13 21:19:50 sisyphus cosmic-session[2122]: process ' COSMIC_SESSION_SOCK=12 cosmic-comp ' failed with code 101\nNov 13 21:19:50 sisyphus pipewire[2382]: mod.x11-bell: X11 I/O error handler called on display :1\nNov 13 21:19:50 sisyphus pipewire[2382]: mod.x11-bell: X11 display (:1) has encountered a fatal I/O error\nNov 13 21:19:50 sisyphus systemd[2100]: cosmic-launcher.scope: Consumed 41min 35.720s CPU time, 653.5M memory peak.\nNov 13 21:19:50 sisyphus systemd[2100]: app-cosmic-google-chrome-30911.scope: Consumed 3min 23.597s CPU time, 1.4G memory peak.\nNov 13 21:19:50 sisyphus cosmic-session[2122]: cosmic-comp exited with error code 101","author_login":"cjshearer","author_association":"NONE","created_at":"2024-11-14T02:32:15+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2477677638","fragment_type":"issue_comment","sequence":2,"text":"I think this is a duplicate of #679, which might trace back to #57. This is also being tracked in pop-os/cosmic-epoch#84.","author_login":"cjshearer","author_association":"NONE","created_at":"2024-11-15T00:18:13+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2483786676","fragment_type":"issue_comment","sequence":3,"text":"I get a similar error when trying to \"wake up\" my computer after sleep.\n\nNov 18 16:36:53 .cosmic-comp-wrapped[1514]: Failed to destroy old mode property blob: No such file or directory (os error 2)\nNov 18 16:36:53 .cosmic-comp-wrapped[1514]: Failed to set new config.\nNov 18 16:36:53 .cosmic-comp-wrapped[1514]: failed to create signaled syncobj\nNov 18 16:36:53 .cosmic-comp-wrapped[1514]: ignoring requested context priority, EGL_IMG_context_priority not supported\nNov 18 16:36:53 .cosmic-comp-wrapped[1514]: ignoring requested context priority, EGL_IMG_context_priority not supported\nNov 18 16:36:54 .cosmic-comp-wrapped[1514]: ignoring requested context priority, EGL_IMG_context_priority not supported\nNov 18 16:36:54 .cosmic-comp-wrapped[1514]: ignoring requested context priority, EGL_IMG_context_priority not supported\nNov 18 16:36:59 .cosmic-comp-wrapped[1514]: Failed to destroy old mode property blob: No such file or directory (os error 2)\nNov 18 16:36:59 .cosmic-comp-wrapped[1514]: thread 'surface-HDMI-A-1' panicked at 'internal error: entered unreachable code': src/backend/kms/surface/mod.rs:780\n 0: ::default\n 1: log_panics::Config::install_panic_hook::{{closure}}\n 2: std::panicking::rust_panic_with_hook\n 3: std::panicking::begin_panic_handler::{{closure}}\n 4: std::sys::backtrace::__rust_end_short_backtrace\n 5: rust_begin_unwind\n 6: core::panicking::panic_fmt\n 7: core::panicking::panic\n 8: > as calloop::sources::EventDispatcher >::process_events::{{closure}}\n 9: > as calloop::sources::EventDispatcher >::process_events\n 10: cosmic_comp::backend::kms::surface::surface_thread\n 11: std::sys::backtrace::__rust_begin_short_backtrace\n 12: core::ops::function::FnOnce::call_once{{vtable.shim}}\n 13: std::sys::pal::unix::thread::Thread::new::thread_start\n 14: start_thread\n 15: clone3\n\nSystem is NixOs using the stable branch. Cosmic versions are\n\ncosmic-applets-1.0.0-alpha.2-unstable-2024-10-21\ncosmic-applibrary-1.0.0-alpha.2-unstable-2024-10-24\ncosmic-bg-1.0.0-alpha.2-unstable-2024-10-09\ncosmic-comp-1.0.0-alpha.2-unstable-2024-10-25\ncosmic-edit-1.0.0-alpha.2-unstable-2024-10-29\ncosmic-files-1.0.0-alpha.2-unstable-2024-10-29\ncosmic-greeter-1.0.0-alpha.2-unstable-2024-10-14\ncosmic-icons-1.0.0-alpha.2-unstable-2024-10-02\ncosmic-idle-0-unstable-2024-10-30\ncosmic-launcher-1.0.0-alpha.2-unstable-2024-10-29\ncosmic-notifications-1.0.0-alpha.2-unstable-2024-10-24\ncosmic-osd-1.0.0-alpha.2-unstable-2024-10-09\ncosmic-panel-1.0.0-alpha.2-unstable-2024-10-22\ncosmic-randr-1.0.0-alpha.2-unstable-2024-10-24\ncosmic-screenshot-1.0.0-alpha.2-unstable-2024-07-25\ncosmic-session-1.0.0-alpha.2-unstable-2024-10-30\ncosmic-settings-1.0.0-alpha.2-unstable-2024-10-30\ncosmic-settings-daemon-1.0.0-alpha.2-unstable-2024-09-26\ncosmic-term-1.0.0-alpha.2-unstable-2024-10-30\ncosmic-wallpapers-1.0.0-alpha.2-unstable-2024-09-27\ncosmic-workspaces-epoch-1.0.0-alpha.2-unstable-2024-08-07\nxdg-desktop-portal-cosmic-1.0.0-alpha.2-unstable-2024-10-10","author_login":"Wasabi375","author_association":"NONE","created_at":"2024-11-18T18:15:22+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541622247","fragment_type":"issue_comment","sequence":4,"text":"@Drakulix Please note that I just updated and am still able to reproduce this issue and URL . \n\nI've tried it maybe 5-6 times in a row, with terminal open on the laptop screen and browser on the external monitor, and I lose both every single time I unplug HDMI. \n\nI have attached my software versions as well as the journal log from the crash (starting around timestamp 0932).\n\nDec 13 09:32:03 pop-os cosmic-comp[2537]: thread 'main' panicked at 'called `Option::unwrap()` on a `None` value': src/shell/mod.rs:974\n\njournal_log.txt\nsys_info_sw_2024-Dec-13- 921.txt","author_login":"zsilet","author_association":"NONE","created_at":"2024-12-13T14:48:32+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541635680","fragment_type":"issue_comment","sequence":5,"text":"How have you updated your install? I am not sure that version is live anywhere, but the Pop!_OS staging repo.\n\nThese logs are unfortunately not very helpful, as they don't contain full backtraces. A debug build of cosmic-comp would produce proper ones.","author_login":"Drakulix","author_association":"MEMBER","created_at":"2024-12-13T14:55:25+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541658048","fragment_type":"issue_comment","sequence":6,"text":"@Drakulix the COSMIC alpha apt repo appears to be pushing nightly builds; today's update version has the commit hash matching #1057 merging to `master`.\n\nI've just updated, if I continue to see the issue I'll see about getting a stacktrace from a debug build.\n\n$ apt show cosmic-comp\nPackage: cosmic-comp\nVersion: 0.1~1734010190~24.04~9b41275\nPriority: optional\nSection: x11\nMaintainer: Victoria Brekenfeld \nInstalled-Size: 24.7 MB\nDepends: libc6 (>= 2.38), libgbm1 (>= 21.3.0~rc1), libgcc-s1 (>= 4.2), libinput10 (>= 1.19.1), libpixman-1-0 (>= 0.30.0), libseat1 (>= 0.5.0), libudev1 (>= 183), libxkbcommon0 (>= 0.5.0), libegl1, libwayland-server0\nRecommends: cosmic-session, libgl1-mesa-dri\nHomepage: URL \nDownload-Size: 7,859 kB\nAPT-Manual-Installed: no\nAPT-Sources: URL noble/main amd64 Packages\nDescription: Wayland compositor of pop-os cosmic shell","author_login":"APCBoston","author_association":"NONE","created_at":"2024-12-13T15:06:48+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2541954168","fragment_type":"issue_comment","sequence":7,"text":"I unfortunately still get that issue with URL I've built it with debugging symbols and tried to bisect the relevant parts, maybe this cosmic-reconnect-crash-log.txt log helps (I think the relevant stacktrace is on line 9606), it looks pretty similar as the log from @zsilet.\n\nWhat I find interesting, is that cosmic-panel crashes first, maybe related, maybe a similar issue as this within cosmic-panel.","author_login":"Philipp-M","author_association":"NONE","created_at":"2024-12-13T17:46:33+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2542717357","fragment_type":"issue_comment","sequence":8,"text":"I still see to see unwrap panics in `Workspaces::active()` sometimes on disconnecting on monitor, even with the latest changes.","author_login":"ids1024","author_association":"MEMBER","created_at":"2024-12-14T03:31:37+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2543112529","fragment_type":"issue_comment","sequence":9,"text":"I've found the issue in my case( URL \nHere's a step-by-step breakdown of the process leading to the panic:\n\n1. Monitor disconnected (let's call it `Output-1`).\n2. In `Workspaces::remove_output`:\n 1. Removed from the `sets`.\n 2. The `backup_set` is set (line 772).\n3. Monitor connected (let's call it `Output-2`).\n4. In `Workspaces::add_output`:\n 1. The `backup_set` is added to `sets` with `Output-2` as the key.\n5. Main function starts handling the event loop (line 120).\n6. In `Common::refresh_focus`, a loop over `seats`:\n 1. In `State::surface_under`, the function `shell.workspaces.active(output)` is called.\n 1. At no point in the above steps is the seat's output updated to `Output-2`.\n 2. Therefore, the `output` passed as a parameter is `Output-1`.\n 2. Panic occurs.\n\nI think the call to `update_pointer_focus()` at line 347 in `Common::refresh_focus` should be moved below line 359.\n\nAlso, when setting `backup_set` in `Workspaces::remove_output`, the `focused_output` of the `seat` for the removed `output` should be set to `None`.\n\nHowever, I’m not sure what exactly `update_pointer_focus()` is for, so I could be wrong.\nAnyway, I found that this resolves the issue.\n\nI’m not very good at English, so I got help from ChatGPT. I’ve read through it and made some revisions, but I apologize if the sentences sound awkward.","author_login":"hayandev","author_association":"NONE","created_at":"2024-12-14T13:34:22+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2543123232","fragment_type":"issue_comment","sequence":10,"text":"I can confirm I am no longer seeing the sleep/wake variant of this issue.","author_login":"APCBoston","author_association":"NONE","created_at":"2024-12-14T14:08:50+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2546443005","fragment_type":"issue_comment","sequence":11,"text":"I am pretty confident the last variant of this issue has now been resolved with URL \n\nThanks @hayandev for debugging this. The missing piece was, that this only happens, when the last output is disconnected (even if just temporarily), which is why I wasn't able to reproduce this earlier.\n\nI bunch of this code was refactored when focus-follows-cursor was introduced, which caused some subtle regressions, which only surfaced after some other fixes to output hotplug. At last that logic should be sound now.","author_login":"Drakulix","author_association":"MEMBER","created_at":"2024-12-16T19:20:05+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2546445376","fragment_type":"issue_comment","sequence":12,"text":"Closing for now. Please comment if you can still reproduce on latest master (preferably with reproducing steps and/or a stack trace). I'll re-open this issue should we find another cause.","author_login":"Drakulix","author_association":"MEMBER","created_at":"2024-12-16T19:21:24+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2548830358","fragment_type":"issue_comment","sequence":13,"text":"Thank you @Drakulix , verified working with the latest update.","author_login":"zsilet","author_association":"NONE","created_at":"2024-12-17T15:51:20+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2549688768","fragment_type":"issue_comment","sequence":14,"text":"Working for me too on\n\n$ rpm -q cosmic-comp\ncosmic-comp-1.0.0~alpha.4^git20241216.7ac204e-1.fc41.x86_64","author_login":"gmpinder","author_association":"NONE","created_at":"2024-12-17T21:36:28+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566461154","fragment_type":"issue_comment","sequence":15,"text":"Can confirm my crash is also fixed. Thank you very much, this was the last blocker to me trying out Cosmic full time!","author_login":"RingOfStorms","author_association":"NONE","created_at":"2024-12-31T13:36:12+08:00","repo_name":"pop-os/cosmic-comp","issue_id":2567949374,"issue_number":906,"issue_url":"https://github.com/pop-os/cosmic-comp/issues/906","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0224","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Need some basic help!","query_context":"Hi,\n\nFirstly, I want to express my gratitude to the team for their outstanding work on this project. Over the past three years, I've had the pleasure of successfully utilizing Boost::Beast, which has given me a deep appreciation for the power of ASIO. Additionally, I've been intrigued by the potential of integrating gRPC into my projects, but I've found it challenging due to my lack of confidence in the build process. To address this, I took the initiative to learn tools such as CMake, Conan, and a bit of Bazel.\n\nYour work has particularly caught my attention because it combines the strengths of both ASIO and gRPC. I've spent several days attempting to integrate it into my projects using both CMake and Conan, but unfortunately, I haven't had much success. Despite this setback, I'm determined not to give up.\n\nI'm seeking your advice on how frameworks like this can be more easily integrated. Perhaps there's a secret sauce that I'm missing, and I'm struggling to identify where I can learn more about it.\n\nFor instance, my goal is to develop a C++ server using asio-grpc to serve clients written in PHP and Python, seamlessly exchanging protobuf messages. I'm also interested in creating a trimmed version of my server, which currently relies on Boost::Beast.\n\nGiven these use cases, the codebase appears somewhat daunting to me. Could you please provide guidance on the steps involved in building this library as a standalone component, enabling me to integrate it into my project effortlessly?\n\n1. Find the package using 'find_package'\n2. What paths to be added to \"target_include_directories\"\n3. What libs are to be added to \"target_link_libraries\"\n\nAs said, I tried with `Conan` and did \"install\" using the below CMakeLIsts.txt, but I ran into several LINK errors:\n\n**CMakeLists.txt**\n\ncmake_minimum_required(VERSION 3.15)\n\nproject(asio_example CXX)\n\n# Minimum C++ standard\nset(CMAKE_CXX_STANDARD 20)\n\nfind_package(ASIO-GRPC REQUIRED)\n\nadd_executable(${PROJECT_NAME} src/file-transfer-server.cpp)\n\ntarget_link_libraries(${PROJECT_NAME} PRIVATE asio-grpc::asio-grpc )\n\n**Install command**\n\nconan install . --output-folder=build --build=missing -s compiler.cppstd=20\n\n**LINK Errors**\n\nlibprotobuf-lite.lib(libprotobuf-lite.dll) : error LNK2005: \"public: virtual __cdecl google::protobuf::io::StringOutputStream::~StringOutputStream(void)\" (??1Str \ningOutputStream@io@protobuf@google@@UEAA@XZ) already defined in libprotobuf.lib(message_differencer.obj) [C:\\Users\\thavi\\.conan2\\p\\b\\grpc67bcbddea9216\\b\\bu \nild\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: bool __cdecl google::protobuf::ServiceDescriptor::GetSourceLocation(struct google::protobuf::SourceLoc \nation *)const \" (?GetSourceLocation@ServiceDescriptor@protobuf@google@@QEBA_NPEAUSourceLocation@23@@Z) already defined in libprotobuf.lib(descriptor.obj) [C:\\Use \nrs\\thavi\\.conan2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: class google::protobuf::Descriptor const * __cdecl google::protobuf::MethodDescriptor::input_type(void \n)const \" (?input_type@MethodDescriptor@protobuf@google@@QEBAPEBVDescriptor@23@XZ) already defined in libprotobuf.lib(descriptor.obj) [C:\\Users\\thavi\\.conan \n2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: class google::protobuf::Descriptor const * __cdecl google::protobuf::MethodDescriptor::output_type(voi \nd)const \" (?output_type@MethodDescriptor@protobuf@google@@QEBAPEBVDescriptor@23@XZ) already defined in libprotobuf.lib(descriptor.obj) [C:\\Users\\thavi\\.con \nan2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: bool __cdecl google::protobuf::MethodDescriptor::GetSourceLocation(struct google::protobuf::SourceLoca \ntion *)const \" (?GetSourceLocation@MethodDescriptor@protobuf@google@@QEBA_NPEAUSourceLocation@23@@Z) already defined in libprotobuf.lib(descriptor.obj) [C:\\Users \n\\thavi\\.conan2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: bool __cdecl google::protobuf::FileDescriptor::GetSourceLocation(class std::vector<int,class std::allo \n\nApologies for any inconvenience caused, but I'm genuinely eager to learn and gain knowledge about the build process, particularly because I'm enthusiastic about utilizing this library. So whatever guidance and pointers you could give, i will be really grateful to you. \n\nThanks,\nTharma","known_context_document_ids":["gh_issue_2138780352"],"reference_answer":"This appears to have been resolved in VS2019 update 16.11.\n\nOn a side note: 16.11 was the first version to fully support C++20. In general, I would not expect `std:c++latest` to actually be stable or conformant, since it will often cover a not-yet-ratified standard (draft C++23 as of 16.11) with bugs of its own.","answer_document_id":"gh_comment_937432062","silver_evidence_path":["gh_comment_1950278632","gh_issue_909932141","gh_comment_937432062"],"evidence_issue_ids":[2138780352,909932141],"source_repo_name":"Tradias/asio-grpc","source_issue_id":2138780352,"source_issue_number":97,"source_issue_url":"https://github.com/Tradias/asio-grpc/issues/97","target_repo_name":"protocolbuffers/protobuf","target_issue_id":909932141,"target_issue_number":8688,"target_issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","reference_anchor_document_id":"gh_comment_1950278632","reference_answer_author":"dlj-NaN","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1622,"anchor_target_overlap":0.1622,"target_answer_overlap":0.2593},"issue_created_at":"2024-02-16T14:50:58+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2138780352","fragment_type":"issue_description","sequence":0,"text":"Need some basic help!\nHi,\n\nFirstly, I want to express my gratitude to the team for their outstanding work on this project. Over the past three years, I've had the pleasure of successfully utilizing Boost::Beast, which has given me a deep appreciation for the power of ASIO. Additionally, I've been intrigued by the potential of integrating gRPC into my projects, but I've found it challenging due to my lack of confidence in the build process. To address this, I took the initiative to learn tools such as CMake, Conan, and a bit of Bazel.\n\nYour work has particularly caught my attention because it combines the strengths of both ASIO and gRPC. I've spent several days attempting to integrate it into my projects using both CMake and Conan, but unfortunately, I haven't had much success. Despite this setback, I'm determined not to give up.\n\nI'm seeking your advice on how frameworks like this can be more easily integrated. Perhaps there's a secret sauce that I'm missing, and I'm struggling to identify where I can learn more about it.\n\nFor instance, my goal is to develop a C++ server using asio-grpc to serve clients written in PHP and Python, seamlessly exchanging protobuf messages. I'm also interested in creating a trimmed version of my server, which currently relies on Boost::Beast.\n\nGiven these use cases, the codebase appears somewhat daunting to me. Could you please provide guidance on the steps involved in building this library as a standalone component, enabling me to integrate it into my project effortlessly?\n\n1. Find the package using 'find_package'\n2. What paths to be added to \"target_include_directories\"\n3. What libs are to be added to \"target_link_libraries\"\n\nAs said, I tried with `Conan` and did \"install\" using the below CMakeLIsts.txt, but I ran into several LINK errors:\n\n**CMakeLists.txt**\n\ncmake_minimum_required(VERSION 3.15)\n\nproject(asio_example CXX)\n\n# Minimum C++ standard\nset(CMAKE_CXX_STANDARD 20)\n\nfind_package(ASIO-GRPC REQUIRED)\n\nadd_executable(${PROJECT_NAME} src/file-transfer-server.cpp)\n\ntarget_link_libraries(${PROJECT_NAME} PRIVATE asio-grpc::asio-grpc )\n\n**Install command**\n\nconan install . --output-folder=build --build=missing -s compiler.cppstd=20\n\n**LINK Errors**\n\nlibprotobuf-lite.lib(libprotobuf-lite.dll) : error LNK2005: \"public: virtual __cdecl google::protobuf::io::StringOutputStream::~StringOutputStream(void)\" (??1Str \ningOutputStream@io@protobuf@google@@UEAA@XZ) already defined in libprotobuf.lib(message_differencer.obj) [C:\\Users\\thavi\\.conan2\\p\\b\\grpc67bcbddea9216\\b\\bu \nild\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: bool __cdecl google::protobuf::ServiceDescriptor::GetSourceLocation(struct google::protobuf::SourceLoc \nation *)const \" (?GetSourceLocation@ServiceDescriptor@protobuf@google@@QEBA_NPEAUSourceLocation@23@@Z) already defined in libprotobuf.lib(descriptor.obj) [C:\\Use \nrs\\thavi\\.conan2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: class google::protobuf::Descriptor const * __cdecl google::protobuf::MethodDescriptor::input_type(void \n)const \" (?input_type@MethodDescriptor@protobuf@google@@QEBAPEBVDescriptor@23@XZ) already defined in libprotobuf.lib(descriptor.obj) [C:\\Users\\thavi\\.conan \n2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: class google::protobuf::Descriptor const * __cdecl google::protobuf::MethodDescriptor::output_type(voi \nd)const \" (?output_type@MethodDescriptor@protobuf@google@@QEBAPEBVDescriptor@23@XZ) already defined in libprotobuf.lib(descriptor.obj) [C:\\Users\\thavi\\.con \nan2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: bool __cdecl google::protobuf::MethodDescriptor::GetSourceLocation(struct google::protobuf::SourceLoca \ntion *)const \" (?GetSourceLocation@MethodDescriptor@protobuf@google@@QEBA_NPEAUSourceLocation@23@@Z) already defined in libprotobuf.lib(descriptor.obj) [C:\\Users \n\\thavi\\.conan2\\p\\b\\grpc67bcbddea9216\\b\\build\\grpc_ruby_plugin.vcxproj]\nlibprotobuf.lib(libprotobuf.dll) : error LNK2005: \"public: bool __cdecl google::protobuf::FileDescriptor::GetSourceLocation(class std::vector<int,class std::allo \n\nApologies for any inconvenience caused, but I'm genuinely eager to learn and gain knowledge about the build process, particularly because I'm enthusiastic about utilizing this library. So whatever guidance and pointers you could give, i will be really grateful to you. \n\nThanks,\nTharma","author_login":"vtharmalingam","author_association":"NONE","created_at":"2024-02-16T14:50:58+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1948625702","fragment_type":"issue_comment","sequence":1,"text":"Hi, thanks for your detailed report. I personally do not use conan but I have a little project where I smoketest asio-grpc with conan. Using default setting with MSVC it builds static libraries for me, for you it seems like you have selected shared libraries (at least for protobuf) and now tries to link with both `libprotobuf-lite` and regular `libprotobuf`. I tried to reproduce that without luck.\n\nHere is the `conanfile.txt` that I used for the reproduction:\n\n[requires]\nasio-grpc/2.9.2\n\n[generators]\nCMakeDeps\nCMakeToolchain\n\n[layout]\ncmake_layout\n\n[options]\nprotobuf/*:shared=True\n\nAfter running the conan install command, I do \n\ncmake --build --preset conan-release","author_login":"Tradias","author_association":"OWNER","created_at":"2024-02-16T15:30:35+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949855537","fragment_type":"issue_comment","sequence":2,"text":"Thank you so much @Tradias for your quick response! \nFurther, I moved to CMake instead, and still face a last bit of problems as stated below in getting my feet wet on this package:\n\nI followed the below instructions of the README.md, and it was **successful** in installing the library.\nThough I do not understand the significance of \"lib\" folder inside the install directory is filled with many cmake files. Maybe that got anything to with my problem, not sure...\n\nimage\n\nIn stage 2, where I wanted to integrate the library to my target. Here is the snippet of **CMakeLists.txt** that builds my target linking asio-grpc:\n\nset (CMAKE_PREFIX_PATH C:/Users/Downloads/asio-grpc/install)\nfind_package(asio-grpc)\n\n## ...\n\nadd_executable(WT hello-world-server.cpp ${HEADERS} ${SOURCES} )\n\n##...\n\n# Specify include directories if your project has header files in multiple directories.\ntarget_include_directories(WT \n PRIVATE\n #asio-grpc\n ${CMAKE_PREFIX_PATH}/include\n ${CMAKE_SOURCE_DIR}/helper\n \n #... \n)\n\ntarget_link_libraries(WT \n PUBLIC \n \n asio-grpc::asio-grpc\n Boost::headers\n\n #..\n)\n \n\nAfter configuring my CMakeLists.txt, when I **build** it, I get the below error:\n\nC:\\thavi\\CPP_WS\\asio-grpc-experiment\\helper\\awaitable_server_rpc.hpp(24,41): error C2039: 'use_awaitable_t': is not a member of 'boost::asio' [C:\\TH\nARMA\\CPP_WS\\asio-grpc-experiment\\build64\\WT.vcxproj]\nC:/thavi/vcpkg/installed/x64-windows/include\\boost/asio/ssl/stream.hpp(39,11): message : see declaration of 'boost::asio' [C:\\thavi\\CPP_WS\\mt5\\manager\\mt5_ib_to \nolstandalone\\build64\\WT.vcxproj]\nC:\\thavi\\CPP_WS\\asio-grpc-experiment\\helper\\awaitable_server_rpc.hpp(24): error C2061: syntax error: identifier 'use_awaitable_t' [C:\\thavi\\CPP_WS\\ \nasio-grpc-experiment\\build64\\WT.vcxproj]\nC:\\thavi\\CPP_WS\\asio-grpc-experiment\\helper\\awaitable_server_rpc.hpp(24,60): error C2039: 'as_default_on_t': is not a member of '`global namespace'' \n [C:\\thavi\\CPP_WS\\asio-grpc-experiment\\build64\\WT.vcxproj]\nC:\\thavi\\CPP_WS\\asio-grpc-experiment\\hello-world-server.cpp(16,1): fatal error C1083: Cannot open include file: 'helloworld/helloworld.grpc.pb.h': \nNo such file or directory [C:\\thavi\\CPP_WS\\asio-grpc-experiment\\build64\\WT.vcxproj]\n\nPrimarily the issue is about missing \"use_awaitable_t\"... not clear if my verion of Boost::asio (1.75) is missing it perhaps? \nMaybe you can take a look at my environment (snapshot below):\n\nimage\n\n**Other general question**:\nSince it is a header-only library, why do we need to link \"asio-grpc::asio-grpc\". Sorry for the basic question.\n\nThanks for your help in advance!\n\nThanks,\nTharma","author_login":"vtharmalingam","author_association":"NONE","created_at":"2024-02-17T06:59:28+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949905112","fragment_type":"issue_comment","sequence":3,"text":"In the long run I highly recommend using a package manager. At work and personally I use vcpkg.\n\nI assume in your CMake you forgot to add:\n\ncmake\ntarget_compile_features(WT PRIVATE cxx_std_20)\n\nSpecifying a target in `target_link_libraries` is CMake's magic way of propagating any kind of build requirements to your target. This includes: libraries to link, directories to include, pre-processor definitions, compile features/flags, .... In the case of asio-grpc that would be linking with `gRPC::grpc++`, enabling compile feature `cxx_std_17` and adding pre-processor definition `AGRPC_BOOST_ASIO`. In general it is a good idea to specify all direct dependencies in a `target_link_libraries` call, regardless of whether they are header-only or compiled.\n\nAlso at some point you will have to generate source code from `.proto` files. You can do so using asio-grpc's helper function:\n\ncmake\nasio_grpc_protobuf_generate(\n GENERATE_GRPC\n TARGET WT\n IMPORT_DIRS \"${CMAKE_CURRENT_SOURCE_DIR}\"\n PROTOS \"${CMAKE_CURRENT_SOURCE_DIR}/proto/helloworld/helloworld.proto\")","author_login":"Tradias","author_association":"OWNER","created_at":"2024-02-17T08:49:39+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950260804","fragment_type":"issue_comment","sequence":4,"text":"Thank you so much! I had a valuable learning experience with this cmake function, target_compile_features. Additionally, I proceeded with \"vcpkg\" as you suggested, and I must say, I found it to be incredibly user-friendly.\n\nRegarding the linking errors, you were absolutely correct! When I replaced cxx_std_17 with cxx_std_20 in the code below, the issues were resolved:\n\ntarget_compile_features(WT PRIVATE cxx_std_20)\n\nWith that, I could \"configure\" (`cmake . -B ./build`) without any error.\nBut when I \"build\" (` cmake --build ./build --config Release` or `cmake --build ./build --config Debug` ), \n**I face just these two errors** (details below):\n\nC:/Users/thavi/Downloads/asio-grpc/install/include\\agrpc/detail/register_awaitable_rpc_handler.hpp(58,15): error C2672: 'co_spawn': \nno matching overloaded function found\n\nC:\\thavi\\build\\generated\\helloworld\\helloworld.pb.cc(43,80): error C2127: 'helloworld::_HelloReply \n_default_instance_': illegal initialization of 'constinit' entity with a non-constant expression\n\nI was wondering if you could provide guidance on this as well? Thanks for your help, in advance.\n\nThanks,\nTharma","author_login":"vtharmalingam","author_association":"NONE","created_at":"2024-02-17T17:18:31+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950278632","fragment_type":"issue_comment","sequence":5,"text":"Here is a complete minimal gRPC helloworld example: URL \n\nThe `register_awaitable_rpc_handler.hpp` error seems to be a Boost 1.75 specific thing where asio forgot to add type traits for `executor_with_default` of `asio::use_awaitable_t` and misdetects MSVC's `decltype` capabilities. Nothing I can do on my side but if you use the example above that won't be an issue (because it will use Boost 1.83).\n\nThe protobuf error is this one URL and was fixed in a later protobuf release. Again, none issue if you use my example.","author_login":"Tradias","author_association":"OWNER","created_at":"2024-02-17T18:34:30+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[909932141],"is_known_query_context":false},{"document_id":"gh_comment_1956159430","fragment_type":"issue_comment","sequence":6,"text":"It very much sounds like a gRPC issue, I don't think I am the right person to help here. I suspect it has something to do with the flags you used when compiling gRPC, maybe a mix of `/MD` and `/MT`. You could try the following, but I doubt it will help:\n\ncmake\nset(ASIO_GRPC_DISABLE_AUTOLINK on)\nfind_package(asio-grpc)\nfind_package(gRPC)\n \ntarget_link_libraries(your_app PUBLIC asio-grpc::asio-grpc gRPC::grpc++)","author_login":"Tradias","author_association":"OWNER","created_at":"2024-02-21T08:49:12+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1956417795","fragment_type":"issue_comment","sequence":7,"text":"Sure, thank you, @Tradias. I will dig further into this.\n\nThanks,\nTharma","author_login":"vtharmalingam","author_association":"NONE","created_at":"2024-02-21T11:09:55+08:00","repo_name":"Tradias/asio-grpc","issue_id":2138780352,"issue_number":97,"issue_url":"https://github.com/Tradias/asio-grpc/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_909932141","fragment_type":"issue_description","sequence":0,"text":"vs2019 update 16.10 : illegal initialization of `constinit` entity with a non-constant expression\n**What version of protobuf and what language are you using?**\n\nVersion: `2021-04-07 version 3.15.8`\nLanguage: C++\n\n**What operating system (Linux, Windows, ...) and version?**\n\nWindows.\n\n**What runtime / compiler are you using (e.g., python version or gcc version)**\n\nVisual Studio 2019 msvc **Update 19.10** . Latest version that just recently added support for `constinit` on May 25th - announcement here.\n\n**What did you do?**\n\nNothing horribly bad.. Steps to reproduce the behavior:\n1. Make sure the language set to C++20, `-std:c++latest`, e.g. for CMake that'd be `set(CMAKE_CXX_STANDARD 20)` .\n2. Try to compile some code that uses generated protobufs that include `port_def.inc` header .\n\n**What did you expect to see**\n\nCode compiles.\n\n**What did you see instead?**\n\nCode fails to compile with errors:\n\nimage\n\n**Patch Proposal**\n\nThe most trivial hacky patch would be to apply the same logic as applied for `__GNUC__` , the issue described in #8310 .\n\nAdding `!defined(_MSC_VER)` check - \"resolves\" the issue. And so `constinit` is not used:\n\ncpp\n// Our use of constinit does not yet work with GCC:\n// URL \n// Our use of constinit does not yet work with Visual Studio 2019 Update 16.10:\n// URL \n#if defined(__cpp_constinit) && !defined(__GNUC__) && !defined(_MSC_VER)\n#define PROTOBUF_CONSTINIT constinit\n\nAnd the code works great after that even with latest Visual Studio 2019 compiler. This could be used as an interim patch to unblock customers using the latest compiler.","author_login":"maxgolov","author_association":"NONE","created_at":"2021-06-02T22:24:00+08:00","repo_name":"protocolbuffers/protobuf","issue_id":909932141,"issue_number":8688,"issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_853840360","fragment_type":"issue_comment","sequence":1,"text":"@maxgolov Thanks for posting this, I am seeing the same. Do you know which version of VSCommunity and Build Tools *doesn't* have this issue? On my local computer, I have VSCommunity 16.9.0 with \n\n$ vcpkg list\ngrpc:x86-windows 1.33.1#2\nprotobuf:x64-windows 3.14.0#1\nprotobuf:x86-windows 3.14.0#1\n\nand everything compiles fine, but I have a Docker image where I am using 16.9.0 from chocolatey\n\n# Install Visual Studio, BuildTools, and compiler (CL.exe)\nRUN choco install visualstudio2019buildtools --version=16.9.0 -y\n# You need this one with you want CL.exe to exist\nRUN choco install visualstudio2019-workload-universalbuildtools -y --package-parameters \"--includeOptional\" --confirm\nRUN choco install visualstudio2019community --version=16.9.0 -y\n\nwith gRPC and Protobuf versions\n\ngrpc:x64-windows 1.37.0#2 An RPC library and framework\ngrpc[codegen]:x64-windows Build code generator machinery\nprotobuf:x64-windows 3.15.8#1 Protocol Buffers - Google's data interchange format\n\nand I still see this error in my Docker build image, even with 16.9.0","author_login":"netpoetica","author_association":"NONE","created_at":"2021-06-03T12:45:35+08:00","repo_name":"protocolbuffers/protobuf","issue_id":909932141,"issue_number":8688,"issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_854018434","fragment_type":"issue_comment","sequence":2,"text":"FWIW I changed my CXX flags to user c++17 instead of c++latest and I was able to get around this issue w/ Protobuf and MSBuild (in case this helps anyone in the future) - only c++latest gives this problem. I also did not need to downgrade MSbuild/VSCommunity as long as I changed those CXX flags (in my case, in CMake triggering MSBuild).","author_login":"netpoetica","author_association":"NONE","created_at":"2021-06-03T16:41:01+08:00","repo_name":"protocolbuffers/protobuf","issue_id":909932141,"issue_number":8688,"issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_854041811","fragment_type":"issue_comment","sequence":3,"text":"@netpoetica - bug report repro steps indicate that: `make sure the language set to C++20, -std:c++latest`. You can avoid the issue by setting compiler flag to earlier language standard. For some projects it is impractical or impossible, esp. if projects actually need the new C++20 language features.\n\nSince you are using `vcpkg` - you may workaround the issue by using `vcpkg` overlay to apply the patch. Take the contents from here: URL , then point `vcpkg` to custom location of the patched package as follows: `vcpkg install --overlay-ports=X:\\path\\to\\patched\\protobuf protobuf` .. I have submitted the proposed patch to `vcpkg`, but unsure how long it'd take to merge.","author_login":"maxgolov","author_association":"NONE","created_at":"2021-06-03T17:17:09+08:00","repo_name":"protocolbuffers/protobuf","issue_id":909932141,"issue_number":8688,"issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_937432062","fragment_type":"issue_comment","sequence":4,"text":"This appears to have been resolved in VS2019 update 16.11.\n\nOn a side note: 16.11 was the first version to fully support C++20. In general, I would not expect `std:c++latest` to actually be stable or conformant, since it will often cover a not-yet-ratified standard (draft C++23 as of 16.11) with bugs of its own.","author_login":"dlj-NaN","author_association":"COLLABORATOR","created_at":"2021-10-07T04:19:15+08:00","repo_name":"protocolbuffers/protobuf","issue_id":909932141,"issue_number":8688,"issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1178430780","fragment_type":"issue_comment","sequence":5,"text":"The issue seems to have unfixed itself at the moment: see #9698 and #10159","author_login":"jgcodes2020","author_association":"NONE","created_at":"2022-07-08T01:20:02+08:00","repo_name":"protocolbuffers/protobuf","issue_id":909932141,"issue_number":8688,"issue_url":"https://github.com/protocolbuffers/protobuf/issues/8688","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0225","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Duplicate FedEx tracking number 635213673400 still on Packages In transit screen even though receipted on 11/24/2023 (Biospecimen)?","query_context":"FedEx tracking number 635213673400 is still showing up on the Packages in Transit screen and in the In Transit Report even though it was receipted back on 11/24/2023.\nBackground to this tracking number: FedEx tracking number 635213673400 was used on 11/16/2023 to ship samples to BPTL from KPGA and again on 11/22/2023 to ship samples to BPTL from Chicago. This was a mistake on part of the BPTL team.\nThe second time it was used, it was recipted into the dashboard on 11/24/2023. \n\nThe tracking number is still showing up so BPTL tried to do a receipt of the package again on 12/1/2023 but the package still has not disappeared from the screen or the report.\nPlease look into why it is still showing up on the Packaged in Transit screen and In Transit report.","known_context_document_ids":["gh_issue_2021428259"],"reference_answer":"This issue is tough to diagnose because there doesn't seem to be a pattern to the failed writes.\n\nThere was a potential issue with the db write operation. These writes were being executed separately and individually, in a way where some could succeed, others could fail, and the user processing the package receipt wouldn't know anything was amiss.\n\nThis update will restructure the way the write operation is handled. The receipted box and specimens in the box will be written in a batch - either 100% pass or 100% fail. Error handling will be implemented to trace any error's source and show a useful error message in the BPTL dashboard. This way, if we have future errors, we'll have a better handle on the source. In the failed cases, it's possible a simple retry will succeed.\n\nAdditionally, we're implementing a check to make sure a box hasn't already been marked received. This should solve the possibility of accidentally scanning a tracking number twice in the 'package receipt' form. Now, if a package has already been received, the user will receive a warning about the already received status. Clicking 'cancel' will terminate the operation, clicking 'continue' will process the double receipt and add a `'forceWriteOverride' = true` property to the box.\n\nThe PR should be out for review tomorrow. Please let me know if any changes are requested to this update.\n\nBox - accidental double receipt screenshots (from dev):\n<img width=\"1185\" alt=\"Screenshot 2023-11-16 at 4 04 34 PM\" src=\" URL \n<img width=\"964\" alt=\"Screenshot 2023-11-16 at 4 06 08 PM\" src=\" URL","answer_document_id":"gh_comment_1815354345","silver_evidence_path":["gh_comment_1845683617","gh_issue_1993249490","gh_comment_1815354345"],"evidence_issue_ids":[2021428259,1993249490],"source_repo_name":"episphere/connect","source_issue_id":2021428259,"source_issue_number":834,"source_issue_url":"https://github.com/episphere/connect/issues/834","target_repo_name":"episphere/connect","target_issue_id":1993249490,"target_issue_number":819,"target_issue_url":"https://github.com/episphere/connect/issues/819","reference_anchor_document_id":"gh_comment_1845683617","reference_answer_author":"JoeArmani","reference_answer_author_association":"COLLABORATOR","quality_score":87.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2162,"anchor_target_overlap":0.1935,"target_answer_overlap":0.0833},"issue_created_at":"2023-12-01T19:01:00+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2021428259","fragment_type":"issue_description","sequence":0,"text":"Duplicate FedEx tracking number 635213673400 still on Packages In transit screen even though receipted on 11/24/2023 (Biospecimen)\nFedEx tracking number 635213673400 is still showing up on the Packages in Transit screen and in the In Transit Report even though it was receipted back on 11/24/2023.\nBackground to this tracking number: FedEx tracking number 635213673400 was used on 11/16/2023 to ship samples to BPTL from KPGA and again on 11/22/2023 to ship samples to BPTL from Chicago. This was a mistake on part of the BPTL team.\nThe second time it was used, it was recipted into the dashboard on 11/24/2023. \n\nThe tracking number is still showing up so BPTL tried to do a receipt of the package again on 12/1/2023 but the package still has not disappeared from the screen or the report.\nPlease look into why it is still showing up on the Packaged in Transit screen and In Transit report.","author_login":"wyattks","author_association":"COLLABORATOR","created_at":"2023-12-01T19:01:00+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1845683617","fragment_type":"issue_comment","sequence":1,"text":"**Initial notes:**\nThis is a separate issue from missing tube received timestamps but stems from the same ‘receive packages’ function.\nLink to that issue: URL \n\nThe two boxes involved:\nBox440 - shipment submitted 11/16/2023\nBox972 - shipment submitted 11/22/2023\n\nBox440:\n•marked ‘received’ and has received timestamp 12/04/2023.\nSpecimens in box 440 have received timestamp:\nspecimen level - 12/4/2023\ntube level - 12/4/2023\ntube level, mouthwash - no mouthwash tube for collection\n\nBox972:\n•marked ‘not received’ and does not have received timestamp.\n•Specimens in Box972 have received timestamp:\nspecimen level 12/4/2023\ntube level, non-mouthwash 12/4/2023\ntube level, mouthwash - 11/24/2023\n\nThe ‘receive packages’ function searched for this tracking number and probably executed correctly the first time.\nThe second time, it got a list of both boxes (duplicate tracking numbers), and defaulted to picking the first one. There’s no currently logic to tell it which box to pick when setting the received timestamp. We should have more specific logic here so duplicate tracking numbers aren't an issue in the future.\n\n**Action:**\nTighten up the logic & conditions used in the ‘receive packages’ function so it knows what box to pick in a duplicate tracking number scenario.\n\nWe have a couple of options here, but I need to recreate this with duplicate tracking numbers in dev and run testing to find the most reliable method for selecting the right box in a duplicate tracking number scenario.\n\nI’ll roll it into the ‘receive packages’ function update I’m currently working on. That's a full stack update with changes on the BPTL end and in ConnectFaas. This will pair well with the ‘package already received’ functionality I'm building.","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-07T16:45:46+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[1993249490],"is_known_query_context":false},{"document_id":"gh_comment_1847850465","fragment_type":"issue_comment","sequence":2,"text":"With this update, any time duplicate tracking numbers are found, a scrollable, selectable list of possible box matches will be returned to the BPTL user (ordered by recency).\n\nThe BPTL user can manually verify the box based on boxID, shipping date, origin site, and received date (listed as 'not yet received' if new), and select the box to continue processing the shipment. After selecting a box and clicking continue, the receipt process will be handled as expected.\n\n<img width=\"935\" alt=\"Screenshot 2023-12-08 at 3 31 52 PM\" src=\" URL","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-08T21:14:15+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847873560","fragment_type":"issue_comment","sequence":3,"text":"Re: GitHub Project Board - this issue moves with URL I'm Leaving 819 in the development category during the review cycle to avoid confusion.","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-08T21:38:28+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[1993249490],"is_known_query_context":false},{"document_id":"gh_comment_1847881617","fragment_type":"issue_comment","sequence":4,"text":"Thanks @StephanieWeinstein. I was really under the gun time-wise because of our dev freeze EOD today, so if we find anything that needs fine-tuning that can certainly happen!","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-08T21:45:39+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852735607","fragment_type":"issue_comment","sequence":5,"text":"Domonique tested it in Dev and it worked. Se issue #819 for her comment","author_login":"wyattks","author_association":"COLLABORATOR","created_at":"2023-12-12T20:13:39+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[1993249490],"is_known_query_context":false},{"document_id":"gh_comment_1852739466","fragment_type":"issue_comment","sequence":6,"text":"image\nmy test shows error when adding FedEx number in shipping daashboard that is a duplicate.","author_login":"wyattks","author_association":"COLLABORATOR","created_at":"2023-12-12T20:16:46+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852832691","fragment_type":"issue_comment","sequence":7,"text":"@wyattks Yep, that confused me at first. I traced it out because I was unfamiliar with it -- that warning was implemented to be site-specific, so it does not catch duplicates across different sites, which is (I think) what happened in the case of this issue. One shipment from Chicago, another from KPGA.\n\nI considered this box selection to be a more flexible solution...and also to serve as a code template for other parts of our apps that need similar response flexibility from the server in the future.\n\nWe can also strengthen this duplicate tracking number warning in the future or remove it...whatever your team decides.\n\nPlease let me know if you need me to set any custom data on the back end in dev so you can test the solution as if the boxes came from different sites. Thanks.","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-12T21:23:53+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852852447","fragment_type":"issue_comment","sequence":8,"text":"Just so my previous comment doesn't obscure the status:\nThis is tested in dev and ready for stage.","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-12T21:40:24+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1858530421","fragment_type":"issue_comment","sequence":9,"text":"Tested receipt of duplicated FedEx ID. Worked as expected.\n\nImage\n\nReady for production","author_login":"wyattks","author_association":"COLLABORATOR","created_at":"2023-12-15T21:50:40+08:00","repo_name":"episphere/connect","issue_id":2021428259,"issue_number":834,"issue_url":"https://github.com/episphere/connect/issues/834","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1993249490","fragment_type":"issue_description","sequence":0,"text":"Missing Tube-Level BPTL Received Dates in Biospecimen Table\n*Repeat occurrence of #653* \n\nThe following Connect IDs are missing at least one tube-level BPTL received date in the biospecimen table. The received dates _are_ present in the Boxes table.\n\n- 9375710580 (HFH)\n \nRecord Date = 2022-06-24T00:00:00.000Z\n\n- 3080768933 (HFH)\n \nRecord Date = 2022-06-24T00:00:00.000Z\n\n- 3409243008 (UCM)\n \n \n \n \n \n \nRecord Date = 2023-10-23T00:00:00.000Z\n\n-8193439990 (MFC)\n \n \nRecord Date = 2022-11-09T00:00:00.000Z\n\n- 5743151720 (MFC)\n \nRecord Date = 2023-07-11T00:00:00.000Z","author_login":"HopkinsDC","author_association":"COLLABORATOR","created_at":"2023-11-14T17:48:02+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1815354345","fragment_type":"issue_comment","sequence":1,"text":"This issue is tough to diagnose because there doesn't seem to be a pattern to the failed writes.\n\nThere was a potential issue with the db write operation. These writes were being executed separately and individually, in a way where some could succeed, others could fail, and the user processing the package receipt wouldn't know anything was amiss.\n\nThis update will restructure the way the write operation is handled. The receipted box and specimens in the box will be written in a batch - either 100% pass or 100% fail. Error handling will be implemented to trace any error's source and show a useful error message in the BPTL dashboard. This way, if we have future errors, we'll have a better handle on the source. In the failed cases, it's possible a simple retry will succeed.\n\nAdditionally, we're implementing a check to make sure a box hasn't already been marked received. This should solve the possibility of accidentally scanning a tracking number twice in the 'package receipt' form. Now, if a package has already been received, the user will receive a warning about the already received status. Clicking 'cancel' will terminate the operation, clicking 'continue' will process the double receipt and add a `'forceWriteOverride' = true` property to the box.\n\nThe PR should be out for review tomorrow. Please let me know if any changes are requested to this update.\n\nBox - accidental double receipt screenshots (from dev):\n<img width=\"1185\" alt=\"Screenshot 2023-11-16 at 4 04 34 PM\" src=\" URL \n<img width=\"964\" alt=\"Screenshot 2023-11-16 at 4 06 08 PM\" src=\" URL","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-11-16T21:37:42+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1816723870","fragment_type":"issue_comment","sequence":2,"text":"Update: After discussion with @HopkinsDC, the desired behavior on override (2nd receipt):\n\n(1) received specimens: use new date or retain old date? --- **Retain old date** \n(2) unreceived specimens: use new data or use old date? --- **Use new date**\n(3) Full specimen received timestamp: use new date or retain old date? --- **Retain old date** \n(4) box received timestamp: use new date or retain old date? --- **Retain old date**","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-11-17T16:26:31+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1830416544","fragment_type":"issue_comment","sequence":3,"text":"Work is still ongoing - 11/28 Dec release. Sandra to add to Punchlist.","author_login":"sonyekere","author_association":"COLLABORATOR","created_at":"2023-11-28T18:11:48+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847875790","fragment_type":"issue_comment","sequence":4,"text":"Re: GitHub Project Board - This issue moves alongside URL I'm leaving this out of the 'reviews' sections to avoid confusion.","author_login":"JoeArmani","author_association":"COLLABORATOR","created_at":"2023-12-08T21:40:17+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852410929","fragment_type":"issue_comment","sequence":5,"text":"Issue tested in dev. Ready for stage.\n\nScreenshot 2023-12-12 at 11 37 26 AM","author_login":"HopkinsDC","author_association":"COLLABORATOR","created_at":"2023-12-12T16:42:24+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1860877590","fragment_type":"issue_comment","sequence":6,"text":"Tested in stage. Ready for production.\nScreenshot 2023-12-18 at 10 52 26 AM","author_login":"HopkinsDC","author_association":"COLLABORATOR","created_at":"2023-12-18T15:52:53+08:00","repo_name":"episphere/connect","issue_id":1993249490,"issue_number":819,"issue_url":"https://github.com/episphere/connect/issues/819","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0226","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"ccall segfault on adopt_threads on win32?","query_context":"Been seeing this sometimes on CI lately. At first I assumed it was an OOM, but the backtrace doesn't really align well with that hypothesis, so this probably needs to be looked into more closely.\n\n From worker 9:\n From worker 9: Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.\n From worker 9: Exception: EXCEPTION_ACCESS_VIOLATION at 0x746ed01d -- jl_makecontext at C:/workdir/src\\win32_ucontext.c:61\n From worker 9: in expression starting at C:\\buildkite-agent\\builds\\win2k22-amdci6-2\\julialang\\julia-master\\julia-1aa59a6e07\\share\\julia\\test\\ccall.jl:1066\n From worker 9: jl_makecontext at C:/workdir/src\\win32_ucontext.c:61\n From worker 9: jl_init_root_task at C:/workdir/src\\task.c:1559\n From worker 9: ijl_adopt_thread at C:/workdir/src\\threading.c:407\n From worker 9: unknown function (ip: 3b4ce4af)\n From worker 9: jl_work_wrapper at C:/workdir/src\\jl_uv.c:987\n From worker 9: uv__queue_work at /workspace/srcdir/libuv\\src\\threadpool.c:305\n From worker 9: worker at /workspace/srcdir/libuv\\src\\threadpool.c:122\n From worker 9: uv__thread_start at /workspace/srcdir/libuv\\src/win\\thread.c:111\n From worker 9: beginthreadex at C:\\Windows\\System32\\msvcrt.dll (unknown line)\n From worker 9: endthreadex at C:\\Windows\\System32\\msvcrt.dll (unknown line)\n From worker 9: BaseThreadInitThunk at C:\\Windows\\System32\\KERNEL32.DLL (unknown line)\n From worker 9: RtlGetFullPathName_UEx at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\n From worker 9: RtlGetFullPathName_UEx at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\n From worker 9: Allocations: 406330629 (Pool: 406147582; Big: 183047); GC: 1166\nWorker 9 terminated.\n\n URL","known_context_document_ids":["gh_issue_1444144964"],"reference_answer":"This is likely not a Julia issue. Windows will throw this error on a double free. \n\nSince the stacktrace goes through:\n\nft_bfmmf at C:\\Users\\runneradmin\\.julia\\artifacts\\2f4394502c5b9c9863425335a6140d4bfd02153b\\bin\\libfasttransforms.dll (unknown line)\n\nIt is likely an issue in the library itself.","answer_document_id":"gh_comment_1455821027","silver_evidence_path":["gh_comment_1587169227","gh_issue_1611029884","gh_comment_1455821027"],"evidence_issue_ids":[1444144964,1611029884],"source_repo_name":"JuliaLang/julia","source_issue_id":1444144964,"source_issue_number":47532,"source_issue_url":"https://github.com/JuliaLang/julia/issues/47532","target_repo_name":"JuliaLang/julia","target_issue_id":1611029884,"target_issue_number":48907,"target_issue_url":"https://github.com/JuliaLang/julia/issues/48907","reference_anchor_document_id":"gh_comment_1587169227","reference_answer_author":"vchuravy","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.3889,"target_answer_overlap":0.5417},"issue_created_at":"2022-11-10T15:50:42+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1444144964","fragment_type":"issue_description","sequence":0,"text":"ccall segfault on adopt_threads on win32\nBeen seeing this sometimes on CI lately. At first I assumed it was an OOM, but the backtrace doesn't really align well with that hypothesis, so this probably needs to be looked into more closely.\n\n From worker 9:\n From worker 9: Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.\n From worker 9: Exception: EXCEPTION_ACCESS_VIOLATION at 0x746ed01d -- jl_makecontext at C:/workdir/src\\win32_ucontext.c:61\n From worker 9: in expression starting at C:\\buildkite-agent\\builds\\win2k22-amdci6-2\\julialang\\julia-master\\julia-1aa59a6e07\\share\\julia\\test\\ccall.jl:1066\n From worker 9: jl_makecontext at C:/workdir/src\\win32_ucontext.c:61\n From worker 9: jl_init_root_task at C:/workdir/src\\task.c:1559\n From worker 9: ijl_adopt_thread at C:/workdir/src\\threading.c:407\n From worker 9: unknown function (ip: 3b4ce4af)\n From worker 9: jl_work_wrapper at C:/workdir/src\\jl_uv.c:987\n From worker 9: uv__queue_work at /workspace/srcdir/libuv\\src\\threadpool.c:305\n From worker 9: worker at /workspace/srcdir/libuv\\src\\threadpool.c:122\n From worker 9: uv__thread_start at /workspace/srcdir/libuv\\src/win\\thread.c:111\n From worker 9: beginthreadex at C:\\Windows\\System32\\msvcrt.dll (unknown line)\n From worker 9: endthreadex at C:\\Windows\\System32\\msvcrt.dll (unknown line)\n From worker 9: BaseThreadInitThunk at C:\\Windows\\System32\\KERNEL32.DLL (unknown line)\n From worker 9: RtlGetFullPathName_UEx at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\n From worker 9: RtlGetFullPathName_UEx at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\n From worker 9: Allocations: 406330629 (Pool: 406147582; Big: 183047); GC: 1166\nWorker 9 terminated.\n\n URL","author_login":"vtjnash","author_association":"MEMBER","created_at":"2022-11-10T15:50:42+08:00","repo_name":"JuliaLang/julia","issue_id":1444144964,"issue_number":47532,"issue_url":"https://github.com/JuliaLang/julia/issues/47532","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1312285646","fragment_type":"issue_comment","sequence":1,"text":"Looking closer, this is the first memory write that should be going to the newly allocated stack for the backup copy-stack context. It should be 0x20 bytes from the very end of it. It should be 8MB large. We have about 2GB allocated in this process already at this time.\n\nThat seems to align with being an OOM, but we should defer allocation of the first copy-stack for a new thread until we are actually forced to need it. Many foreign threads probably won't make new tasks that would need to use it.","author_login":"vtjnash","author_association":"MEMBER","created_at":"2022-11-12T00:31:27+08:00","repo_name":"JuliaLang/julia","issue_id":1444144964,"issue_number":47532,"issue_url":"https://github.com/JuliaLang/julia/issues/47532","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1587169227","fragment_type":"issue_comment","sequence":2,"text":"@vtjnash long shot, but since this involves threading can this possibly be fixed by #50135? Also #48907 reported an `EXCEPTION_ACCESS_VIOLATION` error, but I don't know if this test would involve `libgomp` at any point.","author_login":"giordano","author_association":"CONTRIBUTOR","created_at":"2023-06-12T11:46:34+08:00","repo_name":"JuliaLang/julia","issue_id":1444144964,"issue_number":47532,"issue_url":"https://github.com/JuliaLang/julia/issues/47532","linked_issue_ids":[1611029884],"is_known_query_context":false},{"document_id":"gh_issue_1611029884","fragment_type":"issue_description","sequence":0,"text":"EXCEPTION_ACCESS_VIOLATION in FastTransforms tests\nSee the run URL the error message is:\n\njulia\nPlease submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.\nException: EXCEPTION_ACCESS_VIOLATION at 0x77e352b9 -- RtlGetCurrentServiceSessionId at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\nin expression starting at D:\\a\\FastTransforms.jl\\FastTransforms.jl\\test\\libfasttransformstests.jl:5\nRtlGetCurrentServiceSessionId at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\nRtlConstructCrossVmMutexPath at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\nRtlFreeHeap at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\nfree at C:\\Windows\\System32\\msvcrt.dll (unknown line)\nfree_team at /workspace/srcdir/gcc-12.1.0/libgomp\\team.c:237 [inlined]\ngomp_team_end at /workspace/srcdir/gcc-12.1.0/libgomp\\team.c:1005\nft_bfmmf at C:\\Users\\runneradmin\\.julia\\artifacts\\2f4394502c5b9c9863425335a6140d4bfd02153b\\bin\\libfasttransforms.dll (unknown line)\n* at D:\\a\\FastTransforms.jl\\FastTransforms.jl\\src\\libfasttransforms.jl:892 [inlined]\ntest_1d_plans at D:\\a\\FastTransforms.jl\\FastTransforms.jl\\test\\libfasttransformstests.jl:62\njl_fptr_args at C:/workdir/src\\gf.c:2138\n_jl_invoke at C:/workdir/src\\gf.c:2377 [inlined]\nijl_apply_generic at C:/workdir/src\\gf.c:2559\njl_apply at C:/workdir/src\\julia.h:1843 [inlined]\ndo_call at C:/workdir/src\\interpreter.c:126\neval_value at C:/workdir/src\\interpreter.c:215\neval_stmt_value at C:/workdir/src\\interpreter.c:166 [inlined]\neval_body at C:/workdir/src\\interpreter.c:594\neval_body at C:/workdir/src\\interpreter.c:522\neval_body at C:/workdir/src\\interpreter.c:522\njl_interpret_toplevel_thunk at C:/workdir/src\\interpreter.c:750\njl_toplevel_eval_flex at C:/workdir/src\\toplevel.c:906\njl_toplevel_eval_flex at C:/workdir/src\\toplevel.c:850\nijl_toplevel_eval at C:/workdir/src\\toplevel.c:915 [inlined]\nijl_toplevel_eval_in at C:/workdir/src\\toplevel.c:965\neval at .\\boot.jl:368 [inlined]\ninclude_string at .\\loading.jl:1428\njl_fptr_args at C:/workdir/src\\gf.c:2138\n_jl_invoke at C:/workdir/src\\gf.c:2358 [inlined]\nijl_apply_generic at C:/workdir/src\\gf.c:2559\n_include at .\\loading.jl:1488\ninclude at .\\client.jl:476\nunknown function (ip: 10660535)\n_jl_invoke at C:/workdir/src\\gf.c:2358 [inlined]\nijl_apply_generic at C:/workdir/src\\gf.c:2559\njl_apply at C:/workdir/src\\julia.h:1843 [inlined]\ndo_call at C:/workdir/src\\interpreter.c:126\neval_value at C:/workdir/src\\interpreter.c:215\neval_stmt_value at C:/workdir/src\\interpreter.c:166 [inlined]\neval_body at C:/workdir/src\\interpreter.c:594\njl_interpret_toplevel_thunk at C:/workdir/src\\interpreter.c:750\njl_toplevel_eval_flex at C:/workdir/src\\toplevel.c:906\njl_toplevel_eval_flex at C:/workdir/src\\toplevel.c:850\nijl_toplevel_eval at C:/workdir/src\\toplevel.c:915 [inlined]\nijl_toplevel_eval_in at C:/workdir/src\\toplevel.c:965\neval at .\\boot.jl:368 [inlined]\ninclude_string at .\\loading.jl:1428\njl_fptr_args at C:/workdir/src\\gf.c:2138\n_jl_invoke at C:/workdir/src\\gf.c:2358 [inlined]\nijl_apply_generic at C:/workdir/src\\gf.c:2559\n_include at .\\loading.jl:1488\ninclude at .\\client.jl:476\nunknown function (ip: 10660535)\n_jl_invoke at C:/workdir/src\\gf.c:2377 [inlined]\nijl_apply_generic at C:/workdir/src\\gf.c:2559\njl_apply at C:/workdir/src\\julia.h:1843 [inlined]\ndo_call at C:/workdir/src\\interpreter.c:126\neval_value at C:/workdir/src\\interpreter.c:215\neval_stmt_value at C:/workdir/src\\interpreter.c:166 [inlined]\neval_body at C:/workdir/src\\interpreter.c:594\njl_interpret_toplevel_thunk at C:/workdir/src\\interpreter.c:750\njl_toplevel_eval_flex at C:/workdir/src\\toplevel.c:906\njl_toplevel_eval_flex at C:/workdir/src\\toplevel.c:850\nijl_toplevel_eval at C:/workdir/src\\toplevel.c:915 [inlined]\nijl_toplevel_eval_in at C:/workdir/src\\toplevel.c:965\neval at .\\boot.jl:368 [inlined]\nexec_options at .\\client.jl:276\n_start at .\\client.jl:522\njfptr__start_41558.clone_1 at C:\\hostedtoolcache\\windows\\julia\\1.8.5\\x86\\lib\\julia\\sys.dll (unknown line)\n_jl_invoke at C:/workdir/src\\gf.c:2358 [inlined]\nijl_apply_generic at C:/workdir/src\\gf.c:2559\njl_apply at C:/workdir/src\\julia.h:1843 [inlined]\ntrue_main at C:/workdir/src\\jlapi.c:575\njl_repl_entrypoint at C:/workdir/src\\jlapi.c:719\njl_load_repl at C:/workdir/cli\\loader_lib.c:471\nmainCRTStartup at C:/workdir/cli\\loader_exe.c:59\nBaseThreadInitThunk at C:\\Windows\\System32\\KERNEL32.DLL (unknown line)\nRtlGetFullPathName_UEx at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\nRtlGetFullPathName_UEx at C:\\Windows\\SYSTEM32\\ntdll.dll (unknown line)\nAllocations: 94885190 (Pool: 94868039; Big: 17151); GC: 137\nERROR: LoadError: Package FastTransforms errored during testing\nStacktrace:\n [1] pkgerror(msg::String)\n @ Pkg.Types C:\\hostedtoolcache\\windows\\julia\\1.8.5\\x86\\share\\julia\\stdlib\\v1.8\\Pkg\\src\\Types.jl:67\n [2] test(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; coverage::Bool, julia_args::Cmd, test_args::Cmd, test_fn::Nothing, force_latest_compatible_version::Bool, allow_earlier_backwards_compatible_versions::Bool, allow_reresolve::Bool)\n @ Pkg.Operations C:\\hostedtoolcache\\windows\\julia\\1.8.5\\x86\\share\\julia\\stdlib\\v1.8\\Pkg\\src\\Operations.jl:1813\n [3] test(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; coverage::Bool, test_fn::Nothing, julia_args::Vector{String}, test_args::Cmd, force_latest_compatible_version::Bool, allow_earlier_backwards_compatible_versions::Bool, allow_reresolve::Bool, kwargs::Base.Pairs{Symbol, IOContext{Base.PipeEndpoint}, Tuple{Symbol}, NamedTuple{(:io,), Tuple{IOContext{Base.PipeEndpoint}}}})\n @ Pkg.API C:\\hostedtoolcache\\windows\\julia\\1.8.5\\x86\\share\\julia\\stdlib\\v1.8\\Pkg\\src\\API.jl:434\n [4] test(pkgs::Vector{Pkg.Types.PackageSpec}; io::IOContext{Base.PipeEndpoint}, kwargs::Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol, Symbol}, NamedTuple{(:julia_args, :coverage, :force_latest_compatible_version), Tuple{Vector{String}, Bool, Bool}}})\n @ Pkg.API C:\\hostedtoolcache\\windows\\julia\\1.8.5\\x86\\share\\julia\\stdlib\\v1.8\\Pkg\\src\\API.jl:156\n [5] test(; name::Nothing, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol, Symbol}, NamedTuple{(:julia_args, :coverage, :force_latest_compatible_version), Tuple{Vector{String}, Bool, Bool}}})\n @ Pkg.API C:\\hostedtoolcache\\windows\\julia\\1.8.5\\x86\\share\\julia\\stdlib\\v1.8\\Pkg\\src\\API.jl:171\n [6] top-level scope\n @ D:\\a\\_actions\\julia-actions\\julia-runtest\\latest\\test_harness.jl:15\n [7] include(fname::String)\n @ Base.MainInclude .\\client.jl:476\n [8] top-level scope\n @ none:1\nin expression starting at D:\\a\\_actions\\julia-actions\\julia-runtest\\latest\\test_harness.jl:7\nError: Process completed with exit code 1.\n\nThe tests error only on Windows latest for Julia v1.8.5, and pass on Linux and macOS (although the other tests on Windows get cancelled because of this error). The previous CI run from 3 months back did run successfully on Windows latest (for Julia v1.8.3 and v1.7), so this appears to be a regression. Unfortunately, I don't have access to a Windows system to look into this.","author_login":"jishnub","author_association":"CONTRIBUTOR","created_at":"2023-03-06T09:45:52+08:00","repo_name":"JuliaLang/julia","issue_id":1611029884,"issue_number":48907,"issue_url":"https://github.com/JuliaLang/julia/issues/48907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1455821027","fragment_type":"issue_comment","sequence":1,"text":"This is likely not a Julia issue. Windows will throw this error on a double free. \n\nSince the stacktrace goes through:\n\nft_bfmmf at C:\\Users\\runneradmin\\.julia\\artifacts\\2f4394502c5b9c9863425335a6140d4bfd02153b\\bin\\libfasttransforms.dll (unknown line)\n\nIt is likely an issue in the library itself.","author_login":"vchuravy","author_association":"MEMBER","created_at":"2023-03-06T09:57:37+08:00","repo_name":"JuliaLang/julia","issue_id":1611029884,"issue_number":48907,"issue_url":"https://github.com/JuliaLang/julia/issues/48907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1459097496","fragment_type":"issue_comment","sequence":2,"text":"I wonder if it's related to URL since these issues also only show up on Windows with Julia > 1.8.3.","author_login":"devmotion","author_association":"CONTRIBUTOR","created_at":"2023-03-08T00:52:25+08:00","repo_name":"JuliaLang/julia","issue_id":1611029884,"issue_number":48907,"issue_url":"https://github.com/JuliaLang/julia/issues/48907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1586335609","fragment_type":"issue_comment","sequence":3,"text":"Can someone who could reproduce this bug before try again with latest master which includes #50135? Although I'm not sure it's the same as #48187 because as far as I understand the error message is different, although the timeline looks similar.","author_login":"giordano","author_association":"CONTRIBUTOR","created_at":"2023-06-11T21:00:35+08:00","repo_name":"JuliaLang/julia","issue_id":1611029884,"issue_number":48907,"issue_url":"https://github.com/JuliaLang/julia/issues/48907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1586438318","fragment_type":"issue_comment","sequence":4,"text":"I'll fix this, it's the same issue with accessing FFTW internals. This should be the last occurrence","author_login":"jishnub","author_association":"CONTRIBUTOR","created_at":"2023-06-12T01:34:19+08:00","repo_name":"JuliaLang/julia","issue_id":1611029884,"issue_number":48907,"issue_url":"https://github.com/JuliaLang/julia/issues/48907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1586980087","fragment_type":"issue_comment","sequence":5,"text":"I think this is fixed now, tests seem to pass using the latest julia nightly on Windows in the PR URL \n\nThanks a lot!","author_login":"jishnub","author_association":"CONTRIBUTOR","created_at":"2023-06-12T09:47:17+08:00","repo_name":"JuliaLang/julia","issue_id":1611029884,"issue_number":48907,"issue_url":"https://github.com/JuliaLang/julia/issues/48907","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0228","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[SidecarContainer] Need to provide sidecar implementation best practices?","query_context":"This is a follow up from URL \n\nWe need to improve the page URL with the best practices on how to implement sidecar containers. Things like exiting with `0` on `SIGTERM`","known_context_document_ids":["gh_issue_2511315459"],"reference_answer":"This looks not just limited in the init container with restartPolicy of `Always`, the regular container should have the same behavior.\n\nThere is a time gap between the container start and its startupProbe start. If your container exits quickly, it might not run the startupProbe at all.\n\n---\n \n \n \n\nWhy do you need to run this command with restartPolicy of `Always`?\nI am not getting what this scenario is for.\n\nThe init container with restartPolicy of `Always` is supposed to be long-running.","answer_document_id":"gh_comment_1741528281","silver_evidence_path":["gh_comment_2408193322","gh_issue_1910154718","gh_comment_1741528281"],"evidence_issue_ids":[2511315459,1910154718],"source_repo_name":"kubernetes/website","source_issue_id":2511315459,"source_issue_number":47823,"source_issue_url":"https://github.com/kubernetes/website/issues/47823","target_repo_name":"kubernetes/kubernetes","target_issue_id":1910154718,"target_issue_number":120848,"target_issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","reference_anchor_document_id":"gh_comment_2408193322","reference_answer_author":"gjkim42","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2353,"anchor_target_overlap":0.2973,"target_answer_overlap":0.3846},"issue_created_at":"2024-09-06T23:31:12+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2511315459","fragment_type":"issue_description","sequence":0,"text":"[SidecarContainer] Need to provide sidecar implementation best practices\nThis is a follow up from URL \n\nWe need to improve the page URL with the best practices on how to implement sidecar containers. Things like exiting with `0` on `SIGTERM`","author_login":"SergeyKanzhelev","author_association":"MEMBER","created_at":"2024-09-06T23:31:12+08:00","repo_name":"kubernetes/website","issue_id":2511315459,"issue_number":47823,"issue_url":"https://github.com/kubernetes/website/issues/47823","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2334937413","fragment_type":"issue_comment","sequence":1,"text":"This issue is currently awaiting triage.\n\nSIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the `triage/accepted` label.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n \n\nInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.","author_login":"k8s-ci-robot","author_association":"CONTRIBUTOR","created_at":"2024-09-06T23:31:21+08:00","repo_name":"kubernetes/website","issue_id":2511315459,"issue_number":47823,"issue_url":"https://github.com/kubernetes/website/issues/47823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408193322","fragment_type":"issue_comment","sequence":2,"text":"Some interesting issues that we need to cover:\n\n1. If a sidecar never had a chance to execute the startup probe, it will prevent the main container from even starting: URL \n2. Sidecar implemented as a built-in type always starts before the container. So it will block the main container start before the sidecar's image is pulled. See URL The best practice here is to postpone all heavy operations to as late as possible.","author_login":"SergeyKanzhelev","author_association":"MEMBER","created_at":"2024-10-11T22:24:25+08:00","repo_name":"kubernetes/website","issue_id":2511315459,"issue_number":47823,"issue_url":"https://github.com/kubernetes/website/issues/47823","linked_issue_ids":[1910154718],"is_known_query_context":false},{"document_id":"gh_issue_1910154718","fragment_type":"issue_description","sequence":0,"text":"SideCar startupProbe on 1.28\n### What happened?\n\nThere seems to be a bit of a time sync or race condition between the intiContainer doing its thing and the startup probe , take this example:\n\n containers:\n - name: myapp\n image: alpine:latest\n command: ['sh', '-c', 'tail -F /opt/logs.txt']\n volumeMounts:\n - name: data\n mountPath: /opt\n initContainers:\n - name: logshipper\n image: alpine:latest\n restartPolicy: Always\n command: ['sh', '-c', 'sleep 3 ; echo \"containerId: $(cat /proc/1/uid_map | awk \"{ print $3 }\") logging $(date +%s)\" >> /opt/logs.txt']\n startupProbe:\n exec:\n command: [\"true\"]\n periodSeconds: 1\n initialDelaySeconds: 0\n volumeMounts:\n - name: data\n mountPath: /opt\n\nThis example passes the startupProbe and the container `myapp` starts ok , but if i remove the `sleep` or if i reduce it to anything shorter than `3` seconds , the `myapp` container never start.\n\n### What did you expect to happen?\n\n`myapp` should of start as a result of `startupProbe` passing , but it seems to take too long to exec\n\n### How can we reproduce it (as minimally and precisely as possible)?\n\nexample provided above but , enabling sidecar feature gate and with this example:\n\n#kind create cluster --image kindest/node:v1.28.0 --config cluster.yaml\nkind: Cluster\napiVersion: kind.x-k8s.io/v1alpha4\nfeatureGates:\n \"SidecarContainers\": true\n\npod:\n\napiVersion: v1\nkind: Pod\nmetadata:\n name: pod\nspec:\n volumes:\n - name: data\n emptyDir:\n sizeLimit: 500Mi\n containers:\n - name: myapp\n image: alpine:latest\n command: ['sh', '-c', 'tail -F /opt/logs.txt']\n volumeMounts:\n - name: data\n mountPath: /opt\n initContainers:\n - name: logshipper\n image: alpine:latest\n restartPolicy: Always\n command: ['sh', '-c', 'sleep 5 ; echo \"containerId: $(cat /proc/1/uid_map | awk \"{ print $3 }\") logging $(date +%s)\" >> /opt/logs.txt']\n startupProbe:\n exec:\n command: [\"true\"]\n periodSeconds: 1\n initialDelaySeconds: 0\n volumeMounts:\n - name: data\n mountPath: /opt\n - name: logshipper1\n image: alpine:latest\n restartPolicy: Always\n command: ['sh', '-c', 'sleep 5 ; echo \"containerId: $(cat /proc/1/uid_map | awk \"{ print $3 }\") logging $(date +%s)\" >> /opt/logs.txt']\n startupProbe:\n exec:\n command: [\"true\"]\n periodSeconds: 1\n initialDelaySeconds: 0\n volumeMounts:\n - name: data\n mountPath: /opt\n\n### Anything else we need to know?\n\nVersion is 1.28\n\n### Kubernetes version\n\n \n\nconsole\n❯ kubectl version\nClient Version: v1.28.2\nKustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3\nServer Version: v1.28.0\n\n \n\n### Cloud provider\n\n \nLocal / Kind\n \n\n### OS version\n\n \n\nconsole\n❯ cat /etc/os-release\nNAME=\"Arch Linux\"\nPRETTY_NAME=\"Arch Linux\"\nID=arch\nBUILD_ID=rolling\nANSI_COLOR=\"38;2;23;147;209\"\nHOME_URL=\" URL \nDOCUMENTATION_URL=\" URL \nSUPPORT_URL=\" URL \nBUG_REPORT_URL=\" URL \nPRIVACY_POLICY_URL=\" URL \nLOGO=archlinux-logo\n\n \n\n### Install tools\n\n \n\n \n\n### Container runtime (CRI) and version (if applicable)\n\n \nDocker\n \n\n### Related plugins (CNI, CSI, ...) and versions (if applicable)","author_login":"bechampion","author_association":"NONE","created_at":"2023-09-24T08:37:19+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1732521152","fragment_type":"issue_comment","sequence":1,"text":"There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig `\n- `/wg `\n- `/committee `\n\nPlease see the group list for a listing of the SIGs, working groups, and committees available.\n\n \n\nInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.","author_login":"k8s-ci-robot","author_association":"CONTRIBUTOR","created_at":"2023-09-24T08:37:27+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1732521155","fragment_type":"issue_comment","sequence":2,"text":"This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n \n\nInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.","author_login":"k8s-ci-robot","author_association":"CONTRIBUTOR","created_at":"2023-09-24T08:37:28+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1737837692","fragment_type":"issue_comment","sequence":3,"text":"/triage accepted\n/priority important-longerm\n/assign @SergeyKanzhelev","author_login":"mmiranda96","author_association":"CONTRIBUTOR","created_at":"2023-09-27T17:51:58+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1737837738","fragment_type":"issue_comment","sequence":4,"text":"@mmiranda96: The label(s) `priority/important-longerm` cannot be applied, because the repository doesn't have them.\n\n \n\nIn response to this:\n \n \n \n\nInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.","author_login":"k8s-ci-robot","author_association":"CONTRIBUTOR","created_at":"2023-09-27T17:52:01+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[1910154718],"is_known_query_context":false},{"document_id":"gh_comment_1741528281","fragment_type":"issue_comment","sequence":5,"text":"This looks not just limited in the init container with restartPolicy of `Always`, the regular container should have the same behavior.\n\nThere is a time gap between the container start and its startupProbe start. If your container exits quickly, it might not run the startupProbe at all.\n\n---\n \n \n \n\nWhy do you need to run this command with restartPolicy of `Always`?\nI am not getting what this scenario is for.\n\nThe init container with restartPolicy of `Always` is supposed to be long-running.","author_login":"gjkim42","author_association":"MEMBER","created_at":"2023-09-29T21:55:26+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2381017224","fragment_type":"issue_comment","sequence":6,"text":"This issue has not been updated in over 1 year, and should be re-triaged.\n\nYou can:\n- Confirm that this issue is still relevant with `/triage accepted` (org members only)\n- Close this issue with `/close`\n\nFor more details on the triage process, see URL \n\n/remove-triage accepted","author_login":"k8s-triage-robot","author_association":"NONE","created_at":"2024-09-28T22:58:25+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408189903","fragment_type":"issue_comment","sequence":7,"text":"This sounds a little bit unexpected from user perspective. However, since the sidecar is always in either Terminated state or starting, and not started yet, this is exactly the expected behavior. It will be the same when init container is failing to start. We will keep restarting the Init container untill it completed with `0` exit code. in this case, the condition we are waiting is for sidecar to be started so we can proceed to the next init container or to the main container.","author_login":"SergeyKanzhelev","author_association":"MEMBER","created_at":"2024-10-11T22:20:06+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408192187","fragment_type":"issue_comment","sequence":8,"text":"I think what we need here:\n\n1. Update docs to mention this behavior: URL \n2. Add an e2e test that will effectively codify this behavior as expected","author_login":"SergeyKanzhelev","author_association":"MEMBER","created_at":"2024-10-11T22:23:00+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2532120489","fragment_type":"issue_comment","sequence":9,"text":"/triage accepted\n\n@SergeyKanzhelev what is left for this ticket?","author_login":"kannon92","author_association":"CONTRIBUTOR","created_at":"2024-12-10T15:50:17+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2591216943","fragment_type":"issue_comment","sequence":10,"text":"While this case isn't expected to work, we're not intentionally failing it, so adding a test case for it will not have a consistent outcome.\nWe think the documentation is enough here, it can be closed.\n/close","author_login":"matthyx","author_association":"CONTRIBUTOR","created_at":"2025-01-14T22:17:46+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2591217299","fragment_type":"issue_comment","sequence":11,"text":"@matthyx: Closing this issue.\n\n \n\nIn response to this:\n \n \n \n \n \n\nInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.","author_login":"k8s-ci-robot","author_association":"CONTRIBUTOR","created_at":"2025-01-14T22:17:51+08:00","repo_name":"kubernetes/kubernetes","issue_id":1910154718,"issue_number":120848,"issue_url":"https://github.com/kubernetes/kubernetes/issues/120848","linked_issue_ids":[1910154718],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0229","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"🐛 Bug Report — Runtime APIs: names of WebSocket ready state constants differ from the Living Standard?","query_context":"Names of ready states constants on the `WebSocket` class, defined in here differ from that of the Web IDL definition in the WebSocket Living Standard. In workerd, every name have extra prefix: `READY_STATE_`.\n\nIt may cause problems when we want to use libraries that handle WebSocket connections and depend on the \"standard\" names for checking ready state of sockets in Cloudflare Workers. In workerd environment, ready state checks based on the \"standard\" constant names (e.g. `WebSocket.OPEN`) don't work correctly since they have no value (`undefined`).\n\nI'm curious about why these constants are given different names than the \"standard\". If we have no reason for that, shouldn't we fix it?","known_context_document_ids":["gh_issue_1969897539"],"reference_answer":"@rodbs Try using `const synthesizer = new sdk.SpeechSynthesizer(speechConfig, null);`\nNot sure what the DefaultSpeakerOutput on a Cloudflare worker would be.","answer_document_id":"gh_comment_1469063712","silver_evidence_path":["gh_comment_1859447303","gh_issue_1617636575","gh_comment_1469063712"],"evidence_issue_ids":[1969897539,1617636575],"source_repo_name":"cloudflare/workerd","source_issue_id":1969897539,"source_issue_number":1370,"source_issue_url":"https://github.com/cloudflare/workerd/issues/1370","target_repo_name":"microsoft/cognitive-services-speech-sdk-js","target_issue_id":1617636575,"target_issue_number":645,"target_issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","reference_anchor_document_id":"gh_comment_1859447303","reference_answer_author":"glharper","reference_answer_author_association":"MEMBER","quality_score":94.85,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1296,"anchor_target_overlap":0.1176,"target_answer_overlap":0.0769},"issue_created_at":"2023-10-31T08:24:22+08:00","valid_comment_count":35,"fragments":[{"document_id":"gh_issue_1969897539","fragment_type":"issue_description","sequence":0,"text":"🐛 Bug Report — Runtime APIs: names of WebSocket ready state constants differ from the Living Standard\nNames of ready states constants on the `WebSocket` class, defined in here differ from that of the Web IDL definition in the WebSocket Living Standard. In workerd, every name have extra prefix: `READY_STATE_`.\n\nIt may cause problems when we want to use libraries that handle WebSocket connections and depend on the \"standard\" names for checking ready state of sockets in Cloudflare Workers. In workerd environment, ready state checks based on the \"standard\" constant names (e.g. `WebSocket.OPEN`) don't work correctly since they have no value (`undefined`).\n\nI'm curious about why these constants are given different names than the \"standard\". If we have no reason for that, shouldn't we fix it?","author_login":"jiftechnify","author_association":"NONE","created_at":"2023-10-31T08:24:22+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1787594559","fragment_type":"issue_comment","sequence":1,"text":"Well, the reason was that we were (read: I was) was working from URL which has the states but not a proscription on how they're exposed. Personally, I'm inclined to follow the web idl definition now that I know it exists. What do you think, @jasnell? Maybe we either just add the web idl def form or compat flag in the change to the web idl def form?","author_login":"bcaimano","author_association":"COLLABORATOR","created_at":"2023-10-31T16:44:40+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1787857999","fragment_type":"issue_comment","sequence":2,"text":"Like not worth a compat flag as long as there are no conflicts in the names. Let's just add the additional ones from the spec alongside the current set. If we want to deprecate the old names later we can do so with a compat flag then.","author_login":"jasnell","author_association":"MEMBER","created_at":"2023-10-31T19:12:00+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1791656409","fragment_type":"issue_comment","sequence":3,"text":"@bcaimano ... as a follow up here, but only partially related to this issue... at some point in the not too far off future we really need to go through an audit just how far our implementation of `WebSocket` strays from the standard API definition. We may not necessarily close those gaps but we at least want to document them more thoroughly. Just something to keep in mind as you're thinking about this.","author_login":"jasnell","author_association":"MEMBER","created_at":"2023-11-02T22:36:26+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1859447303","fragment_type":"issue_comment","sequence":4,"text":"This looks to be the cause of this issue with the Cognitive Speech Services SDK when running via Cloudflare Pages Functions. The Speech Services SDK checks the WebSocket readyState against WebSocket.OPEN, which works fine in a browser but fails in a Cloudflare function.\n\nMy current workaround is to define these manually:\n\nexport async function onRequest(context) {\n\n WebSocket.prototype.CONNECTING = 0;\n WebSocket.prototype.OPEN = 1;\n WebSocket.prototype.CLOSING = 2;\n WebSocket.prototype.CLOSED = 3;\n\n...\n\nJust reporting for posterity in case someone comes across the same issue. From the discussion above, I guess workerd isn't yet compliant with the standard for the WebSocket interface, but as soon as the open PR lands, that should be fixed.","author_login":"nmfisher","author_association":"NONE","created_at":"2023-12-18T02:30:03+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[1617636575],"is_known_query_context":false},{"document_id":"gh_comment_1863120945","fragment_type":"issue_comment","sequence":5,"text":"Okay, thanks for the poke that reminded me to circle back on this! I've merged the relevant PR into workerd. Given the holiday season, it may or may not show up on cloudflare workers until the new year.","author_login":"bcaimano","author_association":"COLLABORATOR","created_at":"2023-12-19T16:45:55+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1866673179","fragment_type":"issue_comment","sequence":6,"text":"Thank you @bcaimano ! Given that the fix has been landed (even if not released) let's go ahead and close this issue.","author_login":"jasnell","author_association":"MEMBER","created_at":"2023-12-21T17:18:47+08:00","repo_name":"cloudflare/workerd","issue_id":1969897539,"issue_number":1370,"issue_url":"https://github.com/cloudflare/workerd/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1617636575","fragment_type":"issue_description","sequence":0,"text":"SDK with Cloudflare workers and Fetch API\nWhen using this sdk with cloudflare workers I get this error:\n\nXMLHttpRequest is not defined\n\nI understand it's due to the fact the sdk doesn't suport the `Fetch API`.\nIs it planned to support this API to use speech services sdk with Cloudflare workers?\nIs there any way to make it work now with workers?","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-09T17:01:03+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1463020650","fragment_type":"issue_comment","sequence":1,"text":"@rodbs Thanks for opening this issue, and using Speech SDK. I've merged a fix for this into our repo removing the reference to XMLHttpRequest, is there a way you could pull and build the latest commit? (If not, shoot me a email at (at)microsoft(dot)com and I'll send you binaries.)\n\nIf you could check whether this unblocks you, it'd be much appreciated (and you'd get a shoutout in our next release notes :-) ).","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-10T00:11:42+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1466391000","fragment_type":"issue_comment","sequence":2,"text":"@rodbs I've created a branch removing the offending code, could you build and test again? \nTest branch","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-13T15:41:49+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1467033113","fragment_type":"issue_comment","sequence":3,"text":"@glharper No, I'm getting the same error (I've tried with remove-ocsp branch)\n\n C:\\Users\\sources\\igls-remix-cf\\node_modules\\rsvp\\dist\\lib\\rsvp\\-internal.js:75\n var error = TRY_CATCH_ERROR.error;\n ^\nTypeError: globalThis.XMLHttpRequest is not a constructor\n at originalResolve (C:\\Users\\sources\\igls-remix-cf\\node_modules\\rsvp\\dist\\lib\\rsvp\\-internal.js:75:11)\n at node_modules/rollup-plugin-node-polyfills/polyfills/http-lib/capability.js (C:\\Users\\sources\\igls-remix-cf\\node_modules\\rsvp\\dist\\lib\\rsvp\\-internal.js:102:133)\n at C:\\Users\\rodri\\AppData\\Local\\Temp\\tmp-20132-nDcsnj4wPzj5\\bundledWorker-0.43920512800175326.js:48:56\n at node_modules/rollup-plugin-node-polyfills/polyfills/http-lib/request.js (C:\\Users\\sources\\igls-remix-cf\\public\\node-modules-polyfills:assert:179:3)\n at C:\\Users\\rodri\\AppData\\Local\\Temp\\tmp-20132-nDcsnj4wPzj5\\bundledWorker-0.43920512800175326.js:48:56\n at node-modules-polyfills:http (C:\\Users\\sources\\igls-remix-cf\\node_modules\\minimatch\\minimatch.js:54:41)\n at C:\\Users\\rodri\\AppData\\Local\\Temp\\tmp-20132-nDcsnj4wPzj5\\bundledWorker-0.43920512800175326.js:48:56\n at node-modules-polyfills-commonjs:http (C:\\Users\\sources\\igls-remix-cf\\node_modules\\minimatch\\minimatch.js:304:14) at C:\\Users\\rodri\\AppData\\Local\\Temp\\tmp-20132-nDcsnj4wPzj5\\bundledWorker-0.43920512800175326.js:51:50","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-13T22:07:03+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1468290045","fragment_type":"issue_comment","sequence":4,"text":"@rodbs I've updated the branch to remove the dependency on rsvp, please give it another shot, and thanks for testing this for us. :-)","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-14T15:10:53+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469005043","fragment_type":"issue_comment","sequence":5,"text":"@glharper I don't get the error anymore, but I cannot make it work. I don't know why but when I run this code I don't get the promise resolved. There's no error message at all.\nI'm running this code in Remix+Cloudflare. I think it worked when I ran it in Remix+Node (and for sure in NextJS).\nSo not sure if it's something related with Cloudflare workers ....\n\n const synthesizer = new sdk.SpeechSynthesizer(speechConfig);\n\n const prom = new Promise((resolve, reject) => {\n const ssml = ` \n \n \n ${text} \n \n \n \n `;\n \n synthesizer.speakSsmlAsync(\n ssml,\n async (result) => {\n if (result.errorDetails) { \n console.error(result.errorDetails);\n synthesizer.close();\n } else {\n \n const rdm = parseInt(Math.random() * 10000); \n const fileName = `${tablename}-${rowindex}-${key}-${cloud}-${voiParam.gender}-${voiceSpeedName}-${rdm}.mp3`;\n\n const file = new File([result.audioData], fileName, {\n type: 'audio/mp3',\n lastModified: Date.now()\n });\n \n const url = await saveVoiceToStg(fileName, file, folder);\n \n synthesizer.close();\n resolve([url, fileName]);\n }\n },\n (error) => {\n console.log('err', error);\n synthesizer.close();\n }\n );\n });\n \n return prom;\n \n\n \n\n \n Promise {\n ,\n [Symbol(async_id_symbol)]: 11403,\n [Symbol(trigger_async_id_symbol)]: 10994,\n [Symbol(kResourceStore)]: undefined,\n [Symbol(kResourceStore)]: RequestContext {\n requestDepth: 1,\n pipelineDepth: 1,\n durableObject: false,\n externalSubrequestLimit: 1000,\n internalSubrequestLimit: 1000\n }\n}","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-14T23:32:42+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469063712","fragment_type":"issue_comment","sequence":6,"text":"@rodbs Try using `const synthesizer = new sdk.SpeechSynthesizer(speechConfig, null);`\nNot sure what the DefaultSpeakerOutput on a Cloudflare worker would be.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-15T00:44:37+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470393989","fragment_type":"issue_comment","sequence":7,"text":"@glharper \nI think the problems lies in the way CF works deals with async tasks and this method `waitUntil`\n\n URL \n\nHere it's an explanation:\n URL \n\n`event.waitUntil() is only useful if you have some asynchronous task that you want to keep running after returning a response to the visitor. Usually the Workers runtime will cancel any background tasks spawned from a particular FetchEvent once it detects that the response has been sent. event.waitUntil() tells the runtime to wait for another promise in addition to the visitor response before canceling any tasks. This probably doesn’t apply to your immediate needs. Further, event.waitUntil() doesn’t return anything, so treating its return value as anything other than undefined will lead to an exception.`\n\nI think I need to enclose with a `waitUntil` the promise running the `synthesizer.speakSsmlAsync`. The only issue I see it's that `waitUntil` doesn't return anything, so I cannot return the url of the bucket where uploading audio file....","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-15T16:49:41+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470991473","fragment_type":"issue_comment","sequence":8,"text":"@glharper \nThe `synthesizer.speakSsmlAsync` code inside the ` waitUntil` is not being executed. I don't why because I don't get any message error, not even doing a try/catch. It's like it's being skipped ... Might it be because it's not doing inside a `Fetch` to Azure API?","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-15T23:48:18+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1471164781","fragment_type":"issue_comment","sequence":9,"text":"@rodbs\nIf you have access to console output, could you add the following code to the beginning:\n\nsdk.Diagnostics.SetLoggingLevel(sdk.LogLevel.Debug);\n\nand see what console output you get?\n\nAlso, you're using the sdk.SpeechSynthesizer(speechConfig, *null*) syntax, correct?","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-16T02:01:12+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1471788293","fragment_type":"issue_comment","sequence":10,"text":"@glharper \nYes, I set this config ` sdk.SpeechSynthesizer(speechConfig, null) `\n\nI've run two tests (I deleted the subscription key in the output) : first one with `waitUntil`, \n\n`\n2023-03-16T11:21:23.364Z | ConnectionStartEvent | privName: ConnectionStartEvent | privEventId: AA35EECE3F914F6F884080943F4F630A | privEventTime: 2023-03-16T11:21:23.364Z | privEventType: 1 | privMetadata: {} | privConnectionId: 90C0817D3F8841E4B4BED8900737FFC5 | privUri: wss://westeurope.tts.speech.microsoft.com/cognitiveservices/websocket/v1?Ocp-Apim-Subscription-Key=...................&X-ConnectionId=90C0817D3F8841E4B4BED8900737FFC5 | privHeaders: \n `\n\nand this one with a `Promise/resolve`\n`\n2023-03-16T11:28:53.087Z | SynthesisTriggeredEvent | privName: SynthesisTriggeredEvent | privEventId: BE9B72E1A2004F7BBE07C66B2D9EB546 | privEventTime: 2023-03-16T11:28:53.087Z | privEventType: 1 | privMetadata: {} | privRequestId: 915C7FD74B674E45A291EE8586B7281E | privSessionAudioDestinationId: | privTurnAudioDestinationId: \n2023-03-16T11:28:53.087Z | ConnectingToSynthesisServiceEvent | privName: ConnectingToSynthesisServiceEvent | privEventId: E966B260E51A4067A05E22416C5CE413 | privEventTime: 2023-03-16T11:28:53.087Z | privEventType: 1 | privMetadata: {} | privRequestId: 915C7FD74B674E45A291EE8586B7281E | privAuthFetchEventId: 8B8C3EEC77DB42CCB1FDBDEF985826FB\n2023-03-16T11:28:53.087Z | ConnectionStartEvent | privName: ConnectionStartEvent | privEventId: D0FE081004E649E8ADD28F34C531CED6 | privEventTime: 2023-03-16T11:28:53.087Z | privEventType: 1 | privMetadata: {} | privConnectionId: 94181D344C014D73A91060FB44D300A7 | privUri: wss://westeurope.tts.speech.microsoft.com/cognitiveservices/websocket/v1?Ocp-Apim-Subscription-Key=.....................&X-ConnectionId=94181D344C014D73A91060FB44D300A7 | privHeaders: \n`","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-16T11:34:19+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1471931131","fragment_type":"issue_comment","sequence":11,"text":"@rodbs The sdk is trying to connect to the websocket endpoint, but cannot. If the ws library weren't available, I'd expect similar \"can't resolve\"/\"not a constructor\" error messages as the ones you originally posted.\n\nMy best guess is a network configuration issue between your Cloudflare instance and the wss://westeurope.tts.speech.microsoft.com endpoint. One thing to check is if westeurope.tts.speech.microsoft.com resolves a DNS address when you ping it from Cloudflare. Another is that the 443 port (for wss traffic) is not blocked on your side.\n\nBeyond that, you'll need to engage Cloudflare support and figure out why that connection is not happening.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-16T13:12:56+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1473859276","fragment_type":"issue_comment","sequence":12,"text":"@rodbs To ping over wss, you have to establish a connection first, and it doesn't look like you're able to establish a connection with the wss://westeurope.tts.speech.microsoft.com endpoint yet.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-17T13:38:36+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1474116247","fragment_type":"issue_comment","sequence":13,"text":"@glharper Yeap, I think you're right. I've posted the issue in Cloudflare but no reply yet.\n\nIn the meantime, are you planning to publish these changes to avoid the `XMLHttpRequest ` in the next release?","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-17T16:46:06+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1474156869","fragment_type":"issue_comment","sequence":14,"text":"@rodbs Our tentative timeline for the OCSP removal is 1.28.0 (expected beginning of May). If you need this in a versioned branch sooner, I can talk to our team about a 1.28-prerelease when we release 1.27 in a few weeks.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-03-17T17:15:19+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1474291810","fragment_type":"issue_comment","sequence":15,"text":"@glharper Yeap, if it could be in a prerelease it'd be highly appreciated so that I can do more testing. Thanks!","author_login":"rodbs","author_association":"NONE","created_at":"2023-03-17T19:11:37+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1498892933","fragment_type":"issue_comment","sequence":16,"text":"@glharper \nI've seen v1.27 has been released. Are you planning to release 1.28-prerelease as you commented a few ago?. Thx!","author_login":"rodbs","author_association":"NONE","created_at":"2023-04-06T11:08:19+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1501205219","fragment_type":"issue_comment","sequence":17,"text":"@rodbs\nI've been OOF this past week, I'll bend the ear of our release manager and see if we can get that out this week.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-04-09T20:17:08+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1503415735","fragment_type":"issue_comment","sequence":18,"text":"@rodbs This change has been merged in master, if you're able to take a commit specific dependency.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-04-11T14:02:32+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505561943","fragment_type":"issue_comment","sequence":19,"text":"@glharper \nI'm installing it by adding this to package.json\n\n \n\"microsoft-cognitiveservices-speech-sdk\": \" URL \n\nBut I'm getting this error when install (using yarn):\n\n...\n$ npm run build\n \n \n\n[18:13:34] Using gulpfile ~\\AppData\\Local\\Yarn\\Cache\\v6\\.tmp\\21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare\\gulpfile.js\n[18:13:34] Starting 'compress'...\n[18:13:34] Starting 'bundle'...\n[18:13:34] Starting 'build'...\n[18:13:34] Starting 'build'...\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,34): error TS7039: Mapped object type implicitly has an 'any' template type.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,50): error TS1005: ']' expected.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,50): error TS2304: Cannot find name 'as'.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,53): error TS1005: ';' expected.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,53): error TS2552: Cannot find name 'T'. Did you mean 't'?\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,55): error TS2304: Cannot find name 'P'.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,58): error TS1005: ';' expected.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,66): error TS2693: 'any' only refers to a type, but is being used as a value here.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,70): error TS1011: An element access expression should take an argument.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,74): error TS2304: Cannot find name 'P'.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,78): error TS2693: 'never' only refers to a type, but is being used as a value here.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,83): error TS1005: ';' expected.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,84): error TS1128: Declaration or statement expected.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,86): error TS2304: Cannot find name 'P'.\nC:/Users/rodri/AppData/Local/Yarn/Cache/v6/.tmp/21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare/node_modules/@types/babel__traverse/index.d.ts(68,88): error TS1128: Declaration or statement expected.\nTypeScript: 7 syntax errors\nTypeScript: 8 semantic errors\nTypeScript: emit succeeded (with errors)\n[18:13:58] 'build' errored after 25 s\n[18:13:58] Error: TypeScript: Compilation failed\n at Output.mightFinish (C:\\Users\\rodri\\AppData\\Local\\Yarn\\Cache\\v6\\.tmp\\21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare\\node_modules\\gulp-typescript\\release\\output.js:130:43)\n at C:\\Users\\rodri\\AppData\\Local\\Yarn\\Cache\\v6\\.tmp\\21c2f99d30ecb4b33a45d8db9ea14fae.a79b92f5bd774e03113a196402cedbee82f8cf90.prepare\\node_modules\\gulp-typescript\\release\\output.js:65:22\n[18:13:58] 'build' errored after 25 s\n[18:13:58] 'bundle' errored after 25 s\n[18:13:58] 'compress' errored after 25 s","author_login":"rodbs","author_association":"NONE","created_at":"2023-04-12T16:17:35+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505743410","fragment_type":"issue_comment","sequence":20,"text":"@glharper\nI've managed to install it locally using npm instead of yarn. \nI've got this error when running it; I think it's the same one I got weeks ago about no connecting using wss:\n\n2023-04-12T18:14:30.103Z | SynthesisTriggeredEvent | privName: SynthesisTriggeredEvent | privEventId: 5AA0CE8D864B4D57B1B19E82B6E9221A | privEventTime: 2023-04-12T18nId: \n2023-04-12T18:14:30.103Z | ConnectingToSynthesisServiceEvent | privName: ConnectingToSynthesisServiceEvent | privEventId: 7737B2386C7345DF818FFD787FD32C05 | privEventTime: 2023-04-12T18:14:30.103Z | privEventType: 1 | privMetadata: {} | privRequestId: 2724BB03AA6441848676AD8057B6D0C0 | privAuthFetchEventId: 184280BD999D47FF8024030E371C4BEC\n2023-04-12T18:14:30.103Z | ConnectionStartEvent | privName: ConnectionStartEvent | privEventId: 10C8B02F22DB464583E18A5DA011BCBA | privEventTime: 2023-04-12T18:14:30.103Z | privEventType: 1 | privMetadata: {} | privConnectionId: 6F7BFCA02DA24845A56B779B30143A0D | privUri: wss://westeurope.tts.speech.microsoft.com/cogniti\n\nBut when deploying to Cloudflare I got this other error; it seems it doesn't like to download from git \n\n20:19:54.445 | npm WARN tarball tarball data for microsoft-cognitiveservices-speech-sdk@git+ssh://git@github.com/microsoft/cognitive-services-speech-sdk-js.git#a79b92f5bd774e03113a196402cedbee82f8cf90 (sha512-TKf5bid2fhEUxQGmtRMGT0qSocQc1qIhqkM+czbWyZqRv/nFiTT8wPYuv2rfo/5iC8y3F1/5dWUXwpULDFDOZQ==) seems to be corrupted. Trying again.\n-- | --\n20:22:15.348 | npm WARN tarball tarball data for microsoft-cognitiveservices-speech-sdk@git+ssh://git@github.com/microsoft/cognitive-services-speech-sdk-js.git#a79b92f5bd774e03113a196402cedbee82f8cf90 (sha512-TKf5bid2fhEUxQGmtRMGT0qSocQc1qIhqkM+czbWyZqRv/nFiTT8wPYuv2rfo/5iC8y3F1/5dWUXwpULDFDOZQ==) seems to be corrupted. Trying again.\n20:22:26.517 | npm ERR! code EINTEGRITY\n20:22:26.518 | npm ERR! sha512-TKf5bid2fhEUxQGmtRMGT0qSocQc1qIhqkM+czbWyZqRv/nFiTT8wPYuv2rfo/5iC8y3F1/5dWUXwpULDFDOZQ== integrity checksum failed when using sha512: wanted sha512-TKf5bid2fhEUxQGmtRMGT0qSocQc1qIhqkM+czbWyZqRv/nFiTT8wPYuv2rfo/5iC8y3F1/5dWUXwpULDFDOZQ== but got sha512-Irijnuz2COG7l3IHAORMADaGbR7f25fEnQioUBOGHgvaLjJI0Eh1qRdnh2uGZOPScP0Q7w4MD1JgfhHTcTB7EQ==. (1601293 bytes)\n20:22:26.564 |  \n20:22:26.564 | npm ERR! A complete log of this run can be found in:\n20:22:26.565 | npm ERR! /opt/buildhome/.npm/_logs/2023-04-12T18_22_26_529Z-debug.log","author_login":"rodbs","author_association":"NONE","created_at":"2023-04-12T18:31:43+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509703788","fragment_type":"issue_comment","sequence":21,"text":"@glharper\nI've seen the release and it works when deploying on cloudflare.\nI haven't been able to test it thoroughly (the wss connection), though. Next week I'll be on a business trip so not sure if I'll be be able to test it. I'll let you know. Thx!","author_login":"rodbs","author_association":"NONE","created_at":"2023-04-15T09:37:41+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1520465218","fragment_type":"issue_comment","sequence":22,"text":"@glharper\n\nI've got this log when running the sdk in prod\n\n(log) _action create_voice_full\n (log) fileName bad-a#bad-0-eng-AZR-female-low.mp3\n (log) null\n (info) 2023-04-24T16:07:21.586Z | SynthesisTriggeredEvent | privName: SynthesisTriggeredEvent | privEventId: 702C31FEAE1C40E083583AC835D6A0D5 | privEventTime: 2023-04-24T16:07:21.586Z | privEventType: 1 | privMetadata: {} | privRequestId: 7A2297F67B124C33876CAF496B7DABF6 | privSessionAudioDestinationId: | privTurnAudioDestinationId: \n (info) 2023-04-24T16:07:21.586Z | ConnectingToSynthesisServiceEvent | privName: ConnectingToSynthesisServiceEvent | privEventId: 504539E5E6024B3592DA0F1CD48879F8 | privEventTime: 2023-04-24T16:07:21.586Z | privEventType: 1 | privMetadata: {} | privRequestId: 7A2297F67B124C33876CAF496B7DABF6 | privAuthFetchEventId: 236341C884E147EB8C4FE8D675F6E904\n (log) {\n file: 'words/bad-a#bad-0-eng-AZR-female-low.mp3',\n voiceName: 'en-US-AriaNeural',\n voiceGender: 'female',\n voiceType: 'AZR',\n voiceSpeed: 'low'\n}\n (info) 2023-04-24T16:07:21.586Z | ConnectionStartEvent | privName: ConnectionStartEvent | privEventId: FB2591A765C54753BBEBF4B3D14667B4 | privEventTime: 2023-04-24T16:07:21.586Z | privEventType: 1 | privMetadata: {} | privConnectionId: 7E9767F5499D4D44AB1AEADF2328152C | privUri: wss://westeurope.tts.speech.microsoft.com/cognitiveservices/websocket/v1?Ocp-Apim-Subscription-Key=f3686836b3e44035bd03972ff7d847e2&X-ConnectionId=7E9767F5499D4D44AB1AEADF2328152C | privHeaders: \n (log) res batch {\n file: 'words/bad-a#bad-0-eng-AZR-female-low.mp3',\n voiceName: 'en-US-AriaNeural',\n voiceGender: 'female',\n voiceType: 'AZR',\n voiceSpeed: 'low'\n}\n (info) 2023-04-24T16:07:22.084Z | ConnectionEstablishedEvent | privName: ConnectionEstablishedEvent | privEventId: B2D78D0CB0624B9A9E73ED93A9156416 | privEventTime: 2023-04-24T16:07:22.084Z | privEventType: 1 | privMetadata: {} | privConnectionId: 7E9767F5499D4D44AB1AEADF2328152C\n (info) 2023-04-24T16:07:22.084Z | SynthesisStartedEvent | privName: SynthesisStartedEvent | privEventId: 78F4D76C44B54761AE57FBAF38BAFB19 | privEventTime: 2023-04-24T16:07:22.084Z | privEventType: 1 | privMetadata: {} | privRequestId: 7A2297F67B124C33876CAF496B7DABF6 | privAuthFetchEventId: 236341C884E147EB8C4FE8D675F6E904\n (info) 2023-04-24T16:07:22.084Z | ConnectionMessageSentEvent | privName: ConnectionMessageSentEvent | privEventId: 4FD385050C4247F8ABE3FA7155041A6C | privEventTime: 2023-04-24T16:07:22.084Z | privEventType: 1 | privMetadata: {} | privConnectionId: 7E9767F5499D4D44AB1AEADF2328152C | privNetworkSentTime: 2023-04-24T16:07:22.084Z | privMessage: {\"privBody\":\"{\\\"context\\\":{\\\"system\\\":{\\\"name\\\":\\\"SpeechSDK\\\",\\\"version\\\":\\\"1.28.0-beta.1\\\",\\\"build\\\":\\\"JavaScript\\\",\\\"lang\\\":\\\"JavaScript\\\"},\\\"os\\\":{\\\"platform\\\":\\\"Node/undefined\\\",\\\"name\\\":\\\"Cloudflare-Workers\\\"}}}\",\"privMessageType\":0,\"privHeaders\":{\"Path\":\"speech.config\",\"X-RequestId\":\"7A2297F67B124C33876CAF496B7DABF6\",\"X-Timestamp\":\"2023-04-24T16:07:22.084Z\",\"Content-Type\":\"application/json\"},\"privId\":\"DA30C36F329148D58231F50472556959\",\"privSize\":173,\"privPath\":\"speech.config\",\"privRequestId\":\"7A2297F67B124C33876CAF496B7DABF6\",\"privContentType\":\"application/json\"} \n (log) RESULT [object Object]\n (log) 1 if\n (log) ERROR websocket send error: Websocket not ready 7E9767F5499D4D44AB1AEADF2328152C DA30C36F329148D58231F50472556959 Error\n at $e.sendRawMessage (functionsWorker-0.04974505925468953.js:33452:129)\n at $e. (functionsWorker-0.04974505925468953.js:33474:22)\n at Generator.next ( )\n at c (functionsWorker-0.04974505925468953.js:33336:13)\n\nI've tried several times and always get the same final error. (Websocket not ready)\n\nI'm using this code:\n\n console.log(sdk.Diagnostics.SetLoggingLevel(sdk.LogLevel.Debug));\n\n const prom = new Promise((resolve, reject) => {\n const synthesizer = new sdk.SpeechSynthesizer(speechConfig, null);\n\n synthesizer.speakSsmlAsync(\n ssml,\n async (result) => {\n console.log('RESULT', result);\n if (result.errorDetails) {\n console.log('1 if ');\n console.log('ERROR', result.errorDetails);\n synthesizer.close();\n } else {\n console.log('2 if');\n const file = new File([result.audioData], fileName, {\n type: 'audio/mp3',\n lastModified: Date.now()\n });\n const res = await context.env.R2_IGLSBKT.put(fileName, file);\n console.log('res R2', res);\n synthesizer.close(); \n resolve(fileName);\n }\n },\n (error) => {\n console.log('err', error);\n synthesizer.close();\n }\n );\n });\n \n await context.waitUntil(prom);","author_login":"rodbs","author_association":"NONE","created_at":"2023-04-24T16:14:00+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1521709044","fragment_type":"issue_comment","sequence":23,"text":"@rodbs This sounds a lot like a networking issue between Cloudflare and the endpoint. \nWhat's happening is a connection is established, then the websocket is abruptly closed before the first message can be sent. (That \"websocket not ready\" message can be found here.)There's not much I can do on the SDK side, other than ask random configuration questions like: Is there a max https connection time enforced?","author_login":"glharper","author_association":"MEMBER","created_at":"2023-04-25T12:30:58+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1540926943","fragment_type":"issue_comment","sequence":24,"text":"@glharper\nI've tried version 1.28 but I get the same error. I have contacted Cloudflare on Discord, but no luck!","author_login":"rodbs","author_association":"NONE","created_at":"2023-05-09T21:40:16+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1544040753","fragment_type":"issue_comment","sequence":25,"text":"@rodbs I'm closing this issue, as it's morphed beyond anything that the SDK itself can address. If you come up with any code-resolvable issues, feel free to open a new issue. Thanks again.","author_login":"glharper","author_association":"MEMBER","created_at":"2023-05-11T13:59:50+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1859447914","fragment_type":"issue_comment","sequence":26,"text":"If anyone else is coming up against the same problem, this seems to be an issue with Cloudflare workerd (see my comment here).\n\nThere's an open PR which looks like it should fix this.","author_login":"nmfisher","author_association":"NONE","created_at":"2023-12-18T02:31:03+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872470574","fragment_type":"issue_comment","sequence":27,"text":"hey @nmfisher, I tried your temp fix from the other thread:\n\nWebSocket.prototype.CONNECTING = 0;\nWebSocket.prototype.OPEN = 1;\nWebSocket.prototype.CLOSING = 2;\nWebSocket.prototype.CLOSED = 3;\n\nwhich did make the errors go away fortunately but I still can't get the `speakTextAsync` method to work. When running it outside cloudflare workers it works fine but on cloudflare the response doesn't match the usual shape:\n\n{\n \"privResultId\": \"E9EC170FAD994582BA01D7C185D8B41F\",\n \"privReason\": 10,\n \"privAudioData\": {},\n \"privAudioDuration\": 29125000\n }\n\nwere you able to actually get text to convert fine?","author_login":"TowhidKashem","author_association":"NONE","created_at":"2023-12-30T07:07:48+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872741606","fragment_type":"issue_comment","sequence":28,"text":"@TowhidKashem yes this is working fine for me in production using `speakSsmlAsync` in Cloudflare Pages Functions.\n \nI wouldn't expect any material difference between Functions and Pages Functions, so perhaps it's just some underlying issue with your use of the Azure SDK. Are you sure you are calling `await` at the correct place and resolving the async Promise correctly?","author_login":"nmfisher","author_association":"NONE","created_at":"2023-12-31T07:05:32+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872912296","fragment_type":"issue_comment","sequence":29,"text":"Ooof you know what I got it working, the issue was I forgot to add the credentials via the dashboard, I thought just adding them to `.dev.vars` and deploying would be enough. Anyway thanks its working now with ur temp fix!","author_login":"TowhidKashem","author_association":"NONE","created_at":"2023-12-31T10:14:33+08:00","repo_name":"microsoft/cognitive-services-speech-sdk-js","issue_id":1617636575,"issue_number":645,"issue_url":"https://github.com/microsoft/cognitive-services-speech-sdk-js/issues/645","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0230","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Seeking mechanical properties ontology?","query_context":"Hoping it will cover things like \"Rockwell C Hardness Scale\", \"The Charpy impact test\", \"Elongation / tension tests for metals\".\n\nrelated: URL \n\nAny advice welcome.","known_context_document_ids":["gh_issue_714340806"],"reference_answer":"I looked into this. QUDT does not have a role to play here; QUDT is focused on units, not which type of measurement is conducted. \n\nI suggest we close this ticket and continue our search for a proper metallurgy tests vocabulary on a fresh issue which isn't premised on QUDT.","answer_document_id":"gh_comment_1280941845","silver_evidence_path":["gh_comment_1280935103","gh_issue_1213746006","gh_comment_1280941845"],"evidence_issue_ids":[714340806,1213746006],"source_repo_name":"qudt/qudt-public-repo","source_issue_id":714340806,"source_issue_number":247,"source_issue_url":"https://github.com/qudt/qudt-public-repo/issues/247","target_repo_name":"w3c-ccg/traceability-vocab","target_issue_id":1213746006,"target_issue_number":393,"target_issue_url":"https://github.com/w3c-ccg/traceability-vocab/issues/393","reference_anchor_document_id":"gh_comment_1280935103","reference_answer_author":"nissimsan","reference_answer_author_association":"COLLABORATOR","quality_score":81.96,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.087,"anchor_target_overlap":0.3,"target_answer_overlap":0.1429},"issue_created_at":"2020-10-04T15:42:08+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_714340806","fragment_type":"issue_description","sequence":0,"text":"Seeking mechanical properties ontology\nHoping it will cover things like \"Rockwell C Hardness Scale\", \"The Charpy impact test\", \"Elongation / tension tests for metals\".\n\nrelated: URL \n\nAny advice welcome.","author_login":"OR13","author_association":"NONE","created_at":"2020-10-04T15:42:08+08:00","repo_name":"qudt/qudt-public-repo","issue_id":714340806,"issue_number":247,"issue_url":"https://github.com/qudt/qudt-public-repo/issues/247","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1016465985","fragment_type":"issue_comment","sequence":1,"text":"@dr-shorthair , this is very insightful. Turning the question around, would you recommend QUDT for trade/commerce interoperability? Or should we rather stick with CEFACT Rec20? Interpreting your point, it might seem like QUDT is would be overly generalized and Rec20 purpose build for the trade industry? \n\nNoting that CEFACT is now also expressed with IRIs, including Rec20, ex: \n URL","author_login":"nissimsan","author_association":"NONE","created_at":"2022-01-19T13:28:14+08:00","repo_name":"qudt/qudt-public-repo","issue_id":714340806,"issue_number":247,"issue_url":"https://github.com/qudt/qudt-public-repo/issues/247","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1280935103","fragment_type":"issue_comment","sequence":2,"text":"I suggest that we close this issue. It was established at the top of the discussion that QUDT is not defining metallurgy tests. QUDT is useful for the units of such tests, but not defining the tests themselves. The continued search for a good metallurgy test vocabulary should continue on trace-vocab, which is where it is needed. \n\nAlso, let's make sure to celebrate that this discussion evolved into about QUDT/UNCEFACT vocab alignment which has since been successfully implemented.","author_login":"nissimsan","author_association":"NONE","created_at":"2022-10-17T14:18:02+08:00","repo_name":"qudt/qudt-public-repo","issue_id":714340806,"issue_number":247,"issue_url":"https://github.com/qudt/qudt-public-repo/issues/247","linked_issue_ids":[1213746006],"is_known_query_context":false},{"document_id":"gh_issue_1213746006","fragment_type":"issue_description","sequence":0,"text":"Follow up on qudt\nURL \n URL \n\ncc @nissimsan can you take this one over?","author_login":"OR13","author_association":"COLLABORATOR","created_at":"2022-04-24T19:28:48+08:00","repo_name":"w3c-ccg/traceability-vocab","issue_id":1213746006,"issue_number":393,"issue_url":"https://github.com/w3c-ccg/traceability-vocab/issues/393","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1280941845","fragment_type":"issue_comment","sequence":1,"text":"I looked into this. QUDT does not have a role to play here; QUDT is focused on units, not which type of measurement is conducted. \n\nI suggest we close this ticket and continue our search for a proper metallurgy tests vocabulary on a fresh issue which isn't premised on QUDT.","author_login":"nissimsan","author_association":"COLLABORATOR","created_at":"2022-10-17T14:22:23+08:00","repo_name":"w3c-ccg/traceability-vocab","issue_id":1213746006,"issue_number":393,"issue_url":"https://github.com/w3c-ccg/traceability-vocab/issues/393","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0231","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Fix Error 1002 missing schema on project installer.","query_context":"## Description of the bug\nEnabled project installer on a site that had been upgraded a while ago from D7 but have always used `bee` to download and install.\nI don't think project installer was enabled on the D7 site so an update might have been missed and may not have the projects server listed.. I don't get this anywhere else.\nGot error (that looks like success message) and no projects listed\n\nThis is may not be a Backdrop bug and may be related to the upgrade process and the unusual circumstances of not having project installer enabled, but would appreciate guidance on how to fix it. Happy to apply SQL but don't know where to look.\n\n## Steps To Reproduce\nNot sure - perhaps start with D7 site with project installer disabled\nThen upgrade\nThen enable project installer \n\n## Actual behavior\n\nNo results returned. Notices, warnings and error message. \n\nimage\n\n \nWarning: array_merge(): Expected parameter 2 to be an array, null given in installer_browser_fetch_results() (line 240 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 248 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 256 of /app/docroot/core/modules/installer/installer.browser.inc).\nDismiss\nStatus messageEncountered an error when trying to fetch results from . Error -1002 : missing schema\n \n\nAlso can't install by manual > install projects by name\n\nimage\n\n \nWarning: array_merge(): Expected parameter 2 to be an array, null given in installer_browser_fetch_results() (line 240 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 248 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 256 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Undefined index: projects in installer_manager_install_form_validate() (line 688 of /app/docroot/core/modules/installer/installer.manager.inc).\nSorry, the project server is offline.\nNotice: Trying to access array offset on value of type null in installer_manager_install_form_validate() (line 723 of /app/docroot/core/modules/installer/installer.manager.inc).\nNotice: Trying to access array offset on value of type null in installer_manager_install_form_validate() (line 726 of /app/docroot/core/modules/installer/installer.manager.inc).\nNotice: Trying to access array offset on value of type null in installer_manager_install_form_validate() (line 744 of /app/docroot/core/modules/installer/installer.manager.inc).\nDismiss\nStatus messageEncountered an error when trying to fetch results from . Error -1002 : missing schema\n \n\n## Expected behavior\n\nProject installer lists projects and allows install by name\n\n## Additional information\n\nAdd any other information that could help, such as:\n- Backdrop CMS version: 1.22\n- Web server and its version: apache\n- Operating System and its version: n/a\n- Browser(s) and their versions: n/a","known_context_document_ids":["gh_issue_1310956353"],"reference_answer":"@olafgrabienski:\n \n\n@findlabnet:\n \n\nYes, absolutely! I had this same thought today but you two beat me to suggesting it. Let's included this core update functionality in 1.11.0 but hide it. We can enable it by default in a later release.\n\nWe already have an `installer.settings.json` config file. We should add a new option for enabling core updates, e.g. `config_get('installer.settings', 'core_update')`.\n\nIn fact it would be great to have all of the various installation/updating options be able to be toggled (e.g. `\"module_update\", \"module_install\", \"theme_update\", \"theme_install\", \"layout_update\", \"layout_install\"`). But as we're in a time crunch, let's add the toggle for core only and expand that out later. Our primary concern here is just making it so that we can test this after release with a real example and the whole system together.\n\nSo we need the following:\n\n- Add `core_update: false` to `installer.settings.json`.\n- An update hook to set the default to `false` for existing sites.\n- A conditional check ensuring `config_get('installer.settings', 'core_update')` is TRUE before allowing any core updates.\n\nAt this point, I don't think any UI for toggling the option is needed.","answer_document_id":"gh_comment_417819553","silver_evidence_path":["gh_comment_1191096803","gh_issue_322612121","gh_comment_417819553"],"evidence_issue_ids":[1310956353,322612121],"source_repo_name":"backdrop/backdrop-issues","source_issue_id":1310956353,"source_issue_number":5690,"source_issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","target_repo_name":"backdrop/backdrop-issues","target_issue_id":322612121,"target_issue_number":3105,"target_issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","reference_anchor_document_id":"gh_comment_1191096803","reference_answer_author":"quicksketch","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1,"anchor_target_overlap":0.24,"target_answer_overlap":0.1167},"issue_created_at":"2022-07-20T12:07:31+08:00","valid_comment_count":66,"fragments":[{"document_id":"gh_issue_1310956353","fragment_type":"issue_description","sequence":0,"text":"Fix Error 1002 missing schema on project installer.\n## Description of the bug\nEnabled project installer on a site that had been upgraded a while ago from D7 but have always used `bee` to download and install.\nI don't think project installer was enabled on the D7 site so an update might have been missed and may not have the projects server listed.. I don't get this anywhere else.\nGot error (that looks like success message) and no projects listed\n\nThis is may not be a Backdrop bug and may be related to the upgrade process and the unusual circumstances of not having project installer enabled, but would appreciate guidance on how to fix it. Happy to apply SQL but don't know where to look.\n\n## Steps To Reproduce\nNot sure - perhaps start with D7 site with project installer disabled\nThen upgrade\nThen enable project installer \n\n## Actual behavior\n\nNo results returned. Notices, warnings and error message. \n\nimage\n\n \nWarning: array_merge(): Expected parameter 2 to be an array, null given in installer_browser_fetch_results() (line 240 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 248 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 256 of /app/docroot/core/modules/installer/installer.browser.inc).\nDismiss\nStatus messageEncountered an error when trying to fetch results from . Error -1002 : missing schema\n \n\nAlso can't install by manual > install projects by name\n\nimage\n\n \nWarning: array_merge(): Expected parameter 2 to be an array, null given in installer_browser_fetch_results() (line 240 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 248 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Trying to access array offset on value of type null in installer_browser_fetch_results() (line 256 of /app/docroot/core/modules/installer/installer.browser.inc).\nNotice: Undefined index: projects in installer_manager_install_form_validate() (line 688 of /app/docroot/core/modules/installer/installer.manager.inc).\nSorry, the project server is offline.\nNotice: Trying to access array offset on value of type null in installer_manager_install_form_validate() (line 723 of /app/docroot/core/modules/installer/installer.manager.inc).\nNotice: Trying to access array offset on value of type null in installer_manager_install_form_validate() (line 726 of /app/docroot/core/modules/installer/installer.manager.inc).\nNotice: Trying to access array offset on value of type null in installer_manager_install_form_validate() (line 744 of /app/docroot/core/modules/installer/installer.manager.inc).\nDismiss\nStatus messageEncountered an error when trying to fetch results from . Error -1002 : missing schema\n \n\n## Expected behavior\n\nProject installer lists projects and allows install by name\n\n## Additional information\n\nAdd any other information that could help, such as:\n- Backdrop CMS version: 1.22\n- Web server and its version: apache\n- Operating System and its version: n/a\n- Browser(s) and their versions: n/a","author_login":"yorkshire-pudding","author_association":"MEMBER","created_at":"2022-07-20T12:07:31+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1190262546","fragment_type":"issue_comment","sequence":1,"text":"Very odd. Can you check the following:\n\n- Does the problem persist when you flush all caches?\n- Does the config file `installer.settings.json` exist in your active config directory?\n- If it does, what are the contents?\n\nBackground to this: the first problem seems that in `array_merge($filters, $server)` the $server variable seems to be null, but there's a default setting, so it at least contains ` URL","author_login":"indigoxela","author_association":"MEMBER","created_at":"2022-07-20T13:05:05+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1190284911","fragment_type":"issue_comment","sequence":2,"text":"The problem is not likely related to the upgrade. In D7, the installer is a module called `update`, which doesn't exist in Backdrop, where the installer is called `installer`. In fact, no \"D7 to Backdrop\" upgrade ever has the `installer` module on after the upgrade (it's one of those modules that don't get automatically enabled) - you always have to enable it manually after the upgrade, regardless of whether the D7 had `update` on or off. So you can most likely discard the upgrade process (in fact `installer.install` has only one hook_update_N(), which is not related to the upgrade process). \n\nAs @indigoxela pointed out, the most likely culprit is a problem with `installer.settings.json`. Inspect that file both in your site's `files` folder and in the `core/modules/installer/config` location.\n\nAlso, you may have a files directory problem. Check the site's `settings.php` file (and any possible `settings.local.php` file) for the line `$config_directories['active']` and see where it points, then be sure that `installer.settings.json` is present in that folder.","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-20T13:25:34+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1190404101","fragment_type":"issue_comment","sequence":3,"text":"I agree. In fact, I've upgraded dozens of sites while testing other PRs and this hook has never before run. I think it's safe to remove this hook, as there is no \"update\" from a D7 version, as `installer` doesn't exist in D7 (update_1000() is used for upgrades from D7). \n\nI've done more testing to verify: I can confirm that enabling Installer in a freshly upgraded D7->B site does not run `installer_update_1000()`. I've tested this via en UI and via bee. I haven't tested with drush.\n\nBottom line: I can't explain if or why this hook ran in @yorkshire-pudding site. But it's probably a good idea to leave this open in case others run into this issue.","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-20T15:06:02+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191096803","fragment_type":"issue_comment","sequence":4,"text":"Looking at git blame - this update hook came in with #3105 and still seems OK. Its main intention was to prevent enabling core updates for B sites installed before the core update was enabled.\n\nThere are two situations, though, where this hook does harm:\n\n1. Upgrading from D7\n2. Very, very old B sites (older than 1.11.0) that have the installer disabled\n\nSo, why does this stub config problem exist.\nYou can verify with following code:\n\n$config = config('foobar');\ndebug($config);\n$config->set('bla', 'blu');\ndebug($config);\n$config->save();// Problem!\n\nThe fix can be a one-liner, we only have to check if `$config-isNew()` and in that case do nothing.","author_login":"indigoxela","author_association":"MEMBER","created_at":"2022-07-21T06:35:08+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[322612121],"is_known_query_context":false},{"document_id":"gh_comment_1191119373","fragment_type":"issue_comment","sequence":5,"text":"A PR is available for testing and review.\n\n**How to test:**\n\nUpdate from D7 and verify there's no stub installer.settings.json file in the active config dir\nor\nUpdate from a B install older than 1.11.0 - in that case: if the installer was on, the core updates should be off in config. If the installer was off, no stub file gets created in the active config dir.\n\nI hope, my explanation is clear enough (I often fail to properly explain things) :wink:.","author_login":"indigoxela","author_association":"MEMBER","created_at":"2022-07-21T07:03:24+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191355283","fragment_type":"issue_comment","sequence":6,"text":"Thanks @indigoxela. I confirm:\n- after running `core/update.php` there is no `installer.settings.json`\n- After enabling Project Installer it is there and module works as expected.","author_login":"yorkshire-pudding","author_association":"MEMBER","created_at":"2022-07-21T11:11:46+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191553607","fragment_type":"issue_comment","sequence":7,"text":"Aha! I see that update hook was added as per this comment in that issue. 3105 Thanks @indigoxela. (I did my homework and read the whole thread this time 😉 ) \n\nYour fix makes sense. But your explanations for testing make only partial sense to me:\n \n\nThis doesn't make sense to me. Before your patch, none of the D7 upgrades I'm doing ever run `installer_update_1000()`, and none of them ever create a \"stub\" `installer.settings.json` file - neither before, nor after your patch. This is because `installer` doesn't exist in D7, and therefore it is always disabled when upgrading from D7. And when you manually enable `installer` with the current version of Backdrop after the upgrade, the update hook is not run (which is the expected behavior).\n\nAs I said above, the D7 upgrade **itself** was probably never the problem. It alone can't explain @yorkshire-pudding problem. There must have been an additional problem in between. \n \nUpdate from a B install older than 1.11.0 - in that case: if the installer was on, the core updates should be off in config. If the installer was off, no stub file gets created in the active config dir.\n\nSo, this is also not clear to me.\n\nI did try this:\n- Started with version 1.10.2. (Backdrop looked a bit different back then! 😄 )\n- I manually turned off the installer. \n- I upgrade to 1.11.0. No \"stub\" file is created. Simply: the update hook is not run because `installer` is off, and the stub json file is not created.\n\nThen I tried this:\n- Started with version 1.10.2.\n- I made sure installer is ON. The file `installer.settings.json` file exists normally \"sans\" the `core_update` setting\n- Updated to 1.11.0. The `installer.settings.json` file is updated (the update DOES run this time) and `\"core_update\" : false` is added normally. The rest of the json file is left untouched - it's not a stub file, but a beautifully looking full settings file.\n\nSo none of these situations can explain @yorkshire-pudding problem either.\n\nMy theory is that something went wrong with @yorkshire-pudding's site, and that it was really a fringe case. Therefore fixing `installer.install` with your patch may not be necessary. Your patch doesn't do any harm and is very simple, but it may not be needed in normal situations. Still... better safe than sorry, so I'm going to marked this as RTBC.\n\nSo this is my theory of what happened to @yorkshire-pudding:\n- He probably updated from D7 before 1.11.0. But this fact is probably irrelevant as I explained above.\n- He enabled `installer` in his pre 1.11.0 version in a way that did not move `installer.settings.json` to the config folder (perhaps manually switching it on in the database?), OR that json file was somehow removed from the config directory. So he ended up with an enabled `installer` and no json file, **somehow**. \n- He then updated Backdrop to 1.11.0, and this ran `installer_update_1000()`. But since there was no json file in the config folder, then the empty stub was created","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-21T14:26:52+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[322612121],"is_known_query_context":false},{"document_id":"gh_comment_1191583580","fragment_type":"issue_comment","sequence":8,"text":"@argiepiano thank you so much for your thorough testing! :pray: \n\nYou're absolutely right, the problem must be something else - and I found a way to reproduce it on a fresh vanilla install:\n\n1. Disable and uninstall the installer module (json file gone)\n2. Go to /admin/reports/updates/settings\n3. Save the file - at this point the stub json file gets created\n4. Enable the installer module again - the file stays broken\n\nSo the bug is indeed somewhere else: it's in function update_settings() - the form still displays the core update setting, even if the installer module isn't enabled.","author_login":"indigoxela","author_association":"MEMBER","created_at":"2022-07-21T14:52:25+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191604131","fragment_type":"issue_comment","sequence":9,"text":"Never too late to switch strategy. :wink:\n\nA totally different PR is available for testing and review. Sorry to waste your (testing) time.\n\nThis time testing is much easier (can also happen in the sandbox). Just follow the steps in my previous comment.","author_login":"indigoxela","author_association":"MEMBER","created_at":"2022-07-21T15:10:01+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191607243","fragment_type":"issue_comment","sequence":10,"text":"Wow! That explains the problem, and it's indeed something that can happen much more often. I think the problem is that the option to enable the Manual self update should not be shown if installer is disabled, right?\n\nI see you just submitted a new PR. I'll take a look","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-21T15:12:40+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191607588","fragment_type":"issue_comment","sequence":11,"text":"That makes sense and is almost certainly what happened.\nThanks - will do test","author_login":"yorkshire-pudding","author_association":"MEMBER","created_at":"2022-07-21T15:12:57+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191621489","fragment_type":"issue_comment","sequence":12,"text":"This new PR looks great and WFM. All tests passing. RTBC. Perhaps we should change the title of this issue to reflect the new direction? \n\nThanks for digging into this and finding the culprit, @indigoxela!","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-21T15:21:15+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191640546","fragment_type":"issue_comment","sequence":13,"text":"One more thought. \n\nFor sites that currently present the problem described by @yorkshire-pudding in this issue (because Project Installer was disabled, and they visited and saved the form at `/admin/reports/updates/settings`): this patch with not fix the already problem created by the faulty code. The stub json file already exists in the config directory. \n\nIn fact there are only two ways to fix the problem once it's created: (1) manually fix the json file as @yorkshire-pudding did. (2) Or you would need to enable and then disable `installer` to fully remove the faulty json file.\n\nShould we provide another upgrade hook that checks that the json file exists, and if it contains the key `\"installer_server\"`, and if not, creates the default installer_server entry?","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-21T15:36:23+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191643406","fragment_type":"issue_comment","sequence":14,"text":"I've tested the PR and works. Thanks @indigoxela you are a star.\n@argiepiano - good point, though not sure how common it will be.","author_login":"yorkshire-pudding","author_association":"MEMBER","created_at":"2022-07-21T15:39:02+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191647633","fragment_type":"issue_comment","sequence":15,"text":"@argiepiano @indigoxela \nWould a suitable title be: \"Project installer doesn't work if settings are changed while disabled\"\n?","author_login":"yorkshire-pudding","author_association":"MEMBER","created_at":"2022-07-21T15:42:58+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191945548","fragment_type":"issue_comment","sequence":16,"text":"It can be common. If you upgrade a D7 site, Installer is disabled by default. If you visit `/admin/reports/updates/settings` and save that form, the faulty json file is created. At this point the only way to fix the problem is to manually alter the json file as @yorkshire-pudding did, OR installing - fully uninstalling - installing again Project Installer so that the uninstall step removes the faulty file.\n\nThis update hook is simple. It would check if a faulty json config file exists, and restore the default value. It could look like this\n\nphp\nfunction installer_update_1001() {\n $config = config('installer.settings');\n if (!$config->isNew() && empty($config->get('installer_server'))) {\n $config->set('installer_server', array(\n 'url' => ' URL \n 'name' => 'Backdrop',\n ));\n $config->save();\n }\n}","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-21T21:19:22+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192009586","fragment_type":"issue_comment","sequence":17,"text":"Thanks @indigoxela, @yorkshire-pudding, and @argiepiano! I merged URL since it stands alone as a great fix.\n\n@argiepiano I think your idea to make a \"fix bad JSON\" update might also help be comprehensive. Do you think we should add that as well?","author_login":"quicksketch","author_association":"MEMBER","created_at":"2022-07-21T22:54:56+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192025326","fragment_type":"issue_comment","sequence":18,"text":"Perhaps on a separate issue, for 1.23.0, since this was merged already? Or is there time to do this for 1.22.2? I can probably open a new issue and PR in the next 3 or 4 hours","author_login":"argiepiano","author_association":"NONE","created_at":"2022-07-21T23:27:13+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192125314","fragment_type":"issue_comment","sequence":19,"text":"Yeah let's do it as a new issue. Doesn't necessarily need to wait for\n1.23.0 though. We could get it in 1.22.3.\n\nOn Thu, Jul 21, 2022, 5:27 PM Alejandro Cremaschi ***@***.***>\nwrote:","author_login":"quicksketch","author_association":"MEMBER","created_at":"2022-07-22T02:50:38+08:00","repo_name":"backdrop/backdrop-issues","issue_id":1310956353,"issue_number":5690,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/5690","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_322612121","fragment_type":"issue_description","sequence":0,"text":"[DX] Add core updates via Backdrop UI.\n## Describe your issue or idea\n\nIn URL we are interested in providing the ability for automatic updates to Backdrop core. As an initial step towards that goal this issue adds the ability to manually update Backdrop core via UI at `/admin/modules/update`\n\n### Actual behavior (if reporting a bug)\n\nCurrently at `/admin/modules/update` core updates are relegated to there own `Manual` section that prompts the user to download Backdrop and then move the files around themselves via server tools or cli.\n\n### Expected behavior (if reporting a bug)\n\nAllow updating of core by selecting the core update from `/admin/modules/update` from the list the same way you can update modules.\n\n### Relevant version/system information (if applicable)\n\n`1.x`\n\n----\n\n~~PR: URL this one was `corrupted` w/ `.swp` file\n~~PR: URL \nPR: URL","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-13T17:27:40+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388644317","fragment_type":"issue_comment","sequence":1,"text":"This one can not be tested via sandbox; since sandboxes are downloading `1.x` backdrop (which does not need an update)\n\nTo test (I\"m using lando so I can have drush and things I need):\n\n* Initiate a backdrop site\n \n\nbash\nlando init\n\nselect backdrop\n\n* download an old backdrop\n * lando.dev drush dlb backdrop --select\n * select an eld backdrop I chose `1.9.3` which at the time of this writing was option `2`\n\n* install backdrop\n\nbash\nlando drush si --db-url=mysql://backdrop:backdrop@database/backdrop\n\nMake note of the username and password (you can install via UI as well, this is just a little faster if say you want to test this `11` times).\n\n* Apply this patch: URL \n\n * get the patch:\n\nbash\nwget URL \n\n * apply\n \n\nbash\npatch -p1 < 2186.patch\n\nyou should see output similar to: \n\nbash\ngeoff@yep backdrop exit code: [0] $ patch -p1 < 2186.patch\npatching file core/modules/system/system.updater.inc\npatching file core/includes/updater.inc\npatching file core/modules/installer/installer.authorize.inc\npatching file core/modules/installer/installer.manager.inc\npatching file core/modules/installer/installer.module\npatching file core/modules/system/system.module\nHunk #1 succeeded at 2113 (offset -48 lines).\nHunk #2 succeeded at 3829 (offset -48 lines).\npatching file core/modules/system/system.updater.inc\n\n* clear cache so Backdrop can pick up on the new class `CoreUpdater`\n\nbash\nlando drush cc all\n\n* visit: `/admin/modules/update`; you should see:\n\n<img width=\"1635\" alt=\"screen shot 2018-05-13 at 1 52 47 pm\" src=\" URL \n\n* select the Backdrop update checkbox and proceed as normal.","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-13T17:53:58+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388645055","fragment_type":"issue_comment","sequence":2,"text":"Sorry if I lost something, but for doing such all document root should be writable for web-server?","author_login":"findlabnet","author_association":"NONE","created_at":"2018-05-13T18:06:37+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388665309","fragment_type":"issue_comment","sequence":3,"text":"Who knew it was this easy?!\n\nIt worked smoothly for me. I tested with Lando using @serundeputy's steps -- quite helpful!\n\nA few things:\n\n* This is pretty awesome.\n* swp file shouldn't be in the PR I'm guessing\n* We should change the links on the status page to point to the Update module tab instead of where it points now. Currently someone would click on the red dot at the top:\n\nscreenshot from 2018-05-13 19-52-05\n\nThen when the click *Available Updates* it brings them to:\n\nscreenshot from 2018-05-13 19-45-30\n\nwhich sadly makes it seem like all you can do is download the release and manually upgrade.\n\n* Is it just installing the `/core` folder or also index.php, .htaccess and so on? I couldn't tell from the code. If the latter should we put a warning that any customizations to .htaccess or the like will be lost?","author_login":"herbdool","author_association":"NONE","created_at":"2018-05-13T23:58:21+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388666377","fragment_type":"issue_comment","sequence":4,"text":"Maybe we need to add ability for people to disable these updates in settings.php similar to how Wordpress does it URL","author_login":"herbdool","author_association":"NONE","created_at":"2018-05-14T00:13:35+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388867429","fragment_type":"issue_comment","sequence":5,"text":"Haven't tested yet but will do so as soon as I can (looks awesome!). The screenshot brings to mind this issue: URL \n\n(e.g. core updates show up under \"Update Modules\"? Maybe it's time just to have a single \"Update\" page that lists core, modules, layouts, themes...)","author_login":"laryn","author_association":"CONTRIBUTOR","created_at":"2018-05-14T15:53:03+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388909243","fragment_type":"issue_comment","sequence":6,"text":"Wow, I've successfully updated a Backdrop 1.9.3 remote test site (on shared hosting) via the UI.\n\n(Will try to do the same with another test site soon.)","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-14T18:04:06+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_388968178","fragment_type":"issue_comment","sequence":7,"text":"@herbdool \n \n\n * removed; thaks\n \n\n * updated PR with link from /admin/reports/updates to /admin/modules/update\n<img width=\"1622\" alt=\"screen shot 2018-05-14 at 5 22 17 pm\" src=\" URL \n\n@olafgrabienski, @laryn, @herbdool thanks for testing; if you test further download the latest patch please:\n\nbash\nwget URL","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-14T21:25:48+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389060311","fragment_type":"issue_comment","sequence":8,"text":"For .htaccess files (or other potential updates to root files), we typically parse them on status checks to make sure they have the needed information in them. Same thing for settings.php. If something is amiss in those core files, we have been (and should continue to) flag problems in `system_requirements()`. I also agree we should be overwriting those files, and attempting to merge/update them is a potentially messy business.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2018-05-15T06:43:25+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389137655","fragment_type":"issue_comment","sequence":9,"text":"@quicksketch \n \n\ndid you mean you agree `we should not be` overwriting ... ?","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T11:45:25+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389171715","fragment_type":"issue_comment","sequence":10,"text":"@serundeputy I've tried to get the latest patch release for another test, using `wget URL as recommended by you. I guess that didn't work for me, at least there was no link to `admin/modules/updates` on the *Available updates* page. The auto-update worked however, just like my test yesterday.\n\nMaybe I didn't answer the \"Assume\" question during patching correctly? (The first time I answered with `n` and the patch hadn't been applied, so I started from scratch, answering this time with `y`.)\n\npatch -p1 < 2186.patch\npatching file core/modules/system/system.updater.inc\npatching file core/includes/updater.inc\nFile core/modules/installer/.installer.authorize.inc.swp: git binary diffs are not supported.\npatching file core/modules/installer/installer.authorize.inc\npatching file core/modules/installer/installer.manager.inc\npatching file core/modules/installer/installer.module\npatching file core/modules/system/system.module\nHunk #1 succeeded at 2113 (offset -48 lines).\nHunk #2 succeeded at 3829 (offset -48 lines).\npatching file core/modules/system/system.updater.inc\nThe next patch would delete the file core/modules/installer/.installer.authorize.inc.swp,\nwhich does not exist! Assume -R? [n] y\nFile core/modules/installer/.installer.authorize.inc.swp: git binary diffs are not supported.\npatching file core/modules/update/update.theme.inc","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-15T13:44:40+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389173015","fragment_type":"issue_comment","sequence":11,"text":"Another thing: After updating, on `core/authorize.php` I read:\n \n \n\nand\n \n \n \n\nI guess, \"Your projects have been downloaded and updated.\" should move above the \"Next steps\" section.","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-15T13:48:31+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389186201","fragment_type":"issue_comment","sequence":12,"text":"@olafgrabienski since you already have a patch applied the new patch did not apply.\n\nYou'll either want to start with a fresh install of Backdrop < 1.9.5 and apply the patch\n\nor\n\nFigure out the answers to apply the new patch on top of the old patch.\n\nI've just been blowing away the install and getting a new pre 1.9.5 backdrop release\n\nyou can do that with:\n\nbash\ndrush dlb backdrop --select\n\nthanks for testing!","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T14:25:25+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389192074","fragment_type":"issue_comment","sequence":13,"text":"@serundeputy I don't see any difference on the status report after trying your latest patch.\n\nI think instead of linking the title \"Security update required\" we should make it an action: **Update Backdrop** and then we either reword \"Download\" to \"Alternative: download\" or something, or we get rid of it altogether. For those who are manually updating they already know how to get the file, everyone else will have a clear option to upgrade via the UI.","author_login":"herbdool","author_association":"NONE","created_at":"2018-05-15T14:41:28+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389195049","fragment_type":"issue_comment","sequence":14,"text":"thanks @herbdool \n \n\n * the difference is that the `Security update required` text is now a link to `/admin/modules/update`\n \n\n * I just did it this way because that is what happens for modules that appear on the updates page. That doesn't mean we have to keep it that way, but that is the way it is now. So, before changing that too much I'd like to have a consensus on the change. Otherwise the dev (me in this case) ends up writing a lot of code that chase disparate ideas.\n\nHow we come to consensus has always been a mystery to me ;) ; let's see if others chime in.","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T14:49:32+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389195977","fragment_type":"issue_comment","sequence":15,"text":"oh; i see you are saying no change on `status report`; yep i did not change that as it already links to `admin/modules/update` and the other link goes to the updates list. Is this not the desired behaviour?","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T14:51:52+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389208804","fragment_type":"issue_comment","sequence":16,"text":"I don't see either change.\n\nThis is what I see at `admin/reports/status`:\nscreenshot from 2018-05-15 11-22-21\nhas both links going to `/admin/reports/updates` and that looks like:\nscreenshot from 2018-05-15 11-22-40\nwhich still looks like the old format.","author_login":"herbdool","author_association":"NONE","created_at":"2018-05-15T15:26:57+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389234025","fragment_type":"issue_comment","sequence":17,"text":"@herbdool I'm guessing either the patch isn't applied (maybe it failed) or cache. It is working for me:\n\nbcms-updates","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T16:42:15+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389312686","fragment_type":"issue_comment","sequence":18,"text":"@serundeputy That's what I did. Seems to be the same issue which happens to @herbdool. Going to disable cache now.","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-15T21:03:36+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389314757","fragment_type":"issue_comment","sequence":19,"text":"i guess the removal of the `.swp` file is causing you folks issues with the patch.","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T21:11:09+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389322720","fragment_type":"issue_comment","sequence":20,"text":"Sounds reasonable! Anything we can change by ourselves there, or better wait for a revised patch?","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-15T21:41:23+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389327479","fragment_type":"issue_comment","sequence":21,"text":"I'm not sure why the patch works for me and not for you or @herbdool different os?\n\nI'm on:\n\nbash\ngeoff@yep backdrop (1.x) exit code: [0] $ sw_vers\nProductName: Mac OS X\nProductVersion: 10.13.4\nBuildVersion: 17E202\n\nand the command i issue for the patch is:\n\nbash\npatch -p1 < 2186.patch","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T22:01:11+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389329642","fragment_type":"issue_comment","sequence":22,"text":"I'm on a remote server (shared hosting), OS is Linux Ubuntu.","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-15T22:10:41+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389331441","fragment_type":"issue_comment","sequence":23,"text":"Could this notice (during patching) be of interest?\n\n`The next patch would delete the file core/modules/installer/.installer.authorize.inc.swp,\nwhich does not exist!`\n\nDoes it make sense to remove the `.swp` file related code of the patch?","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-05-15T22:18:17+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389333614","fragment_type":"issue_comment","sequence":24,"text":"I made a commit that removed the `.installer.authorize.inc.swp` file which i had accidentally committed on the first go round. so now this patch has a delete ref to a file that does not exist.\n\nMaybe if you put a blank file there before applying the patch it will be happier?\n\nbash\ntouch core/modules/installer/.installer.authorize.inc.swp\n\nA terrible hack, I know, not very convenient, but might get you up and testing again.","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-15T22:28:17+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389686649","fragment_type":"issue_comment","sequence":25,"text":"I'm glad to see concrete headway on this in Backdrop! Just to touch base, there's more overall interest and activity around this in Drupal now than in the past as well, though ambitions still far rival contributors. Hence I tihnk it's great to see simpler / custom-tailored solutions like this that work for many people and for Backdrop specifically.\n\nDrupal's objectives, as backed by several official initiatives, include getting the Composer engine to run behind an in-browser experience, the concept of a live and inactive code tree that a small readonly \"bootloader\" can toggle between to make multi-file code changes totally atomic and provide some rollback capability, code signing and verification, and hopefully some of the work I did a year or so ago too :). So basically we're letting perfect be the enemy of good, but maybe the day will come where we have something really neat and worth sharing. (It's always been my goal to solve this stuff without tightly coupling it to D8 core, and I've succeeded, I think, in selling that idea.)","author_login":"mbaynton","author_association":"NONE","created_at":"2018-05-16T22:32:16+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_389888874","fragment_type":"issue_comment","sequence":26,"text":"@olafgrabienski you could open the patch file and take out the `swp` stuff then apply the patch.\n\nI think when I get time I'll re-roll the PR and therefore the patch to never have had the erroneously committed `swp` ☘️ \n\nthanks for your dedication!","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-17T14:35:50+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_390490842","fragment_type":"issue_comment","sequence":27,"text":"@olafgrabienski @herbdool @laryn I've re-rolled the patch sans `.swp` file hopefully it will apply cleanly for you folks now and allow for testing.\n\nPatch: URL \n\nbe nice to get this in so we can start working on the automatic part of it.","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-05-20T15:33:41+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_391130271","fragment_type":"issue_comment","sequence":28,"text":"I just took a look at the patch and I think it is adding the `.swp` file and then later removing it. I tried to remove all `.swp` references (attached) and applied it to a dev site on a remote server:\n\n[~/remote_dev/backdrop_html]# patch -p1 temporary://update-extraction-2042941c/backdrop/profiles/testing/modules/backdrop_system_listing_compatible_test/backdrop_system_listing_compatible_test.tests.info ) does not define a 'type' attribute. in Updater::getProjectType() (line 194 of /remote_dev/backdrop_html/core/includes/updater.inc).\n\n2201_sans_swp.patch.txt","author_login":"laryn","author_association":"CONTRIBUTOR","created_at":"2018-05-22T20:30:32+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_397862644","fragment_type":"issue_comment","sequence":29,"text":"Thanks @serundeputy and everyone else that's working hard for this. I am about to give it a go, so I should return back with more. Just wanted to quickly provide the following feedback, in case I get distracted...\n \n\nYep, we need to find a good way to deal with this. A \"flag\" someplace?\n \n\n...please, do not get me started! 😄\n \n\n@quicksketch no you didn't 😛...\"we not should\" 😆","author_login":"klonos","author_association":"MEMBER","created_at":"2018-06-17T08:17:02+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_397865045","fragment_type":"issue_comment","sequence":30,"text":"I have tested this on a 1.9.5 installation:\n\nwget URL \n...\npatch -p1 < 2186.patch\npatching file core/modules/system/system.updater.inc\npatching file core/includes/updater.inc\nFile core/modules/installer/.installer.authorize.inc.swp: git binary diffs are not supported.\npatching file core/modules/installer/installer.authorize.inc\npatching file core/modules/installer/installer.manager.inc\npatching file core/modules/installer/installer.module\npatching file core/modules/system/system.module\nHunk #1 succeeded at 2113 (offset -48 lines).\nHunk #2 succeeded at 3829 (offset -48 lines).\npatching file core/modules/system/system.updater.inc\nThe next patch would delete the file core/modules/installer/.installer.authorize.inc.swp,\nwhich does not exist! Assume -R? [n] y\nFile core/modules/installer/.installer.authorize.inc.swp: git binary diffs are not supported.\npatching file core/modules/update/update.theme.inc\n\nThe update was downloaded, and I was redirected to `/admin/update/ready`, but clicking the \"Continue\" button resulted in this error:\n\nscreen shot 2018-06-17 at 6 29 15 pm\n\n...and it resulted in a totally broken installation (\"Forbidden, You don't have permission to access / on this server.\"). I had seen this error before in the past, and it had to do with folder permissions. So I have restarted the environment and got my installation to work once again. After the restart, the installation was still on 1.9.5 and attempting to reinstall the latest 1.10.1 got me to this loop of error.\n\nI was testing using URL which is what I currently use for all my other local setups. I can give lando/ddev a go, but as @olafgrabienski, I would like to bring some environment diversity to add to the test cases. We should make sure that this works \"everywhere\".\n\n@serundeputy I am looking for ways to troubleshoot this further, so can you please explain where is the new update file supposed to be downloaded and how/where does it get extracted, so I can as a first step start by verifying that these steps are actually being performed?\n\nThanks","author_login":"klonos","author_association":"MEMBER","created_at":"2018-06-17T09:05:49+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_397865164","fragment_type":"issue_comment","sequence":31,"text":"...this repeated PHP error that was caught in the logs might be of help 😄:\n\nUpdaterException: The info file ( temporary://update-extraction-90c96fad/backdrop/profiles/testing/modules/backdrop_system_listing_compatible_test/backdrop_system_listing_compatible_test.tests.info ) does not define a 'type' attribute. in Updater::getProjectType() (line 194 of /var/beetbox/docroot/core/includes/updater.inc).","author_login":"klonos","author_association":"MEMBER","created_at":"2018-06-17T09:08:10+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_397867222","fragment_type":"issue_comment","sequence":32,"text":"...I think that the `[BackdropSystemListingCompatibleTestCase]` line at the top of the .info file upsets the installer. I have moved the `name = Installation profile module tests helper` above that, and it then moved to the next step, which was `/core/authorize.php`:\n\nscreen shot 2018-06-17 at 7 45 16 pm\n\n...this is as far as I get with other modules/themes/layouts with my current setup, so that's good progress 😄. I think I'll give it a rest now.","author_login":"klonos","author_association":"MEMBER","created_at":"2018-06-17T09:46:42+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_397870896","fragment_type":"issue_comment","sequence":33,"text":"...oh you know me, I simply could not leave it alone. I have tried this quickly on ddev. Same problem and same errors in the log. I have then tested a quick and dirty \"fix\": I have commended this line out and replaced it with simply `$info['type'] = \"module\";`. Gave it yet another go, and everything worked just flawlessly this time!\n\nSo I guess all we have to do now is to make the installer happy with finding (or not) `type = module` in .info files of test modules.","author_login":"klonos","author_association":"MEMBER","created_at":"2018-06-17T10:59:46+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_412303110","fragment_type":"issue_comment","sequence":34,"text":"I took a shot at a first pass at some documentation on what kinds of file permissions are required for the updates via UI to be possible are and some of the consequences. Definitely needs our docs crew to look it over and help out with wording. It is in part based on this Drupal node: URL pared down and tailored for Backdrop.\n\nI nominate: @docwilmot, @jenlampton, @quicksketch, @klonos, @mikemccaffrey, @wesruv, and Jack Aponte to have a look: URL","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-08-11T21:38:43+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_412844644","fragment_type":"issue_comment","sequence":35,"text":"I have done a first pass @serundeputy. A missing space here, some commas there to make things more readable, and we're looking good 😉\n\nits good","author_login":"klonos","author_association":"MEMBER","created_at":"2018-08-14T11:45:24+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_412980238","fragment_type":"issue_comment","sequence":36,"text":"@serundeputy I tested this PR again. I think it works fine, though I've got a couple things that need fixing in order for it to work:\n\n1. The PR probably has to be squashed before merging. And if people are going to test with a patch they need to manually remove the sections with the .swp file. I know you removed it but in the patch you'll see that there is both a diff to *add* the .swp binary and then another diff to *remove* it. So I presume that squashing this will ensure that this history just disappears and there will be no mention of the .swp file.\n2. If people are testing with an old version of backdrop they should realize that older versions have line 114 in `update.theme.inc` line 114 wrong. It needs to reference the correct module. It should be `if ($update_link && module_exists('installer')) {` and NOT `project_installer`, which doesn't exist. The current 1.10.0 release has it right.\n\nSo a good MVP here!","author_login":"herbdool","author_association":"NONE","created_at":"2018-08-14T18:59:38+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_412981445","fragment_type":"issue_comment","sequence":37,"text":"@klonos before testing this again, can you check the patch file? Remove all sections relating to .swp binary and patch with that.","author_login":"herbdool","author_association":"NONE","created_at":"2018-08-14T19:03:37+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417731863","fragment_type":"issue_comment","sequence":38,"text":"On yesterday's weekly Backdrop video meeting there was a discussion if to provide core updates via UI with the 1.11 release because the feature would be much easier to test when it's in the release. In my opinion it would help a lot to have easier testing conditions. On the other hand I see a certain risk of critical issues with the core updates via UI, just because we haven't tested the feature very deeply, nor in many different hosting situations.\n\nWhat about to hide the Core UI update feature somehow, or/and to give a statement in the help text that it's still in an experimental status?","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-08-31T17:12:34+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417753843","fragment_type":"issue_comment","sequence":39,"text":"Should this functionality to be mandatory, or can be disabled/skipped somehow?","author_login":"findlabnet","author_association":"NONE","created_at":"2018-08-31T18:34:26+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417780944","fragment_type":"issue_comment","sequence":40,"text":"@findlabnet The core update via Backdrop's UI isn't mandatory. You'll still be able to update Backdrop core in the usual way, replacing the old \"core\" directory with a newer one, as currently described here: URL \n\nThat said, when we're getting closer to provide also *automatic* core updates, I expect a discussion about the option how to disable / skip them - see for instance URL","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-08-31T20:29:47+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417819553","fragment_type":"issue_comment","sequence":41,"text":"@olafgrabienski:\n \n\n@findlabnet:\n \n\nYes, absolutely! I had this same thought today but you two beat me to suggesting it. Let's included this core update functionality in 1.11.0 but hide it. We can enable it by default in a later release.\n\nWe already have an `installer.settings.json` config file. We should add a new option for enabling core updates, e.g. `config_get('installer.settings', 'core_update')`.\n\nIn fact it would be great to have all of the various installation/updating options be able to be toggled (e.g. `\"module_update\", \"module_install\", \"theme_update\", \"theme_install\", \"layout_update\", \"layout_install\"`). But as we're in a time crunch, let's add the toggle for core only and expand that out later. Our primary concern here is just making it so that we can test this after release with a real example and the whole system together.\n\nSo we need the following:\n\n- Add `core_update: false` to `installer.settings.json`.\n- An update hook to set the default to `false` for existing sites.\n- A conditional check ensuring `config_get('installer.settings', 'core_update')` is TRUE before allowing any core updates.\n\nAt this point, I don't think any UI for toggling the option is needed.","author_login":"quicksketch","author_association":"MEMBER","created_at":"2018-09-01T00:31:14+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417861779","fragment_type":"issue_comment","sequence":42,"text":"How would I enable the feature for testing purposes: just change a configuration file?","author_login":"olafgrabienski","author_association":"NONE","created_at":"2018-09-01T14:02:18+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417884003","fragment_type":"issue_comment","sequence":43,"text":"@olafgrabienski yes, you'd have to edit the installer.settings.json file.","author_login":"herbdool","author_association":"NONE","created_at":"2018-09-01T20:06:13+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417888837","fragment_type":"issue_comment","sequence":44,"text":"@serundeputy as per @quicksketch suggestion, I've created a PR URL","author_login":"herbdool","author_association":"NONE","created_at":"2018-09-01T21:39:45+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_417895125","fragment_type":"issue_comment","sequence":45,"text":"I've tested out @herbdool's additions at URL and they look great! As we've already tested this prior to the disabling option, I think we're good to go here.\n\nI've merged in URL Thanks everyone, especially @serundeputy for his direct and simple approach to this problem. This is an exciting development and I'm so glad we came up with a way to proceed on this. Woot!","author_login":"quicksketch","author_association":"MEMBER","created_at":"2018-09-01T23:50:10+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_418158922","fragment_type":"issue_comment","sequence":46,"text":"Wow! went to work on this today and it's merged! Amazing job everyone!","author_login":"serundeputy","author_association":"MEMBER","created_at":"2018-09-03T16:40:19+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_450745707","fragment_type":"issue_comment","sequence":47,"text":"As a followup to this, can we move all update links to one place please? Like a top-level `Updates` link on the Admin bar, which links to a page with Layout, Module, Theme, and Core tabs or fieldsets. The current UI is confusing. Core updates is appearing under the Update Themes page, etc.","author_login":"docwilmot","author_association":"CONTRIBUTOR","created_at":"2019-01-01T17:41:06+08:00","repo_name":"backdrop/backdrop-issues","issue_id":322612121,"issue_number":3105,"issue_url":"https://github.com/backdrop/backdrop-issues/issues/3105","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0233","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Daemon does not start without apparmor?","query_context":"### Description\n\nRunning on Debian 11 Bullseye, and using \n`deb URL bullseye stable`\nin sources.list.d.\n\nAfter upgrade from version 20.10.22 to 23. results in this error\n\nError response from daemon: AppArmor enabled on system but the docker-default profile could not be loaded: running `apparmor_parser apparmor_parser --version` failed with output: \nerror: exec: \"apparmor_parser\": executable file not found in $PATH\nError: failed to start containers: somecontainer\n\nThis seems to be connected with this ticket and this. There is a workaround below.\n\n### Reproduce\n\n1. apt update\n2. apt upgrade\n\nto install docker version 23. \n\n### Expected behavior\n\nUpgrade should run smoothly.\n\n### docker version\n\nbash\nClient: Docker Engine - Community\n Version: 23.0.0\n API version: 1.42\n Go version: go1.19.5\n Git commit: e92dd87\n Built: Wed Feb 1 17:43:17 2023\n OS/Arch: linux/amd64\n Context: default\n\nServer: Docker Engine - Community\n Engine:\n Version: 23.0.0\n API version: 1.42 (minimum version 1.12)\n Go version: go1.19.5\n Git commit: d7573ab\n Built: Wed Feb 1 17:43:17 2023\n OS/Arch: linux/amd64\n Experimental: false\n containerd:\n Version: 1.6.16\n GitCommit: 31aa4358a36870b21a992d3ad2bef29e1d693bec\n runc:\n Version: 1.1.4\n GitCommit: v1.1.4-0-g5fd4c4d\n docker-init:\n Version: 0.19.0\n GitCommit: de40ad0\n\n### docker info\n\nbash\nClient:\n Context: default\n Debug Mode: false\n\nServer:\n Containers: 5\n Running: 5\n Paused: 0\n Stopped: 0\n Images: 30\n Server Version: 23.0.0\n Storage Driver: overlay2\n Backing Filesystem: extfs\n Supports d_type: true\n Using metacopy: false\n Native Overlay Diff: true\n userxattr: false\n Logging Driver: json-file\n Cgroup Driver: systemd\n Cgroup Version: 2\n Plugins:\n Volume: local\n Network: bridge host ipvlan macvlan null overlay\n Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog\n Swarm: inactive\n Runtimes: io.containerd.runc.v2 runc\n Default Runtime: runc\n Init Binary: docker-init\n containerd version: 31aa4358a36870b21a992d3ad2bef29e1d693bec\n runc version: v1.1.4-0-g5fd4c4d\n init version: de40ad0\n Security Options:\n apparmor\n seccomp\n Profile: builtin\n cgroupns\n Kernel Version: 5.10.0-21-amd64\n Operating System: Debian GNU/Linux 11 (bullseye)\n OSType: linux\n Architecture: x86_64\n CPUs: 24\n Total Memory: 125.8GiB\n Name: server\n ID: ASHT:IIYG:NTE5:MWJH:XKZH:LCB2:RYWI:EZQM:QNT6:SNKW:AQWU:UYDW\n Docker Root Dir: /var/lib/docker\n Debug Mode: false\n Registry: URL \n Experimental: false\n Insecure Registries:\n 127.0.0.0/8\n Live Restore Enabled: false\n\n### Additional Info\n\nWorkaround is to install apparmor package\n\n`apt install apparmor`","known_context_document_ids":["gh_issue_1568034818"],"reference_answer":"Thanks everyone! I'm going to go ahead and lock this issue to prevent unnecessary notifications -- the issue is definitively solved, as confirmed by developer testing, formal QA, and end user reports.\n\nFor future users: please note that this behavior will **likely change in the future**. While it will likely always be possible to run Moby without AppArmor installed on an AppArmor-enabled kernel (e.g. to support a mixed userland/kernel situation), there is a strong likelihood that we will require an explicit opt-out in the future, as such configurations are the exception and not the rule.","answer_document_id":"gh_comment_1493418623","silver_evidence_path":["gh_comment_1427736646","gh_issue_1579280313","gh_comment_1493418623"],"evidence_issue_ids":[1568034818,1579280313],"source_repo_name":"moby/moby","source_issue_id":1568034818,"source_issue_number":44900,"source_issue_url":"https://github.com/moby/moby/issues/44900","target_repo_name":"moby/moby","target_issue_id":1579280313,"target_issue_number":44970,"target_issue_url":"https://github.com/moby/moby/issues/44970","reference_anchor_document_id":"gh_comment_1427736646","reference_answer_author":"neersighted","reference_answer_author_association":"MEMBER","quality_score":95.26,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1392,"anchor_target_overlap":0.2152,"target_answer_overlap":0.0851},"issue_created_at":"2023-02-02T13:10:49+08:00","valid_comment_count":37,"fragments":[{"document_id":"gh_issue_1568034818","fragment_type":"issue_description","sequence":0,"text":"Daemon does not start without apparmor\n### Description\n\nRunning on Debian 11 Bullseye, and using \n`deb URL bullseye stable`\nin sources.list.d.\n\nAfter upgrade from version 20.10.22 to 23. results in this error\n\nError response from daemon: AppArmor enabled on system but the docker-default profile could not be loaded: running `apparmor_parser apparmor_parser --version` failed with output: \nerror: exec: \"apparmor_parser\": executable file not found in $PATH\nError: failed to start containers: somecontainer\n\nThis seems to be connected with this ticket and this. There is a workaround below.\n\n### Reproduce\n\n1. apt update\n2. apt upgrade\n\nto install docker version 23. \n\n### Expected behavior\n\nUpgrade should run smoothly.\n\n### docker version\n\nbash\nClient: Docker Engine - Community\n Version: 23.0.0\n API version: 1.42\n Go version: go1.19.5\n Git commit: e92dd87\n Built: Wed Feb 1 17:43:17 2023\n OS/Arch: linux/amd64\n Context: default\n\nServer: Docker Engine - Community\n Engine:\n Version: 23.0.0\n API version: 1.42 (minimum version 1.12)\n Go version: go1.19.5\n Git commit: d7573ab\n Built: Wed Feb 1 17:43:17 2023\n OS/Arch: linux/amd64\n Experimental: false\n containerd:\n Version: 1.6.16\n GitCommit: 31aa4358a36870b21a992d3ad2bef29e1d693bec\n runc:\n Version: 1.1.4\n GitCommit: v1.1.4-0-g5fd4c4d\n docker-init:\n Version: 0.19.0\n GitCommit: de40ad0\n\n### docker info\n\nbash\nClient:\n Context: default\n Debug Mode: false\n\nServer:\n Containers: 5\n Running: 5\n Paused: 0\n Stopped: 0\n Images: 30\n Server Version: 23.0.0\n Storage Driver: overlay2\n Backing Filesystem: extfs\n Supports d_type: true\n Using metacopy: false\n Native Overlay Diff: true\n userxattr: false\n Logging Driver: json-file\n Cgroup Driver: systemd\n Cgroup Version: 2\n Plugins:\n Volume: local\n Network: bridge host ipvlan macvlan null overlay\n Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog\n Swarm: inactive\n Runtimes: io.containerd.runc.v2 runc\n Default Runtime: runc\n Init Binary: docker-init\n containerd version: 31aa4358a36870b21a992d3ad2bef29e1d693bec\n runc version: v1.1.4-0-g5fd4c4d\n init version: de40ad0\n Security Options:\n apparmor\n seccomp\n Profile: builtin\n cgroupns\n Kernel Version: 5.10.0-21-amd64\n Operating System: Debian GNU/Linux 11 (bullseye)\n OSType: linux\n Architecture: x86_64\n CPUs: 24\n Total Memory: 125.8GiB\n Name: server\n ID: ASHT:IIYG:NTE5:MWJH:XKZH:LCB2:RYWI:EZQM:QNT6:SNKW:AQWU:UYDW\n Docker Root Dir: /var/lib/docker\n Debug Mode: false\n Registry: URL \n Experimental: false\n Insecure Registries:\n 127.0.0.0/8\n Live Restore Enabled: false\n\n### Additional Info\n\nWorkaround is to install apparmor package\n\n`apt install apparmor`","author_login":"FriendlyTroll","author_association":"NONE","created_at":"2023-02-02T13:10:49+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1415430415","fragment_type":"issue_comment","sequence":1,"text":"^^ per a discussion on our slack, the package should be `apparmor`, not `apparmor-utils` (updated my comment above)","author_login":"thaJeztah","author_association":"MEMBER","created_at":"2023-02-03T09:13:49+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1415431115","fragment_type":"issue_comment","sequence":2,"text":"I opened URL to fix the `get.docker.com` installation script as well","author_login":"thaJeztah","author_association":"MEMBER","created_at":"2023-02-03T09:14:08+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1415584966","fragment_type":"issue_comment","sequence":3,"text":"There are cases where it's not that simple.\neg\n\n- using a Debian based host\n- running a lxc container inside which is used as a gitlab-runner executor: here you can workaround by installing apparmor userland\n- But then , if in your CI, you use DIND workflows, you wont be able to spawn the dind container as it will check on the same error.\n\nrel #44902","author_login":"kiorky","author_association":"CONTRIBUTOR","created_at":"2023-02-03T10:10:27+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1415615382","fragment_type":"issue_comment","sequence":4,"text":"Can confirm that. Today docker-ce 23.0.0 got pushed to centos repos.\nWe run dockerd in a centos lxd container on an ubuntu lxd host.\nThere is no way to install apparmor/-utils in this scenario.","author_login":"visit1985","author_association":"NONE","created_at":"2023-02-03T10:18:54+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1415750296","fragment_type":"issue_comment","sequence":5,"text":"I would like to emphasis that this bug is a bit critical as docker can be upgraded during an unattended upgrade and then break the workload running on the related host.","author_login":"kiorky","author_association":"CONTRIBUTOR","created_at":"2023-02-03T11:38:05+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420032331","fragment_type":"issue_comment","sequence":6,"text":"FYI, this was discussed in today's maintainer call and a revert to the apparmor startup logic is being fast-tracked for a 23.0.1 release: URL","author_login":"tianon","author_association":"MEMBER","created_at":"2023-02-07T01:20:48+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427533778","fragment_type":"issue_comment","sequence":7,"text":"FWIW, with 23.0.1:\n\n$ apt list docker-ce docker-ce-cli\nListing... Done\ndocker-ce-cli/jammy,now 5:23.0.1-1~ubuntu.22.04~jammy amd64 [installed]\ndocker-ce/jammy,now 5:23.0.1-1~ubuntu.22.04~jammy amd64 [installed]\n$ docker run -ti --rm 0ab66881fb24 bash\ndocker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: unable to apply apparmor profile: apparmor failed to apply profile: write /proc/self/attr/apparmor/exec: no such file or directory: unknown.\n$","author_login":"reddwarf69","author_association":"NONE","created_at":"2023-02-13T08:27:09+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427640284","fragment_type":"issue_comment","sequence":8,"text":"Getting the very same error.\n\nHere my info:\n\nOS: Arch Linux ARM (Rolling Release)\nDocker: v23.0.1, build a5ee5b1dfc\nDocker compose: v2.16.0\nContainerd: v1.6.16 31aa4358a36870b21a992d3ad2bef29e1d693bec.m\nCtr: v1.6.16","author_login":"MartinHotmann","author_association":"NONE","created_at":"2023-02-13T09:51:08+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427736646","fragment_type":"issue_comment","sequence":9,"text":"I'll lock the conversation on this thread in favor of URL which is still open, and to prevent the conversation from diverging.\n\nA short summary;\n\n- `apparmor_parser` is needed for `dockerd` to provide AppArmor protection on a kernel that has apparmor enabled.\n- `apparmor` (which provides `apparmor_parser`) is a _`Recommends:`_ dependency for `dockerd` (which is a _strong_ recommendation, and means that while `dockerd` is _able_ to run without, doing so may require manual intervention).\n- Depending on your installation method and the package manager used, `apparmor` may not get automatically installed when upgrading; if that's the case, then make sure to (manually) install the `apparmor` dependency, and restart the docker daemon afterwards for it to detect that `apparmor_parser` is installed.\n- This issue was caused by a regression in the containerd code we use; we made changes in this repository to work around this regression, and to improve handling of this situation, but additional changes are still needed in containerd; those changes have been merged, but have not yet been released.\n- Subscribe to URL to get posted on updates (but please refrain from \"me too\" / \"+1\" comments if you don't have important details to add).","author_login":"thaJeztah","author_association":"MEMBER","created_at":"2023-02-13T10:58:30+08:00","repo_name":"moby/moby","issue_id":1568034818,"issue_number":44900,"issue_url":"https://github.com/moby/moby/issues/44900","linked_issue_ids":[1579280313],"is_known_query_context":false},{"document_id":"gh_issue_1579280313","fragment_type":"issue_description","sequence":0,"text":"Incorrect detection of lack of Apparmor installed\n### Description\n\nPackage `23.0.1-1~debian.11~bullseye` on fresh install gives:\n\n AppArmor enabled on system but the docker-default profile could not be loaded:\n\nthe app armor is not installed nor enabled\n\nThe bug happened after we installed 23 on new node, previous ones on 20 didn't had the problem\n\n### Reproduce\n\nInstall docker on fresh debian install\n\n### Expected behavior\n\n_No response_\n\n### docker version\n\nbash\nClient: Docker Engine - Community\n Version: 23.0.0\n API version: 1.42\n Go version: go1.19.5\n Git commit: e92dd87\n Built: Wed Feb 1 17:43:17 2023\n OS/Arch: linux/amd64\n Context: default\n\nServer: Docker Engine - Community\n Engine:\n Version: 23.0.1\n API version: 1.42 (minimum version 1.12)\n Go version: go1.19.5\n Git commit: bc3805a\n Built: Thu Feb 9 19:46:54 2023\n OS/Arch: linux/amd64\n Experimental: false\n containerd:\n Version: 1.6.16\n GitCommit: 31aa4358a36870b21a992d3ad2bef29e1d693bec\n runc:\n Version: 1.1.4\n GitCommit: v1.1.4-0-g5fd4c4d\n docker-init:\n Version: 0.19.0\n GitCommit: de40ad0\n\n### docker info\n\nbash\nClient:\n Context: default\n Debug Mode: false\n\nServer:\n Containers: 53\n Running: 4\n Paused: 0\n Stopped: 49\n Images: 7\n Server Version: 23.0.1\n Storage Driver: overlay2\n Backing Filesystem: xfs\n Supports d_type: true\n Using metacopy: false\n Native Overlay Diff: true\n userxattr: false\n Logging Driver: json-file\n Cgroup Driver: systemd\n Cgroup Version: 2\n Plugins:\n Volume: local\n Network: bridge host ipvlan macvlan null overlay\n Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog\n Swarm: inactive\n Runtimes: io.containerd.runc.v2 runc\n Default Runtime: runc\n Init Binary: docker-init\n containerd version: 31aa4358a36870b21a992d3ad2bef29e1d693bec\n runc version: v1.1.4-0-g5fd4c4d\n init version: de40ad0\n Security Options:\n apparmor\n seccomp\n Profile: builtin\n cgroupns\n Kernel Version: 5.10.0-21-amd64\n Operating System: Debian GNU/Linux 11 (bullseye)\n OSType: linux\n Architecture: x86_64\n CPUs: 16\n Total Memory: 29.39GiB\n Name: d1-fw-kube20\n ID: 91ef61ab-0b63-4f4b-9f6c-6cfb41903247\n Docker Root Dir: /var/lib/docker\n Debug Mode: false\n Registry: URL \n Experimental: false\n Insecure Registries:\n 127.0.0.0/8\n Live Restore Enabled: false\n\n### Additional Info\n\n_No response_","author_login":"XANi","author_association":"NONE","created_at":"2023-02-10T08:55:35+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1425584190","fragment_type":"issue_comment","sequence":1,"text":"After being upgraded on an Armbian system to 23.0.1 a couple of hours ago, docker-ce could no longer start containers. The error message was:\n\nError response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container\n process: error during container init: unable to apply apparmor profile: apparmor failed to apply profile: write /proc/self/attr\n/apparmor/exec: no such file or directory: unknown\n\nInstalling the apparmor package didn't help. I had to downgrade it to 20.10.23.","author_login":"wenzhuoz","author_association":"NONE","created_at":"2023-02-10T10:30:08+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1425846578","fragment_type":"issue_comment","sequence":2,"text":"If you're running into this issue, what do the following commands show on your system?\n\nbash\nls /sys/kernel/security/apparmor\n\nbash\ncat /sys/module/apparmor/parameters/enabled\n\nbash\napparmor_parser --version","author_login":"thaJeztah","author_association":"MEMBER","created_at":"2023-02-10T13:57:25+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1425872606","fragment_type":"issue_comment","sequence":3,"text":"I have the same problem as @wenzhuoz on my Debian system without AppArmor installed, resulting in:\n\nError response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: unable to apply apparmor profile: apparmor failed to apply profile: write /proc/self/attr/apparmor/exec: no such file or directory: unknown\n\n Here's my output:\n\n$ ls -l /sys/kernel/security/apparmor\ntotal 0\ndrwxr-xr-x 15 root root 0 Feb 1 20:17 features\nlr--r--r-- 1 root root 0 Feb 1 20:17 policy -> 'apparmorfs:[2154]'\n-r--r--r-- 1 root root 0 Feb 1 20:17 profiles\n-r--r--r-- 1 root root 0 Feb 1 20:17 revision\n\n$ cat /sys/module/apparmor/parameters/enabled\nY\n\n$ apparmor_parser --version\n-bash: apparmor_parser: command not found","author_login":"pavelvodrazka","author_association":"NONE","created_at":"2023-02-10T14:17:11+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426010102","fragment_type":"issue_comment","sequence":4,"text":"we're seeing the same on all our hosts that've upgraded to `v23.0.x`, they all break on apparmor even though we definitely don't have the apparmor daemon installed or running. also, installing apparmor doesn't resolve the issue, it seems like the apparmor code in docker is broken with this release. we're on a mix of Ubuntu 20.04 and 22.04, all running from the official docker apt repo.\n\nroot@host-0:~# ls /sys/kernel/security/apparmor\nfeatures policy profiles revision\nroot@host-0:~# cat /sys/module/apparmor/parameters/enabled\nY\nroot@host-0:~# dpkg -l | rg apparmor\npi libapparmor1:amd64 2.13.6-10 amd64 changehat AppArmor library\nroot@linksharing-0:~# cd /opt/service/\nroot@linksharing-0:/opt/service# docker compose restart\n[+] Running 0/0\n ⠋ Container service-service-1 Restarting 0.1s\nError response from daemon: Cannot restart container 00584aa5c7f75ada259a10d0ff951cce6eeaef921497b798aa30e2f57b68c34b: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: unable to apply apparmor profile: apparmor failed to apply profile: write /proc/self/attr/apparmor/exec: no such file or directory: unknown\n\nwe're going to roll back our packages for the time being, but this feels like a critical bug, at least to us.","author_login":"nergdron","author_association":"NONE","created_at":"2023-02-10T15:55:47+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426048304","fragment_type":"issue_comment","sequence":5,"text":"It's possible this is a duplicate of URL and not a new/worse regression -- right now I am thinking that the attempted fix was incomplete and didn't actually fix the original regression in 23.0.0.\n\nIf you could test that this also occurred on 23.0.0, that would be very helpful. It would also be helpful to make sure to provide `docker info`, `docker version` and the additional information @thaJeztah mentioned if you are affected. Thanks!","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-10T16:26:23+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426064634","fragment_type":"issue_comment","sequence":6,"text":"@neersighted I can confirm that I had the problem described in #44900 when I upgraded to 23.0.0 few days ago. I had to rollback to 20.10.23. I was keen to try upgrade to 23.0.1 again when I saw its changelog, but unfortunatelly the fix is not complete.","author_login":"pavelvodrazka","author_association":"NONE","created_at":"2023-02-10T16:39:58+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426065770","fragment_type":"issue_comment","sequence":7,"text":"Is the issue you see the same across 23.0.0, or is there any change in the error message? I think I am spotting an incomplete fix, but as I am unable to reproduce any of the actual errors here, I am trying to extrapolate from incomplete reports & a code walk.","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-10T16:40:50+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426069882","fragment_type":"issue_comment","sequence":8,"text":"Okay, that is quite helpful. Was this a crash, or just a failure to start a container?","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-10T16:44:42+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426085125","fragment_type":"issue_comment","sequence":9,"text":"oh, yeah, when I checked before I didn't restart docker after installing apparmor. if I do the following, then my containers keep working:\n\napt install -y apparmor && systemctl restart docker && cd /opt/service && docker compose restart\n\nwould definitely love confirmation from @pavelvodrazka, but I think you've found it, @neersighted!","author_login":"nergdron","author_association":"NONE","created_at":"2023-02-10T16:58:06+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426195907","fragment_type":"issue_comment","sequence":10,"text":"Okay, the root cause is understood, and the mitigation is the same: if you're not in some nested containerization scenario, install `apparmor`. It is a `Reccomends:` dependency of the daemon; that means that is technically possible to live without it, but it:\n* is not the happy path\n* may require manual intervention\n* will reduce the security profile of your contianers\n\nThe only question is whether we wait for containerd to accept a revert of the problematic change, or if we spread our in-tree check further. Given that there is a workaround (to not go out of your way to avoid apparmor), and we have not regressed further 23.0.0 (but rather failed to fix a regression), I am inclined to wait for containerd to accept/decline the fix, and to not hurry this.","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-10T18:40:50+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426224500","fragment_type":"issue_comment","sequence":11,"text":"@nergdron I can confirm that installing `apparmor` package and restarting docker service fixed the problem on my system.","author_login":"pavelvodrazka","author_association":"NONE","created_at":"2023-02-10T19:08:45+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426249096","fragment_type":"issue_comment","sequence":12,"text":"Unfortunately AppArmor broke some of my containers, so I have to go back to 20.10.23 until I figure out how to fix it with a less restrictive profile.","author_login":"pavelvodrazka","author_association":"NONE","created_at":"2023-02-10T19:34:11+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426256241","fragment_type":"issue_comment","sequence":13,"text":"You can set `--security-opt apparmor=unconfined` on the affected containers instead of taking a shotgun approach.","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-10T19:42:00+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426432529","fragment_type":"issue_comment","sequence":14,"text":"I can confirm too that installing apparmor prior to upgrading to 23.01 work around the issue.","author_login":"wenzhuoz","author_association":"NONE","created_at":"2023-02-10T22:39:20+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427426513","fragment_type":"issue_comment","sequence":15,"text":"I have the same problem\n\ndocker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: unable to apply apparmor profile: apparmor failed to apply profile: write /proc/self/attr/apparmor/exec: no such file or directory: unknown.\nERRO[0002] error waiting for container:\n\ndocker 23.0.1\nArmbian 22.08.1 Jammy","author_login":"zmyjs","author_association":"NONE","created_at":"2023-02-13T06:39:53+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1427428554","fragment_type":"issue_comment","sequence":16,"text":"Please refrain from \"me too,\" which is unhelpful (sends needless notifications) and unnecessary (there is a :+1: button, and there is a mitigation).\n\nYou can `apt install apparmor` as already discussed in this thread (and then restart `docker`, e.g. `systemctl restart docker.service`), or simply set `apparmor=0` on the kernel command line.","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-13T06:42:57+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1428691093","fragment_type":"issue_comment","sequence":17,"text":"This also happens without Docker installed but with containerd.io from the Docker repo.\nSame fix, just install apparmor and restart containerd...","author_login":"spdfnet","author_association":"NONE","created_at":"2023-02-13T21:12:56+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1428695796","fragment_type":"issue_comment","sequence":18,"text":"Yes, containerd also regressed (or rather, Moby was where people noticed, and containerd was also the root cause). The PRs in containerd point that out and will resolve the regression.","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-02-13T21:16:08+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445343113","fragment_type":"issue_comment","sequence":19,"text":"@neersighted and if you are, any thoughts on how to work around this?","author_login":"frankyw","author_association":"NONE","created_at":"2023-02-26T12:01:28+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1475926048","fragment_type":"issue_comment","sequence":20,"text":"From what I can see...\n\nWhen the kernel is built with `apparmor` (`/sys/kernel/security/apparmor`), and `apparmor`'s enabled (`/sys/module/apparmor/parameters/enabled`), and the `docker`'s profile (`docker-default`) is not loaded, and `apparmor_parser` is not available (not installed), and `containerd >= 1.6.0` (`< 1.7.0`), `docker-23.x` fails to start containers, because it needs `apparmor_parser` to load its profile, e.g.:\n\n$ docker run --rm -it alpine:3.17\ndocker: Error response from daemon: failed to create shim task: OCI \\\nruntime create failed: runc create failed: unable to start container \\\nprocess: error during container init: unable to apply apparmor profile: \\\napparmor failed to apply profile: write /proc/self/attr/apparmor/exec: \\\nno such file or directory: unknown.\n\nThis is caused by `containerd` having stopped checking if `apparmor_parser` is available (which `docker` needs to load its `apparmor` profile, if not already loaded).\n\n`docker` relies on `containerd` to check if `apparmor` is available [sinse `23.0.0`][a].\n\nBefore `containerd-1.6.0` that involved checking `/sys/kernel/security/apparmor`, `/sbin/apparmor_parser` and `/sys/module/apparmor/parameters/enabled`. But in `1.6.0` the `/sbin/apparmor_parser` check was [dropped][b]. The change was [reverted][c] in `1.7.0`.\n\n`docker` added a [temporary fix][d], but it doesn't seem to [ever be released][e], since `containerd` reverted the change.\n\nThe workarounds:\n\n* `apt install apparmor` (and restart the `docker` daemon)\n* downgrade `containerd` to `< 1.6.0`\n* downgrade `docker` to `< 22`\n* `docker run --rm -it --security-opt apparmor=unconfined alpine:3.17`\n\n[a]: URL \n[b]: URL \n[c]: URL \n[d]: URL \n[e]: URL","author_login":"x-yuri","author_association":"NONE","created_at":"2023-03-20T09:56:28+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1476543013","fragment_type":"issue_comment","sequence":21,"text":"I believe the \"final\" fix is pending in release 23.0.2 which appears to be complete.","author_login":"Codelica","author_association":"NONE","created_at":"2023-03-20T16:19:20+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479518921","fragment_type":"issue_comment","sequence":22,"text":"Again from what I can see the final fix basically comes down to [switching to `containerd-1.6.18`][b], which [reverted][a] the behavior. The interesting thing is that with `docker-23.0.1` and `containerd-1.6.18` and no `apparmor` package installed it still says, \"unable to apply apparmor profile.\" I'm running Debian 11 and installed docker from URL \n\n[a]: URL \n[b]: URL","author_login":"x-yuri","author_association":"NONE","created_at":"2023-03-22T12:52:57+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479556777","fragment_type":"issue_comment","sequence":23,"text":"This is bit confusing. So did containerd accept the change made by docker? Or did contained fix it - by not trying to load AppArmor on a non-Debian based machine?\n\n@x-yuri I think you need to have AppArmor installed if your distribution supports it, security wise it's a bad idea not to have AppArmor installed.","author_login":"capriciousduck","author_association":"NONE","created_at":"2023-03-22T13:19:53+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481439998","fragment_type":"issue_comment","sequence":24,"text":"To be clear as to what happened here:\n\n* containerd made a bad change that incorrectly removed the check for apparmor_parser in the **library interface**\n* Moby picked this up during a revendor\n* Moby attempted to work around it in 23.0.1, but the fix was incomplete\n* Moby maintainers determined that the change in contianerd represented a bug/regression and got a revert accepted\n* containerd made a release with the fix, which solves the issue for `cri-containerd` and Kubernetes\n* Moby re-vendored the containerd **library code**\n* This re-vendor will be released in Moby 23.0.2, which solves the issue for Moby/Docker CE/Mirantis Container Runtime","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-03-23T15:51:21+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482154145","fragment_type":"issue_comment","sequence":25,"text":"In other words, the error occurs inside the `dockerd`'s binary (`23.0.1`) which has the `HostSupports()` function from `containerd` `v1.6.16`? And `docker version` says `1.6.18` because it reports the `containerd`'s binary version, not the version from which `HostSupports` was taken into the `dockerd`'s binary? And `dockerd` fails because it has `HostSupports()` from `1.6.16`?\n \n\nOh, I probably see, [this commit][a] seems to have made it into `23.0.1` (not according to GitHub though). At first glance it seems like it should fix the issue though.\n\n[a]: URL","author_login":"x-yuri","author_association":"NONE","created_at":"2023-03-24T02:11:31+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487005065","fragment_type":"issue_comment","sequence":26,"text":"23.0.2 is out now, and the problem is gone for me. Thanks a lot to everyone involved in fixing it!","author_login":"ffdybuster","author_association":"NONE","created_at":"2023-03-28T14:30:00+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1493415326","fragment_type":"issue_comment","sequence":27,"text":"Version 23.0.2 fixed the problem on my machine as well. I'm again able to run docker containers without having apparmor installed. Thanks a lot!","author_login":"pavelvodrazka","author_association":"NONE","created_at":"2023-04-02T18:58:34+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1493418623","fragment_type":"issue_comment","sequence":28,"text":"Thanks everyone! I'm going to go ahead and lock this issue to prevent unnecessary notifications -- the issue is definitively solved, as confirmed by developer testing, formal QA, and end user reports.\n\nFor future users: please note that this behavior will **likely change in the future**. While it will likely always be possible to run Moby without AppArmor installed on an AppArmor-enabled kernel (e.g. to support a mixed userland/kernel situation), there is a strong likelihood that we will require an explicit opt-out in the future, as such configurations are the exception and not the rule.","author_login":"neersighted","author_association":"MEMBER","created_at":"2023-04-02T19:14:56+08:00","repo_name":"moby/moby","issue_id":1579280313,"issue_number":44970,"issue_url":"https://github.com/moby/moby/issues/44970","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0234","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Out-of-date: lib32-gst-plugins-ugly?","query_context":"### 问题类型 / Type of issues\n\n* 过期软件包 / out-of-date packages\n\n### 受影响的软件包 / Affected packages\n\n* lib32-gst-plugins-ugly\n\n----","known_context_document_ids":["gh_issue_1597064483"],"reference_answer":"- lib32-gst-plugins-bad: deb lib32-ffmpeg build fails. AUR comment. AUR maintainer can't reproduce.\n- lib32-gst-plugins-ugly: mpeg2dec test fails. Nothing found in AUR comments.\n\nBoth of them need time to investigate.","answer_document_id":"gh_comment_1066169982","silver_evidence_path":["gh_comment_1442036876","gh_issue_1160406411","gh_comment_1066169982"],"evidence_issue_ids":[1597064483,1160406411],"source_repo_name":"archlinuxcn/repo","source_issue_id":1597064483,"source_issue_number":3186,"source_issue_url":"https://github.com/archlinuxcn/repo/issues/3186","target_repo_name":"archlinuxcn/repo","target_issue_id":1160406411,"target_issue_number":2687,"target_issue_url":"https://github.com/archlinuxcn/repo/issues/2687","reference_anchor_document_id":"gh_comment_1442036876","reference_answer_author":"DDoSolitary","reference_answer_author_association":"MEMBER","quality_score":79.89,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.0556,"target_answer_overlap":0.1429},"issue_created_at":"2023-02-23T15:26:18+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1597064483","fragment_type":"issue_description","sequence":0,"text":"Out-of-date: lib32-gst-plugins-ugly\n### 问题类型 / Type of issues\n\n* 过期软件包 / out-of-date packages\n\n### 受影响的软件包 / Affected packages\n\n* lib32-gst-plugins-ugly\n\n----","author_login":"LiYulin-s","author_association":"NONE","created_at":"2023-02-23T15:26:18+08:00","repo_name":"archlinuxcn/repo","issue_id":1597064483,"issue_number":3186,"issue_url":"https://github.com/archlinuxcn/repo/issues/3186","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1441976769","fragment_type":"issue_comment","sequence":1,"text":"| pkgbase | build history | last build log |\n| --- | --- | --- |\n| lib32-gst-plugins-ugly | build history | last build log |","author_login":"lilacbot","author_association":"CONTRIBUTOR","created_at":"2023-02-23T15:26:23+08:00","repo_name":"archlinuxcn/repo","issue_id":1597064483,"issue_number":3186,"issue_url":"https://github.com/archlinuxcn/repo/issues/3186","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1442036876","fragment_type":"issue_comment","sequence":2,"text":"Duplicate of URL \n\nAs a side note, there is an ongoing effort for cleaning up packages. If @DDoSolitary does not show up and pick their packages in a month, you can take over and fix them. See URL","author_login":"yan12125","author_association":"MEMBER","created_at":"2023-02-23T16:04:41+08:00","repo_name":"archlinuxcn/repo","issue_id":1597064483,"issue_number":3186,"issue_url":"https://github.com/archlinuxcn/repo/issues/3186","linked_issue_ids":[1160406411],"is_known_query_context":false},{"document_id":"gh_issue_1160406411","fragment_type":"issue_description","sequence":0,"text":"lib32-gst-plugins-bad-ugly outdated\n### 问题类型 / Type of issues\n\n* 过期软件包 / out-of-date packages\n\n### 受影响的软件包 / Affected packages\nlib32-gst-plugins-bad\nlib32-gst-plugins-ugly\n\n* （请在此填写包名，每行一个，开头加上星号 / package names, one per line）\nlib32-gst-plugins-bad\nlib32-gst-plugins-ugly\n----","author_login":"mobedoor","author_association":"NONE","created_at":"2022-03-05T17:34:27+08:00","repo_name":"archlinuxcn/repo","issue_id":1160406411,"issue_number":2687,"issue_url":"https://github.com/archlinuxcn/repo/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1059802307","fragment_type":"issue_comment","sequence":1,"text":"| pkgbase | build history | last build log |\n| --- | --- | --- |\n| 请在此填写包名 | build history | last build log |\n| lib32-gst-plugins-bad | build history | last build log |\n| lib32-gst-plugins-ugly | build history | last build log |","author_login":"lilacbot","author_association":"CONTRIBUTOR","created_at":"2022-03-05T17:34:29+08:00","repo_name":"archlinuxcn/repo","issue_id":1160406411,"issue_number":2687,"issue_url":"https://github.com/archlinuxcn/repo/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066169982","fragment_type":"issue_comment","sequence":2,"text":"- lib32-gst-plugins-bad: deb lib32-ffmpeg build fails. AUR comment. AUR maintainer can't reproduce.\n- lib32-gst-plugins-ugly: mpeg2dec test fails. Nothing found in AUR comments.\n\nBoth of them need time to investigate.","author_login":"DDoSolitary","author_association":"MEMBER","created_at":"2022-03-13T19:50:10+08:00","repo_name":"archlinuxcn/repo","issue_id":1160406411,"issue_number":2687,"issue_url":"https://github.com/archlinuxcn/repo/issues/2687","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826248126","fragment_type":"issue_comment","sequence":3,"text":"新版本已由 lib32-gst-bad-ugly 提供，该包提供下面四个包： \n\n lib32-gst-libav\n lib32-gst-plugins-ugly\n lib32-gst-plugins-bad-libs\n lib32-gst-plugins-bad","author_login":"ithomascn","author_association":"NONE","created_at":"2023-11-25T07:57:23+08:00","repo_name":"archlinuxcn/repo","issue_id":1160406411,"issue_number":2687,"issue_url":"https://github.com/archlinuxcn/repo/issues/2687","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0235","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Test: workbench.view.dimUnfocused.*?","query_context":"Refs: URL \n\n- [x] macOS @bhavyaus\n- [x] linux @bpasero\n- [x] windows @justschen\n\nComplexity: 2\n\nCreate Issue\n\n---\n\nThere are new settings `workbench.view.dimUnfocused.enabled` and `workbench.view.dimUnfocused.opacity`, read the settings and verify they work as expected.","known_context_document_ids":["gh_issue_1870550555"],"reference_answer":"It's 3/3 users that commented on it recently (see URL URL plus the requestor of the feature ( URL - \"Dim or otherwise indicate \"inactive\" editor/terminal\"). Additionally, almost all comments on the issue mention only terminals and editors.\n\nDimming all other views would make the feature less useful imo, the reason users want this is to dim less relevant editors and terminals (primary work areas), dimming other parts of the UI that show auxiliary information would harm the user experience as they often augment the active editor. I understand it seems somewhat arbitrary, but it's solving a targeted problem.\n\nWe can expand it later if needed `(accessibility|workbench.view).dimUnfocused.views: { terminal: true, ... }`, but right now that's solving a problem that no one is asking for and I wanted to solve the issue efficiently for those requesting it.","answer_document_id":"gh_comment_1697478907","silver_evidence_path":["gh_comment_1697457434","gh_issue_1871656075","gh_comment_1697478907"],"evidence_issue_ids":[1870550555,1871656075],"source_repo_name":"microsoft/vscode","source_issue_id":1870550555,"source_issue_number":191527,"source_issue_url":"https://github.com/microsoft/vscode/issues/191527","target_repo_name":"microsoft/vscode","target_issue_id":1871656075,"target_issue_number":191610,"target_issue_url":"https://github.com/microsoft/vscode/issues/191610","reference_anchor_document_id":"gh_comment_1697457434","reference_answer_author":"Tyriar","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.25,"target_answer_overlap":0.1765},"issue_created_at":"2023-08-28T21:43:03+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1870550555","fragment_type":"issue_description","sequence":0,"text":"Test: workbench.view.dimUnfocused.*\nRefs: URL \n\n- [x] macOS @bhavyaus\n- [x] linux @bpasero\n- [x] windows @justschen\n\nComplexity: 2\n\nCreate Issue\n\n---\n\nThere are new settings `workbench.view.dimUnfocused.enabled` and `workbench.view.dimUnfocused.opacity`, read the settings and verify they work as expected.","author_login":"Tyriar","author_association":"MEMBER","created_at":"2023-08-28T21:43:03+08:00","repo_name":"microsoft/vscode","issue_id":1870550555,"issue_number":191527,"issue_url":"https://github.com/microsoft/vscode/issues/191527","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1697448579","fragment_type":"issue_comment","sequence":1,"text":"Having tested this I am actually not happy about the way it works currently and feel we should spend more time on it to really fix the rough edges:\n* why does this only apply to text editors and terminals but for example not notebooks?\n* why does it apply to terminals in the panel but not other panels?\n* why does it not apply to the sidebar?\n\nI guess I am not really understanding what we want to solve here: if the idea is to make the focussed part stand out more from other parts, then I would argue we should consistently highlight the \"thing\" that has keyboard focus and dim everything else. The current solution seems half-baked.","author_login":"bpasero","author_association":"MEMBER","created_at":"2023-08-29T13:28:44+08:00","repo_name":"microsoft/vscode","issue_id":1870550555,"issue_number":191527,"issue_url":"https://github.com/microsoft/vscode/issues/191527","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1697457434","fragment_type":"issue_comment","sequence":2,"text":"I guess this is because I rarely use editors other than the text editor 😅. I don't expect editors other than the webviews to be hard to implement.\n \n \n\n@bpasero let's discuss this in URL","author_login":"Tyriar","author_association":"MEMBER","created_at":"2023-08-29T13:34:06+08:00","repo_name":"microsoft/vscode","issue_id":1870550555,"issue_number":191527,"issue_url":"https://github.com/microsoft/vscode/issues/191527","linked_issue_ids":[1871656075],"is_known_query_context":false},{"document_id":"gh_comment_1698157974","fragment_type":"issue_comment","sequence":3,"text":"Some of these may have been mentioned, but no unfocus on some other views in the workbench including gitlens, ports, comments, refactor preview. \n\nOther than that it looks solid in a bunch of the themes I tried it in as well.","author_login":"justschen","author_association":"CONTRIBUTOR","created_at":"2023-08-29T21:17:48+08:00","repo_name":"microsoft/vscode","issue_id":1870550555,"issue_number":191527,"issue_url":"https://github.com/microsoft/vscode/issues/191527","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1871656075","fragment_type":"issue_description","sequence":0,"text":"Why is sidebar not included\nTesting #191527\n\nConceptually panel and sidebar are very similar to me, so is there a reason dimming would not apply to the sidebar? For example, I may have decided to move output editor into the aux sidebar.","author_login":"bpasero","author_association":"MEMBER","created_at":"2023-08-29T13:16:40+08:00","repo_name":"microsoft/vscode","issue_id":1871656075,"issue_number":191610,"issue_url":"https://github.com/microsoft/vscode/issues/191610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1697461727","fragment_type":"issue_comment","sequence":1,"text":"That is the opinion of one user, do we have consensus that this is what we want to build? I personally would at least want other panels that accept keyboard focus to participate as well because these can show lots of output and even may look like an editor.","author_login":"bpasero","author_association":"MEMBER","created_at":"2023-08-29T13:36:18+08:00","repo_name":"microsoft/vscode","issue_id":1871656075,"issue_number":191610,"issue_url":"https://github.com/microsoft/vscode/issues/191610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1697478907","fragment_type":"issue_comment","sequence":2,"text":"It's 3/3 users that commented on it recently (see URL URL plus the requestor of the feature ( URL - \"Dim or otherwise indicate \"inactive\" editor/terminal\"). Additionally, almost all comments on the issue mention only terminals and editors.\n\nDimming all other views would make the feature less useful imo, the reason users want this is to dim less relevant editors and terminals (primary work areas), dimming other parts of the UI that show auxiliary information would harm the user experience as they often augment the active editor. I understand it seems somewhat arbitrary, but it's solving a targeted problem.\n\nWe can expand it later if needed `(accessibility|workbench.view).dimUnfocused.views: { terminal: true, ... }`, but right now that's solving a problem that no one is asking for and I wanted to solve the issue efficiently for those requesting it.","author_login":"Tyriar","author_association":"MEMBER","created_at":"2023-08-29T13:46:13+08:00","repo_name":"microsoft/vscode","issue_id":1871656075,"issue_number":191610,"issue_url":"https://github.com/microsoft/vscode/issues/191610","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0236","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Bug: Unable to calculate team data Viz or data file in Data UI?","query_context":"**Next team meeting _MTL_ Blue Session 3 is Mon, Sept 19 9am**\n\nData UI - data set\nOn 8/23 and 8/30, I attempted to generate the team data file for team that would be uploaded to the SIM UI.\nI received the same error message both times. Screenshot 1 (image 4 in title) is the first screen I see after trying to generate the file. When I click on details, screenshot 2 (image 3) is the details for the error. @jwklocek attempted to do the same on 8/30 with the same dataset and received the same error.\n\n >\n\nMicrosoftTeams-image (4)\n\nMicrosoftTeams-image (3)\n\n1. When was the bug discovered? On 8/23 - two attempts early a.m. and early afternoon and 8/30 about 12:30 pm\n\n3. Is this an invidivual or shared world? Not in SIM UI, in Data UI/Power BI\n\n5. What is the name of the experiment? Not an experiment.\n \n**2. Click on the right:** \ni. **Pipelines** - prioritize in a TeamPSD (& Workgroup) pipeline \nii. **Assignee** - @jamesmrollins \niii. **Label**- assign workgroup (lead) responsible for tracking the task. If this is a bug, add \"Bug\" label. \niv. **Projects** - assign to domain-specific TeamPSD tracker (issues, features, document, manuscript, team) \nv. **Milestones** - select monthly sprint milestone within the workgroup \nvi. **Estimate** - Estimate task in complexity points \nvii. **Epics** - assign to team-wide epic and TeamPSD master plan project \niix. **Releases** - assign to key team release grouped with other relevant issues \n\n**3. If you anticipate that your **issue card** or **bug card** will have **dependencies** these can be added once the issue has been submitted. \nix. **Add dependencies** - assess for and add dependencies *blocking* & *blocked by* this issue","known_context_document_ids":["gh_issue_1357226936"],"reference_answer":"Yeah, let's close this one. There is only one idea missing at this point, the propagation code, but I think that should be a separate issue: URL","answer_document_id":"gh_comment_526199897","silver_evidence_path":["gh_comment_1255665988","gh_issue_458717374","gh_comment_526199897"],"evidence_issue_ids":[1357226936,458717374],"source_repo_name":"lzim/teampsd","source_issue_id":1357226936,"source_issue_number":2723,"source_issue_url":"https://github.com/lzim/teampsd/issues/2723","target_repo_name":"lzim/teampsd","target_issue_id":458717374,"target_issue_number":430,"target_issue_url":"https://github.com/lzim/teampsd/issues/430","reference_anchor_document_id":"gh_comment_1255665988","reference_answer_author":"holbrooa","reference_answer_author_association":"COLLABORATOR","quality_score":78.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.0,"target_answer_overlap":0.1333},"issue_created_at":"2022-08-31T11:54:22+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1357226936","fragment_type":"issue_description","sequence":0,"text":"Bug: Unable to calculate team data Viz or data file in Data UI\n**Next team meeting _MTL_ Blue Session 3 is Mon, Sept 19 9am**\n\nData UI - data set\nOn 8/23 and 8/30, I attempted to generate the team data file for team that would be uploaded to the SIM UI.\nI received the same error message both times. Screenshot 1 (image 4 in title) is the first screen I see after trying to generate the file. When I click on details, screenshot 2 (image 3) is the details for the error. @jwklocek attempted to do the same on 8/30 with the same dataset and received the same error.\n\n >\n\nMicrosoftTeams-image (4)\n\nMicrosoftTeams-image (3)\n\n1. When was the bug discovered? On 8/23 - two attempts early a.m. and early afternoon and 8/30 about 12:30 pm\n\n3. Is this an invidivual or shared world? Not in SIM UI, in Data UI/Power BI\n\n5. What is the name of the experiment? Not an experiment.\n \n**2. Click on the right:** \ni. **Pipelines** - prioritize in a TeamPSD (& Workgroup) pipeline \nii. **Assignee** - @jamesmrollins \niii. **Label**- assign workgroup (lead) responsible for tracking the task. If this is a bug, add \"Bug\" label. \niv. **Projects** - assign to domain-specific TeamPSD tracker (issues, features, document, manuscript, team) \nv. **Milestones** - select monthly sprint milestone within the workgroup \nvi. **Estimate** - Estimate task in complexity points \nvii. **Epics** - assign to team-wide epic and TeamPSD master plan project \niix. **Releases** - assign to key team release grouped with other relevant issues \n\n**3. If you anticipate that your **issue card** or **bug card** will have **dependencies** these can be added once the issue has been submitted. \nix. **Add dependencies** - assess for and add dependencies *blocking* & *blocked by* this issue","author_login":"dlkibbe","author_association":"COLLABORATOR","created_at":"2022-08-31T11:54:22+08:00","repo_name":"lzim/teampsd","issue_id":1357226936,"issue_number":2723,"issue_url":"https://github.com/lzim/teampsd/issues/2723","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1244114661","fragment_type":"issue_comment","sequence":1,"text":"@jeffhoerle discussed at *9_12_22 8am workflow* with @lzim\n\n@jeffhoerle - @lzim is wondering if you can help us troubleshoot this bug. We could use 2pm workflow meeting to discuss or we can resolve asynchronously.\n\n@dlkibbe we moved this bug to the research bug tracker (issue num)","author_login":"KimCase123","author_association":"COLLABORATOR","created_at":"2022-09-12T18:10:59+08:00","repo_name":"lzim/teampsd","issue_id":1357226936,"issue_number":2723,"issue_url":"https://github.com/lzim/teampsd/issues/2723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255657199","fragment_type":"issue_comment","sequence":2,"text":"@emilymetcalf114 & @lzim \nDiscussed at **hq_workflow** 09/22/22\n\n#adjucate_memo\nDiscussed how much time this took for our **IIR Aim 3 Costing**\n\n@dlkibbe & @jwklocek \n_How much time do you think this bug took you two work on (thank you 🙏🏽 !)?_\n\nWe want to track your effort for @claradismuke 's work on costing.","author_login":"lzim","author_association":"OWNER","created_at":"2022-09-22T23:31:05+08:00","repo_name":"lzim/teampsd","issue_id":1357226936,"issue_number":2723,"issue_url":"https://github.com/lzim/teampsd/issues/2723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255660609","fragment_type":"issue_comment","sequence":3,"text":"My estimated time is 1.25 hours from first discovery to my email last night.","author_login":"dlkibbe","author_association":"COLLABORATOR","created_at":"2022-09-22T23:38:04+08:00","repo_name":"lzim/teampsd","issue_id":1357226936,"issue_number":2723,"issue_url":"https://github.com/lzim/teampsd/issues/2723","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255665988","fragment_type":"issue_comment","sequence":4,"text":"#adjudicate_memo\n@emilymetcalf114 and @lzim discussed at **hq_workflow 9/22**\nadjusted the effort to 9 story points divided between the facilitate team. support_workflow story points tracked on #430.","author_login":"emilymetcalf114","author_association":"COLLABORATOR","created_at":"2022-09-22T23:49:57+08:00","repo_name":"lzim/teampsd","issue_id":1357226936,"issue_number":2723,"issue_url":"https://github.com/lzim/teampsd/issues/2723","linked_issue_ids":[458717374],"is_known_query_context":false},{"document_id":"gh_issue_458717374","fragment_type":"issue_description","sequence":0,"text":"Data UI back end upgrade to match splash pages\n**Describe the opportunity**\nIntegration and translation of splash pages' data model conceptualization for count aggregation differentiation (e.g. the distinct summation computation), visualization standardization, and propagation automation.\n\n**FEATURE**\n\n**7. How would you like this feature to work?**\nImprove charts and tables to use the PowerPivot instead of regular pivots, allowing unique counts, among other things.\n\n**8. How urgent is this request? (Urgent/Not Urgent)**\nNot Urgent\n\n**9. Why is this feature important to you?**\nThe better pivots are better for a variety of reasons, including lining up with the splash charts.\n\n**10. Is your feature request related to a problem? Please describe.**\nNah.\n\n**11. Is there a deadline or other scheduled constraint driving your request?\"**\nNah, but this has to be done before the data ui gets propagated.\n\n**12. Additional context**\nThis shouldn't change the look and feel of the front end for users, except perhaps in very minor ways, but it is a big back-end change.\n\n**STOP HERE. INFORMATION BELOW IS TO BE FILLED OUT BY WORKGROUPS AS PART OF TRIAGE AND WORK BREAKDOWN PROCESS**\n\n**Estimated person hours to complete:**\n12\n\n**Key people (use @ assignment for people whose input will be necessary):**\n@holbrooa \n\n**Key dependencies:**\nAre there other tasks that need to be completed first?\nNo\n\n**Constraints:**\nIs there a resource constraint that may affect the development of the feature?\nNo\n\n**Gantt chart needed? Attach link and/or screenshot.**\nThis is already on Savet's big one","author_login":"holbrooa","author_association":"COLLABORATOR","created_at":"2019-06-20T15:13:11+08:00","repo_name":"lzim/teampsd","issue_id":458717374,"issue_number":430,"issue_url":"https://github.com/lzim/teampsd/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_520984953","fragment_type":"issue_comment","sequence":1,"text":"New features were presented and decisions were made on 8/12 at URL and those decisions have now been implemented. See the meeting notes for the changes and decisions.","author_login":"holbrooa","author_association":"COLLABORATOR","created_at":"2019-08-13T19:57:03+08:00","repo_name":"lzim/teampsd","issue_id":458717374,"issue_number":430,"issue_url":"https://github.com/lzim/teampsd/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_526001630","fragment_type":"issue_comment","sequence":2,"text":"@staceypark and @holbrooa Do we have this adequately documented in other issues?\nShould this issue be closed?","author_login":"lzim","author_association":"OWNER","created_at":"2019-08-29T03:04:09+08:00","repo_name":"lzim/teampsd","issue_id":458717374,"issue_number":430,"issue_url":"https://github.com/lzim/teampsd/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_526199897","fragment_type":"issue_comment","sequence":3,"text":"Yeah, let's close this one. There is only one idea missing at this point, the propagation code, but I think that should be a separate issue: URL","author_login":"holbrooa","author_association":"COLLABORATOR","created_at":"2019-08-29T14:03:17+08:00","repo_name":"lzim/teampsd","issue_id":458717374,"issue_number":430,"issue_url":"https://github.com/lzim/teampsd/issues/430","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0237","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"How long lived should a Client be?","query_context":"I'm not sure the best way to ask you a general question, so I'll pose it as an \"issue\"...\n\nHow long lived should a Client object be? Make one command and dispose of it? Or should it be possible to use one Client for an entire Bluetooth connection?","known_context_document_ids":["gh_issue_1193683404"],"reference_answer":"To create a client, you need another package which provides Bluetooth connectivity.\nI've used flutter_blue in the past, but that looks like it's unmaintained, flutter_reactive_ble might be a good alternative.\n\nYou need to discover the service (`8d53dc1d-1db7-4cd3-868b-8a527460aa84`) and characteristic (`da2e7828-fbce-4e01-ae9e-261174997c48`). Then, you subscribe to notifications from the characteristic and pass that stream to the Client constructor - the client will read responses from there. To send requests, it also needs a callback which writes a byte array to the characteristic. There's an example for that in the README.md.\n\nAlso remember to increase the MTU of the connection, the default is way too low and probably won't work.\n\nAfter that, using the echo command looks like this:\n\ndart\nfinal response = await client.echo(\"Hello World\", Duration(seconds: 5));\n\nThis will throw an exception if the command times out or the device returns an error.\n\nOnly few commands are implemented yet (for example, I just added echo in 0.0.2), so depending on what you want to do, you might have to use `client.execute` (and/or create an issue). But everything that's needed for firmware uploads is there.\n\nThere's no full example yet, I'll probably write one for firmware uploads using flutter_reactive_ble this weekend.","answer_document_id":"gh_comment_1069117391","silver_evidence_path":["gh_comment_1090904510","gh_issue_1169045907","gh_comment_1069117391"],"evidence_issue_ids":[1193683404,1169045907],"source_repo_name":"jkdhn/mcumgr-dart","source_issue_id":1193683404,"source_issue_number":3,"source_issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","target_repo_name":"jkdhn/mcumgr-dart","target_issue_id":1169045907,"target_issue_number":1,"target_issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/1","reference_anchor_document_id":"gh_comment_1090904510","reference_answer_author":"jkdhn","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.2158,"target_answer_overlap":0.1167},"issue_created_at":"2022-04-05T20:26:39+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1193683404","fragment_type":"issue_description","sequence":0,"text":"How long lived should a Client be?\nI'm not sure the best way to ask you a general question, so I'll pose it as an \"issue\"...\n\nHow long lived should a Client object be? Make one command and dispose of it? Or should it be possible to use one Client for an entire Bluetooth connection?","author_login":"BikeBr0","author_association":"NONE","created_at":"2022-04-05T20:26:39+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1089830081","fragment_type":"issue_comment","sequence":1,"text":"I'd recommend using one client for the whole connection.\n\nUsing multiple clients at the same time is dangerous (the message sequence number could collide) and making clients long-lived is the safest way to avoid that. There will also be problems if you create a client while a fragmented response is being received (it will start parsing the response stream in the middle of a response).","author_login":"jkdhn","author_association":"OWNER","created_at":"2022-04-06T05:17:08+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1090904510","fragment_type":"issue_comment","sequence":2,"text":"Thank you @jkdhn! That helps me to know I was on the right track. I ask because I am running into a problem with my own code when re-using the Client for multiple echo commands (implementing multiple echo commands within your example app works fine).\n\nBasically, I added an \"Echo\" button to your device screen that opens the following StatefulWidget in a bottom sheet:\n\nimport 'package:flutter/material.dart';\nimport 'package:mcumgr/mcumgr.dart';\nimport 'package:titan_app/bluetooth/titan_device.dart';\n\nclass EchoCommand extends StatefulWidget {\n final TextEditingController txtController = TextEditingController();\n final TitanDevice device;\n\n EchoCommand(this.device, {Key? key, String? text}) : super(key: key) {\n txtController.text = text ?? '';\n }\n\n @override\n State createState() => _EchoCommandState();\n}\n\nclass _EchoCommandState extends State {\n\n String _response = '';\n\n _echo(String msg) async {\n Client client = widget.device.client!;\n String response = await client.echo(msg, const Duration(seconds: 5));\n setState(() {\n _response = response;\n });\n }\n \n @override\n Widget build(BuildContext context) {\n final widgets = [\n Card(\n child: ListTile(\n leading: const Icon(Icons.abc),\n title: TextField(\n controller: widget.txtController,\n onSubmitted: (text) async {\n _echo(text);\n },\n )\n ),\n ),\n Card(\n child: ListTile(\n leading: const Icon(Icons.comment),\n title: Text(_response)\n ),\n )\n ];\n return SingleChildScrollView(\n child: Column(\n children: widgets,\n ),\n );\n }\n}\n\nThis creates a UI to enter text and display the echoed response.\n\nThe first time it is ran, the echo command works as expected and the correct text is displayed. Subsequent attempts, however, throw an exception:\n\nE/flutter ( 9600): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Bad state: Stream has already been listened to.\nE/flutter ( 9600): #0 _StreamController._subscribe (dart:async/stream_controller.dart:676:7)\nE/flutter ( 9600): #1 _ControllerStream._createSubscription (dart:async/stream_controller.dart:827:19)\nE/flutter ( 9600): #2 _StreamImpl.listen (dart:async/stream_impl.dart:473:9)\nE/flutter ( 9600): #3 Smp.decode. package:mcumgr/…/smp/smp.dart:23\nE/flutter ( 9600): #4 _runGuarded (dart:async/stream_controller.dart:814:24)\nE/flutter ( 9600): #5 _BroadcastStreamController._subscribe (dart:async/broadcast_stream_controller.dart:207:7)\nE/flutter ( 9600): #6 _ControllerStream._createSubscription (dart:async/stream_controller.dart:827:19)\nE/flutter ( 9600): #7 _StreamImpl.listen (dart:async/stream_impl.dart:473:9)\nE/flutter ( 9600): #8 new _ForwardingStreamSubscription (dart:async/stream_pipe.dart:114:10)\nE/flutter ( 9600): #9 _ForwardingStream._createSubscription (dart:async/stream_pipe.dart:86:16)\nE/flutter ( 9600): #10 _ForwardingStream.listen (dart:async/stream_pipe.dart:81:12)\nE/flutter ( 9600): #11 Stream.timeout. (dart:async/stream.dart:1598:31)\nE/flutter ( 9600): #12 _runGuarded (dart:async/stream_controller.dart:814:24)\nE/flutter ( 9600): #13 _BroadcastStreamController._subscribe (dart:async/broadcast_stream_controller.dart:207:7)\nE/flutter ( 9600): #14 _ControllerStream._createSubscription (dart:async/stream_controller.dart:827:19)\nE/flutter ( 9600): #15 _StreamImpl.listen (dart:async/stream_impl.dart:473:9)\nE/flutter ( 9600): #16 Stream.first (dart:async/stream.dart:1280:14)\nE/flutter ( 9600): #17 Client._execute package:mcumgr/client.dart:41\nE/flutter ( 9600): #18 Client.execute package:mcumgr/client.dart:105\nE/flutter ( 9600): #19 ClientOsExtension.echo package:mcumgr/os.dart:15\nE/flutter ( 9600): #20 _EchoCommandState._echo\n\nDo you have aby idea why the client is only able to execute one command is this example?","author_login":"BikeBr0","author_association":"NONE","created_at":"2022-04-06T23:07:22+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[1169045907],"is_known_query_context":false},{"document_id":"gh_comment_1091108430","fragment_type":"issue_comment","sequence":3,"text":"That's because the client creates a new subscription to the input stream every time you run a command, which flutter_reactive_ble doesn't allow. I changed that in 37bb5bde0c78942664dd61124e5c930967f34b80, but didn't release a new version yet because there are still some problems with error handling.\n\nFor now, you could just pass `.asBroadcastStream()` to the client.","author_login":"jkdhn","author_association":"OWNER","created_at":"2022-04-07T05:54:13+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091951584","fragment_type":"issue_comment","sequence":4,"text":"That worked! Now my Client instantiation looks like:\n\nfinal client = Client(\n input: _ble.subscribeToCharacteristic(characteristic).asBroadcastStream(),\n output: (msg) => _ble.writeCharacteristicWithoutResponse(characteristic, value: msg),\n);\n\nI did notice that my App crashes when I disconnect from the peripheral. Is this the error you are referring to?\n\nW/System.err(26516): io.reactivex.exceptions.UndeliverableException: The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with. Further reading: URL | com.polidea.rxandroidble2.exceptions.BleDisconnectedException: Disconnected from MAC='XX:XX:XX:XX:XX:XX' with status 0 (GATT_SUCCESS)","author_login":"BikeBr0","author_association":"NONE","created_at":"2022-04-07T16:22:39+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091981849","fragment_type":"issue_comment","sequence":5,"text":"I was able to prevent the disconnect error by changing the Client instantiation as follows:\n\n_client = Client(\n input: _ble.subscribeToCharacteristic(characteristic).asBroadcastStream(onListen: (subscription) {\n _subscription = subscription;\n }),\n output: (msg) => _ble.writeCharacteristicWithoutResponse(characteristic, value: msg),\n);\n\nAnd then calling \n\n_subscription?.cancel();\n_connection?.cancel();\n\nWhen disconnecting from the peripheral.","author_login":"BikeBr0","author_association":"NONE","created_at":"2022-04-07T16:55:54+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092095087","fragment_type":"issue_comment","sequence":6,"text":"The the flutter_reactive_ble FAQ contains a workaround for that exception.\n\nI don't think canceling the subscription is enough, I still got that exception rarely (until I added that workaround in 0fe4cdcb029a8a47e1dc323e2711986002ca681a).\n\nI also added some code to the example to completely ignore errors in the subscription stream because I occasionally got stale \"disconnected\" errors in the new connection after reconnecting to the device. Disconnecting causes the subscription stream to end anyways, so I'm not sure why that error even exists.","author_login":"jkdhn","author_association":"OWNER","created_at":"2022-04-07T18:57:59+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1193683404,"issue_number":3,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1169045907","fragment_type":"issue_description","sequence":0,"text":"Simple Echo example\nI am evaluating this pluigin for use in a Flutter App. Do you have a simple example of issuing an ECHO command? I realize this plugin does not mean to support all mcumgr commands but a little example would help to expose what more work is needed on my side. For example: here is the code required to issue the ECHO command using Nordic's mcumgr for Android:\n\n`\n String uuid = call.argument(\"uuid\");\n BluetoothDevice bluetoothDevice = manager.getAdapter().getRemoteDevice(uuid);\n String message = call.argument(\"message\");\n McuMgrTransport transport = new McuMgrBleTransport(context, bluetoothDevice);\n DefaultManager defaultManager = new DefaultManager(transport);\n\n defaultManager.echo(message, new McuMgrCallback () {\n @Override\n public void onResponse(@NotNull McuMgrEchoResponse response) {\n result.success(new String(response.r.getBytes(StandardCharsets.UTF_8)));\n }\n\n @Override\n public void onError(@NotNull McuMgrException error) {\n result.error(\"MCUMGR_ERROR\", \"Echo command failed\", error.getMessage());\n }\n });\n\n`","author_login":"BikeBr0","author_association":"NONE","created_at":"2022-03-15T00:23:38+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1169045907,"issue_number":1,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1069117391","fragment_type":"issue_comment","sequence":1,"text":"To create a client, you need another package which provides Bluetooth connectivity.\nI've used flutter_blue in the past, but that looks like it's unmaintained, flutter_reactive_ble might be a good alternative.\n\nYou need to discover the service (`8d53dc1d-1db7-4cd3-868b-8a527460aa84`) and characteristic (`da2e7828-fbce-4e01-ae9e-261174997c48`). Then, you subscribe to notifications from the characteristic and pass that stream to the Client constructor - the client will read responses from there. To send requests, it also needs a callback which writes a byte array to the characteristic. There's an example for that in the README.md.\n\nAlso remember to increase the MTU of the connection, the default is way too low and probably won't work.\n\nAfter that, using the echo command looks like this:\n\ndart\nfinal response = await client.echo(\"Hello World\", Duration(seconds: 5));\n\nThis will throw an exception if the command times out or the device returns an error.\n\nOnly few commands are implemented yet (for example, I just added echo in 0.0.2), so depending on what you want to do, you might have to use `client.execute` (and/or create an issue). But everything that's needed for firmware uploads is there.\n\nThere's no full example yet, I'll probably write one for firmware uploads using flutter_reactive_ble this weekend.","author_login":"jkdhn","author_association":"OWNER","created_at":"2022-03-16T13:16:27+08:00","repo_name":"jkdhn/mcumgr-dart","issue_id":1169045907,"issue_number":1,"issue_url":"https://github.com/jkdhn/mcumgr-dart/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0238","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Error when evaluating SSR module: \"Object.defineProperty is not a function\"?","query_context":"### Having below dependancies,\n\n \"@sjsf/ajv8-validator\": \"^2.0.0-next.11\",\n \"@sjsf/flowbite3-theme\": \"^2.0.0-next.11\",\n \"@sjsf/form\": \"^2.0.0-next.11\",\n \"ajv\": \"^8.17.1\",\n\n### included below in app.css\n\n @source \"../node_modules/@sjsf/flowbite3-theme/dist\";\n\n### tried running demo code from README. Getting below error:\n\n10:58:20 PM [vite] (ssr) Error when evaluating SSR module /src/routes/(widgets)/pages/sample/+page.svelte: Object.defineProperty is not a function\n at eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/object.svelte:3:21)\n at ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1070:6)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:82)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:35)\n at SSRCompatModuleRunner.cachedRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1179:28)\n at request (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1228:79)\n at async eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/exports.js:2:1)\n at async ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1062:5)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:61)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:23)\nTypeError: Object.defineProperty is not a function\n at eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/object.svelte:3:21)\n at ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1070:6)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:82)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:35)\n at SSRCompatModuleRunner.cachedRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1179:28)\n at request (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1228:79)\n at async eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/exports.js:2:1)\n at async ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1062:5)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:61)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:23)\n\nKindly help!\n\nBelow is my full list of dependencies for reference:\n\n \"devDependencies\": {\n \"@eslint/compat\": \"^1.2.5\",\n \"@eslint/js\": \"^9.18.0\",\n \"@sveltejs/adapter-node\": \"^5.2.12\",\n \"@sveltejs/kit\": \"^2.16.0\",\n \"@sveltejs/vite-plugin-svelte\": \"^5.0.0\",\n \"@tailwindcss/vite\": \"^4.0.0\",\n \"eslint\": \"^9.18.0\",\n \"eslint-config-prettier\": \"^10.0.1\",\n \"eslint-plugin-svelte\": \"^3.0.0\",\n \"flowbite-svelte\": \"^1.0.5\",\n \"flowbite-svelte-icons\": \"^2.1.1\",\n \"globals\": \"^16.0.0\",\n \"prettier\": \"^3.4.2\",\n \"prettier-plugin-svelte\": \"^3.3.3\",\n \"prettier-plugin-tailwindcss\": \"^0.6.11\",\n \"svelte\": \"^5.0.0\",\n \"svelte-check\": \"^4.0.0\",\n \"tailwindcss\": \"^4.0.0\",\n \"typescript\": \"^5.0.0\",\n \"typescript-eslint\": \"^8.20.0\",\n \"vite\": \"^6.2.6\"\n },\n \"dependencies\": {\n \"@sjsf/ajv8-validator\": \"^2.0.0-next.11\",\n \"@sjsf/flowbite3-theme\": \"^2.0.0-next.11\",\n \"@sjsf/form\": \"^2.0.0-next.11\",\n \"ajv\": \"^8.17.1\",\n \"apexcharts\": \"^4.7.0\",\n \"date-fns\": \"^4.1.0\",\n \"knex\": \"^3.1.0\",\n \"mysql2\": \"^3.14.1\",\n \"unplugin-icons\": \"^22.1.0\"\n }","known_context_document_ids":["gh_issue_3049668350"],"reference_answer":"@x0k Ah, yes. That's the \"slight\" difference. These two are semantically different and you probably have the latter. The former was broken for a long time but the latter just got broken since 6.3.3 due to our natural generalization and we should fix both.\n\njs\nexport default function Object() {}\n\njs\nfunction Object() {}\nexport default Object;","answer_document_id":"gh_comment_2848524390","silver_evidence_path":["gh_comment_2864153910","gh_issue_3036816344","gh_comment_2848524390"],"evidence_issue_ids":[3049668350,3036816344],"source_repo_name":"x0k/svelte-jsonschema-form","source_issue_id":3049668350,"source_issue_number":103,"source_issue_url":"https://github.com/x0k/svelte-jsonschema-form/issues/103","target_repo_name":"vitejs/vite","target_issue_id":3036816344,"target_issue_number":19993,"target_issue_url":"https://github.com/vitejs/vite/issues/19993","reference_anchor_document_id":"gh_comment_2864153910","reference_answer_author":"hi-ogawa","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.3125,"target_answer_overlap":0.1667},"issue_created_at":"2025-05-08T17:36:18+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_3049668350","fragment_type":"issue_description","sequence":0,"text":"Error when evaluating SSR module: \"Object.defineProperty is not a function\"\n### Having below dependancies,\n\n \"@sjsf/ajv8-validator\": \"^2.0.0-next.11\",\n \"@sjsf/flowbite3-theme\": \"^2.0.0-next.11\",\n \"@sjsf/form\": \"^2.0.0-next.11\",\n \"ajv\": \"^8.17.1\",\n\n### included below in app.css\n\n @source \"../node_modules/@sjsf/flowbite3-theme/dist\";\n\n### tried running demo code from README. Getting below error:\n\n10:58:20 PM [vite] (ssr) Error when evaluating SSR module /src/routes/(widgets)/pages/sample/+page.svelte: Object.defineProperty is not a function\n at eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/object.svelte:3:21)\n at ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1070:6)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:82)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:35)\n at SSRCompatModuleRunner.cachedRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1179:28)\n at request (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1228:79)\n at async eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/exports.js:2:1)\n at async ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1062:5)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:61)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:23)\nTypeError: Object.defineProperty is not a function\n at eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/object.svelte:3:21)\n at ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1070:6)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:82)\n at SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:35)\n at SSRCompatModuleRunner.cachedRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1179:28)\n at request (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1228:79)\n at async eval (/Users/gin/sample/node_modules/@sjsf/form/dist/fields/object/exports.js:2:1)\n at async ESModulesEvaluator.runInlinedModule (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1062:5)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/module-runner.js:1284:61)\n at async SSRCompatModuleRunner.directRequest (file:///Users/gin/sample/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:25274:23)\n\nKindly help!\n\nBelow is my full list of dependencies for reference:\n\n \"devDependencies\": {\n \"@eslint/compat\": \"^1.2.5\",\n \"@eslint/js\": \"^9.18.0\",\n \"@sveltejs/adapter-node\": \"^5.2.12\",\n \"@sveltejs/kit\": \"^2.16.0\",\n \"@sveltejs/vite-plugin-svelte\": \"^5.0.0\",\n \"@tailwindcss/vite\": \"^4.0.0\",\n \"eslint\": \"^9.18.0\",\n \"eslint-config-prettier\": \"^10.0.1\",\n \"eslint-plugin-svelte\": \"^3.0.0\",\n \"flowbite-svelte\": \"^1.0.5\",\n \"flowbite-svelte-icons\": \"^2.1.1\",\n \"globals\": \"^16.0.0\",\n \"prettier\": \"^3.4.2\",\n \"prettier-plugin-svelte\": \"^3.3.3\",\n \"prettier-plugin-tailwindcss\": \"^0.6.11\",\n \"svelte\": \"^5.0.0\",\n \"svelte-check\": \"^4.0.0\",\n \"tailwindcss\": \"^4.0.0\",\n \"typescript\": \"^5.0.0\",\n \"typescript-eslint\": \"^8.20.0\",\n \"vite\": \"^6.2.6\"\n },\n \"dependencies\": {\n \"@sjsf/ajv8-validator\": \"^2.0.0-next.11\",\n \"@sjsf/flowbite3-theme\": \"^2.0.0-next.11\",\n \"@sjsf/form\": \"^2.0.0-next.11\",\n \"ajv\": \"^8.17.1\",\n \"apexcharts\": \"^4.7.0\",\n \"date-fns\": \"^4.1.0\",\n \"knex\": \"^3.1.0\",\n \"mysql2\": \"^3.14.1\",\n \"unplugin-icons\": \"^22.1.0\"\n }","author_login":"stalingino","author_association":"NONE","created_at":"2025-05-08T17:36:18+08:00","repo_name":"x0k/svelte-jsonschema-form","issue_id":3049668350,"issue_number":103,"issue_url":"https://github.com/x0k/svelte-jsonschema-form/issues/103","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2864153910","fragment_type":"issue_comment","sequence":1,"text":"This is a Vite bug (`vite@6.3.2` or less works) URL \n\nWe can fix this by simply renaming the `object.svelte` files, but for now I'll keep an eye on progress on linked issue.","author_login":"x0k","author_association":"OWNER","created_at":"2025-05-08T20:10:27+08:00","repo_name":"x0k/svelte-jsonschema-form","issue_id":3049668350,"issue_number":103,"issue_url":"https://github.com/x0k/svelte-jsonschema-form/issues/103","linked_issue_ids":[3036816344],"is_known_query_context":false},{"document_id":"gh_comment_2880860203","fragment_type":"issue_comment","sequence":2,"text":"Noticed that the fix was assigned to 7.0 milestone, so I'll do the fix on the SJSF side in `2.0.0-next.12`.","author_login":"x0k","author_association":"OWNER","created_at":"2025-05-14T16:31:22+08:00","repo_name":"x0k/svelte-jsonschema-form","issue_id":3049668350,"issue_number":103,"issue_url":"https://github.com/x0k/svelte-jsonschema-form/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3506498361","fragment_type":"issue_comment","sequence":3,"text":"Stay on `vite@7`, can you provide more info about this error `Cannot read properties of undefined (reading 'Root')` ?\n\nNot related to this issue, but this line in defaults\n\nts\nexport { createFormIdBuilder as idBuilder } from \"@sjsf/form/id-builders/modern\";\n\nshould be\n\nts\nexport { createFormIdBuilder as idBuilder } from \"@sjsf/sveltekit\";\n\nI also don't see a `theme` export from defaults, maybe this is the reason","author_login":"x0k","author_association":"NONE","created_at":"2025-11-08T12:22:43+08:00","repo_name":"x0k/svelte-jsonschema-form","issue_id":3049668350,"issue_number":103,"issue_url":"https://github.com/x0k/svelte-jsonschema-form/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3506510364","fragment_type":"issue_comment","sequence":4,"text":"Yes `should provide your components via setThemeContext` means that instead of\n\nimport * as components from \"@sjsf/shadcn4-theme/new-york\";\nimport * as extraComponents from \"@sjsf-lab/shadcn-extras-theme/ui\";\n\nyou should import them from you codebase example.\n\nI have prepared an example for you; I hope it will be helpful StackBlitz","author_login":"x0k","author_association":"NONE","created_at":"2025-11-08T12:42:19+08:00","repo_name":"x0k/svelte-jsonschema-form","issue_id":3049668350,"issue_number":103,"issue_url":"https://github.com/x0k/svelte-jsonschema-form/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3036816344","fragment_type":"issue_description","sequence":0,"text":"Live binding does not work when the `Object` constructor is shadowed\n### Describe the bug\n\nAfter updating to `vite@6.3.3`, SSR in my app stopped working.\nI discovered that the issue was introduced in this commit: URL \n\n`lib.js` contains the following code, which shadows the global `Object` constructor and causes the following error:\n\njs\nexport default function Object() {}\n\nTypeError: Object.defineProperty is not a function\n at eval (/home/projects/vitejs-vite-b63hinxr/src/lib.js:5:8)\n at ESModulesEvaluator.runInlinedModule (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1078:6)\n at ModuleRunner.directRequest (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1292:82)\n at ModuleRunner.cachedRequest (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1187:28)\n at request (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1236:79)\n at async eval (/home/projects/vitejs-vite-b63hinxr/src/main.js:3:44)\n at async ESModulesEvaluator.runInlinedModule (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1070:5)\n at async ModuleRunner.directRequest (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1292:61)\n at async ModuleRunner.cachedRequest (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1188:76)\n at async ModuleRunner.import (file:///home/projects/vitejs-vite-b63hinxr/node_modules/vite/dist/node/module-runner.js:1125:12)\n\n### Reproduction\n\n URL \n\n### Steps to reproduce\n\nopen stackblitz\n\n### System Info\n\nshell\nSystem:\n OS: Linux 6.6 cpe:/o:nixos:nixos:24.11 24.11 (Vicuna)\n CPU: (12) x64 Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz\n Memory: 3.82 GB / 15.56 GB\n Container: Yes\n Shell: 5.2.37 - /run/current-system/sw/bin/bash\n Binaries:\n Node: 23.9.0 - /nix/store/wwdh9slw3km4a1cpwacanciinz742wxa-nodejs-23.9.0/bin/node\n npm: 10.9.2 - /nix/store/wwdh9slw3km4a1cpwacanciinz742wxa-nodejs-23.9.0/bin/npm\n pnpm: 10.1.0 - /nix/store/7v3vl4fgjqswj50zm8na25bnxqgli7sn-pnpm-10.6.2/bin/pnpm\n Browsers:\n Brave Browser: 135.1.77.101\n npmPackages:\n vite: catalog: => 6.3.3\n\n### Used Package Manager\n\npnpm\n\n### Logs\n\n_No response_\n\n### Validations\n\n- [x] Follow our Code of Conduct\n- [x] Read the Contributing Guidelines.\n- [x] Read the docs.\n- [x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.\n- [x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.\n- [x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.\n- [x] The provided reproduction is a minimal reproducible example of the bug.","author_login":"x0k","author_association":"NONE","created_at":"2025-05-02T20:50:30+08:00","repo_name":"vitejs/vite","issue_id":3036816344,"issue_number":19993,"issue_url":"https://github.com/vitejs/vite/issues/19993","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2848443086","fragment_type":"issue_comment","sequence":1,"text":"Your reproduction fails before 6.3.3 and that would be a known issue URL Do you have maybe a slightly different code which fails on 6.3.3 specifically?","author_login":"hi-ogawa","author_association":"COLLABORATOR","created_at":"2025-05-03T05:30:11+08:00","repo_name":"vitejs/vite","issue_id":3036816344,"issue_number":19993,"issue_url":"https://github.com/vitejs/vite/issues/19993","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2848519672","fragment_type":"issue_comment","sequence":2,"text":"It seems that before 6.3.3 the following code was not added to the output file\n\njs\n Object.defineProperty(__vite_ssr_exports__, \"default\", {\n enumerable: true,\n configurable: true,\n get() {\n return __vite_ssr_export_default__;\n },\n });","author_login":"x0k","author_association":"NONE","created_at":"2025-05-03T08:29:38+08:00","repo_name":"vitejs/vite","issue_id":3036816344,"issue_number":19993,"issue_url":"https://github.com/vitejs/vite/issues/19993","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2848524390","fragment_type":"issue_comment","sequence":3,"text":"@x0k Ah, yes. That's the \"slight\" difference. These two are semantically different and you probably have the latter. The former was broken for a long time but the latter just got broken since 6.3.3 due to our natural generalization and we should fix both.\n\njs\nexport default function Object() {}\n\njs\nfunction Object() {}\nexport default Object;","author_login":"hi-ogawa","author_association":"COLLABORATOR","created_at":"2025-05-03T08:44:13+08:00","repo_name":"vitejs/vite","issue_id":3036816344,"issue_number":19993,"issue_url":"https://github.com/vitejs/vite/issues/19993","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0239","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"hide .env file on the web?","query_context":"Hi, thanks for this package.\n\nI'm using it in a web project, but I noticed that the .env file is available via inspector, I think because it's in assets, is there any way I can hide it?\n\n<img width=\"667\" alt=\"Screen Shot 2022-10-03 at 12 12 20\" src=\" URL","known_context_document_ids":["gh_issue_1394904964"],"reference_answer":"Thanks for raising the issue!\n\nRelated issues raised are\n URL \n URL \n URL \n\nI am going to close the issues for now but if someone would like to discuss if there is value in obfuscation or has another better idea please feel free to open or re open!","answer_document_id":"gh_comment_2421539531","silver_evidence_path":["gh_comment_2421537530","gh_issue_2516271781","gh_comment_2421539531"],"evidence_issue_ids":[1394904964,2516271781],"source_repo_name":"java-james/flutter_dotenv","source_issue_id":1394904964,"source_issue_number":74,"source_issue_url":"https://github.com/java-james/flutter_dotenv/issues/74","target_repo_name":"java-james/flutter_dotenv","target_issue_id":2516271781,"target_issue_number":111,"target_issue_url":"https://github.com/java-james/flutter_dotenv/issues/111","reference_anchor_document_id":"gh_comment_2421537530","reference_answer_author":"java-james","reference_answer_author_association":"OWNER","quality_score":78.48,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0435,"anchor_target_overlap":0.3958,"target_answer_overlap":0.0},"issue_created_at":"2022-10-03T15:12:34+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1394904964","fragment_type":"issue_description","sequence":0,"text":"hide .env file on the web\nHi, thanks for this package.\n\nI'm using it in a web project, but I noticed that the .env file is available via inspector, I think because it's in assets, is there any way I can hide it?\n\n<img width=\"667\" alt=\"Screen Shot 2022-10-03 at 12 12 20\" src=\" URL","author_login":"rodrigorafaeldamaceno","author_association":"NONE","created_at":"2022-10-03T15:12:34+08:00","repo_name":"java-james/flutter_dotenv","issue_id":1394904964,"issue_number":74,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/74","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1509901066","fragment_type":"issue_comment","sequence":1,"text":"@rodrigorafaeldamaceno , you shouldn't put secrets on the frontend. It's an env file intended to put endpoints, tokens, flags that will always be visible to the frontend even if compiled into the code.","author_login":"kev-techi","author_association":"NONE","created_at":"2023-04-15T17:29:52+08:00","repo_name":"java-james/flutter_dotenv","issue_id":1394904964,"issue_number":74,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/74","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2421537530","fragment_type":"issue_comment","sequence":2,"text":"Hey everyone. Some good discussion on this thread. \n\nI've appended a section to the readme to be more explicit about the concern. See URL \n\nIt's worth mentioning we could add obfuscation to this package to achieve making it harder to extract keys but it would come at a concern of giving the package consumers a false sense of security.\n\nRelated issues raised are\n URL \n URL \n URL \n\nI am going to close the issues for now but if someone would like to discuss if there is value in obfuscation or has another better idea please feel free to open or re open!","author_login":"java-james","author_association":"OWNER","created_at":"2024-10-18T06:33:07+08:00","repo_name":"java-james/flutter_dotenv","issue_id":1394904964,"issue_number":74,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/74","linked_issue_ids":[2516271781],"is_known_query_context":false},{"document_id":"gh_issue_2516271781","fragment_type":"issue_description","sequence":0,"text":".env is available in plain text via web!\nI recently decided to build and run a web version of my app. I was really surprised to find out that your env file is clearly visible in the Google Dev Console as plain text.\n\nIf this behavior is expected, it should be clearly stated in the documentation with a big WARNING sign.\n\n.env is not for storing anything you can't expose to the public and this should be clearly communicated.","author_login":"lukyanov","author_association":"NONE","created_at":"2024-09-10T12:13:22+08:00","repo_name":"java-james/flutter_dotenv","issue_id":2516271781,"issue_number":111,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408274684","fragment_type":"issue_comment","sequence":1,"text":"Environment variables used by your front end application at runtime cannot be reliably projected. They are required to be bundled into the code. Sensitive variables should be stored on your server/backend for example.\n\nPlease see related issue and discussion URL","author_login":"java-james","author_association":"OWNER","created_at":"2024-10-12T00:49:43+08:00","repo_name":"java-james/flutter_dotenv","issue_id":2516271781,"issue_number":111,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2410200900","fragment_type":"issue_comment","sequence":2,"text":"I have added a new section to the readme. URL \n\nObfuscation is something I would be happy to consider along as it's clear to the users of this and any frontend env lib that the bundled keys can be extracted and people don't have a false sense of security and therefore store sensitive info.","author_login":"java-james","author_association":"OWNER","created_at":"2024-10-14T07:01:36+08:00","repo_name":"java-james/flutter_dotenv","issue_id":2516271781,"issue_number":111,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/111","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2421539531","fragment_type":"issue_comment","sequence":3,"text":"Thanks for raising the issue!\n\nRelated issues raised are\n URL \n URL \n URL \n\nI am going to close the issues for now but if someone would like to discuss if there is value in obfuscation or has another better idea please feel free to open or re open!","author_login":"java-james","author_association":"OWNER","created_at":"2024-10-18T06:34:48+08:00","repo_name":"java-james/flutter_dotenv","issue_id":2516271781,"issue_number":111,"issue_url":"https://github.com/java-james/flutter_dotenv/issues/111","linked_issue_ids":[2516271781],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0240","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Thread 1: \"MMKV not initialized properly, must call +initializeMMKV: in main thread before calling any other MMKV methods\"?","query_context":"## Note:\nAn crash issue will be **ignored & closed** in a week **without logs**.\n\n### The language of MMKV\n\nSwift\n\n### The version of MMKV\n\n1.3.5\n\n### The platform of MMKV\n\niOS \n\n### The installation of MMKV\n\nCocoapods\n\n### What's the issue?\n\nThread 1: \"MMKV not initialized properly, must call +initializeMMKV: in main thread before calling any other MMKV methods\"\n\n### What's the log of MMKV when that happened?\n*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'MMKV not initialized properly, must call +initializeMMKV: in main thread before calling any other MMKV methods'\n*** First throw call stack:\n(\n 0 CoreFoundation 0x00000001804ae138 __exceptionPreprocess + 172\n 1 libobjc.A.dylib 0x0000000180087db4 objc_exception_throw + 56\n 2 Foundation 0x0000000180d2dfd8 _userInfoForFileAndLine + 0\n 3 MMKV 0x0000000100d89888 +[MMKV mmkvWithID:cryptKey:rootPath:mode:expectedCapacity:] + 156\n 4 MMKV 0x0000000100d897e0 +[MMKV mmkvWithID:cryptKey:rootPath:mode:] + 88\n 5 MMKV 0x0000000100d893e8 +[MMKV mmkvWithID:mode:] + 160\n 6 moment 0x0000000100aec104 $sSo4MMKVC6mmapID4modeABSgSS_So8MMKVModeVtcfCTO + 64\n 7 moment 0x0000000100aebe8c $s6moment13OperationViewC09configSubC0yyF + 728\n 8 moment 0x0000000100aca994 $s6moment8BaseViewC5frameACSo6CGRectV_tcfc + 320\n 9 moment 0x0000000100acaa14 $s6moment8BaseViewC5frameACSo6CGRectV_tcfcTo + 56\n 10 moment 0x0000000100aec608 $s6moment13OperationViewC5frameACSo6CGRectV_tcfc + 272\n 11 moment 0x0000000100aec66c $s6moment13OperationViewC5frameACSo6CGRectV_tcfcTo + 56\n 12 moment 0x0000000100ae548c $s6moment13OperationViewC5frameACSo6CGRectV_tcfC + 96\n 13 moment 0x0000000100ae5284 $s6moment9GroupCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfc + 3152\n 14 moment 0x0000000100ae5538 $s6moment9GroupCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfcTo + 160\n 15 moment 0x0000000100ae8290 $s6moment8TextCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfc + 228\n 16 moment 0x0000000100ae8370 $s6moment8TextCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfcTo + 160\n 17 UIKitCore 0x0000000185603c04 -[UITableView _dequeueReusableViewOfType:withIdentifier:] + 416\n 18 UIKitCore 0x0000000185603e44 -[UITableView dequeueReusableCellWithIdentifier:] + 152\n 19 UIKitCore 0x0000000185604034 -[UITableView _dequeueReusableCellWithIdentifier:forIndexPath:usingPresentationValues:] + 216\n 20 UIKitCore 0x0000000185603f38 -[UITableView dequeueReusableCellWithIdentifier:forIndexPath:] + 68\n 21 moment 0x0000000100ac9270 $s6moment16MomentControllerC9tableView_12cellForRowAtSo07UITableE4CellCSo0jE0C_10Foundation9IndexPathVtF + 612\n 22 moment 0x0000000100ac9408 $s6moment16MomentControllerC9tableView_12cellForRowAtSo07UITableE4CellCSo0jE0C_10Foundation9IndexPathVtFTo + 136\n 23 UIKitCore 0x0000000185618c8c -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] + 1376\n 24 UIKitCore 0x00000001855eba54 -[UITableView _updateVisibleCellsForRanges:createIfNecessary:] + 560\n 25 UIKitCore 0x00000001855ec06c -[UITableView _updateVisibleCellsNow:] + 1112\n 26 UIKitCore 0x0000000185606168 -[UITableView layoutSubviews] + 144\n 27 UIKitCore 0x000000018590a128 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1492\n 28 QuartzCore 0x000000018a1ae654 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 440\n 29 QuartzCore 0x000000018a1b940c _ZN2CA5Layer28layout_and_display_if_neededEPNS_11TransactionE + 124\n 30 QuartzCore 0x000000018a0f2d30 _ZN2CA7Context18commit_transactionEPNS_11TransactionEdPd + 460\n 31 QuartzCore 0x000000018a122aa8 _ZN2CA11Transaction6commitEv + 652\n 32 UIKitCore 0x0000000185400570 __34-[UIApplication _firstCommitBlock]_block_invoke_2 + 32\n 33 CoreFoundation 0x000000018040ec50 __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 20\n 34 CoreFoundation 0x000000018040e398 __CFRunLoopDoBlocks + 352\n 35 CoreFoundation 0x0000000180408c3c __CFRunLoopRun + 788\n 36 CoreFoundation 0x0000000180408514 CFRunLoopRunSpecific + 572\n 37 GraphicsServices 0x000000018ef06ae4 GSEventRunModal + 160\n 38 UIKitCore 0x00000001853e8040 -[UIApplication _run] + 868\n 39 UIKitCore 0x00000001853ebcc8 UIApplicationMain + 124\n 40 moment 0x0000000100ae2344 main + 64\n 41 dyld 0x0000000100cf9544 start_sim + 20\n 42 ??? 0x0000000100e7a0e0 0x0 + 4310147296\n 43 ??? 0x8152000000000000 0x0 + 9318510578982977536\n)\nlibc++abi: terminating due to uncaught exception of type NSException","known_context_document_ids":["gh_issue_2291626368"],"reference_answer":"Mainly because NSDictionary's value type is uncertain, it's hard to encode/decode NSDictionary properly in protobuf, if not possible.\n\nHowever, you can turn a NSDictionary into a NSData by NSArchive, and store that NSData in MMKV.","answer_document_id":"gh_comment_423465229","silver_evidence_path":["gh_comment_2112463305","gh_issue_362517894","gh_comment_423465229"],"evidence_issue_ids":[2291626368,362517894],"source_repo_name":"Tencent/MMKV","source_issue_id":2291626368,"source_issue_number":1299,"source_issue_url":"https://github.com/Tencent/MMKV/issues/1299","target_repo_name":"Tencent/MMKV","target_issue_id":362517894,"target_issue_number":10,"target_issue_url":"https://github.com/Tencent/MMKV/issues/10","reference_anchor_document_id":"gh_comment_2112463305","reference_answer_author":"lingol","reference_answer_author_association":"COLLABORATOR","quality_score":88.62,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2151,"anchor_target_overlap":0.0263,"target_answer_overlap":0.0556},"issue_created_at":"2024-05-13T01:30:26+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_2291626368","fragment_type":"issue_description","sequence":0,"text":"Thread 1: \"MMKV not initialized properly, must call +initializeMMKV: in main thread before calling any other MMKV methods\"\n## Note:\nAn crash issue will be **ignored & closed** in a week **without logs**.\n\n### The language of MMKV\n\nSwift\n\n### The version of MMKV\n\n1.3.5\n\n### The platform of MMKV\n\niOS \n\n### The installation of MMKV\n\nCocoapods\n\n### What's the issue?\n\nThread 1: \"MMKV not initialized properly, must call +initializeMMKV: in main thread before calling any other MMKV methods\"\n\n### What's the log of MMKV when that happened?\n*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'MMKV not initialized properly, must call +initializeMMKV: in main thread before calling any other MMKV methods'\n*** First throw call stack:\n(\n 0 CoreFoundation 0x00000001804ae138 __exceptionPreprocess + 172\n 1 libobjc.A.dylib 0x0000000180087db4 objc_exception_throw + 56\n 2 Foundation 0x0000000180d2dfd8 _userInfoForFileAndLine + 0\n 3 MMKV 0x0000000100d89888 +[MMKV mmkvWithID:cryptKey:rootPath:mode:expectedCapacity:] + 156\n 4 MMKV 0x0000000100d897e0 +[MMKV mmkvWithID:cryptKey:rootPath:mode:] + 88\n 5 MMKV 0x0000000100d893e8 +[MMKV mmkvWithID:mode:] + 160\n 6 moment 0x0000000100aec104 $sSo4MMKVC6mmapID4modeABSgSS_So8MMKVModeVtcfCTO + 64\n 7 moment 0x0000000100aebe8c $s6moment13OperationViewC09configSubC0yyF + 728\n 8 moment 0x0000000100aca994 $s6moment8BaseViewC5frameACSo6CGRectV_tcfc + 320\n 9 moment 0x0000000100acaa14 $s6moment8BaseViewC5frameACSo6CGRectV_tcfcTo + 56\n 10 moment 0x0000000100aec608 $s6moment13OperationViewC5frameACSo6CGRectV_tcfc + 272\n 11 moment 0x0000000100aec66c $s6moment13OperationViewC5frameACSo6CGRectV_tcfcTo + 56\n 12 moment 0x0000000100ae548c $s6moment13OperationViewC5frameACSo6CGRectV_tcfC + 96\n 13 moment 0x0000000100ae5284 $s6moment9GroupCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfc + 3152\n 14 moment 0x0000000100ae5538 $s6moment9GroupCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfcTo + 160\n 15 moment 0x0000000100ae8290 $s6moment8TextCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfc + 228\n 16 moment 0x0000000100ae8370 $s6moment8TextCellC5style15reuseIdentifierACSo011UITableViewC5StyleV_SSSgtcfcTo + 160\n 17 UIKitCore 0x0000000185603c04 -[UITableView _dequeueReusableViewOfType:withIdentifier:] + 416\n 18 UIKitCore 0x0000000185603e44 -[UITableView dequeueReusableCellWithIdentifier:] + 152\n 19 UIKitCore 0x0000000185604034 -[UITableView _dequeueReusableCellWithIdentifier:forIndexPath:usingPresentationValues:] + 216\n 20 UIKitCore 0x0000000185603f38 -[UITableView dequeueReusableCellWithIdentifier:forIndexPath:] + 68\n 21 moment 0x0000000100ac9270 $s6moment16MomentControllerC9tableView_12cellForRowAtSo07UITableE4CellCSo0jE0C_10Foundation9IndexPathVtF + 612\n 22 moment 0x0000000100ac9408 $s6moment16MomentControllerC9tableView_12cellForRowAtSo07UITableE4CellCSo0jE0C_10Foundation9IndexPathVtFTo + 136\n 23 UIKitCore 0x0000000185618c8c -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] + 1376\n 24 UIKitCore 0x00000001855eba54 -[UITableView _updateVisibleCellsForRanges:createIfNecessary:] + 560\n 25 UIKitCore 0x00000001855ec06c -[UITableView _updateVisibleCellsNow:] + 1112\n 26 UIKitCore 0x0000000185606168 -[UITableView layoutSubviews] + 144\n 27 UIKitCore 0x000000018590a128 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1492\n 28 QuartzCore 0x000000018a1ae654 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 440\n 29 QuartzCore 0x000000018a1b940c _ZN2CA5Layer28layout_and_display_if_neededEPNS_11TransactionE + 124\n 30 QuartzCore 0x000000018a0f2d30 _ZN2CA7Context18commit_transactionEPNS_11TransactionEdPd + 460\n 31 QuartzCore 0x000000018a122aa8 _ZN2CA11Transaction6commitEv + 652\n 32 UIKitCore 0x0000000185400570 __34-[UIApplication _firstCommitBlock]_block_invoke_2 + 32\n 33 CoreFoundation 0x000000018040ec50 __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 20\n 34 CoreFoundation 0x000000018040e398 __CFRunLoopDoBlocks + 352\n 35 CoreFoundation 0x0000000180408c3c __CFRunLoopRun + 788\n 36 CoreFoundation 0x0000000180408514 CFRunLoopRunSpecific + 572\n 37 GraphicsServices 0x000000018ef06ae4 GSEventRunModal + 160\n 38 UIKitCore 0x00000001853e8040 -[UIApplication _run] + 868\n 39 UIKitCore 0x00000001853ebcc8 UIApplicationMain + 124\n 40 moment 0x0000000100ae2344 main + 64\n 41 dyld 0x0000000100cf9544 start_sim + 20\n 42 ??? 0x0000000100e7a0e0 0x0 + 4310147296\n 43 ??? 0x8152000000000000 0x0 + 9318510578982977536\n)\nlibc++abi: terminating due to uncaught exception of type NSException","author_login":"EchoHayate","author_association":"NONE","created_at":"2024-05-13T01:30:26+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2106508866","fragment_type":"issue_comment","sequence":1,"text":"I think the crash is pretty clear. In fact it is crystal clear. MMKV is NOT initiated correctly.\n\nWhat is your problem?","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-13T02:08:19+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106521656","fragment_type":"issue_comment","sequence":2,"text":"Uploading Screenshot 2024-05-13 at 10.23.01.png…\nCheers ! Sorry that I forgot to mention that I have initialize the mmkv by calling this function.","author_login":"EchoHayate","author_association":"NONE","created_at":"2024-05-13T02:25:08+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106524469","fragment_type":"issue_comment","sequence":3,"text":"Uploading Screenshot 2024-05-13 at 10.26.49.png…\nI'm not sure that if you could open the screenshot or not. So I upload it again and with the paste of the snippet\n\nclass AppDelegate: UIResponder, UIApplicationDelegate {\n\n var window: UIWindow?\n \n\n \n func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {\n // Override point for customization after application launch.\n window = UIWindow(frame: UIScreen.main.bounds);\n window?.backgroundColor = UIColor.white;\n \n MMKV.initialize();","author_login":"EchoHayate","author_association":"NONE","created_at":"2024-05-13T02:29:12+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106708829","fragment_type":"issue_comment","sequence":4,"text":"I'm not buying it. Please provide the full logs of mmkv, starting from App launch.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-13T05:54:11+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106710825","fragment_type":"issue_comment","sequence":5,"text":"You should make mmkv initialize the first line of your didFinishLaunch, not the third line.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-13T05:56:18+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106727381","fragment_type":"issue_comment","sequence":6,"text":"No, that is the crash stack. I'm taking about logs from console.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-13T06:10:32+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106730207","fragment_type":"issue_comment","sequence":7,"text":"To be clear, add a line of log before you call MMKV.initialize(). And if there's no log, then mmkv is not initiated.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-13T06:12:46+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106743747","fragment_type":"issue_comment","sequence":8,"text":"And if that's the case, move it to your main() function or create a constructor function for your AppDelegate.\n\nswift\n@UIApplicationMain\nclass AppDelegate: UIResponder, UIApplicationDelegate {\n init() {\n MMKV.initialize()\n\n super.init()\n }\n……\n}","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-13T06:23:21+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2112463305","fragment_type":"issue_comment","sequence":9,"text":"I have added the lines at the beginning of the code.\n@UIApplicationMain\nclass AppDelegate: UIResponder, UIApplicationDelegate {\n\n var window: UIWindow?\n \n override init(){\n print(Thread.current)\n \n MMKV.initialize()\n \n super.init()\n }\n\n \n func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {\n \n \n \n // Override point for customization after application launch.\n window = UIWindow(frame: UIScreen.main.bounds);\n window?.backgroundColor = UIColor.white;\n\nHere is my backtrace\n* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT\n frame #0: 0x0000000105ec49ec libsystem_kernel.dylib`__pthread_kill + 8\n frame #1: 0x0000000104e6f1d0 libsystem_pthread.dylib`pthread_kill + 256\n frame #2: 0x00000001801655c0 libsystem_c.dylib`abort + 104\n frame #3: 0x00000001802a7798 libc++abi.dylib`abort_message + 128\n frame #4: 0x0000000180298eec libc++abi.dylib`demangling_terminate_handler() + 300\n frame #5: 0x0000000180063498 libobjc.A.dylib`_objc_terminate() + 124\n frame #6: 0x00000001802a6c70 libc++abi.dylib`std::__terminate(void (*)()) + 12\n frame #7: 0x00000001802a9acc libc++abi.dylib`__cxa_rethrow + 144\n frame #8: 0x0000000180087f48 libobjc.A.dylib`objc_exception_rethrow + 40\n frame #9: 0x00000001804085c4 CoreFoundation`CFRunLoopRunSpecific + 748\n frame #10: 0x000000018ef06ae4 GraphicsServices`GSEventRunModal + 160\n frame #11: 0x00000001853e8040 UIKitCore`-[UIApplication _run] + 868\n frame #12: 0x00000001853ebcc8 UIKitCore`UIApplicationMain + 124\n * frame #13: 0x0000000104c92724 moment`main at AppDelegate.swift:13:7\n frame #14: 0x0000000105439544 dyld_sim`start_sim + 20\n frame #15: 0x0000000104f360e0 dyld`start + 2360\n\nAlso, I have upgraded the UIKit to the latest version. This issue is still unfixed.","author_login":"EchoHayate","author_association":"NONE","created_at":"2024-05-15T13:04:00+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[362517894],"is_known_query_context":false},{"document_id":"gh_comment_2112690793","fragment_type":"issue_comment","sequence":10,"text":"What are the logs from the console?\nIs it so hard to understand?","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-15T14:23:57+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113814815","fragment_type":"issue_comment","sequence":11,"text":"You know what, I'm tired of repeating to ask the same question. Why don't you upload a reproducible demo?","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-16T02:00:59+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113865481","fragment_type":"issue_comment","sequence":12,"text":"Sorry for causing you any trouble. I'm still learning as a beginner. Here is the repository of the project: URL","author_login":"EchoHayate","author_association":"NONE","created_at":"2024-05-16T02:17:37+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2113918293","fragment_type":"issue_comment","sequence":13,"text":"The problem is that you have called the wrong initialize method.\n\nswift\n// MMKV.initialize();\nMMKV.initialize(rootDir: nil);\n\nChange it as the code above and you should have no problem. \n\nThe `initialize()` method is inherited from NSObject and is useless. I should make it hidden later.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2024-05-16T02:52:34+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2115101988","fragment_type":"issue_comment","sequence":14,"text":"Cheers! I think I couldn't find the log from console even though I tried many times across the Internet. Could you please tell me how to do it? Many Thanks!","author_login":"EchoHayate","author_association":"NONE","created_at":"2024-05-16T12:20:08+08:00","repo_name":"Tencent/MMKV","issue_id":2291626368,"issue_number":1299,"issue_url":"https://github.com/Tencent/MMKV/issues/1299","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_362517894","fragment_type":"issue_description","sequence":0,"text":"why not support NSDictionary as NSUserDefault\n### The language of MMKV\n\nObjective-C\n\n### The version of MMKV\n\nv1.0.10\n\n### The platform of MMKV\n\niOS\n\n### The installation of MMKV\n\nCocoapods\n\n### What's the issue?\n\nFor me, I often use a NSUserDefault to do some simple data persistence. And the NSDictionary is a very important one. Why is there no support for it?","author_login":"yuman07","author_association":"NONE","created_at":"2018-09-21T08:54:20+08:00","repo_name":"Tencent/MMKV","issue_id":362517894,"issue_number":10,"issue_url":"https://github.com/Tencent/MMKV/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423465229","fragment_type":"issue_comment","sequence":1,"text":"Mainly because NSDictionary's value type is uncertain, it's hard to encode/decode NSDictionary properly in protobuf, if not possible.\n\nHowever, you can turn a NSDictionary into a NSData by NSArchive, and store that NSData in MMKV.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2018-09-21T09:00:43+08:00","repo_name":"Tencent/MMKV","issue_id":362517894,"issue_number":10,"issue_url":"https://github.com/Tencent/MMKV/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423466369","fragment_type":"issue_comment","sequence":2,"text":"NSUserDefault can store NSDictionary directly, and MMKV needs to do a conversion through NSArchive. If you consider the consumption of conversion, is the performance advantage of MMKV still greater than NSUserDefault?","author_login":"yuman07","author_association":"NONE","created_at":"2018-09-21T09:04:54+08:00","repo_name":"Tencent/MMKV","issue_id":362517894,"issue_number":10,"issue_url":"https://github.com/Tencent/MMKV/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423468792","fragment_type":"issue_comment","sequence":3,"text":"Well, NSUserDefault's NSDictionary support doesn't come in free. Which algorithm do you think it used to store NSDictionary? NSArchive? I haven't test it yet, but that's my best guess.\n\nGiven that guess, I have confidence MMKV will beat NSUserDefault in such case.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2018-09-21T09:14:15+08:00","repo_name":"Tencent/MMKV","issue_id":362517894,"issue_number":10,"issue_url":"https://github.com/Tencent/MMKV/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_424350388","fragment_type":"issue_comment","sequence":4,"text":"you tell me I should better convert dictionary or Nsarray to NSData ,not the jsonStr , the reason is ( value type is uncertain, it's hard to encode/decode NSDictionary properly)? when I conert to jsonStr , all is NSString ,\nor have other reason ?","author_login":"wg689","author_association":"NONE","created_at":"2018-09-25T13:48:42+08:00","repo_name":"Tencent/MMKV","issue_id":362517894,"issue_number":10,"issue_url":"https://github.com/Tencent/MMKV/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_424606695","fragment_type":"issue_comment","sequence":5,"text":"Use NSData for efficiency, or JSON for convenience. It's your choice.","author_login":"lingol","author_association":"COLLABORATOR","created_at":"2018-09-26T06:58:20+08:00","repo_name":"Tencent/MMKV","issue_id":362517894,"issue_number":10,"issue_url":"https://github.com/Tencent/MMKV/issues/10","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0241","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Fortran: Remove backslash (C escape character) support?","query_context":"Some time ago, code.golf added the `-fbackslash` flag to gfortran. Although it is convenient in some cases, the C-style escape characters are not in the language standard and are more of a language extension.\n\nI feel like I've done enough holes to convince myself that these are not necessary.\n\nAs someone who is more interested in standard-compliant solutions rather than just whatever can be squeezed out of gfortran, I think would be better to remove this flag.\n\nBut think of this issue as more of a \"Request for Comment\"; I am interested to see what others think.","known_context_document_ids":["gh_issue_802978750"],"reference_answer":"Can we close this? We have the flag now, and literal unicode seems to work, thanks.","answer_document_id":"gh_comment_617428019","silver_evidence_path":["gh_comment_1615382249","gh_issue_602264678","gh_comment_617428019"],"evidence_issue_ids":[802978750,602264678],"source_repo_name":"code-golf/code-golf","source_issue_id":802978750,"source_issue_number":376,"source_issue_url":"https://github.com/code-golf/code-golf/issues/376","target_repo_name":"code-golf/code-golf","target_issue_id":602264678,"target_issue_number":177,"target_issue_url":"https://github.com/code-golf/code-golf/issues/177","reference_anchor_document_id":"gh_comment_1615382249","reference_answer_author":"JRaspass","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3542,"anchor_target_overlap":0.1964,"target_answer_overlap":0.25},"issue_created_at":"2021-02-07T15:27:40+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_802978750","fragment_type":"issue_description","sequence":0,"text":"Fortran: Remove backslash (C escape character) support\nSome time ago, code.golf added the `-fbackslash` flag to gfortran. Although it is convenient in some cases, the C-style escape characters are not in the language standard and are more of a language extension.\n\nI feel like I've done enough holes to convince myself that these are not necessary.\n\nAs someone who is more interested in standard-compliant solutions rather than just whatever can be squeezed out of gfortran, I think would be better to remove this flag.\n\nBut think of this issue as more of a \"Request for Comment\"; I am interested to see what others think.","author_login":"marshallward","author_association":"CONTRIBUTOR","created_at":"2021-02-07T15:27:40+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1610689916","fragment_type":"issue_comment","sequence":1,"text":"URL flag is set here.\n\ni prefer to conform to the language standards but i have some golfs built into having \\n exist. so i would be fine either way.","author_login":"stefangimmillaro","author_association":"CONTRIBUTOR","created_at":"2023-06-28T04:25:13+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613392972","fragment_type":"issue_comment","sequence":2,"text":"At this point, I don't think this is worth doing, since it may invalidate solutions that people may not come back to fix. Because Fortran is not one of the most popular languages, I wouldn't want to do something that would reduce the number of solutions.","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2023-06-29T15:26:49+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613615867","fragment_type":"issue_comment","sequence":3,"text":"I've tried to identify the inactive users who could be affected by this change. I've roughly defined \"inactive\" as anyone who has not submitted a solution in the last six months (ie 2023). But in the end, I define it based on my own observation of their activity. (I include some high scorers like cure-honey and LucaArgentiUCF as inactive. Some like ivan-pi are low-frequency but seem active enough to adjust to the change.)\n\nThe holes with inactive players (predominantly \"art\" but a few others as well):\n\n* 12 Days of Christmas: 3/15\n* 99 Bottles of Beer: 5/14\n* ASCII table: 0/9\n* Cubes: 2/9\n* Diamonds: 5/14\n* Game of Life: 0/3\n* Hexdump: 0/4\n* Maze: 0/3\n* Number Spiral: 0/11\n* Quine: ~10/40? (many inactive, but half are cut-and-paste)\n* Sierpinski: 4/12\n* Sudoku: 1/3\n* Sudoku v2: 1/4\n* Tongue Twisters: 3/12\n\nDon't take these numbers too seriously; I didn't script it and I could have overlooked a few holes, and my definition of \"inactive\" might not reflect their willingness to amend their solutions.\n\nMy takeaway is that - with one notable exception - very few of the top scores will be affected, and no hole will be devastated by the change. Worst case is perhaps a loss of ~25% of solutions. Perhaps a bit more of Diamonds and 99 bottles. Practically, I think it will be less.\n\nThe loss of cure-honey's scores could be significant.\n\n----\n\nIf it were me, I'd pull the trigger and drop backslash support. The longer that it's left in, the harder it will be to change. The absence of backslash characters is somewhat unique to Fortran, and can significantly reshape the form of a solution in some cases. Putting it back in feels like part of this ongoing effort to make Fortran look more like C.\n\nBut it's easy for me to say that as a low-effort contributor who doesn't think much about retaining users, so I would leave it in the hands of others to decide.","author_login":"marshallward","author_association":"CONTRIBUTOR","created_at":"2023-06-29T18:35:07+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613862101","fragment_type":"issue_comment","sequence":4,"text":"@JRaspass can you try removing the flag and see how many solutions fail?","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2023-06-29T22:04:27+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615382249","fragment_type":"issue_comment","sequence":5,"text":"We added `-fbackslash` because we initially misunderstood how to deal with UTF-8 in Fortran. See #177. It's a bit unfortunate, because I don't think people use Unicode escape sequences in the way that it was originally requested by @ivan-pi. Or if they do, I doubt it is optimal.\n\nI would consider the loss of 25% of the solutions to be very significant, if it affected that many. For example, that would move Fortran from the 28th most popular language on the site to the 44th most popular language, which would make me very sad. I don't think that it would be worth it.\n\nOne thing we have done in the past that we could consider doing again, if this issue truly is important to people, is running some one time code to automatically replace as many usages of `\\n` as possible, assuming that is the only escape sequence used. We've done this before, when C# enabled top level programs, to strip out the extra boilerplate, for example. In this case, before we disable the flag, before any solutions have broken, we can run through a bunch of replacement rules for `\\n` and if the solutions continue to work, we keep the replacements. That increases the chances that the solutions continue to work after removing the flag.\n\nHere are some examples:\nTry to replace `\\n` with `\"//char(10)//\"`\nTry to replace `\\n` with `'//char(10)//'`\nTry to replace `'\\n'` with `char(10)`\nTry to replace `'\"n\"` with `char(10)`\nTry to replace `\"\\n` with `char(10)//\"`\nTry to replace `'\\n` with `char(10)//'`\nTry to replace `\\n` with `'/'` (when it's used in a literal string in a format specification).\nTry to replace `\\n` with `\"/\"` (when it's used in a literal string in a format specification).\n\nPlus some more variations of the above that add line extension characters automatically in case making the replacement causes the code to hit the line length limit.\n\nThere's probably some other cases that I'm missing.\n\nThese replacements probably aren't optimal, but at least solutions wouldn't break. It may confuse some people though.\n\nAlso, because these replacements are fairly short, they probably wouldn't significantly reshape solutions, unless those solutions contained many instances of `\\n`.","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2023-07-01T02:39:36+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[602264678],"is_known_query_context":false},{"document_id":"gh_comment_1615724355","fragment_type":"issue_comment","sequence":6,"text":"Substitution feels a bit awkward, but I'd be ok with it. Harder to say if the recipients would be.","author_login":"marshallward","author_association":"CONTRIBUTOR","created_at":"2023-07-01T08:47:28+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615823707","fragment_type":"issue_comment","sequence":7,"text":"Before: `11 / 1047` fail\nAfter: `146 / 1047` fail\n\n`84 / 146` are @KatieLG or her transpiler so I'm sure she'd be happy to fix her use of backslash in her auto-printer. So that leaves `51` new failures, not too terrible imo. I see a lot of names on that list that are active enough that they'll probably fix their solutions too.\n\nIt's less than the stats `1770` because the re-tester groups identical bytes/chars for a given golfer to save on re-testing.","author_login":"JRaspass","author_association":"COLLABORATOR","created_at":"2023-07-01T10:02:44+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1616676316","fragment_type":"issue_comment","sequence":8,"text":"Thanks @JRaspass! And also to @SirBogman for handing the discussion. Should we now discuss replacement of `getarg()` with `get_commmand_argument()`? (kidding, kidding...)","author_login":"marshallward","author_association":"CONTRIBUTOR","created_at":"2023-07-02T14:09:37+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1616729730","fragment_type":"issue_comment","sequence":9,"text":"I know you're kidding, but I think that this kind of thing is not as bad, because people will expect it. They wouldn't expect `-fbackslash`.","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2023-07-02T16:52:44+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1616744746","fragment_type":"issue_comment","sequence":10,"text":"I agree, a big difference in my mind is that `get_command_argument()` and `get_command_count()` are almost identical to `getarg()` and `iargc()`, so it's just an offset in count.\n\nOn the other hand, removing `\\n` support can significant change the structure of a solution (at least in my case!), so I think it's a more interesting change.\n\nI also tested four compilers (GNU, Intel Nvidia, Cray) and it seems like they all support `getarg` without special compiler settings, which surprised me. Nvidia was the only one with default support for backslash escape characters, but all have the ability to toggle them.","author_login":"marshallward","author_association":"CONTRIBUTOR","created_at":"2023-07-02T17:35:50+08:00","repo_name":"code-golf/code-golf","issue_id":802978750,"issue_number":376,"issue_url":"https://github.com/code-golf/code-golf/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_602264678","fragment_type":"issue_description","sequence":0,"text":"Fortran and Unicode on Rule 110\nFor the Rule 110 hole, the solution requires the full block character █ (\"\\u2588\").\n\nAs mentioned on this page the `-fbackslash` compiler flag is required for escaped Unicode characters in Fortran with the gfortran compiler. Otherwise, the type conversion has to be done manually using BOZ literals, for instance:\n\nfortran\nstring = u_'unicode_character: ' // char(int(z'263B'), kind=u)\n\n \nRunning the following program\n\nfortran\ninteger, parameter :: u = selected_char_kind('ISO_10646')\ninteger, parameter :: a = selected_char_kind('ASCII')\ninteger::i(100) = 0\nprint *, u, a\nprint *, u_'\\u2588', char(int(z'2588'), kind=u)\nend\n\nproduces the output\n\n 4 1\n \\u2588?\n\nwhich tells me something is wrong with how the ISO_10646 character set is supported.","author_login":"ivan-pi","author_association":"NONE","created_at":"2020-04-17T22:22:04+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615500363","fragment_type":"issue_comment","sequence":1,"text":"I noticed there are many holes which require Unicode characters. If I am not mistaken Fortran compilers are not required to handle Unicode characters in the source code, leading to undefined behavior.","author_login":"ivan-pi","author_association":"NONE","created_at":"2020-04-17T23:04:53+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615502602","fragment_type":"issue_comment","sequence":2,"text":"By design, UTF-8 should normally be compatible with most programming languages that use one byte to store each character. If you put \"█\" into the source code, the compiler will treat it as a three byte string, which is a bit inconvenient, but it prints correctly.\n\nFor example:\n\nfortran\nprint *, \"█\", len(\"█\")\n\nprints\n\n █ 3\n\nThe benefit of using █ directly in the source code is that Code Golf counts it as one character, even though Fortran counts it as three.","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2020-04-17T23:14:57+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615506481","fragment_type":"issue_comment","sequence":3,"text":"Cool, I missed the idea of putting the block in quotes! Thanks.","author_login":"ivan-pi","author_association":"NONE","created_at":"2020-04-17T23:26:46+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615509292","fragment_type":"issue_comment","sequence":4,"text":"We probably may as well add the `-fbackslash` option, since we don't currently have holes that require printing a backslash (you would have to escape it with `\\\\` in that case). Then the following will work:\n\nfortran\nuse::iso_fortran_env\ninteger,parameter::u=selected_char_kind('ISO_10646')\nopen(output_unit,encoding='utf-8')\nprint*,u_'\\u2588'\nend\n\nBut it's much longer than the alternative.\n\nBy the way, welcome to Code Golf 😃","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2020-04-17T23:35:11+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_617428019","fragment_type":"issue_comment","sequence":5,"text":"Can we close this? We have the flag now, and literal unicode seems to work, thanks.","author_login":"JRaspass","author_association":"COLLABORATOR","created_at":"2020-04-21T21:38:16+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_617496166","fragment_type":"issue_comment","sequence":6,"text":"Hopefully most Fortranners will be able to work out the use of literal Unicode characters, or find this issue if they are in trouble.\n\nThanks for your effort. I've learned quite a few new things about Fortran already.","author_login":"ivan-pi","author_association":"NONE","created_at":"2020-04-22T01:38:49+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_619653725","fragment_type":"issue_comment","sequence":7,"text":"Supporting ANSI escape characters may touch on another standards compliance issue. They are not explicitly forbidden, but neither are they supported, and including them has always been less about correctness and more about vendors trying to meet the expectations of customers.\n\nMy impression is that compilers have started disabling them, hence the need to manually enable `-fbackslash`. (Quick look at Intel and PGI also shows them disabled on default.)\n\nEnabling them may still be the right decision, since the Unicode problem is a very hard one to handle in Fortran, but I do think that allowing things like `\\n` as LF does push one away from Fortran list-directed I/O and towards C-like stream manipulation, which may be against the spirit of the challenge.\n\nI don't know what the right decision is on this, but I also don't want to just be a curmudgeon ruining everyone's fun with byzantine concerns about the language standard. I can open a new issue to discuss more if there's interest, but also happy to just drop it if not :).\n\nSome good discussion here at comp.lang.fortran, which is a bit old but still relevant I think: URL","author_login":"marshallward","author_association":"NONE","created_at":"2020-04-27T00:51:35+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_619693120","fragment_type":"issue_comment","sequence":8,"text":"I'm not sure what the best decision is either.\n\nI just checked and I am using a single `\\n` in 12 Days of Christmas. I wouldn't really mind if we decided to remove the flag. It would cost one extra stroke to fix my solution. \n\nI don't think the escaped characters are very useful in general, other than for `\\n`, because you should be able to include arbitrary utf8 characters in strings and this is preferable since they are counted as one character by Code Golf, even if Fortran considers them to be between one and four characters. I know there is at least one character that can't be included literally in a string (`\\n` leads to an `Unterminated character constant` error). I'm not sure if there are others.\n\nI suggested to add the flag because it would make it easier for people to figure out how to output Unicode characters, even though it's not a very good way to do it.","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2020-04-27T03:32:36+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_619700130","fragment_type":"issue_comment","sequence":9,"text":"I agree, I'm also not sure the best approach. I've thankfully never personally had to work with Unicode in Fortran, so I don't know the preferred approach here.\n\n12 days of Christmas is also the only one where I am using a `\\n`, but I did recall having to work around forced line feeds in some of the other problems. Looking back, I think it made those problems more interesting, since they rarely looked much like solutions in other languages.\n\nSince I don't really have a better suggestion, and I'm straying from the issue, I will just leave it here. The flag is a good solution, and perhaps the best one :).","author_login":"marshallward","author_association":"NONE","created_at":"2020-04-27T03:58:13+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_619819661","fragment_type":"issue_comment","sequence":10,"text":"While clearly you've found even shorter solutions, I just thought I'd remind you that Fortran has some pretty powerful formatting strings, e.g.:\n\nfortran\ncharacter(1) :: c(3)\ndata c /'c','d','e'/\nprint'(\"a\",/,\"b\",*(/,:,a))',c\nend\n\nprints\n\na\nb\nc\nd\ne","author_login":"ivan-pi","author_association":"NONE","created_at":"2020-04-27T08:28:39+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_619968380","fragment_type":"issue_comment","sequence":11,"text":"The format strings are very useful. In this case the following prints the same:\n\nfortran\ncharacter(1)::c(3)=['c','d','e']\nprint'(a)','a','b',c\nend","author_login":"SirBogman","author_association":"CONTRIBUTOR","created_at":"2020-04-27T12:56:37+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_620148603","fragment_type":"issue_comment","sequence":12,"text":"Great examples, I myself did not know about `/` formatting.\n\nAll the better reasons to let Fortran be Fortran!","author_login":"marshallward","author_association":"NONE","created_at":"2020-04-27T18:14:55+08:00","repo_name":"code-golf/code-golf","issue_id":602264678,"issue_number":177,"issue_url":"https://github.com/code-golf/code-golf/issues/177","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0242","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"bug/unable to process .docx file from office 365?","query_context":"**Describe the bug**\nWhen I try to use the partition on .docx file, it fails with error unstructured.partition.common.UnsupportedFileFormatError: Partitioning is not supported for the FileType.ZIP file type.\n\n**To Reproduce**\nDownload the attached \n\nDocument.docx\n\nfile and run the below code \n\nfrom unstructured.partition.auto import partition\nelements = partition(\"Document.docx\")\n\n**Expected behavior**\nPartioning should be done without any errors\n\n**Screenshots**\nNA\n\n**Environment Info**\nOS version: macOS-14.6.1-arm64-arm-64bit\nPython version: 3.10.15\nunstructured version: None\nunstructured-inference version: 0.8.7\npytesseract is not installed\nTorch version: 2.6.0\nDetectron2 is not installed\n\n[notice] A new release of pip is available: 23.2.1 -> 25.0.1\n[notice] To update, run: python3 -m pip install --upgrade pip\n\n[notice] A new release of pip is available: 23.2.1 -> 25.0.1\n[notice] To update, run: python3 -m pip install --upgrade pip\nPaddleOCR is not installed\nLibmagic version: file-5.41\nmagic file from /usr/share/file/magic\nTraceback (most recent call last):\nFileNotFoundError: [Errno 2] No such file or directory: 'libreoffice'\n\n**Additional context**\nOn further debugging found that for .docx processing, unstructured relies to unzip the file and look for a specific file called `word/document.xml` , but in certain versions of office365, .docx files are sent with `word/document2.xml`, adding this to the list of checks in URL fixes the issue. \nTried the same in local and found no issues.\n\nTried to understand the same from official microsoft docs, but there is no explicit mention about them","known_context_document_ids":["gh_issue_2891134543"],"reference_answer":"Hello @speedpro , \n\nI have now fixed this issue for good, I do not look anymore at the filenames but instead look at the \"[Content_Types].xml\" file.\n\nThis should be fixed in the just released version (3.10.1).","answer_document_id":"gh_comment_481587389","silver_evidence_path":["gh_comment_2696702745","gh_issue_287129475","gh_comment_481587389"],"evidence_issue_ids":[2891134543,287129475],"source_repo_name":"Unstructured-IO/unstructured","source_issue_id":2891134543,"source_issue_number":3937,"source_issue_url":"https://github.com/Unstructured-IO/unstructured/issues/3937","target_repo_name":"open-xml-templating/docxtemplater","target_issue_id":287129475,"target_issue_number":366,"target_issue_url":"https://github.com/open-xml-templating/docxtemplater/issues/366","reference_anchor_document_id":"gh_comment_2696702745","reference_answer_author":"edi9999","reference_answer_author_association":"MEMBER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.1154,"target_answer_overlap":0.0},"issue_created_at":"2025-03-03T12:36:10+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2891134543","fragment_type":"issue_description","sequence":0,"text":"bug/unable to process .docx file from office 365\n**Describe the bug**\nWhen I try to use the partition on .docx file, it fails with error unstructured.partition.common.UnsupportedFileFormatError: Partitioning is not supported for the FileType.ZIP file type.\n\n**To Reproduce**\nDownload the attached \n\nDocument.docx\n\nfile and run the below code \n\nfrom unstructured.partition.auto import partition\nelements = partition(\"Document.docx\")\n\n**Expected behavior**\nPartioning should be done without any errors\n\n**Screenshots**\nNA\n\n**Environment Info**\nOS version: macOS-14.6.1-arm64-arm-64bit\nPython version: 3.10.15\nunstructured version: None\nunstructured-inference version: 0.8.7\npytesseract is not installed\nTorch version: 2.6.0\nDetectron2 is not installed\n\n[notice] A new release of pip is available: 23.2.1 -> 25.0.1\n[notice] To update, run: python3 -m pip install --upgrade pip\n\n[notice] A new release of pip is available: 23.2.1 -> 25.0.1\n[notice] To update, run: python3 -m pip install --upgrade pip\nPaddleOCR is not installed\nLibmagic version: file-5.41\nmagic file from /usr/share/file/magic\nTraceback (most recent call last):\nFileNotFoundError: [Errno 2] No such file or directory: 'libreoffice'\n\n**Additional context**\nOn further debugging found that for .docx processing, unstructured relies to unzip the file and look for a specific file called `word/document.xml` , but in certain versions of office365, .docx files are sent with `word/document2.xml`, adding this to the list of checks in URL fixes the issue. \nTried the same in local and found no issues.\n\nTried to understand the same from official microsoft docs, but there is no explicit mention about them","author_login":"srisudarsan","author_association":"CONTRIBUTOR","created_at":"2025-03-03T12:36:10+08:00","repo_name":"Unstructured-IO/unstructured","issue_id":2891134543,"issue_number":3937,"issue_url":"https://github.com/Unstructured-IO/unstructured/issues/3937","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2696702745","fragment_type":"issue_comment","sequence":1,"text":"Stumbled on similar issue with other libraries when searching for this, few of them for reference\n URL \n URL \n\nAnd it is possible that the same could be affecting other office file formats like PPTX, XLSX, etc.\n\nLet me know what you think of this and I can potentially suggest a fix for this too","author_login":"srisudarsan","author_association":"NONE","created_at":"2025-03-04T08:59:15+08:00","repo_name":"Unstructured-IO/unstructured","issue_id":2891134543,"issue_number":3937,"issue_url":"https://github.com/Unstructured-IO/unstructured/issues/3937","linked_issue_ids":[287129475],"is_known_query_context":false},{"document_id":"gh_comment_2709724762","fragment_type":"issue_comment","sequence":2,"text":"Hello @micmarty-deepsense , do you have any comments for this ?","author_login":"srisudarsan","author_association":"NONE","created_at":"2025-03-10T08:02:51+08:00","repo_name":"Unstructured-IO/unstructured","issue_id":2891134543,"issue_number":3937,"issue_url":"https://github.com/Unstructured-IO/unstructured/issues/3937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_287129475","fragment_type":"issue_description","sequence":0,"text":"Add support for Office 365 files (with word/document2.xml)\nWhen i use office 365 to edit my docx template (Word Online), the saved document has no `word/document.xml`, but a `word/document2.xml` (see below)\n\nSo i have the error:\n`\n\"The filetype for this file could not be identified, is this file corrupted ?\"`\n\n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\ntemplate_test.docx\n\nhave you planned to support Office365 files?","author_login":"santimauro","author_association":"NONE","created_at":"2018-01-09T15:32:36+08:00","repo_name":"open-xml-templating/docxtemplater","issue_id":287129475,"issue_number":366,"issue_url":"https://github.com/open-xml-templating/docxtemplater/issues/366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_356579570","fragment_type":"issue_comment","sequence":1,"text":"Oh, indeed, this is a bug. \n\nI don't have a clue why office365 uses document2.xml files instead of document.xml, that doesn't make much sense to me, but yes, we should be supporting this.\n\nI will do it in the future if you don't already create a pull request.","author_login":"edi9999","author_association":"OWNER","created_at":"2018-01-10T11:46:40+08:00","repo_name":"open-xml-templating/docxtemplater","issue_id":287129475,"issue_number":366,"issue_url":"https://github.com/open-xml-templating/docxtemplater/issues/366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_356697116","fragment_type":"issue_comment","sequence":2,"text":"I have just released a new version 3.2.3 to npm with this bugfix","author_login":"edi9999","author_association":"OWNER","created_at":"2018-01-10T18:43:38+08:00","repo_name":"open-xml-templating/docxtemplater","issue_id":287129475,"issue_number":366,"issue_url":"https://github.com/open-xml-templating/docxtemplater/issues/366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_481538957","fragment_type":"issue_comment","sequence":3,"text":"Hey @edi9999, \n\nI've just started using the npm module with SharePoint Online, and got pretty much the same error as above, but this time regarding \"word/document22.xml\" (notice, it's **twenty**-two at the end, instead of just a single 2)\n\nI did a quick search/replace in my node_modules folder and replaced all references to document2.xml with document22.xml, and everything worked fine after that.\n\nLooks like Microsoft might be planning to continue playing with the numbers in the filename. Is there a way to make this module more future-proof? I'm happy to help if you need it.","author_login":"speedpro","author_association":"NONE","created_at":"2019-04-10T05:28:15+08:00","repo_name":"open-xml-templating/docxtemplater","issue_id":287129475,"issue_number":366,"issue_url":"https://github.com/open-xml-templating/docxtemplater/issues/366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_481587389","fragment_type":"issue_comment","sequence":4,"text":"Hello @speedpro , \n\nI have now fixed this issue for good, I do not look anymore at the filenames but instead look at the \"[Content_Types].xml\" file.\n\nThis should be fixed in the just released version (3.10.1).","author_login":"edi9999","author_association":"MEMBER","created_at":"2019-04-10T08:15:16+08:00","repo_name":"open-xml-templating/docxtemplater","issue_id":287129475,"issue_number":366,"issue_url":"https://github.com/open-xml-templating/docxtemplater/issues/366","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0243","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Fix `selector-max-specificity` README examples of the `ignoreSelectors` secondary option?","query_context":"see : URL \n\nThese tests are problematic for multiple reasons:\n- `:global` and `:local` are non-standard and it isn't defined what their specificity is.\n- `:global` and `:local` don't have any specificity of their own in `@csstools/selector-specificity`, so ignoring them to reduce their specificity seems weird?\n- `:global` and `:local` do not support selector lists in implementations\n - `lightningcss` errors\n - `postcss-modules` mangles the output (`:global(.page, .bar)` -> `.page .bar`)\n\nThey also dominate the implementation of `selector-max-specificity`.\n\nAs far as I can tell the `ignoreSelectors` was also created with css modules too much in mind.\nIt acts like a hole punch. The AST node that matches doesn't contribute to specificity, but its child nodes do. Which works really well for `:global` and `:local` because they happen to be removed during compilation.\n\nBut I am not sure if this makes sense for any case other than css modules.\nThere isn't any test coverage for other pseudo selectors with child nodes, so I can't tell what the exact intention was here.\n\n--------------\n\nProposal :\n- fix the tests so that `:global` and `:local` are used as supported by implementations\n- better define how `ignoreSelectors` works when it matches AST nodes with child nodes","known_context_document_ids":["gh_issue_2098837543"],"reference_answer":"Did you find the answer?\n\nIf you want to use RegExp, then it's always should be surrounded by `/`, e. g. `\"/.*/\"`.","answer_document_id":"gh_comment_499878534","silver_evidence_path":["gh_comment_1910175718","gh_issue_453495892","gh_comment_499878534"],"evidence_issue_ids":[2098837543,453495892],"source_repo_name":"stylelint/stylelint","source_issue_id":2098837543,"source_issue_number":7495,"source_issue_url":"https://github.com/stylelint/stylelint/issues/7495","target_repo_name":"stylelint/stylelint","target_issue_id":453495892,"target_issue_number":4105,"target_issue_url":"https://github.com/stylelint/stylelint/issues/4105","reference_anchor_document_id":"gh_comment_1910175718","reference_answer_author":"hudochenkov","reference_answer_author_association":"MEMBER","quality_score":81.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.0,"target_answer_overlap":0.1667},"issue_created_at":"2024-01-24T18:20:19+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2098837543","fragment_type":"issue_description","sequence":0,"text":"Fix `selector-max-specificity` README examples of the `ignoreSelectors` secondary option\nsee : URL \n\nThese tests are problematic for multiple reasons:\n- `:global` and `:local` are non-standard and it isn't defined what their specificity is.\n- `:global` and `:local` don't have any specificity of their own in `@csstools/selector-specificity`, so ignoring them to reduce their specificity seems weird?\n- `:global` and `:local` do not support selector lists in implementations\n - `lightningcss` errors\n - `postcss-modules` mangles the output (`:global(.page, .bar)` -> `.page .bar`)\n\nThey also dominate the implementation of `selector-max-specificity`.\n\nAs far as I can tell the `ignoreSelectors` was also created with css modules too much in mind.\nIt acts like a hole punch. The AST node that matches doesn't contribute to specificity, but its child nodes do. Which works really well for `:global` and `:local` because they happen to be removed during compilation.\n\nBut I am not sure if this makes sense for any case other than css modules.\nThere isn't any test coverage for other pseudo selectors with child nodes, so I can't tell what the exact intention was here.\n\n--------------\n\nProposal :\n- fix the tests so that `:global` and `:local` are used as supported by implementations\n- better define how `ignoreSelectors` works when it matches AST nodes with child nodes","author_login":"romainmenke","author_association":"MEMBER","created_at":"2024-01-24T18:20:19+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1909190324","fragment_type":"issue_comment","sequence":1,"text":"@romainmenke Thanks for the report. `ignoreSelectors` seemed to be added by PR #2874, quite a while ago (2017)! I'm honestly unsure about the background, but it seems a good opportunity to reconsider CSS Modules selectors (e.g. `:global`). 👍🏼 \n\nIn addition, thanks for trying `@csstools/selector-resolve-nested` with PR #7496!","author_login":"ybiquitous","author_association":"MEMBER","created_at":"2024-01-25T01:21:05+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1910122923","fragment_type":"issue_comment","sequence":2,"text":"Regressions or CSS modules compat are not really my primary concern here :)\n\nCSS modules are supported in `@csstools/selector-specificity` so there is nothing that needs to happen for that in Stylelint when calculating specificity.\n\nBut the test however write CSS for CSS modules that isn't correct.\nThis is just bogus : \n\ncss\n:global(.page, .bar)\n:global(.page, :local(.bar))\n\nBecause these are bogus we can safely assume that no user will be writing this and that changes won't cause regressions.\n\n--------------------\n\nAt the same time these test are the only coverage we have for `ignoreSelectors` in combination with functional pseudo classes.\n\nThere is no coverage with standard functional pseudo classes and `ignoreSelectors`.\n\nI don't know what the calculated specificity should be for these :\n\n- `ignoreSelectors` -> `:is`\n\ncss\n.foo :is(#bar, input) {} // [1, 1, 0] without ignore\n\nIs that :\n- `[0, 1, 0]` -> `:is` and all children are ignored\n- `[1, 1, 0]` -> only `:is` is ignored, but not its children\n\n`:is` already doesn't have any specificity of its own, it is as specific as its most specific argument.\n\nThe same is true for `:not`, `:has`, ...\n\n- is there a use case for ignoring only a functional pseudo class but not its children?\n- how do other ignore flags work? do they ignore the entire AST subtree?\n\n---------------\n\nThis is different from non-functional pseudo classes.\n\ncss\n.foo :focus {} // [0, 2, 0] without ignore\n\nIgnoring `:focus` does meaningfully affect specificity -> `[0, 1, 0]`","author_login":"romainmenke","author_association":"MEMBER","created_at":"2024-01-25T12:40:33+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1910155263","fragment_type":"issue_comment","sequence":3,"text":"Probably, I guess the following behavior would be correct: ⬇️ \n\n---\n\nGiven:\n\njson\n{\"ignoreSelectors\": [\":global\"]}\n\nThen:\n\ncss\n:global {} /* ignored */\n:global(.foo) {} /* not ignored */\n\n---\n\nGiven:\n\njson\n{\"ignoreSelectors\": [\"/:global\\(.+\\)/\"]}\n\nThen:\n\ncss\n:global {} /* not ignored */\n:global(.foo) {} /* ignored */","author_login":"ybiquitous","author_association":"MEMBER","created_at":"2024-01-25T12:55:47+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1910172016","fragment_type":"issue_comment","sequence":4,"text":"Would it be ok to remove the bogus tests and to replace them with tests for standard functional pseudo classes?\n\nThen at least there is coverage for the current implementation in a way that makes it clear what the expectations are.","author_login":"romainmenke","author_association":"MEMBER","created_at":"2024-01-25T12:59:17+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1910175718","fragment_type":"issue_comment","sequence":5,"text":"If I had to guess it was to cover a real use case; this seems reasonable to me.\n \n\nIf that's a documentation update please check #4105 as well.\n \n \n \n\nIf true, 👍","author_login":"Mouvedia","author_association":"CONTRIBUTOR","created_at":"2024-01-25T13:00:43+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[453495892],"is_known_query_context":false},{"document_id":"gh_comment_1913670092","fragment_type":"issue_comment","sequence":6,"text":"Our end goal is to modernise and make our behaviour around specificity and nesting spec-compliant, which will benefit the majority of our users.\n\nAs such, I think we can remove barriers that'll hamper us in achieving this for our next major release, including removing options that may no longer be relevant. \n\nI suggest we remove the `ignoreSelectors` option (and related tests) as part of URL It may well be that everyone's use case is covered by:\n \n\nIf not, a person can open a new issue with their use case, and we'll decide on the most modern way to cater to it.\n \n\nWe've typically avoided broad ignore options like `ignoreSelectors` because of these types of problems. We've had better success with more focused ignore options like:\n\n- `ignorePseudoClasses`\n- `ignoreContextFunctionalPseudoClasses`\n\nWe can reach for similar options to cater to specific use cases.","author_login":"jeddy3","author_association":"MEMBER","created_at":"2024-01-28T17:36:30+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1913816149","fragment_type":"issue_comment","sequence":7,"text":"I agree with replacing `ignoreSelectors` with more specific options. 👍🏼\n\nPerhaps, I assume that CSS Modules selectors like `:global` or `:local` might be used in most use cases of `ignoreSelectors`. As we can regard them as *functional pseudo classes*, providing `ignoreFunctionalPseudoClasses` instead of `ignoreSelectors` makes sense to me in order to keep compatibility as much as possible.\n\nE.g.\n\njson\n{\n \"selector-max-specificity\": [\"0,2,0\", {\"ignoreFunctionalPseudoClasses\": [\":global\", \":local\"]}]\n}\n\ncss\n.foo .bar.baz {} /* '0,3,0' => reported */\n\n:global(.foo) .bar.baz {} /* '0,2,0' => not reported */\n\nSo, I suggest the following steps:\n\n1. Deprecate `ignoreSelectors` with the next *minor* version (16.x.0)\n2. Add `ignoreFunctionalPseudoClasses` with the next *minor* version (16.x.0)\n3. Remove `ignoreSelectors` with the next *major* version (17.0.0)","author_login":"ybiquitous","author_association":"MEMBER","created_at":"2024-01-29T01:35:03+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915780628","fragment_type":"issue_comment","sequence":8,"text":"Sounds reasonable.\n\nIn the meantime\n \n\nshouldn't hinder that plan.\n@romainmenke Either emend, remove or replace the 6 tests that are affected; we can discuss the details in the PR.\n\n \n\nThe documentation update could be skipped since we are planning to replace it.","author_login":"Mouvedia","author_association":"CONTRIBUTOR","created_at":"2024-01-29T23:51:55+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105653373","fragment_type":"issue_comment","sequence":9,"text":"I've opened URL to fix this specific issue.\n\nI am aware that this is still labeled as `needs discussion` but I am hoping that showing the actual change illustrates the issue better and that we can move forward with this.\n\nIf this is not a change we want to make at this time, then that is fine aswel :)\n\n--------------\n\nDeprecating `ignoreSelectors` and adding `ignoreFunctionalPseudoClasses` can be separate issues?","author_login":"romainmenke","author_association":"MEMBER","created_at":"2024-05-11T09:33:37+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105670958","fragment_type":"issue_comment","sequence":10,"text":"If you fill them/it remember to add a task to #7396.\n \n\nIs this the only rule affected?\n`no-descending-specificity` has one test that uses `:global()`.","author_login":"Mouvedia","author_association":"CONTRIBUTOR","created_at":"2024-05-11T10:39:12+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105728204","fragment_type":"issue_comment","sequence":11,"text":"Ill repurpose this ticket so that it can be accepted.\ni.e. updating the tests is just a simple refactor and doesn't require a changeset","author_login":"Mouvedia","author_association":"CONTRIBUTOR","created_at":"2024-05-11T12:20:24+08:00","repo_name":"stylelint/stylelint","issue_id":2098837543,"issue_number":7495,"issue_url":"https://github.com/stylelint/stylelint/issues/7495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_453495892","fragment_type":"issue_description","sequence":0,"text":"Max Specificity Selector with Regex :not()\nI have a problem with Style Lint. I have set the selector-max-specificity at **0,2,0** with some ignored rules : `ignoreSelectors: [\":focus\", \":hover\", etc..]`\n\nNow, I want to ignore the `:not(.myClass)` selector but this doesn't work :(\n\nFor example i have my class with this name : **`.track a:not(.track-visual)`**\nI have tried with regex selector `\"/:not\\\\(.*\\\\)/\"` or even with `\"/.*:not\\\\(.*\\\\)/\"`\n\nFinally i saw this : URL but i haven't found a solution :'(\n\nIf you have a solution, i'm interested 😃 \nThank you","author_login":"Licoti","author_association":"NONE","created_at":"2019-06-07T12:46:45+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499872280","fragment_type":"issue_comment","sequence":1,"text":"Put your selector here URL and you can find what specify is 0,2,1","author_login":"evilebottnawi","author_association":"MEMBER","created_at":"2019-06-07T12:50:18+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499874004","fragment_type":"issue_comment","sequence":2,"text":"Maybe: `ignoreSelectors: [\":focus\", \":hover\", \"(.*):not\"]` ?","author_login":"evilebottnawi","author_association":"MEMBER","created_at":"2019-06-07T12:56:00+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499874661","fragment_type":"issue_comment","sequence":3,"text":"Also, try `\"/.*:not\\(.*\\)/\"`.\n\nIt's the matter of finding correct RegExp, which is out of scope for stylelint. I'm closing the issue.","author_login":"hudochenkov","author_association":"MEMBER","created_at":"2019-06-07T12:58:12+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499875124","fragment_type":"issue_comment","sequence":4,"text":"It is good problem about DX, maybe we should support `ignoreSelectors` in other way, i.e. using `:not` means ignore all selectors with not?","author_login":"evilebottnawi","author_association":"MEMBER","created_at":"2019-06-07T12:59:44+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499876791","fragment_type":"issue_comment","sequence":5,"text":"This change would affect every rule which accept RegExp as option.\n\nWe can update an example for `selector-max-specificity` to include `:not`.","author_login":"hudochenkov","author_association":"MEMBER","created_at":"2019-06-07T13:04:55+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499877825","fragment_type":"issue_comment","sequence":6,"text":"Thank you :)\n\n(Btw, i have also tested `\":not(.*)\"`, `\"/.*:not\\\\(.*\\\\)/\"`, `\"(.*):not\"`)","author_login":"Licoti","author_association":"NONE","created_at":"2019-06-07T13:08:14+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499878534","fragment_type":"issue_comment","sequence":7,"text":"Did you find the answer?\n\nIf you want to use RegExp, then it's always should be surrounded by `/`, e. g. `\"/.*/\"`.","author_login":"hudochenkov","author_association":"MEMBER","created_at":"2019-06-07T13:10:09+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_499881150","fragment_type":"issue_comment","sequence":8,"text":"No sorry, none of the regex works for the **:not()** even with `\":not(/.*/)\"`, `\"/.*:not\\\\(.*\\\\)/\"`, `\"(/.*/):not\"``\n\nActually i'm ignoring the attribute selector with this : \"/\\\\[.*\\\\]/\" and this work","author_login":"Licoti","author_association":"NONE","created_at":"2019-06-07T13:17:59+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2105731636","fragment_type":"issue_comment","sequence":9,"text":"I have repurposed this ticket in light of URL \nThe intended usage needs to be explicit.","author_login":"Mouvedia","author_association":"CONTRIBUTOR","created_at":"2024-05-11T12:35:00+08:00","repo_name":"stylelint/stylelint","issue_id":453495892,"issue_number":4105,"issue_url":"https://github.com/stylelint/stylelint/issues/4105","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0245","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"matrix-synapse doesn't start and crashes?","query_context":"### Describe the bug\n\nmatrix-synapse service keeps crashing since I updated it today. \n\n### Context\n\n- Hardware: Some Hetzner server. \n- YunoHost version: 11.2.5\n- I have access to my server: Through SSH | through the webadmin\n- Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no\n- Using, or trying to install package version/branch: using stable\n- If upgrading, current package version: Not applicable\n\n### Steps to reproduce\nmatrix-synapse crashes with the log below and restarts, this happens since I updates all apps (synapse was updated) an hour ago. \n\n### Expected behavior\n\nit used to run without any problem. \n\n### Logs\njournalctl\n\n### Remark\nI know this bug report is not very meaningful, sorry about that, not sure what else to write, please have a look in the log.","known_context_document_ids":["gh_issue_1952894787"],"reference_answer":"Logging to `/homeserver.log` by default doesn't seem ideal regardless. I'm not 100% sure where we should put the log file by default (I don't know what the standard practice for docker containers are), but I think we'd be happy to have a PR to change the defaults. We probably do want to make sure that any changes here are backwards compatible? I.e. we don't change the location for existing deployments?","answer_document_id":"gh_comment_840463888","silver_evidence_path":["gh_comment_1813074702","gh_issue_888554281","gh_comment_840463888"],"evidence_issue_ids":[1952894787,888554281],"source_repo_name":"YunoHost-Apps/synapse_ynh","source_issue_id":1952894787,"source_issue_number":420,"source_issue_url":"https://github.com/YunoHost-Apps/synapse_ynh/issues/420","target_repo_name":"matrix-org/synapse","target_issue_id":888554281,"target_issue_number":9970,"target_issue_url":"https://github.com/matrix-org/synapse/issues/9970","reference_anchor_document_id":"gh_comment_1813074702","reference_answer_author":"erikjohnston","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.375,"target_answer_overlap":0.1875},"issue_created_at":"2023-10-19T19:07:32+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_1952894787","fragment_type":"issue_description","sequence":0,"text":"matrix-synapse doesn't start and crashes\n### Describe the bug\n\nmatrix-synapse service keeps crashing since I updated it today. \n\n### Context\n\n- Hardware: Some Hetzner server. \n- YunoHost version: 11.2.5\n- I have access to my server: Through SSH | through the webadmin\n- Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no\n- Using, or trying to install package version/branch: using stable\n- If upgrading, current package version: Not applicable\n\n### Steps to reproduce\nmatrix-synapse crashes with the log below and restarts, this happens since I updates all apps (synapse was updated) an hour ago. \n\n### Expected behavior\n\nit used to run without any problem. \n\n### Logs\njournalctl\n\n### Remark\nI know this bug report is not very meaningful, sorry about that, not sure what else to write, please have a look in the log.","author_login":"utzer","author_association":"NONE","created_at":"2023-10-19T19:07:32+08:00","repo_name":"YunoHost-Apps/synapse_ynh","issue_id":1952894787,"issue_number":420,"issue_url":"https://github.com/YunoHost-Apps/synapse_ynh/issues/420","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1807092289","fragment_type":"issue_comment","sequence":1,"text":"Same problem, new log. \n\n URL \n\nIt is always a bit of a problem that there is almost never anyone with any ideas to solve problems in the Yunohost surrounding, I mean I tried the easy stuff, I played with the permissions of the log... but is seems the error comes regardless of he permission setting for the file/folder. \n\nIt's sad that Synapse server only worked for a few weeks and then after an update stopped working.","author_login":"utzer","author_association":"NONE","created_at":"2023-11-12T11:02:28+08:00","repo_name":"YunoHost-Apps/synapse_ynh","issue_id":1952894787,"issue_number":420,"issue_url":"https://github.com/YunoHost-Apps/synapse_ynh/issues/420","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1813074702","fragment_type":"issue_comment","sequence":2,"text":"Not logging to a file is my solution for now. \n\nuse this config in /etc/matrix-synapse/log.yaml","author_login":"utzer","author_association":"NONE","created_at":"2023-11-15T18:44:49+08:00","repo_name":"YunoHost-Apps/synapse_ynh","issue_id":1952894787,"issue_number":420,"issue_url":"https://github.com/YunoHost-Apps/synapse_ynh/issues/420","linked_issue_ids":[888554281],"is_known_query_context":false},{"document_id":"gh_comment_1824732763","fragment_type":"issue_comment","sequence":3,"text":"After the permission issues I played around with the permissions, I don't remember the permission when the crashes started. I tried some different combinations of user:group and some different permissions for the folder, the files... \n\nNow it is:\n\ndrw-rwx---+ 1 matrix-synapse root 88 Oct 19 20:58 ./\ndrwxr-xr-x 1 root root 3.6K Nov 19 00:00 ../\n-rw-rw----+ 1 matrix-synapse matrix-synapse 0 Oct 19 20:58 homeserver.log\n-rw-rw----+ 1 matrix-synapse root 24K Nov 22 20:21 turnserver.log\n-rw-rw----+ 1 matrix-synapse root 5.1K Oct 1 11:58 turnserver.log.1","author_login":"utzer","author_association":"NONE","created_at":"2023-11-23T17:01:29+08:00","repo_name":"YunoHost-Apps/synapse_ynh","issue_id":1952894787,"issue_number":420,"issue_url":"https://github.com/YunoHost-Apps/synapse_ynh/issues/420","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206754764","fragment_type":"issue_comment","sequence":4,"text":"Closing as it quite old and many change was made since this. Please reopen or create a new issue if the issue still appear.","author_login":"Josue-T","author_association":"NONE","created_at":"2024-07-03T16:30:14+08:00","repo_name":"YunoHost-Apps/synapse_ynh","issue_id":1952894787,"issue_number":420,"issue_url":"https://github.com/YunoHost-Apps/synapse_ynh/issues/420","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_888554281","fragment_type":"issue_description","sequence":0,"text":"Default generated logger config causes \"Permission denied: '/homeserver.log'\" for non-root containers\n### Description\n\nUsing `generate` to create config files with the Docker image sets the value of `handlers.file.filename` inside the `*.log.config` file to `/homeserver.log`, causing the following error when running the container as non-root:\n\nPermissionError: [Errno 13] Permission denied: '/homeserver.log'\n\nChanging it to `/data/homeserver.log` fixes the issue since the `synapse` user has write access to that folder. \n\nUnfortunately it's not enough to disable the `file` log `handler`. Even when disabled an empty log file is initially created. \n\n### Steps to reproduce\n\n- Create minimal config files with `generate`\n- Run container in non-root mode\n\n### Version information\n\nIf not matrix.org:\n\n- **Version**: v1.33.1\n\n- **Install method**: Docker Image\n\n- **Platform**: Kubernetes\n\n### Cause\n\nThe issue lies within how the log config is generated ( URL \n\npython\n def generate_files(self, config, config_dir_path):\n log_config = config.get(\"log_config\")\n if log_config and not os.path.exists(log_config):\n log_file = self.abspath(\"homeserver.log\")\n print(\n \"Generating log config file %s which will log to %s\"\n % (log_config, log_file)\n )\n with open(log_config, \"w\") as log_config_file:\n log_config_file.write(DEFAULT_LOG_CONFIG.substitute(log_file=log_file))\n\nwhich calls:\n\n@staticmethod\n def abspath(file_path):\n return os.path.abspath(file_path) if file_path else file_path\n\nSince the container runs `start.py` in `/`, the above resolves to `/homeserver.log`","author_login":"schnerring","author_association":"NONE","created_at":"2021-05-11T20:34:43+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_840172259","fragment_type":"issue_comment","sequence":1,"text":"Same problem. I've edited the logging strategy as-is to make it work : \n\n filename: /data/homeserver.log","author_login":"flavienbwk","author_association":"NONE","created_at":"2021-05-12T23:42:12+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_840463888","fragment_type":"issue_comment","sequence":2,"text":"Logging to `/homeserver.log` by default doesn't seem ideal regardless. I'm not 100% sure where we should put the log file by default (I don't know what the standard practice for docker containers are), but I think we'd be happy to have a PR to change the defaults. We probably do want to make sure that any changes here are backwards compatible? I.e. we don't change the location for existing deployments?","author_login":"erikjohnston","author_association":"MEMBER","created_at":"2021-05-13T10:18:07+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_840488986","fragment_type":"issue_comment","sequence":3,"text":"@erikjohnston Why don't you put it under `/data` (like all other persisted files)","author_login":"flavienbwk","author_association":"NONE","created_at":"2021-05-13T11:11:26+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_840658915","fragment_type":"issue_comment","sequence":4,"text":"@erikjohnston I think standard practice would be to only log to `console` since containers are ephemeral. Or if file logging is desired, log files would be written to an attached volume that was explicitly configured.\n\nCorrect me if I'm wrong, but backward compatibility shouldn't be affected since running in \"on-the-fly `generate` mode\" is no longer supported. So any existing deployments should have a working `handlers.file.filename` configuration that doesn't change when upgrading Synapse.\n\nI ran Synapse for the first time a couple of days ago and from reading the docs, I was under the impression that running Synapse as container would be done by running in \"generate mode\" only. So I tripped over the following:\n\n URL \n\nSo it's more about the first-time experience when initially generating the logger config. Typically when running Synapse as a container, the `synapse` user has write access to data and Synapse is also aware of that folder during `generate`:\n\n URL \n\nSo I think we have two options:\n\n1. `log_file = self.abspath(environ.get(\"SYNAPSE_DATA_DIR\", \"/data\") + \"/homeserver.log\")`\n2. Prevent the creation of an empty logging file, even if `file` logging is disabled and disable `file` logging by default\n\nI like 1) more.","author_login":"schnerring","author_association":"NONE","created_at":"2021-05-13T16:00:32+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_841646779","fragment_type":"issue_comment","sequence":5,"text":"I would also expect logging to be directed to stdout by default, as people generally rely on Docker's logging system rather than inspecting files in mounts.","author_login":"Half-Shot","author_association":"COLLABORATOR","created_at":"2021-05-15T11:59:12+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_843623767","fragment_type":"issue_comment","sequence":6,"text":"I'm going to peer out from behind my dunce's cap here and admit this one has me stumped. I'm new to docker and even newer to Matrix Synapse but I wanted to set up a small homeserver. At this stage of my knowledge, if the instructions don't explicitly work then I'm in a fix.\n\nI usually drop into the containers (?) via an interactive shelll and tinker but I can't do that from here.\n\nSorry to be so ignorant, but how do I get into a docker container thing to make these changes? Or is there some other way I can fire Synapse up without going through all that rigmarole?","author_login":"marcdraco","author_association":"NONE","created_at":"2021-05-18T23:05:25+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_844278201","fragment_type":"issue_comment","sequence":7,"text":"This currently breaks the installation of anyone trying to install Synapse the first time using Docker, could you please change the default to `/data/homeserver.log` until you have decided on a better approach?\n\nThis issue really requires a quick fix as the Synapse Docker guide currently does not work due to this problem.","author_login":"bluefireoly","author_association":"NONE","created_at":"2021-05-19T16:41:39+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_844493087","fragment_type":"issue_comment","sequence":8,"text":"Yep, I just went through the installation today and ran into this problem. I just disabled file logging completely since Docker catches the console output.","author_login":"satcom886","author_association":"NONE","created_at":"2021-05-19T21:39:26+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_844552733","fragment_type":"issue_comment","sequence":9,"text":"Haven't tested again but this also crashed my container because despite file logging disabled, an empty log file was created.","author_login":"schnerring","author_association":"NONE","created_at":"2021-05-19T22:59:36+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_845204756","fragment_type":"issue_comment","sequence":10,"text":"@schnerring i also didn't have luck disabling logs, but my work around was just to change the log file to /dev/null, and reduce the number of backups to 0. Works so far!","author_login":"Houndie","author_association":"NONE","created_at":"2021-05-20T15:07:44+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_845707802","fragment_type":"issue_comment","sequence":11,"text":"Hi all I have the same problem.\nHow can I disable logging.\nI am a newbie in docker.","author_login":"fertigfs","author_association":"NONE","created_at":"2021-05-21T06:57:02+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_845834214","fragment_type":"issue_comment","sequence":12,"text":"The log settings should be in `/data/SERVERNAME.log.config`. If you copy my log config from my previous comment, it should completely disable logging to a file.","author_login":"satcom886","author_association":"NONE","created_at":"2021-05-21T09:55:42+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_845884317","fragment_type":"issue_comment","sequence":13,"text":"Ok its working thank you.\nIs it possible to use the nginx proxy manager container for another lxc containers outside of docker in my local lan","author_login":"fertigfs","author_association":"NONE","created_at":"2021-05-21T11:27:57+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_845888962","fragment_type":"issue_comment","sequence":14,"text":"That I don't know, I also don't think it's appropriate to discuss this here.","author_login":"satcom886","author_association":"NONE","created_at":"2021-05-21T11:36:46+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_847211348","fragment_type":"issue_comment","sequence":15,"text":"I'm very confused. I thought this *was* the default, per URL","author_login":"richvdh","author_association":"MEMBER","created_at":"2021-05-24T17:28:13+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_847217643","fragment_type":"issue_comment","sequence":16,"text":"ok I see. The problem is that the `file` handler is being created even though it's not enabled.\n\nThis seems to have been introduced by #9162, which landed in Synapse 1.33.0.","author_login":"richvdh","author_association":"MEMBER","created_at":"2021-05-24T17:39:53+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_847219359","fragment_type":"issue_comment","sequence":17,"text":"@schnerring wrote:\n \n\nThis appears to be incorrect - or if it's correct, it's a different problem to what everybody else is talking about. When running with `docker run matrixdotorg/synapse:latest generated`, the log config is generated by `docker/start.py`, not Synapse itself.","author_login":"richvdh","author_association":"MEMBER","created_at":"2021-05-24T17:43:11+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1295160620","fragment_type":"issue_comment","sequence":18,"text":"i have also have this problem \n\n`\nversion: '2.3'\nservices:\n postgres:\n image: postgres:14\n restart: unless-stopped\n networks:\n default:\n ipv4_address: 10.10.10.2\n volumes:\n - ./postgresdata:/var/lib/postgresql/data\n\n # These will be used in homeserver.yaml later on\n environment:\n - POSTGRES_DB=synapse\n - POSTGRES_USER=synapse\n - POSTGRES_PASSWORD=.........\n \n element:\n image: vectorim/element-web:latest\n restart: unless-stopped\n volumes:\n - ./element-config.json:/app/config.json\n networks:\n default:\n ipv4_address: 10.10.10.3\n \n synapse:\n image: matrixdotorg/synapse:latest\n restart: unless-stopped\n networks:\n default:\n ipv4_address: 10.10.10.4\n volumes:\n - ./synapse:/data\n\nnetworks:\n default:\n external:\n name: matrix_net\n`","author_login":"appdroidbuilder","author_association":"NONE","created_at":"2022-10-28T15:49:45+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1305519908","fragment_type":"issue_comment","sequence":19,"text":"@appdroidbuilder @pReya Can you please post the error message you are seeing and the Synapse version number?","author_login":"squahtx","author_association":"MEMBER","created_at":"2022-11-07T12:14:04+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1344149991","fragment_type":"issue_comment","sequence":20,"text":"I don't see how this issue is still happening as-is and no recent reporters have stepped up to say what error message is appearing or what version of Synapse is in use, so I'll close this for now. If you have details, please ask to reopen or file a new issue linking to this one.","author_login":"reivilibre","author_association":"CONTRIBUTOR","created_at":"2022-12-09T10:52:11+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1378008834","fragment_type":"issue_comment","sequence":21,"text":"People may have copied the old homeserver.yaml after changing their server_name instead of generating a new homeserver.yaml? At least that's what I did. \n\nThen log_config line must correspond to this new server_name, otherwise it will create a default log_config file and that'll have the offending configuration `filename: /homeserver.log` in it which obviously causes the permission denied error. \n\nThat was my problem anyway, entirely user error I'd say. Or generally the synapse configuration is not \"forgiving\" or fool-proof :D","author_login":"plantroon","author_association":"NONE","created_at":"2023-01-10T23:03:47+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1500883346","fragment_type":"issue_comment","sequence":22,"text":"**Check your log config location thoroughly if you get the permission denied error!**\n\nWell, I fell into a very similar trap while following a tutorial on \"Install Matrix Home Server On Kubernetes\" by Vincze Janos. I didn't correct the path of the log config in `homeserver.yaml` when moving the configuration to another directory (to `/config` instead of `/data`). Synapse was then not able to find the logging config file, and silently used a default configuration, which included a file handler trying to go to `/homeserver.log`, causing the same symptom as the initial description of this issue, but from quite a different cause (misconfiguration by the user, not a badly generated config file).","author_login":"m-emm","author_association":"NONE","created_at":"2023-04-08T12:36:54+08:00","repo_name":"matrix-org/synapse","issue_id":888554281,"issue_number":9970,"issue_url":"https://github.com/matrix-org/synapse/issues/9970","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0247","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Replace Coptic example at embed.openhistoricalmap.org?","query_context":"**Bug description**\nThe README provides a link where I can \"see Roman Egypt labeled in Copt\". I don't know quite what to expect but when I click on that link I see labels in English and in what I take to be an Arabic script. I do expect that, if I remove `&language=cop` from ` URL the rendering should be different but the map appears the same.","known_context_document_ids":["gh_issue_3049954636"],"reference_answer":"For now, a threshold of 50 may be necessary, but I think we would indeed want to eventually support languages with fewer features, if only because some regionally significant indigenous languages don’t have many features in the native name. I’d also expect ancient languages such as Sumerian and Phoenician to be represented by very few but very significant features. However, we can defer that consideration until we find an alternative solution that doesn’t incur a performance penalty per language. Once we implement bilingual labeling in #799, this will become somewhat less of an issue, because we’d once again expose many of these names via `name=*` anyways.","answer_document_id":"gh_comment_2591500299","silver_evidence_path":["gh_comment_2874311407","gh_issue_2778328973","gh_comment_2591500299"],"evidence_issue_ids":[3049954636,2778328973],"source_repo_name":"OpenHistoricalMap/issues","source_issue_id":3049954636,"source_issue_number":1048,"source_issue_url":"https://github.com/OpenHistoricalMap/issues/issues/1048","target_repo_name":"OpenHistoricalMap/issues","target_issue_id":2778328973,"target_issue_number":948,"target_issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","reference_anchor_document_id":"gh_comment_2874311407","reference_answer_author":"1ec5","reference_answer_author_association":"MEMBER","quality_score":94.57,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.2222,"target_answer_overlap":0.0714},"issue_created_at":"2025-05-08T19:54:10+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_3049954636","fragment_type":"issue_description","sequence":0,"text":"Replace Coptic example at embed.openhistoricalmap.org\n**Bug description**\nThe README provides a link where I can \"see Roman Egypt labeled in Copt\". I don't know quite what to expect but when I click on that link I see labels in English and in what I take to be an Arabic script. I do expect that, if I remove `&language=cop` from ` URL the rendering should be different but the map appears the same.","author_login":"erictheise","author_association":"MEMBER","created_at":"2025-05-08T19:54:10+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":3049954636,"issue_number":1048,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/1048","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2873354580","fragment_type":"issue_comment","sequence":1,"text":"Due to performance issues, we are currently querying only the languages that have more than 500 objects in the database. However, there are many more languages present. For now, it’s fine to test with other examples, but in the future, I think it would be better to extract all languages into a materialized view for the vtiles.\\, because Querying directly with tags -> 'name:xx' is currently expensive for the database.","author_login":"Rub21","author_association":"MEMBER","created_at":"2025-05-12T17:16:06+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":3049954636,"issue_number":1048,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2874311407","fragment_type":"issue_comment","sequence":2,"text":"Don't worry about it, @Rub21, I'll figure out the answer from the json output described at URL","author_login":"erictheise","author_association":"MEMBER","created_at":"2025-05-12T22:07:42+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":3049954636,"issue_number":1048,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/1048","linked_issue_ids":[2778328973],"is_known_query_context":false},{"document_id":"gh_comment_2887864436","fragment_type":"issue_comment","sequence":3,"text":"OpenHistoricalMap/openhistoricalmap-embed@8b1adab8294c6dce5f0f4fbbd26c31b23c6b5a33 replaces the example with one that currently works (Middle Babylon in Ancient Greek and Latin instead of cuneiform). #1059 tracks restoring Copt and other rarely tagged languages.","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-05-17T00:01:38+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":3049954636,"issue_number":1048,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/1048","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2778328973","fragment_type":"issue_description","sequence":0,"text":"Optimize vector tiles by selecting the most common languages\nFrom, URL \n\nCurrently, vector tiles are configured to display all the languages listed in the languages.sql file, which includes approximately 411 languages. During a tile request, the SELECT query, adds these language parameters to search the hstore column in the database tables.\n\nWhile this setup works, but querying such a large number of languages can sometimes slow down the tiler . I propose selecting only the most commonly used languages from the database to include in the vector tiles.\n\nTo achieve this, we can analyze data from Taginfo to identify the most frequently used languages or, at the very least, obtain recommendations for the most relevant languages.\n\ne.g:\n\n- `name:fr` URL 1 997 objects\n- `name:alq` URL 0 objects\n\ncc. @1ec5 @danrademacher","author_login":"Rub21","author_association":"MEMBER","created_at":"2025-01-09T16:58:24+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2581376373","fragment_type":"issue_comment","sequence":1,"text":"Certainly we should eliminate any language for which there are 0 objects. Is there a quick way to at least test for that?","author_login":"danrademacher","author_association":"MEMBER","created_at":"2025-01-09T22:37:25+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585538090","fragment_type":"issue_comment","sequence":2,"text":"Until we finish exposing localized labels to end users (#481), mappers have little incentive to add localized names, so we can’t place too much stock in usage figures yet.\n\n`name:alq` (Algonquin) was implemented in URL because it’s documented on the wiki. Someone went through a long time ago documenting all the valid language codes that were being used in OSM, no matter how rare. Taginfo shows that OHM has a somewhat different language coverage distribution. Essentially, our focus on history means we have more coverage of classical and extinct languages, and we should expect to have more indigenous language coverage as time goes on. We want to support indigenous languages especially _because of_ their rarity as minority languages.\n\nI think it would be OK to prune unused keys as a temporary performance optimization. However, long-term, we’ll need to figure out a more scalable solution for processing these language keys.","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-01-12T01:43:39+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587674208","fragment_type":"issue_comment","sequence":3,"text":"I wrote a small script to filter languages that exist in TagInfo. From the entire list in the file languages.sql, which contains 411 languages, I found 93 languages with names. However, I don’t think this is the best approach because I discovered other languages in TagInfo with a large number of objects that are not reflected in our current list. For example:\n\n- `name:zh_pinyin` have 5220 objects: URL This language is not currently included in the list of languages we have in the vtiles, but it seems it needs to be added because of the large number of objects.\n\nSo, I think the best approach is to list the languages from TagInfo to display the names in the vtiles. However, in some cases, the keys are a bit messy (with messy i men that names include dates, sone random string in some cases).e.g 👇 , but i think those can be filtered. \n\nimage","author_login":"Rub21","author_association":"NONE","created_at":"2025-01-13T16:59:35+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2587831115","fragment_type":"issue_comment","sequence":4,"text":"`name:zh_pinyin=*` was deprecated several years ago in favor of `name:zh-Latn-CN-pinyin=*`, per the ISO standard.","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-01-13T18:05:14+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2589740940","fragment_type":"issue_comment","sequence":5,"text":"With cleaning , Do you mean change all the objects that has `name:zh_pinyin=* to `name:zh-Latn-CN-pinyin=*` , cleaning that should posible and easy. do you think that should be done by the team or someone from the community?","author_login":"Rub21","author_association":"NONE","created_at":"2025-01-14T12:05:44+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2590648154","fragment_type":"issue_comment","sequence":6,"text":"@1ec5 to provide a regex for selecting valid language labels, and we can use that to select valid name keys.\n\nBut what about the long tail of languages that happen once in the whole world.","author_login":"danrademacher","author_association":"MEMBER","created_at":"2025-01-14T17:31:21+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2590852091","fragment_type":"issue_comment","sequence":7,"text":"Doesn’t matter, feel free to make the change, or one of us can post in the forum to ask for help.\n \n\nThe regular expression implemented in Planetiler should be valid in PostgresQL too. Note that this regular expression is case-sensitive.\n\n/ref onthegomap/planetiler#147 onthegomap/planetiler#1115 onthegomap/planetiler#1117","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-01-14T18:46:14+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2591489562","fragment_type":"issue_comment","sequence":8,"text":"@1ec5 The Regex `\"^name:[a-z]{2,3}(-[A-Z][a-z]{3})?(-_?[a-z]{2,})?(-([A-Z]{2}|\\\\d{3}))?$\"` works very well, I was eable to filter the followinf number of languages:\n\n- 431 languages were filtered for the vector-tiler, each having at least 1 object (node, way, or relation).\n- 264 languages were filtered for the vector-tiler, each having at least 5 object (node, way, or relation). \n- 214 languages were filtered for the vector-tiler, each having at least 10 object (node, way, or relation). \n- 120 languages were filtered for the vector-tiler, each having at least 50 object (node, way, or relation). \n- 94 languages were filtered for the vector-tiler, each having at least 10 object (node, way, or relation). \n\nI think we can consider the 120 languages where the minimum number of objects required to appear is more than 50. Even 10 might work, but 1 seems too detailed.","author_login":"Rub21","author_association":"NONE","created_at":"2025-01-15T02:13:01+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2591500299","fragment_type":"issue_comment","sequence":9,"text":"For now, a threshold of 50 may be necessary, but I think we would indeed want to eventually support languages with fewer features, if only because some regionally significant indigenous languages don’t have many features in the native name. I’d also expect ancient languages such as Sumerian and Phoenician to be represented by very few but very significant features. However, we can defer that consideration until we find an alternative solution that doesn’t incur a performance penalty per language. Once we implement bilingual labeling in #799, this will become somewhat less of an issue, because we’d once again expose many of these names via `name=*` anyways.","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-01-15T02:23:40+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2593408008","fragment_type":"issue_comment","sequence":10,"text":"Did you apply the regular expression above? I still see the deprecated keys `name:zh_pinyin`, `name:ja_rm`, and `name:ja_kana` in URL","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-01-15T16:37:20+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2596600963","fragment_type":"issue_comment","sequence":11,"text":"If the issue is with the underscore in names, since those are not considered valid, we can update the regex to something like:\n \n`^name:[a-z]{2,3}(-[A-Z][a-z]{3})?((-[a-z]{2,}|x-[a-z]{2,})(-[a-z]{2,})?)?(-([A-Z]{2}|\\d{3}))?$` the result looks like 👉 URL","author_login":"Rub21","author_association":"NONE","created_at":"2025-01-16T19:15:35+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2596869972","fragment_type":"issue_comment","sequence":12,"text":"Yes, that looks fine to me. Besides, these are all codes for romanizations and transliterations, which are more appropriate for geocoding than for rendering.","author_login":"1ec5","author_association":"MEMBER","created_at":"2025-01-16T20:54:42+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2611096848","fragment_type":"issue_comment","sequence":13,"text":"According to this the languages is requesting from taginfo , we may need to run updates in the tiler query every month to retrieve the languages. Since we are currently evaluating the number of objects that have a name:* tag, we might also need to implement a mechanism to automatically request new languages. For now, I am going to close this ticket.","author_login":"Rub21","author_association":"NONE","created_at":"2025-01-23T21:55:04+08:00","repo_name":"OpenHistoricalMap/issues","issue_id":2778328973,"issue_number":948,"issue_url":"https://github.com/OpenHistoricalMap/issues/issues/948","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0248","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"OpenGL: Transition glitched on NVIDIA GPUs (Proprietary Driver)?","query_context":"On an NVIDIA GPU, the transition effect looks glitched with the OpenGL 1.5 and OpenGL ES 2.0 renderers\n\n URL \n\nOS: Arch Linux (6.12.34-1-lts)\nCPU: AMD FX-4300 (Yes I know this CPU is terrible)\nGPU: NVIDIA RTX 3050 8GB (nvidia-lts 575.64)","known_context_document_ids":["gh_issue_3176675341"],"reference_answer":"Here was my effort, but since I'm not on Windows configuring things wasn't easy. URL","answer_document_id":"gh_comment_3025969343","silver_evidence_path":["gh_comment_3034578778","gh_issue_3158575874","gh_comment_3025969343"],"evidence_issue_ids":[3176675341,3158575874],"source_repo_name":"isledecomp/isle-portable","source_issue_id":3176675341,"source_issue_number":430,"source_issue_url":"https://github.com/isledecomp/isle-portable/issues/430","target_repo_name":"isledecomp/isle-portable","target_issue_id":3158575874,"target_issue_number":337,"target_issue_url":"https://github.com/isledecomp/isle-portable/issues/337","reference_anchor_document_id":"gh_comment_3034578778","reference_answer_author":"AJenbo","reference_answer_author_association":"COLLABORATOR","quality_score":86.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.25,"target_answer_overlap":0.25},"issue_created_at":"2025-06-25T19:05:00+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_3176675341","fragment_type":"issue_description","sequence":0,"text":"OpenGL: Transition glitched on NVIDIA GPUs (Proprietary Driver)\nOn an NVIDIA GPU, the transition effect looks glitched with the OpenGL 1.5 and OpenGL ES 2.0 renderers\n\n URL \n\nOS: Arch Linux (6.12.34-1-lts)\nCPU: AMD FX-4300 (Yes I know this CPU is terrible)\nGPU: NVIDIA RTX 3050 8GB (nvidia-lts 575.64)","author_login":"StevenSYS","author_association":"CONTRIBUTOR","created_at":"2025-06-25T19:05:00+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3005868917","fragment_type":"issue_comment","sequence":1,"text":"As best I can tell this happens because it is presenting the back buffer without waiting for a call to `SDL_GL_SwapWindow()`. If you remove the m_dirty guard you get the same effect on other system. This could be because double buffering is disabled at a driver level but I'm not sure.\n\ncpp\nvoid OpenGL1Renderer::Flip()\n{\n if (m_dirty) {\n SDL_GL_SwapWindow(DDWindow);\n m_dirty = false;\n }\n}\n\nDoes this also happen in windowed mode? It would be good if someone on Windows can also test this.","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-06-25T19:14:15+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3009848878","fragment_type":"issue_comment","sequence":2,"text":"Also happening on AMD.\n\nGPU0:\n apiVersion = 1.4.305\n driverVersion = 25.0.5\n vendorID = 0x1002\n deviceID = 0x73df\n deviceType = PHYSICAL_DEVICE_TYPE_DISCRETE_GPU\n deviceName = AMD Radeon RX 6750 XT (RADV NAVI22)\n driverID = DRIVER_ID_MESA_RADV\n driverName = radv\n driverInfo = Mesa 25.0.5-2\n conformanceVersion = 1.4.0.0\n deviceUUID = 00000000-0800-0000-0000-000000000000\n driverUUID = 414d442d-4d45-5341-2d44-525600000000\n\n URL","author_login":"kernaltrap8","author_association":"NONE","created_at":"2025-06-26T20:19:36+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3012796918","fragment_type":"issue_comment","sequence":3,"text":"Interesting since it's not happening on Radeon 7800xt using radv","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-06-27T12:08:29+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3016157539","fragment_type":"issue_comment","sequence":4,"text":"Transition works perfectly on SDL3_GPU and Miniwin (software) emulation, so must be an issue with ogl shaders (if that is in fact how the transition works, I need to look)","author_login":"kernaltrap8","author_association":"NONE","created_at":"2025-06-28T23:52:32+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3016326428","fragment_type":"issue_comment","sequence":5,"text":"like the title says this is specific to OpenGL and only on some systems. It requires read back and controlled double buffering.","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-06-29T05:39:23+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3033939394","fragment_type":"issue_comment","sequence":6,"text":"The OpenGL 1.1 HAL is completely missing now in c63d725 with the same compiler setup on macOS.\n\n \n \n\nOr it just never worked because the mingw-w64-x86_64-freeglut and mingw-w64-x86_64-glew packages aren't pulled for the Windows builds by the Github Action.","author_login":"aroenai","author_association":"NONE","created_at":"2025-07-03T23:31:16+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3034578778","fragment_type":"issue_comment","sequence":7,"text":"Yes that's why I created this issue: URL , since I don't have Windows I'm not able to solve it. please keep comments .","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-07-04T05:24:21+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[3158575874],"is_known_query_context":false},{"document_id":"gh_comment_3040956649","fragment_type":"issue_comment","sequence":8,"text":"This should now be solved, please let us know if the issue persist in the new builds.","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-07-06T05:34:03+08:00","repo_name":"isledecomp/isle-portable","issue_id":3176675341,"issue_number":430,"issue_url":"https://github.com/isledecomp/isle-portable/issues/430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3158575874","fragment_type":"issue_description","sequence":0,"text":"Build config.exe in CI/Release\nThe config application is not build for Windows during CI/Release. You can use URL to get it building, but I'm not sure how to get CPack to add the used .dll files included in the zip it creates.","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-06-19T01:14:58+08:00","repo_name":"isledecomp/isle-portable","issue_id":3158575874,"issue_number":337,"issue_url":"https://github.com/isledecomp/isle-portable/issues/337","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3025969343","fragment_type":"issue_comment","sequence":1,"text":"Here was my effort, but since I'm not on Windows configuring things wasn't easy. URL","author_login":"AJenbo","author_association":"COLLABORATOR","created_at":"2025-07-02T01:01:24+08:00","repo_name":"isledecomp/isle-portable","issue_id":3158575874,"issue_number":337,"issue_url":"https://github.com/isledecomp/isle-portable/issues/337","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3027998222","fragment_type":"issue_comment","sequence":2,"text":"Worth bumping this, considering Windows is probably the platform most in need of the config tool.","author_login":"VoxelTek","author_association":"CONTRIBUTOR","created_at":"2025-07-02T14:00:42+08:00","repo_name":"isledecomp/isle-portable","issue_id":3158575874,"issue_number":337,"issue_url":"https://github.com/isledecomp/isle-portable/issues/337","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3034699509","fragment_type":"issue_comment","sequence":3,"text":"I got it building with the dlls at least on the msvc 64 bit ver: #520","author_login":"BagelSketches","author_association":"NONE","created_at":"2025-07-04T06:34:23+08:00","repo_name":"isledecomp/isle-portable","issue_id":3158575874,"issue_number":337,"issue_url":"https://github.com/isledecomp/isle-portable/issues/337","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0249","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Question: Dealing with filenames containing newlines?","query_context":"Cheers. I'm trying to use rhash to verify correct copies of various backup data (home folders with AppData, old saved webpages etc) which for one reason or another contain files with newlines in the middle. Is there a recommended way of dealing with these filenames? As in, how to create a sum file that will subsequently verify these files.\n\nMy first thought was to use `--printf` to replicate the oft-used `-0` switch from `find` and many other tools, but if I'm reading the manual correctly, rhash isn't actually able to process sum files created with the printf option. Is there some other way?","known_context_document_ids":["gh_issue_1106264470"],"reference_answer":"The feature is supported by commits: 5ab59ef592826f91b59484a86072cc35b2e8d699, 357e7d37961f589278159cc9bff6fe9369cf4db7.","answer_document_id":"gh_comment_1258000802","silver_evidence_path":["gh_comment_1017261302","gh_issue_523535126","gh_comment_1258000802"],"evidence_issue_ids":[1106264470,523535126],"source_repo_name":"rhash/RHash","source_issue_id":1106264470,"source_issue_number":191,"source_issue_url":"https://github.com/rhash/RHash/issues/191","target_repo_name":"rhash/RHash","target_issue_id":523535126,"target_issue_number":97,"target_issue_url":"https://github.com/rhash/RHash/issues/97","reference_anchor_document_id":"gh_comment_1017261302","reference_answer_author":"rhash","reference_answer_author_association":"OWNER","quality_score":80.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1379,"anchor_target_overlap":0.0667,"target_answer_overlap":0.0},"issue_created_at":"2022-01-17T21:13:54+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1106264470","fragment_type":"issue_description","sequence":0,"text":"Question: Dealing with filenames containing newlines?\nCheers. I'm trying to use rhash to verify correct copies of various backup data (home folders with AppData, old saved webpages etc) which for one reason or another contain files with newlines in the middle. Is there a recommended way of dealing with these filenames? As in, how to create a sum file that will subsequently verify these files.\n\nMy first thought was to use `--printf` to replicate the oft-used `-0` switch from `find` and many other tools, but if I'm reading the manual correctly, rhash isn't actually able to process sum files created with the printf option. Is there some other way?","author_login":"myxal","author_association":"NONE","created_at":"2022-01-17T21:13:54+08:00","repo_name":"rhash/RHash","issue_id":1106264470,"issue_number":191,"issue_url":"https://github.com/rhash/RHash/issues/191","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1017261302","fragment_type":"issue_comment","sequence":1,"text":"Hello. As I understand your OS is Windows.\nCould you describe steps to create such files, to reproduce the situation?\n\nThere is a FR #97 to support special symbols in the filenames, and it is partly implemented (only verification part) by 757942e2d68c4527d37b8a6310d2dbf781d9225b.\nBut, unitl now, I thought that the problem was only Linux/Unix-related.\nTo support Windows, we need a corresponding test-case.","author_login":"rhash","author_association":"OWNER","created_at":"2022-01-20T09:10:35+08:00","repo_name":"rhash/RHash","issue_id":1106264470,"issue_number":191,"issue_url":"https://github.com/rhash/RHash/issues/191","linked_issue_ids":[523535126],"is_known_query_context":false},{"document_id":"gh_comment_1017296542","fragment_type":"issue_comment","sequence":2,"text":"No, actually. Oh, was it my reference to \"AppData\"? Sorry for the confusion, I use \"AppData\" as a shorthand for \"any files created by applications after installation, and not explicitly named/saved by the user, regardless of OS\" - savegames, browser profiles, logs, etc. The files in question were indeed created on Linux, by Google Earth, going by the paths. Don't take that as repro step, these are >10 year old backups and I no longer use Linux on the desktop to know/check if this behaviour still exists.\n\nAs for windows, though - IIRC NTFS drivers on Linux (ntfs-3g?) do not enforce Windows-style filename restrictions, which actually originate in the API (Win32?), not in the filesystem spec. So I think it would be possible to encounter such a file on windows after creating it in Linux. This is just a guess, though.","author_login":"myxal","author_association":"NONE","created_at":"2022-01-20T09:51:00+08:00","repo_name":"rhash/RHash","issue_id":1106264470,"issue_number":191,"issue_url":"https://github.com/rhash/RHash/issues/191","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_523535126","fragment_type":"issue_description","sequence":0,"text":"rhash does not handle special characters.\nrhash will break checking on special characters in linux.\n\nnone\n$ touch 'd'$'\\n''e' 'd'$'\\r''e'","author_login":"bac0n","author_association":"NONE","created_at":"2019-11-15T15:29:24+08:00","repo_name":"rhash/RHash","issue_id":523535126,"issue_number":97,"issue_url":"https://github.com/rhash/RHash/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_561380372","fragment_type":"issue_comment","sequence":1,"text":"Thanks for reporitng the problem. The bug is reconfirmed.\n\nRHash fails to verify 'd'$'\\n''e', although successfully verifies 'd'$'\\r''e' on Linux. Also filenames in verification results and errors are displayed unescaped:\n~~~sh\n$ rhash -M 'd'$'\\n''e' | rhash -Mc -\n\n--( Verifying (stdin) )---------------------------------------------------------\nd No such file or directory\nRHash: can't parse line: e\n--------------------------------------------------------------------------------\nErrors Occurred: Errors:0 Miss:1 Success:0 Total:1\n\n$ rhash -M 'd'$'\\r''e' | rhash -Mc -\n\n--( Verifying (stdin) )---------------------------------------------------------\ne OK\n--------------------------------------------------------------------------------\nEverything OK\n~~~\n\nWhile GNU utilities work:\n~~~sh\n$ for s in b2sum md5sum sha1sum sha256sum sha512sum; do echo $s; $s d*e > hash; $s -c hash; done\nb2sum\n\\d\\ne: OK\ne: OK\nmd5sum\n\\d\\ne: OK\ne: OK\nsha1sum\n\\d\\ne: OK\ne: OK\nsha256sum\n\\d\\ne: OK\ne: OK\nsha512sum\n\\d\\ne: OK\ne: OK\n~~~\n\nThere exists a related problem with filenames containing backslash, since when RHash finds a backslash in a hash file it decides that hash file is generated on Windows and treats backslash as a path separator.\n\nSome supported by RHash hash formats allow to deal with this, since Windows paths forbid special characters (backslash and characters with codes from 0 to 31). So an escaped line can be generated only on Linux and backslash shall be treated as a path separator only in unescaped lines.\n\nMagnet and Ed2k links contains urlencoded filename and there is no way to differ Windows and Linux backslashes. At last BSD format also should be checked if it can handle special characters.\n\nDue to the problem complexity, the fix should not be expected in the nearest time.","author_login":"rhash","author_association":"OWNER","created_at":"2019-12-03T22:11:05+08:00","repo_name":"rhash/RHash","issue_id":523535126,"issue_number":97,"issue_url":"https://github.com/rhash/RHash/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_563379492","fragment_type":"issue_comment","sequence":2,"text":"Regading supported by RHash **BSD format**. FreeBSD UFS allows any characters in filenames except NUL.\n\nOriginal BSD utilities sha1, sha256, sha512 (tested on OpenBSD) are broken for character '\\n':\n~~~sh\n$ touch \"$(printf 'a\\re')\" \"$(printf 'a\\ne')\"\n$ sha512 a*e >hash.sha512\n$ sha1 a*e >hash.sha1\n$ sha1 -c hash.sha1\nsha1: cannot open = da39a3ee5e6b4b0d3255bfef95601890afd80709: No such file or directory\n(SHA1) = da39a3ee5e6b4b0d3255bfef95601890afd80709: MISSING\ne: OK) a\n$ sha512 -c hash.sha512\nsha512: cannot open = cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e: No such file or directory\n(SHA512) = cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e: MISSING\ne: OK12) a\n~~~\nAs expected, filenames are also not escaped when errors are reported.\n\nBut GNU utilities md5sum, sha1sum, ... support BSD format with special characters escaping extension:","author_login":"rhash","author_association":"OWNER","created_at":"2019-12-09T18:55:04+08:00","repo_name":"rhash/RHash","issue_id":523535126,"issue_number":97,"issue_url":"https://github.com/rhash/RHash/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_782927377","fragment_type":"issue_comment","sequence":3,"text":"Changing issue to 'Feature Request', since this case is complicated and is nether correctly handled by *BSD native hashing utilities.","author_login":"rhash","author_association":"OWNER","created_at":"2021-02-21T21:11:57+08:00","repo_name":"rhash/RHash","issue_id":523535126,"issue_number":97,"issue_url":"https://github.com/rhash/RHash/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1258000802","fragment_type":"issue_comment","sequence":4,"text":"The feature is supported by commits: 5ab59ef592826f91b59484a86072cc35b2e8d699, 357e7d37961f589278159cc9bff6fe9369cf4db7.","author_login":"rhash","author_association":"OWNER","created_at":"2022-09-26T12:56:46+08:00","repo_name":"rhash/RHash","issue_id":523535126,"issue_number":97,"issue_url":"https://github.com/rhash/RHash/issues/97","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0250","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Playing a `StreamingSoundData` intermittently plays a scratchy, sped-up version of the sound?","query_context":"I tried playing this audio file as a `StreamingSoundData` with a loop point of 7.0. Occasionally, this would work, but sometimes, it would come out as a scratchy mess:\n\n URL \n\nUpon closer inspection, this seems to be a sped up version of the track. Sometimes this issue would correct itself at the loop point, but occasionally, it continues forever.\n\nThus far, I've only been able to reproduce this issue in debug builds (with optimized dependencies). Release builds seem to be unaffected.","known_context_document_ids":["gh_issue_1490327041"],"reference_answer":"I went ahead and released v0.1.2, so this should be fixed now. Let me know if you have any more issues.","answer_document_id":"gh_comment_739115450","silver_evidence_path":["gh_comment_1347031682","gh_issue_753387912","gh_comment_739115450"],"evidence_issue_ids":[1490327041,753387912],"source_repo_name":"tesselode/kira","source_issue_id":1490327041,"source_issue_number":36,"source_issue_url":"https://github.com/tesselode/kira/issues/36","target_repo_name":"tesselode/kira","target_issue_id":753387912,"target_issue_number":1,"target_issue_url":"https://github.com/tesselode/kira/issues/1","reference_anchor_document_id":"gh_comment_1347031682","reference_answer_author":"tesselode","reference_answer_author_association":"OWNER","quality_score":93.73,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.119,"anchor_target_overlap":0.0741,"target_answer_overlap":0.0909},"issue_created_at":"2022-12-11T18:50:11+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1490327041","fragment_type":"issue_description","sequence":0,"text":"Playing a `StreamingSoundData` intermittently plays a scratchy, sped-up version of the sound\nI tried playing this audio file as a `StreamingSoundData` with a loop point of 7.0. Occasionally, this would work, but sometimes, it would come out as a scratchy mess:\n\n URL \n\nUpon closer inspection, this seems to be a sped up version of the track. Sometimes this issue would correct itself at the loop point, but occasionally, it continues forever.\n\nThus far, I've only been able to reproduce this issue in debug builds (with optimized dependencies). Release builds seem to be unaffected.","author_login":"PatchMixolydic","author_association":"NONE","created_at":"2022-12-11T18:50:11+08:00","repo_name":"tesselode/kira","issue_id":1490327041,"issue_number":36,"issue_url":"https://github.com/tesselode/kira/issues/36","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1347031682","fragment_type":"issue_comment","sequence":1,"text":"This is on Debian Sid (`Linux 5.19.0-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 5.19.11-1 (2022-09-24)`) running PulseAudio. I wasn't able to reproduce this in a fully optimized build. Using `StaticSoundData` avoided the issue, but resulted in long load times in unoptimized builds (which could probably be alleviated by reencoding the music at a lower quality).\n \n\nThat's about what I expected, but I figured I might as well ask here just in case.\n \n\nThis might be part of it. I don't believe there are any generic functions between the main crate and Kira (at least in the state shown in the video), but I am using a trait object to store game states.","author_login":"PatchMixolydic","author_association":"NONE","created_at":"2022-12-12T18:31:39+08:00","repo_name":"tesselode/kira","issue_id":1490327041,"issue_number":36,"issue_url":"https://github.com/tesselode/kira/issues/36","linked_issue_ids":[753387912],"is_known_query_context":false},{"document_id":"gh_comment_1361100182","fragment_type":"issue_comment","sequence":2,"text":"Hi again,\n\nI could not reproduce the issue on Debian Bullseye. When playing a hundred or so copies of the streaming sound, I got underruns, but I didn't observe the sped-up playback you did. I just got normal playback, but with regular pauses.\n\nI'm guessing the Linux kernel version isn't relevant here, but I could be wrong. Not sure what else to try to reproduce the issue.","author_login":"tesselode","author_association":"OWNER","created_at":"2022-12-21T09:57:36+08:00","repo_name":"tesselode/kira","issue_id":1490327041,"issue_number":36,"issue_url":"https://github.com/tesselode/kira/issues/36","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_753387912","fragment_type":"issue_description","sequence":0,"text":"Improper Output Device Selection\nI tried using the Simple Sound Playback example in the readme with a .wav and .ogg file, but it panics on an internal array access. I then tried using the latest git commit (c2877ebae2034498d94070234fa2db8fd6a2458a) and tweaked the example based on the current changes, but the behaviour was the same.\n\nThe panic message: `thread ' ' panicked at 'index out of bounds: the len is 1 but the index is 1', /home/xelivous/.cargo/git/checkouts/kira-a39b987b43e480e3/c2877eb/kira/src/manager/mod.rs:217:21`\n\n URL \n\nI'm running on Manjaro; I looked at basic issues pertaining to linux/arch on cpal's repo but none of them seem to apply, and i could run cpal's examples just fine on my system.\n\nMy best guess from comparing the examples code and the code in kira is that they use `device.default_output_config()?` while kira uses `device.supported_output_configs()?.next()`. The difference being that kira pulls in whatever is listed first, even if it's a very incapable interface that isn't the best suited interface. Debugging it a little, it seems that the interface returned is a single channel interface with a sample rate of `384000`...\n\nIf I change the following config selection chain:\n URL \n\nInto something like:\n\nrust\nlet config = device.default_output_config().ok().ok_or(AudioError::NoSupportedAudioConfig)?.config();\n\nThen everything works without problems, although there might be a better way to send out the proper error other than the really dank `ok().ok_or()` combo. And i'm not sure if you did it with `supported_output_configs` for some particular reason that would be broken for other people when using `default_output_config`.\n\n---\n\nThe alternative solution is properly handling when an interface only has a single output frame/channel and mapping it to something like mono but idk if running something at a really meme sample rate has value.","author_login":"xelivous","author_association":"NONE","created_at":"2020-11-30T11:15:35+08:00","repo_name":"tesselode/kira","issue_id":753387912,"issue_number":1,"issue_url":"https://github.com/tesselode/kira/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_736175945","fragment_type":"issue_comment","sequence":1,"text":"Yeah, you're having the same issue another person I'm talking to is having. I didn't have any special reason for using `supported_output_configs`, that's just what I saw in the cpal docs. I can get a fix merged in soon.","author_login":"tesselode","author_association":"OWNER","created_at":"2020-12-01T02:29:12+08:00","repo_name":"tesselode/kira","issue_id":753387912,"issue_number":1,"issue_url":"https://github.com/tesselode/kira/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_739115450","fragment_type":"issue_comment","sequence":2,"text":"I went ahead and released v0.1.2, so this should be fixed now. Let me know if you have any more issues.","author_login":"tesselode","author_association":"OWNER","created_at":"2020-12-05T03:22:05+08:00","repo_name":"tesselode/kira","issue_id":753387912,"issue_number":1,"issue_url":"https://github.com/tesselode/kira/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0251","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"ST announcement still playing?","query_context":"Hi there!\nYour earlier fix removing the \"_Composite Clipper is used without license_\" indeed removes that message, however after exactly 4 hours of running ST9.92 still an audio advertisement clip is played (\"_This sound is processed by StereoTool ..._ blabla\") mixed through the FM-output), even after a fresh install on a computer without Internet connection.\nAll available licenses are marked green in ST and the only remaining nagging is that this audio advertisement is played after 4 hours run-time on FM-output. I am only using all FM-professional features, including Composite Clipper. I have µMPX, BIMP and other features disabled.","known_context_document_ids":["gh_issue_1804756317"],"reference_answer":"Try adding -f 0x49f508df to the keygen. Might have to do with AGC 3/4 but I'm not sure.","answer_document_id":"gh_comment_1368144661","silver_evidence_path":["gh_comment_1636977678","gh_issue_1514868832","gh_comment_1368144661"],"evidence_issue_ids":[1804756317,1514868832],"source_repo_name":"Anthony96922/st-keygen","source_issue_id":1804756317,"source_issue_number":2,"source_issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","target_repo_name":"Anthony96922/st-keygen","target_issue_id":1514868832,"target_issue_number":1,"target_issue_url":"https://github.com/Anthony96922/st-keygen/issues/1","reference_anchor_document_id":"gh_comment_1636977678","reference_answer_author":"Anthony96922","reference_answer_author_association":"OWNER","quality_score":78.92,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.0417,"target_answer_overlap":0.0},"issue_created_at":"2023-07-14T11:58:15+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_1804756317","fragment_type":"issue_description","sequence":0,"text":"ST announcement still playing\nHi there!\nYour earlier fix removing the \"_Composite Clipper is used without license_\" indeed removes that message, however after exactly 4 hours of running ST9.92 still an audio advertisement clip is played (\"_This sound is processed by StereoTool ..._ blabla\") mixed through the FM-output), even after a fresh install on a computer without Internet connection.\nAll available licenses are marked green in ST and the only remaining nagging is that this audio advertisement is played after 4 hours run-time on FM-output. I am only using all FM-professional features, including Composite Clipper. I have µMPX, BIMP and other features disabled.","author_login":"SpiderBlocker","author_association":"NONE","created_at":"2023-07-14T11:58:15+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1636977678","fragment_type":"issue_comment","sequence":1,"text":"You might be facing the same issue as #1. Disable the composite clipper then restart ST. If the announcement does not play after 4 hours then it means not all bits for the composite clipper are not being set. I will test various feature masks again to see what stops the announcements.","author_login":"Anthony96922","author_association":"OWNER","created_at":"2023-07-16T04:25:14+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[1514868832],"is_known_query_context":false},{"document_id":"gh_comment_1639524865","fragment_type":"issue_comment","sequence":2,"text":"Hi again. I tested with composite clipper disabled and ST restarted, but the announcement keeps popping up after 4 hours. Maybe one of the other features is to blame, unless it would be caused by the fact that composite clipper is not properly registered, regardless whether it is active or not? Since the announcement litterally plays \"_This sound is processed by Stereotool_\", one may expect it to be related to one of the sound processing features and not something like FM, Advanced RDS or µMPX.\nLicenes\nDo you have any ideas for speeding up testing this, as it will take 4 hours for scanning along each of remaining features this way? I already found that the 4-hours timer is not related to the windows clock time, so it can't be tricked that way :-(\nThx!","author_login":"SpiderBlocker","author_association":"NONE","created_at":"2023-07-18T05:47:35+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639976525","fragment_type":"issue_comment","sequence":3,"text":"Update: I have tested with all features disabled and still the announcement pops up. Now testing again with composite clipper deactivated and unregistered (removed it from the feature mask).","author_login":"SpiderBlocker","author_association":"NONE","created_at":"2023-07-18T10:39:09+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1640639824","fragment_type":"issue_comment","sequence":4,"text":"Try using 0x49e508db. I think bit 3 (0x00000004) might be for the event FM license and that is what might be causing the message.","author_login":"Anthony96922","author_association":"OWNER","created_at":"2023-07-18T17:14:03+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1640830384","fragment_type":"issue_comment","sequence":5,"text":"With 0x49e508db ST displays a red message \"FM processing used without license\".","author_login":"SpiderBlocker","author_association":"NONE","created_at":"2023-07-18T19:10:15+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1640892169","fragment_type":"issue_comment","sequence":6,"text":"Just to add to the conversation, I'm using 0xbe27b897 with the command line version of ST and get the message every 12hours.\nOnly Advanced Clipper, Natural Dynamics, Advanced Dynamics and Dehummer enabled.","author_login":"reztek","author_association":"NONE","created_at":"2023-07-18T19:37:29+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1641482411","fragment_type":"issue_comment","sequence":7,"text":"I don't get the message with my \"Test all license options\" preset for some reason. If you can, send me your preset through email and I can try diagnosing further.","author_login":"Anthony96922","author_association":"OWNER","created_at":"2023-07-19T06:17:31+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1641484632","fragment_type":"issue_comment","sequence":8,"text":"That is a strange mask. The program defaults to 0x49e508df. Where did you get that from? (Might be the checksum.)","author_login":"Anthony96922","author_association":"OWNER","created_at":"2023-07-19T06:19:54+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642155872","fragment_type":"issue_comment","sequence":9,"text":"ORd the bits manually by the keygen source reference, for testing and passed to the keymaker using \"-f\". Same thing (audio message everey 12h) happens with the default 0x49e508df.","author_login":"reztek","author_association":"NONE","created_at":"2023-07-19T14:06:09+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1643636337","fragment_type":"issue_comment","sequence":10,"text":"Looks promising for the first 4 hours and 5 minutes so far! I shall further test tomorrow when I will be back home again.\n-------- Oorspronkelijk bericht --------Van: Anthony96922 ***@***.***> Datum: 20-07-2023 05:47 (GMT+08:00) Aan: Anthony96922/st-keygen ***@***.***> Cc: SpiderBlocker ***@***.***>, Author ***@***.***> Onderwerp: Re: [Anthony96922/st-keygen] ST announcement still playing (Issue #2) \n\nWith 0x49e508db ST displays a red message \"FM processing used without license\".\n\nTry 0xeff52fff. This enables all unknown bits.\n\n—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>","author_login":"SpiderBlocker","author_association":"NONE","created_at":"2023-07-20T10:02:16+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1645381722","fragment_type":"issue_comment","sequence":11,"text":"Please tell me what version of the stereo tool does this work for ?! I'm new, I'm very interested in this project","author_login":"pressurefm","author_association":"NONE","created_at":"2023-07-21T10:43:43+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646163575","fragment_type":"issue_comment","sequence":12,"text":"Tested with \"0xeff52fff\" and got no messages after 24 hours running ST. Solved for me.","author_login":"reztek","author_association":"NONE","created_at":"2023-07-21T19:41:35+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646450337","fragment_type":"issue_comment","sequence":13,"text":"this is very good, could you help me install your key? I have raspberry 4, and HiFiBerry dac + adc.i am new to linux.... tnx","author_login":"pressurefm","author_association":"NONE","created_at":"2023-07-22T04:16:01+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646453731","fragment_type":"issue_comment","sequence":14,"text":"Run make-regkey with the name you want to get a registration key.\n\nExample: ./make-regkey 'some name'\n\nThen pass the key with the -k flag.","author_login":"Anthony96922","author_association":"OWNER","created_at":"2023-07-22T04:38:57+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646819870","fragment_type":"issue_comment","sequence":15,"text":"Hi!\nI have made FM-preset from scratch again in fresh ST 9.92 installment, reg'd with 0xeff52fff flag and ST blocked through firewall. All licenses show green, but still 4h announcement is played through FM-output. I have e-mailed that preset to you (thecube); if you could have a look, would be great!","author_login":"SpiderBlocker","author_association":"NONE","created_at":"2023-07-23T11:50:36+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1649250938","fragment_type":"issue_comment","sequence":16,"text":"**I installed this archive on a flash card, and updated it to the latest version via the web interface. How can I run this code?\nI'm new. Sorry for such a stupid question.\n\n URL","author_login":"pressurefm","author_association":"NONE","created_at":"2023-07-25T07:11:20+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1652217902","fragment_type":"issue_comment","sequence":17,"text":"Hello,\nHow does it works please ?\nChocolatey is installed in my Windows 10. Which line of code should I run in Windows powershell ? Is there a tutorial ?\nThank you","author_login":"dole738","author_association":"NONE","created_at":"2023-07-26T17:23:27+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1662318280","fragment_type":"issue_comment","sequence":18,"text":"Hi again!\n\nFinally found which feature causes the 4h announcement. I Have been scanning along more than 30 four-hour runs since July 25th and of course it was the very last possibility left :-)\n\nIt is definitely the Advanced Clipper. It's not the Advanced Cipper as a whole, but a subsetting of it. I can further narrow down the exact subsetting if needed; pls advise if I need to.","author_login":"LoenieAB","author_association":"NONE","created_at":"2023-08-02T14:29:22+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1804756317,"issue_number":2,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1514868832","fragment_type":"issue_description","sequence":0,"text":"Still having speech message every 4 hours\nHi and thanks for the st-keygen.\n\nThe keygen seems to work fine, however every 4 hours there is still a speech message played \"This sound is processed by stereo...\" \n\nAlready tried running crude a shell license server replying \"ok\" to the startup check, preventing the \"invalid licence\" when running with an active internet connection. Only this doesn't seem to solve the problem.\n\nlicence server check shell script: (replace (dot) with real dots)\n\ngrep -q \"vvv(dot)stereotool(dot)com\" /etc/hosts || sudo sh -c \"echo 127.0.0.1 vvv(dot)stereotool(dot)com >> /etc/hosts\"\nmkdir -p cgi-bin\ntouch cgi-bin/chk.pl\ngrep -q \"ok\" cgi-bin/chk.pl || echo ok > cgi-bin/chk.pl\nsudo python3 -m http.server --bind vvv(dot)stereotool(dot)com 80 & SERVER_PID=$! \n./stereo_tool_gui_64 \nsudo kill $SERVER_PID\nrm -rf cgi-bin","author_login":"pauluzs","author_association":"NONE","created_at":"2022-12-30T21:53:24+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1514868832,"issue_number":1,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368139324","fragment_type":"issue_comment","sequence":1,"text":"Testing with stereo_tool_gui_jack_64 9.92 to generate a fm mpx signal.\n\nEnabled:\nDeclipper\nAuto/BASS EQ/Dyn spd/AGC34/Progressive/Speech\nAdvanced Clipper, FM Composite clipper\nNatural Dynamics\nFM (Pre-emphasis,stereo,RDS\n\nimage","author_login":"pauluzs","author_association":"NONE","created_at":"2022-12-31T01:10:16+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1514868832,"issue_number":1,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368144661","fragment_type":"issue_comment","sequence":2,"text":"Try adding -f 0x49f508df to the keygen. Might have to do with AGC 3/4 but I'm not sure.","author_login":"Anthony96922","author_association":"OWNER","created_at":"2022-12-31T01:55:07+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1514868832,"issue_number":1,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370231614","fragment_type":"issue_comment","sequence":3,"text":"I noticed the keygen sometimes not giving the correct name after using some suggested masks, and it needs to be run a second time to display the name again in the license info.\nThis happened after directly after using mask 0x49f508df and again using it without a mask after using 0x49e508db as far i can recall in bash.\nsend me a gmail if u want a log of this","author_login":"pauluzs","author_association":"NONE","created_at":"2023-01-03T21:14:48+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1514868832,"issue_number":1,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374806893","fragment_type":"issue_comment","sequence":4,"text":"started out with all new settings from scratch, which seem to solve the problem, still haven't found what actually caused this.","author_login":"pauluzs","author_association":"NONE","created_at":"2023-01-08T11:15:52+08:00","repo_name":"Anthony96922/st-keygen","issue_id":1514868832,"issue_number":1,"issue_url":"https://github.com/Anthony96922/st-keygen/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0252","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"IsEnabled doesn't update visual state after being updated with INotifyPropertyChanged when displaying shell alert on Windows 10?","query_context":"### Description\n\nVisual state of button doesn't change after alert is displayed despite being enabled. It's visible as disable despite being clickable.\n\nIt works fine on Android.\n\nimage\n\nObservableProperty and ICommand is part of Microsoft.Toolkit.Mvvm.ComponentModel\n\ncs\n [ObservableProperty]\n [AlsoNotifyChangeFor(nameof(IsNotBusy))]\n private bool isBusy;\n public bool IsNotBusy => !IsBusy;\n\nxml\n \n\ncs\n[ICommand]\npublic async Task DisplayAlertAsync()\n {\n IsBusy = true;\n bool answer = await Shell.Current.DisplayAlert(\"Question?\", \"Would you like to play a game\", \"Yes\", \"No\");\n IsBusy = false;\n }\n\n### Steps to Reproduce\n\n1. Run app on Windows 10\n2. Click button\n3. Visual state doesn't update after alert is displayed.\n\n### Version with bug\n\n6.0.419 (current)\n\n### Last version that worked well\n\nUnknown/Other\n\n### Affected platforms\n\nWindows\n\n### Affected platform versions\n\nWindows 10\n\n### Did you find any workaround?\n\n_No response_\n\n### Relevant log output\n\n_No response_","known_context_document_ids":["gh_issue_1313089419"],"reference_answer":"Closing this, as it just seems like an issue with MAUI (also I think I've seen this being mentioned in a separate issue as well though I don't have it handy right now). I'd recommend opening an issue in the MAUI repo (or finding one if it already exists) and possibly linking this one there for reference 🙂","answer_document_id":"gh_comment_1356625388","silver_evidence_path":["gh_comment_1215354495","gh_issue_1333482707","gh_comment_1356625388"],"evidence_issue_ids":[1313089419,1333482707],"source_repo_name":"dotnet/maui","source_issue_id":1313089419,"source_issue_number":8877,"source_issue_url":"https://github.com/dotnet/maui/issues/8877","target_repo_name":"CommunityToolkit/dotnet","target_issue_id":1333482707,"target_issue_number":372,"target_issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","reference_anchor_document_id":"gh_comment_1215354495","reference_answer_author":"Sergio0694","reference_answer_author_association":"MEMBER","quality_score":93.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1905,"anchor_target_overlap":0.2857,"target_answer_overlap":0.04},"issue_created_at":"2022-07-21T11:12:04+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1313089419","fragment_type":"issue_description","sequence":0,"text":"IsEnabled doesn't update visual state after being updated with INotifyPropertyChanged when displaying shell alert on Windows 10\n### Description\n\nVisual state of button doesn't change after alert is displayed despite being enabled. It's visible as disable despite being clickable.\n\nIt works fine on Android.\n\nimage\n\nObservableProperty and ICommand is part of Microsoft.Toolkit.Mvvm.ComponentModel\n\ncs\n [ObservableProperty]\n [AlsoNotifyChangeFor(nameof(IsNotBusy))]\n private bool isBusy;\n public bool IsNotBusy => !IsBusy;\n\nxml\n \n\ncs\n[ICommand]\npublic async Task DisplayAlertAsync()\n {\n IsBusy = true;\n bool answer = await Shell.Current.DisplayAlert(\"Question?\", \"Would you like to play a game\", \"Yes\", \"No\");\n IsBusy = false;\n }\n\n### Steps to Reproduce\n\n1. Run app on Windows 10\n2. Click button\n3. Visual state doesn't update after alert is displayed.\n\n### Version with bug\n\n6.0.419 (current)\n\n### Last version that worked well\n\nUnknown/Other\n\n### Affected platforms\n\nWindows\n\n### Affected platform versions\n\nWindows 10\n\n### Did you find any workaround?\n\n_No response_\n\n### Relevant log output\n\n_No response_","author_login":"Laradius","author_association":"NONE","created_at":"2022-07-21T11:12:04+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1203668086","fragment_type":"issue_comment","sequence":1,"text":"@Eilon @rmarinho Could I get informatiom regarding that issue?","author_login":"Laradius","author_association":"NONE","created_at":"2022-08-03T08:50:44+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1205675283","fragment_type":"issue_comment","sequence":2,"text":"@Laradius we will check this out in an upcoming bug triage meeting. I'm wondering if the async behavior is somehow affecting this? I'm not sure how the MVVM Toolkit attributes work with this, either. What happens if you call `NotifyPropertyChanged(nameof(IsNotBusy))` after setting it to false?","author_login":"Eilon","author_association":"MEMBER","created_at":"2022-08-04T19:19:14+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1206086402","fragment_type":"issue_comment","sequence":3,"text":"Is not busy property returns true and notifies all bindings about the change.","author_login":"Laradius","author_association":"NONE","created_at":"2022-08-05T06:20:47+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1215354495","fragment_type":"issue_comment","sequence":4,"text":"Hi\nI have already posted this at another repo\n URL \nmy problem is the button can't disable itself from the C# code.\nand sometimes from the other buttons as well.\nany guide pls, my whole work is stope at this stage.","author_login":"Ahmadmansoor","author_association":"NONE","created_at":"2022-08-15T16:49:32+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[1333482707],"is_known_query_context":false},{"document_id":"gh_comment_1268023839","fragment_type":"issue_comment","sequence":5,"text":"Do anybody care about this issue?\nRight now it is not possible to use Async Commands for buttons because the visual state of the button (from CanExecute) may be not correct after showing a DisplayAlert. A showstopper in the moment for MAUI on Windows.....","author_login":"sude22","author_association":"NONE","created_at":"2022-10-05T06:53:50+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316883624","fragment_type":"issue_comment","sequence":6,"text":"I've noticed the same in MAUI as well (it does indeed look related to #9753). This seems to be a MAUI specific issue and unrelated from the MVVM Toolkit per se (the same code works just fine on UWP and WinUI 3 too, for instance).\n\n@Laradius unrelated, but you can simplify your code by removing those `IsBusy`/`IsNotBusy` properties entirely, and just bind to the `IsRunning` property exposed by the `IAsyncRelayCommand` property that the generator will create for you. For the inverted property (`IsNotBusy`), simply use a converter or `x:Bind` to function in XAML, you don't need an extra property 🙂","author_login":"Sergio0694","author_association":"NONE","created_at":"2022-11-16T11:55:03+08:00","repo_name":"dotnet/maui","issue_id":1313089419,"issue_number":8877,"issue_url":"https://github.com/dotnet/maui/issues/8877","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1333482707","fragment_type":"issue_description","sequence":0,"text":"MAUI Button IsEnabled Binding\n### Describe the bug\n\nI started noticing my buttons acting weirdly when trying to disable via bindings where in my current project even after setting IsEnabled binding value to false I can still click the button and fire off the binding command.\n\nI created a new app to test and found out that despite when the app first starts and the binding is false, the button can still be clicked until I set it true, then back to false. Only then will it start acting as it should.\n\nIMAGES:\n1. When started - original button is enabled despite CanClick is false\n2. Button clicked and breakpoint fires\n3. Continued and yellow box shows CanClick is still false\n4. Clicked Enable Counter twice (first time to set CanClick to true, then to false) Clicked button not disabled\n\n### Regression\n\n_No response_\n\n### Reproducible in sample app?\n\n- [ ] This bug can be reproduced in the sample app.\n\n### Steps to reproduce\n\ntext\n1. New Maui App\n2. Add CommunityToolKit\n3. Add viewmodel and BindingContext and DataTypes to xaml and xaml.cs\n4. Add bindings (can set the bool CanClick binding false in [ObservableProperty] or in constructor but no effect as CanClick is still false when starting app)\n5. Add [RelayCommands] to both buttons and set break point on original's RelayCommand\n6. Add new button to CanClick = !CanClick (to turn the original button on and off)\n7. Run app\n8. Click original button and breakpoint will fire\n\n### Expected behavior\n\nThe original button should be disable from the start as the binding CanClick is initially set to false\n\n### Screenshots\n\nimage\nimage\nimage\nimage\n\n### Windows Build Number\n\n- [ ] Windows 10 1809 (Build 17763)\n- [ ] Windows 10 1903 (Build 18362)\n- [ ] Windows 10 1909 (Build 18363)\n- [ ] Windows 10 2004 (Build 19041)\n- [ ] Windows 10 20H2 (Build 19042)\n- [ ] Windows 10 21H1 (Build 19043)\n- [ ] Windows 11 21H2 (Build 22000)\n- [X] Other (specify)\n\n### Other Windows Build number\n\nVersion 10.0.19044 Build 19044\n\n### App minimum and target SDK version\n\n- [ ] Windows 10, version 1809 (Build 17763)\n- [ ] Windows 10, version 1903 (Build 18362)\n- [ ] Windows 10, version 1909 (Build 18363)\n- [ ] Windows 10, version 2004 (Build 19041)\n- [ ] Other (specify)\n\n### Other SDK version\n\n_No response_\n\n### Visual Studio Version\n\n2022\n\n### Visual Studio Build Number\n\n17.3.0 Preview 3.0\n\n### Device form factor\n\nDesktop\n\n### Nuget packages\n\nimage\n\n### Additional context\n\n_No response_\n\n### Help us help you\n\nNo.","author_login":"pouchbunny","author_association":"NONE","created_at":"2022-08-09T16:04:27+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1209646090","fragment_type":"issue_comment","sequence":1,"text":"As a follow up. In my own app I created a button to change the value of the binding of one of my buttons that's not being disabled from the start as it should. With the new button it acts just like what I described above. I can officially enable and disable my save button by changing the binding value with the new RelayCommand attached to the new button.","author_login":"pouchbunny","author_association":"NONE","created_at":"2022-08-09T17:09:53+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214443135","fragment_type":"issue_comment","sequence":2,"text":"Yes, it's a big issue, I am struggling for over 1 week though my code has a problem. then I read this here which is the same of my issue.\nI have 2 buttons both of them are getting value by the binding first one is always true whatever I do.\nimage\n\nreally I begin to believe that CommunityToolkit and DotNet Maui are very buggy and it needs a long time to be stable, which pushes us to move to other languages, really sorry to say that.","author_login":"Ahmadmansoor","author_association":"NONE","created_at":"2022-08-14T20:24:12+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1214447249","fragment_type":"issue_comment","sequence":3,"text":"You haven't demonstrated that this is in fact a bug in the MVVM Toolkit whatsoever yet. As far as I can see, it's not.\n\nIt might be a bug in MAUI, yes, and for that this is the wrong repo. Have you opened an issue on the MAUI repo too?","author_login":"Sergio0694","author_association":"MEMBER","created_at":"2022-08-14T20:56:29+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1215114425","fragment_type":"issue_comment","sequence":4,"text":"@Sergio0694 I think u have your point, but really it is disappoint us when we face simple issues that should not exist or miss essential features.\nOn the other hand, sharing our code for some private software is not easy as well too, I hope u understand the situation.\nanyway a big thanks to the contributor for their great work, and I am sorry if I show a misunderstanding.","author_login":"Ahmadmansoor","author_association":"NONE","created_at":"2022-08-15T14:56:50+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1215350191","fragment_type":"issue_comment","sequence":5,"text":"to be more silicification, my problem is the button can't disable itself from the C# code.\nand sometimes from the other buttons as well.","author_login":"Ahmadmansoor","author_association":"NONE","created_at":"2022-08-15T16:47:49+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1222744407","fragment_type":"issue_comment","sequence":6,"text":"It seems as as long the command method with the [RelayCommand] is synchronous, all works fine. When using an Async command, the button stays gray after the first click (although it's clickable as expected). Only on Windows, not in Android.","author_login":"mvervoort","author_association":"NONE","created_at":"2022-08-22T18:16:02+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1356625388","fragment_type":"issue_comment","sequence":7,"text":"Closing this, as it just seems like an issue with MAUI (also I think I've seen this being mentioned in a separate issue as well though I don't have it handy right now). I'd recommend opening an issue in the MAUI repo (or finding one if it already exists) and possibly linking this one there for reference 🙂","author_login":"Sergio0694","author_association":"MEMBER","created_at":"2022-12-18T01:59:05+08:00","repo_name":"CommunityToolkit/dotnet","issue_id":1333482707,"issue_number":372,"issue_url":"https://github.com/CommunityToolkit/dotnet/issues/372","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0253","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Consider making the `version` field optional in Cargo.toml?","query_context":"**Describe the problem you are trying to solve**\n\nToday, the `version` field is required. However, in many (most?) cases it doesn't make sense:\n\n* when doing some casual rust hacking for fun or learning \n* inside \"live at HEAD\" company monorepo\n* when working on a large Rust projects not distributed via `cargo install`\n\nThis creates specific issues:\n\n* additional confusion -- there is a line in Cargo.toml which is there \"just because\", and not due to some specific reason\n* diluted meaning of versions: semver compatibility is a lot to promise, by having versions everywhere it's harder to notice where they matter and where you need to care about API compatibility\n* For projects which mix published and non-published crates in the same source tree, it becomes harder to know at a glance if a particular crate is published. \n\n**Describe the solution you'd like**\n\nMake the `version` field in Cargo.toml optional. Do populate it by default, as it is today. Prevent publishing the crates which (transitively) depend on non-versioned crates. \n\n**Notes**\n\nThere is `publish = false`, to my mind that serves a different purpose -- preventing accidental publishing of the crates. It doesn't help with solving confusion problem -- the version is still there, and it still doesn't have a meaning. Although, if we were to re-design Cargo from scratch, I would argue that we shouldn't have `publish` field at all, and insead define it as `publish = version.is_some()`. \n\nImplementation wise, it seems like we can desugar absence of version as `version = \"0.0.0\" publish = false`. I personally use `version = \"0.0.0\"` as a way to explicitly signal that there's no meaningful version.","known_context_document_ids":["gh_issue_976847689"],"reference_answer":"any lines at all between the `#!` shebang line and the code fence are not supported. in the future only blank lines will be allowed between them. you seem to have a bunch of doc comments which aren't supported, so you need to move the code-fenced Cargo.toml section to right after the shebang line and before any rust comments.","answer_document_id":"gh_comment_1955837476","silver_evidence_path":["gh_comment_1724168035","gh_issue_1733342552","gh_comment_1955837476"],"evidence_issue_ids":[976847689,1733342552],"source_repo_name":"rust-lang/cargo","source_issue_id":976847689,"source_issue_number":9829,"source_issue_url":"https://github.com/rust-lang/cargo/issues/9829","target_repo_name":"rust-lang/cargo","target_issue_id":1733342552,"target_issue_number":12207,"target_issue_url":"https://github.com/rust-lang/cargo/issues/12207","reference_anchor_document_id":"gh_comment_1724168035","reference_answer_author":"programmerjake","reference_answer_author_association":"MEMBER","quality_score":94.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.1667,"target_answer_overlap":0.0667},"issue_created_at":"2021-08-23T09:54:51+08:00","valid_comment_count":112,"fragments":[{"document_id":"gh_issue_976847689","fragment_type":"issue_description","sequence":0,"text":"Consider making the `version` field optional in Cargo.toml\n**Describe the problem you are trying to solve**\n\nToday, the `version` field is required. However, in many (most?) cases it doesn't make sense:\n\n* when doing some casual rust hacking for fun or learning \n* inside \"live at HEAD\" company monorepo\n* when working on a large Rust projects not distributed via `cargo install`\n\nThis creates specific issues:\n\n* additional confusion -- there is a line in Cargo.toml which is there \"just because\", and not due to some specific reason\n* diluted meaning of versions: semver compatibility is a lot to promise, by having versions everywhere it's harder to notice where they matter and where you need to care about API compatibility\n* For projects which mix published and non-published crates in the same source tree, it becomes harder to know at a glance if a particular crate is published. \n\n**Describe the solution you'd like**\n\nMake the `version` field in Cargo.toml optional. Do populate it by default, as it is today. Prevent publishing the crates which (transitively) depend on non-versioned crates. \n\n**Notes**\n\nThere is `publish = false`, to my mind that serves a different purpose -- preventing accidental publishing of the crates. It doesn't help with solving confusion problem -- the version is still there, and it still doesn't have a meaning. Although, if we were to re-design Cargo from scratch, I would argue that we shouldn't have `publish` field at all, and insead define it as `publish = version.is_some()`. \n\nImplementation wise, it seems like we can desugar absence of version as `version = \"0.0.0\" publish = false`. I personally use `version = \"0.0.0\"` as a way to explicitly signal that there's no meaningful version.","author_login":"matklad","author_association":"MEMBER","created_at":"2021-08-23T09:54:51+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1049470327","fragment_type":"issue_comment","sequence":1,"text":"In my case I have a rust project that is just part of an Electron app. My `package.json` already has the version, so the `Cargo.toml` version field is just unnecessary and confusing.\n\nHaving a version can still be useful even if you have `publish = false`. In `npm`, the version field is optional, and you'll get warnings unless you have the equivalent of `publish = false`","author_login":"probablykasper","author_association":"NONE","created_at":"2022-02-24T03:58:37+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1204714110","fragment_type":"issue_comment","sequence":2,"text":"I have the same issue for something I solely distribute as a `.deb` package - my main issue is that I have to update the version in both my Debian packaging files and in my Cargo.toml, which is quite tedious and has been error-prone in my setup.\n\nAt the least it would be nice to able to simply overwrite the version during a build via a CLI flag. Even if the version key didn't have to be present, it would still be ideal to have that so my program could determine the proper version to set in things like a `--version` menu.","author_login":"hwittenborn","author_association":"NONE","created_at":"2022-08-04T03:29:19+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1204719101","fragment_type":"issue_comment","sequence":3,"text":"I think the most simple solution is `cargo new` setting initial version to `v0.0.0` (instead of `v0.1.0`).","author_login":"tshepang","author_association":"CONTRIBUTOR","created_at":"2022-08-04T03:39:20+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1204720694","fragment_type":"issue_comment","sequence":4,"text":"This isn't really an issue with what the default version is, but just how to have no version at all. I think that argument merits its own issue imo.","author_login":"hwittenborn","author_association":"NONE","created_at":"2022-08-04T03:42:31+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1724168035","fragment_type":"issue_comment","sequence":5,"text":"cargo script (#12207) is defaulting the version to `0.0.0` for scripts. To close the gap between a cargo script and `Cargo.toml`, I think it'd be worthwhile to implement this issue. My main concern is with the implications through the rest of cargo, mostly pkgid. For `CARGO_PKG_VERSION` and friends, I would just not populate them.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-09-18T18:38:15+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[1733342552],"is_known_query_context":false},{"document_id":"gh_comment_1737111019","fragment_type":"issue_comment","sequence":6,"text":"Even outside `cargo script`, I find that having to add `publish = false` *and* keep a meaningless version around is pointless boilerplate. I don't think there should be a lint about a missing `publish = false` if the version is absent; it will be obvious when attempting to publish that it's not possible because of the missing version (writing a description error message should be simple) and adding one at that point is simple as well. Maybe we could / should lint if `publish` is set [to something other than `false`] and the version is unset though.","author_login":"jplatte","author_association":"CONTRIBUTOR","created_at":"2023-09-27T10:14:35+08:00","repo_name":"rust-lang/cargo","issue_id":976847689,"issue_number":9829,"issue_url":"https://github.com/rust-lang/cargo/issues/9829","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1733342552","fragment_type":"issue_description","sequence":0,"text":"Tracking Issue for cargo-script RFC 3424\n### Summary\n\nRFC: #3424\nImplementation: #12245, #12269, #12255, #12258, #12268, TODO\nDocumentation: < URL \nIssues: URL \n\nThis is an experimental feature to add unstable support for single-file packages in cargo so we can explore the design and resolve questions with an implementation to collect feedback on.\n\nTasks\n- [ ] `cargo Cargo.toml`\n- [ ] Target directory\n- [ ] Lockfile location\n- [ ] basic command support (e.g. `cargo test --manifest-path foo.rs`)\n- [ ] `cargo publish` (including setting the `includes` implicitly)\n- [ ] `cargo add` / `cargo rm` support\n- [ ] workspace support\n\n### Unresolved Issues\n\n- What do we refer to it when you do `cargo script.rs`? Currently, we are calling ti a \"manifest command\" but that is overloaded\n- Should the manifest fields use an allowlist or a denylist (current)?\n- Should escaping rules match package validation or cargo-new validation?\n- Support for mixed comment styles (see #12258 for details)\n- How do allow capturing of the lockfile?\n- How do we avoid the edition being on the float?\n\nSee also the Pre-RFC for more discussion\n\n### Future Extensions\n\n_No response_\n\n### About tracking issues\n\nTracking issues are used to record the overall progress of implementation.\nThey are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.\nA tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.\nInstead, open a dedicated issue for the specific matter and add the relevant feature gate label.","author_login":"ehuss","author_association":"CONTRIBUTOR","created_at":"2023-05-31T03:55:52+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1582270582","fragment_type":"issue_comment","sequence":1,"text":"The RFC seems a bit unclear on if the filename must end with `.rs` or not?\n\nIf we (a) don't require `.rs`, and (b) don't require an explicit command line option, would that mean `cargo runc myprog` (misspelling `run` as `runc`) would be intepreted as \"treat the runc executable as rust source and try and compile it, then run it\"?","author_login":"ChrisJefferson","author_association":"NONE","created_at":"2023-06-08T10:02:55+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1594813492","fragment_type":"issue_comment","sequence":2,"text":"In the current implementation, it looks like adding/renaming a function will trigger a whole re-compliation including all dependencies. Changing/Adding function signature is not rare in scripting. I wonder if this is expected and if this could be resolved.","author_login":"XOR-op","author_association":"NONE","created_at":"2023-06-16T14:45:16+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1595494247","fragment_type":"issue_comment","sequence":3,"text":"In #12268, the whole scheme is being removed. In future PRs, we'll being some of it back but yes, one of the thing I'll be changing is that the target dir should have a hash of the path, not the content. People change the content more than they change the location.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-06-16T23:57:37+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1595719097","fragment_type":"issue_comment","sequence":4,"text":"*sigh* I forget what all keywords github looks for that I have to avoid","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-06-17T11:36:07+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1596191669","fragment_type":"issue_comment","sequence":5,"text":"As already expressed in the pre-RFC, I think that wrapping the manifest into \ncargo shouldn't be needed. Would a PR be accepted that implements \"option 5: comments\" (without a HEREDOC)? Ideally, this should become possible:\n\nRust\n#!/usr/bin/env cargo\n/*\n[package]\nedition = \"2018\"\n*/\n\nfn main() {}\n\nThe rules would be:\n\n* any `/*` comment directly at the top gets interpreted as a toml snippet\n* adding any blank lines, or lines with content (including `//` comments) between the shebang and the comment disqualifies that comment from being the toml snippet.\n\nComments would still be supported in toml fashion via a `#`.\n\nPersonally I think as we are treading new ground here, one should reduce the overhead that the eval system adds, and \ncargo adds such overhead. Once we stabilize cargo-script support, the option to add treatment of comments in such a fashion is gone.\n\nRegarding the implementation, correct me if I'm wrong, syn seems to not parse comments. Maybe one could switch to using `rustc-lexer`? It should reduce the overhead a bit I think.","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-06-18T16:00:46+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1597845525","fragment_type":"issue_comment","sequence":6,"text":"one alternative option is to do something like Java's jar files...scripts would be a zip file with a different file extension and a unix `#!` line prefixed","author_login":"programmerjake","author_association":"MEMBER","created_at":"2023-06-19T22:42:33+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603265701","fragment_type":"issue_comment","sequence":7,"text":"With #12303, `.cargo/config.toml` will be used relative to the script and not to the CWD. This mirrors `cargo install --path `.\n\nAs for rustup toolchain files, our options seem to be\n- Do nothing as that is what `cargo install --path ` does today\n- Suggest `#!/usr/bin/env -S cargo +stable` despite not being fully cross platform, it will likely be \"good enough\"\n- Don't use the `cargo` proxy but add a new proxy that is specifically meant for thi workflow (see Pre-RFC for naming considerations and ideas)\n- Have the `cargo` proxy evaluate enough of cargo's command-line to detect a \"cargo script\" is being used and to load the toolchain file relative to that path\n - This would effectively require copying cargo's CLI up-to determining whether this is a \"cargo script\" (or go through the hassle of trying to design and maintain a lib for that)\n - rustup ships independent of cargo and on much less frequent schedule yet rustup would need to have knowledge of the latest cargo command-line\n- The real `cargo` binary could detect its in rustup and re-run itself to cause the proxy to look up the rustup toolchain for the \"script\"s path\n - The proxy process is already slow as-is and no-rebuild times need to be kept at a minimum\n - Maybe if rustup told cargo if a rustup toolchain file was being used and only re-evaluate then?","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-06-22T20:21:32+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603345349","fragment_type":"issue_comment","sequence":8,"text":"@rbtcollins Is that only set if the user set it or if a toolchain file is used or is it always set?","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-06-22T21:34:18+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603347465","fragment_type":"issue_comment","sequence":9,"text":"In couple of the threads, a `cargo new --script` has come up\n\nAt minimum, it would create a `foo.rs` that has had `chmod +x` run on it and has a shebang and a main.\n\nThe question is how much more? I think that depends a lot on who you are and what mindset you take when considering this feature, like if it should have some of the manifest in it.\n\nThe other question I have is: \"if we need a `cargo new --script`, have we failed?\". I see this filling a similar role to the playground for learning and trying things out and if there is enough boilerplate that it needs to be automated, that seems bad.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-06-22T21:36:32+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603434109","fragment_type":"issue_comment","sequence":10,"text":"AFAIK, always. In proxy mode [rustup sets both `RUSTUP_TOOLCHAIN` and `RUSTUP_HOME`][1] for the actual command.\n\n[1]: URL","author_login":"weihanglo","author_association":"MEMBER","created_at":"2023-06-22T23:28:36+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1631347461","fragment_type":"issue_comment","sequence":11,"text":"We had a check-in on this experiment during the cargo team meeting. The general feeling that I took from the meeting was that this would be useful enough roughly where we are at, even if we don't have \"larger\" features like workspaces though those features could potentially help out.\n\nProposed features to defer out so long as we have a plan for adding them in without breaking compatibility\n- Workspaces\n - Currently there is no workspace auto-detection and the proposal is for single-file packages to explicitly opt-in via `package.workspace = true` (currently only takes the path to the workspace)\n- `[lib]` support\n - We could distinguish a future `[lib]` single-file package from the existing `[[bin]]` ones via an empty `[lib]` table\n- `cargo package` / `cargo publish`\n - Without `[lib]` support, this is limited `cargo install` use cases and the scope of the use cases for scripts to publish and install seems relatively small\n - No compatibility concern present; we would just remove error checks\n- Embedded or adjacent `Cargo.lock`\n - We could either add a `workspace.lock` field for controlling this or check for the presence of the content, however it is stored\n - The main constraint is if we want to allow embedding the lockfile, that we leave room for doing so syntactically\n\nDecisions still needing to be made:\n- How to embed manifest\n\nDecisions that need to be affirmed\n- Handling of `package.edition` (defaults to \"stable\" but warns every time its parsed)","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-07-11T18:51:37+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1640597214","fragment_type":"issue_comment","sequence":12,"text":"I wonder if we should block cargo script on #9778. 87be661989788e296c90c4ae835cb92822a1617d is an example of this where a file named `42answer.rs` leads to a `answer[EXE]` when it should be `42answer[EXE]`.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-07-18T16:54:46+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1641944348","fragment_type":"issue_comment","sequence":13,"text":"Is anyone working on the rust-analyzer support? I would like to give it a try.","author_login":"victor-timofei","author_association":"NONE","created_at":"2023-07-19T11:53:03+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642116848","fragment_type":"issue_comment","sequence":14,"text":"I was holding off until we had settled how we want to embed the manifest in source to avoid extending out the churn to other projects.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-07-19T13:46:51+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642705799","fragment_type":"issue_comment","sequence":15,"text":"It would take me some time also to familiarize myself with the `rust-analyzer` internals. 😝\n\nBut I guess I could start with just shebang support and no manifest?","author_login":"victor-timofei","author_association":"NONE","created_at":"2023-07-19T20:24:13+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642721415","fragment_type":"issue_comment","sequence":16,"text":"I'd recommend starting with an issue in their repo about detecting \"cargo script\"s and propose a mechanism for how to do it and see where the discussion goes.\n\nPlease cc me in that thread.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-07-19T20:37:17+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1664676416","fragment_type":"issue_comment","sequence":17,"text":"@joshtriplett and I discussed how to handle `package.edition`. This is a draft of what we'd want to do which the rest of the cargo team would need to sign off as part of stabilization (ie doesn't represent the whole team)\n\n## Rough plan\n\n- Perma-warning for now\n - `cargo fix` to address the warning it (not required for first release)\n - If we feel this was a mistake, we can always change this to always being required in a future edition\n- In the future, we could also explore having an edition-wrapper binary like `cargo-2018-edition`, depending on feedback\n- If we have a `cargo new --script`, it will include a manifest in the file\n\n## Use cases\n\nA user might skip on edition and be fine ignoring the warning\n- Bug reproduction (usually can tell from timeframe; ideally short-lived anyways)\n- Throwaway scripts\n\nEither always want the edition set or don't want to include code that produces warnings\n- Long-term scripts\n- Clean documentation that doesn't produce warnings\n\nWith the use cases for skipping an edition, that leaned us towards having the warning instead of requiring it.\n\n## Options considered\n\nDefault to an edition (the one introducing cargo script) unless specified\n- Effectively always requires the edition once people want a new edition\n - Bloats educational material\n\n~~Insert edition on first run~~\n- We don't want to be modifying code\n\n~~Edition flag~~\n- `/usr/bin/env` portability issues\n\nedition wrapper (cargo-2018)\n- Bloated on windows (esp 40 years from now...)\n- `cargo 2018` is weird and requires special parsing to not error out\n- `car\\t` is annoying for completions\n - Already true for third-party commands. (Possibly already true for first-party commands?)\n - Will it be overwhelming though in 40 years\n\nRequire an explicit edition\n\nPerma-warning on missing field.\n- This effectively makes an explicit edition mandatory (for anything except toys and bug-reproductions)\n- If we have a `cargo new --script`, should it always generate the manifest so we get edition?\n - What to call the flag?\n - `cargo new foo.rs` does it based on extension?\n - Doesn't help when people don't want an extension\n - `chmod +x`\n - `#!` block\n - Insert manifest","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-03T21:36:16+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1664716142","fragment_type":"issue_comment","sequence":18,"text":"TLDR: I think the current cargo-script proposal is cutting corners, and I'm fine with cutting corners, but I think it's cutting them in the wrong places. It's cutting corners with the edition, but is overly verbose with regards to manifest inclusions where you have to nest it in two constructs.\n\nDo bug reproductions and throwaway scripts really need the latest edition? The rustc testsuite is still on edition 2015, and many of the tests in the cargo testsuite have edition 2018 (roughly the same number as edition 2021 tests). I think defaulting to edition 2021 wouldn't be that bad as noted.\n\nThis has a way nicer \"pressure curve\" on users than a `rustup update` suddenly breaking some script that started as throwaway script but now is powered by a cronjob: people will eventually notice that they are on an old edition and add the flag.\n \n \n\nThat was the whole deal of the editions RFC: breakage, but safe, and opt-in. `rustup update` should not cause breakages for anybody.\n\nFor the bloat concerns, see my suggestions to reduce the overhead to include Cargo.toml (to just use `/**/` instead of rustdoc markdown code sections) and specify the edition (#12301). That would reduce it from:\n\n`rust\n#!/usr/bin/env cargo-script\n/*!\n\nCargo.toml\n[package]\nedition = \"2021\"\n\n*/\n\nfn main() {\n println!(\"Hello, world!\");\n}\n\n`\n\nto:\n\n`rust\n#!/usr/bin/env cargo-script\n/*\n[package]\nedition = 2021\n*/\n\nfn main() {\n println!(\"Hello, world!\");\n}\n\n`\n\nAnd that's with the standard Cargo.toml inclusion syntax proposal of mine. But I want to repeat points from earlier discussions on discourse about having custom edition syntaxes. My favourite is parsing a `// edition: 2021` like comment, like it is done for rustc's testsuite.\n\ne.g.:\n\nrust\n#!/usr/bin/env cargo-script\n// edition: 2021\n\nfn main() {\n println!(\"Hello, world!\");\n}\n\nBut you can also have `#![edition = \"2021\"]` if you don't like comments (but there is precedent in both the compiletest test suite, rustdoc comments, and ).\n\nThese two ideas would make requiring the edition, or defaulting to a specific one, much easier.\n\nThe current way of specifying the edition in Cargo.toml wasn't particularly optimized for brevity, and it didn't have to be because it was designed for use cases where there is a lot of bloat already. The way of specifying the edition is not set in stone and can be evolved. I think the core promises of the edition RFC to deliver opt-in breakage should *not* be subject to change or exceptions however. Even the playground is paying the edition toll by adding it to the URL (and notice how it doesn't use builtin manifests?).","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-08-03T22:24:22+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1664736541","fragment_type":"issue_comment","sequence":19,"text":"Also, IMO, any way to require less syntax to specify the edition is helpful regardless of the discussion about what cargo should do by default or whether it should require an edition: users will want to specify it one way or another, and if it's easier than the current proposal, they are helped.\n\nAlso, a possible idea to lessen the impact of defaulting to the latest edition, one could limit that to cases where no manifest is embedded. If a script has a manifest embedded already, requiring an edition isn't burdening users a lot even with the status quo of specifying the edition, because they just need to add one/two lines in that instance.","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-08-03T22:53:36+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1664824477","fragment_type":"issue_comment","sequence":20,"text":"@est31 is not decided and has been our biggest open issue on this. Josh and I also talked about it and I need to process the notes and post them but understand that we are still working through this and wanting to have involvement of both T-cargo and T-lang in this.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-04T00:55:09+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1665144153","fragment_type":"issue_comment","sequence":21,"text":"I would argue that Rust's philosophy on explicitness is one of the things that made it successful, and it's certainly one of the things I love about it most.\n\n### Manifest\n\nI'm not particularly a fan of using `/* [...] */` for the manifest, as it looks way too much like an ordinary comment, not just to the developer, but also anything automated examining the code.\n\nThe good thing about module-level documentation comments is that developers are already familiar with them, and the code to parse, highlight, and extract them is pretty much in place - albeit only for the `rust` language for now as far as I know.\n\nAnother place to put the manifest could just be a documentation comment on `main` itself.\n\nrust\n#!/usr/bin/env cargo\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\n/// \ncargo\n/// [dependencies]\n/// clap = { version = \"4.2\", features = [\"derive\"] }\n/// \n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\nWhile this certainly has the drawback of potentially moving the dependencies further down the code, it clearly couples the entry point with everything it needs to start.\n\n### Edition\n\nAs for the edition question, and like @poliorcetics has said, I would very much love for `cargo new --script` to generate the manifest with `edition` included, just like `cargo new --lib/bin` does, for the sake of both explicitness and consistency. I don't feel like that extra three lines within the code is going to degrade the developer experience so much that it would ever truly be an issue, not even for beginners.\n\nIn fact, someone new to the language might not even know what an edition is, and could have a hard time figuring out why the default value (whatever it may be) doesn't work for them.\n\nrust\n#!/usr/bin/env cargo\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\n/// \ncargo\n/// [package]\n/// edition = \"2021\"\n///\n/// [dependencies]\n/// clap = { version = \"4.2\", features = [\"derive\"] }\n/// \n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\n---\n\nI agree with @est31 in that using sane defaults for scripts not containing a manifest at all is a reasonable shortcut for when you just need to get something out quick, and explicitly defining an edition should be required once a manifest _is_ included.","author_login":"skreborn","author_association":"NONE","created_at":"2023-08-04T07:33:51+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1665992690","fragment_type":"issue_comment","sequence":22,"text":"@est31 I now have some more time to write more specifically to your points on editions\n \n\nHow much first-hand experience do you have with the \"cargo script\" feature in nightlies, as of July 11th or so? I encourage anyone wanting to discuss edition default + warning to make good use of the feature (and not trial it). From my experience using the feature (all of my scripts are running cargo from `HEAD`) and from talking to Josh who was heavily involved in editions is that the warning is strong enough to help drive our intended behavior with editions. As Josh put it for the long-term script users: \"[the warning] effectively makes an explicit edition mandatory (for anything except toys and bug-reproductions)\".\n \n\nFor me, a priority is being able to have a file without any manifest. Technically you could then change to the `#!` to `rustc` but I don't want users to have to think about that.\n\nWe also need to keep in mind MVP vs where we eventually end up. I think re-inventing a new syntax or schema in the first version is the wrong direction to go. For manifests, we should have an actual manifest, even if its a more heavily-defaulted version. To that end, I'm also concerned about requiring fields that aren't required today because that can be surprising. As we see how this feature evolves, we can have more targeted discussions on how to improve specific parts of the syntax. Right now, we are trying to design a lot; we need to cut somewhere to ever get this stable.\n \n\nI think those scripts do need the edition. Maybe not always but in enough cases that we would be making life for our users harder. Most people will likely be using and thinking in terms of the current edition and behavior outside of that will be surprising, possibly making a bug reproduction more of a hassle (or surprising) or by making someones syntax/std experiments meaningless to the production code they'll use.\n \n\nI feel this is just as bad as defaulting to 2015 edition but just delays the consequences for a few years.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-04T18:05:41+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1665999332","fragment_type":"issue_comment","sequence":23,"text":"@skreborn \n \n\nExplicitness is not a goal but a tool to help reach goals. Cargo and rust can be implicit at times, including all of the defaulting in `Cargo.toml` or type inference in Rust. This is an important distinction so we make sure we don't over-index on things being explicit but we keep in mind why we want to be explicit and why explicitness could damage our efforts.\n \n\nAs has been noted several times in this thread, the manifest format is our biggest open issue. We have a plan for determining our path forward which I will soon document but I would recommend us not discussing this too much until we have more information.\n \n\nJumping a tiny bit ahead, I do find the proposal of using a doc comment on `main` interesting. The downside is if we want to support libraries. \n \n \n \n\nKeep in mind, if they are using a default, we'll be warning them on every script run that its in place. Like I mentioned in my previous post, I would recommend using the feature out as-is if you haven't already. First-hand experience is a big help for these conversations.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-04T18:12:25+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666010652","fragment_type":"issue_comment","sequence":24,"text":"In the same conversation, joshtriplett and I talked about cargo-new\n\nMy main concern with supporting it out of the box is that I want downward pressure on the syntax by not allowing people to bypass it. However, I can be guilty of just copy/pasting my existing scripts just for some annoyances independent of Rust (`chmod` + writing the `#!`) plus I reuse the same deps over-and-over again.\n\nWhen creating a \"script\", we expect it to\n- Add a standard `#!` line\n- `chmod +x` the file\n- Include a manifest with an edition and empty `dependencies` table\n- Include a `main`\n- If nightly cargo is being used, warn that any `+` needs to be added to the script `#!` as well if it will be invoked directly\n - Maybe restrict this warning to not-windows since `#!` is meaningless on Windows\n\nThe question is how to invoke it\n- A flag could work, but what do we name it? I've been avoiding committing to calling these \"scripts\" in the CLI and user-facing documentation but a lot of people will see it that way, e.g. Single-file scripts that download their dependencies\n- We could do it based on a `.rs` extension (`cargo new foo.rs`)\n - This doesn't help if someone wants an extension-less script\n - This might be confusing if someone wanted to name their package that since they will get a file and not the error guiding them on proper syntax (though -rs suffixes are discouraged)\n - Speaking of, multi-file `cargo new` could warn about `-rs` suffixes...","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-04T18:23:36+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[1733342552],"is_known_query_context":false},{"document_id":"gh_comment_1666309927","fragment_type":"issue_comment","sequence":25,"text":"Thank you!\n \n\nNot much, to be honest. But I have plenty of experience with technology breaking as I upgrade it.\nI also have a lot of experience of using older editions, it's not the end of the world.\n\nMy fear is that if we don't make it really easy to specify the edition, the top requested feature around cargo script will be that there to be a way for the warning to be turned off, which is the opposite of what we'd like.\n\nI've also been in the threads when editions were originally discussed, and the big goal there was to not repeat the python2/3 situation. With python, it's comparatively easy to specify the version right in the shebang, with some distributor worries. And I agree that the 40 years concerns rule out that option for us, but something really simple and easy would be great.\n\nSee my `#![edition = \"2021\"]` proposal, it would be the best yet. Yeah it's another way of specifying the edition but I think we can spend some learning budget on making things require less characters. I think for script files, the edition key is the main user of the `[package]` section.\n\nYour point about practical experience is noted though, and I will do some evaluation of the nightly feature. I have a bunch of throwaway projects that would benefit from being in a single file.\n \n\nThat's a fair demand, and something I also share. `#![edition = \"2021\"]` would solve that.\n \n\nTo use your argument about not wanting a default, specifying the edition is practically required today already in multi file projects because cargo is defaulting to 2015 :). Also, people could perceive it as surprising that multi file projects have a different default from single file ones.\n \n\nIMO, it's the best situation to do that because you have a green field. When you introduce a new feature you have a huge design space. I think one shouldn't be cautious with ideas as long as they provide benefit to the users, and they fit in well with existing features. For me, my proposal to treat the first block comment in the file specially (or only the first block comment that is directly after the shebang), is that.\n\nWrt to your points about introducing special comment syntax e.g. `/*% ... */` or `////` possibly requiring a new edition, if you do that from the start, or at least reserve it via erroring if that syntax is encountered, then you don't need a new edition at all. Also, to be clear, it's more or less what I've been asking for, and such a feature would totally satisfy my demands for more brevity :).\n \n\nIMO this is not much of a concern, in general, because syntax highlighting will follow what languages introduce, especially as features get used a lot. Yes, it might take years for it to be adjusted, but shrug, so do new keywords, or removals of such. In general, I think the main concern for language designers wrt syntax highlighting is that it should be easy to express the syntax in the domain specific languages used by syntax highlighters. But I think so far, all proposals support it well.\n \n\nYeah, ideally one brings improvements to both multi-file and embedded manifests. Having toml somewhere in the .rs file is a good idea I think. However, for single things, like the edition, I think it might make sense to add another way, e.g. `#![edition = \"2021\"]`.\n \n\nPersonally I'm not the *greatest* fan of this, because of the many special characters. But it's certainly lower overhead than the rustdoc idea.","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-08-05T00:47:23+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[1733342552],"is_known_query_context":false},{"document_id":"gh_comment_1666337280","fragment_type":"issue_comment","sequence":26,"text":"Thank you, I would appreciate it!\n \n \n\nTo be clear, I was talking about manifest syntax (TOML) and schema (`Cargo.toml` layout) here. Just because we have a wide design space doesn't mean its wise to use it. I'm watching the PEP 722 discussions and they are looking at inventing a new format that is a subset of requirements.txt's syntax when they also have `pyproject.toml`, `setup.py`, and many other ways of doing these things. And yes, I'm not thrilled that we support a subset of the `Cargo.toml` schema and I'm not thrilled that we have defaults beyond `Cargo.toml` but I feel that is better than a completely new format.\n\nAnd following the syntax and schema doesn't mean we can't later introduce shorthands but I think those shorthands should have a direct correlary to the existing syntax and schema. For example, if we offer a deps shorthand, it should use TOML syntax and Cargo.toml schema within that shorthand rather than inventing a new syntax like cargo script did with cargo-deps\n \n\nYes, we do have some flexibility because this is a new place where it can be used.\n\nHowever\n- rustc does not know the context nor should it really to handle that syntax\n- rust-analyzer support is still unclear for how it will detect single-file packages and having the embedded manifest as one indicator could be useful. This means it needs to work with code from both systems\n- At least Josh and I felt that we shouldn't just be inventing some new semantically meaningful comment syntax proprietary to cargo with regex parsers for it but that this should start as an attribute that gets comment rust syntax support if needed\n \n \n\nThis reply is to a subset of my comment. We specifically called out \"on the web\". Yes, dedicated IDE support will handle syntax highlighting for whatever syntax we throw at it but I doubt most random website syntax highlighting systems will unless you happen to be in the fraction of users who use a treesitter based syntax highlighting for your blog or book (or you go through the hassle of manually highlighting the code).\n \n \n\nI've typed out the cargo-script syntax many times and I've written many attributes in other context (and without raw strings), all on US keyboard. For me, attributes feel like a lot more of a hassle because the syntax is so disjoint.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-05T01:32:40+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[1733342552],"is_known_query_context":false},{"document_id":"gh_comment_1666376983","fragment_type":"issue_comment","sequence":27,"text":"I agree that toml is the best way to specify manifests, and that one should not do non-toml stuff in single file scripts. That being said, for the edition one could make an exception IMO, via `#![edition = \"...\"]` (and still allowing toml-specified editions, but never allowing both at the same time).\n\nMy comment was more in response to your points about alternative syntaxes to the rustdoc markdown toml snippets being potentially surprising to users, and a challenge for syntax highlighters/ downstream tooling etc.\n\nThat being said, the specific use of toml commonly seen in `Cargo.toml` might not be optimal for builtin manifests, e.g. in the a recent single file script experiment I made the following snippet, which I really liked:\n\n`rust\n/*!\n\ncargo\npackage = { edition = \"2021\"}\ndependencies = { toml = \"0.7.6\" }\n\n*/\n\n`\n\nThis uses inline tables, and saves two lines compared to the approach with `[package]`, `[dependencies]`, etc. It is not as scalable, but one can mix it like:\n\ncargo\npackage = { edition = \"2021\"}\n[dependencies]\ntoml = \"0.7.6\"\nsyn = \"2.0\"\nserde = \"1.0\"\n\nEspecially for `[package]` I feel it can be turned into an inline table. Most people probably don't want to add repo or docs.rs links to their one-file packages. Maybe the `cargo new` template should use an inline table for `[package]`.\n \n\nHow much of that is motivated by rust parsing library limitations (syn, etc)? IIRC most of the rust parsing libraries don't let you inspect the content of comments. So yeah it's harder to implement, but personally I think that design considerations, aka what the impact of the feature is for the end user is, should have priority over \"is it possible to use syn without modifying it\".\n\nAlso, given that rustc doesn't really need to concern itself with the syntax, why do an attribute first? Rustdoc comments only associate with their respective attributes because of an implementation detail of how the compiler lowers them (exposed to stable, but still, mostly an implementation detail). I don't think one needs to have an attribute first. You could also equally start with the rustdoc+backtick syntax (it would be sad but it would also provide good parsing library support).\n \n\nI agree that that rendering on websites should be a major priority for the design of the feature, because of one of the intended use cases of the feature: sharing of snippets, which happens via the web. Good point that you pointed that out!\n\nBut I also feel that quick editing and brevity of those shared snippets is important, which is where custom comment syntaxes shine. But I doubt that supporting \"is this `/**/` at the start of the file, if yes then treat it as toml\" is harder to add than support for arbitrary markdown in rustdoc comments, then adding snippet support to that, and adding special cases for `cargo` annotated snippets. For me, \"`/**/` but at the start of the file\" comments or `/*% */` ones seem easier to support.\n\nE.g. github's highlighter doesn't support markdown snippets at all, it just treats rustdoc as random rust comment.\n \n\nI have a german keyboard, and yeah `[]` is a bit tough to type. But I still think it's easier to type a bunch of special characters than to type out `cargo` and another slightly easier to type set of special characters :). Also, in most instances one doesn't need raw string literals for the toml, as toml supports ' strings, another possible deviation of what multi file toml projects are doing that is still within valid toml syntax.","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-08-05T03:53:06+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666434340","fragment_type":"issue_comment","sequence":28,"text":"@est31 The rationale for not having semantically meaningful ordinary comments had nothing to do with parsing, and everything to do with user expectations. Users are used to doc comments being parsed, having doctests in them, etc. *Regular* comments are completely ignored with no semantic effect, and that creates user expectations that comments are *their* space, not to be impinged on by compiler expectations.\n\nRegarding the edition, I've been hoping we can allow omitting `package`, which makes the syntax less verbose:\n\nrust\n//! \ncargo\n//! edition = 2024\n//! \n\nShortening that to just `#![edition = 2024]` feels like it special-cases *one* attribute in a way that invites people to assume they can do the same for all the other package attributes, which will then produce an error unless we make all of those work too.","author_login":"joshtriplett","author_association":"MEMBER","created_at":"2023-08-05T08:08:29+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666443458","fragment_type":"issue_comment","sequence":29,"text":"You don't even need an inline table for this\n\ntoml\npackage.edition = \"2021\"\n[dependencies]\ntoml = \"0.7.6\"\nsyn = \"2.0\"\nserde = \"1.0\"","author_login":"Nemo157","author_association":"MEMBER","created_at":"2023-08-05T08:45:58+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666526775","fragment_type":"issue_comment","sequence":30,"text":"I don't see this as an exception to the syntax/schema guidance i gave but aligns with the \"but we can allow shorthands that align opon syntax/schema in the future\". The future being a key part. \n\nIn addition to wanting to defer shorthands, my other concern is that the \"edition\" concept is also present in Rust. I think a proposal for an `edition` attribute has to make sense in at the rust level, independent of cargo.\n\n---\n\nwe could consider `package.edition = \"2021\"` for `cargo new`. The main question I would have is if/when we add support for libs where there might be other fields, like enabling publishing, would we instead want `[package]` and should we be consistent in style.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-08-05T14:55:06+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666559904","fragment_type":"issue_comment","sequence":31,"text":"About using doc comments: if it's not meant to be used by rustdoc, I don't think it should use this syntax.\n\nI personally like the `cargo` attribute approach.\n \n\nThe logic is good but I don't agree with the origin of this logic: doc comments are used by rustdoc and that's it. This new content will be used by cargo, therefore using doc comments to handle this feature is not the right approach in my opinion.","author_login":"GuillaumeGomez","author_association":"MEMBER","created_at":"2023-08-05T17:27:53+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666572417","fragment_type":"issue_comment","sequence":32,"text":"@GuillaumeGomez They're also used by doctests, which from a user's perspective are just an integrated part of `cargo test`.\n\nI agree that if we want rustdoc to ignore and not process them, we shouldn't use doc comments. But I don't think we want rustdoc to ignore them.","author_login":"joshtriplett","author_association":"MEMBER","created_at":"2023-08-05T18:14:18+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666588335","fragment_type":"issue_comment","sequence":33,"text":"From user's perspective, doc comments are used by `cargo doc`, so that's not a good argument. But in any case, doctests and doc comments are handled by rustdoc.\n \n\nI don't see why: we don't display cargo information directly, only a small subset provided through command line arguments. Therefore, it wouldn't be coherent in this regard.","author_login":"GuillaumeGomez","author_association":"MEMBER","created_at":"2023-08-05T19:36:08+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666603188","fragment_type":"issue_comment","sequence":34,"text":"@joshtriplett \n \n\nThat's an interesting proposal. I think it makes a lot of sense. I guess your proposal is to make it possible to specify *all* keys in the `[package]` table at the top level? Still makes sense IMO.\n \n\nThey might think that but IMO the benefit of being able to specify it without having to specify a manifest is worth this cost.\n \n\nPersonally, to me it seemed like a rough edge of this proposal that users have to include the manifest in the documentation output of their crate, in a way separate from multi-file crates (in general I think that rustdoc displaying the manifest and especially the cargo features is a good idea, but it should be something that multi-file crates support, and it should not automatically be at the main page). It seemed only like a rough edge though as one can always add syntax to not display it, or just not make rustdoc process it at all. But IMO, any toml display feature of `cargo doc` should also include multi file crates. I felt and feel much more strongly about the verbosity though.\n\n@epage \n \n\nI think outside of the edition and github links, most of the required stuff can be inferred. Authors aren't a thing we suggest any more, and crate descriptions can be inferred from the rustdoc (take the first line of the crate-level rustdoc).\n \n\nFair point. Personally I'm concerned less about the impact the edition behaviour has on the cargo part but about the impact it has on the Rust part: from my POV, cargo doesn't have as many breaking changes on edition boundaries as Rust has, and is also a major source of breakage of its own through crate updates (not cargo's fault obv). The edition is controlled via cargo though as cargo passes the edition flag.\n\nAnd yeah, if one adds an `#![edition = \"...\"]` attr to cargo-script, it should also be added to Rust, and vice versa, cargo-script should probably understand `#![edition = \"...\"]` attrs. I suppose this means that rustc should forbid hiding it behind `cfg_attr` like is being proposed for crate_name and crate_type.\n\nThanks for giving me the pointers, I guess I should be knocking the doors of T-lang and/or T-compiler about this attr.","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-08-05T20:55:59+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666806624","fragment_type":"issue_comment","sequence":35,"text":"I'm all in favour of displaying more information. However I think it should be passed through arguments to rustdoc instead of having rustdoc to retrieve the information from the toml file.\n \n\nIt's very strange to try to hide a doc comment only for this use case. What if users use the same code block syntax and suddenly it doesn't appear anymore because of this feature? Sounds like a very bad user experience and a very weird corner case.","author_login":"GuillaumeGomez","author_association":"MEMBER","created_at":"2023-08-06T10:28:22+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722211363","fragment_type":"issue_comment","sequence":36,"text":"Can we unblock the `lib` section in `cargo script`? Maybe with some limitations. \n\nMy main use case for this - is a scripting system for game engine. Currently using rust with wasm target for use cases like this is not very comfortable. You need to create a separate crate for every game entity (player crate, enemy crate, etc.) and compile to wasm `cdylib` to use it with `wasmtime` (or any other runtime).\n\nJust for example, if you select `lua` for scripting purposes, only what you need is to create a .lua file.\n\nSingle file library with dependency will greatly improve the user experience for scripting use cases.\n\nMaybe this use case is out of scope for `cargo-script`?","author_login":"Gordon-F","author_association":"NONE","created_at":"2023-09-16T11:39:26+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722236489","fragment_type":"issue_comment","sequence":37,"text":"Lib support will be interesting however a lot of people have their own pet feature they want for this (lib, workspace support, doctest support, example support, etc). We decided it was important to narrow our focus on an MVP so we can get this through faster, particularly to keep to a minimum the number of decisions we have to make at once as this is already a very large (by decision count) feature and a good number involve a high amount of discussion.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-09-16T13:59:40+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722338559","fragment_type":"issue_comment","sequence":38,"text":"We made progress on syntax for embedding manifests. See the T-lang thread for more details.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-09-16T23:19:07+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722388630","fragment_type":"issue_comment","sequence":39,"text":"As was discussed in the mentioned Zulip thread, we should leave the door open for embedding files other than `Cargo.toml`. By \"leave the door open\", I mean that we should leave ourselves the *option* to support this later in a consistent way.\n\nIt's important to leave this door open because we'll likely learn things after we stabilize this. We may learn, e.g., that the ability to inline the `build.rs` or `.cargo/config.toml` file is critical to some important use-cases that we had not sufficiently considered. If we close this door, then fixing it later becomes more difficult and may result in a worse or less consistent end result.\n\nConcretely, I propose that we include the name of the file with each frontmatter section. Using the Markdown-like syntax that has been proposed, this might look like this:\n\n`rust\n#!/usr/bin/env cargo\n\ncargo file=\"Cargo.toml\"\n[dependencies]\nfoo = \"1.2.3\"\n\nfn main() {}\n\n`\n\nEven aside from its purpose in leaving the door open for future evolution, this seems net-better today in terms of clarity.\n\n---\n\nIn the thread, it was proposed that we could spell this as follows:\n\n`rust\n#!/usr/bin/env cargo\n\nCargo.toml\n[dependencies]\nfoo = \"1.2.3\"\n\nfn main() {}\n\n`\n\nThis would be slightly worse in terms of supporting possible future evolution. For one thing, it's conceivable that other tools may want to use frontmatter sections (e.g. `rustup` or third-party tools), so there should be some way to unambiguously distinguish the tool for which the frontmatter section is intended.\n\nSecondly, it's conceivable that someday `cargo` could want to use such a section to accept data other than a source or config file. E.g., it could use this to accept arguments to `cargo` (something that was earlier discussed on this thread) or arguments to be passed to `rustc`. E.g.:\n\n`rust\n#!/usr/bin/env cargo\n\ncargo rustc-arguments\n-C target-cpu=native\n\ncargo file=\"Cargo.toml\"\n[dependencies]\nfoo = \"1.2.3\"\n\nfn main() {}\n\n`\n\n----\n\nAgain, I want to reiterate, I'm not proposing that any of these features necessarily be included in the RFC or in the initial stabilization. I'm proposing only that we choose a syntax that's expressive and flexible enough to allow us the *option* of adding these later in a consistent and graceful way.","author_login":"traviscross","author_association":"NONE","created_at":"2023-09-17T04:27:24+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1723695391","fragment_type":"issue_comment","sequence":40,"text":"Separate from that is the question as to the infostring that cargo should be using.\n\nWe need to keep in mind our motivating use cases and that a solution does not run counter to that. Requiring `cargo file=\"Cargo.toml\"` feels a lot more bloated and more places to get things wrong. I give that not to shutdown the conversation but as an example of the constraints we have to work in.\n\nSo far, the cargo team has been most interested in leaving the door open for `Cargo.lock`, so I will focus on that case so we don't get side tracked with other potential features that we may or may not want to close the door on as that is a separate conversation.\n\nThe main problem with using `Cargo.lock` with frontmatter syntax is it bloats the \"header\" of the source; people have generally wanted this boilerplate at the bottom.\n\nI see a couple different ways of leaving the door open with the code fence frontmatter\n\n### Info strings\n\nFile names\n\n`md\n\nCargo.toml\n\n`\n\nAttribute, defaulted for `Cargo.toml`\n\n`md\n\ncargo,file=Cargo.toml\n\n \n\ncargo\n\n`\n\nGenerally infostrings describe a format using a name. From that lens, I dislike both approaches.\n\nThe question is whether the initial RFC / implementation should use `cargo` or `Cargo.toml`. Anything past that can be handled in future change proposals or RFCs.\n\n### Syntax\n\nDistinct blocks, maybe with newlines\n\n`md\n\nCargo.toml\n\nCargo.lock\n\n`\n\nContinuous blocks\n\n`md\n\nCargo.toml\n\nCargo.lock\n\n`\n\nDistinct blocks is more like the source inspiration, markdown, though has more noise, places to get things wrong, and syntax questions (newlines).\n\nBoth can be added at a later point and don't need to be in the initial RFC / implementation.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-09-18T15:21:36+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1728128078","fragment_type":"issue_comment","sequence":41,"text":"Looking back over this, once we have #12681 in people's hands to try it out, I feel like most of the \"hard\" decisions will be resolved with and that we'll be ready to get post a RFC for approval. Concurrent to that, we can still work on finishing up the last of the tasks as I don't expect them to uncover new information.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-09-20T17:06:57+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1728513747","fragment_type":"issue_comment","sequence":42,"text":"To give my two cents, regarding the direct three backticks proposal, personally I like it way more than the doc comment plus three backticks proposal. I could live with the naked three backticks. Most importantly it's shorter and doesn't piggy back on the existing concept that exists for documentation.\n\nMy preferred solution would still be sth like `/*% */` or `/*~ */` that would otherwise work the same to the three backticks (special first line that has the optional filename which is also just a reserved feature for now). It doesn't have to compile down to attributes (although they don't seem like a bad option), it could also compile down to `builtin # toml (\"toml here\")` or something like that: I and I think most users would be more interested in the end result. Whether it's temporarily an attribute or something different seems like an implementation detail to me, even if that is mentioned in the reference.\n\nExisting highlighters will highlight `/*% */` or such as *something* and not be disturbed by the construct itself or the sudden toml. It would also be supported by the compiler. But to repeat, backticks are definitely major progress to me. They are character count wise even cheaper than `/*% */`. Latter would fit better into existing rust programs however.","author_login":"est31","author_association":"CONTRIBUTOR","created_at":"2023-09-20T22:36:42+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1775753853","fragment_type":"issue_comment","sequence":43,"text":"Not sure if this is the right place for this note, but `std::env::current_exe` in a `Zscript` script returns e.g. `/home/rhart/.cargo/target/51/634a27a4e923f1/debug/build-`, which isn't very intuitive. `current_exe`'s doc allows for returning a \"platform-specific\" path in some cases, so it seems it might be nice to return the path to the script being invoked? Not sure if it's possible to override that behavior for scripts.","author_login":"novafacing","author_association":"NONE","created_at":"2023-10-23T18:14:18+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1775787193","fragment_type":"issue_comment","sequence":44,"text":"@novafacing could you create an issue so we can discuss the ins and outs more easily than interspersing in the tracking issue or RFC?","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-10-23T18:35:16+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1776031082","fragment_type":"issue_comment","sequence":45,"text":"Just curious, but would incremental compilation work with single-file scripts (maybe it can be cached inside `~/.cargo`)? Or would it always be re-compiled from a scratch?","author_login":"musjj","author_association":"NONE","created_at":"2023-10-23T21:13:38+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1776089794","fragment_type":"issue_comment","sequence":46,"text":"Each cargo script keeps a target directory in `~/.cargo/target` with a path determined by a hash of the file path. This makes it so performance optimization done for a regular package would work here, including incremental compilation","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-10-23T22:00:37+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1822656673","fragment_type":"issue_comment","sequence":47,"text":"A question: Is it possible to run scripts using in release instead of debug?","author_login":"ndavd","author_association":"NONE","created_at":"2023-11-22T12:11:39+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1822895518","fragment_type":"issue_comment","sequence":48,"text":"The main option is to edit debug profile to look like release.\n\nThis is under discussion in the RFC","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-11-22T14:38:43+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823506530","fragment_type":"issue_comment","sequence":49,"text":"An outstanding item for me is to look into how we should handle symlinks. My guess is we'll resolve them so the manifest dir will be after resolving symlinks.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2023-11-22T21:10:00+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872903768","fragment_type":"issue_comment","sequence":50,"text":"@epage How could I be useful to the testing of this feature when it's ready for that?\n\nI've rewritten dozens of my varied Ba/sh scripts in Rust; currently with URL The result is mostly as excellent as I had expected. I look forward to migrating them to the official solution, and I have some thoughts regarding a polished experience that may add value.","author_login":"kellytk","author_association":"CONTRIBUTOR","created_at":"2023-12-31T09:30:37+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1877652079","fragment_type":"issue_comment","sequence":51,"text":"@kellytk we actually have had a call for testing dating back to June but I realized that isn't obvious so I added a prominent link to the issue. I've made some minor edits.\n\nIt'd be particularly interesting to see what your impressions are from\n- Porting some scripts and using them\n- Writing new scripts and using them\n\nI use a `nargo` script that wraps `cargo +nightly -Zscript` to make the experience more like the stable version.\n\nIn a couple of days, nighties will start supporting multiple (undocumented) syntaxes as we do final experimentation on what works best. If next week you can update your nightly and give them a try, that would also be great!\n\n`rust\n#!/usr/bin/env -S cargo +nightly -Zscript\n\n[dependencies]\nclap = { version = \"4.2\", features = [\"derive\"] }\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\n`\n(currently documented syntax but now with optional infostring)\n\n`rust\n#!/usr/bin/env -S cargo +nightly -Zscript\n---\n[dependencies]\nclap = { version = \"4.2\", features = [\"derive\"] }\n---\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\n`\n\n`rust\n#!/usr/bin/env -S cargo +nightly -Zscript\n###\n[dependencies]\nclap = { version = \"4.2\", features = [\"derive\"] }\n###\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\n`\n\n`rust\n#!/usr/bin/env -S cargo +nightly -Zscript\n## [dependencies]\n## clap = { version = \"4.2\", features = [\"derive\"] }\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\n`\n\nNote: the upcoming nightly removes doc-comment support after a several months transition period and as we don't seem to need further feedback on that syntax.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-01-04T19:32:35+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1955786166","fragment_type":"issue_comment","sequence":52,"text":"I get this error when porting from `fornwall/rust-script`.\n\ndiff\nModified age\n@@ -1,4 +1,4 @@\n-#!/usr/bin/env rust-script\n+#!/usr/bin/env -S cargo +nightly -Zscript\n \n //! Age\n //!\n@@ -17,15 +17,15 @@\n //! \n\n //! $ rustfmt age\n //! \n\n-//!\n-//! \ncargo\n-//! [dependencies]\n-//! chrono = \"0.4.34\"\n-//! chrono-humanize = \"0.2.3\"\n-//! owo-colors = \"4.0\"\n-//! num-format = \"0.4\"\n-//! anyhow = \"1.0\"\n-//! \n\n+\n+---\n+[dependencies]\n+chrono = \"0.4.34\"\n+chrono-humanize = \"0.2.3\"\n+owo-colors = \"4.0\"\n+num-format = \"0.4\"\n+anyhow = \"1.0\"\n+---\n\nrust\nwarning: `/home/user/.cargo/config` is deprecated in favor of `config.toml`\nnote: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`\nwarning: `package.edition` is unspecified, defaulting to `2021`\n Compiling age v0.0.0 (/home/user/opt/bin)\nerror: expected item, found `-`\n --> age:21:1\n |\n21 | ---\n | ^ expected item\n |\n = note: for a full list of items that can appear in modules, see < URL \n\nerror: could not compile `age` (bin \"age\") due to 1 previous error\n\n🐡 ❯ rustup toolchain list\nstable-x86_64-unknown-linux-gnu (default)\nnightly-2023-06-18-x86_64-unknown-linux-gnu\nnightly-x86_64-unknown-linux-gnu\n1.73.0-x86_64-unknown-linux-gnu","author_login":"azzamsa","author_association":"NONE","created_at":"2024-02-21T02:59:01+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1955799256","fragment_type":"issue_comment","sequence":53,"text":"@azzamsa newlines before the code fence are not yet supported within cargo. That was an addition to the RFC after we implemented these approaches and it doesn't seem like updating it will help gain new insight, so I've left it as-is until the RFC is approved.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-02-21T03:13:34+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1955837476","fragment_type":"issue_comment","sequence":54,"text":"any lines at all between the `#!` shebang line and the code fence are not supported. in the future only blank lines will be allowed between them. you seem to have a bunch of doc comments which aren't supported, so you need to move the code-fenced Cargo.toml section to right after the shebang line and before any rust comments.","author_login":"programmerjake","author_association":"MEMBER","created_at":"2024-02-21T03:49:30+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1967766775","fragment_type":"issue_comment","sequence":55,"text":"I've written a couple rust scripts now in cases where I need more consistent, programmatic control than a (more often easier) shell script could provide in a few cases e.g., parsing TOML without acquisition of additional tools.\n\nIn those cases, however, it's incredibly useful to write the source in an editor e.g., VSCode + rust-analyzer to have the benefits of an LSP, linting etc. To that end, neither front matter supported now allow for that because of syntax errors:\n\n`\n\ncargo\n[package]\nedition = \"2021\"\n\n`\n\nOr:\n\n---\n[package]\nedition = \"2021\"\n---\n\nUnless the eventual idea is that all tools including `rustc`, `rust-analyzer`, etc., support - even just ignore - this front matter section, writing scripts in an editor is impossible. At leat you have to comment it out and, if you have dependencies, need a `Cargo.toml`. From the current tracking items, it seems solving the latter is on the radar, but it'd be great to consider solving the former. As of now, it seems the idea is to not support commands, depending on what \"Remove doc-comment support\" means exactly.\n\nGiven the use of code fences in the first case above (though it seems the second case is the way forward, yes?), couldn't `cargo` support triple slashes e.g.,\n\nrust\n#!/usr/bin/env -S cargo +nightly -Zscript\n/// \ncargo\n/// [package]\n/// edition = \"2021\"\n/// \n\nfn main() {\n todo!()\n}\n\nAt least until dependency resolution is sorted, this would support opening scripts in an editor using an LSP.","author_login":"heaths","author_association":"NONE","created_at":"2024-02-27T22:28:45+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1967815470","fragment_type":"issue_comment","sequence":56,"text":"The plan is to add the syntax to the Rust language. An RFC exists for this. Once one more T-lang team member checks a box, FCP will start.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-02-27T22:46:27+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1986564690","fragment_type":"issue_comment","sequence":57,"text":"is there a way to use features or other cfg stuff when using `cargo +nightly -Zscript ./hello_world.rs`? like if I have this:\n\n`rs\n#!/usr/bin/env -S cargo +nightly -Zscript\n\ncargo\n[features]\nhi = []\n\nfn main() {\n #[cfg(feature = \"hi\")]\n println!(\"hi\");\n println!(\"hello world\");\n}\n\n`\n\nhow would I run it with the `--features=hi` flag?\n\nsh\njcbhmr@PIG2016:~/Documents/test343$ cargo +nightly -Zscript ./hello_world.rs --features=hi\nwarning: `package.edition` is unspecified, defaulting to `2021`\n Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.07s\n Running `/home/jcbhmr/.cargo/target/aa/3b09aa9f783bc3/debug/hello_world --features=hi`\nhello world\njcbhmr@PIG2016:~/Documents/test343$ cargo +nightly -Zscript --features=hi ./hello_world.rs\nerror: unexpected argument '--features' found\n\nUsage: cargo [+toolchain] [OPTIONS] [COMMAND]\n cargo [+toolchain] [OPTIONS] -Zscript [ARGS]...\n\nFor more information, try '--help'.\n\n☝️ particularly the `cargo +nightly -Zscript --features=hi ./hello_world.rs` one; that one i really hoped would work\n\ni looked at the env var list URL and couldn't find a Ctrl+F match for \"feature\" that would let me do like `CARGO_FEATURES=hi cargo +nightly -Zscript ./hello_world.rs` either 🤷‍♀️\n\nany help appreciated. ❤️","author_login":"jcbhmr","author_association":"NONE","created_at":"2024-03-08T23:31:29+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1986651942","fragment_type":"issue_comment","sequence":58,"text":"Yes, cargo scripts are meant to work with any cargo command, so cargo run works.\n\nWhat is your use case for wanting this on the shebang? My assumption is if you want it when you run it should be a default feature and likely if you use features, you're use case is likely big enough for a multi-file package.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-03-09T00:55:48+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2036105829","fragment_type":"issue_comment","sequence":59,"text":"How would the one maintain the dependencies?\nHow would you import a module from foo.rs?","author_login":"beckend","author_association":"NONE","created_at":"2024-04-04T03:28:09+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2036928783","fragment_type":"issue_comment","sequence":60,"text":"Could you clarify what you mean by \"maintain dependencies\"? In general, we expect tooling to manage embedded manifests like regular ones.\n\nAs for importing a `foo.rs`, that is broken right now when dependencies are used due to a hack we use to get dependencies working. You would `mod foo;` just like from a `main.rs`. However, that would be discouraged as the point of these is to be single file. If you need to `mod` something, why not have a full package?","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-04-04T11:36:00+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037003906","fragment_type":"issue_comment","sequence":61,"text":"\"maintain dependencies\"\nCan I do:\n\ntoml\nonce_cell = { workspace = true, default-features = false }\n\nCan I use `cargo update`?\n\nI would disagree on the limitation of not having the ability to use a module, to be able to externalize some code and import that module makes it much cleaner.","author_login":"beckend","author_association":"NONE","created_at":"2024-04-04T12:07:47+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037176136","fragment_type":"issue_comment","sequence":62,"text":"`cargo update` should already work.\n\n`workspace = true` does not work yet because workspace support is out of scope for the initial release.\n\n`cargo add` will be supported on release. Support is waiting on the syntax RFC being approved.\n\nAs for `mod`, I did not say it wouldn't be supported. I said it would be discouraged. Its still not clear why you'd use an embedded manifest over `Cargo.toml` if you are using external files. A large point of these is to be single file for easy sharing and there are features we are explicitly not supporting, like `build.rs`.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-04-04T13:10:16+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037482876","fragment_type":"issue_comment","sequence":63,"text":"I see almost no discussion around release/optimized mode (except \"This is under discussion in the RFC\" (above) and merged commit adding \"option to generate release mode profile\") which I find pretty important, so I want to express my view on this subject:\n\nWhile manually setting all parameters in the `[profile.dev]` section to be the same as in release mode or just using the \"option to generate release mode profile\" kinda does that, I don't think this is an optimal solution.\n\nAdding `--release` and `-r` flags looks to me like a much more solid solution to the problem. Or perhaps maybe even add support for arbitrary profiles (using `--profile`), same as for the usual `cargo run`, for maximum flexibility.\n\nThis allows users to iterate much faster when developing or experimenting with a script, while not compromising performance when the script is done, and all of this is just by simply adding or removing the `--release` flag to the shebang, unlike the current solution, where you have to manually edit all of the desired flags in \"`Cargo.toml` part\" of the script.","author_login":"dmyTRUEk","author_association":"NONE","created_at":"2024-04-04T15:12:25+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037544691","fragment_type":"issue_comment","sequence":64,"text":"Rather than dividing the conversation, I'd recommend focusing it at URL","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-04-04T15:37:38+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2089904310","fragment_type":"issue_comment","sequence":65,"text":"How is this supposed to work on Windows?\n\nWill rustup extend `PATHEXT` upon installation and associate `.rs` files with `cargo`?\n\nIn this case all Rust source files would become executable, which is confusing, especially when using Windows Explorer.\n\nI think it might be better to use a separate extension, for example `.rsc` for Rust SCript, to ensure that the experience on Windows will not lack behind.","author_login":"surban","author_association":"NONE","created_at":"2024-05-02T08:35:34+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2090141845","fragment_type":"issue_comment","sequence":66,"text":"How does python handle this on Windows? They don't use a separate extension for executable and non-executable files either.","author_login":"bjorn3","author_association":"MEMBER","created_at":"2024-05-02T10:33:19+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2090304975","fragment_type":"issue_comment","sequence":67,"text":"True, but it doesn't mean we have to follow them if we can do better.","author_login":"surban","author_association":"NONE","created_at":"2024-05-02T11:48:34+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2090437747","fragment_type":"issue_comment","sequence":68,"text":"All `*.py` files are executable, scripts *and modules* alike. So I would be hesitant to suggest taking inspiration from Py, but I'm unsure if there's a better alternative than simply using a different file-ext.\n\nMS should definitely add shebang (and magic-numbers) support to Windows! It's overdue since many years ago","author_login":"Rudxain","author_association":"NONE","created_at":"2024-05-02T12:56:47+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091211384","fragment_type":"issue_comment","sequence":69,"text":"They won't do that because it does not make sense on Windows, since the interpreter can be in an installation-dependent place and is not necessarily found in `PATH`. The Windows mechanism is not inherently bad, just different from UNIX.","author_login":"surban","author_association":"NONE","created_at":"2024-05-02T18:17:24+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2091960347","fragment_type":"issue_comment","sequence":70,"text":"well, magic number support can look for a file starting with `#!/usr/bin/env cargo` and send that to wherever cargo is installed, no shebang support needed","author_login":"programmerjake","author_association":"MEMBER","created_at":"2024-05-03T00:40:27+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2358784551","fragment_type":"issue_comment","sequence":71,"text":"Hi @epage, as a daily user of `cargo-script`, I really want to help advance and stabilize this feature. (Thank you all for working on this feature.) What can I do to help? Is there anything you would suggest for me to get started?","author_login":"Rustin170506","author_association":"MEMBER","created_at":"2024-09-18T15:27:57+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2358818671","fragment_type":"issue_comment","sequence":72,"text":"@Rustin170506 any of the tasks in the task list without a PR is good for grabbing.\n\nSome clarifications\n \n\nThe use case for this is that we allow `cargo Cargo.toml` but putting a `#!` in `Cargo.toml` only works well if you symlink it into `path` with the name of the bin.\n\nI had wondered if we should do just always resolve symlinks but that breaks some use cases. Instead, when determining whether its embedded or not and there is no extension, we should resolve it to see what the \n \n\n URL \n\nWhen we talked about this as a Cargo team, we decided this need to reload to cargo home, like `cargo install` does, to avoid downloading a script and being subject to spurious files in your `~/Downloads`, at the cost of losing the config from your repo.\n \n\nThis might require an RFC but likely a trivial one\n \n\nThis will be messy. We'll likely need to change `SourceId` to include the file name if it has an embedded manifest.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-09-18T15:41:32+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2358845973","fragment_type":"issue_comment","sequence":73,"text":"One thing that occurred to me while just reading this is:\n\nShould cargo check for a Mark of the Web when running/building scripts on Wwindows/NTFS-drives?","author_login":"Skgland","author_association":"NONE","created_at":"2024-09-18T15:53:54+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2468294531","fragment_type":"issue_comment","sequence":74,"text":"Not sure if this is the right place to discuss implementation details, but I wanted to ask if the output makes sense.\n\nshell\n$pwd\n/Users/rustin/code/rs-scripts\n\n$ls\nsql.rs sql1.rs sql2.rs sql3.rs sql4.rs sql5.rs sql6.rs sql7.rs sql8.rs sql9.rs\n\n$cargo pkgid sql2.rs\npath+file:///Users/rustin/code/rs-scripts/sql2.rs#embedded","author_login":"Rustin170506","author_association":"MEMBER","created_at":"2024-11-11T14:21:00+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2468338550","fragment_type":"issue_comment","sequence":75,"text":"@Rustin170506 I feel like there might be enough discussion on that that maybe we should create a dedicated issue?","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2024-11-11T14:40:57+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2634933165","fragment_type":"issue_comment","sequence":76,"text":"#14961 added a test, pointing out how `cargo install --path foo.rs` behaviors (errors). I've added support for this as an open question. I lean towards supporting it as it seems relatively innocuous and our overall goal is \"behaves like a regular package\" with cases like workspace membership, packaging support, etc being explicitly deferred out.\n\n@Rustin170506 since you were just dealing with that stuff, would be interested in your thoughts and if you want to pick that work up.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2025-02-04T19:56:57+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2711402159","fragment_type":"issue_comment","sequence":77,"text":"I realized that we hadn't fully noted the status of symlinks.\n\nPast notes\n- URL \n- URL \n- Removed from the tracking issue on Oct 11 after #14670 was merged\n\nThe original emphasis for symlinks was in case we supported `cargo Cargo.toml` so your `Cargo.toml` could have a `#!` and you could create a symlink to it from your `bin` directory. However, if we resolve the symlinks for `manifest-path` immediately, it has the potential to break some use cases.\n\nAnother potential reason for resolving symlinks is so that two references to a project get the same target directory. We could restrict this to only when we are generating the hash for the target directory. As our target directory location is an implementation, what we do is a two-way door. Its unclear what the right answer is. If someone symlinks a manifest or a parent directory, are they expecting isolation or consistency?","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2025-03-10T17:58:26+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[1733342552],"is_known_query_context":false},{"document_id":"gh_comment_2711961097","fragment_type":"issue_comment","sequence":78,"text":"With symlinks, I'd always expect consistency. That is, I'm expecting the path to be canonicalized.","author_login":"traviscross","author_association":"NONE","created_at":"2025-03-10T22:10:47+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3151833946","fragment_type":"issue_comment","sequence":79,"text":"For those looking to use this functionality today, I wrapped it lightly as URL to add two tweaks:\n\n1. It caches the _path_ to the compiled (release by default) binary after the first run and directly exec-s it if mtime or the file's content hash have not changed. Without this, all scripts with the `-Zscript` shebang took ~200ms to start for me, with this they're ~5ms.\n2. It can be used as a trivial shebang `#!/usr/bin/env scriptr`, including on files that have no `.rs` extension.\n\nI hope that I didn't misunderstand a way to make `cargo -Zscript` itself behave this way, but I've endeavored to keep the wrapper tiny.\n\nIt's just <300 lines of trivial Rust wrapping the nightly script runner and keeping everything including its target directory behavior, running the binary directly from where `cargo -Zscript` ordinarily builds it, so that it's fully interoperable with the built-in runner.\n\nI'm super excited for this to be in and default-available everywhere, but... this is the tiniest workaround that seems to make this palatable for now.","author_login":"tekacs","author_association":"NONE","created_at":"2025-08-04T18:00:00+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3151869669","fragment_type":"issue_comment","sequence":80,"text":"@epage I would absolutely love and prefer that. Just patching over until we do so!","author_login":"tekacs","author_association":"NONE","created_at":"2025-08-04T18:12:20+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3365723034","fragment_type":"issue_comment","sequence":81,"text":"#15975 is the issue that fixed not being able to have whitespace between hashbang and dependency fence? If so, thank you whoever did that!","author_login":"andar1an","author_association":"NONE","created_at":"2025-10-03T13:39:33+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3365736034","fragment_type":"issue_comment","sequence":82,"text":"Hi!\nI don't know how late we are in the stabilization process of this feature but I just wanted to inform you that this new syntax (in comparison to `rust-script`) breaks the use of nix' multiline shebangs.\n\nCombining rust's and nix' shebang is an amazingly powerful combination (when using `rust-script`) and it's a shame it doesn't work with `cargo-script`.\n\nHere's the report on the nix side: URL \n\nAn easy fix from the cargo side would be to allow rust multiline comments `/* */` to be placed before the cargo file content, like so:\n\nrust\n#!/usr/bin/env nix\n/*\n#! nix shell github:oxalica/rust-overlay#rust-nightly --command sh -c ``cargo -Zscript $0``\n*/\n---cargo\n[dependencies]\ntime = \"0.1.25\"\n---\n\nfn main() {\n for argument in std::env::args().skip(1) {\n println!(\"{}\", argument);\n };\n println!(\"{}\", std::env::var(\"HOME\").expect(\"\"));\n println!(\"{}\", time::now().rfc822z());\n}","author_login":"PaulGrandperrin","author_association":"NONE","created_at":"2025-10-03T13:43:32+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3365748518","fragment_type":"issue_comment","sequence":83,"text":"No, that was changed much earlier\n\nBlank lines were specified as allowed in the RFC while comments were specified as not allowed. The problem with comments is that makes this feature more dependent on the syntax of Rust which we are specifically trying to limit to make it easy for any tool to interact with this.\n\nimo the best way to think of this is that it is part of the shebang. We had even considered using `#` to further cement this. Originally, blanklines weren't even going to be allowed but we loosened that up after observing people being sloppy about that and getting surprising behavior.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2025-10-03T13:47:21+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3365772924","fragment_type":"issue_comment","sequence":84,"text":"Yes, it has been a while since I have tinkered with this, but I remember being shocked by the behavior. \n\nIt is common for scripts to have details at the top which is why I am curious. If you allow white space, than it feels intuitive that comments should be allowed, but one can easily put comments within the dependency fence block it seems.\n\nI think an discussing for showing how one should comment their script may be a nice addition to docs eventually.","author_login":"andar1an","author_association":"NONE","created_at":"2025-10-03T13:55:07+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3365798280","fragment_type":"issue_comment","sequence":85,"text":"@PaulGrandperrin URL also answers your question to a degree. Looking around, it seems this problem is not unique to Cargo.\n\ndlang's dub has single-file packages and in looking at their parser, it appears to be required to be in the first comment of the file.\n\nIt sounds like Python's inline script metadata would work as it seems to be agnostic of comment order.\n\nMay be useful to review URL which includes first-party and third-party solutions for many languages","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2025-10-03T14:01:39+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[1733342552],"is_known_query_context":false},{"document_id":"gh_comment_3365838112","fragment_type":"issue_comment","sequence":86,"text":"I personally like that thinking, the only nice part about whitespace in this form is aesthetic, and it leaves room for user error. I would personally agree with no whitespace between, and highlighting that shell style comments are possible within the dependency fence because toml uses the same comment syntax as shell?\n\ncan end up looking like:\n\nsh\n#!/usr/bin/env -S cargo +nightly -Zscript\n---cargo\n# Script Name: example_script.rs\n# Author: Your Name\n# Date: MM/DD/YYYY\n# Copyright (c) 2023 Your Company or Name. All rights reserved.\n# Description: A brief description of what the script does.\n\n[dependencies]\nclap = { version = \"4.2\", features = [\"derive\"] }\n---\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}","author_login":"andar1an","author_association":"NONE","created_at":"2025-10-03T14:11:31+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3365923987","fragment_type":"issue_comment","sequence":87,"text":"Note that `#` is already a token in Rust and there is a special case for it in the grammar to work with shebangs which works because of how constrained shebangs typically are. To generalize it for any content like this might not even work.\n\nI also feel like this is an independent enough language proposal that someone can work on it without blocking cargo script.","author_login":"epage","author_association":"CONTRIBUTOR","created_at":"2025-10-03T14:29:34+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3403705194","fragment_type":"issue_comment","sequence":88,"text":"I agree that hermetic/offline builds and isolation (principle-of-least-privilege) are very important, but I'd suggest that it's so important that this concern should be solved more broadly for all of `cargo` not only for `cargo-script`","author_login":"jokeyrhyme","author_association":"NONE","created_at":"2025-10-14T21:38:03+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3413117020","fragment_type":"issue_comment","sequence":89,"text":"Awesome, I needed to update your example to run. looking forward to testing. have shared with our taem\n\n1. add `-Zscript` in shebang line\n2. add `derive` feature to clap, to compile\n\nrs\n#!/usr/bin/env -S cargo +nightly -Zscript\n---cargo\n[dependencies]\nclap = { version = \"4.2\", features = [\"derive\"] }\n\n---\n\nuse clap::Parser;\n\n#[derive(Parser, Debug)]\n#[clap(version)]\nstruct Args {\n #[clap(short, long, help = \"Path to config\")]\n config: Option ,\n}\n\nfn main() {\n let args = Args::parse();\n println!(\"{:?}\", args);\n}\n\nall my examples still compile from when I first started playing around with this.","author_login":"YOU54F","author_association":"NONE","created_at":"2025-10-16T22:29:54+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3413190877","fragment_type":"issue_comment","sequence":90,"text":"Sorry for the hastily assembled example. Hopefully it works now","author_login":"epage","author_association":"NONE","created_at":"2025-10-16T23:10:22+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3413198500","fragment_type":"issue_comment","sequence":91,"text":"Thanks for sharing your scripts!\n\nYes, rust-analyzer support is not there yet. I posted a PR today as a first step.\n\nAs for `--release`, we punted on improving that workflow to keep this focused, see URL","author_login":"epage","author_association":"NONE","created_at":"2025-10-16T23:15:05+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3414553974","fragment_type":"issue_comment","sequence":92,"text":"For nix shell specifically, you can put the additional shebang lines as toml comments inside the embedded manifest.","author_login":"senekor","author_association":"NONE","created_at":"2025-10-17T09:10:08+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3414873754","fragment_type":"issue_comment","sequence":93,"text":"There is one more thing I thought of this morning that is more about convenience and experience. \n\nWith the script I shared, I was playing with many ways to configure many variables. I started with clap, but CLI arguments are inconvenient with this. \n\nI then used a config file which was easy to manage, just need to write the appropriate data structures to deserialize, though it increases the amount of files related to a script. \n\nTo reduce the file count, I started to configure within the script itself which is common for scripting, however, as Rust is compiled that means a recompile for every variable change. This takes no time for small scripts, but it is still undesirable to me for tweaking variables. \n\nI will probably move back to just importing config for that, but it made me wonder if a secondary fense, or some alternative method could be used to set and vary script config variables within the single file, and not trigger a recompile. \n\nI think the best way available now will be to use the config.toml fense now, and define env variables, but I haven't tested yet. Alternatively I may be able to add custom sections, but I have never tried that, and not sure how one would deserialize that by reading it here.\n\nIf anyone knows a good way to define variables for script in single file without triggering recompiles, please let me know! Ty!","author_login":"andar1an","author_association":"NONE","created_at":"2025-10-17T10:29:47+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3422840371","fragment_type":"issue_comment","sequence":94,"text":"While `-Zscript` is under the hood a `cargo run`, it might still be worth a note in the doc highlighting the default profile is `dev` when stabilization. I was doing a disposable benchmark and couldn't understand some unexpected results until I remembered the default profile.","author_login":"weihanglo","author_association":"NONE","created_at":"2025-10-20T16:32:38+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3423955596","fragment_type":"issue_comment","sequence":95,"text":"Wouldn't it make sense to have a new profile for default cargo-script? Release seems like an overkill, but default `dev` is supa slow, and `cargo-script`s script are there... well... to be running and doing useful stuff. Donno, just a thought.","author_login":"dpc","author_association":"NONE","created_at":"2025-10-20T22:27:07+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3424080360","fragment_type":"issue_comment","sequence":96,"text":"Personally, I'd suggest that it's less surprising to have a cargo script begin execution as soon as possible (i.e. dev/debug profile)\n\nI'm making the assumption that users who want slower compilation and higher runtime performance will already know (or can find out) what else to do here","author_login":"jokeyrhyme","author_association":"NONE","created_at":"2025-10-20T23:22:50+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3424230764","fragment_type":"issue_comment","sequence":97,"text":"Maybe not disable by default, can disable when done writing script with config? \n\nBut I also feel the time to execute a script is critical if going to replace some shell scripts for example.\n\n@dpc, why is release overkill?","author_login":"andar1an","author_association":"NONE","created_at":"2025-10-21T00:28:54+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3447042227","fragment_type":"issue_comment","sequence":98,"text":"It would be nice to be able to specify which build profile to use in the script itself. For most scripts I'll just want them to be built as quickly as possible, but then either after I'm done iterating on them, I move them into more critical parts of my system, or they do something specific which needs to be optimized, I would like to build with `--release`.","author_login":"nixpulvis","author_association":"NONE","created_at":"2025-10-25T18:33:45+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3447942972","fragment_type":"issue_comment","sequence":99,"text":"FWIW, we've been running scripts like `verify-dependencies.rs` in our pipelines (and several others in that directory, though less frequently) for almost 2 years and haven't experience any problems...apart from being hard to edit without rust-analyzer support (yet 🙂). Relatively easy to work around for now, though. Excited to get rust-analyzer support!","author_login":"heaths","author_association":"NONE","created_at":"2025-10-26T02:14:39+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3457531385","fragment_type":"issue_comment","sequence":100,"text":"An interesting caveat is that if you link it as a project, the frontmatter parsing breaks: URL I did get hover, code completion, etc. features, but the frontmatter stopped being recognized as acceptable.","author_login":"heaths","author_association":"NONE","created_at":"2025-10-28T16:59:31+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3567864066","fragment_type":"issue_comment","sequence":101,"text":"how should `cargo test` interact with a script file? i.e. a script file with `#[test]` attributes on function definitions?","author_login":"jokeyrhyme","author_association":"NONE","created_at":"2025-11-23T11:44:43+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3636029296","fragment_type":"issue_comment","sequence":102,"text":"Are there any plans for fast nop builds, i.e. if nothing has changed I don't really want to see \n\n Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s\n Running `/home/tim/.cargo/build/ef/65015738498878/target/debug/foo`\n\nI also don't really want it to spend time rereading all of the source files. Ideally I think we'd cache a list of files that were used as input during the compilation and then use mtime-based change detection (which is very fast) to avoid running the Rust compiler at all. That would kill two birds: faster startup, and avoiding those log messages ☝️","author_login":"Timmmm","author_association":"NONE","created_at":"2025-12-10T08:55:57+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3636058246","fragment_type":"issue_comment","sequence":103,"text":"Ah it seems like actually there isn't any caching at all yet? Also you can use\n\n#!/usr/bin/env -S cargo +nightly -Zscript --quiet\n\nbut that gets rid of them *always* when we really only want to get rid of them when there's already a cached binary.","author_login":"Timmmm","author_association":"NONE","created_at":"2025-12-10T09:03:39+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3636077658","fragment_type":"issue_comment","sequence":104,"text":"Cargo is already caching the rustc output the same way it caches them for regular crates. Notice how the first time you run it, it says \"Compiling\" while the second time it doesn't.\n\n$ cat > foo.rs\n#!/usr/bin/env -S cargo +nightly -Zscript\nfn main() {}\n$ chmod u+x foo.rs\n$ ./foo.rs\nwarning: `package.edition` is unspecified, defaulting to `2024`\n Compiling foo v0.0.0 (/tmp/foo.rs)\n Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s\n Running `/home/bjorn/.cargo/build/e5/f0a92620f96e61/target/debug/foo`\n$ ./foo.rs\nwarning: `package.edition` is unspecified, defaulting to `2024`\n Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.01s\n Running `/home/bjorn/.cargo/build/e5/f0a92620f96e61/target/debug/foo`","author_login":"bjorn3","author_association":"NONE","created_at":"2025-12-10T09:08:41+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3643648534","fragment_type":"issue_comment","sequence":105,"text":"Ok fair enough. I think the most critical thing is that it should be possible to run a script without seeing *any* output from Cargo. The minimum requirement is that `Finished` and `Running` are hidden for no-change builds. #8889 seems like it will be some way off, so I think it would be useful to have a solution before that (and I'm not sure it addresses this issue anyway).\n\nSo can we add something for `cargo script` to solve that issue, at least in the short term? I would have thought it would be quite easy.","author_login":"Timmmm","author_association":"NONE","created_at":"2025-12-11T20:23:30+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3668705885","fragment_type":"issue_comment","sequence":106,"text":"It's a bit meta (and therefore off-topic—if you tell me where to better suggest this, I'm happy to move my comment there), but you may take inspiration from what Python does in their PEPs (equivalent of Rust's RFCs). At the top of the PEP there is a disclaimer that this is a historic document and a link to the up-to-date docs.\n\nExample: PEP-692","author_login":"robsdedude","author_association":"NONE","created_at":"2025-12-18T07:06:36+08:00","repo_name":"rust-lang/cargo","issue_id":1733342552,"issue_number":12207,"issue_url":"https://github.com/rust-lang/cargo/issues/12207","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0254","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"n8n Linkedin node?","query_context":"### Bug Description\n\n From LinkedIn\nError code\n\n426\n\nFull message\n\n{ \"status\": 426, \"code\": \"NONEXISTENT_VERSION\", \"message\": \"Requested version 20240401 is not active\" }\n\n### To Reproduce\n\npost to linkedin\n\n### Expected behavior\n\nnode is invalid:\n\n# Debug info\n\n## core\n\n- n8nVersion: 1.88.0\n- platform: docker (cloud)\n- nodeJsVersion: 20.19.0\n- database: sqlite\n- executionMode: regular\n- concurrency: 5\n- license: community\n- consumerId: 00000000-0000-0000-0000-000000000000\n\n## storage\n\n- success: all\n- error: all\n- progress: false\n- manual: true\n- binaryMode: filesystem\n\n## pruning\n\n- enabled: true\n- maxAge: 168 hours\n- maxCount: 2500 executions\n\n## client\n\n- userAgent: mozilla/5.0 (windows nt 10.0; win64; x64) applewebkit/537.36 (khtml, like gecko) chrome/135.0.0.0 safari/537.36\n- isTouchDevice: false\n\nGenerated at: 2025-04-16T11:37:43.341Z\n\n### Operating System\n\nwindows\n\n### n8n Version\n\n1.88\n\n### Node.js Version\n\n1.88\n\n### Database\n\nSQLite (default)\n\n### Execution mode\n\nmain (default)","known_context_document_ids":["gh_issue_2999369459"],"reference_answer":"Hey @filipefmelo,\n\nWe have created an internal ticket to look into this which we will be tracking as \"GHC-1611\"","answer_document_id":"gh_comment_2808912927","silver_evidence_path":["gh_comment_2810448417","gh_issue_2998987533","gh_comment_2808912927"],"evidence_issue_ids":[2999369459,2998987533],"source_repo_name":"n8n-io/n8n","source_issue_id":2999369459,"source_issue_number":14678,"source_issue_url":"https://github.com/n8n-io/n8n/issues/14678","target_repo_name":"n8n-io/n8n","target_issue_id":2998987533,"target_issue_number":14670,"target_issue_url":"https://github.com/n8n-io/n8n/issues/14670","reference_anchor_document_id":"gh_comment_2810448417","reference_answer_author":"Joffcom","reference_answer_author_association":"MEMBER","quality_score":75.14,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0476,"anchor_target_overlap":0.0476,"target_answer_overlap":0.0},"issue_created_at":"2025-04-16T11:38:28+08:00","valid_comment_count":27,"fragments":[{"document_id":"gh_issue_2999369459","fragment_type":"issue_description","sequence":0,"text":"n8n Linkedin node\n### Bug Description\n\n From LinkedIn\nError code\n\n426\n\nFull message\n\n{ \"status\": 426, \"code\": \"NONEXISTENT_VERSION\", \"message\": \"Requested version 20240401 is not active\" }\n\n### To Reproduce\n\npost to linkedin\n\n### Expected behavior\n\nnode is invalid:\n\n# Debug info\n\n## core\n\n- n8nVersion: 1.88.0\n- platform: docker (cloud)\n- nodeJsVersion: 20.19.0\n- database: sqlite\n- executionMode: regular\n- concurrency: 5\n- license: community\n- consumerId: 00000000-0000-0000-0000-000000000000\n\n## storage\n\n- success: all\n- error: all\n- progress: false\n- manual: true\n- binaryMode: filesystem\n\n## pruning\n\n- enabled: true\n- maxAge: 168 hours\n- maxCount: 2500 executions\n\n## client\n\n- userAgent: mozilla/5.0 (windows nt 10.0; win64; x64) applewebkit/537.36 (khtml, like gecko) chrome/135.0.0.0 safari/537.36\n- isTouchDevice: false\n\nGenerated at: 2025-04-16T11:37:43.341Z\n\n### Operating System\n\nwindows\n\n### n8n Version\n\n1.88\n\n### Node.js Version\n\n1.88\n\n### Database\n\nSQLite (default)\n\n### Execution mode\n\nmain (default)","author_login":"EvPro-glitch","author_association":"NONE","created_at":"2025-04-16T11:38:28+08:00","repo_name":"n8n-io/n8n","issue_id":2999369459,"issue_number":14678,"issue_url":"https://github.com/n8n-io/n8n/issues/14678","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2809307027","fragment_type":"issue_comment","sequence":1,"text":"Hey @EvPro-glitch,\n\nWe have created an internal ticket to look into this which we will be tracking as \"GHC-1613\"","author_login":"Joffcom","author_association":"MEMBER","created_at":"2025-04-16T11:38:34+08:00","repo_name":"n8n-io/n8n","issue_id":2999369459,"issue_number":14678,"issue_url":"https://github.com/n8n-io/n8n/issues/14678","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810248752","fragment_type":"issue_comment","sequence":2,"text":"After updating to 1.88, it stopped posting with the mentioned error. Is there a quick fix from our end until it is fixed?","author_login":"codestorycooked","author_association":"NONE","created_at":"2025-04-16T17:31:06+08:00","repo_name":"n8n-io/n8n","issue_id":2999369459,"issue_number":14678,"issue_url":"https://github.com/n8n-io/n8n/issues/14678","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810401181","fragment_type":"issue_comment","sequence":3,"text":"Seems this is broken for now, but I was able to fix it with HTTP Node using the following config:\n(I am using self hosted n8n instance)\n\nPasting a sequence of images \n- Send Body as JSON\n- Refer to the JSON payload","author_login":"codestorycooked","author_association":"NONE","created_at":"2025-04-16T18:34:27+08:00","repo_name":"n8n-io/n8n","issue_id":2999369459,"issue_number":14678,"issue_url":"https://github.com/n8n-io/n8n/issues/14678","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810448417","fragment_type":"issue_comment","sequence":4,"text":"Hi @EvPro-glitch,\n\nThank you for bringing this up! It looks like this issue is a duplicate of #14670, You can follow that issue where we’re already tracking progress and updates. To keep things organized, we’ll close this issue and continue the discussion over there.\n\nIf you have any additional details or context that might help, please feel free to add them to the original issue. Your input is always appreciated!\n\nThanks again for your contribution, and let us know if there’s anything else we can assist with!","author_login":"RomanDavydchuk","author_association":"CONTRIBUTOR","created_at":"2025-04-16T18:51:54+08:00","repo_name":"n8n-io/n8n","issue_id":2999369459,"issue_number":14678,"issue_url":"https://github.com/n8n-io/n8n/issues/14678","linked_issue_ids":[2998987533],"is_known_query_context":false},{"document_id":"gh_issue_2998987533","fragment_type":"issue_description","sequence":0,"text":"LinkedIn API out of date\n### Bug Description\n\nLinkedIn Node stopped working:\n\nYour request is invalid or could not be processed by the service\nRequested version 20240401 is not active\n\nAsked\nError details\n\n From LinkedIn\nError code\n\n426\n\nFull message\n\n{ \"status\": 426, \"code\": \"NONEXISTENT_VERSION\", \"message\": \"Requested version 20240401 is not active\" }\n\n### To Reproduce\n\nJust try to Create a Post with an Image to LinkedIn\n\n### Expected behavior\n\nThe Posting goes well and without errors\n\n### Operating System\n\nHosted N8N\n\n### n8n Version\n\n1.88.0\n\n### Node.js Version\n\nHosted N8N\n\n### Database\n\nSQLite (default)\n\n### Execution mode\n\nmain (default)","author_login":"filipefmelo","author_association":"NONE","created_at":"2025-04-16T09:08:57+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2808912927","fragment_type":"issue_comment","sequence":1,"text":"Hey @filipefmelo,\n\nWe have created an internal ticket to look into this which we will be tracking as \"GHC-1611\"","author_login":"Joffcom","author_association":"MEMBER","created_at":"2025-04-16T09:09:03+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2808963745","fragment_type":"issue_comment","sequence":2,"text":"the fix is simple: just modify the API version from 202404 to 202405. Deployed this hack locally until the fix is done on upstream.","author_login":"cpantus","author_association":"NONE","created_at":"2025-04-16T09:27:57+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2809767854","fragment_type":"issue_comment","sequence":3,"text":"I see the documentation, n8n must use API version 202411 . But for self-hosted, how can we do that?","author_login":"sadiksajid","author_association":"NONE","created_at":"2025-04-16T14:26:53+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2809875316","fragment_type":"issue_comment","sequence":4,"text":"Did you try to remove that header and just keep `X-Restli-Protocol-Version`","author_login":"Mohamed3nan","author_association":"NONE","created_at":"2025-04-16T15:02:08+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810446167","fragment_type":"issue_comment","sequence":5,"text":"I think this is related to:\n\n URL \n\nI have this issue too\n\nYesterday evening I upgraded to the \"latest\" docker image.\n\nI rolled back to 1.86.0 as it was working fine then. I will know if it worked tomorrow morning when I make use of the LinkedIn node","author_login":"VT-Tri","author_association":"NONE","created_at":"2025-04-16T18:51:19+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810883041","fragment_type":"issue_comment","sequence":6,"text":"This feels similar to my bug issue. #14654 \n\nI tried doing it with HTTP Request, but that didn't work either, no matter what steps I tried. This is very frustrating because docs and YouTube tutorials are just button clicks, and it works for them.","author_login":"yashaleo","author_association":"NONE","created_at":"2025-04-16T21:43:57+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810887299","fragment_type":"issue_comment","sequence":7,"text":"For those using **Docker**, I found a **temporary workaround** to bypass the LinkedIn API version issue in `n8n`.\n\n### ✅ What you need to do:\n\nThe idea is to override the `GenericFunctions.js` file inside the container by mounting a local version using Docker volumes. This ensures your changes persist even after container restarts.\n\n---\n\n### 🛠️ Step-by-step:\n\n1. **Access the container terminal as root:**\n\ndocker exec -it -u root sh\n\n2. **Check if the file exists:**\n\nls /usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/GenericFunctions.js\n\n3. **Copy the file from the container to your host machine:**\n\ndocker cp :/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/GenericFunctions.js ./GenericFunctions.js\n\n \n\n4. **Edit the copied file:**\n\nOpen `GenericFunctions.js` and find:\n\n\"LinkedIn-Version\": \"202404\"\n\nReplace it with:\n\n\"LinkedIn-Version\": \"202504\"\n\n5. **Update your `docker-compose.yml` file:**\n\nIn your `n8n` service, add a volume mount to override the original file:\n\nvolumes:\n - ./n8n_custom_code/GenericFunctions.js:/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/GenericFunctions.js\n\n6. **Rebuild and restart the container:**\n\ndocker-compose down\ndocker-compose up --build -d\n\n7. **Confirm the change inside the container:**\n\ndocker exec -it -u root sh\ncat /usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/GenericFunctions.js\n\nMake sure the updated `\"LinkedIn-Version\"` value is present.\n\n---\n\n### 📌 Note:\nThis is a **temporary workaround** until the project maintainers release an official fix. Ideally, this value should be configurable via environment variable or node settings.\n\nHope this helps others running into the same issue! 😉","author_login":"vikthyr","author_association":"NONE","created_at":"2025-04-16T21:46:54+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2810968755","fragment_type":"issue_comment","sequence":8,"text":"Without overcomplicating it, you can just use the HTTP node with your already connected LinkedIn credentials.\n\nHere's a community post showing how to publish a LinkedIn post or image using the HTTP node:\n\n URL","author_login":"Mohamed3nan","author_association":"NONE","created_at":"2025-04-16T22:34:41+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2811398375","fragment_type":"issue_comment","sequence":9,"text":"Anyone know how to deploy a temp. fix if one is using EasyPanel?","author_login":"nickeykhem","author_association":"NONE","created_at":"2025-04-17T01:21:55+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2811968134","fragment_type":"issue_comment","sequence":10,"text":"The temp hack: just search in your n8n installation for the culprit and edit it out\n\n`grep -r 202404 /usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/\n`","author_login":"cpantus","author_association":"NONE","created_at":"2025-04-17T06:51:21+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2812032215","fragment_type":"issue_comment","sequence":11,"text":"Thanks, @cpantus but out of curiosity, can this happen with all the time?. Like next month do i have to change it again?","author_login":"0xgigabyte","author_association":"NONE","created_at":"2025-04-17T07:24:46+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2812104727","fragment_type":"issue_comment","sequence":12,"text":"My API call still worked well until yesterday. It raised the error _\"b'{\"status\":426,\"code\":\"NONEXISTENT_VERSION\",\"message\":\"Requested version 20240401 is not active\"}'\"_\n\nI changed version: **202504**; however, the API always returns empty elements.\n\nAPI request:\n\n`curl -X GET ' URL \\\n-H 'Authorization: Bearer {INSERT_TOKEN}' \\\n-H 'Linkedin-Version: 202504' \\\n-H 'X-Restli-Protocol-Version: 2.0.0'`\n\nResponse:\n`{\"paging\":{\"start\":0,\"count\":10,\"links\":[]},\"elements\":[]}`\n\nPlease advise.","author_login":"hangtran0","author_association":"NONE","created_at":"2025-04-17T07:58:59+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2813134164","fragment_type":"issue_comment","sequence":13,"text":"Following for a solution. The API version changes every 12 months so the fix will hopefully dynamically pull the version from LinkedIn and update the node's protocol settings regularly.","author_login":"RamseyNjire","author_association":"NONE","created_at":"2025-04-17T14:30:44+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2813370785","fragment_type":"issue_comment","sequence":14,"text":"line 41 of GenericFuntions.js\n\"LinkedIn-Version\": \"202504\"\n\nthe above is the fix, you just have to find the file for me I am using NVM for node so mine is \nC:\\Users\\MyUserName\\AppData\\Local\\nvm\\v18.20.6\\node_modules\\n8n\\node_modules\\n8n-nodes-base\\dist\\nodes\\LinkedIn\\GenericFuntions.js\n\nI then stopped my app and restarted and the post worked again","author_login":"dtsoden","author_association":"NONE","created_at":"2025-04-17T15:39:07+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2813456182","fragment_type":"issue_comment","sequence":15,"text":"Why is this closed? The LinkedIn node is still erroring the same thing.","author_login":"rahtid","author_association":"NONE","created_at":"2025-04-17T16:11:43+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2813654326","fragment_type":"issue_comment","sequence":16,"text":"Can confirm this worked for me. Running on a raspberry pi and this was the path: /home/pi/.nvm/versions/node/v20.17.0/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/GenericFunctions.js","author_login":"itsMattShull","author_association":"NONE","created_at":"2025-04-17T17:46:18+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2814040353","fragment_type":"issue_comment","sequence":17,"text":"at n8n cloud isnt working yet. \n\nNodeApiError: Your request is invalid or could not be processed by the service at ExecuteContext.linkedInApiRequest (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/GenericFunctions.js:68:11) at processTicksAndRejections (node:internal/process/task_queues:95:5) at ExecuteContext.execute (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/LinkedIn/LinkedIn.node.js:173:38) at WorkflowExecute.runNode (/usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/execution-engine/workflow-execute.js:681:27) at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/execution-engine/workflow-execute.js:915:51 at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/execution-engine/workflow-execute.js:1246:20\n\nSomeone could help me?","author_login":"igorveloso","author_association":"NONE","created_at":"2025-04-17T21:16:41+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2814049123","fragment_type":"issue_comment","sequence":18,"text":"Cloud is failing for me also, version 1.88.0, \n{ \"status\": 426, \"code\": \"NONEXISTENT_VERSION\", \"message\": \"Requested version 20240401 is not active\" }","author_login":"cpparkin","author_association":"NONE","created_at":"2025-04-17T21:21:05+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2814576416","fragment_type":"issue_comment","sequence":19,"text":"how was this not picked up in unit testing for the 1.88 build?","author_login":"mike-dataduality","author_association":"NONE","created_at":"2025-04-18T05:26:41+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2815487177","fragment_type":"issue_comment","sequence":20,"text":"Why is this closed? Not working on either my n8n cloud instance or community node?","author_login":"danielctc","author_association":"NONE","created_at":"2025-04-18T13:50:16+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816071616","fragment_type":"issue_comment","sequence":21,"text":"Hey everyone, the issue was fixed in this PR and will get released as soon as possible with the next release (probably Tuesday).","author_login":"pdwarf","author_association":"NONE","created_at":"2025-04-18T19:29:41+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2817834282","fragment_type":"issue_comment","sequence":22,"text":"Brother, how to modify this please guide us if possible, I am so newbie here","author_login":"justaguy114","author_association":"NONE","created_at":"2025-04-21T07:27:08+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2822657962","fragment_type":"issue_comment","sequence":23,"text":"Does anyone know how to update to the 1.90.0 version on Railway? I just redeployed and it only updated to 1.89.2","author_login":"rahtid","author_association":"NONE","created_at":"2025-04-22T23:04:43+08:00","repo_name":"n8n-io/n8n","issue_id":2998987533,"issue_number":14670,"issue_url":"https://github.com/n8n-io/n8n/issues/14670","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0255","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Unable to resolve module when using path alias in environment with ESModule and TypeScript?","query_context":"Hello! First of all, thank you for your wonderful project. I'm having some problems using this template, so if you know where I can find a solution, could you please let me know?\n\nIn an environment using TypeScript and ESModule, importing using the path alias set on `tsconfig.json` gives the following error and does not work properly. \n\n/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:757\n throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base));\n ^\nError: Cannot find package '~' imported from /home/yupix/works/remix-v2-server/build/index.js\n at packageResolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:757:9)\n at moduleResolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:798:18)\n at Object.defaultResolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:912:11)\n at /home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:218:35\n at entrypointFallback (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:168:34)\n at /home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:217:14\n at addShortCircuitFlag (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:409:21)\n at resolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:197:12)\n at nextResolve (node:internal/modules/esm/hooks:833:28)\n at Hooks.resolve (node:internal/modules/esm/hooks:278:30)\nFailed running './server.ts'\n\n### Projects I have tested\n\n URL \n\n### Environment\n\nOS: Ubuntu 22.04.3\nRemix: v2.0.1\npnpm: v8.6.7\nnode: v20.8.0","known_context_document_ids":["gh_issue_1942394191"],"reference_answer":"The whole idea of TypeScript is to add static types on top of JavaScript, not to be a higher-level language that builds to JS. The C# / IL comparison is not apt at all.\n\nThere's literally no line of undownleveled JavaScript code you can write where TS intercepts some *string* in it and changes it to be something else. This is 100% consistent with TS behavior in every other kind of JS construct; it would be frankly bizarre to have import paths be the one thing that we decide to go mess with.","answer_document_id":"gh_comment_702801220","silver_evidence_path":["gh_comment_1763116715","gh_issue_713122066","gh_comment_702801220"],"evidence_issue_ids":[1942394191,713122066],"source_repo_name":"xHomu/remix-v2-server","source_issue_id":1942394191,"source_issue_number":5,"source_issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","target_repo_name":"microsoft/TypeScript","target_issue_id":713122066,"target_issue_number":40878,"target_issue_url":"https://github.com/microsoft/TypeScript/issues/40878","reference_anchor_document_id":"gh_comment_1763116715","reference_answer_author":"RyanCavanaugh","reference_answer_author_association":"MEMBER","quality_score":95.88,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3793,"anchor_target_overlap":0.2069,"target_answer_overlap":0.0976},"issue_created_at":"2023-10-13T17:56:40+08:00","valid_comment_count":71,"fragments":[{"document_id":"gh_issue_1942394191","fragment_type":"issue_description","sequence":0,"text":"Unable to resolve module when using path alias in environment with ESModule and TypeScript\nHello! First of all, thank you for your wonderful project. I'm having some problems using this template, so if you know where I can find a solution, could you please let me know?\n\nIn an environment using TypeScript and ESModule, importing using the path alias set on `tsconfig.json` gives the following error and does not work properly. \n\n/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:757\n throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base));\n ^\nError: Cannot find package '~' imported from /home/yupix/works/remix-v2-server/build/index.js\n at packageResolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:757:9)\n at moduleResolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:798:18)\n at Object.defaultResolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:912:11)\n at /home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:218:35\n at entrypointFallback (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:168:34)\n at /home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:217:14\n at addShortCircuitFlag (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:409:21)\n at resolve (/home/yupix/works/remix-v2-server/node_modules/.pnpm/ts-node@10.9.1_@swc+core@1.3.63_@types+node@20.8.4_typescript@5.0.4/node_modules/ts-node/src/esm.ts:197:12)\n at nextResolve (node:internal/modules/esm/hooks:833:28)\n at Hooks.resolve (node:internal/modules/esm/hooks:278:30)\nFailed running './server.ts'\n\n### Projects I have tested\n\n URL \n\n### Environment\n\nOS: Ubuntu 22.04.3\nRemix: v2.0.1\npnpm: v8.6.7\nnode: v20.8.0","author_login":"yupix","author_association":"NONE","created_at":"2023-10-13T17:56:40+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1761962903","fragment_type":"issue_comment","sequence":1,"text":"Hi there, there appears to be a bug with the latest version of @swc/core that caused the error. For now, please fix your @swc/core to 1.3.82:\n\nIn package.json:\n\n` \"@swc/core\": \"1.3.82\",`\n\nI'll dig further into this over the weekend, sorry for the hiccup!","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-13T18:06:33+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1761972131","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your quick reply. I changed `@swc/core` to `1.3.82` and still get the same error. I have also updated the repositories I am testing. I'll be waiting for the weekend.","author_login":"yupix","author_association":"NONE","created_at":"2023-10-13T18:15:06+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762007051","fragment_type":"issue_comment","sequence":3,"text":"Try deleting your pnpm-lock and run `pnpm install; pnpm run dev` again.","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-13T18:32:59+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762018221","fragment_type":"issue_comment","sequence":4,"text":"I deleted `pnpm-lock.yaml` and ran `pnpm i`, but it does not seem to change. Also, I forgot to commit `pnpm-lock.yaml` to the repository, so I committed it.","author_login":"yupix","author_association":"NONE","created_at":"2023-10-13T18:36:56+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762023367","fragment_type":"issue_comment","sequence":5,"text":"That's really strange. I am testing on Windows and Mac environment, so I wonder if there's something specific with swc's Linux kernel that's broken. You can try an older version like 1.3.78 and see if that get it working again.\n\nI'll look into migrating the template to `tsx` instead of `ts-node`, hopefully that would sidestep this issue altogether. Sorry for the trouble!","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-13T18:40:00+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762028208","fragment_type":"issue_comment","sequence":6,"text":"After changing to `1.3.78`, I removed the lock and reinstalled using the same procedure as before, but the error does not seem to change.","author_login":"yupix","author_association":"NONE","created_at":"2023-10-13T18:44:16+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762038070","fragment_type":"issue_comment","sequence":7,"text":"I have also checked the operation on Windows, but the error seems to occur in the same way as with Linux.\n\n### How to reproduce\n\ngit clone URL \ngit checkout esm-server.ts\n\npnpm i\npnpm dev\npnpm dev\n\n### Environment\n\nOS: Windows 11 Pro 22621.2361\npnpm: v8.8.0\nnode: v20.8.0","author_login":"yupix","author_association":"NONE","created_at":"2023-10-13T18:53:09+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762131699","fragment_type":"issue_comment","sequence":8,"text":"I have started working the switch to tsx, you can observe the progress on this branch:\n\n URL \n\nFeel free to test it out and let me know if it works for you!","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-13T19:59:30+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762592802","fragment_type":"issue_comment","sequence":9,"text":"I think it is very cool to tsx, but the error still seems to be the same. Do you get any errors with imports like `import { say_hello } from \"~utils/hello.js\"` in your environment?\n\nAlso, importing using relative paths works fine, but the paths that can be set on tsconfig do not seem to be resolving properly.","author_login":"yupix","author_association":"NONE","created_at":"2023-10-14T04:31:28+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763032689","fragment_type":"issue_comment","sequence":10,"text":"Yes, aliasing works just fine in my environment:\n\nimage\n\nI'm quite confused and having trouble nailing down what might be causing all these issues for you. \n\n* Does the default template `npx create-remix` have the same issues for you?\n* What about the Epic-Stack? URL","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-14T16:24:46+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763116715","fragment_type":"issue_comment","sequence":11,"text":"<img width=\"651\" alt=\"image\" src=\" URL \n<img width=\"237\" alt=\"image\" src=\" URL \n\nThank you for your reply. I just wanted to let you know that I noticed that if you do not give the extension (.js) when importing, an error is displayed on the editor, but Remix works fine without error.\n\nAs far as I know, when using ES Module in TypeScript, the import must specify the extension `js`, is this wrong?\n\n URL","author_login":"yupix","author_association":"NONE","created_at":"2023-10-14T18:30:57+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_1763123691","fragment_type":"issue_comment","sequence":12,"text":"You're correct. ESM requires the extension. I was working on the wrong branch when testing above, import { Hello } from \"~/utils/hello.js\"` is the right syntax.","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-14T18:45:29+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763125127","fragment_type":"issue_comment","sequence":13,"text":"I have found that by setting the extension to `.ts` instead of `.js`, there are no errors on the editor, and the remix seems to work correctly. I see that the epic stack you mentioned also specifies `.ts`. Is it common to specify `.ts` instead of `.js`?","author_login":"yupix","author_association":"NONE","created_at":"2023-10-14T18:51:09+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763125533","fragment_type":"issue_comment","sequence":14,"text":".js should work as long as you have `allowJs\": true` in tsconfig.","author_login":"xHomu","author_association":"OWNER","created_at":"2023-10-14T18:53:02+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763136314","fragment_type":"issue_comment","sequence":15,"text":"You are certainly right about the use of different extensions. This time, hello.ts only provides a function `say_hello` to output `Hello World` using console.log, so I used `ts`. I'm going to close this Issue for now, since it seems that specifying the extension as it is will solve the problem. Thank you for your time. Have a nice weekend!","author_login":"yupix","author_association":"NONE","created_at":"2023-10-14T19:07:24+08:00","repo_name":"xHomu/remix-v2-server","issue_id":1942394191,"issue_number":5,"issue_url":"https://github.com/xHomu/remix-v2-server/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_713122066","fragment_type":"issue_description","sequence":0,"text":"Compiled JavaScript import is missing file extension\n**TypeScript Version:** 4.0.3\n**Search Terms:** module es6 es2015 import file extension missing js ts bug 404\n\n**Steps to reproduce:**\n\nCreate a `main.ts`:\n\nts\nimport {foo} from './dep';\nconsole.log(s, foo);\n\nCreate a `dep.ts`:\n\nts\nexport const foo = 42;\n\nCreate a `tsconfig.json`:\n\njson\n{\n \"compilerOptions\": {\n \"module\": \"ES2015\"\n }\n}\n\nThen run:\n\nshell\nnpx tsc\n\n**Expected behavior:**\n\nThe compiler generates JavaScript \"which runs anywhere JavaScript runs: In a browser, on Node.JS or in your apps\" (according to the TypeScript homepage). For example, it would be valid to create two files as follows; `main.js`:\n\njs\nimport { foo } from './dep.js';\nvar s = \"hello world!\";\nconsole.log(s, foo);\n\nAnd `dep.js`:\n\njs\nexport var foo = 42;\n\n(More generally, the expected behavior is that the module specifier in the generated `import` must match the filename chosen for the generated dependency. For example, it would also be valid for the compiler to generate a file `dep.xyz`, if it also generated `import ( foo } from './dep.xyz'`.)\n\n**Actual behavior:**\n\nAs above, except that in `main.js`, the `import` URL does not match the filename chosen by the compiler for the generated dependency; it is missing the file extension:\n\njs\nimport { foo } from './dep';\n\nWhen executing `main.js` in the browser, it requests the URL `./dep`, which is a 404. This is expected, as the correct relative URL would be `./dep.js`.\n\n**Related Issues:** URL voluntarily closed by the reporter for unknown reasons","author_login":"jameshfisher","author_association":"NONE","created_at":"2020-10-01T19:24:57+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702353715","fragment_type":"issue_comment","sequence":1,"text":"TypeScript doesn't modify import paths as part of compilation - you should always write the path you want to appear in the emitted JS, and configure the project as necessary to make those paths resolve the way you want during compilation","author_login":"RyanCavanaugh","author_association":"MEMBER","created_at":"2020-10-01T19:35:56+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702368941","fragment_type":"issue_comment","sequence":2,"text":"Thanks @RyanCavanaugh! Do you mean I should write `import { foo } from './dep.js'` in my source `main.ts`? That does actually seem to work! In that the compiler uses `'./dep.ts'` to find the types of variables exported.\n\nHowever, I find this surprising, because\n\n- The recommendation everywhere else in TypeScript docs is to omit the file extension.\n- If I try to import from `'./dep.ts'`, the compiler gives me `error TS2691: An import path cannot end with a '.ts' extension. Consider importing './dep' instead`. So apparently it's not possible to generate JavaScript imports that end in `.ts`?\n- The module resolution docs don't say what's going on here. What logic makes this work? Is there a special case for `.js`, which is mapped to `.ts`?\n- I can't find a rationale for this design anywhere.","author_login":"jameshfisher","author_association":"NONE","created_at":"2020-10-01T20:06:51+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702372616","fragment_type":"issue_comment","sequence":3,"text":"TS never takes an existing valid JS construct and emits something different, so this is just the default behavior for all JS you could write. Module resolution tries to make all of this work \"like you would expect\"\n\nSee also URL","author_login":"RyanCavanaugh","author_association":"MEMBER","created_at":"2020-10-01T20:14:38+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702394605","fragment_type":"issue_comment","sequence":4,"text":"@RyanCavanaugh that principle makes sense. My remaining confusion then is why the docs and compiler encourage omitting the file extension, if \"you should write the import path that works at runtime\". Maybe this encouragement is designed for a JS runtime that demands that you omit the file extension. But the runtimes I'm aware of are browser, ES modules, and Node.js, none of which make this demand.","author_login":"jameshfisher","author_association":"NONE","created_at":"2020-10-01T20:59:45+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702508785","fragment_type":"issue_comment","sequence":5,"text":"@RyanCavanaugh Writing \"./dep.js\" doesn't sound logical. It requires the coder to know the exact complied output and be fully aware of the compiled environment. Isn't the whole idea of Typescript to abstract Javascript?\n\n`import { foo } from \"./dep\"` is legitimate Typescript, and it provides the information for Typescript to resolve all that is needed to make the code compiled successfully. So, the compiled output similarly has to work.","author_login":"RevealedFrom","author_association":"NONE","created_at":"2020-10-02T03:37:32+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702801220","fragment_type":"issue_comment","sequence":6,"text":"The whole idea of TypeScript is to add static types on top of JavaScript, not to be a higher-level language that builds to JS. The C# / IL comparison is not apt at all.\n\nThere's literally no line of undownleveled JavaScript code you can write where TS intercepts some *string* in it and changes it to be something else. This is 100% consistent with TS behavior in every other kind of JS construct; it would be frankly bizarre to have import paths be the one thing that we decide to go mess with.","author_login":"RyanCavanaugh","author_association":"MEMBER","created_at":"2020-10-02T15:30:48+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_702840956","fragment_type":"issue_comment","sequence":7,"text":"problem is, ts does not only need to add '.js', there are complexer resolution strategies.\n\ni would like it, if there would be a way of calling a plugin after transpilation had been done, so I could fix the import names with that.\nI know I could use a bundler / build system, but we ship directly the code typescript generates, without an additional build step. at the moment we fix the import path's in our own webserver.","author_login":"jogibear9988","author_association":"NONE","created_at":"2020-10-02T16:48:51+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_711434830","fragment_type":"issue_comment","sequence":8,"text":"@RyanCavanaugh @jameshfisher I was about to post a new bug about TypeScript but then the template encouraged me to search again, and I found this issue, which might be similar enough. \n\nBut I'm still confused, even reading above.\n\nHere is the \"bug\" I submitted to the \"vscode\" repo, and that team rejected it and said that I should submit to the \"TypeScript\" repo here: URL \n\nIt seems that people trying to write TypeScript in VSC face this dilemma of choosing between:\n\n1. VSC shows an error (red underline), but the code works, or:\n1. If we follow the VSC error tooltip's suggestion, it will \"resolve\" the error in the editor, but then the code won't run.\n\nimage\n\nI'm getting this error and don't understand why:\n\n An import path cannot end with a '.ts' extension. Consider importing '_______' instead. ts(2691)\n\nSee also: microsoft/TypeScript#11235 (comment)","author_login":"ryancwalsh","author_association":"NONE","created_at":"2020-10-18T22:42:16+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_711871066","fragment_type":"issue_comment","sequence":9,"text":"So far, I have had success with @RyanCavanaugh's suggestion to \"always write the path you want to appear in the emitted JS, and configure the project as necessary to make those paths resolve the way you want during compilation\".\n\nBut I am still confused because this advice contradicts the compiler and docs and ecosystem, which all encourage omitting file extensions.","author_login":"jameshfisher","author_association":"NONE","created_at":"2020-10-19T08:52:08+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_714040530","fragment_type":"issue_comment","sequence":10,"text":"Yeah that doesn't feel right. I really don't understand. I can't think of any principle where it would make sense to throw a prominent red error for something legal.","author_login":"ryancwalsh","author_association":"NONE","created_at":"2020-10-22T00:18:20+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_722220094","fragment_type":"issue_comment","sequence":11,"text":"Same issue here. Adding a `.js` in the import inside a TypeScript file does allow to compile it with the TypeScript compiler and will output files with working ESM imports. \n\nHowever, when I add `.js` extensions on the imports, I can't get testing working. Tried with Mocha and Jest, but no luck so far: they complain the files with `.js` extension don't exist, which is correct, those files don't exist since they actually have a `.ts` extension.\n\nI would love to see the TypeScript compiler add `.js` extenstions on imports when the output is esm/es2015.","author_login":"josdejong","author_association":"NONE","created_at":"2020-11-05T08:19:39+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_748428647","fragment_type":"issue_comment","sequence":12,"text":"The problem I'm running into is that I need the `.js` extension added to `export` statements, not just `import`. I have this `index.ts` file for a library of math functions:\n\nexport * from './math.js';\nexport {\n Angle, convertFromRadians, convertToRadians, FMT_DD, FMT_DDD, FMT_HH, FMT_MINS, FMT_SECS, FMT_SIGNED,\n HALF_PI, Mode, PI, TWO_PI, Unit\n} from './angle.js';\nexport { MinMaxFinder } from './min-max-finder.js';\nexport { SphericalPosition } from './spherical-position.js';\nexport { SphericalPosition3D } from './spherical-position-3d.js';\nexport { ZeroFinder } from './zero-finder.js';\n\nAdding `.js` only works for the first line. I don't know if that's because it's a wildcard export or not. But the generated JavaScript code is missing the `.js` everywhere else:\n\nexport * from './math.js';\nexport { Angle, convertFromRadians, convertToRadians, FMT_DD, FMT_DDD, FMT_HH, FMT_MINS, FMT_SECS, FMT_SIGNED, HALF_PI, Mode, PI, TWO_PI, Unit } from './angle';\nexport { MinMaxFinder } from './min-max-finder';\nexport { SphericalPosition } from './spherical-position';\nexport { SphericalPosition3D } from './spherical-position-3d';\nexport { ZeroFinder } from './zero-finder';\n//# sourceMappingURL=index.js.map","author_login":"kshetline","author_association":"NONE","created_at":"2020-12-19T06:34:11+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_751518885","fragment_type":"issue_comment","sequence":13,"text":"@josdejong you can get around this by using an `index.ts` file. In the index.ts file do the following `export { MyClass } from 'src/my-class.js'`, and in your test just import the file directly instead of via the index file `import { MyClass } from `src/my-class.ts`.","author_login":"bobbyg603","author_association":"NONE","created_at":"2020-12-27T21:37:18+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_752458275","fragment_type":"issue_comment","sequence":14,"text":"Thanks for sharing your workaround @bobbyg603 . I'm not sure how that would work for the imports inside `src/my-class.ts`, (nested). You can't change that dynamically depending on your context (testing or actually using). \n\nIt feels to me like there is a serious mismatch between plain ES modules (requiring actual existing paths with proper file extensions) and TypeScript code (relying on \"smart\" nodejs module resolution, not requiring file extensions, and (implicitly) changing the (implicit) file extensions from .ts to .js when compiling). I can't understand this issue is marked \"Working as intended\" in URL this is a problem that needs to be addressed. \n\nMost logical to me would be to write imports with `*.ts` extension in your code (matching the actual file extension). And when compiling, have TypeScript replace `*.ts` extensions with `*.js`, matching the actual file extension of the compiled file (which is changed to `*.js` by TypeScript). TypeScript changes the file extensions from `*.ts` to `*.js`, so logically it should also fix corresponding imports.","author_login":"josdejong","author_association":"NONE","created_at":"2020-12-30T11:44:00+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_758272403","fragment_type":"issue_comment","sequence":15,"text":"Facing the same problem.\n\nIn most scenarios, we use webpack. But for simple scenarios and samples, e.g. for our TS-training for developers, we want to use plain TS files and JS modules without the complexity of another transpiler like Babel/webpack.\nIt looks odd in training classes when you try to explain the beauty of TS and then have to stutter something like \"TS never changes outputted strings\". Or you have to tell them that it will get better with webpack. \n=> \"The simple case is ugly but it looks good in the more complicated case when we use more tools.\"\n\nThis means: \n* On the client/browser, TS needs a transpiler to transpile to some non-ECMASCRIPT-modules. \n* If you go go for \"import ./myModule.js\", IDEs might mark it as error.\n* Other ALM-scripts which parse source-code (testscripts, mock-scripts, build-scripts, deploy-scripts, ...) might get confused.\n\nWhy not add an option to tsconfig and leave it to the developer to use it or not?\nWe know that is is not \"pure doctrine\" but for many cases it will work. One could also emit a warning \"will only work with static files\" or something like that.\n\nI'm aware that \"import ./myModule\" could resolve to something which is not a static file on the web-server. E.g. a web-service dynamically resolving and returning js-code. \n\nIn any case, please such an option would leave it to the developer's resonsibility how to transpile it.","author_login":"thomas-mindruptive","author_association":"NONE","created_at":"2021-01-11T22:45:35+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_811706273","fragment_type":"issue_comment","sequence":16,"text":"I think `add .js extenstions on imports when the output is esm/es2015` would be the only correct behaviour, because `The file extension is always necessary ` for relative specifier in esm.","author_login":"ioslh","author_association":"NONE","created_at":"2021-04-01T07:26:20+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826440831","fragment_type":"issue_comment","sequence":17,"text":"@ioslh I'm trying to get eslint to be able to ensure \".js\" extensions are never forgotten\nany thumbs up or help in trying to make my PR be accepted would be appreciated:\n URL","author_login":"pwhissell","author_association":"NONE","created_at":"2021-04-26T01:17:15+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_878346784","fragment_type":"issue_comment","sequence":18,"text":"TypeScript developers, please, do whatever the hell you want with file extensions, this debate has been going on for years, I don't care, your mind is set, fine. But just document this very basic thing in a place that's easy to find: how on earth do I run the JavaScript emitted by tsc when \"module\" is set to \"ESNext\"? That will save a lot of people a lot of time. Most people understand \"transpiles to JavaScript\" as \"transpiles to working JavaScript\". But this is not the case.","author_login":"djfm","author_association":"NONE","created_at":"2021-07-12T14:54:50+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_889441458","fragment_type":"issue_comment","sequence":19,"text":"I'm hitting this exact same issue. I'm not using webpack, just plain typescript and my javascript output is broken because the .js extension is missing. How on earth can this not be a bug? What am I supposed to do instead?","author_login":"TheBoneJarmer","author_association":"NONE","created_at":"2021-07-29T20:40:37+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_889442439","fragment_type":"issue_comment","sequence":20,"text":"@TheBoneJarmer If you're just doing plain TS and JS, use the would-be filename as the import specifier like so:\n\nts\nimport { version } from \"./version.js\";","author_login":"RA80533","author_association":"NONE","created_at":"2021-07-29T20:42:53+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_889562672","fragment_type":"issue_comment","sequence":21,"text":"The problem with this solution is that if you have an \"outDir\" different\nthan the default, i.e. a setup where transpiled files don't live beside the\n.ts files, most tools will freak up and that's not a nice development\nexperience.\n\nI was so pissed-up buy this that I built this monstrosity:\n URL \n\nYou can install it and have it watch your \"outDir\" and it will quickly and\ntransparently add the .js extension where appropriate to the transpiled\nfiles as they appear / are updated by tsc.\n\nIt seems to be working well. Only missing major feature is that I currently\ndon't rewrite the source-maps but it doesn't seem to matter much since the\nchanges I make in the js files are only adding 3 chars to some import\nstatements at the end of some lines. No line offets, no changes to any\nplace where you would be likely nor even able to set a breakpoint anyways.\n\nGive it a go and let me know of any issues you might find!\n\nThere are webpack modules that do the same thing, but my solution is much\nless invasive: keeps file and directory structure, no bundling, no config.\n\nI spent a considerable amount of time reading the obscure ESM spec and I'm\npretty confident my tool doesn't do anything unwise.\n\nI actually think TS has it wrong, as the ESM spec clearly states that there\nis no such thing as a default file extension. So you should \"import foo\nfrom '. /foo.ts'\" and that should transpile to \"import foo from\n'./foo.js'\". I don't see any deviation from JS here. \"import foo from\n'./foo'\" seems just wrong.\n\nOn Thu, Jul 29, 2021, 22:43 RA80533 ***@***.***> wrote:","author_login":"djfm","author_association":"NONE","created_at":"2021-07-30T01:27:39+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_889665287","fragment_type":"issue_comment","sequence":22,"text":"Thanks for the replies guys. Personally I entirely agree with @djfm. I am grateful for the workaround from @RA80533 though, don't take me wrong. But it is far from a good solution imho. And the reasons why are nicely explained by djfm. That said, you are not the only one who got that idea. I found another npm package through Google which does what I believe you do as well. It is called tsc-esm and is created by user @Gin-Quin.","author_login":"TheBoneJarmer","author_association":"NONE","created_at":"2021-07-30T06:35:47+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_889674079","fragment_type":"issue_comment","sequence":23,"text":"That said. I also took my time to learn a bit more about the whole es6 module system and I also think javascript has a flaw here. Imho they should introduce something similar to what happens in urls with index.html. In most if not all web servers you never have to manually insert '/index.html' at the end of an url. When the path ends with a / the server automatically converts that to /index.html. When no file extension is added at the end of an import statement, the client should convert this first to .mjs. If no such file exists than to .js. And only then the client should throw an error if neither files were found.\n\nTherefore I more or less can understand why typescript devs don't consider this a bug from their side. Typescript merely interprets the import statement for typescript purposes but may not be able to convert it that easily to esm. But I do think this should be a config option.\n\nI mean, several users already created their own npm package out of frustration which I think shows how big this problem is. And they are right to be frustrated because my basic typescript app produces broken javascript, which is a definitely a bug from typescript. And the fact that typescript devs do not want to admit that is just plain ignorance and stupid. This will only push people away from using TS. And on top of that, the fact that they say they won't do a thing about it does pisses me off even more. \n\nImho the tsc should stop conversion when an import statement cannot be converted to esm. Or throw a warning or hint that narrows down to \"Due to limitations in the javascript language you are supposed to add a .js in your import statement or else tsc will produce broken code\". And I'd be fine with that but not the way it is now.","author_login":"TheBoneJarmer","author_association":"NONE","created_at":"2021-07-30T06:56:01+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_889681075","fragment_type":"issue_comment","sequence":24,"text":"For a bit of clarity, this behavior is due to the way modern web authors tend to serve content. Web servers as a whole are glorified file systems. A request to `/` is semantically equivalent to inspecting the root directory yet, because web servers have optimized the browsing experience in a manner such that they aren't beholden to typical file system behaviors, that would-be directory request is often treated as a file request through some arcane redirection.","author_login":"RA80533","author_association":"NONE","created_at":"2021-07-30T07:08:55+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_889798977","fragment_type":"issue_comment","sequence":25,"text":"We should fork TypeScript. Let's call it FreeScript for instance.\n\nThere are way too many things in the hands of Microsoft right now and they\ngo way too well together: they have GitHub, Copilot (I'm in the preview and\nit's pretty freaky), TypeScript, VSCode...\n\nIt's too good to be true. Our hands are tied. I have kind of a bad feeling\nabout this. Could turn out the wrong way.\n\nI'd love something like a mix between TypeScript and Webpack. Except that\nyou wouldn't have to bundle up everything using hard to understand and hard\nto configure plugins of plugins of plugins. But a lightweight, carefully\ndesigned, and extensively tested layer of plugins on top of tsc could be\nvery nice.\n\nImagine how the language could grow if you could add rules to tsc via\nplugins, like they do in eslint. Without any changes to JavaScript eslint\nmanaged to get to a pretty good level of static analysis. Just imagine what\nthe community could do using TypeScript instead of JS.\n\nHow many times have I encountered a situation in TS where it wouldn't\ncompile even-though there was no way in hell the code could fail.\n\nLike:\n\nif (someArray.length > 0) {\n const x = someArray.pop();\n console.log(x.y);\n}\n\nDoesn't compile with strictNullChecks, x might be undefined. But i'm pretty\nsure it may not.\n\nBut I digress, sorry.\n\nOn Fri, Jul 30, 2021, 09:09 RA80533 ***@***.***> wrote:","author_login":"djfm","author_association":"NONE","created_at":"2021-07-30T10:26:32+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_902053320","fragment_type":"issue_comment","sequence":26,"text":"It creates non-valid ES6 code when given non-valid ES6 code. The first line in index.ts should be rewritten like so:\n\nts\nimport {start} from \"./lib.js\";","author_login":"RA80533","author_association":"NONE","created_at":"2021-08-19T16:22:47+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_902200532","fragment_type":"issue_comment","sequence":27,"text":"@RA80533, no, it creates non-valid ES6 code when given _valid_ TypeScript code.","author_login":"ericmorand","author_association":"NONE","created_at":"2021-08-19T19:57:45+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_918983144","fragment_type":"issue_comment","sequence":28,"text":"I also just stumbled over this issue and as usual I find the justifications of \"working as intended\" as really questionable. There are various settings in the compiler which steer the module system. If I set `\"module\": \"commonjs\"` my typescript `import` statements are rewritten to `require`. There is also `esModuleInterop` which adds some extensions around the module imports. \n\nWhile I agree that maybe the default behavior should be in the way that TypeScript leaves everything untouched, I also would say that it should/must be a TypeScript compiler setting to handle the mentioned use cases. I wanted to use TypeScript to create a small command line tool, which I can use in my GitHub Actions Workflow (without really making a reusable action) and it just does not work because the TypeScript output is not compatible with Node.js. Node.js seems to be usually a first class citizen in TS and here some very high level rules on the design goals (which IMO only partially apply here) prevent many people to use TS in such an obvious chain as running the compiled output in Node.js. \n\nMaybe we have better chances with the Node.js guys to extend the module resolution algorithm.","author_login":"Danielku15","author_association":"NONE","created_at":"2021-09-14T09:33:42+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_919083803","fragment_type":"issue_comment","sequence":29,"text":"Unbelievable how TS devs are stubborn on this.\n\nOn Tue, Sep 14, 2021, 11:33 Daniel Kuschny ***@***.***> wrote:","author_login":"djfm","author_association":"NONE","created_at":"2021-09-14T12:02:21+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_939636422","fragment_type":"issue_comment","sequence":30,"text":"Expectedly I stumbled upon this when setting a simple Node.js module written in TypeScript and compiled to CommonJS and ES to cater for both cases. I agree with @ericmorand and other similar opinions that, given a valid TypeScript code and valid TS configuration to target ES, the compiler SHOULD generate valid ES code. Otherwise, it should be considered a BUG. If it's a design goal to not generate valid code from TS code, then the design is flawed and needs to be fixed too.","author_login":"htr3n","author_association":"NONE","created_at":"2021-10-11T02:57:49+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_965093339","fragment_type":"issue_comment","sequence":31,"text":"I tried to use typescript@`^4.6.0-dev.20211110`and set `module: node12` in `tsconfig.json` but the compiled code still does not include `.js` file extension. @pwhissell could you give more hints?","author_login":"grimmer0125","author_association":"NONE","created_at":"2021-11-10T12:38:55+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_993826472","fragment_type":"issue_comment","sequence":32,"text":"Indeed, Typescript is a \"superset of Javascript\". But what means to be a superset? It means:\n\n1. you add more features to Javascript,\n2. you compile those added features to be valid Javascript.\n\nThe most basic Typescript additional rule is: \"you can type a variable\". Like this:\n\nts\nconst value: string = \"foo\"\n\nwhich will be *transformed* into `const value = \"foo\"`.\n\nOkay. You add a feature. You compile to make the feature work with the language. A superset of Javascript.\n\nNow there is another feature that is added by Typescript: the fact that the extension is optional.\n\nYou can write:\n\nts\nimport { imported } from \"./my-module.js\"\n\nwhich is valid Javascript *and* valid Typescript. That's normal: Typescript is a superset.\n\nBut because of the Typescript-specific rule \"make the file extension optional for ts/js files\" (not a Javascript rule), you can also write (in Typescript only):\n\nts\nimport { imported } from \"./my-module\"\n\nwhich is valid Typescript but **not valid Javascript**.\n\nIf you add a feature as a superset of a target language, then you ***must*** compile your feature into a valid output of yourtarget language.\n\nAnd, yes, \"make the file extension optional for ts/js files\" is definitely a Typescript-specific feature.","author_login":"Gin-Quin","author_association":"NONE","created_at":"2021-12-14T17:46:24+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_993842111","fragment_type":"issue_comment","sequence":33,"text":"I will add that I indeed created a library called `tsc-esm` as a workaround for this bug, and even though it works quite fine it has been a pain to develop and every time I use it (ie 100% of the times I need to create a library written in Typescript) I feel I should not have to patch the output of the Typescript compiler like I do.\n\nI look forward the day when I can tag my library as \"deprecated\" :)","author_login":"Gin-Quin","author_association":"NONE","created_at":"2021-12-14T18:06:29+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_995313362","fragment_type":"issue_comment","sequence":34,"text":"This whole discussion is absurd. Valid typescript obviously transpiles to invalid ES6 code. I do not understand in which world this can be classified as \"works as designed\" behavior. Adding \".js\" to import statements which actually refer to \".ts\" files as workaround is too wild for me. For my current project I have free choice, therefore I'm gonna switch over to CommonJS target module code. CommonJS works without file extensions. In case one can live with CommonJS target module, this is an option to get around this problem.","author_login":"PatrickFelber","author_association":"NONE","created_at":"2021-12-16T00:06:28+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1001632103","fragment_type":"issue_comment","sequence":35,"text":"An alternative way to make this work without adding dependencies is to use Node's `--es-module-specifier-resolution=node` flag. For example, `node --es-module-specifier-resolution=node dist/index.js`, where `index.js` would itself have ES-style imports without the .js file extension.","author_login":"counterposition","author_association":"NONE","created_at":"2021-12-27T15:58:03+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1013019070","fragment_type":"issue_comment","sequence":36,"text":"I've created a pull request wich wich solve this for raltive imports, see:\n\n URL \n\nI've added a compiler switch:\n\n appendModuleExtension","author_login":"jogibear9988","author_association":"NONE","created_at":"2022-01-14T11:00:06+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1148139676","fragment_type":"issue_comment","sequence":37,"text":"@RyanCavanaugh \n \n\nThis statement is simply not true! TS is a compiler and it is defined in the documentation as \"TypeScript is a strongly typed programming language that builds on JavaScript, giving you better tooling at any scale.\", in fact, it does even generate output not present in the input, for example, polyfills for handling \"await\" etc, depending on the selected target. So it is very much a compiler that outputs JS, the rest seems to be confabulation used not to fix issues that do not fit your current mental model of what TS should or should not do.","author_login":"manast","author_association":"NONE","created_at":"2022-06-07T03:01:40+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191421037","fragment_type":"issue_comment","sequence":38,"text":"I think probably a thousand person, me included, have written similar scripts. This is just absurd.","author_login":"djfm","author_association":"NONE","created_at":"2022-07-21T12:25:37+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191503142","fragment_type":"issue_comment","sequence":39,"text":"@ahejlsberg Please help us in the name of practicality and peace of mind.","author_login":"thomas-exxsite","author_association":"NONE","created_at":"2022-07-21T13:43:12+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193157812","fragment_type":"issue_comment","sequence":40,"text":"This conversation is really frustrating. While I can understand not adding the .js suffix under the rationale of not modifying Javascript (though I disagree with it), what I *cannot understand* is the compiler happily producing code that will fail to run. There should **at least be an option to fail compilation if I don't use a .js suffix in the import**. I don't even care if it's a default option, as long as it's exposed.\n\nIn the meanwhile, what do people recommend doing? What's the safest way to make sure tsc doesn't produce Javascript that will fail in this instance? I'm using node 16 and would really like top level awaits.","author_login":"NathanC","author_association":"NONE","created_at":"2022-07-23T17:13:28+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193160156","fragment_type":"issue_comment","sequence":41,"text":"Yeah, it's not like there aren't already 1000 compiler options to tune the\nbehaviour of TypeScript, one more won't hurt...\n\nOn Sat, 23 Jul 2022, 19:13 Nathan Coleman, ***@***.***> wrote:","author_login":"djfm","author_association":"NONE","created_at":"2022-07-23T17:28:58+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_1193161202","fragment_type":"issue_comment","sequence":42,"text":"And to reiterate, I'm not asking for am option that rewrites the imports, just an option that makes the compiler say \"hey, this probably isn't what you want and will generate broken code\", like a fatal warning. There could even be a flag that would override the warning and allow compilation anyways.\n\nSo `\"failOnInvalidModuleImport\": true` in tsconfig (defaults to false), which would cause the compilation failure, and a flag `tsc --allow-invalid-module-import`which would ignore even if the setting was true, and compile anways.\n\nTypeScript team, can you comment on adding an option like this? This is clearly a problem people have, and I can't see how exposing a default false option to give some greater compile safety could be a bad thing there. It would be a great way to earn some developer good will :)","author_login":"NathanC","author_association":"NONE","created_at":"2022-07-23T17:35:57+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193212625","fragment_type":"issue_comment","sequence":43,"text":"As you all also see in my pull req, the rewrite are only a few lines of code","author_login":"jogibear9988","author_association":"NONE","created_at":"2022-07-24T00:12:33+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1204341749","fragment_type":"issue_comment","sequence":44,"text":"The recommendation to preemptively append `.js` extensions to TypeScript source is not only counterintuitive, it breaks ts-jest tests. It seems to me that TypeScript is in the wrong here. Why ban `.ts` extensions from import statements and encourage leaving them off altogether if the extension is resolved by the language server but *not* the compiler?\n\nI just encountered this issue while attempting to port a library to TypeScript. I didn’t have to deal with it in prior projects because I was building apps with a bundler. Now that I’m emitting modules that can be tree-shaken downstream, this behavior, intended or not, leaves me in a bit of a pickle.","author_login":"adamshaylor","author_association":"NONE","created_at":"2022-08-03T18:42:36+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1204666783","fragment_type":"issue_comment","sequence":45,"text":"@adamshaylor for what it's worth, vitest supports `.js` imports in test code and is largely API-compatible with Jest.","author_login":"counterposition","author_association":"NONE","created_at":"2022-08-04T01:51:24+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1256131378","fragment_type":"issue_comment","sequence":46,"text":"good to see this crazy conversation still going after 2 years\n\nits amazing to me that something so basic as module resolution continues to be one of the most frustrating things about the nodejs ecosystem\n\nI cannot wait for deno to gain more traction and put this issue to bed by enforcing esm\n\nto the TS team, listen to your users and add a compiler flag","author_login":"ProfXponent","author_association":"NONE","created_at":"2022-09-23T12:10:06+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264504331","fragment_type":"issue_comment","sequence":47,"text":"I've got a react app that's being bundled with webpack, and a pure typescript server. The 2 projects share some model classes.\n\nIf I import my classes using the standard Typescript syntax `import MyClass from \"./model/MyClass\"`, I get the \"cannot find module ... imported from ...\" error.\n\nAlright, fine, I can simply add the \".js\": `import MyClass from \"./model/MyClass.js\"`\n\n... This causes webpack errors \"Module not found: Error: Can't resolve './MyClass.js' in \"...\"\"\n\nThis is infuriating","author_login":"tran-simon","author_association":"NONE","created_at":"2022-10-01T23:10:20+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1278396769","fragment_type":"issue_comment","sequence":48,"text":"At first glance of the time of this issue, I think I'm lucky to find a perfect solution. Until scrolling to the bottom then I realize that I'm unlucky. So sad.","author_login":"LinksRay","author_association":"NONE","created_at":"2022-10-14T02:41:34+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1302230947","fragment_type":"issue_comment","sequence":49,"text":"So weird. In VSC if you Cmd+click on a `import something from 'something.js';` you'll get to the .ts file, like VSC knows that this issue exists and \"fixes it\".","author_login":"claudioc","author_association":"NONE","created_at":"2022-11-03T14:51:18+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1303809976","fragment_type":"issue_comment","sequence":50,"text":"But wasn't it fixed?\n\nTo my greatest surprise, in my latest project, I'm using relative imports\nin TypeScript without a file extension and the emitted JS just works!\n\nOn Thu, 3 Nov 2022, 15:51 Claudio Cicali, ***@***.***> wrote:","author_login":"djfm","author_association":"NONE","created_at":"2022-11-04T16:04:45+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[713122066],"is_known_query_context":false},{"document_id":"gh_comment_1312803239","fragment_type":"issue_comment","sequence":51,"text":"This has nothing to do with VSC and also works in every other editor with the typescript LSP. Completely unrelated to this issue.","author_login":"Nimmidev","author_association":"NONE","created_at":"2022-11-13T19:28:37+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1416018432","fragment_type":"issue_comment","sequence":52,"text":"2023 now, and the flicker of hope for this feature is still alive!\nSee URL","author_login":"jmrossy","author_association":"NONE","created_at":"2023-02-03T15:20:26+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1416063236","fragment_type":"issue_comment","sequence":53,"text":"Here a few pull requests or issues, where i need only file extensions (.js) so I could use them in browser:\n\n URL \n URL \n\nI don't know why an extra option wich I created in my pull request could not be added...","author_login":"jogibear9988","author_association":"NONE","created_at":"2023-02-03T15:56:51+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1416117989","fragment_type":"issue_comment","sequence":54,"text":"I know use a js script to add the extension afterwards, see the pull I creaed here on how to do: URL","author_login":"jogibear9988","author_association":"NONE","created_at":"2023-02-03T16:38:55+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445157248","fragment_type":"issue_comment","sequence":55,"text":"Just leaving my `+1` here... can't believe this is still an issue.\n\nWould be as simple as to allow using `.ts` extensions and then transform them into `.js`.\n\nThis would make everyone happy: hundreds of people asking for it and TS maintainers because TS principles will not be affected this way (read this comment).\n\nHope TS maintainers will reconsider this soon.","author_login":"ernestostifano","author_association":"NONE","created_at":"2023-02-25T16:50:27+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1446796326","fragment_type":"issue_comment","sequence":56,"text":"Cross-posting this comment which explains that this is, very much intentionally, not something we are going to do.","author_login":"RyanCavanaugh","author_association":"MEMBER","created_at":"2023-02-27T18:01:09+08:00","repo_name":"microsoft/TypeScript","issue_id":713122066,"issue_number":40878,"issue_url":"https://github.com/microsoft/TypeScript/issues/40878","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0256","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[frontend] logs and artifacts stored in different Minio locations and can't be accessed by frontent?","query_context":"### Environment\n\n* How did you deploy Kubeflow Pipelines (KFP)? from repo\n* KFP version: 1.7.0\nTo find the version number, See version number shows on bottom of KFP UI left sidenav. -->\n* KFP SDK version: \n\nkfp 1.7.0\nkfp-pipeline-spec 0.1.9\nkfp-server-api 1.7.0\n\n### Steps to reproduce\n\n* run a pipeline and store an artifact\n* delete the pod\n\nThen we see that:\n* The artifact (and its preview) can be seen in the output list of Input/Output tab\n* The metrics can be accessed by the visualisations tab\n* A wrong link to the metrics is found in the outputs list of the input/Outputs tab\n * details read `Failed to get object in bucket mlpipeline at path v2/artifacts/pipeline/example pipeline/e154ea68-d59c-46ba-aea4-ead5b9eb0ea8/square/metrics: S3Error: The specified key does not exist.`\n* The logs cannot be retrieved from minio in the logs tab\n * details read `Error response: Could not get main container logs: Error: Unable to find pod log archive information from workflow status.`\n\nLooking in MiniO it seems \n* the Artifact is stored at\n`mlpipeline/v2/artifacts/pipeline/example%20pipeline/e154ea68-d59c-46ba-aea4-ead5b9eb0ea8/square/`\n\n* and the logs and metrics are stored at\n`mlpipeline/artifacts/example-pipeline-ljzls/2021/08/25/example-pipeline-ljzls-1034021739/`\n\nminimal code sample:\n\npython\nimport kfp\nfrom kfp.v2.dsl import pipeline, component, Output, Metrics, Artifact\n\n@component(base_image='python:3')\ndef square(x: int, metrics: Output[Metrics], data: Output[Artifact]):\n metrics.log_metric('test_metrics', 1)\n metrics.log_metric(f'{x} squared', x**2)\n print(f'{x} squared is {x**2}')\n \n with open(data.path, 'w') as f:\n f.write(\"some content\")\n\n@pipeline(name='example pipeline')\ndef pipeline():\n square(4)\n\nclient = kfp.Client(host=' URL \nclient.create_run_from_pipeline_func(\n pipeline, arguments={}, run_name='Example run',\n experiment_name='Default', enable_caching=False,\n mode=kfp.dsl.PipelineExecutionMode.V2_COMPATIBLE\n)\n\n### Expected result\n\nThe logs and metrics can be retrieved from MiniO by the frontend even when pods are deleted\n\n### Materials and Reference\n\nIs this a configuration issue? Should I move things to point only to v2 path?\n\n---\n\n \nImpacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.","known_context_document_ids":["gh_issue_978966541"],"reference_answer":"@kubeflow/pipelines @HumairAK @pdettori I would like to ask that we prioritize this issue, it is a significant regression for V2 pipelines.\n\nThe gist of the issue is that when Argo Workflows has the `archiveLogs` config set (which we do at the cluster level in our manifests), then Argo Workflows automatically creates a \"output artifact\" called `main-logs` which full Pod logs of each step as an S3/MinIO artifact.\n\nIn Kubeflow Pipelines V1, we used to capture this output artifact, which allowed users to see the old logs when the Pod had disappeared, but in V2 this was strangely omitted.\n\nFixing it should be very straightforward, we just need to capture the artifact location of the `main-logs` output of the `executor` step, and store it as an \"Output Artifact\" in the ML Metadata of the step.\n\nFor reference, we can retrieve this artifact by reading the status field of the `Workflow` resource:\n\nyaml\nstatus:\n nodes:\n pipeline-1-8g5bs-3160443754:\n displayName: executor\n outputs:\n artifacts:\n - name: main-logs\n s3:\n key: artifacts/team-1/pipeline-1-8g5bs/2024/06/13/pipeline-1-8g5bs-3160443754/main.log","answer_document_id":"gh_comment_2164166923","silver_evidence_path":["gh_comment_2164154245","gh_issue_1914251519","gh_comment_2164166923"],"evidence_issue_ids":[978966541,1914251519],"source_repo_name":"kubeflow/pipelines","source_issue_id":978966541,"source_issue_number":6428,"source_issue_url":"https://github.com/kubeflow/pipelines/issues/6428","target_repo_name":"kubeflow/pipelines","target_issue_id":1914251519,"target_issue_number":10036,"target_issue_url":"https://github.com/kubeflow/pipelines/issues/10036","reference_anchor_document_id":"gh_comment_2164154245","reference_answer_author":"thesuperzapper","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1852,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1639},"issue_created_at":"2021-08-25T10:13:50+08:00","valid_comment_count":50,"fragments":[{"document_id":"gh_issue_978966541","fragment_type":"issue_description","sequence":0,"text":"[frontend] logs and artifacts stored in different Minio locations and can't be accessed by frontent\n### Environment\n\n* How did you deploy Kubeflow Pipelines (KFP)? from repo\n* KFP version: 1.7.0\nTo find the version number, See version number shows on bottom of KFP UI left sidenav. -->\n* KFP SDK version: \n\nkfp 1.7.0\nkfp-pipeline-spec 0.1.9\nkfp-server-api 1.7.0\n\n### Steps to reproduce\n\n* run a pipeline and store an artifact\n* delete the pod\n\nThen we see that:\n* The artifact (and its preview) can be seen in the output list of Input/Output tab\n* The metrics can be accessed by the visualisations tab\n* A wrong link to the metrics is found in the outputs list of the input/Outputs tab\n * details read `Failed to get object in bucket mlpipeline at path v2/artifacts/pipeline/example pipeline/e154ea68-d59c-46ba-aea4-ead5b9eb0ea8/square/metrics: S3Error: The specified key does not exist.`\n* The logs cannot be retrieved from minio in the logs tab\n * details read `Error response: Could not get main container logs: Error: Unable to find pod log archive information from workflow status.`\n\nLooking in MiniO it seems \n* the Artifact is stored at\n`mlpipeline/v2/artifacts/pipeline/example%20pipeline/e154ea68-d59c-46ba-aea4-ead5b9eb0ea8/square/`\n\n* and the logs and metrics are stored at\n`mlpipeline/artifacts/example-pipeline-ljzls/2021/08/25/example-pipeline-ljzls-1034021739/`\n\nminimal code sample:\n\npython\nimport kfp\nfrom kfp.v2.dsl import pipeline, component, Output, Metrics, Artifact\n\n@component(base_image='python:3')\ndef square(x: int, metrics: Output[Metrics], data: Output[Artifact]):\n metrics.log_metric('test_metrics', 1)\n metrics.log_metric(f'{x} squared', x**2)\n print(f'{x} squared is {x**2}')\n \n with open(data.path, 'w') as f:\n f.write(\"some content\")\n\n@pipeline(name='example pipeline')\ndef pipeline():\n square(4)\n\nclient = kfp.Client(host=' URL \nclient.create_run_from_pipeline_func(\n pipeline, arguments={}, run_name='Example run',\n experiment_name='Default', enable_caching=False,\n mode=kfp.dsl.PipelineExecutionMode.V2_COMPATIBLE\n)\n\n### Expected result\n\nThe logs and metrics can be retrieved from MiniO by the frontend even when pods are deleted\n\n### Materials and Reference\n\nIs this a configuration issue? Should I move things to point only to v2 path?\n\n---\n\n \nImpacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.","author_login":"jonasdebeukelaer","author_association":"CONTRIBUTOR","created_at":"2021-08-25T10:13:50+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1236821061","fragment_type":"issue_comment","sequence":1,"text":"It has been one year, did anyone found out how to resolve/workaround this bug that'd be great, Im sure this is one of the major bugs.","author_login":"capoolebugchat","author_association":"NONE","created_at":"2022-09-05T10:27:09+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018609316","fragment_type":"issue_comment","sequence":2,"text":"Having the same issue with Kubeflow Pipelines 0.2.5 - if pods created by workflow are deleted, logs cannot be accessed from MinIO artifact store, even if they are archived there. Has anyone actually found a way to make this work ?","author_login":"pdettori","author_association":"NONE","created_at":"2024-03-25T18:11:14+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2021309923","fragment_type":"issue_comment","sequence":3,"text":"I think I found the root cause of the problem. It is likely that the schema for Argo Workflow status has changed, as the Argo Workflow fields that are retrieved by URL are not anymore where the ts code expects it. The code expects a workflow status with S3 info under the node's output artifacts, but Argo Workflow may have changed since when that code was written and those properties are now under:\n\nstatus:\n artifactRepositoryRef:\n artifactRepository:\n archiveLogs: true\n s3:","author_login":"pdettori","author_association":"NONE","created_at":"2024-03-26T19:33:22+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2133371397","fragment_type":"issue_comment","sequence":4,"text":"According to URL URL should have fixed it. Do you still have issues?","author_login":"AndersBennedsgaard","author_association":"NONE","created_at":"2024-05-27T12:23:16+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2134230680","fragment_type":"issue_comment","sequence":5,"text":"I still have the issue with KFP 2.2.0, which includes #10568 - does not look like the UI was updated to retrieve the S3 log artifacts stored by Argo. I have a fix in my fork that shows what is needed for the UI to work with the archived logs - URL","author_login":"pdettori","author_association":"NONE","created_at":"2024-05-28T02:02:55+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164154245","fragment_type":"issue_comment","sequence":6,"text":"Since this issue is about `V2_COMPATIBLE` mode I am going to close it as that mode is no longer supported.\n\nHowever, as @pdettori (and the other recent comments have raised) there is a similar issue present in `V2` mode because we don't capture the `main.log` as an output artifact anymore. \n\nLet's continue the discussion on the other issue:\n- URL \n\n/close","author_login":"thesuperzapper","author_association":"MEMBER","created_at":"2024-06-13T00:51:45+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[1914251519],"is_known_query_context":false},{"document_id":"gh_comment_2164154849","fragment_type":"issue_comment","sequence":7,"text":"@pdettori I see in URL that you propose a solution to the V2 issue.\n\nCan you please continue this discussion on the V2 issue: URL","author_login":"thesuperzapper","author_association":"MEMBER","created_at":"2024-06-13T00:52:34+08:00","repo_name":"kubeflow/pipelines","issue_id":978966541,"issue_number":6428,"issue_url":"https://github.com/kubeflow/pipelines/issues/6428","linked_issue_ids":[1914251519],"is_known_query_context":false},{"document_id":"gh_issue_1914251519","fragment_type":"issue_description","sequence":0,"text":"[feature] display main.log as artifact for each step\n### Feature Area\n/area frontend\n/area backend\n\n### What feature would you like to see?\nA feature similar to v1 behavior. In the details page of each step, the log appears as one of the artifacts that users can view:\nimage\n\nIn v2, this main log artifact is no longer displayed. It would be great if we could add a similar section to show the logs, or use the log artifact as a source for the \"logs\" panel after the pod is deleted, instead of directly pulling from the (already deleted) pod.\n\n### What is the use case or pain point?\n\nBecause all the logs of completed pods are auto deleted by Kubernetes after 24 hours, the users can no longer access the logs of earlier pipeline runs. \n\n### Is there a workaround currently?\n\nNo workaround.\n\n/cc @kromanow94\n\n---\n\n \nLove this idea? Give it a 👍.","author_login":"Linchin","author_association":"CONTRIBUTOR","created_at":"2023-09-26T20:28:23+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1914589672","fragment_type":"issue_comment","sequence":1,"text":"I read that this issue was not included in the previous release as mentioned in this comment , just wanted to ask whether we have an update on this or not.","author_login":"revolutionisme","author_association":"NONE","created_at":"2024-01-29T12:25:17+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2109519119","fragment_type":"issue_comment","sequence":2,"text":"/reopen\n\nIs readding this feature to v2 planned for future releases? It would be very helpful.","author_login":"AnnKatrinBecker","author_association":"NONE","created_at":"2024-05-14T07:54:33+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2110415021","fragment_type":"issue_comment","sequence":3,"text":"I'm a bit unfamiliar with the v1 version of this, did this come from argo's archive logging feature? \n\nIn v2 kfp aims to be agnostic to the backing engine, so if this is an argo specific feature, we may need to consider a separate feature/proposal on how to handle persistent logging in general for kfp.","author_login":"HumairAK","author_association":"CONTRIBUTOR","created_at":"2024-05-14T14:36:30+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2110439758","fragment_type":"issue_comment","sequence":4,"text":"Yes, Argo Workflows stores the logs separately and given only kfp metadata, there currently seems to be no way to obtain the logs' locations. You'd need to access the Argo Workflow object directly to obtain the info.\n\nIncluding this feature right into kfp would make sense and imo is much needed, as otherwise, users aren't able to view logs after the step's pod has been deleted.","author_login":"TobiasGoerke","author_association":"CONTRIBUTOR","created_at":"2024-05-14T14:46:28+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2133619225","fragment_type":"issue_comment","sequence":5,"text":"Hi @HumairAK What do you think about this ? \nPoints:\n- DS engineer would be interesting to see logs as artifact, as part of models producer investigation\n- logs can have different retention against artifacts: user can clean them to reduce space usage\n- it is better to have interactive logs\n\nThoughts:\n- in launcher POD: use extra container for waiting logs and publish or use other approaches: fluentd.... it is up to user how to collect logs and put logs. But by default we will do by sidecar container. For this we should disable argoworflow logs.\n- during run we subscribe real container logs stream (this logic already implemented)\n- allow launcher use separate bucket for logs or use the same as artifact\n- in sdk we should be able disable logs","author_login":"sanchesoon","author_association":"NONE","created_at":"2024-05-27T14:39:52+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2133649633","fragment_type":"issue_comment","sequence":6,"text":"I agree persisted logging is very important, but we should clarify if we need them as artifacts, or do users just want to see logs after pods have been removed? \n\nFor example, if we have persisted logs, the log viewer could instead fetch the logs from the persisted location instead of pods (I believe this is the logic currently present in ui, though it may not be utilized in v2). Could it be confusing to see 2 different locations where logs are being shown? \n \n\nNot disagreeing, but could you elaborate on specifics? \n\nI like the idea of decoupling implementation to existing solutions (or at least giving the user the option to, if we opt to natively implement), \n \n\nI think we should also allow users to disable/enable not only in the SDK, but via api & ui as well.","author_login":"HumairAK","author_association":"CONTRIBUTOR","created_at":"2024-05-27T14:57:35+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2134104292","fragment_type":"issue_comment","sequence":7,"text":"Why engineers may interesting in this:\n- some frameworks for ML logging kind of metrics \nimage\n- kubeflow run is snapshot of inputs/intermediate/code/config which can help to reproduce or compare, so for the same combinations of inputs/intermediate/code/config, it is possible to have different logs due to different conditions in cluster: gpu, cpu, drivers.... that is why logs is part of this snapshot\n\nv1 version was implemented correctly from concept view, because it combine logs interaction during run (life time stream from pod) and logs persistent for long term.","author_login":"sanchesoon","author_association":"NONE","created_at":"2024-05-27T22:25:28+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2161582759","fragment_type":"issue_comment","sequence":8,"text":"@sanchesoon Can you give more details on this workaround? I am currently using KFP `2.1.0` with the normal argoworkflow backend. I really want a way to provide users the ability to view their pipeline tasks' logs simply by clicking through the KFP UI.","author_login":"tom-pavz","author_association":"NONE","created_at":"2024-06-11T20:51:27+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2164166923","fragment_type":"issue_comment","sequence":9,"text":"@kubeflow/pipelines @HumairAK @pdettori I would like to ask that we prioritize this issue, it is a significant regression for V2 pipelines.\n\nThe gist of the issue is that when Argo Workflows has the `archiveLogs` config set (which we do at the cluster level in our manifests), then Argo Workflows automatically creates a \"output artifact\" called `main-logs` which full Pod logs of each step as an S3/MinIO artifact.\n\nIn Kubeflow Pipelines V1, we used to capture this output artifact, which allowed users to see the old logs when the Pod had disappeared, but in V2 this was strangely omitted.\n\nFixing it should be very straightforward, we just need to capture the artifact location of the `main-logs` output of the `executor` step, and store it as an \"Output Artifact\" in the ML Metadata of the step.\n\nFor reference, we can retrieve this artifact by reading the status field of the `Workflow` resource:\n\nyaml\nstatus:\n nodes:\n pipeline-1-8g5bs-3160443754:\n displayName: executor\n outputs:\n artifacts:\n - name: main-logs\n s3:\n key: artifacts/team-1/pipeline-1-8g5bs/2024/06/13/pipeline-1-8g5bs-3160443754/main.log","author_login":"thesuperzapper","author_association":"MEMBER","created_at":"2024-06-13T01:08:42+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168252034","fragment_type":"issue_comment","sequence":10,"text":"Completely agree with @thesuperzapper. Having a run fail and not being able to determine the reason why because the logs are not available is a show stopper.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-06-14T15:15:26+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168263051","fragment_type":"issue_comment","sequence":11,"text":"yes, This is show stopper and required to retrieve logs of completed DAGs","author_login":"moorthy156","author_association":"CONTRIBUTOR","created_at":"2024-06-14T15:22:07+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2171590869","fragment_type":"issue_comment","sequence":12,"text":"Hi\nYes I can.\nIn argo workflow you should use something like this:\n\n archiveLogs: true\n s3:\n keyFormat: {{ `\"pod/log/{{workflow.name}}/{{pod.name}}\"` }}\n\nAnd patch frontend split function, frontend/server/workflow-helper.ts:\n\nfunction workflowNameFromPodName(podName: string) {\n return podName.replace(/-system-container-impl-.*/, '')\n}\n\nAnd don't forget configure you kubeflow proxy frontend \nkubectl -n kubeflow describe po ml-pipeline-ui\n\n ARGO_ARCHIVE_LOGS: true\n ARGO_ARCHIVE_ARTIFACTORY: s3\n ARGO_ARCHIVE_PREFIX: pod/log\n ARGO_ARCHIVE_BUCKETNAME\n AWS_ACCESS_KEY_ID\n AWS_SECRET_ACCESS_KEY\n AWS_REGION\n AWS_SSL\n AWS_S3_ENDPOINT\n AWS_PORT","author_login":"sanchesoon","author_association":"NONE","created_at":"2024-06-16T13:18:51+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2218799896","fragment_type":"issue_comment","sequence":13,"text":"My team and I are making good progress. We have a functional POC. It just needs some polish. It involves sending the run execution date to the logging handler since the current AWF configuration stores the log artifacts in date-based subfolders (to reduce the likelihood of collisions (see URL The existing code is more or less fine, it's just looking for the logs in the wrong location. The UX for this will be a bit different than v1. Logs will not be listed under output artifacts. Instead, when the logs tab is loaded, if the k8s pod is not accessible, it will populate the react component from the artifact store instead.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-09T21:56:59+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2219092767","fragment_type":"issue_comment","sequence":14,"text":"@droctothorpe however you do it, make sure that you don't assume anything about the structure of the Argo Workflows `s3.keyFormat` as that is not guaranteed to be the same in all environments.\n\nFor example, some users have changed their key format to a different prefix or path structure which may or may not be the same as the current default in Kubeflow Pipelines.\n\nThat's why I said in URL that you have to get the true path from the workflow status.","author_login":"thesuperzapper","author_association":"MEMBER","created_at":"2024-07-10T00:08:31+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[1914251519],"is_known_query_context":false},{"document_id":"gh_comment_2219285881","fragment_type":"issue_comment","sequence":15,"text":"@thesuperzapper, if I understand the logic correctly, the handler does in fact try to get the log artifact path from the workflow status **first** (if the k8s pods have been garbage collected). It only tries to call the artifact store directly (in a way that currently makes incorrect assumptions about where the log is located) if the workflow has been garbage collected.\n\nThe logic tries to retrieve the logs from multiple sources in the following sequence:\n\n1. It tries to retrieve the logs from the pod (link).\n2. If that fails, it tries to retrieve the logs path by extracting it from the workflow CR (function invocation link, function definition link (with some nesting)).\n3. If that fails **and** `archiveLogs` is true (this is set in config.ts), then and only then does it try to retrieve the logs directly from the artifact store without pathing through the workflow CR. Currently, master makes incorrect assumptions about the path (here is where it is constructed) that are at odds with the keyFormat default in the `workflow-controller-configmap` object.\n\n@sanchesoon's suggestion essentially reverts the log location, but URL and the comments in the configmap convey that dates were deliberately added to the path to reduce the likelihood of collisions.\n\nOur fix essentially corrects the assumption and is only applicable if the workflow has been garbage collected.\n\nIf a user both modifies the keyFormat **and** deletes the workflow CR, option 3 will not work. Why would a user want to modify the keyFormat though? Is that a rare enough edge case that solving for it would constitute bike-shedding? If not, there may be a way to have the handler call the K8s API to lookup the `workflow-controller-configmap`, extract the `keyFormat` and translate it somehow in a dynamic way that the function could parse, but that would (a) add latency, and (b) probably be a PITA, especially figuring out how to map the Go templating syntax to specific parameters in the function in a way that properly accounts for the sundry variants in the template tags. \n\nRelevant meme:\nimage","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-10T01:12:27+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2219944320","fragment_type":"issue_comment","sequence":16,"text":"@droctothorpe\n \n\nIf I understand correctly, this is only the case until the information about where the log artifact is stored is saved to the pipeline run artifacts, right? I take that this is the assumption because it wouldn't be too good to have a requirement of storing the Argo WF CR Objects on the etcd indefinitely. And if this assumption is right, we can use a very simple K8s mechanism to prevent users from manually deleting the WF CR objects before the information about where is the log artifact is stored to Pipeline Run Artifacts - finalizers.\n\nIf we were to use finalizers, we can just make the assumption that we control when exactly the Argo WF CR is released to be GCed and simplify the scenario a bit.\n \n\nThere can be some requirement or limitation where you'd have to reuse the same S3 Bucket for multiple purposes (like multiple KF Instances or a general bucket for logs from multiple sources) because of how a company/organization manages the infrastructure (so in this example you're given an S3 Bucket with a specific prefix where you can save the logs artifacts, lets say `/artifacts/kubeflow/{{workflow.namespace}}/pod/log/{{workflow.name}}/{{pod.name}}`.\n\nAnother example would be if each KF Profile is serving a different team and you're hoping to achieve full Profile isolation where Team A doesn't have any form of access to the logs of Team B. This is something similar to what @thesuperzapper pointed out in the URL `artifacts/team-1/pipeline-1-8g5bs/2024/06/13/pipeline-1-8g5bs-3160443754/main.log`.\n\nAlso, in enterprise environment, you're rarely given the full freedom over your infrastructure and it would be a real issue if something as simple as the `keyFormat` would be a blocker in adopting KF.","author_login":"kromanow94","author_association":"NONE","created_at":"2024-07-10T08:56:57+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[1914251519],"is_known_query_context":false},{"document_id":"gh_comment_2220120768","fragment_type":"issue_comment","sequence":17,"text":"@kromanow94 Thanks for the context! \n \n\nCorrect. Workflows gets GCed after a specified length of time as defined by the TTLStrategy field. Even after workflows are deleted, the corresponding logs persist in the artifact store.\n\nAny objections to letting end users specify the typescript equivalent of an f-string through an env var via `config.ts`? We could document some predetermined variable names that map to what's available in the corresponding handler (e.g. namespace, pod name, date, etc.), and add a comment to the `keyFormat` field stating that if it's modified, the corresponding field in `config.ts` should be updated.\n\nThe alternative is making the logs explicit output artifacts in MLMD. I would be curious to hear from Google about why that was disabled in v2 before reverting it. Output artifacts are first class citizens with dedicated nodes in the v2 graphs; we probably don't want every component to have a corresponding log node in the DAG, so we'd have to handle that in the graph rendering logic as well.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-10T10:23:35+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220190740","fragment_type":"issue_comment","sequence":18,"text":"@droctothorpe \n \n\nMore a doubt than an objection - maybe going for the env var via `config.ts` is just not required at all? If we were to use the finalizer pattern, we assume that it's not required to _reverse engineer_ where the logs _might_ be stored. I think the information about the log URI location should be an integral part of the KFP Step and once that step is finished, we should only reference the KFP Step to get the information where the log artifact is stored.\n\nBut, maybe there is something obvious I don't see that conflicts with this approach. At end, what I think makes sense is to somehow save the address of the logs and put it together with the Step Execution. If this can be stored again in the MLMD, great. If not, is there any other place where we can store it? Maybe this is the part I don't yet fully understand - if the log artifact URI is not saved in the MLMD, do we have any other place where we can store that information, or currently we're forced to guess where the logs might be through the `config.ts`?","author_login":"kromanow94","author_association":"NONE","created_at":"2024-07-10T10:53:06+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220209021","fragment_type":"issue_comment","sequence":19,"text":"Currently, the UI is just guessing and guessing incorrectly, heh. If we store it as an output artifact in MLMD, that removes any guess work but substantially broadens the scope of the changes and will definitely require design review from Google.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-10T11:01:16+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220225180","fragment_type":"issue_comment","sequence":20,"text":"Another argument in favor of storing the log as an output artifact is what if an admin elects to update the keyFormat? The logs for historical runs will no longer be accessible, and there won't be a way for the UI to support both the old and new patterns at once.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-10T11:07:27+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220231576","fragment_type":"issue_comment","sequence":21,"text":"My personal preference for maturity and stability would be to go with the MLMD and google review or an alternative store if possible. I'd even investigate if creating additional table in the mlpipeline db makes sense just to store the log artifacts URIs for given Step ID. Considering all the discussion, I don't feel competent enough to suggest if the workaround with the env var in the `config.ts` is suitable for now... If I were to make this decision myself, I wouldn't do it.","author_login":"kromanow94","author_association":"NONE","created_at":"2024-07-10T11:10:25+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220245671","fragment_type":"issue_comment","sequence":22,"text":"I'm starting to lean in that direction as well, but what the heck do I know, I am just a ~plebe~ user. \n\nDoes ya'll think it make sense to submit a smaller, discrete PR that corrects the UI's incorrect guess _for the time being_ until we can implement a broader fix that adds the log URI to MLMD? We can aim to submit the PR tomorrow (at AWS Summit all day today) to give you a sense of the scope.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-10T11:16:53+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2220261306","fragment_type":"issue_comment","sequence":23,"text":"If this can be added to the KF 1.9 then maybe it makes sense to unblock this with the idea you've proposed with `config.ts`. If it's not going to be a part of the v1.9 release because how short on time we are, maybe not so much.","author_login":"kromanow94","author_association":"NONE","created_at":"2024-07-10T11:23:54+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2221773267","fragment_type":"issue_comment","sequence":24,"text":"I just want to highlight what I said in URL again.\n\nThis is very clearly an accidental regression, because KFP V1 stores the logs in an MLMD artifact (it just did not automatically forward the logs tab to the appropriate artifacts and required users to click the step and view it).\n\nThe only additional complexity (which is probably why this was overlooked) is that in KFP v2 now each step is more than one container, each with its own logs.\n\nAssuming we store the logs for all steps as an artifact (even the non-executor steps) we should correctly show them separately in the logs tab probably with some kind of sub-tab for each container.","author_login":"thesuperzapper","author_association":"MEMBER","created_at":"2024-07-11T00:39:59+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[1914251519],"is_known_query_context":false},{"document_id":"gh_comment_2223816342","fragment_type":"issue_comment","sequence":25,"text":"@chensun @zijianjoy @connor-mccarthy Do you have any objections to adding the driver and executor logs to the list of output artifacts for each component? I just want to make sure that removing that functionality was not a deliberate design choice before we re-implement it in v2. Thank you!","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-11T19:58:46+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225898657","fragment_type":"issue_comment","sequence":26,"text":"I think the executor outputs are being extracted from the IR, and currently the IR doesn't include information about the container logs. We need to decide if we want to include the container logs as executor outputs, which is quite complicated because (a) the path is dynamically inferred by `keyFormat` (for AWF) and not available client-side at IR compilation time, and (b) is extremely AWF specific in a way that could undermine workflow orchestration agnosticism in the IR.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-12T16:08:53+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2231250999","fragment_type":"issue_comment","sequence":27,"text":"POC for the interim solution: URL This will make it possible for anyone to implement a solution in a way that accommodates their unique `keyFormat` syntax without having to modify the actual code. \n\nI plan to join the community call tomorrow to hear from Google about the proposed target-state solution of storing logs as output artifacts.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-07-16T15:35:52+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2292078408","fragment_type":"issue_comment","sequence":28,"text":"URL was just merged 🎉 . It might make make sense to keep this issue open to continue discussion about wether or not to / how to surface driver and executor logs as explicit outputs in the GUI.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-08-15T19:51:02+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2338531429","fragment_type":"issue_comment","sequence":29,"text":"Hey, I noticed the PR is already included in the `2.3.0`. I'm trying to run some tests but I get the following error and I'm not able to get the logs from the Pod Step. I'm having two issues:\n\nThe `ml-pipeline-ui` Pod is exiting the main process with the following error:\n\n/server/node_modules/node-fetch/lib/index.js:1491\n reject(new FetchError(`request to ${request.url} failed, reason: ${err.message}`, 'system', err));\n ^\nFetchError: request to URL failed, reason: getaddrinfo ENOTFOUND metadata\n at ClientRequest. (/server/node_modules/node-fetch/lib/index.js:1491:11)\n at ClientRequest.emit (node:events:517:28)\n at Socket.socketErrorListener (node:_http_client:501:9)\n at Socket.emit (node:events:517:28)\n at emitErrorNT (node:internal/streams/destroy:151:8)\n at emitErrorCloseNT (node:internal/streams/destroy:116:3)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {\n type: 'system',\n errno: 'ENOTFOUND',\n code: 'ENOTFOUND'\n}\n\nIn the short period of time when the `ml-pipeline-ui` is responsive before it's exiting with the above mentioned error code, I'm getting this error:\n\nCould not get main container logs: Error: Unable to retrieve workflow status: [object Object].\n\nDo you know what might be causing the issue?","author_login":"kromanow94","author_association":"NONE","created_at":"2024-09-09T16:13:24+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2338576686","fragment_type":"issue_comment","sequence":30,"text":"FYI, I was testing with kubeflow/manifests 1.9.0 and only changed the container images tags for pipeline components to `2.3.0`.","author_login":"kromanow94","author_association":"NONE","created_at":"2024-09-09T16:35:51+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2338653681","fragment_type":"issue_comment","sequence":31,"text":"@kromanow94, someone in the (deprecated) Kubeflow slack workspace recently DMed me reporting what looks like a very similar error and a corresponding solution:\n\n WF manifest lookup -> artifact store lookup) is defined here. Note that the third step only executes if `archiveLogs` is true.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-09-09T17:16:25+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2340206338","fragment_type":"issue_comment","sequence":32,"text":"I also run another scenario with one of the default pipelines. Using the `Run of [Tutorial] DSL - Control structures` will create a set of Pods with the following names:\n\ntutorial-control-flows-gbjpn-system-dag-driver-1941995042\ntutorial-control-flows-gbjpn-system-dag-driver-2529298331\ntutorial-control-flows-gbjpn-system-container-driver-3821465773\ntutorial-control-flows-gbjpn-system-container-driver-467613593\ntutorial-control-flows-gbjpn-system-container-impl-2018360503\ntutorial-control-flows-gbjpn-system-dag-driver-3793006146\ntutorial-control-flows-gbjpn-system-container-driver-1781539373\ntutorial-control-flows-gbjpn-system-dag-driver-1653906037\ntutorial-control-flows-gbjpn-system-dag-driver-477249553\ntutorial-control-flows-gbjpn-system-dag-driver-3564565339\ntutorial-control-flows-gbjpn-system-dag-driver-511401279\ntutorial-control-flows-gbjpn-system-container-impl-1647980155\ntutorial-control-flows-gbjpn-system-container-driver-133111245\ntutorial-control-flows-gbjpn-system-container-impl-902191899\ntutorial-control-flows-gbjpn-system-dag-driver-2964226956\ntutorial-control-flows-gbjpn-system-dag-driver-820485803\ntutorial-control-flows-gbjpn-system-container-driver-2311769198\ntutorial-control-flows-gbjpn-system-container-impl-3092937256\n\nWith the pipeline above, I confirm the mechanism works and I was able to get to the logs through the artifacts when the Pod was no longer available on the cluster.\n\nFor my other test I used pipeline created with the following script:\n\nfrom kfp import dsl\nimport kfp\n\nclient = kfp.Client()\n\nexperiment_name = \"my-experiment\"\nexperiment_namespace = \"glo-k8s-admin\"\n\n@dsl.component\ndef add(a: float, b: float) -> float:\n \"\"\"Calculates sum of two arguments\"\"\"\n return a + b\n\n@dsl.pipeline(\n name=\"Addition pipeline\",\n description=\"An example pipeline that performs addition calculations.\",\n)\ndef add_pipeline(\n a: float = 1.0,\n b: float = 7.0,\n):\n first_add_task = add(a=a, b=4.0)\n second_add_task = add(a=first_add_task.output, b=b)\n\ntry:\n print(\"getting experiment...\")\n experiment = client.get_experiment(\n experiment_name=experiment_name, namespace=experiment_namespace\n )\n print(\"got experiment!\")\nexcept Exception:\n print(\"creating experiment...\")\n experiment = client.create_experiment(\n name=experiment_name, namespace=experiment_namespace\n )\n print(\"created experiment!\")\n\nclient.create_run_from_pipeline_func(\n add_pipeline,\n arguments={\"a\": 7.0, \"b\": 8.0},\n experiment_id=experiment.experiment_id,\n enable_caching=False,\n)\n\nWhich creates Pods with following names (the name differs from example in previous comment because it's a new run):\n\naddition-pipeline-8fbx5-1329381822\naddition-pipeline-8fbx5-2476489665\naddition-pipeline-8fbx5-2909346888\naddition-pipeline-8fbx5-579177391\naddition-pipeline-8fbx5-822281223\n\nIf I understand correctly, this is because of how the Workflow Name is being provided by formatting the pod name:\n\n URL \n\n URL \n\nIs this because of the difference in how the KFPv1 and KFPv2 works?","author_login":"kromanow94","author_association":"NONE","created_at":"2024-09-10T09:55:52+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2340971900","fragment_type":"issue_comment","sequence":33,"text":"Also, in case it's related, please make note of this issue: URL","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-09-10T14:20:16+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2341151350","fragment_type":"issue_comment","sequence":34,"text":"That being said, continuing to do some extra validation on my end to see if I can repro the error.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-09-10T14:59:53+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2367746660","fragment_type":"issue_comment","sequence":35,"text":"Hey @droctothorpe , were you able to have a closer look here?\n\nTBH, I'm not exactly sure if the Pipeline I created using the script from URL is KFP v1 or KFP v2. I deployed it using `kfp==2.8.0` so I assumed it's KFP v2. Do you know if I should change anything in the script to explicitly configure it for KFP v2?","author_login":"kromanow94","author_association":"NONE","created_at":"2024-09-23T09:58:21+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[1914251519],"is_known_query_context":false},{"document_id":"gh_comment_2368395781","fragment_type":"issue_comment","sequence":36,"text":"When I ran that same pipeline, my pods had different names (i.e. they adhered to the v2 nomenclature):\n<img width=\"657\" alt=\"image\" src=\" URL \n\nAre you positive that you submitted the run with v2?","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-09-23T14:12:09+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2372352840","fragment_type":"issue_comment","sequence":37,"text":"FYI an easier fix to this is adding the following env var to the ml-pipeline-ui:\n\nyaml\n- name: DISABLE_GKE_METADATA\n value: \"true\"\n\nShout out to @boarder7395 for sharing it.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-09-24T20:45:00+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2372433757","fragment_type":"issue_comment","sequence":38,"text":"@kromanow94 I think you might be having the same issue I did. \n\nThe two changes required for everything to work are\n* Update environment variable ARGO_KEYFORMAT on deployment ml-pipeline-ui to any format you want (we include {{workflow.namespace}} to ensure separation of tenant data assets).\n* Update the workflow-controller configmap value of keyFormat to be the same format as above.\n\nWhat I missed was the second item which resulted in the issues you had above.","author_login":"boarder7395","author_association":"CONTRIBUTOR","created_at":"2024-09-24T21:37:00+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2456831693","fragment_type":"issue_comment","sequence":39,"text":"Hey, I was able to get the `main.log` artifact after the Workflow and Pods were deleted with latest version from `kubeflow/manifests` `v1.9.1` which uses the Kubeflow Pipelines version `2.3.0`.\n\nI only had to put those two env variables for the `ml-pipeline-ui` Deployment and all works:\n\nyaml\n- name: ARGO_ARCHIVE_LOGS\n value: \"true\"\n- name: DISABLE_GKE_METADATA\n value: \"true\"\n\nThough still a workaround in code, it works.\n\nAre there any plans for the proper solution that registers the `main.log` as artifact?","author_login":"kromanow94","author_association":"NONE","created_at":"2024-11-05T10:42:58+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2457343997","fragment_type":"issue_comment","sequence":40,"text":"I started working on turning the outputs into proper artifacts. There are a lot of complex design obstacles. There's no simple way to do it that preserves backend agnosticism. We have to decide if we want to rely on AWF to archive the logs and just record the relationship between the execution and the log files in MLMD, which is extremely backend-specific, or just have the launcher capture and publish logs directly, which is kind of reinventing something that AWF already does, and also doesn't account for driver logs. Bandwidth permitting, I may author a design doc. Maybe we can discuss it in the community call.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2024-11-05T14:36:03+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614350787","fragment_type":"issue_comment","sequence":41,"text":"As far as I understand, current solution is a workaround where the dashboard is just configured to look for the main.log in specific places (bucket and path key format). It’s not the main.log URI stored as part of the KFP Step. \n\nShould we reopen until we have a more robust solution (like storing the main.log as a step artefact) or we should create another issue to track it as another feature?","author_login":"kromanow94","author_association":"NONE","created_at":"2025-01-26T12:07:35+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742163645","fragment_type":"issue_comment","sequence":42,"text":"Heads up, friends, we implemented a deeper fix that stores the component log paths directly in MLMD for v2 in this PR.","author_login":"droctothorpe","author_association":"CONTRIBUTOR","created_at":"2025-03-21T03:36:11+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2751301473","fragment_type":"issue_comment","sequence":43,"text":"I'm reopening it as it's not yet implemented (soon to be with the above linked pr 🤞🏾 )","author_login":"HumairAK","author_association":"COLLABORATOR","created_at":"2025-03-25T13:40:13+08:00","repo_name":"kubeflow/pipelines","issue_id":1914251519,"issue_number":10036,"issue_url":"https://github.com/kubeflow/pipelines/issues/10036","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0259","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Fix aarch64 dmg (MacOS Silicon version)?","query_context":"This issue is being opened because the aarch64 version is damaged: URL \n\nAlso because a possible solution is referenced at:\n URL \n\nSo, I'll see if it's possible to fix it for the next version.","known_context_document_ids":["gh_issue_3311065428"],"reference_answer":"This is macOS' gatekeeper (no idea why apple thought it's a good idea to show such a misleading error). It blocks all downloaded apps which are not signed, so the only real solution is to give Apple 100$ to buy \"trust\" :(","answer_document_id":"gh_comment_1341661707","silver_evidence_path":["gh_comment_3193908863","gh_issue_1482922638","gh_comment_1341661707"],"evidence_issue_ids":[3311065428,1482922638],"source_repo_name":"angelespejo/macos-app-trial-extender","source_issue_id":3311065428,"source_issue_number":9,"source_issue_url":"https://github.com/angelespejo/macos-app-trial-extender/issues/9","target_repo_name":"tauri-apps/tauri","target_issue_id":1482922638,"target_issue_number":5778,"target_issue_url":"https://github.com/tauri-apps/tauri/issues/5778","reference_anchor_document_id":"gh_comment_3193908863","reference_answer_author":"FabianLars","reference_answer_author_association":"MEMBER","quality_score":93.5,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3529,"anchor_target_overlap":0.2143,"target_answer_overlap":0.05},"issue_created_at":"2025-08-11T17:55:22+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_3311065428","fragment_type":"issue_description","sequence":0,"text":"Fix aarch64 dmg (MacOS Silicon version)\nThis issue is being opened because the aarch64 version is damaged: URL \n\nAlso because a possible solution is referenced at:\n URL \n\nSo, I'll see if it's possible to fix it for the next version.","author_login":"angelespejo","author_association":"OWNER","created_at":"2025-08-11T17:55:22+08:00","repo_name":"angelespejo/macos-app-trial-extender","issue_id":3311065428,"issue_number":9,"issue_url":"https://github.com/angelespejo/macos-app-trial-extender/issues/9","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3183481364","fragment_type":"issue_comment","sequence":1,"text":"@YinMo19 \n\n URL \n \n \n \n \n \n \n \n\nYes, I'm somewhat familiar with these commands. What I didn't know about was the `com.apple.quarantine` attribute. That's a good tip 😜\n\nI'm familiar with building **dmg** files on Mac, so I could create a custom one where I could add all the information you mentioned. However, I have a feeling the cause of the error must be related to _Tauri v1_ and its build configuration, but I haven't done much research either.\n- URL \n- URL \n\nI'll try to see if I can fix this in the next few days, as I'm a bit stuck.\n\nAnyway, as a temporary solution, I think I'll add the information you mentioned in the _README_.\n\n---\n\n URL \n \n\nI've used this project in the past: URL \nto create pretty custom DMGs programmatically. If you're not familiar with it, I highly recommend it 😜","author_login":"angelespejo","author_association":"OWNER","created_at":"2025-08-13T11:45:33+08:00","repo_name":"angelespejo/macos-app-trial-extender","issue_id":3311065428,"issue_number":9,"issue_url":"https://github.com/angelespejo/macos-app-trial-extender/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3193908863","fragment_type":"issue_comment","sequence":2,"text":"### **SOLVED!**\n\nThis issue affected all versions of MATE from _0.1_ to _0.2.3_.\n\nThe issue appears to be related to the `tauri.conf.json` configuration and building the application on macOS >= 10.14.0.\n\nThe issue has been resolved by adding to `tauri.conf.json`\n\njson\n\"macOS\": {\n \"signingIdentity\": \"-\"\n}\n\n### References to this issue:\n\n- URL \n- URL \n\n---\n\nThanks to @YinMo19 for providing a temporary solution to open the damaged dmg in versions _0.2.3_ or lower.","author_login":"angelespejo","author_association":"OWNER","created_at":"2025-08-16T21:07:49+08:00","repo_name":"angelespejo/macos-app-trial-extender","issue_id":3311065428,"issue_number":9,"issue_url":"https://github.com/angelespejo/macos-app-trial-extender/issues/9","linked_issue_ids":[1482922638],"is_known_query_context":false},{"document_id":"gh_comment_3194005895","fragment_type":"issue_comment","sequence":3,"text":"Beautiful! That's exactly how it should be done. It seems that my approach is just a temporary solution and not having to patch it up is wonderful.","author_login":"YinMo19","author_association":"CONTRIBUTOR","created_at":"2025-08-17T00:41:01+08:00","repo_name":"angelespejo/macos-app-trial-extender","issue_id":3311065428,"issue_number":9,"issue_url":"https://github.com/angelespejo/macos-app-trial-extender/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1482922638","fragment_type":"issue_description","sequence":0,"text":"Tauri app labeled as \"damaged\" on macos when installing\n### Describe the bug\n\nI was playing around with Tauri and made a sample hello world app. When I bundled it, it was installable on my computer. However, when I tried installing on another m1 mac, it said the app was damaged and could not be opened. Running `xattr -cr /Applications/my-app.app` removed the issue. \n\nIMG_5903\n\n### Reproduction\n\n1. Create a new tauri project using the cli\n2. Build it using `tauri build` on a M1\n3. Try installing on another M1 machine\n\n### Expected behavior\n\nI expect the app to be installable.\n\n### Platform and versions\n\nEnvironment\n › OS: Mac OS 13.0.1 X64\n › Node.js: 16.14.0\n › npm: 8.3.1\n › pnpm: 6.11.0\n › yarn: 1.22.15\n › rustup: 1.25.1\n › rustc: 1.65.0\n › cargo: 1.65.0\n › Rust toolchain: stable-aarch64-apple-darwin\n\nPackages\n › @tauri-apps/cli [NPM]: 1.2.1\n › @tauri-apps/api [NPM]: 1.2.0\n › tauri [RUST]: 1.2.1,\n › tauri-build [RUST]: 1.2.1,\n › tao [RUST]: 0.15.6,\n › wry [RUST]: 0.22.5,\n\nApp\n › build-type: bundle\n › CSP: unset\n › distDir: ../dist\n › devPath: URL \n › framework: React\n\nApp directory structure\n ├─ dist\n ├─ node_modules\n ├─ public\n ├─ src-tauri\n ├─ .git\n ├─ .vscode\n └─ src\n\n### Stack trace\n\n_No response_\n\n### Additional context\n\n_No response_","author_login":"fardeem","author_association":"NONE","created_at":"2022-12-07T21:45:36+08:00","repo_name":"tauri-apps/tauri","issue_id":1482922638,"issue_number":5778,"issue_url":"https://github.com/tauri-apps/tauri/issues/5778","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1341661707","fragment_type":"issue_comment","sequence":1,"text":"This is macOS' gatekeeper (no idea why apple thought it's a good idea to show such a misleading error). It blocks all downloaded apps which are not signed, so the only real solution is to give Apple 100$ to buy \"trust\" :(","author_login":"FabianLars","author_association":"MEMBER","created_at":"2022-12-07T22:13:27+08:00","repo_name":"tauri-apps/tauri","issue_id":1482922638,"issue_number":5778,"issue_url":"https://github.com/tauri-apps/tauri/issues/5778","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0260","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Deleted and then recreated Github repository can't be cloned?","query_context":"### Describe the bug\n\nAfter deleting and then creating another repository with the same name, I couldn't clone the new repository in Github Desktop.\n\n### Version & OS\n\nWindows 10, Github Desktop version 2.5.6\n\n### Steps to reproduce the behavior\n\n1. Create repository online\n2. Delete repository online\n3. Create new repository using the same name online\n4. Attempt to clone the new repository\n\n### Expected behavior\n\nIt should clone the repository just fine. \n\n### Actual behavior\n\nI got the message \"We couldn't find that repository. Check that you are logged in, the network is accessible, and the URL or repository alias are spelled correctly.\"\n\n### Screenshots\n\n### Logs\n\n2020-10-26T21:38:03.377Z - warn: [ui] fetchRepository: 'MasquitoWasTaken/masquito-backend' returned a 404\n2020-10-26T21:38:03.493Z - warn: [ui] fetchRepository: 'MasquitoWasTaken/masquito-backend' returned a 404\n2020-10-26T21:38:03.493Z - info: [ui] [AppStore.getAccountForRemoteURL] no generic credentials found for 'MasquitoWasTaken/masquito-backend'\n2020-10-26T21:38:03.494Z - info: [ui] proxy url not resolved, protocol not supported\n2020-10-26T21:38:03.568Z - error: [ui] `git -c credential.helper= clone --recursive --progress -- MasquitoWasTaken/masquito-backend C:\\Users\\Gabriel Pizarro\\Documents\\GitHub\\masquito-backend` exited with an unexpected code: 128.\nstderr:\nfatal: repository 'MasquitoWasTaken/masquito-backend' does not exist\n\n### Additional context\n\nCheck out my repository at URL it does exist. I can also manually clone the repo from CLI.","known_context_document_ids":["gh_issue_729927861"],"reference_answer":"Thanks for the update @AngeloSolusys. Can you try cloning the repository via the command line (`git clone `) to see if that succeeds? I","answer_document_id":"gh_comment_718315014","silver_evidence_path":["gh_comment_1151624553","gh_issue_730649865","gh_comment_718315014"],"evidence_issue_ids":[729927861,730649865],"source_repo_name":"desktop/desktop","source_issue_id":729927861,"source_issue_number":10923,"source_issue_url":"https://github.com/desktop/desktop/issues/10923","target_repo_name":"desktop/desktop","target_issue_id":730649865,"target_issue_number":10930,"target_issue_url":"https://github.com/desktop/desktop/issues/10930","reference_anchor_document_id":"gh_comment_1151624553","reference_answer_author":"steveward","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.4,"target_answer_overlap":0.3077},"issue_created_at":"2020-10-26T21:40:11+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_729927861","fragment_type":"issue_description","sequence":0,"text":"Deleted and then recreated Github repository can't be cloned\n### Describe the bug\n\nAfter deleting and then creating another repository with the same name, I couldn't clone the new repository in Github Desktop.\n\n### Version & OS\n\nWindows 10, Github Desktop version 2.5.6\n\n### Steps to reproduce the behavior\n\n1. Create repository online\n2. Delete repository online\n3. Create new repository using the same name online\n4. Attempt to clone the new repository\n\n### Expected behavior\n\nIt should clone the repository just fine. \n\n### Actual behavior\n\nI got the message \"We couldn't find that repository. Check that you are logged in, the network is accessible, and the URL or repository alias are spelled correctly.\"\n\n### Screenshots\n\n### Logs\n\n2020-10-26T21:38:03.377Z - warn: [ui] fetchRepository: 'MasquitoWasTaken/masquito-backend' returned a 404\n2020-10-26T21:38:03.493Z - warn: [ui] fetchRepository: 'MasquitoWasTaken/masquito-backend' returned a 404\n2020-10-26T21:38:03.493Z - info: [ui] [AppStore.getAccountForRemoteURL] no generic credentials found for 'MasquitoWasTaken/masquito-backend'\n2020-10-26T21:38:03.494Z - info: [ui] proxy url not resolved, protocol not supported\n2020-10-26T21:38:03.568Z - error: [ui] `git -c credential.helper= clone --recursive --progress -- MasquitoWasTaken/masquito-backend C:\\Users\\Gabriel Pizarro\\Documents\\GitHub\\masquito-backend` exited with an unexpected code: 128.\nstderr:\nfatal: repository 'MasquitoWasTaken/masquito-backend' does not exist\n\n### Additional context\n\nCheck out my repository at URL it does exist. I can also manually clone the repo from CLI.","author_login":"TheNewJavaman","author_association":"NONE","created_at":"2020-10-26T21:40:11+08:00","repo_name":"desktop/desktop","issue_id":729927861,"issue_number":10923,"issue_url":"https://github.com/desktop/desktop/issues/10923","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1151624553","fragment_type":"issue_comment","sequence":1,"text":"I have a fresh install of GitHub Desktop and still having this issue. Any other suggestions?","author_login":"chadmkidner","author_association":"NONE","created_at":"2022-06-09T21:06:34+08:00","repo_name":"desktop/desktop","issue_id":729927861,"issue_number":10923,"issue_url":"https://github.com/desktop/desktop/issues/10923","linked_issue_ids":[730649865],"is_known_query_context":false},{"document_id":"gh_comment_1151629784","fragment_type":"issue_comment","sequence":2,"text":"Nevermind, my issue was that when choosing \"Open With GitHub Desktop\", it was not entering the entire URL correctly. I added \".git\" at the end and cloned successfully.","author_login":"chadmkidner","author_association":"NONE","created_at":"2022-06-09T21:12:41+08:00","repo_name":"desktop/desktop","issue_id":729927861,"issue_number":10923,"issue_url":"https://github.com/desktop/desktop/issues/10923","linked_issue_ids":[730649865],"is_known_query_context":false},{"document_id":"gh_comment_2411808578","fragment_type":"issue_comment","sequence":3,"text":"I was no longer able to reproduce this issue, so I'm going to close it as resolved. I believe it was likely fixed by the work done in URL If you are still able to reproduce this issue, please let us know and we can investigate further.","author_login":"steveward","author_association":"MEMBER","created_at":"2024-10-14T17:07:14+08:00","repo_name":"desktop/desktop","issue_id":729927861,"issue_number":10923,"issue_url":"https://github.com/desktop/desktop/issues/10923","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_730649865","fragment_type":"issue_description","sequence":0,"text":"We couldn't find that repository. Check that you are logged in, the network is accessible, and the URL or repository alias are spelled correctly.\nDescribe the bug\nWhen cloning a repository (Note that repository is correct), it keeps getting an error. Error will be: We couldn't find that repository. Check that you are logged in, the network is accessible, and the URL or repository alias are spelled correctly.\n\nVersion & OS\nOpen 'About GitHub Desktop' menu to see the Desktop version. Also include what operating system you are using.\n\nVersion 2.5.6 and Windows 10.0.19042\n\nSteps to reproduce the behavior\nGo to 'Github Desktop'\nClick on 'Your Repositories'\nClick the 'Clone Repository'\nType in your 'URL or username/repository'\nClick 'Clone'\nSee Error\n\nExpected behavior\nGet the repository cloned.\n\nActual behavior\nWhen clicking on the Clone it keeps getting the Error: We couldn't find that repository. Check that you are logged in, the network is accessible, and the URL or repository alias are spelled correctly.\n\nScreenshots\n\nimage\n\nLogs\n2020-10-27.desktop.production.log\n\nAdditional context\nAdd any other context about the problem here.","author_login":"AngeloSolusys","author_association":"NONE","created_at":"2020-10-27T17:10:12+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_717477811","fragment_type":"issue_comment","sequence":1,"text":"@AngeloSolusys thanks for the report. If you go to the `GitHub.com` tab is the repository visible there? Have you tried cloning any other repositories?","author_login":"steveward","author_association":"MEMBER","created_at":"2020-10-27T19:17:28+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_717887944","fragment_type":"issue_comment","sequence":2,"text":"Yes, when I log on `GitHub.com` the repository is there.\nWhen I tried to clone other repository worked ok\n\nimage\n\nLog File today:\n2020-10-28.desktop.production.log","author_login":"AngeloSolusys","author_association":"NONE","created_at":"2020-10-28T12:02:58+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_718315014","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the update @AngeloSolusys. Can you try cloning the repository via the command line (`git clone `) to see if that succeeds? I","author_login":"steveward","author_association":"MEMBER","created_at":"2020-10-29T02:14:57+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_718506548","fragment_type":"issue_comment","sequence":4,"text":"This sound very similar to #10923 and I'm starting to suspect this could have something to do with URL \n\n@AngeloSolusys Was the repository in question deleted or renamed at any point in the past?","author_login":"niik","author_association":"MEMBER","created_at":"2020-10-29T09:02:46+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_718704615","fragment_type":"issue_comment","sequence":5,"text":"Actually yes. I was making some tests and I created the repository Monitor, uploaded some files and then deleted it, after that I created another repository with the same name, uploded some files again and then deleted it again. I've done that about 3 or 4 times, (I can't remebem exactly how many times) in about 1 hour, the first times I was able to clone it but then in some point I couldn't clone the repository anymore using github desktop.\n\nI tried to clone it using the command line and it worked.\nimage","author_login":"AngeloSolusys","author_association":"NONE","created_at":"2020-10-29T11:55:04+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_721256305","fragment_type":"issue_comment","sequence":6,"text":"I have the exact same issue. This is probably a duplicate of #10923","author_login":"TheNewJavaman","author_association":"NONE","created_at":"2020-11-03T17:02:07+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_723467909","fragment_type":"issue_comment","sequence":7,"text":"I face the same issue when trying to clone the wiki of a GitHub Repository.\nThe repository in question however, was never deleted, renamed or similar.\n\nThe logs also don't mention anything about a failed cloning or the repository in question.\n2020-11-07.desktop.production.log","author_login":"Andre601","author_association":"NONE","created_at":"2020-11-07T16:49:15+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_723562052","fragment_type":"issue_comment","sequence":8,"text":"Hey, I also encounter the same blockage. Whether I make the project public or private, it doesn't change anything. On the other hand, via Visual Studio Code no problem for cloning.","author_login":"bryx","author_association":"NONE","created_at":"2020-11-08T11:10:31+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_724231619","fragment_type":"issue_comment","sequence":9,"text":"The repository in question however, was never deleted, renamed or similar.\n\n@Andre601 there are some known issues working with wikis. See URL If you are running into specific authentication issues please open a new issue and we can assist you further.\n\n@bryx it would be helpful if you could open a new issue and fill out the issue template. Thanks!","author_login":"steveward","author_association":"MEMBER","created_at":"2020-11-09T19:34:50+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_733859002","fragment_type":"issue_comment","sequence":10,"text":"You can completely remove github desketop from you PC and install again, remember don't forget to delete Residual file!!! \n\n1\n\nThen it can be solved.","author_login":"CaptainJackey","author_association":"NONE","created_at":"2020-11-25T17:52:55+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_733901114","fragment_type":"issue_comment","sequence":11,"text":"But I believe it's better to find and solve the problem than try to find ways to hide the problem, cause cloning the repository in other ways is easy, I already have done that. i just reported the problem for it to be resolved.","author_login":"AngeloSolusys","author_association":"NONE","created_at":"2020-11-25T19:14:27+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_748022110","fragment_type":"issue_comment","sequence":12,"text":"I also have the same problem. Signing out from my account and then logging in didn't help.\nI use GitHub Desktop for macOS Version 2.6.1.","author_login":"abdullahyildiz","author_association":"NONE","created_at":"2020-12-18T10:58:01+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_757468540","fragment_type":"issue_comment","sequence":13,"text":"Use Git GUI to clone it, then \"Add local repository\" from GitHub Desktop to circumvent this issue.","author_login":"Th-eo","author_association":"NONE","created_at":"2021-01-10T12:31:35+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_757896644","fragment_type":"issue_comment","sequence":14,"text":"Well, if it's the case i'm closing the issue cause i've already got what i need, but the problem remains on the app","author_login":"AngeloSolusys","author_association":"NONE","created_at":"2021-01-11T11:40:08+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_763767793","fragment_type":"issue_comment","sequence":15,"text":"I'm having this problem as well. Suddenly today on Windows I stopped being able to authenticate via command line using a PAT (though it still works on macOS and it worked that last time I was on Windows with no changes).","author_login":"dmauro","author_association":"NONE","created_at":"2021-01-20T16:34:07+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_763808613","fragment_type":"issue_comment","sequence":16,"text":"@dmauro this issue tracker is for GitHub Desktop. For Git authentication issues I'd recommend reaching out to GitHub Support.","author_login":"steveward","author_association":"MEMBER","created_at":"2021-01-20T17:27:00+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_781981345","fragment_type":"issue_comment","sequence":17,"text":"I had the same problem as described above. Seems to be similar to #10923 #7634 and other issues. Thank you @CaptainJackey : your advice solved my problem. I wish I would have found a more \"elegant\" solution, but de-install, re-install is probably the easiest one for a novice like me.","author_login":"AndreasTraut","author_association":"NONE","created_at":"2021-02-19T10:20:30+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113060870","fragment_type":"issue_comment","sequence":18,"text":"I just had the same problem with the latest GitHub Desktop 3.0 and manually solved it following the advice from @CaptainJackey. This is an active bug and shouldn't be marked as closed.","author_login":"dmillar1","author_association":"NONE","created_at":"2022-04-29T08:50:05+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114649982","fragment_type":"issue_comment","sequence":19,"text":"I just completely unistall and install it again as suggested and it worked!\nThanks","author_login":"hbabashah","author_association":"NONE","created_at":"2022-05-02T09:13:18+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1299116585","fragment_type":"issue_comment","sequence":20,"text":"Error still exist on Mac. After reinstall User and Pass is ask for the repo but still not getting in. Other repos clone without problem. New repo won't","author_login":"Quinienl","author_association":"NONE","created_at":"2022-11-01T20:44:37+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1530564484","fragment_type":"issue_comment","sequence":21,"text":"@Quinienl \nI was having the same error, it worked on my macOS and my Windows after I logged out and logged back into my Github desktop account.\nYou go to File -> Options -> Account.","author_login":"matheusdinizdev","author_association":"NONE","created_at":"2023-05-01T23:31:27+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937392619","fragment_type":"issue_comment","sequence":22,"text":"Iae pessoal, tudo certo ?, estava com o mesmo problema\nSolução:: desinstalei, apaguei os arquivos adicionais e reinstalei\n\nfuncionou de boas","author_login":"ThyagoMartins0","author_association":"NONE","created_at":"2024-02-11T02:01:59+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2076501566","fragment_type":"issue_comment","sequence":23,"text":"I also solved this problem by re-logging in, thank you very much!","author_login":"Git-BoHu","author_association":"NONE","created_at":"2024-04-25T06:58:41+08:00","repo_name":"desktop/desktop","issue_id":730649865,"issue_number":10930,"issue_url":"https://github.com/desktop/desktop/issues/10930","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0261","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Gitpod in Mumbai region?","query_context":"_Issue tracked as part of URL \n\nThe latency experienced by me in Rajkot, Gujarat, India is about 300ms. This leads to a subpar experience. I'm on an FTTH connection whose bandwidth is 80Mbps down and 40Mbps up. Please refer to the attached screenshots. I've also attached a screenshot showing the latency of various GCP regions from my location. \n\nIt would be nice to see Gitpod deploying a cluster in India as India houses a sizeable proportion of developers and is one of the largest markets for off-shore development. \n\nScreenshot 2021-10-10 at 9 55 18 PM\ngcp_latency\n<img width=\"395\" alt=\"Screenshot 2021-10-10 at 10 13 08 PM\" src=\" URL","known_context_document_ids":["gh_issue_1022035185"],"reference_answer":"We discussed that we would want to go with the solution outline in #5596. Give our priorities atm this will have to wait a few weeks. Let's aim at scheduling this by mid October.","answer_document_id":"gh_comment_918067331","silver_evidence_path":["gh_comment_1240517297","gh_issue_988716144","gh_comment_918067331"],"evidence_issue_ids":[1022035185,988716144],"source_repo_name":"gitpod-io/gitpod","source_issue_id":1022035185,"source_issue_number":6139,"source_issue_url":"https://github.com/gitpod-io/gitpod/issues/6139","target_repo_name":"gitpod-io/gitpod","target_issue_id":988716144,"target_issue_number":5534,"target_issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","reference_anchor_document_id":"gh_comment_1240517297","reference_answer_author":"svenefftinge","reference_answer_author_association":"MEMBER","quality_score":90.09,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.14,"anchor_target_overlap":0.087,"target_answer_overlap":0.1333},"issue_created_at":"2021-10-10T16:53:30+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_1022035185","fragment_type":"issue_description","sequence":0,"text":"Gitpod in Mumbai region\n_Issue tracked as part of URL \n\nThe latency experienced by me in Rajkot, Gujarat, India is about 300ms. This leads to a subpar experience. I'm on an FTTH connection whose bandwidth is 80Mbps down and 40Mbps up. Please refer to the attached screenshots. I've also attached a screenshot showing the latency of various GCP regions from my location. \n\nIt would be nice to see Gitpod deploying a cluster in India as India houses a sizeable proportion of developers and is one of the largest markets for off-shore development. \n\nScreenshot 2021-10-10 at 9 55 18 PM\ngcp_latency\n<img width=\"395\" alt=\"Screenshot 2021-10-10 at 10 13 08 PM\" src=\" URL","author_login":"hinddeep","author_association":"NONE","created_at":"2021-10-10T16:53:30+08:00","repo_name":"gitpod-io/gitpod","issue_id":1022035185,"issue_number":6139,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6139","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1238653098","fragment_type":"issue_comment","sequence":1,"text":":wave: hey there, please refer to URL as the source of truth for supporting more regions than just EU and US. We are closing this issue to consolidate to the single issue.","author_login":"kylos101","author_association":"CONTRIBUTOR","created_at":"2022-09-06T21:11:10+08:00","repo_name":"gitpod-io/gitpod","issue_id":1022035185,"issue_number":6139,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6139","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240517297","fragment_type":"issue_comment","sequence":2,"text":"Please see related comment on #7489, copied below: \n\n---\n\nThere seems to be some confusion that is related to the closing of the following issues:\n\n URL \n URL \nPlease note: This is not a an update of the status of this issue (closing or opening). The reason for the consolidation is that we now have a proliferation of different regional issues being raised by users. It doesn't make sense for users to directly raising issues about specific required regions, as when it comes to rolling out new regions we'll need to review:\n\nCostings\nLatencies\nCurrent + predicted future usage of Gitpod\n...and many other factors.\n\nIt makes sense for this conversation to happen in a single issue, which is this one. Please continue to share any thoughts or feedback. We'll look to update the description soon as a consolidation of current thinking, as there are now multiple region related issues with many comments.\n\nThanks all 🙏","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-09-08T10:18:58+08:00","repo_name":"gitpod-io/gitpod","issue_id":1022035185,"issue_number":6139,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6139","linked_issue_ids":[988716144],"is_known_query_context":false},{"document_id":"gh_issue_988716144","fragment_type":"issue_description","sequence":0,"text":"Gitpod Singapore (sg) region\n_edit: :wave: hey there, please refer to URL as the source of truth for supporting more regions than just EU and US._\n\nWe have discussed internally regarding creating a new region a few times since the team has expanded to include two employees in Australia but a feature request has never been logged.\n\nI've always found Gitpod workable when connecting from the US or EU clusters from Australia but the experience could be better. \n\nThis morning I received customer feedback which has prompted bringing this topic up once again:\n \n \n \n\nI think the GCP Singapore region would be an appropriate choice for expansion for Gitpod. Singapore is also a region for GitHub Codepsaces btw.\n\nnb. I was on 1 bar of Telstra 4G when performing this test.\n\n Front conversations","author_login":"ghuntley","author_association":"CONTRIBUTOR","created_at":"2021-09-06T04:00:59+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913325518","fragment_type":"issue_comment","sequence":1,"text":"Hi Geoff, the name's Joshua from Indonesia. Been a fan of what Gitpod is working on for quite some time. All the best to the Gitpod team. Hope this helps.\nimage\nimage","author_login":"joshuabezaleel","author_association":"NONE","created_at":"2021-09-06T04:16:48+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913332287","fragment_type":"issue_comment","sequence":2,"text":"Hi, it feels awesome to know that gitpod is finally going to have a Singaporean cluster! I'm from Bangladesh and I have been using gitpod for a 4G mobile network.\nThanks!\n \nScreenshot_20210906-102807\n \nScreenshot_20210906-103306","author_login":"axonasif","author_association":"CONTRIBUTOR","created_at":"2021-09-06T04:35:38+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913345296","fragment_type":"issue_comment","sequence":3,"text":"From Perth, Western Australia\n\nWired VDSL (17/7 down/up Mbps)\n\nAppears my traffic is being routed via East Coast AU instead of direct to Singapore. Rough speed test shows 53ms from me to NewMedia Express SG which is what I'd expect.\n\nimage","author_login":"glennsarti","author_association":"NONE","created_at":"2021-09-06T05:10:06+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913355864","fragment_type":"issue_comment","sequence":4,"text":"Melbourne fibre connection (not NBN). \n\nScreen Shot 2021-09-06 at 3 28 31 pm","author_login":"DevEnable","author_association":"NONE","created_at":"2021-09-06T05:32:26+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_914954368","fragment_type":"issue_comment","sequence":5,"text":"Cool! thanks for all the comments. Let's do this!\n@meysholdt can you take over and share a plan for rolling this out?","author_login":"svenefftinge","author_association":"MEMBER","created_at":"2021-09-08T06:24:44+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_914967098","fragment_type":"issue_comment","sequence":6,"text":"happy to do so. There are two possible setups for this:\na) setup a workspace-cluster in Singapore, hook it up to the us-meta-cluster and have have our server component route starting workspaces to the geographically closest workspace cluster (Singapore or US).\nb) setup a workspace-clusters, a meta-clusters, and a database in Singapore and have the GCP LoadBalancer route users to the geographically closest region. \n\nI'm in favour of (a) because it is the way to go if we want to support more than three regions: it has lower cloud costs, lower operational effort and more control over workspace-routing, etc. \n\nHowever, our server (or bridge) component does not yet support geography(e.g. latency) based routing and we need to decide if that's a feature we we wan to implement now.","author_login":"meysholdt","author_association":"MEMBER","created_at":"2021-09-08T06:48:42+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_915001482","fragment_type":"issue_comment","sequence":7,"text":"@meysholdt If that sounds difficult, it would be great to add a preference in user settings to choose the data center they want. WDYT?","author_login":"bigint","author_association":"NONE","created_at":"2021-09-08T07:46:58+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_915055425","fragment_type":"issue_comment","sequence":8,"text":"Here is a proposal on how we could do automated latency-based workspace-cluster-selection: URL","author_login":"meysholdt","author_association":"MEMBER","created_at":"2021-09-08T09:05:41+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_915109769","fragment_type":"issue_comment","sequence":9,"text":"Agree, this is something that would provide unnecessary complexity for the user. 🐼","author_login":"gtsiolis","author_association":"MEMBER","created_at":"2021-09-08T10:17:50+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_918067331","fragment_type":"issue_comment","sequence":10,"text":"We discussed that we would want to go with the solution outline in #5596. Give our priorities atm this will have to wait a few weeks. Let's aim at scheduling this by mid October.","author_login":"svenefftinge","author_association":"MEMBER","created_at":"2021-09-13T10:43:03+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_920643547","fragment_type":"issue_comment","sequence":11,"text":"FYI, one more data point from @tnir in URL (from Japan, I believe) :","author_login":"jankeromnes","author_association":"MEMBER","created_at":"2021-09-16T07:21:37+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_935949050","fragment_type":"issue_comment","sequence":12,"text":"removing from Platform Inbox because this depends on URL See Sven's comment on how we should proceed.","author_login":"meysholdt","author_association":"MEMBER","created_at":"2021-10-06T10:43:21+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[988716144],"is_known_query_context":false},{"document_id":"gh_comment_964412167","fragment_type":"issue_comment","sequence":13,"text":"Our engineers in APAC would be your best friend if there was a Gitpod cluster local to them in either Singapore or Mumbai 😁\n\nHere's the GCP Ping from one of our engineers in Hyderabad, India\nimage","author_login":"joepurdy","author_association":"NONE","created_at":"2021-11-09T18:18:22+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_965891759","fragment_type":"issue_comment","sequence":14,"text":"Can we pay extra to have a cluster get spun up in whatever GC supported area? Would love something in Sydney.","author_login":"Velua","author_association":"NONE","created_at":"2021-11-11T00:45:31+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_965913822","fragment_type":"issue_comment","sequence":15,"text":"Can't speak for Gitpod's team, but I think the more realistic answer that is to self-host: URL \n\nMaybe I'm wrong though and they'd be willing to explore bespoke regions if the price was right.","author_login":"joepurdy","author_association":"NONE","created_at":"2021-11-11T01:37:41+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_978846962","fragment_type":"issue_comment","sequence":16,"text":"Me too. I'm in Sydney [1] as well (and I work at Gitpod). I find the latency workable but indeed it could be better. All in good time. Gitpod is right now working on getting underlying primitives for architecture solid to make it possible to deploy anywhere and keep operational support costs (human time) scalable. Hold on. It'll be worth it.\n\n[1] URL","author_login":"ghuntley","author_association":"MEMBER","created_at":"2021-11-25T05:25:24+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_990767466","fragment_type":"issue_comment","sequence":17,"text":"I live in Seoul, but somehow Hong Kong wins with the least latency. I assume the actual DC isn't located in Seoul, as that wouldn't make much sense economically.\n\nI have pretty good internet connectivity (~400mbps).\n\nScreenshot_20211210-181713_Chrome\n\nI would be satisfied with a Singapore cluster to be honest.","author_login":"JcdeA","author_association":"NONE","created_at":"2021-12-10T09:22:10+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081396789","fragment_type":"issue_comment","sequence":18,"text":"City: Krung Thep Maha Nakhon (formerly, \"Bangkok\")\nConnection: AIS Fibre\n\n<img width=\"1490\" alt=\"image\" src=\" URL","author_login":"smacintyre","author_association":"NONE","created_at":"2022-03-29T04:43:35+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1102550280","fragment_type":"issue_comment","sequence":19,"text":"This issue was in the inbox of the platform team for some reason. However, there is not much the platform team can do here. Much rather\n* the workspace team would need to set up a cluster in the desired region\n* also, on the WebApp side newly starting workspaces would need to be routed to the new cluster based on latency. Not sure if this falls into the area of team workspace or team WebApp.\n\nI'm moving the issue to the inbox of the workspace team so that they can handle prioritization/planning.","author_login":"meysholdt","author_association":"MEMBER","created_at":"2022-04-19T11:56:08+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1113097504","fragment_type":"issue_comment","sequence":20,"text":"Adding a \"me too\". I am considering Gitpod for my team in Singapore, Thailand and the Philippines - but the ping time to EU/US makes it extremely painful (I'm getting between 200-400ms and I am on gigabit fibre).","author_login":"aalcock","author_association":"NONE","created_at":"2022-04-29T09:19:12+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1138045493","fragment_type":"issue_comment","sequence":21,"text":"I'm from Taiwan, and I connect Internet with a Wi-Fi from a optical fiber network:\n\n<img width=\"1440\" alt=\"截圖 2022-05-26 上午9 27 04\" src=\" URL","author_login":"pan93412","author_association":"NONE","created_at":"2022-05-26T01:30:04+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1227197537","fragment_type":"issue_comment","sequence":22,"text":"<img width=\"992\" alt=\"Screen Shot 2022-08-25 at 7 33 40 PM\" src=\" URL","author_login":"chientrm","author_association":"NONE","created_at":"2022-08-25T12:33:58+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1238652990","fragment_type":"issue_comment","sequence":23,"text":":wave: hey there, please refer to URL as the source of truth for supporting more regions than just EU and US. We are closing this issue to consolidate to the single issue.","author_login":"kylos101","author_association":"CONTRIBUTOR","created_at":"2022-09-06T21:11:02+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1240517842","fragment_type":"issue_comment","sequence":24,"text":"Please see related comment on #7489, copied below: \n\n---\n\nThere seems to be some confusion that is related to the closing of the following issues:\n\n- URL \n- URL \n\nPlease note: This is not a an update of the status of this issue (closing or opening). The reason for the consolidation is that we now have a proliferation of different regional issues being raised by users. It doesn't make sense for users to directly raising issues about specific required regions, as when it comes to rolling out new regions we'll need to review:\n\nCostings\nLatencies\nCurrent + predicted future usage of Gitpod\n...and many other factors.\n\nIt makes sense for this conversation to happen in a single issue, which is this one. Please continue to share any thoughts or feedback. We'll look to update the description soon as a consolidation of current thinking, as there are now multiple region related issues with many comments.\n\nThanks all 🙏","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-09-08T10:19:30+08:00","repo_name":"gitpod-io/gitpod","issue_id":988716144,"issue_number":5534,"issue_url":"https://github.com/gitpod-io/gitpod/issues/5534","linked_issue_ids":[988716144],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0262","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Parser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.","query_context":"### Tested versions\n\nv4.3.beta2.mono.official [b75f0485b]\n\n### System information\n\nWindows 11\n\n### Issue description\n\nI'm working on a new plugin to build by procedural nodes via visual scripting and build my own custom graph nodes.\nAs example:\nimage\n\nTo have the same Look&Feel I rebuild the property editors used by the Godot editor inspector. (The original property editors are not public, but why?)\n\nI used the Godot provided class EditorSpinSlider\nAnd it works fine, so far so good.\n\nBut i have a unit test coverage and it fails when loading my ui components by error\n\nParser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.\n\nFrom the documentation, it is not abstract.\nThis blocks me actually to develop and test the scene and often needs a restart of the Godot editor.\nIt also blocks me to write unit tests because the scene is loaded via a test API and not instantiated by a plugin.\n\n### Steps to reproduce\n\nUse the attached example plugin.\nWhen the project opened, it shows the example in the bottom.\nimage\n\nThe scene is loaded and the custom panel using the `EditorSpinSlider` works fine.\nBut when you try to run the panel scene itself, it fails with the error.\n`Parser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.`\nimage\n\nThis makes it impossible to test the scene manually or by a testing framework.\n\n### Minimal reproduction project (MRP)\n\nEditorSpinSlider.zip","known_context_document_ids":["gh_issue_2385469789"],"reference_answer":"Yes, please comment on it that it solves the problem for you to help it along, it's still waiting for a decision","answer_document_id":"gh_comment_2205908408","silver_evidence_path":["gh_comment_2202286941","gh_issue_1589984289","gh_comment_2205908408"],"evidence_issue_ids":[2385469789,1589984289],"source_repo_name":"godotengine/godot","source_issue_id":2385469789,"source_issue_number":93854,"source_issue_url":"https://github.com/godotengine/godot/issues/93854","target_repo_name":"godotengine/godot","target_issue_id":1589984289,"target_issue_number":73525,"target_issue_url":"https://github.com/godotengine/godot/issues/73525","reference_anchor_document_id":"gh_comment_2202286941","reference_answer_author":"AThousandShips","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.4444,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1111},"issue_created_at":"2024-07-02T07:32:37+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_2385469789","fragment_type":"issue_description","sequence":0,"text":"Parser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.\n### Tested versions\n\nv4.3.beta2.mono.official [b75f0485b]\n\n### System information\n\nWindows 11\n\n### Issue description\n\nI'm working on a new plugin to build by procedural nodes via visual scripting and build my own custom graph nodes.\nAs example:\nimage\n\nTo have the same Look&Feel I rebuild the property editors used by the Godot editor inspector. (The original property editors are not public, but why?)\n\nI used the Godot provided class EditorSpinSlider\nAnd it works fine, so far so good.\n\nBut i have a unit test coverage and it fails when loading my ui components by error\n\nParser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.\n\nFrom the documentation, it is not abstract.\nThis blocks me actually to develop and test the scene and often needs a restart of the Godot editor.\nIt also blocks me to write unit tests because the scene is loaded via a test API and not instantiated by a plugin.\n\n### Steps to reproduce\n\nUse the attached example plugin.\nWhen the project opened, it shows the example in the bottom.\nimage\n\nThe scene is loaded and the custom panel using the `EditorSpinSlider` works fine.\nBut when you try to run the panel scene itself, it fails with the error.\n`Parser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.`\nimage\n\nThis makes it impossible to test the scene manually or by a testing framework.\n\n### Minimal reproduction project (MRP)\n\nEditorSpinSlider.zip","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-02T07:32:37+08:00","repo_name":"godotengine/godot","issue_id":2385469789,"issue_number":93854,"issue_url":"https://github.com/godotengine/godot/issues/93854","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2202286941","fragment_type":"issue_comment","sequence":1,"text":"Correct me if I'm wrong, but I think it's because `EditorSpinSlider`, being an editor control, is only available when running inside the editor, so they cannot be constructed when running the scene as a game.\n\nProbably the same issue as #73525.","author_login":"alvinhochun","author_association":"NONE","created_at":"2024-07-02T08:20:24+08:00","repo_name":"godotengine/godot","issue_id":2385469789,"issue_number":93854,"issue_url":"https://github.com/godotengine/godot/issues/93854","linked_issue_ids":[1589984289],"is_known_query_context":false},{"document_id":"gh_comment_2202362344","fragment_type":"issue_comment","sequence":2,"text":"Yes is described as editor control, but creating a scene and running it for testing makes it impossible if it is recognized as abstract.","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-02T08:51:11+08:00","repo_name":"godotengine/godot","issue_id":2385469789,"issue_number":93854,"issue_url":"https://github.com/godotengine/godot/issues/93854","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1589984289","fragment_type":"issue_description","sequence":0,"text":"EditorExportPlugin raises error everytime you run the game with F5 because of \"abstract native class\"\n### Godot version\n\n4.0 rc2\n\n### System information\n\nManjaro Linux using i3, Foward+\n\n### Issue description\n\nI've added an ExportPlugin to my addon and everytime I run the game in the editor I know get this error:\n\nSCRIPT ERROR: Parse Error: Class \"eh_UtilitiesExportPlugin\" cannot be constructed as it is based on abstract native class \"EditorExportPlugin\".\n\nI even tried to guard it with an `Engine.is_editor_hint()` call but it doesn't work, I still get the same error even though line 54 shouldn't be executing:\nimage\n\nWeirdly enough, this guard works fine in other parts of the project, but fails here.\n\n### Steps to reproduce\n\nJust create a script that extends `EditorExportPlugin`, and try to create an instance of it in an `EditorPlugin` script\n\n### Minimal reproduction project\n\nSee \"Steps to Reproduce\"","author_login":"eh-jogos","author_association":"NONE","created_at":"2023-02-17T21:30:45+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1437959062","fragment_type":"issue_comment","sequence":1,"text":"I've experienced a similar issue with a tool script using `EditorScript.new()` or `EditorPlugin.new()`. \n\nOn running the project (F5), it gives `Parser Error: Native class \"EditorScript\" cannot be constructed as it is abstract.`. The same call works in editor.\n\n4.0 rc2, Win x64, Forward+","author_login":"CodexLambda","author_association":"NONE","created_at":"2023-02-21T07:10:27+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439181983","fragment_type":"issue_comment","sequence":2,"text":"Can confirm that it happens in 4.0 rc**3** as well.\n`EditorPlugin.new()` works fine in the editor itself. But running the project will raise an error.","author_login":"PunchablePlushie","author_association":"NONE","created_at":"2023-02-21T22:37:06+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445635984","fragment_type":"issue_comment","sequence":3,"text":"Still an issue with 4.0rc5.\n\nIt looks like #70700 added that check, which happens while analyzing the gdscript, so `if` guards don't matter there.\n\nI'm still experimenting, hoping I can find an easy fix or workaround...","author_login":"baptr","author_association":"CONTRIBUTOR","created_at":"2023-02-27T03:24:48+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445643298","fragment_type":"issue_comment","sequence":4,"text":"Ah: URL \n\nYou can't instantiate any editor code while running.","author_login":"baptr","author_association":"CONTRIBUTOR","created_at":"2023-02-27T03:34:02+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445882874","fragment_type":"issue_comment","sequence":5,"text":"I don't know think the problem is not allowing editor or \"abstract\" code to run while the game is running. I think the problem is considering `EditorExportPlugin` as an abstract class.\n\nI mean, `EditorPlugin` works just fine when added as an activated plugin, and I don't get why `EditorPlugin.new()` would be used, creating an `EditorPlugin` instance that isn't added as a plugin doesn't make much sense as godot will not know how to use it, so the abstract error makes sense. But why doesn't `EditorExportPlugin` work? \n\nTo customize any exports through plugins I need to:\n- Be inside an existing and activated `EditorPlugin`\n- Create an instance of a script that extends `EditorExportPlugin`\n- add said instance using `EditorPlugin`'s `add_export_plugin()`\n\nThe above will ALWAYS make problems with running the game, even though it is the required steps to make it work for filtering exports. This is what makes no sense to me, not the abstract class thing.\n\nIn 3.x I could just do the same steps above and run the game just fine. I think this is a regression #73525, and `EditorExportPlugin`, despite it's name, shouldn't be considered an abstract class, or should be allowed somehow.","author_login":"eh-jogos","author_association":"NONE","created_at":"2023-02-27T08:11:16+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[1589984289],"is_known_query_context":false},{"document_id":"gh_comment_1445888576","fragment_type":"issue_comment","sequence":6,"text":"See #74025 - the check is trying to use `!can_instantiate` to infer whether the base class is abstract. But due to the check mentioned above, that fails for EditorExportPlugin (and any other API_EDITOR code).","author_login":"baptr","author_association":"CONTRIBUTOR","created_at":"2023-02-27T08:15:15+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[1589984289],"is_known_query_context":false},{"document_id":"gh_comment_1445907217","fragment_type":"issue_comment","sequence":7,"text":"So `EditorExportPlugin` isn't actually an abstract class? it's just being misinterpreted as one? \n\nI had looked at #74025 but I guess I didn't understood what it was doing, so I got confused by how it would fix the problem which led to the comment above.","author_login":"eh-jogos","author_association":"NONE","created_at":"2023-02-27T08:30:47+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1445930138","fragment_type":"issue_comment","sequence":8,"text":"Right, it's registered as a normal full class: URL \n\nBut the recently added gdscript analyzer check which tries to determine if a parent class *is* abstract, instead only checks if it can be instantiated *right now*. The fact that editor types can't be instantiated when running the project leads to the analyzer incorrectly interpreting them as being \"abstract\".","author_login":"baptr","author_association":"CONTRIBUTOR","created_at":"2023-02-27T08:51:31+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1475424472","fragment_type":"issue_comment","sequence":9,"text":"I have this problem too:\n\ngdscript\nstatic func create_open_file_dialog() -> ConfirmationDialog:\n var d\n if Engine.is_editor_hint():\n d = EditorFileDialog.new()\n d.file_mode = EditorFileDialog.FILE_MODE_OPEN_FILE\n d.access = EditorFileDialog.ACCESS_RESOURCES\n else:\n # Duh. I need to be able to test it.\n d = FileDialog.new()\n d.file_mode = FileDialog.FILE_MODE_OPEN_FILE\n d.access = FileDialog.ACCESS_RESOURCES\n d.resizable = true\n return d\n\nI was using this in Godot 3 so I could test my plugin UIs with F5 like regular \"game scenes\", but now Godot 4 complains of the only presence of `EditorFileDialog` even if the code never reaches it.","author_login":"Zylann","author_association":"CONTRIBUTOR","created_at":"2023-03-19T22:51:41+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537216785","fragment_type":"issue_comment","sequence":10,"text":"Meanwhile, a workaround:\n\nCasting the `EditorExportPlugin`-derived class to a `Variant` seems to trick the compiler:\n\n if Engine.is_editor_hint():\n _exporter = (GitVersionInjector as Variant).new()\n add_export_plugin(_exporter)\n\nPresumably this would also work with other classes that might have this issue.","author_login":"apples","author_association":"NONE","created_at":"2023-05-06T20:22:08+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1593577850","fragment_type":"issue_comment","sequence":11,"text":"Ran into this issue extending EditorNode3DGizmoPlugin so can confirm it works with that too.","author_login":"ozqf","author_association":"NONE","created_at":"2023-06-15T19:00:37+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1605900184","fragment_type":"issue_comment","sequence":12,"text":"EditorDebuggerPlugin seems to suffer the same issue and the same workaround","author_login":"chrisb123","author_association":"NONE","created_at":"2023-06-25T06:51:21+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1606063889","fragment_type":"issue_comment","sequence":13,"text":"@chrisb123 are you trying to run a scene of the plugin? Or just your game? (If the latter it doesn't make any sense)","author_login":"Zylann","author_association":"CONTRIBUTOR","created_at":"2023-06-25T12:22:14+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1606067249","fragment_type":"issue_comment","sequence":14,"text":"I'm using the example from the official documentation found here.\n[( URL \n\nI cant find any other information on using the editor debug plugin. I get the same error mentioned above and applying the fix found above does result in the debugger getting an the custom debug plugin tab\n`_exporter = (GitVersionInjector as Variant).new()`","author_login":"chrisb123","author_association":"NONE","created_at":"2023-06-25T12:33:40+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1606069780","fragment_type":"issue_comment","sequence":15,"text":"Oh sorry, I thought you were using the GDScript addon of the same name.","author_login":"Zylann","author_association":"CONTRIBUTOR","created_at":"2023-06-25T12:42:08+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1607409852","fragment_type":"issue_comment","sequence":16,"text":"So the issue here is that user scripts end up trying to access Editor-only classes at runtime?","author_login":"YuriSizov","author_association":"CONTRIBUTOR","created_at":"2023-06-26T12:54:42+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1610669343","fragment_type":"issue_comment","sequence":17,"text":"In my project, I'm not actually accessing the Editor-only classes during game runtime. However, my scripts are still loaded/parsed, and the compiler complains about it. The script code is never executed.\n\nAt least, this is what I believe to be happening, based on the fact that casting the Editor-only class to a Variant fixes the compile error, and there are no further errors during runtime.","author_login":"apples","author_association":"NONE","created_at":"2023-06-28T04:10:31+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2202864865","fragment_type":"issue_comment","sequence":18,"text":"If there is a chance to bring the fix in 4.3?\n\nFrom the documentation, it is not abstract.\nThis blocks me actually to develop and test the scene and often needs a restart of the Godot editor.\nIt also blocks me to write unit tests because the scene is loaded via a test API and not instantiated by a plugin.","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-02T11:27:42+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2203065442","fragment_type":"issue_comment","sequence":19,"text":"If you're able please test the linked PR to help it along:\n* URL","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-07-02T12:43:32+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2203076768","fragment_type":"issue_comment","sequence":20,"text":"I had never built the Godot binary yet, I need first to setup my environment ...","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-02T12:49:17+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2205770259","fragment_type":"issue_comment","sequence":21,"text":"So after a lot of investigation, I find out it was a local firewall Comodo issue ... what the hell","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-03T10:45:39+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2205824653","fragment_type":"issue_comment","sequence":22,"text":"I build Godot rebased on master and run the example project\n\nEditorSpinSlider.zip\n\nThe parse error `Parser Error: Native class \"EditorSpinSlider\" cannot be constructed as it is abstract.` is gone but the components still not usable in a testing scene as described in URL \n\nIt produces errors\nimage","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-03T11:10:07+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2205843377","fragment_type":"issue_comment","sequence":23,"text":"@AThousandShips what would be the next steps to move forward here?","author_login":"MikeSchulze","author_association":"NONE","created_at":"2024-07-03T11:21:18+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2205908408","fragment_type":"issue_comment","sequence":24,"text":"Yes, please comment on it that it solves the problem for you to help it along, it's still waiting for a decision","author_login":"AThousandShips","author_association":"MEMBER","created_at":"2024-07-03T11:59:13+08:00","repo_name":"godotengine/godot","issue_id":1589984289,"issue_number":73525,"issue_url":"https://github.com/godotengine/godot/issues/73525","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0263","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Sam's Thesis Meeting | Dec 19, 2023 - VIRTUAL?","query_context":"My main work this week has been filling in my glossary with information I have already documented. If you think a \"peer review\" would be beneficial, I'm good with that! There are also some gaps to be filled in later that we could discuss if any stand out. I have some specific questions below, which will likely be answered with time and more research, but figured it wouldn't hurt to provide them to potentially get the ball rolling!\n\n1. Level of granularity\n 1. Data Testing\n 2. Reviews\n 3. Path Coverage\n 4. Mutation\n 5. Regression\n2. Parent relations\n 1. Regression testing: can be white- or black-box, so child or both or N/A?\n 2. Metamorphic testing: seems to be black-box for the code and white-box for the tests; is the \"transparency\" of the testing defined in relation to the test subject?\n3. Confusion on terms\n 1. Data testing vs. data coverage in Patton2006 (the same thing, or testing = black-box and coverage = white-box?)\n 2. White-box testing (structural analysis/testing) in Patton2006 vs. structural = white-box in other places (see also #1)\n 3. Black-box testing (\"specification\"/functional testing) in Patton2006 vs. black-box in other places (e.g., \"functional testing\" for FRs)","known_context_document_ids":["gh_issue_2047639417"],"reference_answer":"Yes, the natbib style for citations is nice because it contains some useful information (author and year) right where the citation is located. It is a good idea if you have a file for a paper that you use the same naming convention. It does help with traceability. That is what I've tried to do in the pub repo. I slipped a few times, but most of the files have natbib style names.\n\nIf there are files that would be helpful for @JacquesCarette and me to read, it is a good idea to put the paper somewhere, or link to its public version, when that exists. For files that don't have a public version you can't put them in a public repo, but you could put them in a private repo, like the pub repo mentioned above.","answer_document_id":"gh_comment_1851187353","silver_evidence_path":["gh_comment_1863078480","gh_issue_2036820230","gh_comment_1851187353"],"evidence_issue_ids":[2047639417,2036820230],"source_repo_name":"samm82/TestGen-Thesis","source_issue_id":2047639417,"source_issue_number":18,"source_issue_url":"https://github.com/samm82/TestGen-Thesis/issues/18","target_repo_name":"samm82/TestGen-Thesis","target_issue_id":2036820230,"target_issue_number":15,"target_issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","reference_anchor_document_id":"gh_comment_1863078480","reference_answer_author":"smiths","reference_answer_author_association":"COLLABORATOR","quality_score":95.86,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1235,"anchor_target_overlap":0.098,"target_answer_overlap":0.2128},"issue_created_at":"2023-12-18T23:31:16+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2047639417","fragment_type":"issue_description","sequence":0,"text":"Sam's Thesis Meeting | Dec 19, 2023 - VIRTUAL\nMy main work this week has been filling in my glossary with information I have already documented. If you think a \"peer review\" would be beneficial, I'm good with that! There are also some gaps to be filled in later that we could discuss if any stand out. I have some specific questions below, which will likely be answered with time and more research, but figured it wouldn't hurt to provide them to potentially get the ball rolling!\n\n1. Level of granularity\n 1. Data Testing\n 2. Reviews\n 3. Path Coverage\n 4. Mutation\n 5. Regression\n2. Parent relations\n 1. Regression testing: can be white- or black-box, so child or both or N/A?\n 2. Metamorphic testing: seems to be black-box for the code and white-box for the tests; is the \"transparency\" of the testing defined in relation to the test subject?\n3. Confusion on terms\n 1. Data testing vs. data coverage in Patton2006 (the same thing, or testing = black-box and coverage = white-box?)\n 2. White-box testing (structural analysis/testing) in Patton2006 vs. structural = white-box in other places (see also #1)\n 3. Black-box testing (\"specification\"/functional testing) in Patton2006 vs. black-box in other places (e.g., \"functional testing\" for FRs)","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-18T23:31:16+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2047639417,"issue_number":18,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/18","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1862081954","fragment_type":"issue_comment","sequence":1,"text":"Thank you @samm82 for preparing for our meeting tomorrow. I had a quick look at your glossary. It is good to see you working on it. A few questions come to mind. I think some of them overlap with your questions above:\n\n- what is the methodology you are employing to make sure that you don't miss any terms?\n- what does it mean for a method to be a parent of another method? Are we sure we will have a hierarchy?\n- did you make any progress on the papers we discussed last week? Did they have any methodologies or results that we can borrow?\n- will there be another document besides the glossary? We talked about tracking other data for the types of tests, like the required inputs.","author_login":"smiths","author_association":"COLLABORATOR","created_at":"2023-12-19T04:04:17+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2047639417,"issue_number":18,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1862183566","fragment_type":"issue_comment","sequence":2,"text":"Brief answers before I go to bed (we can elaborate tomorrow):\n\n- Right now, I was essentially just moving all my previous research into this new format. Going forward, I am planning to revisit the sources (I think there are about 5 left to do; I've already gone through Patton2006) and keep track of \"duplicated\" information (e.g., definitions that are present in different sources) or \"conflicting\" information (e.g., a term being used to describe two different things). Then, I'll continue following more papers to see what else is out there, including their sources and papers that source them; not sure how to do this \"completely\".\n- A child of a technique is essentially a \"refinement\" of it (an obvious example is that \"static black-box testing\" is a child of \"black-box testing\"). I am not sure how useful this information would be, but figured it may be nice information to track to get an idea of how the literature \"hierarchs\" them and could provide a column to sort this glossary by in future.\n- I haven't yet gone through the papers we discussed previously (or the \"glossaries\" Dr. Carette provided previously, which I'll likely do first), but as mentioned above, they are coming up on my to-do list.\n- Yes, eventually there will be another document beyond this. The format, information, and scope are yet to be decided; my initial thought is that this document could be \"filled out\" as we uncover patterns/ambiguities to be more like the original vision for this work and that it would grow over time (which would also be a nice way to work on it incrementally), but we can discuss this more.","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-19T06:12:13+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2047639417,"issue_number":18,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1863078480","fragment_type":"issue_comment","sequence":3,"text":"The main takeaway here is to figure out/record my methodology. It is likely worth it to describe my ad hoc approach at the beginning (starting at well-known books within the McMaster context) but then outline the \"switch\" to start from more \"established\" resources (e.g., IEEE, SWEBOK) then \"snowballing\" to other resources. Of course, I should also look into other methodologies to see if there is something out there that would be a better fit.\n\nTo make sure that this isn't redundant work, we should make _sure_ that this hasn't been done. I realized that \"survey\" is a good keyword to search for this kind of work that I didn't look for before (I mainly focused on \"taxonomy\" and \"ontology\"), but if I am unable to find a satisfactory one, reaching out to SE.StackExchange might be a good idea. As far as learning about other techniques (and capturing as many as we can!) goes, looking into the papers from our last meeting (#15) and asking ChatGPT may be good next steps.\n\nA minor note: Dr. Smith pointed out that it would be nice to reserve the word \"formal\" to refer to \"formal math\", so changing \"formal reviews\" to \"structured\" or \"systematic\" reviews may be nice. Obviously, we should record what the literature uses, but this is something to keep on the back burner for now, and to record so I don't forget!","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-19T16:21:08+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2047639417,"issue_number":18,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/18","linked_issue_ids":[2036820230],"is_known_query_context":false},{"document_id":"gh_comment_1954518114","fragment_type":"issue_comment","sequence":4,"text":"I expanded on my methodology in 6a343eb; the bit about \"snowballing\" or finding other sources isn't really captured yet","author_login":"samm82","author_association":"OWNER","created_at":"2024-02-20T15:54:04+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2047639417,"issue_number":18,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2036820230","fragment_type":"issue_description","sequence":0,"text":"Sam's Thesis Meeting | Dec 12, 2023 - VIRTUAL\nStructure of glossary:\n1. How should sources be captured? Should it be a LaTeX table?\n2. Should the \"outcome\" of the test be captured at this point, or would that be getting too granular? (See point 4. below)\n\nReview of research on existing ontologies. **NOTE:** You don't need to read the following papers/excerpts for the meeting (although you can if you want); I just want to highlight where this discussion will come from and keep track of it until I upload the papers!\n\n1. Relations between software testing concepts (Barbosa, 2006, p. 2) 1 \n2. Questions from ROoST (Souza, 2017, pp. 8-9, 12) 1 \n3. Term for \"intervention\" (Engstrom, 2015, pp. 1-3) 1 : is it useful? Does it apply to methods like using oracles/equivalence classes?\n4. \"Test factors\" vs. \"Results of Testing (Area of Confidence)\" column (Perry, 2006, pp. 40-41) 1 ; revisiting from #14 but actually writing down our discussion 😅\n\n 1 I'm assuming it would be helpful to upload resources used to my repo somewhere? In a `papers/` folder, named like the BibTeX references for them? I'm sure using natbib style would also help with traceability (#7).","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-12T01:38:58+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851187353","fragment_type":"issue_comment","sequence":1,"text":"Yes, the natbib style for citations is nice because it contains some useful information (author and year) right where the citation is located. It is a good idea if you have a file for a paper that you use the same naming convention. It does help with traceability. That is what I've tried to do in the pub repo. I slipped a few times, but most of the files have natbib style names.\n\nIf there are files that would be helpful for @JacquesCarette and me to read, it is a good idea to put the paper somewhere, or link to its public version, when that exists. For files that don't have a public version you can't put them in a public repo, but you could put them in a private repo, like the pub repo mentioned above.","author_login":"smiths","author_association":"COLLABORATOR","created_at":"2023-12-12T02:05:12+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851197325","fragment_type":"issue_comment","sequence":2,"text":"@smiths If there are some papers that are public and some that I've had to request access to on ResearchGate, would it make sense to store all related papers in a pub repo so that they're in one place?","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-12T02:19:06+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852185193","fragment_type":"issue_comment","sequence":3,"text":"It is fine to store publicly available papers in your repo, but I find that I don't do it. I keep a bib file (References.bib) in my publications repo. If there is a public link it is stored with the reference.","author_login":"smiths","author_association":"COLLABORATOR","created_at":"2023-12-12T14:49:39+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852365811","fragment_type":"issue_comment","sequence":4,"text":"It looks like email notifications are set up on an individual basis. Would you like to be signed up for them as well @smiths?\n\n## Formatting\nThe format of the glossary should be trivial to parse and easy to add to. CSV probably makes sense for its flexibility, and using natbib will allow for an unambiguous traceability to sources. I should make a private GitLab repo for publications so they are all in one place and named consistently. If possible, publicly available sources (e.g., Google Scholar) should be found, but if the only way to get access is through McMaster or through requesting it, it's private.\n\n## Test Factors/Area of Confidence\nThe test factors from Perry might not be complete, independent, or comprehensive, but they may be useful as part of the \"area of confidence\" analysis; regardless, this is something to potentially return to. For now, either this \"area of confidence\" (or software quality, as I've been implicitly using it!) information can be left to the analysis phase, or recorded in these \"simple\" terms as a reminder to go deeper in the analysis phase\n\n## Research\nI should be looking \"forward\" to see if any resources (particularly ROoST) have been cited in more recent works! I should also be doing an \"active search\" by writing down what I do and what process(es) I use. For example,\n- realizing that making this glossary is a \"subsubtask\"\n- following citations (e.g., [1] from Engstrom)\n- \"looking forward\", as mentioned above\n\nRegardless, we noted that the notion of \"intervention\" from Engstrom likely isn't useful to us (or, at the very least, is out of scope) since it is too meta. I wondered about how it related to equivalence classing, but Dr. Carette pointed out that it is still a \"live question\", since it is something that could be generated, and isn't just an out-of-scope process for designing test cases.","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-12T16:19:57+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852435656","fragment_type":"issue_comment","sequence":5,"text":"Nice summary of the meeting @samm82 and yes, please add me to email notifications as well.","author_login":"smiths","author_association":"COLLABORATOR","created_at":"2023-12-12T16:56:41+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1859305648","fragment_type":"issue_comment","sequence":6,"text":"Closing since this meeting has occurred and items are either in progress or to be revisited later.","author_login":"samm82","author_association":"OWNER","created_at":"2023-12-17T22:30:26+08:00","repo_name":"samm82/TestGen-Thesis","issue_id":2036820230,"issue_number":15,"issue_url":"https://github.com/samm82/TestGen-Thesis/issues/15","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0264","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Transaction execution listeners?","query_context":"**Affects:** 5.3.10\n\nPlease provide a method to register a listener to be notified when a transaction is created/committed/rolledback/finished.","known_context_document_ids":["gh_issue_1008748480"],"reference_answer":"I'd like to fix #36801 before going forward as I implemented it as a customizer which make the problem more apparent.","answer_document_id":"gh_comment_1669637489","silver_evidence_path":["gh_comment_1667397497","gh_issue_1838919959","gh_comment_1669637489"],"evidence_issue_ids":[1008748480,1838919959],"source_repo_name":"spring-projects/spring-framework","source_issue_id":1008748480,"source_issue_number":27479,"source_issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","target_repo_name":"spring-projects/spring-boot","target_issue_id":1838919959,"target_issue_number":36770,"target_issue_url":"https://github.com/spring-projects/spring-boot/issues/36770","reference_anchor_document_id":"gh_comment_1667397497","reference_answer_author":"snicoll","reference_answer_author_association":"MEMBER","quality_score":70.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1111,"target_answer_overlap":0.0},"issue_created_at":"2021-09-27T22:47:48+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1008748480","fragment_type":"issue_description","sequence":0,"text":"Transaction execution listeners\n**Affects:** 5.3.10\n\nPlease provide a method to register a listener to be notified when a transaction is created/committed/rolledback/finished.","author_login":"cdalexndr","author_association":"NONE","created_at":"2021-09-27T22:47:48+08:00","repo_name":"spring-projects/spring-framework","issue_id":1008748480,"issue_number":27479,"issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1146857277","fragment_type":"issue_comment","sequence":1,"text":"Can you try using following phases:-\nBEFORE_COMMIT – The event will be handled before the transaction commit.\nAFTER_COMPLETION – The event will be handled when the transaction has completed regardless of success.\nAFTER_ROLLBACK – The event will be handled when the transaction has rolled back.\nAFTER_COMMIT – The event will be handled when the transaction gets committed successfully.","author_login":"Nidhi-Tanwar14","author_association":"NONE","created_at":"2022-06-05T18:00:09+08:00","repo_name":"spring-projects/spring-framework","issue_id":1008748480,"issue_number":27479,"issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666634631","fragment_type":"issue_comment","sequence":2,"text":"I'm introducing a dedicated `TransactionListener` contract, with such listeners to be registered on the transaction manager itself. There are before/afterBegin, before/afterCommit and before/afterRollback callbacks which are being triggered by the transaction manager whenever it operates on an actual transaction.\n\nThis is effectively a callback interface for stateless listening to transaction creation/completion steps in a transaction manager. It is primarily meant for observation and statistics, not for resource management purposes where stateful transaction synchronizations are still the way to go. In contrast to transaction synchronizations, the transaction listener contract is commonly supported for thread-bound transactions as well as reactive transactions, with a common registration facility in the new `ConfigurableTransactionManager` interface.","author_login":"jhoeller","author_association":"CONTRIBUTOR","created_at":"2023-08-05T23:07:34+08:00","repo_name":"spring-projects/spring-framework","issue_id":1008748480,"issue_number":27479,"issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666764379","fragment_type":"issue_comment","sequence":3,"text":"I've settled on the term \"transaction execution listener\" for it, also naming the contract `TransactionExecutionListener` which goes nicely with the provided `TransactionExecution` argument in the callback methods. A more general \"transaction listener\" term can be confused with `TransactionalApplicationListener` and `@TransactionalEventListener`.","author_login":"jhoeller","author_association":"CONTRIBUTOR","created_at":"2023-08-06T07:59:55+08:00","repo_name":"spring-projects/spring-framework","issue_id":1008748480,"issue_number":27479,"issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666859381","fragment_type":"issue_comment","sequence":4,"text":"@snicoll @wilkinsona I suppose Boot could automatically inject any `TransactionExecutionListener` beans in the context into a `PlatformTransactionManager` or `ReactiveTransactionManager` that it configures, along the following lines:\n\n@Bean\npublic JdbcTransactionManager transactionManager(DataSource dataSource, Collection transactionExecutionListeners) {\n JdbcTransactionManager tm = new JdbcTransactionManager();\n tm.setDataSource(dataSource);\n tm.setTransactionExecutionListeners(transactionExecutionListeners);\n return tm;\n}","author_login":"jhoeller","author_association":"CONTRIBUTOR","created_at":"2023-08-06T13:24:36+08:00","repo_name":"spring-projects/spring-framework","issue_id":1008748480,"issue_number":27479,"issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1667397497","fragment_type":"issue_comment","sequence":5,"text":"Thanks for the suggestion, @jhoeller. I've opened URL Sorry for the noise of #31001 which I opened in the wrong tracker.","author_login":"wilkinsona","author_association":"MEMBER","created_at":"2023-08-07T08:10:35+08:00","repo_name":"spring-projects/spring-framework","issue_id":1008748480,"issue_number":27479,"issue_url":"https://github.com/spring-projects/spring-framework/issues/27479","linked_issue_ids":[1838919959],"is_known_query_context":false},{"document_id":"gh_issue_1838919959","fragment_type":"issue_description","sequence":0,"text":"Add any TransactionExecutionListener beans to the auto-configured transaction manager\nSuggestion from Juergen:","author_login":"wilkinsona","author_association":"MEMBER","created_at":"2023-08-07T08:08:27+08:00","repo_name":"spring-projects/spring-boot","issue_id":1838919959,"issue_number":36770,"issue_url":"https://github.com/spring-projects/spring-boot/issues/36770","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1669637489","fragment_type":"issue_comment","sequence":1,"text":"I'd like to fix #36801 before going forward as I implemented it as a customizer which make the problem more apparent.","author_login":"snicoll","author_association":"MEMBER","created_at":"2023-08-08T13:38:02+08:00","repo_name":"spring-projects/spring-boot","issue_id":1838919959,"issue_number":36770,"issue_url":"https://github.com/spring-projects/spring-boot/issues/36770","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0265","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Invariant: Native Module Cannot be Null (Expo)?","query_context":"Hi there,\n\nI am trying to use this lib for a ios build and when debugging in metro I get the \"Native Module Cannot be Null\" error (please see screenshot attached). It goes away when I comment the printing code so it is definitely coming from this, I have installed npm package and have listed the package \"react-native-star-io10\" in my package.json as well but no luck.\n\nI have been trying to solve this for a while, would greatly appreciate any help :)\n\n \nimage","known_context_document_ids":["gh_issue_1074289316"],"reference_answer":"We have released an updated version that includes the above reflections. Thank you for your patience!","answer_document_id":"gh_comment_1939904986","silver_evidence_path":["gh_comment_1851197930","gh_issue_1597675053","gh_comment_1939904986"],"evidence_issue_ids":[1074289316,1597675053],"source_repo_name":"star-micronics/react-native-star-io10","source_issue_id":1074289316,"source_issue_number":35,"source_issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","target_repo_name":"star-micronics/react-native-star-io10","target_issue_id":1597675053,"target_issue_number":90,"target_issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","reference_anchor_document_id":"gh_comment_1851197930","reference_answer_author":"bandit-ibayashi","reference_answer_author_association":"MEMBER","quality_score":76.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2021-12-08T11:08:43+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1074289316","fragment_type":"issue_description","sequence":0,"text":"Invariant: Native Module Cannot be Null (Expo)\nHi there,\n\nI am trying to use this lib for a ios build and when debugging in metro I get the \"Native Module Cannot be Null\" error (please see screenshot attached). It goes away when I comment the printing code so it is definitely coming from this, I have installed npm package and have listed the package \"react-native-star-io10\" in my package.json as well but no luck.\n\nI have been trying to solve this for a while, would greatly appreciate any help :)\n\n \nimage","author_login":"mnm458","author_association":"NONE","created_at":"2021-12-08T11:08:43+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1015708192","fragment_type":"issue_comment","sequence":1,"text":"I don't think this can run in Expo. Our SDK requires platform-specific features; Bluetooth and BLE to name a few.\nI don't think platform specific-code can run in Expo.","author_login":"gare-bear","author_association":"MEMBER","created_at":"2022-01-18T18:41:02+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1015823707","fragment_type":"issue_comment","sequence":2,"text":"It should work with an Expo development client.\nYou probably won't even need a config plugin looking at the install instructions\nMost likely just infoPlist/permission settings\nIt would require some testing of course. Maybe @mnm458 or others have a device and wouldn't mind trying it out?\nIf there are issues, please share with the Expo community via Discord.\nThis could be a nice addition to expo.","author_login":"kickbk","author_association":"NONE","created_at":"2022-01-18T20:51:51+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1139022237","fragment_type":"issue_comment","sequence":3,"text":"@kickbk @mnm458 I came across some use info in the React Native documentation.\n\nFrom the Caveats section,\n\"Because you don't build any native code when using Expo to create a project, it's not possible to include custom native modules beyond the React Native APIs and components that are available in the Expo client app.\" \n\nSo until that changes from the React Native side, we will not be able to support the Expo client","author_login":"gare-bear","author_association":"MEMBER","created_at":"2022-05-26T20:45:11+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1140310906","fragment_type":"issue_comment","sequence":4,"text":"I already created (with the help of the expo team) a fork that works with a custom expo client. I just need to find the time to clean it up and share.\nIt is highly likely that if you have a project that requires this library, you'd be ok with a custom Expo client. You'd be handling native via a config plugin.","author_login":"kickbk","author_association":"NONE","created_at":"2022-05-28T18:33:14+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1204311122","fragment_type":"issue_comment","sequence":5,"text":"Hey @kickbk I think I'm having the same issue, could you please share this fork?","author_login":"felipesoares6","author_association":"NONE","created_at":"2022-08-03T18:11:48+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1298704866","fragment_type":"issue_comment","sequence":6,"text":"I made a fork that contains some of these fixes, you can try them out by using:\n\n\"react-native-star-io10\": \" URL \n\n \nIn your package.json","author_login":"jongbelegen","author_association":"NONE","created_at":"2022-11-01T15:27:53+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1851197930","fragment_type":"issue_comment","sequence":7,"text":"I have posted a workaround that we think is relevant to this issue at Issue #90.\nWe would appreciate it if you could refer to this.","author_login":"bandit-ibayashi","author_association":"MEMBER","created_at":"2023-12-12T02:19:57+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[1597675053],"is_known_query_context":false},{"document_id":"gh_comment_2097968814","fragment_type":"issue_comment","sequence":8,"text":"Have you found a solution to this problem?\nWe will close this issue once, but if the issue is still not resolved, please reopen it or post a new issue.","author_login":"can-miki","author_association":"CONTRIBUTOR","created_at":"2024-05-07T10:18:42+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1074289316,"issue_number":35,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/35","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1597675053","fragment_type":"issue_description","sequence":0,"text":"[REQUEST] Support `use_frameworks!`\n`react-native-star-io10` currently does not support `use_frameworks!` which means it cannot work alongside many popular libraries, such as `react-native-firebase`. Flipper is another library that doesn't support `use_frameworks!` and trying to meddle with overrides in the podfile will ultimately fail if using Firebase storage or Firebase functions.\nCould we have `react-native-star-io10` suuport `use_frameworks!` soon? Is it complicated to add support for it? If it's simply achievable some edits to the Podfile, please share instructions.","author_login":"kickbk","author_association":"NONE","created_at":"2023-02-23T23:44:05+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1597675053,"issue_number":90,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1533388965","fragment_type":"issue_comment","sequence":1,"text":"@bandit-ibayashi we created a repo with a minimal project that reproduces this build-time issue: URL \n\nThe readme in that repo is an excerpt from the build log with the errors.","author_login":"marvinklein","author_association":"NONE","created_at":"2023-05-03T16:58:35+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1597675053,"issue_number":90,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1644413105","fragment_type":"issue_comment","sequence":2,"text":"For those looking for a working solution: URL \nIt probably needs to be updated to integrate the updates from URL but it'll work.\nSome of the fixes we introduced in the fork are hardcoded and there's a need for matching your project's Kotlin version with the one used by the lib, hence the \"kotlin\" branch for lack of time adding it via a config plugin.\nI'm not currently maintaining this fork since I don't use the library in my project.","author_login":"kickbk","author_association":"NONE","created_at":"2023-07-20T18:38:14+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1597675053,"issue_number":90,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1711554526","fragment_type":"issue_comment","sequence":3,"text":"@kickbk @marvinklein I'm afraid for not responding to this request for a long time.\n\nOur React Native project uses native code, so we didn't consider Expo. But we noticed the official document that contained this sentence has been updated. So we are investigating this matter again, taking into account the hints we received from everyone.\n\nWe would like to thank everyone for their cooperation, and please wait a little longer to find out whether Expo will be possible or not, and if so, how we can respond.","author_login":"bandit-ibayashi","author_association":"MEMBER","created_at":"2023-09-08T11:56:33+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1597675053,"issue_number":90,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1846849105","fragment_type":"issue_comment","sequence":4,"text":"We found to be able to support \"use_frameworks\" by modifying .podspec file.\n\n**Method**\n1. Download current react-native-star-io10 (`yarn install` , etc.)\n2. Add the following code to the react-native-star-io10.podspec file located in the node_modules directory.\n3. Build it.\n\n**Modification**\n\nPlease add the following code the above `s.vendored_frameworks = 'ios/libs/StarIO10.xcframework'`.\n\n podspec\n if ENV['USE_FRAMEWORKS']\n header_search_path = [\n '$(SRCROOT)/../../node_modules/react/** $(SRCROOT)/../../node_modules/react-native/**'\n ]\n\n exclude_source_file_name = [\n 'libs/StarIO10.xcframework/ios-arm64_x86_64-simulator/StarIO10.framework/Headers/*.h libs/StarIO10.xcframework/ios-arm64_x86_64-simulator/StarIO10.framework/PrivateHeaders/*.h'\n ]\n\n s.pod_target_xcconfig = {\n \"HEADER_SEARCH_PATHS\" => header_search_path.join(\" \"),\n \"EXCLUDED_SOURCE_FILE_NAMES\" => exclude_source_file_name.join(\" \")\n }\n end","author_login":"bandit-ibayashi","author_association":"MEMBER","created_at":"2023-12-08T09:28:22+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1597675053,"issue_number":90,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939904986","fragment_type":"issue_comment","sequence":5,"text":"We have released an updated version that includes the above reflections. Thank you for your patience!","author_login":"bandit-ibayashi","author_association":"MEMBER","created_at":"2024-02-13T00:41:54+08:00","repo_name":"star-micronics/react-native-star-io10","issue_id":1597675053,"issue_number":90,"issue_url":"https://github.com/star-micronics/react-native-star-io10/issues/90","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0268","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"POST to a new table returns a 404, but GET on the same table returns a 200?","query_context":"### Environment\n\n* PostgreSQL version: Postgres 15.5 running on my local development machine on port 5432\n* PostgREST version: PostgREST 12.0.2 running on my local machine from an unmodified docker image pulled from `postgrest/postgrest`\n* Operating system: macos 12.6.1\n\n### Description of issue\nI added a table `ApiVersion` to my `pmg` schema through a database migration. My problem is that when I try to POST a record in Postman to `/ApiVersion`, I get a 404 with no error body. I have another request in Postman that is a GET `/ApiVersion` and I get a 200 on that route. \n\n- I did try both sending the server a SIGUSR1 signal (multiple times), and completely restarting the server, with no success.\n- I have tried posting as both a single record and an array containing the record with the same results.\n- I have tried POSTing to other tables in other schemas and that works with no problems\n- I am wondering if there is some kind of database permissions problem causing this - but I would expect in that case to return a 403 and an error body describing the problem - not a 404 with an empty error body.\n- I checked and my user `db_admin` has both USAGE and CREATE privileges on the `pmg` schema\n- I checked the table permissions relating to `db_admin` and got: `db_admin,pmg,ApiVersion,{db_admin=arwdDxt/db_admin} `\nSo, the `db_admin` role has been granted INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES, and TRIGGER privileges on the table.\n- I also checked the sequence permissions for the sequence used in the table index: `db_admin,pmg,ApiVersion_id_seq,{db_admin=rwU/db_admin}`. So, the `db_admin` role has been granted SELECT, UPDATE, and USAGE privileges on the sequence.\n\n#### Summary\nI would expect to be able to insert records in the `pmg.\"ApiVersion\"` table with a POST request, but I get a 404. I can do a GET on the table with a 200.\n\n### Steps to Reproduce\n\n#### Table Creation\nI create the table using a Knex migration, but the equivalent SQL (supplied by TablePlus) is below:\n\nCREATE SEQUENCE IF NOT EXISTS pmg.\"ApiVersion_id_seq\";\nCREATE TABLE \"pmg\".\"ApiVersion\" (\n \"id\" int4 NOT NULL DEFAULT nextval('pmg.\"ApiVersion_id_seq\"'::regclass),\n \"name\" varchar NOT NULL,\n \"activeDate\" timestamptz NOT NULL DEFAULT CURRENT_TIMESTAMP,\n PRIMARY KEY (\"id\")\n);\n\n#### Populate the table\nSET ROLE db_admin;\nINSERT INTO pmg.\"ApiVersion\" (\"name\") VALUES ('weird-wallaby-92');\n\n#### GET request\ncurl --location ' URL \\\n--header 'Accept-Profile: pmg' \\\n--header 'Authorization: Bearer (token containing the db_admin role)\n\nResult:\n\n[\n {\n \"id\": 1,\n \"name\": \"weird-wallaby-92\",\n \"activeDate\": \"2024-02-16T13:48:10.548943-07:00\"\n }\n]\n\n#### POST request\ncurl --location ' URL \\\n--header 'Accept-Profile: pmg' \\\n--header 'Content-Type: application/json' \\\n--header 'Authorization: Bearer (token containing the db_admin role)\\\n--data '[\n {\n \"name\": \"weird-wallaby-93\"\n }\n]'\n\nResult:\n{}","known_context_document_ids":["gh_issue_2139637769"],"reference_answer":"I get the idea, although I don't think this would be respected in practice. Name collisions could also happen in homographs too.\n\n---\n\nSince I was working on bulding the OpenAPI spec, I noticed that it's quite difficult to work with the `Accept-Profile` header, since the response, filters and permissions may change when that header is present and the endpoint is the same. Separating it into a different endpoint instead of a header helps a lot in simplifying this. Of course, we shouldn't build our API around OpenAPI, but I think it's good to know that the issue is there.","answer_document_id":"gh_comment_2033374890","silver_evidence_path":["gh_comment_1952702801","gh_issue_1882193893","gh_comment_2033374890"],"evidence_issue_ids":[2139637769,1882193893],"source_repo_name":"PostgREST/postgrest","source_issue_id":2139637769,"source_issue_number":3231,"source_issue_url":"https://github.com/PostgREST/postgrest/issues/3231","target_repo_name":"PostgREST/postgrest","target_issue_id":1882193893,"target_issue_number":2927,"target_issue_url":"https://github.com/PostgREST/postgrest/issues/2927","reference_anchor_document_id":"gh_comment_1952702801","reference_answer_author":"laurenceisla","reference_answer_author_association":"MEMBER","quality_score":95.55,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0909},"issue_created_at":"2024-02-16T23:40:10+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2139637769","fragment_type":"issue_description","sequence":0,"text":"POST to a new table returns a 404, but GET on the same table returns a 200\n### Environment\n\n* PostgreSQL version: Postgres 15.5 running on my local development machine on port 5432\n* PostgREST version: PostgREST 12.0.2 running on my local machine from an unmodified docker image pulled from `postgrest/postgrest`\n* Operating system: macos 12.6.1\n\n### Description of issue\nI added a table `ApiVersion` to my `pmg` schema through a database migration. My problem is that when I try to POST a record in Postman to `/ApiVersion`, I get a 404 with no error body. I have another request in Postman that is a GET `/ApiVersion` and I get a 200 on that route. \n\n- I did try both sending the server a SIGUSR1 signal (multiple times), and completely restarting the server, with no success.\n- I have tried posting as both a single record and an array containing the record with the same results.\n- I have tried POSTing to other tables in other schemas and that works with no problems\n- I am wondering if there is some kind of database permissions problem causing this - but I would expect in that case to return a 403 and an error body describing the problem - not a 404 with an empty error body.\n- I checked and my user `db_admin` has both USAGE and CREATE privileges on the `pmg` schema\n- I checked the table permissions relating to `db_admin` and got: `db_admin,pmg,ApiVersion,{db_admin=arwdDxt/db_admin} `\nSo, the `db_admin` role has been granted INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES, and TRIGGER privileges on the table.\n- I also checked the sequence permissions for the sequence used in the table index: `db_admin,pmg,ApiVersion_id_seq,{db_admin=rwU/db_admin}`. So, the `db_admin` role has been granted SELECT, UPDATE, and USAGE privileges on the sequence.\n\n#### Summary\nI would expect to be able to insert records in the `pmg.\"ApiVersion\"` table with a POST request, but I get a 404. I can do a GET on the table with a 200.\n\n### Steps to Reproduce\n\n#### Table Creation\nI create the table using a Knex migration, but the equivalent SQL (supplied by TablePlus) is below:\n\nCREATE SEQUENCE IF NOT EXISTS pmg.\"ApiVersion_id_seq\";\nCREATE TABLE \"pmg\".\"ApiVersion\" (\n \"id\" int4 NOT NULL DEFAULT nextval('pmg.\"ApiVersion_id_seq\"'::regclass),\n \"name\" varchar NOT NULL,\n \"activeDate\" timestamptz NOT NULL DEFAULT CURRENT_TIMESTAMP,\n PRIMARY KEY (\"id\")\n);\n\n#### Populate the table\nSET ROLE db_admin;\nINSERT INTO pmg.\"ApiVersion\" (\"name\") VALUES ('weird-wallaby-92');\n\n#### GET request\ncurl --location ' URL \\\n--header 'Accept-Profile: pmg' \\\n--header 'Authorization: Bearer (token containing the db_admin role)\n\nResult:\n\n[\n {\n \"id\": 1,\n \"name\": \"weird-wallaby-92\",\n \"activeDate\": \"2024-02-16T13:48:10.548943-07:00\"\n }\n]\n\n#### POST request\ncurl --location ' URL \\\n--header 'Accept-Profile: pmg' \\\n--header 'Content-Type: application/json' \\\n--header 'Authorization: Bearer (token containing the db_admin role)\\\n--data '[\n {\n \"name\": \"weird-wallaby-93\"\n }\n]'\n\nResult:\n{}","author_login":"jbstewart","author_association":"NONE","created_at":"2024-02-16T23:40:10+08:00","repo_name":"PostgREST/postgrest","issue_id":2139637769,"issue_number":3231,"issue_url":"https://github.com/PostgREST/postgrest/issues/3231","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1949619219","fragment_type":"issue_comment","sequence":1,"text":"Ah, for methods different than `GET` the header to access a different schema is `Content-Profile` instead of `Accept-Profile`. Does this work for you:\n\nbash\ncurl --location ' URL \n--header 'Content-Profile: pmg'\n--header 'Content-Type: application/json'\n--header 'Authorization: Bearer (token containing the db_admin role)\n--data '[\n{\n\"name\": \"weird-wallaby-93\"\n}\n]'","author_login":"laurenceisla","author_association":"MEMBER","created_at":"2024-02-17T02:58:51+08:00","repo_name":"PostgREST/postgrest","issue_id":2139637769,"issue_number":3231,"issue_url":"https://github.com/PostgREST/postgrest/issues/3231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949619423","fragment_type":"issue_comment","sequence":2,"text":"I should add that I went through all the reproduction steps above, but instead of using the `pmg` schema I used a different schema (one that I've been using for a little longer) and this problem did NOT manifest. So it seems to be something connected to the `pmg` schema. Could be a permissions issue, but I've checked everything I can think of permissions-wise. And I still believe if it's a permissions issue it should manifest as a 403 with an error body.","author_login":"jbstewart","author_association":"NONE","created_at":"2024-02-17T02:59:43+08:00","repo_name":"PostgREST/postgrest","issue_id":2139637769,"issue_number":3231,"issue_url":"https://github.com/PostgREST/postgrest/issues/3231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1949625869","fragment_type":"issue_comment","sequence":3,"text":"@laurenceisla YES! That fixed it. But the weird thing is the other POST requests I have in Postman against tables in a different schema ('industrial'), worked with the Accept-Profile header, which is quite strange. Thank you so much!","author_login":"jbstewart","author_association":"NONE","created_at":"2024-02-17T03:24:51+08:00","repo_name":"PostgREST/postgrest","issue_id":2139637769,"issue_number":3231,"issue_url":"https://github.com/PostgREST/postgrest/issues/3231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952702801","fragment_type":"issue_comment","sequence":4,"text":"Two headers is always confusing, agree. We'll fix this on URL","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2024-02-19T15:31:57+08:00","repo_name":"PostgREST/postgrest","issue_id":2139637769,"issue_number":3231,"issue_url":"https://github.com/PostgREST/postgrest/issues/3231","linked_issue_ids":[1882193893],"is_known_query_context":false},{"document_id":"gh_comment_2147784068","fragment_type":"issue_comment","sequence":5,"text":"Does this behavior described by @jbstewart can be explained by something else than the schema selection in the header? I'm facing the exact same problem while following the tutorial. After creating the *todos* tables and applying the dedicated privileges I have a **200 OK** with GET `/todos` but a **404 Not Found** with POST `/todos`. However if I restart the Docker container (I'm running `postgrest/postgrest:v12.0.3` by the way) the POST `/todos` is successful.","author_login":"mtovmassian","author_association":"NONE","created_at":"2024-06-04T15:10:45+08:00","repo_name":"PostgREST/postgrest","issue_id":2139637769,"issue_number":3231,"issue_url":"https://github.com/PostgREST/postgrest/issues/3231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1882193893","fragment_type":"issue_description","sequence":0,"text":"Use `Prefer: schema=x` as an alternative to Accept-Profile/Content-Profile\n## Problem\n\nChanging from `Accept-Profile` to `Content-Profile` depending on the HTTP request method can be confusing. See URL and URL \n\nWe don't really need the flexibility of saying insert into into `schema.users` but give me the results of `another_schema.users` on the same request. This can be achieved in theory with `Content-Profile` from `Accept-Profile`.\n\n## Solution\n\nUse `Prefer: schema=x` instead and apply it to all HTTP methods.","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2023-09-05T15:20:32+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1717651267","fragment_type":"issue_comment","sequence":1,"text":"This would be great, and help clean up some Caddy Config code I've had to implement in order to abstract and \"fix\" this.\n\nI've seen many end users struggle with this too and make the common mistake of using the wrong header.","author_login":"robertsosinski","author_association":"NONE","created_at":"2023-09-13T13:36:10+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1721550247","fragment_type":"issue_comment","sequence":2,"text":"That should be in its own issue but I'd be against it because:\n\n- it makes the url brittle (a schema is an implementation detail and a rename would break the url)\n- would make impossible to do resource embedding across different schemas (if we ever want to)\n- will make custom urls harder to implement later on ( URL","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2023-09-15T16:30:09+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1723486409","fragment_type":"issue_comment","sequence":3,"text":"@wolfgangwalther I've opened a new issue for the schema path idea: URL \n\nI guess we can have both? I don't see why one would exclude the other. This issue is mostly about improving the current header way.","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2023-09-18T14:01:08+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952707140","fragment_type":"issue_comment","sequence":4,"text":"Now that we have `Prefer: handling=strict`, we can use `Prefer: handling=strict; schema=xx` instead. No need for creating a new header.","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2024-02-19T15:32:48+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2030924333","fragment_type":"issue_comment","sequence":5,"text":"That doesn't look right according to REST definition of resource.\n\n URL \n \n \n \n\nA schema is an implementation detail. The \"concept\" (say \"authors\") can move schemas and it'll still be the same. Having the schema on the path results in brittle URLs.\n\nThis way will also give us the flexibility of doing cross-schema resource embedding if the need arises. Using paths for schemas will overcomplicate the syntax `/schema1/projects?select=schema2/projects`?\n\n---\n\nBesides that `Prefer` is just an improvement over the existing Accept/Content-Profile headers so not a new feature. I don't see why not improve things.\n \n\nIt's the only header we can use without inventing an `X-Something`, which is much more likely to give trouble. If you have an alternative header, I'm all ears..","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2024-04-02T01:44:34+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033276573","fragment_type":"issue_comment","sequence":6,"text":"From a conceptual point of view (the REST one), those `items` you refer to should be different concepts. The correct db design for that is to have only one parent table `items` then use table inheritance for childs `items_x` and `items_y`. Those would be different endpoints then.\n \n\nIMO at the relation level. Databases and schemas are boxes of relations. If you rename the table/view then it is a different relation thus a different concept.\n \n\nHm, I don't see why. IME besides the different headers that has been working just fine. Simple in interface, implementation and maintenance.\n\n---\n\nWe had another discussion about the `Host` header pointing to different databases. Following your URL argument here, should we now use `/db/schema/table`? (Like prest does?) Typing that.. looks inconvenient for users.\n\nMaybe that's the real win we have with the header approach. We're able to provide default schemas/databases for our endpoints and keep them simpler.","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2024-04-02T23:27:16+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033374890","fragment_type":"issue_comment","sequence":7,"text":"I get the idea, although I don't think this would be respected in practice. Name collisions could also happen in homographs too.\n\n---\n\nSince I was working on bulding the OpenAPI spec, I noticed that it's quite difficult to work with the `Accept-Profile` header, since the response, filters and permissions may change when that header is present and the endpoint is the same. Separating it into a different endpoint instead of a header helps a lot in simplifying this. Of course, we shouldn't build our API around OpenAPI, but I think it's good to know that the issue is there.","author_login":"laurenceisla","author_association":"MEMBER","created_at":"2024-04-03T01:25:11+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033399321","fragment_type":"issue_comment","sequence":8,"text":"OpenAPI is a valid point. So in general is harder to provide a static spec with the header approach.\n\nIn that case I guess we should also ditch the `Host` idea for mapping an endpoint to another database relation.","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2024-04-03T01:58:23+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2033507039","fragment_type":"issue_comment","sequence":9,"text":"Let's move forward with the schema in URL then. Will open a new issue for that.","author_login":"steve-chavez","author_association":"MEMBER","created_at":"2024-04-03T04:26:03+08:00","repo_name":"PostgREST/postgrest","issue_id":1882193893,"issue_number":2927,"issue_url":"https://github.com/PostgREST/postgrest/issues/2927","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0269","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Help with installing on macOS Ventura 13?","query_context":"Hi,\n\nI am trying to help a student install Corrfunc on their MacBook, which has the latest OS (Ventura 13, I believe). We tried Method 2 (i.e., directly using pip), but ran into the `failed building wheel for Corrfunc` error. Then we tried Method 1, but unfortunately got the following error after running `make CC=gcc-13`:\n\nIn file included from ../../utils/cpu_features.c:13:\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:27:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:29:5,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nIn function 'xgetbv',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:54:10,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:69:4: error: impossible constraint in 'asm'\n\n 69 | __asm(\"xgetbv\" : \"=a\"(a),\"=d\"(d) : \"c\"(ctr) : );\n\n | ^~~~~\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:58:5,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:62:5,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nmake[2]: *** [../../utils/cpu_features.o] Error 1\n\nmake[1]: *** [DD] Error 2\n\nmake: *** [theory] Error 2\n\nDo you know what could be going wrong and what else we can try?","known_context_document_ids":["gh_issue_1777847456"],"reference_answer":"Great - glad this all worked :)! Can you confirm that you have OpenMP support, i.e., that you can use multiple threads now?\n\nSidenote: The reason why you were facing the compilation and non-detection of `llvm-clang/python/numpy` is all because you (or `homebrew`) have the relevant aliases set. The aliases work fine for you since you are always accessing from an interactive terminal - i.e., a terminal where you can send keyboard input to. The shell sessions spawned by `common.mk` are non-interactive and, therefore, **do not** know about the aliases. \n\nI also suspect your `PATH` variable does not contain `/opt/homebrew/bin` (for `llvm-clang`) ahead of `/usr/bin` (for `apple-clang`), and thus, when the non-interactive shell resolves `clang` as `/usr/bin/clang`. Since I don't use `homebrew`, I am unsure if it is an intentional design that `/opt/homebrew/bin` is not added to your `PATH` environment variable. If you ever run into such odd issues of not-detecting-the-correct-tool, then it might be worthwhile adding the full path to whichever tool that you are wanting to detect (or equivalently, add `/opt/homebrew/bin` to `PATH` either in the terminal you are working in, or in the startup shell file - `.bashrc/.zshrc` etc)","answer_document_id":"gh_comment_1592160329","silver_evidence_path":["gh_comment_1610339944","gh_issue_1748201512","gh_comment_1592160329"],"evidence_issue_ids":[1777847456,1748201512],"source_repo_name":"manodeep/Corrfunc","source_issue_id":1777847456,"source_issue_number":298,"source_issue_url":"https://github.com/manodeep/Corrfunc/issues/298","target_repo_name":"manodeep/Corrfunc","target_issue_id":1748201512,"target_issue_number":294,"target_issue_url":"https://github.com/manodeep/Corrfunc/issues/294","reference_anchor_document_id":"gh_comment_1610339944","reference_answer_author":"manodeep","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1084},"issue_created_at":"2023-06-27T22:38:14+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_1777847456","fragment_type":"issue_description","sequence":0,"text":"Help with installing on macOS Ventura 13\nHi,\n\nI am trying to help a student install Corrfunc on their MacBook, which has the latest OS (Ventura 13, I believe). We tried Method 2 (i.e., directly using pip), but ran into the `failed building wheel for Corrfunc` error. Then we tried Method 1, but unfortunately got the following error after running `make CC=gcc-13`:\n\nIn file included from ../../utils/cpu_features.c:13:\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:27:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:29:5,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nIn function 'xgetbv',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:54:10,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:69:4: error: impossible constraint in 'asm'\n\n 69 | __asm(\"xgetbv\" : \"=a\"(a),\"=d\"(d) : \"c\"(ctr) : );\n\n | ^~~~~\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:58:5,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nIn function 'cpuid',\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:62:5,\n\n inlined from 'runtime_instrset_detect' at ../../utils/cpu_features.c:19:5:\n\n../../utils/cpu_features.h:41:4: error: impossible constraint in 'asm'\n\n 41 | __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n\n | ^~~~~\n\nmake[2]: *** [../../utils/cpu_features.o] Error 1\n\nmake[1]: *** [DD] Error 2\n\nmake: *** [theory] Error 2\n\nDo you know what could be going wrong and what else we can try?","author_login":"boryanah","author_association":"NONE","created_at":"2023-06-27T22:38:14+08:00","repo_name":"manodeep/Corrfunc","issue_id":1777847456,"issue_number":298,"issue_url":"https://github.com/manodeep/Corrfunc/issues/298","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1610339944","fragment_type":"issue_comment","sequence":1,"text":"@boryanah Thanks for reporting this! Yeah, this is a known issue and we are working towards a fix. In the meantime, please follow the comments/steps in #294 - hopefully that will at least let you compile.","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-27T23:11:02+08:00","repo_name":"manodeep/Corrfunc","issue_id":1777847456,"issue_number":298,"issue_url":"https://github.com/manodeep/Corrfunc/issues/298","linked_issue_ids":[1748201512],"is_known_query_context":false},{"document_id":"gh_comment_1616411854","fragment_type":"issue_comment","sequence":2,"text":"Thanks a lot! We managed to install it following the instructions in that thread.","author_login":"boryanah","author_association":"NONE","created_at":"2023-07-02T06:51:36+08:00","repo_name":"manodeep/Corrfunc","issue_id":1777847456,"issue_number":298,"issue_url":"https://github.com/manodeep/Corrfunc/issues/298","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1616495969","fragment_type":"issue_comment","sequence":3,"text":"Ohh great - glad at least you could use the workaround and get Corrfunc running. I am closing this issue but please feel free to reopen if you need additional help.","author_login":"manodeep","author_association":"OWNER","created_at":"2023-07-02T09:06:21+08:00","repo_name":"manodeep/Corrfunc","issue_id":1777847456,"issue_number":298,"issue_url":"https://github.com/manodeep/Corrfunc/issues/298","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1748201512","fragment_type":"issue_description","sequence":0,"text":"M2 compiling issues\n## General information\n\n- Corrfunc version: 2.5.0\n- platform: M2 Mac, macOS Monterrey\n- installation method (pip/source/other?): pip, then git clone\n\n## Issue description \npip:\nERROR: Failed building wheel for Corrfunc\n Running setup.py clean for Corrfunc\nFailed to build Corrfunc\nERROR: Could not build wheels for Corrfunc, which is required to install pyproject.toml-based projects\n\nGitHub directory results in the following error after \"make install\":\nclang: error: the clang compiler does not support '-march=native'\n\n### What have you tried so far?\nChanging the \"-march=native\" lines in common.mk to \"-mpu-apple=a14\", adding make CC=gcc, updating my gsl/gcc/python/pip packages - still I get the same error. \n\n## Minimal failing example\n** could not install\n\n \n\nterminal\nmake install\n\n# issue\n\nMakefile:9: Not compiling C extensions for mocks. Either python or numpy not available \ngcc -DVERSION=\\\"2.5.0\\\" -DUSE_UNICODE -std=c99 -m64 -g -Wsign-compare -Wall -Wextra -Wshadow -Wunused -fPIC -D_POSIX_SOURCE=200809L -D_GNU_SOURCE -D_DARWIN_C_SOURCE -O3 -funroll-loops -march=native -fno-strict-aliasing -Wformat=2 -Wpacked -Wnested-externs -Wpointer-arith -Wredundant-decls -Wfloat-equal -Wcast-qual -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wstrict-prototypes -Wno-unused-local-typedefs logbins.c -lm -o logbins\nclang: error: the clang compiler does not support '-march=native'\nmake[1]: *** [logbins] Error 1\nmake: *** [install] Error 2","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-08T15:53:51+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583664551","fragment_type":"issue_comment","sequence":1,"text":"Thanks for using Corrfunc *and* for reporting the issue. I have been meaning to add the compilation-on-m1/m2 fix from the `arm64` branch into the `master` branch and this gives me the reminder to do so now. \n\nEven after the compilation is fixed, you still will have another issue with the non-detection of python/numpy. Can you add a bit more detail about your python/numpy setup - are you using conda/macports/brew?","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-09T00:28:03+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583783552","fragment_type":"issue_comment","sequence":2,"text":"@quasars100 Will you please do the following to check if the new commits fix your compilation issue? The steps would be:\n\n 1. git clone \n 2. git checkout -b fix-compile-on-apple-soc\n 3. make clean\n 4. make\n\nThis should compile all of the command-line executables. If you encounter any warning/errors, please report back.","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-09T01:20:30+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1584836861","fragment_type":"issue_comment","sequence":3,"text":"Thank you so much for the quick reply. My python version is Python 3.10.12 (installed using brew) and NumPy version is 1.24.3 (installed using pip). Local environment (no virtualenv), terminal, packages installed using brew (no condo/macports).","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-09T16:19:47+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1584840637","fragment_type":"issue_comment","sequence":4,"text":"I tried running the code block above and unfortunately got the following error:\n\nIn file included from ../../utils/cpu_features.c:13:\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n ^\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n../../utils/cpu_features.h:69:10: error: couldn't allocate output register for constraint 'a'\n __asm(\"xgetbv\" : \"=a\"(a),\"=d\"(d) : \"c\"(ctr) : );\n ^\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n ^\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n5 errors generated.\nmake[2]: *** [../../utils/cpu_features.o] Error 1\nmake[1]: *** [DD] Error 2\nmake: *** [theory] Error 2","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-09T16:23:24+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585280800","fragment_type":"issue_comment","sequence":5,"text":"That is odd - those lines of code should never be seen by the compiler *if* the environment variable `__ARM_NEON` is defined - which is supposed to be the case. For reference, I just did a fresh repo clone and tried out my instructions and those worked. I also notice that there is line number mis-match between what I see and what you have reported in the error - is it possible that you accidentally skipped the checkout branch line? There was an error in what I quoted - you should do `git checkout fix-compile-on-apple-soc` (i.e., without the `-b` )\n\nIf you were indeed in the correct branch, will you please report back on the following steps:\n\n- please copy-paste the output generated during the (unsuccessful) compilation process. Should look something like this: \n\nclang -DOUTPUT_RPAVG -DENABLE_MIN_SEP_OPT -DCOPY_PARTICLES -DLINK_IN_DEC -DLINK_IN_RA -DDOUBLE_PREC -DUSE_OMP -DVERSION=\\\"2.5.0\\\" -DUSE_UNICODE -std=c99 -m64 -g -Wsign-compare -Wall -Wextra -Wshadow -Wunused -fPIC -D_POSIX_SOURCE=200809L -D_GNU_SOURCE -D_DARWIN_C_SOURCE -O3 -fopenmp=libomp -funroll-loops -fno-strict-aliasing -Wformat=2 -Wpacked -Wnested-externs -Wpointer-arith -Wredundant-decls -Wfloat-equal -Wcast-qual -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wstrict-prototypes -Wno-unused-local-typedefs -I../../io -I../../utils -I/opt/local/include -I../../mocks/DDrppi_mocks -I../../mocks/DDsmu_mocks -I../../mocks/DDtheta_mocks -I../../mocks/vpf_mocks -c run_correlations_mocks.c -o run_correlations_mocks.o\n\nAnd then, can you please report back on these two things at the command-line:\n- `which ` (where you replace the with whichever compiler that you are using). \n- ` -mcpu=apple-m1 -dM -E - < /dev/null | grep -i ARM`","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-09T23:39:00+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588079981","fragment_type":"issue_comment","sequence":6,"text":"Here is what the output is after the following steps.\nIn terminal, in the ~/Corrfunc directory:\n\n _(1. git clone ) --> already cloned and in the Corrfunc directory_\n 2. git checkout fix-compile-on-apple-soc\n 3. make clean\n 4. make\n\nOutput (in terminal):\n\nIn file included from ../../utils/cpu_features.c:13:\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n ^\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n../../utils/cpu_features.h:69:10: error: couldn't allocate output register for constraint 'a'\n __asm(\"xgetbv\" : \"=a\"(a),\"=d\"(d) : \"c\"(ctr) : );\n ^\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n __asm(\"cpuid\" : \"=a\"(a),\"=b\"(b),\"=c\"(c),\"=d\"(d) : \"a\"(functionnumber),\"c\"(0) );\n ^\n../../utils/cpu_features.h:41:10: error: couldn't allocate output register for constraint 'a'\n5 errors generated.\nmake[2]: *** [../../utils/cpu_features.o] Error 1\nmake[1]: *** [DD] Error 2\nmake: *** [theory] Error 2\nachen@MAC0008879 Corrfunc %","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-12T20:51:51+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588127665","fragment_type":"issue_comment","sequence":7,"text":"Just to confirm: there are *no* matches to the ARM grep command for either of the compilers?","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-12T21:24:54+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588199207","fragment_type":"issue_comment","sequence":8,"text":"Also, what happens if you do make CC=gcc (after a make clean)\n\nWhat’s happening is that the compiler is not supposed to see that chunk of code on ARM, based on a variable usually defined by the compiler. That assumption of defined variable seems to break down on your setup. Since I don’t use brew (macports person) here, I hadn’t encountered this issue before","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-12T22:35:40+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588353950","fragment_type":"issue_comment","sequence":9,"text":"Since @quasars100 probably ran the original instructions with `git checkout -b fix-compile-on-apple-soc`, they probably have a local branch that's not tracking the remote. I think the steps to fix this are:\n\n$ git checkout master\n$ git branch -d fix-compile-on-apple-soc\n$ git checkout fix-compile-on-apple-soc\n\nI think at that point, you'll have a local branch that's tracking the remote, which you can confirm with `git branch -vv` or `git status`. Then hopefully the code will compile.","author_login":"lgarrison","author_association":"COLLABORATOR","created_at":"2023-06-13T01:11:21+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1589494744","fragment_type":"issue_comment","sequence":10,"text":"This seems to be able to run, since the last few lines of output are:\n\nar rcs libcountspheres_mocks.a countspheres_mocks.o countspheres_mocks_impl_float.o countspheres_mocks_impl_double.o ../../utils/gridlink_impl_float.o ../../utils/gridlink_impl_double.o ../../utils/gridlink_utils_float.o ../../utils/gridlink_utils_double.o ../../utils/utils.o ../../utils/progressbar.o ../../utils/cpu_features.o ../../utils/avx512_calls.o ../../utils/set_cosmo_dist.o ../../utils/cosmology_params.o\nmake[2]: Nothing to be done for `lib'.\n/Library/Developer/CommandLineTools/usr/bin/make -C examples\ngcc -DOUTPUT_RPAVG -DENABLE_MIN_SEP_OPT -DCOPY_PARTICLES -DLINK_IN_DEC -DLINK_IN_RA -DDOUBLE_PREC -DUSE_OMP -DVERSION=\\\"2.5.0\\\" -DUSE_UNICODE -std=c99 -m64 -g -Wsign-compare -Wall -Wextra -Wshadow -Wunused -fPIC -D_POSIX_SOURCE=200809L -D_GNU_SOURCE -D_DARWIN_C_SOURCE -O3 -funroll-loops -fno-strict-aliasing -Wformat=2 -Wpacked -Wnested-externs -Wpointer-arith -Wredundant-decls -Wfloat-equal -Wcast-qual -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wstrict-prototypes -Wno-unused-local-typedefs -I../../io -I../../utils -I/opt/homebrew/Cellar/gsl/2.7.1/include -I../../mocks/DDrppi_mocks -I../../mocks/DDsmu_mocks -I../../mocks/DDtheta_mocks -I../../mocks/vpf_mocks -c run_correlations_mocks.c -o run_correlations_mocks.o\ngcc run_correlations_mocks.o ../../io/ftread.o ../../io/io.o ../../utils/utils.o ../../utils/progressbar.o ../../utils/cosmology_params.o ../../mocks/DDrppi_mocks/libcountpairs_rp_pi_mocks.a ../../mocks/DDsmu_mocks/libcountpairs_s_mu_mocks.a ../../mocks/DDtheta_mocks/libcountpairs_theta_mocks.a ../../mocks/vpf_mocks/libcountspheres_mocks.a -lm -L/opt/homebrew/Cellar/gsl/2.7.1/lib -lgsl -lgslcblas -Xlinker -rpath -Xlinker /opt/homebrew/Cellar/gsl/2.7.1/lib -o run_correlations_mocks\nachen@MAC0008879 Corrfunc % \n\nHowever, in the middle, there was the following warning:\n\nIf you want to permanently set the default compiler to gcc for all future compilations, please update the \"CC\" variable in \"common.mk\"\n../common.mk:276: Compiler is Apple clang and does not support OpenMP\nIf you want OpenMP support, please install clang with OpenMP support\nFor homebrew, use \"brew update && (brew outdated xctool || brew upgrade xctool) && brew tap homebrew/versions && brew install clang-omp\"\nFor Macports, use \"sudo port install clang-3.8 +assertions +debug + openmp\"\n../common.mk:320: $CC = gcc does not support OpenMP - please use gcc/icc for compiling with openmp. Removing \"USE_OMP\" from compile options. \nIf you are sure your version of \"clang\" ( must be >= 3.7, NOT Apple clang) does support OpenMP, then comment out the line \"OPT:=$(filter-out -DUSE_OMP,$(OPT))\" in the file \"common.mk\"\nYou might have to add in the include path (path to \"omp.h\") to \"CFLAGS\" and the runtime library path to \"CLINK\" at the top of \"common.mk\"\n/bin/sh: python: command not found\n/bin/sh: python: command not found\n/bin/sh: line 0: [: too many arguments\n/bin/sh: line 0: [: too many arguments\n../common.mk:497: Found python version .. but minimum required python is 2.7 \n../common.mk:502: Found NUMPY version .. but minimum required numpy is 1.7 \n\n-------COMPILE SETTINGS------------\n MAKE = [\"/Library/Developer/CommandLineTools/usr/bin/make\"]\n CC = [\"gcc\"]\n OPT = [\"-DOUTPUT_RPAVG -DENABLE_MIN_SEP_OPT -DCOPY_PARTICLES -DLINK_IN_DEC -DLINK_IN_RA -DDOUBLE_PREC\"]\n CFLAGS = [\"-DVERSION=\\\"2.5.0\\\" -DUSE_UNICODE -std=c99 -m64 -g -Wsign-compare -Wall -Wextra -Wshadow -Wunused -fPIC -D_POSIX_SOURCE=200809L -D_GNU_SOURCE -D_DARWIN_C_SOURCE -O3 -funroll-loops -fno-strict-aliasing -Wformat=2 -Wpacked -Wnested-externs -Wpointer-arith -Wredundant-decls -Wfloat-equal -Wcast-qual -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wstrict-prototypes -Wno-unused-local-typedefs -mcpu=apple-m1 -mtune=apple-m1\"]\n CLINK = [\" -lm\"]\n PYTHON = [\"python\"]\n GSL_CFLAGS = [\"\"]\n GSL_LINK = [\"\"]\n PYTHON_CFLAGS = [\"\"]\n-------END OF COMPILE SETTINGS------------\n\nMakefile:7: Not compiling C extensions for mocks. Either python or numpy not available","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-13T15:04:20+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1589501152","fragment_type":"issue_comment","sequence":11,"text":"However, when I check my python version, it was 3.10, which is > python2.7\n\nachen@MAC0008879 Corrfunc % which python\npython: aliased to /opt/homebrew/bin/python3.10\n\nAnd numpy:\n\nPython 3.10.12 (main, Jun 7 2023, 00:37:42) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n \n \n'1.24.3'\n \n\nwhich is >numpy 1.7.\n\nSorry for how long this issue seems to be, and thank you all again for all your help.","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-13T15:06:52+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1589520305","fragment_type":"issue_comment","sequence":12,"text":"Thank you, and after running these steps, the code did seem to compile, however, this was the end output:\n\nMakefile:7: Not compiling C extensions for mocks. Either python or numpy not available \n/Library/Developer/CommandLineTools/usr/bin/make -C DDrppi_mocks\nmake[2]: Nothing to be done for `all'.\n/Library/Developer/CommandLineTools/usr/bin/make -C DDtheta_mocks\nmake[2]: Nothing to be done for `all'.\n/Library/Developer/CommandLineTools/usr/bin/make -C DDsmu_mocks\nmake[2]: Nothing to be done for `all'.\n/Library/Developer/CommandLineTools/usr/bin/make -C vpf_mocks\nmake[2]: Nothing to be done for `all'.\nfor dir in DDrppi_mocks DDtheta_mocks DDsmu_mocks vpf_mocks examples; do \\\n /Library/Developer/CommandLineTools/usr/bin/make -C $dir lib; \\\n done\nmake[2]: Nothing to be done for `lib'.\nmake[2]: Nothing to be done for `lib'.\nmake[2]: Nothing to be done for `lib'.\nmake[2]: Nothing to be done for `lib'.\nmake[2]: Nothing to be done for `lib'.\n/Library/Developer/CommandLineTools/usr/bin/make -C examples\nmake[2]: Nothing to be done for `all'.\nachen@MAC0008879 Corrfunc % \n\nAlso, when I try calling \"Corrfunc\" in python and using its commands, I get the following error:\n \nTraceback (most recent call last):\n File \"/Users/achen/Corrfunc/Corrfunc/theory/xi.py\", line 187, in xi\n from Corrfunc._countpairs import countpairs_xi as xi_extn\nModuleNotFoundError: No module named 'Corrfunc._countpairs'\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n File \" \", line 1, in \n File \"/Users/achen/Corrfunc/Corrfunc/theory/xi.py\", line 191, in xi\n raise ImportError(msg)\nImportError: Could not import the C extension for the correlation function.\n \n\nThe package does import in python without issue, it's just when I try running the commands they don't work. \nThanks again, and sorry for the myriad of issues this seems to have on brew.","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-13T15:14:35+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590196816","fragment_type":"issue_comment","sequence":13,"text":"Hoorrray - that's definitely progress! At least the code seems to be compiling (which I am surprised by, given the lack of the (usually) defined `ARM` variables but I will put that down to a bad `grep` implementation). \n@quasars100 Please don't apologize - you are helping us improve Corrfunc, and that, in turn, helps everyone - so thank you!\n\n@lgarrison Not really sure why `python` is not being detected - the detection is simply a shell calling `python`! I see that the output says ` /bin/sh: python: command not found`. My guess is that `python` is defined as an **alias** and, therefore, only available on the interactive terminal (i.e., where @quasars100 is working but not through the non-interactive terminal invoked by `make`). \n@quasars100 What do you get if you try `alias python`? And regardless of the alias status, using `python -m pip install -e . --verbose` should work. Even if `python` is aliased, that specific command should use the correct python. \n\nRelated, I see that OpenMP is not enabled; ideally, that also needs to be fixed. @quasars100 Will you please run `brew install llvm` to install the OpenMP-enabled version of `clang` and then recompile (after `make clean`) by invoking `make` (or equivalently, `make CC=clang`)","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-13T23:38:25+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1590199731","fragment_type":"issue_comment","sequence":14,"text":"@quasars100 To explicitly clarify, as long as `python` and `numpy` is not detected at compile time, the Corrfunc C extensions will **not** be compiled, and therefore, you will not be able to use Corrfunc from python","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-13T23:41:27+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591632534","fragment_type":"issue_comment","sequence":15,"text":"Here is what I get when running \"alias python\" in terminal:\n\nalias python\npython=/opt/homebrew/bin/python3.10\n\n(which python\npython: aliased to /opt/homebrew/bin/python3.10 )\n \n\nSo prior to opening this issue, I actually ran \"brew install llvm\", and that is the version of clang my current clang compiler is aliased to, which is why the warning of \"OpenMP is not available with apple clang\" was confusing, since clang should be aliased away from Apple clang now.\n\nAfter running \"make CC=clang\", OpenMP is enabled, but I still get this error:\n\n/bin/sh: python: command not found\n/bin/sh: python: command not found\n/bin/sh: line 0: [: too many arguments\n/bin/sh: line 0: [: too many arguments\n../common.mk:497: Found python version .. but minimum required python is 2.7 \n../common.mk:502: Found NUMPY version .. but minimum required numpy is 1.7 \n\nHowever when I check the python version:\n\nwhich python\npython: aliased to /opt/homebrew/bin/python3.10\nachen@MAC0008879 Corrfunc % python\nPython 3.10.12 (main, Jun 7 2023, 00:37:42) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n \n \n'1.24.3'\n\nPython > 2.7 and numpy > 1.7. Do you know if this is something to be changed in \"common.mk\" or my local environment?\n\nThank you again so much for all your help!","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-14T16:43:31+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591898192","fragment_type":"issue_comment","sequence":16,"text":"Ohh good - so python *is* defined as an alias. No wonder `make` can't find python.\n\nTry and run `export CC=clang && python -m pip install -e .` - that should do the trick","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-14T20:04:36+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591967653","fragment_type":"issue_comment","sequence":17,"text":"Yes, that worked! (Has to be in the Corrfunc cloned directory though).\nThank you so much!","author_login":"quasars100","author_association":"NONE","created_at":"2023-06-14T20:51:46+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1592160329","fragment_type":"issue_comment","sequence":18,"text":"Great - glad this all worked :)! Can you confirm that you have OpenMP support, i.e., that you can use multiple threads now?\n\nSidenote: The reason why you were facing the compilation and non-detection of `llvm-clang/python/numpy` is all because you (or `homebrew`) have the relevant aliases set. The aliases work fine for you since you are always accessing from an interactive terminal - i.e., a terminal where you can send keyboard input to. The shell sessions spawned by `common.mk` are non-interactive and, therefore, **do not** know about the aliases. \n\nI also suspect your `PATH` variable does not contain `/opt/homebrew/bin` (for `llvm-clang`) ahead of `/usr/bin` (for `apple-clang`), and thus, when the non-interactive shell resolves `clang` as `/usr/bin/clang`. Since I don't use `homebrew`, I am unsure if it is an intentional design that `/opt/homebrew/bin` is not added to your `PATH` environment variable. If you ever run into such odd issues of not-detecting-the-correct-tool, then it might be worthwhile adding the full path to whichever tool that you are wanting to detect (or equivalently, add `/opt/homebrew/bin` to `PATH` either in the terminal you are working in, or in the startup shell file - `.bashrc/.zshrc` etc)","author_login":"manodeep","author_association":"OWNER","created_at":"2023-06-15T00:28:57+08:00","repo_name":"manodeep/Corrfunc","issue_id":1748201512,"issue_number":294,"issue_url":"https://github.com/manodeep/Corrfunc/issues/294","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0270","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Not downloading raindrop data after 3000 and crashes?","query_context":"This is the error shows after the crash. I only paste Test API key from raindrop\n\nOS: MacOS\nInstallation: Brew","known_context_document_ids":["gh_issue_2780599674"],"reference_answer":"Despite what the documentation says, it looks like there isn't a `X-RateLimit-Reset` header (or any of the other headers) when there's a 429. Instead you get a `Retry-After`.","answer_document_id":"gh_comment_2584033870","silver_evidence_path":["gh_comment_2583214823","gh_issue_2767868475","gh_comment_2584033870"],"evidence_issue_ids":[2780599674,2767868475],"source_repo_name":"davep/braindrop","source_issue_id":2780599674,"source_issue_number":72,"source_issue_url":"https://github.com/davep/braindrop/issues/72","target_repo_name":"davep/braindrop","target_issue_id":2767868475,"target_issue_number":22,"target_issue_url":"https://github.com/davep/braindrop/issues/22","reference_anchor_document_id":"gh_comment_2583214823","reference_answer_author":"davep","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1875,"anchor_target_overlap":0.1739,"target_answer_overlap":0.1538},"issue_created_at":"2025-01-10T16:32:46+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2780599674","fragment_type":"issue_description","sequence":0,"text":"Not downloading raindrop data after 3000 and crashes\nThis is the error shows after the crash. I only paste Test API key from raindrop\n\nOS: MacOS\nInstallation: Brew","author_login":"aoksan","author_association":"NONE","created_at":"2025-01-10T16:32:46+08:00","repo_name":"davep/braindrop","issue_id":2780599674,"issue_number":72,"issue_url":"https://github.com/davep/braindrop/issues/72","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2583214823","fragment_type":"issue_comment","sequence":1,"text":"Thanks @aoksan. I've been anticipating this but haven't been in a position to create it for myself. It's pretty much what #22 has in mind, to some degree.\n\nLong story short: the code that uses the API to download the raindrop data is far too straightforward at the moment, and will need some backoff handling adding.\n\nNow that I know there's someone seeing this sort of thing I'll try and make addressing this a priority (until now I've been concentrating more on the UI side of things; the API side of things needs some attention).","author_login":"davep","author_association":"OWNER","created_at":"2025-01-10T16:39:13+08:00","repo_name":"davep/braindrop","issue_id":2780599674,"issue_number":72,"issue_url":"https://github.com/davep/braindrop/issues/72","linked_issue_ids":[2767868475],"is_known_query_context":false},{"document_id":"gh_comment_2584644755","fragment_type":"issue_comment","sequence":2,"text":"@davep I’d be happy to test the code before the release! Let me know when you have the test version ready, and I’ll give it a try when I free.","author_login":"aoksan","author_association":"NONE","created_at":"2025-01-10T22:50:20+08:00","repo_name":"davep/braindrop","issue_id":2780599674,"issue_number":72,"issue_url":"https://github.com/davep/braindrop/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584655552","fragment_type":"issue_comment","sequence":3,"text":"Awesome, thanks. Depending on what works best for you you'll find the update in this PR or the `throttle-download` branch.","author_login":"davep","author_association":"OWNER","created_at":"2025-01-10T22:52:48+08:00","repo_name":"davep/braindrop","issue_id":2780599674,"issue_number":72,"issue_url":"https://github.com/davep/braindrop/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584929407","fragment_type":"issue_comment","sequence":4,"text":"The script is worked. First downloaded up to 2975 bookmarks, paused to wait for Raindrop, and then resumed downloading. A total of 4200 bookmarks were downloaded.","author_login":"aoksan","author_association":"NONE","created_at":"2025-01-10T23:53:15+08:00","repo_name":"davep/braindrop","issue_id":2780599674,"issue_number":72,"issue_url":"https://github.com/davep/braindrop/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584930399","fragment_type":"issue_comment","sequence":5,"text":"Excellent! Thanks for testing that. Hopefully tomorrow then I'll roll out a proper release.","author_login":"davep","author_association":"OWNER","created_at":"2025-01-10T23:54:54+08:00","repo_name":"davep/braindrop","issue_id":2780599674,"issue_number":72,"issue_url":"https://github.com/davep/braindrop/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2767868475","fragment_type":"issue_description","sequence":0,"text":"Consider making the full download a little less aggressive\nRight now the full download of all Raindrop data goes pretty hard. So far raindrop.io isn't complaining, and also it shouldn't happen too often if you're mostly using the Braindrop itself[^1].\n\nLook at ensuring that the download code observes any throttling, and perhaps also provide a method of interrupting a download.\n\n[^1]: Little less the case if you're a Pro user as Raindrop will do broken link scanning, etc, which will cause changes on the server that will trigger a fresh download the next time you run up the application.","author_login":"davep","author_association":"OWNER","created_at":"2025-01-03T16:41:37+08:00","repo_name":"davep/braindrop","issue_id":2767868475,"issue_number":22,"issue_url":"https://github.com/davep/braindrop/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2583266270","fragment_type":"issue_comment","sequence":1,"text":"Note the rate limits for the Raindrop API: URL \n\nIt does say:\n \n\nwhich would suggest that Raindrop wouldn't be subject to this because it's not using OAuth; but I suspect this is awkward wording and the same limits apply to calls using the test token too.\n\nIt's also worth noting that 120 requests per minute, given the scenario written about in #72, would mean it would take at least 30 seconds to download those 3,000 raindrops. It might be worth looking at estimating the number of pages that need downloading, calculating any pause that needs to be used based on that, and also letting the user know how long they can expect to wait (ish -- there's also the issue of download speed and stuff, of course).\n\nIt might make more sense to work around these headers:\n\nX-RateLimit-Limit\nX-RateLimit-Remaining\nX-RateLimit-Reset","author_login":"davep","author_association":"OWNER","created_at":"2025-01-10T16:58:28+08:00","repo_name":"davep/braindrop","issue_id":2767868475,"issue_number":22,"issue_url":"https://github.com/davep/braindrop/issues/22","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584033870","fragment_type":"issue_comment","sequence":2,"text":"Despite what the documentation says, it looks like there isn't a `X-RateLimit-Reset` header (or any of the other headers) when there's a 429. Instead you get a `Retry-After`.","author_login":"davep","author_association":"OWNER","created_at":"2025-01-10T20:29:51+08:00","repo_name":"davep/braindrop","issue_id":2767868475,"issue_number":22,"issue_url":"https://github.com/davep/braindrop/issues/22","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0271","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Adding Jupyter Notebook causes disconnect from remote server?","query_context":"Type: Bug \n\nWhen ssh-ed into a node, I can run files & use the terminal normally.\n\nHowever, when I add a new jupyter notebook, it shows the \"setting up ssh...\" notification, then disconnects from the server. \n\nThis does not happen when I add a new text file or python file, so maybe an extension. \n\nVS Code version: Code 1.83.1 (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:48:05.904Z)\nOS version: Windows_NT x64 10.0.22621\nModes:\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled|\n|Load (avg)|undefined|\n|Memory (System)|15.77GB (2.81GB free)|\n|Process Argv|--crash-reporter-id 85b6318c-39aa-4637-93f5-fc2aac3f163d|\n|Screen Reader|no|\n|VM|0%|\n\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\n\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\n Extensions: none \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383cf:30185419\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\nvserr242cf:30382550\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263:30335439\nvscorecescf:30445987\nvscod805cf:30301675\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\nvsaa593cf:30376535\npythonvs932:30410667\npy29gd2263:30856252\nvsclangdf:30486550\nc4g48928:30535728\ndsvsc012:30540252\npynewext54:30695312\nazure-dev_surveyone:30548225\n2e4cg342:30602488\nf6dab269:30613381\nshowlangstatbar:30737416\n962ge761:30841074\n03d35959:30757346\npythonfmttext:30731395\nfixshowwlkth:30771522\nshowindicator:30805244\npythongtdpath:30769146\ni26e3531:30792625\ngsofa:30866041\npythonnosmt12:30797651\npythonidxpt:30866567\npythonnoceb:30805159\ncopilotsettingc:30859502\nasynctok:30821568\ndsvsc013:30795093\ndsvsc014:30804076\ndiffeditorv2:30821572\ndsvsc015:30845448\npythontestfixt:30866405\npyreplss1:30865275\npythoncet0:30866520\nh48ei257:30867296\npythontbext0:30864172","known_context_document_ids":["gh_issue_1954415933"],"reference_answer":"We figured out it was caused by Pylance extension killing the remote extension host process (see details in URL The Pylance team has fixed this issue in Prerelease and it working on a recovery release for stable. To mitigate/workaround this issue before the fix lands:\n\n* Open an empty Remote SSH window (Remote indicator -> Connect to Host ... -> Pick the remote)\n* Downgrade the Pylance extension to previous version (a week ago) or disable it for now\n\nWe will keep you posted once there is a new Pylance release.","answer_document_id":"gh_comment_1773202568","silver_evidence_path":["gh_comment_1773153239","gh_issue_1943004800","gh_comment_1773202568"],"evidence_issue_ids":[1954415933,1943004800],"source_repo_name":"microsoft/vscode","source_issue_id":1954415933,"source_issue_number":196089,"source_issue_url":"https://github.com/microsoft/vscode/issues/196089","target_repo_name":"microsoft/vscode","target_issue_id":1943004800,"target_issue_number":195617,"target_issue_url":"https://github.com/microsoft/vscode/issues/195617","reference_anchor_document_id":"gh_comment_1773153239","reference_answer_author":"rebornix","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.375,"target_answer_overlap":0.1429},"issue_created_at":"2023-10-20T14:31:12+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1954415933","fragment_type":"issue_description","sequence":0,"text":"Adding Jupyter Notebook causes disconnect from remote server\nType: Bug \n\nWhen ssh-ed into a node, I can run files & use the terminal normally.\n\nHowever, when I add a new jupyter notebook, it shows the \"setting up ssh...\" notification, then disconnects from the server. \n\nThis does not happen when I add a new text file or python file, so maybe an extension. \n\nVS Code version: Code 1.83.1 (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:48:05.904Z)\nOS version: Windows_NT x64 10.0.22621\nModes:\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled|\n|Load (avg)|undefined|\n|Memory (System)|15.77GB (2.81GB free)|\n|Process Argv|--crash-reporter-id 85b6318c-39aa-4637-93f5-fc2aac3f163d|\n|Screen Reader|no|\n|VM|0%|\n\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\n\nConnection to 'SSH: 209.137.198.14' could not be established Canceled\n Extensions: none \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383cf:30185419\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\nvserr242cf:30382550\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263:30335439\nvscorecescf:30445987\nvscod805cf:30301675\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\nvsaa593cf:30376535\npythonvs932:30410667\npy29gd2263:30856252\nvsclangdf:30486550\nc4g48928:30535728\ndsvsc012:30540252\npynewext54:30695312\nazure-dev_surveyone:30548225\n2e4cg342:30602488\nf6dab269:30613381\nshowlangstatbar:30737416\n962ge761:30841074\n03d35959:30757346\npythonfmttext:30731395\nfixshowwlkth:30771522\nshowindicator:30805244\npythongtdpath:30769146\ni26e3531:30792625\ngsofa:30866041\npythonnosmt12:30797651\npythonidxpt:30866567\npythonnoceb:30805159\ncopilotsettingc:30859502\nasynctok:30821568\ndsvsc013:30795093\ndsvsc014:30804076\ndiffeditorv2:30821572\ndsvsc015:30845448\npythontestfixt:30866405\npyreplss1:30865275\npythoncet0:30866520\nh48ei257:30867296\npythontbext0:30864172","author_login":"loganriggs","author_association":"NONE","created_at":"2023-10-20T14:31:12+08:00","repo_name":"microsoft/vscode","issue_id":1954415933,"issue_number":196089,"issue_url":"https://github.com/microsoft/vscode/issues/196089","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1772958876","fragment_type":"issue_comment","sequence":1,"text":"I'm having this exact same issue, also when ssh-ed in. I can also execute the notebook through code - it's only when it's brought up on the VSCode UI that the disconnect occurs.","author_login":"itrase","author_association":"NONE","created_at":"2023-10-20T15:30:19+08:00","repo_name":"microsoft/vscode","issue_id":1954415933,"issue_number":196089,"issue_url":"https://github.com/microsoft/vscode/issues/196089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773153239","fragment_type":"issue_comment","sequence":2,"text":"This is a duplicate of URL and we are working on a fix now. Let's track this in URL thank you!","author_login":"rebornix","author_association":"MEMBER","created_at":"2023-10-20T17:49:58+08:00","repo_name":"microsoft/vscode","issue_id":1954415933,"issue_number":196089,"issue_url":"https://github.com/microsoft/vscode/issues/196089","linked_issue_ids":[1943004800],"is_known_query_context":false},{"document_id":"gh_issue_1943004800","fragment_type":"issue_description","sequence":0,"text":"Remote SSH Connection Crashed after openning a Jupyter Notebook on the remote server\nDoes this issue occur when all extensions are disabled?: No\n\n \n \n- VS Code Version: 1.83.1\n- OS Version: Windows 11 latest\n\nSteps to Reproduce:\n\n1. Open up a remote ssh connection to a remote server\n2. Open a Jupyter Notebook stored on that remote server. It can be a brand new Notebook or something already existed.\n3. VSCode crashed with \"Cannot reconnect. Please reload the window.\"\n\nIt could be a problem with VSCode, or the Python / Jupyter extension. This did not happen with VSCode 1.83.0 so something in the update could have messed things up.","author_login":"ductai199x","author_association":"NONE","created_at":"2023-10-14T06:13:11+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1769732538","fragment_type":"issue_comment","sequence":1,"text":"Same issue here. I've found that some workspaces (such as selecting the parent directory) appears to avoid the issue. The \"Cannot reconnect. Please reload the window.\" error only occurs when you actually select a kernel. I don't have any .vscode configuration in either of these workspaces, so I'm not really sure what the issue is.","author_login":"nathanmargaglio","author_association":"NONE","created_at":"2023-10-19T01:09:32+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771297840","fragment_type":"issue_comment","sequence":2,"text":"After downgrading to VSCode 1.83.0, I'm still facing the same issue","author_login":"vishu-tyagi","author_association":"NONE","created_at":"2023-10-19T16:07:07+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771303874","fragment_type":"issue_comment","sequence":3,"text":"You need to first remove the .vscode_server folder on the remote server, then reinstall vscode on your local computer with the older version, and then reinstall the extensions on remote server (Python, Jupyter, etc.). The problems go away after I did these steps","author_login":"ductai199x","author_association":"NONE","created_at":"2023-10-19T16:10:12+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771434115","fragment_type":"issue_comment","sequence":4,"text":"I'm seeing the same problem when connecting to Remote-SSH as well as WSL. occurs in both \"code\" and \"code-insiders\" (from MS App Store). Specifically occurs for me when attempting to \"Select Kernel\".","author_login":"edsealing","author_association":"NONE","created_at":"2023-10-19T17:37:04+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772279639","fragment_type":"issue_comment","sequence":5,"text":"I just encountered the same issue. When I was selecting the Jupyter kernel, the SSH connection began to disconnect. At the same time, I noticed through the 'htop' command in the terminal that the CPU usage began to spike significantly as the SSH connection was interrupted.","author_login":"watchwater","author_association":"NONE","created_at":"2023-10-20T08:10:55+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772292307","fragment_type":"issue_comment","sequence":6,"text":"I have the same problem since yesterday. I can work on other files via vscode ssh connection. However, when I open any Jupyter notebook, it asks for the password again and the connection times out.","author_login":"tubagundem","author_association":"NONE","created_at":"2023-10-20T08:20:12+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772492019","fragment_type":"issue_comment","sequence":7,"text":"Same issue here, specifically when saving-as a new notebook created with the \"Create: New Jupyter Notebook\" shortcut. Breaks my connection to WSL in every open window. Only quick fix I've found is to restart VSCode entirely","author_login":"jack-tobin","author_association":"NONE","created_at":"2023-10-20T10:29:54+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772573505","fragment_type":"issue_comment","sequence":8,"text":"Have the same problem, but neither reloading, nor reinstall made any impact.","author_login":"AndrewGrishin","author_association":"NONE","created_at":"2023-10-20T11:33:52+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772827974","fragment_type":"issue_comment","sequence":9,"text":"Discovered the solution that worked for me (**local**: macOS Ventura 13.6, M1, **remote server**: Ubuntu 22.04.3 LTS x86_64).\n\n1. Backup `settings.json` (if you've made any local configurations).\n2. Close VS Code locally and remotely.\n3. Completely delete VS Code from your local machine via steps in #42603103.\n4. Deleted VS Code server from your remote server via:\n- `sudo apt purge code` (deleted VS Code from your remote server)\n- `rm -rf .vscode-server` (delete VS Code server folder from your `$HOME` directory)\n- `sudo apt autoremove` (delete everything that have not been previously deleted including all dependencies of VS code)\n!!**NOTE**!! use this command carefully as it will erase all dependencies that have not been deleted previously from your system.\n- _`rm -rf .ipython`_ (perhaps this command is not required, but I executed it in the pipeline) \n5. Download version of July 2023 (version 1.81) on your local machine.\n6. !!**Disable**!! as VS code make autoupdates in background #50162685.\n7. Configure clean VS code as new one (copy `settings.json`, install required extensions, etc.)\n8. Establish remote connection with your remote server via ssh from VS Code toolkit.\n9. Install all extensions that are required on your remote server.\n\nAgain, this solution worked for me, but I cannot assure that it will work for all mac users.","author_login":"AndrewGrishin","author_association":"NONE","created_at":"2023-10-20T14:19:03+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772849152","fragment_type":"issue_comment","sequence":10,"text":"Yep, similar to my solution on windows or linux above. The important thing is to delete the .vscode_server folder from remote and uninstall local 1.83.1 vscode, then downgrade to 1.83.0 and reinstall everything on remote. It sucked because I have to use about 10 remote servers daily.","author_login":"ductai199x","author_association":"NONE","created_at":"2023-10-20T14:29:38+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773013261","fragment_type":"issue_comment","sequence":11,"text":"This is also happening on version 1.82.2 on a remote connection to a Ubuntu 22.04 host.\n\n- Open ipynb with extensions disabled -> fine\n- Open ipynb with extensions enabled -> Crashes right after activating extensions, before even selecting kernel\n- Have tried deleting all extensions and reinstalling them, worked shortly at one point but then started crashing again","author_login":"jzyrobert","author_association":"CONTRIBUTOR","created_at":"2023-10-20T16:07:44+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773202568","fragment_type":"issue_comment","sequence":12,"text":"We figured out it was caused by Pylance extension killing the remote extension host process (see details in URL The Pylance team has fixed this issue in Prerelease and it working on a recovery release for stable. To mitigate/workaround this issue before the fix lands:\n\n* Open an empty Remote SSH window (Remote indicator -> Connect to Host ... -> Pick the remote)\n* Downgrade the Pylance extension to previous version (a week ago) or disable it for now\n\nWe will keep you posted once there is a new Pylance release.","author_login":"rebornix","author_association":"MEMBER","created_at":"2023-10-20T18:26:27+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1780325282","fragment_type":"issue_comment","sequence":13,"text":"My solution is downgrading the jupyter extention to v2023.10.1002931100 (but I dont know my last jupyter version, just downloaded the second version from vscode office website), that works for me.","author_login":"BigodF","author_association":"NONE","created_at":"2023-10-26T02:38:18+08:00","repo_name":"microsoft/vscode","issue_id":1943004800,"issue_number":195617,"issue_url":"https://github.com/microsoft/vscode/issues/195617","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0272","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Weird notification if local jdk is specified?","query_context":"Greetings,\n\nWhen I'm tying to spec path to local jdk installation, everytime, when I autocomplete code, bunch of notifications pop up, like in screenshot below. Also listing configuration script, maybe there is some misconfiguration\n\nlua\nreturn {\n \"nvim-java/nvim-java\",\n config = false,\n dependencies = {\n {\n \"neovim/nvim-lspconfig\",\n opts = {\n servers = {\n jdtls = {\n settings = {\n java = {\n runtimes = {\n name = \"JavaSE-21\",\n path = \"~/Library/Java/JavaVirtualMachines/corretto-21.0.5/Contents/Home\",\n },\n },\n },\n },\n },\n setup = {\n jdtls = function()\n require(\"java\").setup({\n jdk = {\n auto_install = false,\n },\n })\n end,\n },\n },\n },\n },\n}","known_context_document_ids":["gh_issue_3045694867"],"reference_answer":"You can also tryout following with docker & devcontainer and compare your local setup to figure out what's wrong.\n URL","answer_document_id":"gh_comment_2428110123","silver_evidence_path":["gh_comment_3168356395","gh_issue_2479548965","gh_comment_2428110123"],"evidence_issue_ids":[3045694867,2479548965],"source_repo_name":"nvim-java/nvim-java","source_issue_id":3045694867,"source_issue_number":375,"source_issue_url":"https://github.com/nvim-java/nvim-java/issues/375","target_repo_name":"nvim-java/nvim-java","target_issue_id":2479548965,"target_issue_number":293,"target_issue_url":"https://github.com/nvim-java/nvim-java/issues/293","reference_anchor_document_id":"gh_comment_3168356395","reference_answer_author":"s1n7ax","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.7273,"anchor_target_overlap":0.4545,"target_answer_overlap":0.2},"issue_created_at":"2025-05-07T11:46:29+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_3045694867","fragment_type":"issue_description","sequence":0,"text":"Weird notification if local jdk is specified\nGreetings,\n\nWhen I'm tying to spec path to local jdk installation, everytime, when I autocomplete code, bunch of notifications pop up, like in screenshot below. Also listing configuration script, maybe there is some misconfiguration\n\nlua\nreturn {\n \"nvim-java/nvim-java\",\n config = false,\n dependencies = {\n {\n \"neovim/nvim-lspconfig\",\n opts = {\n servers = {\n jdtls = {\n settings = {\n java = {\n runtimes = {\n name = \"JavaSE-21\",\n path = \"~/Library/Java/JavaVirtualMachines/corretto-21.0.5/Contents/Home\",\n },\n },\n },\n },\n },\n setup = {\n jdtls = function()\n require(\"java\").setup({\n jdk = {\n auto_install = false,\n },\n })\n end,\n },\n },\n },\n },\n}","author_login":"gastonlagaf","author_association":"NONE","created_at":"2025-05-07T11:46:29+08:00","repo_name":"nvim-java/nvim-java","issue_id":3045694867,"issue_number":375,"issue_url":"https://github.com/nvim-java/nvim-java/issues/375","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2888578544","fragment_type":"issue_comment","sequence":1,"text":"This looks like something unrlated to nvim-java but jdtls. You could try to find related issues in jdtls project.","author_login":"s1n7ax","author_association":"MEMBER","created_at":"2025-05-17T20:50:11+08:00","repo_name":"nvim-java/nvim-java","issue_id":3045694867,"issue_number":375,"issue_url":"https://github.com/nvim-java/nvim-java/issues/375","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3168356395","fragment_type":"issue_comment","sequence":2,"text":"The problem is:\n\n opts = {\n servers = {\n jdtls = {\n settings = {\n java = {\n runtimes = {\n name = \"JavaSE-21\",\n path = \"~/Library/Java/JavaVirtualMachines/corretto-21.0.5/Contents/Home\",\n },\n },\n },\n },\n },\n\nPass the jdtls table to nvim-java setup and delete opts = {...} altogether.\n\nDuplicate of #293","author_login":"logrusx","author_association":"CONTRIBUTOR","created_at":"2025-08-08T15:45:46+08:00","repo_name":"nvim-java/nvim-java","issue_id":3045694867,"issue_number":375,"issue_url":"https://github.com/nvim-java/nvim-java/issues/375","linked_issue_ids":[2479548965],"is_known_query_context":false},{"document_id":"gh_comment_3269435782","fragment_type":"issue_comment","sequence":3,"text":"I haven't been clear and maybe I have been partially wrong.\nLet me clarify:\nPassing opts to nvim-lspconfig causes it to setup jdtls before nvim-java. Remove it but take the jdtls part and pass it to jdtls setup after nvim-java has setup. Like that:\n\nlua\n require('java').setup {\n -- Your custom jdtls settings goes here\n jdk = {\n auto_install = false\n },\n }\n\n require('lspconfig').jdtls.setup {\n -- Your custom nvim-java configuration goes here\n\n settings = {\n java = {\n...\n\nI'm not sure what you mean by following the documentation but some things are not obvious like the order in which plugins get setup depending on how you structure your configuration. Nvim-java is picky about that. It needs mason setup before it gets setup and also it needs to be setup before jdtls is setup.\n\nFor reference, take the URL starter project configuration.","author_login":"logrusx","author_association":"CONTRIBUTOR","created_at":"2025-09-09T08:08:10+08:00","repo_name":"nvim-java/nvim-java","issue_id":3045694867,"issue_number":375,"issue_url":"https://github.com/nvim-java/nvim-java/issues/375","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3269672941","fragment_type":"issue_comment","sequence":4,"text":"Thanks\nI understand my mistake : starting from kickstart.nvim, I created a custom/plugins/java.lua file because I did not want to modify the init.lua file.\nWith those .setup in the init.lua file everything is fine. I keep the java.lua file for keymaps but not setup.\nThanks again.","author_login":"lgranie","author_association":"NONE","created_at":"2025-09-09T09:11:28+08:00","repo_name":"nvim-java/nvim-java","issue_id":3045694867,"issue_number":375,"issue_url":"https://github.com/nvim-java/nvim-java/issues/375","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2479548965","fragment_type":"issue_description","sequence":0,"text":"bug: No delegateCommandHandler for vscode.java.test.findTestTypesAndMethods\n### Did you check docs and existing issues?\n\n- [X] I have read all the plugin docs\n- [X] I have searched the existing issues\n- [X] I have searched the existing issues of plugins related to this issue\n\n### Neovim version (nvim -v)\n\nv0.10.1\n\n### Operating system/version\n\nMacOS 14.4.1\n\n### Describe the bug\n\nI have an installation of nvim-java as follows -\n\n{\n \"nvim-java/nvim-java\",\n dependencies = {\n \"neovim/nvim-lspconfig\",\n 'nvim-java/lua-async-await',\n 'nvim-java/nvim-java-refactor',\n 'nvim-java/nvim-java-core',\n 'nvim-java/nvim-java-test',\n 'nvim-java/nvim-java-dap',\n 'MunifTanjim/nui.nvim',\n 'neovim/nvim-lspconfig',\n 'mfussenegger/nvim-dap',\n {\n 'JavaHello/spring-boot.nvim',\n commit = '218c0c26c14d99feca778e4d13f5ec3e8b1b60f0',\n },\n {\n 'williamboman/mason.nvim',\n opts = {\n registries = {\n 'github:nvim-java/mason-registry',\n 'github:mason-org/mason-registry',\n },\n },\n },\n opts = {\n servers = {\n jdtls = {\n settings = {\n java = {\n configuration = {\n runtimes = {\n {\n name = \"JavaSE-17\",\n path = \"/opt/homebrew/opt/openjdk@17/bin/java\",\n default = true\n },\n {\n name = \"JavaSE-11\",\n path = \"/opt/homebrew/opt/openjdk@11/bin/java\",\n }\n }\n }\n },\n },\n },\n },\n setup = {\n jdtls = function()\n require(\"java\").setup()\n end,\n },\n },\n },\n\nWhen i attempt to run ANY java method provided by the plugin, I get the following error:\n\n 02:25:21 msg_show.lua_error JavaTestRunCurrentClass Error executing vim.schedule lua callback: ...site/pack/lazy/opt/nvim-java/lua/java/handlers/error.lua:28: \nfailed to run the current test class\nRPC[Error] code_name = MethodNotFound, message = \"No delegateCommandHandler for vscode.java.test.findTestTypesAndMethods\"\nstack traceback:\n ...site/pack/lazy/opt/nvim-java/lua/java/handlers/error.lua:18: in function 'error_handler'\n ...ck/lazy/opt/nvim-java-core/lua/java-core/utils/async.lua:32: in function 'callback'\n ...nvim-java-core/lua/java-core/ls/clients/jdtls-client.lua:72: in function 'handler'\n .../neovim/0.10.1/share/nvim/runtime/lua/vim/lsp/client.lua:687: in function ''\n vim/_editor.lua: in function \nstack traceback:\n [C]: in function 'error'\n ...site/pack/lazy/opt/nvim-java/lua/java/handlers/error.lua:28: in function 'error_handler'\n ...ck/lazy/opt/nvim-java-core/lua/java-core/utils/async.lua:32: in function 'callback'\n ...nvim-java-core/lua/java-core/ls/clients/jdtls-client.lua:72: in function 'handler'\n .../neovim/0.10.1/share/nvim/runtime/lua/vim/lsp/client.lua:687: in function ''\n vim/_editor.lua: in function \n\nI have checked and all the plugins have been successfully downloaded, as well as jdtls, java-test and java-debug-adapter.\n\n### Steps To Reproduce\n\n1. Install v2.0.1 of nvim-java\n2. Open java file and attempt to run any of the java commands\n\n### Expected Behavior\n\nExpect to see error described in the bug report.","author_login":"ShouryaRSharma","author_association":"NONE","created_at":"2024-08-22T01:35:03+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308252837","fragment_type":"issue_comment","sequence":1,"text":"I have the same issue but, the error appears also immediately after the \"Configuring DAP\" message.\n\nNeovim version (nvim -v)\nv0.10.1\n\nOperating system/version\nArch Linux","author_login":"vasitzin","author_association":"NONE","created_at":"2024-08-24T09:21:21+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2389729435","fragment_type":"issue_comment","sequence":2,"text":"Any updates along these lines? I started seeing this error in the last 4-5 days.","author_login":"manumoreno","author_association":"NONE","created_at":"2024-10-02T21:30:54+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428108788","fragment_type":"issue_comment","sequence":3,"text":"What are the versions of `java-debug-adapter`, `java-test`, `jdtls` you see in Mason?","author_login":"s1n7ax","author_association":"MEMBER","created_at":"2024-10-22T02:58:56+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2428110123","fragment_type":"issue_comment","sequence":4,"text":"You can also tryout following with docker & devcontainer and compare your local setup to figure out what's wrong.\n URL","author_login":"s1n7ax","author_association":"MEMBER","created_at":"2024-10-22T03:00:29+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2454481336","fragment_type":"issue_comment","sequence":5,"text":"I cloned Kickstart yesterday, applied the changes on these 3 commits and got the same error.","author_login":"erlonbie","author_association":"NONE","created_at":"2024-11-04T11:35:47+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480537812","fragment_type":"issue_comment","sequence":6,"text":"FWIW, I was seeing this error when I had the latest jdtls installed (1.41), upon adding `github:nvim-java/mason-registry` to mason registries it installed the ver.1.37 for me which fixed the issue.","author_login":"radon115","author_association":"NONE","created_at":"2024-11-16T12:02:47+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2480539942","fragment_type":"issue_comment","sequence":7,"text":"I'm also getting the same issue, I can provide details:\n\n### Versions\n**Neovim version**\nv0.10.2\n\n**Operating system/version**\nMacOS Version 15.1\n\n**`java-debug-adapter` version**\n0.58.0\n\n**`java-test` version**\n 0.40.1\nnote: this version seems to be locked, since everytime I try to update it will reinstall this exact version\n\n**`jdtls` version**\nv1.37.0\n\n**JDK version**\nopenjdk version \"17.0.12\" 2024-07-16\nOpenJDK Runtime Environment JBR-17.0.12+1-1087.25-jcef (build 17.0.12+1-b1087.25)\nOpenJDK 64-Bit Server VM JBR-17.0.12+1-1087.25-jcef (build 17.0.12+1-b1087.25, mixed mode)\n\nI use kickstart.nvim, with similar setup as above but simpler:\n\n {\n 'nvim-java/nvim-java',\n config = function()\n require('java').setup {\n java_debug_adapter = {\n enable = false,\n },\n }\n end,\n },\n {\n 'neovim/nvim-lspconfig',\n config = function()\n local servers = {\n jdtls = {},\n }\n\n require('mason').setup()\n\n local ensure_installed = vim.tbl_keys(servers or {})\n vim.list_extend(ensure_installed, {\n 'stylua', -- Used to format lua code\n })\n require('mason-tool-installer').setup { ensure_installed = ensure_installed }\n\n require('mason-lspconfig').setup {\n handlers = {\n function(server_name)\n local server = servers[server_name] or {}\n server.capabilities = vim.tbl_deep_extend('force', {}, capabilities, server.capabilities or {})\n require('lspconfig')[server_name].setup(server)\n end,\n },\n }\n end\n }\n\nI got this error on opening a java file, even though I already disabled the DAP\n\n# result from :messages\nError executing vim.schedule lua callback: ...al/share/nvim/lazy/nvim-java/lua/java/handlers/error.lua:28:\ndap configuration failed\nRPC[Error] code_name = MethodNotFound, message = \"No delegateCommandHandler for vscode.java.resolveMainClass\"\nstack traceback:\n ...al/share/nvim/lazy/nvim-java/lua/java/handlers/error.lua:18: in function 'error_handler'\n ...e/nvim/lazy/nvim-java-core/lua/java-core/utils/async.lua:32: in function 'callback'\n ...nvim-java-core/lua/java-core/ls/clients/jdtls-client.lua:72: in function 'handler'\n ...eovim/0.10.2_1/share/nvim/runtime/lua/vim/lsp/client.lua:687: in function ''\n vim/_editor.lua: in function \n\nHope this clarifies.","author_login":"adibfarrasy","author_association":"NONE","created_at":"2024-11-16T12:10:21+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3165583904","fragment_type":"issue_comment","sequence":8,"text":"Can confirm that this issue still exists after updating to `nvim-java 3.0.0`. Here is my config.","author_login":"chenxin-yan","author_association":"NONE","created_at":"2025-08-07T20:16:48+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3166464539","fragment_type":"issue_comment","sequence":9,"text":"Can you provide details about your system as provided in the post above yours please?","author_login":"logrusx","author_association":"CONTRIBUTOR","created_at":"2025-08-08T03:42:15+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3166530699","fragment_type":"issue_comment","sequence":10,"text":"That's insufficient. Please look at the post and provide same details.","author_login":"logrusx","author_association":"CONTRIBUTOR","created_at":"2025-08-08T04:28:53+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3166719382","fragment_type":"issue_comment","sequence":11,"text":"Can you try with the handlers in you jdtls setup contented? \n\nI have done recollection about that being changed in Mason.","author_login":"logrusx","author_association":"CONTRIBUTOR","created_at":"2025-08-08T06:27:14+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3168252605","fragment_type":"issue_comment","sequence":12,"text":"@ShouryaRSharma this is essentially misplaced:\n\nopts = {\n servers = {\n jdtls = {\n settings = {\n java = {\n configuration = {\n runtimes = {\n {\n name = \"JavaSE-17\",\n path = \"/opt/homebrew/opt/openjdk@17/bin/java\",\n default = true\n },\n {\n name = \"JavaSE-11\",\n path = \"/opt/homebrew/opt/openjdk@11/bin/java\",\n }\n }\n }\n },\n },\n },\n },\n setup = {\n jdtls = function()\n require(\"java\").setup()\n end,\n },\n}\n\nThe jdtls table should be passed to nvim-java setup.\n\n@s1n7ax, I'm addressing you since OP is not likely to show up. This issue is a configuration issue and should be closed.","author_login":"logrusx","author_association":"CONTRIBUTOR","created_at":"2025-08-08T15:08:05+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3235219282","fragment_type":"issue_comment","sequence":13,"text":"I’m still getting the same error, even though my config looks a little different. I think it’s essentially the same setup.\n\njava.lua\n\nreturn {\n \"nvim-java/nvim-java\",\n config = function()\n require(\"java\").setup()\n end,\n dependencies = {\n \"neovim/nvim-lspconfig\",\n },\n}\n\nlsp.lua\n\nreturn {\n \"neovim/nvim-lspconfig\",\n dependencies = {\n \"stevearc/conform.nvim\",\n \"williamboman/mason.nvim\",\n \"williamboman/mason-lspconfig.nvim\",\n \"hrsh7th/cmp-nvim-lsp\",\n \"hrsh7th/cmp-buffer\",\n \"hrsh7th/cmp-path\",\n \"hrsh7th/cmp-cmdline\",\n \"hrsh7th/nvim-cmp\",\n \"L3MON4D3/LuaSnip\",\n \"saadparwaiz1/cmp_luasnip\",\n \"j-hui/fidget.nvim\",\n },\n\n config = function()\n local cmp = require(\"cmp\")\n local cmp_lsp = require(\"cmp_nvim_lsp\")\n local capabilities = vim.tbl_deep_extend(\n \"force\",\n {},\n vim.lsp.protocol.make_client_capabilities(),\n cmp_lsp.default_capabilities()\n )\n\n require(\"fidget\").setup({})\n require(\"mason\").setup()\n require(\"mason-lspconfig\").setup({\n automatic_enable = {\n exclude = {\n -- \"jdtls\",\n },\n },\n ensure_installed = {\n \"lua_ls\",\n \"rust_analyzer\",\n \"gopls\",\n \"tailwindcss\",\n },\n\n handlers = {\n function(server_name) -- default handler (optional)\n require(\"lspconfig\")[server_name].setup({\n capabilities = capabilities,\n })\n end,\n\n zls = function()\n local lspconfig = require(\"lspconfig\")\n lspconfig.zls.setup({\n root_dir = lspconfig.util.root_pattern(\".git\", \"build.zig\", \"zls.json\"),\n settings = {\n zls = {\n enable_inlay_hints = true,\n enable_snippets = true,\n warn_style = true,\n },\n },\n })\n vim.g.zig_fmt_parse_errors = 0\n vim.g.zig_fmt_autosave = 0\n end,\n -- [\"jdtls\"] = function()\n -- local lspconfig = require(\"lspconfig\")\n -- lspconfig.jdtls.setup({\n -- capabilities = capabilities,\n -- })\n -- end,\n [\"lua_ls\"] = function()\n local lspconfig = require(\"lspconfig\")\n lspconfig.lua_ls.setup({\n capabilities = capabilities,\n settings = {\n Lua = {\n format = {\n enable = true,\n -- Put format options here\n -- NOTE: the value should be STRING!!\n defaultConfig = {\n indent_style = \"space\",\n indent_size = \"2\",\n },\n },\n },\n },\n })\n end,\n [\"tailwindcss\"] = function()\n local lspconfig = require(\"lspconfig\")\n lspconfig.tailwindcss.setup({\n capabilities = capabilities,\n filetypes = {\n \"html\",\n \"css\",\n \"scss\",\n \"javascript\",\n \"javascriptreact\",\n \"typescript\",\n \"typescriptreact\",\n \"vue\",\n \"svelte\",\n },\n settings = {\n tailwindCSS = {\n experimental = {\n classRegex = {\n \"tw`([^`]*)\",\n 'tw=\"([^\"]*)',\n 'tw={\"([^\"}]*)',\n \"tw\\\\.\\\\w+`([^`]*)\",\n \"tw\\\\(.*?\\\\)`([^`]*)\",\n },\n },\n },\n },\n })\n end,\n },\n })\n...\n\nError msg\n\nError executing vim.schedule lua callback: ...al/share/nvim/lazy/nvim-java/lua/java/handlers/error.lua:28:\ndap configuration failed\nRPC[Error] code_name = MethodNotFound, message = \"No delegateCommandHandler for vscode.java.resolveMainClass\"\nstack traceback:\n ...al/share/nvim/lazy/nvim-java/lua/java/handlers/error.lua:18: in function 'error_handler'\n ...e/nvim/lazy/nvim-java-core/lua/java-core/utils/async.lua:32: in function 'callback'\n ...nvim-java-core/lua/java-core/ls/clients/jdtls-client.lua:74: in function 'handler'\n /usr/share/nvim/runtime/lua/vim/lsp/client.lua:682: in function ''\n vim/_editor.lua: in function \nstack traceback:\n [C]: in function 'error'\n ...al/share/nvim/lazy/nvim-java/lua/java/handlers/error.lua:28: in function 'error_handler'\n ...e/nvim/lazy/nvim-java-core/lua/java-core/utils/async.lua:32: in function 'callback'\n ...nvim-java-core/lua/java-core/ls/clients/jdtls-client.lua:74: in function 'handler'\n /usr/share/nvim/runtime/lua/vim/lsp/client.lua:682: in function ''\n vim/_editor.lua: in function \n\nI’ve tried a few different variations of the config. Ultimately, I think the error is coming from mason-lspconfig, but I can’t seem to get it right.","author_login":"twpowers","author_association":"NONE","created_at":"2025-08-28T23:15:52+08:00","repo_name":"nvim-java/nvim-java","issue_id":2479548965,"issue_number":293,"issue_url":"https://github.com/nvim-java/nvim-java/issues/293","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0273","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"syntax error with phpstan starting with 2.6.7?","query_context":"I use phpstan in my project and after the update to 2.6.7 phpstan fails with a \"syntax error\":\n\n 44/44 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%\n\n ------ ---------------------------------------------------------------------- \n Line tests/ApiTest.php \n ------ ---------------------------------------------------------------------- \n Internal error: syntax error, unexpected 'static' (T_STATIC) \n Run PHPStan with --debug option and post the stack trace to: \n URL \n ------ ---------------------------------------------------------------------- \n \n\nThe internal error is (I'm using php 7.4):\n \n\nDoes anyone know how to work around that?","known_context_document_ids":["gh_issue_1092603840"],"reference_answer":"Hi, can you please create a small reproducing repository that shows this problem? Thanks.","answer_document_id":"gh_comment_1014632593","silver_evidence_path":["gh_comment_1014585628","gh_issue_1105903709","gh_comment_1014632593"],"evidence_issue_ids":[1092603840,1105903709],"source_repo_name":"api-platform/core","source_issue_id":1092603840,"source_issue_number":4614,"source_issue_url":"https://github.com/api-platform/core/issues/4614","target_repo_name":"phpstan/phpstan","target_issue_id":1105903709,"target_issue_number":6386,"target_issue_url":"https://github.com/phpstan/phpstan/issues/6386","reference_anchor_document_id":"gh_comment_1014585628","reference_answer_author":"ondrejmirtes","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.625,"target_answer_overlap":0.125},"issue_created_at":"2022-01-03T15:28:16+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1092603840","fragment_type":"issue_description","sequence":0,"text":"syntax error with phpstan starting with 2.6.7\nI use phpstan in my project and after the update to 2.6.7 phpstan fails with a \"syntax error\":\n\n 44/44 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%\n\n ------ ---------------------------------------------------------------------- \n Line tests/ApiTest.php \n ------ ---------------------------------------------------------------------- \n Internal error: syntax error, unexpected 'static' (T_STATIC) \n Run PHPStan with --debug option and post the stack trace to: \n URL \n ------ ---------------------------------------------------------------------- \n \n\nThe internal error is (I'm using php 7.4):\n \n\nDoes anyone know how to work around that?","author_login":"lazka","author_association":"NONE","created_at":"2022-01-03T15:28:16+08:00","repo_name":"api-platform/core","issue_id":1092603840,"issue_number":4614,"issue_url":"https://github.com/api-platform/core/issues/4614","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1014382691","fragment_type":"issue_comment","sequence":1,"text":"hm, maybe api-platform should avoid php8-only syntax until php8 is required?","author_login":"lazka","author_association":"NONE","created_at":"2022-01-17T10:47:32+08:00","repo_name":"api-platform/core","issue_id":1092603840,"issue_number":4614,"issue_url":"https://github.com/api-platform/core/issues/4614","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014398730","fragment_type":"issue_comment","sequence":2,"text":"yeah, but phpstan parses all referenced files anyway and then fails. And phpstan doesn't provide a way to skip files before parsing, only after parsing :(","author_login":"lazka","author_association":"NONE","created_at":"2022-01-17T11:06:49+08:00","repo_name":"api-platform/core","issue_id":1092603840,"issue_number":4614,"issue_url":"https://github.com/api-platform/core/issues/4614","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014406142","fragment_type":"issue_comment","sequence":3,"text":"This is enough to trigger the error:\n\nphp\n<?php\n\ndeclare(strict_types=1);\n\nnamespace App\\Tests;\n\nuse ApiPlatform\\Core\\Bridge\\Symfony\\Bundle\\Test\\ApiTestCase;\nuse ApiPlatform\\Core\\Bridge\\Symfony\\Bundle\\Test\\Client;\n\nclass Test extends ApiTestCase\n{\n protected function setUp(): void\n {\n parent::setUp();\n static::createClient();\n }\n}","author_login":"lazka","author_association":"NONE","created_at":"2022-01-17T11:14:48+08:00","repo_name":"api-platform/core","issue_id":1092603840,"issue_number":4614,"issue_url":"https://github.com/api-platform/core/issues/4614","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014585628","fragment_type":"issue_comment","sequence":4,"text":"Since URL says this is a phpstan issue I've opened a bug report with phpstan: URL","author_login":"lazka","author_association":"NONE","created_at":"2022-01-17T14:11:05+08:00","repo_name":"api-platform/core","issue_id":1092603840,"issue_number":4614,"issue_url":"https://github.com/api-platform/core/issues/4614","linked_issue_ids":[1105903709],"is_known_query_context":false},{"document_id":"gh_comment_1015390229","fragment_type":"issue_comment","sequence":5,"text":"This is going to be fixed in PHPStan 1.4.2 which is going to be released soon.","author_login":"ondrejmirtes","author_association":"NONE","created_at":"2022-01-18T13:01:46+08:00","repo_name":"api-platform/core","issue_id":1092603840,"issue_number":4614,"issue_url":"https://github.com/api-platform/core/issues/4614","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1105903709","fragment_type":"issue_description","sequence":0,"text":"Does not skip code guarded by PHP_VERSION_ID resulting in \"Internal error: syntax error\"\n# Bug report\n\nI'm using api-platform and they have recently started to include php8 only files and guard their uses via `PHP_VERSION_ID` checks. For example:\n\n URL \n\nwhich then conditionally includes:\n\n URL \n\nwhich is PHP8 only syntax, and fails with PHP 7.4.\n\nRelated downstream issue: URL \n\n### Code snippet that reproduces the problem\n\nphp\n<?php\n// composer require api-platform/core phpstan/phpstan symfony/framework-bundle phpunit/phpunit symfony/http-client\n\ndeclare(strict_types=1);\n\nrequire_once __DIR__.'/vendor/autoload.php';\n\nuse ApiPlatform\\Core\\Bridge\\Symfony\\Bundle\\Test\\ApiTestCase;\nuse ApiPlatform\\Core\\Bridge\\Symfony\\Bundle\\Test\\Client;\n\nclass Test extends ApiTestCase\n{\n protected function setUp(): void\n {\n parent::setUp();\n static::createClient();\n }\n}\n\nbash\n$ php7.4 ./vendor/bin/phpstan analyze a.php\n ------ ---------------------------------------------------------------------- \n Line /a.php \n ------ ---------------------------------------------------------------------- \n Internal error: syntax error, unexpected 'static' (T_STATIC) \n Run PHPStan with --debug option and post the stack trace to: \n URL \n ------ ---------------------------------------------------------------------- \n\n### Expected output\n\nNo output\n\n### Did PHPStan help you today? Did it make you happy in any way?\n\nevery day :)","author_login":"lazka","author_association":"NONE","created_at":"2022-01-17T14:09:25+08:00","repo_name":"phpstan/phpstan","issue_id":1105903709,"issue_number":6386,"issue_url":"https://github.com/phpstan/phpstan/issues/6386","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014632593","fragment_type":"issue_comment","sequence":1,"text":"Hi, can you please create a small reproducing repository that shows this problem? Thanks.","author_login":"ondrejmirtes","author_association":"MEMBER","created_at":"2022-01-17T15:01:28+08:00","repo_name":"phpstan/phpstan","issue_id":1105903709,"issue_number":6386,"issue_url":"https://github.com/phpstan/phpstan/issues/6386","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014719732","fragment_type":"issue_comment","sequence":2,"text":"Thank you, perfect. I'm gonna look into it in the next few days.","author_login":"ondrejmirtes","author_association":"MEMBER","created_at":"2022-01-17T16:35:07+08:00","repo_name":"phpstan/phpstan","issue_id":1105903709,"issue_number":6386,"issue_url":"https://github.com/phpstan/phpstan/issues/6386","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0274","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"index.html permission denied?","query_context":"Jellyfin is installed on TrueNas Scale. Used over Android as well as Windows Devices throughout the House.\n\nImage\n\nI tried the \"Windows\" Fix by adjusting the Permission of index.html in jellyfin-web for all users on my PC, didn´t do anything for JMP on the Device and obviously not for any phone or whatsoever. \n\nTried the docker fix but it got too technical for me as im not even sure what exactly a Docker is and over TrueNas Shell for Jellyfin Container i just get docker: not found. I think that means i don´t use dockers? \n\nImage\n\nAny help would be appreciated on how to move forward trying to fix it and please excuse any technical illiteracy on my part","known_context_document_ids":["gh_issue_2967845508"],"reference_answer":"Hey, the way of modifing something for JMP is deprecated.\nJMP is using the frontend from the server now.\nIf you can't see the button. Check if you have the newest version of JMP 1.11.1 and this plugin","answer_document_id":"gh_comment_2453336232","silver_evidence_path":["gh_comment_2776098377","gh_issue_2172181632","gh_comment_2453336232"],"evidence_issue_ids":[2967845508,2172181632],"source_repo_name":"Namo2/InPlayerEpisodePreview","source_issue_id":2967845508,"source_issue_number":51,"source_issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/51","target_repo_name":"Namo2/InPlayerEpisodePreview","target_issue_id":2172181632,"target_issue_number":10,"target_issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","reference_anchor_document_id":"gh_comment_2776098377","reference_answer_author":"Namo2","reference_answer_author_association":"OWNER","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1373,"anchor_target_overlap":0.1,"target_answer_overlap":0.0},"issue_created_at":"2025-04-03T00:19:08+08:00","valid_comment_count":43,"fragments":[{"document_id":"gh_issue_2967845508","fragment_type":"issue_description","sequence":0,"text":"index.html permission denied\nJellyfin is installed on TrueNas Scale. Used over Android as well as Windows Devices throughout the House.\n\nImage\n\nI tried the \"Windows\" Fix by adjusting the Permission of index.html in jellyfin-web for all users on my PC, didn´t do anything for JMP on the Device and obviously not for any phone or whatsoever. \n\nTried the docker fix but it got too technical for me as im not even sure what exactly a Docker is and over TrueNas Shell for Jellyfin Container i just get docker: not found. I think that means i don´t use dockers? \n\nImage\n\nAny help would be appreciated on how to move forward trying to fix it and please excuse any technical illiteracy on my part","author_login":"CapCom420","author_association":"NONE","created_at":"2025-04-03T00:19:08+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2967845508,"issue_number":51,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/51","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2776098377","fragment_type":"issue_comment","sequence":1,"text":"It seems that TrueNAS uses a different approach for file permissions.\n\nWhat i got from the documentation ( URL \nis that you should be able to change permissions for the whole dataset of your jellyfin instance.\n\nDepending on if you have access to the `index.html` yourself you could try to make the necessary changes yourself.\nDon't worry you don't have to change much, just insert a line like I described here:\n URL \n\nPlease change the version of the line to `1.3.1.0`\n\nUnfortunately, i am not very familiar with TrueNAS and i don't think i can help you further with this issue (of course i will try if i can).\nSo, if my ideas shouldn't work out, you could ask in r/selfhosted or r/truenas on reddit for help.\nThere are a lot of smart people in this subreddits and i believe there are many which know way more about the TrueNAS environment","author_login":"Namo2","author_association":"OWNER","created_at":"2025-04-03T15:05:04+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2967845508,"issue_number":51,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/51","linked_issue_ids":[2172181632],"is_known_query_context":false},{"document_id":"gh_comment_2777602891","fragment_type":"issue_comment","sequence":2,"text":"use this docker mod for lsio images URL It fixes the permission.","author_login":"cosmosgenius","author_association":"NONE","created_at":"2025-04-04T05:35:56+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2967845508,"issue_number":51,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/51","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2172181632","fragment_type":"issue_description","sequence":0,"text":"unable to display the button\nHello, great new idea to navigate faster on jellyfin. At the moment I can't get the button to appear, any ideas? Thanks","author_login":"MaitrePacha","author_association":"NONE","created_at":"2024-03-06T18:39:44+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000614124","fragment_type":"issue_comment","sequence":1,"text":"Hey guys, I am sorry that you have an issue with the program.\nCurrently i don't really have the capacity to work at the project right now.\nI will try to get some stuff done next week.\n\nIt would be nice if you guys could share a little bit more information to track down the problem.\nFor example, which client are you using, JMP Client or Web version?\nIf you are using the Web version, could you open up the Browser Console and check if there are any lines that start with \n[InPlayerEpisodePreview]\n, or any errors (marked red).\nIn which version of the program did the error occur (V1.0.0.0 or V1.0.1.0).\nDoes the bug also happen on the previews version?\nAre you using the Intro Skipper plugin by any chance?","author_login":"Namo2","author_association":"OWNER","created_at":"2024-03-15T23:12:38+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002728960","fragment_type":"issue_comment","sequence":2,"text":"Hey, thanks for the reply.\nI'm using the web interface but I'm currently not home for another week,\nI'll send you the logs then.\nI'm using the latest version of IPEP, 1.0.1.0, and yes, I'm using the Intro\nSkipper plugin.\n\nLe ven. 15 mars 2024, 17:12, Namo ***@***.***> a écrit :","author_login":"MaitrePacha","author_association":"NONE","created_at":"2024-03-18T01:41:35+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[2172181632],"is_known_query_context":false},{"document_id":"gh_comment_2081164141","fragment_type":"issue_comment","sequence":3,"text":"Same as him and also I'm seeing that the plugin is still stuck on version 1.0.0.0 in extensions tabs but won't download the 1.0.1.0 and also by forcing it and doing it manually it's still marked as 1.0.0.0","author_login":"Gauvino","author_association":"NONE","created_at":"2024-04-27T19:50:11+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106339695","fragment_type":"issue_comment","sequence":4,"text":"Hey guys,\n\nI made some changes for the new Jellyfin version.\nWould be nice if you guys could give me an update on the appearnce of the button for the new version.\n\nIf you are still unable to see the button please check inside the browser console if you can see some messages with the prefix `[InPlayerEpisodePreview]`","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-12T18:38:24+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106340859","fragment_type":"issue_comment","sequence":5,"text":"after testing the new update on 10.9 on docker, i finally see the the boutton and the console logs of docker show me this \n\nchrome_jy859TINZm\nchrome_PWk0Hn55rf\n\nbut nothing in the chrome 124 console logs","author_login":"Gauvino","author_association":"NONE","created_at":"2024-05-12T18:43:29+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106345863","fragment_type":"issue_comment","sequence":6,"text":"Ha that is weird that you don't have anything in the chrome logs.\nWell glad it works for you now 👍","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-12T19:04:36+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106346141","fragment_type":"issue_comment","sequence":7,"text":"No luck for me. Chrome still doesn't show logs or button on the latest 10.9","author_login":"MakD","author_association":"NONE","created_at":"2024-05-12T19:05:50+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106348594","fragment_type":"issue_comment","sequence":8,"text":"You can check your log files in jellyfin under Home -> Dashboard -> Logs\nHave a look if anything comes up if you search for `Loaded assembly \"Namo.Plugin.InPlayerEpisodePreview, Version=1.1.0.0`","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-12T19:16:26+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106349781","fragment_type":"issue_comment","sequence":9,"text":"Damn here I see the issue\n\nNamo.Plugin.InPlayerEpisodePreview.InPlayerEpisodePreviewPlugin: Attempting to inject preview script code in \"C:\\Program Files\\Jellyfin\\Server\\jellyfin-web\\index.html\"\n[2024-05-13 00:19:08.336 +05:30] [ERR] [104] Namo.Plugin.InPlayerEpisodePreview.InPlayerEpisodePreviewPlugin: Encountered exception while writing to \"C:\\Program Files\\Jellyfin\\Server\\jellyfin-web\\index.html\": \"System.UnauthorizedAccessException: Access to the path 'C:\\Program Files\\Jellyfin\\Server\\jellyfin-web\\index.html' is denied.","author_login":"MakD","author_association":"NONE","created_at":"2024-05-12T19:21:39+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106350431","fragment_type":"issue_comment","sequence":10,"text":"Here as well\n\n2024-05-13 00:42:49.440 +05:30] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded assembly \"Namo.Plugin.InPlayerEpisodePreview, Version=1.1.0.0, Culture=neutral, PublicKeyToken=null\" from \"C:\\ProgramData\\Jellyfin\\Server\\plugins\\InPlayerEpisodePreview_1.1.0.0\\Namo.Plugin.InPlayerEpisodePreview.dll","author_login":"MakD","author_association":"NONE","created_at":"2024-05-12T19:24:23+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106353045","fragment_type":"issue_comment","sequence":11,"text":"Okay yeah seems like the script doesn't have the right permissions.\nWhat you could try to do is editing the index.html yourself.\n\nCheck your jellyfin installation for the file.\nInside the file look for a section where ` `\n\nIf that doesn't work you may have to find a solution for the write permissions to the file on your system.\nI don't think i can change anything about that on the plugin side","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-12T19:35:35+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2110753266","fragment_type":"issue_comment","sequence":12,"text":"[2024-05-14 22:45:48.931 +05:30] [INF] [24] Emby.Server.Implementations.Plugins.PluginManager: Loaded assembly \"Namo.Plugin.InPlayerEpisodePreview, Version=1.1.0.0, Culture=neutral, PublicKeyToken=null\" from \"C:\\ProgramData\\Jellyfin\\Server\\plugins\\InPlayerEpisodePreview_1.1.0.0\\Namo.Plugin.InPlayerEpisodePreview.dll\"\n\nDid as suggested. Even disabled the custom css, thinking it might be creating issues. No help","author_login":"MakD","author_association":"NONE","created_at":"2024-05-14T17:21:46+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2112691456","fragment_type":"issue_comment","sequence":13,"text":"Have you checked again if you see anything in the chrome logs (Press F12 -> Go to console, and then start an episode)","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-15T14:24:14+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2112728284","fragment_type":"issue_comment","sequence":14,"text":"Okay, when you are watching a video, could you right click and select \"View Page Source\".\nThen search with Ctrl+F for `/InPlayerPreview/ClientScript`.\n\nIn theory you should finde the line you added to your index.html","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-15T14:39:14+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2112753316","fragment_type":"issue_comment","sequence":15,"text":"So normally that line should download the scriptfile from the plugin.\nNext thing you could try would be:\n- uninstall the plugin (just to be sure)\n- download the web-client-script\n- copy the js file inside into the folder where your index.html is\n- replace the old script line from the plugin with this one:\n\nhtml\n \n\nIf that isn't working try this line:\n\nhtml\n \n\nRemember to restart your jellyfin server in between","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-15T14:48:53+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2112888186","fragment_type":"issue_comment","sequence":16,"text":"I guess mine is an isolated issue. Tried both lines, after uninstalling and multiple restarts. Could'nt get it to show up.\n\nimage\nimage","author_login":"MakD","author_association":"NONE","created_at":"2024-05-15T15:40:52+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2119307331","fragment_type":"issue_comment","sequence":17,"text":"@Namo2 finally got an error log in the console, hoping this can be a help. BTW the plugin works awesome in the JMP\n\nimage","author_login":"MakD","author_association":"NONE","created_at":"2024-05-19T17:27:00+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2119320847","fragment_type":"issue_comment","sequence":18,"text":"Quickly patched this up.\n\nThe dll is the complete plugin. You would need to go in your jellyfin folder then to plugins and open \"InPlayerEpisodePreview_1.1.0.0\". Just replace the dll inside there with the one from the zip.\n\nIf that works hit me up. I would make the changes public then\n\ninPlayerEpisodePreview-1.1.1.0-beta-server.zip","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-19T18:21:41+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2119337155","fragment_type":"issue_comment","sequence":19,"text":"Just a query. Even though on your suggestion, I am using JMP, but some of my users use phone to watch my library. Is changing episode from the prompt on web (since the Android app is a web wrapper) totally not possible and is a code limitation, out just currently not implemented?","author_login":"MakD","author_association":"NONE","created_at":"2024-05-19T19:31:25+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2119340169","fragment_type":"issue_comment","sequence":20,"text":"I will check how hard it would be to implement but my main focus for the future will be to get this feature/plugin into the official jellyfin version","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-19T19:43:43+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2129349297","fragment_type":"issue_comment","sequence":21,"text":"Does something to combine this PR and your plugin would be possibly cause to button for something similar would really make the UI messy and too much I think.","author_login":"Gauvino","author_association":"NONE","created_at":"2024-05-24T11:55:39+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2130523072","fragment_type":"issue_comment","sequence":22,"text":"Thanks for mentioning it.\nThe plan is to open a discussion for this feature anyway but before i want to rewrite the core of it, so it would be ready for merging. Changes for the UI etc can be discussed then","author_login":"Namo2","author_association":"OWNER","created_at":"2024-05-24T23:47:23+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2135964389","fragment_type":"issue_comment","sequence":23,"text":"Changing the write permisions of `Jellyfin\\Server\\jellyfin-web` worked for me. I granted read and write access to the group `Users ( \\Users)` and restarted the server. After that, I could see the button.","author_login":"inzsome","author_association":"NONE","created_at":"2024-05-28T19:29:45+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206148398","fragment_type":"issue_comment","sequence":24,"text":"Just checked something on android and i saw that the plugin also works there for me (even the episode switching)","author_login":"Namo2","author_association":"OWNER","created_at":"2024-07-03T13:55:03+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2227635951","fragment_type":"issue_comment","sequence":25,"text":"Followed this ticket and now it works in Browser but not in JMP... Weird, maybe it just needs time to update?","author_login":"FaNt4zMa","author_association":"NONE","created_at":"2024-07-15T03:16:13+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308508371","fragment_type":"issue_comment","sequence":26,"text":"Hey ye,\n\ndo I understand this correctly, the only way this plugin works is by manipulating the `index.html` of Jellyfin?\n\nI'm hosting Jellyfin via Docker in the most common setup, i.e. with individual UID/GID.\nIn this setup, manipulating the file won't be allowed for the user running Jellyfin with the container's default file permissions.\nI think this a reasonable security feature and I'd rather not change the permissions of files inside a readily provided container.\n\nThere is no configurable list of scripts that the Jellyfin frontend loads etc. or other means to inject this button?","author_login":"sebschlicht","author_association":"NONE","created_at":"2024-08-24T19:27:19+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2315088101","fragment_type":"issue_comment","sequence":27,"text":"Same here, Jellyfin-web is installed from Gentoo ebuild (package) and I don’t wish to have to remember to modify the file for each update.","author_login":"nado","author_association":"NONE","created_at":"2024-08-28T11:39:49+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2407008045","fragment_type":"issue_comment","sequence":28,"text":"so I have same issue I use latest version of jellyfin and I cant see that preview button in player (web)/desktop","author_login":"EsmailELBoBDev2","author_association":"NONE","created_at":"2024-10-11T09:25:41+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2407390606","fragment_type":"issue_comment","sequence":29,"text":"Hey, the error message looks like you would use Jellyfin 10.10.0 (from the unstable) release.\nIf so, you need to wait for the official 10.10.0 release which is tomorrow as far as i know","author_login":"Namo2","author_association":"OWNER","created_at":"2024-10-11T13:13:26+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408447459","fragment_type":"issue_comment","sequence":30,"text":"Just heard that the official 10.10 release is delayed by ~2 weeks.\nI will add a pre-release sometime this day, which could be manually installed","author_login":"Namo2","author_association":"OWNER","created_at":"2024-10-12T07:57:39+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408448017","fragment_type":"issue_comment","sequence":31,"text":"oh! thank you for the tip and yes it would be good. so it works on day one when it get released","author_login":"EsmailELBoBDev2","author_association":"NONE","created_at":"2024-10-12T07:59:57+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408452590","fragment_type":"issue_comment","sequence":32,"text":"I don't think I can get it to work directly on release.\nI need to add my github release to the manifest.json you guys are using\nand if I do that beforehand, it will automatically update for everyone, even if they're still on 10.9.\nSo I guess I'll have to do it manually first, but it's usually done the same day.","author_login":"Namo2","author_association":"OWNER","created_at":"2024-10-12T08:13:08+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408453775","fragment_type":"issue_comment","sequence":33,"text":"I think you can specific version for each one if I'm not mistake but yeah i can do the manual way no issue","author_login":"EsmailELBoBDev2","author_association":"NONE","created_at":"2024-10-12T08:17:10+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408454840","fragment_type":"issue_comment","sequence":34,"text":"Oh yeah i think you are right. I never worked with these but maybe i will try it out","author_login":"Namo2","author_association":"OWNER","created_at":"2024-10-12T08:21:00+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2408479062","fragment_type":"issue_comment","sequence":35,"text":"here are other manifests i saw, URL and URL and URL so with help of chatgpt and me being patient zero im sure you can manage it so gl! \n\nworst case, host new manifest on different url till it get officially released?","author_login":"EsmailELBoBDev2","author_association":"NONE","created_at":"2024-10-12T09:43:52+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2452998440","fragment_type":"issue_comment","sequence":36,"text":"Plugin is working on the browser but not on JMP, from the logs I see this error:\n`[ERR] [33] Namo.Plugin.InPlayerEpisodePreview.Api.InPlayerPreviewController: InPlayerEpisodePreviewPlugin: \"Namo.Plugin.InPlayerEpisodePreview.Web.InPlayerPreview.js\"\n`\nI already modified my nativeshell.js as instructed in the readme, it used to work fine but not anymore, any ideas?","author_login":"XDark187","author_association":"NONE","created_at":"2024-11-02T13:57:22+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2453336232","fragment_type":"issue_comment","sequence":37,"text":"Hey, the way of modifing something for JMP is deprecated.\nJMP is using the frontend from the server now.\nIf you can't see the button. Check if you have the newest version of JMP 1.11.1 and this plugin","author_login":"Namo2","author_association":"OWNER","created_at":"2024-11-03T08:06:41+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2453378817","fragment_type":"issue_comment","sequence":38,"text":"Even though the button is displayed and working on the web browser, I can see an error on the console:\nimage\n\nThe amount of time this plugin takes to troubleshoot with every jellyfin update is not worth it for me anymore, all other plugins just migrate smoothly with every jellyfin update except this one, nothing have changed from the last time this plugin was working except for the jellyfin version.","author_login":"XDark187","author_association":"NONE","created_at":"2024-11-03T10:40:04+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2508768390","fragment_type":"issue_comment","sequence":39,"text":"Hi, I am having this issue too.\nThe button appears on the web client (although it still generates this error: [InPlayerEpisodePreview] Couldn't save items from response) but does not appear on the media player, I see that the method for the media player depreciated so shouldn't it appear on the media player if it appears on the web client?\n\nI am on windows and have the latest version of the server, media player and this plugin","author_login":"thelouisrex","author_association":"NONE","created_at":"2024-11-30T01:05:06+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509100549","fragment_type":"issue_comment","sequence":40,"text":"yeah that is how it should be. I don't know yet why it happens.\nThe only thing, that you have to do is restarting the media player after installing the update.\nWhat could also be important is that the media player connects to your server on startup.\nIf you ever used the old version for JMP removing the changes you made back in the days or better, reinstall the player.\n\nJust for information, are you on Windows 10, 11?\nMaybe the version could also be important (e.g. 23H2 or 24H2) for windows 11","author_login":"Namo2","author_association":"OWNER","created_at":"2024-11-30T17:55:49+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509116873","fragment_type":"issue_comment","sequence":41,"text":"before i forget, this error is normal on first initialization (loading/reloading the webpage, starting JMP)\nIt has to do with the new fetching of data in 10.10.x\n\nWhen i have time again, i will think about a rework for more stability.\n(if i don't work on a native integration)","author_login":"Namo2","author_association":"OWNER","created_at":"2024-11-30T18:00:52+08:00","repo_name":"Namo2/InPlayerEpisodePreview","issue_id":2172181632,"issue_number":10,"issue_url":"https://github.com/Namo2/InPlayerEpisodePreview/issues/10","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0276","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"action button not working and sync error Android 14?","query_context":"The action button doesn't work and I'm only able to connect once, after that I have to forget the watch in the app and connect again. \n\nSteps to reproduce:\n\n1. open app\n2. connect watch as instructed \n3. all settings sync perfectly \n4. disconnect watch by short pressing either mode or 'action' button\n5. pressing the action button doesn't do anything\n6. try to connect watch again as instructed but watch displays 'ERR' in the top right matrix display after flashing 'CNCT' for 8 times, no reaction from the app\n7. press 'forget' in the app and connect watch again\n8. app works until watch is disconnected upon which watch won't connect again unless watch is forgotten in app\n\nExpected behavior:\n\n1.- 4. as above\n5. pressing action button launches set action\n6. watch can be reconnected without having to forget every time\n\nIf theres a way to send logs or provide u with other information please let me know. \n\nDevices:\nGW-B5600\nPixel 7 \nAndroid 14 UQ1A.231205.015\nApp ver. 12.1","known_context_document_ids":["gh_issue_2140654827"],"reference_answer":"@tomasz-c OK, good point!\n\nHere is what the app currently does:\n\nThe first time a watch tries to connect, the app will pair with the watch automatically.\nFrom then on, it will only pair with the same watch until you press the \"FORGET\" button.\nIf you try to connect another watch, it will fail.\nYou can test this by resetting your watch to factory default and trying to connect. This will fail because the Bluetooth ID of the watch changes when reset, equivalent to connecting a new watch. To connect the watch, you must press the \"FORGET\" button. (Prior to version 11.9, I have gone back and forth allowing all watches to auto-connect because some people have requested auto-syncing multiple watches, but now only one watch can connect until \"FORGET\" is pressed).\n\nNow, the only way somebody else can connect to the watch is if they are running the app and have not yet paired it with a watch. This can happen when the watch auto-syncs, and they are nearby, like on a bus (a very rare event, I can only hope this app is popular enough for random people to run it on the same bus). In this case, they will not be able to see the Google reminders in the app, but it is possible to send their reminders to your watch, which is, of course, a problem.\n\nAuto-pair is generally a good feature. The app can connect to watches ad-hoc, even if they are not in the supported list. People like this feature, and I would like to keep it.\n\nTo address the rare possibility of sending the wrong reminders, I will arrange the app not to send reminders if this is the first time they have connected to this watch.","answer_document_id":"gh_comment_1928088632","silver_evidence_path":["gh_comment_1950798264","gh_issue_2119316305","gh_comment_1928088632"],"evidence_issue_ids":[2140654827,2119316305],"source_repo_name":"izivkov/CasioGShockSmartSync","source_issue_id":2140654827,"source_issue_number":75,"source_issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","target_repo_name":"izivkov/CasioGShockSmartSync","target_issue_id":2119316305,"target_issue_number":70,"target_issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","reference_anchor_document_id":"gh_comment_1950798264","reference_answer_author":"izivkov","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2041,"anchor_target_overlap":0.3265,"target_answer_overlap":0.25},"issue_created_at":"2024-02-17T23:23:36+08:00","valid_comment_count":55,"fragments":[{"document_id":"gh_issue_2140654827","fragment_type":"issue_description","sequence":0,"text":"action button not working and sync error Android 14\nThe action button doesn't work and I'm only able to connect once, after that I have to forget the watch in the app and connect again. \n\nSteps to reproduce:\n\n1. open app\n2. connect watch as instructed \n3. all settings sync perfectly \n4. disconnect watch by short pressing either mode or 'action' button\n5. pressing the action button doesn't do anything\n6. try to connect watch again as instructed but watch displays 'ERR' in the top right matrix display after flashing 'CNCT' for 8 times, no reaction from the app\n7. press 'forget' in the app and connect watch again\n8. app works until watch is disconnected upon which watch won't connect again unless watch is forgotten in app\n\nExpected behavior:\n\n1.- 4. as above\n5. pressing action button launches set action\n6. watch can be reconnected without having to forget every time\n\nIf theres a way to send logs or provide u with other information please let me know. \n\nDevices:\nGW-B5600\nPixel 7 \nAndroid 14 UQ1A.231205.015\nApp ver. 12.1","author_login":"Lexvox","author_association":"NONE","created_at":"2024-02-17T23:23:36+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1950561825","fragment_type":"issue_comment","sequence":1,"text":"OK, let us establish a baseline for the problem. Let me ask you a few things first:\n\nWhat is the version of the app? You can find the version by pressing the (i) in the top-right of the initial screen.\nIs this a new behavior? Was it working before, or is this something you have experienced before?\nPlease make sure the official app is not running on your phone or on phones in the proximity of the watch.\nPlease make sure this app is not running on a phone in the proximity of the watch.\nDoes the app work on another phone you might have?\nDo you have multiple watches?\nI will look into the issue once I understand the situation better. Thanks for reporting this.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-17T23:42:17+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950573316","fragment_type":"issue_comment","sequence":2,"text":"A simple thing to try is to go the Android setting, and clear \"Storage and Cahe\" and see if this fixes the promle. In v12.1, we cahnged the way we store local data, this might be effecting it.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-17T23:50:16+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950798264","fragment_type":"issue_comment","sequence":3,"text":"If all else fails, somebody reported that they had to pair the watch manually once from the Android settings, and then it started working. We have tested the app with Android 14, so I assumed that this is something specific to their crDroid OS. It seems that some versions of Android 14 have extra security features that don't allow automatic pairing, or there is a bug in the OS. We are still investigating.\n\nIf you try to pair manually, go to Settings, select Bluetooth -> Pair new device, then long-press the lower-left button of the watch, and it will appear in the list of devices. Just pair it then\n\nhere is the link\n\nPlease let me know how it goes.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-18T02:20:44+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_1950947548","fragment_type":"issue_comment","sequence":4,"text":"Just keeping some notes here for future reference:\n\nLocation of DataStore data file:\n/data/data/org.avmedia.gshockGoogleSync/files/datastore/CASIO_GOOGLE_SYNC_STORAGE.preferences_pb\n\nSimmilar issue found here:\n URL","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-18T04:02:46+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951323282","fragment_type":"issue_comment","sequence":5,"text":"**[SOLUTION:]**\n \n\ndid that app works as expected now\n(cleared cache b4 for good measure)\n\n-----\n \n \n \n \n \n\n1. new user\n2. no official app installed, no other phones in vicinity\n3. \"\n4. n/a\n5. no\n\n-----\n \n\nsame behavior as pressing 'forget' in app\n\n-----\n \n\nstock pixel rom, however custom linux-stable based kernel \n(5.10.197-Kirisakura_Raviantah_2.1.0), magisk 26.4, lsposed 1.9.2; if that matters","author_login":"Lexvox","author_association":"NONE","created_at":"2024-02-18T13:15:09+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951325745","fragment_type":"issue_comment","sequence":6,"text":"Great, thanks for the feedback! I'll add this solution to a troubleshooting section.\nI'll continue to investigate why this is the case.i can only assume this is a new security feature to prevent apps from maliciously connecting via Bluetooth without the user's knowledge. It does not effect all Android 14 phones, so I'm not sure what is the difference.\n\nI would be really curious how the official app behaves with your phone, but if you have not installed it before, I understand you might be reluctant to compromise your privacy.\n\nThanks again for reporting this.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-18T13:25:11+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951389297","fragment_type":"issue_comment","sequence":7,"text":"Just tried both the 'classic' g shock connected and newer casio watches app and both work as expected. Once paired in app the watch and app reconnect without hiccup. Deleted the watch pairing from my phones bluetooth settings beforehand.\nSo I'm guessing it's bug specific to your app.","author_login":"Lexvox","author_association":"NONE","created_at":"2024-02-18T17:13:59+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951391913","fragment_type":"issue_comment","sequence":8,"text":"Ok, I'll look into it. Thanks.\n\nOn Sun, Feb 18, 2024, 12:14 PM Lexvox ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-18T17:24:44+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951416246","fragment_type":"issue_comment","sequence":9,"text":"Sounds like you have some good technical skills. Could you help me narrow down the problem?\nI suspect it has something to do with the app storage. After connection, the Bluetooth (BT) ID of the watch is stored in the DataStore of the app. Next time, the app will reuse the same ID to connect to the watch until you clear the storage or press \"FORGET\".\n\nCould you try the following:\n\n1. Unpair the watch and clear storage from Android settings.\n2. Set up ADB on your PC. Put your phone in \"developer\" mode and connect it to the PC via USB.\n3. Run the following to see the content of the app's data:\n\nadb shell\nrun-as org.avmedia.gshockGoogleSync\ncat /data/data/org.avmedia.gshockGoogleSync/files/datastore/CASIO_GOOGLE_SYNC_STORAGE.preferences_pb\n\nYou should see \"File not found\".\n4. Connect the watch to the phone for the first time. Run the above commands again. This time you should see something like:\n\nLastDeviceName*CASIO GA-B2100\nLastDeviceAddress*F6:A1:42:57:7A:07\n\nLastDeviceAddress is what holds the ID of the watch. Let me know if you see it.\n\nThanks","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-18T19:05:45+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1951955204","fragment_type":"issue_comment","sequence":10,"text":"1. cleared app, deleted pairing from phones bt setting\n2. looked up the file (nonexistent)\n3. after connecting (in app) it holds my watches id just like in ur xample, \n4. disconnected watch\n5. wont reconnect as before,\n6. without clearing the app or forgetting the watch in app I connected the watch through my phones bt settings and when I switched back to the app the interface was already up displaying the info as expected\n\nalso cleared and reconnected twice just to see if the phone changed the id for some reason (it didn't)","author_login":"Lexvox","author_association":"NONE","created_at":"2024-02-19T08:42:15+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1972492094","fragment_type":"issue_comment","sequence":11,"text":"Hello @Lexvox \n\nIf you are comfortable with it, do you mind building the branch new-ble and testing it with your Android 14? This should address the issue of having to press the \"FORGET\" button with every connection, without manually pairing the watch.\n\nI replaced my own implementation of the BLE interface with this library. This is supposed to be the \"gold standard\" when referring to BLE libs, so I hope this fixes the issue.\n\nIf you prefer an APK, I can send you to test.\n\nThanks in advance.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-03-01T04:36:54+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1973272741","fragment_type":"issue_comment","sequence":12,"text":"Hi @izivkov \n\nwouldn't mind building it but I'm currently on vacation and don't have my computer with me.\nBut if you can send me an apk I'll gladly test it.","author_login":"Lexvox","author_association":"NONE","created_at":"2024-03-01T14:09:46+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1973366654","fragment_type":"issue_comment","sequence":13,"text":"Oh, sorry to bother you on vacation. Here is the APK, but please don't spend too much time on this, I can get somebody with Android 14 to test it.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-03-01T15:12:36+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1973889859","fragment_type":"issue_comment","sequence":14,"text":"I don't mind, not like I'm wasting any beautiful weather here and I enjoy the tinkering :)\nUnfortunately after going through initial setup the app crashes about a second after I attempt to connect a second time.\nIt first reacts to the watch (loading animation plays) but it crashes before the interface comes up. \nYet again the problem is solved by pairing the watch in the device settings first. \nI'll send you the crash log via email.","author_login":"Lexvox","author_association":"NONE","created_at":"2024-03-01T20:43:30+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1973918856","fragment_type":"issue_comment","sequence":15,"text":"Thanks for the log. I saw this error earlier, and I updated the APK. If you have time, download again give it another try. It does not happen for me. If it deos not work for you, I will post a messages on GitHub regarding this. One of the contributots with Android 12 will try to fix it.\n\nThanks again\nIvo","author_login":"izivkov","author_association":"OWNER","created_at":"2024-03-01T21:06:41+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2140654827,"issue_number":75,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2119316305","fragment_type":"issue_description","sequence":0,"text":"Limit syncing to paired watches\n**Is your feature request related to a problem? Please describe.**\nCurrently, the app has something like auto-pairing.\nI observed a situation where a watch that was not paired with my smartphone triggered (when trying to sync) my calendar entries to be sent to it.\n\nTo repeat this:\nRestore to factory settings (or unpair) watches A and B.\nWe pair watch A with the official Casio app on smartphone 1, watch B with CasioGShockSmartSync on smartphone 2.\n\nLet's turn off the CasioGShockSmartSync app on smartphone 2 (although in my case it was on) and wait for watch A to sync. It connected to smartphone 2, from which the calendar entries (REM) were sent.\n\nMaybe someone with access to two watches and smartphones would be able to confirm this, but it seems to me that this is repeatable.\n\n**Describe the solution you'd like**\nIt seems to me that there would be a useful option that would allow only watches that were previously paired to sync. Without this, our calendar entries can go to other people, at work, school or on the bus :)\n\nBy the way, I wanted to thank you for creating and developing this application.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-05T19:36:03+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928088632","fragment_type":"issue_comment","sequence":1,"text":"@tomasz-c OK, good point!\n\nHere is what the app currently does:\n\nThe first time a watch tries to connect, the app will pair with the watch automatically.\nFrom then on, it will only pair with the same watch until you press the \"FORGET\" button.\nIf you try to connect another watch, it will fail.\nYou can test this by resetting your watch to factory default and trying to connect. This will fail because the Bluetooth ID of the watch changes when reset, equivalent to connecting a new watch. To connect the watch, you must press the \"FORGET\" button. (Prior to version 11.9, I have gone back and forth allowing all watches to auto-connect because some people have requested auto-syncing multiple watches, but now only one watch can connect until \"FORGET\" is pressed).\n\nNow, the only way somebody else can connect to the watch is if they are running the app and have not yet paired it with a watch. This can happen when the watch auto-syncs, and they are nearby, like on a bus (a very rare event, I can only hope this app is popular enough for random people to run it on the same bus). In this case, they will not be able to see the Google reminders in the app, but it is possible to send their reminders to your watch, which is, of course, a problem.\n\nAuto-pair is generally a good feature. The app can connect to watches ad-hoc, even if they are not in the supported list. People like this feature, and I would like to keep it.\n\nTo address the rare possibility of sending the wrong reminders, I will arrange the app not to send reminders if this is the first time they have connected to this watch.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-05T21:02:52+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928130212","fragment_type":"issue_comment","sequence":2,"text":"@tomasz-c The scenario you described in your comment is kind of expected behavior though. If watch A was previously connected to this app, it simply connected to this app again and got reminders from it. The same reminders will show up in the official app.\n\nIf you really wanted only watch B to connect to this app, pair it, and do not press the \"FORGET\" button. Watch A will not connect to the app. This is what should happen in version 11.9 and later of this app. Let me know if this is not what you see.\n\nGenerally, I recommend running only one app, not both.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-05T21:31:19+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928656360","fragment_type":"issue_comment","sequence":3,"text":"I did some tests with my two watches, GW-B5600 and GAB-2100, and the app worked as expected for me (with some small display issues, which I will fix in the next release). Basically, if the watch is already paired, another watch cannot connect unless the \"FORGET\" button is pressed. I made a video to ensure we are on the same page:\n\nWatch Connection Video\n\nIf you actually connect and are able to get to the TIME screen without forgetting, there may be some problem saving to the LocalStorage of your phone, since the paired watch info is stored there. I'm hoping that this is just a display issue, as shown in the video.\n\nRegards","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-06T02:13:36+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930374701","fragment_type":"issue_comment","sequence":4,"text":"@tomasz-c Here are a few things to try:\n- Make sure you have all permissions for the app enabled, especially read/write permissions.\n- Try using a different phone with the two watches. This will eliminate the posibility that the problem is related to the phone setting/Android version.\n- Regards","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-06T17:03:59+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930452668","fragment_type":"issue_comment","sequence":5,"text":"I will check it and let you know.\nCurrently, I have recorded a video of how the application behaves on my smartphone, so I am sharing it:\n URL \n\nI will check it and let you know. Currently, I have recorded a video of how the application behaves on my smartphone, so I am sharing it:\n\nThe application is launched immediately after clearing the data.\n0:03 - information about the program, with visible version,\n0:13 - GST-B500 pairing\n0:23 - disconnected\n0:32 - MSG-B100 pairing\n0:43 - disconnected\n0:50 - GST-B500 pairing\n0:56 - disconnected\n\nI didn't use FORGET here.\nThis is Android 14, tested on the v12.0 app from Fdroid and Google Play.\nBy the way. If you release a new official version, would it be possible to include on GitHub the apk there in addition to the source code, as other projects do? This would allow to test new versions quickly.\n\nRegards","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-06T17:42:08+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930563532","fragment_type":"issue_comment","sequence":6,"text":"On Android 10 with your application, this situation does not occur, the second watch does not pair, it has ERR.\nAfter restarting the application, I can pair the second watch without using FORGET, but this is probably intentional.\n\nOn Android 14, there is no read/write access (data access) in the permission settings, so you can't grant it even manually. On Android 10 this is possible. So I guess you had a good idea to check it out.\nI don't know which Android version you are using, maybe it's due to a change: URL","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-06T18:54:06+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930759395","fragment_type":"issue_comment","sequence":7,"text":"OK, thanks for helping thack this issue. I will look into getting it to work with Adroid 14, and aslo making other small fixes. Should take a couple of days.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-06T21:12:53+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930969210","fragment_type":"issue_comment","sequence":8,"text":"So, looks like the Android Version is not causing the problem. I ran the app with an Android 14 emulator (Pixel 3a API 34), and I can read and write from local storage. \nWhich phone make and model are you using?","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-06T23:54:38+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932669638","fragment_type":"issue_comment","sequence":9,"text":"I'm using OnePlus 6 running crDroid which is based on LineageOS.\n\nI checked the application in App Manager and there are two permissions with data access and the status \"revoked\", even though in the application settings I have the status \"No permissions denied\":\n\nScreenshot_20240207-180348_Permission controller\nScreenshot_20240207-173557_App Manager\n\nI added permissions manually via adb:\n\nadb shell pm grant org.avmedia.gshockGoogleSync android.permission.READ_EXTERNAL_STORAGE\nadb shell pm grant org.avmedia.gshockGoogleSync android.permission.WRITE_EXTERNAL_STORAGE\n\nThey appeared in App Manager (granted):\n\nScreenshot_20240207-173557_App Manager\n\nBut it didn't help and the application works the same.\n\nUnfortunately, I cannot check it on another smartphone with Android 14.\nI understand that since I have an unofficial Android installation, there may be a problem here somewhere, but overall crDroid works very well for me and I haven't had any problems with it.\n\nSo we'll probably have to stop looking for the cause until someone else is able to confirm it on stock Android 14.\n\nRegards","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-07T18:51:32+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1933208582","fragment_type":"issue_comment","sequence":10,"text":"OK, np.\nI noticed that in your \"TIME\" screen, the tempearure is formatted incorrecly, simething like \"24 st C\" as opposed to \"24°C. I'm using localization and have not hardcoded this simbol. Maybe you know if this is specific to the Polish language on Android. I could not find anything related to thes issue on the internet.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-08T01:11:25+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1934384689","fragment_type":"issue_comment","sequence":11,"text":"Yes, that's a shortcut. Anyone would understand it, but it's not commonly used and looks a bit strange. Maybe someone uses it in some literary (non-technical) texts. I think it would be better to use °C. I have no idea why Android shows it this way for the Polish language. In Android battery settings and in the weather on the screen, the temperature is given as °C. So it looks like Android itself is not using its interpretation.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-08T15:35:19+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937106523","fragment_type":"issue_comment","sequence":12,"text":"@tomasz-c I have updated the app to use DataStore instead of SharedPreferences. I think this will address the problem you are experincing on your Android 14 phone, and also is the recommenerd method to use now. You might want to give it a try, and let me know how it goes\n\nI have placed the APK on my Google Drive, since I have not figured out how to build an APK on GitHub. The code for the APK is in branch \"pairing\", if you like to build it from source. (If you are familiar with creating APK's on GitHub, feel free to contribute)\n\nThis branch also fixes a number of display issues, as well as closing the loophole of getting the incorrect reminders for unpaired watches. \n\nI will do some more testing as well, and if there are not issues, I will merge to main and create another relase.\n\nCheers,\nIvo","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-10T19:52:43+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937772611","fragment_type":"issue_comment","sequence":13,"text":"Thank you very much. I'd like to test it, but I can't download this file from Google Drive, is it marked as private?","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-11T14:37:31+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937804967","fragment_type":"issue_comment","sequence":14,"text":"OK, try again to download. here is the link:\n URL \n\nOn Sun, Feb 11, 2024 at 9:37 AM Tomasz C. ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-11T16:43:35+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_1937842271","fragment_type":"issue_comment","sequence":15,"text":"It works! Now on Android 14 without using 'FORGET' the second watch is unable to pair, it displays 'ERR'.\n\nWhen it comes to building Android applications, I have no experience. I thought you could just attach an APK file you built yourself, e.g. the one for Google Play. But I read the article and it looks like it's not that easy:\n URL \n\nThank you for this change in the program. It will be useful in the future when more users will have newer Androids.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-11T19:13:11+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937845351","fragment_type":"issue_comment","sequence":16,"text":"Ok, great! Did you notice if your selected actions were preserved after the\nupdate?\n\nI have created a new version 12.1 on playstote and on f-droid. I know it\ntakes a while to appear on f-droid.\n\nAbout the APK creation on GitHub, I had it working at one time, but the\nsignature was not updated properly, so people had to remove the app before\ninstalling it. I simply have to spend the time to write the correct yml\nscript for GitHub, and I not overly excited about administration work.\n\nOn Sun, Feb 11, 2024, 2:13 PM Tomasz C. ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-11T19:24:52+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_1937846352","fragment_type":"issue_comment","sequence":17,"text":"Yes, I noticed a problem, I edited the previous comment, you probably already replied and didn't see it. Please take a look at them.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-11T19:29:27+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937847263","fragment_type":"issue_comment","sequence":18,"text":"No, should not have to use FORGET to connect the same watch. Is this behavior only on your Android 14 phone? BTW, I don't think it is the Android version, but the os distribution.\n\nThe app 12.1 should be coming on the playstote soon, maybe try it and see any difference","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-11T19:33:07+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937849391","fragment_type":"issue_comment","sequence":19,"text":"Strange, I'll try with more phones. Seems like the new settings are not saved. I think the os you're using is super secure.\n\nCan you try this: \n- Select some actions in the action screen.\n- go to the time screen\n- disconnect and restart the app\n- see if the newly selected actions are still selected.\nThis will tell is if you are able to save your preference","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-11T19:42:30+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937856178","fragment_type":"issue_comment","sequence":20,"text":"Or maybe it has something to do with encryption. Can you put a phone number\nin the action screen, restart the app, and see if the number appears the\nsame?\n\nThanks\n\nOn Sun, Feb 11, 2024, 2:29 PM Tomasz C. ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-11T20:09:17+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_1937909288","fragment_type":"issue_comment","sequence":21,"text":"I did some tests:\n- there is no entry in the application. phone and settings are remembered after restart,\n- I built version 12.1, I don't know if I did it correctly, but I got app-debug.apk, it works and presents itself as 12.1, but this version works the same as the previous one,\n- the most important observation - if I pair the watch in the Android system settings, I can reconnect without using 'FORGET', both after disconnecting the watch and restarting the application. So after pairing in the system, everything in the application seems to work correctly (I haven't tested automatic time synchronization yet)\n\nI hope that such pairing in the system was not always required and I did not know about it. But probably not, because previously the app connected to all watches every time without pairing in the system.\n\nI forgot to mention that I have Android without Gapps (I did not install it), so I do not have GSF (Google Services Framework), but this application in the Google Play store does not show that it is dependent on GSF.\n\nConclusion:\n- currently (after pairing in the system) the application seems to work as expected, I will let you know if the watch synchronizes automatically,\n- this action is fine for me, it doesn't bother me that I have to pair the watch in the system, unless there are some negative consequences that I don't know about,\n\nThank you for these changes to the application.\nRegards.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-11T23:21:30+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937915325","fragment_type":"issue_comment","sequence":22,"text":"OK, will leave it for now. I think it is some permissions related to BT for your device.\n\nIn the future, I will try ti install crDroid 14 on one of my phones and see if I can reproduce it.\n\nI will leave this issue open in case somebody else want to chime in.\n\nThanks for all the feedback","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-11T23:43:51+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939543522","fragment_type":"issue_comment","sequence":23,"text":"Automatic time synchronization does not work. I waited for the watch to want to update, then it was visible that it was connecting and after a short while it displayed ERR. Connecting (bottom left button) and triggering actions (bottom right button) work properly, e.g. sending time to the watch.\nI have no more ideas why it doesn't work for me. I will wait until you or someone else has access to Android 14. Not necessarily crDroid, just information that it works properly on any Android 14 is enough, then I will know that it is definitely something on my side.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-12T20:46:00+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939630252","fragment_type":"issue_comment","sequence":24,"text":"I don't even have the official app on this phone. But it was running on another phone nearby. I will check synchronization if there is no official application nearby and let you know.\nThank you for your suggestion.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-12T21:39:38+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939665272","fragment_type":"issue_comment","sequence":25,"text":"You're right! I set the watch to an hour just before the update, and if there was no other phone with the official application nearby, the synchronization worked :)\nThank you for the idea. I thought that if each watch is paired with its application on separate phones, there will be no conflict.","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-02-12T22:01:29+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939721329","fragment_type":"issue_comment","sequence":26,"text":"What has happened is that the watch is sending a signal that it is trying\nto connect, and the app running on the phones nearby see this request and\nthey try to connect to the watch. The first phone that replies to the watch\nwins. The watch will only talk to this phone from that point on. In your\ncase, the phone that was not paired got in first, and that connection\nfailed. The watch displayed ERR.\n\nOn Mon, Feb 12, 2024 at 5:01 PM Tomasz C. ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-12T22:33:51+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_1950926866","fragment_type":"issue_comment","sequence":27,"text":"Just keeping some notes about this issue for future reference.\n\nLocation of DataStore data file:\n/data/data/org.avmedia.gshockGoogleSync/files/datastore/CASIO_GOOGLE_SYNC_STORAGE.preferences_pb\n\nSimmilar issue found here:\n URL","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-18T03:48:35+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1971630289","fragment_type":"issue_comment","sequence":28,"text":"@tomasz-c\nIf you are comfortable with it, do you mind building the branch new-ble and testing it with your Android 14? This should address the issue of having to press the \"FORGET\" button with every connection, without manually pairing the watch.\n\nI replaced my own implementation of the BLE interface with this library. This is supposed to be the \"gold standard\" when referring to BLE libs, so I hope this fixes the issue.\n\nNote that this was a massive change, so you may encounter some small issues. I have seen the alarm screen display only 4 alarms instead of 5, but this is rare, and I cannot reproduce it now.\n\nThanks for your help in advance.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-02-29T17:34:45+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1974047953","fragment_type":"issue_comment","sequence":29,"text":"@izivkov \nOf course, I was happy to test it. I was only able to do it now, so I checked the latest version 12.4.\n- if the watch is paired in the Android configuration, everything seems to work properly,\n- if my watch is unpaired and I use FORGET after the first and next connections, everything works fine,\n- if I do not use FORGET after the first connection, when I try to connect for the second time, the application crashes with the error:\n\ntime: 1709332930999\nmsg: java.lang.NullPointerException: getName(...) must not be null\nstacktrace: java.lang.NullPointerException: getName(...) must not be null\n at org.avmedia.gshockapi.ble.GShockManagerImpl.isRequiredServiceSupported(IGShockManager.kt:161)\n at no.nordicsemi.android.ble.BleManagerHandler$4.onServicesDiscovered(BleManagerHandler.java:2282)\n at android.bluetooth.BluetoothGatt$1$5.run(BluetoothGatt.java:406)\n at android.os.Handler.handleCallback(Handler.java:958)\n at android.os.Handler.dispatchMessage(Handler.java:99)\n at android.os.Looper.loopOnce(Looper.java:205)\n at android.os.Looper.loop(Looper.java:294)\n at android.app.ActivityThread.main(ActivityThread.java:8244)\n at java.lang.reflect.Method.invoke(Native Method)\n at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)\n at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)\n\nPlease keep in mind that I am using a custom ROM based on LineageOS. There have also been some recent changes with Bluetooth here:\n \n\nSo maybe it's worth having someone else test it on the Android 14 stock ROM before taking any steps.\nIf you need to test the application, let me know.\n\nRegards,","author_login":"tomasz-c","author_association":"NONE","created_at":"2024-03-01T23:02:28+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1974051696","fragment_type":"issue_comment","sequence":30,"text":"Great, this is reality helpful. I'll check the crash report, and will keep\nyou posted.\n\nIvo\n\nOn Fri, Mar 1, 2024, 6:02 PM Tomasz C. ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-03-01T23:06:46+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_1974095298","fragment_type":"issue_comment","sequence":31,"text":"Yeah, the code I'm using is right out of the library's example. I know\nother people with Android 14 are having issues, but not sure if they are\nthe same issues. On the other hand, I looked at the statistics for the app,\nand there are quite a few Android 14 devices, and I don't see any crashes.\nBut in any case, I'll do some more digging. Let me know if you find\nsomething as well.\n\nRegards\n\nOn Fri, Mar 1, 2024 at 6:06 PM Ivo Zivkov ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-03-01T23:52:33+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_2029373473","fragment_type":"issue_comment","sequence":32,"text":"I'm having the same issue with auto time adjustment, but I do have the official app installed, what steps do I take to make sure it works properly?","author_login":"ppsasho","author_association":"NONE","created_at":"2024-04-01T08:20:48+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2029408384","fragment_type":"issue_comment","sequence":33,"text":"- First make sure the official app is not running. You can shut it down\nfrom the the Android settings -> Applications.\n\n- Test that time settings work manually. Set action \"set time\" and trigger\nit by short-pressing the lower-right button. If that works, the automatic\ntime setting should work. There is no difference to the app how time\nsetting was triggered.\n\n- Also, the app should be running when auto time sync takes place. It can\nbe in the background, but still running. Sometimes, Android will swap it\nout of memory. What this means is that if you started the app within a few\nhours of auto sync, this should work.\n\nHope this helps, and let me know if it works for you.\n\nIvo\n\nOn Mon, Apr 1, 2024, 10:21 AM ppsasho ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-04-01T08:35:43+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_2029461864","fragment_type":"issue_comment","sequence":34,"text":"I think there should be at least 6 hours from last time set (manually or\nautomatic) for the automatic action to trigger.\n\nOn Mon, Apr 1, 2024, 10:40 AM ppsasho ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-04-01T09:18:28+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_2029469831","fragment_type":"issue_comment","sequence":35,"text":"I'm not syncing it on purpose to see if it auto syncs, I'm on a POCO X3 PRO - version MIUI 13. I gave the app all necessary permissions to run in the background, removed it from battery restrictions and also used: IMG_20240401_112331.jpg\n\n the app lock feature on MIUI that doesn't let it get closed. Also noticed when trying to change the minutes when it will sync it always goes back to 5 minutes when I Re-connect.","author_login":"ppsasho","author_association":"NONE","created_at":"2024-04-01T09:24:19+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false},{"document_id":"gh_comment_2029489369","fragment_type":"issue_comment","sequence":36,"text":"So, just to understand, is the auto time adjustment triggered and gets an error, or not triggered at all? If it is triggered, there is something else interfering with the connection, like the official app.\n\nAbout settings the minutes, there maybe a small input bug, which I'll fix in the next release. After entering the number, touch the field again, to stop the blinking cursor. Then send to watch.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-04-01T09:40:11+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2029497624","fragment_type":"issue_comment","sequence":37,"text":"I actually checked my apps and forgot I deleted the official app so I hope interference is not the issue, But in the past when It tried to auto sync I would see the watch trying to pair with the phone, failing and leaving an error on the display for a moment. I'm waiting for the auto time to adjust and see if I get an error this time without the app.","author_login":"ppsasho","author_association":"NONE","created_at":"2024-04-01T09:47:28+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2029499160","fragment_type":"issue_comment","sequence":38,"text":"Ok, seems like there is a problem setting the time to adjust value. It worked for me during testing, but not working at the moment. I'll have to investigate further. I plan to have another release around apr. 20th.","author_login":"izivkov","author_association":"OWNER","created_at":"2024-04-01T09:48:47+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2029526532","fragment_type":"issue_comment","sequence":39,"text":"I just got a notification, it connected flawlessly, I'm so glad it worked 😁","author_login":"ppsasho","author_association":"NONE","created_at":"2024-04-01T10:11:52+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2029556574","fragment_type":"issue_comment","sequence":40,"text":"👍\n\nOn Mon, Apr 1, 2024, 12:12 PM ppsasho ***@***.***> wrote:","author_login":"izivkov","author_association":"OWNER","created_at":"2024-04-01T10:36:38+08:00","repo_name":"izivkov/CasioGShockSmartSync","issue_id":2119316305,"issue_number":70,"issue_url":"https://github.com/izivkov/CasioGShockSmartSync/issues/70","linked_issue_ids":[2119316305],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0278","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[🕹️] Feedback Fanatic?","query_context":"### What side quest or challenge are you solving?\n\nFill out our feedback survey after the hackathon with suggestions for improvement\n\n### Points\n\n150\n\n### Description\n\n_No response_\n\n### Provide proof that you've completed the task\n\nScreenshot 2024-10-18 121846","known_context_document_ids":["gh_issue_2618662931"],"reference_answer":"/award 150 \n\nthanks for playing :) keep collecting points to increase your chances of winning!","answer_document_id":"gh_comment_2409302126","silver_evidence_path":["gh_comment_2448746583","gh_issue_2583765259","gh_comment_2409302126"],"evidence_issue_ids":[2618662931,2583765259],"source_repo_name":"formbricks/formbricks","source_issue_id":2618662931,"source_issue_number":4086,"source_issue_url":"https://github.com/formbricks/formbricks/issues/4086","target_repo_name":"formbricks/formbricks","target_issue_id":2583765259,"target_issue_number":3614,"target_issue_url":"https://github.com/formbricks/formbricks/issues/3614","reference_anchor_document_id":"gh_comment_2448746583","reference_answer_author":"jobenjada","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.1333,"target_answer_overlap":0.1111},"issue_created_at":"2024-10-28T14:51:18+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2618662931","fragment_type":"issue_description","sequence":0,"text":"[🕹️] Feedback Fanatic\n### What side quest or challenge are you solving?\n\nFill out our feedback survey after the hackathon with suggestions for improvement\n\n### Points\n\n150\n\n### Description\n\n_No response_\n\n### Provide proof that you've completed the task\n\nScreenshot 2024-10-18 121846","author_login":"rajeevDewangan","author_association":"NONE","created_at":"2024-10-28T14:51:18+08:00","repo_name":"formbricks/formbricks","issue_id":2618662931,"issue_number":4086,"issue_url":"https://github.com/formbricks/formbricks/issues/4086","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2442845369","fragment_type":"issue_comment","sequence":1,"text":"whups, you already got points for that review :( \n\nsorry, we have a 0% tolerance for cheating......","author_login":"jobenjada","author_association":"MEMBER","created_at":"2024-10-28T23:12:57+08:00","repo_name":"formbricks/formbricks","issue_id":2618662931,"issue_number":4086,"issue_url":"https://github.com/formbricks/formbricks/issues/4086","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2442875560","fragment_type":"issue_comment","sequence":2,"text":"@jobenjada I remember I had done secret side quest and it was one of them but Feedback fanatic is a separate task. If you want I can do any other task for the point you awarded to me.","author_login":"rajeevDewangan","author_association":"NONE","created_at":"2024-10-28T23:40:59+08:00","repo_name":"formbricks/formbricks","issue_id":2618662931,"issue_number":4086,"issue_url":"https://github.com/formbricks/formbricks/issues/4086","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2448479711","fragment_type":"issue_comment","sequence":3,"text":"I think its pretty clear that this is a different task, isn't it?\n\n<img width=\"750\" alt=\"image\" src=\" URL","author_login":"jobenjada","author_association":"MEMBER","created_at":"2024-10-30T21:48:06+08:00","repo_name":"formbricks/formbricks","issue_id":2618662931,"issue_number":4086,"issue_url":"https://github.com/formbricks/formbricks/issues/4086","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2448746583","fragment_type":"issue_comment","sequence":4,"text":"@jobenjada by the time I was doing it the survey form was not available so I searched it a little and came across #3614, Now that you have shared the form I will open an issue and do it for 0 points","author_login":"rajeevDewangan","author_association":"NONE","created_at":"2024-10-31T00:40:43+08:00","repo_name":"formbricks/formbricks","issue_id":2618662931,"issue_number":4086,"issue_url":"https://github.com/formbricks/formbricks/issues/4086","linked_issue_ids":[2583765259],"is_known_query_context":false},{"document_id":"gh_issue_2583765259","fragment_type":"issue_description","sequence":0,"text":"[🕹️] Feedback Fanatic\n### What side quest or challenge are you solving?\n\n Fill out our feedback survey after the hackathon with suggestions for improvement\n\n### Points\n\n150\n\n### Description\n\n_No response_\n\n### Provide proof that you've completed the task\n\nScreenshot from 2024-10-13 12-33-09","author_login":"naaa760","author_association":"NONE","created_at":"2024-10-13T07:57:42+08:00","repo_name":"formbricks/formbricks","issue_id":2583765259,"issue_number":3614,"issue_url":"https://github.com/formbricks/formbricks/issues/3614","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2409302126","fragment_type":"issue_comment","sequence":1,"text":"/award 150 \n\nthanks for playing :) keep collecting points to increase your chances of winning!","author_login":"jobenjada","author_association":"MEMBER","created_at":"2024-10-13T23:14:41+08:00","repo_name":"formbricks/formbricks","issue_id":2583765259,"issue_number":3614,"issue_url":"https://github.com/formbricks/formbricks/issues/3614","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0279","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Compatibility with JSR?","query_context":"I love this module and use it in almost every project.\n\nI've recently started using Deno and JSR, and this package can't be used in modules published there for the following reasons:\n\n1. Imports/export strings need to specify the extension (e.g, `export * from 'file.ts'`.\n2. `(... arguments: any[])` isn't allowed\n3. Module augmentations aren't allowed. \n\nProblems 1 & 2 are potentially solvable, but I don't know if (3) is solvable. Maybe this requires to make two different builds, one for JSR, one for npm?\n\nIn the meantime, and for my own needs, I've made a little conversion script, which may be useful to someone else, so I will post it here: ~~build script (it uses this to download and decompress the sources: downloadAndExtractFile)~~ repo is private, posted the files in a comment below.\n\nIf you'd rather use my version (no guarantees of updates, only building this for our own internal usage), you'll find it at URL","known_context_document_ids":["gh_issue_3046064353"],"reference_answer":"@sindresorhus Do we want to update anything with the `If*` types, as suggested in URL \n\n \n \n\nI feel more inclined towards this, but `Is*` variants are likely much more common in codebases, so deprecating them could be annoying.","answer_document_id":"gh_comment_2693438035","silver_evidence_path":["gh_comment_2858728080","gh_issue_1353850512","gh_comment_2693438035"],"evidence_issue_ids":[3046064353,1353850512],"source_repo_name":"sindresorhus/type-fest","source_issue_id":3046064353,"source_issue_number":1122,"source_issue_url":"https://github.com/sindresorhus/type-fest/issues/1122","target_repo_name":"sindresorhus/type-fest","target_issue_id":1353850512,"target_issue_number":450,"target_issue_url":"https://github.com/sindresorhus/type-fest/issues/450","reference_anchor_document_id":"gh_comment_2858728080","reference_answer_author":"som-sm","reference_answer_author_association":"COLLABORATOR","quality_score":85.78,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0556},"issue_created_at":"2025-05-07T13:55:16+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_3046064353","fragment_type":"issue_description","sequence":0,"text":"Compatibility with JSR\nI love this module and use it in almost every project.\n\nI've recently started using Deno and JSR, and this package can't be used in modules published there for the following reasons:\n\n1. Imports/export strings need to specify the extension (e.g, `export * from 'file.ts'`.\n2. `(... arguments: any[])` isn't allowed\n3. Module augmentations aren't allowed. \n\nProblems 1 & 2 are potentially solvable, but I don't know if (3) is solvable. Maybe this requires to make two different builds, one for JSR, one for npm?\n\nIn the meantime, and for my own needs, I've made a little conversion script, which may be useful to someone else, so I will post it here: ~~build script (it uses this to download and decompress the sources: downloadAndExtractFile)~~ repo is private, posted the files in a comment below.\n\nIf you'd rather use my version (no guarantees of updates, only building this for our own internal usage), you'll find it at URL","author_login":"Xananax","author_association":"NONE","created_at":"2025-05-07T13:55:16+08:00","repo_name":"sindresorhus/type-fest","issue_id":3046064353,"issue_number":1122,"issue_url":"https://github.com/sindresorhus/type-fest/issues/1122","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2858728080","fragment_type":"issue_comment","sequence":1,"text":"1. This will be fixed soon with URL \n2. URL \n3. Does it show where we use that? I think this is the only place: URL","author_login":"sindresorhus","author_association":"OWNER","created_at":"2025-05-07T14:03:15+08:00","repo_name":"sindresorhus/type-fest","issue_id":3046064353,"issue_number":1122,"issue_url":"https://github.com/sindresorhus/type-fest/issues/1122","linked_issue_ids":[1353850512],"is_known_query_context":false},{"document_id":"gh_comment_2868721494","fragment_type":"issue_comment","sequence":2,"text":"@acrodrig unless I misunderstand how JSR works, you don't need this package being published to JSR to use it in your own jsr-published package; using the `npm:` specifier works just as well. Either `import type {MergeDeep} from 'npm:type-fest'` or in the CLI, `deno add npm:type-fest` and then `import type {MergeDeep} from 'type-fest'`.","author_login":"Xananax","author_association":"NONE","created_at":"2025-05-10T10:08:30+08:00","repo_name":"sindresorhus/type-fest","issue_id":3046064353,"issue_number":1122,"issue_url":"https://github.com/sindresorhus/type-fest/issues/1122","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1353850512","fragment_type":"issue_description","sequence":0,"text":"v5\n- [x] Target TypeScript 5.9\n- [x] URL \n- [x] `ArrayTail`: Make `preserveReadonly` option true by default.\n- [x] Move to ESM\n- [x] Target Node.js 20\n- [x] Make the `preserveConsecutiveUppercase` option in `CamelCase` `false` by default\n- [x] Remove this: URL \n- [x] Make `PartialDeep` `allowUndefinedInNonTupleArrays` option `false` by default.\n- [x] Make `Split` `strictLiteralChecks` option `true` by default.\n- [x] URL \n- [x] URL \n- [x] `Schema`: Remove `undefined` from `recurseIntoArrays` option.\n- [x] Add a constraint of `object` to `T` for `WritableKeysOf` and `ReadonlyKeysOf`\n- [x] Remove `strict: false` workaround: URL \n- [x] Move `ObservableLike` type to separate export since it mutates global: URL \n- [x] Decide on If/Is types.","author_login":"sindresorhus","author_association":"OWNER","created_at":"2022-08-29T07:42:24+08:00","repo_name":"sindresorhus/type-fest","issue_id":1353850512,"issue_number":450,"issue_url":"https://github.com/sindresorhus/type-fest/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2693378400","fragment_type":"issue_comment","sequence":1,"text":"@som-sm @Emiyaaaaa I'm planning v5 for right after TypeScript 5.9 is out. Probably 2-3 months out.\n\nPlease discuss here if there are any other breaking changes we should do that are not mentioned in the issue body.","author_login":"sindresorhus","author_association":"OWNER","created_at":"2025-03-03T06:15:18+08:00","repo_name":"sindresorhus/type-fest","issue_id":1353850512,"issue_number":450,"issue_url":"https://github.com/sindresorhus/type-fest/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2693438035","fragment_type":"issue_comment","sequence":2,"text":"@sindresorhus Do we want to update anything with the `If*` types, as suggested in URL \n\n \n \n\nI feel more inclined towards this, but `Is*` variants are likely much more common in codebases, so deprecating them could be annoying.","author_login":"som-sm","author_association":"COLLABORATOR","created_at":"2025-03-03T06:51:42+08:00","repo_name":"sindresorhus/type-fest","issue_id":1353850512,"issue_number":450,"issue_url":"https://github.com/sindresorhus/type-fest/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2862319953","fragment_type":"issue_comment","sequence":3,"text":"Cool @sindresorhus, I'll start creating PRs for the tasks listed here.","author_login":"som-sm","author_association":"COLLABORATOR","created_at":"2025-05-08T09:08:36+08:00","repo_name":"sindresorhus/type-fest","issue_id":1353850512,"issue_number":450,"issue_url":"https://github.com/sindresorhus/type-fest/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3171788102","fragment_type":"issue_comment","sequence":4,"text":"I think we can skip this for now, it'll required a proper rewrite, we can move it to v6.","author_login":"som-sm","author_association":"COLLABORATOR","created_at":"2025-08-09T15:33:33+08:00","repo_name":"sindresorhus/type-fest","issue_id":1353850512,"issue_number":450,"issue_url":"https://github.com/sindresorhus/type-fest/issues/450","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0280","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Configure the Log Level Colors?","query_context":"Hello, I really love this plugin but I am having trouble figuring out how to configure the coloring of various Log Levels. Currently, it seems that INFO logs are colored yellow but none of the other Log Levels are colored. I attempted to look through Intellij's menus for a configuration option regarding this and have had no luck thus far. Is this possible? Thank you!","known_context_document_ids":["gh_issue_2813925915"],"reference_answer":"@metaruslan Thank you for using the plugin and submitting feedbacks! You can configure log colors from the **Settings > Editor > Color Scheme > Console Colors > Log console**. I also wonder why JetBrains uses white instead of yellow as the default warning color.\n\n<img width=\"1094\" alt=\"image\" src=\" URL","answer_document_id":"gh_comment_2464632078","silver_evidence_path":["gh_comment_2650359396","gh_issue_2640048360","gh_comment_2464632078"],"evidence_issue_ids":[2813925915,2640048360],"source_repo_name":"orangain/pretty-json-log-plugin","source_issue_id":2813925915,"source_issue_number":107,"source_issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/107","target_repo_name":"orangain/pretty-json-log-plugin","target_issue_id":2640048360,"target_issue_number":90,"target_issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/90","reference_anchor_document_id":"gh_comment_2650359396","reference_answer_author":"orangain","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.625,"anchor_target_overlap":0.625,"target_answer_overlap":0.24},"issue_created_at":"2025-01-27T19:54:18+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_2813925915","fragment_type":"issue_description","sequence":0,"text":"Configure the Log Level Colors\nHello, I really love this plugin but I am having trouble figuring out how to configure the coloring of various Log Levels. Currently, it seems that INFO logs are colored yellow but none of the other Log Levels are colored. I attempted to look through Intellij's menus for a configuration option regarding this and have had no luck thus far. Is this possible? Thank you!","author_login":"kevin-mark-rn","author_association":"NONE","created_at":"2025-01-27T19:54:18+08:00","repo_name":"orangain/pretty-json-log-plugin","issue_id":2813925915,"issue_number":107,"issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/107","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2617059304","fragment_type":"issue_comment","sequence":1,"text":"Not 100% sure, but don't think this is configured in this plugin or in itellij. Check out colorama, I also use structlog (which uses colorama)","author_login":"fraser-langton","author_association":"NONE","created_at":"2025-01-27T22:48:02+08:00","repo_name":"orangain/pretty-json-log-plugin","issue_id":2813925915,"issue_number":107,"issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2650359396","fragment_type":"issue_comment","sequence":2,"text":"@kevin-mark-rn Thank you for using the plugin! You can configure log colors as written here.","author_login":"orangain","author_association":"OWNER","created_at":"2025-02-11T10:15:30+08:00","repo_name":"orangain/pretty-json-log-plugin","issue_id":2813925915,"issue_number":107,"issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/107","linked_issue_ids":[2640048360],"is_known_query_context":false},{"document_id":"gh_comment_2655300480","fragment_type":"issue_comment","sequence":3,"text":"oh thanks I didn't know that is what configured them, thanks! Love the plugin","author_login":"fraser-langton","author_association":"NONE","created_at":"2025-02-13T02:36:39+08:00","repo_name":"orangain/pretty-json-log-plugin","issue_id":2813925915,"issue_number":107,"issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/107","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2640048360","fragment_type":"issue_description","sequence":0,"text":"Add settings for changing colors\nI'd like to configure my own colors. For example, I would definitely make WARNs yellow, because yellow is the color of warnings usually. Currently the plugin makes INFOs yellow.\n\nGreat tool, btw!","author_login":"metaruslan","author_association":"NONE","created_at":"2024-11-07T06:44:43+08:00","repo_name":"orangain/pretty-json-log-plugin","issue_id":2640048360,"issue_number":90,"issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2464632078","fragment_type":"issue_comment","sequence":1,"text":"@metaruslan Thank you for using the plugin and submitting feedbacks! You can configure log colors from the **Settings > Editor > Color Scheme > Console Colors > Log console**. I also wonder why JetBrains uses white instead of yellow as the default warning color.\n\n<img width=\"1094\" alt=\"image\" src=\" URL","author_login":"orangain","author_association":"OWNER","created_at":"2024-11-08T12:24:34+08:00","repo_name":"orangain/pretty-json-log-plugin","issue_id":2640048360,"issue_number":90,"issue_url":"https://github.com/orangain/pretty-json-log-plugin/issues/90","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0281","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[REQ] BTDigg DHT Tracker?","query_context":"Tracker Name : BTDigg\nPublic tracker\nSupports: magnet\nIndexer URL : URL \nIndexer language : English\n\n URL","known_context_document_ids":["gh_issue_422366889"],"reference_answer":"BTDigg is working on Linux/Docker Jackett but not Windows. Unfortunately, the usual solution (spoofing the User-Agent) isn't working. Doesn't matter if I use Linux Jackett UA, a slightly modified one, or my browser's UA.\n\nUsing the Windows Jackett UA in browser does not result in a redirect, so while I'm not sure what is causing it, it doesn't seem to be the UA.\n\nI tried adding every request header being used in browser, with and without the UA, no luck. The site doesn't appear to use cookies, so there's nothing to try there.\n\nUsing a VPN, rather than Jackett's proxy settings, also doesn't work.\n\n@Woody-Stock if BTDigg is a must for you, the only solution right now would be using Docker on Windows for a Jackett container.\n\n@garfield69 any ideas what else it could be?","answer_document_id":"gh_comment_1491806580","silver_evidence_path":["gh_comment_1732111785","gh_issue_1648004388","gh_comment_1491806580"],"evidence_issue_ids":[422366889,1648004388],"source_repo_name":"Jackett/Jackett","source_issue_id":422366889,"source_issue_number":4907,"source_issue_url":"https://github.com/Jackett/Jackett/issues/4907","target_repo_name":"Jackett/Jackett","target_issue_id":1648004388,"target_issue_number":14198,"target_issue_url":"https://github.com/Jackett/Jackett/issues/14198","reference_anchor_document_id":"gh_comment_1732111785","reference_answer_author":"ilike2burnthing","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.2105,"target_answer_overlap":0.1296},"issue_created_at":"2019-03-18T18:20:50+08:00","valid_comment_count":29,"fragments":[{"document_id":"gh_issue_422366889","fragment_type":"issue_description","sequence":0,"text":"[REQ] BTDigg DHT Tracker\nTracker Name : BTDigg\nPublic tracker\nSupports: magnet\nIndexer URL : URL \nIndexer language : English\n\n URL","author_login":"zero77","author_association":"NONE","created_at":"2019-03-18T18:20:50+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1350317536","fragment_type":"issue_comment","sequence":1,"text":"note that both alternate domains are not working. I check the original onion link on a TOR browser and it is not working\ncheck back in a month and drop those alternates if still down.","author_login":"garfield69","author_association":"COLLABORATOR","created_at":"2022-12-14T03:07:15+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1356111189","fragment_type":"issue_comment","sequence":2,"text":"using the TOR browser to get to the .onion link worked this time, however the certificate is invalid (domain)\nbut the site was btdigg and searching for 2022 returned results.\nhowever the *.ly and tor2web.to alternate links still do not work on the regular browser, perhaps due to the invalid CA\nadding a certificates to the indexer, and switching to http did not help the indexer get results.","author_login":"garfield69","author_association":"COLLABORATOR","created_at":"2022-12-17T08:02:04+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1401478212","fragment_type":"issue_comment","sequence":3,"text":"onion alternates are not working again, same reason as described in URL","author_login":"garfield69","author_association":"COLLABORATOR","created_at":"2023-01-24T07:09:28+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509206786","fragment_type":"issue_comment","sequence":4,"text":"well that did not last long. URL Origin is unreachable Error code 523","author_login":"garfield69","author_association":"COLLABORATOR","created_at":"2023-04-14T20:20:28+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1675888533","fragment_type":"issue_comment","sequence":5,"text":"URL - ERR_CONNECTION_CLOSED\nOnly up for 10 of 42 Uptrends checkpoints.","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-08-12T12:25:34+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1732111785","fragment_type":"issue_comment","sequence":6,"text":"BTDigg has started actively blocking Jackett and Prowlarr traffic from linux platforms. \nThis follows a period in March URL which went on until August. While windows traffic is a smaller percentage of total Jackett users, linux (via docker or native) is a much larger user base.\nThere seems little point trying to access this site from Jackett so I shall remove this indexer.","author_login":"garfield69","author_association":"COLLABORATOR","created_at":"2023-09-22T23:01:52+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[1648004388],"is_known_query_context":false},{"document_id":"gh_comment_1732237178","fragment_type":"issue_comment","sequence":7,"text":"Not down for me at the moment, is there some dark magic going on?","author_login":"Hrxn","author_association":"NONE","created_at":"2023-09-23T07:07:38+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872539379","fragment_type":"issue_comment","sequence":8,"text":"Should leave the indexer in jackett so windows users can use it atleast. I don't see the reason for removing it entirely if it is still working for some users. It may start working again for linux at some point like it was previously with windows.","author_login":"RileyXX","author_association":"NONE","created_at":"2023-12-30T14:36:16+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[1648004388],"is_known_query_context":false},{"document_id":"gh_comment_1872545129","fragment_type":"issue_comment","sequence":9,"text":"We're not always able to directly communicate with site owners/admins, and in those cases we take hints that we're not wanted. This is one such case.","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-12-30T15:07:27+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872546208","fragment_type":"issue_comment","sequence":10,"text":"Jackett features & user experience should take priority over uncooperative site owners/admins. \n\nIf they want to attempt to block jackett traffic entirely then so be it, but if it still working for some users why not just leave it and let the user decide if they want to use it.","author_login":"RileyXX","author_association":"NONE","created_at":"2023-12-30T15:13:49+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1872551028","fragment_type":"issue_comment","sequence":11,"text":"Our userbase (and by extension, that too of Prowlarr) is large enough that we have the ability to (accidentally) DDoS sites. If a small site that is useful to the community, but is just being run off a NAS in someone's bedroom, is taken offline due us being wilfully ignorant, that serves no one. \n\nWe do not have an adversarial approach to trackers, where possible we want to work with them, improve the experience of their users, and we have made plenty of changes in the past to accommodate their needs.\n\nIf there's no easy way to communicate with site owners/admins, and we run into some change that stops Jackett from functioning properly (e.g. blocking our UA or a `latest` page), we will generally try to work around this a few times (as steps like these can often be automated rather than purposeful), but after after several attempts we will take the hint and remove the indexer.","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-12-30T15:40:59+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1873806216","fragment_type":"issue_comment","sequence":12,"text":"FYI we have the same problem .. you can track it here:\n\n- URL","author_login":"return42","author_association":"NONE","created_at":"2024-01-02T09:50:18+08:00","repo_name":"Jackett/Jackett","issue_id":422366889,"issue_number":4907,"issue_url":"https://github.com/Jackett/Jackett/issues/4907","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1648004388","fragment_type":"issue_description","sequence":0,"text":"Exception (btdigg): Got redirected to another domain. Try changing the indexer URL to URL Parse error\n### Have you checked our Troubleshooting page for your issue?\n\n- [X] I have checked the Troubleshooting page\n\n### Is there already an issue for your problem?\n\n- [X] I have checked older issues, open and closed\n\n### Have you read our Contributing Guidelines?\n\n- [X] I have read the Contributing Guidelines\n\n### Environment\n\nmarkdown\nWindows 10 x64 22H2 19045.2728\nJackett v0.20.3717 but has been happening for several weeks\nFlaresolverr deactivated as it doesn't work with proxies in its latest versions\nHTTPS5 proxy activated (the targeted website isn't accessible without it).\n\n### Description\n\nTesting the BTDIGG index returns an error.\n\n### Logged Error Messages\n\ntext\nException (btdigg): Got redirected to another domain. Try changing the indexer URL to URL Parse error\n\n### Screenshots\n\n_No response_","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-03-30T17:12:30+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1490651891","fragment_type":"issue_comment","sequence":1,"text":"Forgot to add that this seems the same issue as 12601 which was solved at the time.","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-03-30T17:13:36+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1491017411","fragment_type":"issue_comment","sequence":2,"text":"Working ok here. Try several different proxies/VPN servers if you're still having the issue.","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-03-30T21:58:45+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1491395580","fragment_type":"issue_comment","sequence":3,"text":"Tried with several different proxies and the result is always the same.\nIf that helps I'm using Privado proxies.","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-03-31T06:44:39+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1491647120","fragment_type":"issue_comment","sequence":4,"text":"Using the same proxies, are you able to access URL in browser?","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-03-31T09:46:39+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1491806580","fragment_type":"issue_comment","sequence":5,"text":"BTDigg is working on Linux/Docker Jackett but not Windows. Unfortunately, the usual solution (spoofing the User-Agent) isn't working. Doesn't matter if I use Linux Jackett UA, a slightly modified one, or my browser's UA.\n\nUsing the Windows Jackett UA in browser does not result in a redirect, so while I'm not sure what is causing it, it doesn't seem to be the UA.\n\nI tried adding every request header being used in browser, with and without the UA, no luck. The site doesn't appear to use cookies, so there's nothing to try there.\n\nUsing a VPN, rather than Jackett's proxy settings, also doesn't work.\n\n@Woody-Stock if BTDigg is a must for you, the only solution right now would be using Docker on Windows for a Jackett container.\n\n@garfield69 any ideas what else it could be?","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-03-31T11:47:38+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1492021883","fragment_type":"issue_comment","sequence":6,"text":"OK thanks for the answer, I will try that but never used Docker, so it will be a learning curve.","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-03-31T14:35:06+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1492868857","fragment_type":"issue_comment","sequence":7,"text":"none whatso ever ;-(\never the .onion link which works in a TOR browser does not work with the .ly or web2tor.to proxies.","author_login":"garfield69","author_association":"COLLABORATOR","created_at":"2023-04-01T07:55:58+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1492871462","fragment_type":"issue_comment","sequence":8,"text":"Yes those TOR links stopped working a while ago but if this can be any indication, I think the regular link ( URL stopped working before that over a proxy (well the ones from Privado at the very least).\n\nIt is when those TOR links stopped working that I reverted back to the regular link and saw it didn't work. I always try to use the \"real\" link over alternate ones, so if I had configured TOR links at the time, it's probably because the original one didn't work for me. I honestly don't remember. I first assumed that this will be fixed in a next release but when it wasn't and saw on here it wasn't flagged I decided to open the issue.\n\nSince then the TOR links were removed from BTDigg's Jackett indexer and not replaced unfortunately.","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-04-01T08:03:12+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1492894159","fragment_type":"issue_comment","sequence":9,"text":"Just tried changing the UA in BrowserUtil.cs in case it was somehow picking up that the UA was spoofed, but no.\n\nAlso tried adding `webclient.EmulateBrowser = false` to Cardigann, didn't help.\n\nLeaving this open for some future bright spark to solve, but I wouldn't hold your breath.","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-04-01T09:38:15+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1501095510","fragment_type":"issue_comment","sequence":10,"text":"facing the same issue, using windows ver. with Flaresolverr activated; therefore no proxies.","author_login":"sponnify","author_association":"NONE","created_at":"2023-04-09T10:24:21+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1502134457","fragment_type":"issue_comment","sequence":11,"text":"Newly added *.tor2web.link mirror working on Windows Jackett - URL","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-04-10T18:09:44+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1509721789","fragment_type":"issue_comment","sequence":12,"text":"The TOR link doesn't seem to work anymore so we're back to square one...","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-04-15T10:32:31+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1545114180","fragment_type":"issue_comment","sequence":13,"text":"So has btdig implented something to detect jacket searches somehow? What is the relation to domflow.it? \n\nSeems to me that btdigg is intentionally redirecting jackett searches to a dummy domain, probably to force people to use their site directly. It's possible that the redirect is happening at the cloudflare level. To fix this will probably require changing the way jackett indexes btdigg to avoid detection. \n\nCan someone point me in the right direction on where in the jackett repository we should be looking in order to modify the code for how jackett uses btdigg? I'd like to take a crack at this. Thanks","author_login":"RileyXX","author_association":"NONE","created_at":"2023-05-12T04:44:40+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575499370","fragment_type":"issue_comment","sequence":14,"text":"Is the following code relevant? In URL \n\nI was trying to skim through the code for jackett to figure out how btdig could be identifying requests coming from jackett. Maybe this will give some clues. I don't think the definitions will be helpful. The core code probably needs to be modified in order to avoid detection for this indexer. Perhaps btdig is able to identify the requests coming from jackett via referer or request type? Or maybe when emulateBrowser is null? Possibly a combination of things including the user-agent.\n\nHard to say, but the code is a bit steep for me since I am not proficient in CS. I'm curious how the requests coming from jackett look in cloudflare because that's probably where the redirect is coming from. Admins of btdig probably setup some redirect rules to match requests coming from jackett. Someone with more knowledge will have to investigate further.\n\ncs\n protected virtual async Task RequestWithCookiesAsync(\n string url, string cookieOverride = null, RequestType method = RequestType.GET,\n string referer = null, IEnumerable > data = null,\n Dictionary headers = null, string rawbody = null, bool? emulateBrowser = null)\n {\n var request = new WebRequest\n {\n Url = url,\n Type = method,\n Cookies = cookieOverride ?? CookieHeader,\n PostData = data,\n Referer = referer,\n Headers = headers,\n RawBody = rawbody,\n Encoding = Encoding\n };\n\n if (emulateBrowser.HasValue)\n request.EmulateBrowser = emulateBrowser.Value;\n var result = await webclient.GetResultAsync(request);\n CheckSiteDown(result);\n UpdateCookieHeader(result.Cookies, cookieOverride);\n return result;\n }","author_login":"RileyXX","author_association":"NONE","created_at":"2023-06-04T10:04:33+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575761274","fragment_type":"issue_comment","sequence":15,"text":"I did try playing with UA and `EmulateBrowser` but didn't get anywhere. I assume that's where the issue lies, but 🤷","author_login":"ilike2burnthing","author_association":"COLLABORATOR","created_at":"2023-06-04T22:48:48+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1591205333","fragment_type":"issue_comment","sequence":16,"text":"If this can be any help, I have the exact same error from Prowlarr.\nSo it seems this comes from BTDigg, rather than Jackett itself.\nAs someone suggested, it may be on purpose.","author_login":"Woody-Stock","author_association":"NONE","created_at":"2023-06-14T13:24:30+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1691422982","fragment_type":"issue_comment","sequence":17,"text":"Today I noticed this indexer is working again. Can anyone else confirm? \n\nI am getting successful tests in Jackett dashboard and successful searches/downloads in sonarr.","author_login":"RileyXX","author_association":"NONE","created_at":"2023-08-24T10:28:10+08:00","repo_name":"Jackett/Jackett","issue_id":1648004388,"issue_number":14198,"issue_url":"https://github.com/Jackett/Jackett/issues/14198","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0282","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Implementation details for Grad-CAM visualization?","query_context":"Thank you for creating and maintaining this wonderful project. I've been working with your codebase and found it very insightful.\n\nI noticed that the project includes Grad-CAM visualizations, but I couldn't find any related packages like `torch grad-cam` in the requirements. I tried to reproduce the visualization part but encountered some difficulties. Would it be possible to share some example code about how the Grad-CAM visualization is implemented in this project?\n\nThank you very much for your time and consideration. Any guidance would be greatly appreciated!","known_context_document_ids":["gh_issue_2860676764"],"reference_answer":"Yes, we just use `targets = None` and vanilla GradCAM from the pytorch-grad-cam library ( URL","answer_document_id":"gh_comment_2461243746","silver_evidence_path":["gh_comment_2666784210","gh_issue_2636078790","gh_comment_2461243746"],"evidence_issue_ids":[2860676764,2636078790],"source_repo_name":"luccachiang/robots-pretrain-robots","source_issue_id":2860676764,"source_issue_number":7,"source_issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/7","target_repo_name":"luccachiang/robots-pretrain-robots","target_issue_id":2636078790,"target_issue_number":2,"target_issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/2","reference_anchor_document_id":"gh_comment_2666784210","reference_answer_author":"guangnianyuji","reference_answer_author_association":"COLLABORATOR","quality_score":86.83,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.0833,"target_answer_overlap":0.8571},"issue_created_at":"2025-02-18T14:46:36+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2860676764","fragment_type":"issue_description","sequence":0,"text":"Implementation details for Grad-CAM visualization\nThank you for creating and maintaining this wonderful project. I've been working with your codebase and found it very insightful.\n\nI noticed that the project includes Grad-CAM visualizations, but I couldn't find any related packages like `torch grad-cam` in the requirements. I tried to reproduce the visualization part but encountered some difficulties. Would it be possible to share some example code about how the Grad-CAM visualization is implemented in this project?\n\nThank you very much for your time and consideration. Any guidance would be greatly appreciated!","author_login":"WuDuidi","author_association":"NONE","created_at":"2025-02-18T14:46:36+08:00","repo_name":"luccachiang/robots-pretrain-robots","issue_id":2860676764,"issue_number":7,"issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/7","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2666784210","fragment_type":"issue_comment","sequence":1,"text":"Hi, did you check #2? It should not involve too many modifications to the original PyTorch grad-cam implementation. We will provide an example soon.","author_login":"luccachiang","author_association":"OWNER","created_at":"2025-02-18T19:46:16+08:00","repo_name":"luccachiang/robots-pretrain-robots","issue_id":2860676764,"issue_number":7,"issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/7","linked_issue_ids":[2636078790],"is_known_query_context":false},{"document_id":"gh_comment_2670857753","fragment_type":"issue_comment","sequence":2,"text":"@WuDuidi Could you specify the difficulties you are encountering? I have identified the following common issues:\n\n1. Absence of gradients for generating Grad-CAM – This typically occurs when the model or a specific layer is frozen. To resolve this, it is necessary to explicitly set `requires_grad=True` to allow gradient computation.\n2. Incorrect layer selection within the model – In such cases, it is advisable to print the complete architecture of the model to verify that the selected layer exists and is correctly assigned.\n\nI may not recall all potential issues at the moment. However, if you encounter any, please let me know, and I will do my best to assist you.","author_login":"guangnianyuji","author_association":"COLLABORATOR","created_at":"2025-02-20T09:01:13+08:00","repo_name":"luccachiang/robots-pretrain-robots","issue_id":2860676764,"issue_number":7,"issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/7","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2636078790","fragment_type":"issue_description","sequence":0,"text":"Grad-CAM Visualization\nHello! For the Grad-CAM visualizations in your paper, did you just use `targets = None` and vanilla GradCAM from the pytorch-grad-cam library? Thanks!","author_login":"juseonghan","author_association":"NONE","created_at":"2024-11-05T17:34:24+08:00","repo_name":"luccachiang/robots-pretrain-robots","issue_id":2636078790,"issue_number":2,"issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/2","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2461243746","fragment_type":"issue_comment","sequence":1,"text":"Yes, we just use `targets = None` and vanilla GradCAM from the pytorch-grad-cam library ( URL","author_login":"guangnianyuji","author_association":"COLLABORATOR","created_at":"2024-11-07T03:27:09+08:00","repo_name":"luccachiang/robots-pretrain-robots","issue_id":2636078790,"issue_number":2,"issue_url":"https://github.com/luccachiang/robots-pretrain-robots/issues/2","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0284","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[GAME BUG]: [Debug] memory.cpp:operator():293: Assertion Failed!","query_context":"### Checklist (we expect you to perform these steps before opening the issue)\n\n- [X] I have searched for a similar issue in this repository and did not find one.\n- [X] I am using an official build obtained from releases or updated one of those builds using its in-app updater.\n- [X] I have re-dumped the game and performed a clean install without mods and the issue is still present.\n- [X] I have disabled all patches and cheats and the issue is still present.\n- [X] I have all the required system modules installed.\n\n### Describe the Bug\n\nAfter quick search, it seems neither CUSA00076 (The Order 1886) or memory.cpp:operator related issues are opened right now here\n\n### Reproduction Steps\n\nGame crashes on launch with this error:\n[Debug] memory.cpp:operator():293: Assertion Failed!\n\n1.00 and 1.02 version of game (without patch) have similar crash.\n\n### Specify OS Version\n\nWindows 10\n\n### CPU\n\nIntel Core i5-10600KF\n\n### GPU\n\nNvidia Geforce rtx 3070\n\n### Amount of RAM in GB\n\n48\n\n### Amount of VRAM in GB\n\n8\n\n### Log File\n\nshad_log.zip","known_context_document_ids":["gh_issue_2782050350"],"reference_answer":"@StevenMiller123 I close the other one and let you report every games you tested with this error here. Thanks you :)","answer_document_id":"gh_comment_2386389946","silver_evidence_path":["gh_comment_2585363776","gh_issue_2511458136","gh_comment_2386389946"],"evidence_issue_ids":[2782050350,2511458136],"source_repo_name":"shadps4-emu/shadPS4","source_issue_id":2782050350,"source_issue_number":2128,"source_issue_url":"https://github.com/shadps4-emu/shadPS4/issues/2128","target_repo_name":"shadps4-emu/shadPS4","target_issue_id":2511458136,"target_issue_number":825,"target_issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","reference_anchor_document_id":"gh_comment_2585363776","reference_answer_author":"Hermiten","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1579,"anchor_target_overlap":0.3684,"target_answer_overlap":0.0},"issue_created_at":"2025-01-11T18:12:39+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2782050350","fragment_type":"issue_description","sequence":0,"text":"[GAME BUG]: [Debug] memory.cpp:operator():293: Assertion Failed!\n### Checklist (we expect you to perform these steps before opening the issue)\n\n- [X] I have searched for a similar issue in this repository and did not find one.\n- [X] I am using an official build obtained from releases or updated one of those builds using its in-app updater.\n- [X] I have re-dumped the game and performed a clean install without mods and the issue is still present.\n- [X] I have disabled all patches and cheats and the issue is still present.\n- [X] I have all the required system modules installed.\n\n### Describe the Bug\n\nAfter quick search, it seems neither CUSA00076 (The Order 1886) or memory.cpp:operator related issues are opened right now here\n\n### Reproduction Steps\n\nGame crashes on launch with this error:\n[Debug] memory.cpp:operator():293: Assertion Failed!\n\n1.00 and 1.02 version of game (without patch) have similar crash.\n\n### Specify OS Version\n\nWindows 10\n\n### CPU\n\nIntel Core i5-10600KF\n\n### GPU\n\nNvidia Geforce rtx 3070\n\n### Amount of RAM in GB\n\n48\n\n### Amount of VRAM in GB\n\n8\n\n### Log File\n\nshad_log.zip","author_login":"isshininu","author_association":"CONTRIBUTOR","created_at":"2025-01-11T18:12:39+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2782050350,"issue_number":2128,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/2128","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2585363776","fragment_type":"issue_comment","sequence":1,"text":"This issue URL is sort of similar to opened, with exception that \"Mapping cannot fit inside free region\" part is completely absent, and also not fixed unlike listed games.","author_login":"isshininu","author_association":"NONE","created_at":"2025-01-11T18:17:24+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2782050350,"issue_number":2128,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/2128","linked_issue_ids":[2511458136],"is_known_query_context":false},{"document_id":"gh_comment_2653642892","fragment_type":"issue_comment","sequence":2,"text":"Hello, I'm closing this one, this is now tagged with a label and also present in the wiki:\n URL \n\nThanks you","author_login":"Hermiten","author_association":"COLLABORATOR","created_at":"2025-02-12T12:58:46+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2782050350,"issue_number":2128,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/2128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2511458136","fragment_type":"issue_description","sequence":0,"text":"[Aggregate Issue] Mapping cannot fit inside free region\nSeparated as aggregate.\n\nFat princess adventures - CUSA01660\n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0x200000\n\nDiablo II Resurrected - CUSA28305\n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0x96800000","author_login":"gandalfthewhite19890404","author_association":"NONE","created_at":"2024-09-07T04:20:48+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2335040788","fragment_type":"issue_comment","sequence":1,"text":"Resident Evil 2 (2019) - CUSA09171\n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0xce000000","author_login":"gandalfthewhite19890404","author_association":"NONE","created_at":"2024-09-07T04:47:53+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2353998905","fragment_type":"issue_comment","sequence":2,"text":"@polybiusproxy Should we move the remaining crash logs from #601 here? All the remaining ones are the same type of error as this. It would make testing easier since we wont need to test on a month old build.","author_login":"StevenMiller123","author_association":"CONTRIBUTOR","created_at":"2024-09-16T20:46:04+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2386389946","fragment_type":"issue_comment","sequence":3,"text":"@StevenMiller123 I close the other one and let you report every games you tested with this error here. Thanks you :)","author_login":"Hermiten","author_association":"COLLABORATOR","created_at":"2024-10-01T15:54:21+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2393577282","fragment_type":"issue_comment","sequence":4,"text":"Call of Duty®: Advanced Warfare v1.00 - CUSA00803\n\n[Debug] memory.cpp:operator():640: Assertion Failed!\nMapping cannot fit inside free region: size = 0x80000000\n\nCrash™ Team Racing Nitro-Fueled v1.00 - CUSA13795\n\n[Debug] memory.cpp:operator():640: Assertion Failed!\nMapping cannot fit inside free region: size = 0x20000000","author_login":"StevenMiller123","author_association":"CONTRIBUTOR","created_at":"2024-10-04T12:18:46+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2418478724","fragment_type":"issue_comment","sequence":5,"text":"Kai No Kieski v1.00 - CUSA49295\n\n[Debug] memory.cpp:operator():644: Assertion Failed!\nMapping cannot fit inside free region: size = 0x24000000","author_login":"Rokkag","author_association":"NONE","created_at":"2024-10-17T04:35:09+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2509787424","fragment_type":"issue_comment","sequence":6,"text":"CUSA32600 - ARMORED CORE™ VI FIRES OF RUBICON™ URL \n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0x1ad00000\n\nCUSA10525 - Darkest Dungeon URL \n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0xc0000\n\nCUSA12474 - TOKYO GHOUL:re CALL to EXIST URL \n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0x21810000\n\nCUSA00634 - STAR WARS™ Battlefront™ URL \n\n[Debug] memory.cpp:operator():544: Assertion Failed!\nMapping cannot fit inside free region\n\nCUSA40994 - Amnesia: The Bunker URL \n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0xa5e00000\n\nCUSA13801 - Sekiro™: Shadows Die Twice URL \n\n[Debug] memory.cpp:operator():568: Assertion Failed! \nMapping cannot fit inside free region: size = 0xc0000000\n\nCUSA19264 - 妖怪学園Y ～ワイワイ学園生活～/Yokai Academy Y: Lively School Life URL \n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0x300000\n\nCUSA18880 ELDEN RING™ Network Test Ver URL \n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0x4000000\n\nCUSA28832 - 那由多之軌跡：改 (Nayuta no Kiseki KAI) URL \n\n[Debug] memory.cpp:operator():415: Assertion Failed!\nMapping cannot fit inside free region\n\nCUSA19640 - Persona 5 Strikers URL \n\n[Debug] memory.cpp:operator():568: Assertion Failed!\nMapping cannot fit inside free region: size = 0xd2800000","author_login":"Hermiten","author_association":"COLLABORATOR","created_at":"2024-12-01T14:12:53+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2525373478","fragment_type":"issue_comment","sequence":7,"text":"CUSA28194 - SONIC FRONTIERS shadps4-emu/shadps4-game-compatibility#388\n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0x52000000\n\nCUSA32600 - ARMORED CORE™ VI FIRES OF RUBICON™ shadps4-emu/shadps4-game-compatibility#1263\n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0x1ad00000\n\nCUSA18723 - ELDEN RING™ shadps4-emu/shadps4-game-compatibility#1332\n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0x20000000\n\nCUSA11993 - Marvel's Spider-Man shadps4-emu/shadps4-game-compatibility#1353\n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0x10000000\n\nCUSA17776 - Marvel's Spider-Man: Miles Morales shadps4-emu/shadps4-game-compatibility#978\n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0xdb00000\n\nCUSA13801 - Sekiro™: Shadows Die Twice shadps4-emu/shadps4-game-compatibility#688\n\n[Debug] memory.cpp:operator():655: Assertion Failed!\nMapping cannot fit inside free region: size = 0xc0000000","author_login":"kvicken","author_association":"NONE","created_at":"2024-12-08T01:39:52+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2537475514","fragment_type":"issue_comment","sequence":8,"text":"CUSA04301 - Dreams™\n\n[Debug] memory.cpp:operator():663: Assertion Failed!\nMapping cannot fit inside free region: size = 0x4000000","author_login":"smiRaphi","author_association":"NONE","created_at":"2024-12-12T00:23:28+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2551046737","fragment_type":"issue_comment","sequence":9,"text":"CUSA15325 - Yakuza 3\n\n[Debug] memory.cpp:operator():663: Assertion Failed!\nMapping cannot fit inside free region: size = 0x9800000\n\nshad_log.txt","author_login":"bigol83","author_association":"CONTRIBUTOR","created_at":"2024-12-18T11:14:50+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564320536","fragment_type":"issue_comment","sequence":10,"text":"@gandalfthewhite19890404 , @StevenMiller123, @kvicken can we close it ?\nThis URL normally fix it","author_login":"Hermiten","author_association":"COLLABORATOR","created_at":"2024-12-28T13:04:23+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564337775","fragment_type":"issue_comment","sequence":11,"text":"@Hermiten I agree this should be closed. The main \"regression\" we were tracking is fixed, and most of the games listed here are confirmed to be fixed.","author_login":"StevenMiller123","author_association":"CONTRIBUTOR","created_at":"2024-12-28T14:28:18+08:00","repo_name":"shadps4-emu/shadPS4","issue_id":2511458136,"issue_number":825,"issue_url":"https://github.com/shadps4-emu/shadPS4/issues/825","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0285","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"TypeError: Cannot read properties of undefined (reading 'color')?","query_context":"### Steps to Reproduce\n \n \n1. Update the windows app to version 8.0.7\n2. In the left pane, select the ellipses next to Today -> Worklog\n3. Click on any of the Dates\n4. The popup appears.\n\n### Error Log (Desktop only)\n \n\n### Console Output\n \n\n### Meta Info\nMETA: SP8.0.7 Browser – en-US – Win32 – Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 Edg/125.0.0.0\n\n### Stacktrace\n\ni0 (webpack:///src/app/features/worklog/worklog.component.html:134:34)\nsetSelectedIndex (webpack:///node_modules/@angular/core/fesm2015/core.mjs:12112:8)\nsetBindingIndex (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11975:12)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\n\n### Actions Before Error\n\n1718188298709: [Task] Add time spent \n1718188298712: [Tag] Update Work End for Tag \n1718188298714: [Persistence] Save to DB (2) \n1718188358710: [Task] Add time spent \n1718188358714: [Tag] Update Work End for Tag \n1718188358716: [Persistence] Save to DB (2) \n1718188418705: [Task] Add time spent \n1718188418709: [Tag] Update Work End for Tag \n1718188418711: [Persistence] Save to DB (2) \n1718188458169: [Task] Add time spent \n1718188458172: [Tag] Update Work End for Tag \n1718188458174: [Persistence] Save to DB (2) \n1718188458415: [Task] Add time spent \n1718188458418: [Tag] Update Work End for Tag \n1718188458419: [Persistence] Save to DB (2) \n1718188459425: [Task] Add time spent \n1718188459428: [Tag] Update Work End for Tag \n1718188459429: [Persistence] Save to DB (2) \n1718188460413: [Task] Add time spent \n1718188460415: [Tag] Update Work End for Tag \n1718188460416: [Persistence] Save to DB (2) \n1718188461422: [Task] Add time spent \n1718188461424: [Tag] Update Work End for Tag \n1718188461425: [Persistence] Save to DB (2) \n1718188462425: [Task] Add time spent \n1718188462427: [Tag] Update Work End for Tag \n1718188462428: [Persistence] Save to DB (2) \n1718188463559: [FocusMode] Set focus session elapsed time \n1718188463705: [SP_ALL] Load(import) all data \n1718188463708: [SP_ALL] All Data was loaded","known_context_document_ids":["gh_issue_2348427718"],"reference_answer":"I think I was able to fix this. Hope to make a bug fix release tomorrow or on Monday! Sorry for the inconvenience!","answer_document_id":"gh_comment_2168329539","silver_evidence_path":["gh_comment_2165372579","gh_issue_2332795800","gh_comment_2168329539"],"evidence_issue_ids":[2348427718,2332795800],"source_repo_name":"johannesjo/super-productivity","source_issue_id":2348427718,"source_issue_number":3214,"source_issue_url":"https://github.com/johannesjo/super-productivity/issues/3214","target_repo_name":"johannesjo/super-productivity","target_issue_id":2332795800,"target_issue_number":3208,"target_issue_url":"https://github.com/johannesjo/super-productivity/issues/3208","reference_anchor_document_id":"gh_comment_2165372579","reference_answer_author":"johannesjo","reference_answer_author_association":"OWNER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.2222,"target_answer_overlap":0.0},"issue_created_at":"2024-06-12T10:39:03+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2348427718","fragment_type":"issue_description","sequence":0,"text":"TypeError: Cannot read properties of undefined (reading 'color')\n### Steps to Reproduce\n \n \n1. Update the windows app to version 8.0.7\n2. In the left pane, select the ellipses next to Today -> Worklog\n3. Click on any of the Dates\n4. The popup appears.\n\n### Error Log (Desktop only)\n \n\n### Console Output\n \n\n### Meta Info\nMETA: SP8.0.7 Browser – en-US – Win32 – Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 Edg/125.0.0.0\n\n### Stacktrace\n\ni0 (webpack:///src/app/features/worklog/worklog.component.html:134:34)\nsetSelectedIndex (webpack:///node_modules/@angular/core/fesm2015/core.mjs:12112:8)\nsetBindingIndex (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11975:12)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\n\n### Actions Before Error\n\n1718188298709: [Task] Add time spent \n1718188298712: [Tag] Update Work End for Tag \n1718188298714: [Persistence] Save to DB (2) \n1718188358710: [Task] Add time spent \n1718188358714: [Tag] Update Work End for Tag \n1718188358716: [Persistence] Save to DB (2) \n1718188418705: [Task] Add time spent \n1718188418709: [Tag] Update Work End for Tag \n1718188418711: [Persistence] Save to DB (2) \n1718188458169: [Task] Add time spent \n1718188458172: [Tag] Update Work End for Tag \n1718188458174: [Persistence] Save to DB (2) \n1718188458415: [Task] Add time spent \n1718188458418: [Tag] Update Work End for Tag \n1718188458419: [Persistence] Save to DB (2) \n1718188459425: [Task] Add time spent \n1718188459428: [Tag] Update Work End for Tag \n1718188459429: [Persistence] Save to DB (2) \n1718188460413: [Task] Add time spent \n1718188460415: [Tag] Update Work End for Tag \n1718188460416: [Persistence] Save to DB (2) \n1718188461422: [Task] Add time spent \n1718188461424: [Tag] Update Work End for Tag \n1718188461425: [Persistence] Save to DB (2) \n1718188462425: [Task] Add time spent \n1718188462427: [Tag] Update Work End for Tag \n1718188462428: [Persistence] Save to DB (2) \n1718188463559: [FocusMode] Set focus session elapsed time \n1718188463705: [SP_ALL] Load(import) all data \n1718188463708: [SP_ALL] All Data was loaded","author_login":"riyaan","author_association":"NONE","created_at":"2024-06-12T10:39:03+08:00","repo_name":"johannesjo/super-productivity","issue_id":2348427718,"issue_number":3214,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3214","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2164774167","fragment_type":"issue_comment","sequence":1,"text":"Hey there! Thank you very much for reporting this!\n\nIt might be that for some reason a bit of your data got into an invalid state that I didn't account for and that I can't reproduce. It would be great if you could share a copy of your data to contact@super-productivity.com, so I can debug this on my computer (and please let me know here, if you send something, as those mails quite often land in the spam folder). You can create an export by navigating to \"Settings\" and then to \"Import/Export\" or you can use the \"Export data\" button from the error Dialog (there is also a button there which will anonymize the data before exporting).","author_login":"johannesjo","author_association":"OWNER","created_at":"2024-06-13T07:15:49+08:00","repo_name":"johannesjo/super-productivity","issue_id":2348427718,"issue_number":3214,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3214","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2165372579","fragment_type":"issue_comment","sequence":2,"text":"duplicate URL \n\nat least one task of the day must not be assigned to a project.","author_login":"kvieto","author_association":"NONE","created_at":"2024-06-13T11:23:29+08:00","repo_name":"johannesjo/super-productivity","issue_id":2348427718,"issue_number":3214,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3214","linked_issue_ids":[2332795800],"is_known_query_context":false},{"document_id":"gh_comment_2165376798","fragment_type":"issue_comment","sequence":3,"text":"Hi. Thanks for responding to my email.\n\nI have sent an email (*Subject: Issue #3214 - Data export*) with the copy\nof my data.\n\nRegards,\nRiyaan\n\n \n\nOn Thu, Jun 13, 2024 at 9:16 AM Johannes Millan ***@***.***>\nwrote:","author_login":"riyaan","author_association":"NONE","created_at":"2024-06-13T11:25:27+08:00","repo_name":"johannesjo/super-productivity","issue_id":2348427718,"issue_number":3214,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3214","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2332795800","fragment_type":"issue_description","sequence":0,"text":"TypeError: Cannot read properties of undefined (reading 'color')\n### Steps to Reproduce\n1. Open the \"Worklog\"\n2. Expand a day with some task\n\n### Error Log (Desktop only)\n \n\n### Console Output\n \n\n### Meta Info\nMETA: SP8.0.7 Electron – it – Win32 – Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) superProductivity/8.0.7 Chrome/122.0.6261.156 Electron/29.2.0 Safari/537.36\n\n### Stacktrace\n\ni0 (webpack:///src/app/features/worklog/worklog.component.html:134:34)\nsetSelectedIndex (webpack:///node_modules/@angular/core/fesm2015/core.mjs:12112:8)\nsetBindingIndex (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11975:12)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\nexecuteCheckHooks (webpack:///node_modules/@angular/core/fesm2015/core.mjs:11999:29)\nviewAttachedToChangeDetector (webpack:///node_modules/@angular/core/fesm2015/core.mjs:13025:16)\n\n### Actions Before Error\n\n1717432546870: [Persistence] Save to DB (2) \n1717432547865: [Task] Add time spent \n1717432547866: [Tag] Update Work End for Tag \n1717432547869: [Persistence] Save to DB (2) \n1717432548864: [Task] Add time spent \n1717432548866: [Tag] Update Work End for Tag \n1717432548867: [Persistence] Save to DB (2) \n1717432549400: [Layout] Hide SideBar \n1717432549871: [Task] Add time spent \n1717432549872: [Tag] Update Work End for Tag \n1717432549874: [Persistence] Save to DB (2) \n1717432550865: [Task] Add time spent \n1717432550867: [Tag] Update Work End for Tag \n1717432550868: [Persistence] Save to DB (2) \n1717432551026: [Pomodoro] Stop Pomodoro \n1717432551027: [Task] UnsetCurrentTask \n1717432551029: [Pomodoro] Pause Pomodoro \n1717432556824: [Task] Update Task \n1717432557072: [Persistence] Save to DB \n1717432560045: [Task] SetSelectedTask \n1717432560052: [Layout] Hide Notes \n1717432563438: [Task] Move to archive \n1717432563441: [Persistence] Save to DB (2) \n1717432563442: [Task] UnsetCurrentTask \n1717432563442: [Pomodoro] Pause Pomodoro \n1717432563499: [Persistence] Save to DB \n1717486530111: [FocusMode] Set focus session elapsed time \n1717486530406: [SP_ALL] Load(import) all data \n1717486530410: [Idle] Reset \n1717486530411: [SP_ALL] All Data was loaded","author_login":"APsAntonioli","author_association":"NONE","created_at":"2024-06-04T07:44:28+08:00","repo_name":"johannesjo/super-productivity","issue_id":2332795800,"issue_number":3208,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2146881247","fragment_type":"issue_comment","sequence":1,"text":"I have this problem only in the \"Today\" worklog. The worklogs of my personal projects work good.","author_login":"APsAntonioli","author_association":"NONE","created_at":"2024-06-04T08:09:12+08:00","repo_name":"johannesjo/super-productivity","issue_id":2332795800,"issue_number":3208,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2147693927","fragment_type":"issue_comment","sequence":2,"text":"Same here. It crashes when you open a day in worklog view and there is at least one task **without project**. If all tasks have project it works fine.","author_login":"albertopesquerabrooktec","author_association":"NONE","created_at":"2024-06-04T14:32:37+08:00","repo_name":"johannesjo/super-productivity","issue_id":2332795800,"issue_number":3208,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2148903896","fragment_type":"issue_comment","sequence":3,"text":"the same since yesterday app update.\ntoday->worklog causes app error state.","author_login":"kvieto","author_association":"NONE","created_at":"2024-06-05T05:44:23+08:00","repo_name":"johannesjo/super-productivity","issue_id":2332795800,"issue_number":3208,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3208","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168329539","fragment_type":"issue_comment","sequence":4,"text":"I think I was able to fix this. Hope to make a bug fix release tomorrow or on Monday! Sorry for the inconvenience!","author_login":"johannesjo","author_association":"OWNER","created_at":"2024-06-14T16:03:09+08:00","repo_name":"johannesjo/super-productivity","issue_id":2332795800,"issue_number":3208,"issue_url":"https://github.com/johannesjo/super-productivity/issues/3208","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0287","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"netkit vs route tables?","query_context":"### Is there an existing issue for this?\n\n- [x] I have searched the existing issues\n\n### Version\n\nequal or higher than v1.17.1 and lower than v1.18.0\n\n### What happened?\n\nnode have two interface called private and public. both exist in cilium devices list.\npublic interface by default do not have IP address.\nit get ip address when kube-vip discovers a loadbalancer service, then kube-vip assign a public ip.\npublic ip not enough in this network environment, it also needs a route. since default route already exist in the private link we use SBR, so the system creates a new route table with the gateway for the public address and place an ip rule about if from address is the public ip then use that route table. this is how the node can respond requests on the public interface while still the default route belongs to the private interface.\n\nif the bpf.datapathMode set to veth all ok with cilium networking, all test run.\nif the bpf.datapathMode set to netkit every other node ok, but the node who have a public ip + routes goes wrong. in this node what we experienced that the node can't communicate with the pods which running on that node.\nif we move the public ip to another node, the node-pod network starts to work, and goes wrong on that node which got the public ip.\nThis is only reproducable in netkit mode.\nAny ideas? How we can debug this further?\n\n### How can we reproduce the issue?\n\ncilium installed with helm:\n\nautoDirectNodeRoutes: true\nbandwidthManager:\n enabled: true\nbgpControlPlane:\n secretsNamespace:\n create: false\nbpf:\n datapathMode: veth\n hostLegacyRouting: false\n lbExternalClusterIP: true\n masquerade: true\ncluster:\n id: 1\n name: sg1-kubego-io\nclusterDomain: k8s.sg1.example.com\ncni:\n exclusive: false\ndashboards:\n enabled: true\ndebug:\n enabled: false\ndevices: public private wg+\nenableIPv4Masquerade: true\nenableRuntimeDeviceDetection: true\nendpointRoutes:\n enabled: true\nenvoyConfig:\n secretsNamespace:\n create: false\nhostFirewall:\n enabled: true\nhostPort:\n enabled: true\nipam:\n mode: multi-pool\n operator:\n autoCreateCiliumPodIPPools:\n default:\n ipv4:\n cidrs:\n - 10.207.0.0/23\n maskSize: 28\n dashboards:\n enabled: true\n namespace: monitoring\n multiPoolPreAllocation: false\n prometheus:\n enabled: true\n labels:\n release: prometheus\n metricRelabelings: null\nipv4NativeRoutingCIDR: 10.207.0.0/19\nipv6:\n enabled: false\nk8s:\n requireIPv4PodCIDR: true\n requireIPv6PodCIDR: false\nk8sServiceHost: kube-api.example.com\nk8sServicePort: 443\nkubeProxyReplacement: true\nl7Proxy: true\nloadBalancer:\n acceleration: best-effort\n algorithm: maglev\n mode: dsr\nnodePort:\n enabled: true\noperator:\n dashboards:\n enabled: true\n namespace: monitoring\n prometheus:\n enabled: true\n interval: 60s\n labels:\n release: prometheus\n metricRelabelings: null\n replicas: 1\n rollOutPods: true\nprometheus:\n enabled: true\n serviceMonitor:\n enabled: true\n interval: 60s\n labels:\n release: prometheus\nrouting-mode: native\nroutingMode: native\nsecretsNamespace:\n create: false\n sync: false\nsocketLB:\n enabled: true\n hostNamespaceOnly: true\n\nwitch config above everything works as expected using public ip that way mentioned above.\nif you set this:\n\nbpf:\n datapathMode: netkit\n\neverything works as expected until a node get a public ip and sbr.\n\n### Cilium Version\n\n1.16.x/1.17.x\n\n### Kernel Version\n\n6.8.x\n\n### Kubernetes Version\n\n1.31.x\n\n### Regression\n\n_No response_\n\n### Sysdump\n\n_No response_\n\n### Relevant log output\n\nshell\n\n### Anything else?\n\n_No response_\n\n### Cilium Users Document\n\n- [ ] Are you a user of Cilium? Please add yourself to the Users doc\n\n### Code of Conduct\n\n- [x] I agree to follow this project's Code of Conduct","known_context_document_ids":["gh_issue_2892335118"],"reference_answer":"Hah, okay, thanks for testing and taking a look. I presume NETKIT_SCRUB_NONE generally could be enough as an option anyway and if needed BPF prog could zero the data. I'll finalize and add a BPF selftest (next week) so that this can be submitted & merged then.","answer_document_id":"gh_comment_2378646870","silver_evidence_path":["gh_comment_2699445233","gh_issue_2551539057","gh_comment_2378646870"],"evidence_issue_ids":[2892335118,2551539057],"source_repo_name":"cilium/cilium","source_issue_id":2892335118,"source_issue_number":37976,"source_issue_url":"https://github.com/cilium/cilium/issues/37976","target_repo_name":"cilium/cilium","target_issue_id":2551539057,"target_issue_number":35060,"target_issue_url":"https://github.com/cilium/cilium/issues/35060","reference_anchor_document_id":"gh_comment_2699445233","reference_answer_author":"borkmann","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2715,"anchor_target_overlap":0.2252,"target_answer_overlap":0.12},"issue_created_at":"2025-03-03T21:18:41+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_2892335118","fragment_type":"issue_description","sequence":0,"text":"netkit vs route tables?\n### Is there an existing issue for this?\n\n- [x] I have searched the existing issues\n\n### Version\n\nequal or higher than v1.17.1 and lower than v1.18.0\n\n### What happened?\n\nnode have two interface called private and public. both exist in cilium devices list.\npublic interface by default do not have IP address.\nit get ip address when kube-vip discovers a loadbalancer service, then kube-vip assign a public ip.\npublic ip not enough in this network environment, it also needs a route. since default route already exist in the private link we use SBR, so the system creates a new route table with the gateway for the public address and place an ip rule about if from address is the public ip then use that route table. this is how the node can respond requests on the public interface while still the default route belongs to the private interface.\n\nif the bpf.datapathMode set to veth all ok with cilium networking, all test run.\nif the bpf.datapathMode set to netkit every other node ok, but the node who have a public ip + routes goes wrong. in this node what we experienced that the node can't communicate with the pods which running on that node.\nif we move the public ip to another node, the node-pod network starts to work, and goes wrong on that node which got the public ip.\nThis is only reproducable in netkit mode.\nAny ideas? How we can debug this further?\n\n### How can we reproduce the issue?\n\ncilium installed with helm:\n\nautoDirectNodeRoutes: true\nbandwidthManager:\n enabled: true\nbgpControlPlane:\n secretsNamespace:\n create: false\nbpf:\n datapathMode: veth\n hostLegacyRouting: false\n lbExternalClusterIP: true\n masquerade: true\ncluster:\n id: 1\n name: sg1-kubego-io\nclusterDomain: k8s.sg1.example.com\ncni:\n exclusive: false\ndashboards:\n enabled: true\ndebug:\n enabled: false\ndevices: public private wg+\nenableIPv4Masquerade: true\nenableRuntimeDeviceDetection: true\nendpointRoutes:\n enabled: true\nenvoyConfig:\n secretsNamespace:\n create: false\nhostFirewall:\n enabled: true\nhostPort:\n enabled: true\nipam:\n mode: multi-pool\n operator:\n autoCreateCiliumPodIPPools:\n default:\n ipv4:\n cidrs:\n - 10.207.0.0/23\n maskSize: 28\n dashboards:\n enabled: true\n namespace: monitoring\n multiPoolPreAllocation: false\n prometheus:\n enabled: true\n labels:\n release: prometheus\n metricRelabelings: null\nipv4NativeRoutingCIDR: 10.207.0.0/19\nipv6:\n enabled: false\nk8s:\n requireIPv4PodCIDR: true\n requireIPv6PodCIDR: false\nk8sServiceHost: kube-api.example.com\nk8sServicePort: 443\nkubeProxyReplacement: true\nl7Proxy: true\nloadBalancer:\n acceleration: best-effort\n algorithm: maglev\n mode: dsr\nnodePort:\n enabled: true\noperator:\n dashboards:\n enabled: true\n namespace: monitoring\n prometheus:\n enabled: true\n interval: 60s\n labels:\n release: prometheus\n metricRelabelings: null\n replicas: 1\n rollOutPods: true\nprometheus:\n enabled: true\n serviceMonitor:\n enabled: true\n interval: 60s\n labels:\n release: prometheus\nrouting-mode: native\nroutingMode: native\nsecretsNamespace:\n create: false\n sync: false\nsocketLB:\n enabled: true\n hostNamespaceOnly: true\n\nwitch config above everything works as expected using public ip that way mentioned above.\nif you set this:\n\nbpf:\n datapathMode: netkit\n\neverything works as expected until a node get a public ip and sbr.\n\n### Cilium Version\n\n1.16.x/1.17.x\n\n### Kernel Version\n\n6.8.x\n\n### Kubernetes Version\n\n1.31.x\n\n### Regression\n\n_No response_\n\n### Sysdump\n\n_No response_\n\n### Relevant log output\n\nshell\n\n### Anything else?\n\n_No response_\n\n### Cilium Users Document\n\n- [ ] Are you a user of Cilium? Please add yourself to the Users doc\n\n### Code of Conduct\n\n- [x] I agree to follow this project's Code of Conduct","author_login":"pasztorl","author_association":"NONE","created_at":"2025-03-03T21:18:41+08:00","repo_name":"cilium/cilium","issue_id":2892335118,"issue_number":37976,"issue_url":"https://github.com/cilium/cilium/issues/37976","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2699445233","fragment_type":"issue_comment","sequence":1,"text":"Hi @pasztorl \n\nI have a couple of questions.\n \n \n \n\nOut of curiousity, have you looked into Cilium's L2 announcements feature. I'm not sure if this would work for your use case, but there's some overlap between the functionality that kube-vip, namely the assignment (and reassignment) of a VIPs to nodes for `LoadBalancer` services. My first thought is that if it's possible to use this instead it may be better than trying to mix components that may get in each other's way. As you point out, however, your setup works with veth, so it can't be entirely kube-vip's fault here.\n \n\nJust to clarify, you're using source-based routing to send traffic whose source IP matches the public IP out through your secondary (public) interface? Do you configure this routing policy on all your nodes at all times or is it only configured for the node that currently holds the public IP?\n \nif the bpf.datapathMode set to netkit every other node ok, but the node who have a public ip + routes goes wrong. in this node what we experienced that the node can't communicate with the pods which running on that node.\nif we move the public ip to another node, the node-pod network starts to work, and goes wrong on that node which got the public ip.\n\nCould you clarify what you mean by \"the node can't communicate with the pods which running on that node\"? Are you unable to talk to pods from within the host namespace of the node in question? Is there a specific command like `curl` that illustrates the issue? What does the output of `cilium-health` say when run on the impacted node?\n \n \n \n \n\nI see you're using endpoint routes. I would suggest taking a look at some of the links and discussion in URL There were some issues previously using endpoint routes with netkit that were fixed in 1.17. However, this mostly applies when using network policies. I'm not sure if this is true in your case. Also, you'd need to latest kernel fixes for netkit. \n \n \n\nIt looks like you might be using Ubuntu or something similar? If so, make sure you're using `6.8.0-53-generic` at minimum which was just released. This is the first kernel release with the fixes I mentioned. Again, this may or may not apply to your case, but it's worth trying if it's easy to do so.\n\nOne thing that would help get to the bottom of your issue is to capture the output of `cilium-dbg monitor` on the impacted node in both `veth` and `netkit` modes while doing something that fails in netkit mode (e.g. run `curl` from the host namespace or something).","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2025-03-05T01:06:03+08:00","repo_name":"cilium/cilium","issue_id":2892335118,"issue_number":37976,"issue_url":"https://github.com/cilium/cilium/issues/37976","linked_issue_ids":[2551539057],"is_known_query_context":false},{"document_id":"gh_comment_2701733320","fragment_type":"issue_comment","sequence":2,"text":"VIP routes only configured on node(s) which have VIP(s).\n\nIs this something kube-vip does by default or do you have a custom script which sets up these routes? Glancing at the `kube-vip` documentation, there seems to be options like `vip_servicesinterface` control which interfaces to bind and address to. I see some vague references to routing, but nothing explicitly mentioning SBR. Could you clarify who is actually setting these routing tables up? It might be helpful to see how you've configured kube-vip if you can provide the details; I'm wondering if this is a problem that is easy to reproduce by just installing kube-vip with some basic configuration.\n \n \n \n \n \n\nAh, ok. So making sure I understand, things work with *both* netkit and veth as long as `bpf.hostLegacyRouting=true` and *both* modes present the same problem when `bpf.hostLegacyRouting=false` or is it only failing with netkit+bpf.hostLegacyRouting=false?\n \n\nThanks. From the output provided, it looks like the node with the VIP+routes can't reach the local `cilium-health` endpoint. If possible, could you provide the output with the `--verbose` flag. It should give a little more detail about the request to that endpoint and why it's failing, although my guess is it's a timeout of some sort.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2025-03-05T18:22:43+08:00","repo_name":"cilium/cilium","issue_id":2892335118,"issue_number":37976,"issue_url":"https://github.com/cilium/cilium/issues/37976","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2720718047","fragment_type":"issue_comment","sequence":3,"text":"@jrife sorry one more question.. i included a cilium-db monitor output.\nThis flow is the readiness check for a pod. i think this check need to come from the kubelet internal address but it seems it comming from the configured external ip from the node. i think this is not ok. what do you think?\n\n-> endpoint 954 flow 0xbbd96870 , identity host->92858 state new ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58270 -> 10.96.1.99:5566 tcp SYN\n-> endpoint 954 flow 0x880227c6 , identity host->92858 state new ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58284 -> 10.96.1.99:5566 tcp SYN\n-> endpoint 954 flow 0xbbd96870 , identity host->92858 state established ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58270 -> 10.96.1.99:5566 tcp ACK\n-> endpoint 954 flow 0x880227c6 , identity host->92858 state established ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58284 -> 10.96.1.99:5566 tcp ACK\n-> endpoint 954 flow 0xbbd96870 , identity host->92858 state established ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58270 -> 10.96.1.99:5566 tcp ACK\n-> endpoint 954 flow 0x880227c6 , identity host->92858 state established ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58284 -> 10.96.1.99:5566 tcp ACK\n-> endpoint 954 flow 0x880227c6 , identity host->92858 state established ifindex lxcbe38814d9e9e orig-ip 80.77.122.114: 80.77.122.114:58284 -> 10.96.1.99:5566 tcp ACK, FIN","author_login":"pasztorl","author_association":"NONE","created_at":"2025-03-13T10:18:24+08:00","repo_name":"cilium/cilium","issue_id":2892335118,"issue_number":37976,"issue_url":"https://github.com/cilium/cilium/issues/37976","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2734030843","fragment_type":"issue_comment","sequence":4,"text":"Hi @pasztorl \n \n\nJust to check, are you experiencing any connectivity issues or are the readiness probes working?","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2025-03-18T16:59:04+08:00","repo_name":"cilium/cilium","issue_id":2892335118,"issue_number":37976,"issue_url":"https://github.com/cilium/cilium/issues/37976","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2551539057","fragment_type":"issue_description","sequence":0,"text":"Netkit does not work with endpoint routes in some cases\nThis tracks a group of issues related to netkit that share a similar root cause and discussion around it.\n\n- In #34042 a user reported that liveness/readiness probes stopped working after applying `NetworkPolicy` to a `Pod` when using `netkit` and endpoint routes. The same configuration using `veth` did not have this problem. Some investigation turned up that packets coming from the host namespace get misidentified with the `world` identity instead of `host`. With `NetworkPolicies` applied to the endpoint this leads to packets from liveness/readiness probes getting dropped.\n- In #33875 a user reported that running `curl -I -s URL from a `Pod` hangs when using `netkit` and endpoint routes after applying a `CiliumNetworkPolicy` which specifies `.spec.egress.toFQDNs`. The same configuration using `veth` or with endpoint routes disabled did not have this problem. Some investigation turned up a similar symptoms, with reply DNS traffic returning from the proxy taking on the `world` identity in `cil_to_container`.\n\nIn both cases the root cause looks to be that netkit scrubs packets (clearing `skb->mark`) before executing attached BPF programs. This is evident looking at the source for `netkit_xmit` where `netkit_prep_forward` clears `skb->mark` when crossing network namespaces before `netkit_run()` runs any attached programs.\n\nc\n netkit_prep_forward(skb, !net_eq(dev_net(dev), dev_net(peer)));\n eth_skb_pkt_type(skb, peer);\n skb->dev = peer;\n entry = rcu_dereference(nk->active);\n if (entry)\n ret = netkit_run(entry, skb, ret);\n\nIn contrast, when using `veth` TC/TCX hooks are executed *before* the `veth` driver does any packet scrubbing.\n\n#### `netkit` egress processing order\n1. `sch_handle_egress` is called but does not execute any hooks, since BPF programs are attached directly to the device in `netkit` mode.\n2. `netkit_xmit` begins\n3. `netkit_xmit` clears `skb->mark`\n4. `netkit_xmit` runs `cil_to_container`\n5. `netkit_xmit` passes the packet to the peer device\n\n#### `veth` egress processing order\n1. `sch_handle_egress` is called executing `cil_to_container`.\n2. `veth_xmit` begins\n3. `veth_xmit` clears `skb->mark`\n4. `veth_xmit` passes the packet to the peer device\n\nSince `cil_to_container` uses `ctx->mark` for proxy redirection and policy enforcement this can lead to various issues. For now this only seems to be a problem when using endpoint routes, but if `cilium_host` were to be changed to `netkit` (I'm not sure if this is the case already) it may interfere there as well.\n\nJust to confirm that this is indeed the root cause, patching the netkit driver with this hack locally resolves the reported issues in both cases making behavior consistent between `veth` and `netkit` modes (note: this is not a real fix, just something I used to test my observations).\n\n static void netkit_prep_forward(struct sk_buff *skb, bool xnet)\n {\n+ u32 save_mark = skb->mark;\n skb_scrub_packet(skb, xnet);\n+ skb->mark = save_mark;\n skb->priority = 0;\n nf_skip_egress(skb, true);\n skb_reset_mac_header(skb);\n\n## Tasks\n- [ ] Short term, decide whether or not we should allow netkit to be used with endpoint routes enabled. We could add some checks on startup to block this combination. Cons: this might make things stop working for some users who are already using this combination without issue.\n- [ ] Document this as a known issue (#35126)\n- [ ] Patch netkit. Talking to @borkmann offline, he mentioned maybe adding a new mode to determine if the scrub happens before or after running BPF. If implemented, this needs some follow up work to make sure this mode is configured.\n- [ ] Expand test coverage to include some of these scenarios with netkit+endpoint routes.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-26T21:11:45+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2377953044","fragment_type":"issue_comment","sequence":1,"text":"CC @julianwiedmann @joestringer who are also involved in the issues mentioned.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-26T21:16:06+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2377965861","fragment_type":"issue_comment","sequence":2,"text":"Just wanted to add, I'm happy to take a stab at adding a new mode to netkit if it would help.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-26T21:24:54+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378059759","fragment_type":"issue_comment","sequence":3,"text":"Hi @jrife I've pushed a patch here which I think could be acceptable. Do you have a chance to help testing whether that looks good on your side? URL I can run this by Martin and Nik in the meantime. Thanks for your help!","author_login":"borkmann","author_association":"MEMBER","created_at":"2024-09-26T22:38:23+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378081693","fragment_type":"issue_comment","sequence":4,"text":"We could try asking for stable backport once this lands. I can add a Fixes tag just in case.","author_login":"borkmann","author_association":"MEMBER","created_at":"2024-09-26T22:50:18+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378103967","fragment_type":"issue_comment","sequence":5,"text":"Cool, I'll give it a try locally under the two scenarios mentioned.\n \n\nThat would be great. It looks like we'd need to backport a fix to all supported Cilium versions to use `NETKIT_SCRUB_AFTER` if supported by the current kernel. I wonder if there should be any logic in Cilium to block a user from using endpoint routes with netkit on an unpatched kernel? Then again, maybe a known issue is enough since affected users could just switch to `veth` until they update their kernel.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-26T23:15:19+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378353563","fragment_type":"issue_comment","sequence":6,"text":"I changed Cilium locally to set `IFLA_NETKIT_SCRUB` to `NETKIT_SCRUB_AFTER`.\n\n* I tested the scenario in #34042 (liveness probes + `NetworkPolicy`) with the kernel patch and it seems to fix the issue. Switching to `NETKIT_SCRUB_BEFORE` this breaks again as expected.\n* The scenario in #33875 does not work still unless `NETKIT_SCRUB_NONE` is used. I believe this is related to the fact that `skb->mark` is immediately reset after running `cil_to_container()` which sets it in `__ctx_redirect_to_proxy`.\n \nc\n ctx->mark = MARK_MAGIC_TO_PROXY | proxy_port unknown state unknown ifindex eth0 orig-ip 0.0.0.0: 10.244.0.156:53 -> 10.244.1.246:36813 udp\n -> proxy flow 0x0 , identity 10388->26256 state reply ifindex lxc7b7ce9de2500 orig-ip 10.244.0.156: 10.244.0.156:53 -> 10.244.1.246:36813 udp\n unknown state unknown ifindex eth0 orig-ip 0.0.0.0: 10.244.0.156:53 -> 10.244.1.246:36813 udp\n -> proxy flow 0x0 , identity 10388->26256 state reply ifindex lxc7b7ce9de2500 orig-ip 10.244.0.156: 10.244.0.156:53 -> 10.244.1.246:36813 udp","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-27T03:58:20+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378646870","fragment_type":"issue_comment","sequence":7,"text":"Hah, okay, thanks for testing and taking a look. I presume NETKIT_SCRUB_NONE generally could be enough as an option anyway and if needed BPF prog could zero the data. I'll finalize and add a BPF selftest (next week) so that this can be submitted & merged then.","author_login":"borkmann","author_association":"MEMBER","created_at":"2024-09-27T07:56:22+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380076652","fragment_type":"issue_comment","sequence":8,"text":"To expand a bit on the behavior I saw in the second scenario for posterity,\n\n1. Used `NETKIT_SCRUB_AFTER`\n2. The coredns Pod sends a UDP packet back to the curl Pod.\n3. `netkit_xmit()` starts and runs `netkit_run()` triggering `cil_from_container` for the coredns Pod.\n4. `cil_from_container` calls `ipv4_local_delivery()` which tail calls to `handle_policy()` for the curl Pod.\n5. Eventually this hits `ctx_redirect_to_proxy4()` which sets `ctx->mark` to `MARK_MAGIC_TO_PROXY`.\n6. `netkit_run()` returns with `skb->mark` now set to `MARK_MAGIC_TO_PROXY`.\n7. `netkit_xnet(skb)` immediately clears the mark before sending it on to the peer device and host namespace.\n\nI think this then messes up routing to the proxy. Going from `NETKIT_SCRUB_BEFORE` -> `NETKIT_SCRUB_AFTER` basically swaps one problem for another. In the `veth` case `cil_from_container` runs on the ingress side after passing the packet to the primary device so any mark is preserved. I guess this is true for redirects as well. A program could mark a packet then call `bpf_redirect()`. If the redirect target expects the mark to be set, they'd be in for a surprise.\n \n\nAck. `NETKIT_SCRUB_NONE` does seem to have the least surprising behavior when compared to `veth`. Hopefully there's no corner case where a container could set a mark to bypass ingress or egress policies.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-27T21:22:57+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380843920","fragment_type":"issue_comment","sequence":9,"text":"I am not sure if it is related; but l7 functionnality isnt working either. Using netkit (+BBR ba,dwith manager and native routing) and running a `cilium connectivity test` shows errors in all l7 related tests. \nThe same config but switching to veth makes those same tests pass.","author_login":"Anghille","author_association":"NONE","created_at":"2024-09-28T17:37:25+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2380868373","fragment_type":"issue_comment","sequence":10,"text":"@Anghille but this is with per-endpoint-routes config, right?","author_login":"borkmann","author_association":"MEMBER","created_at":"2024-09-28T19:09:26+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2381260267","fragment_type":"issue_comment","sequence":11,"text":"It is with endpoint-routes disabled. Traffic flow by the cilium interface directly","author_login":"Anghille","author_association":"NONE","created_at":"2024-09-29T08:26:49+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2383939745","fragment_type":"issue_comment","sequence":12,"text":"@Anghille `cilium connectivity test` runs regularly as part of CI against netkit-enabled clusters. Can you share a bit of info about your configuration as well as the errors you encountered while running? What arguments did you use with `cilium connectivity test`? What does `cilium status` show?","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-09-30T18:58:13+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2394983030","fragment_type":"issue_comment","sequence":13,"text":"I can open a new ticket to avoid polluting this one with all informations necessary if you want :)","author_login":"Anghille","author_association":"NONE","created_at":"2024-10-05T08:40:45+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2397167614","fragment_type":"issue_comment","sequence":14,"text":"Sure. Since you don't have endpoint routes enabled it sounds like this could be something different. If you have an easy way to reproduce your use case (preferably in a kind cluster) that would help as well.","author_login":"jrife","author_association":"CONTRIBUTOR","created_at":"2024-10-07T14:56:53+08:00","repo_name":"cilium/cilium","issue_id":2551539057,"issue_number":35060,"issue_url":"https://github.com/cilium/cilium/issues/35060","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0288","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Ferdium won't launch after upgrading Ubuntu to 24.04 (using AppImage)?","query_context":"### Your issue\n\nFerdium is not opening anymore after upgrading ubuntu from 23.10 to the unreleased 24.04.\n\nThis is what I get. Even the help to get ferdium info is not available anymore.\n\nimage\n\nHowever this is the AppImage I am using.\n\nFerdium-linux-Portable-6.7.3-nightly.11-x86_64_4a1b12d6d452e18c9051545269e61317.AppImage\n\nLaunching it from the command line, this is the message I got.\n\nbash\n➜ ./Ferdium-linux-Portable-6.7.3-nightly.11-x86_64_4a1b12d6d452e18c9051545269e61317.AppImage \nQSocketNotifier: Can only be used with threads started with QThread\n[14565:0416/153718.391657:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_FerdiuAUvtnU/chrome-sandbox is owned by root and has mode 4755.\n\nOS version\n\n~/Applications …\n➜ lsb_release -a\nNo LSB modules are available.\nDistributor ID: Ubuntu\nDescription: Ubuntu Noble Numbat (development branch)\nRelease: 24.04\nCodename: noble","known_context_document_ids":["gh_issue_2246674349"],"reference_answer":"Thank you for the suggestion!\n\nI have a few concerns about this:\n- It means that the installer will require root access.\n- Overwriting `/path/to/Joplin-2.14.20.AppImage` could give an attacker access to unprivileged user namespaces.\n - This would mean, however, that an attacker would already need to be able to write files and run code as a user with Joplin installed.\n- Uninstalling Joplin becomes a bit more complicated, particularly if multiple users on a computer have Joplin installed. In this case, the AppArmor profile also needs to be removed, but only if all users have uninstalled Joplin.\n - One solution could be to use a flag `--full-uninstall`.\n - Another solution could be to install the AppImage to a globally-accessible location (e.g. in `/usr`).\n\nSee also \n URL","answer_document_id":"gh_comment_2066582463","silver_evidence_path":["gh_comment_2067112679","gh_issue_2251907468","gh_comment_2066582463"],"evidence_issue_ids":[2246674349,2251907468],"source_repo_name":"ferdium/ferdium-app","source_issue_id":2246674349,"source_issue_number":1694,"source_issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","target_repo_name":"laurent22/joplin","target_issue_id":2251907468,"target_issue_number":10332,"target_issue_url":"https://github.com/laurent22/joplin/issues/10332","reference_anchor_document_id":"gh_comment_2067112679","reference_answer_author":"personalizedrefrigerator","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.1667},"issue_created_at":"2024-04-16T18:41:37+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_2246674349","fragment_type":"issue_description","sequence":0,"text":"Ferdium won't launch after upgrading Ubuntu to 24.04 (using AppImage)\n### Your issue\n\nFerdium is not opening anymore after upgrading ubuntu from 23.10 to the unreleased 24.04.\n\nThis is what I get. Even the help to get ferdium info is not available anymore.\n\nimage\n\nHowever this is the AppImage I am using.\n\nFerdium-linux-Portable-6.7.3-nightly.11-x86_64_4a1b12d6d452e18c9051545269e61317.AppImage\n\nLaunching it from the command line, this is the message I got.\n\nbash\n➜ ./Ferdium-linux-Portable-6.7.3-nightly.11-x86_64_4a1b12d6d452e18c9051545269e61317.AppImage \nQSocketNotifier: Can only be used with threads started with QThread\n[14565:0416/153718.391657:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_FerdiuAUvtnU/chrome-sandbox is owned by root and has mode 4755.\n\nOS version\n\n~/Applications …\n➜ lsb_release -a\nNo LSB modules are available.\nDistributor ID: Ubuntu\nDescription: Ubuntu Noble Numbat (development branch)\nRelease: 24.04\nCodename: noble","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-16T18:41:37+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2059722547","fragment_type":"issue_comment","sequence":1,"text":"Weird that this is the latest version of Ferdi I see on the Releases page `6.7.3-nightly.9` that was released 3 days ago but I have this `6.7.3-nightly.11` instead.\n\nFerdium-linux-Portable-6.7.3-nightly.9-x86_64.AppImage","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-16T18:44:23+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2059725009","fragment_type":"issue_comment","sequence":2,"text":"Same issue happens with this verison `Ferdium-linux-Portable-6.7.3-nightly.9-x86_64_cdca802a7cee1d127f07bebdefeb5ef2.AppImage`","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-16T18:46:10+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2059734204","fragment_type":"issue_comment","sequence":3,"text":"Version 6.7.3-nigthly.11 was released today and had a bug that is reported here: URL \n\nUnfortunately I think you made the Ubuntu upgrade and, at the same time, the Ferdium upgrade... Which caused the black screen you are seeing.\n\nIt is weird that nightly.9 is not working tho...","author_login":"SpecialAro","author_association":"MEMBER","created_at":"2024-04-16T18:52:52+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2063424176","fragment_type":"issue_comment","sequence":4,"text":"@leoheck can you check if you can upgrade to the latest nightly and if this issue is fixed?","author_login":"SpecialAro","author_association":"MEMBER","created_at":"2024-04-18T09:24:24+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2064053023","fragment_type":"issue_comment","sequence":5,"text":"Yeah the version \n\nVersion: 6.7.3-nightly.12\nServer: Ferdium Server\nElectron: 30.0.0\nChrome: 124.0.6367.49\nNode.js: 20.11.1\nPlatform: Linux 6.8\nArch: x64\nBuild date: Wed Apr 17 2024 09:24:46 GMT-0300 (Brasilia Standard Time)\nGit SHA: deba94e5\nGit branch: nightly\n\nWorks again, actually while downloading it, version `6.7.3-nightly.9` started to work... maybe ubuntu upgraded something.","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-18T14:40:58+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066842446","fragment_type":"issue_comment","sequence":6,"text":"@SpecialAro the new `nightly.13` is not working anymore.\n\nimage","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-19T15:46:59+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066843586","fragment_type":"issue_comment","sequence":7,"text":"Can could you reopen this issue? I cannot see the button for that.","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-19T15:47:40+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066856556","fragment_type":"issue_comment","sequence":8,"text":"I can reopen, but I don't think it is related to the same issue. I see that you can not open the app at all","author_login":"SpecialAro","author_association":"MEMBER","created_at":"2024-04-19T15:55:26+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066879587","fragment_type":"issue_comment","sequence":9,"text":"That's true when launching from the command line. When using the launcher it shows the icon on tray.","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-19T16:08:59+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066880446","fragment_type":"issue_comment","sequence":10,"text":"However the issue here is that it is not launching. So I think it is still related to the report.","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-19T16:09:30+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067112679","fragment_type":"issue_comment","sequence":11,"text":"Crossreferencing URL and URL here which seem to be suffering from the same issue.","author_login":"mcmxcdev","author_association":"CONTRIBUTOR","created_at":"2024-04-19T18:46:59+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[2251907468],"is_known_query_context":false},{"document_id":"gh_comment_2079642534","fragment_type":"issue_comment","sequence":12,"text":"@leoheck Do you know if the problem is also happening when installing Ferdium through the `.deb` file? I am also on Ubuntu 23.10 at the moment, and might update soon to 24.04, and we will need to see if we can provide a patch for that before those jumping from the previous LTS get this problem.","author_login":"Alphrag","author_association":"MEMBER","created_at":"2024-04-26T15:42:05+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2080233827","fragment_type":"issue_comment","sequence":13,"text":"Hey @Alphrag , I am on Ubuntu 24.04 (not a clean install) it was upgraded when it was still to be released. It was released yesterday. However, it has been updating a bunch of things daily since when I upgraded it. It may have eventually improved/fixed something.\n\nNow, talking about the Ferdium, it is currently working. There are no problems anymore.\nBut I am not sure about the .deb version of it. \n\nI am running this version\n\nVersion: 6.7.3-nightly.15\nServer: Ferdium Server\nElectron: 30.0.1\nChrome: 124.0.6367.60\nNode.js: 20.11.1\nPlatform: Linux 6.8\nArch: x64\nBuild date: Sat Apr 20 2024 21:50:37 GMT-0300 (Brasilia Standard Time)\nGit SHA: fe61e6ba\nGit branch: nightly","author_login":"leoheck","author_association":"NONE","created_at":"2024-04-26T23:33:45+08:00","repo_name":"ferdium/ferdium-app","issue_id":2246674349,"issue_number":1694,"issue_url":"https://github.com/ferdium/ferdium-app/issues/1694","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2251907468","fragment_type":"issue_description","sequence":0,"text":"Joplin does not work in Ubuntu 24.04 due to apparmor issue\n### Operating system\n\nLinux\n\n### Joplin version\n\n2.11.11\n\n### Desktop version info\n\n_No response_\n\n### Current behaviour\n\nThe Joplin appimage does not run in Ubuntu 24.04 due to recent changes in apparmor, which prevents all electron apps from running.\n\nFor details, see URL and URL \n\nA temporary fix is described here URL \n\nThere is probably nothing the Joplin developers can do until apparmor fixes it, but I still wanted to report the bug to prevent huge confusion when 24.04 is released and thousands of users start using Joplin on it.\n\n### Expected behaviour\n\n_No response_\n\n### Logs\n\n$ ./Joplin.AppImage \n\n[9034:0418/214224.008705:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_Joplin8u3ir2/chrome-sandbox is owned by root and has mode 4755.","author_login":"archisman-panigrahi","author_association":"NONE","created_at":"2024-04-19T01:44:43+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2065805259","fragment_type":"issue_comment","sequence":1,"text":"It looks like the workaround was only enabled for the 23.10 version of Ubuntu:\n\n URL \n\nThis line likely needs to be changed to include 23.10 and **all later versions**.","author_login":"personalizedrefrigerator","author_association":"COLLABORATOR","created_at":"2024-04-19T05:46:29+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2065889431","fragment_type":"issue_comment","sequence":2,"text":"unfortunately Joplin is only shipped as an appimage for Linux. Which means we can not ship a profile for it by default that will allow it to use capabilities within the unprivileged user namespace that the electron embedded browser is attempting to use.\n\nThis means that the user is required to intervene to enable an electron based appimage so that it can be run. Unfortunately for 24.04 this means some manual command line based intervention, instead of using a GUI like on MacOS when a user needs to enable an application downloaded from the internet.\n\nIf you look in the kernel logs, (or dmesg) you will find an message an apparmor message similar to below showing what is causing your issue.\n\n$ sudo dmesg | grep \"apparmor=\\\"AUDIT\"\n\n[ 85.468352] audit: type=1400 audit(1713509122.843:224): apparmor=\"AUDIT\" operation=\"userns_create\" class=\"namespace\" info=\"Userns create - transitioning profile\" profile=\"unconfined\" pid=3058 comm=\"@joplinapp-desk\" requested=\"userns_create\" target=\"unprivileged_userns\"\n\nand\n\n$ sudo dmesg | grep DENIED\n\n[ 85.469966] audit: type=1400 audit(1713509122.847:225): apparmor=\"DENIED\" operation=\"capable\" class=\"cap\" profile=\"unprivileged_userns\" pid=3065 comm=\"@joplinapp-desk\" capability=21 capname=\"sys_admin\"\n\nUnfortunately unprivileged user namespaces are using privileged kernel interfaces (above protected by capabiity sys_admin) that have now been restricted to known applications because they have been used in a lot of exploit chains.\n\nyou can add a profile for the application by copying the profile from below into /etc/apparmor.d/ and then updating by replacing \n/home/jj/Downloads/Joplin-2.14.20.AppImage\n with the location you are running your joplin appimage from.\n\n# This profile allows everything and only exists to give the\n# application a name instead of having the label \"unconfined\"\n\nabi ,\ninclude \n\nprofile joplin /home/jj/Downloads/Joplin-2.14.20.AppImage flags=(unconfined) {\n userns,\n\n # Site-specific additions and overrides. See local/README for details.\n include if exists \n}\n\nOnce that is done you can do\n\n$ sudo apparmor_parser -r /etc/apparmor.d/joplin\n\nthat will allow you to run joplin without having to reboot. Having the jplin profile in /etc/apparmor.d/ will ensure it is reloaded if you reboot.","author_login":"jrjohansen","author_association":"NONE","created_at":"2024-04-19T07:04:27+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066582463","fragment_type":"issue_comment","sequence":3,"text":"Thank you for the suggestion!\n\nI have a few concerns about this:\n- It means that the installer will require root access.\n- Overwriting `/path/to/Joplin-2.14.20.AppImage` could give an attacker access to unprivileged user namespaces.\n - This would mean, however, that an attacker would already need to be able to write files and run code as a user with Joplin installed.\n- Uninstalling Joplin becomes a bit more complicated, particularly if multiple users on a computer have Joplin installed. In this case, the AppArmor profile also needs to be removed, but only if all users have uninstalled Joplin.\n - One solution could be to use a flag `--full-uninstall`.\n - Another solution could be to install the AppImage to a globally-accessible location (e.g. in `/usr`).\n\nSee also \n URL","author_login":"personalizedrefrigerator","author_association":"COLLABORATOR","created_at":"2024-04-19T13:25:21+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066605480","fragment_type":"issue_comment","sequence":4,"text":"actually --no-sandbox should work as well. Ubuntu isn't going so far as requiring a profile for all downloaded applications. Only those that use unprivileged user namespaces and try to use system capabilities within the user namespace. Since --no-sandbox will stop chrome from creating the unprivileged user namespace, that should be enough to get it to work without creating a profile.","author_login":"jrjohansen","author_association":"NONE","created_at":"2024-04-19T13:36:14+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2066964686","fragment_type":"issue_comment","sequence":5,"text":"`no-sandbox` should work, it's been tested before. It'd be ideal if Chromium/Electron had a less binary flag for it, but unfortunately that's not the case we're in. It might change in the future though, Ubuntu isn't the only one who've started restricting access to it and even Linus Torvalds himself has called it a mistake that they're stuck with.\n \n\nI'd not honestly expect a resolution for this in the \"it just runs\" manner. I know Ubuntu has been working on permissions prompting for snaps like how Android/iOs have it (\"Joplin is trying to access ./SSH, would you like to allow\" kind of prompts), and as I casually read through Launchpad, it seems there's an apetite for making user namespaces work the same way even outside of snaps, but it'd be unlikely to get backported into 24.04 which will persist for years.\n\nFrom what I've read, the Electron Flatpaks have a trick they use called Zypak that allows the Chromium sandbox to work without SETUID bits and potentially usernamespaces, it could be possibly replicated in the AppImage and provide better sandboxing than nothing.\n\nBut as far as Ubuntu the project goes, they'd likely say the answer needs to be a PPA (more maintenace effort), a snap (Which already exists), or for it to be submitted to the Universe repository (which is less than ideal because the package would become stale and eventually become incompatible for syncing with the latest clients).\n\nEven in the snap, `--no-sandbox` is still used, snapd itself sets up apparmor permissions and seccomp and BPF and all that stuff so that Chromium doesn't have to, only big vendors like Mozilla or Brave or etc would be allowed to use unprivileged user namespaces, even in a snap!","author_login":"JGCarroll","author_association":"NONE","created_at":"2024-04-19T17:08:06+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2067311146","fragment_type":"issue_comment","sequence":6,"text":"So make it just runs is problematic. The goal is to stop unknown code from being able to use unprivileged user namespaces to attack the kernel. There are a few ways we can get safely get the \"make it just run\" behavior, like shipping profiles for known applications in locations that regular userspace code can't write. Or signed code with a valid integrity hash. Both of these exist. Unfortunately we can't do that for code that a user can just down load and run from their home dir in locations that attack code code write to gain privilege. If we enabled that, attack code would just have to add a simple step to the exploit chain.\n\nIts not that we don't want users to be able to run these applications. Its just an unfortunate reality of how unprivileged user name space exploits work.\n\nSo we need some privileged way that a user can enable new applications. Currently that is adding a profile or signed code that can be verified by the integrity architecture. With snapd there is the opportunity for a third way via prompting the user. Unfortunately atm it is experimental and not integrated with the unprivileged user namespace yet.\n\nLike I said unfortunately the user experience in 24.04 isn't good when failure happens. The goal is to improve the experience, and that includes 24.04. On the snap side, snapd and snaps get updated separate from the base so you will see improvements there coming back to 24.04. Some of them might depend on an HWE kernel, but if needed some changes might get backported, to older kernels (this has been done for other features).\n\nThe apparmor side we are looking to looking at the possibility of bringing new versions back to older releases to better support the HWE kernels.\n \n \n\nZypak is interesting, and it should be possible to get it working, at least with the caveat that the launched application won't have access/need access to privileged kernel interfaces. I haven't looked into it yet, but its on the list of things to look at.\n \n \n \n\nSo from a support hat side of things that does make things easier, but we do want to make the user experience for electron and appimages. The current situation really isn't acceptable for the average user.\n \n\nIts entirely possible to create a full apparmor profile for the application, that allows it to also use unprivileged user namespaces. The unconfined profile stub is just trying to make it easier for the user, and yes t is not easy enough atm. As for snapd there is a new interface that allows access to unprivileged user nameapces, and any snap can request it. The goal is not to stop applications from using them, but to stop exp","author_login":"jrjohansen","author_association":"NONE","created_at":"2024-04-19T21:35:23+08:00","repo_name":"laurent22/joplin","issue_id":2251907468,"issue_number":10332,"issue_url":"https://github.com/laurent22/joplin/issues/10332","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0289","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Request to Submit Chinese Translation Documentation?","query_context":"### Description:\nI am ar0m(JinDongJie), and I am a big fan of the Hyprland project. I would like to help more Chinese users to better utilize this desktop manager. I plan to contribute by translating the project documentation into Chinese and am willing to dedicate my time and skills to complete this task.\n\n### Plan and Approach:\n\n1. I will translate the original project documentation into Chinese step by step, ensuring accuracy and fluency in the translation.\n2. I will create a new branch(or a better way) to submit the translated documentation and will maintain regular updates to keep it synchronized.\n3. I will collaborate with the community and maintainers to ensure the quality and accuracy of the translated documentation.\n4. I hope that this translated documentation will help more Chinese users to easily utilize the Hyprland project.\n\n### Inquiries:\n I have reviewed the current documentation website, and it seems that there is no language switch feature available. In the future, would it be possible to implement a language selection feature within the project? This feature could allow users to choose their preferred language for the documentation, enhancing accessibility for a wider audience.\n\n### Additional Information:\n If you believe that this translation work is valuable and approve of my contribution, I am eager to contribute to the project. I look forward to working with you to make the Hyprland project more user-friendly and inclusive.\n I have used the translation website weblate.org to translate some other open-source projects that I like. I believe I am capable of handling this task.\n\nThank you for your time and attention!","known_context_document_ids":["gh_issue_2214838215"],"reference_answer":"we can't, I believe.\n\nBesides, the speed at which arch wikis get out of date is _far_ slower than hyprland. We've had like at least 3 breaking changes in your config alone since latest release 0.35 like 2-3 weeks ago.","answer_document_id":"gh_comment_1952272540","silver_evidence_path":["gh_comment_2026937642","gh_issue_2141917296","gh_comment_1952272540"],"evidence_issue_ids":[2214838215,2141917296],"source_repo_name":"hyprwm/hyprland-wiki","source_issue_id":2214838215,"source_issue_number":560,"source_issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/560","target_repo_name":"hyprwm/hyprland-wiki","target_issue_id":2141917296,"target_issue_number":478,"target_issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/478","reference_anchor_document_id":"gh_comment_2026937642","reference_answer_author":"vaxerski","reference_answer_author_association":"MEMBER","quality_score":76.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2024-03-29T07:36:28+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2214838215","fragment_type":"issue_description","sequence":0,"text":"Request to Submit Chinese Translation Documentation\n### Description:\nI am ar0m(JinDongJie), and I am a big fan of the Hyprland project. I would like to help more Chinese users to better utilize this desktop manager. I plan to contribute by translating the project documentation into Chinese and am willing to dedicate my time and skills to complete this task.\n\n### Plan and Approach:\n\n1. I will translate the original project documentation into Chinese step by step, ensuring accuracy and fluency in the translation.\n2. I will create a new branch(or a better way) to submit the translated documentation and will maintain regular updates to keep it synchronized.\n3. I will collaborate with the community and maintainers to ensure the quality and accuracy of the translated documentation.\n4. I hope that this translated documentation will help more Chinese users to easily utilize the Hyprland project.\n\n### Inquiries:\n I have reviewed the current documentation website, and it seems that there is no language switch feature available. In the future, would it be possible to implement a language selection feature within the project? This feature could allow users to choose their preferred language for the documentation, enhancing accessibility for a wider audience.\n\n### Additional Information:\n If you believe that this translation work is valuable and approve of my contribution, I am eager to contribute to the project. I look forward to working with you to make the Hyprland project more user-friendly and inclusive.\n I have used the translation website weblate.org to translate some other open-source projects that I like. I believe I am capable of handling this task.\n\nThank you for your time and attention!","author_login":"LoongArum","author_association":"NONE","created_at":"2024-03-29T07:36:28+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2214838215,"issue_number":560,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/560","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2026937642","fragment_type":"issue_comment","sequence":1,"text":"Referencing a past issue URL \n \n\nI believe it can be implemented simply as ` URL with a selector in the navbar.","author_login":"fufexan","author_association":"MEMBER","created_at":"2024-03-29T09:24:50+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2214838215,"issue_number":560,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/560","linked_issue_ids":[2141917296],"is_known_query_context":false},{"document_id":"gh_comment_2027172794","fragment_type":"issue_comment","sequence":2,"text":"I'm really excited to hear this news! Should I fork this repository and start translating? Or do you have any better suggestions? I'm eager to start contributing. Perhaps, once Hyprland is more stable, you could consider releasing these documents. @fufexan","author_login":"LoongArum","author_association":"NONE","created_at":"2024-03-29T12:18:59+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2214838215,"issue_number":560,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/560","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2027446749","fragment_type":"issue_comment","sequence":3,"text":"We should check in with Vaxry first, as he was against the previous translation attempt.","author_login":"fufexan","author_association":"MEMBER","created_at":"2024-03-29T16:22:50+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2214838215,"issue_number":560,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/560","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2141917296","fragment_type":"issue_description","sequence":0,"text":"[Feature] Multilingual support\nThe content on this wiki website is extensive.\n\nAlthough I can read English, it is still inconvenient to refer to it frequently.\n\nP.S. @fufexan I saw you said that the website might switch to another hugo theme \"lotusdocs\".\n\nThat's great, because \"lotusdocs\" support multilingual. It also support content searching using CJK characters.\n\nAnd if you're really supporting multilingual, I'll contribute in zh-CN translation.","author_login":"clsty","author_association":"NONE","created_at":"2024-02-19T09:31:23+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2141917296,"issue_number":478,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952082671","fragment_type":"issue_comment","sequence":1,"text":"that's not a good idea. Translations will get dangerously out-of-sync.","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-02-19T09:53:31+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2141917296,"issue_number":478,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952101640","fragment_type":"issue_comment","sequence":2,"text":"True, it makes sense.\n\nBut, take Arch Wiki as example, it has multilingual support, and on the top of the translated page there is a notice about the last time this page is updated, and also a link to the original language.\n\nIf we could implement such warning/notification, will you feel it better?","author_login":"clsty","author_association":"NONE","created_at":"2024-02-19T10:03:53+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2141917296,"issue_number":478,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952272540","fragment_type":"issue_comment","sequence":3,"text":"we can't, I believe.\n\nBesides, the speed at which arch wikis get out of date is _far_ slower than hyprland. We've had like at least 3 breaking changes in your config alone since latest release 0.35 like 2-3 weeks ago.","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-02-19T11:41:38+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2141917296,"issue_number":478,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/478","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952288806","fragment_type":"issue_comment","sequence":4,"text":"Wow, this speed is so astonishing.\n\nIn such case, I hope multilingual could be implemented some other day in future.\n\nClosing for now.","author_login":"clsty","author_association":"NONE","created_at":"2024-02-19T11:51:52+08:00","repo_name":"hyprwm/hyprland-wiki","issue_id":2141917296,"issue_number":478,"issue_url":"https://github.com/hyprwm/hyprland-wiki/issues/478","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0290","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"p384: arithmetic + ECDSA support?","query_context":"Hi,\n\nIs there a way to compute and verify p384 signatures yet?\n\n`p384` has an `ecdsa` feature, but I couldn't get anything done with it.\n`ProjectiveArithmetic` is not implemented for `NistP384`. The `arithmetic` feature of the `elliptic_curve` crate isn't set, so I wasn't even able to manually compute a public key.\n\nIs it possible to use it in a similar way as `p256` and `k256`? Or to use it for ECDSA at all? Or is it still a work in progress?\n\nThanks for your help :)","known_context_document_ids":["gh_issue_754581168"],"reference_answer":"#589 adds `const fn` support to field elements\n\nAfter that it would be nice to expose `const fn` wrappers for the field arithmetic functions, and then rewrite the various constants back into canonical form, transforming them into Montgomery form at compile time.\n\nAnd after that, I'm good to ship it!","answer_document_id":"gh_comment_1145056951","silver_evidence_path":["gh_comment_1138824583","gh_issue_1249843697","gh_comment_1145056951"],"evidence_issue_ids":[754581168,1249843697],"source_repo_name":"RustCrypto/elliptic-curves","source_issue_id":754581168,"source_issue_number":240,"source_issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","target_repo_name":"RustCrypto/elliptic-curves","target_issue_id":1249843697,"target_issue_number":566,"target_issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","reference_anchor_document_id":"gh_comment_1138824583","reference_answer_author":"tarcieri","reference_answer_author_association":"MEMBER","quality_score":87.35,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.15,"anchor_target_overlap":0.4,"target_answer_overlap":0.087},"issue_created_at":"2020-12-01T17:20:43+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_754581168","fragment_type":"issue_description","sequence":0,"text":"p384: arithmetic + ECDSA support\nHi,\n\nIs there a way to compute and verify p384 signatures yet?\n\n`p384` has an `ecdsa` feature, but I couldn't get anything done with it.\n`ProjectiveArithmetic` is not implemented for `NistP384`. The `arithmetic` feature of the `elliptic_curve` crate isn't set, so I wasn't even able to manually compute a public key.\n\nIs it possible to use it in a similar way as `p256` and `k256`? Or to use it for ECDSA at all? Or is it still a work in progress?\n\nThanks for your help :)","author_login":"jedisct1","author_association":"CONTRIBUTOR","created_at":"2020-12-01T17:20:43+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":754581168,"issue_number":240,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1137174002","fragment_type":"issue_comment","sequence":1,"text":"Nice! I can take a look at merging that into the `p384` crate. It seems to largely follow the same structure.","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-25T12:23:39+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":754581168,"issue_number":240,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1137204055","fragment_type":"issue_comment","sequence":2,"text":"Interesting... I would like to compare performance of that with the WolfCrypt C implementation...","author_login":"rod-chapman","author_association":"NONE","created_at":"2022-05-25T12:55:41+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":754581168,"issue_number":240,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1137332573","fragment_type":"issue_comment","sequence":3,"text":"I'd be happy if we could merge that and therefore remove the `broken-arithmetic-do-not-use` stuff ^^","author_login":"Erik1000","author_association":"NONE","created_at":"2022-05-25T14:29:24+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":754581168,"issue_number":240,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1138104263","fragment_type":"issue_comment","sequence":4,"text":"@jedisct1 I opened a draft PR here: URL \n\nAlternatively if you'd like to open a PR yourself, that works too","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-26T03:15:28+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":754581168,"issue_number":240,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1138824583","fragment_type":"issue_comment","sequence":5,"text":"An arithmetic implementation derived from `p384-rs` was merged in #565.\n\nThank you @jedisct1 and @brycx! And vicarious thanks to the fiat-crypto people!\n\nFor anyone following this issue, I've opened a tracking issue for a v0.11 release with arithmetic support: #566","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-26T17:25:59+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":754581168,"issue_number":240,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/240","linked_issue_ids":[1249843697],"is_known_query_context":false},{"document_id":"gh_issue_1249843697","fragment_type":"issue_description","sequence":0,"text":"p384: v0.11 release tracking issue\nThis is a tracking ticket for work items it would be nice to have before cutting a final v0.11 release which includes an initial arithmetic implementation.\n\nNOTE: not all of these need to be completed prior to a release and they can be added after-the-fact.\n\n- [x] #573\n- [x] Test vectors\n - [x] #567 \n - [x] #570\n - [x] #569\n - [x] #574\n\ncc @brycx @jedisct1","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-26T17:23:35+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1138822907","fragment_type":"issue_comment","sequence":1,"text":"@daviddrysdale would you be interested in helping add Wycheproof test vectors?","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-26T17:24:07+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1138880300","fragment_type":"issue_comment","sequence":2,"text":"@jedisct1 did you want to take a look at adding 32-bit support? If not, I probably can in the next few days","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-26T18:21:38+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1139959462","fragment_type":"issue_comment","sequence":3,"text":"#573 implemented (currently untested) 32-bit support except for field and scalar inversions, which presently use a 64-bit only implementation.\n\nOnce that has been addressed, we can add `cross` tests for 32-bit targets, and after that I'd say it's ready to release.","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-05-27T19:17:28+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1140197648","fragment_type":"issue_comment","sequence":4,"text":"Happy to put in something analogous to the P256 test vectors, but it doesn't seem like the various traits (e.g. `SigningKey`, `VerifyingKey`) needed to use `new_wycheproof_test!` are available yet?","author_login":"daviddrysdale","author_association":"CONTRIBUTOR","created_at":"2022-05-28T07:43:37+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144565614","fragment_type":"issue_comment","sequence":5,"text":"@tarcieri Is there anything left blocking the `0.11.0` release? I see you've changed the inversion to work with the 32-bit backend as well :rocket:","author_login":"brycx","author_association":"CONTRIBUTOR","created_at":"2022-06-02T07:58:55+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145056951","fragment_type":"issue_comment","sequence":6,"text":"#589 adds `const fn` support to field elements\n\nAfter that it would be nice to expose `const fn` wrappers for the field arithmetic functions, and then rewrite the various constants back into canonical form, transforming them into Montgomery form at compile time.\n\nAnd after that, I'm good to ship it!","author_login":"tarcieri","author_association":"MEMBER","created_at":"2022-06-02T16:18:07+08:00","repo_name":"RustCrypto/elliptic-curves","issue_id":1249843697,"issue_number":566,"issue_url":"https://github.com/RustCrypto/elliptic-curves/issues/566","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0291","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"SQLalchemy cast to String not working anymore?","query_context":"first of all: I really appreciate this project, it helps me a lot everyday. Thank you @laughingman7743 and other contributors!\n\nI have a question/issue report: with the last realease (v2.5.0) some features changed (probabily this #286) and something that was working very well with version 2.4.0 is not working anymore.\n\nLet's say that I have an integer column '_integer_col_' in the table '_some_table_' in the database '_some_db_'.\n\nwith v2.4.0 the SQLalchemy query\n\npython\nselect(\n some_table.integer_col.cast(String)\n)\n\nproduces the following SQL\n\nSQL\nSELECT CAST(\"some_db\".\"some_table\".\"integer_col\" AS VARCHAR)\nFROM \"some_db\".\"some_table\"\n\nwhich is perfect.\n\nwhile with v2.5.0 the same query produces the following SQL\n\nSQL\nSELECT CAST(\"some_db\".\"some_table\".\"integer_col\" AS STRING)\nFROM \"some_db\".\"some_table\"\n\nwhich return the following error in Athena\n\n`SYNTAX_ERROR: line xxx:yyy: Unknown type: string`\n\nAs workround I could change the query as follows\n\npython\nselect(\n some_table.integer_col.cast(VARCHAR(n))\n)\n\nwhich, however, is not very convenient to use since sometimes is not possible to know the length of the string n.\n\nWhat I am missing?","known_context_document_ids":["gh_issue_1162936391"],"reference_answer":"In the case of DDL, I get an error if the Integer type is not INT.\n\nI removed table constraints and fixed the INT type handling in the following branches.\n URL \nPlease check it out.","answer_document_id":"gh_comment_1046209519","silver_evidence_path":["gh_comment_1062512952","gh_issue_1139298327","gh_comment_1046209519"],"evidence_issue_ids":[1162936391,1139298327],"source_repo_name":"laughingman7743/PyAthena","source_issue_id":1162936391,"source_issue_number":289,"source_issue_url":"https://github.com/laughingman7743/PyAthena/issues/289","target_repo_name":"laughingman7743/PyAthena","target_issue_id":1139298327,"target_issue_number":279,"target_issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","reference_anchor_document_id":"gh_comment_1062512952","reference_answer_author":"laughingman7743","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3793,"anchor_target_overlap":0.2414,"target_answer_overlap":0.2222},"issue_created_at":"2022-03-08T17:37:33+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_1162936391","fragment_type":"issue_description","sequence":0,"text":"SQLalchemy cast to String not working anymore?\nfirst of all: I really appreciate this project, it helps me a lot everyday. Thank you @laughingman7743 and other contributors!\n\nI have a question/issue report: with the last realease (v2.5.0) some features changed (probabily this #286) and something that was working very well with version 2.4.0 is not working anymore.\n\nLet's say that I have an integer column '_integer_col_' in the table '_some_table_' in the database '_some_db_'.\n\nwith v2.4.0 the SQLalchemy query\n\npython\nselect(\n some_table.integer_col.cast(String)\n)\n\nproduces the following SQL\n\nSQL\nSELECT CAST(\"some_db\".\"some_table\".\"integer_col\" AS VARCHAR)\nFROM \"some_db\".\"some_table\"\n\nwhich is perfect.\n\nwhile with v2.5.0 the same query produces the following SQL\n\nSQL\nSELECT CAST(\"some_db\".\"some_table\".\"integer_col\" AS STRING)\nFROM \"some_db\".\"some_table\"\n\nwhich return the following error in Athena\n\n`SYNTAX_ERROR: line xxx:yyy: Unknown type: string`\n\nAs workround I could change the query as follows\n\npython\nselect(\n some_table.integer_col.cast(VARCHAR(n))\n)\n\nwhich, however, is not very convenient to use since sometimes is not possible to know the length of the string n.\n\nWhat I am missing?","author_login":"luca-ferreri","author_association":"NONE","created_at":"2022-03-08T17:37:33+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1162936391,"issue_number":289,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/289","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1062512952","fragment_type":"issue_comment","sequence":1,"text":"As you point out, #286 changes the handling of VARCHAR and STRINGS. When I was discussing the change in #279, I made the change to the STRING type if no length is specified, as it is an error if the length is not specified in the VARCHAR when the table is created. However I overlooked that Athena cannot CAST to STRING.\n URL \nI would like to consider some way to work around this issue.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-03-09T03:15:59+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1162936391,"issue_number":289,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/289","linked_issue_ids":[1139298327],"is_known_query_context":false},{"document_id":"gh_comment_1062856555","fragment_type":"issue_comment","sequence":2,"text":"A workaround to revert to old behaviour at runtime is to specify:\n\n \npython\n@compiles(String)\n def compile_varchar(element, compiler, **kw):\n if element.length == 'unbounded':\n return \"VARCHAR\"\n else:\n return compiler.visit_VARCHAR(element, **kw)\n\nand then use it as in:\n\npython\nselect(\n some_table.integer_col.cast(String('unbounded'))\n)\n\nwhen a cast to VARCHAR is needed.\n\n@laughingman7743 I think that a possible \"correct\" solution would be specifying two different _TypeCompiler_,s one (with hive mapping) to be used by the _DDLCompiler_ and one (with presto mapping) to be used by the _SQLCompiler_. \n\nIt could then be possible to override the attribute _type_compiler_ of the _DDLCompiler_ (which by default maps to the _Dialect_ one) in order to make it use the one with the correct mapping.","author_login":"andreaschiappacasse","author_association":"NONE","created_at":"2022-03-09T12:09:50+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1162936391,"issue_number":289,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1139298327","fragment_type":"issue_description","sequence":0,"text":"Creating tables with SQLAlchemy models supported?\nThe first issue I encountered:\n\nsqlalchemy.exc.CompileError: You need to specify the storage location for the table using the `awsathena_location` dialect keyword argument\n\nI was able to address this with something like:\n\nBase.metadata.tables['my_table'].dialect_options['awsathena']['location'] = location\n\nThere is probably a better solution, but this is all I could come up with so far.\n\nOnce I fixed this, I encountered this:\n\nsqlalchemy.exc.DatabaseError: (pyathena.error.DatabaseError) An error occurred (InvalidRequestException) when calling the StartQueryExecution operation: line 1:8: mismatched input 'EXTERNAL'. Expecting: 'OR', 'SCHEMA', 'TABLE', 'VIEW'\n\nI debugged this on the Athena console and determined the issue is the SQL generated has primary key constraints which are not supported by Athena. Removing the primary key constraint in SQLAlchemy gives:\n\nsqlalchemy.exc.ArgumentError: Mapper mapped class Institution->institution could not assemble any primary key columns for mapped table 'my_table'\n\nAm I in unsupported territory or am I doing something wrong?","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-15T22:57:09+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1041500600","fragment_type":"issue_comment","sequence":1,"text":"Without the executed code and the stack trace, I can't examine anything. Please share the code you executed and the stack trace that resulted in the error first.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-16T13:37:52+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1041502995","fragment_type":"issue_comment","sequence":2,"text":"Here are the tests related to CREATE TABLE in SQLAlchemy.\n URL \nMaybe it will help you in some way.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-16T13:40:34+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1041823244","fragment_type":"issue_comment","sequence":3,"text":"Thanks, this did help me figure out a better way to provide the location:\n\n __table_args__ = { 'awsathena_location': location }","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-16T16:04:41+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1041879208","fragment_type":"issue_comment","sequence":4,"text":"Great, thanks. I did more poking around and it seems SQLAlchemy requires a primary key. So perhaps in this scenario pyathena would omit this constraint when passing to Athena, since Athena does not support it?","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-16T16:59:06+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1041884940","fragment_type":"issue_comment","sequence":5,"text":"URL \nI don't know the detailed implementation of SQLAlchemy, but I don't generate DDLs that specify about the primary key when generating DDLs, though.\n URL","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-16T17:04:31+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1041920476","fragment_type":"issue_comment","sequence":6,"text":"Thanks for the link regarding mapping a table that has no primary key. However, I don't think the solution applies here. It shows how to specify multiple columns to make up a primary key.","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-16T17:39:16+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1046189578","fragment_type":"issue_comment","sequence":7,"text":"Why are you specifying PrimaryKey when Athena doesn't support it in the first place? I don't understand.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-20T08:38:48+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1046191114","fragment_type":"issue_comment","sequence":8,"text":"URL \nThis is where the PrimaryKey constraint will be added. This process is probably not necessary in Athena.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-20T08:47:48+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1046209519","fragment_type":"issue_comment","sequence":9,"text":"In the case of DDL, I get an error if the Integer type is not INT.\n\nI removed table constraints and fixed the INT type handling in the following branches.\n URL \nPlease check it out.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-20T10:44:32+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048161871","fragment_type":"issue_comment","sequence":10,"text":"Only because SQLAlchemy complains if there is no primary key defined.","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-22T19:59:33+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048166922","fragment_type":"issue_comment","sequence":11,"text":"We had created an ugly work-around in the meantime by walking the ORM class attributes and generating the CREATE_TABLE SQL. I will try your solution as soon as I can. Thanks!","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-22T20:05:42+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048692691","fragment_type":"issue_comment","sequence":12,"text":"I've added a simple test case.\n URL \nI'm not sure of the use case for this feature. If there is a test case you need, please let me know.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-23T11:36:55+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1051140041","fragment_type":"issue_comment","sequence":13,"text":"Unfortunately, it didn't work 100%. It looks like the primary key part is working, but there is some issue with the VARCHAR type handling. Athena requires a size to be specified for VARCHAR:\n\nTraceback (most recent call last):\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 1803, in _execute_context\n cursor, statement, parameters, context\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/default.py\", line 732, in do_execute\n cursor.execute(statement, parameters)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/pyathena/util.py\", line 37, in _wrapper\n return wrapped(*args, **kwargs)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/pyathena/cursor.py\", line 108, in execute\n raise OperationalError(query_execution.state_change_reason)\npyathena.error.OperationalError: FAILED: ParseException line 2:0 mismatched input ')' expecting ( near 'VARCHAR' in primitive type specification\n\nThe above exception was the direct cause of the following exception:\n\nTraceback (most recent call last):\n File \"pyathena_test.py\", line 35, in \n Base.metadata.tables['mytable'].create(athena_engine)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/sql/schema.py\", line 950, in create\n bind._run_ddl_visitor(ddl.SchemaGenerator, self, checkfirst=checkfirst)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 3117, in _run_ddl_visitor\n conn._run_ddl_visitor(visitorcallable, element, **kwargs)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 2113, in _run_ddl_visitor\n visitorcallable(self.dialect, self, **kwargs).traverse_single(element)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/sql/visitors.py\", line 524, in traverse_single\n return meth(obj, **kw)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/sql/ddl.py\", line 898, in visit_table\n include_foreign_key_constraints, # noqa\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 1289, in execute\n return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/sql/ddl.py\", line 81, in _execute_on_connection\n self, multiparams, params, execution_options\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 1387, in _execute_ddl\n compiled,\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 1846, in _execute_context\n e, statement, parameters, cursor, context\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 2027, in _handle_dbapi_exception\n sqlalchemy_exception, with_traceback=exc_info[2], from_=e\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/util/compat.py\", line 207, in raise_\n raise exception\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 1803, in _execute_context\n cursor, statement, parameters, context\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/sqlalchemy/engine/default.py\", line 732, in do_execute\n cursor.execute(statement, parameters)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/pyathena/util.py\", line 37, in _wrapper\n return wrapped(*args, **kwargs)\n File \"/home/ec2-user/environment/pyathena_test/pr_virtenv/lib/python3.7/site-packages/pyathena/cursor.py\", line 108, in execute\n raise OperationalError(query_execution.state_change_reason)\nsqlalchemy.exc.OperationalError: (pyathena.error.OperationalError) FAILED: ParseException line 2:0 mismatched input ')' expecting ( near 'VARCHAR' in primitive type specification\n[SQL: \nCREATE EXTERNAL TABLE mytable (\n pk INT, \n name VARCHAR\n)\nSTORED AS PARQUET\nLOCATION 's3://terry-athena-bucket/mytable/'","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-25T19:38:51+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1051192472","fragment_type":"issue_comment","sequence":14,"text":"Update: I think the issue is that the type mappings from SQLAlchemy to Athena probably were not necessary before if only queries were used. In our work-around we are mapping the SQLAlchemy to Athena for the types we are using so far (not complete):\n\nINTEGER->integer\nDATETIME->timestamp\nFLOAT->double\nVARCHAR->string\nBOOLEAN->boolean\nBIGINT->bigint\n\nand then the more ugly part:\n\nVARCHAR(40)->varchar(40)\n\nBtw, if I change the test code from:\n\n name = Column('name', String)\n\nto\n\n name = Column('name', String(40))\n\nThen PR #281 works.","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-25T20:11:16+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1053574518","fragment_type":"issue_comment","sequence":15,"text":"I'm trying a change in another branch to make it a STRING type when the length is not specified in VARCHAR.\n URL","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-02-27T14:36:16+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1054642984","fragment_type":"issue_comment","sequence":16,"text":"Mapping VARCHAR with no length to string seems reasonable. It is what we are doing in our work-around.","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-28T20:39:56+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1054670136","fragment_type":"issue_comment","sequence":17,"text":"Sorry, my mistake, I didn't realized it was merged. My original small test now works using pr 281.","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-02-28T21:16:09+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1055072129","fragment_type":"issue_comment","sequence":18,"text":"Thanks for the confirmation, I'll merge the PR.\nI will be releasing the next version 2.5.0 once I have addressed #284.","author_login":"laughingman7743","author_association":"OWNER","created_at":"2022-03-01T06:28:39+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1055561147","fragment_type":"issue_comment","sequence":19,"text":"OK, great! The next step on my side is to try our full application with all our tables and data types.","author_login":"terrylimnsv","author_association":"NONE","created_at":"2022-03-01T15:24:51+08:00","repo_name":"laughingman7743/PyAthena","issue_id":1139298327,"issue_number":279,"issue_url":"https://github.com/laughingman7743/PyAthena/issues/279","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0292","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Hiding long sections partially?","query_context":"### Context\n\nThis request is a follow to a GitHub discussion.\n\n### Description\n\nI write documentation and tutorials which may have long sections, between two options. For example:\n\nmarkdown\nYou could do it this way:\n\n- long set of instructions\n\nOr this other way:\n\n- Another long set of instructions\n\nI would like the ability to show a preview of long sections of texts and fold/unfold to see the full text. \n\n### Related links\n\n- AWS documentation site with this capability\n\n### Use Cases\n\nOn a long documentation page, not all sections are relevant to the reader, or sections which contain explanations and long code blocks. I would like readers to judge whether they need to see and read those sections, or continue reading the rest of the documentation.\nI expect this to improve readability of long pages. \n\n### Visuals\n\nAn example on how this is done on this AWS documentation site:\n\nimage\n\nAs you can see, some sections are partially hidden, until the reader presses \"Show more\", which unfolds the section.\n\nimage\n\nOne can then click \"Show less\" to fold the section back.\n\n### Before submitting\n\n- [X] I have read and followed the change request guidelines.\n- [X] I have verified that my idea is a change request and not a bug report.\n- [X] I have ensured that, to the best of my knowledge, my idea will benefit the entire community.\n- [X] I have included relevant links to the documentation, related issues, and discussions to underline the need for my idea.","known_context_document_ids":["gh_issue_1977254056"],"reference_answer":"Nice! If you find some time, could you isolate the necessary CSS changes and send a PR? One problem with the label approach is: it's not accessible. if you add `tabIndex=0` to both `label` elements, you can open it with keyboard. Also, proper ARIA attributes are probably a good idea.","answer_document_id":"gh_comment_1440356043","silver_evidence_path":["gh_comment_1793475561","gh_issue_1564074000","gh_comment_1440356043"],"evidence_issue_ids":[1977254056,1564074000],"source_repo_name":"squidfunk/mkdocs-material","source_issue_id":1977254056,"source_issue_number":6289,"source_issue_url":"https://github.com/squidfunk/mkdocs-material/issues/6289","target_repo_name":"squidfunk/mkdocs-material","target_issue_id":1564074000,"target_issue_number":4964,"target_issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","reference_anchor_document_id":"gh_comment_1793475561","reference_answer_author":"squidfunk","reference_answer_author_association":"OWNER","quality_score":94.85,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3077,"anchor_target_overlap":0.2308,"target_answer_overlap":0.0769},"issue_created_at":"2023-11-04T09:32:11+08:00","valid_comment_count":43,"fragments":[{"document_id":"gh_issue_1977254056","fragment_type":"issue_description","sequence":0,"text":"Hiding long sections partially\n### Context\n\nThis request is a follow to a GitHub discussion.\n\n### Description\n\nI write documentation and tutorials which may have long sections, between two options. For example:\n\nmarkdown\nYou could do it this way:\n\n- long set of instructions\n\nOr this other way:\n\n- Another long set of instructions\n\nI would like the ability to show a preview of long sections of texts and fold/unfold to see the full text. \n\n### Related links\n\n- AWS documentation site with this capability\n\n### Use Cases\n\nOn a long documentation page, not all sections are relevant to the reader, or sections which contain explanations and long code blocks. I would like readers to judge whether they need to see and read those sections, or continue reading the rest of the documentation.\nI expect this to improve readability of long pages. \n\n### Visuals\n\nAn example on how this is done on this AWS documentation site:\n\nimage\n\nAs you can see, some sections are partially hidden, until the reader presses \"Show more\", which unfolds the section.\n\nimage\n\nOne can then click \"Show less\" to fold the section back.\n\n### Before submitting\n\n- [X] I have read and followed the change request guidelines.\n- [X] I have verified that my idea is a change request and not a bug report.\n- [X] I have ensured that, to the best of my knowledge, my idea will benefit the entire community.\n- [X] I have included relevant links to the documentation, related issues, and discussions to underline the need for my idea.","author_login":"ojacques","author_association":"CONTRIBUTOR","created_at":"2023-11-04T09:32:11+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1977254056,"issue_number":6289,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/6289","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1793402179","fragment_type":"issue_comment","sequence":1,"text":"An immediate solution would be to use a custom admonition that is collapsible. With some tweaking, this could be made to look similar to what Amazon do - if, say, you do not like the border around the admonition. If you use the block syntax that the Pymdown Extensions provide then you don't have to worry about indentation as much.","author_login":"alexvoss","author_association":"COLLABORATOR","created_at":"2023-11-04T10:09:07+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1977254056,"issue_number":6289,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/6289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1793475561","fragment_type":"issue_comment","sequence":2,"text":"More specifically, you could try and adapt what I've done here: URL The example was specifically targeting code blocks, but it could be adapted for any content.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-11-04T15:26:46+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1977254056,"issue_number":6289,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/6289","linked_issue_ids":[1564074000],"is_known_query_context":false},{"document_id":"gh_comment_1793660761","fragment_type":"issue_comment","sequence":3,"text":"Thanks for suggesting! We'll evaluate this as a potential change request in the future. If you want to go ahead and check if you can find any potential approaches how this can be elegantly solved, feel free to share them here!","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-11-05T07:26:15+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1977254056,"issue_number":6289,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/6289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1564074000","fragment_type":"issue_description","sequence":0,"text":"Expandable Code Blocks\n### Context\n\n_No response_\n\n### Description\n\nAdd option to make code blocks expandable so that only a few lines are shown at first place. A button below the code block will give the option to expand it entirely.\n\n### Related links\n\n- URL \n- URL \n- Collapsible blocks\n\n### Use Cases\n\n- Authors perspective: Long code blocks are sometimes required in references, how-to guides, examples, etc. However, they will break the reading flow of the page which can defeat the purpose of it. On the other hand, hiding code blocks with collapsible admonitions is the other extreme, which removes the visual stylistic device of having code bocks between paragraphs.\n- User perspective: Large code blocks can lead to get lost/overwhelmed if new to a topic. Being able to read a page first, from top to bottom, helps to get a basic understanding before looking at details. Expandable code blocks encourage to do so and signalize that there is an important piece of code, but it can be skipped safely until it might be required later.\n\n### Visuals\n\nimage\nSource: URL \n\n### Before submitting\n\n- [X] I have read and followed the change request guidelines.\n- [X] I have verified that my idea is a change request and not a bug report.\n- [X] I have ensured that, to the best knowledge, my idea will benefit the entire community.\n- [X] I have included relevant links to the documentation, related issues and discussions to underline the need for my idea.","author_login":"azbpa","author_association":"NONE","created_at":"2023-01-31T10:49:17+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435698146","fragment_type":"issue_comment","sequence":1,"text":"Thanks for suggesting. I've investigated possible ways of implementing this, and I think I found a way that works without JavaScript! We would need a little support from the Highlight extension, provided by Python Markdown Extensions. The solution is similar to what we do with content tabs.\n\n \n HTML prototype \n\n html\n \n \n \n \n code {\n display: block;\n padding: 10px;\n background: #eee;\n overflow: auto;\n }\n code input {\n display: none;\n }\n .__collapse {\n display: none;\n }\n code input:checked + .__collapse {\n display: inline;\n }\n code label {\n background: blue;\n color: white;\n padding: 4px 10px;\n cursor: pointer;\n }\n code input:checked + .__collapse ~ [for=__open] {\n display: none; /* Hide expand button - could possible be kept */\n }\n \n \n \n \n markdown_extensions:\n\n # Python Markdown\n - abbr\n - admonition\n - attr_list\n - def_list\n - footnotes\n - md_in_html\n - toc:\n permalink: true\n \n # Python Markdown Extensions\n - pymdownx.arithmatex:\n generic: true\n - pymdownx.betterem:\n smart_enable: all\n - pymdownx.caret\n - pymdownx.details\n - pymdownx.emoji:\n emoji_index: !!python/name:materialx.emoji.twemoji\n emoji_generator: !!python/name:materialx.emoji.to_svg\n - pymdownx.highlight\n - pymdownx.inlinehilite\n - pymdownx.keys\n - pymdownx.mark\n - pymdownx.smartsymbols\n - pymdownx.superfences\n - pymdownx.tabbed:\n alternate_style: true\n - pymdownx.tasklist:\n custom_checkbox: true\n - pymdownx.tilde\n \n Expand \n \n \n \n\n \n\nThe prototype looks like this:\n\n<img width=\"395\" alt=\"Bildschirmfoto 2023-02-18 um 16 09 20\" src=\" URL \n\n<img width=\"398\" alt=\"Bildschirmfoto 2023-02-18 um 16 09 14\" src=\" URL \n\nThe next step would be to on-board @facelessuser, and check if he would be willing to implement something like this, given that it fits the tone and vision of the Highlight extension. When this is done, we could add styling support in Material for MkDocs. In any case, this needs to be taken upstream, and there are no actionables for us until support is added.\n\n---\n\n__Further considerations__:\n\n- It makes no sense to add this functionality in JavaScript, since we would induce massive content shift when the page is rendered, especially when the page is long and has a lot of code blocks\n- I've only found the `input` + `label` technique to work. Another candidate would be `details`, but that would induce a new block formatting context, breaking out of the `code` block, thus a dead-end. However, the solution I prototyped works beautifully and even keeps code annotations functional, because we're not inducing `overflow` on the container.","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-18T15:17:15+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435712517","fragment_type":"issue_comment","sequence":2,"text":"I'm not so sure how all this would work, but I'm willing to at least talk about it and see if it maybe could work somehow. I have concerns about this, especially when paired with Pygments. This is taking a very simple case and applying such logic, but what about when syntax highlighting is at play? What if we are applying this to a code block using the table format and line numbers?\n\nEven if this is too convoluted for Highlight, we _might_ be able to provide a new general-purpose block that applies something like this to a given code block. General purpose blocks are getting closer and closer to being ready for the public to start trying. I guess there are always custom fences as well.\n\nAnyways, while I see _maybe_ a possibility when done with a very simple example as shown above, there are definitely some concerns with this playing nice with other features enabled.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-18T16:35:43+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435714003","fragment_type":"issue_comment","sequence":3,"text":"Couldn't this be done similar to / or with line spans? We could even make this configurable similar to `hl_lines`, e.g. `collapse_lines=\"4\"` to collapse everything from the 4th line on, or `collapse_lines=\"4-8\"` to only collapse lines 4-8. As I understand, only the line spans would need to be wrapped, so this should – in theory – be possible to implement as a post processor, not?","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-18T16:43:34+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435717259","fragment_type":"issue_comment","sequence":4,"text":"Hmm, no, not yet. I don't think it will work with tables. But I guess it might work with `pymdownx-inline`, right?","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-18T17:00:52+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435718666","fragment_type":"issue_comment","sequence":5,"text":"I'm still not sure why we couldn't use generic blocks to create a simple collapsible wrapper.\n\n`\n/// collapse\n\nsome\ncode\nwith a lot\nof lines\n\n///\n\n`\n\nIf I'm being honest, I'm not a huge fan of wrapping lines with an input checkbox. Maybe it will grow on me? \n\nI'm not saying I'm against the suggested approach, but I'm skeptical that there is no other way, and that this is the best and only way. That's not to discount the research you've put into this. If I were going to do something like this, it needs to work generally well and I'd probably want to explore some other avenues even if they lead to dead ends. If I'm to support such an approach, I want to be 100% sure I couldn't approach this in a better way.\n \n\nI imagine it could work fine with `pymdownx-inline`.\n\nI know there are some complications right now, but I know things like `:has()` are on the horizon. Browsers are moving forward with this where they weren't before. Granted, they will be somewhat limited for the sake of performance, but they are coming, granted, I don't know how many years until we can actually use them. So clearly, this isn't available now, but something to keep in mind as we are thinking forward.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-18T17:06:47+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435724365","fragment_type":"issue_comment","sequence":6,"text":"I'm agnostic to how things are implemented – this was just a first rough sketch. Let's let that sit for a while and maybe come back to it later at some point. I think it would be a great addition to the toolbelt.","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-18T17:37:19+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435742058","fragment_type":"issue_comment","sequence":7,"text":"Yep, that makes sense. I may tinker with the idea myself. It may be that this is the only pure CSS approach right now, but that probably just highlights the weakness in the current, implemented CSS spec. I'm just hesitant a bit right now as it is an invasive approach and only works on some of the supported code block styles, and I'm certain the future will allow us to do this better if there isn't already a way now. I won't deny that many may find the feature useful though.\n\nI have a feeling that if I did implement this as currently proposed, I'd be more willing to post-process it in some generic block as described above than make it an integrated part of Highlight. That would give me the ability to implement an approach native to Highlight at some future point when the landscape is a bit more attractive for a pure CSS, collapsible block. I could just bundle it in Material Extras or something like that.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-18T19:06:20+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435787814","fragment_type":"issue_comment","sequence":8,"text":"I feel like something like this could work. No JS, just CSS. It's kind of sloppy right now, but the idea is simply that it sets the max height on the block and fades the text at the bottom. When you expand, it shows everything.\n\n URL \n\ncollapse","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-18T23:03:41+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435836282","fragment_type":"issue_comment","sequence":9,"text":"Pulled it off in Material using generic blocks:\n\n<img width=\"789\" alt=\"Screenshot 2023-02-18 at 8 53 50 PM\" src=\" URL","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-19T03:54:42+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435904288","fragment_type":"issue_comment","sequence":10,"text":"After tweaking it a bit, I'm thinking this is probably a fairly reasonable approach. If you wanted to not have it collapsable after expansion, the button could just be hidden after expansion. I think a reasonable alternative is just adding a class to a code block and making it shorter, but scrollable, but if expanding blocks is absolutely desired, I think this approach could work and wouldn't require us to deeply integrate it into Highlight. We just create a simple wrapper around the code blocks. Anyways, I think I'm done exploring this for now.\n\ncollapse","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-19T06:18:20+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435928118","fragment_type":"issue_comment","sequence":11,"text":"Does this work with code annotations? FWIW, setting `max-height` implies `overflow: hidden`, and this might mess with code annotations. Strangely, I thought it was definite, but it seems like it works in Webkit. Not sure about other browsers, though. This is why I resorted to the nested span solution, which I still find to be more flexible, as it would allow for supporting multiple foldable sections.\n\nSo, this still works in Chrome (to my surprise), but other browsers would need to be tested:\n\n<img width=\"391\" alt=\"Bildschirmfoto 2023-02-19 um 09 48 50\" src=\" URL","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-19T08:49:37+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1435998839","fragment_type":"issue_comment","sequence":12,"text":"I had not tested annotations, in your test, do the annotations need to be wrapped in the container or outside?\n \n\nI guess I missed this part. I've never seen this done anywhere.\n\nI thought this was for posting large code blocks without taking up a ton of space. I didn't realize people wanted multiple foldable sections. This seems like it creates very complex code examples. I guess some your suggestions make more sense in context now.\n\nIf multiple, foldable code blocks is really what is desired, then we could still go with your idea, but I think approaching it with a special Material, generic block would be the ideal way to go as least for now. I'm not exactly sure how complicated I want Highlight to be. At the very least, it would allow me to ship the functionally as it's own experimental thing and have it mature in Material first. This may be a good candidate for the Material Extra repo that I already maintain.\n\nSo, I imagine we could have a block that you can wrap your code (and annotations?) in, and we could extract the HTML for the code block and then post process it with foldable sections.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-19T14:07:00+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436044356","fragment_type":"issue_comment","sequence":13,"text":"Just a note, the simple expand option I provided worked fine in Firefox, Chrome, and Safari. As a simple option, it is more than sufficient and very quick and easy to get working as I technically already have a prototype.\n\nBut if we absolutely want multiple folding regions, that can be done. It's obviously more work in the post-processing realm, but I imagine doable.\n\nRegardless of which direction we go, I'll probably utilize the generic block feature that should be available soon-ish. Deep integration into Highlight may or may not happen at some future time.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-19T17:19:34+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436331649","fragment_type":"issue_comment","sequence":14,"text":"My current focus is to get out the generic block plugin out. I'll personally be using the basic fold in my own documents as I'm actually kind of liking the look and functionality. I can't see any negatives except that it isn't as quite as powerful as the per-line folding approach. FWIW I think it works well for what I personally need. If it turns out people are interested, I don't mind making it publically available.\n\n<img width=\"804\" alt=\"Screenshot 2023-02-19 at 9 21 48 PM\" src=\" URL \n\nAs far as the more complex folding approach, I'll probably look at it sometime after the generic blocks plugin is released. I'm not exactly sure when, but it would definitely be after that gets out. I think it is generally more complex than I personally need, but I can see people maybe wanting to utilize this approach as it does open up more possibilities. I think we can achieve everything in the suggested prototype without having to deeply integrate this into Highlight.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-20T05:01:22+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436493021","fragment_type":"issue_comment","sequence":15,"text":"@squidfunk / @facelessuser thanks for the great discussion the this request. \n\nThe last screenshot shared looks like what I was imagining. If I got the discussion right, this is based on pure CSS and thereby could be already added using customization stylesheet file. \n\nI would appreciate if you would share your current code so I could test it.","author_login":"azbpa","author_association":"NONE","created_at":"2023-02-20T07:48:23+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436540264","fragment_type":"issue_comment","sequence":16,"text":"@facelessuser the last screenshot you posted looks pretty good. Could you create a PR with the necessary changes when the generic block plugin is out? And this is language agnostic, right?\n\nRegarding multiple foldable regions – this might be something for the future, so no hurry.","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-20T08:28:37+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1437052723","fragment_type":"issue_comment","sequence":17,"text":"It certainly can be. Right now I have the enable/disable labels with optional text. In the screenshot, I just set the option with no text and specify icons in the style. There are tooltips as well where you can change the text, these also can bet set to nothing to disable them.\n \n\nYep, totally understand. I'm hoping to have the general blocks available sometime soon-ish, so once they are out I'll decide whether I mainline the demoed collapsible block, or drop it in Material Extra. Regardless, once available, I'll create a pull request so you can polish up anything you don't like 🙂.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-20T13:48:37+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1440199171","fragment_type":"issue_comment","sequence":18,"text":"@azbpa I'm about to release a beta of the general purpose blocks: URL \n\nThe actual plugin is here: URL It will not work yet without the pymdownx beta release as it builds on the general purpose block framework in that release. I might get the beta out today?\n\nAs mentioned, it does work with just CSS. The bulk of it is here: URL \n\nThere may be some corner cases for tabs and mobile where some things may need to be adjusted. I think I made some of those changes, but I haven't gathered all the specific changes into one place yet, and this is based on my docs which do have some custom stuff, so I really need to play with this in a pure Material environment to give a complete bare minimum of what is required.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-22T14:58:29+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1440335611","fragment_type":"issue_comment","sequence":19,"text":"Beta is live. Real-world you can play with here: example here: URL","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-02-22T16:15:30+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1440356043","fragment_type":"issue_comment","sequence":20,"text":"Nice! If you find some time, could you isolate the necessary CSS changes and send a PR? One problem with the label approach is: it's not accessible. if you add `tabIndex=0` to both `label` elements, you can open it with keyboard. Also, proper ARIA attributes are probably a good idea.","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-22T16:27:09+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1440442284","fragment_type":"issue_comment","sequence":21,"text":"Thinking about ARIA, I think we need to do this in JS. IIRC, we need to set `aria-expanded` on the code block dynamically, i.e., whenever it is expanded or collapsed. We'll do ARIA attributes in Material for MkDocs.\n\nOne more thing: we need to be able to translate the `title` attributes of the labels. I guess that means we need those as options, similar to `permalink_title` in the `toc` extension. This will also integrate nicely with improved tooltips.","author_login":"squidfunk","author_association":"OWNER","created_at":"2023-02-22T17:09:06+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1715798258","fragment_type":"issue_comment","sequence":22,"text":"@facelessuser apologies if I missed it but I couldn't find any further references to this. Was this ever brought out of beta? I tried searching for how to enable this feature but couldn't find anything. If the answer is custom CSS that is fine, just wanted to check. Thank you!","author_login":"Vasperous","author_association":"NONE","created_at":"2023-09-12T14:07:12+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1717507575","fragment_type":"issue_comment","sequence":23,"text":"Thank you! Looking forward to seeing it as I have some lengthy code blocks which this feature would be extremely helpful for.","author_login":"Vasperous","author_association":"NONE","created_at":"2023-09-13T12:11:53+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1718085465","fragment_type":"issue_comment","sequence":24,"text":"Using this custom extension: URL to wrap a single code block, paired with the following CSS should be all that is needed.\n\n \n Minimum Required CSS \n\ncss\n.md-typeset .collapse-code{\n position:relative;\n margin-top:1em;\n margin-bottom:1em\n}\n.md-typeset .collapse-code pre,\n.md-typeset .collapse-code .highlighttable {\n margin-top:0;\n margin-bottom:0\n}\n.md-typeset .collapse-code input{\n display:none\n}\n.md-typeset .collapse-code input~.code-footer{\n width:100%;\n margin:0;\n padding:.25em .5em .25em 0\n}\n.md-typeset .collapse-code input~.code-footer label{\n position:relative;\n margin:.05em;\n padding:.15em .8em;\n color:var(--md-primary-bg-color);\n font-size:90%;\n background-color:var(--md-primary-fg-color);\n -webkit-mask-repeat:no-repeat;\n mask-repeat:no-repeat;\n -webkit-mask-size:contain;\n mask-size:contain;\n border-radius:.1rem;\n cursor:pointer;\n content:\"\"\n}\n.md-typeset .collapse-code input~.code-footer label:hover{\n background-color:var(--md-accent-fg-color)\n}\n.md-typeset .collapse-code input~.code-footer label::before{\n position:absolute;\n top:.15em;\n left:.15em;\n display:block;\n box-sizing:border-box;\n width:1.25em;\n height:1.25em;\n background-color:var(--md-primary-bg-color);\n background-size:1.25em;content:\"\"\n}\n.md-typeset .collapse-code input~.code-footer label.expand{\n display:none\n}\n.md-typeset .collapse-code input~.code-footer label.expand::before{\n -webkit-mask-image:url('data:image/svg+xml;charset=utf-8, ');\n mask-image:url('data:image/svg+xml;charset=utf-8, ')\n}\n.md-typeset .collapse-code input~.code-footer label.collapse::before{\n -webkit-mask-image:url('data:image/svg+xml;charset=utf-8, ');\n mask-image:url('data:image/svg+xml;charset=utf-8, ')\n}\n.md-typeset .collapse-code input:checked~.code-footer label.expand{\n display:inline\n}\n.md-typeset .collapse-code input:checked~.code-footer label.collapse{\n display:none\n}\n.md-typeset .collapse-code input:checked+div.highlight code,\n.md-typeset .collapse-code input:checked+div.highlight .linenodiv{\n max-height:9.375em;\n overflow:hidden\n}\n.md-typeset .collapse-code input:checked~.code-footer{\n position:absolute;\n bottom:0;\n left:0;\n padding:2em .5em .5em .8rem;\n background-image:linear-gradient(to bottom,transparent,var(--md-default-bg-color) 80% 100%)\n}\n\n.md-typeset .tabbed-block>.collapse-code:first-child,\n.md-typeset .tabbed-block>.collapse-code:first-child {\n margin: 0;\n}\n\n@media screen and (max-width:44.9375em){\n .md-typeset>.collapse-code{\n margin-right:-.8rem;\n margin-left:-.8rem\n }\n .md-typeset>.collapse-code label.collapse{\n left:.8rem\n }\n}\n\n \n\n<img width=\"878\" alt=\"Screenshot 2023-09-13 at 11 56 52 AM\" src=\" URL \n\nIf you were to wrap anything other than code blocks or you were to wrap more than a singular code block, it is likely you would get odd styling. This is styled to mimic how Material handles singular code blocks with the added interface to expand them.\n\nFor Material to integrate this, I would need to officially release the custom plugin. And to do that, I'd like to get feedback from @squidfunk first. Once in the wild, it is unlikely I would make any large changes to it.\n\nCurrently, I just place the custom plugin in my projects `tools` folder and configure it like so:\n\n URL","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-09-13T18:03:27+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771910369","fragment_type":"issue_comment","sequence":25,"text":"@facelessuser actually I cannot get the solution to work, I created the tools folder locally and can never get mkdocs to find the extension. I found a recommendation to use `python -m mkdocs serve` which got rid of the error but the processing never actually occurred. I even put the collapse_code.py in my package folder (i.e., in pip) but still no luck even after getting it to past the error.\nI feel like I am missing something basic.","author_login":"Vasperous","author_association":"NONE","created_at":"2023-10-20T01:05:58+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771930540","fragment_type":"issue_comment","sequence":26,"text":"I did some more research and it looks like I have to use the Blocks feature, is there a way to do this without using Blocks?","author_login":"Vasperous","author_association":"NONE","created_at":"2023-10-20T01:23:57+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771986368","fragment_type":"issue_comment","sequence":27,"text":"@facelessuser no specific reason other than its not something I am terribly familiar with. In this case its a syntax I am using just for the collapse code. Regardless, thank you for the help, much appreciated :)","author_login":"Vasperous","author_association":"NONE","created_at":"2023-10-20T02:38:23+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771996749","fragment_type":"issue_comment","sequence":28,"text":"Well, you are free to write your own plugin instead or use raw HTML that matches what the CSS expects.","author_login":"facelessuser","author_association":"CONTRIBUTOR","created_at":"2023-10-20T02:53:42+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1824848703","fragment_type":"issue_comment","sequence":29,"text":"I wonder if the extension/plugin proposed by @facelessuser can be further extended to expand horizontally as well?\n\nAs per the linked issue I logged URL in the tech docs we often work with data tables, and tables are known to span wide.\n\nIt would be amazing to have an option to expand in both ways as shown here in the description.\n\n**I am willing to sponsor this work.**","author_login":"hellt","author_association":"CONTRIBUTOR","created_at":"2023-11-23T19:35:18+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1898039123","fragment_type":"issue_comment","sequence":30,"text":"I think having full-width, expandable or else options to show _more_ is useful for a technical documentation engine. Think of command line output, for example. Currently, and depending on what customisation or plugin (i.e. URL the output isn't always easy to read.\n\nI am experimenting with it at URL Content gets truncated which is not great.","author_login":"NikosAlexandris","author_association":"NONE","created_at":"2024-01-18T08:46:44+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945889552","fragment_type":"issue_comment","sequence":31,"text":"Here is a good example how fullscreen code blocks are done on dev.to\n URL \n\n URL","author_login":"hellt","author_association":"CONTRIBUTOR","created_at":"2024-02-15T11:19:07+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2146768241","fragment_type":"issue_comment","sequence":32,"text":"Since it took me a moment to get tools/collapse_code.py to work let me note here a few things that might make it easier for future visitors:\n\nDue to the way pythons sys.path is populated you either have to use python3 -m mkdocs or add . to your PYTHONPATH to make this work ( which is super inconvenient for my setup, I am still looking for a way to add it from within the mkdocs config )\n\nNot setting expand_text/collapse_text to empty will cause the two arrow icons to overlap the text. I added padding-left: 1.5em to my css for label.expand and label.collapse to make it look better for my case, no idea though if that will be useful for the general public.\n\nIt Seems to be unclear how to use it within markdown syntax, so this is how the syntax looks for me and works:\n\n`\n/// collapse-code\n\nall the code in multiple lines\n\n///\n\n`\n\nAll in all I find this thing quite useful and am wondering if we could get that maybe as part of the official extensions package? The setup is quite a bit more involved than for everything else, especially with the sys.path thing being a major invonvenience at least for me.\n\nPS: Maybe it would be possible to add the number of lines or so as a parameter that the collapsed version should be in size? Sometimes it seems quite appropriate to me to be able to chose...\n\nPPS: would making an option to have a scrollable code box fit in here as well or would it make sense to have that as a completely seperate feature?","author_login":"PlasmaHH","author_association":"NONE","created_at":"2024-06-04T07:07:38+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2357925833","fragment_type":"issue_comment","sequence":33,"text":"I’m interested in using this feature as well and noticed that a solution is already available above URL .\n\nWith that in mind, would it be possible to make this a default feature and include a reference to it in the documentation at Code Blocks Reference?\n\nMany thanks for your consideration!","author_login":"kolibril13","author_association":"NONE","created_at":"2024-09-18T09:13:25+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[1564074000],"is_known_query_context":false},{"document_id":"gh_comment_2357941798","fragment_type":"issue_comment","sequence":34,"text":"Sure! We're working on much bigger things right now, but we will very likely consider this again at a later point.","author_login":"squidfunk","author_association":"OWNER","created_at":"2024-09-18T09:20:38+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2357949527","fragment_type":"issue_comment","sequence":35,"text":"That's great to hear! All the best for your next development steps!","author_login":"kolibril13","author_association":"NONE","created_at":"2024-09-18T09:24:09+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2566716534","fragment_type":"issue_comment","sequence":36,"text":"I'm interested in this for a different reason. I'd like to add an expandable \"table of contents\" link at the top of each page.\n\nThe reason is that most people use phones to browse the internet now, and the existing TOC on the right side is geared for desktop users (with wide enough screens). But I don't want to remove the right-side TOC for desktop users. So I'd like to add an additional toc, but not have it expanded by default since there will be multiple TOCs.\n\nI think this would be preferable for phone-users because the \"back to top\" button on each page makes it easier to see and use a TOC at the top vs the one that's less obvious in their mobile menu. But I think the right-side TOC is preferable for desktop users.","author_login":"MaximilianKohler","author_association":"NONE","created_at":"2024-12-31T21:23:30+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2572502685","fragment_type":"issue_comment","sequence":37,"text":"We use a macro plugin that expands a toc macro to something similar to:\n\nmarkdown\n???+ note inline end \"Table of Contents\"\n [TOC]\n\n(For `[TOC]` to work you must enable the toc markdown extension)","author_login":"PlasmaHH","author_association":"NONE","created_at":"2025-01-06T07:57:37+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2576209973","fragment_type":"issue_comment","sequence":38,"text":"It is mkdocs-macros but thats besides the point, the point was what it expands to, the snippet I showed is basically an exapandable toc as it uses the classic mkdocs material collapsible admonition via `???+`","author_login":"PlasmaHH","author_association":"NONE","created_at":"2025-01-07T20:59:45+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2576409347","fragment_type":"issue_comment","sequence":39,"text":"Oh wow. I searched the docs for \"expandable\" and didn't see any mention of that.\n\nWow, it even automatically creates the TOC! Nice!\n\nOh my, I see it in the docs now URL ~~Maybe I misspelled it when searching~~. Oh, I only searched for \"expandable\". :(\n\n@squidfunk can we put the word \"expandable\" somewhere on that wiki page? Would you want me to create a PR or would you rather do it your way?\n\nMy suggestion is to use alternative wording for the first paragraph of that section. Change:\n \n\nto\n \n\nI also don't see any mention of `[TOC]` in the docs. URL \n\n**Another possible improvement**:\nThese seem to be the current options:\n\nInline end:\ninline end\n\nInline front:\ninline front\n\nNot inline:\nnot inline\n\nI like the way \"inline\" shortens it, but there doesn't appear to be a way to only shorten it without messing up the alignment.\n\nI even tried a zero-width-space trick, but when you expand it that's not what I want, so I guess \"inline\" doesn't work at all to just shorten the box.\nzwsp inline 01\nzwsp inline 02","author_login":"MaximilianKohler","author_association":"NONE","created_at":"2025-01-07T23:18:14+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2576934520","fragment_type":"issue_comment","sequence":40,"text":"Yes, that's ok.\n \n\n[TOC] is Python Markdown, not Material for MkDocs.","author_login":"squidfunk","author_association":"OWNER","created_at":"2025-01-08T07:33:23+08:00","repo_name":"squidfunk/mkdocs-material","issue_id":1564074000,"issue_number":4964,"issue_url":"https://github.com/squidfunk/mkdocs-material/issues/4964","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0293","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"The reply url host my.home-assistant.io doesn't match with the ones configured on the application?","query_context":"### Checks\n\n- [X] I have searched the existing issues and no issue is describing my issue\n- [X] I have checked the documentation\n- [X] I have installed/try to install the latest version\n\n### The problem\n\nHi @andrea-mattioli I tried to install your integration several times but when I try to authorize the connection thought the link created in the installation phase I receive this message:\n\nI inserted all my datas different time but with now other results but this.\n\nI notice that in the link yo authorize the app (second picture down) there is still the \" URL is this normal?\n\nI the first window of configuration as url to access to HA I use my domain.\n\nsmall note to connect to Ha from internet I use cloudflared on Docker\n\nthanks for your help\n\n` \n \n  |  \n-- | --\nerror | \"invalid_request\"\nerror_description | \"The reply url host my.home-assistant.io doesn't match with the ones configured on the application\"\n\n \n \n `\n\nimmagine\n\nimmagine\n\n### On which thermostat you have the issue?\n\nX8000\n\n### Which version of the Bticino X8000 component are you using?\n\n0.2.0\n\n### Which version of Home Assistant are you using?\n\n2024.3.3\n\n### What type of installation are you running?\n\nHome Assistant Core\n\n### Anything in the logs that might be useful for me?\n\n_No response_\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_2213661334"],"reference_answer":"Make a test by adding all the subnets, if it works then write to Legrand and ask which ones you need to implement and remove the rest!\n\nAlso you can try make a POST (use internet connection):\n\nimport requests\nimport json\n\ndef send_post_request(url, payload):\n headers = {'Content-Type': 'application/json'}\n try:\n response = requests.post(url, data=json.dumps(payload), headers=headers)\n if response.status_code == 200:\n print(\"POST request successful!\")\n print(\"Response:\")\n print(response.json())\n else:\n print(\"POST request failed with status code:\", response.status_code)\n print(\"Response:\")\n print(response.text)\n except Exception as e:\n print(\"An error occurred:\", e)\n\n# payload JSON\npayload = {\n \"key1\": \"value1\",\n \"key2\": \"value2\"\n}\n\n# URL\nurl = \" URL \n\n# POST\nsend_post_request(url, payload)\n\nYou can find the correct endpoint url via Legrand API or via my old integration URL","answer_document_id":"gh_comment_1943458986","silver_evidence_path":["gh_comment_2033759793","gh_issue_2120555193","gh_comment_1943458986"],"evidence_issue_ids":[2213661334,2120555193],"source_repo_name":"andrea-mattioli/bticino_x8000_component","source_issue_id":2213661334,"source_issue_number":19,"source_issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/19","target_repo_name":"andrea-mattioli/bticino_x8000_component","target_issue_id":2120555193,"target_issue_number":9,"target_issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","reference_anchor_document_id":"gh_comment_2033759793","reference_answer_author":"andrea-mattioli","reference_answer_author_association":"OWNER","quality_score":94.45,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.3,"target_answer_overlap":0.069},"issue_created_at":"2024-03-28T16:35:46+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_2213661334","fragment_type":"issue_description","sequence":0,"text":"The reply url host my.home-assistant.io doesn't match with the ones configured on the application\n### Checks\n\n- [X] I have searched the existing issues and no issue is describing my issue\n- [X] I have checked the documentation\n- [X] I have installed/try to install the latest version\n\n### The problem\n\nHi @andrea-mattioli I tried to install your integration several times but when I try to authorize the connection thought the link created in the installation phase I receive this message:\n\nI inserted all my datas different time but with now other results but this.\n\nI notice that in the link yo authorize the app (second picture down) there is still the \" URL is this normal?\n\nI the first window of configuration as url to access to HA I use my domain.\n\nsmall note to connect to Ha from internet I use cloudflared on Docker\n\nthanks for your help\n\n` \n \n  |  \n-- | --\nerror | \"invalid_request\"\nerror_description | \"The reply url host my.home-assistant.io doesn't match with the ones configured on the application\"\n\n \n \n `\n\nimmagine\n\nimmagine\n\n### On which thermostat you have the issue?\n\nX8000\n\n### Which version of the Bticino X8000 component are you using?\n\n0.2.0\n\n### Which version of Home Assistant are you using?\n\n2024.3.3\n\n### What type of installation are you running?\n\nHome Assistant Core\n\n### Anything in the logs that might be useful for me?\n\n_No response_\n\n### Additional information\n\n_No response_","author_login":"Danifly80","author_association":"NONE","created_at":"2024-03-28T16:35:46+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2213661334,"issue_number":19,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/19","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2033759793","fragment_type":"issue_comment","sequence":1,"text":"You must follow the readme and use URL it's only for the first auth.\nRegarding cloudflare follow this thread: URL","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-04-03T07:29:11+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2213661334,"issue_number":19,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/19","linked_issue_ids":[2120555193],"is_known_query_context":false},{"document_id":"gh_comment_2156202596","fragment_type":"issue_comment","sequence":2,"text":"@andrea-mattioli I confirm the issue. The link contain a generic \"my.home-assistant.io\" and ignore the properties setted in configuration.\n\n@Danifly80 for temporary fix the problem, you have to manually change in the link \"my.home-assistant.io\" that is at the end of the URL with your HA url.","author_login":"engal89","author_association":"NONE","created_at":"2024-06-08T22:01:25+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2213661334,"issue_number":19,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2569476289","fragment_type":"issue_comment","sequence":3,"text":"I have the same issue, after I confirm the authorisation it jumps directly to my URL host, so I can't finish setup","author_login":"testorp","author_association":"NONE","created_at":"2025-01-03T16:10:38+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2213661334,"issue_number":19,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2687424465","fragment_type":"issue_comment","sequence":4,"text":"Seguito tutto alla lettera in maniera estremamente precisa anche se la guida omette e da per scontato alcuni passaggi.\n\nL'applicazione sul sito legrand ha il reply_url segnato da te sulla documentazione.\nL'accesso di terze parti è attivo (anche perché non avrei potuto usare il tuo vecchio componente aggiuntivo x8000 v2).\nHo cloudflare ma ho seguito i tuoi passaggi di un commento che avevi dato ad un altro utente tra gli issue (Zero Trust). Non cambia nulla.\nHo copiato il link dopo l'auth sia lasciando invariato URL sia mettendo il mio indirizzo (come detto da un altro utente negli issue) e in entrambi i casi...non cambia nulla. Non riesco a configurarlo","author_login":"majorhector","author_association":"NONE","created_at":"2025-02-27T09:46:59+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2213661334,"issue_number":19,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2120555193","fragment_type":"issue_description","sequence":0,"text":"Data not updating with Cloudflare tunnel\n### Question\n\nHi Andrea, I have correctly configured the new component and I can correctly see the two thermostats installed. The only thing is that the data is not updated: for example the temperature detected by the component is not the same as that shown on the APP. Could it be that I'm exposing Homeassistant via a Cloudflare tunnel?\n\n### Additional information\n\n_No response_","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-06T11:28:17+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929498039","fragment_type":"issue_comment","sequence":1,"text":"Yes, I also have problems with cloudflare and the DNS proxy, I had to remove it and expose the public IP.\nI have a pfsense firewall with HA proxy with ACLs and I have thus secured my infrastructure.Even Alexa doesn't work for me with the proxy active, I haven't figured out why yet but the HA app doesn't work for me either!\nIndeed, if you know how to solve the problem with Alexa and the HA app, maybe we can find the root cause of the problem also for sending data from Legrand!","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-02-06T13:04:27+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929705284","fragment_type":"issue_comment","sequence":2,"text":"I wish I could help you but I have no way to expose Homeassistant other than with the Cloudflare tunnel because I'm behind a 5G connection with double NAT and I have no other way to publish externally. I have Alexa but not configured in Homeassistant, for now I let it work on its own. The strange thing is that the Companion APP works correctly, wouldn't it be necessary to also put the ports (MQTT?) used by the thermostats in the tunnel?","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-06T13:54:50+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929760537","fragment_type":"issue_comment","sequence":3,"text":"It doesn't use mqtt, the data arrives via http post on a ha webhook","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-02-06T14:11:04+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1939183823","fragment_type":"issue_comment","sequence":4,"text":"Hi Andrea, I did a test: within the integration, by selecting system options, I disabled and enabled polling for updates. The two thermostats took the correct values ​​at that time. This means that they can communicate correctly with the Legrand cloud via Cloudflare tunnel. I don't understand why it doesn't do it automatically...","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-12T17:17:46+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1941458728","fragment_type":"issue_comment","sequence":5,"text":"If you don't wait for the data to arrive from Legrand but you make the query it's different, it's one thing to do get on their servers and another to receive posts on your HA's webhooks","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-02-13T12:55:24+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1941746143","fragment_type":"issue_comment","sequence":6,"text":"Try:\n\n1. Go to Cloudflare’s dashboard on their website, Zero Trust > Access > Tunnels. Select your tunnel. (This is where the Tunnel ID comes from for the Cloudflare Tunnel Token above.)\n\n2. Check that everything is correct. The public hostname and service target ( URL must be right. Verify that remote access to that domain still works.\n\n3. Go to Cloudflare’s dashboard, Zero Trust > Access > Access Groups. Create a new group, named whatever you like. I used “Google Assistant IPs”.\n\n4. Under Group Configuration > Include, selector IP ranges, add the following ranges.\n\n| Geography | Region | IP V4 ranges |\n|--------------------|-------------------------------|---------------------|\n| Australia | Australia East | 20.37.194.0/24 |\n| |Australia South East | 20.42.226.0/24 |\n| Brazil | Brazil South | 191.235.226.0/24 |\n| Canada | Central Canada | 52.228.82.0/24 |\n| Asia Pacific | Southeast Asia (Singapore) | 20.195.68.0/24 |\n| India | South India | 20.41.194.0/24 |\n| | Central India | 20.204.197.192/26 |\n| United States | Central United States | 20.37.158.0/23 |\n| | West Central United States | 52.150.138.0/24 |\n| | East United States | 20.42.5.0/24 |\n| | East 2 United States | 20.41.6.0/23 |\n| | North United States | 40.80.187.0/24 |\n| | South United States | 40.119.10.0/24 |\n| | West United States | 40.82.252.0/24 |\n| | West 2 United States | 20.42.134.0/23 |\n| | West 3 United States | 20.125.155.0/24 |\n| Europe | Western Europe | 40.74.28.0/23 |\n| | North Europe | 20.166.41.0/24 |\n| United Kingdom | United Kingdom South | 51.104.26.0/24 |\n\nIt would be a good idea to also ask Legrand support a question to find out which regions they have the services distributed in, otherwise I'm afraid you'll have to open all those subnets.\nHere you will find the link to the AZURE page, I hope it can help you.","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-02-13T15:11:42+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1942026392","fragment_type":"issue_comment","sequence":7,"text":"Ciao Andrea, I traced with my firewall the domain my smarther(s) contact from inside my lan to Legrand cloud. Could be helpful in your opinion?","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-13T17:08:25+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1943291098","fragment_type":"issue_comment","sequence":8,"text":"@andrea-mattioli what I have to ask exactly to Legrand forum?","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-14T08:33:55+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1943458986","fragment_type":"issue_comment","sequence":9,"text":"Make a test by adding all the subnets, if it works then write to Legrand and ask which ones you need to implement and remove the rest!\n\nAlso you can try make a POST (use internet connection):\n\nimport requests\nimport json\n\ndef send_post_request(url, payload):\n headers = {'Content-Type': 'application/json'}\n try:\n response = requests.post(url, data=json.dumps(payload), headers=headers)\n if response.status_code == 200:\n print(\"POST request successful!\")\n print(\"Response:\")\n print(response.json())\n else:\n print(\"POST request failed with status code:\", response.status_code)\n print(\"Response:\")\n print(response.text)\n except Exception as e:\n print(\"An error occurred:\", e)\n\n# payload JSON\npayload = {\n \"key1\": \"value1\",\n \"key2\": \"value2\"\n}\n\n# URL\nurl = \" URL \n\n# POST\nsend_post_request(url, payload)\n\nYou can find the correct endpoint url via Legrand API or via my old integration URL","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-02-14T10:18:28+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1945883037","fragment_type":"issue_comment","sequence":10,"text":"Ciao Andrea, I've added all the subnets to cloudflare tunnel and now seems to work. Meanwhile I've made a post in Legrand forum asking for the correct subnet. You'll find it in forum.","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-15T11:16:40+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1956991123","fragment_type":"issue_comment","sequence":11,"text":"Hi Andrea,\nI'm replying here because I think my issue is related (sorry if I'm missing some configuration steps). My 4 thermostats' reported data are not updating too, but I'm not on a cloud flare tunnel. I have indeed a reverse proxy with swag (nginix), Could it be something related to swag then? do I have to configure some extra port? \nThanks in advance! \nIvano\n<img width=\"1119\" alt=\"Screenshot 2024-02-21 alle 16 40 20\" src=\" URL","author_login":"ivanlouis87","author_association":"NONE","created_at":"2024-02-21T15:40:36+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1957232354","fragment_type":"issue_comment","sequence":12,"text":"no, the port uses the default external address of the home assistant.\nif you don't receive data check the reverse proxy logs.\nabove in the comments there is a script to send posts to the thermostats address, try it and see the return code.\nIf you have blocks on the reverse proxy, remove them and see if it works for you.\nLegrand sends POST to a webhook address, and must be reachable from outside on the HA address.","author_login":"andrea-mattioli","author_association":"OWNER","created_at":"2024-02-21T16:37:08+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1962323259","fragment_type":"issue_comment","sequence":13,"text":"Ciao Andrea, mi sorge un dubbio: nella guida indichi di inserire come \"first reply url\" URL nell'app di Legrand. Essendo con Cloudflare devo lasciare quella od indicare il link che espongo? ( URL \nStessa cosa per il link che viene generato all'interno del custom component.\nGrazie ancora!","author_login":"DjMayone","author_association":"NONE","created_at":"2024-02-24T10:34:40+08:00","repo_name":"andrea-mattioli/bticino_x8000_component","issue_id":2120555193,"issue_number":9,"issue_url":"https://github.com/andrea-mattioli/bticino_x8000_component/issues/9","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0294","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"How to make snapshots work on self-hosted ?","query_context":"Hey there 👋🏼 \n\n@yohanboniface and I can't quite seem to figure out how to make snapshots work on our Grist instance 🤷🏼 \n\nEvery time we open the \"Document History\" tool, there is only one snapshot which is from a few seconds ago : \n\n<img width=\"244\" alt=\"Screenshot 2022-11-17 at 16 33 50\" src=\" URL \n\nThat's obviously not super useful to us, as we'd like to have screenshots made at specific points in history (say, 5min ago, 1hour ago, a day ago, a week ago).\n\nAre we missing something here ?\n\nThanks 🙏🏼","known_context_document_ids":["gh_issue_1453555586"],"reference_answer":"Its not, you need to pass the right region. We can't guess region for your deployment.","answer_document_id":"gh_comment_1152945857","silver_evidence_path":["gh_comment_1429825761","gh_issue_1268280688","gh_comment_1152945857"],"evidence_issue_ids":[1453555586,1268280688],"source_repo_name":"gristlabs/grist-core","source_issue_id":1453555586,"source_issue_number":359,"source_issue_url":"https://github.com/gristlabs/grist-core/issues/359","target_repo_name":"minio/minio-js","target_issue_id":1268280688,"target_issue_number":1038,"target_issue_url":"https://github.com/minio/minio-js/issues/1038","reference_anchor_document_id":"gh_comment_1429825761","reference_answer_author":"harshavardhana","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.125,"target_answer_overlap":0.1429},"issue_created_at":"2022-11-17T15:36:40+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_1453555586","fragment_type":"issue_description","sequence":0,"text":"How to make snapshots work on self-hosted ?\nHey there 👋🏼 \n\n@yohanboniface and I can't quite seem to figure out how to make snapshots work on our Grist instance 🤷🏼 \n\nEvery time we open the \"Document History\" tool, there is only one snapshot which is from a few seconds ago : \n\n<img width=\"244\" alt=\"Screenshot 2022-11-17 at 16 33 50\" src=\" URL \n\nThat's obviously not super useful to us, as we'd like to have screenshots made at specific points in history (say, 5min ago, 1hour ago, a day ago, a week ago).\n\nAre we missing something here ?\n\nThanks 🙏🏼","author_login":"vviers","author_association":"COLLABORATOR","created_at":"2022-11-17T15:36:40+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1319169827","fragment_type":"issue_comment","sequence":1,"text":"Hi @vviers, @yohanboniface, we don't have an implementation of snapshots that works directly on a plain file system, so snapshots don't do anything useful in grist-core. For our SaaS, we have an implementation for managing document versions in AWS S3. Grist Enterprise includes that implementation, plus support for Azure Blob Storage URL We are committed to getting a snapshot solution to grist-core by the end of the year. We don't want to leave Grist tied to any particular storage service, so we have been looking for good options. The S3 API has become a de facto standard, implemented by many services and applications, including MinIO URL so support for S3 API compatible storage is what we plan to release. Would that work for you?\n\nThe amount of code to implement this isn't much. In our non-free grist-ee repo you can see AWS S3 code here URL and Azure code here URL - as you can see, they are short files. The task is mostly making decisions about what dependencies to take on, and setting up testing. Our existing tests rely on AWS infrastructure, I'd probably want to substitute MinIO.","author_login":"paulfitz","author_association":"MEMBER","created_at":"2022-11-17T20:34:33+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1319670511","fragment_type":"issue_comment","sequence":2,"text":"Perfectly! We already have a minio running ;)\n \n\nOkay, that may be something we'll work on. Let's communicate when one of us start working on it, so we don't duplicate the effort!","author_login":"yohanboniface","author_association":"CONTRIBUTOR","created_at":"2022-11-18T08:05:55+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340057570","fragment_type":"issue_comment","sequence":3,"text":"Hi @yohanboniface, we will be starting work on this shortly.","author_login":"paulfitz","author_association":"MEMBER","created_at":"2022-12-06T21:52:05+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1362208968","fragment_type":"issue_comment","sequence":4,"text":"Update: the basic functionality has landed URL I'm working on setting up aws-free tests URL","author_login":"paulfitz","author_association":"MEMBER","created_at":"2022-12-21T23:14:37+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1362996358","fragment_type":"issue_comment","sequence":5,"text":"(drafting documentation on how to use this)\n\nHere's how to test this out locally. We'll use three containers: `minio`, `redis`, and `grist`. Redis is currently needed for snapshots, though I think this dependency could be dropped now with a bit of work - it is from the days when more parts of s3 were eventually consistent, so a separate transient but consistent store was needed for some tasks.\n\nFirst, make a network to put the containers in:\n\ndocker network create grist\n\nStart Redis:\n\ndocker run --rm --network grist --name redis redis\n\nStart MinIO:\n\ndocker run --rm --network grist --name minio \\\n -v /tmp/minio:/data \\\n -p 9000:9000 -p 9001:9001 \\\n -e MINIO_ROOT_USER=grist -e MINIO_ROOT_PASSWORD=admingrist \\\n -it minio/minio server /data -console-address \":9001\"\n\nUse the MinIO interface at ` URL to create a bucket called `grist-docs`. Be sure to turn on versioning! Alternatively you can use the MinIO or AWS client to make the bucket.\n\nStart Grist (make sure you are using an up-do-date image):\n\ndocker run --rm --network grist \\\n -e GRIST_DOCS_MINIO_ACCESS_KEY=grist \\\n -e GRIST_DOCS_MINIO_SECRET_KEY=admingrist \\\n -e GRIST_DOCS_MINIO_USE_SSL=0 \\\n -e GRIST_DOCS_MINIO_BUCKET=grist-docs \\\n -e GRIST_DOCS_MINIO_ENDPOINT=minio \\\n -e GRIST_DOCS_MINIO_PORT=9000 \\\n -e REDIS_URL=redis://redis \\\n -v /tmp/gristdata:/persist -p 8484:8484 -it gristlabs/grist\n\nSnapshots will now work, and the bucket is now the canonical store for your documents. To see that, stop Grist, delete the `docs` subdirectory in its persistent directory, and start it again - your documents should open without trouble.\n\nIf along with Redis and MinIO you also use PostgreSQL as your home DB ( URL then all important Grist state is externalized.","author_login":"paulfitz","author_association":"MEMBER","created_at":"2022-12-22T15:51:09+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1426839498","fragment_type":"issue_comment","sequence":6,"text":"Thinking out loud, and just as a side note: if this works with a \"generic\" HTTP CRUD API such as S3, Grist could run \"backendless\" on other \"generic\" HTTP CRUD APIs (\"zero\" data protocols), such as Solid or remoteStorage.\n\nWith using Minio's Secure Token Service (STS) it even appears within reach, that the Grist browser application talks to the object store directly.\n\nBoth options in return open up doors for #380, if state management within the service worker can be solved.\n\nOn another note I wonder, if this worked for you @yohanboniface, should we close here?","author_login":"almereyda","author_association":"NONE","created_at":"2023-02-11T18:01:15+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1429825761","fragment_type":"issue_comment","sequence":7,"text":"That error sounds very like URL \n\n@vviers it looks like the client library we use (minio.js) has a `region` option that could be added here URL Sorry for not including that as an option.","author_login":"paulfitz","author_association":"MEMBER","created_at":"2023-02-14T14:22:07+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[1268280688],"is_known_query_context":false},{"document_id":"gh_comment_1441461445","fragment_type":"issue_comment","sequence":8,"text":"Our ops team tried to put a dev instance with snapshot and it seems to work, however it also seems to delete all the documents on the instance. Is it a wanted behaviour ?","author_login":"LouisDelbosc","author_association":"CONTRIBUTOR","created_at":"2023-02-23T09:45:49+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1441901475","fragment_type":"issue_comment","sequence":9,"text":"@LouisDelbosc once there is external storage, it becomes the \"canonical\" store of documents, with anything on any individual Grist instances becoming a cache. Deleting documents isn't wanted behavior, but the scenario of migrating an existing site is different from initially configuring a site. I thought I had tested what happens when migrating existing sites, but perhaps I muddled something, sorry. I'll dig in what I get a chance - in the meantime, if you have the capacity to look into it, I'd appreciate it, since I'm a bit backlogged. The core logic is in:\n URL \nA workaround if you're seeing deletion could be to try this migration procedure: (1) shut Grist down, (2) copy the `*.grist` files from the old local store to the external store, placing them in the location where new Grist documents would be placed, then (3) bring Grist up with new settings. I have not tested this workaround.","author_login":"paulfitz","author_association":"MEMBER","created_at":"2023-02-23T14:36:04+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477520716","fragment_type":"issue_comment","sequence":10,"text":"I made an local environment with miniio and redis to be able to snapshot in local. The config seems to work but snapshots doesn't appear. Am i missing something ?\n\n<img width=\"851\" alt=\"Screenshot 2023-03-21 at 10 27 52\" src=\" URL \n\nAlso, in my docker-compose, I create a document without miniio config and I could see and modify it. However when I open the snapshot panel, I have the following error.\n`Error: Request to URL failed with status 500: Internal Server Error (MinIOExternalStorage.head did not get expected fields)`\n\n<img width=\"436\" alt=\"Screenshot 2023-03-21 at 10 29 55\" src=\" URL \n\nShould I watch the code you showed us in the previous comment to fix this issue ?\n\n@paulfitz @dsagal","author_login":"LouisDelbosc","author_association":"CONTRIBUTOR","created_at":"2023-03-21T09:33:55+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1478559711","fragment_type":"issue_comment","sequence":11,"text":"@vviers do things look healthy in your server logs? You should be seeing lines like:\n\n2023-03-20 15:37:40.637 - info: ext doc upload: minio://..../docs/2456fae3-3ea3-4a51-a521-d4d30876a150/Hello.grist checksum 18e95a856443d62dea407a0ecfd06576 version 4d3f4d22-a69d-4f75-b03e-5c9b9d506398\n...\n\nAnd you should be seeing files appear in your minio bucket.\n\nOh, and can you check you have versioning turned on in your minio bucket? I see this is just a subtle gray comment on URL but it is really important :)","author_login":"paulfitz","author_association":"MEMBER","created_at":"2023-03-21T20:48:22+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481392095","fragment_type":"issue_comment","sequence":12,"text":"Thanks @paulfitz I managed to make it work locally using a remote s3.\n\nThe following question may be dumb but I cannot reproduce the issue. Did you make any change on how snapshot are made/used ?\n\nI will tried an older version to see if there is some bugs.","author_login":"LouisDelbosc","author_association":"CONTRIBUTOR","created_at":"2023-03-23T15:22:33+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487118346","fragment_type":"issue_comment","sequence":13,"text":"Thanks @paulfitz ! We have some inconsistencies. I thought everything was working fine, but sometime we have unexpected errors.\n\nHere our servers logs:\n\n<img width=\"1162\" alt=\"Screenshot 2023-03-28 at 17 26 33\" src=\" URL \n<img width=\"1171\" alt=\"Screenshot 2023-03-28 at 17 27 14\" src=\" URL \n\nDid you have some of these errors ? Does it mean something to you ?","author_login":"LouisDelbosc","author_association":"CONTRIBUTOR","created_at":"2023-03-28T15:28:50+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1502493681","fragment_type":"issue_comment","sequence":14,"text":"It will be good to add to the Cloud Storage / Snapshot documentation that when using MinIO, a distributed deployment is required, as versioning is restricted to that use case.\n\n- URL \n- URL \n\nI am unsure from reading their docs if a full Multi-Node Multi-Drive setup is required, or if a Singe-Node Multi-Drive setup would suffice (to enable Erasure Coding [EC] and with it Versioning).\n\nDoes anyone here have experiences with running Minio in the above two configurations, and could leave a little remark for clarification? The Minio documentation is also not very expressive, under which circumstances versioning will be enabled: They talk about distributed mode, and then immediately introduce two different ways of doing so.\n\n- URL \n Certain features such as versioning, object locking, and bucket replication require distributed deploying MinIO with Erasure Coding. For extended development and production, deploy MinIO with Erasure Coding enabled - specifically, with a *minimum* of **4 drives per MinIO server**. See MinIO Erasure Code Quickstart Guide for more complete documentation.\n\n* URL \n* URL \n* URL \n\nIn the Minio console at URL they explicitly reference *Distributed Mode* and link to the Multi-Node Multi-Drive configuration.\n\nHaving these details available when reading through the Snapshot-Self-Host documentation from Grist will make it easier to evaluate, if this prerequisite is met by a chosen, local MinIO installation, or if a new one needs to be set up.\n\nWhich is interesting to reconsider when looking at URL where such an extended setup does not seem to be necessary.","author_login":"almereyda","author_association":"NONE","created_at":"2023-04-11T00:06:55+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1607090688","fragment_type":"issue_comment","sequence":15,"text":"Following up on Louis' last message : we discovered that bucket versioning wasn't turned on and that snapshots seem to work just fine now that we set up versioning\n\nWill run some more tests on our dev instance but looks promising overall :)","author_login":"vviers","author_association":"COLLABORATOR","created_at":"2023-06-26T09:39:18+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1633921420","fragment_type":"issue_comment","sequence":16,"text":"Hi!\n\nI could manage to make the snapshot work using a local MinIO instance and everything works perfectly!\n\nHowever while trying to connect to a S3 bucket from Scaleway, with the versioning feature enabled, we still have this issue:\n \n\nAnd the snapshots don't work anymore.\n\nDo you have any clue of what's going on by chance?\nWe continue investigating but any help would be much appreciated :pray:.","author_login":"fflorent","author_association":"COLLABORATOR","created_at":"2023-07-13T09:48:34+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2692113239","fragment_type":"issue_comment","sequence":17,"text":"Hi @paulfitz ,\n\nHow to use DigitalOcean Spaces for the S3 Object storage, given that DO Spaces does not support versioned buckets?","author_login":"arladmin","author_association":"NONE","created_at":"2025-03-01T09:59:26+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2692373254","fragment_type":"issue_comment","sequence":18,"text":"Hi @arladmin, I haven't used DO Spaces. Reading up, I see this page: URL \n\nThat suggests that perhaps versioning could be turned on? If so, that's definitely the easiest solution, and MinIO should work just fine.\n\nIf not, there's no existing back-end I know of that will help. For our SaaS we use the AWS S3 library, for historical reasons, but MinIO works just as well. For an enterprise client, we added Azure Blob Storage support. But none of that would help with DO. Adding a new back-end is actually pretty achievable, I'm kind of expecting some day for someone to sit down and make one that works on a raw file system plus some cron scripts for lifecycle management. Just need to implement the methods in this interface URL","author_login":"paulfitz","author_association":"MEMBER","created_at":"2025-03-01T19:16:33+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2692563721","fragment_type":"issue_comment","sequence":19,"text":"Hi @paulfitz , thanks for your response and that link!\n\nIt does seem that DO provides the functionality to turn on versioning via their CLI. Will try it out now.\n\nBtw, is there any particular reason why the option to use the AWS S3 client is not a part of the standard (core) offering? \nIn my experience with dozens of tools (FOSS or otherwise), the standard has always been the AWS S3 client, and hence, this is the first time that i'm actually experiencing this sort of an issue.","author_login":"arladmin","author_association":"NONE","created_at":"2025-03-02T05:19:08+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2692922012","fragment_type":"issue_comment","sequence":20,"text":"Given that we have minio.js support, adding the AWS dependency also felt a little heavy? Just in terms of the size of the packages. The minio.js client has been working fine for us against original AWS S3. But if it is giving you trouble of some kind I'd be interested in the details. Either library should handle versioning just fine, but maybe there's some other awkwardness?","author_login":"paulfitz","author_association":"MEMBER","created_at":"2025-03-02T21:41:58+08:00","repo_name":"gristlabs/grist-core","issue_id":1453555586,"issue_number":359,"issue_url":"https://github.com/gristlabs/grist-core/issues/359","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1268280688","fragment_type":"issue_description","sequence":0,"text":"Region hardcoded in `listBuckets`\nThe authorization header is malformed; the region 'us-east-1' is wrong; expecting 'nl-ams'.\n\nTrying to connect to Scaleway S3-compastible storage. When I specify a `region` property or leave it out, I get:\n \n\nSee code below.\n\nts\nimport { Client } from \"minio\";\n\nconst minioClient = new Client({\n endPoint: \"xxx.s3.nl-ams.scw.cloud\",\n port: 443,\n useSSL: true,\n accessKey: \"xxx\",\n secretKey: \"xxx\",\n});\n\n(async function run() {\n await minioClient.listBuckets();\n})();","author_login":"louwers","author_association":"NONE","created_at":"2022-06-11T13:44:26+08:00","repo_name":"minio/minio-js","issue_id":1268280688,"issue_number":1038,"issue_url":"https://github.com/minio/minio-js/issues/1038","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152942161","fragment_type":"issue_comment","sequence":1,"text":"Yeah OK not super surprising, the region is hardcoded:\n\n URL","author_login":"louwers","author_association":"NONE","created_at":"2022-06-11T14:48:06+08:00","repo_name":"minio/minio-js","issue_id":1268280688,"issue_number":1038,"issue_url":"https://github.com/minio/minio-js/issues/1038","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152945857","fragment_type":"issue_comment","sequence":2,"text":"Its not, you need to pass the right region. We can't guess region for your deployment.","author_login":"harshavardhana","author_association":"MEMBER","created_at":"2022-06-11T15:03:22+08:00","repo_name":"minio/minio-js","issue_id":1268280688,"issue_number":1038,"issue_url":"https://github.com/minio/minio-js/issues/1038","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152979174","fragment_type":"issue_comment","sequence":3,"text":"@harshavardhana As you can clearly see in the linked source code, it is hard coded.\n\nWhen I pass in the region the behavior doesn't change.","author_login":"louwers","author_association":"NONE","created_at":"2022-06-11T18:41:14+08:00","repo_name":"minio/minio-js","issue_id":1268280688,"issue_number":1038,"issue_url":"https://github.com/minio/minio-js/issues/1038","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152979259","fragment_type":"issue_comment","sequence":4,"text":"js\n this.makeRequest({method}, '', [200], 'us-east-1', true, (e, response) => {\n // ^ here","author_login":"louwers","author_association":"NONE","created_at":"2022-06-11T18:41:44+08:00","repo_name":"minio/minio-js","issue_id":1268280688,"issue_number":1038,"issue_url":"https://github.com/minio/minio-js/issues/1038","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153025206","fragment_type":"issue_comment","sequence":5,"text":"We will send a fix soon for using the configured region param. Thank you @louwers","author_login":"prakashsvmx","author_association":"MEMBER","created_at":"2022-06-12T00:08:37+08:00","repo_name":"minio/minio-js","issue_id":1268280688,"issue_number":1038,"issue_url":"https://github.com/minio/minio-js/issues/1038","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0295","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Error loading libraries for: SafariCore java.io.IOException: Invalid index: 443820488?","query_context":"**Describe the bug**\nAttempting to load all relevant dylds from the library search path leads to `Error loading libraries for: SafariCore java.io.IOException: Invalid index: 443820488`.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Start new project for 24D60's SafariCore on x86_64.\n2. Choose \"Load Libraries\" from the menu and make sure to include the a library search path for the extracted dylds in the Library Search Paths. Hit OK.\n3. After a while you'll get the Invalid index error as mentioned.\n\n**Expected behavior**\nParsing of all the libraries without error.\n\n**Screenshots**\nSee attachments.\n\n**Attachments**\n\njava\n2025-02-10 11:16:27 ERROR (LoadLibrariesOptionsDialog) Load Libraries: Error loading libraries for: SafariCore java.io.IOException: Invalid index: 443820488\n at ghidra.app.util.bin.FileByteProvider.ensureBounds(FileByteProvider.java:264)\n at ghidra.app.util.bin.FileByteProvider.readBytes(FileByteProvider.java:121)\n at ghidra.formats.gfilesystem.RefdByteProvider.readBytes(RefdByteProvider.java:95)\n at ghidra.app.util.bin.BinaryReader.readInt(BinaryReader.java:1067)\n at ghidra.app.util.bin.BinaryReader.readInt(BinaryReader.java:1056)\n at ghidra.app.util.bin.BinaryReader.peekNextInt(BinaryReader.java:376)\n at ghidra.app.util.bin.format.macho.MachHeader.parseSegments(MachHeader.java:206)\n at ghidra.app.util.opinion.MachoLoader.detectCompilerName(MachoLoader.java:82)\n at ghidra.app.util.opinion.MachoLoader.findSupportedLoadSpecs(MachoLoader.java:66)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.matchSupportedLoadSpec(AbstractLibrarySupportLoader.java:1159)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadLibrary(AbstractLibrarySupportLoader.java:816)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadLibraryFromSearchPaths(AbstractLibrarySupportLoader.java:628)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadLibraries(AbstractLibrarySupportLoader.java:533)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadProgram(AbstractLibrarySupportLoader.java:128)\n at ghidra.app.util.opinion.AbstractProgramLoader.load(AbstractProgramLoader.java:129)\n at ghidra.plugin.importer.LoadLibrariesOptionsDialog.lambda$okCallback$1(LoadLibrariesOptionsDialog.java:76)\n at ghidra.util.task.TaskLauncher$1.run(TaskLauncher.java:87)\n at ghidra.util.task.Task.monitoredRun(Task.java:134)\n at ghidra.util.task.TaskRunner.lambda$startTaskThread$0(TaskRunner.java:106)\n at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)\n at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)\n at java.base/java.lang.Thread.run(Thread.java:1570)\n\n**Environment (please complete the following information):**\n - OS: macOS 15.3 (24D60)\n - Java Version:\njava 22.0.2 2024-07-16\nJava(TM) SE Runtime Environment (build 22.0.2+9-70)\nJava HotSpot(TM) 64-Bit Server VM (build 22.0.2+9-70, mixed mode, sharing)\n - Ghidra Version: 11.3 PUBLIC\n - Ghidra Origin: official GitHub distro\n\n**Additional context**\nWill gladly provide any additional details upon request.","known_context_document_ids":["gh_issue_2842239470"],"reference_answer":"Note that in the original screen shot, the `init` selector is by default too small for Ghirda to decode as a string, so that particular one might not appear correct in the decompiler until a string is made on that data type.","answer_document_id":"gh_comment_2672338227","silver_evidence_path":["gh_comment_2672328706","gh_issue_2742507622","gh_comment_2672338227"],"evidence_issue_ids":[2842239470,2742507622],"source_repo_name":"NationalSecurityAgency/ghidra","source_issue_id":2842239470,"source_issue_number":7469,"source_issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","target_repo_name":"NationalSecurityAgency/ghidra","target_issue_id":2742507622,"target_issue_number":7289,"target_issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","reference_anchor_document_id":"gh_comment_2672328706","reference_answer_author":"ryanmkurtz","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.1429,"target_answer_overlap":0.1429},"issue_created_at":"2025-02-10T12:16:41+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_2842239470","fragment_type":"issue_description","sequence":0,"text":"Error loading libraries for: SafariCore java.io.IOException: Invalid index: 443820488\n**Describe the bug**\nAttempting to load all relevant dylds from the library search path leads to `Error loading libraries for: SafariCore java.io.IOException: Invalid index: 443820488`.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Start new project for 24D60's SafariCore on x86_64.\n2. Choose \"Load Libraries\" from the menu and make sure to include the a library search path for the extracted dylds in the Library Search Paths. Hit OK.\n3. After a while you'll get the Invalid index error as mentioned.\n\n**Expected behavior**\nParsing of all the libraries without error.\n\n**Screenshots**\nSee attachments.\n\n**Attachments**\n\njava\n2025-02-10 11:16:27 ERROR (LoadLibrariesOptionsDialog) Load Libraries: Error loading libraries for: SafariCore java.io.IOException: Invalid index: 443820488\n at ghidra.app.util.bin.FileByteProvider.ensureBounds(FileByteProvider.java:264)\n at ghidra.app.util.bin.FileByteProvider.readBytes(FileByteProvider.java:121)\n at ghidra.formats.gfilesystem.RefdByteProvider.readBytes(RefdByteProvider.java:95)\n at ghidra.app.util.bin.BinaryReader.readInt(BinaryReader.java:1067)\n at ghidra.app.util.bin.BinaryReader.readInt(BinaryReader.java:1056)\n at ghidra.app.util.bin.BinaryReader.peekNextInt(BinaryReader.java:376)\n at ghidra.app.util.bin.format.macho.MachHeader.parseSegments(MachHeader.java:206)\n at ghidra.app.util.opinion.MachoLoader.detectCompilerName(MachoLoader.java:82)\n at ghidra.app.util.opinion.MachoLoader.findSupportedLoadSpecs(MachoLoader.java:66)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.matchSupportedLoadSpec(AbstractLibrarySupportLoader.java:1159)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadLibrary(AbstractLibrarySupportLoader.java:816)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadLibraryFromSearchPaths(AbstractLibrarySupportLoader.java:628)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadLibraries(AbstractLibrarySupportLoader.java:533)\n at ghidra.app.util.opinion.AbstractLibrarySupportLoader.loadProgram(AbstractLibrarySupportLoader.java:128)\n at ghidra.app.util.opinion.AbstractProgramLoader.load(AbstractProgramLoader.java:129)\n at ghidra.plugin.importer.LoadLibrariesOptionsDialog.lambda$okCallback$1(LoadLibrariesOptionsDialog.java:76)\n at ghidra.util.task.TaskLauncher$1.run(TaskLauncher.java:87)\n at ghidra.util.task.Task.monitoredRun(Task.java:134)\n at ghidra.util.task.TaskRunner.lambda$startTaskThread$0(TaskRunner.java:106)\n at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)\n at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)\n at java.base/java.lang.Thread.run(Thread.java:1570)\n\n**Environment (please complete the following information):**\n - OS: macOS 15.3 (24D60)\n - Java Version:\njava 22.0.2 2024-07-16\nJava(TM) SE Runtime Environment (build 22.0.2+9-70)\nJava HotSpot(TM) 64-Bit Server VM (build 22.0.2+9-70, mixed mode, sharing)\n - Ghidra Version: 11.3 PUBLIC\n - Ghidra Origin: official GitHub distro\n\n**Additional context**\nWill gladly provide any additional details upon request.","author_login":"ro-achterberg","author_association":"NONE","created_at":"2025-02-10T12:16:41+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2647908485","fragment_type":"issue_comment","sequence":1,"text":"How did you import SafariCore? Was that extracted from the cache or does it reside on your system somewhere?","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-10T12:55:52+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2647916379","fragment_type":"issue_comment","sequence":2,"text":"We extracted it from the cache using blacktop's ipsw with the following \ncommand line: ipsw dyld extract -a --objc --stubs\nThe slide option wasn't working for 24D60.\n\nOn ma 10-2-2025 13:56, Ryan Kurtz wrote:","author_login":"ro-achterberg","author_association":"NONE","created_at":"2025-02-10T12:58:50+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2647951582","fragment_type":"issue_comment","sequence":3,"text":"Ok. I'll say up front that Ghidra may not play nicely with dylb's extracted from other tools. Ghidra can also extract...did you try that?","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-10T13:13:21+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2647956912","fragment_type":"issue_comment","sequence":4,"text":"Haven't tried that yet, going to now. Thanks for getting back to me so \nquickly.\n\nOn ma 10-2-2025 14:13, Ryan Kurtz wrote:","author_login":"ro-achterberg","author_association":"NONE","created_at":"2025-02-10T13:15:39+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2654496813","fragment_type":"issue_comment","sequence":5,"text":"Well, it seems to be working as expected. If you bring in `libobjc.dylib` before starting any analysis, it won't complain about the missing string at `0x7ff81f6fd197`.","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-12T18:12:18+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2654498578","fragment_type":"issue_comment","sequence":6,"text":"I am going to play with bringing in `libobjc.dylib` by default, along with some other pieces that seem essential for proper analysis.","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-12T18:13:07+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2672328706","fragment_type":"issue_comment","sequence":7,"text":"Addressed with change e2435030bcc888ef283ba66c3a3471abf7f4e8fc. See URL for more info.","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-20T18:23:42+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2842239470,"issue_number":7469,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7469","linked_issue_ids":[2742507622],"is_known_query_context":false},{"document_id":"gh_issue_2742507622","fragment_type":"issue_description","sequence":0,"text":"DAT_ is shown instead of selector when working with dyld shared cache\n**Describe the bug**\nIn my instances `DAT_ ` is shown instead of the selector that is being invoked when working with the dyld_shared_cache.\n\nScreenshot 2024-12-16 at 15 04 09\n\nUsing blacktop's `ipsw` however the selector can be read, so it is available:\n\n./ipsw dyld a2s /System/Cryptexes/OS/System/Library/dyld/dyld_shared_cache_x86_64 7ffb404adb00 \n • Address location dylib=/System/Library/Frameworks/MailKit.framework/Versions/A/MailKit section=__DATA_CONST.__objc_selrefs\n0x7ffb404adb00: sel_init\n\nWhen right clicking the address and going to References there's also no option to \"Add To Program\" as was suggested in an article when dealing with the dsc.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Go to `File › Open File System`\n2. Select the /System/Cryptexes/OS/System/Library/dyld/dyld_shared_cache_x86_64\n3. Select MailKit as library to import\n4. Choose Format `Mac OS X Mach-O` and in `Options` select `Load Libraries from Disk` to pull in all dependencies\n5. Decompile method `-[MEDecodeContext_initWithCoder:]`\n6. See `DAT_7ffb404adb00` instead of the selector being called\n\n**Expected behavior**\nWhen the selector / string information is available, that should be shown instead of `DAT_ `\n\n**Environment (please complete the following information):**\n - OS: macOS 15.2 (24C101)\n - Java Version: OpenJDK Runtime Environment Temurin-23.0.1+11 (build 23.0.1+11)\n - Ghidra Version: 11.2.1\n - Ghidra Origin: official GitHub distro\n\n**Additional context**\nApologies for not using the correct terminology.","author_login":"lukele","author_association":"NONE","created_at":"2024-12-16T14:14:34+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2600388694","fragment_type":"issue_comment","sequence":1,"text":"I'll add to this that functions appear to do the same thing. `FUN_ ` instead of the external function. This appears to be new to 15.2? I've only noticed it recently.\n\nApple seems to have dropped some of their shared cache builder code in dyld-1231.3 (which was released with 15.0): URL \n\nA later release, dyld-1235.2, seems to touch a \"NewSharedCacheBuilder\":\n URL \n\nNot sure if any of this has to do with these potential regressions, but I thought I'd mention it.","author_login":"nmggithub","author_association":"NONE","created_at":"2025-01-19T01:38:54+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614748301","fragment_type":"issue_comment","sequence":2,"text":"Looking more into this, this appears to be (in some respects) at least two different issues:\n\n1. All of the trampolines in `__objc_stubs` use pointers to selector strings that are all in one big array in virtual memory. These pointers can be resolved by loading that memory into the `Program`, but I think it might be easier to repoint them back to the strings in `__objc_methname`. They don't start until somewhat in the middle of that section (I'm not sure what the indicators are), but otherwise they selector strings and trampolines appear to be in the same order.\n2. External symbols and functions are not resolved to names, due to other optimizations.\n\nIssue 1 is the only one I have looked into deeply, although I would not be surprised if Issue 2 is similar.","author_login":"nmggithub","author_association":"NONE","created_at":"2025-01-27T02:37:06+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2629008925","fragment_type":"issue_comment","sequence":3,"text":"@ryanmkurtz I've been doing a bit of digging into this on my own and I think I found a bug that might be the root cause of this (or at least part of it).\n\n1. The `SymbolTableCommand` represents a load command in a Mach-O that points to the _file offset_ of the symbol table and the symbol strings.\n2. Given that these are file offsets, it wouldn't make sense for them to be negative.\n3. However, when playing around with the parsing code, I found that, in some cases, the `symoff` and `stroff` will be negative values.\n\nI'm honestly not sure why that doesn't make it crash, but it does seem to end up with a symbol table that has the right number of symbols (`nsyms` is never big enough to be misinterpreted), but they are all the empty string.\n\nIn Kotlin, I can re-parse the symbols like so, and get proper symbol strings:\n\nkotlin\nval (symbolsFileOffset, stringsFileOffset) =\n symbolTableCommand.let {\n Pair(\n it.symbolOffset.toUInt(),\n it.stringTableOffset.toUInt(),\n )\n }\nvar symbolTable = mutableListOf ()\nfor (i in 0 until symbolTableCommand.numberOfSymbols) {\n val nList = NList(readerForSymbolTable, machHeader.is32bit)\n nList.initString(readerForSymbolTable, symbolsFileOffset.toLong())\n symbolTable += nList\n}\n\nI don't think Java has `.toUInt()`, but I think if you change\n\njava\n symoff = loadCommandReader.readNextInt();\n nsyms = loadCommandReader.readNextInt();\n stroff = loadCommandReader.readNextInt();\n strsize = loadCommandReader.readNextInt();\n\nto\n\njava\n symoff = loadCommandReader.readNextUnsignedInt();\n nsyms = loadCommandReader.readNextInt();\n stroff = loadCommandReader.readNextUnsignedInt();\n strsize = loadCommandReader.readNextInt();\n\nit might solve things.\n\nHonestly, they could all be interpreted as unsigned integers, as I don't think any of them would ever be negative.","author_login":"nmggithub","author_association":"NONE","created_at":"2025-02-01T16:06:37+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2632164874","fragment_type":"issue_comment","sequence":4,"text":"Do you guys think it would make sense if it just brought in `libobjc.dylib` by default? I could have a load option to have it not do that but it seems like you would always want it since there is so much objc stuff everywhere.","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-03T21:53:05+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2632331044","fragment_type":"issue_comment","sequence":5,"text":"I wouldn't be against this. It's what I'm playing around with in GhidraApple already. Especially for cached dylibs and their `__objc_*list` sections, those often reference `libobjc`. And given that the Objective-C 2 Class analyzer doesn't have a \"soft fail\" path (as we discussed in #7361), not including `libobjc` would lead to Class analysis failing for a lot of cached dylibs.","author_login":"nmggithub","author_association":"NONE","created_at":"2025-02-03T22:34:53+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2672338227","fragment_type":"issue_comment","sequence":6,"text":"Note that in the original screen shot, the `init` selector is by default too small for Ghirda to decode as a string, so that particular one might not appear correct in the decompiler until a string is made on that data type.","author_login":"ryanmkurtz","author_association":"COLLABORATOR","created_at":"2025-02-20T18:26:53+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2672519581","fragment_type":"issue_comment","sequence":7,"text":"Very cool. Thank you very much! I’ll test it and report back!","author_login":"lukele","author_association":"NONE","created_at":"2025-02-20T19:46:27+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2889201145","fragment_type":"issue_comment","sequence":8,"text":"@ryanmkurtz Pinging here just so I don't have to make a whole new issue. I have been testing this out in the beta, and while it's good, I find that, since `libobjc` is included by default, its exports (which are many) show up under Exports in the Symbol Tree. I think the markup of exports should be avoided, in general, for additional dylibs mapped into a Program's address space.","author_login":"nmggithub","author_association":"CONTRIBUTOR","created_at":"2025-05-18T20:40:19+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2891403244","fragment_type":"issue_comment","sequence":9,"text":"@ryanmkurtz Just built it and it looks nice! I don't see the `libobjc` exports anymore.","author_login":"nmggithub","author_association":"CONTRIBUTOR","created_at":"2025-05-19T15:14:20+08:00","repo_name":"NationalSecurityAgency/ghidra","issue_id":2742507622,"issue_number":7289,"issue_url":"https://github.com/NationalSecurityAgency/ghidra/issues/7289","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0296","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Move historical results from `members.json` into separate file?","query_context":"### What is the expected enhancement?\n\nMove historical results from `members.json` into separate file","known_context_document_ids":["gh_issue_1370370340"],"reference_answer":"Before closing this issue, just a quick question @frankharkins how do we manage the submission actually in PR :\n- #388 \n- #390\n- #398 \n- #402 \n\nFor the #402, I can close it and regenerate it (it's my QAMP project) but for the other do we resubmit them by hand ?","answer_document_id":"gh_comment_1623974436","silver_evidence_path":["gh_comment_1613000449","gh_issue_1778942694","gh_comment_1623974436"],"evidence_issue_ids":[1370370340,1778942694],"source_repo_name":"qiskit-community/ecosystem","source_issue_id":1370370340,"source_issue_number":228,"source_issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","target_repo_name":"qiskit-community/ecosystem","target_issue_id":1778942694,"target_issue_number":424,"target_issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","reference_anchor_document_id":"gh_comment_1613000449","reference_answer_author":"mickahell","reference_answer_author_association":"COLLABORATOR","quality_score":86.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3333,"target_answer_overlap":0.0625},"issue_created_at":"2022-09-12T18:51:54+08:00","valid_comment_count":28,"fragments":[{"document_id":"gh_issue_1370370340","fragment_type":"issue_description","sequence":0,"text":"Move historical results from `members.json` into separate file\n### What is the expected enhancement?\n\nMove historical results from `members.json` into separate file","author_login":"IceKhan13","author_association":"MEMBER","created_at":"2022-09-12T18:51:54+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1245165044","fragment_type":"issue_comment","sequence":1,"text":"Seems like a good first issue to try. \nDo you mean moving the values for the key `tests_results` or `historical_test_results` if values exist under the first nesting level (`Main`, `Community`, `Extensions`, etc)?","author_login":"dhruvshettty","author_association":"NONE","created_at":"2022-09-13T09:47:22+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1248097814","fragment_type":"issue_comment","sequence":2,"text":"@dhruvshettty Hey! Thank you for interest in this issue!\n\nI mean remove `historical_test_results` field from `members.json` and move it to separate file. Probably separate file structure will be something like \n\njson\n{\n \"1\": {\n \"repo_url\": ...,\n \"historical_test_results\": [...]\n }\n}","author_login":"IceKhan13","author_association":"MEMBER","created_at":"2022-09-15T13:24:19+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253547271","fragment_type":"issue_comment","sequence":3,"text":"@IceKhan13 yes please, I'd like to take this up.\n\nThis is the format I'm thinking of:\n\n{\n \"1\": {\n \"repo_url\": \"...\",\n \"tier\": \"Community\",\n \"historical_test_results\": [...],\n }\n}\n\nI'm choosing to keep the `tier` key since that would help us identify the structure of the JSON. And the number is just a unique ID. If this works, I'll get on with it, else please let me know if there are changes required.","author_login":"dhruvshettty","author_association":"NONE","created_at":"2022-09-21T11:06:22+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253996922","fragment_type":"issue_comment","sequence":4,"text":"@dhruvshettty assigned to you! Thank you for jumping on this! You rock! 😄","author_login":"IceKhan13","author_association":"MEMBER","created_at":"2022-09-21T17:12:54+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613000449","fragment_type":"issue_comment","sequence":5,"text":"@AbdullahKazi500 & @dhruvshettty if you are still there maybe you both could sync with @frankharkins and pass on the issue #424 to be clear on the new structure","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-29T11:52:25+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[1778942694],"is_known_query_context":false},{"document_id":"gh_comment_1613200230","fragment_type":"issue_comment","sequence":6,"text":"Because, the file `members.json` is gonna disapeared to be split into separated individual folder.","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-29T13:38:26+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613216794","fragment_type":"issue_comment","sequence":7,"text":"@AbdullahKazi500 what do you have so far? Slack me on the Qiskit workspace (`@frankharkins`) if you prefer.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-29T13:48:37+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615866239","fragment_type":"issue_comment","sequence":8,"text":"Hi, sorry I could not work on this. I'm removing myself from this issue, however, @AbdullahKazi500 happy to help you if you need it","author_login":"dhruvshettty","author_association":"NONE","created_at":"2023-07-01T11:43:21+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1624096962","fragment_type":"issue_comment","sequence":9,"text":"Hi @AbdullahKazi500, @frankharkins finished the new structured. You can `pull` the evolve and go ahead :)\n \n \n \n \n \n \n \n \n \n \n\nI think you can integrate `historical_test_results` into the new unitary project `toml` file.\n\nDo not hesitate if you have any question","author_login":"mickahell","author_association":"COLLABORATOR","created_at":"2023-07-06T17:56:45+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1658591309","fragment_type":"issue_comment","sequence":10,"text":"Gonna close as this seems stale, and I don't think this is needed any more.\n\nWith the new structure, having historical test results in the same file is no longer a problem as they can be easily ignored. Separating them out would most likely make the code more complicated. I'm open to other opinions though.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-07-31T15:22:26+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1370370340,"issue_number":228,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/228","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1778942694","fragment_type":"issue_description","sequence":0,"text":"Refactor: Split members.json into separate files\n### Problem\n\nThe ecosystem database is in `members.json`, and is difficult to for humans to edit, and causes merge conflicts.\n\n### Proposed solution\n\n@IceKhan13 and @1ucian0 have suggested splitting this out into different files (one file per repo).\n\nSince `manager.py` seems to access repos exclusively by tier or URL, I suggest the following structure:\n\nsh\necosystem/resources/members\n├── Tier.yaml # List of URLs of repos\n└── organisation\n └── repo-name.yaml\n\nFor example:\n\nsh\necosystem/resources/members\n├── Community.yaml\n├── Extensions.yaml\n├── Main.yaml\n├── Qiskit\n│   ├── qiskit-finance.yaml\n│   └── qiskit-nature.yaml\n└── unitaryfund\n └── mitiq.yaml\n\nThis should immediately remove merge conflict problems, but should also make it easier to avoid the `set-output` feature (see #406) as each step in the action can modify a file.\n\n### Future work\n\n- ~~Will still include a `members.json` as MVP, but eventually should have that compiled and released using an action.~~ Actually I think releasing `members.json` should be in MVP.\n- Currently unsure how this fits with #228.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-28T13:24:19+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1612991533","fragment_type":"issue_comment","sequence":1,"text":"Don't you thing still having centralized files for url (`Tier.yaml`) will still favorized conflicts and so just moving the problem from a file to another ?\n\nWhy not having a folder per Tier and then inside having one yaml per project, something like :\n\nbash\necosystem/resources/members\n├── community\n│   ├── my_super_project.yaml\n│   ├── my_awesome_project.yaml\n├── extensions\n│   ├── my_super_extt.yaml\n│   ├── my_awesome_ext.yaml\n├── main\n│   ├── qiskit-finance.yaml\n│   └── qiskit-nature.yaml\n└── index.yaml\n\nThe `index.yaml` would contains the list of the tier folders (community, extensions, main, ...). As the tier are static, we would not have any conflict this way.\n\n- Also what the difference between `qiskit` and `main`, from my understanding `qiskit` is purely `main` ?\n- I saw `unitaryfund` folder, do we need a folder per organisation or can we have a folder `partners` or something like ? If we create a folder per organization, we need to find a way to reference new folder without re-creating conflict.\n\n---\n- About #228, i think we should close it and keep the work on this new one.\n- For the `set-output`, the problem is for the function in actions bash script as well. I think we need to review it more generally to have a better management of the vars.","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-29T11:47:52+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613155721","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your reply!\n\nI'm thinking ahead a bit, but since most uses of the DAO are accessing by URL, my idea was to order the files by URL (the part after `github.com/`). Then file access becomes trivial and we can rid of the DAO in the future. The only other access type is by tier, hence the `Tier.yaml` files. These merge conflicts would just be one line, but it's still not zero-touch, which I agree is a drawback.\n\nIn terms of how things currently are, your suggestion makes more sense as that's the way `members.json` is structured. Can I suggest something like this?\n\n└── tier\n └── organisation\n └── repo.yaml\n\nFor example:\n\necosystem/resources/members\n├── community\n│   └── unitaryfund\n│   └── mitiq.yaml\n├── extensions\n│   └── qiskit-community\n│   └── prototype-qrao.yaml\n└── main\n ├── Qiskit\n │   └── qiskit_ibm_runtime.yaml\n └── openqasm\n └── openqasm.yaml\n\nThat way there are no problems if two repos have the same name.\n\n***\n \n\nI'm not 100% sure, but I _think_ tier is just a level of endorsement. I can see that at least the `openqasm/openqasm` repo is considered \"main\", so main ≠ qiskit.\n \n\nI think it would be good if filepath was unique to URL (e.g. `github.com/unitaryfund/mitiq`). We can just do an `os.walk` to find files; no index needed.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-29T13:08:23+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613162532","fragment_type":"issue_comment","sequence":3,"text":"@AbdullahKazi500 I won't assign just yet as it's not clear what the best solution is.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-29T13:13:11+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613198196","fragment_type":"issue_comment","sequence":4,"text":"@frankharkins indeed something like should work fine :)\n\nJust in the community as most of the project doesn't have organization, how do you see them ? Inside a subfolder `toto` or directly inside the `community` mixed with the organizations folders ?","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-29T13:37:07+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613212693","fragment_type":"issue_comment","sequence":5,"text":"@mickahell After thinking on it a bit, I think the path of least resistance is to go with your original proposal. I think by trying to add more layers I was just making it more complicated.\n\nLet's go with your original idea.\n\necosystem/resources/members\n├── community\n│   ├── my_super_project.yaml\n│   ├── my_awesome_project.yaml\n├── extensions\n│   ├── my_super_extt.yaml\n│   ├── my_awesome_ext.yaml\n├── main\n│   ├── qiskit-finance.yaml\n│   └── qiskit-nature.yaml\n└── index.yaml","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-29T13:46:08+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[1778942694],"is_known_query_context":false},{"document_id":"gh_comment_1613258496","fragment_type":"issue_comment","sequence":6,"text":"Yeah, I agree with the original idea. I do not recommend including the GitHub organization. It seems unnecessary. We've never had duplicate project names in the ecosystem and can control for that since we decide who can join or not.\n\n@frankharkins are you still suggesting that we convert all these YAML files into one generated JSON file? So that it stays simple for qiskit.org to consume, and they can deal with JSON rather than YAML. That idea sounded good to me.","author_login":"Eric-Arellano","author_association":"NONE","created_at":"2023-06-29T14:14:13+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613310937","fragment_type":"issue_comment","sequence":7,"text":"@Eric-Arellano thanks! Yep I imagined either nightly or on push to main, an action would compile a JSON in the same form as we currently have, and add it as a release asset. Then qiskit.org can point to one link. I.e.\n\ndiff\n- URL \n+ URL","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-29T14:44:34+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613434295","fragment_type":"issue_comment","sequence":8,"text":"We need to find a simple way to stock this file, maybe more using artifact or something like","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-29T15:41:53+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1613469445","fragment_type":"issue_comment","sequence":9,"text":"Probably even simpler is to have the file generated by the user, using a script, and checked in to version control. Then, qiskit.org points to that static URL.\n\nYes, there will be merge conflicts for the generated file. But the answer is to simply regenerate the generated file -- you should never try to manually fix the merge conflict.\n\nThis is how we generate our quite complex GitHub action YAML files for Pantsbuild. It's worked quite well for us! URL It's nice being able to see in the PR how the final rendered asset will look.","author_login":"Eric-Arellano","author_association":"NONE","created_at":"2023-06-29T16:07:17+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1614246723","fragment_type":"issue_comment","sequence":10,"text":"Hmm ok, so we need a manual action to generate it. It's too much action for someone to git pull, git checkout and then git push and create a PR to do.\n\nBut It can also became the same problem as we have today and we will have so many branchs open (similar to the `batch_check_` branchs)","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-30T07:28:17+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1614454847","fragment_type":"issue_comment","sequence":11,"text":"The action can probably push directly to the `submission-*` branch, maybe triggering on PR approval.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-06-30T10:24:07+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1614571837","fragment_type":"issue_comment","sequence":12,"text":"I'm not following why we need a GitHub Action? When you change the YAML files, you are expected to also run a script to update the final JSON file. CI will check if the JSON file is out-of-date and error if so with instructions of how to run the script.\n\nYeah, that's a little manual. But keep it simple for now.","author_login":"Eric-Arellano","author_association":"NONE","created_at":"2023-06-30T12:18:01+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1614736159","fragment_type":"issue_comment","sequence":13,"text":"If we put the generated general file who ref every project we will have conflict as well because every submission gonna edit it with their url :/\n \n\nUser never run any script, they only submitted issue and the Action does the who trick, then someone only need to validate the PR to add the project and so never no-one need to clone and commit anything so can't run any script. That's why we need an action to generated this file\n\nDo you see what I mean ? I'm not sure to be totally clear ^^'","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-06-30T14:27:50+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615835863","fragment_type":"issue_comment","sequence":14,"text":"Or I'm wondering, can github Pages generated raw data html page by merging json ?\nThis way we would not have to store any general json file. And so we would not have any risk of conflict anymore. And no need any manual process to do.","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-07-01T10:25:07+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1615844104","fragment_type":"issue_comment","sequence":15,"text":"If my point just above is not possible. The solution you refer @frankharkins looks good to me 🙂\nDoing that from the main branch in order to stock the general file in the latest tag assets, would allow to not have conflict and to always be up to date with the actual main branch. Only require at most to click on a single button (no script, no git cmd, ...)\nWe could even schedule the action to be launch every day or every week in order to be fully automatic 🤖","author_login":"mickahell","author_association":"CONTRIBUTOR","created_at":"2023-07-01T10:45:23+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1618211233","fragment_type":"issue_comment","sequence":16,"text":"After trying to implement this, I've realised that we shouldn't have the \"tier\" information in two places. This is already causing problems: For example, `qiskit-ibm-provider` is \"Main\" on qiskit.org/ecosystem, but has the \"Extension\" badge.\n\nIn PR #426, I've gone with naming all TOML files the repo name, and having them all the same level.","author_login":"frankharkins","author_association":"COLLABORATOR","created_at":"2023-07-03T12:56:49+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1623974436","fragment_type":"issue_comment","sequence":17,"text":"Before closing this issue, just a quick question @frankharkins how do we manage the submission actually in PR :\n- #388 \n- #390\n- #398 \n- #402 \n\nFor the #402, I can close it and regenerate it (it's my QAMP project) but for the other do we resubmit them by hand ?","author_login":"mickahell","author_association":"COLLABORATOR","created_at":"2023-07-06T16:30:47+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1624088836","fragment_type":"issue_comment","sequence":18,"text":"I re-created each submission but I couldn't delete the old branches\nMaybe we can also clean the batch branches in order to restarted from this new way to go. What do you think ?\n\nAnyway we can close this issue :)","author_login":"mickahell","author_association":"COLLABORATOR","created_at":"2023-07-06T17:49:43+08:00","repo_name":"qiskit-community/ecosystem","issue_id":1778942694,"issue_number":424,"issue_url":"https://github.com/qiskit-community/ecosystem/issues/424","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0297","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Open discussion: rename the default branch ?","query_context":"In a way a \"bit late to the party\", but should the default branch be renamed away from `master` ?\n\nAnd if so, what would be the preferred new name ?\n\nSome options:\n* A lot of repos have gone with `main`. For a \"one branch\" repo, that would be an obvious choice.\n* As an alternative, but that would also involve a different branching strategy, it could be considered to have a `stable` branch as a release branch and have a `develop` branch as the default PR branch. For a new release `develop` would then be merged into `stable`.\n\nOpinions ?","known_context_document_ids":["gh_issue_1130872045"],"reference_answer":"Well relying on named branches is fairly dangerous, as you can have major changes happening at any time. That's why we introduced the concept of branch aliases, so dev-main can be aliased to 1.x-dev in the dealerdirect/phpcodesniffer-composer-installer case for example, then you can require it as `1.x-dev` or even better `^1.1@dev` for example right now if you need unreleased new features (1.0.0 being latest stable), so that tells composer I need the 1.1 release of that package, but also I'll take a dev version if needed. `1.x-dev` (seen as `1.9999999.9999999` internally) matches `^1.1` so it'll install dev-main right now, but once 1.1.0 is tagged it would go back to stable tags if you have `prefer-stable:true`, or if a package using yours as dependency does not allow dev packages for example.\n\nRequiring dev-main directly breaks all of this, so it is not a good idea.\n\nIf consumers require packages correctly, and the publisher had an alias for dev-master previously, then renaming should be pain-free as dev-main would get the same numeric alias as dev-master had, and everything keeps working.\n\nI realize this may not help you solve anything right now because once it's done it's too late, but hopefully this clarifies things and you and others can learn from this.","answer_document_id":"gh_comment_1420761666","silver_evidence_path":["gh_comment_1419516552","gh_issue_1573029347","gh_comment_1420761666"],"evidence_issue_ids":[1130872045,1573029347],"source_repo_name":"PHPCSStandards/composer-installer","source_issue_id":1130872045,"source_issue_number":160,"source_issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","target_repo_name":"composer/composer","target_issue_id":1573029347,"target_issue_number":11301,"target_issue_url":"https://github.com/composer/composer/issues/11301","reference_anchor_document_id":"gh_comment_1419516552","reference_answer_author":"Seldaek","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1053,"anchor_target_overlap":0.2632,"target_answer_overlap":0.2247},"issue_created_at":"2022-02-10T20:19:36+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1130872045","fragment_type":"issue_description","sequence":0,"text":"Open discussion: rename the default branch ?\nIn a way a \"bit late to the party\", but should the default branch be renamed away from `master` ?\n\nAnd if so, what would be the preferred new name ?\n\nSome options:\n* A lot of repos have gone with `main`. For a \"one branch\" repo, that would be an obvious choice.\n* As an alternative, but that would also involve a different branching strategy, it could be considered to have a `stable` branch as a release branch and have a `develop` branch as the default PR branch. For a new release `develop` would then be merged into `stable`.\n\nOpinions ?","author_login":"jrfnl","author_association":"CONTRIBUTOR","created_at":"2022-02-10T20:19:36+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1035541458","fragment_type":"issue_comment","sequence":1,"text":"I'm in favor of moving away from `master`.\n\nI'd say, for now, lets just move to `main` ASAP (since we're making other soft-breaking changes to our dev environment anyway).\n\nWe can always move to something more elaborate when needed.\n\nMy 2️⃣🪙","author_login":"Potherca","author_association":"MEMBER","created_at":"2022-02-10T21:32:46+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1059757124","fragment_type":"issue_comment","sequence":2,"text":"Places that need editing for this rename:\n\n URL \n URL \n URL \n URL \n URL","author_login":"Potherca","author_association":"MEMBER","created_at":"2022-03-05T12:42:55+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1059757649","fragment_type":"issue_comment","sequence":3,"text":"@jrfnl Do we want to make this change as well for the v1 release?","author_login":"Potherca","author_association":"MEMBER","created_at":"2022-03-05T12:46:36+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1059759278","fragment_type":"issue_comment","sequence":4,"text":"If we make this change, then, yes, the 1.0 release would be a good time to do so.\n\nI suggest doing it *_just_* before the 1.0 release.\nThat way, if there are people who use `dev-master`, their workflow won't be broken without a notification (i.e. a mention in the release notes for the 1.0 release).","author_login":"jrfnl","author_association":"CONTRIBUTOR","created_at":"2022-03-05T12:56:17+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1322724549","fragment_type":"issue_comment","sequence":5,"text":"Another vote +1 for `main` branch just before the 1.0 release.","author_login":"paulshryock","author_association":"NONE","created_at":"2022-11-21T22:18:37+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1419516552","fragment_type":"issue_comment","sequence":6,"text":"Eh... consider me one of those people whose workflow was broken without notification. I thought you might be able to prevent breakage by adding a branch alias, but it seems like that's not possible: URL","author_login":"danepowell","author_association":"NONE","created_at":"2023-02-06T18:01:40+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[1573029347],"is_known_query_context":false},{"document_id":"gh_comment_1419855625","fragment_type":"issue_comment","sequence":7,"text":"@danepowell Out of curiosity: why were you using the `master` branch instead of a tagged release ?","author_login":"jrfnl","author_association":"CONTRIBUTOR","created_at":"2023-02-06T22:18:08+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1419980466","fragment_type":"issue_comment","sequence":8,"text":"@danepowell Interesting. That bug was never reported by anyone, but clearly people (you) did run into it. Thanks for letting me know.\n\nThe good news is, of course, that the bug fix is included in the 1.0.0 release, so you should be able to switch back to versioned updates now.","author_login":"jrfnl","author_association":"CONTRIBUTOR","created_at":"2023-02-07T00:20:10+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420471950","fragment_type":"issue_comment","sequence":9,"text":"Hey 👋🏼\n\nA project I work on has also just been caught out by this change\n\nOne of the packages we use pushed a fix yesterday changing from `dev-master` to `dev-main` but they've not yet been able to tag and publish a new release yet...\n- URL \n\nWhilst we work to resolve these issues on our project, we'll create upstream updates for the packages we use and hoping they're maintained and can push new releases soon as this will be tricky for packages that are not so well maintained\n\nA quick GitHub search shows 14 of the first 50 search results (3481 total results) use `dev-master`\n\nUnsure of a workable solution, though a solution from Composer would be ideal, I've subscribed to URL and will be interested in replies there...","author_login":"ntwb","author_association":"CONTRIBUTOR","created_at":"2023-02-07T09:38:53+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[1573029347],"is_known_query_context":false},{"document_id":"gh_comment_1424208509","fragment_type":"issue_comment","sequence":10,"text":"@jrfnl Should we create a branch `master` from `main` for now until things are further resolved?","author_login":"Potherca","author_association":"MEMBER","created_at":"2023-02-09T13:41:02+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1424223046","fragment_type":"issue_comment","sequence":11,"text":"@Potherca I don't think so. Yes, the change is inconvenient for people, however:\n* People shouldn't be using `dev-master` (or `dev-main`) anyway.\n* Now the 1.0 release has been tagged, I expect we can go back to rapid releases for bug fixes (if any), which removes the need for anyone using `dev-master`/`dev-main`.\n* Now the 1.0 release has been tagged, people won't need to update the version constraints on every 0.x minor release anymore either (as those are treated as majors).\n\nIt's also a one-time only change (at least that's the intention) and we executed it in the most considerate way possible:\n* We has a long running open issue about the rename (this one).\n* We did the rename _just_ before the release.\n* The rename was mentioned in the changelog of the release.\n\nI'd recommend for people who choose to use `dev-` branches of repos to watch the repo or, at the very least, watch release notifications of those repos, but that's not our responsibility.","author_login":"jrfnl","author_association":"CONTRIBUTOR","created_at":"2023-02-09T13:52:28+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1424223352","fragment_type":"issue_comment","sequence":12,"text":"The official suggestion from composer in URL is that you should create a 1.x branch alias for main and projects should use that instead of dev-master or dev-main. That means not keeping a duplicate branch.","author_login":"danepowell","author_association":"NONE","created_at":"2023-02-09T13:52:43+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[1573029347],"is_known_query_context":false},{"document_id":"gh_comment_1427656676","fragment_type":"issue_comment","sequence":13,"text":"Oh, this could be why I've not encounted this previously.\n\nGitHub redirects renamed branches, but only if they were renamed\n\n URL","author_login":"ntwb","author_association":"CONTRIBUTOR","created_at":"2023-02-13T10:02:39+08:00","repo_name":"PHPCSStandards/composer-installer","issue_id":1130872045,"issue_number":160,"issue_url":"https://github.com/PHPCSStandards/composer-installer/issues/160","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1573029347","fragment_type":"issue_description","sequence":0,"text":"Cannot make branch alias for dev-master (renaming master to main)\nAs you've probably noticed, many projects are renaming `master` to `main`. This has caused a lot of problem for consumers of those libraries using the `dev-master` version.\n\nSpecifically, my project uses `dealerdirect/phpcodesniffer-composer-installer:dev-master`. That package renamed `master` to `main`, causing my builds to fail. I thought \"no problem, I'll just submit a PR for phpcodesniffer-composer-installer to add a branch alias for `dev-master` to fix everyone's builds\".... but it turns out that's not possible, because the branch-alias can only be a numbered version ending in `-dev`.\n\nSo I'm wondering how projects can rename branches without causing massive disruption to consumers.\n\nMy `composer.json`:\n\njson\n{\n \"name\": \"dealerdirect/phpcodesniffer-composer-installer\",\n \"description\": \"PHP_CodeSniffer Standards Composer Installer Plugin\",\n \"type\": \"composer-plugin\",\n \"keywords\": [\n \"composer\", \"installer\", \"plugin\",\n \"phpcs\", \"phpcbf\", \"codesniffer\", \"phpcodesniffer\", \"php_codesniffer\",\n \"standard\", \"standards\", \"style guide\", \"stylecheck\",\n \"qa\", \"quality\", \"code quality\", \"tests\"\n ],\n \"homepage\": \" URL \n \"license\": \"MIT\",\n \"authors\": [\n {\n \"name\": \"Franck Nijhof\",\n \"email\": \"franck.nijhof@dealerdirect.com\",\n \"homepage\": \" URL \n \"role\": \"Developer / IT Manager\"\n },\n {\n \"name\" : \"Contributors\",\n \"homepage\" : \" URL \n }\n ],\n \"support\": {\n \"issues\": \" URL \n \"source\": \" URL \n },\n \"require\": {\n \"php\": \">=5.4\",\n \"composer-plugin-api\": \"^1.0 || ^2.0\",\n \"squizlabs/php_codesniffer\": \"^2.0 || ^3.1.0 || ^4.0\"\n },\n \"require-dev\": {\n \"ext-json\": \"*\",\n \"ext-zip\": \"*\",\n \"composer/composer\": \"*\",\n \"phpcompatibility/php-compatibility\": \"^9.0\",\n \"php-parallel-lint/php-parallel-lint\": \"^1.3.1\",\n \"yoast/phpunit-polyfills\": \"^1.0\"\n },\n \"minimum-stability\": \"dev\",\n \"prefer-stable\": true,\n \"autoload\": {\n \"psr-4\": {\n \"PHPCSStandards\\\\Composer\\\\Plugin\\\\Installers\\\\PHPCodeSniffer\\\\\": \"src/\"\n }\n },\n \"autoload-dev\": {\n \"psr-4\": {\n \"PHPCSStandards\\\\Composer\\\\Plugin\\\\Installers\\\\PHPCodeSniffer\\\\Tests\\\\\": \"tests/\"\n }\n },\n \"extra\": {\n \"class\": \"PHPCSStandards\\\\Composer\\\\Plugin\\\\Installers\\\\PHPCodeSniffer\\\\Plugin\",\n \"branch-alias\": {\n \"dev-main\": \"dev-master\"\n }\n },\n \"scripts\": {\n \"install-codestandards\": [\n \"PHPCSStandards\\\\Composer\\\\Plugin\\\\Installers\\\\PHPCodeSniffer\\\\Plugin::run\"\n ],\n \"lint\": [\n \"@php ./vendor/php-parallel-lint/php-parallel-lint/parallel-lint . -e php --exclude vendor --exclude .git\"\n ],\n \"test\": [\n \"@php ./vendor/phpunit/phpunit/phpunit --no-coverage\"\n ],\n \"coverage\": [\n \"@php ./vendor/phpunit/phpunit/phpunit\"\n ]\n }\n}\n\nOutput of `composer diagnose`:\n\nChecking composer.json: WARNING\nextra.branch-alias.dev-main : the target branch (dev-master) must end in -dev\nChecking platform settings: OK\nChecking git settings: OK git version 2.39.1\nChecking http connectivity to packagist: OK\nChecking https connectivity to packagist: OK\nChecking github.com oauth access: OK\nChecking disk free space: OK\nChecking pubkeys:\nTags Public Key Fingerprint: 57815BA2 7E54DC31 7ECC7CC5 573090D0 87719BA6 8F3BB723 4E5D42D0 84A14642\nDev Public Key Fingerprint: 4AC45767 E5EC2265 2F0C1167 CBBB8A2B 0C708369 153E328C AD90147D AFE50952\nOK\nChecking composer version: You are not running the latest stable version, run `composer self-update` to update (2.4.1 => 2.5.2)\nComposer version: 2.4.1\nPHP version: 8.1.14\nPHP binary path: /usr/local/Cellar/php@8.1/8.1.14_1/bin/php\nOpenSSL version: OpenSSL 1.1.1s 1 Nov 2022\ncURL version: 7.87.0 libz 1.2.11 ssl (SecureTransport) OpenSSL/1.1.1s\nzip: extension present, unzip present, 7-Zip not available\n\nWhen I run this command: \n\ncomposer validate\n\nI get the following output: \n\n- extra.branch-alias.dev-main : the target branch (dev-master) must end in -dev\n\nAnd I expected this to happen:\n\ndev-master to be a supported alias","author_login":"danepowell","author_association":"CONTRIBUTOR","created_at":"2023-02-06T18:00:32+08:00","repo_name":"composer/composer","issue_id":1573029347,"issue_number":11301,"issue_url":"https://github.com/composer/composer/issues/11301","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420761666","fragment_type":"issue_comment","sequence":1,"text":"Well relying on named branches is fairly dangerous, as you can have major changes happening at any time. That's why we introduced the concept of branch aliases, so dev-main can be aliased to 1.x-dev in the dealerdirect/phpcodesniffer-composer-installer case for example, then you can require it as `1.x-dev` or even better `^1.1@dev` for example right now if you need unreleased new features (1.0.0 being latest stable), so that tells composer I need the 1.1 release of that package, but also I'll take a dev version if needed. `1.x-dev` (seen as `1.9999999.9999999` internally) matches `^1.1` so it'll install dev-main right now, but once 1.1.0 is tagged it would go back to stable tags if you have `prefer-stable:true`, or if a package using yours as dependency does not allow dev packages for example.\n\nRequiring dev-main directly breaks all of this, so it is not a good idea.\n\nIf consumers require packages correctly, and the publisher had an alias for dev-master previously, then renaming should be pain-free as dev-main would get the same numeric alias as dev-master had, and everything keeps working.\n\nI realize this may not help you solve anything right now because once it's done it's too late, but hopefully this clarifies things and you and others can learn from this.","author_login":"Seldaek","author_association":"MEMBER","created_at":"2023-02-07T13:17:42+08:00","repo_name":"composer/composer","issue_id":1573029347,"issue_number":11301,"issue_url":"https://github.com/composer/composer/issues/11301","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422196492","fragment_type":"issue_comment","sequence":2,"text":"The point of aliasing is to become compatible with numeric constraints. You don't really need an alias for named constraints because named constraints only ever match one exact name.\n\nI can definitely see how it would lead to confusion though if you take it as a plain aliasing feature to alias anything. But I'd rather not add this at this stage. Improving docs definitely would be good I agree.","author_login":"Seldaek","author_association":"MEMBER","created_at":"2023-02-08T08:10:58+08:00","repo_name":"composer/composer","issue_id":1573029347,"issue_number":11301,"issue_url":"https://github.com/composer/composer/issues/11301","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0298","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Mechanism for hackathon discoverability?","query_context":"In the context of the `hackathon-in-a-box` idea, a core requirement is to have discoverability of at least two main things related to a hackathon:\n * **Event details**\n * **Hackathon projects**\n\nDiscoverability implies machine-readable formats and standardized access patterns. Dribdat already tracks projects and a significant part of the event details, so this information needs to be exposed, but in a standard way to allow others to implement it without the need to run dribdat. The two parts (**Event details** and **Hackathon projects**) have potentially different implementations, and conceptual differences, so I will describe them separately.\n\n## Event details\nConceptually, this would be a mechanism similar to `schema.org`, `robots.txt`, or micro-format specification, to describe the hackathon's metadata in a machine-readable way and with a focus on machine discoverability as well.\n\nSchema.org has a format for generic events, and some sub-classing for specific event types, but none of them fits exactly a hackathon: URL \n\nOn the other hand, the simplicity of a root-level file descriptor (i.e. `robots.txt`, `humans.txt`, etc) is extremely appealing.\n\nSo the proposal would be to define a root-level `hackathon.json` file containing the following (tentative) metadata about the hackathon:\n- event name\n- event date(s)\n- event location(s)\n- topics\n- sibling events: list of links to other domains containing `hackathon.json` descriptors to enable event chaining)\n- projects API: link to a json API to access projects presented at the hackathon (the API would be integral part of dribdat, but at the same time, should be a well-defined standard that other platforms can implement. See next section)\n\nThe sibling event link list creates a crawlable graph that connects events to each other, fostering discoverability in general, and also establishing a relations between events.\n\nThis root-level file descriptor should be placed at the event's main website's root.\n\n## Hackathon projects\nA second level of detail in the meta-description of an event is its actual content, i.e. the projects presented during the event. For this, Dribdat already hosts all the information required, and the only additional need to be to expose it over a well-defined JSON end-point and format/spec.\n\nAs mentioned in the previous section, this end-point would be linked from the root-level file descriptor through the `projects API` property.\n\n---\n\nIn combination these two metadata end-points would allow an event/hackathon to self-describe itself in a fully decentralized manner while allowing the creation of a graph of events to keep things tied together (for a multitude or reasons: forked events, friend events, topical events, etc).\n\nOn top of it, additional tools and services (also decentralized) could be created by crawling and visualizing the event graph in various ways. For instance, this community event calendar could be generated out of this data.","known_context_document_ids":["gh_issue_302243287"],"reference_answer":"The concept of _ActivityPub Data_ explained by @sgrj in Understanding ActivityPub intrigues me.","answer_document_id":"gh_comment_2512507063","silver_evidence_path":["gh_comment_1333381382","gh_issue_1457748738","gh_comment_2512507063"],"evidence_issue_ids":[302243287,1457748738],"source_repo_name":"dribdat/dribdat","source_issue_id":302243287,"source_issue_number":112,"source_issue_url":"https://github.com/dribdat/dribdat/issues/112","target_repo_name":"dribdat/dribdat","target_issue_id":1457748738,"target_issue_number":325,"target_issue_url":"https://github.com/dribdat/dribdat/issues/325","reference_anchor_document_id":"gh_comment_1333381382","reference_answer_author":"loleg","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1818,"anchor_target_overlap":0.1364,"target_answer_overlap":0.125},"issue_created_at":"2018-03-05T10:21:26+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_302243287","fragment_type":"issue_description","sequence":0,"text":"Mechanism for hackathon discoverability\nIn the context of the `hackathon-in-a-box` idea, a core requirement is to have discoverability of at least two main things related to a hackathon:\n * **Event details**\n * **Hackathon projects**\n\nDiscoverability implies machine-readable formats and standardized access patterns. Dribdat already tracks projects and a significant part of the event details, so this information needs to be exposed, but in a standard way to allow others to implement it without the need to run dribdat. The two parts (**Event details** and **Hackathon projects**) have potentially different implementations, and conceptual differences, so I will describe them separately.\n\n## Event details\nConceptually, this would be a mechanism similar to `schema.org`, `robots.txt`, or micro-format specification, to describe the hackathon's metadata in a machine-readable way and with a focus on machine discoverability as well.\n\nSchema.org has a format for generic events, and some sub-classing for specific event types, but none of them fits exactly a hackathon: URL \n\nOn the other hand, the simplicity of a root-level file descriptor (i.e. `robots.txt`, `humans.txt`, etc) is extremely appealing.\n\nSo the proposal would be to define a root-level `hackathon.json` file containing the following (tentative) metadata about the hackathon:\n- event name\n- event date(s)\n- event location(s)\n- topics\n- sibling events: list of links to other domains containing `hackathon.json` descriptors to enable event chaining)\n- projects API: link to a json API to access projects presented at the hackathon (the API would be integral part of dribdat, but at the same time, should be a well-defined standard that other platforms can implement. See next section)\n\nThe sibling event link list creates a crawlable graph that connects events to each other, fostering discoverability in general, and also establishing a relations between events.\n\nThis root-level file descriptor should be placed at the event's main website's root.\n\n## Hackathon projects\nA second level of detail in the meta-description of an event is its actual content, i.e. the projects presented during the event. For this, Dribdat already hosts all the information required, and the only additional need to be to expose it over a well-defined JSON end-point and format/spec.\n\nAs mentioned in the previous section, this end-point would be linked from the root-level file descriptor through the `projects API` property.\n\n---\n\nIn combination these two metadata end-points would allow an event/hackathon to self-describe itself in a fully decentralized manner while allowing the creation of a graph of events to keep things tied together (for a multitude or reasons: forked events, friend events, topical events, etc).\n\nOn top of it, additional tools and services (also decentralized) could be created by crawling and visualizing the event graph in various ways. For instance, this community event calendar could be generated out of this data.","author_login":"gonzalocasas","author_association":"COLLABORATOR","created_at":"2018-03-05T10:21:26+08:00","repo_name":"dribdat/dribdat","issue_id":302243287,"issue_number":112,"issue_url":"https://github.com/dribdat/dribdat/issues/112","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1333381382","fragment_type":"issue_comment","sequence":1,"text":"Recent discussions and experiments around URL make me think: wouldn't it be cool if dribdat instances federated each other automatically, rather than the manual import and export of Data Packages that I have to do now?","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2022-12-01T08:17:29+08:00","repo_name":"dribdat/dribdat","issue_id":302243287,"issue_number":112,"issue_url":"https://github.com/dribdat/dribdat/issues/112","linked_issue_ids":[1457748738],"is_known_query_context":false},{"document_id":"gh_comment_1795512721","fragment_type":"issue_comment","sequence":2,"text":"I've been thinking recently that instead of a full-blown installation of Dribdat, a hackathon organizer should be able to quickly generate a `hackathon.json` or META-tags for the Schema.org spec using a simple tool, like a one-page app with a form to fill out, a CSV to upload or paste in - and then they can do what they want with the generated file. In this project, we could also then use the backboard app to offer quick visualization or static-site deployment of the hackathon for archiving purposes.","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2023-11-06T17:06:16+08:00","repo_name":"dribdat/dribdat","issue_id":302243287,"issue_number":112,"issue_url":"https://github.com/dribdat/dribdat/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1936666045","fragment_type":"issue_comment","sequence":3,"text":"I'm going to say that we have solved the original proposal - all the data is being served by our API + `hackathon.json` + OpenGraph meta-tags. We are still far from the Ultimate Mechanism (which, today, probably means getting your event to stand out in GPT results), and there are some great further ideas in this ticket - but I would say that we have ensured that hackathons powered by Dribdat have decent SEO.\n\nSee also #379","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2024-02-09T22:05:17+08:00","repo_name":"dribdat/dribdat","issue_id":302243287,"issue_number":112,"issue_url":"https://github.com/dribdat/dribdat/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1457748738","fragment_type":"issue_description","sequence":0,"text":"Connect dribs with ActivityPub\nAlthough dribdat already supports cross-posting to social networks including Mastodon), the ActivityPub protocol (see also Wikipedia) would be interesting to support. From easing our authentication troubles to improving archival strategies, we could imagine multiple ways to re-imagine dribdat, join (delightful-apps) the party, and make a contribution to the Fediverse.\n\nThe first obvious step might be to migrate the model of our built-in commenting feature - dribs, or class Activity in the Python model - from writing (solely) to a database, to synchronizing with an ActivityPub compatible server. With this, posts on dribdat could be automatically propagated to a Mastodon server, or conversely, a team could define a Mastodon account whose posts (like we already do with Git repositories) are sync'ed in along with project results.\n\nSee also dridbot, Pixelfed, Mastodon.py and flask_activitypub\n\nScreenshot from 2022-11-21 12-02-03\n\n_Screenshot of social icons underneath a dribdat post, or drib._","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2022-11-21T11:07:50+08:00","repo_name":"dribdat/dribdat","issue_id":1457748738,"issue_number":325,"issue_url":"https://github.com/dribdat/dribdat/issues/325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1327843991","fragment_type":"issue_comment","sequence":1,"text":"Making @Mastodon@domain.tld links work in dribs and pitches, instead of turning into mailto:'s, would be a good start.","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2022-11-25T19:58:25+08:00","repo_name":"dribdat/dribdat","issue_id":1457748738,"issue_number":325,"issue_url":"https://github.com/dribdat/dribdat/issues/325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1348728884","fragment_type":"issue_comment","sequence":2,"text":"Some further thoughts contributed to / found in our community:\n\n- ForgeFed\n- URL \n- The Fediverse unlocks a world of composable distributed apps (opensource.org)\n- ActivityPub - Final thoughts, one year later. (overengineer.dev)\n\nAlternatives to ActivityPub to consider before committing:\n\n- Indieweb\n- Linked Data notifications (W3C)\n- Webmentions","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2022-12-13T14:48:32+08:00","repo_name":"dribdat/dribdat","issue_id":1457748738,"issue_number":325,"issue_url":"https://github.com/dribdat/dribdat/issues/325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1762815804","fragment_type":"issue_comment","sequence":3,"text":"I've started work on this in the feature-activitypub branch.","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2023-10-14T10:46:14+08:00","repo_name":"dribdat/dribdat","issue_id":1457748738,"issue_number":325,"issue_url":"https://github.com/dribdat/dribdat/issues/325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1830848122","fragment_type":"issue_comment","sequence":4,"text":"I've explored this in #370 \nFor now, adding full support is too much effort for me alone. I'll focus on #248 and come back to this later. If anyone knows of a good ActivityPub hackathon, ping me!","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2023-11-28T22:17:53+08:00","repo_name":"dribdat/dribdat","issue_id":1457748738,"issue_number":325,"issue_url":"https://github.com/dribdat/dribdat/issues/325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2512507063","fragment_type":"issue_comment","sequence":5,"text":"The concept of _ActivityPub Data_ explained by @sgrj in Understanding ActivityPub intrigues me.","author_login":"loleg","author_association":"COLLABORATOR","created_at":"2024-12-02T19:09:55+08:00","repo_name":"dribdat/dribdat","issue_id":1457748738,"issue_number":325,"issue_url":"https://github.com/dribdat/dribdat/issues/325","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0299","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"pystac 1.12 search results cause ValueError when using `odc.stac.load` that does not happen with pystac 1.11?","query_context":"I am not completely sure this is actually a problem in `pystac` (vs maybe the projection extension or another associated package), but I do know that downgrading from `pystac==1.12` to `pystac==1.11` was a successful workaround. In a conda environment created with this: `mamba create -n pystac_prob_min python=3.11 pystac-client odc-stac shapely`, running the following code will cause a `ValueError`.\n\npython\n\nimport pystac_client\nfrom odc import stac\nfrom datetime import datetime as dt\nfrom shapely.geometry import Point\n\ndef get_stac_items(x_coord: float, y_coord: float) -> pystac_client.item_search.ItemSearch:\n location_point = Point(x_coord, y_coord)\n collection = 'sentinel-2-l2a'\n start_date = None # earliest available\n end_date = dt.today().strftime(\"%Y-%m-%d\")\n\n # get a pystac client going to search the images\n client = pystac_client.Client.open(\" URL \n # From all days available with less than 5% cloud cover, get the 5\n # least cloudy days.\n search_results = client.search(\n collections=[collection],\n intersects=location_point,\n datetime=[start_date, end_date],\n query=[\"eo:cloud_cover \n ds = stac.load(\n ^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_stac_load.py\", line 360, in load\n _parsed = list(parse_items(items, cfg=stac_cfg, md_plugin=md_plugin))\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 745, in parse_items\n proc.update(item)\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 574, in update\n self._bootstrap(item)\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 557, in _bootstrap\n _, band2grid = compute_eo3_grids(data_bands)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 317, in compute_eo3_grids\n geoboxes = dicttoolz.valmap(asset_geobox, assets)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/toolz/dicttoolz.py\", line 85, in valmap\n rv.update(zip(d.keys(), map(func, d.values())))\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 277, in asset_geobox\n raise ValueError(\nValueError: The asset must have the following fields (from the projection extension): shape, transform, and one of an epsg, wkt2, or projjson\npython-BaseException\n\nIf I force `pystac==1.11` (instead of version 1.12) by creating another conda env with this command: `mamba create -n pystac_prob_fix python=3.11 pystac=1.11 pystac-client odc-stac shapely` and run the same code, then I get the expected result which is an xarray Dataset containing the retrieved items. \n\nThe problem seems to have something to do with how the projection extension is working (the proj `crs_string` is coming back as `None`), but I haven't had time to dig any further at this point.\n\nIt seems that at least one other person was having the same problem: URL (I'm the one that commented there, not the original poster).","known_context_document_ids":["gh_issue_2811773584"],"reference_answer":"Looks like this is due to `from_file` calling `from_dict` with `migrate = true` (o = cls.from_dict(d, href=href, migrate=True, preserve_dict=False)) but the actual default value (which **pystac-client** uses) is `False` (migrate: bool = False,). I thinking defaulting to `True` in `from_dict` _should_ make sense, as migration will become a more-and-more common operation as there is more hetergenous STAC (and STAC extension) versions in the wild. I'll cook up a PR.","answer_document_id":"gh_comment_2612469196","silver_evidence_path":["gh_comment_2614627101","gh_issue_2808463771","gh_comment_2612469196"],"evidence_issue_ids":[2811773584,2808463771],"source_repo_name":"stac-utils/pystac","source_issue_id":2811773584,"source_issue_number":1507,"source_issue_url":"https://github.com/stac-utils/pystac/issues/1507","target_repo_name":"stac-utils/pystac","target_issue_id":2808463771,"target_issue_number":1503,"target_issue_url":"https://github.com/stac-utils/pystac/issues/1503","reference_anchor_document_id":"gh_comment_2614627101","reference_answer_author":"gadomski","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.1071,"target_answer_overlap":0.1667},"issue_created_at":"2025-01-26T20:32:22+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2811773584","fragment_type":"issue_description","sequence":0,"text":"pystac 1.12 search results cause ValueError when using `odc.stac.load` that does not happen with pystac 1.11\nI am not completely sure this is actually a problem in `pystac` (vs maybe the projection extension or another associated package), but I do know that downgrading from `pystac==1.12` to `pystac==1.11` was a successful workaround. In a conda environment created with this: `mamba create -n pystac_prob_min python=3.11 pystac-client odc-stac shapely`, running the following code will cause a `ValueError`.\n\npython\n\nimport pystac_client\nfrom odc import stac\nfrom datetime import datetime as dt\nfrom shapely.geometry import Point\n\ndef get_stac_items(x_coord: float, y_coord: float) -> pystac_client.item_search.ItemSearch:\n location_point = Point(x_coord, y_coord)\n collection = 'sentinel-2-l2a'\n start_date = None # earliest available\n end_date = dt.today().strftime(\"%Y-%m-%d\")\n\n # get a pystac client going to search the images\n client = pystac_client.Client.open(\" URL \n # From all days available with less than 5% cloud cover, get the 5\n # least cloudy days.\n search_results = client.search(\n collections=[collection],\n intersects=location_point,\n datetime=[start_date, end_date],\n query=[\"eo:cloud_cover \n ds = stac.load(\n ^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_stac_load.py\", line 360, in load\n _parsed = list(parse_items(items, cfg=stac_cfg, md_plugin=md_plugin))\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 745, in parse_items\n proc.update(item)\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 574, in update\n self._bootstrap(item)\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 557, in _bootstrap\n _, band2grid = compute_eo3_grids(data_bands)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 317, in compute_eo3_grids\n geoboxes = dicttoolz.valmap(asset_geobox, assets)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/toolz/dicttoolz.py\", line 85, in valmap\n rv.update(zip(d.keys(), map(func, d.values())))\n File \"/Users/jkibele/miniforge3/envs/pystac_prob_min/lib/python3.11/site-packages/odc/stac/_mdtools.py\", line 277, in asset_geobox\n raise ValueError(\nValueError: The asset must have the following fields (from the projection extension): shape, transform, and one of an epsg, wkt2, or projjson\npython-BaseException\n\nIf I force `pystac==1.11` (instead of version 1.12) by creating another conda env with this command: `mamba create -n pystac_prob_fix python=3.11 pystac=1.11 pystac-client odc-stac shapely` and run the same code, then I get the expected result which is an xarray Dataset containing the retrieved items. \n\nThe problem seems to have something to do with how the projection extension is working (the proj `crs_string` is coming back as `None`), but I haven't had time to dig any further at this point.\n\nIt seems that at least one other person was having the same problem: URL (I'm the one that commented there, not the original poster).","author_login":"jkibele","author_association":"NONE","created_at":"2025-01-26T20:32:22+08:00","repo_name":"stac-utils/pystac","issue_id":2811773584,"issue_number":1507,"issue_url":"https://github.com/stac-utils/pystac/issues/1507","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2614627101","fragment_type":"issue_comment","sequence":1,"text":"After poking around a bit more, I found #1503. It looks very likely that was the cause of my problem. It seems that you fine folks have already found and fixed this issue, and I missed it when searching the issues earlier. Sorry to raise a false alarm, and thanks for all your work.","author_login":"jkibele","author_association":"NONE","created_at":"2025-01-26T23:08:23+08:00","repo_name":"stac-utils/pystac","issue_id":2811773584,"issue_number":1507,"issue_url":"https://github.com/stac-utils/pystac/issues/1507","linked_issue_ids":[2808463771],"is_known_query_context":false},{"document_id":"gh_comment_2615579101","fragment_type":"issue_comment","sequence":2,"text":"No worries at all, and thanks for the detailed report. I'm hoping to release the bugfix (and probably an implementation for URL which should also help) early this week.","author_login":"gadomski","author_association":"MEMBER","created_at":"2025-01-27T12:04:53+08:00","repo_name":"stac-utils/pystac","issue_id":2811773584,"issue_number":1507,"issue_url":"https://github.com/stac-utils/pystac/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2808463771","fragment_type":"issue_description","sequence":0,"text":"Version 1.12.0 breaks ProjectionExtension.crs_string for items using projection extension <2\npython\nimport pystac\nfrom pystac.extensions.projection import ProjectionExtension\nfrom pystac_client import Client\n\nstac = Client.open(\" URL \n\nsearch = stac.search(\n bbox=[-120.0, 35.0, -119.0, 36.0],\n datetime=\"2023-01-01/2023-01-07\",\n collections=[\"landsat-c2-l2\"],\n)\n\nprint(f\"pystac.__version__ = {pystac.__version__}\\n\")\nfor it in search.items():\n _it = pystac.item.Item.from_file(it.self_href)\n props = \"; \".join(\n f\"{k}={v}\" for k, v in it.properties.items() if k.startswith(\"proj:\")\n )\n proj_ext, *_ = (ext for ext in it.stac_extensions if \"/projection/\" in ext)\n print(\n f\"\"\"{it.id}\n proj: {props}\n proj.ext: {proj_ext}\n crs_str : {ProjectionExtension.ext(it).crs_string}\n .from_file() item\n crs_str': {ProjectionExtension.ext(_it).crs_string}\n\"\"\"\n )\n\nproduces following output:\n\npystac.__version__ = 1.12.0\n\nLC09_L2SP_043035_20230107_02_T1\n proj: proj:epsg=32610; proj:shape=[7731, 7611]; proj:transform=[30.0, 0.0, 564885.0, 0.0, -30.0, 4106115.0]\n proj.ext: URL \n crs_str : None\n .from_file() item\n crs_str': EPSG:32610\n\nLC08_L2SP_041036_20230101_02_T1\n proj: proj:epsg=32611; proj:shape=[7891, 7761]; proj:transform=[30.0, 0.0, 262785.0, 0.0, -30.0, 3948615.0]\n proj.ext: URL \n crs_str : None\n .from_file() item\n crs_str': EPSG:32611\n\nLC08_L2SP_041035_20230101_02_T1\n proj: proj:epsg=32611; proj:shape=[7871, 7741]; proj:transform=[30.0, 0.0, 302085.0, 0.0, -30.0, 4106715.0]\n proj.ext: URL \n crs_str : None\n .from_file() item\n crs_str': EPSG:32611\n\nLooks like items returned from `search` are NOT migrated to supported older extension version in the metadata compared to code, when using `Item.from_file( )` migration does happen by default.","author_login":"Kirill888","author_association":"NONE","created_at":"2025-01-24T04:24:13+08:00","repo_name":"stac-utils/pystac","issue_id":2808463771,"issue_number":1503,"issue_url":"https://github.com/stac-utils/pystac/issues/1503","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2612469196","fragment_type":"issue_comment","sequence":1,"text":"Looks like this is due to `from_file` calling `from_dict` with `migrate = true` (o = cls.from_dict(d, href=href, migrate=True, preserve_dict=False)) but the actual default value (which **pystac-client** uses) is `False` (migrate: bool = False,). I thinking defaulting to `True` in `from_dict` _should_ make sense, as migration will become a more-and-more common operation as there is more hetergenous STAC (and STAC extension) versions in the wild. I'll cook up a PR.","author_login":"gadomski","author_association":"MEMBER","created_at":"2025-01-24T12:55:30+08:00","repo_name":"stac-utils/pystac","issue_id":2808463771,"issue_number":1503,"issue_url":"https://github.com/stac-utils/pystac/issues/1503","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0300","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"AutoHUD Compatibility?","query_context":"When using this mod with the AutoHUD mod, i noticed that the items in the hotbar are misaligned. As shown here:\n2023-11-22_23 51 43\n\nAfter digging around in the AutoHUD settings a little bit, i found that if i turned off the Fade option then the items were aligned, but the item borders from the Item Borders mod were not:\n2023-11-23_00 05 04\n\nI am using version 1.20.1 of Minecraft on Quilt, with the newest version of both Raised and AutoHUD. And i have my Hud height at 10 in the Raised settings. (turning the Support option in the Raised settings on or off didn't seem to be changing anything)\n\nThanks!","known_context_document_ids":["gh_issue_2007184420"],"reference_answer":"The reason this is not an issue with 2.x or earlier is because Raised worked differently back then. Raised modified the Y value which was inherited down the line all the way to the hotbar item's render method which this mod took its Y value from. Now Raised translates the matrix stacks instead. This mod does not use the stack for the hotbar for some reason. The two ways cannot be done at the same time or else it would just double the vanilla stuff.","answer_document_id":"gh_comment_1766454842","silver_evidence_path":["gh_comment_1823677525","gh_issue_1941600748","gh_comment_1766454842"],"evidence_issue_ids":[2007184420,1941600748],"source_repo_name":"yurisuika/Raised","source_issue_id":2007184420,"source_issue_number":75,"source_issue_url":"https://github.com/yurisuika/Raised/issues/75","target_repo_name":"yurisuika/Raised","target_issue_id":1941600748,"target_issue_number":65,"target_issue_url":"https://github.com/yurisuika/Raised/issues/65","reference_anchor_document_id":"gh_comment_1823677525","reference_answer_author":"yurisuika","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.32,"target_answer_overlap":0.3333},"issue_created_at":"2023-11-22T22:14:52+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2007184420","fragment_type":"issue_description","sequence":0,"text":"AutoHUD Compatibility\nWhen using this mod with the AutoHUD mod, i noticed that the items in the hotbar are misaligned. As shown here:\n2023-11-22_23 51 43\n\nAfter digging around in the AutoHUD settings a little bit, i found that if i turned off the Fade option then the items were aligned, but the item borders from the Item Borders mod were not:\n2023-11-23_00 05 04\n\nI am using version 1.20.1 of Minecraft on Quilt, with the newest version of both Raised and AutoHUD. And i have my Hud height at 10 in the Raised settings. (turning the Support option in the Raised settings on or off didn't seem to be changing anything)\n\nThanks!","author_login":"DarkFireNinja","author_association":"NONE","created_at":"2023-11-22T22:14:52+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1823677525","fragment_type":"issue_comment","sequence":1,"text":"Item Borders was determined to not be compatible because it creates a new matrix stack (#65). As far as its behavior with AutoHud, that is peculiar. You may notice that while it may fade ItemBorders, it will not animate it, whether Raised is installed or not. This is likely because of the same reason.","author_login":"yurisuika","author_association":"OWNER","created_at":"2023-11-23T00:04:58+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[1941600748],"is_known_query_context":false},{"document_id":"gh_comment_1824771133","fragment_type":"issue_comment","sequence":2,"text":"Ah, you raised this here as well. Link for reference: Crendgrim/AutoHUD#79\n\nI can confirm that AutoHUD is incompatible with ItemBorders for the same reason as #65. I sent a PR to ItemBorders that has not been accepted (or responded to) yet.\n\nIf there is a further incompatibility between AutoHUD and Raised, I'm happy to investigate that, but I believe this to be ItemBorder's doing (AHilyard/ItemBorders#20, AHilyard/ItemBorders#21).","author_login":"Crendgrim","author_association":"NONE","created_at":"2023-11-23T17:42:49+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[1941600748],"is_known_query_context":false},{"document_id":"gh_comment_1825739423","fragment_type":"issue_comment","sequence":3,"text":"@yurisuika Thanks for letting me know about the issue having to do with Item Borders and not with Raised. But is there still a way to get Raised to work with AutoHUD without having to turn the fade option off?\n\nThanks!","author_login":"DarkFireNinja","author_association":"NONE","created_at":"2023-11-24T14:18:10+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1826831545","fragment_type":"issue_comment","sequence":4,"text":"I have a fix for this lined up in the next AutoHUD release, though for Fabric only.\n\n@yurisuika is there a way similar to Fabric's ObjectShare to easily get the HUD offset on Forge?","author_login":"Crendgrim","author_association":"NONE","created_at":"2023-11-26T16:42:01+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1828588688","fragment_type":"issue_comment","sequence":5,"text":"@Crendgrim Thanks a lot for fixing this issue in the newest version! I'm very grateful. As for the problem with Item Borders and Raised, i will be patient, no worries :D","author_login":"DarkFireNinja","author_association":"NONE","created_at":"2023-11-27T20:54:17+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1852116187","fragment_type":"issue_comment","sequence":6,"text":"In the past I asked on the Forge Discord if there was an analog to ObjectShare with Forge and the post was just deleted, so if they don't want me to know I guess I cannot answer you. It would be great if there were.\n\nIf you are willing to have a soft dependency, in the `RaisedConfig` class I have some public static methods that should expose these variables such as `RaisedConfig.getHud()`. You'd just have to run a check like `ModList.get().isLoaded(\"raised\")`.\n URL \n\nSorry for the slow response.","author_login":"yurisuika","author_association":"OWNER","created_at":"2023-12-12T14:12:33+08:00","repo_name":"yurisuika/Raised","issue_id":2007184420,"issue_number":75,"issue_url":"https://github.com/yurisuika/Raised/issues/75","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1941600748","fragment_type":"issue_description","sequence":0,"text":"item borders incompatibility with 3.0.0\n(2.0.0)\n2023-10-13_04 29 26\n(3.0.0)\n2023-10-13_04 22 13","author_login":"vex-ace","author_association":"NONE","created_at":"2023-10-13T09:34:38+08:00","repo_name":"yurisuika/Raised","issue_id":1941600748,"issue_number":65,"issue_url":"https://github.com/yurisuika/Raised/issues/65","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766200160","fragment_type":"issue_comment","sequence":1,"text":"I have one idea on how this might be supported. I can confirm this is on both Forge and Fabric, and 1.19.x does not work either.\n\nIt will probably involve adding a \"catch\" for injections around certain HUD elements. This mod injects AFTER the renderHotbarItem calls in renderHotbar.","author_login":"yurisuika","author_association":"OWNER","created_at":"2023-10-17T11:14:05+08:00","repo_name":"yurisuika/Raised","issue_id":1941600748,"issue_number":65,"issue_url":"https://github.com/yurisuika/Raised/issues/65","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766419280","fragment_type":"issue_comment","sequence":2,"text":"I'm not really sure the answer to this one yet. Perhaps it has something to do with its custom Iceberg library. It seems to use that for `drawGradientRect` instead of `fillGradient` from DrawContext or DrawableHelper. That could have something to do with it, my best guess right now.\n\nAt the end of the day, this is all stuff that I am unfamiliar with, so my recommendation for now is to just use <=2.x for now.","author_login":"yurisuika","author_association":"OWNER","created_at":"2023-10-17T13:27:33+08:00","repo_name":"yurisuika/Raised","issue_id":1941600748,"issue_number":65,"issue_url":"https://github.com/yurisuika/Raised/issues/65","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766427589","fragment_type":"issue_comment","sequence":3,"text":"Okay, I rewrote their mod (never submitted that previous comment so its why its like from a minute before this one) to use the vanilla gradient stuff and that wasn't it. But then I looked around and traced the methods back and bam it hit me like how did I not notice that before.\n\nimage\nSo it doesn't use the stack for the hotbar. I don't know why, but that is the source of the issue here. It is creating a new stack. If you were to make it use the stack (like I did in that screenshot), it would work. This would have to be fixed on their end.\n\nimage","author_login":"yurisuika","author_association":"OWNER","created_at":"2023-10-17T13:31:55+08:00","repo_name":"yurisuika/Raised","issue_id":1941600748,"issue_number":65,"issue_url":"https://github.com/yurisuika/Raised/issues/65","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766454842","fragment_type":"issue_comment","sequence":4,"text":"The reason this is not an issue with 2.x or earlier is because Raised worked differently back then. Raised modified the Y value which was inherited down the line all the way to the hotbar item's render method which this mod took its Y value from. Now Raised translates the matrix stacks instead. This mod does not use the stack for the hotbar for some reason. The two ways cannot be done at the same time or else it would just double the vanilla stuff.","author_login":"yurisuika","author_association":"OWNER","created_at":"2023-10-17T13:46:20+08:00","repo_name":"yurisuika/Raised","issue_id":1941600748,"issue_number":65,"issue_url":"https://github.com/yurisuika/Raised/issues/65","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0301","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"`setTimeout().unref()` is not a function?","query_context":"Seeing in shared process:\n\nbootstrap-window.js:253 TypeError: setTimeout(...).unref is not a function\n at IncomingMessage. (Sender.ts:138)\n at IncomingMessage.emit (events.js:327)\n at endReadableNT (internal/streams/readable.js:1327)\n at processTicksAndRejections (internal/process/task_queues.js:80)\n\nOriginates from `Sender.ts` of app insights it seems.\n\nimage\n\n URL","known_context_document_ids":["gh_issue_1101670653"],"reference_answer":"FYI we're still hitting this in VS Code where we run the module in an Electron window. URL \n\nEven though it doesn't look like you specifically target web, you can prevent this exception by supporting both environments like so:\n\nts\nconst x = setTimeout(...) as number | NodeJS.Timeout;\nif (typeof x !== 'number') {\n x.unref();\n}","answer_document_id":"gh_comment_1144972583","silver_evidence_path":["gh_comment_1098727526","gh_issue_292506429","gh_comment_1144972583"],"evidence_issue_ids":[1101670653,292506429],"source_repo_name":"microsoft/vscode","source_issue_id":1101670653,"source_issue_number":140624,"source_issue_url":"https://github.com/microsoft/vscode/issues/140624","target_repo_name":"Microsoft/ApplicationInsights-node.js","target_issue_id":292506429,"target_issue_number":367,"target_issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","reference_anchor_document_id":"gh_comment_1098727526","reference_answer_author":"Tyriar","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.2222,"target_answer_overlap":0.1071},"issue_created_at":"2022-01-13T12:45:56+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_1101670653","fragment_type":"issue_description","sequence":0,"text":"`setTimeout().unref()` is not a function\nSeeing in shared process:\n\nbootstrap-window.js:253 TypeError: setTimeout(...).unref is not a function\n at IncomingMessage. (Sender.ts:138)\n at IncomingMessage.emit (events.js:327)\n at endReadableNT (internal/streams/readable.js:1327)\n at processTicksAndRejections (internal/process/task_queues.js:80)\n\nOriginates from `Sender.ts` of app insights it seems.\n\nimage\n\n URL","author_login":"bpasero","author_association":"MEMBER","created_at":"2022-01-13T12:45:56+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1013340661","fragment_type":"issue_comment","sequence":1,"text":"Hmmm, `unref` has been around in node for awhile. Are you doing anything special? It seems like a lot of the errors with unref happen when you accidentally execute in a browser based context rather than node.","author_login":"lramos15","author_association":"MEMBER","created_at":"2022-01-14T18:02:51+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1013631797","fragment_type":"issue_comment","sequence":2,"text":"Nothing special afaik, just show the shared process window via F1:\n\nimage\n\nKeep in mind that the shared process is a browser window, so `setTimeout` does not return a function but a number!\n\nimage","author_login":"bpasero","author_association":"MEMBER","created_at":"2022-01-15T07:19:30+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1021410398","fragment_type":"issue_comment","sequence":3,"text":"Is there something special about exploration builds? I just added a try catch","author_login":"lramos15","author_association":"MEMBER","created_at":"2022-01-25T17:04:00+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1021911329","fragment_type":"issue_comment","sequence":4,"text":"@lramos15 yeah maybe how uncaught exceptions are handled and reported. This one you cannot really catch as it happens from an event handler:\n\nimage","author_login":"bpasero","author_association":"MEMBER","created_at":"2022-01-26T06:37:28+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1022254348","fragment_type":"issue_comment","sequence":5,"text":"Yeah like I said not sure what we should do here as one module expects node and another module expects window and the shared process is a bit in between","author_login":"lramos15","author_association":"MEMBER","created_at":"2022-01-26T14:33:52+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1098727526","fragment_type":"issue_comment","sequence":6,"text":"This is still happening.\n\nBtw found URL Maybe we need to contribute a PR.","author_login":"bpasero","author_association":"MEMBER","created_at":"2022-04-14T05:35:43+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[292506429],"is_known_query_context":false},{"document_id":"gh_comment_1099202978","fragment_type":"issue_comment","sequence":7,"text":"Is the issue saying we're trying to use the node SDK in the electron renderer?","author_login":"lramos15","author_association":"MEMBER","created_at":"2022-04-14T13:44:44+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099206339","fragment_type":"issue_comment","sequence":8,"text":"Yeah in the renderer we get the `setTimeout` variant from `DOM` and not `node.js`. I was actually looking into whether we could simply shim the `unref()` method, but it didn't seem to easy, unless we would overwrite the entire `setTimeout` method for everyone.","author_login":"bpasero","author_association":"MEMBER","created_at":"2022-04-14T13:48:24+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099211199","fragment_type":"issue_comment","sequence":9,"text":"Maybe we should be using the web SDK in the renderer then? We use the web telemetry reporter in the `/browser/` telemetryService so I'm surprised that we're using the node one in the renderer.","author_login":"lramos15","author_association":"MEMBER","created_at":"2022-04-14T13:53:38+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099222627","fragment_type":"issue_comment","sequence":10,"text":"Yeah that sounds reasonable. Though the fact that the shared process is a browser window is a bit of a debt issue, eventually we probably want to go away from running it as hidden window and use a pure node.js process once URL landed.\n\nGiven that, maybe we should just ignore the issue for now until we get to a real node.js process.","author_login":"bpasero","author_association":"MEMBER","created_at":"2022-04-14T14:05:27+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144936156","fragment_type":"issue_comment","sequence":11,"text":"Going to reopen this since it hasn't really been fixed and Daniel is seeing the issue as well. We are working on switching modules so maybe that will help but still want to keep this as a tracking issue.","author_login":"lramos15","author_association":"MEMBER","created_at":"2022-06-02T14:31:38+08:00","repo_name":"microsoft/vscode","issue_id":1101670653,"issue_number":140624,"issue_url":"https://github.com/microsoft/vscode/issues/140624","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_292506429","fragment_type":"issue_description","sequence":0,"text":"TypeError: this._handle.unref is not a function\nI get this exception just starting the Node.js appInsight v1.0.1:\n\nnode_modules/applicationinsights/out/AutoCollection…:28 Uncaught TypeError: this._handle.unref is not a function\n at AutoCollectPerformance.enable (/node_modules/applicationinsights/out/AutoCollection…:28)\n at Function.start (/node_modules/applicationinsights/out/applicationins…:68)\n at edebelix.js:6\nAutoCollectPerformance.enable @ /node_modules/applicationinsights/out/AutoCollection…:28\nstart @ /node_modules/applicationinsights/out/applicationins…:68\n(anonymous) @ edebelix.js:6\n\nJs Code:\n\nvar appInsights = require(\"applicationinsights\");\nappInsights.setup(MY_KEY)\n .start();\n\nI'm trying to use the SDK in a electron App.","author_login":"alyssonlopes","author_association":"NONE","created_at":"2018-01-29T18:09:03+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_361334714","fragment_type":"issue_comment","sequence":1,"text":"Thanks for reporting this? Which version of Node.js are you running? Docs seem to indicate unref should exist since 0.9.1 URL","author_login":"OsvaldoRosado","author_association":"MEMBER","created_at":"2018-01-29T18:11:26+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_361335442","fragment_type":"issue_comment","sequence":2,"text":"Just saw the update about electron. Are you trying to reference this from the frontend HTML rendering? If so, you'll want to use URL instead.","author_login":"OsvaldoRosado","author_association":"MEMBER","created_at":"2018-01-29T18:13:43+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_361336966","fragment_type":"issue_comment","sequence":3,"text":"Thanks for your reply.\nSo i can't use the Node.js version in electron renderer, right?\nIn this case, how can I use some functions from the Node.js version, like trackNodeHttpRequest?","author_login":"alyssonlopes","author_association":"NONE","created_at":"2018-01-29T18:18:59+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_361338150","fragment_type":"issue_comment","sequence":4,"text":"I think you have two options here.\n\n1) You can treat this like a typical webpage + server setup and instrument them separately. Requests on the server side, page views on the client side, and using our server and client side SDKs.\n\n2) You can use only the Node.js SDK for server-side instrumentation, and manually expose its track methods to your frontend. This lets you use only one SDK, but you'll lose the things we've written in our client side js SDK (like automatic AJAX collection and page load performance).","author_login":"OsvaldoRosado","author_association":"MEMBER","created_at":"2018-01-29T18:22:55+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_361338712","fragment_type":"issue_comment","sequence":5,"text":"Pinging @KamilSzostak in case he's seen any suggested guidance for this before from the JS side","author_login":"OsvaldoRosado","author_association":"MEMBER","created_at":"2018-01-29T18:24:53+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144972583","fragment_type":"issue_comment","sequence":6,"text":"FYI we're still hitting this in VS Code where we run the module in an Electron window. URL \n\nEven though it doesn't look like you specifically target web, you can prevent this exception by supporting both environments like so:\n\nts\nconst x = setTimeout(...) as number | NodeJS.Timeout;\nif (typeof x !== 'number') {\n x.unref();\n}","author_login":"Tyriar","author_association":"MEMBER","created_at":"2022-06-02T15:04:31+08:00","repo_name":"Microsoft/ApplicationInsights-node.js","issue_id":292506429,"issue_number":367,"issue_url":"https://github.com/Microsoft/ApplicationInsights-node.js/issues/367","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0302","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Feature request: Code generate support R language (RCurl package or httr pachage)?","query_context":"1. Postman Version: Postman v4.10.7\n 2. App (Chrome app or Mac app): Windows APP\n 3. OS details: Windows 7 / 10 64 Bit \n\ncould it possible to add R Language support in code generation function?\nFor example, could support generate code for R Language's RCurl or httr package.","known_context_document_ids":["gh_issue_223283519"],"reference_answer":"@nviraj Thank you for sharing this. This was helpful.\nWe have decided we'll add support for both. Because even ~370k downloads a month is a good number. \n\nWe'll keep this thread up-to-date with the progress and also share sample snippets.","answer_document_id":"gh_comment_1077494599","silver_evidence_path":["gh_comment_1076363033","gh_issue_712110683","gh_comment_1077494599"],"evidence_issue_ids":[223283519,712110683],"source_repo_name":"postmanlabs/postman-app-support","source_issue_id":223283519,"source_issue_number":2968,"source_issue_url":"https://github.com/postmanlabs/postman-app-support/issues/2968","target_repo_name":"postmanlabs/postman-code-generators","target_issue_id":712110683,"target_issue_number":347,"target_issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","reference_anchor_document_id":"gh_comment_1076363033","reference_answer_author":"umeshp7","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.2222},"issue_created_at":"2017-04-21T05:48:59+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_223283519","fragment_type":"issue_description","sequence":0,"text":"Feature request: Code generate support R language (RCurl package or httr pachage)\n1. Postman Version: Postman v4.10.7\n 2. App (Chrome app or Mac app): Windows APP\n 3. OS details: Windows 7 / 10 64 Bit \n\ncould it possible to add R Language support in code generation function?\nFor example, could support generate code for R Language's RCurl or httr package.","author_login":"strategist922","author_association":"NONE","created_at":"2017-04-21T05:48:59+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":223283519,"issue_number":2968,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/2968","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1076363033","fragment_type":"issue_comment","sequence":1,"text":"We'll be soon adding this support. You can track the progress here: URL","author_login":"umeshp7","author_association":"MEMBER","created_at":"2022-03-23T13:15:43+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":223283519,"issue_number":2968,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/2968","linked_issue_ids":[712110683],"is_known_query_context":false},{"document_id":"gh_comment_1176049305","fragment_type":"issue_comment","sequence":2,"text":"Support for Rcurl and httr are now in the Postman platform\n\n<img width=\"482\" alt=\"image\" src=\" URL","author_login":"DannyDainton","author_association":"CONTRIBUTOR","created_at":"2022-07-06T10:20:51+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":223283519,"issue_number":2968,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/2968","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_712110683","fragment_type":"issue_description","sequence":0,"text":"Add R to Generate Code Snippets\nHi, Please can you add an R code snippet in the Generate Code Snippets section. Thank you for your help.","author_login":"pmlove3","author_association":"NONE","created_at":"2020-09-30T16:49:14+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_722685824","fragment_type":"issue_comment","sequence":1,"text":"The specific R libraries this should be implemented for are httr and curl.","author_login":"ad0861","author_association":"NONE","created_at":"2020-11-05T22:37:24+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_758012531","fragment_type":"issue_comment","sequence":2,"text":"+1 \n\nThe auto-generated R SDK by OpenAPI Generator seems pretty heavy so I would prefer code snippets using curl instead","author_login":"soobbea","author_association":"NONE","created_at":"2021-01-11T15:10:48+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_879971318","fragment_type":"issue_comment","sequence":3,"text":"Would really love this to be honest! \nI encounter a lot of Postman collections in the wild but translating them manually to httr/ curl in R is a bit painful. \nThis would be a really beneficial addition to the Postman ecosystem considering R is at rank 12 according to TIOBE index.","author_login":"nviraj","author_association":"NONE","created_at":"2021-07-14T15:05:24+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1076352868","fragment_type":"issue_comment","sequence":4,"text":"Thanks for feedback and this feature request. I am happy to let you know that we will be soon adding support for this. \n\n@ad0861 @nviraj @soobbea Please let us know your preference on httr vs rcurl. We have started working on both. And it would be great to know which ones are more commonly used in the industry. \n\ncc @LuisTejedaS @erfemega","author_login":"umeshp7","author_association":"MEMBER","created_at":"2022-03-23T13:05:01+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1076369140","fragment_type":"issue_comment","sequence":5,"text":"I would recommend httr as it's very popular. The maintainers of the R library are also very active in the R community.","author_login":"ad0861","author_association":"NONE","created_at":"2022-03-23T13:21:46+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1076442973","fragment_type":"issue_comment","sequence":6,"text":"Thanks for taking this up @umeshp7! From my personal experience and working with other colleagues, httr seems to be more prevalent. In case it is useful, I am attaching stats for number of installs from RStudio's CRAN mirror (Not comprehensive as it is just a mirror but might indicate trends)\nhttr - []( URL \nRCurl - []( URL","author_login":"nviraj","author_association":"NONE","created_at":"2022-03-23T14:29:39+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1077494599","fragment_type":"issue_comment","sequence":7,"text":"@nviraj Thank you for sharing this. This was helpful.\nWe have decided we'll add support for both. Because even ~370k downloads a month is a good number. \n\nWe'll keep this thread up-to-date with the progress and also share sample snippets.","author_login":"umeshp7","author_association":"MEMBER","created_at":"2022-03-24T10:52:44+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1331399072","fragment_type":"issue_comment","sequence":8,"text":"Just chiming in here that httr2 has been released. It is the successor to httr2. Not quite 300k a month, but having been released just over a year ago, ~35k/month is not insignificant. \n\n[]( URL","author_login":"mrworthington","author_association":"NONE","created_at":"2022-11-29T22:25:45+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1700690022","fragment_type":"issue_comment","sequence":9,"text":"I am seconding the call for httr2 code snipper support! It is more state-of-the-R-art because it is pipe-able and provides really good support for oauth flows and caching!","author_login":"spechticus","author_association":"NONE","created_at":"2023-08-31T09:29:54+08:00","repo_name":"postmanlabs/postman-code-generators","issue_id":712110683,"issue_number":347,"issue_url":"https://github.com/postmanlabs/postman-code-generators/issues/347","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0303","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Error with --snapshot-move-data Flag in Velero with Rook-Ceph Storage backup time?","query_context":"Description\nI am encountering an issue while attempting to back up and restore pods using Velero with Rook-Ceph as the storage backend. The error occurs when using the --snapshot-move-data flag for CSI snapshot data movement. Detailed steps and error messages are provided below.\n\nSteps to Reproduce\n\n- Setup Environment:\nVelero configured with Rook-Ceph as the storage backend.\nKubernetes cluster managed by Kubespray.\n- Backup Pod:\nExecute the backup command with the --snapshot-move-data flag.\nvelero backup create media6 --snapshot-move-data\n- Encounter Error:\nBackup process fails\n\nCurrent Issue\nThe backup processes fail with an error stating partially failed.\n\nExpected Outcome\n• Successful backup of pods using the --snapshot-move-data flag with Velero and Rook-Ceph.\n• Successful restore of the backed-up data without encountering the DataUpload error.\n\nActual Outcome\n• The backup process fails with an error related to partially failed.\n\nAdditional Information\n• Current Environment:\n- Kubernetes cluster managed by Kubespray.\n- Velero for backup operations.\n- Rook-Ceph as the storage backend.\n\nRequest for Assistance\nI would appreciate guidance on the following:\n1. Any additional configuration steps or best practices for using the --snapshot-move-data flag with Velero and Rook-Ceph.\n2. Clarification on whether this is a known issue and if there are any patches or updates available to address it.\n\nI have now installed the node-agent, and it is running. I attempted to back up, but I'm encountering a error.\n\nScreenshot_752\nScreenshot_749\nScreenshot_751\nScreenshot_750\n\nHere is the related bundle file:\nbundle-2024-08-06-17-38-42.tar.gz","known_context_document_ids":["gh_issue_2452560801"],"reference_answer":"@Lyndon-Li given that even \"no nodes available\" isn't necessarily permanent, I'm wondering whether the message-parsing approach might be too error-prone, missing edge cases, etc.","answer_document_id":"gh_comment_2183289694","silver_evidence_path":["gh_comment_2272783663","gh_issue_2357436918","gh_comment_2183289694"],"evidence_issue_ids":[2452560801,2357436918],"source_repo_name":"vmware-tanzu/velero","source_issue_id":2452560801,"source_issue_number":8092,"source_issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","target_repo_name":"vmware-tanzu/velero","target_issue_id":2357436918,"target_issue_number":7898,"target_issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","reference_anchor_document_id":"gh_comment_2272783663","reference_answer_author":"sseago","reference_answer_author_association":"COLLABORATOR","quality_score":85.78,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.275,"target_answer_overlap":0.0556},"issue_created_at":"2024-08-07T06:01:07+08:00","valid_comment_count":29,"fragments":[{"document_id":"gh_issue_2452560801","fragment_type":"issue_description","sequence":0,"text":"Error with --snapshot-move-data Flag in Velero with Rook-Ceph Storage backup time\nDescription\nI am encountering an issue while attempting to back up and restore pods using Velero with Rook-Ceph as the storage backend. The error occurs when using the --snapshot-move-data flag for CSI snapshot data movement. Detailed steps and error messages are provided below.\n\nSteps to Reproduce\n\n- Setup Environment:\nVelero configured with Rook-Ceph as the storage backend.\nKubernetes cluster managed by Kubespray.\n- Backup Pod:\nExecute the backup command with the --snapshot-move-data flag.\nvelero backup create media6 --snapshot-move-data\n- Encounter Error:\nBackup process fails\n\nCurrent Issue\nThe backup processes fail with an error stating partially failed.\n\nExpected Outcome\n• Successful backup of pods using the --snapshot-move-data flag with Velero and Rook-Ceph.\n• Successful restore of the backed-up data without encountering the DataUpload error.\n\nActual Outcome\n• The backup process fails with an error related to partially failed.\n\nAdditional Information\n• Current Environment:\n- Kubernetes cluster managed by Kubespray.\n- Velero for backup operations.\n- Rook-Ceph as the storage backend.\n\nRequest for Assistance\nI would appreciate guidance on the following:\n1. Any additional configuration steps or best practices for using the --snapshot-move-data flag with Velero and Rook-Ceph.\n2. Clarification on whether this is a known issue and if there are any patches or updates available to address it.\n\nI have now installed the node-agent, and it is running. I attempted to back up, but I'm encountering a error.\n\nScreenshot_752\nScreenshot_749\nScreenshot_751\nScreenshot_750\n\nHere is the related bundle file:\nbundle-2024-08-06-17-38-42.tar.gz","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-07T06:01:07+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2272691449","fragment_type":"issue_comment","sequence":1,"text":"@Lyndon-Li I don’t understand; there’s nothing related to my current issue.","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-07T06:10:25+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2272743903","fragment_type":"issue_comment","sequence":2,"text":"Here is the error associated to the partially failed backup:\n`\"message\": \"found a dataupload velero/media6-fj8fl with expose error: Pod is unschedulable: 0/3 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.. mark it as cancel\",`","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-08-07T06:48:13+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2272783663","fragment_type":"issue_comment","sequence":3,"text":"@Lyndon-Li You have no idea\n\n`\"message\": \"found a dataupload velero/media6-fj8fl with expose error: Pod is unschedulable: 0/3 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.. mark it as cancel\",`\n\n why this issue occurred, and the error message displayed does not provide a solution. The issue #7898 lacks any description for resolution. Is it possible that the problem lies in my installation steps or elsewhere? Any guidance to help resolve this issue would be appreciated.","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-07T07:14:32+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[2357436918],"is_known_query_context":false},{"document_id":"gh_comment_2272790054","fragment_type":"issue_comment","sequence":4,"text":"There is no resolution/workaround, you have to wait the release of 1.14.1 or you need to downgrade to 1.13.x","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-08-07T07:18:29+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2272795586","fragment_type":"issue_comment","sequence":5,"text":"@Lyndon-Li This means that the issue \n\n`\"message\": \"found a dataupload velero/media6-fj8fl with expose error: Pod is unschedulable: 0/3 nodes are available: pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.. mark it as cancel\"`,\n\ndid not occur in version 1.13.x, and my backup process was executed using the --snapshot-move-data flag, correct?","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-07T07:22:07+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2273098834","fragment_type":"issue_comment","sequence":6,"text":"@Lyndon-Li Following your suggestion, I used version 1.13.2. After installing it and attempting to back up with the --snapshot-move-data flag, the backup status completed without any errors. However, the snapshot data was not moved as expected. I also checked the MinIO S3 bucket, and there was no Kopia folder created for the snapshot backup. In short, this is not meeting my requirements. Do you have any solutions related to this issue?\n\nScreenshot_754\nScreenshot_755\nScreenshot_756\nScreenshot_758\nScreenshot_757\nScreenshot_759\nScreenshot_760\nScreenshot_761\n\nHere is the related bundle file:\nbundle-2024-08-07-15-23-09.tar.gz","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-07T10:03:32+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2273168892","fragment_type":"issue_comment","sequence":7,"text":"For Velero prior to 1.14, you need to add CSI plugin in installation if you want to use data mover feature.","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-08-07T10:41:55+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2273280832","fragment_type":"issue_comment","sequence":8,"text":"@Lyndon-Li I'm encountering this error related to volume snapshots and classes, even though I've already defined them in my namespace.\n \nScreenshot_762\nScreenshot_763\nScreenshot_764\nScreenshot_765\n\nHere is the related bundle file:\nbundle-2024-08-07-17-03-56.tar.gz","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-07T11:47:29+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2273531207","fragment_type":"issue_comment","sequence":9,"text":"@jayrajmeh0 You're using version 0.1.1 of the CSI plugin. For Velero 1.13 you need 0.7.x.","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-08-07T13:52:00+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2275097423","fragment_type":"issue_comment","sequence":10,"text":"**@Lyndon-Li & @sseago Thank you both for your guidance and assistance with the backup process. I was able to take a snapshot backup using the flag --snapshot-move-data , which proves that I successfully completed this task.**\n\nScreenshot_773\nScreenshot_774\nScreenshot_775\nScreenshot_776\nScreenshot_777\nScreenshot_783\n\n**The backup process has been successfully completed. However, when I removed the namespace associated with the backup shown in the screenshot above, I encountered an issue during my next task, which is restoring using Velero. The details of the issue are as follows:**\n\nScreenshot_778\nScreenshot_780\nScreenshot_781\n\nHere is the related bundle file:\nbundle-2024-08-08-12-08-27.tar.gz","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-08T07:04:10+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2277197696","fragment_type":"issue_comment","sequence":11,"text":"By checking the logs I found following error messages:\n\ntime=\"2024-08-08T06:25:44Z\" level=info msg=\"BackupStorageLocations is valid, marking as available\" backup-storage-location=velero/default controller=backup-storage-location logSource=\"pkg/controller/backup_storage_location_controller.go:126\"\ntime=\"2024-08-08T06:25:53Z\" level=error msg=\"fail to get DataDownload: fail to list DataDownload: etcdserver: leader changed\" Action=PVCRestoreItemAction Namespace=velero OperationID=dd-4703bc72-cbef-4a31-a0bf-8a3ad433d90f.be3cfbe8-fe0a-41d7f03b9 cmd=/plugins/velero-plugin-for-csi logSource=\"/go/src/velero-plugin-for-csi/internal/restore/pvc_action.go:240\" pluginName=velero-plugin-for-csi\ntime=\"2024-08-08T06:25:53Z\" level=info msg=\"Marking restore mongo-20240808115503 FinalizingPartiallyFailed\" logSource=\"pkg/controller/restore_operations_controller.go:186\" restore=velero/mongo-20240808115503\n\nSo it seems a random issue in etcd, if the problem is highly reproducible, you may want to check if there's any resource or perf issue in your cluster.","author_login":"reasonerjt","author_association":"CONTRIBUTOR","created_at":"2024-08-09T05:50:08+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2283576622","fragment_type":"issue_comment","sequence":12,"text":"@reasonerjt \nI have checked all the pods, and everything looks good without any errors during the restore process. Can you help me resolve the issue in more detail?\n\n**@Lyndon-Li @sseago @reasonerjt** \n**Additionally, I have another question related to Velero and Ceph storage. Currently, I have a three-node Kubernetes cluster with Ceph storage. If any of these three nodes were to be destroyed and my database backup is stored in the cloud using Velero, can I restore it to a new Kubernetes environment? What are the prerequisites for this, particularly concerning Ceph storage pools and OSDs? Do I need to set up the same names or configurations for Velero to restore everything correctly?**","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-12T10:11:30+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2293323198","fragment_type":"issue_comment","sequence":13,"text":"@Lyndon-Li \n**I successfully backed up one cluster and used the --snapshot-move-data flag to restore the backup on a second cluster. The restore process completed without any issues, and all statuses showed as successful. However, when I checked the MongoDB pod in the namespace of the new cluster, it was not functioning properly and encountered some issues.**\n\nScreenshot_822\nScreenshot_823\nScreenshot_827\nScreenshot_828\nScreenshot_824\nScreenshot_825\n\nHere is the related bundle file:\nbundle-2024-08-16-16-45-06.tar.gz","author_login":"jayrajmeh0","author_association":"NONE","created_at":"2024-08-16T11:20:33+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2298149269","fragment_type":"issue_comment","sequence":14,"text":"@jayrajmeh0 \n\nAs for the latest issue, it seems the infrastructure where you restore the mongo DB does not meet the requirement of mongoDB.\nI suggest you read the links in the error message to understand why it failed. IMO it is beyond the scope of velero.","author_login":"reasonerjt","author_association":"CONTRIBUTOR","created_at":"2024-08-20T07:22:04+08:00","repo_name":"vmware-tanzu/velero","issue_id":2452560801,"issue_number":8092,"issue_url":"https://github.com/vmware-tanzu/velero/issues/8092","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2357436918","fragment_type":"issue_description","sequence":0,"text":"Fail early DM pod checks have false positives\n**What steps did you take and what happened:**\nIn Velero 1.13, we added code to fail early if the datamover pods are in an unrecoverable state: URL \nIn 1.14, some additional changes were made here: URL \n\nIn our OADP testing with Velero 1.14, we found that in some cases DDs or DUs were being canceled almost immediately. Digging into the code added in the above 2 PRs, there are a few situations where Velero considers a pod unrecoverable:\n1) pod phase of Failed or Unknown\n2) pod phase of Pending with an \"unschedulable\" condition\n3) container status with ImagePullBackOff or ErrImgNeverPull\n\nIt was the second situation that was causing the failure for us. The pod will have an \"unschedulable\" condition until the PVC is is bound to a PV. In many cases, this all happens quickly enough that by the time Velero checks, the PVC is bound and the Pod is no longer unschedulable, but if the provisioner takes a few seconds to bind the PV and PVC together, the Pod may still have an \"unschedulable\" condition when the node agent first checks, which will cause the DU or DD to be immediately canceled.\n\nWe are seeing this happen frequently with Ceph volumes.\n\nWe have a couple of options here.\n\n1) The simplest option would be to remove \"unschedulable\" from the list of unrecoverable conditions. As we see here, \"unschedulable\" does not always indicate an unrecoverable state. The only downside here is that we lose fast fail for permanently-unschedulable pods.\n\n2) Slightly more complicated -- we could wrap the unschedulable check in a PollUntilContextTimeout call with some hard-coded timeout (2 minutes maybe?) -- this will result in almost-fast-failing for unschedulable pods. This assumes that no provisioner should take more than 2 minutes to provision the PV. That's probably safe. \n\nI will be posting a draft PR for option 1) -- I'm open to moving to 2) if the consensus is that it's a better solution.\n\n**Environment:**\n\n- Velero version (use `velero version`): 1.14\n- Velero features (use `velero client config get features`): \n- Kubernetes version (use `kubectl version`):\n- Kubernetes installer & version:\n- Cloud provider or hardware configuration:\n- OS (e.g. from `/etc/os-release`):\n\n**Vote on this issue!**\n\nThis is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here. \nUse the \"reaction smiley face\" up to the right of this comment to vote.\n\n- :+1: for \"I would like to see this bug fixed as soon as possible\"\n- :-1: for \"There are more important bugs to focus on right now\"","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-17T14:03:02+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2174792243","fragment_type":"issue_comment","sequence":1,"text":"@sseago \n \n\nDuring data mover restore, I think this happens for almost every volume ---- the workload pod and PVC is firstly created, but the workload PVC is not bound to any PV until the DDCR completes, this won't complete in seconds/minutes. However, we didn't see this problem during the test.\n\nOr do you mean this is an intermediate moment when the PV is provisioned and it takes some seconds to bound the PVC and PV.","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-06-18T02:17:24+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2176943354","fragment_type":"issue_comment","sequence":2,"text":"It is definitely an intermediate scenario. I think some provisioners are fast enough that the code doesn't force cancel of DU/DD with the current code, but we have discovered with Ceph as a CSI provisioner, we are seeing frequent situations where DU or DD are getting canceled because the \"unschedulable\" pod state is considered \"unrecoverable\" by Velero even though it's not unrecoverable.","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-18T20:46:53+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2177300752","fragment_type":"issue_comment","sequence":3,"text":"I personally think ignoring unschedulable makes the most sense.. an admin (or autoscaler) can scale up more nodes etc for scheduling to resolve. timing out at 1 minute and marking restore fail can be misleading. velero did everything right, infra was just not yet avail to schedule but could be totally fine 30 minutes later.","author_login":"kaovilai","author_association":"CONTRIBUTOR","created_at":"2024-06-19T00:30:04+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2178733056","fragment_type":"issue_comment","sequence":4,"text":"@Lyndon-Li here is the error we saw with Ceph:\n\n message: 'found a dataupload openshift-adp/backup20-llp79 with expose error: Pod\n is unschedulable: 0/6 nodes are available: pod has unbound immediate PersistentVolumeClaims.\n preemption: 0/6 nodes are available: 6 Preemption is not helpful for scheduling...\n mark it as cancel'\n\nThe \"unbound immediate PersistentVolumeClaims\" part is probably the most relevant part of the message. Unbound PVC is a temporary error.","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-19T13:32:41+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2179692909","fragment_type":"issue_comment","sequence":5,"text":"@sseago\nThen I think we can preserve the benefit by doing more check on the message though it is a little bit trick (when the message is changed by kubernetes, we also need to change), by this:\n\n- We add a new parameter (e.g., `unscheduableMsg`) to `IsPodUnrecoverable`\n- We check the Unscheduable container state only when `unscheduableMsg` is not empty\n- When we detect the pod is Unschedulable status, we fruther check the message contains the `unscheduableMsg`\n- There is only one place need to pass an non-empty `unscheduableMsg`, that is in `PeekExposed` where we set `unscheduableMsg` as `node affinity conflict`\n\nWhat do you think?\n\ncc @reasonerjt","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-06-20T02:20:48+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2183287970","fragment_type":"issue_comment","sequence":6,"text":"@Lyndon-Li Looks like we have another bug seeing the same thing -- this time with node autoscaling -- i.e. no nodes available initially, but wait a little bit and new nodes are made available, but the DU has already been canceled: URL","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-21T18:52:26+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2183289694","fragment_type":"issue_comment","sequence":7,"text":"@Lyndon-Li given that even \"no nodes available\" isn't necessarily permanent, I'm wondering whether the message-parsing approach might be too error-prone, missing edge cases, etc.","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-21T18:53:48+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2185450319","fragment_type":"issue_comment","sequence":8,"text":"All in all, I think the approach mentioned here is still valid since it is checking the string `node affinity conflict` and none of the existing issues have a container message like that.\n\nOn the other hand, I also agree this is a tricky approach. So the other way I suggest there is to simply remove the \"UnReachable\" container message check and let the DU/DD being cancelled after 30min timeout. This should be what #7899 is doing (if so we also need to change the design).\n\nI am fine with the either way. @sseago Let me know your choice. And I will also discuss with others in the team.","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-06-24T02:02:03+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[2357436918],"is_known_query_context":false},{"document_id":"gh_comment_2185740661","fragment_type":"issue_comment","sequence":9,"text":"We further discussed this issue and realized that there is no reliable way to filter out the unschedule problem caused by users' data mover node selection.\nTherefore, we suggest to simply remove the changes remove the \"UnReachable\" container message check and let the DU/DD being cancelled after 30min timeout. This should be what URL is doing + data mover node selection design change.\n\n@sseago Let us know your thoughts.","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-06-24T06:49:53+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2187621647","fragment_type":"issue_comment","sequence":10,"text":"@Lyndon-Li so it sounds like you're saying the change in #7899 is appropriate? We still fail early for ImagePullBackOff or Failed pods, but for unschedulable, we just let the 30 minute timeout take effect? I'm marking that PR as ready for review now -- we can approve/merge that one or continue to discuss changes needed there.","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-24T23:36:52+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2187817013","fragment_type":"issue_comment","sequence":11,"text":"Yes, #7899 has been merged. Meanwhile, I will submit a PR to change the node-selection design.","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-06-25T02:12:02+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2189740919","fragment_type":"issue_comment","sequence":12,"text":"@Lyndon-Li reopening to consider this for 1.14.1 -- let me know if it's better to create a new issue instead.","author_login":"sseago","author_association":"COLLABORATOR","created_at":"2024-06-25T18:53:56+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2190309393","fragment_type":"issue_comment","sequence":13,"text":"IMO, cherrypicks don't have to reference a still opened issue, one could have cherrypicks that close an already closed issue for a different release branch.","author_login":"kaovilai","author_association":"CONTRIBUTOR","created_at":"2024-06-26T00:52:02+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2190729892","fragment_type":"issue_comment","sequence":14,"text":"No problem, we can use the same issue to track all (it was auto closed when merging #7899)","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-06-26T05:20:39+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2295731075","fragment_type":"issue_comment","sequence":15,"text":"As the problem describe here, we cannot fail earlier, but we still need to preserve as more info as possible to help the troubleshooting when prepare timeout happens. Opened an issue #8125 for this.","author_login":"Lyndon-Li","author_association":"CONTRIBUTOR","created_at":"2024-08-19T06:01:50+08:00","repo_name":"vmware-tanzu/velero","issue_id":2357436918,"issue_number":7898,"issue_url":"https://github.com/vmware-tanzu/velero/issues/7898","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0304","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Feature requests - hotkeys for cycling spaces, mouse pointer warp with focus management?","query_context":"Love this app and excited to see where it goes. Using multiple spaces is a great way to organize but the delay when switching (especially bad at 120hz) is nearly intolerable. It also exposed me to your Snippety app which I will also have to check out now.\n\nI have a few suggestions, feel free to ignore if they do not fit with your plans for the app.\n\n1. I am very used to using the built-in gesture to switch spaces (3/4 finger swipe left right when enabled in settings) and would love a way to assign shortcuts to cycle between the different \"flash spaces\" that I have created, like Ctrl+Left|Right does for the built-in spaces feature. I used BetterTouchTool to configure the 3-finger swipe left/right to toggle between two defined spaces, but it would be nice to have it switch between all of the ones I've created. I could probably make this work with BTT using a variable to keep track of the current space but it seems worth asking.\n\n2. When switching app focus with the keyboard shortcuts it would be nice if the mouse pointer also moved to the focused application.\n\n3. While I'm still adjusting to the auto-hiding of apps I occasionally feel like I \"lose\" an app (like the settings menu I've opened to tweak something) because I switched spaces. Maybe there could be a way to assign windows that get created in an existing space to a specific defined space when you switch rather than hiding from all spaces? OTOH I will probably get used to the behavior and this may be unnecessary long term.","known_context_document_ids":["gh_issue_2810332423"],"reference_answer":"This change shouldn't affect the performance. \n\nThe performance is the main goal of this project, I started it because Aerospace is too slow and there is no plan to fix it. See more here: #1 \n \n\nYes, I use native hiding, Aerospace hides apps by hiding them in screen corners, but I think the main issue with Aerospace is that it checks all windows every time you try changing something which is inefficient but probably necessary to implement tiling management. This project doesn't need to care about windows placement so it's easier to make it faster.","answer_document_id":"gh_comment_2610780059","silver_evidence_path":["gh_comment_2613453526","gh_issue_2807392113","gh_comment_2610780059"],"evidence_issue_ids":[2810332423,2807392113],"source_repo_name":"wojciech-kulik/FlashSpace","source_issue_id":2810332423,"source_issue_number":12,"source_issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/12","target_repo_name":"wojciech-kulik/FlashSpace","target_issue_id":2807392113,"target_issue_number":3,"target_issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/3","reference_anchor_document_id":"gh_comment_2613453526","reference_answer_author":"wojciech-kulik","reference_answer_author_association":"OWNER","quality_score":78.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.303,"anchor_target_overlap":0.0303,"target_answer_overlap":0.15},"issue_created_at":"2025-01-24T20:34:45+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2810332423","fragment_type":"issue_description","sequence":0,"text":"Feature requests - hotkeys for cycling spaces, mouse pointer warp with focus management\nLove this app and excited to see where it goes. Using multiple spaces is a great way to organize but the delay when switching (especially bad at 120hz) is nearly intolerable. It also exposed me to your Snippety app which I will also have to check out now.\n\nI have a few suggestions, feel free to ignore if they do not fit with your plans for the app.\n\n1. I am very used to using the built-in gesture to switch spaces (3/4 finger swipe left right when enabled in settings) and would love a way to assign shortcuts to cycle between the different \"flash spaces\" that I have created, like Ctrl+Left|Right does for the built-in spaces feature. I used BetterTouchTool to configure the 3-finger swipe left/right to toggle between two defined spaces, but it would be nice to have it switch between all of the ones I've created. I could probably make this work with BTT using a variable to keep track of the current space but it seems worth asking.\n\n2. When switching app focus with the keyboard shortcuts it would be nice if the mouse pointer also moved to the focused application.\n\n3. While I'm still adjusting to the auto-hiding of apps I occasionally feel like I \"lose\" an app (like the settings menu I've opened to tweak something) because I switched spaces. Maybe there could be a way to assign windows that get created in an existing space to a specific defined space when you switch rather than hiding from all spaces? OTOH I will probably get used to the behavior and this may be unnecessary long term.","author_login":"iceblink","author_association":"NONE","created_at":"2025-01-24T20:34:45+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2810332423,"issue_number":12,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/12","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2613407902","fragment_type":"issue_comment","sequence":1,"text":"Hi, thank you for the feedback! \n\nAd 1. I'm not sure if I understand it correctly. Would you like to have an option in the app to turn on the 3-fingers swipe to change spaces? Or would you like the app to expose some interface so that you can integrate another app that recognizes swipes? In any case, it sounds pretty cool and I'd like to add it.\n\nAd 2. Another great idea, I will try adding it.\n\nAd 3. Hmm, I'm not sure about this one. The key point is that I would like to keep the experience that FlashSpace is to help you but doesn't interfere too much with your actions. So if you call some app it appears as expected, as if FlashSpace didn't exist. Regarding auto assignments, I'm worried about ending up like most tiling managers with everything blinking and jumping when a new window appears and gets assigned somewhere, especially small windows :D. However, I understand the point here, I'll think about it.\n\nThanks for valuable ideas 🍻","author_login":"wojciech-kulik","author_association":"OWNER","created_at":"2025-01-24T21:27:52+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2810332423,"issue_number":12,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/12","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613453526","fragment_type":"issue_comment","sequence":2,"text":"For #1 just keyboard shortcuts to cycle spaces is fine and keeps this tool keyboard focused. BetterTouchTool is already great at binding a gesture to a keyboard shortcut so it makes sense to keep those separate.\n\nFor #3 I do agree it starts to get into full on window management which does seem out of scope. I think this was just onboarding, after a few hours I am pretty used to how it works already.","author_login":"iceblink","author_association":"NONE","created_at":"2025-01-24T22:00:20+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2810332423,"issue_number":12,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/12","linked_issue_ids":[2807392113],"is_known_query_context":false},{"document_id":"gh_comment_2613664540","fragment_type":"issue_comment","sequence":3,"text":"Hi! I added the features you asked for. I really love both, great suggestions! 🍻 \n\nRegarding the cursor warp, I added two modes separately. One is for hotkeys changing focus and one is for hotkeys changing workspaces.","author_login":"wojciech-kulik","author_association":"OWNER","created_at":"2025-01-25T00:40:00+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2810332423,"issue_number":12,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/12","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2807392113","fragment_type":"issue_description","sequence":0,"text":"Question about: The last app on the list will be focused when switching to the workspace.\nIs there any plan in mind to make it configurable?\n\nLet's say: When changing to another workspace, it should focus not the last app on the configured list of the workspace, but actually the last focused app in that workspace.","author_login":"bartier","author_association":"NONE","created_at":"2025-01-23T16:38:52+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2807392113,"issue_number":3,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610366503","fragment_type":"issue_comment","sequence":1,"text":"Interesting, definitely worth adding as an option. I plan to add settings, so I could probably add such feature there.","author_login":"wojciech-kulik","author_association":"OWNER","created_at":"2025-01-23T16:41:05+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2807392113,"issue_number":3,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610390495","fragment_type":"issue_comment","sequence":2,"text":"Is this behavior if implemented can somehow affect the performance? I know it is hard to say, but I tested and comparing to AeroSpace, I can see FlashSpace changes faster even in the v0.2.3 version (early project development).\n\nAre you relying in different APIs than AeroSpace to the core of its APP? I know it is hard to compare as the tools try to solve different problems (AeroSpace adds window management behavior, but I am not interested in that). I ask that, because I couldn't really find quickly these infos and I am not Swift Developer to understand the code basis in a hurry, I'd need to take a time to onboard, so asking seems easier.","author_login":"bartier","author_association":"NONE","created_at":"2025-01-23T16:44:59+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2807392113,"issue_number":3,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610780059","fragment_type":"issue_comment","sequence":3,"text":"This change shouldn't affect the performance. \n\nThe performance is the main goal of this project, I started it because Aerospace is too slow and there is no plan to fix it. See more here: #1 \n \n\nYes, I use native hiding, Aerospace hides apps by hiding them in screen corners, but I think the main issue with Aerospace is that it checks all windows every time you try changing something which is inefficient but probably necessary to implement tiling management. This project doesn't need to care about windows placement so it's easier to make it faster.","author_login":"wojciech-kulik","author_association":"OWNER","created_at":"2025-01-23T18:57:49+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2807392113,"issue_number":3,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2610803419","fragment_type":"issue_comment","sequence":4,"text":"Really enjoyed the app UNIX philosophy (not sure if it was intended): do 1 thing and do it the best way possible: Workspaces management. I am not interested in window tiling and I can see how AeroSpace is interested in that, but not my use case. Thanks for the overview. I can't wait this project to grow :-)","author_login":"bartier","author_association":"NONE","created_at":"2025-01-23T19:08:07+08:00","repo_name":"wojciech-kulik/FlashSpace","issue_id":2807392113,"issue_number":3,"issue_url":"https://github.com/wojciech-kulik/FlashSpace/issues/3","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0305","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Add small caps æ and ø?","query_context":"If I download Besley* from URL I get an old version (1.8.3) which is useless in Norwegian because of the ø's. If I download from github I get version 2.000 which is equally useless for the same reason. But if I download from Google fonts I get version 2.001 which is perfect! This version is called Besley (without an asterisk) and contains no weight called fatface – but a «black» which looks very similiar. Will you update the fonts – at least in indestructibletype.com?","known_context_document_ids":["gh_issue_998409095"],"reference_answer":"Stop being such a rude asshole to Owen.\n\nHe did fix it.\n\nimage\n\nIt's possible he didn't update the TTF's distributed, or for some other reason, you're still using an old font. Making a duplicate issue instead of replying in the existing one with something nicer like \"it still doesn't work for me, any idea why?\" will get you a lot more traction.\n\nClosed.","answer_document_id":"gh_comment_1377080794","silver_evidence_path":["gh_comment_1377117060","gh_issue_1527176268","gh_comment_1377080794"],"evidence_issue_ids":[998409095,1527176268],"source_repo_name":"indestructible-type/Besley","source_issue_id":998409095,"source_issue_number":19,"source_issue_url":"https://github.com/indestructible-type/Besley/issues/19","target_repo_name":"indestructible-type/Besley","target_issue_id":1527176268,"target_issue_number":32,"target_issue_url":"https://github.com/indestructible-type/Besley/issues/32","reference_anchor_document_id":"gh_comment_1377117060","reference_answer_author":"ctrlcctrlv","reference_answer_author_association":"COLLABORATOR","quality_score":86.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1429},"issue_created_at":"2021-09-16T16:33:54+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_998409095","fragment_type":"issue_description","sequence":0,"text":"Add small caps æ and ø\nIf I download Besley* from URL I get an old version (1.8.3) which is useless in Norwegian because of the ø's. If I download from github I get version 2.000 which is equally useless for the same reason. But if I download from Google fonts I get version 2.001 which is perfect! This version is called Besley (without an asterisk) and contains no weight called fatface – but a «black» which looks very similiar. Will you update the fonts – at least in indestructibletype.com?","author_login":"sigurdhasle","author_association":"NONE","created_at":"2021-09-16T16:33:54+08:00","repo_name":"indestructible-type/Besley","issue_id":998409095,"issue_number":19,"issue_url":"https://github.com/indestructible-type/Besley/issues/19","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1377117060","fragment_type":"issue_comment","sequence":1,"text":"@sigurdhasle opened #32 which was quite rude and also a duplicate so I closed this but you forgot to add the substitutions to the lookup. I'll open a PR for it.","author_login":"ctrlcctrlv","author_association":"COLLABORATOR","created_at":"2023-01-10T11:29:46+08:00","repo_name":"indestructible-type/Besley","issue_id":998409095,"issue_number":19,"issue_url":"https://github.com/indestructible-type/Besley/issues/19","linked_issue_ids":[1527176268],"is_known_query_context":false},{"document_id":"gh_comment_1377616364","fragment_type":"issue_comment","sequence":2,"text":"I am sorry if you consider me a rude asshole. I opened a new issue because I was not aware that I could comment in a closed one. I am just frustrated that I cannot use the small caps: it still doesn't work for me. Do you have any idea why?\n\nI have downloaded and installed the files again today – they should not be old files.. The small caps Æ still looks like a lowercase æ – both in MainType and LibreOffice.","author_login":"sigurdhasle","author_association":"NONE","created_at":"2023-01-10T17:35:21+08:00","repo_name":"indestructible-type/Besley","issue_id":998409095,"issue_number":19,"issue_url":"https://github.com/indestructible-type/Besley/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1527176268","fragment_type":"issue_description","sequence":0,"text":"Add Æ and correct Ø to small caps\nWow! You fixed it – NOT! The small caps still need a bit of work. The æ's are _still_ just lowercase instead of small uppercase letters. The ø's should be the same shape and size as the o's, but with a slash through it. The slash should go throught the middle of the ring (the two crescents should be the same size). Slurv!\n\nimage","author_login":"sigurdhasle","author_association":"NONE","created_at":"2023-01-10T10:56:20+08:00","repo_name":"indestructible-type/Besley","issue_id":1527176268,"issue_number":32,"issue_url":"https://github.com/indestructible-type/Besley/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377080794","fragment_type":"issue_comment","sequence":1,"text":"Stop being such a rude asshole to Owen.\n\nHe did fix it.\n\nimage\n\nIt's possible he didn't update the TTF's distributed, or for some other reason, you're still using an old font. Making a duplicate issue instead of replying in the existing one with something nicer like \"it still doesn't work for me, any idea why?\" will get you a lot more traction.\n\nClosed.","author_login":"ctrlcctrlv","author_association":"COLLABORATOR","created_at":"2023-01-10T11:00:58+08:00","repo_name":"indestructible-type/Besley","issue_id":1527176268,"issue_number":32,"issue_url":"https://github.com/indestructible-type/Besley/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1377309868","fragment_type":"issue_comment","sequence":2,"text":"I am sorry if you consider me a rude asshole. I opened a new issue because I was not aware that I could comment in a closed one. I am just frustrated that I cannot use the small caps.\nI have downloaded and installed the files again today. The small caps Æ still looks like a lowercase æ.","author_login":"sigurdhasle","author_association":"NONE","created_at":"2023-01-10T13:46:39+08:00","repo_name":"indestructible-type/Besley","issue_id":1527176268,"issue_number":32,"issue_url":"https://github.com/indestructible-type/Besley/issues/32","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0306","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Update min LibCST version when it supports Python 3.9 relaxed decorator syntax?","query_context":"python\nwith (a() as b, c() as d):\n pass\n\n@(lambda f: f)\ndef g():\n pass\n\nis valid Python 3.9 syntax which triggers URL and, in `--refactor` mode, URL and URL Once these upstream bugs are fixed, we should:\n\n- [x] update the minimum version of Black\n- [x] update the minimum version of LibCST","known_context_document_ids":["gh_issue_896314972"],"reference_answer":"Progress update: I have a working CI job that produces binary wheels for LibCST with the new rust-based parser for any combination of python (3.6, 3.7, 3.8, 3.9, 3.10) & (macos x86_64, macos arm64, 32bit linux, 64bit linux, 32bit windows, 64bit windows).\n\nExample artifacts at URL (it's a zipfile with wheels in it).\nYou can `pip install` the relevant wheel from the zip on the above platforms and run\n\nLIBCST_PARSER_TYPE=native python -c 'import libcst; print(libcst.parse_module(\"foo(a, b)\"))'\n\nTo see the new parser in action. Note: match statement is not implemented yet in these.","answer_document_id":"gh_comment_996123089","silver_evidence_path":["gh_comment_1011485391","gh_issue_602426115","gh_comment_996123089"],"evidence_issue_ids":[896314972,602426115],"source_repo_name":"Zac-HD/shed","source_issue_id":896314972,"source_issue_number":18,"source_issue_url":"https://github.com/Zac-HD/shed/issues/18","target_repo_name":"Instagram/LibCST","target_issue_id":602426115,"target_issue_number":285,"target_issue_url":"https://github.com/Instagram/LibCST/issues/285","reference_anchor_document_id":"gh_comment_1011485391","reference_answer_author":"zsol","reference_answer_author_association":"MEMBER","quality_score":93.48,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0714,"anchor_target_overlap":0.3571,"target_answer_overlap":0.0952},"issue_created_at":"2021-05-20T05:56:22+08:00","valid_comment_count":28,"fragments":[{"document_id":"gh_issue_896314972","fragment_type":"issue_description","sequence":0,"text":"Update min LibCST version when it supports Python 3.9 relaxed decorator syntax\npython\nwith (a() as b, c() as d):\n pass\n\n@(lambda f: f)\ndef g():\n pass\n\nis valid Python 3.9 syntax which triggers URL and, in `--refactor` mode, URL and URL Once these upstream bugs are fixed, we should:\n\n- [x] update the minimum version of Black\n- [x] update the minimum version of LibCST","author_login":"Zac-HD","author_association":"OWNER","created_at":"2021-05-20T05:56:22+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1011485391","fragment_type":"issue_comment","sequence":1,"text":"Per URL an upcoming release will enable their new Rust-based parser for 3.10 & 3.11 grammar by default :tada: \n\n(maybe this will also make it faster?)","author_login":"Zac-HD","author_association":"OWNER","created_at":"2022-01-12T21:52:22+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[602426115],"is_known_query_context":false},{"document_id":"gh_comment_1013728638","fragment_type":"issue_comment","sequence":2,"text":"`black` also now supports 3.10+ syntax with patma / parenthesized with statements.","author_login":"isidentical","author_association":"CONTRIBUTOR","created_at":"2022-01-15T18:12:57+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1013989959","fragment_type":"issue_comment","sequence":3,"text":"Black now works, so we're just waiting for enabled-by-default `native` parser in libCST :tada:","author_login":"Zac-HD","author_association":"OWNER","created_at":"2022-01-17T00:24:57+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1110561759","fragment_type":"issue_comment","sequence":4,"text":"This all works now; we just need to add some tests and bump the minimum required version.","author_login":"Zac-HD","author_association":"OWNER","created_at":"2022-04-27T05:33:27+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114071515","fragment_type":"issue_comment","sequence":5,"text":"I tried adding a test to check for python 3.9 syntax but apparently libcst has not yet added syntax checking for this python version. python39syntax","author_login":"jpaniagua26","author_association":"NONE","created_at":"2022-04-30T23:25:48+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114071588","fragment_type":"issue_comment","sequence":6,"text":"I tried adding a test to check for python 3.9 syntax but apparently libcst has not yet added syntax checking for this python version. URL","author_login":"jpaniagua26","author_association":"NONE","created_at":"2022-04-30T23:26:29+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114071784","fragment_type":"issue_comment","sequence":7,"text":"I tried adding adding a test to check for python 3.9 syntax but it failed. Apparently libcst has not yet added syntax checking for this python version. URL","author_login":"jpaniagua26","author_association":"NONE","created_at":"2022-04-30T23:28:22+08:00","repo_name":"Zac-HD/shed","issue_id":896314972,"issue_number":18,"issue_url":"https://github.com/Zac-HD/shed/issues/18","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_602426115","fragment_type":"issue_description","sequence":0,"text":"3.10+ support\nPEP 617 (if it is accepted, and it probably will) is out and I'm wondering if LibCST's underlying parser is capable of parsing PEG grammar. With 3.10, the LL(1) restriction on the grammar will be deferred and this means that `lib2to3.pgen2` won't be able to parse new changes on the python grammar. I'm not sure about internals of LibCST but from what I have seen in readme that it uses something that bases on `lib2to3.pgen2`. Does LibCST will continue to support newer python versions and their grammar? (We are currently using lib2to3 as our refactoring tool on unimport but we might need to migrate another tool to support 3.10+ which is why I am asking)","author_login":"isidentical","author_association":"CONTRIBUTOR","created_at":"2020-04-18T10:15:26+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615966753","fragment_type":"issue_comment","sequence":1,"text":"I haven't discussed with the other maintainers yet, but here are some thoughts:\n\n1) My reading of the PEP is that it specifies that no LL(1)-incompatible change will be made to the language grammar until _after_ 3.10 is released. That gives us some time to adapt and should mean that supporting both 3.9 and 3.10 with the current LibCST parser will be straightforward, so this issue should probably be titled \"3.11+ support.\"\n\n2) In the long run I think we would want/need to rebase LibCST on top of a PEG parser in order to support Python grammar post-3.10. We will need to see how much of the code of the PEP 617 parser we can reuse for LibCST, given that we need syntactic trivia (whitespace, comments) and Python doesn't.","author_login":"carljm","author_association":"CONTRIBUTOR","created_at":"2020-04-18T22:38:35+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615967641","fragment_type":"issue_comment","sequence":2,"text":"Oops, looks like I mis-read the PEP. It seems the old parser will be removed in 3.10 and non-LL(1) constructs may be added then. So we will need to address this in order to support Python 3.10.","author_login":"carljm","author_association":"CONTRIBUTOR","created_at":"2020-04-18T22:42:36+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615968969","fragment_type":"issue_comment","sequence":3,"text":"Do you know a good PEG parser for python that also constructs a CST, I'm not much familiar with PEG :/","author_login":"isidentical","author_association":"NONE","created_at":"2020-04-18T22:48:02+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_615985808","fragment_type":"issue_comment","sequence":4,"text":"No, I doubt any such thing exists. We, or someone, would have to build it. I just sent a message to the python-dev thread about PEP 617 inquiring about the potential for reusing some of pegen (the new parser in PEP 617) for this: URL","author_login":"carljm","author_association":"CONTRIBUTOR","created_at":"2020-04-19T00:04:04+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_617493638","fragment_type":"issue_comment","sequence":5,"text":"It seems like one option would be to use URL as a starting point for a new Python 3.10 compatible parser.","author_login":"carljm","author_association":"CONTRIBUTOR","created_at":"2020-04-22T01:28:58+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_617678243","fragment_type":"issue_comment","sequence":6,"text":"Yes, that would be a great idea. If there is anything I can help you folks, just let me know.","author_login":"isidentical","author_association":"NONE","created_at":"2020-04-22T09:56:29+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_655713949","fragment_type":"issue_comment","sequence":7,"text":"I'm thinking about augmenting stdlib ast module to have some lib2to3 features (because lib2to3 is going away). If this is of interest to you:\n URL \n(No promises that I'll do the work of course, but I have high hopes)","author_login":"kamahen","author_association":"NONE","created_at":"2020-07-08T19:35:00+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_790703386","fragment_type":"issue_comment","sequence":8,"text":"This issue is a blocker for us:\n- We are trying to integrate `libcst` into `wemake-python-styleguide` which supports all versions from 3.6\n- We even have a PR ready: URL \n- But, since 3.9+ is not supported, we have to reconsider this idea\n- The same is true for several other projects of mine which potentially could use `libcst` for code auto-formatting 😞 \n\nAre there any updates? Is there anything I can help with?","author_login":"sobolevn","author_association":"NONE","created_at":"2021-03-04T15:32:24+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_847752718","fragment_type":"issue_comment","sequence":9,"text":"No updates yet apart from some of us hacking around on our spare time to get LibCST onto a peg parser. I'll update here as soon as work starts on this in earnest. I'm hoping for good news in a month or so.","author_login":"zsol","author_association":"MEMBER","created_at":"2021-05-25T10:30:10+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_868478609","fragment_type":"issue_comment","sequence":10,"text":"Good news! :) I'm working on this as part of my main job now. The current status is: in my branch there's a rust implementation of a peg parser for a small part of the python grammar, but complete with whitespace handling (thanks to the awesome work on whitespace parsing and tokenization by @bgw). It can successfully roundtrip simple functions like this without any extra string allocations (the built CST shares memory with the input source string), and it seems to be _real_ fast (it will be interesting to see if this holds as I add more and more of the grammar).\n\nI've opted for implementing the heavy lifting in Rust, and then expose the resulting CST as Python objects as part of a relatively high level interface that will be compatible with URL \nI'm hoping this will let us get significant speedups in both CPU and memory usage while being memory-safe.\n\nThere's still lots of work to do, for example:\n- better error messages\n- comprehensive testing\n- more grammar\n- wrap the API to be usable from Python\n\nI'll keep updating this issue as I go along","author_login":"zsol","author_association":"MEMBER","created_at":"2021-06-25T12:53:27+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_894699168","fragment_type":"issue_comment","sequence":11,"text":"Here's the current status of the rewrite: I think I have 99% of the Python 3.8 grammar implemented, and the parser can roundtrip (parse -> serialize losslessly; i.e. input bytes are same as output bytes) all of the LibCST python implementation (i.e. this repo). This is a big milestone but there's still some work to be done. But first, some details in case you want to play around:\n\nThe code currently lives still in URL you should be able to `cargo build` in that directory to get a debug build. This will put a binary called `parser` (`parser.exe` on Windows) in `target/debug/` which\n* accepts python code on stdin, then parses it into a CST and serializes it back onto stdout\n* optionally (when given the `-d` flag) dumps the internal CST representation before the generated source - this should look familiar if you've used `python -m libcst.tool print` before\n* if the first argument is `-n` it doesn't output anything (except parse errors), just parses the input\n\nHere's what I know still needs to be done:\n* [ ] wrap the API in a thin python layer to be usable from LibCST\n* [ ] hunt down bugs in the grammar by parsing all the python source code ever\n* [ ] implement missing grammar features like match statement, walrus, or parenthesis around `with` statements\n* [ ] there's a bug with whitespace parsing around the end of multiple nested indented blocks; this results in duplicate whitespace in certain situations - but not for any of the LibCST source code apparently\n* [ ] figure out how to make a LibCST release that can switch between the new and old parser backends\n* [ ] CI for the rust code\n\nAnd then on top of this it'd be nice to look into:\n* [ ] Perf optimizations. I haven't done any :)\n* [ ] Make the parser error-recoverable; that is, for a syntactically invalid Python document, try and produce _something_ that resembles a CST and is usable. This would be great for interactive use cases like IDE linting.\n* [ ] Improve the parser error messages. They are really basic at the moment, just outputting expected characters at the furthest parsed position.\n * [ ] There has been some great work in CPython recently around this front, and we should be able to port most of it over easily, if rust-peg can be enhanced to support early termination","author_login":"zsol","author_association":"MEMBER","created_at":"2021-08-07T19:44:07+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_896231816","fragment_type":"issue_comment","sequence":12,"text":"I've setup an example using github actions here: URL \n\nSample run: URL","author_login":"lpetre","author_association":"CONTRIBUTOR","created_at":"2021-08-10T18:50:18+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_986207026","fragment_type":"issue_comment","sequence":13,"text":"Hi, What is the advice for libraries that depend on this project? Can we expect 3.10 support in the near future of should people start looking for alternatives? It seems like Black has solved this with their lib2to3 fork.","author_login":"Luttik","author_association":"NONE","created_at":"2021-12-05T10:49:36+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_986208274","fragment_type":"issue_comment","sequence":14,"text":"I plan to release a version with opt-in 3.10 support by the end of the year. If that goes well, a new release in January will have 3.10 support by default.","author_login":"zsol","author_association":"MEMBER","created_at":"2021-12-05T10:58:15+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_996123089","fragment_type":"issue_comment","sequence":15,"text":"Progress update: I have a working CI job that produces binary wheels for LibCST with the new rust-based parser for any combination of python (3.6, 3.7, 3.8, 3.9, 3.10) & (macos x86_64, macos arm64, 32bit linux, 64bit linux, 32bit windows, 64bit windows).\n\nExample artifacts at URL (it's a zipfile with wheels in it).\nYou can `pip install` the relevant wheel from the zip on the above platforms and run\n\nLIBCST_PARSER_TYPE=native python -c 'import libcst; print(libcst.parse_module(\"foo(a, b)\"))'\n\nTo see the new parser in action. Note: match statement is not implemented yet in these.","author_login":"zsol","author_association":"MEMBER","created_at":"2021-12-16T19:39:08+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_996856581","fragment_type":"issue_comment","sequence":16,"text":"#566 proposes to merge the Rust-based parser. After merging I'll follow up with (much simpler) PRs to implement match statement, and parenthesized context managers.","author_login":"zsol","author_association":"MEMBER","created_at":"2021-12-17T16:31:02+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1011427731","fragment_type":"issue_comment","sequence":17,"text":"Note that for 3.10 (and 3.11) support, you still need to set `LIBCST_PARSER_TYPE=native` env var for now. We'll be removing this restriction in a future release (soon (tm)).","author_login":"zsol","author_association":"MEMBER","created_at":"2022-01-12T20:32:42+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1528408204","fragment_type":"issue_comment","sequence":18,"text":"- It's been a while - any plan for when the native parser will become the default?\n\n- I've discovered a fair few bugs while using it, and could take a day to do a more thorough search if there are resources to fix them. What's the maintenance status of libcst, and is this worth trying?","author_login":"Zac-HD","author_association":"CONTRIBUTOR","created_at":"2023-04-29T01:30:36+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1528646739","fragment_type":"issue_comment","sequence":19,"text":"- Unsure on when rust parser will become the default, but `export LIBCST_PARSER_TYPE=native` is ok for now.\n- I haven't faced any bugs in practice with libcst on the latest release. Can you mention what bugs? Have you created github issues for them?","author_login":"tusharsadhwani","author_association":"NONE","created_at":"2023-04-29T04:21:41+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1528652157","fragment_type":"issue_comment","sequence":20,"text":"- Yes, I have a workaround you can see in #917, but it's pretty ugly.\n- URL includes seven open bugs in the current version, all of which I hit in practice. In the last few months there's also #829, #846, #854, and #916.","author_login":"Zac-HD","author_association":"CONTRIBUTOR","created_at":"2023-04-29T04:45:46+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1563245203","fragment_type":"issue_comment","sequence":21,"text":"#929 is landing in a moment, after which I'll release it with a major version bump 🎉","author_login":"zsol","author_association":"MEMBER","created_at":"2023-05-25T17:13:40+08:00","repo_name":"Instagram/LibCST","issue_id":602426115,"issue_number":285,"issue_url":"https://github.com/Instagram/LibCST/issues/285","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0307","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Create a bidscrambler for EEG data in the BrainVision Core format?","query_context":"The BrainVision Core file format is one of the file formats for EEG data supported in BIDS. Compared to the EEGLAB file format (which is also supported), it is much simpler to read and write. Hence I propose that we first implement a scrambler for this format. \n\nOne EEG recording consists of an ascii `.vhdr` (header) and `.vmrk` (marker/events/trigger) file, plus a data file with the actual EEG data. The data file often has the extension `.eeg`, but that extension is not required. The data file name (including extension) is specified _inside_ the header file. \n\nBoth header and marker file resemble the windows-ini and the TOML file format. \n\nIn principle the data file can be either ASCII or binary, and either serialized or multiplexed (and all those files exist in the wild), but the formal 1.0 specification PDF prescribes that it must be multiplexed binary (which makes things much simpler).","known_context_document_ids":["gh_issue_2469996292"],"reference_answer":"Hi @schoffelen could you test the implemented scrambling of the BrainVision format EEG data? Starting from the original dataset of 2.4, you can use URL to make a BrainVision formatted version for some of the subjects, and then apply BIDScramble. Following scrambling of the EEG data (with the option `brainvision`, the code for that is in URL the EEG time series should contain random noise. It seems to work in my hands, so I hope that testing for you will be easy.","answer_document_id":"gh_comment_2522984199","silver_evidence_path":["gh_comment_2345198900","gh_issue_2515150307","gh_comment_2522984199"],"evidence_issue_ids":[2469996292,2515150307],"source_repo_name":"SIESTA-eu/wp15","source_issue_id":2469996292,"source_issue_number":28,"source_issue_url":"https://github.com/SIESTA-eu/wp15/issues/28","target_repo_name":"SIESTA-eu/wp15","target_issue_id":2515150307,"target_issue_number":31,"target_issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","reference_anchor_document_id":"gh_comment_2345198900","reference_answer_author":"robertoostenveld","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.303},"issue_created_at":"2024-08-16T10:36:58+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2469996292","fragment_type":"issue_description","sequence":0,"text":"Create a bidscrambler for EEG data in the BrainVision Core format\nThe BrainVision Core file format is one of the file formats for EEG data supported in BIDS. Compared to the EEGLAB file format (which is also supported), it is much simpler to read and write. Hence I propose that we first implement a scrambler for this format. \n\nOne EEG recording consists of an ascii `.vhdr` (header) and `.vmrk` (marker/events/trigger) file, plus a data file with the actual EEG data. The data file often has the extension `.eeg`, but that extension is not required. The data file name (including extension) is specified _inside_ the header file. \n\nBoth header and marker file resemble the windows-ini and the TOML file format. \n\nIn principle the data file can be either ASCII or binary, and either serialized or multiplexed (and all those files exist in the wild), but the formal 1.0 specification PDF prescribes that it must be multiplexed binary (which makes things much simpler).","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-08-16T10:36:58+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2469996292,"issue_number":28,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/28","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2293338022","fragment_type":"issue_comment","sequence":1,"text":"To remind myself: MNE python relies on URL for their (somewhat limited, i.e. it does not support a round trip in reading and writing) Brainvision IO","author_login":"schoffelen","author_association":"COLLABORATOR","created_at":"2024-08-16T11:31:29+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2469996292,"issue_number":28,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2345198900","fragment_type":"issue_comment","sequence":2,"text":"Note that this issue was duplicated in #31 and has been implemented with pull request #32","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-09-12T03:33:54+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2469996292,"issue_number":28,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/28","linked_issue_ids":[2515150307],"is_known_query_context":false},{"document_id":"gh_issue_2515150307","fragment_type":"issue_description","sequence":0,"text":"Implement scrambling of EEG data for use case 2.4\n@marcelzwiers @schoffelen @arnodelorme @CPernet \n\nFor your information, I am working on the implementation of the BrainVision Core data format in the BIDScramble. The EEGLAB `.set` format is too complex for now, but the data in use case 2.4 can be converted (using FieldTrip) from EEGLAB to BrainVision format without compromising the analysis pipeline. \n\nAs the [pybv]( URL reader was a bit of a mess with regards to dependencies and not symmetric in reading and writing, I implemented my own BrainVision read and write package. See URL I will make sure that this gets added to pypi to allow installation with pip.","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-09-10T00:18:20+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2339568887","fragment_type":"issue_comment","sequence":1,"text":"The BrainVision code is now on PyPi at URL \n\nI implemented an automatic release \"action\" following the instructions at URL","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-09-10T04:09:44+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378634877","fragment_type":"issue_comment","sequence":2,"text":"As discussed with @CPernet we need to come up with a few thought-through meaningful scrambling options for MEEG data, beyond time series scrambling. Let's reopen this issue to bounce ideas back and forth.\n\nWe probably need to have 2 or 3 additional ways to break the spatio/temporal/spectral structure in the data.\n\nI am currently thinking about a combination of spatial filtering and blockwise scrambling. For ERP'ish application this probably also would need to take the structure of the events into account.\n\nSpecifically, using spatial unmixing (based on 'some' heuristic), then a scrambling step (e.g. scrambling the order of the latent components and/or blockwise scrambling (i.e. keeping the overall spectral structure in the data, and/or time-locked to event stuff), then again a spatial mixing step, would be a flexible framework that allows for a mixture of spatiotemporal scrambling, preserving aspects of the overall structure in the data","author_login":"schoffelen","author_association":"COLLABORATOR","created_at":"2024-09-27T07:49:07+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2382445354","fragment_type":"issue_comment","sequence":3,"text":"I agree that within the ICA framework, one is likely able to mess stuff up different ways (after characterizing the evoked and spectral aspects id IC). I also agree (as discussed on line) that often the pipeline will be something like 'can want to see if the pipeline can detect X', so the feature of interest needs somehow to be present.\n \n- one could play with the weight matrix ?? maybe as a way to 'remove' known sensitive attributes (not something I'd do by default, but if a data control right holder indicates an aspect that needs nullifying, this can be a way)\n- specific IC could be made noisier adding pink noise or a sin where evoked response is (say found IC with spectral / evoked response, ie increase energy following events anytime from 50 to 1000ms, no need to be specific IMO -then add, it exist tools for simulations I used that can be leveraged for that)\n- total randomness, chunk time courses based on autocorrelation size (to keep main spectral, autocorrelation) and exchange within/between IC and remix\n\nnot sure all makes sense, but putting some ideas down ...","author_login":"CPernet","author_association":"COLLABORATOR","created_at":"2024-09-30T08:28:44+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2522984199","fragment_type":"issue_comment","sequence":4,"text":"Hi @schoffelen could you test the implemented scrambling of the BrainVision format EEG data? Starting from the original dataset of 2.4, you can use URL to make a BrainVision formatted version for some of the subjects, and then apply BIDScramble. Following scrambling of the EEG data (with the option `brainvision`, the code for that is in URL the EEG time series should contain random noise. It seems to work in my hands, so I hope that testing for you will be easy.","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-12-06T11:38:02+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2527777631","fragment_type":"issue_comment","sequence":5,"text":"I can confirm that the scrambler for brainvision data works.\n\nThe current default is nulling, but when I add the \npermute\n as a method, the data are nicely permuted, confirmed by visualizing the time series of a given channel, and by comparing the histograms of the amplitudes of the scrambled and non-scrambled versions. \n\nOne additional observation I had, is that I need to specify \ncfg.readbids='no'\n in order to load the scrambled data into matlab (using \nft_preprocessing\n). The reason for this seems to be that that scrambling (I did a two step approach with:\n\nscramble in out stub \nscramble in out brainvisino permute\n\nresulted in a dataset with empty run-specific json files, causing fieldtrip to choke)","author_login":"schoffelen","author_association":"COLLABORATOR","created_at":"2024-12-09T12:21:31+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2528313816","fragment_type":"issue_comment","sequence":6,"text":"Would those be the `eeg.json` files that are empty? I believe that empty run-specific json files are not BIDS compliant, which means that BIDScramble has a bug.","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-12-09T15:18:27+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2536222116","fragment_type":"issue_comment","sequence":7,"text":"Considering my previous comment: upon rereading the documentation I suspect that scramble should also have been called with the `json` action. The `stub` action creates the empty files, the `json` action allows copying json file content over (with or without modifications).\n\nThe use case specific scramble instructions should be updated/completed/reviewed. I'll make a new issue for that.","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-12-11T14:54:10+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[2515150307],"is_known_query_context":false},{"document_id":"gh_comment_2536338109","fragment_type":"issue_comment","sequence":8,"text":"Is there any documentation on empty json-files being non-compliant? Because I think there is nothing wrong with that (it's not desirable, but also not wrong))","author_login":"marcelzwiers","author_association":"COLLABORATOR","created_at":"2024-12-11T15:36:58+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2536456311","fragment_type":"issue_comment","sequence":9,"text":"Yes, as I wrote in this comment I also think it is a user error. Some of the json files should have been copied over with `--preserve`, as those are needed for processing. \n\nI am surprised that you write that scrambled data can never be BIDS compliant. Why not? In general - with the proper options - I think that the scrambled data would onl;y have different numbers, not a different structure. If not compliant, I don't think that strict BIDS apps like MRIQC will even work on the scrambled data.","author_login":"robertoostenveld","author_association":"COLLABORATOR","created_at":"2024-12-11T16:20:46+08:00","repo_name":"SIESTA-eu/wp15","issue_id":2515150307,"issue_number":31,"issue_url":"https://github.com/SIESTA-eu/wp15/issues/31","linked_issue_ids":[2515150307],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0308","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"DenoisedPathTracer does not appear as an option in the Renderer drop-down menu?","query_context":"As stated. It is just not there. I got two other options though - ALBEDO and NORMAL. I have no idea what to do with this.","known_context_document_ids":["gh_issue_1659169861"],"reference_answer":"The README that you read is for a WIP newer version of the plugin that is not yet released. The `DenoisedPathTracer` is not in the 0.4.0 version of the plugin. This README is for the 0.4.0 version of the Denoiser plugin.","answer_document_id":"gh_comment_1384481575","silver_evidence_path":["gh_comment_1500711719","gh_issue_1535398278","gh_comment_1384481575"],"evidence_issue_ids":[1659169861,1535398278],"source_repo_name":"chunky-dev/chunky-denoiser","source_issue_id":1659169861,"source_issue_number":39,"source_issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/39","target_repo_name":"chunky-dev/chunky-denoiser","target_issue_id":1535398278,"target_issue_number":37,"target_issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/37","reference_anchor_document_id":"gh_comment_1500711719","reference_answer_author":"Peregrine05","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2857,"target_answer_overlap":0.4545},"issue_created_at":"2023-04-07T20:38:04+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1659169861","fragment_type":"issue_description","sequence":0,"text":"DenoisedPathTracer does not appear as an option in the Renderer drop-down menu\nAs stated. It is just not there. I got two other options though - ALBEDO and NORMAL. I have no idea what to do with this.","author_login":"Faandyy","author_association":"NONE","created_at":"2023-04-07T20:38:04+08:00","repo_name":"chunky-dev/chunky-denoiser","issue_id":1659169861,"issue_number":39,"issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/39","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1500711719","fragment_type":"issue_comment","sequence":1,"text":"Unline the member in question, I do not get denoised images in my snapshots folder.","author_login":"Faandyy","author_association":"NONE","created_at":"2023-04-07T23:04:16+08:00","repo_name":"chunky-dev/chunky-denoiser","issue_id":1659169861,"issue_number":39,"issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/39","linked_issue_ids":[1535398278],"is_known_query_context":false},{"document_id":"gh_comment_1500712606","fragment_type":"issue_comment","sequence":2,"text":"Have you downloaded OIDN and set it up according to the instructions?\n URL \n\nIf so, have you rendered to the Target SPP?","author_login":"Peregrine05","author_association":"MEMBER","created_at":"2023-04-07T23:06:06+08:00","repo_name":"chunky-dev/chunky-denoiser","issue_id":1659169861,"issue_number":39,"issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1500714003","fragment_type":"issue_comment","sequence":3,"text":"Sorry, my bad, I just looked some more and it is there. Just very confused about the whole thing.","author_login":"Faandyy","author_association":"NONE","created_at":"2023-04-07T23:09:25+08:00","repo_name":"chunky-dev/chunky-denoiser","issue_id":1659169861,"issue_number":39,"issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/39","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1535398278","fragment_type":"issue_description","sequence":0,"text":"`DenoisedPathTracer` missing from Advanced tab\nThe `ALBEDO` and `NORMAL` renderers show up alongside the default `PathTracingRenderer`, but `DenoisedPathTracer` (mentioned in the readme) is nowhere to be seen.\n\nobrazek\n\nHowever, denoising still works (probably) as intended, since the render process starts out by first rendering the normal and albedo passes before anything else, and the denoised image *can* be found in the scene's `snapshots` folder:\n\nobrazek\n\n- Chunky version: 2.4.4\n- Denoiser Plugin version: 0.4.0\n- OIDN package: oidn-1.4.3.x64.vc14.windows\n- Java version: 17.0.1.12 (Adoptium JDK)\n- JavaFX SDK version: 18.0.2\n- OS: Windows 10 Home x64 v1909 (build 18363.1556)","author_login":"Matojeje","author_association":"NONE","created_at":"2023-01-16T19:29:32+08:00","repo_name":"chunky-dev/chunky-denoiser","issue_id":1535398278,"issue_number":37,"issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1384481575","fragment_type":"issue_comment","sequence":1,"text":"The README that you read is for a WIP newer version of the plugin that is not yet released. The `DenoisedPathTracer` is not in the 0.4.0 version of the plugin. This README is for the 0.4.0 version of the Denoiser plugin.","author_login":"Peregrine05","author_association":"MEMBER","created_at":"2023-01-16T19:45:46+08:00","repo_name":"chunky-dev/chunky-denoiser","issue_id":1535398278,"issue_number":37,"issue_url":"https://github.com/chunky-dev/chunky-denoiser/issues/37","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0309","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"FkProducer.java:12: Fake Producer implementation?","query_context":"The puzzle `10-404e50f4` from #10 has to be resolved: \n\n URL \n\nThe puzzle was created by @h1alexbel on 24-Feb-23. \n\nEstimate: 45 minutes, role: DEV. \n\nIf you have any technical questions, don't ask me, submit new tickets instead. The task will be \\\"done\\\" when the problem is fixed and the text of the puzzle is _removed_ from the source code. Here is more about PDD and about me.","known_context_document_ids":["gh_issue_1598853645"],"reference_answer":"@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is ``2023-06-22T20:09:04.176448``.\n\nEstimation here is ``60 minutes``, that's how much you will be paid.\n\nRemember, you don't have to solve everything in this ticket - you can solve it partially and leave ``todo`` markers in the code, which will become future tasks.\n\nIf you have any questions don't ask me, I'm not a technical person. Open new tickets instead.\n\nIf you don't have time or simply don't want to work on this, you can always resign.","answer_document_id":"gh_comment_1588019589","silver_evidence_path":["gh_comment_1589384089","gh_issue_1753094223","gh_comment_1588019589"],"evidence_issue_ids":[1598853645,1753094223],"source_repo_name":"eo-cqrs/eo-kafka","source_issue_id":1598853645,"source_issue_number":44,"source_issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/44","target_repo_name":"eo-cqrs/eo-kafka","target_issue_id":1753094223,"target_issue_number":364,"target_issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","reference_anchor_document_id":"gh_comment_1589384089","reference_answer_author":"zoeself","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.25,"target_answer_overlap":0.2973},"issue_created_at":"2023-02-24T15:30:46+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1598853645","fragment_type":"issue_description","sequence":0,"text":"FkProducer.java:12: Fake Producer implementation\nThe puzzle `10-404e50f4` from #10 has to be resolved: \n\n URL \n\nThe puzzle was created by @h1alexbel on 24-Feb-23. \n\nEstimate: 45 minutes, role: DEV. \n\nIf you have any technical questions, don't ask me, submit new tickets instead. The task will be \\\"done\\\" when the problem is fixed and the text of the puzzle is _removed_ from the source code. Here is more about PDD and about me.","author_login":"0pdd","author_association":"COLLABORATOR","created_at":"2023-02-24T15:30:46+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1598853645,"issue_number":44,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/44","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1449932090","fragment_type":"issue_comment","sequence":1,"text":"The fake producer can be built using an in-memory XML sheet.\n\nxml\n \n \n \n 1 \n org.apache.kafka.common.serialization.StringSerializer \n org.apache.kafka.common.serialization.StringSerializer \n \n \n \n 1 \n \n name \n 1 \n key-0 \n \n \n \n 2 \n \n name2 \n 3 \n key-1 \n \n \n \n \n\nOn each \nsend\n method execution new chunk will be added. But where to store this file with initial values? So far, I don't know","author_login":"h1alexbel","author_association":"MEMBER","created_at":"2023-03-01T11:22:09+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1598853645,"issue_number":44,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/44","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1589384089","fragment_type":"issue_comment","sequence":2,"text":"@0pdd 2 puzzles #292, #293 are still not solved; solved: #364.","author_login":"0pdd","author_association":"COLLABORATOR","created_at":"2023-06-13T14:03:50+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1598853645,"issue_number":44,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/44","linked_issue_ids":[1753094223],"is_known_query_context":false},{"document_id":"gh_comment_1591441542","fragment_type":"issue_comment","sequence":3,"text":"@0pdd the puzzle #373 is still not solved; solved: #292, #293, #364.","author_login":"0pdd","author_association":"COLLABORATOR","created_at":"2023-06-14T15:13:53+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1598853645,"issue_number":44,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/44","linked_issue_ids":[1753094223],"is_known_query_context":false},{"document_id":"gh_comment_1592654746","fragment_type":"issue_comment","sequence":4,"text":"@0pdd all 4 puzzles are solved here: #292, #293, #364, #373.","author_login":"0pdd","author_association":"COLLABORATOR","created_at":"2023-06-15T09:04:24+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1598853645,"issue_number":44,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/44","linked_issue_ids":[1753094223],"is_known_query_context":false},{"document_id":"gh_issue_1753094223","fragment_type":"issue_description","sequence":0,"text":"FkBroker.java:29-31: Broker has too many methods We...\nThe puzzle `292-fab4489f` from #292 has to be resolved: \n\n URL \n\nThe puzzle was created by @h1alexbel on 12-Jun-23. \n\nEstimate: 60 minutes, role: DEV. \n\nIf you have any technical questions, don't ask me, submit new tickets instead. The task will be \\\"done\\\" when the problem is fixed and the text of the puzzle is _removed_ from the source code. Here is more about PDD and about me.","author_login":"0pdd","author_association":"COLLABORATOR","created_at":"2023-06-12T16:11:50+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1753094223,"issue_number":364,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1587646117","fragment_type":"issue_comment","sequence":1,"text":"@0pdd thank you for reporting this. I'll assign someone to take care of it soon.","author_login":"zoeself","author_association":"COLLABORATOR","created_at":"2023-06-12T16:11:53+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1753094223,"issue_number":364,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1587658006","fragment_type":"issue_comment","sequence":2,"text":"@l3r8yJ this is your task now, please go ahead. Deadline (when this ticket should be closed) is ``2023-06-22T16:19:05.771309``.\n\nEstimation here is ``60 minutes``, that's how much you will be paid.\n\nRemember, you don't have to solve everything in this ticket - you can solve it partially and leave ``todo`` markers in the code, which will become future tasks.\n\nIf you have any questions don't ask me, I'm not a technical person. Open new tickets instead.\n\nIf you don't have time or simply don't want to work on this, you can always resign.","author_login":"zoeself","author_association":"COLLABORATOR","created_at":"2023-06-12T16:20:17+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1753094223,"issue_number":364,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588007523","fragment_type":"issue_comment","sequence":3,"text":"@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.","author_login":"zoeself","author_association":"COLLABORATOR","created_at":"2023-06-12T20:04:45+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1753094223,"issue_number":364,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588010955","fragment_type":"issue_comment","sequence":4,"text":"@h1alexbel I've just registered this ticket as a task and will assign it to someone soon. Thanks!","author_login":"zoeself","author_association":"COLLABORATOR","created_at":"2023-06-12T20:05:25+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1753094223,"issue_number":364,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588019589","fragment_type":"issue_comment","sequence":5,"text":"@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is ``2023-06-22T20:09:04.176448``.\n\nEstimation here is ``60 minutes``, that's how much you will be paid.\n\nRemember, you don't have to solve everything in this ticket - you can solve it partially and leave ``todo`` markers in the code, which will become future tasks.\n\nIf you have any questions don't ask me, I'm not a technical person. Open new tickets instead.\n\nIf you don't have time or simply don't want to work on this, you can always resign.","author_login":"zoeself","author_association":"COLLABORATOR","created_at":"2023-06-12T20:10:17+08:00","repo_name":"eo-cqrs/eo-kafka","issue_id":1753094223,"issue_number":364,"issue_url":"https://github.com/eo-cqrs/eo-kafka/issues/364","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0310","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"switch-input-source-backward need to be handled as well, in addition to switch-input-source?","query_context":"1) The \"switch-input-source-backward\" binding should be handled in addition to \"switch-input-source\".\n\nYou can see it using next command line output:\n\n gsettings list-recursively org.gnome.desktop.wm.keybindings|grep switch-input \n\nBy default Super+Space switches layout forward, while Super+Shift+Space switches it backward.\nSuppressing of the popup window works for \"forward\" switching at the moment, while Super+Shift+Space still shows the popup.\n\nIt also can be reproduced using next command line settings for Ctrl+Shift switch:\n\n gsettings set org.gnome.desktop.wm.keybindings switch-input-source \"[' Ctrl_L']\" \n gsettings set org.gnome.desktop.wm.keybindings switch-input-source-backward \"[' Shift_L']\" \n \nor next ones for Alt+Shift keystroke:\n\n gsettings set org.gnome.desktop.wm.keybindings switch-input-source \"[' Alt_L']\" \n gsettings set org.gnome.desktop.wm.keybindings switch-input-source-backward \"[' Shift_L']\" \n\nThat way Ctrl+Shift or Alt+Shift keystroke will act just like it works in Windows, but the popup window will still appear for each second Ctrl+Shift or Alt+Shift stroke from time to time (not each time though).\n\n2) Also it would be nice to integrate that Ctrl_L and Shift_L (or Alt_L and Shift_L) hack somewhere in plugin settings as option, because it's not obvious how to obtain Windows like keyboard layout switching \"out of the box\". \nThe default Super+Space combination is not so \"quick\" as for me.","known_context_document_ids":["gh_issue_1511165170"],"reference_answer":"I can't reproduce :-( \nAt least not when tested on _Wayland_.\nAlso tested with AND without a custom key bound to the switching.","answer_document_id":"gh_comment_1656991037","silver_evidence_path":["gh_comment_1372802559","gh_issue_1521435240","gh_comment_1656991037"],"evidence_issue_ids":[1511165170,1521435240],"source_repo_name":"ankostis/gnome-shell-quick-lang-switch","source_issue_id":1511165170,"source_issue_number":4,"source_issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/4","target_repo_name":"ankostis/gnome-shell-quick-lang-switch","target_issue_id":1521435240,"target_issue_number":5,"target_issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/5","reference_anchor_document_id":"gh_comment_1372802559","reference_answer_author":"ankostis","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1014,"anchor_target_overlap":0.1042,"target_answer_overlap":0.125},"issue_created_at":"2022-12-26T19:05:57+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_1511165170","fragment_type":"issue_description","sequence":0,"text":"switch-input-source-backward need to be handled as well, in addition to switch-input-source\n1) The \"switch-input-source-backward\" binding should be handled in addition to \"switch-input-source\".\n\nYou can see it using next command line output:\n\n gsettings list-recursively org.gnome.desktop.wm.keybindings|grep switch-input \n\nBy default Super+Space switches layout forward, while Super+Shift+Space switches it backward.\nSuppressing of the popup window works for \"forward\" switching at the moment, while Super+Shift+Space still shows the popup.\n\nIt also can be reproduced using next command line settings for Ctrl+Shift switch:\n\n gsettings set org.gnome.desktop.wm.keybindings switch-input-source \"[' Ctrl_L']\" \n gsettings set org.gnome.desktop.wm.keybindings switch-input-source-backward \"[' Shift_L']\" \n \nor next ones for Alt+Shift keystroke:\n\n gsettings set org.gnome.desktop.wm.keybindings switch-input-source \"[' Alt_L']\" \n gsettings set org.gnome.desktop.wm.keybindings switch-input-source-backward \"[' Shift_L']\" \n\nThat way Ctrl+Shift or Alt+Shift keystroke will act just like it works in Windows, but the popup window will still appear for each second Ctrl+Shift or Alt+Shift stroke from time to time (not each time though).\n\n2) Also it would be nice to integrate that Ctrl_L and Shift_L (or Alt_L and Shift_L) hack somewhere in plugin settings as option, because it's not obvious how to obtain Windows like keyboard layout switching \"out of the box\". \nThe default Super+Space combination is not so \"quick\" as for me.","author_login":"alexandrustinov","author_association":"NONE","created_at":"2022-12-26T19:05:57+08:00","repo_name":"ankostis/gnome-shell-quick-lang-switch","issue_id":1511165170,"issue_number":4,"issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/4","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1365455613","fragment_type":"issue_comment","sequence":1,"text":"1. I'm not surprised that i hadn't handled also the shift(backwards) case, i didn't know this command existed. But I'm surprised that no one ever reported it.\n2. Will fix it. \n\n3. I don't know the Ctrl_L hacks? Can you give me some hints, or an merge request?","author_login":"ankostis","author_association":"OWNER","created_at":"2022-12-26T21:01:00+08:00","repo_name":"ankostis/gnome-shell-quick-lang-switch","issue_id":1511165170,"issue_number":4,"issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1365477010","fragment_type":"issue_comment","sequence":2,"text":"1. I suppose that the backward switch is rarely (never) used because most of users just cycle between native and English language, it's enough to press Super+Space for that\n2. TA in advance\n3. In short - it's not possible to assign Ctrl+Shift or Alt+Shift as language switch sequence using Gnome Settings tool. \nMeanwhile it's possible to do that using Gnome Tweaks Utility (it has Keyboard & Mouse > Additional Layout options > Switching to another layout > [ ] Ctrl+Shift checkbox). \nIt will work, though it will be not possible to see changing in status bar icon, it will always show 'en' (Centos Stream 9 / Gnome Standard Wayland, other distros also seems are affected).\n\nAs workaround it's possible to execute the next commands from command line (I mentioned them above), after that keyboard layout switch will work as expected and the icon in status bar will change accordingly:\n\n gsettings set org.gnome.desktop.wm.keybindings switch-input-source \"[' Ctrl_L']\" \n gsettings set org.gnome.desktop.wm.keybindings switch-input-source-backward \"[' Shift_L']\" \n\nI initially found the gsettings hack here URL \nsorry for the Russian text, but it could be autotranslated using Google Chrome Translate option.\n\nAlso next link might explain the same issue better:\n URL \n\nThat way I found existence of switch-input-source-backward and faced with the popup which had to be suppressed by your plugin.\n\nSo it will be great to create small setup dialog for your plugin which will allow to choose proper settings for language switcher (default Super+Space, Ctrl+Shift, Alt+Shift or PrtSc/SysRq) . \nI would raise PR from my side though I never developed the GNOME extensions, it will take some time to deep-in there.","author_login":"alexandrustinov","author_association":"NONE","created_at":"2022-12-26T21:44:30+08:00","repo_name":"ankostis/gnome-shell-quick-lang-switch","issue_id":1511165170,"issue_number":4,"issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/4","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1372802559","fragment_type":"issue_comment","sequence":3,"text":"I've made a quick patch adding new const for \"switch-input-source-backward\" shortcut and duplicating code for \"\"switch-input-source\". I didn't add \"disable\" part because of issue #5 \n\n--- extension.js\n+++ extension.js\n@@ -26,6 +26,7 @@\n const { Gio, Meta, Shell } = imports.gi\n const Main = imports.ui.main;\n const SWITCH_SHORTCUT_NAME = 'switch-input-source'\n+const SWITCH_BACK_SHORTCUT_NAME = 'switch-input-source-backward'\n const InputSourceManager = imports.ui.status.keyboard.getInputSourceManager();\n \n class Extension {\n@@ -35,10 +36,16 @@\n enable() {\n log(`enabling extension '${Me.metadata.name}': bypassing language switcher popup.`);\n Main.wm.removeKeybinding(SWITCH_SHORTCUT_NAME);\n+ Main.wm.removeKeybinding(SWITCH_BACK_SHORTCUT_NAME);\n Main.wm.addKeybinding(SWITCH_SHORTCUT_NAME,\n new Gio.Settings({ schema_id: \"org.gnome.desktop.wm.keybindings\" }),\n Meta.KeyBindingFlags.NONE,\n Shell.ActionMode.ALL,\n+ this._quickSwitch);\n+ Main.wm.addKeybinding(SWITCH_BACK_SHORTCUT_NAME,\n+ new Gio.Settings({ schema_id: \"org.gnome.desktop.wm.keybindings\" }),\n+ Meta.KeyBindingFlags.NONE,\n+ Shell.ActionMode.ALL,\n this._quickSwitch);\n }\n\n \nTo apply this patch you need to perform such actions in a Terminal\n1) Go to extension directory\n`cd \"~/.local/share/gnome-shell/extensions/quick-lang-switch@ankostis.gmail.com/\"`\n2) Create patch file\n`nano disable--switch-input-source-backwards.patch`\n3) Paste content of the patch (above) with right mouse click (or Ctrl+Shift+V) and save it with Ctrl+S\n3) Apply patch (and backup original file as extension.js.orig)\n`patch -b < disable--switch-input-source-backwards.patch`","author_login":"Alt37","author_association":"NONE","created_at":"2023-01-05T21:31:59+08:00","repo_name":"ankostis/gnome-shell-quick-lang-switch","issue_id":1511165170,"issue_number":4,"issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/4","linked_issue_ids":[1521435240],"is_known_query_context":false},{"document_id":"gh_issue_1521435240","fragment_type":"issue_description","sequence":0,"text":"Switcher popup breaks after disabling the extension (needs gnome-shell restart)\nOS: Ubuntu 22.04.1\nGNOME: 42.5\nSession: X11\n\nSteps to reproduce (with default key-binding + Space):\n1) Enable, then disable extension without gnome-shell restart\n2) Try to hold \"Super\" and press \"Space\" multiple times\n\nExpected result:\nWhile you're holding \"Super\" pop-up remains on the screen and you can switch languages with \"Space\"\n\nActual Result:\nPop-up disappears immediately after you've pressed \"Space\" the second time.","author_login":"xalt7x","author_association":"CONTRIBUTOR","created_at":"2023-01-05T21:14:36+08:00","repo_name":"ankostis/gnome-shell-quick-lang-switch","issue_id":1521435240,"issue_number":5,"issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/5","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1656991037","fragment_type":"issue_comment","sequence":1,"text":"I can't reproduce :-( \nAt least not when tested on _Wayland_.\nAlso tested with AND without a custom key bound to the switching.","author_login":"ankostis","author_association":"OWNER","created_at":"2023-07-30T01:35:22+08:00","repo_name":"ankostis/gnome-shell-quick-lang-switch","issue_id":1521435240,"issue_number":5,"issue_url":"https://github.com/ankostis/gnome-shell-quick-lang-switch/issues/5","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0311","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"J2objc 3.0.0 and JDK 17?","query_context":"Hello J2OBJC team,\nI am new to J2OBJC. I saw that there was version 3.0 but it seems it is not an official release. I have two questions below:\n1. Does j2objc 3.0.0 support Java JDK 17?\n2. When will there be an official release?\n\nDeveloping and maintaining J2OBJC is a great thing, thank you for your effort. I am looking forward to your response.","known_context_document_ids":["gh_issue_2325110356"],"reference_answer":"That's tough to answer with a yes or no, as there are really three questions with this one:\n\n1. Does j2objc support all Java 17 language features?\n2. Does j2objc support new Java 17 JRE API?\n3. Does j2objc run on Java 17?\n\n1) AFAIK, j2objc supports the latest language features, like text blocks and switch expression statements. Much of that support is free, because j2objc uses javac as its front-end; for example, javac converts text blocks into regular strings, so j2objc didn't need to be updated to support that feature.\n\n2) No, J2ObjC's JRE is a fork of Android's libcore library (its JRE), so if it's not available in Android, it's not available on iOS. That's intentional, as the purpose of J2ObjC is to support shared Java across an app's clients, not to be a complete Java platform (that's why we don't/can't call it \"Java\").\n\n3) No, because the javac team (see 1)) keeps changing access to its packages. So it works on Java 11, but it is currently broken on Java 17 until someone fixes the necessary flags (contributions welcome!).\n\nThe Android Gradle Plugin should be able to run command-line tools like j2objc in a separate shell (and likely already does). So try installing both Java 17 and Java 11 on your system, with the j2objc action defined by the flags in the j2objc.sh script. That script is also where the flags aren't correct for Java 17, so if you can fix them, great!","answer_document_id":"gh_comment_1552066470","silver_evidence_path":["gh_comment_2639265205","gh_issue_1714092926","gh_comment_1552066470"],"evidence_issue_ids":[2325110356,1714092926],"source_repo_name":"google/j2objc","source_issue_id":2325110356,"source_issue_number":2345,"source_issue_url":"https://github.com/google/j2objc/issues/2345","target_repo_name":"google/j2objc","target_issue_id":1714092926,"target_issue_number":2095,"target_issue_url":"https://github.com/google/j2objc/issues/2095","reference_anchor_document_id":"gh_comment_2639265205","reference_answer_author":"tomball","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.375,"target_answer_overlap":0.2667},"issue_created_at":"2024-05-30T08:49:08+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2325110356","fragment_type":"issue_description","sequence":0,"text":"J2objc 3.0.0 and JDK 17\nHello J2OBJC team,\nI am new to J2OBJC. I saw that there was version 3.0 but it seems it is not an official release. I have two questions below:\n1. Does j2objc 3.0.0 support Java JDK 17?\n2. When will there be an official release?\n\nDeveloping and maintaining J2OBJC is a great thing, thank you for your effort. I am looking forward to your response.","author_login":"v-thien","author_association":"NONE","created_at":"2024-05-30T08:49:08+08:00","repo_name":"google/j2objc","issue_id":2325110356,"issue_number":2345,"issue_url":"https://github.com/google/j2objc/issues/2345","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2140031937","fragment_type":"issue_comment","sequence":1,"text":"We stopped distributing release bundles for two reasons. First, with the new Apple-related architectures and added JRE features, release bundles have been too big to upload to GitHub for years now. Second, developers want the latest features and bug fixes within days of their being committed to our repo, so most projects build j2objc from HEAD. We realized that j2objc is best suited for large, multi-platform app builds, and those teams wisely demand full control over what's in the apps. So between customer priorities and GitHub limits, releases no longer make sense.\n\nThe reason for the 3.0.0 tag is because we distribute the annotations jar via Maven, since Google Guava depends upon it. The last time we added an annotation that the Guava team used, we had to bump up our jar's version number.\n \n\nNo, but our latest source builds with JDK 17. However, our biggest clients are still on Java 11, so it hasn't been tested as thoroughly. You can use post-Java11 features that are implemented by javac, like switch expressions, text blocks, and pattern matching for instanceof. Features requiring JRE updates, like Records, are not yet supported.","author_login":"tomball","author_association":"COLLABORATOR","created_at":"2024-05-30T15:52:30+08:00","repo_name":"google/j2objc","issue_id":2325110356,"issue_number":2345,"issue_url":"https://github.com/google/j2objc/issues/2345","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2639265205","fragment_type":"issue_comment","sequence":2,"text":"@tomball: Good to see that J2ObjC now builds with JDK 17 👍 I'll try it soon and update #2095 and the Requirements section of the root-level README file if it works.","author_login":"adil-hussain-84","author_association":"CONTRIBUTOR","created_at":"2025-02-06T09:27:23+08:00","repo_name":"google/j2objc","issue_id":2325110356,"issue_number":2345,"issue_url":"https://github.com/google/j2objc/issues/2345","linked_issue_ids":[1714092926],"is_known_query_context":false},{"document_id":"gh_comment_2640501257","fragment_type":"issue_comment","sequence":3,"text":"FYI, I'm still working on support for switch expressions. With the Java 21\nadded support for patterns, the ASTs javac returns are different between\nJava 17 and 21.\n\nOn Thu, Feb 6, 2025 at 1:27 AM Adil Hussain ***@***.***>\nwrote:","author_login":"tomball","author_association":"COLLABORATOR","created_at":"2025-02-06T17:11:28+08:00","repo_name":"google/j2objc","issue_id":2325110356,"issue_number":2345,"issue_url":"https://github.com/google/j2objc/issues/2345","linked_issue_ids":[1714092926],"is_known_query_context":false},{"document_id":"gh_issue_1714092926","fragment_type":"issue_description","sequence":0,"text":"Is Java 17 supported?\nThis project's README file specifies \"JDK 1.8 or JDK 11\" in the Requirements.\n\nLines 191 to 205 of the make/common.mk file suggest that Java versions 12 to 19 are supported.\n\nCan I build and use J2ObjC with Java 17? I ask because the latest Android tooling (specifically, the Android Gradle Plugin) require Java 17 or later. (For reference, see the Android Gradle Plugin 8.0.0 release notes.)","author_login":"adil-hussain-84","author_association":"CONTRIBUTOR","created_at":"2023-05-17T14:53:18+08:00","repo_name":"google/j2objc","issue_id":1714092926,"issue_number":2095,"issue_url":"https://github.com/google/j2objc/issues/2095","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1552066470","fragment_type":"issue_comment","sequence":1,"text":"That's tough to answer with a yes or no, as there are really three questions with this one:\n\n1. Does j2objc support all Java 17 language features?\n2. Does j2objc support new Java 17 JRE API?\n3. Does j2objc run on Java 17?\n\n1) AFAIK, j2objc supports the latest language features, like text blocks and switch expression statements. Much of that support is free, because j2objc uses javac as its front-end; for example, javac converts text blocks into regular strings, so j2objc didn't need to be updated to support that feature.\n\n2) No, J2ObjC's JRE is a fork of Android's libcore library (its JRE), so if it's not available in Android, it's not available on iOS. That's intentional, as the purpose of J2ObjC is to support shared Java across an app's clients, not to be a complete Java platform (that's why we don't/can't call it \"Java\").\n\n3) No, because the javac team (see 1)) keeps changing access to its packages. So it works on Java 11, but it is currently broken on Java 17 until someone fixes the necessary flags (contributions welcome!).\n\nThe Android Gradle Plugin should be able to run command-line tools like j2objc in a separate shell (and likely already does). So try installing both Java 17 and Java 11 on your system, with the j2objc action defined by the flags in the j2objc.sh script. That script is also where the flags aren't correct for Java 17, so if you can fix them, great!","author_login":"tomball","author_association":"COLLABORATOR","created_at":"2023-05-17T20:49:30+08:00","repo_name":"google/j2objc","issue_id":1714092926,"issue_number":2095,"issue_url":"https://github.com/google/j2objc/issues/2095","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1554340809","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the answer 👍 We'll try it out in the coming weeks and see how we get on with it.","author_login":"adil-hussain-84","author_association":"NONE","created_at":"2023-05-19T10:07:54+08:00","repo_name":"google/j2objc","issue_id":1714092926,"issue_number":2095,"issue_url":"https://github.com/google/j2objc/issues/2095","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1655277350","fragment_type":"issue_comment","sequence":3,"text":"I just re-read my question and @tomball's answer and I see that I was unclear about what I was asking exactly.\n\nWhat I meant to ask was: Can I build J2ObjC with my `JAVA_HOME` environment variable set to JDK 17? I just tried it and the answer right now is: no. The build fails for me with the following error:\n\nshell\n...\nbuilding cycle_finder jar\nbuilding jre_emul archs: iphone64 simulator64 simulator\nNote: Some input files use or override a deprecated API.\nNote: Recompile with -Xlint:deprecation for details.\ntranslating jre_emul sources\ninstall -m 0644 build_result/cycle_finder.jar ../dist/lib/cycle_finder.jar\nerror: internal error translating \"/Users/adil/Work/j2objc/jre_emul/openjdk/src/macosx/classes/sun/nio/fs/MacOSXNativeDispatcher.java\"\njava.lang.IllegalAccessError: class com.google.devtools.j2objc.javac.TreeConverter$1 (in unnamed module @0x1a708820) cannot access class com.sun.tools.javac.parser.Tokens$Comment$CommentStyle (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.parser to unnamed module @0x1a708820\n at com.google.devtools.j2objc.javac.TreeConverter$1. (TreeConverter.java:1477)\n at com.google.devtools.j2objc.javac.TreeConverter.convertInner(TreeConverter.java:280)\n at com.google.devtools.j2objc.javac.TreeConverter.convert(TreeConverter.java:261)\n at com.google.devtools.j2objc.javac.TreeConverter.convertCompilationUnit(TreeConverter.java:232)\n at com.google.devtools.j2objc.javac.JavacParser.parseFiles(JavacParser.java:212)\n at com.google.devtools.j2objc.pipeline.FileProcessor.processBatch(FileProcessor.java:137)\n at com.google.devtools.j2objc.pipeline.FileProcessor.processInputs(FileProcessor.java:67)\n at com.google.devtools.j2objc.pipeline.TranslationProcessor.processInputs(TranslationProcessor.java:84)\n at com.google.devtools.j2objc.J2ObjC.run(J2ObjC.java:127)\n at com.google.devtools.j2objc.J2ObjC.main(J2ObjC.java:176)\n\nException in thread \"main\" java.lang.NullPointerException: Cannot invoke \"com.google.devtools.j2objc.ast.CompilationUnit.getSourceFilePath()\" because \" \" is null\n at com.google.devtools.j2objc.javac.JavacParser.parseFiles(JavacParser.java:214)\n at com.google.devtools.j2objc.pipeline.FileProcessor.processBatch(FileProcessor.java:137)\n at com.google.devtools.j2objc.pipeline.FileProcessor.processInputs(FileProcessor.java:67)\n at com.google.devtools.j2objc.pipeline.TranslationProcessor.processInputs(TranslationProcessor.java:84)\n at com.google.devtools.j2objc.J2ObjC.run(J2ObjC.java:127)\n at com.google.devtools.j2objc.J2ObjC.main(J2ObjC.java:176)\nmake[1]: *** [/Users/adil/Work/j2objc/jre_emul/build_result/Classes/.translate_mark_jre_emul] Error 1\nmake: *** [jre_emul_dist] Error 2\n\nThis is not a blocker for me. Taking @tomball's answer into consideration, I have both JDK 11 and 17 installed on my machine. I have my `JAVA_HOME` environment variable set to JDK 17 except in a small number of isolated processes where I change it to JDK 11. For example, when building J2ObjC and when running the `j2objc` command.","author_login":"adil-hussain-84","author_association":"CONTRIBUTOR","created_at":"2023-07-28T08:34:58+08:00","repo_name":"google/j2objc","issue_id":1714092926,"issue_number":2095,"issue_url":"https://github.com/google/j2objc/issues/2095","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2704457107","fragment_type":"issue_comment","sequence":4,"text":"Still working on switch expressions. The basics are improving with each commit, but the language spec got a lot more complicated in Java 21 with pattern and guard support.\n \n\nOnly as requested by customers, and then only APIs that are implemented on Android and don't require massive changes. Examples of new APIs that won't be supported include lightweight threads, pseudo-random number generators, foreign memory access API, and context-specific deserialization filters. Generally, j2objc's purpose is to support code-sharing of Java on iOS that also runs on Android or is transpiled via J2CL on web platforms.\n \n\nYes, j2objc is currently in use inside Google on Java 22, and I've been testing new language features on Java 14, 17, and 21.","author_login":"tomball","author_association":"COLLABORATOR","created_at":"2025-03-06T17:15:06+08:00","repo_name":"google/j2objc","issue_id":1714092926,"issue_number":2095,"issue_url":"https://github.com/google/j2objc/issues/2095","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0312","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"docs: Add a mention for how to glob image files (frontend bundler)?","query_context":"Currently it seems that if you want to use `webpack_path` with an image in `frontend/images/`, it's not possible if the same image isn't used in a JS or CSS file (e.g. `import \"../images/file.png\"` in `frontend/javascript/index.js`).\n\nThis limitation isn't mentioned anywhere in the docs, as far as I can see.\n\n**Bridgetown Version**: 0.21.5\n\n**To Reproduce**\n\n1. Create a fresh Bridgetown site\n2. Add an image to `frontend/images/`\n3. Try to use that file on a liquid page (e.g. ` `)\n\n**Current behavior**\n\nAn opaque error is printed to the logs:\n\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n\nAnd the emitted mark-up is:\n\n \n\n**Expected behavior**\n\nI would expect, based on the documentation, to be able to use any image from `frontend/` with the `#webpack_path` helper to take advantage of file hashes etc…\n\n**Screenshots**\n\n—\n\n**Computing environment (please complete the following information):**\n - OS: macOS Big Sur\n - Browser: any browser\n - Browser Version —\n - Ruby Version: 2.6.6\n\n**Additional context**\n\n—","known_context_document_ids":["gh_issue_1034768647"],"reference_answer":"I looked into this a bit. For my own reference, here's a more concrete example:\n\n* `entry.js`:\n\n \njs\n console.log(import(\"./academic-cap.svg\"))\n \n\n* `academic-cap.svg`:\n\n \nsvg\n \n \n\nWhen the above files are bundled with `esbuild entry.js --bundle --format=esm --splitting --outdir=out --metafile=meta.json --loader:.svg=file`, I get the following `meta.json` file:\n\njson\n{\n \"inputs\": {\n \"academic-cap.svg\": {\n \"bytes\": 7,\n \"imports\": []\n },\n \"entry.js\": {\n \"bytes\": 42,\n \"imports\": [\n {\n \"path\": \"academic-cap.svg\",\n \"kind\": \"dynamic-import\"\n }\n ]\n }\n },\n \"outputs\": {\n \"out/entry.js\": {\n \"imports\": [\n {\n \"path\": \"out/academic-cap-JHXDOPWG.js\",\n \"kind\": \"dynamic-import\"\n }\n ],\n \"exports\": [],\n \"entryPoint\": \"entry.js\",\n \"inputs\": {\n \"entry.js\": {\n \"bytesInOutput\": 50\n }\n },\n \"bytes\": 63\n },\n \"out/academic-cap-55CCFTCE.svg\": {\n \"imports\": [],\n \"exports\": [],\n \"inputs\": {\n \"academic-cap.svg\": {\n \"bytesInOutput\": 7\n }\n },\n \"bytes\": 7\n },\n \"out/academic-cap-JHXDOPWG.js\": {\n \"imports\": [],\n \"exports\": [\n \"default\"\n ],\n \"entryPoint\": \"academic-cap.svg\",\n \"inputs\": {\n \"academic-cap.svg\": {\n \"bytesInOutput\": 56\n }\n },\n \"bytes\": 124\n }\n }\n}\n\nThis information lets you map from `out/entry.js` => `out/academic-cap-JHXDOPWG.js` => `academic-cap.svg` but there is no link to `out/academic-cap-55CCFTCE.svg` (the file referenced by the imported string).","answer_document_id":"gh_comment_1350426687","silver_evidence_path":["gh_comment_1347005502","gh_issue_1487580925","gh_comment_1350426687"],"evidence_issue_ids":[1034768647,1487580925],"source_repo_name":"bridgetownrb/bridgetown","source_issue_id":1034768647,"source_issue_number":428,"source_issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","target_repo_name":"evanw/esbuild","target_issue_id":1487580925,"target_issue_number":2731,"target_issue_url":"https://github.com/evanw/esbuild/issues/2731","reference_anchor_document_id":"gh_comment_1347005502","reference_answer_author":"evanw","reference_answer_author_association":"OWNER","quality_score":82.29,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0286,"anchor_target_overlap":0.2,"target_answer_overlap":0.383},"issue_created_at":"2021-10-25T07:18:21+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1034768647","fragment_type":"issue_description","sequence":0,"text":"docs: Add a mention for how to glob image files (frontend bundler)\nCurrently it seems that if you want to use `webpack_path` with an image in `frontend/images/`, it's not possible if the same image isn't used in a JS or CSS file (e.g. `import \"../images/file.png\"` in `frontend/javascript/index.js`).\n\nThis limitation isn't mentioned anywhere in the docs, as far as I can see.\n\n**Bridgetown Version**: 0.21.5\n\n**To Reproduce**\n\n1. Create a fresh Bridgetown site\n2. Add an image to `frontend/images/`\n3. Try to use that file on a liquid page (e.g. ` `)\n\n**Current behavior**\n\nAn opaque error is printed to the logs:\n\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n[Bridgetown] Webpack: There was an error parsing your images/favicon.png file. Please check your images/favicon.png file for any errors.\n\nAnd the emitted mark-up is:\n\n \n\n**Expected behavior**\n\nI would expect, based on the documentation, to be able to use any image from `frontend/` with the `#webpack_path` helper to take advantage of file hashes etc…\n\n**Screenshots**\n\n—\n\n**Computing environment (please complete the following information):**\n - OS: macOS Big Sur\n - Browser: any browser\n - Browser Version —\n - Ruby Version: 2.6.6\n\n**Additional context**\n\n—","author_login":"matiaskorhonen","author_association":"NONE","created_at":"2021-10-25T07:18:21+08:00","repo_name":"bridgetownrb/bridgetown","issue_id":1034768647,"issue_number":428,"issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1017701671","fragment_type":"issue_comment","sequence":1,"text":"Updating this issue to cover adding a mention for how to glob image files in both esbuild and Webpack frontend bundler configs.","author_login":"jaredcwhite","author_association":"MEMBER","created_at":"2022-01-20T16:44:08+08:00","repo_name":"bridgetownrb/bridgetown","issue_id":1034768647,"issue_number":428,"issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328452873","fragment_type":"issue_comment","sequence":2,"text":"Speaking of the frontend developer, this can also be used with videos too? Not just images.\n\nThanks for the quick fix @matiaskorhonen, looks like that should work for me as well. I'd always had issues using the frontend bundler with images, only got it work correctly with CSS/SCSS.","author_login":"KorbsStudio","author_association":"NONE","created_at":"2022-11-28T02:40:10+08:00","repo_name":"bridgetownrb/bridgetown","issue_id":1034768647,"issue_number":428,"issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328719463","fragment_type":"issue_comment","sequence":3,"text":"Yeah, I don't see why not. You'd just need to add `mp4` or `webm` or whatever to the glob pattern…\n\nI used the same setup for both images and data files on the @euruko 2022 conference site: URL","author_login":"matiaskorhonen","author_association":"NONE","created_at":"2022-11-28T08:38:42+08:00","repo_name":"bridgetownrb/bridgetown","issue_id":1034768647,"issue_number":428,"issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1346732076","fragment_type":"issue_comment","sequence":4,"text":"I seem to have issues with this as I work wit esBuild better than Webpack.","author_login":"KorbsStudio","author_association":"CONTRIBUTOR","created_at":"2022-12-12T15:37:27+08:00","repo_name":"bridgetownrb/bridgetown","issue_id":1034768647,"issue_number":428,"issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1347005502","fragment_type":"issue_comment","sequence":5,"text":"@jaredcwhite id say a copy plugin that writes to a manifest is better. The problem with the manifests that are generated by doing import statements is that the strings get inlined into the final bundle, so you would need to make a separate assets entrypoint that you never use.\n\nAlso, ESBuilds asset detection is spotty at best since the asset -> hashed asset requires some workarounds.\n\n URL","author_login":"KonnorRogers","author_association":"MEMBER","created_at":"2022-12-12T18:20:57+08:00","repo_name":"bridgetownrb/bridgetown","issue_id":1034768647,"issue_number":428,"issue_url":"https://github.com/bridgetownrb/bridgetown/issues/428","linked_issue_ids":[1487580925],"is_known_query_context":false},{"document_id":"gh_issue_1487580925","fragment_type":"issue_description","sequence":0,"text":"[Feature Request]: For entrypoints handled by \"file\" loader, add the hashed file to the metafile output\nThe title is hard to understand, but basically im looking for a map back to the original file that creates an asset chunk.\n\nExample:\n\njs\n// index.js\nimport(\"academic-cap.svg\")\n\nin my ESBuild metafile:\n\njs\nfor (const [hashedPath, details] of Object.entries(result.metafile.outputs)) {\n console.log(hashedPath, details)\n \n // public/esbuild-builds/chunks/academic-cap-JO6NDN2A.js\n // {\n // imports: [],\n // exports: [ 'default' ],\n // entryPoint: 'app/javascript/assets/academic-cap.svg',\n // inputs: { 'app/javascript/assets/academic-cap.svg': { bytesInOutput: 56 } },\n // bytes: 204\n // }\n }\n\nIf you notice theres no hashed `\"public/esbuilds-builds/assets/academic-cap-[hash].svg\"`, it only has the \".js\" entrypoint. I'm curious if it would be possible to support the use-case of keeping a referenced to the hashed-file with the original extension and not the generated JS file.","author_login":"KonnorRogers","author_association":"NONE","created_at":"2022-12-09T22:50:37+08:00","repo_name":"evanw/esbuild","issue_id":1487580925,"issue_number":2731,"issue_url":"https://github.com/evanw/esbuild/issues/2731","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1350426687","fragment_type":"issue_comment","sequence":1,"text":"I looked into this a bit. For my own reference, here's a more concrete example:\n\n* `entry.js`:\n\n \njs\n console.log(import(\"./academic-cap.svg\"))\n \n\n* `academic-cap.svg`:\n\n \nsvg\n \n \n\nWhen the above files are bundled with `esbuild entry.js --bundle --format=esm --splitting --outdir=out --metafile=meta.json --loader:.svg=file`, I get the following `meta.json` file:\n\njson\n{\n \"inputs\": {\n \"academic-cap.svg\": {\n \"bytes\": 7,\n \"imports\": []\n },\n \"entry.js\": {\n \"bytes\": 42,\n \"imports\": [\n {\n \"path\": \"academic-cap.svg\",\n \"kind\": \"dynamic-import\"\n }\n ]\n }\n },\n \"outputs\": {\n \"out/entry.js\": {\n \"imports\": [\n {\n \"path\": \"out/academic-cap-JHXDOPWG.js\",\n \"kind\": \"dynamic-import\"\n }\n ],\n \"exports\": [],\n \"entryPoint\": \"entry.js\",\n \"inputs\": {\n \"entry.js\": {\n \"bytesInOutput\": 50\n }\n },\n \"bytes\": 63\n },\n \"out/academic-cap-55CCFTCE.svg\": {\n \"imports\": [],\n \"exports\": [],\n \"inputs\": {\n \"academic-cap.svg\": {\n \"bytesInOutput\": 7\n }\n },\n \"bytes\": 7\n },\n \"out/academic-cap-JHXDOPWG.js\": {\n \"imports\": [],\n \"exports\": [\n \"default\"\n ],\n \"entryPoint\": \"academic-cap.svg\",\n \"inputs\": {\n \"academic-cap.svg\": {\n \"bytesInOutput\": 56\n }\n },\n \"bytes\": 124\n }\n }\n}\n\nThis information lets you map from `out/entry.js` => `out/academic-cap-JHXDOPWG.js` => `academic-cap.svg` but there is no link to `out/academic-cap-55CCFTCE.svg` (the file referenced by the imported string).","author_login":"evanw","author_association":"OWNER","created_at":"2022-12-14T05:40:20+08:00","repo_name":"evanw/esbuild","issue_id":1487580925,"issue_number":2731,"issue_url":"https://github.com/evanw/esbuild/issues/2731","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0313","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Decimal * Uint128 treats Uint128 as a raw Decimal value?","query_context":"Seems to be a \"feature\" so raw `Uint128` values can be treated as decimals.\n\nrust\n// NOTE: using a custom Decimal fork here since the constructor is normally private\n unimplemented!(\n \"{} {} {} {}\",\n gas_cost * Decimal::one(), // decimal * decimal\n gas_cost * Uint128::from(1u128), // decimal * u128\n gas_cost * Decimal::from_ratio(Uint128::from(1u128), 1u128), // decimal * decimal(u128 / 1)\n gas_cost * Decimal(Uint128::from(1u128)), // decimal * decimal(u128)\n );\n//1 'not implemented: 0.00000000000338 0 0.00000000000338 0'\n\nThis is very surprising, since the `Div` implementation doesn't follow this behavior, and `Mul` doesn't this either.\n\nSimilar to #1155 I propose the `Decimal()` constructor to be made public. The `Mul` implementation should be fixed, then the old behavior can be more explicit via `decimal_val * Decimal(uint_val)`.","known_context_document_ids":["gh_issue_1041839813"],"reference_answer":"Checked math only makes sense if the contract actually handles the error cases. If they just `?` them to top level, you can also just panic. In both cases the contract execution is terminated, the transaction is reverted and an error message is logged. When you multiply with constants like 1/3 you know the operation can never fail. So I'd implement both for consistency with other math operations.","answer_document_id":"gh_comment_1370604927","silver_evidence_path":["gh_comment_1313419079","gh_issue_1447759394","gh_comment_1370604927"],"evidence_issue_ids":[1041839813,1447759394],"source_repo_name":"CosmWasm/cosmwasm","source_issue_id":1041839813,"source_issue_number":1156,"source_issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","target_repo_name":"CosmWasm/cosmwasm","target_issue_id":1447759394,"target_issue_number":1485,"target_issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","reference_anchor_document_id":"gh_comment_1313419079","reference_answer_author":"webmaster128","reference_answer_author_association":"MEMBER","quality_score":95.69,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.6,"target_answer_overlap":0.0938},"issue_created_at":"2021-11-02T03:12:27+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1041839813","fragment_type":"issue_description","sequence":0,"text":"Decimal * Uint128 treats Uint128 as a raw Decimal value\nSeems to be a \"feature\" so raw `Uint128` values can be treated as decimals.\n\nrust\n// NOTE: using a custom Decimal fork here since the constructor is normally private\n unimplemented!(\n \"{} {} {} {}\",\n gas_cost * Decimal::one(), // decimal * decimal\n gas_cost * Uint128::from(1u128), // decimal * u128\n gas_cost * Decimal::from_ratio(Uint128::from(1u128), 1u128), // decimal * decimal(u128 / 1)\n gas_cost * Decimal(Uint128::from(1u128)), // decimal * decimal(u128)\n );\n//1 'not implemented: 0.00000000000338 0 0.00000000000338 0'\n\nThis is very surprising, since the `Div` implementation doesn't follow this behavior, and `Mul` doesn't this either.\n\nSimilar to #1155 I propose the `Decimal()` constructor to be made public. The `Mul` implementation should be fixed, then the old behavior can be more explicit via `decimal_val * Decimal(uint_val)`.","author_login":"archseer","author_association":"NONE","created_at":"2021-11-02T03:12:27+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1003783493","fragment_type":"issue_comment","sequence":1,"text":"Thanks for brining this up. I'm really unsure what the desired output type is.\n\nThere is also no generic and safe conversion\n* **Decimal -> Uint128:** because information after the decimal point get lost\n* **Uint128 -> Decimal:** because the range of Decimal is smaller since 18 digits are reserved for the data behind the decimal point\n\nThis makes it hard to say: Use this output type that can easily be converted.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-01-02T22:12:47+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1003784160","fragment_type":"issue_comment","sequence":2,"text":"Looking at URL it feels like this should not be implemented at all.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-01-02T22:18:41+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1029729643","fragment_type":"issue_comment","sequence":3,"text":"This should be implemented. I'd expect `decimal * uint128` to do a simple multiplication. Equivalent to `decimal(decimal.0 * uint128)` or `decimal * decimal::from_ratio(uint128, 1)` but more gas efficient than constructing a `int/1` fraction then multiplying two fractions together.","author_login":"archseer","author_association":"NONE","created_at":"2022-02-04T07:41:52+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1029743812","fragment_type":"issue_comment","sequence":4,"text":"i.e. I have `$0.05` dollars (internally, stored as `5` cents, the lowest possible fraction, with a `DECIMALS` value of 2). I double my money (`2 * 5`) => `$0.10`","author_login":"archseer","author_association":"NONE","created_at":"2022-02-04T08:08:38+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1303490937","fragment_type":"issue_comment","sequence":5,"text":"Basically, there are two ways we could want.\n\n200 * 50% = 100 (multiply my number by some decimal) - this is implemented as majority case\n25% * 3 = 75% (multiply my percentage by a number to get a bigger percentage) - this is not typical, but should be possible.\n\nMaybe this is included in #1186 ?\n\nBut if we have `Decimal * Decimal -> Decimal` that should be plenty. And you can convert your integer to a decimal with no loss before multiplying. Making it possible, even if not super simple syntax.","author_login":"ethanfrey","author_association":"MEMBER","created_at":"2022-11-04T12:56:40+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1313419079","fragment_type":"issue_comment","sequence":6,"text":"The mixed type arithmetic Decimal * Uint128 should be removed when we get the chance. Created a ticket for 2.0: URL","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-11-14T10:09:54+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1041839813,"issue_number":1156,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1156","linked_issue_ids":[1447759394],"is_known_query_context":false},{"document_id":"gh_issue_1447759394","fragment_type":"issue_description","sequence":0,"text":"Remove mixed type arithmetic Decimal * Uint128\nThere is no natural return type for Decimal * Uint128. It could be Decimal, Uint128 or even Uint512. See URL for a more elaborate description of the problem.\n\nThe choice of Decimal * Uint128 = Uint128 has no reason other than its first use case. It has often confused users who expect Decimal * Uint128 = Decimal. \n\nThe better solution for the integer math is something like:\n\nrust\nlet a: Uint128;\nlet b: Decimal;\n\nlet c = a.multiply_ratio(b.numerator(), b.denominator());\n\nThe better solution for the decimal math is something like:\n\nrust\nlet a: Uint128;\nlet b: Decimal;\n\nlet c = Decimal::try_into(a)? * b;","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-11-14T10:08:26+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1315774264","fragment_type":"issue_comment","sequence":1,"text":"This is not a \"better solution\" in my mind. Very cumbersome to use and not adding clarity to devs.\n\nIf you want to make `let c = a.multiply_ratio(b);` that starts getting usable (if verbose).\nPeople should not be forced to deconstruct Decimal to be able to do basic math","author_login":"ethanfrey","author_association":"MEMBER","created_at":"2022-11-15T19:32:29+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1315886060","fragment_type":"issue_comment","sequence":2,"text":"Yeah, this was not meant as the final API. It should just showcase how `Decimal * Uint128 = Uint128` and `Decimal * Uint128 = Decimal` can be done and the implementation for both operation is there. It can be implemented with something like\n\nrust\nfn multiply_by(self, rhs: Into ) -> Uint128\n\ninstead to keep the caller code concise.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-11-15T21:28:52+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316099836","fragment_type":"issue_comment","sequence":3,"text":"Along these lines, it would be very useful to have some ceil and floor multiplication for Uints and Decimals. Something like this:\n\nrust\nfn mul_ceiled(self, rhs: impl Fraction) -> Self;\nfn mul_floored(self, rhs: impl Fraction) -> Self;\n\nThis would allow for a lot of flexibility when dealing with rounding errors etc.","author_login":"ewoolsey","author_association":"NONE","created_at":"2022-11-16T00:47:36+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316106344","fragment_type":"issue_comment","sequence":4,"text":"@uint is 👆 something a macro implementation could help us with? I think we need those 4 functions implemented for Uint64, Uint128 and Uint256:\n\nrust\nfn mul_ceiled(self, rhs: impl Fraction) -> Self;\nfn mul_floored(self, rhs: impl Fraction) -> Self;\nfn checked_mul_ceiled(self, rhs: impl Fraction) -> Self;\nfn checked_mul_floored(self, rhs: impl Fraction) -> Self;\n\nWith those in place, we can confidentally remove the mixed type operator implementation in 2.0.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-11-16T00:53:47+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317323435","fragment_type":"issue_comment","sequence":5,"text":"Probably! Like an `impl_arithmetic!(u64)` macro called in every `Uint*` module?","author_login":"uint","author_association":"COLLABORATOR","created_at":"2022-11-16T16:43:08+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317332425","fragment_type":"issue_comment","sequence":6,"text":"Yeah, or better specifically for the new additions `impl_mul_arithmetic!(u64)` such that we get them implemented consistently. We discussed deduplicating the Uint* implementations before and I think this is a good opportunity to try this approach. But I'm not that confident writing macros myself due to lack of experience.\n\nNote that Uint512 should not get them since it does not have a `full_mul` implementation. If we add that we also need Uint1024 and the series would go on indefinitly.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-11-16T16:49:06+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317526724","fragment_type":"issue_comment","sequence":7,"text":"Isn't `Uint128::checked_multiply_ratio` already a ceil multiplication?","author_login":"uint","author_association":"COLLABORATOR","created_at":"2022-11-16T19:02:08+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1318395440","fragment_type":"issue_comment","sequence":8,"text":"@webmaster128 I took a shot at it yesterday. I think it's not as simple as reusing the logic in `checked_multiply_ratio`. E.g. if you have\n\nrs\nlet left: Uint64;\nlet right: Decimal; // or even Decimal256\nlet result = left.checked_mul_floored(right).unwrap();\n\nI suspect the multiplication of `left * right.numerator()` might overflow quite easily, and `full_mul` doesn't help.","author_login":"uint","author_association":"COLLABORATOR","created_at":"2022-11-17T10:10:17+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1318456455","fragment_type":"issue_comment","sequence":9,"text":"Right, this is something I vaguely imagined to become a problem. \n\nSo what we do currently support is basically\n\nUint64 * Fraction \nUint128 * Fraction \nUint256 * Fraction \n\nwith (more or less) Decimal being a `Fraction ` and Decimal256 being a `Fraction `. Also by widening we can easily support\n\nUint128 * Fraction \nUint256 * Fraction \nUint256 * Fraction \n\nSo the number if bits in the integer needs to be >= the number of bits of the decimal. We are lacking an easy way to get\n\nUint64 * Fraction (i.e. Uint64 * Decimal)\nUint64 * Fraction (i.e. Uint64 * Decimal256)\nUint128 * Fraction (i.e. Uint128 * Decimal256)\n\nHowever, if we do not do the multiplication size based on the integer size (current `self.full_mul` behaviour) but based on the larger of the two, we can get this to work. A simple implementation just takes 256*256=512 bit multiplication to cover all the cases at once.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2022-11-17T10:56:35+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370142574","fragment_type":"issue_comment","sequence":10,"text":"Hey folks, tried my hand at this here: URL for Uint128.\n\nA few things:\n- It looks like the primary use case in this issue with the Uint# * Decimal use case. For our contracts, we are trying to support a Uint128 * Fraction(Uint128, Uint128) use case ( URL This means, we need a struct that implements \"Fraction\". I tried implementing a generic struct for this (renaming the interface to Fractional), but the `inv()` method is problematic. Would like some feedback on this approach, possibly another direction is better.\n\n- This does not support multiplying higher bit numbers. Any suggestions on how to handle this? Do you suggest casting everything to a Uint512?\n\n- I made the unchecked versions simply the unwrapped of the checked. I wonder if these are necessary at all though and checked should be the default with the consumers unwrapping themselves.","author_login":"grod220","author_association":"NONE","created_at":"2023-01-03T19:25:09+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370210178","fragment_type":"issue_comment","sequence":11,"text":"Just pushed an update to that PR that adds a macro. If it's acceptable to cast to Uint512 for all int sizes, we simply need to wrap all of the Uint structs in `fraction_math!(Uint128);`. Think this is what folks were suggesting earlier in the thread.","author_login":"grod220","author_association":"NONE","created_at":"2023-01-03T20:48:40+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370604927","fragment_type":"issue_comment","sequence":12,"text":"Checked math only makes sense if the contract actually handles the error cases. If they just `?` them to top level, you can also just panic. In both cases the contract execution is terminated, the transaction is reverted and an error message is logged. When you multiply with constants like 1/3 you know the operation can never fail. So I'd implement both for consistency with other math operations.","author_login":"webmaster128","author_association":"MEMBER","created_at":"2023-01-04T08:17:26+08:00","repo_name":"CosmWasm/cosmwasm","issue_id":1447759394,"issue_number":1485,"issue_url":"https://github.com/CosmWasm/cosmwasm/issues/1485","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0314","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"GraphServiceClient.Users.GetAsync() returns nothing or non-helpful value for Schema Extension Data?","query_context":"**Describe the bug**\nVery related to Issue #2305 when running the standard query and \"not\" explicitly including the schema extension data, nothing is returned for the schema extension data. One step more problematic than #2305 is when the schema extension **_is_** explicitly requested it returns non-helpful data instead of the actual data stored and that the documentation is referring to.\n\nWhen doing a regular/default query **GraphServiceClient.Users.GetAsync()** it is returning no extension data field/value/reference of any kind and only non-helpful data when the Schema Extension item is explicitly supplied by **QueryParameter.Select** \n\nimage\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n**IDE Setup**\n- Visual Studio 17.8.3\n- .NET 8.0 C# command line project\n\n**Expected behavior**\n**Issue 1**\nIf data exists in the specified Schema Extension for the user, the data should be returned by the default query. \nShould not require explicitly returning that field to display the data.\n\n**Issue 2**\nIf data exists in the specified Schema Extension for the user, the actual field values should be returned when explicitly requesting the schema extension data using QueryParameter.Select\n\n**Steps**\n- Created a GraphClient _graphClient (success)\n- Added values to a user for the Schema Extension (success)\n\n- Run GraphClient.Users[UserId].GetAsync() - returns nothing for schema extension (_failure_)\n\n- Run GraphClient.Users[UserId].GetAsync() with schema extension explicitly supplied in QueryParameters.Select (_success_ but also _failure_)\n\nimage\n\n**Code**\nThe following code returns no field/value/reference for an existing schema extension data when running the basic user query:\n\n`_graphClient.Users[UserId].GetAsync();`\n\nThe following code returns a non-helpful, non-informational value for the schema extension data when adding the explicitly select parameter (_but has the bug where every field is returned_)\n\n`requestConfiguration.QueryParameters.Select = new string[] { \"id\", \"displayName\", \"domain_schemaextensionname\" };`\n\nimage","known_context_document_ids":["gh_issue_2104650776"],"reference_answer":"Thanks for raising this @drewid \n\nAny chance you can confirm the method you are verifying the properties returned from `result` object? If you are serializing the object the object, are you using this?\n\ncs\nvar jsonString = var jsonString = KiotaJsonSerializer.SerializeAsString(result);","answer_document_id":"gh_comment_1911554989","silver_evidence_path":["gh_comment_1914105461","gh_issue_2101221249","gh_comment_1911554989"],"evidence_issue_ids":[2104650776,2101221249],"source_repo_name":"microsoftgraph/msgraph-sdk-dotnet","source_issue_id":2104650776,"source_issue_number":2308,"source_issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2308","target_repo_name":"microsoftgraph/msgraph-sdk-dotnet","target_issue_id":2101221249,"target_issue_number":2304,"target_issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","reference_anchor_document_id":"gh_comment_1914105461","reference_answer_author":"andrueastman","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.3333,"target_answer_overlap":0.1875},"issue_created_at":"2024-01-29T04:58:10+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2104650776","fragment_type":"issue_description","sequence":0,"text":"GraphServiceClient.Users.GetAsync() returns nothing or non-helpful value for Schema Extension Data\n**Describe the bug**\nVery related to Issue #2305 when running the standard query and \"not\" explicitly including the schema extension data, nothing is returned for the schema extension data. One step more problematic than #2305 is when the schema extension **_is_** explicitly requested it returns non-helpful data instead of the actual data stored and that the documentation is referring to.\n\nWhen doing a regular/default query **GraphServiceClient.Users.GetAsync()** it is returning no extension data field/value/reference of any kind and only non-helpful data when the Schema Extension item is explicitly supplied by **QueryParameter.Select** \n\nimage\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n**IDE Setup**\n- Visual Studio 17.8.3\n- .NET 8.0 C# command line project\n\n**Expected behavior**\n**Issue 1**\nIf data exists in the specified Schema Extension for the user, the data should be returned by the default query. \nShould not require explicitly returning that field to display the data.\n\n**Issue 2**\nIf data exists in the specified Schema Extension for the user, the actual field values should be returned when explicitly requesting the schema extension data using QueryParameter.Select\n\n**Steps**\n- Created a GraphClient _graphClient (success)\n- Added values to a user for the Schema Extension (success)\n\n- Run GraphClient.Users[UserId].GetAsync() - returns nothing for schema extension (_failure_)\n\n- Run GraphClient.Users[UserId].GetAsync() with schema extension explicitly supplied in QueryParameters.Select (_success_ but also _failure_)\n\nimage\n\n**Code**\nThe following code returns no field/value/reference for an existing schema extension data when running the basic user query:\n\n`_graphClient.Users[UserId].GetAsync();`\n\nThe following code returns a non-helpful, non-informational value for the schema extension data when adding the explicitly select parameter (_but has the bug where every field is returned_)\n\n`requestConfiguration.QueryParameters.Select = new string[] { \"id\", \"displayName\", \"domain_schemaextensionname\" };`\n\nimage","author_login":"drewid","author_association":"NONE","created_at":"2024-01-29T04:58:10+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2104650776,"issue_number":2308,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2308","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1914105461","fragment_type":"issue_comment","sequence":1,"text":"Thanks for raising this @drewid \n\nThe API will only return a limited number of properties by default and thus the $select parameter is required to fetch those properties. \nWith regards to displaying the results, the models used by the SDK should be serialized as pointed at here due to the custom serialization.\n\nAny chance you can confirm this resolves it?","author_login":"andrueastman","author_association":"MEMBER","created_at":"2024-01-29T07:25:24+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2104650776,"issue_number":2308,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2308","linked_issue_ids":[2101221249],"is_known_query_context":false},{"document_id":"gh_comment_1914169347","fragment_type":"issue_comment","sequence":2,"text":"I will look into things further but if more work/serialization is needed then core graph documentation and examples needs to be seriously updated as it is very wrong.","author_login":"drewid","author_association":"NONE","created_at":"2024-01-29T08:11:51+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2104650776,"issue_number":2308,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2308","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915840830","fragment_type":"issue_comment","sequence":3,"text":"Is strange that regular serialization does not work and only works with KiotaJsonSerializer. This is not documented anywhere obvious.","author_login":"drewid","author_association":"NONE","created_at":"2024-01-30T00:41:15+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2104650776,"issue_number":2308,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2308","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1916445711","fragment_type":"issue_comment","sequence":4,"text":"Thanks for confirming @drewid . Since this is related to the discussion in URL We will close this and follow this up there","author_login":"andrueastman","author_association":"MEMBER","created_at":"2024-01-30T09:43:14+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2104650776,"issue_number":2308,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2308","linked_issue_ids":[2101221249],"is_known_query_context":false},{"document_id":"gh_issue_2101221249","fragment_type":"issue_description","sequence":0,"text":"GraphServiceClient.Users.GetAsync() is not respecting QueryParameters.Select\n**Describe the bug**\nNo matter what **QueryParameters.Select** fields are entered, the Users.GetAsync() and Users[\"user\"].GetAsyc() query returns all the fields for a user instead of the subset. My code is close to identical to MS standard examples.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n**IDE Setup**\nVisual Studio 17.8.3\n.NET 8.0 C# command line project\n\n**Steps**\n1. Created a GraphClient _graphClient (_success_)\n2. Added values to a user for ExtensionAttribute1 and ExtensionAttribute2 (_success_)\n3. Added Directory Extension (_success_)\n\n4a. Return the fields Id, DisplayName, OnPremisesExtensionAttributes (_**failure**_)\n4b. Return the fields Id, DisplayName, extension_clientid_extensionname (_**failure**_)\n4c. Return just the fields Id and DisplayName (_**failure**_)\n\n**Problem**\nNo matter what is put in the values for **QueryParameters.Select** all the fields are returned for the user instead of the subset specified in the Select array.\n\nI have tried changing the case of the fields (Camel Case vs Capitalized) to no luck.\n\n**Expected behavior**\nOnly the fields that were specified during the select should be returned.\n\n**Code**\nIf applicable, add screenshots to help explain your problem.\n\nimage\n\n`\nvar result = await _graphClient.Users[\"userid\"].GetAsync((requestConfiguration) =>\n{\n requestConfiguration.QueryParameters.Select = new[] { \"Id\", \"DisplayName\", \"OnPremisesExtensionAttributes\" };\n});\nreturn result;\n`\n\nThe response returns the full list of user fields. Example snippet:\n\nimage","author_login":"drewid","author_association":"NONE","created_at":"2024-01-25T21:47:15+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1911554989","fragment_type":"issue_comment","sequence":1,"text":"Thanks for raising this @drewid \n\nAny chance you can confirm the method you are verifying the properties returned from `result` object? If you are serializing the object the object, are you using this?\n\ncs\nvar jsonString = var jsonString = KiotaJsonSerializer.SerializeAsString(result);","author_login":"andrueastman","author_association":"MEMBER","created_at":"2024-01-26T06:34:19+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1913003768","fragment_type":"issue_comment","sequence":2,"text":"I printed out the serialized results using the following:\n` Console.WriteLine(JsonConvert.SerializeObject(result));`\n\nI would not expect to see all of the fields having been returned.\n\nWhen I used the following you mentioned, it is empty\n`var jsonString = KiotaJsonSerializer.SerializeAsString(result);`","author_login":"drewid","author_association":"NONE","created_at":"2024-01-27T05:18:37+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1914088425","fragment_type":"issue_comment","sequence":3,"text":"Thanks for getting back @drewid \nAny chance this shows the values returned? Due to the backingStore, the properties may not show as the serializer will pick out only changed values after the response. \n\ncs\nresult.BackingStore.InitializationCompleted = false;\nvar jsonString = KiotaJsonSerializer.SerializeAsString(result);","author_login":"andrueastman","author_association":"MEMBER","created_at":"2024-01-29T07:11:09+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1914170506","fragment_type":"issue_comment","sequence":4,"text":"A get should never just return changed values and that is not implied anywhere in the docs.","author_login":"drewid","author_association":"NONE","created_at":"2024-01-29T08:12:40+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1914173197","fragment_type":"issue_comment","sequence":5,"text":"I will dig further but this is a royal mess.\n\n- A default query should return all values.\n- A select should return just those mentioned and not the slew being returned","author_login":"drewid","author_association":"NONE","created_at":"2024-01-29T08:14:24+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915539759","fragment_type":"issue_comment","sequence":6,"text":"@andrueastman Thank you for the magical code snippet regarding the BackingStore - I have no idea why that magically makes things work in making the serialization honor the select list (or at least properly trim the fields).\n\nWhat is misleading though is that **the query still returns \"every\" field**, including the selected fields requested. The KiotaJsonSerializer is being applied after the fact and I can see the query is returning all the fields when doing a basic serialization of the result. This is remarkably misleading and incredibly wasteful. What has been implemented is not a select parameter, it's actually a \"make sure to include these fields\" parameter.\n\nThe information related to KiotaJsonSerializer and v5 breaking change regarding BackingStore needs a \"lot\" more information publicly. Is not listed anywhere in the normal docs and examples that I can see.\n\nIn essence, the standard described ways of doing QueryParameters.Select do not work without it (at least narrowing it down). It does include the fields selected, but also includes every other field.","author_login":"drewid","author_association":"NONE","created_at":"2024-01-29T20:50:20+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1916528484","fragment_type":"issue_comment","sequence":7,"text":"Thanks for the feedback here @drewid \n\nJust to clarify, what is indeed happening is that API is indeed only returns the fields selected(This can be confirmed using the Graph Explorer ). \nHowever, the model properties will by default read as null by a serializer if they have not been set due to the proxy mechanism used by the backing store. The `KiotaJsonSerializer` is built for this and can be used to get back the Json received or to be sent out by a given execution call. \n\nThis indeed should be better documented, and we've created URL to update the v5 documentation here.","author_login":"andrueastman","author_association":"MEMBER","created_at":"2024-01-30T10:23:24+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928536403","fragment_type":"issue_comment","sequence":8,"text":"Better documentation will be great because it is 100% not intuitive and not at all clear.","author_login":"drewid","author_association":"NONE","created_at":"2024-02-06T00:04:51+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1935897264","fragment_type":"issue_comment","sequence":9,"text":"Thanks for the feedback here @drewid. We'll close this for now and track this via URL","author_login":"andrueastman","author_association":"MEMBER","created_at":"2024-02-09T13:06:19+08:00","repo_name":"microsoftgraph/msgraph-sdk-dotnet","issue_id":2101221249,"issue_number":2304,"issue_url":"https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/2304","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0315","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[CRITICAL ISSUE] Standardization of formats, primarily NBT?","query_context":"Due to the recent shit with Meteor Client (see URL I think it's time to form some sort of standard for the Archives, specifically the NBT.\n\nCurrently all the NBT is sourced from Meteor Client's `.nbt copy`, and easiest to plug-and-play with Meteor Client's `.nbt set`, however the latter command is currently broken, and has led me to wonder if that's the right path anyway. Should the NBT be kept as is, or should it be updated to be plug-and-play with IBE Editor instead? This would involve updating some 81 kits, not counting open [New Kit] issues, but could make it easier. At the same time, the NBT can currently be used in IBE Editor, you just need to add or alter the `tag:{}` portion of the SNBT within IBE Editor.\n\nIf we update the 81 kits, I suggest simply adding `tag:` at the beginning of them all, and when users copy-paste they can choose to include or exclude that part.\n\nIn relation, the Using NBT guide should be updated accordingly with this.","known_context_document_ids":["gh_issue_1581362313"],"reference_answer":"Closing this, as it's solved in the last few commits. NBT Editor allows loading of .nbt files, which store Infinity/NaN properly. Problem solved :D","answer_document_id":"gh_comment_1437840500","silver_evidence_path":["gh_comment_1440978527","gh_issue_1569176895","gh_comment_1437840500"],"evidence_issue_ids":[1581362313,1569176895],"source_repo_name":"KadTheHunter/ShulkerArchives","source_issue_id":1581362313,"source_issue_number":96,"source_issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","target_repo_name":"KadTheHunter/ShulkerArchives","target_issue_id":1569176895,"target_issue_number":63,"target_issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/63","reference_anchor_document_id":"gh_comment_1440978527","reference_answer_author":"KadTheHunter","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.12,"anchor_target_overlap":0.12,"target_answer_overlap":0.1333},"issue_created_at":"2023-02-12T18:31:26+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1581362313","fragment_type":"issue_description","sequence":0,"text":"[CRITICAL ISSUE] Standardization of formats, primarily NBT\nDue to the recent shit with Meteor Client (see URL I think it's time to form some sort of standard for the Archives, specifically the NBT.\n\nCurrently all the NBT is sourced from Meteor Client's `.nbt copy`, and easiest to plug-and-play with Meteor Client's `.nbt set`, however the latter command is currently broken, and has led me to wonder if that's the right path anyway. Should the NBT be kept as is, or should it be updated to be plug-and-play with IBE Editor instead? This would involve updating some 81 kits, not counting open [New Kit] issues, but could make it easier. At the same time, the NBT can currently be used in IBE Editor, you just need to add or alter the `tag:{}` portion of the SNBT within IBE Editor.\n\nIf we update the 81 kits, I suggest simply adding `tag:` at the beginning of them all, and when users copy-paste they can choose to include or exclude that part.\n\nIn relation, the Using NBT guide should be updated accordingly with this.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-12T18:31:26+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1428281576","fragment_type":"issue_comment","sequence":1,"text":"_After a bit more research, it's incredibly easy to paste a kit into IBE, provided it has `,tag:` appended._\n\n### Breakdown:\n- By default, items do not have a `tag:{}` field. For example:\n - An orange shulker box has the following: `{Count:1,id:\"minecraft:orange_shulker_box\"}`\n - If our NBT data starts with `,tag:`, followed by the actual NBT itself, then users can simply click between the closing quote of the item name and the closing curly bracket, and paste in the data.\n\n- Relatively few items have naturally existing tag fields, with the majority falling in the Combat, Enchantment and Potion/Effects categories.\n\n- While we do have some standalone items, including some that have natural tags, the majority of our archive is storage-based, thus prefixing all NBT with `,tag:` would render the mass majority of the archive instantly usable regardless of interface (IBE, Meteor, Wurst, etc).\n\nThis should (generally speaking), solve the issue of multi-interface compatibility. Appending everything with `,tag:` makes all the kits usable in any interface, and while some items won't be usable if you straight up copy-paste the entire file, users can simply exclude `,tag:` in their selection when copying.\n\nThere are however other standards that need to be set, including the following:\n- Kits/Items without Authors\n- Kits/Items without Names\n- Kits/Items with NSFW or 18+ content including links, text, images, references.\n- Books\n- Kits/Items with the ability to significantly harm servers, primarily the Total Freedom network.\n\n## **_Please give feedback either in this thread or on Discord for the NBT Standard as well as ideas for the other standards as I can not add more kits to the archives until (at the very least) the NBT Standard is set._**","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-13T16:52:38+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1430151603","fragment_type":"issue_comment","sequence":2,"text":"Well despite the absolute lack of feedback from anybody, I'm approving the `,tag:` standard, and will elaborate on other standards in the below comments.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-14T17:57:19+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1430162275","fragment_type":"issue_comment","sequence":3,"text":"# Kits/Items without Authors\n\nThis has become an increasingly problematic issue, as many of the kits saved in Antis plot lack credit of any sort.\nThus far, I've been listing unknown authors as 'Pending', but I feel this is both unclear, and a temporary measure.\n\n### Proposed Solutions\n- Switch 'Pending' to 'Unknown', 'Unknown Authors', or something clearer.\n- Add a notice of some sort requesting information on kits with Unknown Authors.\n\nIn my opinion, there is no good solution to this issue, as I seriously doubt we will ever identify the authors of more than a handful of kits. However, we can certainly do a better job than at current with labeling these kits appropriately.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-14T18:04:47+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1430172006","fragment_type":"issue_comment","sequence":4,"text":"# Kits/Items without Names\n\nSimilar to \"Kits/Items without Authors\", this is a problematic issue with many kits in Antis plot, but one we can do a lot more to rectify.\n\n### Proposed Solutions\n\n- Names should be suggested based off the contents of the kit\n- Chosen names should be agreed upon by 3 people (Kaddicus, Parsa and Anti at the very least)\n- When added to the site, the name should have an asterisk (*) next to it to indicate the name is not the original\n- A note should be provided in the kits description or above the list of kits stating that kits with an asterisk had no name, and the name given was chosen by the Archivists\n\nThis would allow a number of interesting kits currently sitting in Antis plot to be added to the archives.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-14T18:12:53+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1430188350","fragment_type":"issue_comment","sequence":5,"text":"# Kits/Items with NSFW or 18+ content including links, text, images, references.\n\nCoincidentally this is an issue being currently discussed on the server: [[POLL] The Matter of NSFW Content]( URL \n\nMy views have already been expressed in that thread, but that's for the server as a whole.\n\nMy view of NSFW and the Archives is that anything goes, _provided it has suitable warning_.\n\n### Proposed Solutions\n- Add a neon red [NSFW] tag on kits containing NSFW\n- Separate NSFW kits into a separate page, or add a checkbox to show/hide NSFW kits (hide by default)","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-14T18:27:01+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1440978527","fragment_type":"issue_comment","sequence":6,"text":"Ironically, the solution to Issue #63 (NaN/Inf Attributes not saving in SNBT) invalidates this entire issue. Unsure if I'll reverse the NBT format decision, given how fucking long it took me to implement, but we'll see. Closing this issue by tomorrow when I decide.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-22T23:07:34+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[1569176895],"is_known_query_context":false},{"document_id":"gh_comment_1445169934","fragment_type":"issue_comment","sequence":7,"text":"# Final Changes\n\nOk, long-ass post incoming. Thank fuck GitHub has a fairly massive char limit, cus I got a lot to say.\n\n## Summary\n\nThis entire issue started when Meteor Client's `.nbt set` command broke (fun fact, they still haven't fixed it), prompting me to switch everything over to IBE Editor. However, not even a few days later, I started investigating Issue #63, and found that any form of SNBT would not save certain attributes, and in the case of #86 SNBT would often just shit itself when you tried working with books. Aside from being problems in and of themselves, they also meant that this issue was partially invalidated since SNBT would no longer be the primary format of the archives.\n\n## Changes\n\nThe initial goal of this Issue was to update all of the archived Kits and Items SNBT to include the `,tag:` used by IBE Editor. \n\n### SNBT\n\nI actually did carry through with that update, and all the SNBT in the Kits section of the archives contains it.\n\nHowever, I then went on to upgrade every NBT page (as part of #63's swap to .nbt files), and in doing so made the SNBT copy-able with the click of a button.... except it now contains `,tag:` which means you can't use it with Meteor Client's `.nbt paste` or NBT Editor's SNBT menu unless you manually select and copy the SNBT and exclude the `,tag:` bit.\n\n### Kits without Authors/Names\n\nI still intend to implement some of these ideas, but never got around to it because of the SNBT/InfNan business.\n\n## So... what now?\n\nWell, I've made a royal mess of things haven't I.\n\nTo start off with, I'll reverse my initial decision, and remove `,tag:` from all of the SNBT. This means I will also need to extensively edit the just-finished UsingNBT page, but so be it. I'd rather have the SNBT be easily copy-able for the few people who use it than be a swiss army knife of Editor Support.\n\nFor the Kits without Authors/Names, I'm going to implement the following:\n\n- Switch 'Pending' to 'Unknown Author'\n*I feel this is a much better term than Pending, especially given that we may never know the Authors of some kits*\n\n- Have a group of us (Anti/Parsa/Myself, possibly the greater extent of PCI as well) choose and confirm names for unnamed Kits\n*It will take more thought, and some organization, but I feel this is the best way to handle this. There are plenty of amazing kits in Antis plot alone being excluded from the Archives because they have no name, and I'd rather they have an unofficial name, than no name at all.*\n\nThere is also an unposted comment I typed up pertaining to NSFW in Kits and Items. I had initially planned to lay down rules regarding that, but have since rethought the situation and decided that Kits and Items should not be excluded from the archives on the basis that they contain Mature or Adult content or themes.\n\n## Going Forward\n\nWhile the initial reasons for this Issue are either invalid or semi-valid, there are still things I want to see standardized. A good example would be Kit Submission.\n\nThe current setup we have is:\n- \\> Users make a Kit/Item/Book\n- \\> They open an Issue on this Repository, using the applicable form\n- \\> Fill in the data and Submit\n- \\> Eventually I get around to adding it.\n\nWell, the major issue with that now is, of course, .nbt files. Even if users wanted to submit .nbt files, GitHub doesn't support uploading them in Issues/Comments (because that would just be too convenient now wouldn't it?).\n\nI've no idea how users are supposed to submit kits now, but I may try some method involving a submission box on the site, and emails.\n\nFor now, the GitHub Issues method for submitting kits is going to have to be shut down, and kits will just be submitted to me or someone I authorize to receive them in-game. *Oh how I wish we could use /mail for Kits...*\n\nAnYway, that's going to be my closing comment for this. I have more to say, but it's an unformed incoherent mess when I try and type it, and I'm getting tired of typing, so yeah. \n\n***Issue Closed***","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-25T17:57:03+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1581362313,"issue_number":96,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/96","linked_issue_ids":[1569176895],"is_known_query_context":false},{"document_id":"gh_issue_1569176895","fragment_type":"issue_description","sequence":0,"text":"Infinity/NaN\nMinecraft's JSON will just consider those strings. Infinity strings can be replaced with a valid (although pretty big) number. As for NaN though, well that is not gonna work. Maybe a different approach is needed","author_login":"unrealiceyou","author_association":"NONE","created_at":"2023-02-03T04:05:16+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1569176895,"issue_number":63,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1414935595","fragment_type":"issue_comment","sequence":1,"text":"@unrealiceyou both are rather uncommon in the wider spread of kits (or so I believe), so I'm not super concerned. I can probably just preface the text file containing the NBT with a note about the Infinity/NaN when needed, including how to properly import it.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-03T04:44:22+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1569176895,"issue_number":63,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1431809399","fragment_type":"issue_comment","sequence":2,"text":"Can confirm after testing that both `Infinity` and `NaN` just gets converted to `0.0` when added to an item as SNBT, and has to be manually changed.\n\nUltimately it seems Infinity/NaN items can't be stored as SNBT at all without removing the Infinity/NaN.\n\nUnless there's another way to save these items beyond SNBT.... they can't be saved.","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-15T18:17:30+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1569176895,"issue_number":63,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1433889698","fragment_type":"issue_comment","sequence":3,"text":"Can confirm, Hotbars work.\n\nAny method involving SNBT will _**not**_ work, as SNBT causes NaN and Infinity to be reset to 0.0 when applied to an item.\n\nMy theory is when the SNBT gets converted to normal NBT, it can't map \"NaN\" or \"Infinity\", so resets it to default (0.0)","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-16T23:41:54+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1569176895,"issue_number":63,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/63","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1437840500","fragment_type":"issue_comment","sequence":4,"text":"Closing this, as it's solved in the last few commits. NBT Editor allows loading of .nbt files, which store Infinity/NaN properly. Problem solved :D","author_login":"KadTheHunter","author_association":"OWNER","created_at":"2023-02-21T04:22:39+08:00","repo_name":"KadTheHunter/ShulkerArchives","issue_id":1569176895,"issue_number":63,"issue_url":"https://github.com/KadTheHunter/ShulkerArchives/issues/63","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0317","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"DjVu documents (and potentially other cases) cause chafa to consume a lot cpu and memory?","query_context":"**Summary**:\nSince chafa seems to try to display as many file formats as possible, sometimes it might just be inappropriate and should be prevented or optimized.\n\n**Example**:\nOne such case is DjVu files, many-page djvu documents to be accurate.\n\nIn my exact case, I have set in my lf preview script to use chafa to preview any file of image/* type. Unfortunately, DjVu files are \"image/vnd.djvu\" type. However, I think the argument applies to more general use cases as well.\n\nWhen I use chafa to (pre)view a several-hundred-page djvu document, it consumes all the available memory and the system just hangs.\n\n**Discussion**:\nMaybe chafa should at least check for potential memory consumption.\n\nMaybe also optimize the preview, such as only preview the first page, which I believe will never cost many GBs of memory. This possibly applies to PDFs as well, which currently is very slow (a few seconds) to display.","known_context_document_ids":["gh_issue_2009144802"],"reference_answer":"That would be nice to have, indeed. Since it's so little code, it would be easy to audit and fuzz test too.","answer_document_id":"gh_comment_1672396996","silver_evidence_path":["gh_comment_1825736530","gh_issue_1838426327","gh_comment_1672396996"],"evidence_issue_ids":[2009144802,1838426327],"source_repo_name":"hpjansson/chafa","source_issue_id":2009144802,"source_issue_number":179,"source_issue_url":"https://github.com/hpjansson/chafa/issues/179","target_repo_name":"hpjansson/chafa","target_issue_id":1838426327,"target_issue_number":157,"target_issue_url":"https://github.com/hpjansson/chafa/issues/157","reference_anchor_document_id":"gh_comment_1825736530","reference_answer_author":"hpjansson","reference_answer_author_association":"OWNER","quality_score":87.27,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0909,"anchor_target_overlap":0.1212,"target_answer_overlap":0.2},"issue_created_at":"2023-11-24T05:53:24+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2009144802","fragment_type":"issue_description","sequence":0,"text":"DjVu documents (and potentially other cases) cause chafa to consume a lot cpu and memory\n**Summary**:\nSince chafa seems to try to display as many file formats as possible, sometimes it might just be inappropriate and should be prevented or optimized.\n\n**Example**:\nOne such case is DjVu files, many-page djvu documents to be accurate.\n\nIn my exact case, I have set in my lf preview script to use chafa to preview any file of image/* type. Unfortunately, DjVu files are \"image/vnd.djvu\" type. However, I think the argument applies to more general use cases as well.\n\nWhen I use chafa to (pre)view a several-hundred-page djvu document, it consumes all the available memory and the system just hangs.\n\n**Discussion**:\nMaybe chafa should at least check for potential memory consumption.\n\nMaybe also optimize the preview, such as only preview the first page, which I believe will never cost many GBs of memory. This possibly applies to PDFs as well, which currently is very slow (a few seconds) to display.","author_login":"xlucn","author_association":"NONE","created_at":"2023-11-24T05:53:24+08:00","repo_name":"hpjansson/chafa","issue_id":2009144802,"issue_number":179,"issue_url":"https://github.com/hpjansson/chafa/issues/179","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1825291271","fragment_type":"issue_comment","sequence":1,"text":"this has happened to me as well, when previewing a large pdf using lf, my window manager just froze","author_login":"Zerogaku","author_association":"NONE","created_at":"2023-11-24T08:13:30+08:00","repo_name":"hpjansson/chafa","issue_id":2009144802,"issue_number":179,"issue_url":"https://github.com/hpjansson/chafa/issues/179","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1825736530","fragment_type":"issue_comment","sequence":2,"text":"Hi, thanks for reporting this. This is happening because Chafa delegates to ImageMagick when there's no internal loader to handle the file format. ImageMagick gets very enthusiastic and sometimes trips on its own shoelaces.\n\nThe problem is fixed in master and will go away in the next release -- see #157.\n\nIn the meantime, you should be able to curb problematic formats in ImageMagick's configuration. On my distro, this lives in `/etc/ImageMagick-7/`. The best way is to list it in the security policy file:\n\n1. Find the format identifier by running `magick -list format`.\n2. Add it to the policy file (`policy.xml`), e.g:\n \nsh\n \n \n \n\nThe default configuration varies between Linux distros; mine already has PDF on the do-not-load list, and it looks like DjVu support is not built in at all.","author_login":"hpjansson","author_association":"OWNER","created_at":"2023-11-24T14:15:43+08:00","repo_name":"hpjansson/chafa","issue_id":2009144802,"issue_number":179,"issue_url":"https://github.com/hpjansson/chafa/issues/179","linked_issue_ids":[1838426327],"is_known_query_context":false},{"document_id":"gh_comment_1881791416","fragment_type":"issue_comment","sequence":3,"text":"I just released version 1.14.0, where ImageMagick is no longer an option. That should fix the issue (but it will no longer produce previews for DjVu and PDF; maybe one day it will be possible to do so safely).","author_login":"hpjansson","author_association":"OWNER","created_at":"2024-01-08T20:43:33+08:00","repo_name":"hpjansson/chafa","issue_id":2009144802,"issue_number":179,"issue_url":"https://github.com/hpjansson/chafa/issues/179","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1838426327","fragment_type":"issue_description","sequence":0,"text":"Remove ImageMagick support\nImageMagick is a complex dependency that's hard to support. While it's an extremely versatile library, it's also got a kitchen sink approach that includes spawning external processes, causing inadvertent resource exhaustion and security issues. It would be nice to remove this dependency to cut down on risk/maintenance/packaging footprint.\n\nThat would leave the `chafa` CLI tool with support for the following formats: GIF, JPEG, PNG, SVG, TIFF, WebP, XWD. We may want to add support for AVIF as mentioned in #98 first. Potentially other important image formats too (suggestions welcome).\n\nWe'd lose support for formats like PDF (which many distributions disable anyway) and all video transcoding via IM (ew!). Users who want to keep using these can pipe to stdin like in the following examples:\n\nbash\nffmpeg -i URL -f gif - | chafa -d inf\n\nbash\nconvert URL gif:- | chafa -t 1 --bg white\n\n...and the performance will be better too.","author_login":"hpjansson","author_association":"OWNER","created_at":"2023-08-06T21:29:14+08:00","repo_name":"hpjansson/chafa","issue_id":1838426327,"issue_number":157,"issue_url":"https://github.com/hpjansson/chafa/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1672330834","fragment_type":"issue_comment","sequence":1,"text":"QOI might be worth a look. It is not widespread as exchange format, but quite popular as internal image format in many apps. It has okish compression and is really fast for its small code footprint.","author_login":"jerch","author_association":"NONE","created_at":"2023-08-09T23:53:24+08:00","repo_name":"hpjansson/chafa","issue_id":1838426327,"issue_number":157,"issue_url":"https://github.com/hpjansson/chafa/issues/157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1672396996","fragment_type":"issue_comment","sequence":2,"text":"That would be nice to have, indeed. Since it's so little code, it would be easy to audit and fuzz test too.","author_login":"hpjansson","author_association":"OWNER","created_at":"2023-08-10T01:24:23+08:00","repo_name":"hpjansson/chafa","issue_id":1838426327,"issue_number":157,"issue_url":"https://github.com/hpjansson/chafa/issues/157","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0318","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Always-onscreen keyboard bar?","query_context":"Firstly, thank you a million for this app. I've been looking for an open source alternative to the Remotix app and no one has ever even come close until yours, and I've looked regularly for a long time. Amazing work, I've officially uninstalled it and haven't looked back\n\nBut anyway one thing that'd be really great and cool and epic would be an option to keep that bottom keyboard row on screen at all times. I'm always reaching for it and it would be nice to just keep it there","known_context_document_ids":["gh_issue_1816629272"],"reference_answer":"Hi @sudomain , I am working on full re-implementation of virtual keys. The new layout follows the same style as Termux. (There are some differences as the use case is different for AVNC). \n- 2-row layout similar to Termux\n- Meta keys are automatically released on next key press. Long-press to lock meta keys, as described in this particular issue.\n- There are three swipable \"pages\":\n - First two pages contain keys\n - Similar to Termux, third page contains an editbox. It allows you to have full-fledged Android editing experience in a session. When finished, you can send the whole text to server in one go.\n\nFirst page:\nScreenshot_2024-04-04-21-51-23-702_com gaurav avnc debug-edit\n\nEdit box:\nScreenshot_2024-04-04-21-52-25-104_com gaurav avnc debug-edit\n\n---\n\nWhile there are still some rough edges, I would appreciate if you guys can test it.\nTest APK: URL \n\ncc @dp-alvarez","answer_document_id":"gh_comment_2037693965","silver_evidence_path":["gh_comment_2139740534","gh_issue_1513106319","gh_comment_2037693965"],"evidence_issue_ids":[1816629272,1513106319],"source_repo_name":"gujjwal00/avnc","source_issue_id":1816629272,"source_issue_number":181,"source_issue_url":"https://github.com/gujjwal00/avnc/issues/181","target_repo_name":"gujjwal00/avnc","target_issue_id":1513106319,"target_issue_number":117,"target_issue_url":"https://github.com/gujjwal00/avnc/issues/117","reference_anchor_document_id":"gh_comment_2139740534","reference_answer_author":"gujjwal00","reference_answer_author_association":"OWNER","quality_score":84.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.1818,"anchor_target_overlap":0.0,"target_answer_overlap":0.1579},"issue_created_at":"2023-07-22T05:20:03+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1816629272","fragment_type":"issue_description","sequence":0,"text":"Always-onscreen keyboard bar\nFirstly, thank you a million for this app. I've been looking for an open source alternative to the Remotix app and no one has ever even come close until yours, and I've looked regularly for a long time. Amazing work, I've officially uninstalled it and haven't looked back\n\nBut anyway one thing that'd be really great and cool and epic would be an option to keep that bottom keyboard row on screen at all times. I'm always reaching for it and it would be nice to just keep it there","author_login":"domportera","author_association":"NONE","created_at":"2023-07-22T05:20:03+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1662660135","fragment_type":"issue_comment","sequence":1,"text":"Glad you find AVNC useful! I have tried to make it as seamless as possible.\n\nThere is already an option to automatically open \"virtual keys\" with the soft-keyboard (`Settings => Input => Virtual keys`). But if you are talking about showing them when connection is started, that can be implemented too.","author_login":"gujjwal00","author_association":"OWNER","created_at":"2023-08-02T17:27:01+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1662696760","fragment_type":"issue_comment","sequence":2,"text":"I do have that option checked, i just would like it on screen by default. Bonus points for an option to have a \"show keyboard\" button on there too ;)","author_login":"domportera","author_association":"NONE","created_at":"2023-08-02T17:55:05+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1662749253","fragment_type":"issue_comment","sequence":3,"text":"I will change the `Open with keyboard` option to a list with three options: Open manually, Open automatically, and Open with keyboard.","author_login":"gujjwal00","author_association":"OWNER","created_at":"2023-08-02T18:35:20+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1714611880","fragment_type":"issue_comment","sequence":4,"text":"Hi,\n\nThank you very much for developing this awesome software.\n\nWhile we're on the subject of on-screen keyboard and when and how to open it, I just wanted to share my experience here:\n- when I'm using AVNC on my phone, for quick sessions, then, the two-finger-tap to open keyboard works well, although I do need to tap and tap and tap to get it right (maybe this action could be backed up by a hardware key, volume-up or volume-down or something)\n- when I'm using AVNC on my tablet, which has a mouse attached to it, for longer sessions, then, I always need android keyboard + virtual keyboard open, so I find myself two-finger-tap-tapping all the time and then I realized that it would be super useful if we could have a global option \"auto open keyboard on session start\"\n\nSo I found this thread and figured, best to join in here.\n\nThanks.\n\nAVNC rocks!","author_login":"AtmanActive","author_association":"NONE","created_at":"2023-09-11T21:30:29+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869687911","fragment_type":"issue_comment","sequence":5,"text":"Although a slightly different request, it's still similar enough that I'm going to share my feedback here.\n\nWhen using a tablet with a thick and strong case, it's really hard to swipe from the edge of the device, as the case goes around the screen. Thus, it takes too many tries to open the sidebar.\n\nI would suggest to incorporate the sidebar buttons into the keyboard bar. Being able to quickly toggle the touchscreen/touchpad behavior without accidentally moving the mouse cursor would be very welcome.\n\nLikewise, it would be nice to have virtual buttons for scrolling up/down and middle-click.\n\nI would like to have the keyboard bar always visible.\n\nI understand this isn't the original request of this issue, but it's related and I didn't want to open another issue for something so similar. (Also, I typed this on AVNC with touch keyboard and a laggy VNC connection.)","author_login":"denilsonsa","author_association":"NONE","created_at":"2023-12-26T17:48:06+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2139659291","fragment_type":"issue_comment","sequence":6,"text":"Hi all, a bit late, but next version will contain many improvements related to virtual keys:\n- Two-row layout, similar to Termux\n- Dedicated button to toggle Android soft-keyboard\n- Persistence of visibility across sessions: Once opened, virtual keys will continue to automatically open on each connection (same goes for closing them)\n- Other changes like a textbox to allow full-fledged editing experience, and long-press to 'lock' meta keys\n\nPreview:\nimage\n\nTest APK: URL","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-05-30T14:17:22+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2139685220","fragment_type":"issue_comment","sequence":7,"text":"oh this is lovely, just tried it! Thank you so much - I've actually since switched back to Remotix because of these issues and I am happy to come back with these changes :)","author_login":"domportera","author_association":"NONE","created_at":"2024-05-30T14:25:26+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2139740534","fragment_type":"issue_comment","sequence":8,"text":"Great! I had hoped to implement these sooner but couldn't get enough free time to properly fix all of these (re #117 , #187) .","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-05-30T14:38:16+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[1513106319],"is_known_query_context":false},{"document_id":"gh_comment_2145580197","fragment_type":"issue_comment","sequence":9,"text":"Two-row layout is great, still one feature request:\non my tablet, this virtual keyboard is only half of my screen width, which is wasting of space.\nHow about make it using the complete with, to also have the \"extended keys\" easy reachable at the same time?","author_login":"bcm314","author_association":"NONE","created_at":"2024-06-03T15:59:01+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2145737702","fragment_type":"issue_comment","sequence":10,"text":"Yeah, its more optimized for mobiles. Making these more configurable is already on my todo list.","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-06-03T17:16:48+08:00","repo_name":"gujjwal00/avnc","issue_id":1816629272,"issue_number":181,"issue_url":"https://github.com/gujjwal00/avnc/issues/181","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1513106319","fragment_type":"issue_description","sequence":0,"text":"Feature request: change behavior of virtual (modifier) keys: short press keys to make them apply to only next key event, long press to have the key be \"sticky\".\nHello,\n\nCould the modifier keys (Shift, Ctrl, Alt, and Meta (Windows)) be made so that a long press causes them to become \"sticky\" (I.e. sticky keys) or applied to every key press until they're turned off with another press please? This is the current behavior of the short press of a modifier key. The reason I ask is because I'd also like the short press of modifier keys to apply only to the next key press, and then deactivate. This is similar behavior to Termux's extra-keys row, but also on many Android soft keyboards short pressing Shift tends to only capitalize the next letter, whereas long pressing Shift tends to activate caps lock.","author_login":"sudomain","author_association":"NONE","created_at":"2022-12-28T19:44:52+08:00","repo_name":"gujjwal00/avnc","issue_id":1513106319,"issue_number":117,"issue_url":"https://github.com/gujjwal00/avnc/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037693965","fragment_type":"issue_comment","sequence":1,"text":"Hi @sudomain , I am working on full re-implementation of virtual keys. The new layout follows the same style as Termux. (There are some differences as the use case is different for AVNC). \n- 2-row layout similar to Termux\n- Meta keys are automatically released on next key press. Long-press to lock meta keys, as described in this particular issue.\n- There are three swipable \"pages\":\n - First two pages contain keys\n - Similar to Termux, third page contains an editbox. It allows you to have full-fledged Android editing experience in a session. When finished, you can send the whole text to server in one go.\n\nFirst page:\nScreenshot_2024-04-04-21-51-23-702_com gaurav avnc debug-edit\n\nEdit box:\nScreenshot_2024-04-04-21-52-25-104_com gaurav avnc debug-edit\n\n---\n\nWhile there are still some rough edges, I would appreciate if you guys can test it.\nTest APK: URL \n\ncc @dp-alvarez","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-04-04T16:41:59+08:00","repo_name":"gujjwal00/avnc","issue_id":1513106319,"issue_number":117,"issue_url":"https://github.com/gujjwal00/avnc/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2037891723","fragment_type":"issue_comment","sequence":2,"text":"That was already on my mind, but then the current implementation got slightly more complex. So I decided to get this working for now, and put custom configuration on hold. Maybe someday it will be implemented, but I don't have any immediate plans for it.\n\nThat said, is there any key missing from current layout?","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-04-04T18:21:17+08:00","repo_name":"gujjwal00/avnc","issue_id":1513106319,"issue_number":117,"issue_url":"https://github.com/gujjwal00/avnc/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156001503","fragment_type":"issue_comment","sequence":3,"text":"v2.5 is now available with this change. \nAnd I will let you know when the keys are more configurable.","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-06-08T11:43:36+08:00","repo_name":"gujjwal00/avnc","issue_id":1513106319,"issue_number":117,"issue_url":"https://github.com/gujjwal00/avnc/issues/117","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2269508140","fragment_type":"issue_comment","sequence":4,"text":"Hi @sudomain I am working on allowing users to configure key layout. Instead of a file, I have added a small UI to customize keys.\n\nTest APK: URL \nGo to `Settings => Input => Virtual Keys => Customize keys` to make changes.","author_login":"gujjwal00","author_association":"OWNER","created_at":"2024-08-05T16:55:34+08:00","repo_name":"gujjwal00/avnc","issue_id":1513106319,"issue_number":117,"issue_url":"https://github.com/gujjwal00/avnc/issues/117","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0319","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Should there be optional `undesirable_object_name()` linter?","query_context":"A number of potential object names can cause trouble because they also represent commonly used function names. \nHere are a few that come to mind (can definitely be expanded based on feedback):\n\nr\nt, c, df, I # (from `{base}` package)\ndata # (from `{utils}` package)\n\nIn edge cases, these produce the cryptic `object of type 'closure' is not subsettable` error:\n\n r\ndf Error in df$x: object of type 'closure' is not subsettable\n\n Created on 2023-01-09 with reprex v2.0.2 \n\nSo should there be an `undesirable_object_name()` linter that would caution users to avoid such variable names?\nExamples that would produce lints:\n\nr\ndf Error in c(2, 2): unused argument (2)\n\n Created on 2023-01-09 with reprex v2.0.2","known_context_document_ids":["gh_issue_1526371184"],"reference_answer":"I wrote something similar to this, the issue is there are several thousand names to check which would make the linter relatively heavy","answer_document_id":"gh_comment_770349416","silver_evidence_path":["gh_comment_1377470917","gh_issue_416404277","gh_comment_770349416"],"evidence_issue_ids":[1526371184,416404277],"source_repo_name":"r-lib/lintr","source_issue_id":1526371184,"source_issue_number":1897,"source_issue_url":"https://github.com/r-lib/lintr/issues/1897","target_repo_name":"r-lib/lintr","target_issue_id":416404277,"target_issue_number":376,"target_issue_url":"https://github.com/r-lib/lintr/issues/376","reference_anchor_document_id":"gh_comment_1377470917","reference_answer_author":"MichaelChirico","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1351,"anchor_target_overlap":0.2432,"target_answer_overlap":0.1667},"issue_created_at":"2023-01-09T21:42:30+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1526371184","fragment_type":"issue_description","sequence":0,"text":"Should there be optional `undesirable_object_name()` linter?\nA number of potential object names can cause trouble because they also represent commonly used function names. \nHere are a few that come to mind (can definitely be expanded based on feedback):\n\nr\nt, c, df, I # (from `{base}` package)\ndata # (from `{utils}` package)\n\nIn edge cases, these produce the cryptic `object of type 'closure' is not subsettable` error:\n\n r\ndf Error in df$x: object of type 'closure' is not subsettable\n\n Created on 2023-01-09 with reprex v2.0.2 \n\nSo should there be an `undesirable_object_name()` linter that would caution users to avoid such variable names?\nExamples that would produce lints:\n\nr\ndf Error in c(2, 2): unused argument (2)\n\n Created on 2023-01-09 with reprex v2.0.2","author_login":"IndrajeetPatil","author_association":"COLLABORATOR","created_at":"2023-01-09T21:42:30+08:00","repo_name":"r-lib/lintr","issue_id":1526371184,"issue_number":1897,"issue_url":"https://github.com/r-lib/lintr/issues/1897","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1377470917","fragment_type":"issue_comment","sequence":1,"text":"Definitely related, but this issue has a much narrower scope in mind. \n\nChecking against every function name in default packages (stats, graphics, grDevices, utils, datasets, methods, base) is going to be an expensive check, so I thought restricting such a check to a few functions might be a good compromise.\n\nMaybe we keep this open until we decide either way in #376?","author_login":"IndrajeetPatil","author_association":"COLLABORATOR","created_at":"2023-01-10T15:47:30+08:00","repo_name":"r-lib/lintr","issue_id":1526371184,"issue_number":1897,"issue_url":"https://github.com/r-lib/lintr/issues/1897","linked_issue_ids":[416404277],"is_known_query_context":false},{"document_id":"gh_comment_1377807064","fragment_type":"issue_comment","sequence":2,"text":"I have an existing implementation that used something like the top 100-most overloaded symbols (at least in our internal code)","author_login":"MichaelChirico","author_association":"COLLABORATOR","created_at":"2023-01-10T20:27:33+08:00","repo_name":"r-lib/lintr","issue_id":1526371184,"issue_number":1897,"issue_url":"https://github.com/r-lib/lintr/issues/1897","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_416404277","fragment_type":"issue_description","sequence":0,"text":"find variables which reuse names from functions or variables in base or recommended packages\nAlthough the code in R itself doesn't follow its own recommendations, it would be nice to lint for times when a variable is defined which overrides the name of something in a base or recommended package. I imagine it would be easy to string match against the contents of those namespaces.\n\nE.g., I would love a lints for:\n\nversion <- \"version is a 'simple.list' in the base package\"\nnames <- c(\"alice\", \"bob\") # oh no, names is a function in base\n\nThis can lead to problems, e.g. when editing the variable declaration, but not updating subsequent uses, since the symbol will still be found, but will often be for a closure, giving opaque errors.\n\nThis would apply to both variables defined within functions, and function arguments, so the following would also be good to lint:\n\nmy_fun <- function(data.frame = cars) head(data.frame)","author_login":"jackwasey","author_association":"NONE","created_at":"2019-03-02T14:48:51+08:00","repo_name":"r-lib/lintr","issue_id":416404277,"issue_number":376,"issue_url":"https://github.com/r-lib/lintr/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_770349416","fragment_type":"issue_comment","sequence":1,"text":"I wrote something similar to this, the issue is there are several thousand names to check which would make the linter relatively heavy","author_login":"MichaelChirico","author_association":"COLLABORATOR","created_at":"2021-01-31T08:58:54+08:00","repo_name":"r-lib/lintr","issue_id":416404277,"issue_number":376,"issue_url":"https://github.com/r-lib/lintr/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_770365139","fragment_type":"issue_comment","sequence":2,"text":"Maybe reusing logic from the `object_usage_linter` and checking for collisions of all of the found symbols within the base & recommended packages would be a lightweight way to implement this.\n\nThat way we wouldn't need a list of all bad object names, but instead dynamically check the (presumably fewer) used symbols against a bunch of loaded namespaces.","author_login":"AshesITR","author_association":"COLLABORATOR","created_at":"2021-01-31T11:12:08+08:00","repo_name":"r-lib/lintr","issue_id":416404277,"issue_number":376,"issue_url":"https://github.com/r-lib/lintr/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1817403049","fragment_type":"issue_comment","sequence":3,"text":"See #2307. It's not as slow as you might expect (though noticeably slower than the fastest+simplest linters)","author_login":"MichaelChirico","author_association":"COLLABORATOR","created_at":"2023-11-18T05:44:44+08:00","repo_name":"r-lib/lintr","issue_id":416404277,"issue_number":376,"issue_url":"https://github.com/r-lib/lintr/issues/376","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1817964328","fragment_type":"issue_comment","sequence":4,"text":"Marking this as closed by #2307. please file any residual FR as a follow-up","author_login":"MichaelChirico","author_association":"COLLABORATOR","created_at":"2023-11-19T20:11:41+08:00","repo_name":"r-lib/lintr","issue_id":416404277,"issue_number":376,"issue_url":"https://github.com/r-lib/lintr/issues/376","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0320","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"New page that lists all Price tag proofs without any prices yet (= open for contribution)?","query_context":"### Story\n\nFollowing changes in the backend - URL - users are now allowed to add prices on PRICE_TAG proofs they do now own. Thus unlocking distributed contribution.\n\nTo kickstart this, we need a page that lists all available proofs open for contribution.\n\n### How\n\nA list of all proofs that have the following caracteristics:\n- type = PRICE_TAG\n- price_count = 0\n- location_id__isnull = False\n\nAnd clear actions for each proof : \n- view full size image\n- add prices\n- add prices via the contribution assistant\n\n### Questions\n\n- how to avoid users adding prices on the same proof ?\n- how to skip proofs that are unreable or without any barcodes displayed ? \n - allow users to tag proofs ?\n\n### Ideas\n\n- display proofs in a random order on each load, to mitigate the risk of having 2 users simultaneously adding prices on the same proof","known_context_document_ids":["gh_issue_2733276404"],"reference_answer":"But I don't understand how with your current `price_tags` model proposal you can store multiple predictions ? It's missing a data JSONField, thus we could simply plug in the ProofPrediction model (or a dedicated `PricePrediction`)","answer_document_id":"gh_comment_2538221833","silver_evidence_path":["gh_comment_2536556615","gh_issue_2725479450","gh_comment_2538221833"],"evidence_issue_ids":[2733276404,2725479450],"source_repo_name":"openfoodfacts/open-prices-frontend","source_issue_id":2733276404,"source_issue_number":1115,"source_issue_url":"https://github.com/openfoodfacts/open-prices-frontend/issues/1115","target_repo_name":"openfoodfacts/open-prices","target_issue_id":2725479450,"target_issue_number":611,"target_issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","reference_anchor_document_id":"gh_comment_2536556615","reference_answer_author":"raphodn","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1786,"anchor_target_overlap":0.2679,"target_answer_overlap":0.2778},"issue_created_at":"2024-12-11T15:22:58+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2733276404","fragment_type":"issue_description","sequence":0,"text":"New page that lists all Price tag proofs without any prices yet (= open for contribution)\n### Story\n\nFollowing changes in the backend - URL - users are now allowed to add prices on PRICE_TAG proofs they do now own. Thus unlocking distributed contribution.\n\nTo kickstart this, we need a page that lists all available proofs open for contribution.\n\n### How\n\nA list of all proofs that have the following caracteristics:\n- type = PRICE_TAG\n- price_count = 0\n- location_id__isnull = False\n\nAnd clear actions for each proof : \n- view full size image\n- add prices\n- add prices via the contribution assistant\n\n### Questions\n\n- how to avoid users adding prices on the same proof ?\n- how to skip proofs that are unreable or without any barcodes displayed ? \n - allow users to tag proofs ?\n\n### Ideas\n\n- display proofs in a random order on each load, to mitigate the risk of having 2 users simultaneously adding prices on the same proof","author_login":"raphodn","author_association":"MEMBER","created_at":"2024-12-11T15:22:58+08:00","repo_name":"openfoodfacts/open-prices-frontend","issue_id":2733276404,"issue_number":1115,"issue_url":"https://github.com/openfoodfacts/open-prices-frontend/issues/1115","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2536556615","fragment_type":"issue_comment","sequence":1,"text":"Displaying proofs at random is enough for now! We should just keep in mind that SQL random() doesn't scale well to huge tables (as seen on Robotoff).\nI wonder whether it's better to wait for URL to be implemented in the backend, as it will make it easier from a front-end perspective:\n- fetch the `price_tag`s with `status=null` randomly\n- annotate (using an interface similar to the 3rd step from the contribution assistant)\n- repeat\n\nAnother game could be to check that no bounding box (=item in the `price_tag` table) is missing, and if there are some, the user draw additional bounding boxes, which become available as new `price_tag`s items to annotate.","author_login":"raphael0202","author_association":"CONTRIBUTOR","created_at":"2024-12-11T16:59:33+08:00","repo_name":"openfoodfacts/open-prices-frontend","issue_id":2733276404,"issue_number":1115,"issue_url":"https://github.com/openfoodfacts/open-prices-frontend/issues/1115","linked_issue_ids":[2725479450],"is_known_query_context":false},{"document_id":"gh_comment_2543352854","fragment_type":"issue_comment","sequence":2,"text":"closing as we'll wait for \"prices to validate list\" instead of this \"proofs to add list\"","author_login":"raphodn","author_association":"MEMBER","created_at":"2024-12-14T21:42:55+08:00","repo_name":"openfoodfacts/open-prices-frontend","issue_id":2733276404,"issue_number":1115,"issue_url":"https://github.com/openfoodfacts/open-prices-frontend/issues/1115","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2725479450","fragment_type":"issue_description","sequence":0,"text":"Add a `price_tags` table to store predictions\nIn #526, we've talked about how to speed up price addition using ML/AI ( URL \n\nFor price tags, the workflow seems now clear:\n\n1. user upload their proof\n2. an object detection model identifies individual price tags. The object detection model returns the coordinates of each detected bounding box, along with a confidence score.\n3. we extract information from the price tags: price, EAN or product category, price type, organic or not\n4. we let the user (and later other users) fix and validate the prediction\n\nStep (2) is currently in development. Once the proof is uploaded, we would ideally run all ML models as an async job.\nFor each detected price tag, we need to store some information:\n\n- the bounding box of the price tag with respect to the original proof\n- the detected price\n- the detected category and/or EAN\n- organic/non-organic\n- the price per (per kg or per unit)\n- origins (for raw products)\n\nI suggest we create a new `price_tags` table. Storing intermediate data in a new table is necessary to allow performing async processing. The user won't have to wait for models to run, and we can distribute workload (=price validation) between contributors. Besides, it allows having gold truth data evaluating and training models that extract information from price tags.\n\n### Schema\n\n- `id`: ID of the price tag\n- `proof_id`: FK to the proof\n- `created`: creation datetime\n- `updated`: datetime of last update\n- `bounding_box`: the coordinates of the bounding box, in relative coordinated as (y_min, x_min, y_max, x_max). The origin is the top-left corner of the image.\n- `status`: The status of the price tag: either a price is already linked for this price tag (status=1), it may be waiting for approval or completion (`status=null`), or it may be invalid (`status=0`, the information cannot be read or is hidden). Only `price_tag`s with `null` status will be suggested in a \"Hunger Games-like\" games.\n\nFields pre-filled by the extraction model (currently Gemini):\n- `predicted_product_code`\n- `predicted_category_tag`\n- `predicted_price`\n- `predicted_price_per`\n- `predicted_price_is_discounted`\n- `price_without_discount`\n- `predicted_currency`\n- `predicted_labels_tags`\n- `predicted_origins_tags`\n\nFields that are derived from predictions, validated by the user. These fields are null before the price tag is validated by the user.\n\n- `price`\n- `price_is_discounted`\n- `price_without_discount`\n- `price_per`\n- `product_code`\n- `category_tag`\n- `currency`\n- `labels_tags`\n- `origins_tags`\n- `models_info` (JSONB): extra information about the version of the models that generated the prediction, about which model was used for what, etc. \n\nWe can add a nullable `price_tag_id` in the `prices` table to keep track of the individual price tag that is behind a price.\n\n### Workflow\n\nWhen a new proof is uploaded, the price tag object detector model is run on the image of the proof. We create one element in the `price_tags` table for each detected price tag (above a fixed threshold).\nFor each detected price tag, we run the Gemini model on it and save the results in the `predicted_*` fields.\nThe `status` of the `price_tag` is null by default. Users can validate the extracted data by calling an endpoint to retrieve all `price_tag`s with `null` status. Once validated, a new price is created linked with the original `price_tag` using the `price_tag_id` foreign key.","author_login":"raphael0202","author_association":"CONTRIBUTOR","created_at":"2024-12-08T19:28:49+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2537227318","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the detailed issue !\n\nA few remarks:\n- after having created a ProofPrediction table (in #511), isn't there similarities we could reuse here ? it might be complexifying, but I see things in steps : \n - first create the PriceTag table that stores a bounding box and a status. that could already be fed to the user in the frontend\n - then create a PriceTagPrediction that stores the result of 1 or multiple models that we run on the image. that we could re-run as well in the future if we improve the model, etc\n- I see this (and the already-created ProofPrediction) in a dedicated `ml` sub-app. The backend should be able to run without these AI. Even if it will become \"core\" to speeding up price collection, we shouldn't make it mandatory.","author_login":"raphodn","author_association":"MEMBER","created_at":"2024-12-11T21:27:16+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2538221833","fragment_type":"issue_comment","sequence":2,"text":"But I don't understand how with your current `price_tags` model proposal you can store multiple predictions ? It's missing a data JSONField, thus we could simply plug in the ProofPrediction model (or a dedicated `PricePrediction`)","author_login":"raphodn","author_association":"MEMBER","created_at":"2024-12-12T08:46:49+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2538296543","fragment_type":"issue_comment","sequence":3,"text":"We don't store multiple predictions (ex: we don't store 2 price prediction by 2 different models). On Robotoff, it turns out after a couple of years that we never needed predictions from 2 models at the same time: when a new model is trained and tested, I just delete all the predictions associated with this model and relaunch the model on all images.","author_login":"raphael0202","author_association":"CONTRIBUTOR","created_at":"2024-12-12T09:14:59+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2538361371","fragment_type":"issue_comment","sequence":4,"text":"Ok but I would be in favor to have the flexibility to do any number of predictions, for instance ones coming from Gemini, and another coming from our own model, and have both show up in the UI to help the user, or help us test/compare while we transition out of GenAI, no ?","author_login":"raphodn","author_association":"MEMBER","created_at":"2024-12-12T09:34:25+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2538594698","fragment_type":"issue_comment","sequence":5,"text":"If you want to keep the flexibility to have any number of predictions of the same type, it's better to have a `PriceTagProofPrediction` as you suggested!\nI'm down for creating this new table then, if we plan to implement model comparison in the front-end :)","author_login":"raphael0202","author_association":"CONTRIBUTOR","created_at":"2024-12-12T11:15:47+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2545234807","fragment_type":"issue_comment","sequence":6,"text":"Updated schema, after the discussions above:\n\n## Schemas\n\n### `price_tags` table\n\n- `id`: ID of the price tag\n- `proof_id`: FK to the proof\n- `price_id`: FK to the price created from this price tag, can be null.\n- `created`: creation datetime\n- `updated`: datetime of last update\n- `bounding_box`: the coordinates of the bounding box, in relative coordinated as (y_min, x_min, y_max, x_max). The origin is the top-left corner of the image. Cannot be null.\n- `status`: The status of the price tag: either a price is already linked for this price tag (status=1), it may be waiting for approval or completion (`status=null`), or it may be invalid (`status=0`, the information cannot be read or is hidden). Only `price_tag`s with `null` status will be suggested in a \"Hunger Games-like\" games.\n- `model_version`: the version of the object detector model that created this price tag. If it was created by a human, this field is null.\n- `created_by`: the name of the user who created the price tag. If the price tag was created automatically after object detection, this field is null.\n- `updated_by`: the name of the user who updated the price tag coordinates. If the price tag was created automatically and never updated, this field is null. \n\n### `price_tag_predictions` table\n\n- `id`: ID of the price tag prediction\n- `type`: type of the prediction. Currently, only one value is supported: `price_tag_extraction`\n- `model_name`: name of the model. Currently, there is only one model: `gemini`\n- `model_version`: version of the model. Currently, there is only one version: `gemini-1.5-flash`\n- `data`: JSONB containing prediction data returned by the model. The schema of the dictionary is specific to the model.\n- `created`: creation datetime\n\n## Workflow\n\nWhen a new proof is uploaded, the price tag object detector model is run on the image of the proof. We create one element in the `price_tags` table for each detected price tag (above a fixed threshold).\nFor each detected price tag, we run the Gemini model on it and create a new `PriceTagPrediction` object in DB linked to the PriceTag.\nThe `status` of the `price_tag` is null by default. Users can validate the extracted data by calling an endpoint to retrieve all `price_tag`s with `null` status. Once validated, a new price is created linked with the original `price_tag` using the `price_tag.price_id` foreign key.","author_login":"raphael0202","author_association":"CONTRIBUTOR","created_at":"2024-12-16T10:45:58+08:00","repo_name":"openfoodfacts/open-prices","issue_id":2725479450,"issue_number":611,"issue_url":"https://github.com/openfoodfacts/open-prices/issues/611","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0322","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Mybatis INSERT foreach case SQLSyntaxErrorException?","query_context":"## Bug Report\n\n### Which version of ShardingSphere did you use?\n5.1.1\n### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?\nShardingSphere-Proxy\n### Expected behavior\nThe following INSERT statement can run normally when calling MySQL directly, but an exception is thrown after using Sharding-Proxy.\n\n@Insert(value = {\" insert into ${tableName} (shapeid, userid, groupid, create_userid, name, type, name_alias, \" +\n \"stringvalue, doublevalue, intvalue, blobvalue, version, datasize, createtime, modifytime, deleted) values\" +\n \" \" +\n \"(#{item.builder.serverPID}, #{item.userID}, #{item.groupID}, #{item.userID}, \" +\n \"#{item.builder.fieldName}, #{item.builder.type}, #{item.builder.fieldName2}, \" +\n \"#{item.builder.stringValue}, #{item.builder.doubleValue}, #{item.builder.intValue}, \" +\n \"#{item.blobValue}, #{item.builder.version}, #{item.dataSize}, \" +\n \"#{item.builder.createTime}, #{item.builder.modifyTime}, #{item.builder.deleted})\" +\n \" \"})\n@Options(useGeneratedKeys=true, keyProperty=\"propertyExList.builder.serverID\", keyColumn=\"id\")\nboolean insertBatchProperty(@Param(\"tableName\") String tableName,\n @Param(\"propertyExList\") List propertyExList);\n\n### Actual behavior\n\n### Error updating database. Cause: java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n### The error may exist in xxx/cn/syncserver/dao/UploadShapeDao.java (best guess)\n### The error may involve xxx.cn.syncserver.dao.UploadShapeDao.insertBatchProperty-Inline\n### The error occurred while setting parameters\n### SQL: insert into shape_property_simple (shapeid, userid, groupid, create_userid, name, type, name_alias, stringvalue, doublevalue, intvalue, blobvalue, version, datasize, createtime, modifytime, deleted) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) , (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)\n### Cause: java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n; bad SQL grammar []; nested exception is java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n\n### Reason analyze (If you can)\nI found that the following insert statement can be executed. The only difference between it and the previous statements with errors is that it does not contain ` (?,?,...)`.\n\n[INFO ] 2022-05-23 15:20:37.162 [ShardingSphere-Command-0] ShardingSphere-SQL - Actual SQL: syncdb1 ::: insert into shape_simple (layerid, userid, create_userid, groupid, type, data, minlevel, maxlevel, version, datasize, legend, createtime, modifytime, deleted, create_version) values (0, 10232, 10232, -1, 1, x'0a1b09c240214c1bc45c4011ee44a401170b4440190000000000000000', 0, 0, 15, 120.0, '', '2022-05-23 15:18:54', '2022-05-23 15:18:54', 0, 15)","known_context_document_ids":["gh_issue_1244706432"],"reference_answer":"Hi @tuichenchuxin \nThe value was recognized as `expr` instead of `blobValue`. I found this may be related to #16493. Could you take a look at this?\n\n<img width=\"1680\" alt=\"image\" src=\" URL \n<img width=\"347\" alt=\"image\" src=\" URL","answer_document_id":"gh_comment_1137041067","silver_evidence_path":["gh_comment_1135445942","gh_issue_1246025932","gh_comment_1137041067"],"evidence_issue_ids":[1244706432,1246025932],"source_repo_name":"apache/shardingsphere","source_issue_id":1244706432,"source_issue_number":17870,"source_issue_url":"https://github.com/apache/shardingsphere/issues/17870","target_repo_name":"apache/shardingsphere","target_issue_id":1246025932,"target_issue_number":17892,"target_issue_url":"https://github.com/apache/shardingsphere/issues/17892","reference_anchor_document_id":"gh_comment_1135445942","reference_answer_author":"TeslaCN","reference_answer_author_association":"MEMBER","quality_score":78.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2727,"target_answer_overlap":0.0625},"issue_created_at":"2022-05-23T07:31:36+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1244706432","fragment_type":"issue_description","sequence":0,"text":"Mybatis INSERT foreach case SQLSyntaxErrorException\n## Bug Report\n\n### Which version of ShardingSphere did you use?\n5.1.1\n### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?\nShardingSphere-Proxy\n### Expected behavior\nThe following INSERT statement can run normally when calling MySQL directly, but an exception is thrown after using Sharding-Proxy.\n\n@Insert(value = {\" insert into ${tableName} (shapeid, userid, groupid, create_userid, name, type, name_alias, \" +\n \"stringvalue, doublevalue, intvalue, blobvalue, version, datasize, createtime, modifytime, deleted) values\" +\n \" \" +\n \"(#{item.builder.serverPID}, #{item.userID}, #{item.groupID}, #{item.userID}, \" +\n \"#{item.builder.fieldName}, #{item.builder.type}, #{item.builder.fieldName2}, \" +\n \"#{item.builder.stringValue}, #{item.builder.doubleValue}, #{item.builder.intValue}, \" +\n \"#{item.blobValue}, #{item.builder.version}, #{item.dataSize}, \" +\n \"#{item.builder.createTime}, #{item.builder.modifyTime}, #{item.builder.deleted})\" +\n \" \"})\n@Options(useGeneratedKeys=true, keyProperty=\"propertyExList.builder.serverID\", keyColumn=\"id\")\nboolean insertBatchProperty(@Param(\"tableName\") String tableName,\n @Param(\"propertyExList\") List propertyExList);\n\n### Actual behavior\n\n### Error updating database. Cause: java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n### The error may exist in xxx/cn/syncserver/dao/UploadShapeDao.java (best guess)\n### The error may involve xxx.cn.syncserver.dao.UploadShapeDao.insertBatchProperty-Inline\n### The error occurred while setting parameters\n### SQL: insert into shape_property_simple (shapeid, userid, groupid, create_userid, name, type, name_alias, stringvalue, doublevalue, intvalue, blobvalue, version, datasize, createtime, modifytime, deleted) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) , (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)\n### Cause: java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n; bad SQL grammar []; nested exception is java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n\n### Reason analyze (If you can)\nI found that the following insert statement can be executed. The only difference between it and the previous statements with errors is that it does not contain ` (?,?,...)`.\n\n[INFO ] 2022-05-23 15:20:37.162 [ShardingSphere-Command-0] ShardingSphere-SQL - Actual SQL: syncdb1 ::: insert into shape_simple (layerid, userid, create_userid, groupid, type, data, minlevel, maxlevel, version, datasize, legend, createtime, modifytime, deleted, create_version) values (0, 10232, 10232, -1, 1, x'0a1b09c240214c1bc45c4011ee44a401170b4440190000000000000000', 0, 0, 15, 120.0, '', '2022-05-23 15:18:54', '2022-05-23 15:18:54', 0, 15)","author_login":"wingkingbobo","author_association":"NONE","created_at":"2022-05-23T07:31:36+08:00","repo_name":"apache/shardingsphere","issue_id":1244706432,"issue_number":17870,"issue_url":"https://github.com/apache/shardingsphere/issues/17870","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1134454929","fragment_type":"issue_comment","sequence":1,"text":"A simple PrepareStatement will also report an error. I wonder if there is a problem with the support of PrepareStatement.\nIn this example, the sharding column is userid.\n\njava\n String jdbcUrl = \"jdbc:mysql://localhost:3307/sharding_db?useUnicode=true&characterEncoding=utf8&useSSL=false&serverTimezone=Asia/Shanghai\";\n// String jdbcUrl = \"jdbc:mysql://localhost:3306/p1?useUnicode=true&characterEncoding=utf8&useSSL=false&serverTimezone=Asia/Shanghai\";\n DriverManager.registerDriver(new Driver());\n Connection connection = DriverManager.getConnection(jdbcUrl, \"root\", \"123456\");\n\n String sql = \"INSERT INTO remark(userid, content, `time`) values (?, ?, ?)\";\n java.sql.Date date = new java.sql.Date(remark.getTime().getTime());\n PreparedStatement statement = connection.prepareStatement(sql);\n statement.setLong(1, remark.getUserId());\n statement.setString(2, remark.getContent());\n statement.setDate(3, date);\n statement.execute();\n\ncom.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'org.apache.shardingsphere.sharding.rewrite.token.pojo.ShardingInsertValuesToken@' at line 1\n at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)\n at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)\n at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)\n at java.lang.reflect.Constructor.newInstance(Constructor.java:423)\n at com.mysql.jdbc.Util.handleNewInstance(Util.java:425)\n at com.mysql.jdbc.Util.getInstance(Util.java:408)\n at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:944)\n at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3978)\n at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3914)\n at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2530)\n at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683)\n at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2495)\n at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1903)\n at com.mysql.jdbc.PreparedStatement.execute(PreparedStatement.java:1242)","author_login":"wingkingbobo","author_association":"NONE","created_at":"2022-05-23T09:54:28+08:00","repo_name":"apache/shardingsphere","issue_id":1244706432,"issue_number":17870,"issue_url":"https://github.com/apache/shardingsphere/issues/17870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1134464148","fragment_type":"issue_comment","sequence":2,"text":"Hi @wingkingbobo, thank you for your feedback, can you provide your sharding configuration?","author_login":"strongduanmu","author_association":"MEMBER","created_at":"2022-05-23T10:01:50+08:00","repo_name":"apache/shardingsphere","issue_id":1244706432,"issue_number":17870,"issue_url":"https://github.com/apache/shardingsphere/issues/17870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1134523050","fragment_type":"issue_comment","sequence":3,"text":"Thank you @wingkingbobo, can you provide your original sql, I will try to reproduce this problem.","author_login":"strongduanmu","author_association":"MEMBER","created_at":"2022-05-23T10:57:00+08:00","repo_name":"apache/shardingsphere","issue_id":1244706432,"issue_number":17870,"issue_url":"https://github.com/apache/shardingsphere/issues/17870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1135346987","fragment_type":"issue_comment","sequence":4,"text":"@strongduanmu \n`MySQLSyntaxErrorException` thrown by prepareStatement seems to be another problem, so I raised an issue #17888 separately.\nFor the current problem, I'm trying to make a simplified demo to reproduce it.","author_login":"wingkingbobo","author_association":"NONE","created_at":"2022-05-24T02:59:56+08:00","repo_name":"apache/shardingsphere","issue_id":1244706432,"issue_number":17870,"issue_url":"https://github.com/apache/shardingsphere/issues/17870","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1135445942","fragment_type":"issue_comment","sequence":5,"text":"@strongduanmu \nThe problem is that the blob length is equal to 0.\nThe description of this issue is incorrect, so I opened a new one #17892.","author_login":"wingkingbobo","author_association":"NONE","created_at":"2022-05-24T06:02:12+08:00","repo_name":"apache/shardingsphere","issue_id":1244706432,"issue_number":17870,"issue_url":"https://github.com/apache/shardingsphere/issues/17870","linked_issue_ids":[1246025932],"is_known_query_context":false},{"document_id":"gh_issue_1246025932","fragment_type":"issue_description","sequence":0,"text":"MyBatis INSERT blob cause SQLSyntaxErrorException when blob length is 0\n## Bug Report\n\n### Which version of ShardingSphere did you use?\n5.1.1\n\n### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?\nShardingSphere-Proxy\n\n### Expected behavior\nexecute insert by mybatis with a blob value.\n\njava\n@Insert(\"INSERT INTO remark(id, userid, content, time, blobValue) \" +\n \"VALUES(null, #{userId}, #{content}, #{time}, #{blobValue})\"\n )\n boolean insert2(RemarkPO remark);\n\n### Actual behavior\n\n### Error updating database. Cause: java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n### The error may exist in rivermap/cn/wemapsyncserver/dao/UploadShapeDao.java (best guess)\n### The error may involve rivermap.cn.wemapsyncserver.dao.UploadShapeDao.insertBatchProperty-Inline\n### The error occurred while setting parameters\n### SQL: insert into dt_shape_property_simple (shapeid, userid, groupid, create_userid, name, type, name_alias, stringvalue, doublevalue, intvalue, blobvalue, version, datasize, createtime, modifytime, deleted) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) , (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)\n### Cause: java.sql.SQLSyntaxErrorException: This version of ShardingSphere-Proxy doesn't yet support this SQL. 'You have an error in your SQL syntax'\n\n### Reason analyze (If you can)\n* Use the configuration mentioned in #17888 and add a `blobvalue` field of `blob` type in the `remark` table.\n\njava\n public class RemarkPO {\n\n private byte[] blobValue;\n\n public byte[] getBlobValue() {\n return blobValue;\n }\n\n public void setBlobValue(byte[] blobValue) {\n this.blobValue = blobValue;\n }\n}\n\n* `insert(remark)`\n* The execution conditions and results are as follows:\n * `remark.setBlobValue(null)`: OK\n * `remark.setBlobValue(new byte[5])`: OK\n * `remark.setBlobValue(new byte[0])`: throw SQLSyntaxErrorException","author_login":"wingkingbobo","author_association":"NONE","created_at":"2022-05-24T05:59:01+08:00","repo_name":"apache/shardingsphere","issue_id":1246025932,"issue_number":17892,"issue_url":"https://github.com/apache/shardingsphere/issues/17892","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1136907201","fragment_type":"issue_comment","sequence":1,"text":"I found the SQL was not rewritten correctly.\n\n[INFO ] 2022-05-25 15:44:55.387 [ShardingSphere-Command-9] ShardingSphere-SQL - Logic SQL: INSERT INTO remark(userid, content, `time`, b) VALUES (4, 'test0', '2022-05-25', _binary'blob')\n[INFO ] 2022-05-25 15:44:55.387 [ShardingSphere-Command-9] ShardingSphere-SQL - SQLStatement: MySQLInsertStatement(setAssignment=Optional.empty, onDuplicateKeyColumns=Optional.empty)\n[INFO ] 2022-05-25 15:44:55.387 [ShardingSphere-Command-9] ShardingSphere-SQL - Actual SQL: p1 ::: INSERT INTO remark(userid, content, `time`, b) VALUES (4, 'test0', '2022-05-25', 'binary'blob')","author_login":"TeslaCN","author_association":"MEMBER","created_at":"2022-05-25T07:48:10+08:00","repo_name":"apache/shardingsphere","issue_id":1246025932,"issue_number":17892,"issue_url":"https://github.com/apache/shardingsphere/issues/17892","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1137041067","fragment_type":"issue_comment","sequence":2,"text":"Hi @tuichenchuxin \nThe value was recognized as `expr` instead of `blobValue`. I found this may be related to #16493. Could you take a look at this?\n\n<img width=\"1680\" alt=\"image\" src=\" URL \n<img width=\"347\" alt=\"image\" src=\" URL","author_login":"TeslaCN","author_association":"MEMBER","created_at":"2022-05-25T09:58:08+08:00","repo_name":"apache/shardingsphere","issue_id":1246025932,"issue_number":17892,"issue_url":"https://github.com/apache/shardingsphere/issues/17892","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0324","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Feature] We need API version for endpoints?","query_context":"Even we are now in alpha phase for our API , I still think we need a version in endpoints.\nThis will let us break api whenever we need to change structure without breaking userspace.\n\nFor example\nright now we are using ` URL endpoint \nmy suggestion is adding version part in this endpoint such as\n` URL `v1` `/{product}.json`\n\nTo keep it backward compatibility we can use redirection for a while\n URL -> URL \n\nAnd whenever we need a break in api we just put new to v2 so v1 users still can continue to get values\nwith a warning that v1 is deprecated and will be removed","known_context_document_ids":["gh_issue_1499930096"],"reference_answer":"This has been implement following the merge of #2080.\n \n \n\nIt will be difficult for us to do this. It would mean we would have to duplicate the API each time we decide to alter the products identifiers. @captn3m0 opened a discussion about that, let's continue there.","answer_document_id":"gh_comment_2848664145","silver_evidence_path":["gh_comment_2848667176","gh_issue_1550719185","gh_comment_2848664145"],"evidence_issue_ids":[1499930096,1550719185],"source_repo_name":"endoflife-date/endoflife.date","source_issue_id":1499930096,"source_issue_number":2066,"source_issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2066","target_repo_name":"endoflife-date/endoflife.date","target_issue_id":1550719185,"target_issue_number":2331,"target_issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","reference_anchor_document_id":"gh_comment_2848667176","reference_answer_author":"marcwrobel","reference_answer_author_association":"MEMBER","quality_score":77.5,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":1.0,"target_answer_overlap":0.05},"issue_created_at":"2022-12-16T10:07:56+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1499930096","fragment_type":"issue_description","sequence":0,"text":"[Feature] We need API version for endpoints\nEven we are now in alpha phase for our API , I still think we need a version in endpoints.\nThis will let us break api whenever we need to change structure without breaking userspace.\n\nFor example\nright now we are using ` URL endpoint \nmy suggestion is adding version part in this endpoint such as\n` URL `v1` `/{product}.json`\n\nTo keep it backward compatibility we can use redirection for a while\n URL -> URL \n\nAnd whenever we need a break in api we just put new to v2 so v1 users still can continue to get values\nwith a warning that v1 is deprecated and will be removed","author_login":"usta","author_association":"MEMBER","created_at":"2022-12-16T10:07:56+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1499930096,"issue_number":2066,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2066","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1354501538","fragment_type":"issue_comment","sequence":1,"text":"@captn3m0 @generalmimon @hebbet @BiNZGi @marcwrobel @adriens","author_login":"usta","author_association":"MEMBER","created_at":"2022-12-16T10:08:30+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1499930096,"issue_number":2066,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2066","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1354558364","fragment_type":"issue_comment","sequence":2,"text":"There's a lot of maintenance burden maintaining old versions of the API, so we'll need some way to avoid that as well. I think just establishing a changelog + announcement process for any API changes should be good enough for now, with current URL redirects to `/v1/`.\n\nLong-term:\n\n- Alpha: API breaks whenever, no guarantees (We're here now)\n- Beta: API schema is stable. We'll announce any changes, breaking or otherwise in advance. Breaking changes will be avoided, as much as possible. Field additions are still possible. Bug fixes are still allowed (such as fixing templates).\n- Stable: Any breaking changes will be implemented via a separate version endpoint. Old endpoints will stay functional for [X] months, and default endpoint (without a version) will upgrade to new version after [Y] months.\n\nDoes this mean we'll need to add endoflife.date as a product on the site 😏 ?","author_login":"captn3m0","author_association":"MEMBER","created_at":"2022-12-16T11:02:16+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1499930096,"issue_number":2066,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2066","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1355871833","fragment_type":"issue_comment","sequence":3,"text":"Does it mean you'll have to maintain old APIs for retro-compat changes ?...","author_login":"adriens","author_association":"CONTRIBUTOR","created_at":"2022-12-17T00:28:49+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1499930096,"issue_number":2066,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2066","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2848667176","fragment_type":"issue_comment","sequence":4,"text":"This has been implement following the merge of #2080.\n\nDuplicate of #2331.","author_login":"marcwrobel","author_association":"MEMBER","created_at":"2025-05-03T15:10:41+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1499930096,"issue_number":2066,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2066","linked_issue_ids":[1550719185],"is_known_query_context":false},{"document_id":"gh_issue_1550719185","fragment_type":"issue_description","sequence":0,"text":"Add API endpoint containing its current version\nAdd API endpoint containing its current version\n\n**Is your feature request related to a problem? Please describe.**\nCurrently, the API is not versioned.\nThis means that every change to its JSON structure, data types or data itself comes up as unexpected to the users.\nIn effect, this breaks applications using the API.\n\nExamples of possibly app-breaking changes to the API:\n URL \n URL \n\n**Describe the solution you'd like**\nAdd API endpoint, in a way that it can be accessed at:\n URL \nand contains:\n`{\"version\":\" \"}`\n\nThis would require support of semantic versioning of the API with major releases being JSON structure, data type changes etc. and minor releases being product / product details value updates.\n\n**Describe alternatives you've considered**\nNone.\n\n**Additional context**\nThis addition would prove endoflife.date more development-friendly.","author_login":"filip-szweda","author_association":"CONTRIBUTOR","created_at":"2023-01-20T11:43:05+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1399304638","fragment_type":"issue_comment","sequence":1,"text":"Suggestion: use `schema_version` instead of version. Version has other meanings in the API, so it might be confusing.\n\nI would like to keep versioning similar to URL which uses the following:","author_login":"captn3m0","author_association":"MEMBER","created_at":"2023-01-21T18:19:09+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1399346538","fragment_type":"issue_comment","sequence":2,"text":"@filip-szweda Our api is still in alpha thus it might be a little unstable , thats the main reason we are trying to implement this one : URL","author_login":"usta","author_association":"MEMBER","created_at":"2023-01-21T22:39:16+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1399460855","fragment_type":"issue_comment","sequence":3,"text":"FYI the approach taken in #2080 is to version the API using the URL (e.g. `/api/v1`, `/api/v2`...) and incrementing the version when there is breaking changes, such as field removal.\n\nThis approach makes more sense in our particular context. It allows us to have multiple and concurrent versions of the API to give time to our users to migrate. This would not be possible with a `version` field because endoflife.date is just a static site.\n\nWe could also add a `version` (or `schema_version`) field in the response. Maybe it would be useful when an older version of the API is removed and old API URLs are redirected to the new API URLs ? What do you think @filip-szweda, @usta, @captn3m0 ?","author_login":"marcwrobel","author_association":"MEMBER","created_at":"2023-01-22T11:36:59+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1399461856","fragment_type":"issue_comment","sequence":4,"text":"It would also be helpful when we make minor schema changes (such as field additions).","author_login":"captn3m0","author_association":"MEMBER","created_at":"2023-01-22T11:42:26+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1401663844","fragment_type":"issue_comment","sequence":5,"text":"I really like your approach in URL 👍\n\nOne thing I'm a bit concerned about are changes to the API that do not add / remove fields like e.g. URL \nDo you think such changes could also increment the API version, perhaps only its minor part (i.e. /api/v1.1, /api/v1.2, /api/v1.3)?","author_login":"filip-szweda","author_association":"NONE","created_at":"2023-01-24T10:02:49+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2848664145","fragment_type":"issue_comment","sequence":6,"text":"This has been implement following the merge of #2080.\n \n \n\nIt will be difficult for us to do this. It would mean we would have to duplicate the API each time we decide to alter the products identifiers. @captn3m0 opened a discussion about that, let's continue there.","author_login":"marcwrobel","author_association":"MEMBER","created_at":"2025-05-03T15:03:46+08:00","repo_name":"endoflife-date/endoflife.date","issue_id":1550719185,"issue_number":2331,"issue_url":"https://github.com/endoflife-date/endoflife.date/issues/2331","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0325","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Merge NDArray inits with fill and random?","query_context":"To reduce the number of initializer overloads for ndarray we could take the `__inits__` that are identical other than having either random or fill and make initializers that default to filling with zeros, and do not allow for the fill to be nonzero if the random argument is true.\n\nmojo\nfn __init__( inout self, *shape: Int, random: Bool = False, order: String = \"C\" ) raises:\n\nand\n\nmojo\nfn __init__( inout self, *shape: Int, fill: Scalar[dtype], order: String = \"C\" ) raises:\n\nbecomes \n\nmojo\nfn __init__( inout self, *shape: Int, fill: Scalar[dtype]=0, random:Bool=False, order: String = \"C\" ) raises:\n if random == True and fill !=0:\n raise Error(\"numojo/core/ndarray:NDArray: __init__(*shape, fill, random)): Error if random is true you cannot set a fill value\")\n\nThis would turn 8 of our initializers into 4 thus reducing our number of initializers from 14 to 10.\n\nThoughts?","known_context_document_ids":["gh_issue_2497803248"],"reference_answer":"Reassigning to Lang as this requires compiler changes in how we import builtins. There's not much the library itself can do short of providing a smaller transitive closure set of builtins/prelude.","answer_document_id":"gh_comment_2106299448","silver_evidence_path":["gh_comment_2330194176","gh_issue_2279527356","gh_comment_2106299448"],"evidence_issue_ids":[2497803248,2279527356],"source_repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","source_issue_id":2497803248,"source_issue_number":96,"source_issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","target_repo_name":"modularml/mojo","target_issue_id":2279527356,"target_issue_number":2529,"target_issue_url":"https://github.com/modularml/mojo/issues/2529","reference_anchor_document_id":"gh_comment_2330194176","reference_answer_author":"JoeLoser","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1,"anchor_target_overlap":0.2,"target_answer_overlap":0.2778},"issue_created_at":"2024-08-30T16:59:54+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2497803248","fragment_type":"issue_description","sequence":0,"text":"Merge NDArray inits with fill and random\nTo reduce the number of initializer overloads for ndarray we could take the `__inits__` that are identical other than having either random or fill and make initializers that default to filling with zeros, and do not allow for the fill to be nonzero if the random argument is true.\n\nmojo\nfn __init__( inout self, *shape: Int, random: Bool = False, order: String = \"C\" ) raises:\n\nand\n\nmojo\nfn __init__( inout self, *shape: Int, fill: Scalar[dtype], order: String = \"C\" ) raises:\n\nbecomes \n\nmojo\nfn __init__( inout self, *shape: Int, fill: Scalar[dtype]=0, random:Bool=False, order: String = \"C\" ) raises:\n if random == True and fill !=0:\n raise Error(\"numojo/core/ndarray:NDArray: __init__(*shape, fill, random)): Error if random is true you cannot set a fill value\")\n\nThis would turn 8 of our initializers into 4 thus reducing our number of initializers from 14 to 10.\n\nThoughts?","author_login":"MadAlex1997","author_association":"COLLABORATOR","created_at":"2024-08-30T16:59:54+08:00","repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","issue_id":2497803248,"issue_number":96,"issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2322988791","fragment_type":"issue_comment","sequence":1,"text":"I would suggest that the `random` argument should be removed completely from this way of creating arrays as it is not obvious that this is uniform distribution between 0 and 1. \nCreating random arrays should be done using `nm.core.random. `. This would make is explicit what kind of random is being created and allow for parameters to be set, like `nm.core.random.randn(mean=1.0, std=2.0)` or `nm.core.random.randint(min=10, max=100)` etc etc. \nWhat do you think @MadAlex1997 ?","author_login":"sandstromviktor","author_association":"CONTRIBUTOR","created_at":"2024-08-31T17:45:37+08:00","repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","issue_id":2497803248,"issue_number":96,"issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2323000129","fragment_type":"issue_comment","sequence":2,"text":"@sandstromviktor It would be better aligned with NumPy that way. Admittedly most of the data structure and initialization stuff was @forFudan and @shivasankarka, I have handled the math and numerics backend part more. Perhaps they would be able to give their reasoning for it being that way?\n\nThe randomly generated scalar/array part of NuMojo is currently pretty limited maybe we could put that on the list for V0.3 along with the many changes for the upgrade to Mojo 24.5.","author_login":"MadAlex1997","author_association":"COLLABORATOR","created_at":"2024-08-31T18:10:16+08:00","repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","issue_id":2497803248,"issue_number":96,"issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2323843156","fragment_type":"issue_comment","sequence":3,"text":"@sandstromviktor I agree with that. Initially we added it to default constructors as mojo `random` module is quite limited. I am implementing some functions for random number generators right now. I will move these random array constructors to that. \n\n@MadAlex1997 what other changes do you have in mind for the randomly generated arrays for NuMojo v0.3?","author_login":"shivasankarka","author_association":"COLLABORATOR","created_at":"2024-09-02T05:26:58+08:00","repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","issue_id":2497803248,"issue_number":96,"issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2324309486","fragment_type":"issue_comment","sequence":4,"text":"I have created a PR #98 with some basic changes for the `random` and `ndarray` module. If you all have any suggestions to improve the random module, please share here or in the PR. Thanks!","author_login":"shivasankarka","author_association":"COLLABORATOR","created_at":"2024-09-02T09:50:48+08:00","repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","issue_id":2497803248,"issue_number":96,"issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2330194176","fragment_type":"issue_comment","sequence":5,"text":"@sandstromviktor Your suggestion is nice.\n\n@MadAlex1997 @shivasankarka, Another reason why we did not have a better `random` module was that the built-in `random` module is imported by default (which is actually a known issue URL This leaking polluted the naming space and caused importing `random` from `numojo` to fail in many cases.\n\nWith this issue fixed, we can improve the `random` module soon.","author_login":"forFudan","author_association":"COLLABORATOR","created_at":"2024-09-04T21:40:45+08:00","repo_name":"Mojo-Numerics-and-Algorithms-group/NuMojo","issue_id":2497803248,"issue_number":96,"issue_url":"https://github.com/Mojo-Numerics-and-Algorithms-group/NuMojo/issues/96","linked_issue_ids":[2279527356],"is_known_query_context":false},{"document_id":"gh_issue_2279527356","fragment_type":"issue_description","sequence":0,"text":"[BUG] Functions, traits, structs and aliases are leaking into builtins and are importable from anywhere\n### Bug description\n\nAs the title says, importing anything without a leading underscore in \"./stdlib/builtin/anything.mojo\" insert it into the list of stuff that does not need to be imported globally.\n\nThe fix should be to make anything that's defined in URL available globally, but not more. And in this file, we will import all the things that should be auto-imported.\n\n### Steps to reproduce\n\nConsider this code:\n\nmojo\ndef main():\n print(now()) # I want this to call time.now()\n\nyou might think that it will not work. Well, if someone, by mistake, imports `now()` into any of the builtin files, this will work.\ne.g. Add `from time import now` in `stdlib/src/builtin/hash.mojo`, then run\n\nbash\n./stdlib/scripts/build-stdlib.sh && MODULAR_MOJO_NIGHTLY_IMPORT_PATH=./build mojo trying_stuff.mojo\n\nIt will happily compile the code and print\n\n13050285013500\n\nImports are all messed up in the stdlib because of this. When doing refactorings, suddently from functions are not auto-imported anymore and sometime some functions are auto-imported while we don't want them to be.\n\nWe should auto-import everything defined in a single file, not a whole package. After all, there are not that many things that should be auto-imported in mojo.\n\n### Suggestion of the fix process\n\nSince changing the imports in the whole stdlib and the internal codebase might cause a huge diff and a lot of conflicts, I will suggest the following:\n\n* we populate `stdlib/src/builtin/__init__.mojo` with the current list of auto-imported names (so too much names, so we don't have to fix everything at once)\n* The compiler devs change the rule for auto-imported names. Auto-import everything in `stdlib/src/builtin/__init__.mojo` instead of everything in `stdlib/src/builtin/*.mojo`. Since we filled `stdlib/src/builtin/__init__.mojo` with everything auto-imported before, no other changes are necessary.\n* We remove progressively names from `stdlib/src/builtin/__init__.mojo` that shouldn't be auto-imported. We can even do one name by one name to avoid too many conflicts or too many changes in one PR.\n\n### System information\n\nshell\nubuntu 22.04 in wsl2\nmodular 0.7.2 (d0adc668)\nmojo 2024.5.323 (1d9276ea)","author_login":"gabrieldemarmiesse","author_association":"CONTRIBUTOR","created_at":"2024-05-05T13:14:09+08:00","repo_name":"modularml/mojo","issue_id":2279527356,"issue_number":2529,"issue_url":"https://github.com/modularml/mojo/issues/2529","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106299448","fragment_type":"issue_comment","sequence":1,"text":"Reassigning to Lang as this requires compiler changes in how we import builtins. There's not much the library itself can do short of providing a smaller transitive closure set of builtins/prelude.","author_login":"JoeLoser","author_association":"COLLABORATOR","created_at":"2024-05-12T16:00:34+08:00","repo_name":"modularml/mojo","issue_id":2279527356,"issue_number":2529,"issue_url":"https://github.com/modularml/mojo/issues/2529","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0326","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"async_task fails to run?","query_context":"Integration tests that rely on `async_task` started failing:\n \n\nTraceback (most recent call last):\n File \"/opt/venv/lib64/python3.8/site-packages/openeogeotrellis/async_task.py\", line 234, in main\n batch_jobs = get_batch_jobs(batch_job_id, user_id)\n File \"/opt/venv/lib64/python3.8/site-packages/openeogeotrellis/async_task.py\", line 201, in get_batch_jobs\n jvm.org.slf4j.MDC.put(jvm.org.openeo.logging.JsonLayout.UserId(), user_id)\n File \"/opt/venv/lib64/python3.8/site-packages/py4j/java_gateway.py\", line 1664, in __getattr__\n raise Py4JError(\"{0} does not exist in the JVM\".format(new_fqn))\npy4j.protocol.Py4JError: org.slf4j.MDC does not exist in the JVM\n\nRunning from the command line shows more details:\n\n`java.lang.NoSuchFieldError: mdc`\n\nProbably has to do with the recent upgrade to Spark 3.5, which upgraded its log4j and slf4j dependencies.","known_context_document_ids":["gh_issue_2862569938"],"reference_answer":"These warnings seem to be from slf4j 1.x. Spark 3.5.0 updated its slf4j dependencies to 2.x and removed the log4j implementation that slf4j 1.x delegates to, hence the warnings.\n\nslf4j 2.x seems to be backwards compatible, so should be a matter of upgrading our own slf4j dependencies. Spark already brings in a suitable log4j implementation.\n\nI linked a branch that already fixes some submodules but there's more work left.","answer_document_id":"gh_comment_2682058397","silver_evidence_path":["gh_comment_2814776110","gh_issue_2878294172","gh_comment_2682058397"],"evidence_issue_ids":[2862569938,2878294172],"source_repo_name":"Open-EO/openeo-geopyspark-driver","source_issue_id":2862569938,"source_issue_number":1054,"source_issue_url":"https://github.com/Open-EO/openeo-geopyspark-driver/issues/1054","target_repo_name":"Open-EO/openeo-geotrellis-extensions","target_issue_id":2878294172,"target_issue_number":382,"target_issue_url":"https://github.com/Open-EO/openeo-geotrellis-extensions/issues/382","reference_anchor_document_id":"gh_comment_2814776110","reference_answer_author":"bossie","reference_answer_author_association":"COLLABORATOR","quality_score":87.84,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.6667,"target_answer_overlap":0.0968},"issue_created_at":"2025-02-19T08:21:25+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2862569938","fragment_type":"issue_description","sequence":0,"text":"async_task fails to run\nIntegration tests that rely on `async_task` started failing:\n \n\nTraceback (most recent call last):\n File \"/opt/venv/lib64/python3.8/site-packages/openeogeotrellis/async_task.py\", line 234, in main\n batch_jobs = get_batch_jobs(batch_job_id, user_id)\n File \"/opt/venv/lib64/python3.8/site-packages/openeogeotrellis/async_task.py\", line 201, in get_batch_jobs\n jvm.org.slf4j.MDC.put(jvm.org.openeo.logging.JsonLayout.UserId(), user_id)\n File \"/opt/venv/lib64/python3.8/site-packages/py4j/java_gateway.py\", line 1664, in __getattr__\n raise Py4JError(\"{0} does not exist in the JVM\".format(new_fqn))\npy4j.protocol.Py4JError: org.slf4j.MDC does not exist in the JVM\n\nRunning from the command line shows more details:\n\n`java.lang.NoSuchFieldError: mdc`\n\nProbably has to do with the recent upgrade to Spark 3.5, which upgraded its log4j and slf4j dependencies.","author_login":"bossie","author_association":"COLLABORATOR","created_at":"2025-02-19T08:21:25+08:00","repo_name":"Open-EO/openeo-geopyspark-driver","issue_id":2862569938,"issue_number":1054,"issue_url":"https://github.com/Open-EO/openeo-geopyspark-driver/issues/1054","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2668538798","fragment_type":"issue_comment","sequence":1,"text":"Removing the Hadoop classpath fixed `async_task`, although this is in the logs:\n\nSLF4J: Failed to load class \"org.slf4j.impl.StaticMDCBinder\".\nSLF4J: Defaulting to no-operation MDCAdapter implementation.\nSLF4J: See URL for further details.\nSLF4J: Failed to load class \"org.slf4j.impl.StaticLoggerBinder\".\nSLF4J: Defaulting to no-operation (NOP) logger implementation\nSLF4J: See URL for further details.","author_login":"bossie","author_association":"COLLABORATOR","created_at":"2025-02-19T12:39:45+08:00","repo_name":"Open-EO/openeo-geopyspark-driver","issue_id":2862569938,"issue_number":1054,"issue_url":"https://github.com/Open-EO/openeo-geopyspark-driver/issues/1054","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2814776110","fragment_type":"issue_comment","sequence":2,"text":"Fixing URL fixed `async_task` logging and got rid of those SLF4J warnings above.","author_login":"bossie","author_association":"COLLABORATOR","created_at":"2025-04-18T07:24:40+08:00","repo_name":"Open-EO/openeo-geopyspark-driver","issue_id":2862569938,"issue_number":1054,"issue_url":"https://github.com/Open-EO/openeo-geopyspark-driver/issues/1054","linked_issue_ids":[2878294172],"is_known_query_context":false},{"document_id":"gh_issue_2878294172","fragment_type":"issue_description","sequence":0,"text":"Logging went missing when running tests\nFor example when running `testWriteMultibandTemporalRDDWithGapsSeparateAssetPerBand`, but probably is an issue with any test.\nThe logs show:\n\nSLF4J: Failed to load class \"org.slf4j.impl.StaticLoggerBinder\".\nSLF4J: Defaulting to no-operation (NOP) logger implementation\nSLF4J: See URL for further details.\nSLF4J: Failed to load class \"org.slf4j.impl.StaticMDCBinder\".\nSLF4J: Defaulting to no-operation MDCAdapter implementation.\nSLF4J: See URL for further details.\n\nAnd then many normal logs are not shown anymore.\n\nFixing the issue here might fix it also for `async_task`: URL \n\ncc @bossie","author_login":"EmileSonneveld","author_association":"CONTRIBUTOR","created_at":"2025-02-25T12:46:02+08:00","repo_name":"Open-EO/openeo-geotrellis-extensions","issue_id":2878294172,"issue_number":382,"issue_url":"https://github.com/Open-EO/openeo-geotrellis-extensions/issues/382","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2682058397","fragment_type":"issue_comment","sequence":1,"text":"These warnings seem to be from slf4j 1.x. Spark 3.5.0 updated its slf4j dependencies to 2.x and removed the log4j implementation that slf4j 1.x delegates to, hence the warnings.\n\nslf4j 2.x seems to be backwards compatible, so should be a matter of upgrading our own slf4j dependencies. Spark already brings in a suitable log4j implementation.\n\nI linked a branch that already fixes some submodules but there's more work left.","author_login":"bossie","author_association":"COLLABORATOR","created_at":"2025-02-25T13:54:48+08:00","repo_name":"Open-EO/openeo-geotrellis-extensions","issue_id":2878294172,"issue_number":382,"issue_url":"https://github.com/Open-EO/openeo-geotrellis-extensions/issues/382","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0327","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[FEATURE] Allow to disable SSL/TLS communication?","query_context":"**Is your feature request related to a problem?**\nThe `security` plugins comes with SSL/TLS communication out of the box. This certainly should be the default, but in certain environments which use other means of secure communication (for example, IPSec), it would be great to offer the option to disable SSL/TLS.\n\n**What solution would you like?**\nOffer the option to disable SSL/TLS.\n\n**What alternatives have you considered?**\nN/A\n\n**Do you have any additional context?**\nIt might not be easy to do but preliminary discussion hinted it is feasible, in general.","known_context_document_ids":["gh_issue_1553693821"],"reference_answer":"Inter node request carries user context (which contains sensitive information like user credential details, roles etc..), hence for securing user's sensitive information we need to enable node to node encryption. \n\nSo, it is not possible to disable SSL at transport layer. \n\nDuplicate of URL","answer_document_id":"gh_comment_491981501","silver_evidence_path":["gh_comment_1671693347","gh_issue_438817381","gh_comment_491981501"],"evidence_issue_ids":[1553693821,438817381],"source_repo_name":"opensearch-project/security","source_issue_id":1553693821,"source_issue_number":2414,"source_issue_url":"https://github.com/opensearch-project/security/issues/2414","target_repo_name":"opensearch-project/security","target_issue_id":438817381,"target_issue_number":37,"target_issue_url":"https://github.com/opensearch-project/security/issues/37","reference_anchor_document_id":"gh_comment_1671693347","reference_answer_author":"hardik-k-shah","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.1698,"target_answer_overlap":0.1923},"issue_created_at":"2023-01-23T19:59:26+08:00","valid_comment_count":28,"fragments":[{"document_id":"gh_issue_1553693821","fragment_type":"issue_description","sequence":0,"text":"[FEATURE] Allow to disable SSL/TLS communication\n**Is your feature request related to a problem?**\nThe `security` plugins comes with SSL/TLS communication out of the box. This certainly should be the default, but in certain environments which use other means of secure communication (for example, IPSec), it would be great to offer the option to disable SSL/TLS.\n\n**What solution would you like?**\nOffer the option to disable SSL/TLS.\n\n**What alternatives have you considered?**\nN/A\n\n**Do you have any additional context?**\nIt might not be easy to do but preliminary discussion hinted it is feasible, in general.","author_login":"reta","author_association":"COLLABORATOR","created_at":"2023-01-23T19:59:26+08:00","repo_name":"opensearch-project/security","issue_id":1553693821,"issue_number":2414,"issue_url":"https://github.com/opensearch-project/security/issues/2414","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1400911074","fragment_type":"issue_comment","sequence":1,"text":"[Triage] @peternied Could you please provide some context around the limitations of the securityadmin tool relying on TLS/SSL?","author_login":"cwperks","author_association":"MEMBER","created_at":"2023-01-23T20:08:35+08:00","repo_name":"opensearch-project/security","issue_id":1553693821,"issue_number":2414,"issue_url":"https://github.com/opensearch-project/security/issues/2414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1402519150","fragment_type":"issue_comment","sequence":2,"text":"There is a functional concern that the security plugin depends on the admin certificate to authenticate a super admin user, without support for this there are many scenarios that are not possible. If the certificate was removed as a requirement for these APIs then this could be opened up.\n\nRelated issues\n- URL \n- URL \n- URL","author_login":"peternied","author_association":"MEMBER","created_at":"2023-01-24T19:54:54+08:00","repo_name":"opensearch-project/security","issue_id":1553693821,"issue_number":2414,"issue_url":"https://github.com/opensearch-project/security/issues/2414","linked_issue_ids":[438817381],"is_known_query_context":false},{"document_id":"gh_comment_1436142620","fragment_type":"issue_comment","sequence":3,"text":"+1 for sure. To basically echo the sentiments of the original thread, #37, if you're already running all nodes and connections within a VPC, the SSL is redundant.","author_login":"JaneJeon","author_association":"NONE","created_at":"2023-02-20T00:13:59+08:00","repo_name":"opensearch-project/security","issue_id":1553693821,"issue_number":2414,"issue_url":"https://github.com/opensearch-project/security/issues/2414","linked_issue_ids":[438817381],"is_known_query_context":false},{"document_id":"gh_comment_1671567368","fragment_type":"issue_comment","sequence":4,"text":"@reta With #2411 [1] merged, I think a large part of this issue is resolved - I am closing. If there are there other features that are not accessible, could you file issues on them or reopen with more details?\n\n- [1] #2411","author_login":"peternied","author_association":"MEMBER","created_at":"2023-08-09T14:55:09+08:00","repo_name":"opensearch-project/security","issue_id":1553693821,"issue_number":2414,"issue_url":"https://github.com/opensearch-project/security/issues/2414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1671693347","fragment_type":"issue_comment","sequence":5,"text":"@peternied From what I understand, the original intent of this request is to disable Transport level TLS (instead of REST-level TLS which the security plugin already supports disabling)\n\nAt one point it looks like this feature may have been under development (See URL but I'm not sure of the status of that. \n\nThe major concern pointed out here is that disabling Transport TLS has consequences for the logic around nodes joining the cluster securely. A major feature of the security plugin is either the static `nodes_dn` setting in `opensearch.yml` or the dynamic `nodes_dn.yml` file which is part of the security index. In order for a node to join the cluster securely it must present a certificate that matches a known node_dn.","author_login":"cwperks","author_association":"MEMBER","created_at":"2023-08-09T15:57:41+08:00","repo_name":"opensearch-project/security","issue_id":1553693821,"issue_number":2414,"issue_url":"https://github.com/opensearch-project/security/issues/2414","linked_issue_ids":[438817381],"is_known_query_context":false},{"document_id":"gh_issue_438817381","fragment_type":"issue_description","sequence":0,"text":"disable TLS for Transport, enable for Rest\nIs it possible to disable encryption for node-to-node transport but have encryption for REST Layer ?\n\nlike to set _false_ for `opendistro_security.ssl.transport.enabled` (and comment/disable `opendistro_security.ssl.transport.*`), \nand keep _true_ for `opendistro_security.ssl.http.enabled`\n\nunfortunately I get \n`Caused by: java.lang.IllegalStateException: opendistro_security.ssl.transport.enabled must be set to 'true'\n`\n\nif security enabled on both, everything works fine.\ndo I miss something?\n\nthanks","author_login":"nean-and-i","author_association":"NONE","created_at":"2019-04-30T14:46:05+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_489065982","fragment_type":"issue_comment","sequence":1,"text":"I think you cannot disable Transport SSL as of now, i have opened a issue for the same\n URL \n\nPossible Duplicate of #36","author_login":"abhijithshivaswamy","author_association":"NONE","created_at":"2019-05-03T11:32:33+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_491981501","fragment_type":"issue_comment","sequence":2,"text":"Inter node request carries user context (which contains sensitive information like user credential details, roles etc..), hence for securing user's sensitive information we need to enable node to node encryption. \n\nSo, it is not possible to disable SSL at transport layer. \n\nDuplicate of URL","author_login":"hardik-k-shah","author_association":"MEMBER","created_at":"2019-05-13T20:51:16+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_493064177","fragment_type":"issue_comment","sequence":3,"text":"@hardik-k-shah , understood, but this depends on the design I'd say.\nThe transport can happen within a data dmz where the traffic is not exposed and the only way to get data in is ingest in front of it and coordinating nodes ,so in this case I'd need encryption on REST layer only.\n\ningest -> node1-node2-...nodeN -> coordinating node\n\nso, if there is no chance to get this integrated it might be worth to remove that from the documentation and config examples.","author_login":"nean-and-i","author_association":"NONE","created_at":"2019-05-16T13:19:28+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_493089899","fragment_type":"issue_comment","sequence":4,"text":"I agree that this would be very convenient in topologies residing in DMZ.\n+1","author_login":"JulienCarnec","author_association":"NONE","created_at":"2019-05-16T14:25:37+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_493098358","fragment_type":"issue_comment","sequence":5,"text":"Hi @nean-and-i @JulienCarnec - Thanks for raising this use case. Can you provide details about scenarios that exist for you in a single DMZ. Currently transport SSL cannot be disabled. Keeping this as an action item to investigate further.","author_login":"alolita","author_association":"MEMBER","created_at":"2019-05-16T14:45:56+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_493182881","fragment_type":"issue_comment","sequence":6,"text":"@alolita , we have ES cluster in a VPC, with Kibana behind a HTTPS Proxy, we use ODFE for Logs, Analytics and Alerting. We do not required HTTPS or Node-to-Node encryption.","author_login":"abhijithshivaswamy","author_association":"NONE","created_at":"2019-05-16T18:33:38+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_493205420","fragment_type":"issue_comment","sequence":7,"text":"Hi @alolita ,\nIn our use-case we use ODFE inside a secured Kubernetes cluster.","author_login":"JulienCarnec","author_association":"NONE","created_at":"2019-05-16T19:42:25+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_493885364","fragment_type":"issue_comment","sequence":8,"text":"Hi @alolita ,\nI'm using an EL cluster in one of our datacenters where I have dedicated ingest nodes for inserting data into the cluster and on the other hand I also have dedicated coordinator nodes for queries.\nThe data nodes are in a dedicated not exposed vlan, so only ingest and coordinator nodes are able to access the data nodes via a dedicated backend connection into the vlan.\nSo everything is separated and there is no chance to access/sniff the transport traffic.\nThis means there are reasonable examples/design/architecture where transport and rest is separated, hence it could make sense to separate encryption.\nI was thinking of avoiding as much additional processing as possible, I want to go for as low latencies as possible on the cluster and saturating its 10G interlinks.","author_login":"nean-and-i","author_association":"NONE","created_at":"2019-05-20T08:18:17+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_631891382","fragment_type":"issue_comment","sequence":9,"text":"Another request for this here... We really only have a need for the authentication backends (LDAP, OIDC et al.) and no need for any encryption support.\n\nThere are really a few sets of different functionality in this plugin that ought to be individually available, (1) encryption (transport and REST layers), (2) authc and (3) authz. \n\nThis issue is even more pressing given that ES's official ECK K8s operator enforces the use of SSL via xpack. With this plugin also forcing its own SSL on the transport layer I imagine there are going to be conflicts, which may prevent the use of this plugin with the official ECK operator (although I am still poking around to find a workaround for this).","author_login":"Atreus-Technologies","author_association":"NONE","created_at":"2020-05-21T05:36:14+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_648885715","fragment_type":"issue_comment","sequence":10,"text":"I am trying to use this plugin in a kubernetes cluster with a service mesh which is already taking care of inter-node secure communication and would also like to turn this off","author_login":"eljohnson92","author_association":"NONE","created_at":"2020-06-24T15:18:10+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_665429673","fragment_type":"issue_comment","sequence":11,"text":"Same here, I am running k8s istio service mesh with mTLS in STRICT mode. I would to turn TLS off.","author_login":"NickDatLe","author_association":"NONE","created_at":"2020-07-29T04:52:35+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_674342626","fragment_type":"issue_comment","sequence":12,"text":"Appreciate that you'd like to enforce sound security practises, but in the age of microservices... terminating TLS is not OFFE's job.","author_login":"publicvirtualvoid","author_association":"NONE","created_at":"2020-08-15T03:39:06+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_677075771","fragment_type":"issue_comment","sequence":13,"text":"@hardik-k-shah what is the product management thoughts about this request. Is this planned to be implemented or there is no plan for this now?","author_login":"SKumarMN","author_association":"NONE","created_at":"2020-08-20T04:58:43+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_688342341","fragment_type":"issue_comment","sequence":14,"text":"I am also facing same issue. We are running a security k8s cluster and it is not that easy to generate correct certs for internode/interpod communication. \nRemoving the requirement to use TLS communication, but still keeping other security features, would be very much welcoming feature.","author_login":"dmpe","author_association":"NONE","created_at":"2020-09-07T13:55:55+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_691147583","fragment_type":"issue_comment","sequence":15,"text":"Ok, I can report some progress for those who want to use this security plugin but are currently unable due to various reasons, eg. related to certs and/or kubernetes. \nBasically, the solution is to heavely adjust helm chart:\n- remove data & master node and use just a client node which gets two additional roles (of being data and master) -> URL \n- because we use traefik as ingress provider (its `ingressroute`), client's ingress has to be adjusted as well. -> URL \n- becasue, your ES client becomes master and data node at the same time, you will need to ensure that you expose a correct set of services -> URL \n- the strategy is then doing following: you expose ES on a (\"public\") ingress, e.g. `elastic.devops.firm.com` and do the same with kibana (with its security plugin) which points to that `httpS://elastic.devops.firm.com`. We run them both fine now, from 1 cluster, and ES is protected by default with password admin:admin which you can change. Same goes to kibana.\n\nThis is by no means optimal because in principle if you have just large cluster (we have just minikube) you dont need to expose ES via ingress. But doing so, puts ES on SSL and kibana is then quite easy for lift off. \nUnfortunately, I am not able to post code here but that should help some people, until this issue will get higher priority in the roadmap. 💯 (which i hope it will)","author_login":"dmpe","author_association":"NONE","created_at":"2020-09-11T15:01:20+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_691397335","fragment_type":"issue_comment","sequence":16,"text":"@dmpe, this issue is not related to helm charts or K8s. It requests an option to disable TLS at the transport layer in Opendistro. It is not related to Traefik, Helm deployments, Minikube, or other aspects of a K8s setup.\n\nCan you please edit your comment to make it clear that it does not resolve the issue, or (better!) delete your comment here and create a new issue describing your workaround?\n\nWhile it may help some users, I am concerned your comment implies that there is a workaround. This might lead to premature closure of the issue (if the maintainers actually checked their Github issues, which I suspect they do not, but still...)\n\nHappy to provide you some advice on your setup for if you want to dm me @MilesGarnsey on Twitter.","author_login":"Atreus-Technologies","author_association":"NONE","created_at":"2020-09-12T03:36:15+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_692510187","fragment_type":"issue_comment","sequence":17,"text":"Sorry for the delay! \nWe will bring this to our next prioritization meeting and update here soon.","author_login":"hardik-k-shah","author_association":"MEMBER","created_at":"2020-09-15T07:00:48+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_696495654","fragment_type":"issue_comment","sequence":18,"text":"hey @hardik-k-shah - do you have an ETA of when the update of when we would be able to turn off inter-node TLS through elasticsearch.yml?","author_login":"NickDatLe","author_association":"NONE","created_at":"2020-09-22T03:57:14+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_696554060","fragment_type":"issue_comment","sequence":19,"text":"Hello all,\n\nYes, we have discussed this issue internally and decided that for benefit of ODFE community, we will be supporting configuration to disable TLS. (Though we strongly recommend not to disable TLS).\n\nAnd we are currently testing TLS disabling feature. \nSame time we are also working on introducing Dual Mode (so moving from TLS disable to enable will become simpler without down time. )\n\nThank you all.","author_login":"hardik-k-shah","author_association":"MEMBER","created_at":"2020-09-22T07:24:29+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_699640065","fragment_type":"issue_comment","sequence":20,"text":"@hardik-k-shah will it be available in next release ? 1.10.1 ? thanks","author_login":"lukasmrtvy","author_association":"NONE","created_at":"2020-09-27T14:08:01+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_731238393","fragment_type":"issue_comment","sequence":21,"text":"I've brought this issue up in the meetup couple of weeks ago but didn't get any response yet. \nI do not see this into the current roadmap either. Is this something that is being worked on, or not yet?\n\nThanks a lot in advance for any info.","author_login":"spapadop","author_association":"NONE","created_at":"2020-11-20T15:33:32+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_736027086","fragment_type":"issue_comment","sequence":22,"text":"@spapadop Sorry we missed this one from the community meeting a while ago but I'm checking into it now.","author_login":"stockholmux","author_association":"NONE","created_at":"2020-11-30T20:34:33+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_961030252","fragment_type":"issue_comment","sequence":23,"text":"@spapadop Not sure, to be honest. I know the team has been juggled a bit. Let me find out. Maybe @davidlago knows about the mysterious roadmap item?","author_login":"stockholmux","author_association":"MEMBER","created_at":"2021-11-04T14:17:42+08:00","repo_name":"opensearch-project/security","issue_id":438817381,"issue_number":37,"issue_url":"https://github.com/opensearch-project/security/issues/37","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0329","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"\"ValueError: value.index does not match parent’s axis 0 names\" error when trying to read h5ad that was processed through scVI?","query_context":"Hi !\n\nI am new to the Scanpy/Anndata ecosystem, and trying to use scVI for data integration.\n\nI trained a scVI model on an Anndata object, saved the object as h5ad, and now I get an error when trying to read the file.\n\nThe error occurs when using scanpy.read_h5ad or scvi.data.read_h5ad, and I found someone else reporting the error in this repo before , so I am posting the issue here. Kindly let me know if I should post this somewhere else.\n\npy\nadipo_all = scvi.data.read_h5ad(\"/home/yyyyy/analysis/anndata_working/adipo_sn_01112021_trained_v1.h5ad\")\n\npytb\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/anndata.py:120: ImplicitModificationWarning: Transforming to str index.\n warnings.warn(\"Transforming to str index.\", ImplicitModificationWarning)\n\n---------------------------------------------------------------------------\nValueError Traceback (most recent call last)\n/scratch/33545574/ipykernel_5065/2292619582.py in \n----> 1 adipo_all = scvi.data.read_h5ad(\"/home/yyyyy/analysis/anndata_working/adipo_sn_01112021_trained_v1.h5ad\")\n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_io/h5ad.py in read_h5ad(filename, backed, as_sparse, as_sparse_fmt, chunk_size)\n 435 _clean_uns(d) # backwards compat\n 436 \n--> 437 return AnnData(**d)\n 438 \n 439 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/anndata.py in __init__(self, X, obs, var, uns, obsm, varm, layers, raw, dtype, shape, filename, filemode, asview, obsp, varp, oidx, vidx)\n 320 varp=varp,\n 321 filename=filename,\n--> 322 filemode=filemode,\n 323 )\n 324 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/anndata.py in _init_as_actual(self, X, obs, var, uns, obsm, varm, varp, obsp, raw, layers, dtype, shape, filename, filemode)\n 508 \n 509 # TODO: Think about consequences of making obsm a group in hdf\n--> 510 self._obsm = AxisArrays(self, 0, vals=convert_to_dict(obsm))\n 511 self._varm = AxisArrays(self, 1, vals=convert_to_dict(varm))\n 512 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/aligned_mapping.py in __init__(self, parent, axis, vals)\n 233 self._data = dict()\n 234 if vals is not None:\n--> 235 self.update(vals)\n 236 \n 237 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/_collections_abc.py in update(*args, **kwds)\n Supraclavicular 839 if isinstance(other, Mapping):\n 840 for key in other:\n--> 841 self[key] = other[key]\n 842 elif hasattr(other, \"keys\"):\n 843 for key in other.keys():\n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/aligned_mapping.py in __setitem__(self, key, value)\n 149 \n 150 def __setitem__(self, key: str, value: V):\n--> 151 value = self._validate_value(value, key)\n 152 self._data[key] = value\n 153 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/aligned_mapping.py in _validate_value(self, val, key)\n 211 # Could probably also re-order index if it’s contained\n 212 raise ValueError(\n--> 213 f\"value.index does not match parent’s axis {self.axes[0]} names\"\n 214 )\n 215 return super()._validate_value(val, key)\n\nValueError: value.index does not match parent’s axis 0 names\n\nThis is the offending anndata object. \n\nAnnData object with n_obs × n_vars = 123472 × 36795\n obs: 'orig.ident', 'nCount_RNA', 'nFeature_RNA', 'nCount_spliced', 'nFeature_spliced', 'nCount_unspliced', 'nFeature_unspliced', 'nCount_HTO', 'nFeature_HTO', 'HTO_maxID', 'HTO_secondID', 'HTO_margin', 'HTO_classification', 'HTO_classification.global', 'hash.ID', 'nCount_SCT', 'nFeature_SCT', 'batch', 'n_genes', 'annot', 'sample_origin', 'day', 'depot', 'tissue', 'timepoint', 'n_genes_by_counts', 'total_counts', 'total_counts_percent_ribo', 'pct_counts_percent_ribo', '_scvi_batch', '_scvi_labels'\n var: 'features', 'spliced_features', 'unspliced_features', 'n_cells', 'highly_variable', 'highly_variable_rank', 'means', 'variances', 'variances_norm', 'highly_variable_nbatches', 'percent_ribo', 'n_cells_by_counts', 'mean_counts', 'pct_dropout_by_counts', 'total_counts'\n uns: 'hvg', 'sample_origin_colors', 'depot_colors', '_scvi'\n obsm: '_scvi_extra_categoricals', '_scvi_extra_continuous', 'X_scVI'\n layers: 'counts', 'spliced', 'unspliced'\n \n\n \nWhereas the previous version below can be read just fine. scanpy.pp.highly_variable_genes and sc.pp.calculate_qc_metrics were run followed by model training in scVI to get the above anndata.\n\nAnnData object with n_obs × n_vars = 123472 × 36795\n obs: 'orig.ident', 'nCount_RNA', 'nFeature_RNA', 'nCount_spliced', 'nFeature_spliced', 'nCount_unspliced', 'nFeature_unspliced', 'nCount_HTO', 'nFeature_HTO', 'HTO_maxID', 'HTO_secondID', 'HTO_margin', 'HTO_classification', 'HTO_classification.global', 'hash.ID', 'nCount_SCT', 'nFeature_SCT', 'batch', 'n_genes', 'annot', 'sample_origin', 'day', 'depot', 'tissue', 'timepoint'\n var: 'features', 'spliced_features', 'unspliced_features', 'n_cells'\n layers: 'counts', 'spliced', 'unspliced'\n\n \n**Libraries: scanpy==1.8.1 anndata==0.7.6 umap==0.5.1 numpy==1.20.3 scipy==1.7.1 pandas==1.3.3 scikit-learn==0.24.2 statsmodels==0.13.0rc0 python-igraph==0.9.6 pynndescent==0.5.4**","known_context_document_ids":["gh_issue_1041327967"],"reference_answer":"I'm not the biggest fan of it either, but it's hard to move away from. Ideally there would be entirely separate methods for positional indexing and label based indexing (i.e. `loc` and `iloc`) but that isn't our API. When I first came across this, implementing that kind of API would have been very difficult, though could be easier now. For backwards compatibility we could probably never support integer label based access with `adata[idx]` syntax. There are also a lot of assumptions built into the ecosystem about this.\n\n-------------------------------\n\npython\nadata = sc.AnnData(data)\nadata.obsm['X'] = data\n\n@flying-sheep, if the passed object has a numeric index, we could try converting it to strings and check if that matches?\n\n----------------------\n\n@dburkhardt, there are some previous issues on this topic you might be interested in:\n\n* URL \n* URL","answer_document_id":"gh_comment_582732350","silver_evidence_path":["gh_comment_1603993299","gh_issue_557066977","gh_comment_582732350"],"evidence_issue_ids":[1041327967,557066977],"source_repo_name":"scverse/anndata","source_issue_id":1041327967,"source_issue_number":635,"source_issue_url":"https://github.com/scverse/anndata/issues/635","target_repo_name":"scverse/anndata","target_issue_id":557066977,"target_issue_number":311,"target_issue_url":"https://github.com/scverse/anndata/issues/311","reference_anchor_document_id":"gh_comment_1603993299","reference_answer_author":"ivirshup","reference_answer_author_association":"COLLABORATOR","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2222,"target_answer_overlap":0.12},"issue_created_at":"2021-11-01T15:57:06+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1041327967","fragment_type":"issue_description","sequence":0,"text":"\"ValueError: value.index does not match parent’s axis 0 names\" error when trying to read h5ad that was processed through scVI\nHi !\n\nI am new to the Scanpy/Anndata ecosystem, and trying to use scVI for data integration.\n\nI trained a scVI model on an Anndata object, saved the object as h5ad, and now I get an error when trying to read the file.\n\nThe error occurs when using scanpy.read_h5ad or scvi.data.read_h5ad, and I found someone else reporting the error in this repo before , so I am posting the issue here. Kindly let me know if I should post this somewhere else.\n\npy\nadipo_all = scvi.data.read_h5ad(\"/home/yyyyy/analysis/anndata_working/adipo_sn_01112021_trained_v1.h5ad\")\n\npytb\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/anndata.py:120: ImplicitModificationWarning: Transforming to str index.\n warnings.warn(\"Transforming to str index.\", ImplicitModificationWarning)\n\n---------------------------------------------------------------------------\nValueError Traceback (most recent call last)\n/scratch/33545574/ipykernel_5065/2292619582.py in \n----> 1 adipo_all = scvi.data.read_h5ad(\"/home/yyyyy/analysis/anndata_working/adipo_sn_01112021_trained_v1.h5ad\")\n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_io/h5ad.py in read_h5ad(filename, backed, as_sparse, as_sparse_fmt, chunk_size)\n 435 _clean_uns(d) # backwards compat\n 436 \n--> 437 return AnnData(**d)\n 438 \n 439 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/anndata.py in __init__(self, X, obs, var, uns, obsm, varm, layers, raw, dtype, shape, filename, filemode, asview, obsp, varp, oidx, vidx)\n 320 varp=varp,\n 321 filename=filename,\n--> 322 filemode=filemode,\n 323 )\n 324 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/anndata.py in _init_as_actual(self, X, obs, var, uns, obsm, varm, varp, obsp, raw, layers, dtype, shape, filename, filemode)\n 508 \n 509 # TODO: Think about consequences of making obsm a group in hdf\n--> 510 self._obsm = AxisArrays(self, 0, vals=convert_to_dict(obsm))\n 511 self._varm = AxisArrays(self, 1, vals=convert_to_dict(varm))\n 512 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/aligned_mapping.py in __init__(self, parent, axis, vals)\n 233 self._data = dict()\n 234 if vals is not None:\n--> 235 self.update(vals)\n 236 \n 237 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/_collections_abc.py in update(*args, **kwds)\n Supraclavicular 839 if isinstance(other, Mapping):\n 840 for key in other:\n--> 841 self[key] = other[key]\n 842 elif hasattr(other, \"keys\"):\n 843 for key in other.keys():\n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/aligned_mapping.py in __setitem__(self, key, value)\n 149 \n 150 def __setitem__(self, key: str, value: V):\n--> 151 value = self._validate_value(value, key)\n 152 self._data[key] = value\n 153 \n\n/home/xxxxx/pyenv_custom/py_scanalysis_env/lib/python3.7/site-packages/anndata/_core/aligned_mapping.py in _validate_value(self, val, key)\n 211 # Could probably also re-order index if it’s contained\n 212 raise ValueError(\n--> 213 f\"value.index does not match parent’s axis {self.axes[0]} names\"\n 214 )\n 215 return super()._validate_value(val, key)\n\nValueError: value.index does not match parent’s axis 0 names\n\nThis is the offending anndata object. \n\nAnnData object with n_obs × n_vars = 123472 × 36795\n obs: 'orig.ident', 'nCount_RNA', 'nFeature_RNA', 'nCount_spliced', 'nFeature_spliced', 'nCount_unspliced', 'nFeature_unspliced', 'nCount_HTO', 'nFeature_HTO', 'HTO_maxID', 'HTO_secondID', 'HTO_margin', 'HTO_classification', 'HTO_classification.global', 'hash.ID', 'nCount_SCT', 'nFeature_SCT', 'batch', 'n_genes', 'annot', 'sample_origin', 'day', 'depot', 'tissue', 'timepoint', 'n_genes_by_counts', 'total_counts', 'total_counts_percent_ribo', 'pct_counts_percent_ribo', '_scvi_batch', '_scvi_labels'\n var: 'features', 'spliced_features', 'unspliced_features', 'n_cells', 'highly_variable', 'highly_variable_rank', 'means', 'variances', 'variances_norm', 'highly_variable_nbatches', 'percent_ribo', 'n_cells_by_counts', 'mean_counts', 'pct_dropout_by_counts', 'total_counts'\n uns: 'hvg', 'sample_origin_colors', 'depot_colors', '_scvi'\n obsm: '_scvi_extra_categoricals', '_scvi_extra_continuous', 'X_scVI'\n layers: 'counts', 'spliced', 'unspliced'\n \n\n \nWhereas the previous version below can be read just fine. scanpy.pp.highly_variable_genes and sc.pp.calculate_qc_metrics were run followed by model training in scVI to get the above anndata.\n\nAnnData object with n_obs × n_vars = 123472 × 36795\n obs: 'orig.ident', 'nCount_RNA', 'nFeature_RNA', 'nCount_spliced', 'nFeature_spliced', 'nCount_unspliced', 'nFeature_unspliced', 'nCount_HTO', 'nFeature_HTO', 'HTO_maxID', 'HTO_secondID', 'HTO_margin', 'HTO_classification', 'HTO_classification.global', 'hash.ID', 'nCount_SCT', 'nFeature_SCT', 'batch', 'n_genes', 'annot', 'sample_origin', 'day', 'depot', 'tissue', 'timepoint'\n var: 'features', 'spliced_features', 'unspliced_features', 'n_cells'\n layers: 'counts', 'spliced', 'unspliced'\n\n \n**Libraries: scanpy==1.8.1 anndata==0.7.6 umap==0.5.1 numpy==1.20.3 scipy==1.7.1 pandas==1.3.3 scikit-learn==0.24.2 statsmodels==0.13.0rc0 python-igraph==0.9.6 pynndescent==0.5.4**","author_login":"nagendraKU","author_association":"NONE","created_at":"2021-11-01T15:57:06+08:00","repo_name":"scverse/anndata","issue_id":1041327967,"issue_number":635,"issue_url":"https://github.com/scverse/anndata/issues/635","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1142512507","fragment_type":"issue_comment","sequence":1,"text":"I had a similar error and doing the following resolved the error. Make sure all 'obsm' objects that are dataframes have the same index as the 'obs' dataframe.","author_login":"cinaljess","author_association":"NONE","created_at":"2022-05-31T18:32:21+08:00","repo_name":"scverse/anndata","issue_id":1041327967,"issue_number":635,"issue_url":"https://github.com/scverse/anndata/issues/635","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603993299","fragment_type":"issue_comment","sequence":2,"text":"Seems like this is solved, and the discussion happens in #311 \n\nPlease tell us if you need anything","author_login":"flying-sheep","author_association":"MEMBER","created_at":"2023-06-23T09:20:36+08:00","repo_name":"scverse/anndata","issue_id":1041327967,"issue_number":635,"issue_url":"https://github.com/scverse/anndata/issues/635","linked_issue_ids":[557066977],"is_known_query_context":false},{"document_id":"gh_issue_557066977","fragment_type":"issue_description","sequence":0,"text":"Is logging \"Transforming to str index.\" necessary?\nI do a lot of moving back and forth between DataFrames and AnnData objects, and the \"Transforming to str index.\" warning can get annoying, especially if I'm running things in a loop:\n\n<img width=\"1052\" alt=\"image\" src=\" URL \n\nIn these cases, I'm creating a DataFrame using something like:\n\npython\ndata = np.random.normal(size=(1000,100))\ndata = pd.DataFrame(data)\n... # code that expects data as a DataFrame\nadata = sc.AnnData(data)\n\nDoes this need to be logged in a manner that is printed by default? Is there an easy way to disable this?\n\nIt looks like this is the offending line\n URL","author_login":"dburkhardt","author_association":"CONTRIBUTOR","created_at":"2020-01-29T19:26:10+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_580132609","fragment_type":"issue_comment","sequence":1,"text":"It was introduced in 34f4eb63710628fbc15e7050e5efcac1d7806062\n\nIt triggers even if we have a RangeIndex, which shouldn’t trigger a warning.\n\nI’m not sure if a Int64Index should trigger a warning, as it’s easy to get one by slicing a DataFrame with a RangeIndex.","author_login":"flying-sheep","author_association":"MEMBER","created_at":"2020-01-30T08:09:09+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582094623","fragment_type":"issue_comment","sequence":2,"text":"I also realized this bug raises an index error when you try to add `obs` annotations using a rangeindex:\n\npython\nimport scanpy as sc\nimport pandas as pd\nimport numpy as np\ndata = pd.DataFrame(np.random.normal(size=(100,2)))\n\nadata = sc.AnnData(data)\nadata.obsm['X'] = data\nTransforming to str index.\nTransforming to str index.\n\n---------------------------------------------------------------------------\nValueError Traceback (most recent call last)\n in \n 5 \n 6 adata = sc.AnnData(data)\n----> 7 adata.obsm['X'] = data\n\n~/.local/lib/python3.8/site-packages/anndata/_core/aligned_mapping.py in __setitem__(self, key, value)\n 148 \n 149 def __setitem__(self, key: str, value: V):\n--> 150 value = self._validate_value(value, key)\n 151 self._data[key] = value\n 152 \n\n~/.local/lib/python3.8/site-packages/anndata/_core/aligned_mapping.py in _validate_value(self, val, key)\n 209 ):\n 210 # Could probably also re-order index if it’s contained\n--> 211 raise ValueError(\n 212 f\"value.index does not match parent’s axis {self.axes[0]} names\"\n 213 )\n\nValueError: value.index does not match parent’s axis 0 names","author_login":"dburkhardt","author_association":"NONE","created_at":"2020-02-04T20:14:52+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582099412","fragment_type":"issue_comment","sequence":3,"text":"What's the reason for changing the index to str in the first place? Why not use the pd.Index object passed when you create the AnnData object?","author_login":"dburkhardt","author_association":"NONE","created_at":"2020-02-04T20:27:02+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582262579","fragment_type":"issue_comment","sequence":4,"text":"AnnData objects use positional indexing when you supply numeric indices, but access by name when pass strings. If we allowed numeric indices that would statements like: `adata[0]` ambiguous. There's a little more detail on this in the AnnData docstring notes.\n\n@flying-sheep, this is a logging warning, not an actual `warnings.Warning` right? It should probably be an actual warning so it's easier to catch and silence.","author_login":"ivirshup","author_association":"COLLABORATOR","created_at":"2020-02-05T06:33:31+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582294160","fragment_type":"issue_comment","sequence":5,"text":"Default behavior is that warnings display once per location where it’s raised: URL \n\ndoes that mean it gets shown once per location where it’s raised? that would be bad, as we want it to show every time a new AnnData object is created or has its index replaced.","author_login":"flying-sheep","author_association":"MEMBER","created_at":"2020-02-05T08:25:04+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582298730","fragment_type":"issue_comment","sequence":6,"text":"Hmm. I'm not quite sure. I had thought location meant context/ stack-level, but I'm not sure if that's true. It'll definitely warn less than @dburkhardt is reporting:\n\npython\nIn [1]: import warnings \n\nIn [2]: def dangerous(): \n ...: warnings.warn(\"Woah there!\", UserWarning) \n ...: \n\nIn [3]: def foo(): \n ...: for i in range(10): \n ...: dangerous() \n ...: \n\nIn [4]: foo() \n/usr/local/bin/ipython:2: UserWarning: Woah there!\n # -*- coding: utf-8 -*-\n\nIn [5]: foo() \n/usr/local/bin/ipython:2: UserWarning: Woah there!\n # -*- coding: utf-8 -*-","author_login":"ivirshup","author_association":"COLLABORATOR","created_at":"2020-02-05T08:38:23+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582456358","fragment_type":"issue_comment","sequence":7,"text":"Thanks for the help here all! I don't think this issue is closed though as the following code will still raise an error, when I don't think it should:\n\npython\nimport scanpy as sc\nimport pandas as pd\nimport numpy as np\ndata = pd.DataFrame(np.random.normal(size=(100,2)))\n\nadata = sc.AnnData(data)\nadata.obsm['X'] = data\n\nThanks for the clarification on positional vs names indices @ivirshup. I'm not sure that I like this paradigm of assuming that there need be `str` labels for each column. I understand that in the context of scRNA-seq one will often have cell barcodes, but it was my impression that `AnnData` is meant to be a more generalized data storage class (hence little mention of any specific technology in the docs). I usually think of it as `pd.DataFrame`-plus. \n\nI often have data with only numeric positional indices. It would be nice to have full support for this use-case correct? Shouldn't that code above work properly without raising an error? I think to do that you might need to let users who don't have non-numeric `obs_names` or `var_names`.\n\nAnother consideration here is what to do if I were to select a subset of that DataFrame before creating the AnnData object:\n\npython\nadata = sc.AnnData(data.iloc[10:])\n\nthen the `obs` at position `0` will have index `10` in the DataFrame.","author_login":"dburkhardt","author_association":"NONE","created_at":"2020-02-05T15:16:45+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582585635","fragment_type":"issue_comment","sequence":8,"text":"It does? I thought we test if a DataFrame has a RangedIndex and don’t warn if it’s the case.","author_login":"flying-sheep","author_association":"MEMBER","created_at":"2020-02-05T20:00:38+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582732350","fragment_type":"issue_comment","sequence":9,"text":"I'm not the biggest fan of it either, but it's hard to move away from. Ideally there would be entirely separate methods for positional indexing and label based indexing (i.e. `loc` and `iloc`) but that isn't our API. When I first came across this, implementing that kind of API would have been very difficult, though could be easier now. For backwards compatibility we could probably never support integer label based access with `adata[idx]` syntax. There are also a lot of assumptions built into the ecosystem about this.\n\n-------------------------------\n\npython\nadata = sc.AnnData(data)\nadata.obsm['X'] = data\n\n@flying-sheep, if the passed object has a numeric index, we could try converting it to strings and check if that matches?\n\n----------------------\n\n@dburkhardt, there are some previous issues on this topic you might be interested in:\n\n* URL \n* URL","author_login":"ivirshup","author_association":"COLLABORATOR","created_at":"2020-02-06T04:33:21+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_582803335","fragment_type":"issue_comment","sequence":10,"text":"that would work I guess. not really pretty, but I can’t think of how it would have unintentional side effects","author_login":"flying-sheep","author_association":"MEMBER","created_at":"2020-02-06T09:03:57+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1630961732","fragment_type":"issue_comment","sequence":11,"text":"Let’s track this in #31. #954 fixed a bit more issues with strings.","author_login":"flying-sheep","author_association":"MEMBER","created_at":"2023-07-11T14:42:41+08:00","repo_name":"scverse/anndata","issue_id":557066977,"issue_number":311,"issue_url":"https://github.com/scverse/anndata/issues/311","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0330","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Ren'Py Launcher Not Responding?","query_context":"Hello!\n\nI recently got back into Renpy. I downloaded the latest build, Renpy 8.3.2. It worked fine at first, but now, for some reason, the launcher will not work. It instantly goes into \"not responding.\" I have tried reinstalling and installing it into a different folder path. Nothing has worked.\n\nThis issue started a bit after installing VS Code and its extensions for Renpy and Python, such as Pylance. However, I am not positive if its directly responsible for the issue, since after uninstalling it the issue stayed.\n\nThe log file says everything loaded fine, there is no traceback file.\n\nAny help would be much appreciated!","known_context_document_ids":["gh_issue_2597005133"],"reference_answer":"I'm closing this, as it's likely to be some other process that's causing this problem.","answer_document_id":"gh_comment_1962783467","silver_evidence_path":["gh_comment_2422444337","gh_issue_2107939511","gh_comment_1962783467"],"evidence_issue_ids":[2597005133,2107939511],"source_repo_name":"renpy/renpy","source_issue_id":2597005133,"source_issue_number":5846,"source_issue_url":"https://github.com/renpy/renpy/issues/5846","target_repo_name":"renpy/renpy","target_issue_id":2107939511,"target_issue_number":5325,"target_issue_url":"https://github.com/renpy/renpy/issues/5325","reference_anchor_document_id":"gh_comment_2422444337","reference_answer_author":"renpytom","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1176,"anchor_target_overlap":0.3235,"target_answer_overlap":0.2857},"issue_created_at":"2024-10-18T09:39:18+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2597005133","fragment_type":"issue_description","sequence":0,"text":"Ren'Py Launcher Not Responding\nHello!\n\nI recently got back into Renpy. I downloaded the latest build, Renpy 8.3.2. It worked fine at first, but now, for some reason, the launcher will not work. It instantly goes into \"not responding.\" I have tried reinstalling and installing it into a different folder path. Nothing has worked.\n\nThis issue started a bit after installing VS Code and its extensions for Renpy and Python, such as Pylance. However, I am not positive if its directly responsible for the issue, since after uninstalling it the issue stayed.\n\nThe log file says everything loaded fine, there is no traceback file.\n\nAny help would be much appreciated!","author_login":"Torvyn","author_association":"NONE","created_at":"2024-10-18T09:39:18+08:00","repo_name":"renpy/renpy","issue_id":2597005133,"issue_number":5846,"issue_url":"https://github.com/renpy/renpy/issues/5846","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2422425534","fragment_type":"issue_comment","sequence":1,"text":"Did you install Visual Code via the Launcher or manually? The reason I ask is because the Launcher allows you to download Visual Code with the current version of Renpy Extension (which had been changed recently). If you did not do it through the Launcher:\n\nTry uninstalling Visual Code completely, restarting, and loading the Launcher again. If it works after that point, try going to Preferences in the Launcher, then Text Editor, and click on Visual Code. It will download and install both Visual Code and the current version of the Renpy extension.\n\nAnother thing you can try if uninstalling Visual Code does not fix it, try on another User account for your system. User Profiles (especially Windows) can cause strange behaviors if something happens (yes, that is vague, but there is a lot of things that occurs with a User Profile). If that fails and you have access to another system, check to see if the same behavior happens on that.","author_login":"danac78","author_association":"NONE","created_at":"2024-10-18T13:00:41+08:00","repo_name":"renpy/renpy","issue_id":2597005133,"issue_number":5846,"issue_url":"https://github.com/renpy/renpy/issues/5846","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2422442672","fragment_type":"issue_comment","sequence":2,"text":"You can also try:\n\n URL \n\nSelect a build from the Ren'Py 8 Fix column. These are nightly fixes that fix issues found in Renpy that might not be in 8.3.2 whereas Renpy 8 Development meant for developing the next version (in this case, 8.4) of Ren'Py. This way fixes could be released sooner without waiting for Renpy 8.4 to come out.:)","author_login":"danac78","author_association":"NONE","created_at":"2024-10-18T13:09:30+08:00","repo_name":"renpy/renpy","issue_id":2597005133,"issue_number":5846,"issue_url":"https://github.com/renpy/renpy/issues/5846","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2422444337","fragment_type":"issue_comment","sequence":3,"text":"This sounds like URL - did you per chance move the Launcher's window to a secondary monitor, and close it there the last time that it was working properly?\n\nIf so, try creating a new .rpy file in your `renpy-8.3.2-sdk/launcher/game/` folder, and write the following inside it:\n\npy\ninit 999 python:\n preferences.restore_window_position = False\n\nSee if that indeed fixes the issue.","author_login":"juniorthejunior","author_association":"NONE","created_at":"2024-10-18T13:10:21+08:00","repo_name":"renpy/renpy","issue_id":2597005133,"issue_number":5846,"issue_url":"https://github.com/renpy/renpy/issues/5846","linked_issue_ids":[2107939511],"is_known_query_context":false},{"document_id":"gh_comment_2422612731","fragment_type":"issue_comment","sequence":4,"text":"Fixed it by adding a new file in renpy-8.3.2-sdk/launcher/game/\n\nnamed the file fix.rpy, and adding the following code\n\ninit 999 python:\n preferences.restore_window_position = False","author_login":"Torvyn","author_association":"NONE","created_at":"2024-10-18T14:29:08+08:00","repo_name":"renpy/renpy","issue_id":2597005133,"issue_number":5846,"issue_url":"https://github.com/renpy/renpy/issues/5846","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2107939511","fragment_type":"issue_description","sequence":0,"text":"Game freezes when restoring window position from secondary monitors\nEncountering an issue in Ren'Py 8.2.0 where, if I launch a game from the Launcher, move the game's window to a secondary monitor, and close the game there, on the next launch the game freezes on a fully white screen and becomes non-responsive until it is needed to be forcefully killed. This does not happen if the window was only moved elsewhere on the Primary monitor - that works as intended and the previous position gets restored.\n\nThe Primary monitor is a 21:9 2560x1080p, and the secondary monitors are a 16:9 4K (3840x2160px) one and a 16:10 1920x1200px; this happens when I move the game's window to either of them.\n\nI was initially wondering if this was due to the varying resolutions of the monitors, but that did not seem to be the case: I asked a few people with multi-monitor setups to test it out, one whose both monitors had the same resolution, and two others with also varying resolutions ((1920x1080px + 1920x1080px + 4K), and (2560x1080p+ 1920x1080px)); and they did _not_ experience this issue.\n\nI also ran some experiments with making each monitor the Primary:\n- If the 16:10 one is the Primary, the results are the same; moving the window to the other monitors makes it freeze on the next launch.\n- If the 4K one is the Primary, moving the window to other monitors has no special result: it always gets reset back to the center of the 4K one, with no freezes or anything. It does also restore the position if it was set elsewhere on the 4K monitor itself.\n\nI also tried changing the resolutions of all 3 monitors to 1920x1080px via Windows settings, that did not make a difference. \nAlso tried unplugging each one of the monitors entirely, and the results were the same with the remaining monitors in all combinations.\n\nUnsure of what else to test, but I tried printing out `preferences.window_position` and `preferences.window_position_layout` during Init to maybe help provide some clue:\n\npy\n# Moved from Primary 21:9 to elsewhere on Primary 21:9:\nrenpy.game.preferences.window_position == (649, 31)\nrenpy.game.preferences.window_position_layout == ((0, 0, 2560, 1080), (-3840, -465, 2560, 1440), (2560, 2, 1920, 1200))\n\n# Moved from Primary 21:9 to secondary 16:9 4K (freeze):\nrenpy.game.preferences.window_position == (-3560, -265)\nrenpy.game.preferences.window_position_layout == ((0, 0, 2560, 1080), (-3840, -465, 2560, 1440), (2560, 2, 1920, 1200))\n\n# Moved from Primary 21:9 to secondary 16:10 1920x1200px (freeze):\nrenpy.game.preferences.window_position == (2633, 74)\nrenpy.game.preferences.window_position_layout == ((0, 0, 2560, 1080), (-3840, -465, 2560, 1440), (2560, 2, 1920, 1200))\n\nLog file: log.txt\n\nThis is on Ren'Py 8.2.0,\nNVIDIA driver version: 551.23 (latest at this time)\nOS:\n Edition: Windows 10 Pro\n Version: 22H2\n OS build: 19045.3930\n Experience: Windows Feature Experience Pack 1000.19053.1000.0\n\nScreenshot 2024-01-29_\nScreenshot 2024-01-29__","author_login":"juniorthejunior","author_association":"NONE","created_at":"2024-01-30T14:01:41+08:00","repo_name":"renpy/renpy","issue_id":2107939511,"issue_number":5325,"issue_url":"https://github.com/renpy/renpy/issues/5325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1917311851","fragment_type":"issue_comment","sequence":1,"text":"I don't know what the problem is, but this is very unlikely to be a Ren'Py problem. Other than positioning the window where you last place it, Ren'Py is working the same way regardless of monitor. I'd suggest reporting this issue to Nvidia to see if they can help as all.","author_login":"renpytom","author_association":"MEMBER","created_at":"2024-01-30T15:51:01+08:00","repo_name":"renpy/renpy","issue_id":2107939511,"issue_number":5325,"issue_url":"https://github.com/renpy/renpy/issues/5325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1918076033","fragment_type":"issue_comment","sequence":2,"text":"@juniorthejunior Have you tried completely uninstalling the Nvidia Drivers, downloading the latest from Nvidia, restarting Windows, and Reinstalling the Drivers? Going into Device Manager, right-click on the video card(s), click on uninstall, and click the checkbox that Asks if you want to Delete Drivers. It will probably be something Nvidia will ask to see if it is a problem with their drivers, or if it is a problem with your currently installed drivers.\n\nOne thing about \"updating drivers\", it may not ALWAYS put the newest version of everything. There could be a lingering issue that could cause odd behaviors.\n\nAdditionally, they also may ask you if this happens in another profile (Username). Corrupted (or starting to corrupt) profiles can cause wide range of weird issues. It will help both them and you determine if it is system-wide or just account-wide.\n\nJust two things to check that I did not see in your lists because I do not know how quick Nvidia is with responding to support requests.","author_login":"danac78","author_association":"NONE","created_at":"2024-01-30T23:17:37+08:00","repo_name":"renpy/renpy","issue_id":2107939511,"issue_number":5325,"issue_url":"https://github.com/renpy/renpy/issues/5325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1919207402","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the suggestions. Followed the steps - deleted via Device Manager, restarted, installed 551.23 (the latest), restarted - and the problem still persists. I also repeated the process except uninstalling the driver using DDU (a third-party \"deep uninstaller\" of sorts), and that made no difference either.\n\nAlso made a new Windows account/profile, downloaded and ran Ren'Py 8.2.0 and the results were the same there as well.\n\nI'll have to put together a report to NVIDIA at some point in the future, though at least for the time being, I am disabling this feature entirely in my project, since I personally would not want a player to encounter it and have them have to deal with it (however rare it might be; if it's happened to me, it'll happen to someone else), especially for a mostly QoL feature.","author_login":"juniorthejunior","author_association":"NONE","created_at":"2024-01-31T14:24:17+08:00","repo_name":"renpy/renpy","issue_id":2107939511,"issue_number":5325,"issue_url":"https://github.com/renpy/renpy/issues/5325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1959155871","fragment_type":"issue_comment","sequence":4,"text":"I have almost the same issue. Found that it was Discord that was messing something up sometimes and that was causing the videos on YouTube to not play and Ren'Py games freezing on closing.","author_login":"lauwurence","author_association":"CONTRIBUTOR","created_at":"2024-02-22T10:33:44+08:00","repo_name":"renpy/renpy","issue_id":2107939511,"issue_number":5325,"issue_url":"https://github.com/renpy/renpy/issues/5325","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1962783467","fragment_type":"issue_comment","sequence":5,"text":"I'm closing this, as it's likely to be some other process that's causing this problem.","author_login":"renpytom","author_association":"MEMBER","created_at":"2024-02-25T01:47:11+08:00","repo_name":"renpy/renpy","issue_id":2107939511,"issue_number":5325,"issue_url":"https://github.com/renpy/renpy/issues/5325","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0332","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"What does this error mean and how do I resolve it?","query_context":"Hello,\n\nI am getting this error when running an analysis:\n\nError during simplification\nToo many variables used in Z^{n+1},\n12 are allowed variables but 19 were found.\n\nI haven't found any information on this issue and don't know how to resolve it. \n\nI've attached the file. I am trying to use this to upload to an ATF1504 CPLD.\n\nCPLD_RAM_2MB.zip\n\nThanks!","known_context_document_ids":["gh_issue_1125325868"],"reference_answer":"When I played around with your equations, I was able to reproduce one of the exceptions.\n\nCould it be that you were trying to simplify the equation for C8 which has 17 input variables? Setting the memory 2GByte is not enough for that, even with 12GByte the equation can't be simplified with QMC.\n\nThe root cause of the error messages is a Java heap space error.","answer_document_id":"gh_comment_663865359","silver_evidence_path":["gh_comment_1031447958","gh_issue_665459692","gh_comment_663865359"],"evidence_issue_ids":[1125325868,665459692],"source_repo_name":"hneemann/Digital","source_issue_id":1125325868,"source_issue_number":913,"source_issue_url":"https://github.com/hneemann/Digital/issues/913","target_repo_name":"hneemann/Digital","target_issue_id":665459692,"target_issue_number":495,"target_issue_url":"https://github.com/hneemann/Digital/issues/495","reference_anchor_document_id":"gh_comment_1031447958","reference_answer_author":"hneemann","reference_answer_author_association":"OWNER","quality_score":93.16,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0645,"anchor_target_overlap":0.1455,"target_answer_overlap":0.1481},"issue_created_at":"2022-02-06T21:42:51+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1125325868","fragment_type":"issue_description","sequence":0,"text":"What does this error mean and how do I resolve it?\nHello,\n\nI am getting this error when running an analysis:\n\nError during simplification\nToo many variables used in Z^{n+1},\n12 are allowed variables but 19 were found.\n\nI haven't found any information on this issue and don't know how to resolve it. \n\nI've attached the file. I am trying to use this to upload to an ATF1504 CPLD.\n\nCPLD_RAM_2MB.zip\n\nThanks!","author_login":"reifsnyderb","author_association":"NONE","created_at":"2022-02-06T21:42:51+08:00","repo_name":"hneemann/Digital","issue_id":1125325868,"issue_number":913,"issue_url":"https://github.com/hneemann/Digital/issues/913","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1031447958","fragment_type":"issue_comment","sequence":1,"text":"The simulator uses QMC (Quine and McCluskey) to simplify logic equations, and the problem with QMC is that while it always provides an exact minimum solution, the memory consumption and computing time increases exponentially with the number of input variables. Therefore QMC is not suitable for functions with many inputs. To avoid that it takes too long until the result is available, the calculation is not performed if there are more than 12 inputs.\nWith such a large number of inputs you would have to use e.g. the heuristic Espresso algorithm, which is faster and uses less memory, but does not always provide the minimum solution.\nUnfortunately, I have not yet got around to implementing the Espresso algorithm.\n\nsee also #495","author_login":"hneemann","author_association":"OWNER","created_at":"2022-02-07T13:05:55+08:00","repo_name":"hneemann/Digital","issue_id":1125325868,"issue_number":913,"issue_url":"https://github.com/hneemann/Digital/issues/913","linked_issue_ids":[665459692],"is_known_query_context":false},{"document_id":"gh_comment_1031455608","fragment_type":"issue_comment","sequence":2,"text":"Is there a way to increase the number of inputs at your own risk?","author_login":"reifsnyderb","author_association":"NONE","created_at":"2022-02-07T13:13:27+08:00","repo_name":"hneemann/Digital","issue_id":1125325868,"issue_number":913,"issue_url":"https://github.com/hneemann/Digital/issues/913","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1031463617","fragment_type":"issue_comment","sequence":3,"text":"Yes! You can start the simulator with the command line argument `experimental`.\nThis avoids the error message. But in this case you should also increase the allowed max memory consumption.\n\njava -Xmx8192m -jar Digital.jar experimental","author_login":"hneemann","author_association":"OWNER","created_at":"2022-02-07T13:21:38+08:00","repo_name":"hneemann/Digital","issue_id":1125325868,"issue_number":913,"issue_url":"https://github.com/hneemann/Digital/issues/913","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032020635","fragment_type":"issue_comment","sequence":4,"text":"I terminated the program after about 4 hours. Memory consumption was up over 10 GB. I really like the program but will have to use it for logic simulations and smaller CPLD's only.","author_login":"reifsnyderb","author_association":"NONE","created_at":"2022-02-07T23:00:56+08:00","repo_name":"hneemann/Digital","issue_id":1125325868,"issue_number":913,"issue_url":"https://github.com/hneemann/Digital/issues/913","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1032269217","fragment_type":"issue_comment","sequence":5,"text":"As I said before: Exact solution algorithms are of order O(2^n). These are not suitable for minimizing equations with more than 12-14 variables. And this is sufficient for the application for which the simulator is intended (teaching).\nBut without a heuristic, non-exact solution method like e.g. the Espresso algorithm, it is not possible to find a solution in many cases.","author_login":"hneemann","author_association":"OWNER","created_at":"2022-02-08T06:52:53+08:00","repo_name":"hneemann/Digital","issue_id":1125325868,"issue_number":913,"issue_url":"https://github.com/hneemann/Digital/issues/913","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_665459692","fragment_type":"issue_description","sequence":0,"text":"Unable to build circuit with 17 inputs out of NAND gates\nI wanted to see how many NAND gates my 8 bit carry-lookahead adder would have if it was built solely using them.\nThe adder was created from 32 boolean expressions, later each circuit that depended on another connected with tunnels (some expressions' variables were results from other expressions). These are the 32 expressions:\n\nlet p0 = a0^b0;\nlet p1 = a1^b1;\nlet p2 = a2^b2;\nlet p3 = a3^b3;\nlet p4 = a4^b4;\nlet p5 = a5^b5;\nlet p6 = a6^b6;\nlet p7 = a7^b7;\nlet g0 = a0 b0;\nlet g1 = a1 b1;\nlet g2 = a2 b2;\nlet g3 = a3 b3;\nlet g4 = a4 b4;\nlet g5 = a5 b5;\nlet g6 = a6 b6;\nlet g7 = a7 b7;\nlet S0 = p0 ^ C0;\nlet C1 = g0 + p0 C0;\nlet S1 = p1 ^ C1;\nlet C2 = g1 + p1 g0 + p1 p0 C0;\nlet S2 = p2 ^ C2;\nlet C3 = g2 + p2 g1 + p2 p1 g0 + p2 p1 p0 C0;\nlet S3 = p3 ^ C3;\nlet C4 = g3 + p3 g2 + p3 p2 g1 + p3 p2 p1 g0 + p3 p2 p1 p0 C0;\nlet S4 = p4 ^ C4;\nlet C5 = g4 + p4 g3 + p4 p3 g2 + p4 p3 p2 g1 + p4 p3 p2 p1 g0 + p4 p3 p2 p1 p0 C0;\nlet S5 = p5 ^ C5;\nlet C6 = g5 + p5 g4 + p5 p4 g3 + p5 p4 p3 g2 + p5 p4 p3 p2 g1 + p5 p4 p3 p2 p1 g0 + p5 p4 p3 p2 p1 p0 C0;\nlet S6 = p6 ^ C6;\nlet C7 = g6 + p6 g5 + p6 p5 g4 + p6 p5 p4 g3 + p6 p5 p4 p3 g2 + p6 p5 p4 p3 p2 g1 + p6 p5 p4 p3 p2 p1 g0 + p6 p5 p4 p3 p2 p1 p0 C0;\nlet S7 = p7 ^ C7;\nlet C8 = g7 + p7 g6 + p7 p6 g5 + p7 p6 p5 g4 + p7 p6 p5 p4 g3 + p7 p6 p5 p4 p3 g2 + p7 p6 p5 p4 p3 p2 g1 + p7 p6 p5 p4 p3 p2 p1 g0 + p7 p6 p5 p4 p3 p2 p1 p0 C0\n\nI cloned the repository and with Digital built v0.24-137-ga08496b (as of a08496b5b132a49093a7a93a0bf4007ef2d7687a), running it with OpenJDK Runtime Environment (build 14.0.2+12) using `java -Xms2048M -jar Digital.jar experimental` and `java -Xms2560M -jar Digital.jar experimental`, both instances were able to generate identical tables. The sha256sum of the two saved tables is `37413a273d8bec7b51d4ba36ccd3c28903d1eb9a20866683251d02f6a132777e` and `diff` found no differences either. But the tables were generated with an error in both cases:\n\nde.neemann.digital.analyse.expression.ExpressionException: ExpressionListenerStore not closed\n at de.neemann.digital.gui.components.table.ExpressionListenerStore.replayTo(ExpressionListenerStore.java:62)\n at de.neemann.digital.gui.components.table.ExpressionCreator.create(ExpressionCreator.java:93)\n at de.neemann.digital.gui.components.table.TableDialog.lambda$calculateExpressions$9(TableDialog.java:723)\n at java.base/java.lang.Thread.run(Thread.java:832)\n\nWith the table, I tried to build a circuit solely with NAND gates, and the following error issued:\n\nde.neemann.digital.analyse.expression.ExpressionException: Não há equações mínimas!\n at de.neemann.digital.gui.components.table.BuilderExpressionCreator.create(BuilderExpressionCreator.java:50)\n at de.neemann.digital.gui.components.table.TableDialog.createCircuit(TableDialog.java:642)\n at de.neemann.digital.gui.components.table.TableDialog.createCircuit(TableDialog.java:630)\n at de.neemann.digital.gui.components.table.TableDialog.access$1500(TableDialog.java:75)\n at de.neemann.digital.gui.components.table.TableDialog$26.actionPerformed(TableDialog.java:554)\n at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)\n at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)\n at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)\n at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)\n at java.desktop/javax.swing.AbstractButton.doClick(AbstractButton.java:369)\n at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1020)\n at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1064)\n at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)\n at java.desktop/java.awt.Component.processMouseEvent(Component.java:6636)\n at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)\n at java.desktop/java.awt.Component.processEvent(Component.java:6401)\n at java.desktop/java.awt.Container.processEvent(Container.java:2263)\n at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5012)\n at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)\n at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)\n at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4919)\n at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4548)\n at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4489)\n at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)\n at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2764)\n at java.desktop/java.awt.Component.dispatchEvent(Component.java:4844)\n at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)\n at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)\n at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)\n at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)\n at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)\n at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)\n at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)\n at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)\n at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)\n at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)\n at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)\n at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)\n at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)\n at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)\n at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)\n at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)\n at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)\n\nIf it is needed to know anything else, I'm glad to inform.","author_login":"bottle2","author_association":"NONE","created_at":"2020-07-24T23:01:05+08:00","repo_name":"hneemann/Digital","issue_id":665459692,"issue_number":495,"issue_url":"https://github.com/hneemann/Digital/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_663821793","fragment_type":"issue_comment","sequence":1,"text":"I'm not sure I understood the problem.\nI have tested your input to the circuit generator, and this seems to work fine. \n\nIf you then try to create a truth table, it's is not possible because of not unique variables used.\n\nBut if you fix the internal used local variables (which should be done by the circuit generator automatically, i guess) there are only 17 inputs remaining (a0-a7, b0-b7 and c0) and you will get the truth table of an 8-bit adder which is the same for any 8-bit adder and therefore useless in respect of the carry-look-ahead logic.","author_login":"hneemann","author_association":"OWNER","created_at":"2020-07-25T07:18:50+08:00","repo_name":"hneemann/Digital","issue_id":665459692,"issue_number":495,"issue_url":"https://github.com/hneemann/Digital/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_663865359","fragment_type":"issue_comment","sequence":2,"text":"When I played around with your equations, I was able to reproduce one of the exceptions.\n\nCould it be that you were trying to simplify the equation for C8 which has 17 input variables? Setting the memory 2GByte is not enough for that, even with 12GByte the equation can't be simplified with QMC.\n\nThe root cause of the error messages is a Java heap space error.","author_login":"hneemann","author_association":"OWNER","created_at":"2020-07-25T15:02:53+08:00","repo_name":"hneemann/Digital","issue_id":665459692,"issue_number":495,"issue_url":"https://github.com/hneemann/Digital/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_663892692","fragment_type":"issue_comment","sequence":3,"text":"You understood correctly the problem, but now I see how foolish on my part it was to think that whatever circuit I could build from the truth table, be it made out of two-input NAND gates or anything else, would represent the carry-lookahead circuit.\n \n\nNot directly, but certainly. After I generated the circuit with the equations and I fixed the internal variables, just as you did, I hit \"Analysis\" from the \"Analysis\" menu and waited until the table was generated, when the errors occurred.\n\nI think you are right with it being lack of memory, specially for C8. Using Digital as of 98dc38540bcd649fcd2b4ffe2089d2458e841298 and with the same parameters as before, I tried \"Synthesis\" of the \"Analysis\" menu, I opened the saved table and, after a while, this appeared: \"java.lang.OutOfMemoryError: Java heap space\". For context, this is the full output in the terminal:\n\n[AWT-EventQueue-0] INFO de.neemann.digital.gui.components.table.TableDialog - start optimization\n[AWT-EventQueue-0] INFO de.neemann.digital.gui.components.table.TableDialog - optimization finished\n[AWT-EventQueue-0] INFO de.neemann.digital.gui.components.table.TableDialog - start optimization\n[AWT-EventQueue-0] INFO de.neemann.digital.gui.components.table.TableDialog - optimization finished\n[AWT-EventQueue-0] INFO de.neemann.digital.gui.components.table.TableDialog - start optimization\n[AWT-EventQueue-0] INFO de.neemann.digital.gui.components.table.TableDialog - optimization finished\nde.neemann.digital.analyse.expression.ExpressionException: ExpressionListenerStore not closed\n at de.neemann.digital.gui.components.table.ExpressionListenerStore.replayTo(ExpressionListenerStore.java:62)\n at de.neemann.digital.gui.components.table.ExpressionCreator.create(ExpressionCreator.java:93)\n at de.neemann.digital.gui.components.table.TableDialog.lambda$calculateExpressions$9(TableDialog.java:723)\n at java.base/java.lang.Thread.run(Thread.java:832)\njul. 25, 2020 3:15:56 PM sun.awt.X11.XToolkit processException\nWARNING: Exception on Toolkit thread\njava.lang.OutOfMemoryError: Java heap space\n\nde.neemann.digital.analyse.expression.ExpressionException: ExpressionListenerStore not closed\n at de.neemann.digital.gui.components.table.ExpressionListenerStore.replayTo(ExpressionListenerStore.java:62)\n at de.neemann.digital.gui.components.table.ExpressionCreator.create(ExpressionCreator.java:93)\n at de.neemann.digital.gui.components.table.TableDialog.lambda$calculateExpressions$9(TableDialog.java:723)\n at java.base/java.lang.Thread.run(Thread.java:832)\n\nIndeed, by removed all outputs except C8 from the table through the option \"Reorder/Delete Output Columns\" in the \"Edit\" menu, the same error appears after a while: `java.lang.OutOfMemoryError: Java heap space`.\n\nI think we may close the issue then.","author_login":"bottle2","author_association":"NONE","created_at":"2020-07-25T19:34:25+08:00","repo_name":"hneemann/Digital","issue_id":665459692,"issue_number":495,"issue_url":"https://github.com/hneemann/Digital/issues/495","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_663903038","fragment_type":"issue_comment","sequence":4,"text":"The problem with QMC (Quine and McCluskey) is that while it always provides an exact minimum solution, the memory consumption and computing time increases exponentially with the number of input variables. Therefore QMC is not suitable for functions with many inputs. In such a case you would have to use e.g. the heuristic Espresso algorithm, which is faster and uses less memory, but does not always provide the minimum solution.\nUnfortunately, I have not yet got around to implementing the Espresso algorithm.","author_login":"hneemann","author_association":"OWNER","created_at":"2020-07-25T20:30:27+08:00","repo_name":"hneemann/Digital","issue_id":665459692,"issue_number":495,"issue_url":"https://github.com/hneemann/Digital/issues/495","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0333","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Invalid yaml?","query_context":"- `/income/verification/documents/download`\n- `/beta/credit/v1/bank_employment/get`\n- `/deposit_switch/get`\n\nAll have API errors in their yaml\n\nmost can be fixed with indentation; the beta one has `x-hidden-from-docs: true` outside of a method, which means some tooling treats it as a method and crashes.","known_context_document_ids":["gh_issue_1708474674"],"reference_answer":"@henryobiaraije This option was deprecated couple uears ago with Improvements we made with import flow to handle larger specifications better.\n\nCould you explain the need to use this option and any issues that you might be running into?","answer_document_id":"gh_comment_2728182237","silver_evidence_path":["gh_comment_1548808891","gh_issue_1241809648","gh_comment_2728182237"],"evidence_issue_ids":[1708474674,1241809648],"source_repo_name":"plaid/plaid-openapi","source_issue_id":1708474674,"source_issue_number":124,"source_issue_url":"https://github.com/plaid/plaid-openapi/issues/124","target_repo_name":"postmanlabs/postman-app-support","target_issue_id":1241809648,"target_issue_number":10928,"target_issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","reference_anchor_document_id":"gh_comment_1548808891","reference_answer_author":"VShingala","reference_answer_author_association":"MEMBER","quality_score":94.38,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2308,"anchor_target_overlap":0.0769,"target_answer_overlap":0.1053},"issue_created_at":"2023-05-13T06:56:17+08:00","valid_comment_count":36,"fragments":[{"document_id":"gh_issue_1708474674","fragment_type":"issue_description","sequence":0,"text":"Invalid yaml\n- `/income/verification/documents/download`\n- `/beta/credit/v1/bank_employment/get`\n- `/deposit_switch/get`\n\nAll have API errors in their yaml\n\nmost can be fixed with indentation; the beta one has `x-hidden-from-docs: true` outside of a method, which means some tooling treats it as a method and crashes.","author_login":"Lewiscowles1986","author_association":"NONE","created_at":"2023-05-13T06:56:17+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1548449735","fragment_type":"issue_comment","sequence":1,"text":"We validate the OpenAPI file using the validator at URL and it passes that validation. If there is a specific different validation tool that you are running or specific places where you think the indentation should be changed, please let us know.","author_login":"phoenixy1","author_association":"CONTRIBUTOR","created_at":"2023-05-15T19:28:10+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548778315","fragment_type":"issue_comment","sequence":2,"text":"Okay so for `/deposit_switch/get` and `/income/verification/documents/download` would you say that parameters is correctly indented, or indeed necesarry?\n\nEven within the same file, the indentation is different to all the other endpoints featuring `parameters: []`\n\n`/beta/credit/v1/bank_employment/get` has an `x-hidden-from-docs: true` which is not within a http method under a path. Is that correct?\n\nI don't doubt you have automation. These endpoints are documented, but don't seem to work with URL when passed through URL being told to use examples.\n\nAlso when I try to use these endpoints using swagger generator I get errors like the following\n\n{\n \"message\": \"unknown format \\\"datetime\\\" is used in schema at path \\\"#/properties/initiated_date\\\"\"\n}\n\nwhich is a http 500 error.","author_login":"Lewiscowles1986","author_association":"NONE","created_at":"2023-05-16T00:06:30+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548785173","fragment_type":"issue_comment","sequence":3,"text":"Other tooling used (problematically) are things like postman\n\n \"\n },\n \"client_id\": {\n \"value\": \" \"\n },\n \"secret\": {\n \"value\": \" \"\n }\n}\n\nwhich is what happens if I try to import ` URL (currently `master`)","author_login":"Lewiscowles1986","author_association":"NONE","created_at":"2023-05-16T00:15:18+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548786654","fragment_type":"issue_comment","sequence":4,"text":"None of this is intended to be problematic. When I asked about OpenAPI2 support, I accepted that OAS3 is what we should work with. I Also accept this is difficult and new and a hard area and that PR's are not really worth it, as they then need to be translated to some program that generates that file. I Just want things to work and not cause issues. Using swagger generator and verifying calls to plaid via postman are two ways of troubleshooting that implementations in code match the API-spec contract as well as making calls direct to plaid to gain visibility.","author_login":"Lewiscowles1986","author_association":"NONE","created_at":"2023-05-16T00:17:36+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1548808891","fragment_type":"issue_comment","sequence":5,"text":"Thanks, that is super helpful detail.\n\nThe `x-hidden-from-docs: true` I can fix (it doesn't even do anything, so we can delete that line)\nThe `parameters` indentation is also an easy fix (and again, I'm not sure it's even doing anything) \nThe `format: datetime` thing is something we already caught internally and it's fixed on master, so that should be rolled out with next month's release.\n\nThe Postman error seems like unfortunately a limitation in Postman rather than anything wrong with the API specification, so I don't think there's anything we can do about that. There are some suggested workarounds floating around online, e.g.: URL","author_login":"phoenixy1","author_association":"CONTRIBUTOR","created_at":"2023-05-16T00:51:25+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[1241809648],"is_known_query_context":false},{"document_id":"gh_comment_1550124973","fragment_type":"issue_comment","sequence":6,"text":"Super helpful thanks. The workaround I'm picking out from that little thread might be\n\nopenapi2postmanv2 -s root.yaml -o collection.json -p -O folderStrategy=Tags,includeAuthInfoInExample=false,optimizeConversion=false,stackLimit=50\n\nI've applied the fixes locally and just did a find replace for the hyphenation of date-time; It's more that I'd sooner not write automated tools; it's not just plaid, every vendor has... insert quirky thing 👍","author_login":"Lewiscowles1986","author_association":"NONE","created_at":"2023-05-16T18:00:34+08:00","repo_name":"plaid/plaid-openapi","issue_id":1708474674,"issue_number":124,"issue_url":"https://github.com/plaid/plaid-openapi/issues/124","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1241809648","fragment_type":"issue_description","sequence":0,"text":"Error: Too many levels of nesting to fake this schema\n### Is there an existing issue for this?\n\n- [X] I have searched the tracker for existing similar issues and I know that duplicates will be closed\n\n### Describe the Issue\n\nWhen I use nesting in my OpenAPI definition and generate collection. The generated examples where nesting has been used show the following error:\n\n \n\nSample generated Example:\n\n{\n \"meta\": {\n \"page_size\": 50,\n \"continuation_token\": \"A Very Long JSON String\"\n },\n \"data\": [\n {\n \"service\": {\n \"id\": \"bc73d72d-3cca-433b-8229-ab8fd0f7c2f1\",\n \"name\": \"Software Development\"\n },\n \"posted_by\": {\n \"id\": \"05072d22-ab35-47ce-8d58-4ffe0d6fcda7\",\n \"name\": \"John Wick\",\n \"city\": \"Toronto\",\n \"country\": \"Canada\",\n \"phone\": \"+1 ***-***-3006\",\n \"phone_verified\": true,\n \"email\": \"us***@****.com\",\n \"email_verified\": false,\n \"posted_on\": \"2017-07-21T17:32:28Z\"\n },\n \"id\": \"05072d22-ab35-47ce-8d58-4ffe0d6fcda7\",\n \"lead_status\": \"pending\",\n \"credits\": 22,\n \"experts_responded\": 3,\n \"service_questions_and_answers\": [\n {\n \"question_id\": {\n \"value\": \" \"\n },\n \"question\": {\n \"value\": \" \"\n },\n \"answer\": {\n \"value\": \" \"\n }\n },\n {\n \"question_id\": {\n \"value\": \" \"\n },\n \"question\": {\n \"value\": \" \"\n },\n \"answer\": {\n \"value\": \" \"\n }\n }\n ]\n },\n {\n \"service\": {\n \"id\": \"bc73d72d-3cca-433b-8229-ab8fd0f7c2f1\",\n \"name\": \"Software Development\"\n },\n \"posted_by\": {\n \"id\": \"05072d22-ab35-47ce-8d58-4ffe0d6fcda7\",\n \"name\": \"John Wick\",\n \"city\": \"Toronto\",\n \"country\": \"Canada\",\n \"phone\": \"+1 ***-***-3006\",\n \"phone_verified\": true,\n \"email\": \"us***@****.com\",\n \"email_verified\": false,\n \"posted_on\": \"2017-07-21T17:32:28Z\"\n },\n \"id\": \"05072d22-ab35-47ce-8d58-4ffe0d6fcda7\",\n \"lead_status\": \"pending\",\n \"credits\": 22,\n \"experts_responded\": 3,\n \"service_questions_and_answers\": [\n {\n \"question_id\": {\n \"value\": \" \"\n },\n \"question\": {\n \"value\": \" \"\n },\n \"answer\": {\n \"value\": \" \"\n }\n },\n {\n \"question_id\": {\n \"value\": \" \"\n },\n \"question\": {\n \"value\": \" \"\n },\n \"answer\": {\n \"value\": \" \"\n }\n }\n ]\n }\n ]\n}\n\n### Steps To Reproduce\n\n1. Import attached API Spec\n2. Generate Collection\n3. View generated successful response example under Leads --> [admin,client,expert] Returns lead list\n\n### Screenshots or Videos\n\nimage\nSpec.txt\n\n### Operating System\n\nWindows\n\n### Postman Version\n\n9.18.2\n\n### Postman Platform\n\nPostman App\n\n### Additional Context?\n\n_No response_","author_login":"umnex","author_association":"NONE","created_at":"2022-05-19T13:45:02+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1131989227","fragment_type":"issue_comment","sequence":1,"text":"Hi @umnex , thanks for reporting. I'm not able to reproduce using your example when importing when using path or tags folder organization. It looks at first glance like the 10 stack limit nesting level hasn't been reached either.\n<img width=\"1779\" alt=\"Screen Shot 2022-05-19 at 11 39 12 AM\" src=\" URL \n\nIs there a different example you're using that has more nesting happening? To get around these limits, I'd recommend checking out the openapi-to-postman project and this thread in particular where these limits are discussed for how to bypass them:\n URL","author_login":"timbochamp","author_association":"NONE","created_at":"2022-05-19T17:28:01+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1132556584","fragment_type":"issue_comment","sequence":2,"text":"Sorry I attached the spec where i solved the issue by removing the nesting. Here is the spec sample that generates issues.\nspec_with_issues.txt","author_login":"umnex","author_association":"NONE","created_at":"2022-05-20T07:12:37+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1136147744","fragment_type":"issue_comment","sequence":3,"text":"Sorry for the delay, @umnex. I've added a feature tag here for our Product team to review this as a feature request where the implementation will likely take time. It is a fixed limit of 10 levels of nesting I believe. \n\nAs mentioned in my last post, to get around these limits, I'd recommend checking out the openapi-to-postman project and this thread in particular where these limits are discussed for how to bypass them:\npostmanlabs/openapi-to-postman#306 if that's a feasible workaround in the meantime?","author_login":"timbochamp","author_association":"NONE","created_at":"2022-05-24T16:34:17+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1136151490","fragment_type":"issue_comment","sequence":4,"text":"Thanks for the update. I don't think I passed the 10 levels limit in my spec. Can you confirm it please?","author_login":"umnex","author_association":"NONE","created_at":"2022-05-24T16:38:10+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141373746","fragment_type":"issue_comment","sequence":5,"text":"@umnex sorry to be mistaken on my part! I spoke with @VShingala and the \"Too many levels of nesting to fake this schema\" problems are due to how big the spec is where there are only six layers of nesting. \n\nAs a workaround, you can turn off Optimize Conversion setting, which should prevent the deeper layers of nesting from being populated with \"Too many levels of nesting to fake this schema\". I verified this with your file as well.\nScreen Shot 2022-05-30 at 2 32 13 PM","author_login":"timbochamp","author_association":"NONE","created_at":"2022-05-30T17:38:29+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1142198789","fragment_type":"issue_comment","sequence":6,"text":"Going to close this out but feel free to reopen it if this issue is persisting! I'll log a ticket internally to try to better this error messaging where it's not intuitive to know to disable this Optimize conversion setting I realize.","author_login":"timbochamp","author_association":"NONE","created_at":"2022-05-31T14:18:33+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1193013454","fragment_type":"issue_comment","sequence":7,"text":"Hi Team, \n\nTurning off **Optimize Conversion** setting via UI does work. \nIs there a way to do that via the Postman API?\n\nI am using the Automation-API Workflow and still getting the error. Documentation is not clear/ doesn't show settings available in the UI\n\n URL","author_login":"pierre-wehbe","author_association":"NONE","created_at":"2022-07-23T00:03:10+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1205985845","fragment_type":"issue_comment","sequence":8,"text":"Turning off \"Optimize conversion\" worked for me... thanks a lot.","author_login":"sagaofsilence","author_association":"NONE","created_at":"2022-08-05T02:53:13+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1213385893","fragment_type":"issue_comment","sequence":9,"text":"@umnex @timbochamp Just making sure this doesn't get lost in translation, this **works** if we were to use the POSTMAN UI to import, but **doesn't work** via API (no field to turn off optimize conversion. Any suggestions?","author_login":"pierre-wehbe","author_association":"NONE","created_at":"2022-08-12T18:16:04+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1216590608","fragment_type":"issue_comment","sequence":10,"text":"@pierre-wehbe have you tried openapi-to-postman as a workaround?\n URL \n\nYou should be able to set `optimizeConversion=false` that way I want to say!","author_login":"timbochamp","author_association":"NONE","created_at":"2022-08-16T12:47:52+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1282287775","fragment_type":"issue_comment","sequence":11,"text":"Turning off Optimize Conversion doesn't work for me. I use collection from here: URL","author_login":"voodooism","author_association":"NONE","created_at":"2022-10-18T12:13:08+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1300686991","fragment_type":"issue_comment","sequence":12,"text":"I am also using the POSTMAN UI to import, and turning off the \"Optimize Conversion\" setting doesn't work. I am still getting the \" \" error. \n\nI am also not able to tell if I've reached the 10 stack limit nesting as I am not sure how exactly that's measured. Are there any updates on when this feature will be implemented?","author_login":"Gunacan","author_association":"NONE","created_at":"2022-11-02T15:31:04+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1301712460","fragment_type":"issue_comment","sequence":13,"text":"@Gunacan \nI got a same problem and I found a solution!\nIt worked really well for me.\n\nsh\nopenapi2postmanv2 -s root.yaml -o collection.json -p -O folderStrategy=Tags,includeAuthInfoInExample=false,optimizeConversion=false,stackLimit=50","author_login":"iksflow","author_association":"NONE","created_at":"2022-11-03T07:00:20+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1302140412","fragment_type":"issue_comment","sequence":14,"text":"@iksflow, thanks for your response, but as I said in my message, I am doing the import on Postman UI (Postman app), and not the API.","author_login":"Gunacan","author_association":"NONE","created_at":"2022-11-03T13:46:49+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1302236862","fragment_type":"issue_comment","sequence":15,"text":"@Gunacan \nYeah, that's right. It's not cool.\nYou already know, So I imported the collection.json(generated by CLI command) to Postman App. 🤣","author_login":"iksflow","author_association":"NONE","created_at":"2022-11-03T14:55:27+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1322485630","fragment_type":"issue_comment","sequence":16,"text":"This ticket should not be marked closed as the root cause has not really been addressed.","author_login":"karl-cardenas-coding","author_association":"NONE","created_at":"2022-11-21T18:33:02+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1379648533","fragment_type":"issue_comment","sequence":17,"text":"Reopening to track with ticket internally to try to better this error messaging or arrive at a solution not requiring openapi-to-postman as a workaround","author_login":"timbochamp","author_association":"NONE","created_at":"2023-01-12T00:19:20+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1423335898","fragment_type":"issue_comment","sequence":18,"text":"No, openapi-to-postman doesn't work for me. It's even worse because it generates only 2 levels when it comes to this situation.","author_login":"lanshunfang","author_association":"NONE","created_at":"2023-02-08T22:43:51+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1460141414","fragment_type":"issue_comment","sequence":19,"text":"Using Version 10.11.1 of Postman UI and the setting does not work for me.","author_login":"mbablok","author_association":"NONE","created_at":"2023-03-08T13:16:16+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1466633480","fragment_type":"issue_comment","sequence":20,"text":"Using Version 10.11.2 of Postman UI and the setting does not work for me.","author_login":"anandsunderraman","author_association":"NONE","created_at":"2023-03-13T17:56:09+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1486806857","fragment_type":"issue_comment","sequence":21,"text":"I have come back to this issue after a period of time working on other things and have stumbled-upon a solution.\n\nIt seems that if you pass the config options on the command-line, e.g:\n`openapi2postmanv2 -s postman.yml -o collection.json -p -O folderStrategy=Tags,requestParametersResolution=Example,optimizeConversion=false,stackLimit=50`\nyou get the \" \" error, but if you pass the same parameters in a JSON config file, e.g.\n`openapi2postmanv2 -s postman.yml -o collection.json -c config.json`\nwhere config.json contains:\n\n{\n \"optimizeConversion\": true,\n \"folderStrategy\": \"Tags\",\n \"requestParametersResolution\": \"Example\",\n \"optimizeConversion\": false,\n \"stackLimit\": 50\n}\n\nit works as expected, with no error generated. In my case, it now claims to be using a stack of depth 11.","author_login":"maldaba-nigel","author_association":"NONE","created_at":"2023-03-28T12:34:07+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1506977140","fragment_type":"issue_comment","sequence":22,"text":"@maldaba-nigel I tried this out myself with stripe API which has maximum of 27 nested levels and using same args provided as you, it's generating collection without any `\" \"` error in collection.\n\nCould it be the case that the OpenAPI definition you're working with has more than 50 levels of nesting?","author_login":"VShingala","author_association":"MEMBER","created_at":"2023-04-13T13:36:01+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1547259714","fragment_type":"issue_comment","sequence":23,"text":"@shae128 @pmrussell892 If possible you be able to share the definition / sample definition where this issue is still reproducible?\n\nIt's still possible to have this error if there is too much nesting in the data. i.e. more than 30 levels. But many cases are now generat8ing collection without this. For example, Here's Stripe API which used to have this limitation but with this change, generated collection from this now does not contain such error.","author_login":"VShingala","author_association":"MEMBER","created_at":"2023-05-15T06:28:13+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1577774668","fragment_type":"issue_comment","sequence":24,"text":"Is their any plans to allow users to change the stack limit using Postman settings?","author_login":"pmrussell892","author_association":"NONE","created_at":"2023-06-06T01:54:34+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1600551388","fragment_type":"issue_comment","sequence":25,"text":"@pmrussell892 We're looking more into this. Meanwhile, you can make use of our open-source collection generator from OpenAPI definition.\n\nHere is more on how this tool can be installed and used. This conversion will take place on your machine so it'll be private. Do provide your feedback if increasing this limit is generating collection as expected or not.","author_login":"VShingala","author_association":"MEMBER","created_at":"2023-06-21T10:01:44+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[1241809648],"is_known_query_context":false},{"document_id":"gh_comment_2256691602","fragment_type":"issue_comment","sequence":26,"text":"Bumping this. It's been over a year since this last message:\n \n\nHow's the looking going?","author_login":"jstjoe","author_association":"NONE","created_at":"2024-07-29T19:03:47+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2258344939","fragment_type":"issue_comment","sequence":27,"text":"@jstjoe With the current limit that we have in place (stack=30) most of the use-cases should not be having this issue. But if you have this issue occurring where even for a property that is not very nested and you receive this error, let us know and we can look into it.\n\nAs for exposing this option in App, It seems allowing this option could cause many potential issues due to sheer amount of collection size that few definitions that are imported can generate. We've seen collections getting generated that are more then 500 MB to even 1 GB in such cases. Due to this, we've made decision to allow such generation only from usage of module directly.","author_login":"VShingala","author_association":"MEMBER","created_at":"2024-07-30T13:24:16+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2727543919","fragment_type":"issue_comment","sequence":28,"text":"How do I get to this screen in current version of postman? \n\nImage","author_login":"henryobiaraije","author_association":"NONE","created_at":"2025-03-16T17:02:39+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2728182237","fragment_type":"issue_comment","sequence":29,"text":"@henryobiaraije This option was deprecated couple uears ago with Improvements we made with import flow to handle larger specifications better.\n\nCould you explain the need to use this option and any issues that you might be running into?","author_login":"VShingala","author_association":"MEMBER","created_at":"2025-03-17T05:10:29+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2733307972","fragment_type":"issue_comment","sequence":30,"text":"As an example, in postman you see stuff like this\n\nImage\n\nThis was imported from my openapi documentation json.\nWhen examples or responses have deeply nested key value pais, you start seeing this error \n\nImage\n\nBut in swagger, everything is displayed, and no errors\n\nImage","author_login":"henryobiaraije","author_association":"NONE","created_at":"2025-03-18T13:45:16+08:00","repo_name":"postmanlabs/postman-app-support","issue_id":1241809648,"issue_number":10928,"issue_url":"https://github.com/postmanlabs/postman-app-support/issues/10928","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0337","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Runners crashing frequently with CrashLoopBackOff?","query_context":"**Describe the bug**\n\nSuddenly GitHub Runners containers starts to crash with below errors and keeps in CrashLoopBackOff.\n\nAnd when we update the runner with the latest release it gets fixed but after sometime it starts throwing same error.\n\nmv: inter-device move failed: './externalstmp/node12' to './externals/node12'; unable to remove target: Directory not empty\n\nmv: inter-device move failed: './externalstmp/node12_alpine' to './externals/node12_alpine'; unable to remove target: Directory not empty\n\n## Runner Version and Platform\nKubernetes Cluster 1.20\nGitHub Runners version 2.280.3\n\nOS of the machine running the runner? OSX/Windows/Linux/...\nLinux","known_context_document_ids":["gh_issue_980432106"],"reference_answer":"@MichaelJJ the runner didn't call `git` directly, the `actions/checkout@v2` will call it.\nthe error seems related to the runner can't start the `actions/checkout@v2` actions.\n\nCan your runner run step? only `actions/checkout@v2` fail or all kinds of steps in the job are failing?\n\nAlso, make sure you don't have a really big environment set on the environment or in your job since a huge environment variable block might block creating a new process on the OS.","answer_document_id":"gh_comment_961169675","silver_evidence_path":["gh_comment_1063849582","gh_issue_1044892296","gh_comment_961169675"],"evidence_issue_ids":[980432106,1044892296],"source_repo_name":"actions/runner","source_issue_id":980432106,"source_issue_number":1290,"source_issue_url":"https://github.com/actions/runner/issues/1290","target_repo_name":"actions/runner","target_issue_id":1044892296,"target_issue_number":1464,"target_issue_url":"https://github.com/actions/runner/issues/1464","reference_anchor_document_id":"gh_comment_1063849582","reference_answer_author":"TingluoHuang","reference_answer_author_association":"MEMBER","quality_score":85.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0714,"anchor_target_overlap":0.2143,"target_answer_overlap":0.2895},"issue_created_at":"2021-08-26T16:25:05+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_980432106","fragment_type":"issue_description","sequence":0,"text":"Runners crashing frequently with CrashLoopBackOff\n**Describe the bug**\n\nSuddenly GitHub Runners containers starts to crash with below errors and keeps in CrashLoopBackOff.\n\nAnd when we update the runner with the latest release it gets fixed but after sometime it starts throwing same error.\n\nmv: inter-device move failed: './externalstmp/node12' to './externals/node12'; unable to remove target: Directory not empty\n\nmv: inter-device move failed: './externalstmp/node12_alpine' to './externals/node12_alpine'; unable to remove target: Directory not empty\n\n## Runner Version and Platform\nKubernetes Cluster 1.20\nGitHub Runners version 2.280.3\n\nOS of the machine running the runner? OSX/Windows/Linux/...\nLinux","author_login":"azizzoaib786","author_association":"NONE","created_at":"2021-08-26T16:25:05+08:00","repo_name":"actions/runner","issue_id":980432106,"issue_number":1290,"issue_url":"https://github.com/actions/runner/issues/1290","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1063849582","fragment_type":"issue_comment","sequence":1,"text":"Hi @azizzoaib786,\n\nAre you experiencing this issue again? Please, look at this issue, which might help with your problem. If not, could you please provide how did you set up your runner so we can try to reproduce this behaviour?","author_login":"nikola-jokic","author_association":"COLLABORATOR","created_at":"2022-03-10T09:33:03+08:00","repo_name":"actions/runner","issue_id":980432106,"issue_number":1290,"issue_url":"https://github.com/actions/runner/issues/1290","linked_issue_ids":[1044892296],"is_known_query_context":false},{"document_id":"gh_comment_1073613890","fragment_type":"issue_comment","sequence":2,"text":"I'm going to close out this issue until we hear back from you, please let us know if you are still seeing this issue!","author_login":"nikola-jokic","author_association":"MEMBER","created_at":"2022-03-21T08:25:01+08:00","repo_name":"actions/runner","issue_id":980432106,"issue_number":1290,"issue_url":"https://github.com/actions/runner/issues/1290","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1044892296","fragment_type":"issue_description","sequence":0,"text":"Issue running steps on ephemeral kubernetes agent - No such file or directory\n**Describe the bug**\nWe are using the new self-hosted runner scaling API to create a new kubernetes agent with every new job. When trying to run steps like checkout v2, we receive the error No such file or directory. We can manually run git commands.\n\n## Runner Version and Platform\nVersion of your runner?\n\n2.284.0 using docker image based on ubuntu:20.04. The image has the runner pre-installed We have a handful of utilities pre-installed and also run the `installdependencies.sh` during image creation.\n\n## What's not working?\nActions steps, like actions/checkout@v2\n\nAction workflow:\n\njobs:\n test-build:\n runs-on: self-hosted\n steps:\n - name: pull\n uses: actions/checkout@v2\n\n## Job Log Output\n\n##[group]Run actions/checkout@v2\n2021-11-04T15:18:27.5101918Z with:\n2021-11-04T15:18:27.5102825Z repository: ****\n2021-11-04T15:18:27.5104008Z token: ***\n2021-11-04T15:18:27.5104359Z ssh-strict: true\n2021-11-04T15:18:27.5104777Z persist-credentials: true\n2021-11-04T15:18:27.5105183Z clean: true\n2021-11-04T15:18:27.5105527Z fetch-depth: 1\n2021-11-04T15:18:27.5105854Z lfs: false\n2021-11-04T15:18:27.5106199Z submodules: false\n2021-11-04T15:18:27.5106549Z ##[endgroup]\n2021-11-04T15:18:27.5182071Z ##[error]No such file or directory\n2021-11-04T15:18:27.5190763Z ##[debug]System.ComponentModel.Win32Exception (2): No such file or directory\n2021-11-04T15:18:27.5192403Z ##[debug] at System.Diagnostics.Process.ForkAndExecProcess(String filename, String[] argv, String[] envp, String cwd, Boolean redirectStdin, Boolean redirectStdout, Boolean redirectStderr, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec)\n2021-11-04T15:18:27.5194067Z ##[debug] at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)\n2021-11-04T15:18:27.5195191Z ##[debug] at System.Diagnostics.Process.Start()\n2021-11-04T15:18:27.5197055Z ##[debug] at GitHub.Runner.Sdk.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)\n2021-11-04T15:18:27.5200247Z ##[debug] at GitHub.Runner.Common.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)\n2021-11-04T15:18:27.5203334Z ##[debug] at GitHub.Runner.Worker.Handlers.DefaultStepHost.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, CancellationToken cancellationToken)\n2021-11-04T15:18:27.5205631Z ##[debug] at GitHub.Runner.Worker.Handlers.NodeScriptActionHandler.RunAsync(ActionRunStage stage)\n2021-11-04T15:18:27.5206859Z ##[debug] at GitHub.Runner.Worker.ActionRunner.RunAsync()\n2021-11-04T15:18:27.5207933Z ##[debug] at GitHub.Runner.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)","author_login":"MichaelJJ","author_association":"NONE","created_at":"2021-11-04T15:30:29+08:00","repo_name":"actions/runner","issue_id":1044892296,"issue_number":1464,"issue_url":"https://github.com/actions/runner/issues/1464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_961169675","fragment_type":"issue_comment","sequence":1,"text":"@MichaelJJ the runner didn't call `git` directly, the `actions/checkout@v2` will call it.\nthe error seems related to the runner can't start the `actions/checkout@v2` actions.\n\nCan your runner run step? only `actions/checkout@v2` fail or all kinds of steps in the job are failing?\n\nAlso, make sure you don't have a really big environment set on the environment or in your job since a huge environment variable block might block creating a new process on the OS.","author_login":"TingluoHuang","author_association":"MEMBER","created_at":"2021-11-04T15:44:08+08:00","repo_name":"actions/runner","issue_id":1044892296,"issue_number":1464,"issue_url":"https://github.com/actions/runner/issues/1464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_961180100","fragment_type":"issue_comment","sequence":2,"text":"It doesn't appear to be able to run any step, I've also tried actions/setup-python@v2.\n\nI don't have any env variables set. This is the entire workflow:\n\nname: Run\n\non:\n workflow_dispatch: {}\n \njobs:\n Test-Job:\n runs-on: self-hosted\n steps:\n - uses: actions/checkout@v2\n``\n\nI've also attached the dockerfile used to create the agent The entrypoint script simply starts the runner on container start.\nDockerfile-runner.txt","author_login":"MichaelJJ","author_association":"NONE","created_at":"2021-11-04T15:55:56+08:00","repo_name":"actions/runner","issue_id":1044892296,"issue_number":1464,"issue_url":"https://github.com/actions/runner/issues/1464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_961202925","fragment_type":"issue_comment","sequence":3,"text":"&& mv ./externals ./externalstmp \\\n\n☝️ I assume that's the problem?","author_login":"TingluoHuang","author_association":"MEMBER","created_at":"2021-11-04T16:21:18+08:00","repo_name":"actions/runner","issue_id":1044892296,"issue_number":1464,"issue_url":"https://github.com/actions/runner/issues/1464","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_961204345","fragment_type":"issue_comment","sequence":4,"text":"Yes, I copied the dockerfile from another project and missed that portion.","author_login":"MichaelJJ","author_association":"NONE","created_at":"2021-11-04T16:22:52+08:00","repo_name":"actions/runner","issue_id":1044892296,"issue_number":1464,"issue_url":"https://github.com/actions/runner/issues/1464","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0339","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"test(e2e): parallelize tests to improve CI times?","query_context":"## Background\n\nSince our tests are now independent, we can parallelize them to improve CI times\n\n## Suggested Design\n\nAdd `s.T().Parallel()` to the following:\n- `TestIBCTokenTransferAndCreatePool`\n- `TestSuperfluidVoting`\n- `TestAddToExistingLockPostUpgrade`\n- `TestAddToExistingLock`\n- `TestTWAP`\n- `TestExpeditedProposals`\n\nNote:\n`TestStateSync` cannot be parallelized\n\n## Acceptance Criteria\n- tests are parallelized\n- benchmark CI time improvement\n- ensure that the following still work locally:\n * `make test-e2e-debug`\n * `make test-e2e-short`","known_context_document_ids":["gh_issue_1365326459"],"reference_answer":"Yes, this is not useful at all for regular cases. However, the goal here is to log so that we can see the reasons for failure _when it fails_\n \n\nThis is exactly the problem - it is hard to tell when a transaction is successful and when it is not **in a general way**\n\nOff the top of my head, the problems are:\n- success is sometimes logged to stdout, other times in stderr\n- Some CLI commands log \"error\" to the output when they are successful so it is non-trivial to do some regex/pattern matching.\n\nI'm open to investigating identifying the tx fails more. However, from my previous attempts, there are quite a few edge cases to work around. I can try looking into this again after v12","answer_document_id":"gh_comment_1242228262","silver_evidence_path":["gh_comment_1241773362","gh_issue_1366405261","gh_comment_1242228262"],"evidence_issue_ids":[1365326459,1366405261],"source_repo_name":"osmosis-labs/osmosis","source_issue_id":1365326459,"source_issue_number":2646,"source_issue_url":"https://github.com/osmosis-labs/osmosis/issues/2646","target_repo_name":"osmosis-labs/osmosis","target_issue_id":1366405261,"target_issue_number":2653,"target_issue_url":"https://github.com/osmosis-labs/osmosis/issues/2653","reference_anchor_document_id":"gh_comment_1241773362","reference_answer_author":"p0mvn","reference_answer_author_association":"MEMBER","quality_score":85.06,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0952,"anchor_target_overlap":0.1905,"target_answer_overlap":0.0488},"issue_created_at":"2022-09-08T00:09:19+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1365326459","fragment_type":"issue_description","sequence":0,"text":"test(e2e): parallelize tests to improve CI times\n## Background\n\nSince our tests are now independent, we can parallelize them to improve CI times\n\n## Suggested Design\n\nAdd `s.T().Parallel()` to the following:\n- `TestIBCTokenTransferAndCreatePool`\n- `TestSuperfluidVoting`\n- `TestAddToExistingLockPostUpgrade`\n- `TestAddToExistingLock`\n- `TestTWAP`\n- `TestExpeditedProposals`\n\nNote:\n`TestStateSync` cannot be parallelized\n\n## Acceptance Criteria\n- tests are parallelized\n- benchmark CI time improvement\n- ensure that the following still work locally:\n * `make test-e2e-debug`\n * `make test-e2e-short`","author_login":"p0mvn","author_association":"MEMBER","created_at":"2022-09-08T00:09:19+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1365326459,"issue_number":2646,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2646","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1241358123","fragment_type":"issue_comment","sequence":1,"text":"Might not be as simple as adding `s.T().Parallel()` due to the need for synchronizing some shared variables.","author_login":"p0mvn","author_association":"MEMBER","created_at":"2022-09-09T00:16:30+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1365326459,"issue_number":2646,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241773362","fragment_type":"issue_comment","sequence":2,"text":"I also am suspicious that this is where the big speedup will come from, vs block time changes\n\nIts a bit hard to see right now due to #2653 , but my recollection from before was that the time from traces looked to mostly be in waiting for blocks to occur.","author_login":"ValarDragon","author_association":"MEMBER","created_at":"2022-09-09T10:06:27+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1365326459,"issue_number":2646,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2646","linked_issue_ids":[1366405261],"is_known_query_context":false},{"document_id":"gh_issue_1366405261","fragment_type":"issue_description","sequence":0,"text":"tests/e2e: revert logging all tx results\n## Background\n\nNot sure when it was added, but the e2e test suite is now logging all tx results. This should be reverted, as it massively crowds out the logs, and makes it hard to get relevant info at a glance. (Perhaps at most logging a tx hash by default, so you can quer)\n\nIf this is helpful for a particular debugging flow right now, we can add ways to improve that same debugging flows. (e.g. display results for last 3 txs)","author_login":"ValarDragon","author_association":"MEMBER","created_at":"2022-09-08T14:04:14+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1366405261,"issue_number":2653,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241336356","fragment_type":"issue_comment","sequence":1,"text":"I think this has significantly improved the debugging experience. If these are not present, it is close to impossible to tell what exactly happened in the failing container / why did a certain CLI command fail.\n\nIn the long term, we should instead pipe logs from each container to a file and preserve them as artifacts after running the CI job. This would remove the need for the extra logging. However, in the meantime, I think having more logs is better than having none","author_login":"p0mvn","author_association":"MEMBER","created_at":"2022-09-08T23:33:04+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1366405261,"issue_number":2653,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1241746736","fragment_type":"issue_comment","sequence":2,"text":"This is the log from the first TX I saw in the logs: URL \n\nIts about 400 lines. Not sure which part of this is helpful for debugging in the normal case, beyond `txhash, stdout, stderr`. We can get the remainder of events & log from querying the txhash, but I don't see how this helps the standard case","author_login":"ValarDragon","author_association":"MEMBER","created_at":"2022-09-09T09:40:52+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1366405261,"issue_number":2653,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2653","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1242228262","fragment_type":"issue_comment","sequence":3,"text":"Yes, this is not useful at all for regular cases. However, the goal here is to log so that we can see the reasons for failure _when it fails_\n \n\nThis is exactly the problem - it is hard to tell when a transaction is successful and when it is not **in a general way**\n\nOff the top of my head, the problems are:\n- success is sometimes logged to stdout, other times in stderr\n- Some CLI commands log \"error\" to the output when they are successful so it is non-trivial to do some regex/pattern matching.\n\nI'm open to investigating identifying the tx fails more. However, from my previous attempts, there are quite a few edge cases to work around. I can try looking into this again after v12","author_login":"p0mvn","author_association":"MEMBER","created_at":"2022-09-09T17:00:45+08:00","repo_name":"osmosis-labs/osmosis","issue_id":1366405261,"issue_number":2653,"issue_url":"https://github.com/osmosis-labs/osmosis/issues/2653","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0340","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Step-by-step guide to enable shortcuts in Ubuntu and other popular Linux distributions?","query_context":"Despite the mentions of D-Bus and the need to use system level shortcuts, the process for non-developers like myself is not entirely straightforward. So this may limit the user audience.\n\nI might try to make the PR adding to README.md myself. I just want to know if this makes sense.","known_context_document_ids":["gh_issue_2035562135"],"reference_answer":"With this parameter it will run \"natively\" on Wayland. Without it will run through XWayland. It's a compatibility layer.\nOn my phone I set this variable globally for all Qt applications.","answer_document_id":"gh_comment_1847899337","silver_evidence_path":["gh_comment_1860009322","gh_issue_2028796120","gh_comment_1847899337"],"evidence_issue_ids":[2035562135,2028796120],"source_repo_name":"crow-translate/crow-translate","source_issue_id":2035562135,"source_issue_number":640,"source_issue_url":"https://github.com/crow-translate/crow-translate/issues/640","target_repo_name":"crow-translate/crow-translate","target_issue_id":2028796120,"target_issue_number":638,"target_issue_url":"https://github.com/crow-translate/crow-translate/issues/638","reference_anchor_document_id":"gh_comment_1860009322","reference_answer_author":"Shatur","reference_answer_author_association":"MEMBER","quality_score":94.57,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.16,"anchor_target_overlap":0.16,"target_answer_overlap":0.0714},"issue_created_at":"2023-12-11T12:23:15+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2035562135","fragment_type":"issue_description","sequence":0,"text":"Step-by-step guide to enable shortcuts in Ubuntu and other popular Linux distributions\nDespite the mentions of D-Bus and the need to use system level shortcuts, the process for non-developers like myself is not entirely straightforward. So this may limit the user audience.\n\nI might try to make the PR adding to README.md myself. I just want to know if this makes sense.","author_login":"poglazov","author_association":"NONE","created_at":"2023-12-11T12:23:15+08:00","repo_name":"crow-translate/crow-translate","issue_id":2035562135,"issue_number":640,"issue_url":"https://github.com/crow-translate/crow-translate/issues/640","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1860009322","fragment_type":"issue_comment","sequence":1,"text":"Not sure what you mean, but Wayland is the default since Ubuntu 21.04.\n\nI'm using Ubuntu 22.04.3 LTS and ran into an issue: URL I had heard a little about Wayland, but had no idea how it related to keyboard shortcuts.\n\nI believe that a large portion of Linux users have Ubuntu with Wayland, so I want to make it easier for them to use Crow.","author_login":"poglazov","author_association":"NONE","created_at":"2023-12-18T10:11:25+08:00","repo_name":"crow-translate/crow-translate","issue_id":2035562135,"issue_number":640,"issue_url":"https://github.com/crow-translate/crow-translate/issues/640","linked_issue_ids":[2028796120],"is_known_query_context":false},{"document_id":"gh_comment_1860023296","fragment_type":"issue_comment","sequence":2,"text":"Ubuntu usually at 6-8 place by popularity according to URL \nWhile I see the point of step-by-step instruction, it will be different for different DE's. Event Kubuntu and Ubuntu will have different instructions. I would prefer to avoid maintaining it.\nI would suggest to blame Wayland for it because it doesn't provide any DE-independent way for global shortcuts.","author_login":"Shatur","author_association":"MEMBER","created_at":"2023-12-18T10:16:55+08:00","repo_name":"crow-translate/crow-translate","issue_id":2035562135,"issue_number":640,"issue_url":"https://github.com/crow-translate/crow-translate/issues/640","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2028796120","fragment_type":"issue_description","sequence":0,"text":"On Ubuntu 22.04, global shortcuts work in Google Chrome and do not work in gedit, Evince, ...\n**Bug description**\nBoth default Ctrl - Alt - E and a new shortcut I set instead:\n- work in Google Chrome,\n- don't work in most other applications, e.g. gedit and Evince.\n\nI've read that \"Wayland does not support global shortcuts registration, but you can use D-Bus to bind actions in the system settings.\", but I can't figure out why it works in Google Chrome.\n\n**Environment**\n\n- OS: Ubuntu 22.04.3 LTS\n- Desktop environment: GNOME 42.9\n- Crow Translate version: 2.11.0\n- Windowing System: Wayland","author_login":"poglazov","author_association":"NONE","created_at":"2023-12-06T15:21:36+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1843182253","fragment_type":"issue_comment","sequence":1,"text":"Most likely you run Crow on XWayland and it works with other XWayland applications, like Google Chrome.","author_login":"Shatur","author_association":"MEMBER","created_at":"2023-12-06T15:52:53+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1843240497","fragment_type":"issue_comment","sequence":2,"text":"Could you tell how can I check it?\n\nI tried \nxlsclients\n as a random internet advice tells. It tells that Google Chrome does run on XWayland, but Crow doesn't: \nScreenshot from 2023-12-06 22-22-15","author_login":"poglazov","author_association":"NONE","created_at":"2023-12-06T16:26:40+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847682287","fragment_type":"issue_comment","sequence":3,"text":"You were right:\n\npavel@pavel-ux31a:~$ env | grep QT\nQT_ACCESSIBILITY=1\nQT_IM_MODULE=ibus\npavel@pavel-ux31a:~$ export QT_QPA_PLATFORM=wayland\npavel@pavel-ux31a:~$ env | grep QT\nQT_ACCESSIBILITY=1\nQT_QPA_PLATFORM=wayland\nQT_IM_MODULE=ibus\npavel@pavel-ux31a:~$ crow \nWarning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.\nQSocketNotifier: Can only be used with threads started with QThread\n\nNow the shortcuts don't work in either Chrome or gedit. Crow app itself also works worse, e.g. not all entered text is displayed.\n\nI wish shortcuts worked across all apps, and Crow worked well.\n\nWhat should I do?","author_login":"poglazov","author_association":"NONE","created_at":"2023-12-08T19:06:55+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847776775","fragment_type":"issue_comment","sequence":4,"text":"On Wayland there is no API for global shortcuts. Each DE implements global shortcuts in its own specific way and you need to manually register D-Bus commands on shortcuts. But now you should have working selection translation. Try it out.\n \n\nThis is odd. I assume that it could be some GNOME-specific bug. I run the app my phone on Phosh (a DE similar to GNOME, but mobile oriented) and the app work fine.","author_login":"Shatur","author_association":"MEMBER","created_at":"2023-12-08T20:03:54+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847832467","fragment_type":"issue_comment","sequence":5,"text":"Thank you for explanation.\n\nI created a Gnome shortcut running dbus-send, disabled global shortcuts in Crow, and now the shortcut works in both Chrome and gedit: \nimage\n\nThe shortcut works both with Crow running with QT_QPA_PLATFORM=wayland and without it. Which option should I use?","author_login":"poglazov","author_association":"NONE","created_at":"2023-12-08T20:54:57+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847899337","fragment_type":"issue_comment","sequence":6,"text":"With this parameter it will run \"natively\" on Wayland. Without it will run through XWayland. It's a compatibility layer.\nOn my phone I set this variable globally for all Qt applications.","author_login":"Shatur","author_association":"MEMBER","created_at":"2023-12-08T22:04:01+08:00","repo_name":"crow-translate/crow-translate","issue_id":2028796120,"issue_number":638,"issue_url":"https://github.com/crow-translate/crow-translate/issues/638","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0342","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"UI stops functioning, but doesn't completely block/hang?","query_context":"Does this issue occur when all extensions are disabled?: I don't know, as this issue takes a while to happen and VS Code is unusable for me without extensions so I cannot use it long enough to see if the issue reproduces. I guess this is a downside of a minimal core system that favours functionality in plugins and not in the core.\n\n \n \n- VS Code Version:\nVersion: 1.76.1\nCommit: 5e805b79fcb6ba4c2d23712967df89a089da575b\nDate: 2023-03-08T16:31:31.010Z\nElectron: 19.1.11\nChromium: 102.0.5005.196\nNode.js: 16.14.2\nV8: 10.2.154.26-electron.0\nOS: Linux x64 6.1.15-200.fc37.x86_64\nSandboxed: Yes\n\n- OS Version: Fedora 37\n\nSteps to Reproduce:\n\n1. Use VS Code\n2. That's all I know at this point\n\nBut after a while of using it it will simply stop accepting any input, either in the form of keystrokes or mouse clicks. It is not completely hung/blocked though. There is an \"activity\" bar at the top of the _Source Control_ pane that is moving from right to left over and over again. The same \"activity\" bar seems to be happening on the _Commits_ sub-pane.\n\nI can change tabs. But I cannot edit in any of them. The _Source Control_ pane is not showing any files as being edited even though there are some. I can scroll in the _Commits_ subpane. I can click on new files in that subpane's \"Compare ...\" -> \"* files changed\" but the editor does not switch to that file.\n\nI do also have the following in the OUTPUT tab:\n\n[Error - 05:31:53] Sending notification cpptools/onIntervalTimer failed.\nError: Cannot call write after a stream was destroyed\n at new NodeError (node:internal/errors:371:5)\n at _write (node:internal/streams/writable:321:11)\n at Socket.Writable.write (node:internal/streams/writable:334:10)\n at /home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59851:29\n at new Promise ( )\n at WritableStreamWrapper.write (/home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59841:16)\n at StreamMessageWriter.doWrite (/home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59053:33)\n at /home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59044:29\n at runNextTicks (node:internal/process/task_queues:61:5)\n at processImmediate (node:internal/timers:437:9)\n[Error - 05:31:53] The language server crashed. Restarting...\n\nAbout the only thing that ever resolves this is a _Developer: Reload Window_ action. But even then, it only lasts a few minutes, or seconds even and it goes back to be unresponsive.\n\nI am sure there is nowhere near enough info here to diagnose, but I am happy to take guidance on collecting enough info.","known_context_document_ids":["gh_issue_1623329919"],"reference_answer":"This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.\n\nHappy Coding!","answer_document_id":"gh_comment_1868273464","silver_evidence_path":["gh_comment_1474266258","gh_issue_1626177883","gh_comment_1868273464"],"evidence_issue_ids":[1623329919,1626177883],"source_repo_name":"microsoft/vscode","source_issue_id":1623329919,"source_issue_number":177072,"source_issue_url":"https://github.com/microsoft/vscode/issues/177072","target_repo_name":"microsoft/vscode","target_issue_id":1626177883,"target_issue_number":177282,"target_issue_url":"https://github.com/microsoft/vscode/issues/177282","reference_anchor_document_id":"gh_comment_1474266258","reference_answer_author":"VSCodeTriageBot","reference_answer_author_association":"COLLABORATOR","quality_score":86.57,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3056,"anchor_target_overlap":0.1111,"target_answer_overlap":0.0714},"issue_created_at":"2023-03-14T11:59:46+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1623329919","fragment_type":"issue_description","sequence":0,"text":"UI stops functioning, but doesn't completely block/hang\nDoes this issue occur when all extensions are disabled?: I don't know, as this issue takes a while to happen and VS Code is unusable for me without extensions so I cannot use it long enough to see if the issue reproduces. I guess this is a downside of a minimal core system that favours functionality in plugins and not in the core.\n\n \n \n- VS Code Version:\nVersion: 1.76.1\nCommit: 5e805b79fcb6ba4c2d23712967df89a089da575b\nDate: 2023-03-08T16:31:31.010Z\nElectron: 19.1.11\nChromium: 102.0.5005.196\nNode.js: 16.14.2\nV8: 10.2.154.26-electron.0\nOS: Linux x64 6.1.15-200.fc37.x86_64\nSandboxed: Yes\n\n- OS Version: Fedora 37\n\nSteps to Reproduce:\n\n1. Use VS Code\n2. That's all I know at this point\n\nBut after a while of using it it will simply stop accepting any input, either in the form of keystrokes or mouse clicks. It is not completely hung/blocked though. There is an \"activity\" bar at the top of the _Source Control_ pane that is moving from right to left over and over again. The same \"activity\" bar seems to be happening on the _Commits_ sub-pane.\n\nI can change tabs. But I cannot edit in any of them. The _Source Control_ pane is not showing any files as being edited even though there are some. I can scroll in the _Commits_ subpane. I can click on new files in that subpane's \"Compare ...\" -> \"* files changed\" but the editor does not switch to that file.\n\nI do also have the following in the OUTPUT tab:\n\n[Error - 05:31:53] Sending notification cpptools/onIntervalTimer failed.\nError: Cannot call write after a stream was destroyed\n at new NodeError (node:internal/errors:371:5)\n at _write (node:internal/streams/writable:321:11)\n at Socket.Writable.write (node:internal/streams/writable:334:10)\n at /home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59851:29\n at new Promise ( )\n at WritableStreamWrapper.write (/home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59841:16)\n at StreamMessageWriter.doWrite (/home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59053:33)\n at /home/brian/.vscode/extensions/ms-vscode.cpptools-1.14.4-linux-x64/dist/main.js:59044:29\n at runNextTicks (node:internal/process/task_queues:61:5)\n at processImmediate (node:internal/timers:437:9)\n[Error - 05:31:53] The language server crashed. Restarting...\n\nAbout the only thing that ever resolves this is a _Developer: Reload Window_ action. But even then, it only lasts a few minutes, or seconds even and it goes back to be unresponsive.\n\nI am sure there is nowhere near enough info here to diagnose, but I am happy to take guidance on collecting enough info.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-14T11:59:46+08:00","repo_name":"microsoft/vscode","issue_id":1623329919,"issue_number":177072,"issue_url":"https://github.com/microsoft/vscode/issues/177072","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1474221512","fragment_type":"issue_comment","sequence":1,"text":"I don't follow, can you share a gif?\n\nDoes this happen if you disable extensions? eg F1 > Disable All Installed Extensions.\n\nIf that resolves it, maybe you can work out which extension is responsible by using the \"Start Extension Bisect\" command","author_login":"roblourens","author_association":"MEMBER","created_at":"2023-03-17T18:08:35+08:00","repo_name":"microsoft/vscode","issue_id":1623329919,"issue_number":177072,"issue_url":"https://github.com/microsoft/vscode/issues/177072","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1474266258","fragment_type":"issue_comment","sequence":2,"text":"I don't know how to make those.\n \n\nI answered that in the original post. VS Code is quite unusable without extensions and given that this doesn't happen immediately, VS Code would not be usable enough for me to wait for it to happen. I would open it and wouldn't be able to do anything useful with it, so the problem likely would never reproduce as it's not doing anything.\n\nBut honestly, VS Code is completely unusable for me at the moment so I cannot add anything useful to this issue.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-17T18:47:10+08:00","repo_name":"microsoft/vscode","issue_id":1623329919,"issue_number":177072,"issue_url":"https://github.com/microsoft/vscode/issues/177072","linked_issue_ids":[1626177883],"is_known_query_context":false},{"document_id":"gh_comment_1480464667","fragment_type":"issue_comment","sequence":3,"text":"I wonder whether this issue is related to the other one?\n\nI don't really understand what you are seeing in the SCM view though, and that sounds like a good clue. If you are able, we might also get some information from \n\n- F1 > Set Log Level > Trace\n- repro the issue and grab the log from the Window output channel","author_login":"roblourens","author_association":"MEMBER","created_at":"2023-03-23T01:40:37+08:00","repo_name":"microsoft/vscode","issue_id":1623329919,"issue_number":177072,"issue_url":"https://github.com/microsoft/vscode/issues/177072","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481165506","fragment_type":"issue_comment","sequence":4,"text":"None of that is going to be possible until #177282 (which is a blocking crasher for me and has had no activity at all!) is resolved. That is a complete and outright hang and crash after an OOM.\n\nThe window freezes entirely as soon as I select _Source Control_ from the left pane, pops a few WNRs (window not responding) until it finally crashes outright and is terminated. The active plugin on the plugin bar on the left doesn't even show a change that is how quickly the window freezes, so there is no functioning \"Window output channel\" to grab a log from.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-23T13:08:00+08:00","repo_name":"microsoft/vscode","issue_id":1623329919,"issue_number":177072,"issue_url":"https://github.com/microsoft/vscode/issues/177072","linked_issue_ids":[1626177883],"is_known_query_context":false},{"document_id":"gh_comment_1587136761","fragment_type":"issue_comment","sequence":5,"text":"Hey @roblourens, this issue might need further attention.\n\n@brianjmurrell, you can help us out by closing this issue if the problem no longer exists, or adding more information.","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2023-06-12T11:25:34+08:00","repo_name":"microsoft/vscode","issue_id":1623329919,"issue_number":177072,"issue_url":"https://github.com/microsoft/vscode/issues/177072","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1626177883","fragment_type":"issue_description","sequence":0,"text":"Memory use grows until OOM\nDoes this issue occur when all extensions are disabled?: Yes\n\n \n \n- VS Code Version: \n\nVersion: 1.76.1\nCommit: 5e805b79fcb6ba4c2d23712967df89a089da575b\nDate: 2023-03-08T16:31:31.010Z\nElectron: 19.1.11\nChromium: 102.0.5005.196\nNode.js: 16.14.2\nV8: 10.2.154.26-electron.0\nOS: Linux x64 6.1.15-200.fc37.x86_64\nSandboxed: Yes\n\n- OS Version: Fedora 37\n\nSteps to Reproduce:\n\n1. `code --disable-extensions`\n2. Select _Source Control_ from the left pane\n3. Watch memory growth with `top` -- it gobbles up GBs of RAM\n4. Dismiss several **The window is not responding** dialogs with _Keep waiting_\n5. Finally get a new dialog **The window terminated unexpected (reason: 'crashed', code: 132')** with an option to _Reopen_\n6. Click _Reopen_\n7. Rinse\n8. Repeat\n\nVS Code is now entirely unusable for me.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-15T19:43:40+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470749294","fragment_type":"issue_comment","sequence":1,"text":"Native crash dump in zip archive\n\nApologies, but put into a zip simply to placate GitHub's supported file types.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-15T19:54:05+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1473880308","fragment_type":"issue_comment","sequence":2,"text":"Any ideas on this? I hate to sound impatient, but this one is a complete blocker for me. VS Code is entirely unusable at this point. Have to go back to the `git` CLI and vim fugititve, which clearly is not a nice and functional as VS Code.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-17T13:54:25+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1481168983","fragment_type":"issue_comment","sequence":3,"text":"Is it too much to ask to get some help on this one given that VS Code is completely unusable for me on this? This is not just some functionality that isn't working. This is a full-out hang and crash as soon as I select _Source Control_, which I am sure you can understand is vital functionality.\n\nJust to clarify regarding the \"freeze-slow-crash-leak\" label, there is nothing slow about it. It happens immediately upon selecting _Source Control_ which is what makes this such a blocker for me.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-03-23T13:10:22+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1498020122","fragment_type":"issue_comment","sequence":4,"text":"Still no update here? Can somebody **PLEASE** look into this?\n\nIs there not enough information? What else can I provide? I am happy to do the leg work here.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-04-05T19:40:08+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505483702","fragment_type":"issue_comment","sequence":5,"text":"I was able to resolve this by doing a `git gc` in the repo that was causing it.\n\nHaving VS Code OOM and crash due to this situation is clearly sub-optimal.","author_login":"brianjmurrell","author_association":"NONE","created_at":"2023-04-12T15:33:10+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1608456401","fragment_type":"issue_comment","sequence":6,"text":"In the past few days, the crash has been extremely severe. If I play Dota2 and turn on VScode, my computer will crash directly after a while","author_login":"shijunti19","author_association":"NONE","created_at":"2023-06-26T23:23:29+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1858497501","fragment_type":"issue_comment","sequence":7,"text":"Do you still face the issue with latest versions without having to perform `git gc` as a workaround ? If the issue persists, it would be great if you can share a minimal repro.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-12-15T21:14:54+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1868273464","fragment_type":"issue_comment","sequence":8,"text":"This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.\n\nHappy Coding!","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2023-12-23T11:25:07+08:00","repo_name":"microsoft/vscode","issue_id":1626177883,"issue_number":177282,"issue_url":"https://github.com/microsoft/vscode/issues/177282","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0343","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Is Indexhibit dead?","query_context":"Hi,\n\nI've been contacted by an artist friend about migrating his indexhibit portfolio to wordpress so as to get a responsive version of his website. My first reflex was to go check on indexhibit.org whether there was new updates and possibly someone might have worked on responsive templates for indexhibit, but the front page of indexhibit.org is empty or nearly empty, and the last updates were done last year...\n\nMaybe it's time to announce that the project is not maintained anymore?\n\nAn official announcement would allow people to start planning for a migration.\n\nIt was a lovely project btw, I loved working with it a few years back!\n\nBest to you and thanks for everything,\n\nmaathieu","known_context_document_ids":["gh_issue_1137887514"],"reference_answer":"It's amazing how much people know about me. The projects fail because it takes time and money. Where were all of you when I was trying to find donations? How many have emailed me begging for free help - not offering to hire me or pay me for working on your personal site? It's totally unfair that I am responsible and underappreciated. Can you afford to work for over a decade for free? I simply can't. When I have time...I have time...this is the reality. I really do not appreciate that my personal email was posted in this thread...","answer_document_id":"gh_comment_1010635166","silver_evidence_path":["gh_comment_1039743227","gh_issue_887336803","gh_comment_1010635166"],"evidence_issue_ids":[1137887514,887336803],"source_repo_name":"Indexhibit/indexhibit","source_issue_id":1137887514,"source_issue_number":29,"source_issue_url":"https://github.com/Indexhibit/indexhibit/issues/29","target_repo_name":"Indexhibit/indexhibit","target_issue_id":887336803,"target_issue_number":28,"target_issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","reference_anchor_document_id":"gh_comment_1039743227","reference_answer_author":"Indexhibit","reference_answer_author_association":"OWNER","quality_score":85.44,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1724,"anchor_target_overlap":0.1379,"target_answer_overlap":0.0488},"issue_created_at":"2022-02-14T21:48:05+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1137887514","fragment_type":"issue_description","sequence":0,"text":"Is Indexhibit dead?\nHi,\n\nI've been contacted by an artist friend about migrating his indexhibit portfolio to wordpress so as to get a responsive version of his website. My first reflex was to go check on indexhibit.org whether there was new updates and possibly someone might have worked on responsive templates for indexhibit, but the front page of indexhibit.org is empty or nearly empty, and the last updates were done last year...\n\nMaybe it's time to announce that the project is not maintained anymore?\n\nAn official announcement would allow people to start planning for a migration.\n\nIt was a lovely project btw, I loved working with it a few years back!\n\nBest to you and thanks for everything,\n\nmaathieu","author_login":"maathieu","author_association":"NONE","created_at":"2022-02-14T21:48:05+08:00","repo_name":"Indexhibit/indexhibit","issue_id":1137887514,"issue_number":29,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/29","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1039743227","fragment_type":"issue_comment","sequence":1,"text":"The author had mention it’s not being maintained due to exhaustion of resource: he was doing it for free anyway, and if you look at the earlier post, you’d understand you should not expect updates and supports. \n\nsaid earlier post \n\nThen again if you need a responsive site you shouldn’t be looking at indexhibit, it is a platform designed from the time of simpler sites.","author_login":"giisha","author_association":"NONE","created_at":"2022-02-15T01:09:31+08:00","repo_name":"Indexhibit/indexhibit","issue_id":1137887514,"issue_number":29,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/29","linked_issue_ids":[887336803],"is_known_query_context":false},{"document_id":"gh_comment_1068211320","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your answer. I hope the author can update the Readme so that people can see straight away that the project is over :-).","author_login":"maathieu","author_association":"NONE","created_at":"2022-03-15T16:46:00+08:00","repo_name":"Indexhibit/indexhibit","issue_id":1137887514,"issue_number":29,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/29","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_887336803","fragment_type":"issue_description","sequence":0,"text":"PHP 8 compatibility?\nVaska, I'm raising this here rather than the forum because the forum is not accepting new postings. This is a critical problem and not just a \"How do I ...\" question.\n\nMy hosting service has just upgraded to PHP8 and my indexhibit 2.1.6 site has immediately stopped working. Browser generates this error: `[Domain] is currently unable to handle this request. HTTP ERROR 500 `\n\nDoes this require an update to indexhibit code, or is there a setting I can update myself? I'm no expert in php and am flying blind ... also slightly panicked.","author_login":"5833tP2","author_association":"NONE","created_at":"2021-05-11T13:46:12+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008314604","fragment_type":"issue_comment","sequence":1,"text":"Hi 5833tP2,\n\nDid you find any solution to this? I've been spending two days trying to resolve the same issue looking at the Indexhibit forum, but I haven't found any solution and I've made too many attempts at changing so nothing works anymore.\n\nSlightly panicked too :)\nThanks !\nTrd","author_login":"TandiRD","author_association":"NONE","created_at":"2022-01-09T15:05:20+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008317369","fragment_type":"issue_comment","sequence":2,"text":"No solution at all, I'm afraid @TandiRD. I got no response to my posting. In depseration, I migrated my site to another platform. I hated having to do it but there was no other option for me. You could try emailing Vaska directly at studio@vaska.com. Sorry I don't have better news.","author_login":"5833tP2","author_association":"NONE","created_at":"2022-01-09T15:20:53+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008336919","fragment_type":"issue_comment","sequence":3,"text":"This has happened to me over time, with various hosts deprecating EOL'ed PHP versions. I think I recall trying to get in touch with the devs directly as well. Tragically I decided to move away from indexhibit as it seems more or less retired by the devs. Unfortunate loss of an elegant and fun tool.","author_login":"kees-","author_association":"NONE","created_at":"2022-01-09T17:05:52+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008361366","fragment_type":"issue_comment","sequence":4,"text":"Thank you both @5833tP2 & @kees- for the fast reply! I'll try e-mailing Vaska and if not migrating to another site. That would be a pitty though, Indexhibit is such a good tool. I don't understand how the passage to php 8 could mess it all up. I thought it was an advantage to always have the last version.","author_login":"TandiRD","author_association":"NONE","created_at":"2022-01-09T19:42:33+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1010353304","fragment_type":"issue_comment","sequence":5,"text":"The world of updating software architecture is not comparable to the end user experience, where updating to the latest app, the newest operating system, buying the newest phone is all generally safe practice.\n\nCreating a piece of software involves depending on all sorts of _things_ related to computers. Nothing is ever created from scratch. Even the earliest calculating machines relied on stable formal systems: the laws of math, physics.. Think about how when you do something as simple as arithmetic, you're trusting that the rules of combining some numbers to get a new result haven't changed, because that would break your calculations. So back to computer science, the design process is about where you place your trust among a large stack of tools, rules, and systems that you must rely on. One thing, in one time and place, must do exactly what you command it to.\n\nWith the countless things needed to develop software in the modern environment, you need to organize collections of them as they exist in specific times and places. These are called your **dependencies**. Dependencies can be languages, libraries, frameworks etc, all the way down to hardware.\n\nIn contrast to the essentially stable rules of arithmetic, active software is constantly being updated by developers to work better and do more. Security and user experience are also omnipresent concerns.\n\nThe web is all over the place in that regard. Things developed so quickly that certain tools have now been nearly unchanged for decades, while other efforts big and small can be downright ramshackle. When there's no precedent in a space, all something has to do to be widely adopted is work well enough for now. For major software like PHP, cleaning it up later involves rewriting lots of code and patching problems that compromise the security of its dependents. Largely for that reason, versioning is used to sort out what will work in one time and place, and what won't.\n\nAll this is just to spell out why deprecation happens. Stuff can't always be backwards compatible. Sometimes the effort to keep up is semantic, but sometimes involves so much refactoring that it plays a significant role in devs retiring fading projects.\n\nVaska has written about letting go of indexhibit. I do believe its only chance would be if it was picked up (more likely, completely recreated) by new dev(s). I hope this answer isn't pandering, I just wanted to explain it comprehensively because you were curious.","author_login":"kees-","author_association":"NONE","created_at":"2022-01-11T20:57:21+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1010635166","fragment_type":"issue_comment","sequence":6,"text":"It's amazing how much people know about me. The projects fail because it takes time and money. Where were all of you when I was trying to find donations? How many have emailed me begging for free help - not offering to hire me or pay me for working on your personal site? It's totally unfair that I am responsible and underappreciated. Can you afford to work for over a decade for free? I simply can't. When I have time...I have time...this is the reality. I really do not appreciate that my personal email was posted in this thread...","author_login":"Indexhibit","author_association":"OWNER","created_at":"2022-01-12T04:56:34+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1010753378","fragment_type":"issue_comment","sequence":7,"text":"@kees- I appreciate the comprehensive explanations. I was thinking it was something along those lines, but the forum incentivising php update got me confused.\n\n@Indexhibit those are very fair and valid points, food for thought on internet and labor. For what it’s worth: thank you for all your work and time. I understand however that gratitude doesn’t pay the bills and will keep that in mind for the future.","author_login":"TandiRD","author_association":"NONE","created_at":"2022-01-12T08:09:02+08:00","repo_name":"Indexhibit/indexhibit","issue_id":887336803,"issue_number":28,"issue_url":"https://github.com/Indexhibit/indexhibit/issues/28","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0344","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Populate the publication policy link, where missing?","query_context":"Some publication policies are good and have valuable information for the data users. It will be helpful to include the \"Publication Policy\" field on the dataset site. We can auto-populate the field with the pelican data or manually if the publisher is not publishing the publication policy link in their JSONs correctly. \n\n@sabahfromlondon what do you think?","known_context_document_ids":["gh_issue_1095525512"],"reference_answer":"Note that the original discussion in this issue was about overriding the from/to date for existing jobs. However, for unretrieved publications, we don't have a job at all, and want to also set the other overview fields: ocid prefix and license, so for implementing this, we should:","answer_document_id":"gh_comment_3245382101","silver_evidence_path":["gh_comment_1326429511","gh_issue_1424359903","gh_comment_3245382101"],"evidence_issue_ids":[1095525512,1424359903],"source_repo_name":"open-contracting/data-registry","source_issue_id":1095525512,"source_issue_number":192,"source_issue_url":"https://github.com/open-contracting/data-registry/issues/192","target_repo_name":"open-contracting/data-registry","target_issue_id":1424359903,"target_issue_number":256,"target_issue_url":"https://github.com/open-contracting/data-registry/issues/256","reference_anchor_document_id":"gh_comment_1326429511","reference_answer_author":"yolile","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1818,"anchor_target_overlap":0.4545,"target_answer_overlap":0.2174},"issue_created_at":"2022-01-06T17:21:47+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1095525512","fragment_type":"issue_description","sequence":0,"text":"Populate the publication policy link, where missing\nSome publication policies are good and have valuable information for the data users. It will be helpful to include the \"Publication Policy\" field on the dataset site. We can auto-populate the field with the pelican data or manually if the publisher is not publishing the publication policy link in their JSONs correctly. \n\n@sabahfromlondon what do you think?","author_login":"yolile","author_association":"MEMBER","created_at":"2022-01-06T17:21:47+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1006889885","fragment_type":"issue_comment","sequence":1,"text":"@yolile Can you share an example with Sabah, in case she hasn't seen a good one before?","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2022-01-06T19:52:42+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1006916294","fragment_type":"issue_comment","sequence":2,"text":"I have some examples in Spanish but not so many in English. But maybe the UK one is a good one URL and Zambia URL \n\nIn Spanish some examples are: \n- URL \n- URL \n- URL","author_login":"yolile","author_association":"MEMBER","created_at":"2022-01-06T20:34:50+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1026785973","fragment_type":"issue_comment","sequence":3,"text":"All of the INAI's publications publish a good publication policy, more examples: URL \n URL \netc\n\nAnd this is another example from Honduras URL","author_login":"yolile","author_association":"MEMBER","created_at":"2022-02-01T12:21:38+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1249927874","fragment_type":"issue_comment","sequence":4,"text":"We'd need to update `update_collection_metadata` to either:\n\n1. Just set a new `publication_policy` field\n2. Store the entire response from Pelican, so that we don't need to re-process old collections to get additional metadata","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2022-09-16T23:11:10+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1326403114","fragment_type":"issue_comment","sequence":5,"text":"Let's do (2) then. How should we name this new field? `metadata`, `pelican_response`, `pelican_metadata`, other?\n\nFor the record, this is a sample snippet of what pelican currently returns:\n\n` json\n{\n \"url\": \"The URL where the data can be downloaded isn't presently available.\",\n \"publisher\": \"Instituto Duranguense de Acceso a la Información Pública y de Protección de Datos Personales\",\n \"extensions\": [\n ],\n \"ocid_prefix\": \"ocds-ywf11i\",\n \"data_license\": \" URL \n \"published_to\": \"2021-11-03 19.51.47\",\n \"published_from\": \"2021-08-04 18.06.41\",\n \"publication_policy\": null\n}\n\n`","author_login":"yolile","author_association":"MEMBER","created_at":"2022-11-24T12:45:09+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1326415883","fragment_type":"issue_comment","sequence":6,"text":"Note that the only fields that we are missing from pelican are `extensions` and `publication_policy`, but I'm not sure if we will add more fields to pelican itself in the future. I'm happy with (2), but I'm not sure if we should remove all the other existing columns (`ocid_prefix`, `date_from`, `date_to`, `license`) and use the new JSON column instead, to be consistent.","author_login":"yolile","author_association":"MEMBER","created_at":"2022-11-24T12:56:00+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1326429511","fragment_type":"issue_comment","sequence":7,"text":"And, we want the `publication_policy` to be editable, right? From URL \n \n\nShould we also put this field (`metadata` or `publication_policy`) in the publication/collection form?","author_login":"yolile","author_association":"MEMBER","created_at":"2022-11-24T13:07:18+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[1424359903],"is_known_query_context":false},{"document_id":"gh_comment_1326694504","fragment_type":"issue_comment","sequence":8,"text":"Let's call it `extracted_metadata`.\n \n\nIn #256 we want date_to/date_from to be overridable. So we can keep those. I think OCID prefix will always be correct, so we can remove that one.\n\nSimilarly, some publishers don't put a license in the package metadata, but they do include one in their docs, so we can leave `license_custom` to be overridden. (We can rename it to `license` and set `db_column=\"license_custom\"`, so that at least within the code the name of the field is consistent.)\n \n\nLet's save `extracted_metadata` for what's automatically extracted (read only), and then we can add `publication_policy` for the override. That way, the editable field will render automatically in the Django admin (not sure if there are good packages for editing structured JSON fields). We can display the `extracted_metadata` similar to how the Job `context` is rendered, so that admins can see whether they want to override something.\n\nWe can add a method to the model that returns the original metadata with any overrides as a new dict. That way, view code can just call `instance.metadata.license` and render the license, without worrying about whether it is the original value or not.","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2022-11-24T17:08:33+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[1424359903],"is_known_query_context":false},{"document_id":"gh_comment_1326739999","fragment_type":"issue_comment","sequence":9,"text":"Hmm actually, I think that maybe we want the publication policy to be overridable too, I can't remember a specific case but I'm pretty sure that there are some cases where a publication policy exists but is not referenced in the package metadata","author_login":"yolile","author_association":"MEMBER","created_at":"2022-11-24T17:54:21+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[1424359903],"is_known_query_context":false},{"document_id":"gh_comment_1326766470","fragment_type":"issue_comment","sequence":10,"text":"Oh, true, sorry, I commented before finishing reading 😸 all good then, I will implement URL","author_login":"yolile","author_association":"MEMBER","created_at":"2022-11-24T18:40:19+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274111941","fragment_type":"issue_comment","sequence":11,"text":"Should we implement: \n\n URL \n\ninstead of still using Pelican's metadata? Or should we mark this as blocked until #291 is done?","author_login":"yolile","author_association":"MEMBER","created_at":"2024-08-07T18:42:03+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2274964347","fragment_type":"issue_comment","sequence":12,"text":"We can do this without doing #291. Doing this is very easy. Doing #291 is much more work.","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-08-08T05:10:37+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2461294887","fragment_type":"issue_comment","sequence":13,"text":"Code is done now. I just added a new field, because this was the last thing that Kingfisher Process extracted.\n\nThe Publication (Collection) also has a publication policy field now. If empty, it will be populated by the job's publication policy from Kingfisher Process. Otherwise, we can provide a manual value that will never be overridden.\n\nAssigning to @yolile to populate whenever (if desired, we could do `scrapy pluck --package-pointer /publicationPolicy` to see which jobs will get a value next time they run).","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-11-07T04:28:49+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2463010070","fragment_type":"issue_comment","sequence":14,"text":"I've updated some, but I think it would be easier to wait for the auto-update and then change or add the missings","author_login":"yolile","author_association":"MEMBER","created_at":"2024-11-07T19:05:27+08:00","repo_name":"open-contracting/data-registry","issue_id":1095525512,"issue_number":192,"issue_url":"https://github.com/open-contracting/data-registry/issues/192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1424359903","fragment_type":"issue_description","sequence":0,"text":"Make from/to date range overridable in admin\ne.g. France has a \"5021\" typo in its data, and another source (or maybe France again) has a minimum year of \"21\": URL \n\nAlso, some publications don't set the date correctly (they set it to the current/retrieval date), so we will need to override those as well (I think Argentina Vialidad).\n\nI think this field is currently a property of the job (which makes sense). For the override, we would put it on the publication itself (and we'll need to remember to change the end date periodically).","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2022-10-26T16:41:59+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2082900318","fragment_type":"issue_comment","sequence":1,"text":"We can also add an admin filter to check for future \"to\" dates (and/or early \"from\" dates).","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-04-29T14:27:55+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2106322262","fragment_type":"issue_comment","sequence":2,"text":"I fixed the impossible dates by limiting Kingfisher Process's metadata endpoint to > Unix epoch and <= today.\n \n\nThis issue could remain open for this reason, but ...\n \n\nThat's too much overhead. So, we can just make a note in the quality issues.\n\nFWIW, Vialidad seems to not have the issue anymore: URL","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-05-12T17:33:47+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107574409","fragment_type":"issue_comment","sequence":3,"text":"Hmm well, they are not setting it to the current date but the dates are still incorrect.","author_login":"yolile","author_association":"MEMBER","created_at":"2024-05-13T13:25:04+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107607006","fragment_type":"issue_comment","sequence":4,"text":"Does anyone else have known incorrect dates (between 1970 and today)?","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-05-13T13:38:54+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107644508","fragment_type":"issue_comment","sequence":5,"text":"With the updated query in Kingfisher Process their dates will be in a reasonable range (see above commit). Will they have incorrect dates even within that range?","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-05-13T13:55:08+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107689467","fragment_type":"issue_comment","sequence":6,"text":"I think your fix will work (the files will still be segmented by all the available years though, right?)","author_login":"yolile","author_association":"MEMBER","created_at":"2024-05-13T14:14:18+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107732611","fragment_type":"issue_comment","sequence":7,"text":"Yeah, the exporter worker reads directly from Kingfisher Process without applying similar conditions/filters.","author_login":"jpmckinney","author_association":"MEMBER","created_at":"2024-05-13T14:24:16+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2107763722","fragment_type":"issue_comment","sequence":8,"text":"It also happens in Paraguay Hacienda URL but they are not updating their data anymore anyway so I think we can leave the issue closed","author_login":"yolile","author_association":"MEMBER","created_at":"2024-05-13T14:31:33+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3245382101","fragment_type":"issue_comment","sequence":9,"text":"Note that the original discussion in this issue was about overriding the from/to date for existing jobs. However, for unretrieved publications, we don't have a job at all, and want to also set the other overview fields: ocid prefix and license, so for implementing this, we should:","author_login":"yolile","author_association":"MEMBER","created_at":"2025-09-02T13:35:48+08:00","repo_name":"open-contracting/data-registry","issue_id":1424359903,"issue_number":256,"issue_url":"https://github.com/open-contracting/data-registry/issues/256","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0346","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Sentry integration is not working with Strapi 4?","query_context":"## Bug report\n\n### Describe the bug\nStrapi is not reporting any errors to the sentry. tried triggering errors by sending invalid graphql request and Rest API call in both cases it's not reporting errors to sentry.\n\nA clear and concise description of what the bug is.\n\n### Steps to reproduce the behavior\n\n1. Enable graphql plugin\n2. Install latest sentry plugin (one compatible with sentry 4)\n3. Configure sentry plugin in config/plugin.js as shown in step below \n\njavascript\n// path: ./config/plugins.js\n\nmodule.exports = {\n //\n graphql: {\n config: {\n endpoint: \"/graphql\",\n shadowCRUD: true,\n playgroundAlways: true,\n depthLimit: 7,\n amountLimit: 100,\n apolloServer: {\n tracing: false,\n },\n },\n },\n sentry: {\n enabled: true,\n config: {\n dsn: \" URL \n sendMetadata: true,\n },\n },\n};\n\n5. Create A collection\n6. Add Data\n7. Call graphql API / Rest API with invalid parameters \n8. It will return error response \n9. Error wont be logged in sentry\n\n### Expected behavior\n\nThe error should be reported to the sentry and should be visible in the sentry dashboard.\n\n### Screenshots\n\nIf applicable, add screenshots to help explain your problem.\n\n### Code snippets\n\nIf applicable, add code samples to help explain your problem.\n\n### System\n\n- Node.js version: v16.13.1\n- NPM version: 8.1.2\n- Strapi version: 4.0.3\n- Database: postgres / sqlite\n- Operating system: mac / linux\n\n### Additional context\n\nAdd any other context about the problem here.","known_context_document_ids":["gh_issue_1155351818"],"reference_answer":"@VictorienTardif I don't know if your issue is already resolved. The Strapi folks fixed this in their `4.11.1` version - please update to at least that version (as you're still on `4.2.3`). Additionally, make sure that all your sentry deps are on the same version. (check in lockfile)","answer_document_id":"gh_comment_1200871170","silver_evidence_path":["gh_comment_1104809563","gh_issue_1209366926","gh_comment_1200871170"],"evidence_issue_ids":[1155351818,1209366926],"source_repo_name":"strapi/strapi","source_issue_id":1155351818,"source_issue_number":12702,"source_issue_url":"https://github.com/strapi/strapi/issues/12702","target_repo_name":"getsentry/sentry-javascript","target_issue_id":1209366926,"target_issue_number":4956,"target_issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","reference_anchor_document_id":"gh_comment_1104809563","reference_answer_author":"lforst","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2667,"anchor_target_overlap":0.4,"target_answer_overlap":0.125},"issue_created_at":"2022-03-01T13:38:00+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1155351818","fragment_type":"issue_description","sequence":0,"text":"Sentry integration is not working with Strapi 4\n## Bug report\n\n### Describe the bug\nStrapi is not reporting any errors to the sentry. tried triggering errors by sending invalid graphql request and Rest API call in both cases it's not reporting errors to sentry.\n\nA clear and concise description of what the bug is.\n\n### Steps to reproduce the behavior\n\n1. Enable graphql plugin\n2. Install latest sentry plugin (one compatible with sentry 4)\n3. Configure sentry plugin in config/plugin.js as shown in step below \n\njavascript\n// path: ./config/plugins.js\n\nmodule.exports = {\n //\n graphql: {\n config: {\n endpoint: \"/graphql\",\n shadowCRUD: true,\n playgroundAlways: true,\n depthLimit: 7,\n amountLimit: 100,\n apolloServer: {\n tracing: false,\n },\n },\n },\n sentry: {\n enabled: true,\n config: {\n dsn: \" URL \n sendMetadata: true,\n },\n },\n};\n\n5. Create A collection\n6. Add Data\n7. Call graphql API / Rest API with invalid parameters \n8. It will return error response \n9. Error wont be logged in sentry\n\n### Expected behavior\n\nThe error should be reported to the sentry and should be visible in the sentry dashboard.\n\n### Screenshots\n\nIf applicable, add screenshots to help explain your problem.\n\n### Code snippets\n\nIf applicable, add code samples to help explain your problem.\n\n### System\n\n- Node.js version: v16.13.1\n- NPM version: 8.1.2\n- Strapi version: 4.0.3\n- Database: postgres / sqlite\n- Operating system: mac / linux\n\n### Additional context\n\nAdd any other context about the problem here.","author_login":"shyamlohar","author_association":"NONE","created_at":"2022-03-01T13:38:00+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1057939849","fragment_type":"issue_comment","sequence":1,"text":"Please share your package.json just so we can have a look at what version of the sentry plugin you have installed. (Also please consider updating your strapi version and it's dependencies to the latest version)","author_login":"kasonde","author_association":"CONTRIBUTOR","created_at":"2022-03-03T11:15:39+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1062005471","fragment_type":"issue_comment","sequence":2,"text":"Hey this is what my package.json looks like sorry for delayed reply \n\n{\n \"name\": \"strapi-production\",\n \"private\": true,\n \"version\": \"0.1.0\",\n \"description\": \"A Strapi application\",\n \"scripts\": {\n \"develop\": \"strapi develop\",\n \"start\": \"strapi start\",\n \"build\": \"strapi build\",\n \"strapi\": \"strapi\"\n },\n \"dependencies\": {\n \"@strapi/plugin-graphql\": \"^4.0.3\",\n \"@strapi/plugin-i18n\": \"4.0.3\",\n \"@strapi/plugin-sentry\": \"^4.1.1\",\n \"@strapi/plugin-users-permissions\": \"4.0.3\",\n \"@strapi/strapi\": \"4.0.3\",\n \"pg\": \"^8.7.1\",\n \"sqlite3\": \"5.0.2\",\n \"strapi-middleware-cache\": \"^2.1.7\"\n },\n \"author\": {\n \"name\": \"A Strapi developer\"\n },\n \"strapi\": {\n \"uuid\": \"d131dec1-ef29-4211-987e-003549bb28cc\"\n },\n \"engines\": {\n \"node\": \">=12.x.x =6.0.0\"\n },\n \"license\": \"MIT\"\n}","author_login":"shyamlohar","author_association":"NONE","created_at":"2022-03-08T17:08:07+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081220227","fragment_type":"issue_comment","sequence":3,"text":"You have a bunch of miss-matched strapi packages and I know for a fact that `strapi-middleware-cache` doesn't work on the v4 as there is a new replacement package for it.","author_login":"derrickmehaffy","author_association":"MEMBER","created_at":"2022-03-28T22:35:36+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100807984","fragment_type":"issue_comment","sequence":4,"text":"@derrickmehaffy We are not using `strapi-middleware-cache` will be removing that from dependencies. did you mean I should have same versions for `@strapi/plugin-graphql` ,`@strapi/plugin-i18n` ,`@strapi/plugin-sentry` and `@strapi/strapi`","author_login":"shyamlohar","author_association":"NONE","created_at":"2022-04-17T05:32:09+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101518709","fragment_type":"issue_comment","sequence":5,"text":"Yes all packages prefixed with `@strapi/` should have the same version.","author_login":"derrickmehaffy","author_association":"MEMBER","created_at":"2022-04-18T15:55:21+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1101756675","fragment_type":"issue_comment","sequence":6,"text":"@strapi/developer-experience / @strapi/expansion I'm not sure the root cause on this and it could be either package so I've set it to both of your projects for now.","author_login":"derrickmehaffy","author_association":"MEMBER","created_at":"2022-04-18T20:51:14+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1104809563","fragment_type":"issue_comment","sequence":7,"text":"Folks, does it have to do anything with URL \n\nStrapi v4 by default adds sentry 6.3.0 to yarn lock file which has some bugs. Can we update sentry version to 6.3.2 as mentioned URL","author_login":"SujayPrabhu96","author_association":"NONE","created_at":"2022-04-21T07:22:37+08:00","repo_name":"strapi/strapi","issue_id":1155351818,"issue_number":12702,"issue_url":"https://github.com/strapi/strapi/issues/12702","linked_issue_ids":[1209366926],"is_known_query_context":false},{"document_id":"gh_issue_1209366926","fragment_type":"issue_description","sequence":0,"text":"self._mergeOptions is not a function with Strapi v4\n### Environment\n\nself-hosted ( URL \n\n### Version\n- Strapi - 4.1.7\n- @sentry/node - 6.19.6\n- @sentry/tracing - 6.19.6\n\n_No response_\n\n### Steps to Reproduce\n\nInstrument Strapi v4 application with Sentry integration. Followed Performance monitoring setup with Koa from the doc\n\n### Expected Result\n\nLog Strapi erros on Sentry\n\n### Actual Result\n\nNot able to track errors on Sentry instead logs `self._mergeOptions is not a function`\n\n<img width=\"438\" alt=\"Screenshot 2022-04-18 at 8 48 29 PM\" src=\" URL","author_login":"SujayPrabhu96","author_association":"NONE","created_at":"2022-04-18T15:18:49+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1103634921","fragment_type":"issue_comment","sequence":1,"text":"Hi @SujayPrabhu96, thanks for writing in! To effectively investigate your issue we would need a little bit more information. Can you share which versions of Koa, Strapi, and the sentry SDK you are using and how exactly you set up the Sentry SDK (ie, how you configured the `Sentry.init()` call)?","author_login":"lforst","author_association":"MEMBER","created_at":"2022-04-20T08:45:41+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1103666772","fragment_type":"issue_comment","sequence":2,"text":"Hi @lforst,\nI have updated the versions in the issue. As Strapi is built on top of Koa, it is not installed separately.\nRegarding setup I have created custom middleware `sentry` in Strapi to make `Sentry.init()` call.\n\nFor reference here is my PR: URL \nConfigured Sentry using sentry middleware","author_login":"SujayPrabhu96","author_association":"NONE","created_at":"2022-04-20T09:07:52+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1103679589","fragment_type":"issue_comment","sequence":3,"text":"I'm seeing in the repository you linked that you have old Sentry dependencies in your lockfile: example\n\nThe particular version you have, has a bug that was reported in URL and got fixed in URL \n\nCan you try and update those dependencies to at least version 6.3.2 and report back whether that fixed the issue? By the way, I strongly recommend using the same versions across all Sentry SDK dependencies, as having different versions might introduce unknown behaviour.","author_login":"lforst","author_association":"MEMBER","created_at":"2022-04-20T09:16:45+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1129171699","fragment_type":"issue_comment","sequence":4,"text":"Strapi version 4.11.1 upgraded to latest Sentry version. This fixed the issue. So, closing this","author_login":"SujayPrabhu96","author_association":"NONE","created_at":"2022-05-17T18:12:17+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194086529","fragment_type":"issue_comment","sequence":5,"text":"I'm still having the issue with Strapi 4.2.3 and Sentry 6.19.6 for all Sentry packages :/ \n\nAre you sure it is fixed?\nIs it a regression @lforst?\n\nThx","author_login":"VictorienTardif","author_association":"NONE","created_at":"2022-07-25T13:59:43+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194091463","fragment_type":"issue_comment","sequence":6,"text":"@VictorienTardif could you run `yarn why @sentry/core` and `yarn why @sentry/hub` and reply with the output (`npm ls` will work like `yarn why` if you're using that)","author_login":"AbhiPrasad","author_association":"MEMBER","created_at":"2022-07-25T14:03:38+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194095085","fragment_type":"issue_comment","sequence":7,"text":"Hello @AbhiPrasad, here it is:\n\nyarn why @sentry/core\nyarn why v1.22.17\n[1/4] 🤔 Why do we have the module \"@sentry/core\"...?\n[2/4] 🚚 Initialising dependency graph...\n[3/4] 🔍 Finding dependency...\n[4/4] 🚡 Calculating file sizes...\n=> Found \"@sentry/core@6.19.6\"\ninfo Reasons this module exists\n - \"_project_#@strapi#plugin-sentry#@sentry#node\" depends on it\n - Hoisted from \"_project_#@strapi#plugin-sentry#@sentry#node#@sentry#core\"\ninfo Disk size without dependencies: \"932KB\"\ninfo Disk size with unique dependencies: \"5.09MB\"\ninfo Disk size with transitive dependencies: \"5.09MB\"\ninfo Number of shared dependencies: 5\n✨ Done in 0.51s.\n\nyarn why @sentry/hub\nyarn why v1.22.17\n[1/4] 🤔 Why do we have the module \"@sentry/hub\"...?\n[2/4] 🚚 Initialising dependency graph...\n[3/4] 🔍 Finding dependency...\n[4/4] 🚡 Calculating file sizes...\n=> Found \"@sentry/hub@6.19.6\"\ninfo Reasons this module exists\n - \"_project_#@strapi#plugin-sentry#@sentry#node\" depends on it\n - Hoisted from \"_project_#@strapi#plugin-sentry#@sentry#node#@sentry#hub\"\n - Hoisted from \"_project_#@strapi#plugin-sentry#@sentry#node#@sentry#core#@sentry#hub\"\n - Hoisted from \"_project_#@strapi#plugin-sentry#@sentry#node#@sentry#core#@sentry#minimal#@sentry#hub\"\ninfo Disk size without dependencies: \"564KB\"\ninfo Disk size with unique dependencies: \"3.99MB\"\ninfo Disk size with transitive dependencies: \"3.99MB\"\ninfo Number of shared dependencies: 3\n✨ Done in 0.32s.","author_login":"VictorienTardif","author_association":"NONE","created_at":"2022-07-25T14:06:23+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194110525","fragment_type":"issue_comment","sequence":8,"text":"@VictorienTardif, could you try upgrading to v7? This may fix the error as per: URL","author_login":"AbhiPrasad","author_association":"MEMBER","created_at":"2022-07-25T14:18:01+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1195221538","fragment_type":"issue_comment","sequence":9,"text":"Hi, I found out that it was a problem with Strapi docker image that installs Strapi globally.\nThere must be a mismatch with Sentry versions or something. \nInstalling everything locally and running outside of docker it's working fine.\n\nThx for your help.","author_login":"VictorienTardif","author_association":"NONE","created_at":"2022-07-26T09:10:34+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1195374871","fragment_type":"issue_comment","sequence":10,"text":"@VictorienTardif, if this is not the case already, I would encourage you to use the official Strapi integration for Sentry. They are not always on the newest version of Sentry, but they do make sure that Sentry works properly.","author_login":"vladanpaunovic","author_association":"CONTRIBUTOR","created_at":"2022-07-26T11:43:22+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1200871170","fragment_type":"issue_comment","sequence":11,"text":"@VictorienTardif I don't know if your issue is already resolved. The Strapi folks fixed this in their `4.11.1` version - please update to at least that version (as you're still on `4.2.3`). Additionally, make sure that all your sentry deps are on the same version. (check in lockfile)","author_login":"lforst","author_association":"MEMBER","created_at":"2022-08-01T08:15:44+08:00","repo_name":"getsentry/sentry-javascript","issue_id":1209366926,"issue_number":4956,"issue_url":"https://github.com/getsentry/sentry-javascript/issues/4956","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0348","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"ReferenceError: \"AlternateLinks is not defined\" upon new SvelteKit install?","query_context":"ReferenceError: AlternateLinks is not defined\n at eval (/Users/.../node_modules/.pnpm/@inlang+paraglide-sveltekit@0.11.0_@sveltejs+kit@2.5.28_@sveltejs+vite-plugin-svelte@3.1.2_sv_bhgsp6l6qijmxfcyqggxzwsu2m/node_modules/@inlang/paraglide-sveltekit/dist/runtime/ParaglideJS.svelte:108:48)","known_context_document_ids":["gh_issue_2534517537"],"reference_answer":"@ambios1 you have to create them yourself. you can use this pattern and adapt it for alternate links URL or create a sitemap with URL a PR that would introduce a `generateAlternateLinks(\"/path\")` would also be appreciated","answer_document_id":"gh_comment_2741672469","silver_evidence_path":["gh_comment_2673425106","gh_issue_2501881174","gh_comment_2741672469"],"evidence_issue_ids":[2534517537,2501881174],"source_repo_name":"opral/inlang-paraglide-js","source_issue_id":2534517537,"source_issue_number":223,"source_issue_url":"https://github.com/opral/inlang-paraglide-js/issues/223","target_repo_name":"opral/inlang-paraglide-js","target_issue_id":2501881174,"target_issue_number":201,"target_issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","reference_anchor_document_id":"gh_comment_2673425106","reference_answer_author":"samuelstroschein","reference_answer_author_association":"MEMBER","quality_score":94.12,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0909,"anchor_target_overlap":0.2727,"target_answer_overlap":0.0769},"issue_created_at":"2024-09-18T19:26:26+08:00","valid_comment_count":57,"fragments":[{"document_id":"gh_issue_2534517537","fragment_type":"issue_description","sequence":0,"text":"ReferenceError: \"AlternateLinks is not defined\" upon new SvelteKit install\nReferenceError: AlternateLinks is not defined\n at eval (/Users/.../node_modules/.pnpm/@inlang+paraglide-sveltekit@0.11.0_@sveltejs+kit@2.5.28_@sveltejs+vite-plugin-svelte@3.1.2_sv_bhgsp6l6qijmxfcyqggxzwsu2m/node_modules/@inlang/paraglide-sveltekit/dist/runtime/ParaglideJS.svelte:108:48)","author_login":"yadoga","author_association":"NONE","created_at":"2024-09-18T19:26:26+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2534517537,"issue_number":223,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/223","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2501540628","fragment_type":"issue_comment","sequence":1,"text":"I stumbled into this error too, after adding svelte-preprocess to a newly initialized site.","author_login":"bhark","author_association":"NONE","created_at":"2024-11-26T17:28:26+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2534517537,"issue_number":223,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/223","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673425106","fragment_type":"issue_comment","sequence":2,"text":"Error can't appear in Paraglide JS 2.0 anymore. The SvelteKit adapter is not used anymore URL Re-open if the issue persist in v2","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-21T04:43:59+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2534517537,"issue_number":223,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/223","linked_issue_ids":[2501881174],"is_known_query_context":false},{"document_id":"gh_issue_2501881174","fragment_type":"issue_description","sequence":0,"text":"Project: Paraglide JS 2.0 (variants, pluralization, gendering)\n### Context\n\nThis issue serves as \"subscribe here to stay up to date with paraglide js 2.0\".\n\n### Changelog\n\n- [X] supports for variants\n- [X] builds on the inlang SDK v2 which uses sqlite\n- URL \n\n### Tasks/issues\n\nSee issues with the \"v2.0\" label","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-09-03T04:11:41+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2334244878","fragment_type":"issue_comment","sequence":1,"text":"@juliomuhlbauer added to the project that comes after paraglide js 2.0 (metaframework overhaul) URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-09-06T14:56:52+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2349863137","fragment_type":"issue_comment","sequence":2,"text":"Progress is halted until the message format plugin, which most paraglide users use, is updated to v3 URL While updating the message format to v3, the data model showed inconsistencies, see URL \n\nNumber 1 prio is to resolve the data model problems. Work on paralglide 2.0 will continue afterward","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-09-13T18:43:42+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2359602398","fragment_type":"issue_comment","sequence":3,"text":"From discord URL \n\n**End to end import, CRUD, export achieved**\n\nMilestone achieved. We are now entering the phase of taking the observations from an end to end workflow to fix bugs and do adjustemnts where useful/required\n\nUploading CleanShot 2024-09-18 at 19.00.29.mp4…","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-09-18T23:07:01+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2377174670","fragment_type":"issue_comment","sequence":4,"text":"Work on paraglide 2.0 continues. Might have a pre-release by the end of the day!\n\n* the inlang sdk v2 is stable\n* the message format plugin supports variants (!)","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-09-26T14:42:38+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378209633","fragment_type":"issue_comment","sequence":5,"text":"Logical tests are passing. TypeSafety is still a todo. Hence, no pre-release today and no prerelease until mid October. The team is meeting in Rome for an onsite next week which I a) have to attend and b) I have to prep :)","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-09-27T01:06:20+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2405499586","fragment_type":"issue_comment","sequence":6,"text":"Update: \n\nThe tests are passing now, but a release of Paraglide JS 2.0 is postponed until we have lix 1.0, which powers Paraglide JS. That's likely in January or February.\n\n- PRs for fixed or improvements will be reviewed and accepted \n- Read more here URL \n\n URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2024-10-10T15:56:41+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2442562436","fragment_type":"issue_comment","sequence":7,"text":"it would be nice to also implement something like that in v2","author_login":"nosovk","author_association":"NONE","created_at":"2024-10-28T20:30:40+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2569699282","fragment_type":"issue_comment","sequence":8,"text":"What's this? 👀 _Hint: Work continues. Paraglide JS 2.0 beta this January_ \n\nCleanShot 2025-01-03 at 14 11 15@2x","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-03T19:15:52+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2581248877","fragment_type":"issue_comment","sequence":9,"text":"## Paraglide JS 2.0 Beta has been released\n\n- variant (plural, gendering, a/b test) support 🥳 \n- test the beta and report issues\n- targeting general availability by the end of January \n\nHere are examples to get started URL \n\n URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-09T21:07:47+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2583012803","fragment_type":"issue_comment","sequence":10,"text":"I'm very glad that you added a generic form of pluralization using Intl.PluralRules. Reading the examples and documentation, I have some feedback. Sorry if this turns out already covered by your overview video, I can't watch it because of network error. I notice the plurals need a lot of boilerplate:\n\n{\n\"some_happy_cat\": {\n \"declarations\": [\"input count\", \"local countPlural = count: plural\"],\n \"selectors\": [\"countPlural\"],\n \"match\": {\n \"countPlural=one\": \"There is one cat.\",\n \"countPlural=other\": \"There are many cats.\",\n },\n }\n}\n\nWith a note:\n\nRead the `local countPlural = count: plural` syntax as \"create a local variable `countPlural` that equals `plural(count)`\". \n\nIs there a plan to make Paraglide infer the most typical case of declarations and selectors (the one documented) from a shorthand:\n\n{\n\"some_happy_cat\": {\n \"match\": {\n \"plural(count)=one\": \"{count} кіт\", // -1 кіт, 21 кіт, 31 кіт...\n \"plural(count)=few\": \"{count} коти\", // 2 коти, 22 коти...\n \"plural(count)=many\": \"{count} котів\", // 0 котів, 5 котів, 11 котів, 25 котів...\n \"plural(count)=other\": \"{count} кота\", // 3,5 кота...\n },\n }\n}\n\nOtherwise I seem to need a lot of copy-pasting and the translation file will grow vertically way too fast.","author_login":"nykula","author_association":"NONE","created_at":"2025-01-10T15:48:42+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2583190514","fragment_type":"issue_comment","sequence":11,"text":"@nykula Yes, most inputs are inferred. \n\nThe inlang message format plugin is responsible for the syntax. Any other syntax can be used as well (icu1, i18next, etc.). That said, expressing messages with variants is complex. So complex that we are optimizing for tooling rather than handwriting and managing JSON files.","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-10T16:32:40+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2589950896","fragment_type":"issue_comment","sequence":12,"text":"@gooonzick Yes. I will put updating these docs URL on my todo list today","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-14T13:45:43+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2596202820","fragment_type":"issue_comment","sequence":13,"text":"Question about the API. Should Paraglide JS 2.0 \n\n1‍⃣ prefix `locale` suff with \"Available\" \n\nts\nimport { availableLocales, type AvailableLocale, assertAvailableLocale } from \"./paraglide/runtime.js\"\n\nconst locale: AvailableLocale = \"en\"\n\nif (availableLocales.includes(\"de\")){\n //\n}\n\nconst x = assertAvailableLocale(\"fr\")\n\n2‍⃣ or drop the `available` prefix\n\nts\nimport { locales, type Locale, assertLocale } from \"./paraglide/runtime.js\"\n\nconst locale: Locale = \"en\"\n\nif (locales.includes(\"de\")){\n //\n}\n\nconst x = assertLocale(\"fr\")\n\nVote with 1‍⃣ for `available` prefix or 2‍⃣ for no prefix","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-16T16:39:40+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2599406749","fragment_type":"issue_comment","sequence":14,"text":"## Progress update\n\n**Jan 12 - Jan 17**\n\n✅ paraglide js 2.0 beta \n\n✅ astro adapter beta\n\n❌ sveltekit adapter beta\n\n✅ metaframework adapter overhaul approach \n\n**Focus in Jan 20 - Jan 24**\n\n- sveltekit adapter beta\n- metaframework adapter overhaul implementation \n\n**Targets for end of january** \n\n- [on track] GA paraglide js 2.0\n- [on track] GA adapters\n- [on track] GA metaframework overhaul\n\n URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-18T00:20:53+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613623635","fragment_type":"issue_comment","sequence":15,"text":"**The adapters have been released as beta. Try them out and give feedback.** \n\n- SvelteKit URL \n- NextJS URL (look into the next.config.js && src/app/layout.tsx) \n- Astro URL \n\n**Target for next week**\n\n- [ ] configurable strategy (i18n routing, cookies, domain based, something else)\n- [ ] per locale splitting URL \n- [ ] URL \n\nIf everything goes well, have the release candidate for paraglide js 2.0 by next Friday 🔥","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-24T23:59:19+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613686955","fragment_type":"issue_comment","sequence":16,"text":"This is an error I am encountering when running `npx next dev` in my Next.js project\n\nnode:internal/modules/esm/resolve:303\n return new ERR_PACKAGE_PATH_NOT_EXPORTED(\n ^\n\nError [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './plugin' is not defined by \"exports\" in C:\\dev\\project\\node_modules\\@inlang\\paraglide-next\\package.json imported from C:\\dev\\project\\next.config.js\n at exportsNotFound (node:internal/modules/esm/resolve:303:10)\n at packageExportsResolve (node:internal/modules/esm/resolve:650:9)\n at packageResolve (node:internal/modules/esm/resolve:828:14)\n at moduleResolve (node:internal/modules/esm/resolve:918:18)\n at defaultResolve (node:internal/modules/esm/resolve:1148:11)\n at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:528:12)\n at ModuleLoader.resolve (node:internal/modules/esm/loader:497:25)\n at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:231:38)\n at ModuleWrap. (node:internal/modules/esm/module_job:97:39)\n at link (node:internal/modules/esm/module_job:96:36) {\n code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'\n}\n\nUsing `\"@inlang/paraglide-js\": \"2.0.0-beta.13\"` and `\"@inlang/paraglide-next\": \"1.0.0-beta.2\"`. `1.0.0-beta.1` has the same problem, but `0.7.9` works fine","author_login":"revosw","author_association":"NONE","created_at":"2025-01-25T01:00:38+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614020243","fragment_type":"issue_comment","sequence":17,"text":"Can you try renaming your next config to .mjs? I encountered several esm related issues with nextjs that went away after renaming the config to mjs","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-25T16:25:10+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614121220","fragment_type":"issue_comment","sequence":18,"text":"It should but on my machine a `next.config.ts` led to module resolution errors. \n\nIf you get a `.ts` config to work, make a PR as long as Paraglide JS does not need to be compiled to CJS. Introducing CJS is too much overhead. With the new node feature to import ESM from CJS, the problem might resolve itself.","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-25T22:35:37+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614476496","fragment_type":"issue_comment","sequence":19,"text":"Oh right, I have probably forgotten to read release notes or similar. In my next config I had this:\n\nts\nimport { paraglide } from \"@inlang/paraglide-next/plugin\";\n// ^ note the ./plugin import, hence the error mentioning \"./plugin\"\n\nexport default paraglide({\n paraglide: {\n project: \"./project.inlang\",\n outdir: \"./paraglide\",\n },\n // ...other settings\n})\n\nBut now I need to change it to\n\nimport { withParaglideNext } from \"@inlang/paraglide-next\";\n// ^ removed /plugin, imported the new function\n\nexport default withParaglideNext({\n paraglide: {\n project: \"./project.inlang\",\n outdir: \"./paraglide\",\n },\n // ...other settings\n})\n\nI was also amused to see that there were no other exports from the next adapter package, and seemingly no replacement of ` `, `useRouter`, `middleware` and other stuff inside paraglide-js.\n\nDespite that, it works flawlessly now!!","author_login":"revosw","author_association":"NONE","created_at":"2025-01-26T15:47:51+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2614781898","fragment_type":"issue_comment","sequence":20,"text":"Acctually, it seems like the default output has changed to `./src/paraglide`, while in my project I used the `./paraglide` path for my output. There is an `--output` option you can run, for example `npx paraglide-js --project my-project.inlang --output ./paraglide`, but I don't see a way to configure the output in the `my-project.inlang/settings.json` file. This means I'll have to run the compiler manually, which is unfortunate","author_login":"revosw","author_association":"NONE","created_at":"2025-01-27T03:22:59+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2618683990","fragment_type":"issue_comment","sequence":21,"text":"I am trying to upgrade to Paraglide V2 with the nextjs adapter but I am currently getting this issue in my middleware.ts file:\n\n[{\n \"resource\": \"/Users/User/code/next-project/middleware.ts\",\n \"owner\": \"typescript\",\n \"code\": \"2307\",\n \"severity\": 8,\n \"message\": \"Cannot find module './paraglide/adapter' or its corresponding type declarations.\",\n \"source\": \"ts\",\n \"startLineNumber\": 2,\n \"startColumn\": 28,\n \"endLineNumber\": 2,\n \"endColumn\": 49,\n \"modelVersionId\": 106\n}]\n\nI am using the same next config and middleware from this example URL \n\n \"scripts\": {\n \"dev\": \"next dev --turbopack\",\n \"build\": \"paraglide-js compile --project ./project.inlang --outdir ./paraglide && next build\",\n \"start\": \"next start\",\n \"lint\": \"next lint\",\n \"postinstall\": \"paraglide-js compile --project ./project.inlang --outdir ./paraglide\",\n \"drizzle\": \"npx drizzle-kit studio --config drizzle.config.ts\"\n },\n\n \"devDependencies\": {\n \"@inlang/paraglide-js\": \"^2.0.0-beta.13\",\n \"@inlang/paraglide-next\": \"^1.0.0-beta.2\",\n\nAny help would be greatly appreciated. Thanks!","author_login":"rorybush","author_association":"NONE","created_at":"2025-01-28T11:06:30+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2624389417","fragment_type":"issue_comment","sequence":22,"text":"Hi.\nI just wanted to mention that I am getting an Error while running npm install when using the:\n \"@inlang/paraglide-js\": \"2.0.0-beta.14\",\n \"@inlang/paraglide-sveltekit\": \"1.0.0-beta.4\",\n\nThe Error:\nnpm error Could not resolve dependency:\nnpm error peer @inlang/paraglide-js@\"^2\" from @inlang/paraglide-sveltekit@1.0.0-beta.4\n\nImage","author_login":"ambigos1","author_association":"NONE","created_at":"2025-01-30T12:35:16+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2624941645","fragment_type":"issue_comment","sequence":23,"text":"Arghhhhh why are beta releases so broken on NPM? Will fix this today","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-30T16:15:58+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2625951708","fragment_type":"issue_comment","sequence":24,"text":"New batch of beta's released: \n\n- paraglide js 2.0.0-beta.16\n- paraglide next 1.0.0-beta.6\n- paraglide astro 1.0.0-beta.4\n- paraglide sveltekit 1.0.0-beta.5\n\nThe new beta's have the #346 API: \n\ndiff\nstrategy: [\"pathname\", \"cookie\", \"baseLocale\"]\n\nPlease try it out and give feedback. If you encounter issues, please open separate issues to keep this thread clean with updates on the beta. \n\n**Next steps**\n\n- try top level await approach in #88\n- prepare release candidate (docs)","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-01-30T23:44:31+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2629134167","fragment_type":"issue_comment","sequence":25,"text":"In the paraglide sveltekit beta, it seems that the logic to replace `%lang%` with the current language in the `app.html` template is gone.\n\nThis logic : URL","author_login":"mquandalle","author_association":"NONE","created_at":"2025-02-01T22:03:35+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2629536113","fragment_type":"issue_comment","sequence":26,"text":"Also I can't find the way to translate pathnames in the paraglide sveltekit beta?","author_login":"mquandalle","author_association":"NONE","created_at":"2025-02-02T20:06:35+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2634083117","fragment_type":"issue_comment","sequence":27,"text":"**Progress on customizable localized pathnames #359 **\n \n URL \n\nAPI will enable you to match any localized route of your choice. The example below prefixes every path with the locales, even for en. The syntax is uses the web standard URLPattern URL \n\nts\npathnames: {\n \"/:path*\": {\n en: \"/en/:path\",\n de: \"/de/:path\",\n },\n},\n\nThis pattern will not prefix the locale for en \n\nts\npathnames: {\n \"/:path*\": {\n en: \"/:path\",\n de: \"/de/:path\",\n },\n},\n\nOr go fully custom \n\nts\npathnames: {\n \"/blog/:id\": {\n en: \"/english/blog/:id\",\n de: \"/deutsch/artikel/:id\",\n },\n},","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-04T14:10:08+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2635671170","fragment_type":"issue_comment","sequence":28,"text":"Gonna go with a bundled version of path-to-regex for #359. \n\nI won't work tomorrow and Thursday on Paraglide 2.0 as I am attending a conference. A release candidate at the end of the week is thereby unlikely but a new beta with the pathname API on Friday is likely. \n\n URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-05T04:22:49+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2655440950","fragment_type":"issue_comment","sequence":29,"text":"### URL based localization (pathname, domain based, multi-tenancy) likely nailed!\n\nI spent over 1 week on coming up with this API, and I think it nails any URL-based use case. Will make a decision tomorrow on whether to use URLPattern or path-to-regexp v8, which depends on URL \n\n- one API to rule any url based needs \n- not >10 flags are different APIs that interfere in behavior (!) \n\n**Next steps**\n\n- [ ] determine if path-to-regexp v8 can work with a `baseLocale` setting per pattern to combat ambiguous matches\n- [ ] else, try adoption of URLPattern\n\n URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-13T04:20:02+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2661932425","fragment_type":"issue_comment","sequence":30,"text":"#378 is shipped 🛥. This was the last big development effort that was needed. \n\nNext up are simple bugfixes or features and write documentation. GA release by the end of February (2 weeks) is on track. \n\nImage","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-17T04:11:49+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2666252483","fragment_type":"issue_comment","sequence":31,"text":"coming in paraglide js 2.0: \n\nauto-import when writing `m`. \n\nno more manual `import * as m`\n\nImage","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-18T16:38:37+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2666477107","fragment_type":"issue_comment","sequence":32,"text":"That looks fantastic, I'm curious how this works, so far couldn't find anything on how to enable auto-import for `import * as X` 🤔","author_login":"CanRau","author_association":"NONE","created_at":"2025-02-18T17:57:00+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2672221595","fragment_type":"issue_comment","sequence":33,"text":"@zhihengGet you need to use the vite plugin of the adapter for the `adapter.js` file to exist. \n\nbut good news: adapters will likely be a thing of the past today. found another abstraction which makes adapters redundant. will report more later today :)","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-20T17:40:29+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673375348","fragment_type":"issue_comment","sequence":34,"text":"## Implemented `serverMiddleware()`, no more adapters needed\n\nI shipped #388 which exposes `serverMiddleware()` that works in any SSR framework. No more adapters. You read right. No more adapters. \n\n- introduced `serverMiddleware()`\n- added examples for frameworks, including SSG examples for applicable (closes #109) \n\ndiff\nimport type { Handle } from '@sveltejs/kit';\n+import { serverMiddleware } from '$lib/paraglide/runtime';\n\nexport const handle: Handle = ({ event, resolve }) => {\n return serverMiddleware(event.request, () => resolve(event));\n};\n\n URL \n\nReleased as beta.19!","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-21T04:21:55+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2673550495","fragment_type":"issue_comment","sequence":35,"text":"that is amazing !!! giving it a try now, \n\nhmm got compile error\n\nin compiled message , the generated export has extra ` at the end\n\ni18n/paraglide/messages/save/es.js\n\nts\n// eslint-disable\n\n/** @type {(inputs: {}) => string} */\nexport const Save = () => `Guardar`;`;\n\ni have this in my en.json\n\n` \"Save\": \"Save\",`","author_login":"zhihengGet","author_association":"NONE","created_at":"2025-02-21T06:03:04+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674043824","fragment_type":"issue_comment","sequence":36,"text":"The example of @zhihengGet seems to be a bit malformed but I can report a similar issue with the beta 18 I'm playing around with: keys are not clearly marked as case insensitive, which can inadvertently break paraglide exports. On top of that, if you happen to have such issues, you have to manually delete the affected `messages` subfolders to resolve the issue. Can you guys add a clearer warning, not generate these \"duplicate\" keys and also eventually clean up the `messages` folder with unused localizations?","author_login":"WarningImHack3r","author_association":"NONE","created_at":"2025-02-21T09:33:56+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2676739190","fragment_type":"issue_comment","sequence":37,"text":"Awesome redirect feature @samuelstroschein - can wait for v2 release","author_login":"harrytran998","author_association":"NONE","created_at":"2025-02-23T09:33:07+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2680006131","fragment_type":"issue_comment","sequence":38,"text":"## Nesting and arbitrary key names support implemented\n\nSurprise for v2. Long time awaited nesting of keys is now supported #285. \n\n{\n \"nested\": {\n \"key\": \"Nested key\"\n }\n}\n\nts\nimport { m } from \"./paraglide/messages.js\";\n\nconsole.log(m\"nested.key\");\n\nYou can even use emojis\n\nts\nimport { m } from \"./paraglide/messages.js\"\n\nm\"🍌\"","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-02-25T00:17:32+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2684621891","fragment_type":"issue_comment","sequence":39,"text":"Hi @samuelstroschein, it's great to see the progress with Paraglide v2 lately! I have questions about the api to translate routes:\n\njs\n{\n pattern: \":protocol://:domain(.*)::port?/:about/:path*\",\n deLocalizedNamedGroups: { \n about: \"about\" \n },\n localizedNamedGroups: {\n en: { \n about: \"about\" \n },\n fr: { \n about: \"a-propos\" \n },\n },\n},\n\n \nIs it required to provide a full url pattern with `:protocol://:domain(.*)::port?` even if I just want to specify that \"about\" is translated to \"a-propos\" in french?\nDoes it work with a route param like `/travel-[city]` that I want to translate to `/voyage-[city]`?\nAlso maybe I read the documentation too quickly but the `deLocalizedNamedGroups` / `localizedNamedGroups` logic isn't clear to me at the moment.","author_login":"mquandalle","author_association":"NONE","created_at":"2025-02-26T10:56:24+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2695821448","fragment_type":"issue_comment","sequence":40,"text":"**Paraglide JS GA release this or early next week**\n\nYou can adopt Paraglide JS 2.0 already. The latest beta releases are stable. \n\nThe remaining tasks are mostly adding feature for SSG and creating a benchmark suite to test an experimental per locale splitting URL Among the open issues: \n\n- [ ] URL \n- [ ] URL \n- [ ] URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-03-03T23:43:50+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2696220578","fragment_type":"issue_comment","sequence":41,"text":"Hi bro! Nested key are welcome. But I think the variant should be passed through options, right?\n\nImage\n\nImage","author_login":"thankkien","author_association":"NONE","created_at":"2025-03-04T05:09:14+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2696243057","fragment_type":"issue_comment","sequence":42,"text":"@thankkien you need to wrap messages with variants in an array URL","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-03-04T05:22:33+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2696273830","fragment_type":"issue_comment","sequence":43,"text":"@samuelstroschein Oh, I was following an expired document here: URL","author_login":"thankkien","author_association":"NONE","created_at":"2025-03-04T05:39:31+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2716680241","fragment_type":"issue_comment","sequence":44,"text":"## Two last bugs\n\n- URL \n- URL \n\nI expect to complete them tomorrow!\n\nBefore a 2.0 release, I'd like to complete the following issues as well: \n\n- #342 \n- #444 \n- comparison table to other i18n libs\n- investigate 1h into per locale splitting via SSG \n\nPS The >beta.28 are the release candidates. You can go ahead and already adopt it!","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-03-12T06:26:09+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2719643416","fragment_type":"issue_comment","sequence":45,"text":"Feedback wanted for the comparison table in the docs URL \n\n- i find it a bit overwhelming \n- the key message of \"paraglide js is simple to use, tree-shakes, and works in any framework\" is not getting across\n- BUT enterprise adopters are looking for stuff like multi tenancy etc. \n\nIdea: \n\nMaybe split the comparison table into two? 1. Simple 5 key features then 2. Full feature comparison (for the people who need it)?\n\nImage","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-03-13T02:34:39+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2720459949","fragment_type":"issue_comment","sequence":46,"text":"For me personally that table is cool. I would only think about how to visually group that features, this should make reception softer. Maybe something like Basic use | Enterprise use / Advanced use. Maybe the other way... Like Performance, Ecosystem, etc. Something what will visually break long list to the few smaller lists.","author_login":"oskar-gmerek","author_association":"NONE","created_at":"2025-03-13T08:53:25+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2720475667","fragment_type":"issue_comment","sequence":47,"text":"One simple suggestion: the table is not scrollable on mobile, so you can only see the first three columns.","author_login":"leeoocca","author_association":"NONE","created_at":"2025-03-13T08:56:50+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2720616373","fragment_type":"issue_comment","sequence":48,"text":"Yes, maybe order/highlight/group the list. We had a preference for a (Meta)framework first and then looked for translation libraries.\nSo Metaframework (NextJS, SvelteKit, Astro, ...) compatible and Framework agnostic / support for svelte were important.\nSo grouping Framework stuff like\nMetaframework (NextJS, SvelteKit, Astro, ...) compatible and Framework agnostic would make sense.","author_login":"1muen","author_association":"NONE","created_at":"2025-03-13T09:45:09+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2721387189","fragment_type":"issue_comment","sequence":49,"text":"Hi, thanks for the hard work !\n\n1. I find the \"Requires build step\" misleading: the \"Yes\" has the red cross whereas the \"No\" has the green tick. At first I thought this is just a typo. But probably the icons are OK, but opposite to the answer they represent. So maybe a \"No build step\" label would be more appropriate: then Paraglide is \"No\" with red cross and the others are \"Yes\" with green tick. Or if \"Requires a build step\" is a \"good\" thing, then the icons are wrong.\n2. I do not find this particularly overwhelming, I just noticed some points are not very clear to me: \"Multi-tenancy\", \"Strategy agnostic\" as examples. Maybe an info icon with a tooltip/title which provides context could help.\n4. Instead of \"Maturity\", I would rather use something which is more common and representative like \"Under active development\". I feel like Maturity term could disadvantage ParaglideJS for no good reason.","author_login":"pluxain","author_association":"NONE","created_at":"2025-03-13T14:05:35+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730653935","fragment_type":"issue_comment","sequence":50,"text":"Thank you and congrats for this release!! Hope this will be the new standard for i18n!","author_login":"WarningImHack3r","author_association":"NONE","created_at":"2025-03-17T19:43:22+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2741672469","fragment_type":"issue_comment","sequence":51,"text":"@ambios1 you have to create them yourself. you can use this pattern and adapt it for alternate links URL or create a sitemap with URL a PR that would introduce a `generateAlternateLinks(\"/path\")` would also be appreciated","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-03-20T21:13:02+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2741688700","fragment_type":"issue_comment","sequence":52,"text":"Hi @samuelstroschein,\n\nI don't know if I'm referencing the wrong documentation or maybe I have the wrong plugin. I'm trying to include these options but ts is yelling at me saying\n \n\njavascript\n// vite.config.ts\nimport { paraglideVitePlugin } from '@inlang/paraglide-js';\n\nparaglideVitePlugin({\n project: './project.inlang',\n outdir: './src/paraglide',\n // options: {\n // emitGitIgnore: false,\n // emitPrettierIgnore: false,\n // emitDts: true,\n // },\n});","author_login":"rickcedwhat","author_association":"NONE","created_at":"2025-03-20T21:21:48+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2741698331","fragment_type":"issue_comment","sequence":53,"text":"@rickcedwhat wrong docs. the options are defined directly on the root object. Please make a PR to the docs to lift the confusion \n\nts\n\nparaglideVitePlugin({\n project: './project.inlang',\n outdir: './src/paraglide',\n // emitGitIgnore: false,\n // emitPrettierIgnore: false,\n // emitDts: true,\n});","author_login":"samuelstroschein","author_association":"MEMBER","created_at":"2025-03-20T21:27:00+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3188942805","fragment_type":"issue_comment","sequence":54,"text":"Migration Guide from user from I18N who solely use the useTranslation hook.\n\nExample of what i have created, but easily could be added to Paraglide npm\n\n// Import the JSON file directly as fallback\nimport messages from \"../../messages/en.json\";\n\n// Define TFunction type to maintain compatibility with i18next-based components\nexport type TFunction = (\n key: string,\n options?: Record ,\n) => string;\n\n// Helper function to handle parameter interpolation\nconst interpolateMessage = (\n message: string,\n options?: Record ,\n): string => {\n if (!options) return message;\n\n let result = message;\n Object.entries(options).forEach(([key, value]) => {\n // Handle both {key} and {{key}} patterns for compatibility\n result = result.replace(\n new RegExp(`\\\\{\\\\{?${key}\\\\}?\\\\}`, \"g\"),\n String(value),\n );\n });\n\n return result;\n};\n\n// Helper function to convert dot notation keys to underscore notation (matching our JSON keys)\nconst convertKeyToJsonKey = (key: string): string =>\n key\n .replace(/\\./g, \"_\") // dots to underscores\n .replace(/-/g, \"_\") // hyphens to underscores\n .replace(/[^a-zA-Z0-9_]/g, \"_\") // any other special chars to underscores\n .replace(/_+/g, \"_\") // multiple underscores to single\n .replace(/^_|_$/g, \"\"); // remove leading/trailing underscores\n\n/**\n * @deprecated\n * This custom useTranslation hook is deprecated and will be removed in the future.\n *\n * Please transition to using ParaglideJS message functions directly for all new code.\n * Instead of:\n * const { t } = useTranslation();\n * t(\"subscription.subscriber.general\");\n * t(\"fileSize.kilobytes\", { size: 150 });\n *\n * Use:\n * import * as m from \"@paraglide/messages\";\n * m.subscription_subscriber_general();\n * m.fileSize_kilobytes({ size: 150 });\n *\n * This provides full type-safety, better performance, and is the recommended approach going forward.\n * See: URL \n */\nexport const useTranslation = () => {\n const t: TFunction = (key: string, options?: Record ) => {\n // First try the key as-is\n let message = (messages as any)[key];\n\n // If not found, try converting dots to underscores\n if (!message) {\n const convertedKey = convertKeyToJsonKey(key);\n message = (messages as any)[convertedKey];\n }\n\n // If still not found, try some variations\n if (!message) {\n const variations = [\n key.toLowerCase(),\n key.toUpperCase(),\n convertKeyToJsonKey(key.toLowerCase()),\n convertKeyToJsonKey(key.toUpperCase()),\n ];\n\n for (const variation of variations) {\n if ((messages as any)[variation]) {\n message = (messages as any)[variation];\n break;\n }\n }\n }\n\n if (message) {\n // Interpolate parameters if provided\n return interpolateMessage(message, options);\n }\n\n // If no message found, log a warning and return the key\n console.warn(`Translation key not found: ${key}`);\n\n return key;\n };\n\n return { t };\n};","author_login":"Samuel-Morgan-Tyghe","author_association":"NONE","created_at":"2025-08-14T15:49:01+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3498179708","fragment_type":"issue_comment","sequence":55,"text":"@qshssewww no. the idea is that the *.inlang folder is under our control. otherwise, we'd have to consider how users interact witht that dir and what is gitignored etc","author_login":"samuelstroschein","author_association":"NONE","created_at":"2025-11-06T16:22:53+08:00","repo_name":"opral/inlang-paraglide-js","issue_id":2501881174,"issue_number":201,"issue_url":"https://github.com/opral/inlang-paraglide-js/issues/201","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0349","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Design & discovery: Hazard stories for MVP?","query_context":"### Design & discovery: Hazard stories for MVP\nPreliminary MVP flow (in Figma)\nMVP user stories - design details\n\n**Supporting user flow:** Person clicks on a link from an NWS alert\n\n**Stories to include**\n- 4.1 As a member of the public who got a hazard alert through their weather app, I want to click a link and see the full WWA hazard\n- 4.2 … I want to be made aware of any hazards for a specific location\n- 4.3 … I want to understand at-a-glance what, where, and how bad the threat/impact level of a hazard for a 4.4 specific location\n- 4.4 … I would like to know what to expect for the next 24 hours (could be more?) for a specific location\n- 4.5… I want to understand the actions or steps I could take to save my life or property at my location\n- 4.6… I'd like to know when and where the hazard is in order to see if the hazard is approaching me or near me/specific location\n\nRelated:\n- As an external user, I want to be made aware of the of any hazards for a specific location\n**Added just to capture broader need for the following 2 stories. \n\n## Tasks\n- Design and define molecules/layout\n- Collab w/content for hierarchy of content and content details\n- PO collab and review for organizational needs and feasibility\n- Feasibility collab and review w/eng\n- Determine if an user research is needed\n\n## By the end of this sprint\n- Designs ready for review: molecules and layout designed for each story supporting flow for hazard (link from outside source to full alert)\n- Beginning documentation of acceptance criteria and supporting need for each user story/molecule\n-- Wireframe and needed support (technical and organizational)\n-- Documentation of high level key implementation details\n\n**Continuous discovery**\n- What we might want to test with users and what we have less certainty about\n\nOut of scope - future sprint:\n- Secondary visual imagery discovery for hazards","known_context_document_ids":["gh_issue_1859830898"],"reference_answer":"@janelx Updated this story to reflect the concept we talked about of this as a version/view of a weather story. I added a couple examples based on past hazard-based stories, but it might be a bit before I can grab some images to go with them because I'll need to wait for new ones or use wayback machine to find some that match. \nWith that missing piece in mind, does this otherwise reflect what we talked about? Is anything different or missing?","answer_document_id":"gh_comment_1750642834","silver_evidence_path":["gh_comment_1746988135","gh_issue_1877500048","gh_comment_1750642834"],"evidence_issue_ids":[1859830898,1877500048],"source_repo_name":"weather-gov/weather.gov","source_issue_id":1859830898,"source_issue_number":148,"source_issue_url":"https://github.com/weather-gov/weather.gov/issues/148","target_repo_name":"weather-gov/weather.gov","target_issue_id":1877500048,"target_issue_number":155,"target_issue_url":"https://github.com/weather-gov/weather.gov/issues/155","reference_anchor_document_id":"gh_comment_1746988135","reference_answer_author":"kmranjo","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1935,"anchor_target_overlap":0.3226,"target_answer_overlap":0.2432},"issue_created_at":"2023-08-21T17:31:12+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1859830898","fragment_type":"issue_description","sequence":0,"text":"Design & discovery: Hazard stories for MVP\n### Design & discovery: Hazard stories for MVP\nPreliminary MVP flow (in Figma)\nMVP user stories - design details\n\n**Supporting user flow:** Person clicks on a link from an NWS alert\n\n**Stories to include**\n- 4.1 As a member of the public who got a hazard alert through their weather app, I want to click a link and see the full WWA hazard\n- 4.2 … I want to be made aware of any hazards for a specific location\n- 4.3 … I want to understand at-a-glance what, where, and how bad the threat/impact level of a hazard for a 4.4 specific location\n- 4.4 … I would like to know what to expect for the next 24 hours (could be more?) for a specific location\n- 4.5… I want to understand the actions or steps I could take to save my life or property at my location\n- 4.6… I'd like to know when and where the hazard is in order to see if the hazard is approaching me or near me/specific location\n\nRelated:\n- As an external user, I want to be made aware of the of any hazards for a specific location\n**Added just to capture broader need for the following 2 stories. \n\n## Tasks\n- Design and define molecules/layout\n- Collab w/content for hierarchy of content and content details\n- PO collab and review for organizational needs and feasibility\n- Feasibility collab and review w/eng\n- Determine if an user research is needed\n\n## By the end of this sprint\n- Designs ready for review: molecules and layout designed for each story supporting flow for hazard (link from outside source to full alert)\n- Beginning documentation of acceptance criteria and supporting need for each user story/molecule\n-- Wireframe and needed support (technical and organizational)\n-- Documentation of high level key implementation details\n\n**Continuous discovery**\n- What we might want to test with users and what we have less certainty about\n\nOut of scope - future sprint:\n- Secondary visual imagery discovery for hazards","author_login":"janelx","author_association":"COLLABORATOR","created_at":"2023-08-21T17:31:12+08:00","repo_name":"weather-gov/weather.gov","issue_id":1859830898,"issue_number":148,"issue_url":"https://github.com/weather-gov/weather.gov/issues/148","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1715707869","fragment_type":"issue_comment","sequence":1,"text":"I believe this ticket is in review:\n- Hazard SMEs and Champions on Wednesday, Sept 13\n- Forecaster feedback\n\nOnce we get feedback, we can then finalize our definition for the MVP Hazard flow.","author_login":"colinmurphy01","author_association":"MEMBER","created_at":"2023-09-12T13:16:49+08:00","repo_name":"weather-gov/weather.gov","issue_id":1859830898,"issue_number":148,"issue_url":"https://github.com/weather-gov/weather.gov/issues/148","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1745211312","fragment_type":"issue_comment","sequence":2,"text":"@janelx are we still waiting on forecaster feedback on this? I don't think we've gotten it, but Sarah might have this prioritized against partner/public needs as well.","author_login":"colinmurphy01","author_association":"COLLABORATOR","created_at":"2023-10-03T15:25:56+08:00","repo_name":"weather-gov/weather.gov","issue_id":1859830898,"issue_number":148,"issue_url":"https://github.com/weather-gov/weather.gov/issues/148","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1746906649","fragment_type":"issue_comment","sequence":3,"text":"@colinmurphy01 I believe we have received enough in from forecasters to begin creating this. I have a good idea of what it will look like and how we might be able to begin testing it. It sounds like there is a large public and partner need for hazard stories (forecaster communication around hazard) and the hazard page in general.","author_login":"janelx","author_association":"COLLABORATOR","created_at":"2023-10-04T13:42:31+08:00","repo_name":"weather-gov/weather.gov","issue_id":1859830898,"issue_number":148,"issue_url":"https://github.com/weather-gov/weather.gov/issues/148","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1746988135","fragment_type":"issue_comment","sequence":4,"text":"@colinmurphy01 the comment above is for #155 Hazard Forecasts, which I mistook this ticket for. I don't think this ticket requires forecaster feedback at the moment? I'm not sure where that need came from. I created a new ticket for a more detailed wireframe #242. I can review flow and components with POs this Friday and if approved we can close this ticket.","author_login":"janelx","author_association":"COLLABORATOR","created_at":"2023-10-04T14:25:27+08:00","repo_name":"weather-gov/weather.gov","issue_id":1859830898,"issue_number":148,"issue_url":"https://github.com/weather-gov/weather.gov/issues/148","linked_issue_ids":[1877500048],"is_known_query_context":false},{"document_id":"gh_issue_1877500048","fragment_type":"issue_description","sequence":0,"text":"Hazard story\nWe are dramatically simplifying this feature\n\n### Supported user stories\nE4 … As a member of the public or a partner, I would like to understand the possibility, severity, and impact of a hazard\nE4.3 …I want to understand at-a-glance what, where, and how bad the threat/impact level is of a hazard for a specific location \nE4.4 … I would like to know what to expect for the length of the hazard (could be more?) for a specific location\nE4.5 … I want to understand the actions or steps I could take to save my life or property at my location\nE.9 As a forecaster I want to be able to write a unique weather story for a specific hazard that is separate from my WFO weather story, in order to communinate relevant details to people experiencing the hazard.\n\nConsiderations:\n- How do we ingest hazard products into the CMS?\n- Is there a Hazard ID we can use?\n- How can a forecaster link a story to a hazard in the CMS?\n- Can a forecaster correlate a story to multiple hazards?\n- When should the hazard story be published or unpublished?\n\nHypotheses: \n- By displaying hazard-specific content only to those impacted by the hazard, we can deliver high value without adding confusion or alarm to other users. \n- Content in the hazard story provides a complement to the hazard product itself. \n\nAcceptance Criteria\n\n- [ ] \n\n----- Delete below? -------\n\n### User acceptance criteria\nAs a member of the public or partner, I understand the conditions, timing, impact and severity of a hazard for my specific location, and the actions I need to take to protect life or property from that hazard. \n\n### Design (define/discovery)\n**Purpose**\nProvide an open space for forecasters to communicate the what/when/impacts of an impending weather hazard for a specific area, and safety guidance needed to advise those in that area how to protect life and property. Serves as a complement to the hazard products and weather data. \n\n**Format**\nText with the option to include supportive imagery\nText would need basic styling options (bold, italic, underline, add links, etc) \nImage formats are TBD \n\n### Examples \n**Wind advisory in effect tonight**\nExpect strong northwest winds tonight up to 50 mph, ending Friday morning. \nWinds will be strong enough to blow away unsecured items, and make driving difficult for high profile vehicles. \n**Take action**\nSecure loose items like outdoor furniture, and use caution if outdoors, especially driving. \n\n**Severe thunderstorm warning** \nA severe thunderstorm has been spotted in McDonough County, moving east. \nExpect winds over 50 mph, heavy rain, lightning, and quarter-sized hail, which is likely to damage vehicles. \n**Take action**\nMove indoors immediately. Move to an interior room on the lowest floor, and avoid large windows.\n\n### Component acceptance criteria\nA forecaster should be able to: \n- Create a new hazard story \n- Write and format the text as desired\n- Associate the story with a specific hazard product (or multiple hazard products) \n- Tag the story with the hazard type \n- Upload an image file (or multiple) to the DAM\n- Author alt text or a caption for each image\n- Add images (up to 3)\n- Publish the story \n- Unpublish the story \n- Edit an existing story (both updating the text and/or removing or updating the image) \n- View all hazard stories created within a given WFO, regardless of publication status, and search by hazard type tag \n- View the change log of a story (date/time of change, type of change, person who changed it, etc) \n\nA forecaster should not be able to: \n- Inject code into the component \n- Write more than 500 words in the text field \n- Add more than 3 images \n\nAn end user should be able to: \n- Navigate to any page displaying the hazard product and see the hazard story paired with it\n- Read the text up to 300 words \n- If text is longer than 300 words, see a clear invitation to expand it in full \n- Expand and collapse the expanded text \n- See when the story was last published\n- View the image\n- If multiple images are present, swipe and/or click through each one \n- Read the alt text or caption for each image \n- Expand each image and return it to previous size \n\nThe system should be able to: \n- Automatically include a date and timestamp when the story is published \n- Automatically include the name of the WFO it is associated with \n- Include the component on the page only if the linked hazard product applies to that location \n\n### Exploration needed\nStakeholder user testing: Is the limit of up to 500 words enough to meet the need?\n\nEnd user testing:\n- Is the guidance of 100-200 words (with room for up to 500) enough to meet the need? If full length, does it negatively impact the experience?\n- What type of images add value to the weather story for the user? \n\n**Notes**\n- Currently offices differ: 1 product to multiple zones or WSW for each zone and add timing\n\n----\n\n[tasklist]\n#### Review: design, function and flow:\n- [ ] POs - org alignment and vision review\n- [ ] Eng - feasibility review and right size stories\n- [ ] UX - what and how to test\n\n[tasklist]\n#### Story details\n- [ ] Reviewed designs (must be attached)\n- [ ] Acceptance criteria define (added to this story)","author_login":"janelx","author_association":"CONTRIBUTOR","created_at":"2023-09-01T14:10:01+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1741390639","fragment_type":"issue_comment","sequence":1,"text":"I'm afraid I haven't worked on this one yet at all - limited on time this week. I do think that once we have the weather story ticket fleshed out, it will heavily inform this one, so I've been prioritizing work on that first. It's ready to be discussed with design and product.","author_login":"kmranjo","author_association":"COLLABORATOR","created_at":"2023-09-29T19:34:46+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750642834","fragment_type":"issue_comment","sequence":2,"text":"@janelx Updated this story to reflect the concept we talked about of this as a version/view of a weather story. I added a couple examples based on past hazard-based stories, but it might be a bit before I can grab some images to go with them because I'll need to wait for new ones or use wayback machine to find some that match. \nWith that missing piece in mind, does this otherwise reflect what we talked about? Is anything different or missing?","author_login":"kmranjo","author_association":"COLLABORATOR","created_at":"2023-10-06T13:01:15+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847453911","fragment_type":"issue_comment","sequence":3,"text":"@kmranjo can you do two things: \n\n- confirm that I've updated this to reflect the capability we're testing in the prototype?\n- Review the content from the older ticket (below Delete this?) and determine what's relevant to keep?","author_login":"colinmurphy01","author_association":"COLLABORATOR","created_at":"2023-12-08T16:06:57+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847502194","fragment_type":"issue_comment","sequence":4,"text":"@colinmurphy01 I updated the info above to include the hypothesis I think we are testing, but want to confirm with @partly-igor and @sarahmhgov that this looks correct. \nI also updated the info below the \"delete\" line to be a bit closer to the concept we're considering, but a lot of it is very specific to implementation and I don't think we're there just yet. Not sure if it is valuable to keep all that since we might need it eventually (even if edited), or if it woudl be cleaner to delete it all and get the design fully where we want it before looking at that level of detail for how the component will work. Thoughts?","author_login":"kmranjo","author_association":"COLLABORATOR","created_at":"2023-12-08T16:40:39+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1847834190","fragment_type":"issue_comment","sequence":5,"text":"The hypotheses look good to me. \n\nAgree that some of the implementation details in the AC below the delete line is a little early, and may change based on feedback we hear next week. Wondering if we refine this ticket after the round of research?","author_login":"partly-igor","author_association":"COLLABORATOR","created_at":"2023-12-08T20:56:51+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1915062723","fragment_type":"issue_comment","sequence":6,"text":"@kmranjo @sarahmhgov I think we are holding on this feature for a while now. I'm going to close this ticket.","author_login":"colinmurphy01","author_association":"COLLABORATOR","created_at":"2024-01-29T16:22:50+08:00","repo_name":"weather-gov/weather.gov","issue_id":1877500048,"issue_number":155,"issue_url":"https://github.com/weather-gov/weather.gov/issues/155","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0350","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"core java plugin - inconsistent version resolution?","query_context":"**Describe the bug**\n\nVersion resolution is inconsistent between JVM vendors.\nRoot cause being that the versions aren't consistent between vendors.\n\n**To Reproduce**\n\nMake sure to run this with no local installs of java\n\nsh\n \n...\nmise ~/foo/.mise.toml tools: java@17.0.2\n \nopenjdk version \"17.0.2\" 2022-01-18\nOpenJDK Runtime Environment (build 17.0.2+8-86)\nOpenJDK 64-Bit Server VM (build 17.0.2+8-86, mixed mode, sharing)\n\n✅ You get the latest openjdk 17 release\n\n \n...\nmise ~/foo/.mise.toml tools: java@sapmachine-17\n \nopenjdk version \"17\" 2021-09-14 LTS\nOpenJDK Runtime Environment SapMachine (build 17+35-LTS-sapmachine)\nOpenJDK 64-Bit Server VM SapMachine (build 17+35-LTS-sapmachine, mixed mode)\n\n❌ You get the initial sapmachine 17 release, not the most recent which would be 17.0.10 at the time of writing\n\n❯ mise ls-remote java@sapmachine-17\nsapmachine-17\nsapmachine-17.0.1\n...\nsapmachine-17.0.10\nsapmachine-17.0.4-snapshot.0\nsapmachine-17.0.7-snapshot.1\n\n**Expected behavior**\n\nRegardless of the vendor, if I use just the major version, I get the latest patch release for said version as per \"fuzzy matching\"\n\n**`mise doctor` output**\n\n \n `mise doctor` \n\ntext\nversion: 2024.4.0 macos-arm64 (2024-04-02)\nactivated: yes\nshims_on_path: yes\n\nbuild_info:\n Target: aarch64-apple-darwin\n Features: DEFAULT, NATIVE_TLS\n Built: Tue, 2 Apr 2024 01:55:39 +0000\n Rust Version: rustc 1.77.1 (7cf61ebde 2024-03-27) (Homebrew)\n Profile: release\n\nshell:\n /bin/zsh\n zsh 5.9 (x86_64-apple-darwin23.0)\n\ndirs:\n data: ~/.../.mise\n config: ~/.../.mise\n cache: ~/.../.mise\n state: ~/.../.mise\n shims: ~/.../.mise/shims\n\nconfig_files:\n ~/.../.mise/config.toml\n ~/.../foo-mise-java/.mise.toml\n\nplugins:\n bun (core)\n deno (core)\n go (core)\n gradle URL \n java (core)\n maven URL \n node (core)\n python (core)\n ruby (core)\n vault URL \n\ntoolset:\n java@sapmachine-17\n maven@3.9.6\n node@18.20.1\n\nenv_vars:\n MISE_DIR=/Users/.../.mise\n MISE_CONFIG_DIR=/Users/.../.mise\n MISE_CACHE_DIR=/Users/.../.mise\n MISE_STATE_DIR=/Users/.../.mise\n MISE_DATA_DIR=/Users/.../.mise\n MISE_SHELL=zsh\n\nsettings:\n activate_aggressive = false\n all_compile = false\n always_keep_download = false\n always_keep_install = false\n asdf_compat = false\n cargo_binstall = true\n color = true\n disable_default_shorthands = false\n disable_tools = []\n experimental = false\n go_default_packages_file = \"~/.default-go-packages\"\n go_download_mirror = \" URL \n go_repo = \" URL \n go_set_gopath = false\n go_set_goroot = true\n go_skip_checksum = false\n jobs = 4\n legacy_version_file = true\n legacy_version_file_disable_tools = []\n node_compile = false\n not_found_auto_install = true\n paranoid = false\n plugin_autoupdate_last_check_duration = \"7d\"\n python_compile = false\n python_default_packages_file = \"/Users/I327130/.default-python-packages\"\n python_pyenv_repo = \" URL \n raw = false\n trusted_config_paths = []\n quiet = false\n verbose = false\n yes = false\n ci = false\n debug = false\n trace = false\n log_level = \"info\"\n python_venv_auto_create = false\n\n [status]\n missing_tools = \"if_other_versions_installed\"\n show_env = false\n show_tools = false\n\n1 problem found:\n\n1. new mise version 2024.4.3 available, currently on 2024.4.0\n\n \n\n**Additional context**\n\nHonestly I'm not quite sure if this should be a bug or a feature.\n\nInterestingly enough, the problem is already recognized, at least for `openjdk` where major versions _are_ normalized already:\n\n URL \n\notherwise `mise use java@17` would behave the same (incorrect) way 😄","known_context_document_ids":["gh_issue_2237187396"],"reference_answer":"I am not sure why that check is there. I think maybe I expect that the version was resolved at that point or something so if it was ToolVersionRequest::Prefix in the past it should at this point be resolved to ToolVersionRequest::Version. I would try adding ToolVersionRequest::Prefix and seeing if everything works, if so we can add that to the assertion","answer_document_id":"gh_comment_2049990631","silver_evidence_path":["gh_comment_2049988527","gh_issue_2237963484","gh_comment_2049990631"],"evidence_issue_ids":[2237187396,2237963484],"source_repo_name":"jdx/mise","source_issue_id":2237187396,"source_issue_number":1887,"source_issue_url":"https://github.com/jdx/mise/issues/1887","target_repo_name":"jdx/mise","target_issue_id":2237963484,"target_issue_number":1888,"target_issue_url":"https://github.com/jdx/mise/issues/1888","reference_anchor_document_id":"gh_comment_2049988527","reference_answer_author":"jdx","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.1875,"target_answer_overlap":0.1905},"issue_created_at":"2024-04-11T08:27:07+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2237187396","fragment_type":"issue_description","sequence":0,"text":"core java plugin - inconsistent version resolution\n**Describe the bug**\n\nVersion resolution is inconsistent between JVM vendors.\nRoot cause being that the versions aren't consistent between vendors.\n\n**To Reproduce**\n\nMake sure to run this with no local installs of java\n\nsh\n \n...\nmise ~/foo/.mise.toml tools: java@17.0.2\n \nopenjdk version \"17.0.2\" 2022-01-18\nOpenJDK Runtime Environment (build 17.0.2+8-86)\nOpenJDK 64-Bit Server VM (build 17.0.2+8-86, mixed mode, sharing)\n\n✅ You get the latest openjdk 17 release\n\n \n...\nmise ~/foo/.mise.toml tools: java@sapmachine-17\n \nopenjdk version \"17\" 2021-09-14 LTS\nOpenJDK Runtime Environment SapMachine (build 17+35-LTS-sapmachine)\nOpenJDK 64-Bit Server VM SapMachine (build 17+35-LTS-sapmachine, mixed mode)\n\n❌ You get the initial sapmachine 17 release, not the most recent which would be 17.0.10 at the time of writing\n\n❯ mise ls-remote java@sapmachine-17\nsapmachine-17\nsapmachine-17.0.1\n...\nsapmachine-17.0.10\nsapmachine-17.0.4-snapshot.0\nsapmachine-17.0.7-snapshot.1\n\n**Expected behavior**\n\nRegardless of the vendor, if I use just the major version, I get the latest patch release for said version as per \"fuzzy matching\"\n\n**`mise doctor` output**\n\n \n `mise doctor` \n\ntext\nversion: 2024.4.0 macos-arm64 (2024-04-02)\nactivated: yes\nshims_on_path: yes\n\nbuild_info:\n Target: aarch64-apple-darwin\n Features: DEFAULT, NATIVE_TLS\n Built: Tue, 2 Apr 2024 01:55:39 +0000\n Rust Version: rustc 1.77.1 (7cf61ebde 2024-03-27) (Homebrew)\n Profile: release\n\nshell:\n /bin/zsh\n zsh 5.9 (x86_64-apple-darwin23.0)\n\ndirs:\n data: ~/.../.mise\n config: ~/.../.mise\n cache: ~/.../.mise\n state: ~/.../.mise\n shims: ~/.../.mise/shims\n\nconfig_files:\n ~/.../.mise/config.toml\n ~/.../foo-mise-java/.mise.toml\n\nplugins:\n bun (core)\n deno (core)\n go (core)\n gradle URL \n java (core)\n maven URL \n node (core)\n python (core)\n ruby (core)\n vault URL \n\ntoolset:\n java@sapmachine-17\n maven@3.9.6\n node@18.20.1\n\nenv_vars:\n MISE_DIR=/Users/.../.mise\n MISE_CONFIG_DIR=/Users/.../.mise\n MISE_CACHE_DIR=/Users/.../.mise\n MISE_STATE_DIR=/Users/.../.mise\n MISE_DATA_DIR=/Users/.../.mise\n MISE_SHELL=zsh\n\nsettings:\n activate_aggressive = false\n all_compile = false\n always_keep_download = false\n always_keep_install = false\n asdf_compat = false\n cargo_binstall = true\n color = true\n disable_default_shorthands = false\n disable_tools = []\n experimental = false\n go_default_packages_file = \"~/.default-go-packages\"\n go_download_mirror = \" URL \n go_repo = \" URL \n go_set_gopath = false\n go_set_goroot = true\n go_skip_checksum = false\n jobs = 4\n legacy_version_file = true\n legacy_version_file_disable_tools = []\n node_compile = false\n not_found_auto_install = true\n paranoid = false\n plugin_autoupdate_last_check_duration = \"7d\"\n python_compile = false\n python_default_packages_file = \"/Users/I327130/.default-python-packages\"\n python_pyenv_repo = \" URL \n raw = false\n trusted_config_paths = []\n quiet = false\n verbose = false\n yes = false\n ci = false\n debug = false\n trace = false\n log_level = \"info\"\n python_venv_auto_create = false\n\n [status]\n missing_tools = \"if_other_versions_installed\"\n show_env = false\n show_tools = false\n\n1 problem found:\n\n1. new mise version 2024.4.3 available, currently on 2024.4.0\n\n \n\n**Additional context**\n\nHonestly I'm not quite sure if this should be a bug or a feature.\n\nInterestingly enough, the problem is already recognized, at least for `openjdk` where major versions _are_ normalized already:\n\n URL \n\notherwise `mise use java@17` would behave the same (incorrect) way 😄","author_login":"mpern","author_association":"NONE","created_at":"2024-04-11T08:27:07+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2049988527","fragment_type":"issue_comment","sequence":1,"text":"This looks inconsistent indeed, will need to dig into this since it works for some and not for others. In the meantime i would have suggested to use the workaround using a `prefix:` scope but it looks that is also not working as expected with #1888.","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-11T15:40:14+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[2237963484],"is_known_query_context":false},{"document_id":"gh_comment_2050072252","fragment_type":"issue_comment","sequence":2,"text":"Behaviour is consistent in the sense that it uses the \"exact\" match if found, otherwise falls back to newest available version (fuzzy) matching the provided version. The `@17` version is a shorthand for `openjdk` which behaves a bit differently as you have pointed out.\n\n17 --> openjdk-17.0.2\nopenjdk-17 --> openjdk-17\nsapmachine-17 --> sapmachine-17\nliberica-17 --> liberica-17.0.10+13 (no liberica-17 version, so newest 17.x is installed)\noracle-17 --> oracle-17","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-11T16:27:37+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2061538712","fragment_type":"issue_comment","sequence":3,"text":"to make it even more fun:\n\nsh\n❯ mise use java@sapmachine-17.0.11\n...\nOpenJDK Runtime Environment SapMachine (build 17.0.11+9-LTS)\nOpenJDK 64-Bit Server VM SapMachine (build 17.0.11+9-LTS, mixed mode, sharing)\nmise java@sapmachine-17.0.11 ✓ installed\nmise ~/foo/.mise.toml tools: java@sapmachine-17.0.11\n\n❯ mise use java@sapmachine-17\nmise ~/foo/.mise.toml tools: java@sapmachine-17.0.11","author_login":"mpern","author_association":"NONE","created_at":"2024-04-17T15:25:14+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2061564217","fragment_type":"issue_comment","sequence":4,"text":"I humbly suggest to nnormalilze all versions when ingesting data for URL","author_login":"mpern","author_association":"NONE","created_at":"2024-04-17T15:31:03+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2078984668","fragment_type":"issue_comment","sequence":5,"text":"Interestingly this does not happen if `sapmachine-17` is already installed.\n\nbash\n ❯ mise i java@sapmachine-17\n\n ❯ mise use java@sapmachine-17.0.11\n...\nOpenJDK Runtime Environment SapMachine (build 17.0.11+9-LTS)\nOpenJDK 64-Bit Server VM SapMachine (build 17.0.11+9-LTS, mixed mode, sharing)\nmise java@sapmachine-17.0.11 ✓ installed\nmise ~/foo/.mise.toml tools: java@sapmachine-17.0.11\n\n ❯ mise use java@sapmachine-17\nmise ~/foo/.mise.toml tools: java@sapmachine-17","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-26T09:18:40+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2084385236","fragment_type":"issue_comment","sequence":6,"text":"How about this:\n\nInstead of making the version resolution logic more complicated, normalize the input data.\n\nIf java versions where consistent (major.minor.patch) across all vemdors in rtx-java-metadata, all of this would go away and you could even drop the secret sauce to make `java@21` work as expected.\n\nHappy to help if that's the route you want to take.","author_login":"mpern","author_association":"NONE","created_at":"2024-04-30T05:01:25+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2084702913","fragment_type":"issue_comment","sequence":7,"text":"@mpern Agree that this might be a better solution but i assume this will be quite some effort. I'm not familiar with the java-metadata repo in detail but historic metadata would need to be updated manually as it is not updated automatically (only new versions are added AFAIK).\n\n@jdx What is your take on this?","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-30T08:29:58+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2085861672","fragment_type":"issue_comment","sequence":8,"text":"Okey, i'm clearly in favour of having a consistent solution by normalizing the versions in rtx-java-metadata.","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-30T16:23:25+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2131296251","fragment_type":"issue_comment","sequence":9,"text":"@mpern with PR URL merged, this should be resolved now. After `mise cache clear` the command `mise ls-remote java` should show no more semantically incorrect versions.","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-05-25T14:32:17+08:00","repo_name":"jdx/mise","issue_id":2237187396,"issue_number":1887,"issue_url":"https://github.com/jdx/mise/issues/1887","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2237963484","fragment_type":"issue_description","sequence":0,"text":"mise panics if prefix: is used on certain core plugins\n**Describe the bug**\nWhen using `prefix:` on certain plugins (bun, deno, java, ruby,..) the installation panics with following error.\n\n**To Reproduce**\n`mise i java@prefix:sapmachine-17`\n\n**Expected behavior**\nInstallation is successful with latest version matching the prefix.\n\n**Additional context**\nMost likely related to following assertion used in the mentioned plugins.\n\nrust\n fn install_version_impl(&self, ctx: &InstallContext) -> Result {\n ...\n assert!(matches!(\n &ctx.tv.request,\n ToolVersionRequest::Version { .. }\n ));\n...","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-11T15:06:04+08:00","repo_name":"jdx/mise","issue_id":2237963484,"issue_number":1888,"issue_url":"https://github.com/jdx/mise/issues/1888","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049982638","fragment_type":"issue_comment","sequence":1,"text":"@jdx Shouldn't be possible to use scopes via version suffix as well or was this only intended for configuration files?","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-11T15:37:12+08:00","repo_name":"jdx/mise","issue_id":2237963484,"issue_number":1888,"issue_url":"https://github.com/jdx/mise/issues/1888","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049990631","fragment_type":"issue_comment","sequence":2,"text":"I am not sure why that check is there. I think maybe I expect that the version was resolved at that point or something so if it was ToolVersionRequest::Prefix in the past it should at this point be resolved to ToolVersionRequest::Version. I would try adding ToolVersionRequest::Prefix and seeing if everything works, if so we can add that to the assertion","author_login":"jdx","author_association":"OWNER","created_at":"2024-04-11T15:41:22+08:00","repo_name":"jdx/mise","issue_id":2237963484,"issue_number":1888,"issue_url":"https://github.com/jdx/mise/issues/1888","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2050009848","fragment_type":"issue_comment","sequence":3,"text":"Other core plugins like `go`, `node`, `python` don't have this assertion. Adding Prefix to the assertion works, question is if other scopes also would need to be supported and removal of the assertion would make more sense.","author_login":"roele","author_association":"CONTRIBUTOR","created_at":"2024-04-11T15:51:01+08:00","repo_name":"jdx/mise","issue_id":2237963484,"issue_number":1888,"issue_url":"https://github.com/jdx/mise/issues/1888","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0351","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"How to use PicoScan ROS1 to run 2 PicoScan for negivation?","query_context":"Dear Teams,\nWould you please share with us the workflow how to use 2 PicoScan for negivation ?\nCustomer used our 2 PicoScan can't work well, they can't start together.\n\n266b894cce5fde5fec099c9cac76ba9d","known_context_document_ids":["gh_issue_2287229718"],"reference_answer":"You are probably right. According to URL and URL you can use URL to create an odometry feedback. But I have not tested it (it is a bit beyond the scope of the driver).\n\nNevertheless, you can use the slam_toolbox to create an initial map. In navigational mode, the NAV-350 lidar generates pose- and landmark data, which are translated to TF messages. Using these TF messages, you can see in rviz, how the lidar moves on the map.","answer_document_id":"gh_comment_1706624087","silver_evidence_path":["gh_comment_2104955099","gh_issue_1874842043","gh_comment_1706624087"],"evidence_issue_ids":[2287229718,1874842043],"source_repo_name":"SICKAG/sick_scan_xd","source_issue_id":2287229718,"source_issue_number":326,"source_issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","target_repo_name":"SICKAG/sick_scan_xd","target_issue_id":1874842043,"target_issue_number":206,"target_issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","reference_anchor_document_id":"gh_comment_2104955099","reference_answer_author":"rostest","reference_answer_author_association":"COLLABORATOR","quality_score":92.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.3056,"target_answer_overlap":0.0333},"issue_created_at":"2024-05-09T09:00:06+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2287229718","fragment_type":"issue_description","sequence":0,"text":"How to use PicoScan ROS1 to run 2 PicoScan for negivation?\nDear Teams,\nWould you please share with us the workflow how to use 2 PicoScan for negivation ?\nCustomer used our 2 PicoScan can't work well, they can't start together.\n\n266b894cce5fde5fec099c9cac76ba9d","author_login":"sjeffreydong","author_association":"NONE","created_at":"2024-05-09T09:00:06+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2104955099","fragment_type":"issue_comment","sequence":1,"text":"Thanks for your feedback. To use 2 picoScan lidars under ROS-1, start sick_scan_xd twice with different ip addresses and topics in two ros nodes. See the FAQ for an example configuration.\n\nsick_scan_xd publishes PointCloud2 and LaserScan messages, SLAM and navigation using two lidars is a bit beyond the scope of the driver. See slam.md and #206 for more information or use run_linux_ros1_simu_slam_mrs1xxx.bash resp. test_200_slam_ros1_hector.launch as an example.","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2024-05-10T17:02:06+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[1874842043],"is_known_query_context":false},{"document_id":"gh_comment_2136342783","fragment_type":"issue_comment","sequence":2,"text":"Dear Teams,\n\nOur customer is running 2 picoScan150 on one controller, however will happen issues with one can't start and no data.\nbff850e8b528906f33706293b1a10ee8","author_login":"sjeffreydong","author_association":"NONE","created_at":"2024-05-29T01:12:32+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2136646369","fragment_type":"issue_comment","sequence":3,"text":"Thanks for your feedback. The photo does not support a clear diagnosis of the problem. Please send the launchfiles used for both picoScan150 devices, the commandline calls and parameters to launch sick_scan_xd and complete logfiles for further diagnosis.","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2024-05-29T06:37:38+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2136677001","fragment_type":"issue_comment","sequence":4,"text":"Dear Teams,\n\nPlease have a look. Could you check what is the issues ? why 2 picScan can’t run well on the one controller when start 2 pcioScan together ? \npicoScan150.zip\nmail","author_login":"sjeffreydong","author_association":"NONE","created_at":"2024-05-29T06:59:20+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2136678197","fragment_type":"issue_comment","sequence":5,"text":"Dear Teams,\n\nCould you check what is the issues ? why 2 picScan can’t run well on the one controller when start 2 pcioScan together ?\n\nFrom: rostest ***@***.***>\nSent: Wednesday, May 29, 2024 2:38 PM\nTo: SICKAG/sick_scan_xd ***@***.***>\nCc: Jeffrey Dong ***@***.***>; Author ***@***.***>\nSubject: Re: [SICKAG/sick_scan_xd] How to use PicoScan ROS1 to run 2 PicoScan for negivation? (Issue #326)\n\nEXTERNAL EMAIL: This message was sent from outside of SICK. Please do not click any links or open any attachments unless you trust the sender and know the content is safe. Please report suspicious emails via SMAX >\nBest regards\n\nJeffrey Dong\nProduct Manager | Sales & Service China & Hong Kong\n_________________________________________________________________________________________________________\nSICK China Co., Ltd. | Industrial Park | Building A, Suzhou Center Plaza | SuZhou, 215021 | China\n广东西克智能科技有限公司苏州办事处 | 江苏省苏州市工业园区苏州中心广场A幢1005室， 215021\nPhone +86 512 67339115-5335 | Mobile: +86 186 1621 9594 | ***@***.*** | Service hotline 4000 121 000 | www.sickcn.com | URL","author_login":"sjeffreydong","author_association":"NONE","created_at":"2024-05-29T07:00:13+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2137388960","fragment_type":"issue_comment","sequence":6,"text":"Thanks for further information and launchfiles. To run two picoScan devices simultanously, sick_scan_xd must be started in two different nodes. Each node must be configured with different lidar ip addresses and udp ports, different node names, different ros topics and frame ids for each point cloud. Therefore the following launchfile parameter should be overwritten by individual settings for each lidar:\n* \"hostname\": e.g. \"192.168.0.190\" and \"192.168.0.98\"\n* \"nodename\": e.g. sick_picoscan0\" and \"sick_picoscan1\"\n* \"publish_frame_id\": e.g. \"world0\" and \"world1\"\n* \"publish_laserscan_segment_topic\": e.g. \"scan0_segment\" and \"scan1_segment\"\n* \"publish_laserscan_fullframe_topic\": e.g. \"scan0_fullframe\" and \"scan1_fullframe\"\n* \"imu_topic\": e.g. \"imu0\" and \"imu1\"\n* \"udp_port\": e.g. \"56661\" and \"56662\"\n* \"imu_udp_port\": e.g. \"7503\" and \"7504\"\n* individual topics and frame id for each customized point cloud, e.g.\n * replace all \"topic=/cloud_\" by \"topic=/cloud0_\" resp. \"topic=/cloud1_\"\n * replace all \"frameid=world\" by \"frameid=world0\" resp. \"frameid=world1\"\n\nTwo modified launchfiles are attached. We recommend to first verify the launchfile configuration separately for each picoScan, then run both devices simultanously.\npicoscan_launchfiles.zip\n\nParameter udp_receiver_ip must be the ip address of your PC running sick_scan_xd. We recommend to use the same subnet as the lidar, i.e. to change the customers current ip address 224.0.0.1 to an ip address within the subnet 192.168.x.y.","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2024-05-29T13:14:40+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":2287229718,"issue_number":326,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/326","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1874842043","fragment_type":"issue_description","sequence":0,"text":"ROS2 slam test test_005_hector.launch not working\nHello,\n\nTrying to use the test_005_hector.launch with sick_nav_350 in ROS 2 Iron. It seems the launch file gets stuck after launching nav350. Communication with the nav 350 is working as it should but it does not launch hector or the rviz stuff. I've tried launching it in two different ways:\n\nros run sick_scan sick_scan_generic test_005_hector.launch\n\nAnd i've written a python wrapper so it works with:\n\nros launch sick_scan test_005.hector.launch\n\nSame result:\n[sick_generic_caller-1] [INFO] [1693461766.148262524] [sick_scan]: SickScanServices: service \"/SickScanExit\" created (\"/SickScanExit\")\n[sick_generic_caller-1] [INFO] [1693461766.148357365] [sick_scan]: SickScanServices: ros services initialized\n[sick_generic_caller-1] [INFO] [1693461766.148383347] [sick_scan]: Setup completed, sick_scan_xd is up and running. Pointcloud is published on topic \"cloud\"\n[sick_generic_caller-1] scanner_type string sick_nav_350\n[sick_generic_caller-1] slam_echo string laser_POS_000_DIST1\n[sick_generic_caller-1] slam_bundle bool true\n[sick_generic_caller-1] min_ang double -2.3998277\n[sick_generic_caller-1] max_ang double +2.3998277\n[sick_generic_caller-1] intensity_resolution_16bit bool False\n[sick_generic_caller-1] hostname string 192.168.0.1\n[sick_generic_caller-1] port string 2112\n[sick_generic_caller-1] timelimit int 5\n\nTo me it looks like the launch file is not forking the process and won't continue working through the launch file.","author_login":"zezami","author_association":"NONE","created_at":"2023-08-31T06:04:43+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1702404433","fragment_type":"issue_comment","sequence":1,"text":"I've realised that this test is for ROS 1 only. Are there any plans to add examples for ROS 2 with scan matching algoritms without the need for wheel odometry?\n\nTried the test again with ROS1, scanner, hector and rviz starts up but Global status, Pointcloud and TF are not happy. Complains about:\nGlobal status > Fixed frame > Unknown frame map\n\nPointcloud2 > Status error > Transform > For frame [cloud]: Fixed frame [map] does not exist\n\nTF: No transform from [xxxx] to frame[map]\n\nLaunch file looks like this:","author_login":"zezami","author_association":"NONE","created_at":"2023-09-01T08:54:08+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1702422692","fragment_type":"issue_comment","sequence":2,"text":"Thanks for your feedback. We will analyze hector_slam support for NAV-350 on ROS-1 and possibilities for a migration to ROS-2.","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2023-09-01T09:08:12+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1705339473","fragment_type":"issue_comment","sequence":3,"text":"Please find attached launch and rviz configuration files adapted for NAV-350 and SLAM support. Just unzip file sick_scan_xd_slam_launch.zip into folder sick_scan_xd.\n\n**NAV-350 ROS-1 SLAM example**\n\nBuild hector_slam and sick_scan_xd:\n\ncd src\ngit clone URL \ngit clone URL \ncd ..\ncatkin_make_isolated --install --cmake-args -DROS_VERSION=1 -DCMAKE_ENABLE_EMULATOR=1 -Wno-dev\n\nRun rviz, sick_scan_xd and hector_slam:\n\nsource /opt/ros/noetic/setup.bash\nsource ./devel_isolated/setup.bash\nrosrun rviz rviz -d ./src/sick_scan_xd/test/emulator/config/rviz_slam_nav350.rviz &\nroslaunch sick_scan sick_nav_350.launch hostname:=192.168.0.1 &\nroslaunch sick_scan test_200_slam_ros1_hector.launch scan_topic:=/sick_nav_350/scan &\n\nThe following rviz screenshot shows an example of a NAV-350 pointcloud created by sick_scan_xd and its map generated by hector_slam on ROS1:\nimage\n\n**NAV-350 ROS-2 SLAM example**\n\nInstall the ROS2 slam-toolbox with `sudo apt install ros-foxy-navigation2 ros-foxy-nav2-bringup ros-foxy-slam-toolbox` (replace `foxy` by your ros distribution).\n\nBuild sick_scan_xd for ROS-2 as described in INSTALL-ROS2.md\n\nRun rviz2, sick_scan_xd, slam_toolbox and static transforms:\n\nsource /opt/ros/foxy/setup.bash\nsource ./install/setup.bash\nros2 run rviz2 rviz2 -d ./src/sick_scan_xd/test/emulator/config/rviz2_slam_nav350.rviz &\nros2 launch sick_scan sick_nav_350.launch.py hostname:=192.168.0.1 &\nros2 run tf2_ros static_transform_publisher 0 0 0 0 0 0 base_link cloud &\nros2 run tf2_ros static_transform_publisher 0 0 0 0 0 0 base_footprint base_link &\nros2 run tf2_ros static_transform_publisher 0 0 0 0 0 0 odom base_footprint &\nros2 launch nav2_bringup navigation_launch.py &\nros2 launch slam_toolbox online_async_launch.py &\n\nNote: Laserscan messages need to be remapped to topic `/scan` (default is `/sick_nav_350/scan`). Use `remappings=[ ('/sick_nav_350/scan', '/scan'), ]` in the launchfile, e.g.:\n\nnode = Node(\n package='sick_scan',\n executable='sick_generic_caller',\n output='screen',\n remappings=[ ('/sick_nav_350/scan', '/scan'), ], # remap laserscan messages to topic /scan\n)\n\nThe following rviz2 screenshot shows an example of a NAV-350 laserscan created by sick_scan_xd and its map generated by slam_toolbox on ROS2:\nimage\n\nsick_scan_xd_slam_launch.zip","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2023-09-04T14:10:44+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1706407010","fragment_type":"issue_comment","sequence":4,"text":"Thank you! I will give it a try. \n\nI see that you are using slam_toolbox for ROS2 instead of Hector slam. I thought it was not possible to use slam_toolbox without wheel odometry feedback?","author_login":"zezami","author_association":"NONE","created_at":"2023-09-05T11:04:15+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1706624087","fragment_type":"issue_comment","sequence":5,"text":"You are probably right. According to URL and URL you can use URL to create an odometry feedback. But I have not tested it (it is a bit beyond the scope of the driver).\n\nNevertheless, you can use the slam_toolbox to create an initial map. In navigational mode, the NAV-350 lidar generates pose- and landmark data, which are translated to TF messages. Using these TF messages, you can see in rviz, how the lidar moves on the map.","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2023-09-05T13:28:22+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1709533237","fragment_type":"issue_comment","sequence":6,"text":"I tried the ROS 1 example but I get the following when launching hector:\n[ INFO] [1694066953.126533259]: lookupTransform base_link to cloud timed out. Could not transform laser scan into base_frame.","author_login":"zezami","author_association":"NONE","created_at":"2023-09-07T06:11:05+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1958774717","fragment_type":"issue_comment","sequence":7,"text":"Can this be done only on nav350, or can it be done on lms-1xx as well?","author_login":"erknl","author_association":"NONE","created_at":"2024-02-22T06:15:16+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1958876024","fragment_type":"issue_comment","sequence":8,"text":"@erknl I think the above \"NAV-350 ROS-2 SLAM example\" might work with humble and lms-1xx, if you swap `foxy` with `humble` and `sick_nav_350` with `sick_lms_1xx`.","author_login":"rostest","author_association":"COLLABORATOR","created_at":"2024-02-22T07:45:53+08:00","repo_name":"SICKAG/sick_scan_xd","issue_id":1874842043,"issue_number":206,"issue_url":"https://github.com/SICKAG/sick_scan_xd/issues/206","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0352","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Title does not seem to be correctly displayed anymore after updating to Nuxt 3.7?","query_context":"### Describe the bug\n\nIn a situation similar to this\n\nvue\n \n \n \n \n \n \n \n \n\n \nuseSeoMeta({\n title: () => 'Page Title',\n description: () => 'Page Description',\n ogImage: () => '/path/to/image.png',\n})\n \n\nAfter upgrading to Nuxt 3.7, the meta title does not seem to be correctly retrieved/displayed anymore.\n\nBefore the update, it was correctly `Page Title | Site Name`, while now is `| Site Name`.\n\nSeo Kit is updated to the latest version `1.3.10`\n\nPlease let me know if you need further details or info :)\n\n### Reproduction\n\n_No response_\n\n### System / Nuxt Info\n\nShell\nSystem:\n OS: Linux 6.4 openSUSE Tumbleweed 20230823\n CPU: (16) x64 AMD Ryzen 7 4800H with Radeon Graphics\n Memory: 5.22 GB / 15.03 GB\n Container: Yes\n Shell: 5.2.15 - /bin/bash\n Binaries:\n Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node\n Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn\n npm: 9.7.1 - ~/.nvm/versions/node/v16.17.0/bin/npm\n pnpm: 8.7.1 - ~/.nvm/versions/node/v16.17.0/bin/pnpm\n Browsers:\n Brave Browser: 116.1.57.53\n Chromium: 116.0.5845.96","known_context_document_ids":["gh_issue_1875967054"],"reference_answer":"Thanks for the continued effort in helping me debug this, this seems to be fixed with Unhead 1.5.1.\n\nThe issue is basically that the client-side doesn't know what the original title is but is rendering a title template.","answer_document_id":"gh_comment_1705770688","silver_evidence_path":["gh_comment_1705287541","gh_issue_1872779758","gh_comment_1705770688"],"evidence_issue_ids":[1875967054,1872779758],"source_repo_name":"harlan-zw/nuxt-seo-kit","source_issue_id":1875967054,"source_issue_number":92,"source_issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","target_repo_name":"harlan-zw/nuxt-seo-kit","target_issue_id":1872779758,"target_issue_number":87,"target_issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/87","reference_anchor_document_id":"gh_comment_1705287541","reference_answer_author":"harlan-zw","reference_answer_author_association":"OWNER","quality_score":93.94,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2222,"anchor_target_overlap":0.4444,"target_answer_overlap":0.0588},"issue_created_at":"2023-08-31T17:34:04+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1875967054","fragment_type":"issue_description","sequence":0,"text":"Title does not seem to be correctly displayed anymore after updating to Nuxt 3.7\n### Describe the bug\n\nIn a situation similar to this\n\nvue\n \n \n \n \n \n \n \n \n\n \nuseSeoMeta({\n title: () => 'Page Title',\n description: () => 'Page Description',\n ogImage: () => '/path/to/image.png',\n})\n \n\nAfter upgrading to Nuxt 3.7, the meta title does not seem to be correctly retrieved/displayed anymore.\n\nBefore the update, it was correctly `Page Title | Site Name`, while now is `| Site Name`.\n\nSeo Kit is updated to the latest version `1.3.10`\n\nPlease let me know if you need further details or info :)\n\n### Reproduction\n\n_No response_\n\n### System / Nuxt Info\n\nShell\nSystem:\n OS: Linux 6.4 openSUSE Tumbleweed 20230823\n CPU: (16) x64 AMD Ryzen 7 4800H with Radeon Graphics\n Memory: 5.22 GB / 15.03 GB\n Container: Yes\n Shell: 5.2.15 - /bin/bash\n Binaries:\n Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node\n Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn\n npm: 9.7.1 - ~/.nvm/versions/node/v16.17.0/bin/npm\n pnpm: 8.7.1 - ~/.nvm/versions/node/v16.17.0/bin/pnpm\n Browsers:\n Brave Browser: 116.1.57.53\n Chromium: 116.0.5845.96","author_login":"stefanobartoletti","author_association":"NONE","created_at":"2023-08-31T17:34:04+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1701842583","fragment_type":"issue_comment","sequence":1,"text":"Having the same issue with `nuxt-seo-kit` v1.3.10 and Nuxt 3.6.5 - the title is `null`","author_login":"DamianGlowala","author_association":"NONE","created_at":"2023-08-31T22:04:18+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1702610730","fragment_type":"issue_comment","sequence":2,"text":"Hi, can you see if you're using Unhead v1.4. `npm why unhead`, if not can you delete lock file + re-install.","author_login":"harlan-zw","author_association":"OWNER","created_at":"2023-09-01T11:37:53+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1702669991","fragment_type":"issue_comment","sequence":3,"text":"Deleted lockfile, node_modules and installed dependencies again. No luck so far.\n\n`pnpm why unhead`:\n\n@nuxt/devtools 0.8.2\n├─┬ @nuxt/devtools-kit 0.8.2\n│ └─┬ nuxt 3.6.5 peer\n│ └─┬ @unhead/vue 1.4.1\n│ └── unhead 1.4.1\n└─┬ nuxt 3.6.5 peer\n └─┬ @unhead/vue 1.4.1\n └── unhead 1.4.1\n@vueuse/nuxt 10.4.1\n└─┬ nuxt 3.6.5 peer\n └─┬ @unhead/vue 1.4.1\n └── unhead 1.4.1\nnuxt 3.6.5\n└─┬ @unhead/vue 1.4.1\n └── unhead 1.4.1\nnuxt-seo-kit 1.3.10\n├─┬ nuxt-schema-org 2.2.0\n│ └─┬ @unhead/schema-org-vue 0.6.0\n│ └─┬ @unhead/vue 1.4.1 peer\n│ └── unhead 1.4.1\n└─┬ nuxt-unhead 1.4.17\n ├─┬ @vueuse/head 1.3.1\n │ └─┬ @unhead/vue 1.4.1\n │ └── unhead 1.4.1\n └── unhead 1.4.1","author_login":"DamianGlowala","author_association":"NONE","created_at":"2023-09-01T12:29:12+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1702679910","fragment_type":"issue_comment","sequence":4,"text":"Apologies for confusion, this is working correctly on Nuxt 3.6.5! :)","author_login":"DamianGlowala","author_association":"NONE","created_at":"2023-09-01T12:37:17+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1703271104","fragment_type":"issue_comment","sequence":5,"text":"I can confirm that with nuxt `3.6.5` everything works as expected. I start to have this issue only with `3.7`","author_login":"stefanobartoletti","author_association":"NONE","created_at":"2023-09-01T20:11:25+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1703388339","fragment_type":"issue_comment","sequence":6,"text":"Can you confirm that you're upgrading using `npx nuxi upgrade --force` (should delete lock file + node_modules) and the unhead version `npm why unhead`\n\nI've tried replicating with Nuxt 3.7 and Unhead 1.4.1 and it _seems_ to be working.","author_login":"harlan-zw","author_association":"OWNER","created_at":"2023-09-01T22:28:17+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1703817296","fragment_type":"issue_comment","sequence":7,"text":"Yes, I always upgrade Nuxt with `npx nuxi upgrade --force` because it is the recommended way.\n\nThis is my unhead \n\nnpm why unhead\nunhead@1.4.1\nnode_modules/unhead\n unhead@\"^1.1.26\" from nuxt-unhead@1.4.17\n node_modules/nuxt-unhead\n nuxt-unhead@\"^1.4.17\" from nuxt-seo-kit@1.3.11\n node_modules/nuxt-seo-kit\n nuxt-seo-kit@\"^1.3.11\" from the root project\n unhead@\"1.4.1\" from @unhead/vue@1.4.1\n node_modules/@unhead/vue\n @unhead/vue@\"^1.3.7\" from nuxt@3.7.0\n node_modules/nuxt\n nuxt@\"^3.7.0\" from the root project\n peer nuxt@\"^3.6.5\" from @nuxt/devtools@0.8.2\n node_modules/@nuxt/devtools\n dev @nuxt/devtools@\"^0.8.2\" from the root project\n peer nuxt@\"^3.6.5\" from @nuxt/devtools-kit@0.8.2\n node_modules/@nuxt/devtools-kit\n @nuxt/devtools-kit@\"0.8.2\" from @nuxt/devtools@0.8.2\n node_modules/@nuxt/devtools\n dev @nuxt/devtools@\"^0.8.2\" from the root project\n peer nuxt@\"^3.0.0\" from @zadigetvoltaire/nuxt-gtm@0.0.13\n node_modules/@zadigetvoltaire/nuxt-gtm\n @zadigetvoltaire/nuxt-gtm@\"^0.0.13\" from the root project\n peer @unhead/vue@\">=1.1.9\" from @unhead/schema-org-vue@0.6.0\n node_modules/@unhead/schema-org-vue\n @unhead/schema-org-vue@\"^0.6.0\" from nuxt-schema-org@2.2.0\n node_modules/nuxt-schema-org\n nuxt-schema-org@\"^2.2.0\" from nuxt-seo-kit@1.3.11\n node_modules/nuxt-seo-kit\n nuxt-seo-kit@\"^1.3.11\" from the root project\n @unhead/vue@\"^1.3.1\" from @vueuse/head@1.3.1\n node_modules/@vueuse/head\n @vueuse/head@\"^1.1.26\" from nuxt-unhead@1.4.17\n node_modules/nuxt-unhead\n nuxt-unhead@\"^1.4.17\" from nuxt-seo-kit@1.3.11\n node_modules/nuxt-seo-kit\n nuxt-seo-kit@\"^1.3.11\" from the root project\n\nAnd the problems is still here :/\n\nPlease let me know if I have to provide more info","author_login":"stefanobartoletti","author_association":"NONE","created_at":"2023-09-02T12:19:41+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1705287541","fragment_type":"issue_comment","sequence":8,"text":"Here is a reproduction for `v2.0.0-beta.24` and nuxt `3.7.0`: URL \nI think it's the same issue or very related.","author_login":"dargmuesli","author_association":"CONTRIBUTOR","created_at":"2023-09-04T13:35:26+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[1872779758],"is_known_query_context":false},{"document_id":"gh_comment_1705770829","fragment_type":"issue_comment","sequence":9,"text":"Fixed with Unhead 1.5.1 hopefully :pray: \n\nThanks for the issue!","author_login":"harlan-zw","author_association":"OWNER","created_at":"2023-09-04T23:43:18+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1713810712","fragment_type":"issue_comment","sequence":10,"text":"I updated everything, but the problem is still there, at least for me.\n\nMaybe there is something wrong with my specific configuration, but I still have this issue with nuxt `3.7.1`. unhead `1.6.2` and nuxt-seo-kit `1.3.13`","author_login":"stefanobartoletti","author_association":"NONE","created_at":"2023-09-11T12:47:47+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1755027357","fragment_type":"issue_comment","sequence":11,"text":"I solved this by upgrading nuxt-seo-kit to @nuxtseo/module.\n\nIt does not really solve the issue per-se, but with the new module the problem is no longer there.","author_login":"stefanobartoletti","author_association":"NONE","created_at":"2023-10-10T10:52:04+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1755657964","fragment_type":"issue_comment","sequence":12,"text":"Thanks for confirming, will close for now as the v2 is my main focus at the moment.","author_login":"harlan-zw","author_association":"OWNER","created_at":"2023-10-10T15:11:37+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1875967054,"issue_number":92,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/92","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1872779758","fragment_type":"issue_description","sequence":0,"text":"html `lang` goes `undefined` :walking:\n### Describe the bug\n\nWhen adding `@nuxtseo/module` AND using `useServerHeadSafe` to set the html's language, the language goes `undefined` in client side hydration :walking: \n\nUsing `useHeadSafe` instead \"fixes\" the issue, removing `@nuxtseo/module` form the module array does too.\n\nI would not expect this behavior. Am I doing something wrong or is this a good bug report? :smile: \n\n### Reproduction\n\n URL \n\n### System / Nuxt Info\n\nShell\n------------------------------\n- Operating System: Linux\n- Node Version: v16.20.0\n- Nuxt Version: 3.7.0\n- CLI Version: 3.7.2\n- Nitro Version: 2.6.2\n- Package Manager: npm@9.4.2\n- Builder: -\n- User Config: modules\n- Runtime Modules: @nuxtseo/module@2.0.0-beta.19\n- Build Modules: -\n------------------------------","author_login":"dargmuesli","author_association":"CONTRIBUTOR","created_at":"2023-08-30T02:30:49+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1872779758,"issue_number":87,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/87","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1699723602","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the issue, looks to be fixed :) URL \n\n(also the nuxt-og-image bug)","author_login":"harlan-zw","author_association":"OWNER","created_at":"2023-08-30T19:31:42+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1872779758,"issue_number":87,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/87","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1699975705","fragment_type":"issue_comment","sequence":2,"text":"Hmm, what about the `title`? It becomes `null` on client hydration if it's set using `useServerHeadSafe`: URL \nUsing `useHeadSafe` keeps the title intact.","author_login":"dargmuesli","author_association":"CONTRIBUTOR","created_at":"2023-08-30T23:18:05+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1872779758,"issue_number":87,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/87","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1705770688","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the continued effort in helping me debug this, this seems to be fixed with Unhead 1.5.1.\n\nThe issue is basically that the client-side doesn't know what the original title is but is rendering a title template.","author_login":"harlan-zw","author_association":"OWNER","created_at":"2023-09-04T23:42:52+08:00","repo_name":"harlan-zw/nuxt-seo-kit","issue_id":1872779758,"issue_number":87,"issue_url":"https://github.com/harlan-zw/nuxt-seo-kit/issues/87","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0353","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Extend unit of measure symbol predicates to things other than units of measure?","query_context":"Currently we have three symbol-related datatype properties with domain `UnitOfMeasure`:\n\nunitSymbol\nunitSymbolHtml # as of 10.0.0\nunitSymbolUnicode\n\nThe proposal is to extend the predicates to apply to anything, since things other than units of measure may have symbols, such as chemical compounds (this could have been relevant to one of my past clients). Thus:\n\nsymbol\nsymbolHtml\nsymbolUnicode\n\nand modify `skos:definition` accordingly. We can include `domainIncludes gist:UnitOfMeasure` to indicate that one usage pertains to units of measure.","known_context_document_ids":["gh_issue_971808580"],"reference_answer":"Assigning to @Jamie-SA for review. If he approves, he can either implement or pass on to someone else.","answer_document_id":"gh_comment_1892863623","silver_evidence_path":["gh_comment_1782944179","gh_issue_1963897769","gh_comment_1892863623"],"evidence_issue_ids":[971808580,1963897769],"source_repo_name":"semanticarts/gist","source_issue_id":971808580,"source_issue_number":531,"source_issue_url":"https://github.com/semanticarts/gist/issues/531","target_repo_name":"semanticarts/gist","target_issue_id":1963897769,"target_issue_number":992,"target_issue_url":"https://github.com/semanticarts/gist/issues/992","reference_anchor_document_id":"gh_comment_1782944179","reference_answer_author":"rjyounes","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2308,"anchor_target_overlap":0.1538,"target_answer_overlap":0.0},"issue_created_at":"2021-08-16T14:39:38+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_971808580","fragment_type":"issue_description","sequence":0,"text":"Extend unit of measure symbol predicates to things other than units of measure\nCurrently we have three symbol-related datatype properties with domain `UnitOfMeasure`:\n\nunitSymbol\nunitSymbolHtml # as of 10.0.0\nunitSymbolUnicode\n\nThe proposal is to extend the predicates to apply to anything, since things other than units of measure may have symbols, such as chemical compounds (this could have been relevant to one of my past clients). Thus:\n\nsymbol\nsymbolHtml\nsymbolUnicode\n\nand modify `skos:definition` accordingly. We can include `domainIncludes gist:UnitOfMeasure` to indicate that one usage pertains to units of measure.","author_login":"rjyounes","author_association":"COLLABORATOR","created_at":"2021-08-16T14:39:38+08:00","repo_name":"semanticarts/gist","issue_id":971808580,"issue_number":531,"issue_url":"https://github.com/semanticarts/gist/issues/531","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1781547645","fragment_type":"issue_comment","sequence":1,"text":"If we decided to do this, why did we just create #992 \nSee also #959, #579","author_login":"uscholdm","author_association":"CONTRIBUTOR","created_at":"2023-10-26T17:32:43+08:00","repo_name":"semanticarts/gist","issue_id":971808580,"issue_number":531,"issue_url":"https://github.com/semanticarts/gist/issues/531","linked_issue_ids":[1963897769],"is_known_query_context":false},{"document_id":"gh_comment_1782944179","fragment_type":"issue_comment","sequence":2,"text":"I see the confusion. #992 should be entitled \"Deprecate `gist:symbolHtml` and `gist:symbolUnicode` once the names have been changed in this issue. I'll clarify that.","author_login":"rjyounes","author_association":"COLLABORATOR","created_at":"2023-10-27T13:43:04+08:00","repo_name":"semanticarts/gist","issue_id":971808580,"issue_number":531,"issue_url":"https://github.com/semanticarts/gist/issues/531","linked_issue_ids":[1963897769],"is_known_query_context":false},{"document_id":"gh_issue_1963897769","fragment_type":"issue_description","sequence":0,"text":"Remove symbolUnicode and symbolHtml? (post-531 implementation)\nNote: these predicates do not currently exist, but will exist after the implementation of issue #531. #531 involves renaming to make them applicable to things other than units. This is about whether we need the HTML and Unicode versions of the symbol predicate.","author_login":"rjyounes","author_association":"COLLABORATOR","created_at":"2023-10-26T16:09:27+08:00","repo_name":"semanticarts/gist","issue_id":1963897769,"issue_number":992,"issue_url":"https://github.com/semanticarts/gist/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1781538770","fragment_type":"issue_comment","sequence":1,"text":"I thought we agreed to keep Html and Unicode versions based on what @Jamie-SA said about the likelihood of using them in the foreseeable future. See #531 and #959.","author_login":"uscholdm","author_association":"CONTRIBUTOR","created_at":"2023-10-26T17:26:08+08:00","repo_name":"semanticarts/gist","issue_id":1963897769,"issue_number":992,"issue_url":"https://github.com/semanticarts/gist/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1782951058","fragment_type":"issue_comment","sequence":2,"text":"I didn't think we reached a conclusion on this. There is the possibility of implementing them in the SA ontology. It depends on whether we consider the need for them broad enough to include in gist.","author_login":"rjyounes","author_association":"COLLABORATOR","created_at":"2023-10-27T13:47:43+08:00","repo_name":"semanticarts/gist","issue_id":1963897769,"issue_number":992,"issue_url":"https://github.com/semanticarts/gist/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1887548476","fragment_type":"issue_comment","sequence":3,"text":"Recommendation: Move HTML/Unicode to SA ontology, remove from core. Verify with @Jamie-SA","author_login":"sa-bpelakh","author_association":"CONTRIBUTOR","created_at":"2024-01-11T16:39:52+08:00","repo_name":"semanticarts/gist","issue_id":1963897769,"issue_number":992,"issue_url":"https://github.com/semanticarts/gist/issues/992","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1892863623","fragment_type":"issue_comment","sequence":4,"text":"Assigning to @Jamie-SA for review. If he approves, he can either implement or pass on to someone else.","author_login":"rjyounes","author_association":"COLLABORATOR","created_at":"2024-01-15T23:18:20+08:00","repo_name":"semanticarts/gist","issue_id":1963897769,"issue_number":992,"issue_url":"https://github.com/semanticarts/gist/issues/992","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0354","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: Recently Added - Random album order?","query_context":"### I confirm that:\n\n- [x] I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered\n- [x] I'm using the latest version (your issue may have been fixed already)\n\n### Version\n\n0.55.0 (365df522)\n\n### Current Behavior\n\nWhen visiting \"Recently Added\" albums are placed in random order, with no seemingly good reason. I have checked music files (timestamps) and their content and nothing has changed since yesterdays Navidrome update. It affects all albums. Have run \"Full scan\" and \"Quick scan\".\n\n### Expected Behavior\n\nWhen visiting \"Recently Added\" newly added album should be shown in descending order, as it has always been.\n\n### Steps To Reproduce\n\n1. Log into Navidrome\n2. Visit Recently Added (does this automatically upon login)\n3. Random album sorting.\n\n### Environment\n\nmarkdown\n- OS: Debian 12.9 (6.1.0-31-amd64) / Docker version 28.0.1, build 068a01e\n- Browser: Brave \n- Client: play:Sub\n\n### How Navidrome is installed?\n\nDocker\n\n### Configuration\n\ntoml\nservices:\n navidrome:\n container_name: navidrome\n hostname: navidrome\n networks:\n prxnet:\n ipv4_address: 172.30.1.22\n user: 304:304\n volumes:\n - /mnt/ssd/music/sorted:/music:ro\n - ./data:/data\n - /etc/localtime:/etc/localtime:ro\n env_file:\n - container.env\n restart: unless-stopped\n pull_policy: always\n image: deluan/navidrome:latest\n healthcheck:\n interval: 5m\n start_period: 1m\n\nnetworks:\n prxnet:\n external: true\n\n### Relevant log output\n\nshell\n\n### Anything else?\n\n_No response_\n\n### Code of Conduct\n\n- [x] I agree to follow Navidrome's Code of Conduct","known_context_document_ids":["gh_issue_2919892298"],"reference_answer":"This is only possible if your FS supports birth time. If you are using Linux, use `stat` to check that. You should see a line saying `Birth`\n\nExample of FS that does support it:\n\n$ stat docker-compose.yml\n File: docker-compose.yml\n Size: 484 Blocks: 8 IO Block: 4096 regular file\nDevice: 254,1 Inode: 750 Links: 1\nAccess: (0644/-rw-r--r--) Uid: ( 1000/corintio) Gid: ( 1000/corintio)\nAccess: 2024-12-21 15:06:32.012000000 -0800\nModify: 2024-11-24 11:03:32.700000000 -0800\nChange: 2024-11-24 11:03:32.820000000 -0800\n Birth: 2024-11-24 10:34:49.188000000 -0800\n\nIf it is supported, set `RecentlyAddedByModTime=false`. If not, there's nothing I can do about it, and the option will fallback to using the time the file was added to the DB.","answer_document_id":"gh_comment_2560595788","silver_evidence_path":["gh_comment_2726034790","gh_issue_2005547238","gh_comment_2560595788"],"evidence_issue_ids":[2919892298,2005547238],"source_repo_name":"navidrome/navidrome","source_issue_id":2919892298,"source_issue_number":3823,"source_issue_url":"https://github.com/navidrome/navidrome/issues/3823","target_repo_name":"navidrome/navidrome","target_issue_id":2005547238,"target_issue_number":2650,"target_issue_url":"https://github.com/navidrome/navidrome/issues/2650","reference_anchor_document_id":"gh_comment_2726034790","reference_answer_author":"deluan","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.2667,"target_answer_overlap":0.175},"issue_created_at":"2025-03-14T10:57:38+08:00","valid_comment_count":26,"fragments":[{"document_id":"gh_issue_2919892298","fragment_type":"issue_description","sequence":0,"text":"[Bug]: Recently Added - Random album order\n### I confirm that:\n\n- [x] I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered\n- [x] I'm using the latest version (your issue may have been fixed already)\n\n### Version\n\n0.55.0 (365df522)\n\n### Current Behavior\n\nWhen visiting \"Recently Added\" albums are placed in random order, with no seemingly good reason. I have checked music files (timestamps) and their content and nothing has changed since yesterdays Navidrome update. It affects all albums. Have run \"Full scan\" and \"Quick scan\".\n\n### Expected Behavior\n\nWhen visiting \"Recently Added\" newly added album should be shown in descending order, as it has always been.\n\n### Steps To Reproduce\n\n1. Log into Navidrome\n2. Visit Recently Added (does this automatically upon login)\n3. Random album sorting.\n\n### Environment\n\nmarkdown\n- OS: Debian 12.9 (6.1.0-31-amd64) / Docker version 28.0.1, build 068a01e\n- Browser: Brave \n- Client: play:Sub\n\n### How Navidrome is installed?\n\nDocker\n\n### Configuration\n\ntoml\nservices:\n navidrome:\n container_name: navidrome\n hostname: navidrome\n networks:\n prxnet:\n ipv4_address: 172.30.1.22\n user: 304:304\n volumes:\n - /mnt/ssd/music/sorted:/music:ro\n - ./data:/data\n - /etc/localtime:/etc/localtime:ro\n env_file:\n - container.env\n restart: unless-stopped\n pull_policy: always\n image: deluan/navidrome:latest\n healthcheck:\n interval: 5m\n start_period: 1m\n\nnetworks:\n prxnet:\n external: true\n\n### Relevant log output\n\nshell\n\n### Anything else?\n\n_No response_\n\n### Code of Conduct\n\n- [x] I agree to follow Navidrome's Code of Conduct","author_login":"benlenau","author_association":"NONE","created_at":"2025-03-14T10:57:38+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2725791194","fragment_type":"issue_comment","sequence":1,"text":"i have also lost my \"recently added\" order since the 0.55 upgrade.","author_login":"anarcat","author_association":"NONE","created_at":"2025-03-14T21:15:04+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2725804992","fragment_type":"issue_comment","sequence":2,"text":"What is the value of `RecentlyAddedByModTime` config option?\n\n- `false` (default): Albums will be sorted by `created_at` date, which is the oldest `birthtime` of the song files in the album. If your system does not support `birthtime`, it is the time it was imported to the library\n- `true`: will use the newest `updated_at` (`mtime`) from the song files in the album.\n\nThis logic had a slightly different from previous versions, which could cause these \"movements\" in upgraded libraries. \n\nSorry for the inconvenience, but it was necessary due to the internal changes in the scanner/db model. Didn't anticipate it would be a \"breaking\" change.","author_login":"deluan","author_association":"MEMBER","created_at":"2025-03-14T21:22:43+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2726034790","fragment_type":"issue_comment","sequence":3,"text":"i have `ND_RECENTLYADDEDBYMODTIME: \"false\"` in my docker-compose file, since: URL \n\ni am now pretty confused. i don't understand why the BFR refactoring changed this at all.","author_login":"anarcat","author_association":"NONE","created_at":"2025-03-15T00:04:24+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[2005547238],"is_known_query_context":false},{"document_id":"gh_comment_2726043961","fragment_type":"issue_comment","sequence":4,"text":"I had to admit that my library also suffered some movements, about 30 random albums came to the top of Recently Added, and I didn't investigated in deep.\n\nIf this is a big issue for you, please open a new GH issue and we can discuss there, as this one was about the `RecentlyAddedByModTime` option, it seems.","author_login":"deluan","author_association":"MEMBER","created_at":"2025-03-15T00:14:11+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2732582930","fragment_type":"issue_comment","sequence":5,"text":"I can also confirm that adding \"ND_RECENTLYADDEDBYMODTIME=1\" to my Docker config solved the issue for me too!!","author_login":"Phil-BKK","author_association":"NONE","created_at":"2025-03-18T10:29:48+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2785622839","fragment_type":"issue_comment","sequence":6,"text":"0.55.2 I believe RecentlyAddedByModTime = true fixed the same issue for me as well","author_login":"tomerrr","author_association":"NONE","created_at":"2025-04-08T08:18:23+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2799017370","fragment_type":"issue_comment","sequence":7,"text":"I had to do the same, otherwise things seemed to be vaguely sorted by Artist Name in descending alphabetical order. Adding new albums did not result in them appearing at the top.","author_login":"InvisibleFunction","author_association":"NONE","created_at":"2025-04-12T19:52:30+08:00","repo_name":"navidrome/navidrome","issue_id":2919892298,"issue_number":3823,"issue_url":"https://github.com/navidrome/navidrome/issues/3823","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2005547238","fragment_type":"issue_description","sequence":0,"text":"[Bug]: Recently Added shouldn't rely on Update but Create timestamp\n### I confirm that:\n\n- [X] I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered\n- [X] I'm using the latest version (your issue may have been fixed already)\n\n### Version\n\n0.50.1\n\n### Current Behavior\n\nModifications to (say) an album cover brings said album back into the top of the \"Recently Added\" queue, even though it might be an old album.\n\n### Expected Behavior\n\nInstead, \"Recently Added\" should only rely on the creation (or import?) date of the file that's being processed.\n\n### Steps To Reproduce\n\n 1. import two albums in Navidrome, with file timestamps far enough apart to make them sortable\n 2. modify the old one by, say, adding an album cover\n\nExpected result: the newer album before step 2 should still show up as the newest.\n\nActual result: modified album bumps the newer album.\n\n### Environment\n\nmarkdown\n- OS: Debian GNU/Linux bookworm, Docker container\n- Browser: Firefox ESR, but irrelevant\n- Client: Supersonic or web\n\n### How Navidrome is installed?\n\nDocker\n\n### Configuration\n\ntoml\n---\n# managed by Puppet, local changes will be lost\nversion: \"3\"\n\nvolumes:\n navidrome-data:\n\nservices:\n navidrome:\n image: deluan/navidrome:latest\n user: 10000:10000 # should be owner of volumes\n ports:\n - \"127.0.0.1:4533:4533\"\n restart: unless-stopped\n environment:\n ND_SCANSCHEDULE: 1h\n ND_LOGLEVEL: info\n ND_SESSIONTIMEOUT: 24h\n ND_BASEURL: \"\"\n ND_RECENTLYADDEDBYMODTIME: \"true\"\n ND_LASTFM_ENABLED: \"false\"\n ND_AUTOIMPORTPLAYLISTS: \"false\"\n ND_ENABLESHARING: \"true\"\n volumes:\n - \"navidrome-data:/data\"\n - \"/srv/mp3:/music/mp3:ro\"\n\n### Relevant log output\n\nshell\nI perused the logs and didn't find much interesting, so I do not believe that is relevant.\n\n### Anything else?\n\nAt first I thought this was because Navidrome only held a single timestamp for albums, but after inspecting the sqlite database (after fear of losing my ratings and play counts, which I *think* i did?), I noticed there was a `created_at` AND `updated_at` column, so that data is actually there, just not used correctly, I believe.\n\nBut here's two albums from the database that are sorted, IMHO, backwards:\n\nsqlite> select name,artist,created_at,updated_at from album where name like '%American III: Solitary%';\nAmerican III: Solitary Man|Johnny Cash|2021-07-04T00:51:17.930079536Z|2023-03-09T22:58:57.431454258Z\nsqlite> select name,artist,created_at,updated_at from album where name like '%Vertiges%';\nVertiges|zouz|2022-06-01T20:11:36.78922778Z|2022-06-01T19:44:39.486551366Z\n\nThere, \"Johnny Cash\" gets sorted first, as more \"Recently Added\" than \"zouz\".\n\nNow of course, one fix to this is to run an SQL query updating my entire database to wipe off the differnet `update_at` timestamps, or at least tweak the ones that are incorrect, but that seems like shoving a problem under the rug...\n\nBesides, maybe we *could* have a Recently Updated view as well? That would be interesting, listing the albums that have a different `created_at` and `updated_at` timestamp! :) Unfortunately, it looks like all those timestamps differ here, sometimes by only a few seconds...\n\n### Code of Conduct\n\n- [X] I agree to follow Navidrome's Code of Conduct","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-22T04:22:13+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1822099547","fragment_type":"issue_comment","sequence":1,"text":"In my case, the workaround was relatively simple: I added a *lot* (350+) of covers all at once, in a short timeframe, so I could rewrite the `update_at` fields on those relatively easily with this query:\n\nUPDATE album SET updated_at = created_at WHERE updated_at > '2023-03-06' AND updated_at < '2023-03-10' AND created_at < '2023-03-01';\n\nBut of course, if I fix an old cover again, that poor old album is going to come back up the list and try to play with the young kids and everyone is going to look at him sideways and think \"ok boomer\" and release a barely hidden sigh that will just make everyone really uncomfortable...","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-22T04:31:52+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1822197302","fragment_type":"issue_comment","sequence":2,"text":"You have set ND_RECENTLYADDEDBYMODTIME to true which is not what you want from what your description reads.\n\n URL \n\nThe functionality you describe is implemented with #2553 as long as you dont Set ND_RECENTLYADDEDBYMODTIME (default is False)","author_login":"metalheim","author_association":"CONTRIBUTOR","created_at":"2023-11-22T06:40:58+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1822930471","fragment_type":"issue_comment","sequence":3,"text":"Hmm... well that setting doesn't do what I thought it did though: I thought that would set the `created_at` field on import, but from what you seem to be saying here, it influences how the albums are *displayed*?\n\nthe `created_at` fields are correctly set here, just to be really clear.","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-22T14:58:30+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823228114","fragment_type":"issue_comment","sequence":4,"text":"That's correct. It is used for controlling how to display the Recent Added Albums view.","author_login":"deluan","author_association":"MEMBER","created_at":"2023-11-22T17:52:53+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823253522","fragment_type":"issue_comment","sequence":5,"text":"okay, so couldn't this be made in reverse, like at import time, if that setting is on, use the file mtime as the `created_at` field instead of `updated_at`? for me this thing is completely setup backwards, but maybe that's just me. :)","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-22T18:13:09+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823717148","fragment_type":"issue_comment","sequence":6,"text":"I think the fields should be used for what they mean: `created_at` for when the file was created/first imported (see #1350), and `updated_at` for when was the last time the record was changed in the DB. Inverting these two can cause confusion when maintaining the codebase, and it is just a matter of displaying sorted by one or the other, with no need to change their semantics.\n\nAlso, making this distinction at scan time, means that if you want to change it, Navidrome needs to rescan everything again - with a full scan - which can take days sometimes for some large libraries.","author_login":"deluan","author_association":"MEMBER","created_at":"2023-11-23T01:19:14+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823724335","fragment_type":"issue_comment","sequence":7,"text":"i see. so what are my options here?\n\ni guess i could remap the `created_at` timestamp to `updated_at` if the latter is lower? would that work?","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-23T01:34:17+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823728932","fragment_type":"issue_comment","sequence":8,"text":"That should be the behaviour if you remove `ND_RECENTLYADDEDBYMODTIME: \"true\"`. The default behaviour (`false`) is to use import date (or birth date as per #1350)","author_login":"deluan","author_association":"MEMBER","created_at":"2023-11-23T01:44:17+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823734389","fragment_type":"issue_comment","sequence":9,"text":"okay well maybe that's where my confusion comes from: I thought `ND_RECENTLYADDEDBYMODTIME` was a feature flag that enabled the \"birth date used on import\" defined in #1350 - those two are actually unrelated?","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-23T01:53:23+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1823748408","fragment_type":"issue_comment","sequence":10,"text":"No it is not!\n\n`ND_RECENTLYADDEDBYMODTIME` selects whether to use `created_at` (false, default) or `updated_at` (true) for sorting the Recently Added albums view. This was implemented by #822 a couple of years ago.\n\n#1350 (fixed by #2553) was released in 0.50.0, which replaces import date with birth date, on systems that support it, as that's a sensible thing to do (use the actual file creation date instead of the import date)","author_login":"deluan","author_association":"MEMBER","created_at":"2023-11-23T02:22:23+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1828238198","fragment_type":"issue_comment","sequence":11,"text":"Ookay... I completely misread this! thanks for the clarification...\n\nis there a way to *rescan* files so that their creation date is retrofitted back into the `created_at` field?","author_login":"anarcat","author_association":"NONE","created_at":"2023-11-27T16:51:29+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1828342200","fragment_type":"issue_comment","sequence":12,"text":"Try a full rescan. If that doesn't work, there's no other option except for re-adding all your files, which currently will make you lose your playlists and favourites/ratings/play counts :/","author_login":"deluan","author_association":"MEMBER","created_at":"2023-11-27T17:56:01+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1834472573","fragment_type":"issue_comment","sequence":13,"text":"i noticed to that if the song already has a `created_at` timestamp, a full rescan will not refresh it with the file creation date.","author_login":"certuna","author_association":"CONTRIBUTOR","created_at":"2023-11-30T20:10:01+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2460977804","fragment_type":"issue_comment","sequence":14,"text":"Closing as this is not an issue, and making the full rescan reimport all timestamps is being handled in #2709","author_login":"deluan","author_association":"MEMBER","created_at":"2024-11-06T23:11:25+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2466440951","fragment_type":"issue_comment","sequence":15,"text":"I'm actually going to reopen this and we can close it once #2709 is merged and officially released. That way the author can get notified of the fix being available.","author_login":"Szeraax","author_association":"COLLABORATOR","created_at":"2024-11-09T20:11:11+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2536411020","fragment_type":"issue_comment","sequence":16,"text":"@deluan If I create a track outside of the knowledge of Navidrome, and then, say, a year later I finally get around to adding it to Navidrome's \"field of view\", the album of that track does _not_ appear in the Recently Added Albums list. This is because Navidrome is looking at the date of creation of the track, not the date at which the album suddenly appeared in the music library. This is seems wrong. An album should be regarded as recently created if the album was recently added to the database; it should have nothing to do with how old or new the _tracks_ are. — I make this comment here because it seems to be part of the same discussion, but I'll be happy to open it as a separate issue if you prefer. Thx.","author_login":"mattneub","author_association":"NONE","created_at":"2024-12-11T16:04:16+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2536532334","fragment_type":"issue_comment","sequence":17,"text":"@mattneub What you want is the default behaviour, with `RecentlyAddedByModTime=false`. Did you change this option?","author_login":"deluan","author_association":"MEMBER","created_at":"2024-12-11T16:49:09+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2547349486","fragment_type":"issue_comment","sequence":18,"text":"@deluan - I am looking for the exact opposite behavior. I got confused with all the configuration options so I will ask you instead. What are the correct settings for navidrome to consider recently added as when the file itself (not import) was created (and not updated, only created)? \n\nWhenever I change tags on the music files themselves they appear as recently added with my current configuration.\n\nThank you","author_login":"oransterf","author_association":"NONE","created_at":"2024-12-17T02:10:30+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2560595788","fragment_type":"issue_comment","sequence":19,"text":"This is only possible if your FS supports birth time. If you are using Linux, use `stat` to check that. You should see a line saying `Birth`\n\nExample of FS that does support it:\n\n$ stat docker-compose.yml\n File: docker-compose.yml\n Size: 484 Blocks: 8 IO Block: 4096 regular file\nDevice: 254,1 Inode: 750 Links: 1\nAccess: (0644/-rw-r--r--) Uid: ( 1000/corintio) Gid: ( 1000/corintio)\nAccess: 2024-12-21 15:06:32.012000000 -0800\nModify: 2024-11-24 11:03:32.700000000 -0800\nChange: 2024-11-24 11:03:32.820000000 -0800\n Birth: 2024-11-24 10:34:49.188000000 -0800\n\nIf it is supported, set `RecentlyAddedByModTime=false`. If not, there's nothing I can do about it, and the option will fallback to using the time the file was added to the DB.","author_login":"deluan","author_association":"MEMBER","created_at":"2024-12-24T03:35:02+08:00","repo_name":"navidrome/navidrome","issue_id":2005547238,"issue_number":2650,"issue_url":"https://github.com/navidrome/navidrome/issues/2650","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0355","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Feature request Add some placeholders?","query_context":"### What feature would you like to request?\n\nAdd some placeholders,such as the team name,team prefix\n\n### Are you able to help implement the feature?\n\n_No response_\n\n### Is your feature request related to an existing bug or issue?\n\n_No response_\n\n### Please enter any additional comments below.\n\n_No response_","known_context_document_ids":["gh_issue_2793501806"],"reference_answer":"It's out now in the latest snapshot, but it is disabled by default. To enable it set the `extended-toggle` value in Essence's configuration (it's in the teleportation section) to `true`.\n\nAs of this version /tptoggle toggles both, but I might change that to /tptoggle in the future. I'll update the Wiki and drop a message here if that's the case.\n\nDownload: URL \nWiki: URL \n\nWhilst this is a snapshot build it is tested and considered stable. However, as always I recommend backing up your server first. This version also contains #201","answer_document_id":"gh_comment_2888933328","silver_evidence_path":["gh_comment_2888979112","gh_issue_3071280202","gh_comment_2888933328"],"evidence_issue_ids":[2793501806,3071280202],"source_repo_name":"LewMC/Essence","source_issue_id":2793501806,"source_issue_number":187,"source_issue_url":"https://github.com/LewMC/Essence/issues/187","target_repo_name":"LewMC/Essence","target_issue_id":3071280202,"target_issue_number":200,"target_issue_url":"https://github.com/LewMC/Essence/issues/200","reference_anchor_document_id":"gh_comment_2888979112","reference_answer_author":"lewmilburn","reference_answer_author_association":"MEMBER","quality_score":92.28,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2174,"anchor_target_overlap":0.4898,"target_answer_overlap":0.0256},"issue_created_at":"2025-01-16T18:46:36+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2793501806","fragment_type":"issue_description","sequence":0,"text":"Feature request Add some placeholders\n### What feature would you like to request?\n\nAdd some placeholders,such as the team name,team prefix\n\n### Are you able to help implement the feature?\n\n_No response_\n\n### Is your feature request related to an existing bug or issue?\n\n_No response_\n\n### Please enter any additional comments below.\n\n_No response_","author_login":"Tomorin114514","author_association":"NONE","created_at":"2025-01-16T18:46:36+08:00","repo_name":"LewMC/Essence","issue_id":2793501806,"issue_number":187,"issue_url":"https://github.com/LewMC/Essence/issues/187","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2887098934","fragment_type":"issue_comment","sequence":1,"text":"Hi, does this refer to the placeholders we use in MOTDs and join/leave messages ( URL or placeholderAPI placeholders?","author_login":"lewmilburn","author_association":"MEMBER","created_at":"2025-05-16T15:49:00+08:00","repo_name":"LewMC/Essence","issue_id":2793501806,"issue_number":187,"issue_url":"https://github.com/LewMC/Essence/issues/187","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2888979112","fragment_type":"issue_comment","sequence":2,"text":"Team placeholders are out now in the latest snapshot alongside some other changes to placeholders, I'd highly recommend reading the linked Wiki page first. Essence doesn't currently provide team prefixes but I'm working on that so I'll leave this issue open for now.\n\nDownload: URL \nWiki: URL \n\nWhilst this is a snapshot build it is tested and considered stable. However, as always I recommend backing up your server first. This version also contains URL and URL \n\nPlease note that due to changes in how placeholders work once you upgrade to 1.9.0 you cannot downgrade to a previous version.","author_login":"lewmilburn","author_association":"MEMBER","created_at":"2025-05-18T13:04:49+08:00","repo_name":"LewMC/Essence","issue_id":2793501806,"issue_number":187,"issue_url":"https://github.com/LewMC/Essence/issues/187","linked_issue_ids":[3071280202],"is_known_query_context":false},{"document_id":"gh_comment_2889029310","fragment_type":"issue_comment","sequence":3,"text":"A basic version of team prefixes is now available as well: URL","author_login":"lewmilburn","author_association":"MEMBER","created_at":"2025-05-18T14:42:32+08:00","repo_name":"LewMC/Essence","issue_id":2793501806,"issue_number":187,"issue_url":"https://github.com/LewMC/Essence/issues/187","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3071280202","fragment_type":"issue_description","sequence":0,"text":"[Feature Request] Allow players to disable others teleporting to them via /tp\n### What feature would you like to request?\n\nIt would be great if /tptoggle applied to /tp as well, so that other players who have access to `/tp` cannot teleport to them. Obviously OPs/Admins with perms can bypass this and teleport regardless.\n\nThis would likely just be an extension of `/tptoggle`, to include `/tp` itself in addition to `/tpa`.\n\nUnsure if final syntax should still just be `/tptoggle` to toggle `/tpa` + `/tp`, or if there should be the ability to toggle `/tpa` and `/tp` individually, i.e. `/tptoggle tpa`.\n\n### Are you able to help implement the feature?\n\nUnfortunately not; Maybe I'll be more familiar with Essences codebase (and Paper plugins in general) in the future tho :D\n\n### Is your feature request related to an existing bug or issue?\n\nNo\n\n### Please enter any additional comments below.\n\n_No response_","author_login":"KadTheHunter","author_association":"NONE","created_at":"2025-05-18T02:04:35+08:00","repo_name":"LewMC/Essence","issue_id":3071280202,"issue_number":200,"issue_url":"https://github.com/LewMC/Essence/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2888907855","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the request! I'm working on this now. I've decided to make this a configurable feature that is off by default, so you'll need to enable it for it to work. I'll have a wiki page setup with a guide once it's tested & a snapshot build is out.","author_login":"lewmilburn","author_association":"MEMBER","created_at":"2025-05-18T10:25:30+08:00","repo_name":"LewMC/Essence","issue_id":3071280202,"issue_number":200,"issue_url":"https://github.com/LewMC/Essence/issues/200","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2888933328","fragment_type":"issue_comment","sequence":2,"text":"It's out now in the latest snapshot, but it is disabled by default. To enable it set the `extended-toggle` value in Essence's configuration (it's in the teleportation section) to `true`.\n\nAs of this version /tptoggle toggles both, but I might change that to /tptoggle in the future. I'll update the Wiki and drop a message here if that's the case.\n\nDownload: URL \nWiki: URL \n\nWhilst this is a snapshot build it is tested and considered stable. However, as always I recommend backing up your server first. This version also contains #201","author_login":"lewmilburn","author_association":"MEMBER","created_at":"2025-05-18T11:25:49+08:00","repo_name":"LewMC/Essence","issue_id":3071280202,"issue_number":200,"issue_url":"https://github.com/LewMC/Essence/issues/200","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0357","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"simulations stopping with assert currentTimes.simTime <= simTime()?","query_context":"All the simulations are failing with this error on the latest code. \ngradys-error\n\nThe simulations were working in an old version which was part of the pre-created VM (OVA file). But none of the showcase ini files are working in the latest version. I have changed the paths for ArduCopter/ArduPlane/ArduRover in ini file to appropriate values and the SITL processes are running in the background.","known_context_document_ids":["gh_issue_2114749797"],"reference_answer":"@klonikar hello! I am also having trouble setting up GrADyS-SIM with OMNeT++ 6 on Windows. While I haven't quite figured out the root cause yet, I have created a new .ova virtual machine image in case you want to use it: URL \n\nI saw that you also got the same idea as me of setting the simulator up on a Linux virtual machine, that's great! If you have any trouble, try the .ova image above and see if that helps.\n\nAlso, replied to you on your other issue about the SITL integration.","answer_document_id":"gh_comment_1925578543","silver_evidence_path":["gh_comment_1929358542","gh_issue_2097474488","gh_comment_1925578543"],"evidence_issue_ids":[2114749797,2097474488],"source_repo_name":"Project-GrADyS/gradys-simulations","source_issue_id":2114749797,"source_issue_number":32,"source_issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","target_repo_name":"Project-GrADyS/gradys-simulations","target_issue_id":2097474488,"target_issue_number":31,"target_issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","reference_anchor_document_id":"gh_comment_1929358542","reference_answer_author":"Thlamz","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.1778,"target_answer_overlap":0.15},"issue_created_at":"2024-02-02T11:44:44+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2114749797","fragment_type":"issue_description","sequence":0,"text":"simulations stopping with assert currentTimes.simTime <= simTime()\nAll the simulations are failing with this error on the latest code. \ngradys-error\n\nThe simulations were working in an old version which was part of the pre-created VM (OVA file). But none of the showcase ini files are working in the latest version. I have changed the paths for ArduCopter/ArduPlane/ArduRover in ini file to appropriate values and the SITL processes are running in the background.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-02T11:44:44+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1925577801","fragment_type":"issue_comment","sequence":1,"text":"Hello, thanks for using the project, and sorry for the slow response! \n\nThis 'currentTimes.simTime <= simTime()' error happens when the \"RealTimeScheduler\" can't keep up with real time. The scheduler is the OMNeT++ class responsible for dispatching events in the correct timings, the RealTimeScheduler provided by INED dispatches these messages to try to keep the simulation synched with real time. When the simulation is too slow (could be too many vehicles, computer resources, overhead from the virtual machine, etc.) the scheduler raises these exceptions. \n\nAn easy workaround is to simply remove the RealTimeScheduler, it should be on your .ini file with the key \"scheduler-class\". Removing this loses you the guarantee that your simulation will be synched with real time. You can still get pretty good results by manually controlling the simulation speed to approximate real time. If being precisely in synch with real time isn't one of your requirements, I would highly suggest this solution. If you do want to keep things synchronized, I'm afraid you will have to opt for a lighter simulated scenario\n\nI was never able to figure out the exact mechanism that causes this assertion to fail. I highly suspect it's some implementation detail of the RealTimeScheduler class that I just never figured out. If I ever do, I will make sure to include a patched version of the class with the simulator. If you find a solution or the root-problem, please share it with us!\n\nAlso, I made a new .ova file to use with the new version of the simulator, that should help you with the setup if you are having trouble with that: URL","author_login":"Thlamz","author_association":"COLLABORATOR","created_at":"2024-02-04T04:33:29+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925850611","fragment_type":"issue_comment","sequence":2,"text":"Thanks for responding. I will try out the removing the RealTimeScheduler. At this time, real timeness is not a strict requirement for me. I do not know why is it not able to keep up with real time even when trying it on a quite powerful linux machine and the default ini file **showcases/sitl/simple_simulation/omnetpp.ini** config **SimpleSitl** config which has `*.numUAVs = 2`.\nIf I find a workaround/solution, I will certainly share.\n\nDo I need to replace the RealTimeScheduler with something else or simply remove/comment the line?","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-04T17:34:18+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1926535896","fragment_type":"issue_comment","sequence":3,"text":"The simulations are working now after commenting out the RealTimeSimulator line. Among the 4 sitl showcases (gradys-simulations -> showcases -> sitl), 3 are working. The simple_simulation (SimpleSitl of ini file) starts but the vehicle does not move. I changed the waypoints file also but there is no movement. I think the logic in DroneMobilityMav::readWaypointsFromFile in DroneMobilityMav.cc may have something to do with it. Your if-else statements are processing GOTO, TAKEOFF, RETURN_LAUNCH commands but the file has only GOTO and REVERSE commands. In this function, you are not calling queueMessage like you do in MAVLinkFileMobility::readMissionFromFile and MAVLinkFileMobility::startMission.\n\nThe file mission.waypoints for file_mobility_simulation has more command types.\n\nI am not that familiar with omnet++ so I could not dig further.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-05T09:18:28+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1928954859","fragment_type":"issue_comment","sequence":4,"text":"@Thlamz your OVA is ubuntu 20.04 and all the simulations are working with RealTimeScheduler enabled. Can you briefly describe your changes?\n\nI see that your omnet++ is also built with OSG, OSGEarth but map imagery is not visible. Possibly that makes a difference as CPU does not have to render it.\n\nEven the **SimpleSitl** is working (I only changed the paths to point to ArduCopter.elf and param files): The two quad vehicles properly go to sensor[0] and sensor[1] and return.\n\nThe only differences I see are ubuntu 20.04, python 3.8 instead of 3.11 and the git branch th-fixes instead of main... Even after shifting to main branch, SimpleSitl works. I am not clear why does it fail in my environment.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-06T07:51:56+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929358542","fragment_type":"issue_comment","sequence":5,"text":"@klonikar I only changed configuration and build stuff. The main things I remember:\n- Some of the paths set in Paths and Symbols were absolute and invalid on my machine, so I changed them to the proper ones\n- I added the -lpython3.8 flag to get the python integration to work. \n- Changed the protocol path for all modules that used the python integration\n- Changed the .elf and param file paths for all modules that used the SITL integration\n- The python sample in the showcases folder was completely broken, it's still a bit broken but at least it opens now, the python files were completely missing in the repository\n\nYou can see the full changes on PR #33. It's still being reviewed, which is why I didn't merge it yet.\n\nI chose Ubuntu 20.04 because I always had trouble installing OSG on Ubuntu 22.04, which I think you yourself described here: URL \n\nThe map imagery really is not visible, even though I saw no visible errors. I am sure that with this same installation using python 5.6.2 the map imagery used to show. Since it was only visual I didn't investigate further, assumed it was just an incompatibility between OMNeT 6 and the OSG libraries. Your comment that it worked on Ubuntu 22.04 left me curious, I'll try to investigate further.","author_login":"Thlamz","author_association":"COLLABORATOR","created_at":"2024-02-06T11:52:22+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[2097474488],"is_known_query_context":false},{"document_id":"gh_comment_1929430815","fragment_type":"issue_comment","sequence":6,"text":"@klonikar fixed it and reuploaded the images! You can download the new one here. In case you don't want to redownload the image, the fix was very simple, just set the environment variable MESA_GL_VERSION_OVERRIDE=3.3.","author_login":"Thlamz","author_association":"COLLABORATOR","created_at":"2024-02-06T12:32:20+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929443960","fragment_type":"issue_comment","sequence":7,"text":"That was quick 👍 \nI wasn't really complaining about the imagery not there... Rather, I thought the SimpleSitl worked because imagery was not there!! Thanks.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-06T12:40:29+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1929451590","fragment_type":"issue_comment","sequence":8,"text":"Thanks for the detailed reply. There is nothing in the PR that will solve the problem for SimpleSITL and also the RealTimeScheduler... Its only some added python files and change to use python 3.8 which is default for ubuntu 20.04.\n\nThis leaves me to wonder why does it work in your OVA but not in my real ubuntu 20.04 machine or the 22.04 OVA.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-06T12:44:46+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[2097474488],"is_known_query_context":false},{"document_id":"gh_comment_1931803540","fragment_type":"issue_comment","sequence":9,"text":"@Thlamz I think I found out the reason for RealTimeScheduler not working. When I changed the build type to debug (for both gradys-simulations and inet4.5) in your OVA VM, I always get the simTime() error. When I change it back to release build, I dont get it.\n\nThen I created a brand new ubuntu 20.04 VM, installed all the required packages as given in omnet++ InstallGuide.pdf, including osg, osgearth. Changed the configure.user to enable osgearth, built the osgearth, inet4.5 in release mode... finally built the gradys-simulations in release mode and launched SimpleSitl.\n\nI will close this issue unless you have something to add.\n\nimage","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-07T11:03:25+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1932018336","fragment_type":"issue_comment","sequence":10,"text":"@klonikar Nothing to add! OMNeT does tend to run much slower in debug mode, so what you said makes complete sense.","author_login":"Thlamz","author_association":"COLLABORATOR","created_at":"2024-02-07T13:09:34+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2114749797,"issue_number":32,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2097474488","fragment_type":"issue_description","sequence":0,"text":"Windows build with OMNET++ 6.0.2 throws error Class gradys_simulations::MobileNode not found\nI managed to build on windows using mingw64 (not WSL) on **OMNET++ 6.0.2** and when running any of the showcases from within OMNET IDE, I get the following error:\nimage\n\nI checked the size of the executable `out/gcc-release/src/gradys_simulations_build.exe`. Its only 100KB. The MobileNode.cc has the following code:\n\nRegister_Class(MobileNode);\n//Define_Module(MobileNode);\n\nIf this file was part of the .exe, it should have been executed. It appears that the .o files created for any of the .cc in src are not linked.\n\nI have followed your instructions on URL for running outside the docker. I also tried to run the executable from cmd line like below:\n\n`gradys-simulations/showcases$ ../out/gcc-release/src/gradys_simulations_build.exe sitl/simple_simulation/omnetpp.ini\n`\n\nBut this gives the following error:\nimage\n\nAnother thing I found was that 3 executables are created as follows:\n\nout/gcc-release/gradys_simulations_build.exe\nout/gcc-release/src/gradys_simulations_build.exe\nout/gcc-release/src/pybind11_json/gradys_simulations.exe\n\nI assume that the one in `out/gcc-release/src/gradys_simulations_build.exe` is the one to be executed for showcases. But that too does not work.","author_login":"klonikar","author_association":"NONE","created_at":"2024-01-24T05:48:31+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2097474488,"issue_number":31,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1920563616","fragment_type":"issue_comment","sequence":1,"text":"I was able to build on virtualbox based ubuntu 22.04. It needs openscenegraph 3.4.1 and osgearth 2.9.0. Follow directions on URL for Linux build but use GL2 instead of GL3:\n\ngit clone URL \ncd OpenSceneGraph\ngit checkout OpenSceneGraph-3.4.1 # ==> this is new\nmkdir build && cd build\ncmake .. -DOPENGL_PROFILE=GL2 -DOSG_GL_CONTEXT_VERSION=4.6 # GL2 instead of GL3\nmake -j8\nsudo make install\ncd ..\ngit clone URL \ncd draco\nmkdir build && cd build\ncmake .. -DCMAKE_CXX_FLAGS=-fPIC\nmake -j8\nsudo make install\ncd ..\ngit clone URL \ncd osgearth\ngit checkout osgearth-2.9 # ==> this is new\nmkdir build && cd build\ncmake .. -DOSGEARTH_ENABLE_FASTDXT=OFF\nmake -j8\nsudo make install\n\nThen in config.user of omnetpp, change `WITH_OSGEARTH=no` to `WITH_OSGEARTH=yes` and build omnetpp using `./configure` and `make`.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-01T05:51:12+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2097474488,"issue_number":31,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1921184232","fragment_type":"issue_comment","sequence":2,"text":"That sounds great! \n\nWhat do you think about do a PR do create a new dockfile for Ubuntu 22.04?","author_login":"brunoolivieri","author_association":"COLLABORATOR","created_at":"2024-02-01T12:10:03+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2097474488,"issue_number":31,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1924425887","fragment_type":"issue_comment","sequence":3,"text":"By the way, the build is successful but when running any showcase, I get an error \"simulations stopping with assert currentTimes.simTime <= simTime()\". I have created a separate issue for this.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-02T18:06:53+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2097474488,"issue_number":31,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925578543","fragment_type":"issue_comment","sequence":4,"text":"@klonikar hello! I am also having trouble setting up GrADyS-SIM with OMNeT++ 6 on Windows. While I haven't quite figured out the root cause yet, I have created a new .ova virtual machine image in case you want to use it: URL \n\nI saw that you also got the same idea as me of setting the simulator up on a Linux virtual machine, that's great! If you have any trouble, try the .ova image above and see if that helps.\n\nAlso, replied to you on your other issue about the SITL integration.","author_login":"Thlamz","author_association":"COLLABORATOR","created_at":"2024-02-04T04:39:00+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2097474488,"issue_number":31,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925847509","fragment_type":"issue_comment","sequence":5,"text":"Thanks. I will try out your .ova VM, though now I also have a virtualbox VM where gradys is built. I kind of gave up widows, and went ahead with VM. I think the first root cause is that the Makemake is not generating a proper Makefile to build the gradys related sources into obj files. When I hand modified the Makefile to build it, I am getting several \"undefined symbol\" errors for symbols in inet lib as well for winsock lib.\n\nld.lld: error: undefined symbol: inet::ClockUserModuleMixin ::exponential(inet::ClockTime, int) const\nld.lld: error: undefined symbol: __declspec(dllimport) WSAStartup\nld.lld: error: undefined symbol: __declspec(dllimport) socket\n\nWe need to add more `-l` options to the linker cmd line. But not sure how to fix the issue for building gradys sources.\n\nI also have a linux machine where the build works fine but I get the simTime error.","author_login":"klonikar","author_association":"NONE","created_at":"2024-02-04T17:22:38+08:00","repo_name":"Project-GrADyS/gradys-simulations","issue_id":2097474488,"issue_number":31,"issue_url":"https://github.com/Project-GrADyS/gradys-simulations/issues/31","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0358","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"DeclareStrictTypesFixer split?","query_context":"So far, we have a (risky) fixer that adds/relocate `declare(strict_types=1)`.\n\nI think we should split it.\n1. fixer to add `declare` statement if missing (risky)\n2. fixer to relocate declaration (non-risky) - here, with option what should be the position (same line with opening tag or next one).\n\nWe will be more generic and allow to have better user experience, like allowing to move declaration to same place for all files but not enforcing adding it to every single file. Or allow to place the declaration to place defined by `Extended Coding Style Guide` proposal.\n\nAlso, a ref: URL","known_context_document_ids":["gh_issue_164638946"],"reference_answer":"Hey! I'm closing this as no traffic around anymore. The idea could be valid, yet it didn't get any movement around.\nIf any of you see a value in it and are ready to implement it, please draft mini-RFC what you would like to achieve and how.","answer_document_id":"gh_comment_1492512388","silver_evidence_path":["gh_comment_1330826946","gh_issue_397768023","gh_comment_1492512388"],"evidence_issue_ids":[164638946,397768023],"source_repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","source_issue_id":164638946,"source_issue_number":2062,"source_issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","target_repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","target_issue_id":397768023,"target_issue_number":4252,"target_issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","reference_anchor_document_id":"gh_comment_1330826946","reference_answer_author":"keradus","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2963,"anchor_target_overlap":0.2593,"target_answer_overlap":0.1364},"issue_created_at":"2016-07-09T00:17:04+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_164638946","fragment_type":"issue_description","sequence":0,"text":"DeclareStrictTypesFixer split\nSo far, we have a (risky) fixer that adds/relocate `declare(strict_types=1)`.\n\nI think we should split it.\n1. fixer to add `declare` statement if missing (risky)\n2. fixer to relocate declaration (non-risky) - here, with option what should be the position (same line with opening tag or next one).\n\nWe will be more generic and allow to have better user experience, like allowing to move declaration to same place for all files but not enforcing adding it to every single file. Or allow to place the declaration to place defined by `Extended Coding Style Guide` proposal.\n\nAlso, a ref: URL","author_login":"keradus","author_association":"MEMBER","created_at":"2016-07-09T00:17:04+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1310490475","fragment_type":"issue_comment","sequence":1,"text":"Is there any progress so far? I'd really like to make my files look like:\n`<?php declare(strict_types=1);`\nand so fixer wont move declare statement anywhere.","author_login":"Arkemlar","author_association":"NONE","created_at":"2022-11-10T15:46:16+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1310858494","fragment_type":"issue_comment","sequence":2,"text":"@Arkemlar , no, as ppl were not finding this important enough. Feel free to raise the PR proposal.\n\n@kubawerlos , if you have anything ready, I encourage to open a PR","author_login":"keradus","author_association":"MEMBER","created_at":"2022-11-10T20:30:25+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1311316947","fragment_type":"issue_comment","sequence":3,"text":"@keradus it only does half of point 2, so not really ready :)","author_login":"kubawerlos","author_association":"MEMBER","created_at":"2022-11-11T07:18:05+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1313235270","fragment_type":"issue_comment","sequence":4,"text":"When making any changes to the way `declare` is handled, it would be awesome when the rule would **not** be applied to Interfaces as a `declare` doesn't make any sense in an interface.\n\nSee note at URL","author_login":"heiglandreas","author_association":"NONE","created_at":"2022-11-14T07:58:13+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1320938844","fragment_type":"issue_comment","sequence":5,"text":"@heiglandreas Thanks for the suggestion! I opened #6688 as it can be implemented separately.","author_login":"julienfalque","author_association":"MEMBER","created_at":"2022-11-19T18:15:42+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1330826946","fragment_type":"issue_comment","sequence":6,"text":"If someone needs just only feature of having `declare(strict_types=1)` on same line as php opening tag:\n`<?php declare(strict_types=1)`\nThen look at this one URL \nAnd at the bottom you will find a link to URL that has `DeclareAfterOpeningTagFixer` rule beside other useful rules. It solves my need just fine.","author_login":"Arkemlar","author_association":"NONE","created_at":"2022-11-29T15:28:24+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[397768023],"is_known_query_context":false},{"document_id":"gh_comment_1399226419","fragment_type":"issue_comment","sequence":7,"text":"@heiglandreas can you help me a bit? I've seen that note you have copied from URL \n \n \n \n\nand got surprised because I thought it is not how strict types are working.\n\nSo I've tried to do it myself at URL and cannot make it work the way it is - at least with my understanding - described in the note. What am I doing wrong?","author_login":"kubawerlos","author_association":"MEMBER","created_at":"2023-01-21T10:44:41+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1399281180","fragment_type":"issue_comment","sequence":8,"text":"Thanks for bringing that up.\n\nAnd I have no good explanation for that issue that you are scetching out. Perhaps that is something for the bugtracker of the php-src.\n\nThe reason why I brought up that citation though was because the `declare_strict` is only relevant within files that actually **call** other functions. As an interface does - by definition - only **defines** function-signatures and **never** calls other functions, a `declare(stict_types)` is always unnecessary in an interface-file.","author_login":"heiglandreas","author_association":"NONE","created_at":"2023-01-21T16:14:44+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1719111560","fragment_type":"issue_comment","sequence":9,"text":"Just for the record: in #7053 we added ability to place namespace declaration in the same line as `<?php` or to enforce it in consequent lines. Probably we need similar flexibility for `declare()` 🙂.","author_login":"Wirone","author_association":"COLLABORATOR","created_at":"2023-09-14T09:42:07+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":164638946,"issue_number":2062,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2062","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_397768023","fragment_type":"issue_description","sequence":0,"text":"Declare after PHP Opening Tag\nUsing 2.14 I'm looking for a fixer that takes care of moving the `declare(...)` statement right after the `<?php` opening tag (and one space in front).\n\n<?php delcare(strict_types=1);\n\n \n\nI imagined it would already exists so I was searching for it but after doing so my assumption grows it does not yet.\n\nSo I'd like to ask if there is anything like that in existence incl. preparation first of all, I see a lot of potential related issues as well so I can imagine this is perhaps a rule to apply PHP-CS-Fixer can not apply a working strategy across all rules, so any kind of feedback is welcome.","author_login":"ktomk","author_association":"CONTRIBUTOR","created_at":"2019-01-10T10:36:12+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_462043434","fragment_type":"issue_comment","sequence":1,"text":"I would love that as well.\n\nSo, the rule should not allow it for anything *except* `declare()`.\n\nThat is currently not possible:\n\n* `true` -> `declare()` is in next line\n* `false` -> anything else can be on the same line","author_login":"apfelbox","author_association":"NONE","created_at":"2019-02-09T13:11:16+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_462116499","fragment_type":"issue_comment","sequence":2,"text":"Speaking of rules and which configuration they could (theoretically have), this is my own mental model representation:\n~~~\n'blank_line_after_opening_tag' => 'true_unless_declare_which_is_forced_in_first_line_with_single_space_if_in_use',\n/* commented out by intention 'declare_strict_types' => true, */\n~~~\n\nImportant part here is that `declare_strict_types` should be independent to this setting, I use strict types in some files, but in some other files I do not and this is not a per directory rule or so, but just differs between files.","author_login":"ktomk","author_association":"NONE","created_at":"2019-02-10T09:18:22+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_549178167","fragment_type":"issue_comment","sequence":3,"text":"@apfelbox You still have interest for this one? And re-reading your suggestion somehow looks pretty viable in a rule on it's own. If other declare related rules are done beforehand (as we can say there should be none), your suggestion should be non-conflicting and it's perhaps possible to implement it.","author_login":"ktomk","author_association":"CONTRIBUTOR","created_at":"2019-11-03T21:01:41+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_711100176","fragment_type":"issue_comment","sequence":4,"text":"I don't know about @apfelbox but as someone who has to review the strictification of a PHP app I sure would enjoy standardizing the `declare` on these files.","author_login":"a666","author_association":"NONE","created_at":"2020-10-18T00:51:27+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_759777590","fragment_type":"issue_comment","sequence":5,"text":"Is this (question / problem) still a thing?\nRequired the declare statement in a project with many (~6.000) existing files.\nHad to play around with some parameters.\n\nBut in the end this setup did the job for me ... the declare statement on the first line.\n\n$config = PhpCsFixer\\Config::create()\n ->setRiskyAllowed(true)\n ->setUsingCache(false)\n ->setRules([\n '@Symfony' => true,\n '@PSR2' => true,\n '@PhpCsFixer' => true,\n\n 'declare_strict_types' => true,\n 'linebreak_after_opening_tag' => false,\n 'blank_line_after_opening_tag' => false,\n ...","author_login":"mvoelker","author_association":"NONE","created_at":"2021-01-13T22:26:12+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_759911762","fragment_type":"issue_comment","sequence":6,"text":"Those three last lines are those we use for enforcement.\n\nThey do solve the situation somewhat, but currently we have a lot of files with divergent declarations:\n\nphp\n<?php declare(strict_types=1);\n\nphp\n<?php\ndeclare(strict_types=1);\n\nor even\n\nphp\n<?php\ndeclare(encoding='SJIS');\ndeclare(strict_types=1);","author_login":"a666","author_association":"NONE","created_at":"2021-01-14T04:05:56+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_776815261","fragment_type":"issue_comment","sequence":7,"text":"The problem is, that here it only ensures the existing line break (or not). It does not ensure, that there is no line break. So when you already have a line break here, it won't get removed. Probably this requires a new rule which ensures declare on same line as <?php opening tag.","author_login":"a-r-m-i-n","author_association":"NONE","created_at":"2021-02-10T16:01:38+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_984015580","fragment_type":"issue_comment","sequence":8,"text":"Hello\n\nIf you still search for this rule, just found URL \n\nNot tested..","author_login":"cavo789","author_association":"NONE","created_at":"2021-12-01T20:10:17+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1492512388","fragment_type":"issue_comment","sequence":9,"text":"Hey! I'm closing this as no traffic around anymore. The idea could be valid, yet it didn't get any movement around.\nIf any of you see a value in it and are ready to implement it, please draft mini-RFC what you would like to achieve and how.","author_login":"keradus","author_association":"MEMBER","created_at":"2023-03-31T19:48:31+08:00","repo_name":"PHP-CS-Fixer/PHP-CS-Fixer","issue_id":397768023,"issue_number":4252,"issue_url":"https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/4252","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0361","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"`let` indexes using noUncheckedIndexedAccess in TS 5.5.2?","query_context":"### 🔎 Search Terms\n\n\"array\", \"noUncheckedIndexedAccess\", \"5.5\"\n\n### 🕗 Version & Regression Information\n\n- This changed between versions 5.4.5 and 5.5.2\n\n### ⏯ Playground Link\n\n URL \n\n### 💻 Code\n\nts\nconst a: number[] = [1, 2, 3];\nlet i: number = 1;\n\nif(typeof a[i] === \"number\")\n a[i]++\n\n### 🙁 Actual behavior\n\nTypescript reports the following error:\n\nObject is possibly 'undefined'.(2532)\nconst a: number[]\n\n### 🙂 Expected behavior\n\nIt should not report an error for such cases\n\n### Additional information about the issue\n\nThis obviously requires `noUncheckedIndexedAccess` to be enabled in the tsconfig.\n\nThis only happens when the variable used to access the array is non const (`let` in this case).\n\nI think that TS 5.5 actually fixed the original behavior because in 5.4 if we remove the check:\n\nts\nconst a: number[] = [1, 2, 3];\nlet i: number = 1;\na[i]++\n\nTS does not raise the same error (which would be expected as `a[i]` could be undefined).\nThe current workaround:\n\nts\nconst j = i;\nif (typeof digits[j] === \"number\") {\n digits[j]++;\n}","known_context_document_ids":["gh_issue_2367744540"],"reference_answer":"If this is just an array, I don't see why you need `crypto-js` as part of the repro. Please provide a minimal example, with config, that shows what's happening","answer_document_id":"gh_comment_2168659231","silver_evidence_path":["gh_comment_2184974540","gh_issue_2340975470","gh_comment_2168659231"],"evidence_issue_ids":[2367744540,2340975470],"source_repo_name":"microsoft/TypeScript","source_issue_id":2367744540,"source_issue_number":58972,"source_issue_url":"https://github.com/microsoft/TypeScript/issues/58972","target_repo_name":"microsoft/TypeScript","target_issue_id":2340975470,"target_issue_number":58803,"target_issue_url":"https://github.com/microsoft/TypeScript/issues/58803","reference_anchor_document_id":"gh_comment_2184974540","reference_answer_author":"RyanCavanaugh","reference_answer_author_association":"MEMBER","quality_score":83.8,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.16,"anchor_target_overlap":0.04,"target_answer_overlap":0.1429},"issue_created_at":"2024-06-22T11:04:44+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2367744540","fragment_type":"issue_description","sequence":0,"text":"`let` indexes using noUncheckedIndexedAccess in TS 5.5.2\n### 🔎 Search Terms\n\n\"array\", \"noUncheckedIndexedAccess\", \"5.5\"\n\n### 🕗 Version & Regression Information\n\n- This changed between versions 5.4.5 and 5.5.2\n\n### ⏯ Playground Link\n\n URL \n\n### 💻 Code\n\nts\nconst a: number[] = [1, 2, 3];\nlet i: number = 1;\n\nif(typeof a[i] === \"number\")\n a[i]++\n\n### 🙁 Actual behavior\n\nTypescript reports the following error:\n\nObject is possibly 'undefined'.(2532)\nconst a: number[]\n\n### 🙂 Expected behavior\n\nIt should not report an error for such cases\n\n### Additional information about the issue\n\nThis obviously requires `noUncheckedIndexedAccess` to be enabled in the tsconfig.\n\nThis only happens when the variable used to access the array is non const (`let` in this case).\n\nI think that TS 5.5 actually fixed the original behavior because in 5.4 if we remove the check:\n\nts\nconst a: number[] = [1, 2, 3];\nlet i: number = 1;\na[i]++\n\nTS does not raise the same error (which would be expected as `a[i]` could be undefined).\nThe current workaround:\n\nts\nconst j = i;\nif (typeof digits[j] === \"number\") {\n digits[j]++;\n}","author_login":"ex0ns","author_association":"NONE","created_at":"2024-06-22T11:04:44+08:00","repo_name":"microsoft/TypeScript","issue_id":2367744540,"issue_number":58972,"issue_url":"https://github.com/microsoft/TypeScript/issues/58972","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2184126250","fragment_type":"issue_comment","sequence":1,"text":"See: URL \n\nAnd also the PR: #57847\n\nThis intentionally is only working for constant-like variables.","author_login":"MartinJohns","author_association":"CONTRIBUTOR","created_at":"2024-06-22T17:45:41+08:00","repo_name":"microsoft/TypeScript","issue_id":2367744540,"issue_number":58972,"issue_url":"https://github.com/microsoft/TypeScript/issues/58972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2184156051","fragment_type":"issue_comment","sequence":2,"text":"Heh, this is a fun one... in a sense this is surprising. TS thinks `i` is global here. If we just add `export {}` to the end of this file then it works like expected: TS playground\n\nEven though it doesn't exactly look like it... this feels like a duplicate of URL . Obviously, this repro is wildly different from the other one but the implementation source of the problem is very likely the same","author_login":"Andarist","author_association":"CONTRIBUTOR","created_at":"2024-06-22T19:00:05+08:00","repo_name":"microsoft/TypeScript","issue_id":2367744540,"issue_number":58972,"issue_url":"https://github.com/microsoft/TypeScript/issues/58972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2184919765","fragment_type":"issue_comment","sequence":3,"text":"This is working as intended. We specifically exclude global variables from assignment analysis as the control flow analyzer can't see all references (there might be references in other files). Adding an `export {}` limits the scope to the current file at which point CFA can determinate the location of the last assignment and treat the variable as `const` for the remained of the file.","author_login":"ahejlsberg","author_association":"MEMBER","created_at":"2024-06-23T09:35:34+08:00","repo_name":"microsoft/TypeScript","issue_id":2367744540,"issue_number":58972,"issue_url":"https://github.com/microsoft/TypeScript/issues/58972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2184923244","fragment_type":"issue_comment","sequence":4,"text":"Thanks, for the clarifications, I was simply surprised because the behavior in a very \"hello world\" code is now a bit confusing for non-experienced people:\n\nts\nfunction goThroughArray() {\n const a: number[] = [1, 2, 3];\n for(let i = 0; i < a.length; i++) {\n if (typeof a[i] === \"number\") {\n a[i]++; // a[i] can be undefined\n }\n }\n}\n\nWhich is not exactly the reproducer I have send in the original issue, as I was trying to narrow this down.\n\nHowever given that the compiler can't know if `i` was modified in the loop or not, I guess it's the best we can do for now.","author_login":"ex0ns","author_association":"NONE","created_at":"2024-06-23T09:47:49+08:00","repo_name":"microsoft/TypeScript","issue_id":2367744540,"issue_number":58972,"issue_url":"https://github.com/microsoft/TypeScript/issues/58972","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2184974540","fragment_type":"issue_comment","sequence":5,"text":"Ah, shoot. I forgot that those are still global variables (even if not available on `globalThis`) and can leak across scripts 😢 \n \n\nThis would be a duplicate of URL . CFA graph walk could likely check if an assignment happens between those 2 points but that could cost some perf.","author_login":"Andarist","author_association":"CONTRIBUTOR","created_at":"2024-06-23T12:42:56+08:00","repo_name":"microsoft/TypeScript","issue_id":2367744540,"issue_number":58972,"issue_url":"https://github.com/microsoft/TypeScript/issues/58972","linked_issue_ids":[2340975470],"is_known_query_context":false},{"document_id":"gh_issue_2340975470","fragment_type":"issue_description","sequence":0,"text":"Narrowing for constant indexed access fails on array getter\n### 🔎 Search Terms\n\nconstant indexed access, array\n\n### 🕗 Version & Regression Information\n\n- This changed between versions `5.4.5` and `5.5.beta`\n- This changed in commit or PR\n\n### ⏯ Playground Link\n_I could not repro this in playground, due to the lib import_ \n\n### 💻 Code\n\nts\nimport crypto from 'crypto-js'\n\nconst bar = \"abc\"\nconst foo: crypto.lib.WordArray = crypto.enc.Utf8.parse(bar) // Returns type: { words: number[], ... }\nfor (let i = 0; i \n}\n\nAdding suitable checks in the loop-body for falsey values does _not_ fix it, eg:\n\nts\nif (foo && foo.words && foo.words[i]) {\n // Same code as above, same error\n}\n\nHowever the following _does_ fix it:\n\nts\nconst word = foo.words[i]\nif (word) {\n foo.words[i] = word + 1 // OK\n}\n\n### 🙁 Actual behavior\n\nerror TS2532: Object is possibly 'undefined'.\n\n### 🙂 Expected behavior\n\nNo error - this type-checked fine previously\n\n### Additional information about the issue\n\nThis issue is new since the new `Control Flow Narrowing for Constant Indexed Accesses` feature. Rolling back to the previous typescript version 'fixes' it","author_login":"grant-d","author_association":"NONE","created_at":"2024-06-07T18:34:49+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2155831647","fragment_type":"issue_comment","sequence":1,"text":"You can often import npm packages in the playground just fine. It's capable of fetching their types. \n\nI don't see any error here with the nightly version: TS playground. `foo.words` has `number[]` type so I'm not sure how `undefined` has crawled into all of this in your tests. Perhaps you are using `noUncheckedIndexedAccess`?\n\nThis would indeed show the difference in the behavior:\nTS 5.4\nTS nightly\n\nThis, in turn, looks like a correctness improvement.","author_login":"Andarist","author_association":"CONTRIBUTOR","created_at":"2024-06-08T06:14:43+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2168659231","fragment_type":"issue_comment","sequence":2,"text":"If this is just an array, I don't see why you need `crypto-js` as part of the repro. Please provide a minimal example, with config, that shows what's happening","author_login":"RyanCavanaugh","author_association":"MEMBER","created_at":"2024-06-14T19:47:01+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170849201","fragment_type":"issue_comment","sequence":3,"text":"@RyanCavanaugh yes I am aware of that, but I was unable to find a repro without the package.\n\n@Andarist I think you nailed it - thanks so much, that must be the issue. Not sure what the action is here, I am closing but please re-open as necessary.","author_login":"grant-d","author_association":"NONE","created_at":"2024-06-15T21:12:12+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2181658607","fragment_type":"issue_comment","sequence":4,"text":"@RyanCavanaugh here is a minimal repro in TS Playground (based on @Andarist repro)\n\nIncluding code here for ease of understanding:\n\ntypescript\n// @noUncheckedIndexedAccess: true\ninterface Foo { words: number[] }\nconst foo: Foo = { words: [1, 2, 3] }\n\nfor (let i = 0; i < foo.words.length; i++) {\n if (foo.words[i]) {\n foo.words[i] = foo.words[i] + 1\n // ^Object is possibly 'undefined'.(2532)^\n }\n}\n\n<img width=\"530\" alt=\"image\" src=\" URL","author_login":"grant-d","author_association":"NONE","created_at":"2024-06-20T22:32:44+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2181674316","fragment_type":"issue_comment","sequence":5,"text":"The problem here is that `i` is assigned to so it doesn't pass this check: \n URL \n\n`i` is special in loops. We know that it's only assigned to after this loop block. So perhaps some extra fine-tuning for this case would be possible.","author_login":"Andarist","author_association":"CONTRIBUTOR","created_at":"2024-06-20T22:51:21+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2182194499","fragment_type":"issue_comment","sequence":6,"text":"Oh, this just never works for variables that are reassigned:\n\nts\nfunction f1(obj: Record ) {\n let key: string = \"\";\n if (typeof obj[key] === \"string\") {\n obj[key].toUpperCase();\n }\n key = \"\"; // toggle to see the error to go away and come back\n}\n\nThis is kinda spooky to see an error pop up on a previous line that seemingly has no real correlation with the line that just got added.","author_login":"Andarist","author_association":"CONTRIBUTOR","created_at":"2024-06-21T07:45:40+08:00","repo_name":"microsoft/TypeScript","issue_id":2340975470,"issue_number":58803,"issue_url":"https://github.com/microsoft/TypeScript/issues/58803","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0362","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Improvement: Update the `URL` database model?","query_context":"Do the following to improve the definition of the `URL` database model.\n\n- [x] 1. Rename it. A good choice to rename to is `DatasetURL`\n- [x] 2. Remove any field that is no longer needed. For example, `update_announced` can be remove once all the code for the V1 API is removed.\n- [x] 3. Rename some of the fields to make them more informative. For example, `info_ts` can be renamed to `last_update`.\n\nNote: The fulfillment of this issue should be done after the removal of V1 API and support of SQLAlchemy in put in place.","known_context_document_ids":["gh_issue_1753969026"],"reference_answer":"I am aware of this. Last time I checked, the logic in handling update was not fully implemented. The idea of using a central dispatcher with an dedicated queue I mentioned today should solve the problem, but I may use a more expedient solution for now.","answer_document_id":"gh_comment_1449310849","silver_evidence_path":["gh_comment_1613430901","gh_issue_1604148441","gh_comment_1449310849"],"evidence_issue_ids":[1753969026,1604148441],"source_repo_name":"datalad/datalad-registry","source_issue_id":1753969026,"source_issue_number":186,"source_issue_url":"https://github.com/datalad/datalad-registry/issues/186","target_repo_name":"datalad/datalad-registry","target_issue_id":1604148441,"target_issue_number":112,"target_issue_url":"https://github.com/datalad/datalad-registry/issues/112","reference_anchor_document_id":"gh_comment_1613430901","reference_answer_author":"candleindark","reference_answer_author_association":"COLLABORATOR","quality_score":94.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1364,"anchor_target_overlap":0.0909,"target_answer_overlap":0.087},"issue_created_at":"2023-06-13T03:37:06+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1753969026","fragment_type":"issue_description","sequence":0,"text":"Improvement: Update the `URL` database model\nDo the following to improve the definition of the `URL` database model.\n\n- [x] 1. Rename it. A good choice to rename to is `DatasetURL`\n- [x] 2. Remove any field that is no longer needed. For example, `update_announced` can be remove once all the code for the V1 API is removed.\n- [x] 3. Rename some of the fields to make them more informative. For example, `info_ts` can be renamed to `last_update`.\n\nNote: The fulfillment of this issue should be done after the removal of V1 API and support of SQLAlchemy in put in place.","author_login":"candleindark","author_association":"COLLABORATOR","created_at":"2023-06-13T03:37:06+08:00","repo_name":"datalad/datalad-registry","issue_id":1753969026,"issue_number":186,"issue_url":"https://github.com/datalad/datalad-registry/issues/186","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1613430901","fragment_type":"issue_comment","sequence":1,"text":"2 and 3 are pretty much outlined in the changes to the model needed to implement proper (cron or triggered) updates as in URL . Either URL model gets renamed - I don't care much but indeed smth like `RepoUrl` (I think we deal only with datasets ATM but could be regular git repos without UUID I guess in the future) would be more appropriate but not critical to rename, but could be done in conjunction with other changes needing migration. So I will add it to the project along with that #112","author_login":"yarikoptic","author_association":"MEMBER","created_at":"2023-06-29T15:39:34+08:00","repo_name":"datalad/datalad-registry","issue_id":1753969026,"issue_number":186,"issue_url":"https://github.com/datalad/datalad-registry/issues/186","linked_issue_ids":[1604148441],"is_known_query_context":false},{"document_id":"gh_comment_1613530375","fragment_type":"issue_comment","sequence":2,"text":"Yes, these changes will be done with whatever changes needed in #112.","author_login":"candleindark","author_association":"COLLABORATOR","created_at":"2023-06-29T16:55:32+08:00","repo_name":"datalad/datalad-registry","issue_id":1753969026,"issue_number":186,"issue_url":"https://github.com/datalad/datalad-registry/issues/186","linked_issue_ids":[1604148441],"is_known_query_context":false},{"document_id":"gh_issue_1604148441","fragment_type":"issue_description","sequence":0,"text":"\"cron job\" to keep dataset updated\nI sorted by \"Last update\" to get a few which seems never got analyzed but the sample one I went to exists and well\n\nURL | Dataset | Commit | Annex keys | Annexed files in working tree | Size of Annexed files in working tree (bytes)\n-- | -- | -- | -- | -- | --\n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None |   |   | None | None |   |  \n URL | None\n\nI even wonder if we should add some \"Last update error\" DB field to store information if it was some errored out execution and add it as the last column to web ui table to ease troubleshooting... WDYT?","author_login":"yarikoptic","author_association":"MEMBER","created_at":"2023-03-01T03:02:29+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1449310849","fragment_type":"issue_comment","sequence":1,"text":"I am aware of this. Last time I checked, the logic in handling update was not fully implemented. The idea of using a central dispatcher with an dedicated queue I mentioned today should solve the problem, but I may use a more expedient solution for now.","author_login":"candleindark","author_association":"COLLABORATOR","created_at":"2023-03-01T04:11:46+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1610067233","fragment_type":"issue_comment","sequence":2,"text":"This is suggested changes to the model which should IMHO facilitate all desired operations for checks more or less efficiently\n\npatch\n❯ git diff\ndiff --git a/datalad_registry/models.py b/datalad_registry/models.py\nindex 75c0faf..b9748d9 100644\n--- a/datalad_registry/models.py\n+++ b/datalad_registry/models.py\n@@ -15,13 +15,20 @@ class URL(db.Model): # type: ignore\n annex_key_count = db.Column(db.Integer)\n annexed_files_in_wt_count = db.Column(db.Integer)\n annexed_files_in_wt_size = db.Column(db.BigInteger)\n- info_ts = db.Column(db.DateTime(timezone=True))\n- update_announced = db.Column(db.Boolean, default=False, nullable=False)\n head = db.Column(db.Text)\n head_describe = db.Column(db.Text)\n+ head_dt = db.Column(db.DateTime(timezone=True))\n branches = db.Column(db.Text)\n tags = db.Column(db.Text)\n git_objects_kb = db.Column(db.BigInteger)\n+\n+ #: Last time the DB record was updated\n+ last_update_dt = db.Column(db.DateTime(timezone=True)) # former info_ts\n+ #: Last time we checked this URL\n+ last_check_dt = db.Column(db.DateTime(timezone=True))\n+ #: Non-null value means there is a pending check request, with a dt on when it was requested.\n+ #: If non-null set, and another request comes in, ignore new request - keep old check_request value\n+ check_request_dt = db.Column(db.DateTime(timezone=True), default=None, nullable=True) # former bool update_announced\n #: Whether initial data has been collected for this URL\n processed = db.Column(db.Boolean, default=False, nullable=False)","author_login":"yarikoptic","author_association":"MEMBER","created_at":"2023-06-27T19:04:35+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1610114628","fragment_type":"issue_comment","sequence":3,"text":"here is chatgpt produced code:\n\npython\nimport time\nfrom datetime import datetime\nfrom sqlalchemy import create_engine, MetaData, Table, select\nfrom celery import Celery\n\n# Set up the Celery application\napp = Celery('tasks', broker='pyamqp://guest@localhost//')\n\n# Set up the SQLAlchemy engine\nengine = create_engine('postgresql://user:password@localhost/dbname')\n\n# SQLAlchemy models\nmetadata = MetaData()\nURLs = Table('urls', metadata, autoload_with=engine)\n\ncheck_minimal_time = 3600 # seconds -- so no checks for a URL\nn_run_in_parallel = 10\nsleep_waiting = 60\nn_max_failed_checks = 10\n\n@app.task\ndef check_url(url):\n pass # Implement your task here\n\nwhile True:\n # Get all running tasks\n inspect = app.control.inspect()\n active_tasks = inspect.active()\n n_currently_running = len([task for tasks in active_tasks.values() for task in tasks if task['name'] == 'tasks.check_url'])\n\n n_can_run = n_run_in_parallel - n_currently_running\n if not n_can_run:\n time.sleep(sleep_waiting)\n continue\n\n with engine.connect() as connection:\n # SQLAlchemy query\n query = select([URLs]).where(URLs.c.processed == True)\n urls = connection.execute(query).fetchall()\n\n urls_to_check = sorted(\n [url for url in urls if url.check_request_dt and url.processed],\n key=lambda url: url.check_request_dt)[:n_can_run]\n \n if not urls_to_check:\n urls_to_check = sorted(\n [url for url in urls \n if url.processed and url.n_failed_checks check_minimal_time\n ],\n key=lambda url: url.last_check_dt)[:n_can_run]\n \n if urls_to_check:\n for url in urls_to_check:\n # SQLAlchemy update\n query = URLs.update().where(URLs.c.id == url.id).values(last_check_dt=datetime.now())\n connection.execute(query)\n # Adding tasks to celery\n [check_url.delay(url) for url in urls_to_check]\n else:\n time.sleep(sleep_waiting)","author_login":"yarikoptic","author_association":"MEMBER","created_at":"2023-06-27T19:43:39+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1610118004","fragment_type":"issue_comment","sequence":4,"text":"here is the code avoiding while True loop \n\npython\nimport time\nfrom datetime import datetime\nfrom sqlalchemy import create_engine, MetaData, Table, select\nfrom celery import Celery\n\n# Set up the Celery application\napp = Celery('tasks', broker='pyamqp://guest@localhost//')\n\n# Set up the SQLAlchemy engine\nengine = create_engine('postgresql://user:password@localhost/dbname')\n\n# SQLAlchemy models\nmetadata = MetaData()\nURLs = Table('urls', metadata, autoload_with=engine)\n\ncheck_minimal_time = 3600 # seconds -- so no checks for a URL\nn_run_in_parallel = 10\nsleep_waiting = 60\nn_max_failed_checks = 10\n\n@app.task\ndef check_url(url):\n pass # Implement your task here\n\nwhile True:\n # Get all running tasks\n inspect = app.control.inspect()\n active_tasks = inspect.active()\n n_currently_running = len([task for tasks in active_tasks.values() for task in tasks if task['name'] == 'tasks.check_url'])\n\n n_can_run = n_run_in_parallel - n_currently_running\n if not n_can_run:\n time.sleep(sleep_waiting)\n continue\n\n with engine.connect() as connection:\n # SQLAlchemy query\n query = select([URLs]).where(URLs.c.processed == True)\n urls = connection.execute(query).fetchall()\n\n urls_to_check = sorted(\n [url for url in urls if url.check_request_dt and url.processed],\n key=lambda url: url.check_request_dt)[:n_can_run]\n \n if not urls_to_check:\n urls_to_check = sorted(\n [url for url in urls \n if url.processed and url.n_failed_checks check_minimal_time\n ],\n key=lambda url: url.last_check_dt)[:n_can_run]\n \n if urls_to_check:\n for url in urls_to_check:\n # SQLAlchemy update\n query = URLs.update().where(URLs.c.id == url.id).values(last_check_dt=datetime.now())\n connection.execute(query)\n # Adding tasks to celery\n [check_url.delay(url) for url in urls_to_check]\n else:\n time.sleep(sleep_waiting)","author_login":"yarikoptic","author_association":"MEMBER","created_at":"2023-06-27T19:46:50+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1610121269","fragment_type":"issue_comment","sequence":5,"text":"re update: since some evil ppl could do \"git push --force\" and rewrite history we cannot just use `git pull` or even `git pull --ff-only` since it would not be guaranteed to work. I think the safest strategy would be to \n\ntry `git fetch`. If that is ok, means connection is good etc. Do `git pull --ff-only` and if that one fails, then `rm` cached copy, redo cloning from scratch for that URL. If `git fetch` fails -- announce check failed, and let above cron job to retry later.","author_login":"yarikoptic","author_association":"MEMBER","created_at":"2023-06-27T19:49:46+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1612301468","fragment_type":"issue_comment","sequence":6,"text":"@yarikoptic is `head_dt` the `authordate` of the current `HEAD`?","author_login":"candleindark","author_association":"COLLABORATOR","created_at":"2023-06-29T01:23:00+08:00","repo_name":"datalad/datalad-registry","issue_id":1604148441,"issue_number":112,"issue_url":"https://github.com/datalad/datalad-registry/issues/112","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0363","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Won't load the seed I input?","query_context":"Hello, when I input a seed, the game still ends up generating a new seed instead of loading the seed I inputted","known_context_document_ids":["gh_issue_2104934882"],"reference_answer":"This is likely due to what I do here\n\nI set the seed override to false when you're not at a MoonOfTheDay moon.\n\nLooking at their code (which they mention is heavily inspired by MoonOfTheDay), they seem to touch that variable at the same time. So it'd be down to whichever mod loads first, as that one will be overridden iirc.\n\nI think they can fix it by adding a soft dependency to MoonOfTheDay, which should cause their mod to be loaded after mine. Alternatively, they can set their patch to run last.","answer_document_id":"gh_comment_1927527876","silver_evidence_path":["gh_comment_1937840437","gh_issue_2106981213","gh_comment_1927527876"],"evidence_issue_ids":[2104934882,2106981213],"source_repo_name":"FlooflesDev/LCSeedPicker","source_issue_id":2104934882,"source_issue_number":10,"source_issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","target_repo_name":"MaxWasUnavailable/MoonOfTheDay","target_issue_id":2106981213,"target_issue_number":3,"target_issue_url":"https://github.com/MaxWasUnavailable/MoonOfTheDay/issues/3","reference_anchor_document_id":"gh_comment_1937840437","reference_answer_author":"MaxWasUnavailable","reference_answer_author_association":"OWNER","quality_score":90.2,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.0435,"target_answer_overlap":0.1176},"issue_created_at":"2024-01-29T08:32:38+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2104934882","fragment_type":"issue_description","sequence":0,"text":"Won't load the seed I input\nHello, when I input a seed, the game still ends up generating a new seed instead of loading the seed I inputted","author_login":"haroelim","author_association":"NONE","created_at":"2024-01-29T08:32:38+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1914254011","fragment_type":"issue_comment","sequence":1,"text":"I can look at this later today, I thought this worked when I tested it but I might be wrong.\n\nCould you please send me a list of mods that you are using? It is very likely that another mod is overwriting the seed that you set","author_login":"FlooflesDev","author_association":"OWNER","created_at":"2024-01-29T09:06:16+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1916012192","fragment_type":"issue_comment","sequence":2,"text":"Sure\n\nBepInEx-BepInExPack-5.4.2100\nRugbugRedfern-Skinwalkers-4.0.1\nCapyCat-Solos_Ring_Compass-1.0.3\nAlexCodesGames-AdditionalSuits-2.0.0\nx753-More_Suits-1.4.1\nVerity-TooManySuits-1.0.5\nx753-Mimics-2.3.2\nanormaltwig-LateCompany-1.0.10\nnotnotnotswipez-MoreCompany-1.7.6\ntinyhoot-ShipLoot-1.0.0\nthomas-AlwaysShowClock-1.0.0\nTheFluff-FairAI-1.3.2\nRune580-LethalCompany_InputUtils-0.6.1\nRenegades-FlashlightToggle-1.5.0\nRenegades-WalkieUse-1.5.0\n2018-LC_API-3.4.5\nEliteMasterEric-Coroner-1.5.3\nCapyCat-Solos_Bodycams-1.0.5\nMoreLethal-Pinger-3.2.0\nboxofbiscuits97-QuotaRollover-2.3.0\nBobbie-MetalRecharging-1.0.0\nCoomfy-CoomfyDungeon-1.0.12\namnsoft-EmployeeAssignments-1.1.0\nEvaisa-HookGenPatcher-0.0.5\nEvaisa-LethalLib-0.14.0\nMegaPiggy-BuyableShotgun-1.0.4\nMegaPiggy-BuyableShotgunShells-1.0.5\nmatsuura-HealthMetrics-1.0.2\nToskan4134-LethalRegeneration-1.2.0\nStoneman-LethalProgression-1.3.2\nJunLethalCompany-GamblingMachineAtTheCompany-1.3.5\nMikeMediaStudios-MikesTweaks-2.0.2\nMoonJuice-BuyRateSettings-1.3.1\nSligili-HDLethalCompany-1.5.6\nakechii-DiscountAlert-2.3.0\nOzone-Runtime_Netcode_Patcher-0.2.5\nAlexCodesGames-AdditionalContentFramework-1.0.3\nHomelessGinger-MaskedEnemyOverhaul-3.1.1\nATK-LaterNights-0.9.1\nOzone-BepInUtils-1.2.1\nOzone-Glow_Steps-1.1.2\nPooble-LCBetterSaves-1.7.3\nCTMods-KarmaForBeingAnnoying-1.1.0\nzerouni-CustomRadio-0.1.1\nrafl-CustomBoomboxMusicFixed-1.0.2\nMom_Llama-Lethal_Company_Enhancer-0.1.10\nsunnobunno-YippeeMod-1.2.3\nAzim-HoarderBud-1.0.10\nblink9803-AutoFlyToCompany-1.0.1\ndarksnakex-NoCorpseHigherQuota-2.5.0\nIntegrityChaos-Diversity-1.1.10\nSuskitech-AlwaysHearActiveWalkies-1.4.4\nFlipMods-TooManyEmotes-1.8.3\nAllToasters-SpectateEnemies-2.2.1\nBlorb-WeatherMultipliers-1.1.0\nSv_Matt-HideModList-1.0.1\nPortableNavi-BetterInverseTeleporter-1.0.2\nno00ob-LCSoundTool-1.5.0\nClementinise-CustomSounds-2.3.2\nSkrimpGang-AAAAAGHH-1.0.1\ndarmuh-ghostCodes-1.5.1\nF4ilS4fe-MaskTheDead-1.0.5\nDev1A3-ScannableCodes-1.0.2\nButteryStancakes-AccurateStaminaDisplay-1.1.2\nOE_Tweaks-Possessed_Masks-2.0.2\nextraes-LethalLoudnessMeter-1.0.2\nZG-ScalingStartCredits-1.0.6\nElectric131-IsThisTheWayICame-1.1.4\nSoraYuki-ShowAmmoCount-1.1.0\nMaxWasUnavailable-MoonOfTheDay-1.0.4\nSligili-More_Emotes-1.3.3\nRattenbonkers-Teleporter_Cooldown_Reset-1.0.1\nTwinDimensionalProductions-CoilHeadStare-1.0.3\nFlipMods-ObjectVolumeController-1.0.4\neXish-Batteries-1.0.4\nAgentRev-ShootableMouthDogs-1.0.1\nCyanBlob-Motion_Tracker-1.0.0\nScruffyRules-BatteryText-1.0.0\nCTMods-ChatCommands-1.1.7\nFlooflesDEV-LCSeedPicker-1.2.1","author_login":"haroelim","author_association":"NONE","created_at":"2024-01-30T03:33:01+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1916012641","fragment_type":"issue_comment","sequence":3,"text":"I could try it on a very basic modpack (just the seedpicker installed) to see if that changes anything, too","author_login":"haroelim","author_association":"NONE","created_at":"2024-01-30T03:33:42+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1916094751","fragment_type":"issue_comment","sequence":4,"text":"I have found the conflicting mod: it is MaxWasUnavailable-MoonOfTheDay-1.0.4\n\nWhen that mod is disabled in my modpack, that seedpicker works as intended. When it is enabled, the seedpicker is ignored","author_login":"haroelim","author_association":"NONE","created_at":"2024-01-30T05:18:42+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1927531036","fragment_type":"issue_comment","sequence":5,"text":"Crossposting from the issue on my end:\n\n URL \n\nShould be an easy fix if you set your patch priority to run last @FlooflesDev","author_login":"MaxWasUnavailable","author_association":"NONE","created_at":"2024-02-05T17:28:20+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[2106981213],"is_known_query_context":false},{"document_id":"gh_comment_1937840437","fragment_type":"issue_comment","sequence":6,"text":"I was hoping that Harmony had a function like that, but I had some trouble finding it until now. Thanks for the help and for letting me loosely copy your mod :) (extremely new to Unity modding).\nI fixed the issue in v1.2.2 of the mod.","author_login":"FlooflesDev","author_association":"OWNER","created_at":"2024-02-11T19:06:07+08:00","repo_name":"FlooflesDev/LCSeedPicker","issue_id":2104934882,"issue_number":10,"issue_url":"https://github.com/FlooflesDev/LCSeedPicker/issues/10","linked_issue_ids":[2106981213],"is_known_query_context":false},{"document_id":"gh_issue_2106981213","fragment_type":"issue_description","sequence":0,"text":"[Mod Conflict] LCSeedPicker is not able to load inputted seed on vanilla moons with MoonOfTheDay is installed\nWhen using my usual modpack, I first I thought that LCSeedPicker was not working, but when I used it by itself, it worked as intended.\n\nI disabled mods to see if any were causing any conflicts. The seed picker works only when Moon of the day is disabled.\n\nI just wanted to report the mod conflict for your information","author_login":"haroelim","author_association":"NONE","created_at":"2024-01-30T05:25:12+08:00","repo_name":"MaxWasUnavailable/MoonOfTheDay","issue_id":2106981213,"issue_number":3,"issue_url":"https://github.com/MaxWasUnavailable/MoonOfTheDay/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1927527876","fragment_type":"issue_comment","sequence":1,"text":"This is likely due to what I do here\n\nI set the seed override to false when you're not at a MoonOfTheDay moon.\n\nLooking at their code (which they mention is heavily inspired by MoonOfTheDay), they seem to touch that variable at the same time. So it'd be down to whichever mod loads first, as that one will be overridden iirc.\n\nI think they can fix it by adding a soft dependency to MoonOfTheDay, which should cause their mod to be loaded after mine. Alternatively, they can set their patch to run last.","author_login":"MaxWasUnavailable","author_association":"OWNER","created_at":"2024-02-05T17:26:33+08:00","repo_name":"MaxWasUnavailable/MoonOfTheDay","issue_id":2106981213,"issue_number":3,"issue_url":"https://github.com/MaxWasUnavailable/MoonOfTheDay/issues/3","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1937841099","fragment_type":"issue_comment","sequence":2,"text":"Fixed the issue on my end:\n\n URL \n\nFeel free to close this issue, thanks for the help!","author_login":"FlooflesDev","author_association":"NONE","created_at":"2024-02-11T19:08:47+08:00","repo_name":"MaxWasUnavailable/MoonOfTheDay","issue_id":2106981213,"issue_number":3,"issue_url":"https://github.com/MaxWasUnavailable/MoonOfTheDay/issues/3","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0364","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"How can I get my output address like rtsp or file address?","query_context":"ENV: \nNVIDIA Jetson Xavier NX (Developer Kit Version)\n Jetpack 4.6 [L4T 32.6.1]\n Board info:\n Type: Xavier NX (Developer Kit Version)\n Libraries:\n CUDA: 10.2.300\n cuDNN: 8.2.1.32\n TensorRT: 8.0.1.6\n Visionworks: 1.6.0.501\n OpenCV: 4.5.1 compiled CUDA: YES\n VPI: ii libnvvpi1 1.1.15 arm64 NVIDIA Vision Programming Interface library\n Vulkan: 1.2.70\n jetson-stats:\n Version 3.1.2\n Works on Python 3.6.9\n\nDeepStream Version 6.0.1\nTensorRT Version 8.0.1.6\n\nmy config file is below：\n\n[application]\nenable-perf-measurement=1\nperf-measurement-interval-sec=5\n\n[tiled-display]\nenable=1\nrows=1\ncolumns=1\n#width=704\n#height=576\n\nwidth=1920\nheight=1080\ngpu-id=0\nnvbuf-memory-type=0\n\n[source0]\nenable=1\ntype=3\n#uri=file:///opt/nvidia/deepstream/deepstream/samples/streams/sample_1080p_h264.mp4\n#uri=file:///home/dvadmin/wxp/safeHat/video/show-hat.avi\nuri=rtsp://admin:be92319@192.168.0.641:554\nnum-sources=1\ngpu-id=0\ncudadec-memtype=0\n\n[sink0]\nenable=1\ntype=3\ncodec=1\nenc-type=0\nbitrate=4000000\nrtsp-port=8554\nudp-port=5400\nsync=0\n#gpu-id=0\nsource-id=1\n#nvbuf-memory-type=0\n#profile=1\noutput-file=out_res.mp4\nudp-buffer-size=100000\n\n[osd]\nenable=1\ngpu-id=0\nborder-width=5\ntext-size=15\ntext-color=1;1;1;1;\ntext-bg-color=0.3;0.3;0.3;1\nfont=Serif\nshow-clock=0\nclock-x-offset=800\nclock-y-offset=820\nclock-text-size=12\nclock-color=1;0;0;0\nnvbuf-memory-type=0\n\n[streammux]\ngpu-id=0\nlive-source=0\nbatch-size=1\nbatched-push-timeout=40000\nwidth=1920\nheight=1080\nenable-padding=0\nnvbuf-memory-type=0\n\n[primary-gie]\nenable=1\ngpu-id=0\ngie-unique-id=1\nnvbuf-memory-type=0\nconfig-file=config_infer_primary_yoloV5.txt\n\n[tests]\nfile-loop=0\n\nrun log is below:\n\nWARNING: [TRT]: Using an engine plan file across different models of devices is not recommended and is likely to affect performance or even cause errors.\nDeserialize yoloLayer plugin: yolo_93\nDeserialize yoloLayer plugin: yolo_96\nDeserialize yoloLayer plugin: yolo_99\n0:00:05.616159735 5167 0x4219600 INFO nvinfer gstnvinfer.cpp:638:gst_nvinfer_logger: NvDsInferContext[UID 1]: Info from NvDsInferContextImpl::deserializeEngineAndBackend() [UID = 1]: deserialized trt engine from :/home/dvadmin/wxp/tensorrtx/DeepStream-Yolo/model_b1_gpu0_fp32.engine\nINFO: [Implicit Engine Info]: layers num: 4\n0 INPUT kFLOAT data 3x640x640\n1 OUTPUT kFLOAT yolo_93 255x80x80\n2 OUTPUT kFLOAT yolo_96 255x40x40\n3 OUTPUT kFLOAT yolo_99 255x20x20\n\n0:00:05.616422771 5167 0x4219600 INFO nvinfer gstnvinfer.cpp:638:gst_nvinfer_logger: NvDsInferContext[UID 1]: Info from NvDsInferContextImpl::generateBackendContext() [UID = 1]: Use deserialized engine model: /home/dvadmin/wxp/tensorrtx/DeepStream-Yolo/model_b1_gpu0_fp32.engine\n0:00:05.627614037 5167 0x4219600 INFO nvinfer gstnvinfer_impl.cpp:313:notifyLoadModelStatus: [UID 1]: Load new model:/home/dvadmin/wxp/tensorrtx/DeepStream-Yolo/config_infer_primary_yoloV5.txt sucessfully\n\nRuntime commands:\n h: Print this help\n q: Quit\n\n p: Pause\n r: Resume\n\n**PERF: FPS 0 (Avg)\n**PERF: 0.00 (0.00)\n** INFO: : Pipeline ready\n\n** INFO: : Pipeline running\n\n**PERF: 28.15 (27.98)\n**PERF: 25.00 (26.41)\n**PERF: 25.00 (25.92)\n**PERF: 25.00 (25.68)\n**PERF: 25.00 (25.54)\n**PERF: 25.00 (25.45)\n**PERF: 25.01 (25.38)\n**PERF: 24.99 (25.34)\nq\nQuitting\nApp run successful\n\nbut I can not find out put file out_res.mp4\nwhen I set sink0 type is 4, but I can not find out put rtsp url. I try to use rtsp://localhost:8554/ds_test but fail.\nplease help me think you very much","known_context_document_ids":["gh_issue_1264362590"],"reference_answer":"You can use DeepStream with C++ or Python. My repo shows how to compile DeepStream to use Yolo models. You need edit deepstream apps code (deepstream-test1, deepstream-test2, etc.) as you needed and use compiled files.","answer_document_id":"gh_comment_608170658","silver_evidence_path":["gh_comment_1154643141","gh_issue_592992284","gh_comment_608170658"],"evidence_issue_ids":[1264362590,592992284],"source_repo_name":"marcoslucianops/DeepStream-Yolo","source_issue_id":1264362590,"source_issue_number":185,"source_issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","target_repo_name":"marcoslucianops/DeepStream-Yolo","target_issue_id":592992284,"target_issue_number":1,"target_issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/1","reference_anchor_document_id":"gh_comment_1154643141","reference_answer_author":"marcoslucianops","reference_answer_author_association":"OWNER","quality_score":92.59,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.7625,"anchor_target_overlap":0.0513,"target_answer_overlap":0.2222},"issue_created_at":"2022-06-08T08:09:41+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1264362590","fragment_type":"issue_description","sequence":0,"text":"How can I get my output address like rtsp or file address\nENV: \nNVIDIA Jetson Xavier NX (Developer Kit Version)\n Jetpack 4.6 [L4T 32.6.1]\n Board info:\n Type: Xavier NX (Developer Kit Version)\n Libraries:\n CUDA: 10.2.300\n cuDNN: 8.2.1.32\n TensorRT: 8.0.1.6\n Visionworks: 1.6.0.501\n OpenCV: 4.5.1 compiled CUDA: YES\n VPI: ii libnvvpi1 1.1.15 arm64 NVIDIA Vision Programming Interface library\n Vulkan: 1.2.70\n jetson-stats:\n Version 3.1.2\n Works on Python 3.6.9\n\nDeepStream Version 6.0.1\nTensorRT Version 8.0.1.6\n\nmy config file is below：\n\n[application]\nenable-perf-measurement=1\nperf-measurement-interval-sec=5\n\n[tiled-display]\nenable=1\nrows=1\ncolumns=1\n#width=704\n#height=576\n\nwidth=1920\nheight=1080\ngpu-id=0\nnvbuf-memory-type=0\n\n[source0]\nenable=1\ntype=3\n#uri=file:///opt/nvidia/deepstream/deepstream/samples/streams/sample_1080p_h264.mp4\n#uri=file:///home/dvadmin/wxp/safeHat/video/show-hat.avi\nuri=rtsp://admin:be92319@192.168.0.641:554\nnum-sources=1\ngpu-id=0\ncudadec-memtype=0\n\n[sink0]\nenable=1\ntype=3\ncodec=1\nenc-type=0\nbitrate=4000000\nrtsp-port=8554\nudp-port=5400\nsync=0\n#gpu-id=0\nsource-id=1\n#nvbuf-memory-type=0\n#profile=1\noutput-file=out_res.mp4\nudp-buffer-size=100000\n\n[osd]\nenable=1\ngpu-id=0\nborder-width=5\ntext-size=15\ntext-color=1;1;1;1;\ntext-bg-color=0.3;0.3;0.3;1\nfont=Serif\nshow-clock=0\nclock-x-offset=800\nclock-y-offset=820\nclock-text-size=12\nclock-color=1;0;0;0\nnvbuf-memory-type=0\n\n[streammux]\ngpu-id=0\nlive-source=0\nbatch-size=1\nbatched-push-timeout=40000\nwidth=1920\nheight=1080\nenable-padding=0\nnvbuf-memory-type=0\n\n[primary-gie]\nenable=1\ngpu-id=0\ngie-unique-id=1\nnvbuf-memory-type=0\nconfig-file=config_infer_primary_yoloV5.txt\n\n[tests]\nfile-loop=0\n\nrun log is below:\n\nWARNING: [TRT]: Using an engine plan file across different models of devices is not recommended and is likely to affect performance or even cause errors.\nDeserialize yoloLayer plugin: yolo_93\nDeserialize yoloLayer plugin: yolo_96\nDeserialize yoloLayer plugin: yolo_99\n0:00:05.616159735 5167 0x4219600 INFO nvinfer gstnvinfer.cpp:638:gst_nvinfer_logger: NvDsInferContext[UID 1]: Info from NvDsInferContextImpl::deserializeEngineAndBackend() [UID = 1]: deserialized trt engine from :/home/dvadmin/wxp/tensorrtx/DeepStream-Yolo/model_b1_gpu0_fp32.engine\nINFO: [Implicit Engine Info]: layers num: 4\n0 INPUT kFLOAT data 3x640x640\n1 OUTPUT kFLOAT yolo_93 255x80x80\n2 OUTPUT kFLOAT yolo_96 255x40x40\n3 OUTPUT kFLOAT yolo_99 255x20x20\n\n0:00:05.616422771 5167 0x4219600 INFO nvinfer gstnvinfer.cpp:638:gst_nvinfer_logger: NvDsInferContext[UID 1]: Info from NvDsInferContextImpl::generateBackendContext() [UID = 1]: Use deserialized engine model: /home/dvadmin/wxp/tensorrtx/DeepStream-Yolo/model_b1_gpu0_fp32.engine\n0:00:05.627614037 5167 0x4219600 INFO nvinfer gstnvinfer_impl.cpp:313:notifyLoadModelStatus: [UID 1]: Load new model:/home/dvadmin/wxp/tensorrtx/DeepStream-Yolo/config_infer_primary_yoloV5.txt sucessfully\n\nRuntime commands:\n h: Print this help\n q: Quit\n\n p: Pause\n r: Resume\n\n**PERF: FPS 0 (Avg)\n**PERF: 0.00 (0.00)\n** INFO: : Pipeline ready\n\n** INFO: : Pipeline running\n\n**PERF: 28.15 (27.98)\n**PERF: 25.00 (26.41)\n**PERF: 25.00 (25.92)\n**PERF: 25.00 (25.68)\n**PERF: 25.00 (25.54)\n**PERF: 25.00 (25.45)\n**PERF: 25.01 (25.38)\n**PERF: 24.99 (25.34)\nq\nQuitting\nApp run successful\n\nbut I can not find out put file out_res.mp4\nwhen I set sink0 type is 4, but I can not find out put rtsp url. I try to use rtsp://localhost:8554/ds_test but fail.\nplease help me think you very much","author_login":"WangxuP","author_association":"NONE","created_at":"2022-06-08T08:09:41+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1152565883","fragment_type":"issue_comment","sequence":1,"text":"Sink for save file:\n\n[sink0]\nenable=0\ntype=3\n# 1 = mp4, 2 = mkv\ncontainer=1\n# 1 = h264, 2 = h265\ncodec=1\n# Encoder type: 0 = Hardware 1 = Software\nenc-type=0\nsync=0\nbitrate=4000000\noutput-file=out.mp4\nsource-id=0\n\nSink for rtsp output:\n\n[sink0]\nenable=0\ntype=4\n# 1 = h264, 2 = h265\ncodec=1\n# Encoder type: 0 = Hardware 1 = Software\nenc-type=0\nsync=0\nbitrate=400000\nrtsp-port=8554\nudp-port=5400\n\nThe output link for RTSP streaming is `rtsp://localhost:8554/ds-test`\n\nYou can use multiple sinks by change their numbers (example: [sink0], [sink1], etc)","author_login":"marcoslucianops","author_association":"OWNER","created_at":"2022-06-10T17:05:28+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152897168","fragment_type":"issue_comment","sequence":2,"text":"I'm sorry, but I still can't output MP4 files or RTSP using the method you recommended.","author_login":"WangxuP","author_association":"NONE","created_at":"2022-06-11T10:43:33+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1154643141","fragment_type":"issue_comment","sequence":3,"text":"In fact, I have consulted NVIDIA's official blog, but it still hasn't been resolved。\nmy deepstream_app_config.txt is below:\n`[application]\nenable-perf-measurement=1\nperf-measurement-interval-sec=5\n\n[tiled-display]\nenable=1\nrows=1\ncolumns=1\n#width=704\n#height=576\n\nwidth=1920\nheight=1080\ngpu-id=0\nnvbuf-memory-type=0\n\n[source0]\nenable=1\ntype=4\n#uri=file:///opt/nvidia/deepstream/deepstream/samples/streams/sample_1080p_h264.mp4\n#uri=file:///home/dvadmin/wxp/safeHat/video/show-safetyhelmet.avi\nuri=rtsp://admin:beSdeV99@192.168.0.64:554\n#uri=rtmp://192.168.0.186:1980/live\nnum-sources=1\ngpu-id=0\ncudadec-memtype=0\n\n[sink0]\nenable=0\n#Type - 1=FakeSink 2=EglSink 3=File 4=RTSPStreaming\ntype=4\n#1=h264 2=h265\ncodec=1\nsync=0\nbitrate=4000000\n# set below properties in case of RTSPStreaming\nrtsp-port=8554\nudp-port=5400\n\n[osd]\nenable=1\ngpu-id=0\nborder-width=5\ntext-size=15\ntext-color=1;1;1;1;\ntext-bg-color=0.3;0.3;0.3;1\nfont=Serif\nshow-clock=0\nclock-x-offset=800\nclock-y-offset=820\nclock-text-size=12\nclock-color=1;0;0;0\nnvbuf-memory-type=0\n\n[streammux]\ngpu-id=0\nlive-source=0\nbatch-size=1\nbatched-push-timeout=40000\nwidth=1920\nheight=1080\nenable-padding=0\nnvbuf-memory-type=0\n\n[primary-gie]\nenable=1\ngpu-id=0\ngie-unique-id=1\nnvbuf-memory-type=0\nconfig-file=config_infer_primary_yoloV5.txt\n\n[tests]\nfile-loop=0`","author_login":"WangxuP","author_association":"NONE","created_at":"2022-06-14T02:34:56+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[592992284],"is_known_query_context":false},{"document_id":"gh_comment_1154644204","fragment_type":"issue_comment","sequence":4,"text":"In fact, I have consulted NVIDIA's official blog, but it still hasn't been resolved。see in: URL \nmy deepstream_app_config.txt is below:\n[application]\nenable-perf-measurement=1\nperf-measurement-interval-sec=5\n\n[tiled-display]\nenable=1\nrows=1\ncolumns=1\n#width=704\n#height=576\n\nwidth=1920\nheight=1080\ngpu-id=0\nnvbuf-memory-type=0\n\n[source0]\nenable=1\ntype=4\n#uri=file:///opt/nvidia/deepstream/deepstream/samples/streams/sample_1080p_h264.mp4\n#uri=file:///home/dvadmin/wxp/safeHat/video/show-safetyhelmet.avi\nuri=rtsp://admin:beSdeV99@192.168.0.64:554\n#uri=rtmp://192.168.0.186:1980/live\nnum-sources=1\ngpu-id=0\ncudadec-memtype=0\n\n[sink0]\nenable=0\n#Type - 1=FakeSink 2=EglSink 3=File 4=RTSPStreaming\ntype=4\n#1=h264 2=h265\ncodec=1\nsync=0\nbitrate=4000000\n# set below properties in case of RTSPStreaming\nrtsp-port=8554\nudp-port=5400\n\n[osd]\nenable=1\ngpu-id=0\nborder-width=5\ntext-size=15\ntext-color=1;1;1;1;\ntext-bg-color=0.3;0.3;0.3;1\nfont=Serif\nshow-clock=0\nclock-x-offset=800\nclock-y-offset=820\nclock-text-size=12\nclock-color=1;0;0;0\nnvbuf-memory-type=0\n\n[streammux]\ngpu-id=0\nlive-source=0\nbatch-size=1\nbatched-push-timeout=40000\nwidth=1920\nheight=1080\nenable-padding=0\nnvbuf-memory-type=0\n\n[primary-gie]\nenable=1\ngpu-id=0\ngie-unique-id=1\nnvbuf-memory-type=0\nconfig-file=config_infer_primary_yoloV5.txt\n\n[tests]\nfile-loop=0","author_login":"WangxuP","author_association":"NONE","created_at":"2022-06-14T02:36:58+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[592992284],"is_known_query_context":false},{"document_id":"gh_comment_1154644564","fragment_type":"issue_comment","sequence":5,"text":"In fact, I have consulted NVIDIA's official blog, but it still hasn't been resolved。see in: URL \nmy deepstream_app_config.txt is below:\n[application]\nenable-perf-measurement=1\nperf-measurement-interval-sec=5\n\n[tiled-display]\nenable=1\nrows=1\ncolumns=1\n#width=704\n#height=576\n\nwidth=1920\nheight=1080\ngpu-id=0\nnvbuf-memory-type=0\n\n[source0]\nenable=1\ntype=4\n#uri=file:///opt/nvidia/deepstream/deepstream/samples/streams/sample_1080p_h264.mp4\n#uri=file:///home/dvadmin/wxp/safeHat/video/show-safetyhelmet.avi\nuri=rtsp://admin:beSdeV99@192.168.0.64:554\n#uri=rtmp://192.168.0.186:1980/live\nnum-sources=1\ngpu-id=0\ncudadec-memtype=0\n\n[sink0]\nenable=0\n#Type - 1=FakeSink 2=EglSink 3=File 4=RTSPStreaming\ntype=4\n#1=h264 2=h265\ncodec=1\nsync=0\nbitrate=4000000\n#set below properties in case of RTSPStreaming\nrtsp-port=8554\nudp-port=5400\n\n[osd]\nenable=1\ngpu-id=0\nborder-width=5\ntext-size=15\ntext-color=1;1;1;1;\ntext-bg-color=0.3;0.3;0.3;1\nfont=Serif\nshow-clock=0\nclock-x-offset=800\nclock-y-offset=820\nclock-text-size=12\nclock-color=1;0;0;0\nnvbuf-memory-type=0\n\n[streammux]\ngpu-id=0\nlive-source=0\nbatch-size=1\nbatched-push-timeout=40000\nwidth=1920\nheight=1080\nenable-padding=0\nnvbuf-memory-type=0\n\n[primary-gie]\nenable=1\ngpu-id=0\ngie-unique-id=1\nnvbuf-memory-type=0\nconfig-file=config_infer_primary_yoloV5.txt\n\n[tests]\nfile-loop=0","author_login":"WangxuP","author_association":"NONE","created_at":"2022-06-14T02:37:45+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[592992284],"is_known_query_context":false},{"document_id":"gh_comment_1160559771","fragment_type":"issue_comment","sequence":6,"text":"Sorry, but I don't know what's going on in your case. Here it works normally.","author_login":"marcoslucianops","author_association":"OWNER","created_at":"2022-06-20T15:04:40+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":1264362590,"issue_number":185,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/185","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_592992284","fragment_type":"issue_description","sequence":0,"text":"Question: Deepstream source code\nThanks for creating this repo; I was under the impression that the Nvidia deepstream sdk has to be edited in a c++ file. Here it seems that is not how the interaction with deep stream taking place. Any information to clear up my misconception will be helpful.","author_login":"ishangupta3","author_association":"NONE","created_at":"2020-04-03T00:09:16+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":592992284,"issue_number":1,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_608170658","fragment_type":"issue_comment","sequence":1,"text":"You can use DeepStream with C++ or Python. My repo shows how to compile DeepStream to use Yolo models. You need edit deepstream apps code (deepstream-test1, deepstream-test2, etc.) as you needed and use compiled files.","author_login":"marcoslucianops","author_association":"OWNER","created_at":"2020-04-03T00:54:19+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":592992284,"issue_number":1,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_608171299","fragment_type":"issue_comment","sequence":2,"text":"If I use deepstream with Python, will that effect the performance issues compared to c++?","author_login":"ishangupta3","author_association":"NONE","created_at":"2020-04-03T00:57:14+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":592992284,"issue_number":1,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_608171815","fragment_type":"issue_comment","sequence":3,"text":"Do you know where I can access the deepstream apps code (deepstream-test1, deepstream-2)files?","author_login":"ishangupta3","author_association":"NONE","created_at":"2020-04-03T00:59:23+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":592992284,"issue_number":1,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_608178066","fragment_type":"issue_comment","sequence":4,"text":"Is the same performance, but Python is more sintax friendly than C++.\nIn this video, I'm using Python: URL \n \n\nC code is located in /opt/nvidia/deepstream/deepstream-4.0/sources/apps/sample_apps/\nPython you need install from link: URL","author_login":"marcoslucianops","author_association":"OWNER","created_at":"2020-04-03T01:23:47+08:00","repo_name":"marcoslucianops/DeepStream-Yolo","issue_id":592992284,"issue_number":1,"issue_url":"https://github.com/marcoslucianops/DeepStream-Yolo/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0365","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"HttpMessageHandler Passed To Constructor Of FhirClient Gets Disposed When FhirClient Is Disposed?","query_context":"**Describe the bug**\nWe are using the firely-net-sdk in a project and are experiencing port exhaustion when the server-web-api using the sdk is under high load. To deal with the issue, I tried to reuse the HttpMessageHandler that gets passed into the constructor of the FhirClient. However, the HttpMessageHandler gets disposed with the HttpClientRequester, that is created in the FhirClient's constructor. \n\n**Expected behavior**\nIf I am not mistaken, a class instance passed into a constructor should in general not be disposed by the class using it. The BaseFhirClient should therefore only dispose the HttpMessageHandler if the class BaseFhirClient or the FhirClient created it. If the HttpMessageHandler was passed as a constructor parameter, the handler should not be disposed with the BaseFhirClient.\n\n**Version used:**\n - FHIR Version: R4, maybe other versions are also affected\n - Version: 3.8.0\n\nKind regards,\nAshwani Mehlem","known_context_document_ids":["gh_issue_1186469655"],"reference_answer":"Noting through those posts it makes the point that it's not the actual HttpClient that is the issue, its the HttpMessageHandler that is the problem, and that's the thing you need to hang onto and the Factory helps manage things better.","answer_document_id":"gh_comment_1090826026","silver_evidence_path":["gh_comment_1095589141","gh_issue_1194225965","gh_comment_1090826026"],"evidence_issue_ids":[1186469655,1194225965],"source_repo_name":"FirelyTeam/firely-net-sdk","source_issue_id":1186469655,"source_issue_number":2029,"source_issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2029","target_repo_name":"FirelyTeam/firely-net-sdk","target_issue_id":1194225965,"target_issue_number":2036,"target_issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2036","reference_anchor_document_id":"gh_comment_1095589141","reference_answer_author":"brianpos","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2,"anchor_target_overlap":0.2,"target_answer_overlap":0.1053},"issue_created_at":"2022-03-30T13:32:05+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1186469655","fragment_type":"issue_description","sequence":0,"text":"HttpMessageHandler Passed To Constructor Of FhirClient Gets Disposed When FhirClient Is Disposed\n**Describe the bug**\nWe are using the firely-net-sdk in a project and are experiencing port exhaustion when the server-web-api using the sdk is under high load. To deal with the issue, I tried to reuse the HttpMessageHandler that gets passed into the constructor of the FhirClient. However, the HttpMessageHandler gets disposed with the HttpClientRequester, that is created in the FhirClient's constructor. \n\n**Expected behavior**\nIf I am not mistaken, a class instance passed into a constructor should in general not be disposed by the class using it. The BaseFhirClient should therefore only dispose the HttpMessageHandler if the class BaseFhirClient or the FhirClient created it. If the HttpMessageHandler was passed as a constructor parameter, the handler should not be disposed with the BaseFhirClient.\n\n**Version used:**\n - FHIR Version: R4, maybe other versions are also affected\n - Version: 3.8.0\n\nKind regards,\nAshwani Mehlem","author_login":"AMehlem","author_association":"NONE","created_at":"2022-03-30T13:32:05+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1186469655,"issue_number":2029,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2029","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1094625842","fragment_type":"issue_comment","sequence":1,"text":"Have confirmed this behaviour, and have a simple fix for it.","author_login":"brianpos","author_association":"COLLABORATOR","created_at":"2022-04-11T07:02:26+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1186469655,"issue_number":2029,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2029","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095298739","fragment_type":"issue_comment","sequence":2,"text":"Good idea to use the boolean `disposeHandler` of the `HttpClient` constructor. It saves us a flag in the `FhirClient` to remember not dispose the injected handler. \n\nWe will create a PR for this.","author_login":"marcovisserFurore","author_association":"MEMBER","created_at":"2022-04-11T16:52:48+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1186469655,"issue_number":2029,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2029","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095589141","fragment_type":"issue_comment","sequence":3,"text":"Thanks @brianpos, your fix solves the problem with the port exhaustion as the message handler can then be reused.\n\nAs a side note: It would be even easier if the constructor of the class FhirClient would take an HttpClient or an IHttpClientFactory as a parameter instead of an HttpMessageHandler, as this would allow using the HttpClientFactory-Pattern (see URL already mentioned in issue #2036. \nThe main benefit of this is that the HttpClientFactory handles the lifetime of the message handlers, which avoids DNS-Issues (which can occur when the message handlers live too long) as well as port exhaustion and performance problems (which may occur when too many message handlers are created in a short period of time).","author_login":"AMehlem","author_association":"NONE","created_at":"2022-04-11T21:34:06+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1186469655,"issue_number":2029,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2029","linked_issue_ids":[1194225965],"is_known_query_context":false},{"document_id":"gh_issue_1194225965","fragment_type":"issue_description","sequence":0,"text":"Introduce HttpClientFactory in HttpClient\nIn (closed) issue #2032 , the discussion centered around re-using instances of the HttpClient. Currently, every instance of the FhirClient creates an instance of the HttpClient, but Microsoft recommends having a single HttpClient per application - which means the FhirClient should re-use one single instance.\n\n**Describe the solution you'd like**\n@brianpos suggests using a class called `HttpClientFactory` but it is unclear to me how this solves the problem.\n\n**Describe alternatives you've considered**\nA clear and concise description of any alternative solutions or features you've considered.\n\n**Additional context**\nSee issue the discussion in #2032 for more info.","author_login":"ewoutkramer","author_association":"MEMBER","created_at":"2022-04-06T08:02:39+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1194225965,"issue_number":2036,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1090826026","fragment_type":"issue_comment","sequence":1,"text":"Noting through those posts it makes the point that it's not the actual HttpClient that is the issue, its the HttpMessageHandler that is the problem, and that's the thing you need to hang onto and the Factory helps manage things better.","author_login":"brianpos","author_association":"COLLABORATOR","created_at":"2022-04-06T21:28:17+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1194225965,"issue_number":2036,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1105995030","fragment_type":"issue_comment","sequence":2,"text":"I think with these changes to include the HttpClient via the constructor, then we don't need to do the HttpClientHandlerFactory stuff, and if someone wants to use that stuff, they can and we don't need to be involved.\n(and we get the other unit testing benefits too as I've mentioned in the PRs.)","author_login":"brianpos","author_association":"COLLABORATOR","created_at":"2022-04-22T04:32:55+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1194225965,"issue_number":2036,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1106592745","fragment_type":"issue_comment","sequence":3,"text":"The HttpClientFactory creates and manages HttpClient instances and takes an available message handler from the pool. The HttpClient should be included in the constructor rather than the factory, so the consumer can reuse the same HttpClient.","author_login":"vankampenp","author_association":"NONE","created_at":"2022-04-22T14:50:37+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1194225965,"issue_number":2036,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2036","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1114492665","fragment_type":"issue_comment","sequence":4,"text":"@ewoutkramer, Now that the 3.8.3 and 4 beta release have the httpclient in the constructor of the fhirclient, I think we can close this issue as it enables the HttpClientFactory to be used without change in this library","author_login":"brianpos","author_association":"COLLABORATOR","created_at":"2022-05-02T04:42:09+08:00","repo_name":"FirelyTeam/firely-net-sdk","issue_id":1194225965,"issue_number":2036,"issue_url":"https://github.com/FirelyTeam/firely-net-sdk/issues/2036","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0366","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Fields with `setAllowedCharPattern` do not support some cases of removed `setPreventInvalidInput`?","query_context":"### Describe your motivation\n\nUsing a pattern like \"[0-9]{1,10}\" to restrict the input to maximum 10 digits worked for TextField::setPattern, but not for TextField::setAllowedCharPattern. The new method only seems to check if every part of the input string fulfills the pattern, which an e.g. 15 digit long number does in the above example. But Regex already provides a mechanism to match a pattern multiple times by encapsulating it in a capturing group.\n\n### Describe the solution you'd like\n\nsetAllowedCharPattern should not check if all parts of the input fulfill the pattern, but if the whole input fulfills the pattern. Same behavior as setPattern.","known_context_document_ids":["gh_issue_1481837160"],"reference_answer":"We removed `setPreventInvalidInput` API in V24 since it was essentially broken. Closing this as no longer relevant.","answer_document_id":"gh_comment_2775858371","silver_evidence_path":["gh_comment_1340982930","gh_issue_1195749639","gh_comment_2775858371"],"evidence_issue_ids":[1481837160,1195749639],"source_repo_name":"vaadin/flow-components","source_issue_id":1481837160,"source_issue_number":4307,"source_issue_url":"https://github.com/vaadin/flow-components/issues/4307","target_repo_name":"vaadin/flow-components","target_issue_id":1195749639,"target_issue_number":2986,"target_issue_url":"https://github.com/vaadin/flow-components/issues/2986","reference_anchor_document_id":"gh_comment_1340982930","reference_answer_author":"web-padawan","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1176,"anchor_target_overlap":0.2941,"target_answer_overlap":0.2},"issue_created_at":"2022-12-07T11:49:35+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1481837160","fragment_type":"issue_description","sequence":0,"text":"Fields with `setAllowedCharPattern` do not support some cases of removed `setPreventInvalidInput`\n### Describe your motivation\n\nUsing a pattern like \"[0-9]{1,10}\" to restrict the input to maximum 10 digits worked for TextField::setPattern, but not for TextField::setAllowedCharPattern. The new method only seems to check if every part of the input string fulfills the pattern, which an e.g. 15 digit long number does in the above example. But Regex already provides a mechanism to match a pattern multiple times by encapsulating it in a capturing group.\n\n### Describe the solution you'd like\n\nsetAllowedCharPattern should not check if all parts of the input fulfill the pattern, but if the whole input fulfills the pattern. Same behavior as setPattern.","author_login":"MathiasAugstein","author_association":"NONE","created_at":"2022-12-07T11:49:35+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1340923774","fragment_type":"issue_comment","sequence":1,"text":"Please note that `setAllowedCharPattern` intentionally requires a regular expression that matches a **single character** to prevent typing invalid characters. We are not going to change this behavior, but we could probably document it better.\n\nOn the other hand, `setPattern` is just a shortcut for the native ` ` element logic (although we also implemented it for `TextArea` using custom logic, because in HTML, there is no support for `pattern` in ` ` element).","author_login":"web-padawan","author_association":"MEMBER","created_at":"2022-12-07T12:53:22+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340943208","fragment_type":"issue_comment","sequence":2,"text":"Does this mean that there might be an opportunity for a new feature that would show feedback in the same way as `setAllowedCharPattern` but do the validation based on the whole field content like `setPattern`?","author_login":"Legioth","author_association":"MEMBER","created_at":"2022-12-07T13:09:35+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340982930","fragment_type":"issue_comment","sequence":3,"text":"We used to have `setPreventInvalidInput(true)` API, but it was badly broken by making it impossible to type anything with certain regular expressions - see #1143, #1635, #2986. The `setAllowedCharPattern` API was added to replace it.","author_login":"web-padawan","author_association":"MEMBER","created_at":"2022-12-07T13:38:58+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[1195749639],"is_known_query_context":false},{"document_id":"gh_comment_1341044595","fragment_type":"issue_comment","sequence":4,"text":"`setPreventInvalidInput` is indeed often problematic since it uses the same pattern both for incomplete values and for the final value. I could imagine there are cases where you want to have a more permissive full-value pattern while typing and a more strict one for the final value.\n\nRegardless of that, there's at least a workaround for the issue mentioned in the original issue by using `setMaxLength(10)` to limit the size instead of relying on the pattern for that purpose.","author_login":"Legioth","author_association":"MEMBER","created_at":"2022-12-07T14:25:47+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1342540487","fragment_type":"issue_comment","sequence":5,"text":"Thanks for the quick clarification. The workaround should be enough for most use cases, and a better documentation helps.","author_login":"MathiasAugstein","author_association":"NONE","created_at":"2022-12-08T11:03:52+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1382708198","fragment_type":"issue_comment","sequence":6,"text":"Hi,\nI'm currently using setPreventInvalidInput method in my app and migrating to Vaadin 23/24, it's now impossible to get the same behaviour as before. My example is quite simple, we have a specific number pattern including thousand separator (\\\\d'?){0,5}.\nI tried some combinason using the setPattern and/or setAllowedCharPattern, but none if them fits.\nThe user has to be able to enter either 99999 or 99'999, so the setMaxLength is not an option in this case.\n\nDo you suggest another way of dealing with this case (without using validators of course) or can you consider un-deprecate this feature for the future versions ?\n\nRegards,","author_login":"Freeman656","author_association":"NONE","created_at":"2023-01-14T10:23:33+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1405021058","fragment_type":"issue_comment","sequence":7,"text":"Hi,\nAny input on this issue ? The removal of this feature avoid us from migrating to version 24.\nIs it possible to keep the setPreventInvalidInput method or at least keep a possibility to use it at a lower level ?\nThanks,","author_login":"Freeman656","author_association":"NONE","created_at":"2023-01-26T13:39:38+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639928124","fragment_type":"issue_comment","sequence":8,"text":"As has been mentioned, `setAllowedCharPattern` is not intended as a complete replacement for `setPreventInvalidInput`. The main purpose of that was to restrict which characters the user is allowed to type into the field, which `setAllowedCharPattern` does a better job of. We did not introduce an alternative for preventing input if the full value does not match a specific pattern because that has a questionable UX, and we recommend using validation together with showing an error as user feedback instead.\n\nI opened a PR for clarifying the purpose of `setAllowedCharPattern` in the JavaDoc. As this issue was about changing how `setAllowedCharPattern` works, which we do not intend to do, I'll close this as resolved. Feel free to open a new feature request for introducing a separate feature for preventing input if the full input does not match a pattern, as suggested here: URL","author_login":"sissbruecker","author_association":"CONTRIBUTOR","created_at":"2023-07-18T10:08:06+08:00","repo_name":"vaadin/flow-components","issue_id":1481837160,"issue_number":4307,"issue_url":"https://github.com/vaadin/flow-components/issues/4307","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1195749639","fragment_type":"issue_description","sequence":0,"text":"setPreventInvalidInput(true) on EmailField prevents the user to type in anything\n### Description\n\nsetPreventInvalidInput(true) on EmailField prevents the user to type in anything. E.g. Pressing `a` has no effect (well the cursor goes red briefly) since it's not a valid e-mail address.\n\n### Expected outcome\n\nI should be able to gradually type in e-mail address.\n\n### Actual outcome\n\nI can't type in anything.\n\n### Minimal reproducible example\n\njava\n@Route(\"\")\npublic class MainView extends VerticalLayout {\n\n public MainView() {\n final EmailField emailField = new EmailField(\"E-mail\");\n emailField.setPreventInvalidInput(true);\n add(emailField);\n }\n}\n\n### Steps to reproduce\n\n1. Paste the above to Skeleton starter and run it\n2. Start typing text into EmailField - nothing happens.\n\n### Environment\n\n- Vaadin 14.8.7\n- Ubuntu 21.10\n\n### Browsers Affected\n- [ ] Chrome\n- [x] Firefox 99\n- [ ] Safari\n- [ ] Edge\n- [ ] IE 11\n- [ ] iOS Safari\n- [ ] Android Chrome","author_login":"mvysny","author_association":"MEMBER","created_at":"2022-04-07T09:11:02+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091434239","fragment_type":"issue_comment","sequence":1,"text":"Yes, but this luckily seems to work. \n\n@Route(\"email\")\npublic class EmailView extends VerticalLayout {\n \n public EmailView() {\n final EmailField emailField = new EmailField(\"E-mail\");\n emailField.addValueChangeListener(e -> {\n if (!emailField.isInvalid()) {\n Notification.show(e.getValue());\n }\n });\n add(emailField);\n }\n}","author_login":"TatuLund","author_association":"CONTRIBUTOR","created_at":"2022-04-07T09:38:58+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091437183","fragment_type":"issue_comment","sequence":2,"text":"The web component seems to do the checking after every key stroke. But I think it should be done only when intended value change is to happen.","author_login":"TatuLund","author_association":"CONTRIBUTOR","created_at":"2022-04-07T09:41:51+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1111895552","fragment_type":"issue_comment","sequence":3,"text":"After some discussion we decided that the API shouldn't be there in the first place, and that it should be removed. Instead developers should rely on the regular validation, or set custom pattern validation, and let users correct their changes.\nMeanwhile we can deprecate the existing method, and add a note to the JavaDoc that it has no practical use for email field.","author_login":"sissbruecker","author_association":"CONTRIBUTOR","created_at":"2022-04-28T08:26:53+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1111901466","fragment_type":"issue_comment","sequence":4,"text":"I agree, but then what's the point of having an EmailField - what does it offer on top of a regular TextField?","author_login":"mvysny","author_association":"MEMBER","created_at":"2022-04-28T08:33:02+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1246391348","fragment_type":"issue_comment","sequence":5,"text":"With the introduction of `allowed-chars-pattern` ( URL we could, instead of removing `setPreventInvalidInput`, re-define it to toggle the usage of an allowed-chars pattern pre-populated with chars valid in an email address. That way the Email Field would prevent users from entering characters that are invalid in emails when `setPreventInvalidInput` is true.","author_login":"rolfsmeds","author_association":"CONTRIBUTOR","created_at":"2022-09-14T08:01:17+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2775858371","fragment_type":"issue_comment","sequence":6,"text":"We removed `setPreventInvalidInput` API in V24 since it was essentially broken. Closing this as no longer relevant.","author_login":"web-padawan","author_association":"MEMBER","created_at":"2025-04-03T13:49:42+08:00","repo_name":"vaadin/flow-components","issue_id":1195749639,"issue_number":2986,"issue_url":"https://github.com/vaadin/flow-components/issues/2986","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0368","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Login with UniversalLinkFlow auto direct Safari browser?","query_context":"Hello, I'm applying Line login flow, but when I tried to call Login with UniversalLinkFlow when the Line app was installed before without login, when the Line App opened then auto-directed to the Safari browser.\n- So In this case how to configure to Line app to keep that session without directing it to the browser?\n- I have referred to another app like TikTok when logging Line no login yet, but the Line app still keeps that session.\n- I also tried the example on Line SDK, whose behavior is still directed to the browser.","known_context_document_ids":["gh_issue_2055310054"],"reference_answer":"Sorry for the delay of syncing up. With discussion of the team, we think the current behavior is expected and there is no plan to make a change for it currently.\n\nI am closing this issue due to the conclusion. Thanks for the report and your understanding.","answer_document_id":"gh_comment_2390478241","silver_evidence_path":["gh_comment_1868694182","gh_issue_2025193932","gh_comment_2390478241"],"evidence_issue_ids":[2055310054,2025193932],"source_repo_name":"line/line-sdk-ios-swift","source_issue_id":2055310054,"source_issue_number":202,"source_issue_url":"https://github.com/line/line-sdk-ios-swift/issues/202","target_repo_name":"line/flutter_line_sdk","target_issue_id":2025193932,"target_issue_number":90,"target_issue_url":"https://github.com/line/flutter_line_sdk/issues/90","reference_anchor_document_id":"gh_comment_1868694182","reference_answer_author":"onevcat","reference_answer_author_association":"MEMBER","quality_score":93.38,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1034,"anchor_target_overlap":0.1379,"target_answer_overlap":0.0476},"issue_created_at":"2023-12-25T02:37:09+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2055310054","fragment_type":"issue_description","sequence":0,"text":"Login with UniversalLinkFlow auto direct Safari browser\nHello, I'm applying Line login flow, but when I tried to call Login with UniversalLinkFlow when the Line app was installed before without login, when the Line App opened then auto-directed to the Safari browser.\n- So In this case how to configure to Line app to keep that session without directing it to the browser?\n- I have referred to another app like TikTok when logging Line no login yet, but the Line app still keeps that session.\n- I also tried the example on Line SDK, whose behavior is still directed to the browser.","author_login":"TrongTran-98","author_association":"NONE","created_at":"2023-12-25T02:37:09+08:00","repo_name":"line/line-sdk-ios-swift","issue_id":2055310054,"issue_number":202,"issue_url":"https://github.com/line/line-sdk-ios-swift/issues/202","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1868694182","fragment_type":"issue_comment","sequence":1,"text":"Maybe duplicated to URL \n\nWe are discussing the behavior internally. However, navigating to the web browser and allow users to continue the login process there seems to be a \"not bad\" solution for now. We will see if there is any way to provide a better UX, but now I cannot give any promise about it.","author_login":"onevcat","author_association":"MEMBER","created_at":"2023-12-25T03:16:15+08:00","repo_name":"line/line-sdk-ios-swift","issue_id":2055310054,"issue_number":202,"issue_url":"https://github.com/line/line-sdk-ios-swift/issues/202","linked_issue_ids":[2025193932],"is_known_query_context":false},{"document_id":"gh_comment_1868696698","fragment_type":"issue_comment","sequence":2,"text":"But I still have a question: why does the TikTok apply Line login still keep the Line app session instead of directing Webpage? Do have another version, solutions, etc,.. or do they do it on their own?","author_login":"TrongTran-98","author_association":"NONE","created_at":"2023-12-25T03:22:39+08:00","repo_name":"line/line-sdk-ios-swift","issue_id":2055310054,"issue_number":202,"issue_url":"https://github.com/line/line-sdk-ios-swift/issues/202","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882127079","fragment_type":"issue_comment","sequence":3,"text":"To my understanding, we do not provide any 'distinct version'. The behavior of LINE on iOS and Android platforms differs: on iOS, a webpage login is utilized, whereas on Android, the user is required to login within the LINE app itself. However, on Android, the user is not automatically redirected back to your application even after logging in. It necessitates initiating another login process from your application.\n\nCould you clarify if you are experimenting on different platforms?","author_login":"onevcat","author_association":"MEMBER","created_at":"2024-01-09T01:30:43+08:00","repo_name":"line/line-sdk-ios-swift","issue_id":2055310054,"issue_number":202,"issue_url":"https://github.com/line/line-sdk-ios-swift/issues/202","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2025193932","fragment_type":"issue_description","sequence":0,"text":"[iOS] Login line account auto switch from line app to line web\n## Is it a security issue?\n\nIf you believe you have discovered a vulnerability or have an issue related to security, please **DO NOT** open a public issue. Instead, send us a mail to dl_oss_dev@linecorp.com.\n\n## What did you do?\n\nWhen I login line in iOS, my device has installed the Line app but still not login account. The issue is that when navigate from my app to the line app for starting login line account, it automatically switches from line app to the web line for login. I have setup onlyWebLogin variable false but not work.\n\n## What did you expect?\n\nWhen I setup onlyWebLogin variable as false, it will not automatically switch from Line app to web Line.\n\n## What happened actually?\n\nAuto navigate to web Line while line app is installed\n\n## Your environment?\n\nflutter 3.3.9\nflutter_line_sdk: 2.3.5\n\nDoctor summary (to see all details, run flutter doctor -v):\n[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6.2 21G320 darwin-arm, locale\n en-VN)\n[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)\n[✓] Xcode - develop for iOS and macOS (Xcode 14.2)\n[✓] Chrome - develop for the web\n[✓] Android Studio (version 2022.1)\n[✓] VS Code (version 1.74.3)\n[✓] Connected device (4 available)\n[✓] HTTP Host Availability","author_login":"tuyen3962","author_association":"NONE","created_at":"2023-12-05T03:16:46+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839968742","fragment_type":"issue_comment","sequence":1,"text":"Usually, if your channel app is still under development, this means you are not adding your LINE account as a testing account to your app. Please check and confirm the Developer Console and add your account in the tester list.","author_login":"onevcat","author_association":"MEMBER","created_at":"2023-12-05T04:07:32+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839973331","fragment_type":"issue_comment","sequence":2,"text":"can you explain more detail about the tester list and testing account?","author_login":"tuyen3962","author_association":"NONE","created_at":"2023-12-05T04:12:11+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839979620","fragment_type":"issue_comment","sequence":3,"text":"You can find the related setting in the LINE Developer Console (login from URL check your channel and invite the LINE account to the tester list.\n\n<img width=\"1132\" alt=\"截屏2023-12-05 13 18 45\" src=\" URL \n\nFor more, please also check this documentation: URL","author_login":"onevcat","author_association":"MEMBER","created_at":"2023-12-05T04:20:47+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839988338","fragment_type":"issue_comment","sequence":4,"text":"But when i use the other user line account in iOs, is it necessary for this steip?","author_login":"tuyen3962","author_association":"NONE","created_at":"2023-12-05T04:31:38+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839989751","fragment_type":"issue_comment","sequence":5,"text":"Only users on this list are allowed to use your channel while it is under development. After you mark the channel to be published, all LINE users can login to your channel.","author_login":"onevcat","author_association":"MEMBER","created_at":"2023-12-05T04:33:34+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839991809","fragment_type":"issue_comment","sequence":6,"text":"My channel has been published. But the issue still be here and only happen in iOS when user has not login account in Line app","author_login":"tuyen3962","author_association":"NONE","created_at":"2023-12-05T04:36:24+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839994346","fragment_type":"issue_comment","sequence":7,"text":"If the user does not yet log in the LINE iOS app, then it is the expected behavior: LINE app recognize the auth request from the LINE SDK and try to read the login status from itself. If not yet login, then it goes to an error handling process since no login user yet there in LINE.","author_login":"onevcat","author_association":"MEMBER","created_at":"2023-12-05T04:39:31+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1839996917","fragment_type":"issue_comment","sequence":8,"text":"That's right. Like the android, when navigate to line app for login, i can handle action in app. No need switch to web app","author_login":"tuyen3962","author_association":"NONE","created_at":"2023-12-05T04:42:51+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1843962999","fragment_type":"issue_comment","sequence":9,"text":"@tuyen3962 Ummm, thanks for the explanation.\n\nI will record this and start a discussion with the team to see if we can improve it. But since it is already a long-lasting LINE iOS app behavior and not directly involved with LINE SDK side, it may take a while before a decision can be finally made. Let me try!","author_login":"onevcat","author_association":"MEMBER","created_at":"2023-12-07T01:01:20+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2390478241","fragment_type":"issue_comment","sequence":10,"text":"Sorry for the delay of syncing up. With discussion of the team, we think the current behavior is expected and there is no plan to make a change for it currently.\n\nI am closing this issue due to the conclusion. Thanks for the report and your understanding.","author_login":"onevcat","author_association":"MEMBER","created_at":"2024-10-03T04:11:21+08:00","repo_name":"line/flutter_line_sdk","issue_id":2025193932,"issue_number":90,"issue_url":"https://github.com/line/flutter_line_sdk/issues/90","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0369","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"bug: `npm run build` produces non functioning app...","query_context":"One of the recent commits URL that I assume was supposed to reduce disk space and network traffic went wrong and broke the build.\n\nBuilding the HTML5 app uses URL as a last step to compress files exceeding certain size.\n\nThe plugin works in a way where during the `npm run build` it leaves original files produced by `webpack` in place, and produces a `.gz` versions of all files that exceed the threshold specified in webpack config:\n\n URL \n\nWhen using `deleteOriginalAssets: true` the plugin actually removes the uncompressed original files as they are not actually needed on the server\n\nSo a directory produced with `deleteOriginalAssets: false`:\n\n-rw-r--r-- 1 mman staff 1423307 May 21 11:42 60.96569f9e.js\n-rw-r--r-- 1 mman staff 2881 May 21 11:42 60.96569f9e.js.LICENSE.txt\n-rw-r--r-- 1 mman staff 421274 May 21 11:42 60.96569f9e.js.gz\n-rw-r--r-- 1 mman staff 160371 May 21 11:42 main.c742e74d.js\n-rw-r--r-- 1 mman staff 1818 May 21 11:42 runtime-main.17566f78.js\n\nWill look like this when `deleteOriginalAssets: true` is used:\n\n-rw-r--r-- 1 mman staff 421274 May 21 11:42 60.96569f9e.js.gz\n-rw-r--r-- 1 mman staff 160371 May 21 11:42 main.c742e74d.js\n-rw-r--r-- 1 mman staff 1818 May 21 11:42 runtime-main.17566f78.js\n\nThis all looks nice and shiny, until we realise there is \n\n## Problem 1: LICENSE.txt file gets deleted as well\n\nWe can see that it not only deleted the original `.js` file, but it also accidentally got rid of the `.js.LICENSE.txt` file that gets shipped along... This is probably a bug in the `CompressionPlugin`.\n\n## Problem 2: Deleted original `.js` file does not get injected into `index.html`\n\nThere seems to be a race condition between the `CompressionPlugin` and the `HtmlWebpackPlugin` where `HTMLWebpackPlugin` does not properly inject required `.js` files into the `index.html` when they are removed by the `CompressionPlugin`. This should not happen as `CompressionPlugin` is mentioned last in our `webpack.config` but it does happen.\n\nThe result is that running either the `npm run build` or `npm run start` both result in an empty HTML5 app...\n\n<img width=\"1192\" alt=\"Screenshot 2024-05-21 at 11 25 04\" src=\" URL \n\nSimple fix is to revert the commit URL \n\nMore complex fix is to figure out how to make `CompressionPlugin` play well with `HtmlWebpackPlugin`.","known_context_document_ids":["gh_issue_2307934403"],"reference_answer":"You can fix it using `test: /\\.(js|css)$/,`, something wrong in `manifest-webpack-plugin` (looks like a wrong hook)","answer_document_id":"gh_comment_2137939541","silver_evidence_path":["gh_comment_2124495955","gh_issue_2310206620","gh_comment_2137939541"],"evidence_issue_ids":[2307934403,2310206620],"source_repo_name":"victronenergy/venus-html5-app","source_issue_id":2307934403,"source_issue_number":370,"source_issue_url":"https://github.com/victronenergy/venus-html5-app/issues/370","target_repo_name":"webpack-contrib/compression-webpack-plugin","target_issue_id":2310206620,"target_issue_number":390,"target_issue_url":"https://github.com/webpack-contrib/compression-webpack-plugin/issues/390","reference_anchor_document_id":"gh_comment_2124495955","reference_answer_author":"alexander-akait","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.5556,"anchor_target_overlap":0.4444,"target_answer_overlap":0.3333},"issue_created_at":"2024-05-21T10:21:14+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2307934403","fragment_type":"issue_description","sequence":0,"text":"bug: `npm run build` produces non functioning app...\nOne of the recent commits URL that I assume was supposed to reduce disk space and network traffic went wrong and broke the build.\n\nBuilding the HTML5 app uses URL as a last step to compress files exceeding certain size.\n\nThe plugin works in a way where during the `npm run build` it leaves original files produced by `webpack` in place, and produces a `.gz` versions of all files that exceed the threshold specified in webpack config:\n\n URL \n\nWhen using `deleteOriginalAssets: true` the plugin actually removes the uncompressed original files as they are not actually needed on the server\n\nSo a directory produced with `deleteOriginalAssets: false`:\n\n-rw-r--r-- 1 mman staff 1423307 May 21 11:42 60.96569f9e.js\n-rw-r--r-- 1 mman staff 2881 May 21 11:42 60.96569f9e.js.LICENSE.txt\n-rw-r--r-- 1 mman staff 421274 May 21 11:42 60.96569f9e.js.gz\n-rw-r--r-- 1 mman staff 160371 May 21 11:42 main.c742e74d.js\n-rw-r--r-- 1 mman staff 1818 May 21 11:42 runtime-main.17566f78.js\n\nWill look like this when `deleteOriginalAssets: true` is used:\n\n-rw-r--r-- 1 mman staff 421274 May 21 11:42 60.96569f9e.js.gz\n-rw-r--r-- 1 mman staff 160371 May 21 11:42 main.c742e74d.js\n-rw-r--r-- 1 mman staff 1818 May 21 11:42 runtime-main.17566f78.js\n\nThis all looks nice and shiny, until we realise there is \n\n## Problem 1: LICENSE.txt file gets deleted as well\n\nWe can see that it not only deleted the original `.js` file, but it also accidentally got rid of the `.js.LICENSE.txt` file that gets shipped along... This is probably a bug in the `CompressionPlugin`.\n\n## Problem 2: Deleted original `.js` file does not get injected into `index.html`\n\nThere seems to be a race condition between the `CompressionPlugin` and the `HtmlWebpackPlugin` where `HTMLWebpackPlugin` does not properly inject required `.js` files into the `index.html` when they are removed by the `CompressionPlugin`. This should not happen as `CompressionPlugin` is mentioned last in our `webpack.config` but it does happen.\n\nThe result is that running either the `npm run build` or `npm run start` both result in an empty HTML5 app...\n\n<img width=\"1192\" alt=\"Screenshot 2024-05-21 at 11 25 04\" src=\" URL \n\nSimple fix is to revert the commit URL \n\nMore complex fix is to figure out how to make `CompressionPlugin` play well with `HtmlWebpackPlugin`.","author_login":"mman","author_association":"COLLABORATOR","created_at":"2024-05-21T10:21:14+08:00","repo_name":"victronenergy/venus-html5-app","issue_id":2307934403,"issue_number":370,"issue_url":"https://github.com/victronenergy/venus-html5-app/issues/370","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2124495955","fragment_type":"issue_comment","sequence":1,"text":"The original commit here URL was supposed to enable `WebpackCompressionPlugin`. However `WebpackCompressionPlugin` seems to be broken and does not play well with `HtmlWebpackPlugin` when `deleteOriginalAssets: true`.\n\nI have filed two related bugs here: \n\n URL \n\n URL","author_login":"mman","author_association":"COLLABORATOR","created_at":"2024-05-22T10:51:25+08:00","repo_name":"victronenergy/venus-html5-app","issue_id":2307934403,"issue_number":370,"issue_url":"https://github.com/victronenergy/venus-html5-app/issues/370","linked_issue_ids":[2310206620],"is_known_query_context":false},{"document_id":"gh_comment_2125114957","fragment_type":"issue_comment","sequence":2,"text":"I have temporarily fixed this by reverting the original commit, here: URL leaving open for investigation how to properly implement gzip + delete","author_login":"mman","author_association":"COLLABORATOR","created_at":"2024-05-22T15:40:57+08:00","repo_name":"victronenergy/venus-html5-app","issue_id":2307934403,"issue_number":370,"issue_url":"https://github.com/victronenergy/venus-html5-app/issues/370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3338067533","fragment_type":"issue_comment","sequence":3,"text":"The fix for URL is now part of the webpack so I am closing this issue and re-enabling the `deleteOriginalAssets: true` again.","author_login":"mman","author_association":"COLLABORATOR","created_at":"2025-09-26T10:42:44+08:00","repo_name":"victronenergy/venus-html5-app","issue_id":2307934403,"issue_number":370,"issue_url":"https://github.com/victronenergy/venus-html5-app/issues/370","linked_issue_ids":[2310206620],"is_known_query_context":false},{"document_id":"gh_issue_2310206620","fragment_type":"issue_description","sequence":0,"text":"Bug: `deleteOrigianlAssets: true` breaks the build badly...\n### Bug report\n\nCreated an empty `npx create-react-app@latest webpack-compress-test`, added this plugin and broke the build.\n\nLooks like `CompressionPlugin` is racing with `HtmlWebpackPlugin` and deletes original `.js` files too early... before `HtmlWebpackPlugin` gets a chance to process them.\n\n#### Steps to reproduce:\n\n1. Create new react app:\n\n€ npx create-react-app@latest webpack-compress-test\n\nCreating a new React app in /Users/mman/Developer/webpack-compress-test.\n\nInstalling packages. This might take a couple of minutes.\n...\n\n2. Add compression plugin dependency:\n\n€ npm install compression-webpack-plugin --save-dev\nadded 5 packages, and audited 1561 packages in 2s\n...\n\n3. Eject config to get access to `webpack.config.js`\n\n€ npm run eject\n \n \n\nNOTE: Create React App 2+ supports TypeScript, Sass, CSS Modules and more without ejecting: URL \n\n✔ Are you sure you want to eject? This action is permanent. … yes\nEjecting...\n...\n\n4. Try to build:\n\n€ npm run build\n \n \n\nCreating an optimized production build...\nCompiled successfully.\n...\n\n5. Examine output:\n\n€ ls -l build/static/js \ntotal 1064\n-rw-r--r-- 1 mman staff 4542 May 22 12:42 453.80dd94dc.chunk.js\n-rw-r--r-- 1 mman staff 10597 May 22 12:42 453.80dd94dc.chunk.js.map\n-rw-r--r-- 1 mman staff 143827 May 22 12:42 main.2663d1cb.js\n-rw-r--r-- 1 mman staff 971 May 22 12:42 main.2663d1cb.js.LICENSE.txt\n-rw-r--r-- 1 mman staff 371868 May 22 12:42 main.2663d1cb.js.map\n\n6. Enable compression plugin:\n\nNow modify the `config/webpack.config.js` and enable compression plugin as the last step to compress everything.\n\n+const CompressionPlugin = require(\"compression-webpack-plugin\");\n\n...\n+ new CompressionPlugin({\n+ threshold: 0,\n+ deleteOriginalAssets: true,\n+ })\n+\n\n7. Try to build:\n\n€ npm run build\n \n \n\nCreating an optimized production build...\nFailed to compile.\n\nCannot destructure property 'info' of 'compilation.getAsset(...)' as it is undefined.\n\n### Actual Behavior\n\nBuild fails:\n\n€ npm run build\n \n \n\nCreating an optimized production build...\nFailed to compile.\n\nCannot destructure property 'info' of 'compilation.getAsset(...)' as it is undefined.\n\n### Expected Behavior\n\nBuild should succeed with all files being .gzipped\n\n### How Do We Reproduce?\n\nSee the detailed steps above.\n\nThe repo contains broken code: URL \nThe commit here enables the compression: URL","author_login":"mman","author_association":"NONE","created_at":"2024-05-22T10:48:30+08:00","repo_name":"webpack-contrib/compression-webpack-plugin","issue_id":2310206620,"issue_number":390,"issue_url":"https://github.com/webpack-contrib/compression-webpack-plugin/issues/390","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2137911330","fragment_type":"issue_comment","sequence":1,"text":"I think we will need a fix in html-webpack-plugin too, I will investigate tomorrow deeply and provide fixes for html-webpack-plugin too","author_login":"alexander-akait","author_association":"MEMBER","created_at":"2024-05-29T17:20:37+08:00","repo_name":"webpack-contrib/compression-webpack-plugin","issue_id":2310206620,"issue_number":390,"issue_url":"https://github.com/webpack-contrib/compression-webpack-plugin/issues/390","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2137939541","fragment_type":"issue_comment","sequence":2,"text":"You can fix it using `test: /\\.(js|css)$/,`, something wrong in `manifest-webpack-plugin` (looks like a wrong hook)","author_login":"alexander-akait","author_association":"MEMBER","created_at":"2024-05-29T17:38:42+08:00","repo_name":"webpack-contrib/compression-webpack-plugin","issue_id":2310206620,"issue_number":390,"issue_url":"https://github.com/webpack-contrib/compression-webpack-plugin/issues/390","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0370","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Select by rectangle map tool shows up when feature selection mode is single?","query_context":"### Describe the bug\n\nWe added a new configuration parameter Feature selection, when the selection mode is single, this tool should not show up in the map and in the map feature selection should be single.\n\nImage\n\n### Expected Behavior\n\nSelect by rectangle tool will not show when feature selection configuration setting is single.\n\n### Reproduction Steps & Sample\n\nTest app: URL \n1) Launch the app.\n2) Notice the tool on the map and when selected, it lets us select multiple features.\n\n### Other Relevant Info\n\n_No response_","known_context_document_ids":["gh_issue_3084128910"],"reference_answer":"@azizaparveen \n\n## Cause\n- This is an enhancement requested by the client to add support to turn off multiple selection in the table\n___\n## Solution\n- Retrieve the selection mode from the config\n- If selection mode is single, then allow only one feature to be selected at a time from the map/table\n- If selection mode is multiple, then allow multiple features to be selected at a time from the map/table\n___\n## Dev Checklist\n \nItems | Is required | Status | Comments\n-- | -- | -- | --\nRequired NLS changes? | No | | \nRequired Backward compatibility | Yes | | \nRequired 508 | Yes | | \nNeed Sanitize? | No | | \n___\n## Impact Analysis Report\nImpacted Areas | Comments\n-- | --\nHave Configuration changes? | No\nHave Runtime changes? | Yes\nImpact on RTL | No\nImpacted components | - Feature table - Map card - Info card\nImpact on runtime | When **Single selection mode** is selected Allow user to select only one feature (from map/table) On selecting a new feature, the previous selection will be removed and the user can select only one feature at a time Multi-selection tool from the map should be hidden- URL \n || When **Multiple Selection mode** is selected (current behaviour) Allow users to select multiple features using a table or Multi-Selection tool from the map \n || To support backward compatibility by default, Multiple option should be selected","answer_document_id":"gh_comment_2853716378","silver_evidence_path":["gh_comment_2909979040","gh_issue_2807652995","gh_comment_2853716378"],"evidence_issue_ids":[3084128910,2807652995],"source_repo_name":"Esri/solutions-components","source_issue_id":3084128910,"source_issue_number":1355,"source_issue_url":"https://github.com/Esri/solutions-components/issues/1355","target_repo_name":"Esri/solutions-components","target_issue_id":2807652995,"target_issue_number":1114,"target_issue_url":"https://github.com/Esri/solutions-components/issues/1114","reference_anchor_document_id":"gh_comment_2909979040","reference_answer_author":"pratiksabale07","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1154,"anchor_target_overlap":0.1923,"target_answer_overlap":0.3659},"issue_created_at":"2025-05-22T17:46:58+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_3084128910","fragment_type":"issue_description","sequence":0,"text":"Select by rectangle map tool shows up when feature selection mode is single\n### Describe the bug\n\nWe added a new configuration parameter Feature selection, when the selection mode is single, this tool should not show up in the map and in the map feature selection should be single.\n\nImage\n\n### Expected Behavior\n\nSelect by rectangle tool will not show when feature selection configuration setting is single.\n\n### Reproduction Steps & Sample\n\nTest app: URL \n1) Launch the app.\n2) Notice the tool on the map and when selected, it lets us select multiple features.\n\n### Other Relevant Info\n\n_No response_","author_login":"azizaparveen","author_association":"COLLABORATOR","created_at":"2025-05-22T17:46:58+08:00","repo_name":"Esri/solutions-components","issue_id":3084128910,"issue_number":1355,"issue_url":"https://github.com/Esri/solutions-components/issues/1355","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2909979040","fragment_type":"issue_comment","sequence":1,"text":"@azizaparveen @jmhauck \n\n- This issue is not reproducible in local environment.\n- Looks like featureSelectionMode property is not set on the mananger component\nPossible solutions\n - Please check if the featureSelectionMode property is being passed to the Crowdsource Manager app .\n - URL \n - According to this if it is not passed properly then featureSelectionMode will be multiple by default","author_login":"sumitzarkar","author_association":"COLLABORATOR","created_at":"2025-05-26T14:43:15+08:00","repo_name":"Esri/solutions-components","issue_id":3084128910,"issue_number":1355,"issue_url":"https://github.com/Esri/solutions-components/issues/1355","linked_issue_ids":[2807652995],"is_known_query_context":false},{"document_id":"gh_comment_2914341710","fragment_type":"issue_comment","sequence":2,"text":"@sumitzarkar Editor widget added multi selection tool in this release, In Manager we are skipping this page but I believe we will need to show this page for bulk attribute editing. If we show this page, the toolbar with multi selection tool will be showing right? \n\nIf it shows then we will not need the multi selection map tool (select by rectangle tool) we added. Wondering if these tools can work with this feature selection mode settings. When single selection is selected in the setting, these tools will be hidden and bulk attribute editing will not be possible \n\nImage","author_login":"azizaparveen","author_association":"COLLABORATOR","created_at":"2025-05-27T22:35:56+08:00","repo_name":"Esri/solutions-components","issue_id":3084128910,"issue_number":1355,"issue_url":"https://github.com/Esri/solutions-components/issues/1355","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2807652995","fragment_type":"issue_description","sequence":0,"text":"Add support to turn off multiple selection in Table in Manager\n### Describe requirements\n\nWe got a user request to provide option to turn off multiple selection in Table, currently the record selection from table behaves the same way as map viewer and allows multiple selection. With this new option users will be able to configure the selection mode depending on their need.\nWe can add this as a configurable option in the Interactivity-> Table options section.\n\nImage\n\n### Alternatives\n\n_No response_\n\n### Other Relevant Info\n\n_No response_\n\n### Impact\n\n_No response_","author_login":"azizaparveen","author_association":"COLLABORATOR","created_at":"2025-01-23T18:43:07+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2742299684","fragment_type":"issue_comment","sequence":1,"text":"@azizaparveen \n\nWe need to implement this in config and runtime as well:\n\n## Configuration \n- Add an option to select the 'Selection Mode'\n Image\n- To support backward compatibility by default Multiple option needs to be selected\n- This needs to be implemented in Configuration\n\n## Runitme \n- Currently, runtime supports multiple selection only\n- We will update the code to work as per the selected 'Selection Mode' in the configuration\n- When Single selection mode is selected\n - User will able to select only one feature (from map/table)\n - If selecting a new feature previous selection will be removed and the user can select only one feature at a time\n - Hide the Multi-selection tool from the map - URL \n - When Multiple Selection mode is selected (current behavior)\n - Allow users to select multiple features using a table or Multi-Selection tool from the map\n \n\nPlease confirm if our understanding is correct","author_login":"sumitzarkar","author_association":"COLLABORATOR","created_at":"2025-03-21T04:59:37+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2765961982","fragment_type":"issue_comment","sequence":2,"text":"@azizaparveen \n- The feature table toolbar contains various tools.\n- In single-selection mode, only one feature can be selected at a time.\n- Therefore, tools, like Select All (which selects all features) and Switch Selection (which toggles the selection), are unnecessary in the single selection mode.\n- These tools should be hidden when single-selection mode is enabled.\n\nLet us know your thoughts on this","author_login":"pratiksabale07","author_association":"COLLABORATOR","created_at":"2025-03-31T11:36:36+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2786645978","fragment_type":"issue_comment","sequence":3,"text":"The config option is added to the Modify tab of Manager. @jmhauck could you please create a prop for this so CT team can connect this with the component?\n\nImage","author_login":"azizaparveen","author_association":"COLLABORATOR","created_at":"2025-04-08T14:28:30+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2853716378","fragment_type":"issue_comment","sequence":4,"text":"@azizaparveen \n\n## Cause\n- This is an enhancement requested by the client to add support to turn off multiple selection in the table\n___\n## Solution\n- Retrieve the selection mode from the config\n- If selection mode is single, then allow only one feature to be selected at a time from the map/table\n- If selection mode is multiple, then allow multiple features to be selected at a time from the map/table\n___\n## Dev Checklist\n \nItems | Is required | Status | Comments\n-- | -- | -- | --\nRequired NLS changes? | No | | \nRequired Backward compatibility | Yes | | \nRequired 508 | Yes | | \nNeed Sanitize? | No | | \n___\n## Impact Analysis Report\nImpacted Areas | Comments\n-- | --\nHave Configuration changes? | No\nHave Runtime changes? | Yes\nImpact on RTL | No\nImpacted components | - Feature table - Map card - Info card\nImpact on runtime | When **Single selection mode** is selected Allow user to select only one feature (from map/table) On selecting a new feature, the previous selection will be removed and the user can select only one feature at a time Multi-selection tool from the map should be hidden- URL \n || When **Multiple Selection mode** is selected (current behaviour) Allow users to select multiple features using a table or Multi-Selection tool from the map \n || To support backward compatibility by default, Multiple option should be selected","author_login":"pratiksabale07","author_association":"COLLABORATOR","created_at":"2025-05-06T08:35:34+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2881162238","fragment_type":"issue_comment","sequence":5,"text":"@sumitzarkar @pratiksabale07 Single feature selection option lets me select multiple.\n\n URL \n\nImage","author_login":"skrishn","author_association":"COLLABORATOR","created_at":"2025-05-14T18:31:41+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2882324957","fragment_type":"issue_comment","sequence":6,"text":"@jmhauck \n\n- To support backward compatibility, Multiple option is enabled. In this case, it seems the configured props is not passed to the component, and hence we see multiple selections.\n- Could you please confirm if this configuration is passed to the Manager Component property 'featureSelectionMode'","author_login":"sumitzarkar","author_association":"COLLABORATOR","created_at":"2025-05-15T04:53:54+08:00","repo_name":"Esri/solutions-components","issue_id":2807652995,"issue_number":1114,"issue_url":"https://github.com/Esri/solutions-components/issues/1114","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0371","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Read and store checkpoints from live data?","query_context":"Currently, in live data analysis, we only read the `checkpoints` but do not store them. This functionality needs to be implemented, and a few considerations should be taken into account:\n\n1. As this type of data changes sparsely, the corresponding value should be stored only when it changes to avoid storing redundant data.\n2. We should also consider the representation of the checkpoints to assess their similarity with previous values.","known_context_document_ids":["gh_issue_1996796839"],"reference_answer":"Since in branch write-to-PLC we started working on this Issue, let us state the problem with detail and provide some constraints set from the domain expert @ge0rgemera.\n\nWe have decided to work with a simpler case, at least for now, that involves the ground source (BTES) solar assisted heat pump. In this case, we can control the hp by changing the value of the corresponding **setpoint**. The setpoint has to have a value in range $[15, 51]$, but it cannot be changed arbitrarily. Specifically:\n\n- If the hp *general alarm* is on, no operation on the hp is acceptible.\n- The hp should not be turned on/off in a time period less than *5 minutes*.\n- If the top layer temperature exceedes *52 oC*, the hp must be turned off.\n- If the temperature of the ground BTES tank is less than *8 oC*, the hp should be turned off. If this case is true, no other operation on the hp setpoint is acceptible until the temperature of the BTES tank becomes $\\geq 12\\ oC$, in which senario the hp must be turned back on.","answer_document_id":"gh_comment_1952204559","silver_evidence_path":["gh_comment_1857829923","gh_issue_2020916307","gh_comment_1952204559"],"evidence_issue_ids":[1996796839,2020916307],"source_repo_name":"data-eng/navgreen","source_issue_id":1996796839,"source_issue_number":20,"source_issue_url":"https://github.com/data-eng/navgreen/issues/20","target_repo_name":"data-eng/navgreen","target_issue_id":2020916307,"target_issue_number":30,"target_issue_url":"https://github.com/data-eng/navgreen/issues/30","reference_anchor_document_id":"gh_comment_1857829923","reference_answer_author":"tatiana-boura","reference_answer_author_association":"COLLABORATOR","quality_score":79.55,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0909},"issue_created_at":"2023-11-16T12:54:41+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1996796839","fragment_type":"issue_description","sequence":0,"text":"Read and store checkpoints from live data\nCurrently, in live data analysis, we only read the `checkpoints` but do not store them. This functionality needs to be implemented, and a few considerations should be taken into account:\n\n1. As this type of data changes sparsely, the corresponding value should be stored only when it changes to avoid storing redundant data.\n2. We should also consider the representation of the checkpoints to assess their similarity with previous values.","author_login":"tatiana-boura","author_association":"COLLABORATOR","created_at":"2023-11-16T12:54:41+08:00","repo_name":"data-eng/navgreen","issue_id":1996796839,"issue_number":20,"issue_url":"https://github.com/data-eng/navgreen/issues/20","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1820507683","fragment_type":"issue_comment","sequence":1,"text":"The checkpoints represent temperature values that define the desired temperature range for the corresponding container. For instance, if the checkpoint is 42.0, then the temperature $t \\in[42.0 - \\delta, 42.0 + \\delta ]$ for some $\\delta \\geq 0$. Currently, the configured $\\delta$ is set to 5.\n\n@ge0rgemera highlighted that when adjusting the checkpoints, they typically modify the integer part of the float and very rarely alter the first decimal. Therefore, we should focus on storing checkpoint values that adhere to these patterns.","author_login":"tatiana-boura","author_association":"COLLABORATOR","created_at":"2023-11-21T09:07:55+08:00","repo_name":"data-eng/navgreen","issue_id":1996796839,"issue_number":20,"issue_url":"https://github.com/data-eng/navgreen/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1857809222","fragment_type":"issue_comment","sequence":2,"text":"This Issue is to be fixed by PR #33, but it should be revisited when we develop code that remotely changes the values of the checkpoints.","author_login":"tatiana-boura","author_association":"COLLABORATOR","created_at":"2023-12-15T12:30:33+08:00","repo_name":"data-eng/navgreen","issue_id":1996796839,"issue_number":20,"issue_url":"https://github.com/data-eng/navgreen/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1857815742","fragment_type":"issue_comment","sequence":3,"text":"Is there an issue outlining what should be checked or changed when that code is developed?","author_login":"stasinos","author_association":"CONTRIBUTOR","created_at":"2023-12-15T12:35:42+08:00","repo_name":"data-eng/navgreen","issue_id":1996796839,"issue_number":20,"issue_url":"https://github.com/data-eng/navgreen/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1857829923","fragment_type":"issue_comment","sequence":4,"text":"I was thinking that we could create it once we agree on the structure of the code in Issue #30.","author_login":"tatiana-boura","author_association":"COLLABORATOR","created_at":"2023-12-15T12:46:18+08:00","repo_name":"data-eng/navgreen","issue_id":1996796839,"issue_number":20,"issue_url":"https://github.com/data-eng/navgreen/issues/20","linked_issue_ids":[2020916307],"is_known_query_context":false},{"document_id":"gh_issue_2020916307","fragment_type":"issue_description","sequence":0,"text":"Writing checkpoints\nCorresponding experiments and checks should be conducted in order to succesfully being able to write to the checkpoints' registers.","author_login":"tatiana-boura","author_association":"COLLABORATOR","created_at":"2023-12-01T13:47:41+08:00","repo_name":"data-eng/navgreen","issue_id":2020916307,"issue_number":30,"issue_url":"https://github.com/data-eng/navgreen/issues/30","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1857864568","fragment_type":"issue_comment","sequence":1,"text":"Noting here that after designing the mechanism for remotely setting checkpoints, some of the code in PR #33 might need to re-visited, as it will be possible to simplify it under the assumption that checkpoints will not be set via other channels.","author_login":"stasinos","author_association":"CONTRIBUTOR","created_at":"2023-12-15T13:14:09+08:00","repo_name":"data-eng/navgreen","issue_id":2020916307,"issue_number":30,"issue_url":"https://github.com/data-eng/navgreen/issues/30","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952204559","fragment_type":"issue_comment","sequence":2,"text":"Since in branch write-to-PLC we started working on this Issue, let us state the problem with detail and provide some constraints set from the domain expert @ge0rgemera.\n\nWe have decided to work with a simpler case, at least for now, that involves the ground source (BTES) solar assisted heat pump. In this case, we can control the hp by changing the value of the corresponding **setpoint**. The setpoint has to have a value in range $[15, 51]$, but it cannot be changed arbitrarily. Specifically:\n\n- If the hp *general alarm* is on, no operation on the hp is acceptible.\n- The hp should not be turned on/off in a time period less than *5 minutes*.\n- If the top layer temperature exceedes *52 oC*, the hp must be turned off.\n- If the temperature of the ground BTES tank is less than *8 oC*, the hp should be turned off. If this case is true, no other operation on the hp setpoint is acceptible until the temperature of the BTES tank becomes $\\geq 12\\ oC$, in which senario the hp must be turned back on.","author_login":"tatiana-boura","author_association":"COLLABORATOR","created_at":"2024-02-19T11:00:14+08:00","repo_name":"data-eng/navgreen","issue_id":2020916307,"issue_number":30,"issue_url":"https://github.com/data-eng/navgreen/issues/30","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0372","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Wheels for Python 3.11 and PyPy?","query_context":"It would be nice to have wheels for Python 3.11 and PyPy (3.7 and 3.8), so as to not need cargo when installing blake3 in such environments.\n\nThis is a mere request, not a demand nor anything. Thanks for the good work here!.","known_context_document_ids":["gh_issue_1090857048"],"reference_answer":"Currently all the wheels are built by GitHub Actions, in this job: URL \n\nGitHub doesn't directly support ARM runners as far as I know (but I could be wrong), so getting additional wheels up probably requires some sort of virtualization. I'm sure something with QEMU is possible, but I don't have a ton of experience with this. Things might get a lot easier if we could use URL directly for this, but I'm not sure.","answer_document_id":"gh_comment_1008359074","silver_evidence_path":["gh_comment_1009195306","gh_issue_1097218449","gh_comment_1008359074"],"evidence_issue_ids":[1090857048,1097218449],"source_repo_name":"oconnor663/blake3-py","source_issue_id":1090857048,"source_issue_number":27,"source_issue_url":"https://github.com/oconnor663/blake3-py/issues/27","target_repo_name":"oconnor663/blake3-py","target_issue_id":1097218449,"target_issue_number":28,"target_issue_url":"https://github.com/oconnor663/blake3-py/issues/28","reference_anchor_document_id":"gh_comment_1009195306","reference_answer_author":"oconnor663","reference_answer_author_association":"OWNER","quality_score":79.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0588,"anchor_target_overlap":0.1739,"target_answer_overlap":0.0},"issue_created_at":"2021-12-30T03:47:55+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1090857048","fragment_type":"issue_description","sequence":0,"text":"Wheels for Python 3.11 and PyPy\nIt would be nice to have wheels for Python 3.11 and PyPy (3.7 and 3.8), so as to not need cargo when installing blake3 in such environments.\n\nThis is a mere request, not a demand nor anything. Thanks for the good work here!.","author_login":"HacKanCuBa","author_association":"NONE","created_at":"2021-12-30T03:47:55+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1009195306","fragment_type":"issue_comment","sequence":1,"text":"Similar issue: URL \n\nI currently use GitHub Actions to build all the wheels. If there's an easy way to get Actions (and particularly the `actions/setup-python@v2` helper that we use here) to install these versions of Python, I'd be happy to add that. According to these docs there might be:\n\n URL \n URL \n\nThat said, if we add something like `3.11.0-alpha.3`, we might want to think a bit about what our update policy is. As new alphas come out, do we expect to add them to the build \"whenever\"? Or is there some way to automate this? Maybe check for new Python versions persistently, like once a day, rather than tying them exclusively to versions bumps of this library? Not sure what's the most reasonable solution here.","author_login":"oconnor663","author_association":"OWNER","created_at":"2022-01-10T18:13:22+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[1097218449],"is_known_query_context":false},{"document_id":"gh_comment_1009198837","fragment_type":"issue_comment","sequence":2,"text":"True, I've honestly been only building wheels for linux, but most of my projects have no building deps so it doesn't make much of difference (which is why I haven't tried anything else yet).\nGonna give you a hand later today","author_login":"HacKanCuBa","author_association":"NONE","created_at":"2022-01-10T18:17:46+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194997148","fragment_type":"issue_comment","sequence":3,"text":"cibuildwheel is becoming pretty standard as a way to build wheels for lots of platforms. You can see pyzmq as an example that builds wheels including a bundled (C++) library dependency, covering pypy, arm, windows, etc.","author_login":"minrk","author_association":"NONE","created_at":"2022-07-26T04:48:12+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1290655224","fragment_type":"issue_comment","sequence":4,"text":"Python 3.11 has been released, so it might be time to make a new release of blake3\n URL","author_login":"Pilen","author_association":"NONE","created_at":"2022-10-25T14:33:54+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1292417637","fragment_type":"issue_comment","sequence":5,"text":"ugh, yeah, seems like 3.11 isn't in macOS yet, but should be soon, i hope 🙏","author_login":"HacKanCuBa","author_association":"NONE","created_at":"2022-10-26T18:10:50+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1297137987","fragment_type":"issue_comment","sequence":6,"text":"I don't see them in the latest release :P\nDo you have to make a new release or can u manually push them?","author_login":"HacKanCuBa","author_association":"NONE","created_at":"2022-10-31T14:00:57+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1297233189","fragment_type":"issue_comment","sequence":7,"text":"Oh my bad, the binaries made it to GitHub but not PyPI. Let me kick it again...","author_login":"oconnor663","author_association":"OWNER","created_at":"2022-10-31T15:08:26+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1297361622","fragment_type":"issue_comment","sequence":8,"text":"hahaha awesome! I just tried in a mac and i got the wheel, and i can clearly see the rest of the wheels, so i'm closing this as fixed.\n\nthanks so much!","author_login":"HacKanCuBa","author_association":"NONE","created_at":"2022-10-31T16:35:41+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1297389078","fragment_type":"issue_comment","sequence":9,"text":"I guess the question of Pypy binaries is still open? But I kind of imagine anyone going out of their way to run Pypy can probably also install a Rust toolchain and let Pip build from source?","author_login":"oconnor663","author_association":"OWNER","created_at":"2022-10-31T16:57:57+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1297435948","fragment_type":"issue_comment","sequence":10,"text":"You are correct, we are still missing the PyPy part :P\nand of course, anyone using it will know what to do regarding rust toolchain, but the same goes for CPython users. If you are planning to add PyPy as supported (meaning tests for it, i guess), and/or add it to the build chain, then i can reopen this issue (or better yet, create a new, specific one)","author_login":"HacKanCuBa","author_association":"NONE","created_at":"2022-10-31T17:34:15+08:00","repo_name":"oconnor663/blake3-py","issue_id":1090857048,"issue_number":27,"issue_url":"https://github.com/oconnor663/blake3-py/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1097218449","fragment_type":"issue_description","sequence":0,"text":"Linux wheel for aarch64 and armv7 architecture ?\nI've seen that you've provided lots of wheel package but could you please provide linux wheel for aarch64 and armv7 architecture ?","author_login":"dulfox","author_association":"NONE","created_at":"2022-01-09T15:00:47+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1008359074","fragment_type":"issue_comment","sequence":1,"text":"Currently all the wheels are built by GitHub Actions, in this job: URL \n\nGitHub doesn't directly support ARM runners as far as I know (but I could be wrong), so getting additional wheels up probably requires some sort of virtualization. I'm sure something with QEMU is possible, but I don't have a ton of experience with this. Things might get a lot easier if we could use URL directly for this, but I'm not sure.","author_login":"oconnor663","author_association":"OWNER","created_at":"2022-01-09T19:25:43+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1319344258","fragment_type":"issue_comment","sequence":2,"text":"URL uses Docker and qemu to run emulated aarch64 containers to build wheels. I'm currently working on getting this to work with pytaglib and it seems to do its job (although slow, unsurprisingly).","author_login":"strayer","author_association":"NONE","created_at":"2022-11-17T23:28:23+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1446820215","fragment_type":"issue_comment","sequence":3,"text":"I found a build service that's half the price of GitHub actions and has support for arm64 URL","author_login":"robd003","author_association":"NONE","created_at":"2023-02-27T18:14:53+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987064129","fragment_type":"issue_comment","sequence":4,"text":"Great news @oconnor663 GitHub has a beta for arm64 runners!\n\nYou can sign-up here: URL","author_login":"robd003","author_association":"NONE","created_at":"2024-03-10T04:17:28+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2360181975","fragment_type":"issue_comment","sequence":5,"text":"you can simply use the `maturin-action` like pydantic does: URL","author_login":"ddelange","author_association":"NONE","created_at":"2024-09-19T07:18:47+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2360370720","fragment_type":"issue_comment","sequence":6,"text":"I saw you use python scripts to upload as release assets.\n\nin constrast, pydantic uses github artifacts for uploading the wheels, and downloads them again in the publish step.\n\nthen, you can upload them as release assets and to pypi using dedicated actions (example) too. you won't need PyGithub or your python scrips anymore. 100% yml :)\n\nthis example ^ uses pypi trusted publishing (no user/pass). all you need to do is add oconnor663/blake3-py as trusted publisher here and add the `permissions` in the github action as per the example.","author_login":"ddelange","author_association":"NONE","created_at":"2024-09-19T08:36:45+08:00","repo_name":"oconnor663/blake3-py","issue_id":1097218449,"issue_number":28,"issue_url":"https://github.com/oconnor663/blake3-py/issues/28","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0373","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Question] Getting several context values at once?","query_context":"Hi :wave:\n\nFirst things first, thx a lot for this great work! :clap: I'm still discovering it, and maybe I'm going to ask a silly question but... is there any reason why `useContextSelector` examples were always using the same \"one call, one value\" pattern:\n\nconst v1 = useContextSelector((ctx) => ctx.v1)\nconst v2 = useContextSelector((ctx) => ctx.v2)\nconst v3 = useContextSelector((ctx) => ctx.v3)\n...\n\n...which seems quite verbose to me. Couldn't we simply use a single call such as:\n\nconst { v1, v2, v3 } = useContextSelector(({ v1, v2, v3 }) => ({ v1, v2, v3 }))\n\nThx a lot for your answer! :pray:","known_context_document_ids":["gh_issue_1402988994"],"reference_answer":"`useSelectorWithEqlFn` creates memoized selector (and you need to pass stable `selector` and `eqlFn`).\n\nI'm not sure if I understand your point. (and I'm not sure if I responded well to your concern.)\n\nBTW, if you are interested in a full implementation with useMutableSource for Redux. I developed this URL . The API is not backward compatible and more like proposing a new pattern.","answer_document_id":"gh_comment_622582548","silver_evidence_path":["gh_comment_1273257451","gh_issue_608689125","gh_comment_622582548"],"evidence_issue_ids":[1402988994,608689125],"source_repo_name":"dai-shi/use-context-selector","source_issue_id":1402988994,"source_issue_number":93,"source_issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","target_repo_name":"dai-shi/use-context-selector","target_issue_id":608689125,"target_issue_number":19,"target_issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","reference_anchor_document_id":"gh_comment_1273257451","reference_answer_author":"dai-shi","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.4118,"anchor_target_overlap":0.2353,"target_answer_overlap":0.1333},"issue_created_at":"2022-10-10T11:04:07+08:00","valid_comment_count":48,"fragments":[{"document_id":"gh_issue_1402988994","fragment_type":"issue_description","sequence":0,"text":"[Question] Getting several context values at once?\nHi :wave:\n\nFirst things first, thx a lot for this great work! :clap: I'm still discovering it, and maybe I'm going to ask a silly question but... is there any reason why `useContextSelector` examples were always using the same \"one call, one value\" pattern:\n\nconst v1 = useContextSelector((ctx) => ctx.v1)\nconst v2 = useContextSelector((ctx) => ctx.v2)\nconst v3 = useContextSelector((ctx) => ctx.v3)\n...\n\n...which seems quite verbose to me. Couldn't we simply use a single call such as:\n\nconst { v1, v2, v3 } = useContextSelector(({ v1, v2, v3 }) => ({ v1, v2, v3 }))\n\nThx a lot for your answer! :pray:","author_login":"soykje","author_association":"NONE","created_at":"2022-10-10T11:04:07+08:00","repo_name":"dai-shi/use-context-selector","issue_id":1402988994,"issue_number":93,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1273163281","fragment_type":"issue_comment","sequence":1,"text":"You can do that if you memoize the selector function. For example `proxy-memoize` does it for you.\n\njs\nimport memoize from 'proxy-memoize';\n\nconst selector = memoize(({ v1, v2, v3 }) => ({ v1, v2, v3 }));\n\nconst Component = () => {\n const { v1, v2, v3 } = useContextSelector(Ctx, selector);\n // ...\n};","author_login":"dai-shi","author_association":"OWNER","created_at":"2022-10-10T11:20:40+08:00","repo_name":"dai-shi/use-context-selector","issue_id":1402988994,"issue_number":93,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273174826","fragment_type":"issue_comment","sequence":2,"text":"Thx for this quick answer! I must be missing something but, why should I use memoization? Aren't both patterns eqs?","author_login":"soykje","author_association":"NONE","created_at":"2022-10-10T11:30:30+08:00","repo_name":"dai-shi/use-context-selector","issue_id":1402988994,"issue_number":93,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273257451","fragment_type":"issue_comment","sequence":3,"text":"Because\n\njs\nconst { v1, v2, v3 } = useContextSelector(({ v1, v2, v3 }) => ({ v1, v2, v3 }))\n\nwill trigger re-renders for any changes (like `v4`).\n\nSo, \"one call, one value\" pattern is the rule we follow. You might be interested in reading #19 discussion.","author_login":"dai-shi","author_association":"OWNER","created_at":"2022-10-10T12:42:26+08:00","repo_name":"dai-shi/use-context-selector","issue_id":1402988994,"issue_number":93,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","linked_issue_ids":[608689125],"is_known_query_context":false},{"document_id":"gh_comment_1273265169","fragment_type":"issue_comment","sequence":4,"text":"Hmmm... I'm not sure to perfectly understand why, but I'll be looking for some infos within the linked discussion :+1: Thx a lot @dai-shi !","author_login":"soykje","author_association":"NONE","created_at":"2022-10-10T12:48:18+08:00","repo_name":"dai-shi/use-context-selector","issue_id":1402988994,"issue_number":93,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1273272728","fragment_type":"issue_comment","sequence":5,"text":"Assuming you are not talking about custom equality function, `const { v1, v2, v3 } = useContextSelector(({ v1, v2, v3 }) => ({ v1, v2, v3 }))` is not technically easy.\nIt's not impossible though, and that's what `react-tracked` does.\n\njs\nconst { v1, v2, v3 } = useTrackedState()\n\n`react-tracked` uses `use-context-selector` under the hood. So, they do different jobs.","author_login":"dai-shi","author_association":"OWNER","created_at":"2022-10-10T12:54:20+08:00","repo_name":"dai-shi/use-context-selector","issue_id":1402988994,"issue_number":93,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/93","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_608689125","fragment_type":"issue_description","sequence":0,"text":"Support for custom equality function\nIt seems like the library is currently hardcoded to compare the value produced by the selector using `Object.is`\n\n URL \n\nSometimes it may be useful to use a different equality comparison such as shallow equal when composing an object. The redux `useSelector` API has an extra optional parameter for this purpose, which can be used like\n\nconst selectedData = useSelector(selectorReturningObject, shallowEqual)\n\nWould you consider supporting this in use-context-selector?","author_login":"robeady","author_association":"NONE","created_at":"2020-04-29T00:01:03+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_620921020","fragment_type":"issue_comment","sequence":1,"text":"Hi, thanks for opening an issue.\nThis might be controversial, but I have a strong belief that react community should prefer using `useCallback` to `equalityFn`. In the case of react-redux, it can't be helped because it had to provide a clear migration path from the HoC API.\nI'm pretty convinced about this with the upcoming `useMutableSource`. v2 is already implemented in #12, and it _requires_ `useCallback`. Supporting `equalityFn` with `useMutableSource` would be extra work, and I'm suspicious about how to clearly make the implementation Concurrent Mode safe.\n\nThat said, I'm eager to learn the use case that requires `equalityFn` and provide a workaround or even a util function. Do you have an example that we can discuss on?","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-04-29T00:21:14+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621638926","fragment_type":"issue_comment","sequence":2,"text":"@dai-shi I'm not sure I follow. If a selector composes an object, using referential equality will always trigger a rerender. Shallow equality would help; how would `useCallback` help instead?","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T06:26:57+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621647571","fragment_type":"issue_comment","sequence":3,"text":"Const selector = useCallback (s=>({a: s.a, b: s.b}),[])\nconst obj = useSelector(selector)","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T06:50:42+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621649052","fragment_type":"issue_comment","sequence":4,"text":"@lishine The selector callback is cached, but it returns a new object every time. The selected value will always be different referentially.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T06:54:33+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621652983","fragment_type":"issue_comment","sequence":5,"text":"Ok, my bad.\nThen create this object in the useContextState with a useMemo. I mean where you create the state for the useSelector","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T07:04:07+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621658920","fragment_type":"issue_comment","sequence":6,"text":"That would violate the rule of hooks, wouldn't it? Using \"useMemo\" in a selector means that it's called in function that is neither a component nor a custom hook.\n\nI suppose the deeper underlying point is that you can memoize the returned object (not through useMemo, but something else like reselect or just rolling your own memoization), but that's just ultimately a roundabout way of doing custom equality checks.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T07:18:26+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621658944","fragment_type":"issue_comment","sequence":7,"text":"@victorporof Sorry, I think I mixed the two points. Ref equality is almost default with useMutableSource (and React in general), so supporting equalityFn is an extra work that I think shouldn't be part of this library. So, one would need to use memoization library before passing. I'm not very familiar, but reselect can be used or there would be more alternatives.\n\n(Requiring `useCallback` is a different story.)","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-04-30T07:18:29+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621660018","fragment_type":"issue_comment","sequence":8,"text":"To be clear, this is the point myself (and I believe OP) are referring to: URL \n\nIf this library choses to only support memoization instead of equality checks for the generated selector data, then sure.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T07:20:56+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621662182","fragment_type":"issue_comment","sequence":9,"text":"This I what I meant.\nIn the hook that you pass to the provider, wrap the object with useMemo.","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T07:25:48+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621664309","fragment_type":"issue_comment","sequence":10,"text":"@lishine You can't useMemo inside a useCallback, or another function that isn't a hook or a function component.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T07:30:21+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621664314","fragment_type":"issue_comment","sequence":11,"text":"@lishine Yeah. Note that `useMemo` can only be used in render, and often the case with a selector is not in render.","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-04-30T07:30:21+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621664999","fragment_type":"issue_comment","sequence":12,"text":"Sure in render , in the component that includes the provider.","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T07:31:51+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621665650","fragment_type":"issue_comment","sequence":13,"text":"I write a custom hook that creates the state. That state is passed to the provider.","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T07:33:13+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621665716","fragment_type":"issue_comment","sequence":14,"text":"I write a custom hook that creates the state. That state is passed to the provider.","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T07:33:21+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621666019","fragment_type":"issue_comment","sequence":15,"text":"@lishine Are you talking about memoizing the whole state that is passed to the provider? That is different from from selecting multiple values from that state.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T07:33:55+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621667732","fragment_type":"issue_comment","sequence":16,"text":"If you want to return an object from the selector that includes several properties of the state, you create this object beforehand where you manage the state. So that the selector uses it as a property of the state.","author_login":"lishine","author_association":"NONE","created_at":"2020-04-30T07:37:40+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621670824","fragment_type":"issue_comment","sequence":17,"text":"@lishine Aha, I see what you mean. I think that's a reasonable workaround (just like many others, such as using reselect, or memoizing the returned value from a selector on the spot). I think we're in agreement that being constrained with just being able to use referential equality doesn't mean that there's no other ways of doing this.\n\nI'd say that there can be various possible combinations of substate that the provider component would then have to know about, which means propagating these concerns up the component tree. I maintain that this workaround (and memoization inside selectors) are less ergonomic or natural than just being able to pass in a custom equality function in the selector. However I also concede that this might be because of some folks just being used to react-redux's approach.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T07:44:15+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621671757","fragment_type":"issue_comment","sequence":18,"text":"Note: doing this sort of memoization inside the provider component doesn't seem possible when it'd depend on various props that are available only to some deeply descendant component.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T07:46:06+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621739323","fragment_type":"issue_comment","sequence":19,"text":"In this context, my preference it to use multiple `useSelector`s.","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-04-30T10:07:35+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621756641","fragment_type":"issue_comment","sequence":20,"text":"@dai-shi Multiple selectors aren't suitable in all circumstances. Consider this:\n\nconst state = useSelector(state => {\n const { foo, bar } = expensive(state, props.baz);\n return { foo, bar };\n});\n\nvs.\n\nconst foo = useSelector(state => expensive(state, props.baz).foo);\nconst bar = useSelector(state => expensive(state, props.baz).bar);\n});\n\n...where `baz` is a prop. Then also consider the situation where this is used in a component that is instantiated multiple times (e.g. a set of children where each `baz` is a different id).\n\nMultiple selectors won't help. You want to build a memoized selector factory, with a memo'ed caching selector for each component instance. Which is fine (and what you'd do with reselect for example); it's just that shallow equality would be so much simpler, and one of the reasons why react-redux opted to support it in addition to allowing consumers roll up their own memoization strategies, instead of enforcing them.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T10:45:40+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621759673","fragment_type":"issue_comment","sequence":21,"text":"Thanks for a concrete example. Totally makes sense.\n(In my redux apps, I would do expensive work in reducers, and all selectors are just \"selecting\" parts of state. That's not always the case for everyone, though.)\n\nHere's a rough idea. There might be some issues in CM. 🤔 \n\njs\nconst useSelectorWithEqlFn = (selector, eqlFn) => {\n const ref = useRef();\n const patchedSelector = useCallback((state) => {\n const selected = selector(state);\n if (eqlFn(ref.current, selected)) {\n return ref.current;\n }\n ref.current = selected;\n return selected;\n }, [selector, eqlFn]);\n return useSelector(patchedSelector);\n};","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-04-30T10:52:51+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621823962","fragment_type":"issue_comment","sequence":22,"text":"@dai-shi While that works fine, that would trigger a re-render wouldn't it? My point wasn't necessarily about receiving a memoized object for the consumer code, but making sure that the components don't rerender in the first place.","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T13:08:47+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_621830686","fragment_type":"issue_comment","sequence":23,"text":"Scratch that, I think that should work fine. You'd also need to be careful that `selector` is itself handled via `useCallback`. It's a mountain of hooks :)","author_login":"victorporof","author_association":"NONE","created_at":"2020-04-30T13:19:49+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622028224","fragment_type":"issue_comment","sequence":24,"text":"Wow this blew up :)\n\nYes @victorporof gave a reasonable example use case. Mine was pulling from multiple parts of the state, contingent on a null check. Here's a simplified example:\n\nconst foo = useSelector(s => s.flag && s.foos[fooId]);\nconst bar = useSelector(s => s.flag && s.bars[barId]);\n\nwhich could be better replaced by\n\nconst foo = useSelector(s => flag && ({ foo: s.foos[fooId], bar: s.bars[barId] }), shallowEqual);\n\nI use typescript and sadly the first version loses the proof that `foo` and `bar` are either both null or both present. And I don't want to push this projection into the state itself, because that would create duplication of data and consistency issues (I use this library like one is encouraged to use redux, with normalised immutable state).\n\nThe other obvious workaround is to use reselect and I think it's fair to recommend that instead :)","author_login":"robeady","author_association":"NONE","created_at":"2020-04-30T18:35:26+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622051470","fragment_type":"issue_comment","sequence":25,"text":"I haven't actually used reselect before - I looked at the documentation, and had some trouble understanding how to apply it to my example. Would it be like this?\n\nconst fooAndBarSelector = useMemo(() =>\n createSelector(\n s => s.flag,\n s => s.foos[fooId],\n s => s.bars[barId],\n (flag, foo, bar) => flag && { foo, bar },\n ),\n)\nconst fooAndBar = useSelector(fooAndBarSelector)\n\nI guess that works although it's quite finicky","author_login":"robeady","author_association":"NONE","created_at":"2020-04-30T19:17:00+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622058481","fragment_type":"issue_comment","sequence":26,"text":"Or maybe this works? reselect docs have some room for improvement regarding extra arguments :)\n\n// top level\nconst fooAndBarSelector = useMemo(\n createSelector(\n s => s.flag,\n (s, { fooId }) => s.foos[fooId],\n (s, { barId }) => s.bars[barId],\n (flag, foo, bar) => flag && { foo, bar },\n ),\n)\n// in my component\nconst fooAndBar = useSelector(s => fooAndBarSelector(s, { fooId, barId }))\n\nwith the caveat that there has to be one `fooAndBarSelector` per instance of the component (luckily I have just one)","author_login":"robeady","author_association":"NONE","created_at":"2020-04-30T19:29:57+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622163245","fragment_type":"issue_comment","sequence":27,"text":"I hadn't thought about this, but it's very convincing. Thanks for the use case.\n \n\nIt's more like `useRef` has to be used carefully in Concurrent Mode.\n \n\nYou want to avoid accessing `s.foos` if the flag is falsy. So, maybe something like this?\n\njs\nconst fooAndBarSelector = createSelector(\n s => s.flag,\n (s, { fooId }) => s.flag && s.foos[fooId],\n (s, { barId }) => s.flag && s.bars[barId],\n (flag, foo, bar) => flag && { foo, bar },\n)","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-04-30T23:00:30+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622178450","fragment_type":"issue_comment","sequence":28,"text":"To circle back around, are there any implications of concurrent mode and/or useMutableSource on the notion of introducing a custom equality function parameter? \n\nOr, is that a separate discussion, and is the main issue with the custom equality function idea one of API design and steering usage in the right way?","author_login":"robeady","author_association":"NONE","created_at":"2020-04-30T23:47:59+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622272071","fragment_type":"issue_comment","sequence":29,"text":"Besides my preference on API design, `useRef` is very difficult to use in CM. Looking back `useSelectorWithEqlFn` in URL , I hope it works in CM, but not 100% confident.\n\nSome references:\n- URL \n- URL","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-05-01T06:43:28+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[608689125],"is_known_query_context":false},{"document_id":"gh_comment_622510721","fragment_type":"issue_comment","sequence":30,"text":"Reading those links there doesn't seem to be a place for this custom equality function idea with useMutableSource. But I found the API highly confusing. I was particular confused by the redux example\n\nfunction Example() {\n // The user-provided selector should be memoized with useCallback.\n // This will prevent unnecessary re-subscriptions each update.\n // This selector can also use e.g. props values if needed.\n const memoizedSelector = useCallback(state => state.users, []);\n \n // The Redux hook will connect user code to useMutableSource.\n const users = useSelector(memoizedSelector);\n\nthat doesn't look very ergonomic or similar to how anybody uses redux selectors today... am I missing something here?","author_login":"robeady","author_association":"NONE","created_at":"2020-05-01T18:40:24+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_622582548","fragment_type":"issue_comment","sequence":31,"text":"`useSelectorWithEqlFn` creates memoized selector (and you need to pass stable `selector` and `eqlFn`).\n\nI'm not sure if I understand your point. (and I'm not sure if I responded well to your concern.)\n\nBTW, if you are interested in a full implementation with useMutableSource for Redux. I developed this URL . The API is not backward compatible and more like proposing a new pattern.","author_login":"dai-shi","author_association":"OWNER","created_at":"2020-05-01T21:51:04+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_766467359","fragment_type":"issue_comment","sequence":32,"text":"Okay, I may need to change my mind if React supports equalityFn. ref: URL \nIf it lands, we don't need useMutableSource, and there's no restriction.","author_login":"dai-shi","author_association":"OWNER","created_at":"2021-01-25T00:18:30+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_767007512","fragment_type":"issue_comment","sequence":33,"text":"I was thinking about this again recently, actually. I have seen more situations since I opened the issue where `equalityFn` would be useful, I don't remember specific examples right now but I think they are similar to the above, typically whenever you combine an inline non-trivial selector function with typescript type narrowing.","author_login":"robeady","author_association":"NONE","created_at":"2021-01-25T18:06:54+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_767198162","fragment_type":"issue_comment","sequence":34,"text":"It's still doubtful, if react really supports equalityFn. There's probably going to be a big debate.\n\nFor now, we should focus on creating a wrapper.\nRewriting URL \n\njs\nimport { useContextSelector } from 'use-context-selector';\n\nexport const useSelectedContext = (ctx, selector, eqlFn) => {\n const prev = useMemo(() => ({ value: null }), [ctx]);\n const patchedSelector = useCallback((state) => {\n const selected = selector(state);\n if (eqlFn(prev.value, selected)) {\n return prev.value;\n }\n prev.value = selected;\n return selected;\n }, [selector, eqlFn, prev]);\n return useContextSelector(ctx, patchedSelector);\n};","author_login":"dai-shi","author_association":"OWNER","created_at":"2021-01-26T00:23:15+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[608689125],"is_known_query_context":false},{"document_id":"gh_comment_823693625","fragment_type":"issue_comment","sequence":35,"text":"Hopefully this wrapper solution or something similar can be considered as the standard export of the package. I was really hoping to replace Redux with Context API for application state management. While `use-context-selector` seemed promising in this endeavor, not being able to specify an equality function like you can in Redux is a deal-breaker.\n\nThe equality function option would be especially useful when replacing Redux with Context since you usually need to grab both values and methods (mutations) from your context object and so referential equality is a clear problem. With Redux you're doubly covered in this regard, because instead of selecting mutations you dispatch them through a separate mechanism.\n\nHaving the wrapper function mentioned in the above comment as a work-around is great, but I'm unsure how stable the solution is.","author_login":"rhyek","author_association":"NONE","created_at":"2021-04-21T00:39:03+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_823913006","fragment_type":"issue_comment","sequence":36,"text":"While I understand where you are coming from, I'm still not confident if the equalityFn is going to be a mainstream in the React core. I'm not sure either how we can make it CM friendly. My hope is to do some experiment against a new experimental build of React and learn how it behaves (but that doesn't ensure anything for the future React versions.)\n\nWe had some discussions above and some of them are convincing the need of equalityFn. But, if it's about methods or Redux dispatch, I'd suggest to use two hooks.\n\njs\nconst foo = useContextSelector(v => v.state.foo);\nconst dispatch = useContextSelector(v => v.dispatch);\n\n \n\nIt should be just fine at this point. Not sure with concurrent mode thing in the future, but I guess your concern is for the future React too? So, including the workaround in the lib doesn't seem to help, does it?","author_login":"dai-shi","author_association":"OWNER","created_at":"2021-04-21T09:17:32+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_904086066","fragment_type":"issue_comment","sequence":37,"text":"Thanks for this nice hook. I observed a problem that I want to share, maybe it will help others too.\n\nIf you intend to use this hook like this for example:\n\njs\nfunction useSelectedArray(keys: string[]): string[] {\n return useSelectedContext(formStateContext,\n (state) => keys.map(key => state[key]),\n (prev, next) => deepCompare(prev, next))\n}\n\nThe hook will never return the cached value but always a new value. The problem lies in the dependency of the `useMemo` hook which is: `[ctx, selector, eqlFn]`. In the above example, there is always passed a new selector and eqlFn.\n\nTo fix this, I edited the dependency array as follows `[]`. Because in my code I know, the dependencies will never change..\n\nAnother option would probably be to use a `useCallback` hook for the the `selector` and `eqlFn` of `useSelectedArray`. But somehow this felt weird to me. What are your thoughts on this?","author_login":"timbicker","author_association":"NONE","created_at":"2021-08-23T20:10:38+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[608689125],"is_known_query_context":false},{"document_id":"gh_comment_904154632","fragment_type":"issue_comment","sequence":38,"text":"@timbicker Hi, you understand it correctly. My expectation is to use `useCallback`, or what's better is to define those functions outside render whenever possible.\nNow, I know this is controversial, but from library perspective, giving stable function from the library consumer is almost necessary.\nWe have a discussion thread about this for React 18: URL","author_login":"dai-shi","author_association":"OWNER","created_at":"2021-08-23T21:44:05+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_927748302","fragment_type":"issue_comment","sequence":39,"text":"Here is the typescript version:\n\nexport const useEqlContextSelector = (\n ctx: Context ,\n selector: (val: T) => R,\n isEql: (a: R | null, b: R) => boolean\n) => {\n const patchedSelector = useMemo(() => {\n let prevValue: R | null = null;\n\n return (state: T) => {\n const nextValue: R = selector(state);\n\n if (isEql(prevValue, nextValue)) {\n return prevValue;\n }\n return (prevValue = nextValue);\n };\n }, [isEql, selector]);\n\n return useContextSelector(ctx, patchedSelector);\n};","author_login":"quolpr","author_association":"NONE","created_at":"2021-09-27T10:51:48+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1207084913","fragment_type":"issue_comment","sequence":40,"text":"I don't think `useMemo` is need at all, in fact, it's doing the opposite becuase `selector` and `eqlFn` are most likely being updated every render, I believe `useRef` would best serve the purose (storing `prevValue`)\n\nts\nimport { useContextSelector } from 'use-context-selector';\n\nexport const useSelectedContext = (ctx, selector, eqlFn) => {\n const prevValue = useRef(null);\n const patchedSelector = (state) => {\n const nextValue = selector(state);\n if (eqlFn(prevValue.current, nextValuue)) {\n return prevValue.current;\n }\n return (prevValue.current = nextValue);\n }\n };\n return useContextSelector(ctx, patchedSelector);\n};","author_login":"valen214","author_association":"NONE","created_at":"2022-08-05T23:22:40+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1747480028","fragment_type":"issue_comment","sequence":41,"text":"Just found that I implemented pretty similar to this package, but with a bit more features:\n\n1. memoization of returned object is supported by default (and custom equal)\n2. no \"stale props\" problem\n3. has deps for \"selector\" function\n\n URL","author_login":"Morglod","author_association":"NONE","created_at":"2023-10-04T19:07:30+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1747788211","fragment_type":"issue_comment","sequence":42,"text":"Yeah, we recently implemented `useShallow` in Zustand with `useRef`.\n URL","author_login":"dai-shi","author_association":"OWNER","created_at":"2023-10-04T23:32:26+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2468005577","fragment_type":"issue_comment","sequence":43,"text":"FYI, our latest recommendation is URL and if you need custom equality function, `use-sync-external-store` would do:\n\njs\nimport {\n createContext as createContextOrig,\n useContext as useContextOrig,\n useRef,\n} from 'react';\nimport { useSyncExternalStoreWithSelector } from 'use-sync-external-store/with-selector';\n\nexport const createContext = (defaultValue) => {\n const context = createContextOrig();\n const ProviderOrig = context.Provider;\n context.Provider = ({ value, children }) => {\n const storeRef = useRef();\n let store = storeRef.current;\n if (!store) {\n const listeners = new Set();\n store = {\n value,\n subscribe: (l) => { listeners.add(l); return () => listeners.delete(l); },\n notify: () => listeners.forEach((l) => l()),\n }\n storeRef.current = store;\n }\n useEffect(() => {\n if (!Object.is(store.value, value)) {\n store.value = value;\n store.notify();\n }\n });\n return {children} \n };\n return context;\n}\n\nexport const useContextSelector = (context, selector, equalityFn) => {\n const store = useContextOrig(context);\n return useSyncExternalStoreWithSelector(\n store.subscribe,\n () => selector(store.value),\n undefined,\n equalityFn\n );\n};\n\nWith that, let's close this.","author_login":"dai-shi","author_association":"OWNER","created_at":"2024-11-11T12:00:04+08:00","repo_name":"dai-shi/use-context-selector","issue_id":608689125,"issue_number":19,"issue_url":"https://github.com/dai-shi/use-context-selector/issues/19","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0375","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: UnboundLocalError: local variable 'date' referenced before assignment?","query_context":"### Describe the bug.\n\n\"UnboundLocalError: local variable 'date' referenced before assignment\" I am getting this error after trying to load installed models or load outdated models in browser.\n\n### Steps to reproduce the problem.\n\n1. Go to sd-civitai-browser-plus\n2. Press update models\n3. scan for models you need\n4. press load Outdated models to browser\n\n### Expected behavior\n\nnothing works after that\n\n### System info\n\n* Extension version: fbdbc336\n* OS: Windows 11 professional\n* SD-WebUI version: Forge f0.0.17v1.8.0rc-latest-276-g29be1da7\n* Python: 3.10.9\n\n### Console logs\n\nShell\nLaunching Web UI with arguments: --skip-torch-cuda-test --xformers --pin-shared-memory --cuda-malloc --cuda-stream\nUsing cudaMallocAsync backend.\nTotal VRAM 12288 MB, total RAM 32694 MB\nWARNING:xformers:A matching Triton is not available, some optimizations will not be enabled.\nError caught was: No module named 'triton'\nxformers version: 0.0.23.post1\nSet vram state to: NORMAL_VRAM\nAlways pin shared GPU memory\nDevice: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync\nVAE dtype: torch.bfloat16\nCUDA Stream Activated: True\nUsing xformers cross attention\nControlNet preprocessor location: F:\\Forge\\webui\\models\\ControlNetPreprocessor\n[-] ADetailer initialized. version: 24.3.0, num models: 12\nCivitAI Browser+: Aria2 RPC started\nCivitai: API loaded\nLoading weights [488aab7bd7] from F:\\Forge\\webui\\models\\Stable-diffusion\\mklanArtVersion_mklan201art.safetensors\n2024-03-16 13:37:37,015 - ControlNet - INFO - ControlNet UI callback registered.\nmodel_type EPS\nUNet ADM Dimension 2816\nRunning on local URL: URL \n\nTo create a public link, set `share=True` in `launch()`.\nCivitai: Check resources for missing info files\nCivitai: Check resources for missing preview images\nStartup time: 17.6s (prepare environment: 3.9s, import torch: 4.1s, import gradio: 0.9s, setup paths: 0.7s, initialize shared: 0.1s, other imports: 0.5s, load scripts: 4.9s, create ui: 2.1s, gradio launch: 0.2s).\nUsing xformers attention in VAE\nWorking with z of shape (1, 4, 32, 32) = 4096 dimensions.\nUsing xformers attention in VAE\nCivitai: Found 0 resources missing info files\nCivitai: No info found on Civitai\nCivitai: Found 29 resources missing preview images\nCivitai: Found 16 hash matches\nCivitai: Updated 0 preview images\nextra {'cond_stage_model.clip_l.text_projection', 'cond_stage_model.clip_l.logit_scale', 'cond_stage_model.clip_g.transformer.text_model.embeddings.position_ids'}\nTo load target model SDXLClipModel\nBegin to load 1 model\n[Memory Management] Current Free GPU Memory (MB) = 11228.910247802734\n[Memory Management] Model Memory (MB) = 2144.3546981811523\n[Memory Management] Minimal Inference Memory (MB) = 1024.0\n[Memory Management] Estimated Remaining GPU Memory (MB) = 8060.555549621582\nMoving model(s) has taken 0.53 seconds\nModel loaded in 7.0s (load weights from disk: 0.3s, forge load real models: 5.8s, calculate empty prompt: 0.8s).\nCivitAI Browser+: model: \"PontiusMIX.safetensors\" not found on CivitAI servers.\nCivitAI Browser+: \"Mklan Anime version\" is currently outdated.\nCivitAI Browser+: \"RealCartoon3D\" is currently outdated.\nCivitAI Browser+: \"Cora from Mass Effect: Andromeda\" is currently outdated.\nTraceback (most recent call last):\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\routes.py\", line 488, in run_predict\n output = await app.get_blocks().process_api(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\blocks.py\", line 1431, in process_api\n result = await self.call_function(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\blocks.py\", line 1103, in call_function\n prediction = await anyio.to_thread.run_sync(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\anyio\\to_thread.py\", line 33, in run_sync\n return await get_asynclib().run_sync_in_worker_thread(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\anyio\\_backends\\_asyncio.py\", line 877, in run_sync_in_worker_thread\n return await future\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\anyio\\_backends\\_asyncio.py\", line 807, in run\n result = context.run(func, *args)\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\utils.py\", line 707, in wrapper\n response = f(*args, **kwargs)\n File \"F:\\Forge\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_file_manage.py\", line 1144, in load_to_browser\n model_list_return = _api.update_model_list(from_ver=True, tile_count=tile_count)\n File \"F:\\Forge\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py\", line 542, in update_model_list\n HTML = model_list_html(gl.json_data)\n File \"F:\\Forge\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py\", line 325, in model_list_html\n model_card = f' '\nUnboundLocalError: local variable 'date' referenced before assignment\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_2189847980"],"reference_answer":"I've now published an update which fixes the paging issues with the new API! v3.5.0\n\nDo note, it's no longer possible to jump directly to a specific page unless that page has already been visited, this is the result of the new \"cursor\" based paging system which was required due to the amount of models on CivitAI.\n\nAlso another note, currently the API returns the error:\n\nError: 500 Server Error: Internal Server Error for url\n\nQuite often, there is nothing I can do about this, as this is an issue caused by the CivitAI API.\nI assume this will get fixed after some time! :)\nFor the time being, I've made a bug report for it here: #233\n\nOther than that, everything should be working again!\nPlease feel free to create a bug report if you encounter any other issues.","answer_document_id":"gh_comment_2002172350","silver_evidence_path":["gh_comment_2001975092","gh_issue_2189284931","gh_comment_2002172350"],"evidence_issue_ids":[2189847980,2189284931],"source_repo_name":"BlafKing/sd-civitai-browser-plus","source_issue_id":2189847980,"source_issue_number":231,"source_issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/231","target_repo_name":"BlafKing/sd-civitai-browser-plus","target_issue_id":2189284931,"target_issue_number":229,"target_issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","reference_anchor_document_id":"gh_comment_2001975092","reference_answer_author":"BlafKing","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.375,"target_answer_overlap":0.3333},"issue_created_at":"2024-03-16T07:57:56+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2189847980","fragment_type":"issue_description","sequence":0,"text":"[Bug]: UnboundLocalError: local variable 'date' referenced before assignment\n### Describe the bug.\n\n\"UnboundLocalError: local variable 'date' referenced before assignment\" I am getting this error after trying to load installed models or load outdated models in browser.\n\n### Steps to reproduce the problem.\n\n1. Go to sd-civitai-browser-plus\n2. Press update models\n3. scan for models you need\n4. press load Outdated models to browser\n\n### Expected behavior\n\nnothing works after that\n\n### System info\n\n* Extension version: fbdbc336\n* OS: Windows 11 professional\n* SD-WebUI version: Forge f0.0.17v1.8.0rc-latest-276-g29be1da7\n* Python: 3.10.9\n\n### Console logs\n\nShell\nLaunching Web UI with arguments: --skip-torch-cuda-test --xformers --pin-shared-memory --cuda-malloc --cuda-stream\nUsing cudaMallocAsync backend.\nTotal VRAM 12288 MB, total RAM 32694 MB\nWARNING:xformers:A matching Triton is not available, some optimizations will not be enabled.\nError caught was: No module named 'triton'\nxformers version: 0.0.23.post1\nSet vram state to: NORMAL_VRAM\nAlways pin shared GPU memory\nDevice: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync\nVAE dtype: torch.bfloat16\nCUDA Stream Activated: True\nUsing xformers cross attention\nControlNet preprocessor location: F:\\Forge\\webui\\models\\ControlNetPreprocessor\n[-] ADetailer initialized. version: 24.3.0, num models: 12\nCivitAI Browser+: Aria2 RPC started\nCivitai: API loaded\nLoading weights [488aab7bd7] from F:\\Forge\\webui\\models\\Stable-diffusion\\mklanArtVersion_mklan201art.safetensors\n2024-03-16 13:37:37,015 - ControlNet - INFO - ControlNet UI callback registered.\nmodel_type EPS\nUNet ADM Dimension 2816\nRunning on local URL: URL \n\nTo create a public link, set `share=True` in `launch()`.\nCivitai: Check resources for missing info files\nCivitai: Check resources for missing preview images\nStartup time: 17.6s (prepare environment: 3.9s, import torch: 4.1s, import gradio: 0.9s, setup paths: 0.7s, initialize shared: 0.1s, other imports: 0.5s, load scripts: 4.9s, create ui: 2.1s, gradio launch: 0.2s).\nUsing xformers attention in VAE\nWorking with z of shape (1, 4, 32, 32) = 4096 dimensions.\nUsing xformers attention in VAE\nCivitai: Found 0 resources missing info files\nCivitai: No info found on Civitai\nCivitai: Found 29 resources missing preview images\nCivitai: Found 16 hash matches\nCivitai: Updated 0 preview images\nextra {'cond_stage_model.clip_l.text_projection', 'cond_stage_model.clip_l.logit_scale', 'cond_stage_model.clip_g.transformer.text_model.embeddings.position_ids'}\nTo load target model SDXLClipModel\nBegin to load 1 model\n[Memory Management] Current Free GPU Memory (MB) = 11228.910247802734\n[Memory Management] Model Memory (MB) = 2144.3546981811523\n[Memory Management] Minimal Inference Memory (MB) = 1024.0\n[Memory Management] Estimated Remaining GPU Memory (MB) = 8060.555549621582\nMoving model(s) has taken 0.53 seconds\nModel loaded in 7.0s (load weights from disk: 0.3s, forge load real models: 5.8s, calculate empty prompt: 0.8s).\nCivitAI Browser+: model: \"PontiusMIX.safetensors\" not found on CivitAI servers.\nCivitAI Browser+: \"Mklan Anime version\" is currently outdated.\nCivitAI Browser+: \"RealCartoon3D\" is currently outdated.\nCivitAI Browser+: \"Cora from Mass Effect: Andromeda\" is currently outdated.\nTraceback (most recent call last):\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\routes.py\", line 488, in run_predict\n output = await app.get_blocks().process_api(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\blocks.py\", line 1431, in process_api\n result = await self.call_function(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\blocks.py\", line 1103, in call_function\n prediction = await anyio.to_thread.run_sync(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\anyio\\to_thread.py\", line 33, in run_sync\n return await get_asynclib().run_sync_in_worker_thread(\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\anyio\\_backends\\_asyncio.py\", line 877, in run_sync_in_worker_thread\n return await future\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\anyio\\_backends\\_asyncio.py\", line 807, in run\n result = context.run(func, *args)\n File \"F:\\Forge\\webui\\venv\\lib\\site-packages\\gradio\\utils.py\", line 707, in wrapper\n response = f(*args, **kwargs)\n File \"F:\\Forge\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_file_manage.py\", line 1144, in load_to_browser\n model_list_return = _api.update_model_list(from_ver=True, tile_count=tile_count)\n File \"F:\\Forge\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py\", line 542, in update_model_list\n HTML = model_list_html(gl.json_data)\n File \"F:\\Forge\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py\", line 325, in model_list_html\n model_card = f' '\nUnboundLocalError: local variable 'date' referenced before assignment\n\n### Additional information\n\n_No response_","author_login":"pontius911","author_association":"NONE","created_at":"2024-03-16T07:57:56+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189847980,"issue_number":231,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/231","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2001938198","fragment_type":"issue_comment","sequence":1,"text":"Getting same error now\n\n`Traceback (most recent call last):\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\gradio\\routes.py\", line 488, in run_predict\n output = await app.get_blocks().process_api(\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\gradio\\blocks.py\", line 1431, in process_api\n result = await self.call_function(\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\gradio\\blocks.py\", line 1103, in call_function\n prediction = await anyio.to_thread.run_sync(\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\anyio\\to_thread.py\", line 33, in run_sync\n return await get_asynclib().run_sync_in_worker_thread(\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\anyio\\_backends\\_asyncio.py\", line 877, in run_sync_in_worker_thread\n return await future\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\anyio\\_backends\\_asyncio.py\", line 807, in run\n result = context.run(func, *args)\n File \"D:\\StableDiffusion\\venv\\lib\\site-packages\\gradio\\utils.py\", line 707, in wrapper\n response = f(*args, **kwargs)\n File \"D:\\StableDiffusion\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_file_manage.py\", line 1144, in load_to_browser\n model_list_return = _api.update_model_list(from_ver=True, tile_count=tile_count)\n File \"D:\\StableDiffusion\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py\", line 542, in update_model_list\n HTML = model_list_html(gl.json_data)\n File \"D:\\StableDiffusion\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py\", line 325, in model_list_html\n model_card = f' '\nUnboundLocalError: local variable 'date' referenced before assignment`","author_login":"DaisukeVN","author_association":"NONE","created_at":"2024-03-16T10:12:23+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189847980,"issue_number":231,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2001975092","fragment_type":"issue_comment","sequence":2,"text":"There was a change to the api that has completely broken the extension. See here.\n URL","author_login":"Worldgate","author_association":"NONE","created_at":"2024-03-16T12:39:16+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189847980,"issue_number":231,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/231","linked_issue_ids":[2189284931],"is_known_query_context":false},{"document_id":"gh_comment_2002173329","fragment_type":"issue_comment","sequence":3,"text":"This should now be fixed in the new update!\n\nThanks for reporting, I'll mark this as resolved 👍🏻","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-16T23:04:30+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189847980,"issue_number":231,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/231","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2189284931","fragment_type":"issue_description","sequence":0,"text":"[Bug]: totalPages key error\nJust a heads up:\n\nCivitAI has updated their API, and the extension is currently broken.\nI've started working on a fix, but it might take a while since the paging system has been completely changed, which this extension relied on pretty heavily.","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-15T18:58:10+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000457997","fragment_type":"issue_comment","sequence":1,"text":"Not exactly, the bug report was initially for runpod issues, which were likely caused by something else.","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-15T21:24:04+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000478149","fragment_type":"issue_comment","sequence":2,"text":"The bug is that Civitai changed their API, and the key totalPages doesn't exist anymore.","author_login":"debaetsr","author_association":"NONE","created_at":"2024-03-15T21:36:44+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000479527","fragment_type":"issue_comment","sequence":3,"text":"I am aware, already working on a fix as stated in the post👍🏻","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-15T21:38:10+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2000873153","fragment_type":"issue_comment","sequence":4,"text":"Little update:\nThe current code (like most of this extension) is a complete spaghetti mess and it broke a lot more than I anticipated.\n\nAfter trying to patch in fixes for a few hours, it's really not going too well.\nIt's probably possible to patch in enough fixes for the new API but after looking at the abomination that's in front me, I've now opted to re-write most of the API handling code as continuing with the current code would create an ever bigger mess than what's already present.\n\nThis will be quite a lot of work, so it's going to take a while.\nRest assured though, I've got plenty of free time ahead so I'll try my best to get the update out ASAP!","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-16T00:58:45+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2001296121","fragment_type":"issue_comment","sequence":5,"text":"I created an account specifically to say you fully deserve your name ~~and your bio~~\n\nThank you for your time <3","author_login":"Kiramut","author_association":"NONE","created_at":"2024-03-16T02:53:06+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002014148","fragment_type":"issue_comment","sequence":6,"text":"We had to switch to a cursor based model do to the volume of models now. Sorry for the surprise. I'll see if we can at least get those keys put back, but I don't think that alone will fix things here.","author_login":"JustMaier","author_association":"NONE","created_at":"2024-03-16T15:06:19+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002017701","fragment_type":"issue_comment","sequence":7,"text":"Just took a look at the codebase, looks like it's very heavily oriented around pages 😬","author_login":"JustMaier","author_association":"NONE","created_at":"2024-03-16T15:18:39+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002017869","fragment_type":"issue_comment","sequence":8,"text":"No worries, that's okay! makes sense that switching to a cursor-based model was necessary\nI should have an update ready somewhere today that will be compatible with the new cursor system!\n\nOnly change for this extension will be that it will no longer be possible to jump directly to a specific page. which is a consequence of moving away from traditional pagination to a more scalable cursor approach.\n\nI appreciate your efforts in maintaining and improving the API :)","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-16T15:19:10+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002136553","fragment_type":"issue_comment","sequence":9,"text":"Workarrond: For those who still want to download via the plugin, you can do 2 edits then the plugin works. Not as it should but you can browser civitai for urls and paste those in the search of the plugin to download.\n\n- Go to the SD folder\\webui\\extensions\\sd-civitai-browser-plus\\scripts\\civitai_api.py and open it in notepad or a different editor, (i would suggest Notepad ++.)\n- line 327 says model_card = f' '\n changed is to model_card = f' '\n (removed the date, because the list wasn't giving a response to date and throwing an error of date nog begin defined)\n\n- line 481 says total_pages = f\"{json_data['metadata']['totalPages']}\", changed that to total_pages = 1 \n (can be more off course, but you could get empty pages)\n\nYou can just search for the text and replace it off course. Might want to make a backup of the civitai_api.py before editing\n\nThis way the plugin works for now, just 1 page of results for now","author_login":"Xipomus","author_association":"NONE","created_at":"2024-03-16T21:19:05+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002172350","fragment_type":"issue_comment","sequence":10,"text":"I've now published an update which fixes the paging issues with the new API! v3.5.0\n\nDo note, it's no longer possible to jump directly to a specific page unless that page has already been visited, this is the result of the new \"cursor\" based paging system which was required due to the amount of models on CivitAI.\n\nAlso another note, currently the API returns the error:\n\nError: 500 Server Error: Internal Server Error for url\n\nQuite often, there is nothing I can do about this, as this is an issue caused by the CivitAI API.\nI assume this will get fixed after some time! :)\nFor the time being, I've made a bug report for it here: #233\n\nOther than that, everything should be working again!\nPlease feel free to create a bug report if you encounter any other issues.","author_login":"BlafKing","author_association":"OWNER","created_at":"2024-03-16T23:02:03+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2002544277","fragment_type":"issue_comment","sequence":11,"text":"Looks like they have stopped hashing new models. Can anyone confirm?","author_login":"thebeline","author_association":"NONE","created_at":"2024-03-17T17:17:20+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2009788261","fragment_type":"issue_comment","sequence":12,"text":"@thebeline \n \n\nAs I can see on:\nLunarity XL Turbo\nThis brand new model has a hash.","author_login":"schoenid","author_association":"NONE","created_at":"2024-03-20T15:03:10+08:00","repo_name":"BlafKing/sd-civitai-browser-plus","issue_id":2189284931,"issue_number":229,"issue_url":"https://github.com/BlafKing/sd-civitai-browser-plus/issues/229","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0377","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Add comment button should move focus to the new comment?","query_context":"Issues reported by @albinazs as part of WCAG 2.2 accessibility audit.\n\n### Issue Summary\n\nWhen editing pages and adding the first comment, focus doesn't move to the comment box. This works as expected when the comment panel is already opened, but not when it’s closed.\n\nIllustration:\n\nadd comment interaction recording\n\n### Steps to Reproduce\n\n1. Go to any page editing form (for example URL \n2. With the keyboard or mouse, active a \"Add comment\" button next to a field\n3. Observe focus isn’t moving to the commenting box\n\n### Working on this\n\nThis requires investigating the comment implementation in JS/React/Redux. Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.","known_context_document_ids":["gh_issue_2078410239"],"reference_answer":"Update - I closed URL as it was not able to be reviewed and was painful to keep rebasing.\n\nHappy to re-raise this PR again if there is capacity to review.","answer_document_id":"gh_comment_2456829271","silver_evidence_path":["gh_comment_1891430738","gh_issue_1933570370","gh_comment_2456829271"],"evidence_issue_ids":[2078410239,1933570370],"source_repo_name":"wagtail/wagtail","source_issue_id":2078410239,"source_issue_number":11450,"source_issue_url":"https://github.com/wagtail/wagtail/issues/11450","target_repo_name":"wagtail/wagtail","target_issue_id":1933570370,"target_issue_number":11021,"target_issue_url":"https://github.com/wagtail/wagtail/issues/11021","reference_anchor_document_id":"gh_comment_1891430738","reference_answer_author":"lb-","reference_answer_author_association":"MEMBER","quality_score":86.85,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.25,"target_answer_overlap":0.0769},"issue_created_at":"2024-01-12T09:19:44+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2078410239","fragment_type":"issue_description","sequence":0,"text":"Add comment button should move focus to the new comment\nIssues reported by @albinazs as part of WCAG 2.2 accessibility audit.\n\n### Issue Summary\n\nWhen editing pages and adding the first comment, focus doesn't move to the comment box. This works as expected when the comment panel is already opened, but not when it’s closed.\n\nIllustration:\n\nadd comment interaction recording\n\n### Steps to Reproduce\n\n1. Go to any page editing form (for example URL \n2. With the keyboard or mouse, active a \"Add comment\" button next to a field\n3. Observe focus isn’t moving to the commenting box\n\n### Working on this\n\nThis requires investigating the comment implementation in JS/React/Redux. Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-01-12T09:19:44+08:00","repo_name":"wagtail/wagtail","issue_id":2078410239,"issue_number":11450,"issue_url":"https://github.com/wagtail/wagtail/issues/11450","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1891430738","fragment_type":"issue_comment","sequence":1,"text":"Could be a duplicate of URL \n\nPR up with a fix from October last year. URL \n\nJust awaiting a review.","author_login":"lb-","author_association":"MEMBER","created_at":"2024-01-15T07:01:58+08:00","repo_name":"wagtail/wagtail","issue_id":2078410239,"issue_number":11450,"issue_url":"https://github.com/wagtail/wagtail/issues/11450","linked_issue_ids":[1933570370],"is_known_query_context":false},{"document_id":"gh_comment_1893852866","fragment_type":"issue_comment","sequence":2,"text":"Thank you @lb-, yes I believe it is :) I thought we had an issue opened for this but couldn’t find it for some reason.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-01-16T14:25:14+08:00","repo_name":"wagtail/wagtail","issue_id":2078410239,"issue_number":11450,"issue_url":"https://github.com/wagtail/wagtail/issues/11450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1933570370","fragment_type":"issue_description","sequence":0,"text":"Add comment button should move focus to the new comment when the panel is closed\n### Issue Summary\n\nIf the comment panel is closed and you highlight a section of text and click the comment button the text will not be highlighted and an error is produced in the console.\n\nvendor.js?v=673766ba:2 Error: Your focus-trap must have at least one container with at least one tabbable node in it at all times\n[…]\n\n \n\n### Steps to Reproduce\n\n1. Open a page to edit.\n2. Ensure comment panel is closed.\n3. Highlight a section of text and click the comment button in the text editor.\n4. The comment panel will open but the text is not highlighted as intended.\n\nAny other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?\n\n- I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: Yes\n\n### Technical details\n\n- Python version: 3.10\n- Django version: 4.2.2\n- Wagtail version: 5.0.1, have confirmed bug is also in 5.1.2\n- Browser version: Chrome 117 & Firefox 102\n\n### Working on this\n\nThis requires investigating the comment implementation in JS/React/Redux. Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.","author_login":"RichK89","author_association":"NONE","created_at":"2023-10-09T18:17:22+08:00","repo_name":"wagtail/wagtail","issue_id":1933570370,"issue_number":11021,"issue_url":"https://github.com/wagtail/wagtail/issues/11021","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1753635351","fragment_type":"issue_comment","sequence":1,"text":"Thanks, I can confirm this is happening and it appears to be an issue with the comments / side panel (closed) generally, not just for rich text.\n\n<img width=\"2001\" alt=\"Screenshot 2023-10-10 at 5 49 28 am\" src=\" URL \n\n<img width=\"1997\" alt=\"Screenshot 2023-10-10 at 5 48 25 am\" src=\" URL","author_login":"lb-","author_association":"MEMBER","created_at":"2023-10-09T19:50:03+08:00","repo_name":"wagtail/wagtail","issue_id":1933570370,"issue_number":11021,"issue_url":"https://github.com/wagtail/wagtail/issues/11021","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1893850236","fragment_type":"issue_comment","sequence":2,"text":"Thank you for reporting this @RichK89! This was also reported by @albinazs as part of WCAG 2.2 accessibility audit.\n\n### Issue Summary\n\nWhen editing pages and adding the first comment, focus doesn't move to the comment box. This works as expected when the comment panel is already opened, but not when it’s closed.\n\nIllustration:\n\nadd comment interaction recording\n\n### Steps to Reproduce\n\n1. Go to any page editing form (for example URL \n2. With the keyboard or mouse, active a \"Add comment\" button next to a field\n3. Observe focus isn’t moving to the commenting box\n\n### Working on this\n\nThis requires investigating the comment implementation in JS/React/Redux. Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.","author_login":"thibaudcolas","author_association":"MEMBER","created_at":"2024-01-16T14:23:45+08:00","repo_name":"wagtail/wagtail","issue_id":1933570370,"issue_number":11021,"issue_url":"https://github.com/wagtail/wagtail/issues/11021","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894703468","fragment_type":"issue_comment","sequence":3,"text":"Just a reminder @thibaudcolas - a PR with a fix is already up. I have updated your comment about 'working on this'. \n\n URL","author_login":"lb-","author_association":"MEMBER","created_at":"2024-01-16T23:53:48+08:00","repo_name":"wagtail/wagtail","issue_id":1933570370,"issue_number":11021,"issue_url":"https://github.com/wagtail/wagtail/issues/11021","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2456829271","fragment_type":"issue_comment","sequence":4,"text":"Update - I closed URL as it was not able to be reviewed and was painful to keep rebasing.\n\nHappy to re-raise this PR again if there is capacity to review.","author_login":"lb-","author_association":"MEMBER","created_at":"2024-11-05T10:41:51+08:00","repo_name":"wagtail/wagtail","issue_id":1933570370,"issue_number":11021,"issue_url":"https://github.com/wagtail/wagtail/issues/11021","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0378","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Numbers don't update correctly when reordering list items?","query_context":"### Description\n\n**Expected behavior:** When moving items up or down in an ordered list, the list content should move while the list numbers don't, maintaining a proper sequence. \n\n**Buggy behavior:** When moving items up or down in an ordered list, the list numbers follow the content, breaking the proper sequence of the list. \n\n### Reproducing\n\nWrite a list:\n\n1- apple\n2- banana\n3- coconut\n4- daikon\n\nNavigate the caret to list item #2, press `Alt`+`↑` to move that item into #1 position. That yields the following output:\n\n2- banana\n1- apple\n3- coconut\n4- daikon\n\n(I'm using \"2-\", \"1-\" etc. because if I use \"2.\", \"1.\" etc. then github will render them sequentially rather than in my custom order, above.)\n\n### Zettlr Version\n\nBeta (if applicable)\n\n### Specify version\n\n3.0.0-beta.4\n\n### Installation Method\n\nFrom the Website or GitHub\n\n### Your Platform\n\n- [X] Windows\n- [ ] macOS\n- [ ] Linux\n\n### Architecture\n\n- [X] Intel 64bit\n- [ ] ARM 64bit\n\n### Operating System Version\n\nWindows 10\n\n### Additional Information\n\n_No response_","known_context_document_ids":["gh_issue_1709060658"],"reference_answer":"@MediocrityXT The PR you referenced was about continuing the correct numbering, not when you delete an item. And yes, it is hard to fix it and that's why it has not yet been fixed.","answer_document_id":"gh_comment_986778477","silver_evidence_path":["gh_comment_1583844473","gh_issue_639839427","gh_comment_986778477"],"evidence_issue_ids":[1709060658,639839427],"source_repo_name":"Zettlr/Zettlr","source_issue_id":1709060658,"source_issue_number":4327,"source_issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","target_repo_name":"Zettlr/Zettlr","target_issue_id":639839427,"target_issue_number":937,"target_issue_url":"https://github.com/Zettlr/Zettlr/issues/937","reference_anchor_document_id":"gh_comment_1583844473","reference_answer_author":"nathanlesage","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.1471,"target_answer_overlap":0.1818},"issue_created_at":"2023-05-14T20:15:45+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1709060658","fragment_type":"issue_description","sequence":0,"text":"Numbers don't update correctly when reordering list items\n### Description\n\n**Expected behavior:** When moving items up or down in an ordered list, the list content should move while the list numbers don't, maintaining a proper sequence. \n\n**Buggy behavior:** When moving items up or down in an ordered list, the list numbers follow the content, breaking the proper sequence of the list. \n\n### Reproducing\n\nWrite a list:\n\n1- apple\n2- banana\n3- coconut\n4- daikon\n\nNavigate the caret to list item #2, press `Alt`+`↑` to move that item into #1 position. That yields the following output:\n\n2- banana\n1- apple\n3- coconut\n4- daikon\n\n(I'm using \"2-\", \"1-\" etc. because if I use \"2.\", \"1.\" etc. then github will render them sequentially rather than in my custom order, above.)\n\n### Zettlr Version\n\nBeta (if applicable)\n\n### Specify version\n\n3.0.0-beta.4\n\n### Installation Method\n\nFrom the Website or GitHub\n\n### Your Platform\n\n- [X] Windows\n- [ ] macOS\n- [ ] Linux\n\n### Architecture\n\n- [X] Intel 64bit\n- [ ] ARM 64bit\n\n### Operating System Version\n\nWindows 10\n\n### Additional Information\n\n_No response_","author_login":"noah-arroyo","author_association":"NONE","created_at":"2023-05-14T20:15:45+08:00","repo_name":"Zettlr/Zettlr","issue_id":1709060658,"issue_number":4327,"issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1578808803","fragment_type":"issue_comment","sequence":1,"text":"I'm having a look into this issue now. Should hopefully have more details and potentially a PR up soon.","author_login":"Kinack987","author_association":"NONE","created_at":"2023-06-06T13:50:45+08:00","repo_name":"Zettlr/Zettlr","issue_id":1709060658,"issue_number":4327,"issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1580451610","fragment_type":"issue_comment","sequence":2,"text":"I've played around with this a bit and it isn't specific to moving lines with alt+up/alt+down, ordered lists item numbers don't update in general when altering them in some way (For example, if you have list 1 2 3 4 5 6, and you copy element 6 to clipboard then paste it above element 2, the list is now ordered 1 6 2 3 4 5) (The same behaviour as described above, but occurs in general when moving items around in existing lists).","author_login":"mattstring","author_association":"CONTRIBUTOR","created_at":"2023-06-07T10:26:44+08:00","repo_name":"Zettlr/Zettlr","issue_id":1709060658,"issue_number":4327,"issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583844473","fragment_type":"issue_comment","sequence":3,"text":"I've opened a pull request #4406 to fix this issue. However, for now, I have only addressed the case of moving lines with alt+up/alt+down. There is another pinned issue #937 open since 2020 which addresses the issue of fixing list numbers when deleting / copy-pasting items in an ordered list. As such, I'd suggest this issue could be safely closed if the above pull request is found to be sufficient.","author_login":"Kinack987","author_association":"NONE","created_at":"2023-06-09T02:22:55+08:00","repo_name":"Zettlr/Zettlr","issue_id":1709060658,"issue_number":4327,"issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","linked_issue_ids":[639839427],"is_known_query_context":false},{"document_id":"gh_comment_1586493061","fragment_type":"issue_comment","sequence":4,"text":"Ah gotcha, good catch. Guessing this requires someone else's weigh in -- I don't object to what you're describing.","author_login":"noah-arroyo","author_association":"NONE","created_at":"2023-06-12T02:48:44+08:00","repo_name":"Zettlr/Zettlr","issue_id":1709060658,"issue_number":4327,"issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1595790085","fragment_type":"issue_comment","sequence":5,"text":"As I've also written in the PR: There is this function that can automatically correct list markers for those lists that are touched by any of the selections within the editor.\n\nUnder the assumption that this function works as expected (which I'd love to have another person double check), then we could simply write a `transactionExtender` that *always* triggers if the document contents have been changed. This includes, but is not limited to, exchanging lines, adding new ones, deleting items, pasting content, and so on. This would also eliminate the current \"sonderweg\" we have to do with the tab character (list item indentation).","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2023-06-17T15:38:55+08:00","repo_name":"Zettlr/Zettlr","issue_id":1709060658,"issue_number":4327,"issue_url":"https://github.com/Zettlr/Zettlr/issues/4327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_639839427","fragment_type":"issue_description","sequence":0,"text":"[ENHANCEMENT] Keeping numbering consistent when deleting items from a numbered list\n## Description\n\nThere should be a way to keep numbering consistent when deleting items from a numbered list.\nWhat I’m talking about is: suppose you have a list like\n\n1. one\n2. two\n3. three\n4. four\n\nThen you delete point 2. You are left with\n\n1. one\n3. three\n4. four\n\nThat’s not a problem if you export the content but when you e.g. copy Markdown, the inconsistency is still there. It would be better if there was some way to recalculate the numbering.\n\n \n## Proposed Changes\n\nI can think of two possible ways to solve this.\n\n(1) When one presses enter to create a new list item, the numbering could be automatically recalculated, so instead of\n\n1. one\n3. three\n4. four\n5.\n\nit would be\n\n1. one\n2. three\n3. four\n4.\n\nRecalculating should also be done on indent change as it effectively creates new lists?\n\n(2) A context menu item that would allow to recalculate numbering in the currently selected list\n\n \n## Caveats\n\n \n## Additional Information","author_login":"peczony","author_association":"NONE","created_at":"2020-06-16T17:16:18+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647763343","fragment_type":"issue_comment","sequence":1,"text":"Side note: GitHub supports the following:\n\n1. a\n1. b\n1. c\n\nand it'll render as\n\n1. a\n2. b\n3. c\n\nas demonstrated:\n1. a\n1. b\n1. c\n\nA similar approach will simplify all numbering. I don't know how this affects other systems though (but if it does, perhaps it's time for this to become a standard?).","author_login":"sebastienvercammen","author_association":"NONE","created_at":"2020-06-22T20:51:40+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_647949918","fragment_type":"issue_comment","sequence":2,"text":"In Zettlr, you can also do lists like such:\n\n#. One\n#. Two\n#. Three\n\nAnd it'll automatically number; because this is a feature of Pandoc. Oh, and we might want to support that in the list indentation as well … let's remember this!","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2020-06-23T07:00:04+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_648056556","fragment_type":"issue_comment","sequence":3,"text":"Sure, I’m totally fine with `1. 1.` or `#. #.` syntax. On the other hand it would be convenient to quickly see what the resulting numbering would be without first exporting the content. Like some hotkey for quick non-editable preview maybe?","author_login":"peczony","author_association":"NONE","created_at":"2020-06-23T10:31:53+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_648075300","fragment_type":"issue_comment","sequence":4,"text":"Of course, but there's no hotkey necessary. Just some improvements to the underlying algorithm, which is currently based on a CodeMirror plugin. We'd need to rewrite that thing. Possible, but quite some work!","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2020-06-23T11:07:05+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_648963640","fragment_type":"issue_comment","sequence":5,"text":"I mean maybe “show quick html preview instead of editable text” is less work than rewriting the plugin, with the same effect (and maybe even better for some use cases) :)","author_login":"peczony","author_association":"NONE","created_at":"2020-06-24T17:37:56+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_649045501","fragment_type":"issue_comment","sequence":6,"text":"Actually it's the opposite :D At least when it comes to sane code and my own mental health! ;D","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2020-06-24T20:12:57+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_782358131","fragment_type":"issue_comment","sequence":7,"text":"It's not a bug, it's simply that the algorithm is not as smart as it could be ;)","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2021-02-19T21:17:35+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_920732249","fragment_type":"issue_comment","sequence":8,"text":"I would just like to be able to set an option for the numbered list to not at all increment the numbers, but just put 1., 1., 1.\nThis would solve all problems from above. It is also the standard accepted by GitLab.\nIt is also better for when you view diffs in version control.","author_login":"braykov","author_association":"NONE","created_at":"2021-09-16T09:17:39+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_922073300","fragment_type":"issue_comment","sequence":9,"text":"@braykov Mh, in the Pandoc-context the equivalent would be `#.`. I'm not sure if the editor accepts this syntax, though …","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2021-09-17T20:49:42+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_922251306","fragment_type":"issue_comment","sequence":10,"text":"@nathanlesage unfortunately that is not standard and not supported by GitLab.","author_login":"braykov","author_association":"NONE","created_at":"2021-09-18T09:54:48+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_986425074","fragment_type":"issue_comment","sequence":11,"text":"Need this EHANCEMENT!!! The long numbering list makes me really annoyed when lots of numbering need rewriting.\nrecent numbering fixing dates back to 2018...\nAfter you press enter and generate a new list item, rewrite all items' numbering after the new item.I guess it's not that hard but don't know why nobody fix it","author_login":"MediocrityXT","author_association":"NONE","created_at":"2021-12-06T04:20:00+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_986778477","fragment_type":"issue_comment","sequence":12,"text":"@MediocrityXT The PR you referenced was about continuing the correct numbering, not when you delete an item. And yes, it is hard to fix it and that's why it has not yet been fixed.","author_login":"nathanlesage","author_association":"MEMBER","created_at":"2021-12-06T13:30:53+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1194817663","fragment_type":"issue_comment","sequence":13,"text":"May I also add to the question that whenever I try to do something like\n1. first point\n2. second point \n3. third point\n\nand then have sub-points under it like \n1. first point\n * sub\n3. second point\n\nit will leave the list as 1., 3. and skipping 2 - that is really a bummer as it makes numbered lists unusable for me.","author_login":"yin-ori","author_association":"NONE","created_at":"2022-07-26T00:29:57+08:00","repo_name":"Zettlr/Zettlr","issue_id":639839427,"issue_number":937,"issue_url":"https://github.com/Zettlr/Zettlr/issues/937","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0379","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"remove political capital from the game?","query_context":"the system where you unlock scenarios and upgrade units is now out of scope\n\nwhat can be fun instead is a simple high score system. we can display it to the player on the score tally modal\n\n(the reason i suggest anything in its stead is because _earning_ political capital is already implemented. players just can't buy anything with it)","known_context_document_ids":["gh_issue_1718621665"],"reference_answer":"implemented in:\n- eccf122960cbb15ef3c68fbe0670b261a5d8ba61\n- 09e5f28222c91772c1776f6c45b4d1faabf2a5bb\n- b3b5fa039f57194bb1d550fa1844a28242ab668c\n- other surrounding commits","answer_document_id":"gh_comment_1592045757","silver_evidence_path":["gh_comment_1586499131","gh_issue_1740636955","gh_comment_1592045757"],"evidence_issue_ids":[1718621665,1740636955],"source_repo_name":"mucrow/MobileTowerDefense","source_issue_id":1718621665,"source_issue_number":46,"source_issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/46","target_repo_name":"mucrow/MobileTowerDefense","target_issue_id":1740636955,"target_issue_number":57,"target_issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/57","reference_anchor_document_id":"gh_comment_1586499131","reference_answer_author":"mucrow","reference_answer_author_association":"OWNER","quality_score":70.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1176,"target_answer_overlap":0.0},"issue_created_at":"2023-05-21T19:56:43+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1718621665","fragment_type":"issue_description","sequence":0,"text":"remove political capital from the game\nthe system where you unlock scenarios and upgrade units is now out of scope\n\nwhat can be fun instead is a simple high score system. we can display it to the player on the score tally modal\n\n(the reason i suggest anything in its stead is because _earning_ political capital is already implemented. players just can't buy anything with it)","author_login":"mucrow","author_association":"OWNER","created_at":"2023-05-21T19:56:43+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1718621665,"issue_number":46,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/46","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1575165876","fragment_type":"issue_comment","sequence":1,"text":"worked on this in 851e956 and a20ce5c\n\nneed to restore DefeatScoreTallyModal buttons","author_login":"mucrow","author_association":"OWNER","created_at":"2023-06-03T19:59:56+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1718621665,"issue_number":46,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/46","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575174636","fragment_type":"issue_comment","sequence":2,"text":"oops, actually, political capital is no longer mentioned on the scoretallymodal, but it's still in the save data.\n\ni need to replace political capital with high scores","author_login":"mucrow","author_association":"OWNER","created_at":"2023-06-03T20:20:18+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1718621665,"issue_number":46,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/46","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1575175192","fragment_type":"issue_comment","sequence":3,"text":"actually no i don't. all i still need to do for this ticket is search the codebase for mentions of political capital and gut what needs to be gutted.\n\na high score system is a separate feature which i have notated in #56 (though i dont think it will be prioritized)","author_login":"mucrow","author_association":"OWNER","created_at":"2023-06-03T20:22:28+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1718621665,"issue_number":46,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/46","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1586499131","fragment_type":"issue_comment","sequence":4,"text":"i should do #57 first so i dont brick my ability to test on ios (ios doesnt give me a way to clear an app's save data, tho i could just uninstall the whole thing)","author_login":"mucrow","author_association":"OWNER","created_at":"2023-06-12T02:59:38+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1718621665,"issue_number":46,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/46","linked_issue_ids":[1740636955],"is_known_query_context":false},{"document_id":"gh_issue_1740636955","fragment_type":"issue_description","sequence":0,"text":"settings menu\n- [x] music volume slider\n- [x] sound effect volume slider\n- [ ] ~~disable cutscenes button~~\n- [x] erase save data button\n - [x] erase save data confirmation modal","author_login":"mucrow","author_association":"OWNER","created_at":"2023-06-04T22:24:54+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1740636955,"issue_number":57,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1592045757","fragment_type":"issue_comment","sequence":1,"text":"implemented in:\n- eccf122960cbb15ef3c68fbe0670b261a5d8ba61\n- 09e5f28222c91772c1776f6c45b4d1faabf2a5bb\n- b3b5fa039f57194bb1d550fa1844a28242ab668c\n- other surrounding commits","author_login":"mucrow","author_association":"OWNER","created_at":"2023-06-14T21:58:24+08:00","repo_name":"mucrow/MobileTowerDefense","issue_id":1740636955,"issue_number":57,"issue_url":"https://github.com/mucrow/MobileTowerDefense/issues/57","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0380","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Unclear TensorRT version match?","query_context":"**Description**\nI use the docker containers to export an ONNX model to TenosrRT to use with the triton server. Each release of URL always expects a specific version of TensorRT, but this version does not exactly match the version of the Triton server. So it is unclear to me which release of onnx-tensorrt I should match with which release of triton-infernce-server?","known_context_document_ids":["gh_issue_1127531600"],"reference_answer":"I would recommend using trtexec over onnx2trt as the CLI interface for converting ONNX models into TensorRT engines since it is more actively maintained. \n\nonnx2trt hasn't been updated in a while, and we are planning to deprecate it in favor of trtexec soon.","answer_document_id":"gh_comment_752759384","silver_evidence_path":["gh_comment_1033238586","gh_issue_654488247","gh_comment_752759384"],"evidence_issue_ids":[1127531600,654488247],"source_repo_name":"triton-inference-server/server","source_issue_id":1127531600,"source_issue_number":3904,"source_issue_url":"https://github.com/triton-inference-server/server/issues/3904","target_repo_name":"onnx/onnx-tensorrt","target_issue_id":654488247,"target_issue_number":500,"target_issue_url":"https://github.com/onnx/onnx-tensorrt/issues/500","reference_anchor_document_id":"gh_comment_1033238586","reference_answer_author":"kevinch-nv","reference_answer_author_association":"COLLABORATOR","quality_score":86.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.25,"target_answer_overlap":0.1818},"issue_created_at":"2022-02-08T17:11:09+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1127531600","fragment_type":"issue_description","sequence":0,"text":"Unclear TensorRT version match\n**Description**\nI use the docker containers to export an ONNX model to TenosrRT to use with the triton server. Each release of URL always expects a specific version of TensorRT, but this version does not exactly match the version of the Triton server. So it is unclear to me which release of onnx-tensorrt I should match with which release of triton-infernce-server?","author_login":"Michelvl92","author_association":"NONE","created_at":"2022-02-08T17:11:09+08:00","repo_name":"triton-inference-server/server","issue_id":1127531600,"issue_number":3904,"issue_url":"https://github.com/triton-inference-server/server/issues/3904","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1032896785","fragment_type":"issue_comment","sequence":1,"text":"You can use our `trtexec` from Nvidia's TensorRT container release to convert onnx to trt model. The generated model would be compatible with corresponding release of Triton. For instance, model generated with 22.01 TRT container will work with 22.01 Triton container.\n URL","author_login":"tanmayv25","author_association":"CONTRIBUTOR","created_at":"2022-02-08T17:52:29+08:00","repo_name":"triton-inference-server/server","issue_id":1127531600,"issue_number":3904,"issue_url":"https://github.com/triton-inference-server/server/issues/3904","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1033238586","fragment_type":"issue_comment","sequence":2,"text":"You can find more about the difference here: URL \nClosing the issue now. Please re-open if you have any other questions.","author_login":"tanmayv25","author_association":"CONTRIBUTOR","created_at":"2022-02-09T01:32:00+08:00","repo_name":"triton-inference-server/server","issue_id":1127531600,"issue_number":3904,"issue_url":"https://github.com/triton-inference-server/server/issues/3904","linked_issue_ids":[654488247],"is_known_query_context":false},{"document_id":"gh_issue_654488247","fragment_type":"issue_description","sequence":0,"text":"[Question] onnx2trt vs trtexec --onnx\nHi, what's the difference between `onnx2trt` and `trtexec --onnx`? Are they the same thing? If not, is one preferred over the other? Also if different, and if I need to add a onnx parser plugin for a custom layer, should I use one over the other?\n\nAlso, I don't see an engine.serialize() option for `onnx_tensorrt.tensorrt_engine.Engine`, compared to `tensorrt.ICudaEngine`. Is there a major difference between Engine and ICudaEngine, and is there a way to save Engine to trt file?","author_login":"austinmw","author_association":"NONE","created_at":"2020-07-10T03:46:59+08:00","repo_name":"onnx/onnx-tensorrt","issue_id":654488247,"issue_number":500,"issue_url":"https://github.com/onnx/onnx-tensorrt/issues/500","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_749043383","fragment_type":"issue_comment","sequence":1,"text":"Does anyone have info on this? Especially the second question for me personally","author_login":"casbolwerk","author_association":"NONE","created_at":"2020-12-21T15:50:29+08:00","repo_name":"onnx/onnx-tensorrt","issue_id":654488247,"issue_number":500,"issue_url":"https://github.com/onnx/onnx-tensorrt/issues/500","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_752759384","fragment_type":"issue_comment","sequence":2,"text":"I would recommend using trtexec over onnx2trt as the CLI interface for converting ONNX models into TensorRT engines since it is more actively maintained. \n\nonnx2trt hasn't been updated in a while, and we are planning to deprecate it in favor of trtexec soon.","author_login":"kevinch-nv","author_association":"COLLABORATOR","created_at":"2020-12-30T21:09:52+08:00","repo_name":"onnx/onnx-tensorrt","issue_id":654488247,"issue_number":500,"issue_url":"https://github.com/onnx/onnx-tensorrt/issues/500","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_787699035","fragment_type":"issue_comment","sequence":3,"text":"Can you please tell me how to add multiple optimisation profiles using trtexec. I can't seem to find any example anywhere. I know it is possible to do using Python and C++ API but I've no idea about trtexec.\n\nThanks","author_login":"Sayyam-Jain","author_association":"NONE","created_at":"2021-03-01T06:51:54+08:00","repo_name":"onnx/onnx-tensorrt","issue_id":654488247,"issue_number":500,"issue_url":"https://github.com/onnx/onnx-tensorrt/issues/500","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_788354097","fragment_type":"issue_comment","sequence":4,"text":"@kevinch-nv Thank you but I meant Optimisation Profiles where I can set multiple min, opt and max sizes for different optimisation profiles. \n\nEg. like this: URL \nbut only using trtexec. Using trtexec, I can set maximum only 1 profile (min, opt & max) but with Python API you can add multiple such profiles","author_login":"Sayyam-Jain","author_association":"NONE","created_at":"2021-03-01T22:35:43+08:00","repo_name":"onnx/onnx-tensorrt","issue_id":654488247,"issue_number":500,"issue_url":"https://github.com/onnx/onnx-tensorrt/issues/500","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0381","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Editing with Synchronised Clips Causes Random Glitches During Playback?","query_context":"Hi there,\nI am doing my first project with BrawTool in FCPX and i have a huge problem. When i trim a clip on the timeline the trimviewer don't move and it doesn't trim either. Strangely enough it trims when i do it at the end of the clip. See screenVid of the problem.\nI hope this is some weird glitch which can be solve soon or i have to revert back to resolve to edit. Please help.\nI restarted fcpx several times and also my mac studio. No solution. \n\n URL","known_context_document_ids":["gh_issue_1676906261"],"reference_answer":"@tangierc - You'll find this interesting...\n\nApple has gotten back to us after reviewing this, and believe it or not, it's actually got nothing to do with BRAW Toolbox itself, it's because we're applying it to a static generator! If you add keyframes to the generator or if you replace the generator with something like \"Clouds\" it'll fix the issue!\n\nWe'll investigate a proper fix in BRAW Toolbox soon, and try and find a solution for fixing existing libraries - which should be easy, as we can just replace the static generator with Clouds, etc.","answer_document_id":"gh_comment_1579617836","silver_evidence_path":["gh_comment_1539271014","gh_issue_1701164620","gh_comment_1579617836"],"evidence_issue_ids":[1676906261,1701164620],"source_repo_name":"latenitefilms/BRAWToolbox","source_issue_id":1676906261,"source_issue_number":116,"source_issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","target_repo_name":"latenitefilms/BRAWToolbox","target_issue_id":1701164620,"target_issue_number":128,"target_issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/128","reference_anchor_document_id":"gh_comment_1539271014","reference_answer_author":"latenitefilms","reference_answer_author_association":"OWNER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2,"target_answer_overlap":0.3056},"issue_created_at":"2023-04-20T15:01:01+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1676906261","fragment_type":"issue_description","sequence":0,"text":"Editing with Synchronised Clips Causes Random Glitches During Playback\nHi there,\nI am doing my first project with BrawTool in FCPX and i have a huge problem. When i trim a clip on the timeline the trimviewer don't move and it doesn't trim either. Strangely enough it trims when i do it at the end of the clip. See screenVid of the problem.\nI hope this is some weird glitch which can be solve soon or i have to revert back to resolve to edit. Please help.\nI restarted fcpx several times and also my mac studio. No solution. \n\n URL","author_login":"Droffelt","author_association":"NONE","created_at":"2023-04-20T15:01:01+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1517065601","fragment_type":"issue_comment","sequence":1,"text":"Can you please try creating Multicam Clips from BRAW Toolbox instead and see if the problem remains?\n\n URL","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-04-20T23:44:57+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1517490545","fragment_type":"issue_comment","sequence":2,"text":"Hi thanks for answering. Multicam clips seems to work, but i already imported 7 days of shooting and meta tagged all shots. Costed me a day's work. Can i convert existing clips to multicam or is there a way to duplicate all metadata to the clips if i have to import again?","author_login":"Droffelt","author_association":"NONE","created_at":"2023-04-21T08:46:30+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1517678000","fragment_type":"issue_comment","sequence":3,"text":"Could you send me the Final Cut Pro library and I'll have a look?\n\nYou can upload here:\n\n URL \n\nI'll also report this issue to Apple. Are you on the latest Ventura by any chance?\n\nOne potential workaround is to \"Open Clip\" on each Synchronised Clip and try either move it above the primary storyline or make it a Compound Clip.","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-04-21T11:22:33+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1517743172","fragment_type":"issue_comment","sequence":4,"text":"I am on Ventura 13.1 Should i update to 13.3.1 and try again?","author_login":"Droffelt","author_association":"NONE","created_at":"2023-04-21T12:19:34+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1520932365","fragment_type":"issue_comment","sequence":5,"text":"No, I don't think updating to Ventura 13.3.1 will have any impact on this particular problem, and if you have a lot of Audio Units, 13.3.1 could cause issues with validating audio plugins.\n\nThanks for sending across your library. Are you able to `.ZIP` it up first, then send it across again? I think because it uploaded the library as if it was a folder, some of the file names went a bit funky. Just right click on the library and press the \"Compress\" option in Finder to make it a `.ZIP` file.\n\nAs far as I can tell, it seems to be a bug/problem with Final Cut Pro itself, rather than anything specifically wrong with how BRAW Toolbox works. Synchronised Clips don't seem to update/work properly when they only have a Generator inside. The only way to force Final Cut Pro to update them correctly seems to be to wrap them either in a Compound Clip or a Multicam Clip.\n\nI will do some investigating to see if we can add something to the Workflow Extension to wrap any BRAW Toolbox Synchronised Clips inside a Multicam or Compound Clip. I'll also investigate just making **Create Multicam Clips** the default option. I'll also keep chatting with the Final Cut Pro team to see if they can provide any insight on their end.\n\nMy sincerest apologies - I know this is extremely frustrating when you've already logged 7 days of shooting!","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-04-24T23:04:11+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1529406987","fragment_type":"issue_comment","sequence":6,"text":"Hi @latenitefilms any progress on this issue?\n\nI'm experiencing the exact issue mentioned in this ticket. We imported 35 days of footage without using create Multicam Clips. Bit hard to go back and do that work again. Any help would be greatly appreciated!\n\nM.","author_login":"mdonnellymedia","author_association":"NONE","created_at":"2023-05-01T06:42:49+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1529409993","fragment_type":"issue_comment","sequence":7,"text":"Have you already started editing in a project/timeline, or are you just key-wording/favouriting in the browser at this stage?\n\nThe only manual fix I know currently is to open up each Synchronised Clip, and turn the Generator into a Compound Clip. If you head down this route, obviously try it on one clip first to make sure it works before you do to lots of clips.\n\nThis is a tricky one, as I haven't been able to reproduce the issue myself. I'm on macOS Monterey 12.6.3 & FCPX 10.6.5. If you're able to create a small library that demonstrates this issue that you can send, that would be a big help.\n\nI'm still looking into a workaround, where you can convert Synchronised Clips into Multicam Clips, but it's somewhat complex - hence why there's no quick/easy fix.","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-01T06:49:13+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1529411721","fragment_type":"issue_comment","sequence":8,"text":"Thanks for the info, at the moment the issue happens randomly so were not sure how bad those fixes will stack up. We're Melbourne based and you're more than welcome to remote into our editing machine to take a look if that helps everyone else too.","author_login":"mdonnellymedia","author_association":"NONE","created_at":"2023-05-01T06:53:10+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1529463452","fragment_type":"issue_comment","sequence":9,"text":"Are you able to send me your Final Cut Pro library? You can upload here:\n\n URL","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-01T08:05:54+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537571126","fragment_type":"issue_comment","sequence":10,"text":"Tengo problemas al editar, al cortar el clip, del lugar donde corto pone el inicio del clip!! que estoy haciendo mal? \n\n URL","author_login":"Sanvid779","author_association":"NONE","created_at":"2023-05-07T23:50:19+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537601358","fragment_type":"issue_comment","sequence":11,"text":"@Sanvid779 writes:\n \n\nCan you please try using Multicam Clips instead?\n\nSee: URL","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-08T01:07:34+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537605296","fragment_type":"issue_comment","sequence":12,"text":"lo intentare, la pregunta seria estos clips están grabados con audio de cámara de referencia, y con sonido directo, al hacer la multicámara como sincronizo el audio directo?","author_login":"Sanvid779","author_association":"NONE","created_at":"2023-05-08T01:12:50+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537617122","fragment_type":"issue_comment","sequence":13,"text":"@Sanvid779 writes:\n \n\nIf you're just using the audio on the BRAW files as a guide track, but have timecode synced your camera and an external sound recorder, I would leave the \"Create Multicam Clips\" off, and then use Sync-N-Link to create new Multicam Clips from the Synchronised Clips and location audio:\n\n URL \n\nYou should also be able to do it manually in Final Cut Pro if you're manually syncing with a dumb slate, etc.\n\nBasically, Synchronised Clips currently seem broken for some users in Final Cut Pro - but as soon as you \"wrap\" them in a Multicam Clip, everything works correctly again.","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-08T01:30:29+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1539271014","fragment_type":"issue_comment","sequence":14,"text":"I'm going to close this issue in favour of #128, however feel free to keep replying here if necessary.","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-09T01:41:44+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1676906261,"issue_number":116,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/116","linked_issue_ids":[1701164620],"is_known_query_context":false},{"document_id":"gh_issue_1701164620","fragment_type":"issue_description","sequence":0,"text":"Editing with Synchronised Clips Causes Random Glitches During Playback\n**Apple Feedback Assistant ID:** FB12179665\n\nAs discussed in #115, #116 and elsewhere, there's a bug in Final Cut Pro 10.6.5 that causes Synchronised Clips to **sometimes** play back the wrong frames during playback. This also affects rendering and exporting. It's very frustrating for everyone.\n\nIt doesn't seem to affect skimming, and the correct frames play correctly when using the arrow keys to go frame-by-frame (i.e. if you hold down the right arrow key, it will play back the correct footage).\n\nThe workaround is to always use the **Create Multicam Clips** option in BRAW Toolbox. By wrapping a Synchronised Clip in a Multicam, it seems to fix the issue.\n\nAlternatively, if you **Open Clip** on a BRAW Toolbox Synchronised Clip, and then wrap the Generator on the primary storyline within a Compound Clip, this also seems to fix the issue.\n\nHowever, if you need to sync your BRAW Toolbox Clips with location audio, you can still create Synchronised Clips, then use something like Sync-N-Link or manual Multicam syncing within Final Cut Pro to create new Multicam Clips. Editing with Multicam Clips doesn't seem to have any issues.\n\nI have reached out to the Apple Final Cut Pro team to try and come up with a solution/solve/workaround/bug-fix update.\n\nUnfortunately, at this stage, it seem to be a bug in Final Cut Pro, and not something we can solve in BRAW Toolbox's FxPlug4 code.\n\nI will update this issue if we learn more from Apple, or if we come up with a solution ourselves.\n\nI will be pushing out an update ASAP which turns on **Create Multicam Clips** by default, and will display a warning message if you disable it.","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-09T01:39:02+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1701164620,"issue_number":128,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1539442847","fragment_type":"issue_comment","sequence":1,"text":"BRAW Toolbox v1.1.1 is now on the Mac App Store with the following changes:\n\n<img width=\"1415\" alt=\"image\" src=\" URL","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-05-09T05:43:31+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1701164620,"issue_number":128,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1579617836","fragment_type":"issue_comment","sequence":2,"text":"@tangierc - You'll find this interesting...\n\nApple has gotten back to us after reviewing this, and believe it or not, it's actually got nothing to do with BRAW Toolbox itself, it's because we're applying it to a static generator! If you add keyframes to the generator or if you replace the generator with something like \"Clouds\" it'll fix the issue!\n\nWe'll investigate a proper fix in BRAW Toolbox soon, and try and find a solution for fixing existing libraries - which should be easy, as we can just replace the static generator with Clouds, etc.","author_login":"latenitefilms","author_association":"OWNER","created_at":"2023-06-06T23:59:24+08:00","repo_name":"latenitefilms/BRAWToolbox","issue_id":1701164620,"issue_number":128,"issue_url":"https://github.com/latenitefilms/BRAWToolbox/issues/128","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0382","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"bug(@vtmn/react) `VtmnDropdown` component always display label although it is not configured?","query_context":"**Describe the bug**\nIn the React Showcase of the VtmnDropdown component, it say that if the label is not set, it will not disayed but it's still here\n\n**Steps to reproduce**\n- install React \n- install Vtmn package for React\n\n**Expected behavior**\nNormally, if the label is not set, it does not appear\n\n**Version affected**\n@react: 18.2.0\n@vtmn/react: 0.67.0\n\nScreenshot from 2023-03-24 11-30-26\nScreenshot from 2023-03-24 11-30-08","known_context_document_ids":["gh_issue_1639131903"],"reference_answer":"Thanks @jdeca-decat for this issue.\nAs the `@vtmn/react` is a community library, I hope someone will take this issue to help you.\nIf you want, feel free to contribute also! We are there to help you if needed regarding launching & contributing on the vitamin-web stack.","answer_document_id":"gh_comment_1482725724","silver_evidence_path":["gh_comment_1485739651","gh_issue_1639250838","gh_comment_1482725724"],"evidence_issue_ids":[1639131903,1639250838],"source_repo_name":"Decathlon/vitamin-web","source_issue_id":1639131903,"source_issue_number":1399,"source_issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","target_repo_name":"Decathlon/vitamin-web","target_issue_id":1639250838,"target_issue_number":1401,"target_issue_url":"https://github.com/Decathlon/vitamin-web/issues/1401","reference_anchor_document_id":"gh_comment_1485739651","reference_answer_author":"lauthieb","reference_answer_author_association":"MEMBER","quality_score":79.35,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.25,"target_answer_overlap":0.087},"issue_created_at":"2023-03-24T10:31:45+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1639131903","fragment_type":"issue_description","sequence":0,"text":"bug(@vtmn/react) `VtmnDropdown` component always display label although it is not configured\n**Describe the bug**\nIn the React Showcase of the VtmnDropdown component, it say that if the label is not set, it will not disayed but it's still here\n\n**Steps to reproduce**\n- install React \n- install Vtmn package for React\n\n**Expected behavior**\nNormally, if the label is not set, it does not appear\n\n**Version affected**\n@react: 18.2.0\n@vtmn/react: 0.67.0\n\nScreenshot from 2023-03-24 11-30-26\nScreenshot from 2023-03-24 11-30-08","author_login":"jdeca-decat","author_association":"NONE","created_at":"2023-03-24T10:31:45+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1482612314","fragment_type":"issue_comment","sequence":1,"text":"While waiting for the bug to be fixed, I added a style rule: \n`.vtmn-dropdown label {\n display: none;\n}`","author_login":"jdeca-decat","author_association":"NONE","created_at":"2023-03-24T10:55:55+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482725574","fragment_type":"issue_comment","sequence":2,"text":"Thanks @jdeca-decat for this issue.\nAs the `@vtmn/react` is a community library, I hope someone will take this issue to help you.\nIf you want, feel free to contribute also! We are there to help you if needed regarding launching & contributing on the vitamin-web stack.","author_login":"lauthieb","author_association":"MEMBER","created_at":"2023-03-24T12:31:01+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1485739651","fragment_type":"issue_comment","sequence":3,"text":"Hi @jdeca-decat,\n\nFollowing our last discussion from #1401 I'm glad you've been able to solve your issue.\n\nI've just opened a P.R in order to solve this issue so that we won't have to use a CSS workaround anymore :)","author_login":"0x2A-git","author_association":"CONTRIBUTOR","created_at":"2023-03-27T19:23:08+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[1639250838],"is_known_query_context":false},{"document_id":"gh_comment_1486376584","fragment_type":"issue_comment","sequence":4,"text":"Thanks @0x2A-git I'll take a look !\nBut.. I stopped using the VtmnDropdown, because I had another problem: there is no documentation and no option to configure the dropdown in single selection mode. I want to disable multiselect default option but there is no way apparently :(","author_login":"jdeca-decat","author_association":"NONE","created_at":"2023-03-28T07:48:30+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1487172713","fragment_type":"issue_comment","sequence":5,"text":"Did you take a look at the `Select` component ? It might suit your use case :) ( URL ) :)","author_login":"0x2A-git","author_association":"CONTRIBUTOR","created_at":"2023-03-28T15:49:48+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1488144792","fragment_type":"issue_comment","sequence":6,"text":"Great idea :) Accessibility + web standards + usage > aesthetic","author_login":"lauthieb","author_association":"MEMBER","created_at":"2023-03-29T08:19:39+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639131903,"issue_number":1399,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1399","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1639250838","fragment_type":"issue_description","sequence":0,"text":"bug(@vtmn/react): `VtmnDropdownItem` component doesn't display any content\n**Describe the bug**\nWhen I add items to VtmnDropdown like in the React showcase, nothing appear..\nScreenshot from 2023-03-24 12-44-41\nScreenshot from 2023-03-24 12-43-50\n\n**Steps to reproduce**\n- Install React\n- install Vtmn package for React\n- add VtmnDropdownItem component to your VtmnDropdown as children\n\n**Expected behavior**\nVtmnDropdownItem should be able to display their content, like in MUI Item Select\n\n**Version affected**\n@react: 18.2.0\n@vtmn/react: 0.67.0","author_login":"jdeca-decat","author_association":"NONE","created_at":"2023-03-24T11:50:40+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639250838,"issue_number":1401,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1482725724","fragment_type":"issue_comment","sequence":1,"text":"Thanks @jdeca-decat for this issue.\nAs the `@vtmn/react` is a community library, I hope someone will take this issue to help you.\nIf you want, feel free to contribute also! We are there to help you if needed regarding launching & contributing on the vitamin-web stack.","author_login":"lauthieb","author_association":"MEMBER","created_at":"2023-03-24T12:31:09+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639250838,"issue_number":1401,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484059042","fragment_type":"issue_comment","sequence":2,"text":"Hi @jdeca-decat,\n\nI've tried to reproduce your setup in a CRA project and tested it on both Firefox & Chrome but I'm not able to reproduce it.\n\nCode : \n\njsx\n {\n console.log(value)\n }}\n \n 10 \n\n 20 \n\n 30 \n \n\nResult : \n\nimage\n\nThe only 'issue' that I've encountered is the 'value' parameter being set to undefined which is the expected behavior given that my VtmnDropdownItem do not have a value attribute. \n\nCould the VtmnDropdown component be wrapped inside another component that would prevent its children from being displayed ? :thinking:","author_login":"0x2A-git","author_association":"CONTRIBUTOR","created_at":"2023-03-26T10:51:45+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639250838,"issue_number":1401,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484060768","fragment_type":"issue_comment","sequence":3,"text":"Hi @jdeca-decat,\n\nI've tried to reproduce your setup in a CRA project and tested it on both Firefox & Chrome but I'm not able to reproduce it.\n\nCode :\n\n {\n console.log(value)\n }}\n \n 10 \n\n 20 \n\n 30 \n \n\nResult :\n\nimage\n\nThe only 'issue' that I've encountered is the 'value' parameter being set to undefined which is the expected behavior given that my VtmnDropdownItem do not have a value attribute.\n\nCould the VtmnDropdown component be wrapped inside another component that would prevent its children from being displayed ? thinking","author_login":"0x2A-git","author_association":"CONTRIBUTOR","created_at":"2023-03-26T10:59:09+08:00","repo_name":"Decathlon/vitamin-web","issue_id":1639250838,"issue_number":1401,"issue_url":"https://github.com/Decathlon/vitamin-web/issues/1401","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0383","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Issue: nmap plugin misses HTTP services?","query_context":"## Issue description\nA large part of existing Tsunami plugins identifies vulnerabilities in HTTP based web services. Thus, it is important that these services are identified correctly. Turns out the nmap plugin (or more precise nmap itself) is really bad at this.\n\nFor example, I'm currently developing a plugin for a vulnerability in MinIO. MinIO runs a HTTP based API, usually on TCP port 9000. Here the output from nmap (version 7.93), using the same parameters as the nmap plugin:\n\nnmap --unprivileged -Pn -n -sT -sV --version-intensity 5 -T4 --script banner 172.21.0.4 -p 9000\nStarting Nmap 7.93 ( URL ) at 2023-04-06 08:46 CEST\nNmap scan report for 172.21.0.4\nHost is up (0.00029s latency).\n\nPORT STATE SERVICE VERSION\n9000/tcp open cslistener?\n| fingerprint-strings: \n| GenericLines, Help, Kerberos, RTSPRequest, SIPOptions, SSLSessionReq, TLSSessionReq: \n| HTTP/1.1 400 Bad Request\n| Content-Type: text/plain; charset=utf-8\n| Connection: close\n| Request\n| GetRequest: \n| HTTP/1.0 400 Bad Request\n| Accept-Ranges: bytes\n| Content-Length: 232\n| Content-Type: application/xml\n| Server: MinIO\n| Vary: Origin\n| Date: Thu, 06 Apr 2023 06:46:32 GMT\n| \n| InvalidRequest Invalid Request (invalid argument) / ed2576f8-f43d-4c0d-8bf5-60fd0bf780cc \n| HTTPOptions: \n| HTTP/1.0 200 OK\n| Vary: Origin\n| Date: Thu, 06 Apr 2023 06:46:32 GMT\n|_ Content-Length: 0\n1 service unrecognized despite returning data. If you know the service/version, please submit the following fingerprint at URL :\nSF-Port9000-TCP:V=7.93%I=5%D=4/6%Time=642E6AC8%P=x86_64-unknown-linux-gnu%\nSF:r(GenericLines,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\nContent-Type:\\\nSF:x20text/plain;\\x20charset=utf-8\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x20B\nSF:ad\\x20Request\")%r(GetRequest,190,\"HTTP/1\\.0\\x20400\\x20Bad\\x20Request\\r\\\nSF:nAccept-Ranges:\\x20bytes\\r\\nContent-Length:\\x20232\\r\\nContent-Type:\\x20\nSF:application/xml\\r\\nServer:\\x20MinIO\\r\\nVary:\\x20Origin\\r\\nDate:\\x20Thu,\nSF:\\x2006\\x20Apr\\x202023\\x2006:46:32\\x20GMT\\r\\n\\r\\n \\n InvalidRequest Invalid\\x20Request\\x20\\(invalid\\x20argument\\) / ed2576f8-f43d-4c0d-8bf5-60fd0bf7\nSF:80cc \")%r(HTTPOptions,59,\"HTTP/1\\.0\\x20200\\x20OK\\r\\nVar\nSF:y:\\x20Origin\\r\\nDate:\\x20Thu,\\x2006\\x20Apr\\x202023\\x2006:46:32\\x20GMT\\r\nSF:\\nContent-Length:\\x200\\r\\n\\r\\n\")%r(RTSPRequest,67,\"HTTP/1\\.1\\x20400\\x20\nSF:Bad\\x20Request\\r\\nContent-Type:\\x20text/plain;\\x20charset=utf-8\\r\\nConn\nSF:ection:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\")%r(Help,67,\"HTTP/1\\.1\\x2\nSF:0400\\x20Bad\\x20Request\\r\\nContent-Type:\\x20text/plain;\\x20charset=utf-8\nSF:\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\")%r(SSLSessionReq\nSF:,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\nContent-Type:\\x20text/plain;\nSF:\\x20charset=utf-8\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\"\nSF:)%r(TLSSessionReq,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\nContent-Typ\nSF:e:\\x20text/plain;\\x20charset=utf-8\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x\nSF:20Bad\\x20Request\")%r(Kerberos,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\\nSF:nContent-Type:\\x20text/plain;\\x20charset=utf-8\\r\\nConnection:\\x20close\\\nSF:r\\n\\r\\n400\\x20Bad\\x20Request\")%r(SIPOptions,67,\"HTTP/1\\.1\\x20400\\x20Bad\nSF:\\x20Request\\r\\nContent-Type:\\x20text/plain;\\x20charset=utf-8\\r\\nConnect\nSF:ion:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\");\n\nService detection performed. Please report any incorrect results at URL .\nNmap done: 1 IP address (1 host up) scanned in 36.58 seconds\n\nWhen the nmap scanner plugin parses the XML output, the extractServiceFromNmapRun method is invoked. To identify web services, it calls Tsunamies NetworkServiceUtils.isWebService which simply checks the service name against a list of known \"nmap patterns\":\n\njava\n private static final ImmutableMap IS_PLAIN_HTTP_BY_KNOWN_WEB_SERVICE_NAME =\n ImmutableMap. builder()\n .put(\"http\", true)\n .put(\"http-alt\", true) // Some http server are identified as this rather than \"http\".\n .put(\"http-proxy\", true)\n .put(\"https\", false)\n .put(\"radan-http\", true) // Port 8088, Hadoop Yarn web UI identified as this.\n .put(\"ssl/http\", false)\n .put(\"ssl/https\", false)\n .put(\"ssl/http-proxy\", false)\n .build();\n\nThis requires that nmap identifies the HTTP service correctly. However, the basic fingerprinting of nmap is less \"advanced\" as most people assume. To my knowledge the fingerprinting does not allow \"dynamic values\" (for example the hostname/IP address) in the request. This would be required to send a HTTP 1.1 request. Nmap is therefore only uses a simple \"HTTP 1.0\" request that does not require a \"Host:\" header field.\n\nThis works fine if the HTTP service still fully supports HTTP 1.0 but for many modern web service implementations, this is no longer the case. The MinIO server for example returns with a HTTP 400 error, which does not match with the service fingerprints from nmap:\n\nGET / HTTP/1.0\n\nHTTP/1.0 400 Bad Request\nAccept-Ranges: bytes\nContent-Length: 232\nContent-Type: application/xml\nServer: MinIO\nVary: Origin\nDate: Thu, 06 Apr 2023 07:06:03 GMT\n\n \n InvalidRequest Invalid Request (invalid argument) / ed2576f8-f43d-4c0d-8bf5-60fd0bf780cc \n\n \nAs a result, the service is not identified as a web service and is not scanned by plugins that should actually be executed.\n\n## Suggested solution/improvement\n\nI think the best solution would to improve the code in the `extractServiceFromNmapRun`. The code should take the additional scan data from the NMAP output into account and use that to perform additional HTTP / service fingerprinting by analyzing the \"GetRequest\" output that is also included in the scan:\n\n| GetRequest: \n| HTTP/1.0 400 Bad Request\n| Accept-Ranges: bytes\n| Content-Length: 232\n| Content-Type: application/xml\n| Server: MinIO\n| Vary: Origin\n| Date: Thu, 06 Apr 2023 06:46:32 GM\n\nI can implement this, but I thought I might discuss this first.","known_context_document_ids":["gh_issue_1656817413"],"reference_answer":"Hi @fmunozs,\n\nSorry I realized that I did not answer. This is intentional, when performing tests internally we found that this is the best trade-off for us.\n\n_~tooryx_","answer_document_id":"gh_comment_3052838334","silver_evidence_path":["gh_comment_1500801988","gh_issue_1651173103","gh_comment_3052838334"],"evidence_issue_ids":[1656817413,1651173103],"source_repo_name":"google/tsunami-security-scanner-plugins","source_issue_id":1656817413,"source_issue_number":303,"source_issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/303","target_repo_name":"google/tsunami-security-scanner-plugins","target_issue_id":1651173103,"target_issue_number":298,"target_issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/298","reference_anchor_document_id":"gh_comment_1500801988","reference_answer_author":"tooryx","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2353,"anchor_target_overlap":0.2353,"target_answer_overlap":0.0},"issue_created_at":"2023-04-06T07:22:11+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1656817413","fragment_type":"issue_description","sequence":0,"text":"Issue: nmap plugin misses HTTP services\n## Issue description\nA large part of existing Tsunami plugins identifies vulnerabilities in HTTP based web services. Thus, it is important that these services are identified correctly. Turns out the nmap plugin (or more precise nmap itself) is really bad at this.\n\nFor example, I'm currently developing a plugin for a vulnerability in MinIO. MinIO runs a HTTP based API, usually on TCP port 9000. Here the output from nmap (version 7.93), using the same parameters as the nmap plugin:\n\nnmap --unprivileged -Pn -n -sT -sV --version-intensity 5 -T4 --script banner 172.21.0.4 -p 9000\nStarting Nmap 7.93 ( URL ) at 2023-04-06 08:46 CEST\nNmap scan report for 172.21.0.4\nHost is up (0.00029s latency).\n\nPORT STATE SERVICE VERSION\n9000/tcp open cslistener?\n| fingerprint-strings: \n| GenericLines, Help, Kerberos, RTSPRequest, SIPOptions, SSLSessionReq, TLSSessionReq: \n| HTTP/1.1 400 Bad Request\n| Content-Type: text/plain; charset=utf-8\n| Connection: close\n| Request\n| GetRequest: \n| HTTP/1.0 400 Bad Request\n| Accept-Ranges: bytes\n| Content-Length: 232\n| Content-Type: application/xml\n| Server: MinIO\n| Vary: Origin\n| Date: Thu, 06 Apr 2023 06:46:32 GMT\n| \n| InvalidRequest Invalid Request (invalid argument) / ed2576f8-f43d-4c0d-8bf5-60fd0bf780cc \n| HTTPOptions: \n| HTTP/1.0 200 OK\n| Vary: Origin\n| Date: Thu, 06 Apr 2023 06:46:32 GMT\n|_ Content-Length: 0\n1 service unrecognized despite returning data. If you know the service/version, please submit the following fingerprint at URL :\nSF-Port9000-TCP:V=7.93%I=5%D=4/6%Time=642E6AC8%P=x86_64-unknown-linux-gnu%\nSF:r(GenericLines,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\nContent-Type:\\\nSF:x20text/plain;\\x20charset=utf-8\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x20B\nSF:ad\\x20Request\")%r(GetRequest,190,\"HTTP/1\\.0\\x20400\\x20Bad\\x20Request\\r\\\nSF:nAccept-Ranges:\\x20bytes\\r\\nContent-Length:\\x20232\\r\\nContent-Type:\\x20\nSF:application/xml\\r\\nServer:\\x20MinIO\\r\\nVary:\\x20Origin\\r\\nDate:\\x20Thu,\nSF:\\x2006\\x20Apr\\x202023\\x2006:46:32\\x20GMT\\r\\n\\r\\n \\n InvalidRequest Invalid\\x20Request\\x20\\(invalid\\x20argument\\) / ed2576f8-f43d-4c0d-8bf5-60fd0bf7\nSF:80cc \")%r(HTTPOptions,59,\"HTTP/1\\.0\\x20200\\x20OK\\r\\nVar\nSF:y:\\x20Origin\\r\\nDate:\\x20Thu,\\x2006\\x20Apr\\x202023\\x2006:46:32\\x20GMT\\r\nSF:\\nContent-Length:\\x200\\r\\n\\r\\n\")%r(RTSPRequest,67,\"HTTP/1\\.1\\x20400\\x20\nSF:Bad\\x20Request\\r\\nContent-Type:\\x20text/plain;\\x20charset=utf-8\\r\\nConn\nSF:ection:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\")%r(Help,67,\"HTTP/1\\.1\\x2\nSF:0400\\x20Bad\\x20Request\\r\\nContent-Type:\\x20text/plain;\\x20charset=utf-8\nSF:\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\")%r(SSLSessionReq\nSF:,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\nContent-Type:\\x20text/plain;\nSF:\\x20charset=utf-8\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\"\nSF:)%r(TLSSessionReq,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\nContent-Typ\nSF:e:\\x20text/plain;\\x20charset=utf-8\\r\\nConnection:\\x20close\\r\\n\\r\\n400\\x\nSF:20Bad\\x20Request\")%r(Kerberos,67,\"HTTP/1\\.1\\x20400\\x20Bad\\x20Request\\r\\\nSF:nContent-Type:\\x20text/plain;\\x20charset=utf-8\\r\\nConnection:\\x20close\\\nSF:r\\n\\r\\n400\\x20Bad\\x20Request\")%r(SIPOptions,67,\"HTTP/1\\.1\\x20400\\x20Bad\nSF:\\x20Request\\r\\nContent-Type:\\x20text/plain;\\x20charset=utf-8\\r\\nConnect\nSF:ion:\\x20close\\r\\n\\r\\n400\\x20Bad\\x20Request\");\n\nService detection performed. Please report any incorrect results at URL .\nNmap done: 1 IP address (1 host up) scanned in 36.58 seconds\n\nWhen the nmap scanner plugin parses the XML output, the extractServiceFromNmapRun method is invoked. To identify web services, it calls Tsunamies NetworkServiceUtils.isWebService which simply checks the service name against a list of known \"nmap patterns\":\n\njava\n private static final ImmutableMap IS_PLAIN_HTTP_BY_KNOWN_WEB_SERVICE_NAME =\n ImmutableMap. builder()\n .put(\"http\", true)\n .put(\"http-alt\", true) // Some http server are identified as this rather than \"http\".\n .put(\"http-proxy\", true)\n .put(\"https\", false)\n .put(\"radan-http\", true) // Port 8088, Hadoop Yarn web UI identified as this.\n .put(\"ssl/http\", false)\n .put(\"ssl/https\", false)\n .put(\"ssl/http-proxy\", false)\n .build();\n\nThis requires that nmap identifies the HTTP service correctly. However, the basic fingerprinting of nmap is less \"advanced\" as most people assume. To my knowledge the fingerprinting does not allow \"dynamic values\" (for example the hostname/IP address) in the request. This would be required to send a HTTP 1.1 request. Nmap is therefore only uses a simple \"HTTP 1.0\" request that does not require a \"Host:\" header field.\n\nThis works fine if the HTTP service still fully supports HTTP 1.0 but for many modern web service implementations, this is no longer the case. The MinIO server for example returns with a HTTP 400 error, which does not match with the service fingerprints from nmap:\n\nGET / HTTP/1.0\n\nHTTP/1.0 400 Bad Request\nAccept-Ranges: bytes\nContent-Length: 232\nContent-Type: application/xml\nServer: MinIO\nVary: Origin\nDate: Thu, 06 Apr 2023 07:06:03 GMT\n\n \n InvalidRequest Invalid Request (invalid argument) / ed2576f8-f43d-4c0d-8bf5-60fd0bf780cc \n\n \nAs a result, the service is not identified as a web service and is not scanned by plugins that should actually be executed.\n\n## Suggested solution/improvement\n\nI think the best solution would to improve the code in the `extractServiceFromNmapRun`. The code should take the additional scan data from the NMAP output into account and use that to perform additional HTTP / service fingerprinting by analyzing the \"GetRequest\" output that is also included in the scan:\n\n| GetRequest: \n| HTTP/1.0 400 Bad Request\n| Accept-Ranges: bytes\n| Content-Length: 232\n| Content-Type: application/xml\n| Server: MinIO\n| Vary: Origin\n| Date: Thu, 06 Apr 2023 06:46:32 GM\n\nI can implement this, but I thought I might discuss this first.","author_login":"h0ng10","author_association":"CONTRIBUTOR","created_at":"2023-04-06T07:22:11+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1656817413,"issue_number":303,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/303","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1500801988","fragment_type":"issue_comment","sequence":1,"text":"@h0ng10 can you try running the scan with intensity 7 (nmap default)? I reported a similar problem at #298 in my case nmap is able to detect the HTTP with intensity 7, after that the service can be scanned.","author_login":"fmunozs","author_association":"CONTRIBUTOR","created_at":"2023-04-08T06:04:34+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1656817413,"issue_number":303,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/303","linked_issue_ids":[1651173103],"is_known_query_context":false},{"document_id":"gh_comment_1501984161","fragment_type":"issue_comment","sequence":2,"text":"@h0ng10 Thanks for reporting this behaviour. I'm aware in certain cases nmap defaults to /etc/services for open ports, but never really investigated thoroughly. What you suggested makes sense, please go ahead with the proposed solution.","author_login":"maoning","author_association":"COLLABORATOR","created_at":"2023-04-10T15:55:46+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1656817413,"issue_number":303,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1504747065","fragment_type":"issue_comment","sequence":3,"text":"@maoning I didn't use this in the MinIO plugin, it was just an example I had on hand. \nI think it would be worth trying to at least parse the HTTP headers, as this could also possibly identify the service used (as nmap does).\n\nI will first do some nmap scans on various HTTP services (I already have a few candidates in mind that cause problems) and then see what works best.","author_login":"h0ng10","author_association":"NONE","created_at":"2023-04-12T06:42:54+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1656817413,"issue_number":303,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1884977615","fragment_type":"issue_comment","sequence":4,"text":"Hi,\n\nThis has been fixed in 7cf51a42 and 55aa6978\n\n_~tooryx_","author_login":"tooryx","author_association":"MEMBER","created_at":"2024-01-10T14:41:37+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1656817413,"issue_number":303,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/303","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1651173103","fragment_type":"issue_description","sequence":0,"text":"portscan nmap plugin withVersionDetectionIntensity sets to 5\nThe current nmap plugin for portscan sets the version detection intensity to 5 [0] , this differs from the default Nmap scan that sets the value to 7 [1] and will identify additional services.\n\nI believe that the value should be changed to the default Nmap setting or at least be configurable from a cli-option.\n\n NmapRun result =\n setPortTargets(nmapClient)\n .withDnsResolution(DnsResolution.NEVER)\n .treatAllHostsAsOnline()\n .withScanTechnique(ScanTechnique.CONNECT)\n .asUnprivileged()\n .withServiceAndVersionDetection()\n .withVersionDetectionIntensity(5)\n\n[0] URL \n[1] URL","author_login":"fmunozs","author_association":"CONTRIBUTOR","created_at":"2023-04-03T01:15:39+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1651173103,"issue_number":298,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/298","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3052838334","fragment_type":"issue_comment","sequence":1,"text":"Hi @fmunozs,\n\nSorry I realized that I did not answer. This is intentional, when performing tests internally we found that this is the best trade-off for us.\n\n_~tooryx_","author_login":"tooryx","author_association":"MEMBER","created_at":"2025-07-09T14:13:50+08:00","repo_name":"google/tsunami-security-scanner-plugins","issue_id":1651173103,"issue_number":298,"issue_url":"https://github.com/google/tsunami-security-scanner-plugins/issues/298","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0384","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"vsyscall=emulate not working anymore ?","query_context":"WslLogs-2025-06-02_17-40-38.zip\n\n### Windows Version\n\n10.0.19045.5854\n\n### WSL Version\n\n2.5.7.0\n\n### Are you using WSL 1 or WSL 2?\n\n- [x] WSL 2\n- [ ] WSL 1\n\n### Kernel Version\n\n6.6.87.1-1\n\n### Distro Version\n\nUbuntu 22.04LTS\n\n### Other Software\n\nSince some days / weeks (cannot say it precisely), a binary program that used to work thanks to the vsyscall emulation, fails now with a segmentation fault. i have tried all possible values for vsyscall, with no success.\nHas anything changed in WSL kernel lately that breaks backward compatibility ?\n\nHere is the gdb backtrace:\n`\nProgram received signal SIGSEGV, Segmentation fault.\n0xffffffffff600000 in ?? ()\n(gdb) bt full\n#0 0xffffffffff600000 in ?? ()\nNo symbol table info available.\n#1 0x00000000004daa2d in gettimeofday () at ../sysdeps/unix/sysv/linux/x86_64/gettimeofday.S:37\nNo locals.\n#2 0x000000000043f4ab in for_since_epoch_t ()\nNo symbol table info available.\n#3 0x000000000041e0ff in for_rtl_init_ ()\nNo symbol table info available.\n#4 0x0000000000400359 in main ()\nNo symbol table info available.\n#5 0x00000000004c1e94 in __libc_start_main (main=0x400330 , argc=1, ubp_av=0x7fffffffd788, init=0x4c2380 , fini=0x4c2340 , rtld_fini=0x0, stack_end=0x7fffffffd778)\n at libc-start.c:226\n self = \n result = \n ubp_ev = \n auxvec = \n stack_chk_guard = \n unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 0, 0, 4989760, 4989824, 0, -1386217472, 653851885568}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0,\n canceltype = 0}}}\n not_first_call = \n#6 0x0000000000400239 in _start () at ../sysdeps/x86_64/elf/start.S:113\nNo locals.\n`\n\n### Repro Steps\n\nRun an old binary on an Ubuntu 22.04 running on the latest wsl2. fails with a Segmentation Fault\n\n### Expected Behavior\n\nThe program shall run normally. (as it used to)\n\n### Actual Behavior\n\nThe program ends with a Segmentation fault issue\n\n### Diagnostic Logs\n\n_No response_","known_context_document_ids":["gh_issue_3110684800"],"reference_answer":"We're planning to fix this issue in the next kernel release. In the meantime, you can build a custom kernel with the config enabled as a workaround.","answer_document_id":"gh_comment_2932365126","silver_evidence_path":["gh_comment_2931862502","gh_issue_3096876409","gh_comment_2932365126"],"evidence_issue_ids":[3110684800,3096876409],"source_repo_name":"microsoft/WSL","source_issue_id":3110684800,"source_issue_number":13031,"source_issue_url":"https://github.com/microsoft/WSL/issues/13031","target_repo_name":"microsoft/WSL","target_issue_id":3096876409,"target_issue_number":12987,"target_issue_url":"https://github.com/microsoft/WSL/issues/12987","reference_anchor_document_id":"gh_comment_2931862502","reference_answer_author":"chessturo","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3333,"target_answer_overlap":0.25},"issue_created_at":"2025-06-02T15:37:12+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_3110684800","fragment_type":"issue_description","sequence":0,"text":"vsyscall=emulate not working anymore ?\nWslLogs-2025-06-02_17-40-38.zip\n\n### Windows Version\n\n10.0.19045.5854\n\n### WSL Version\n\n2.5.7.0\n\n### Are you using WSL 1 or WSL 2?\n\n- [x] WSL 2\n- [ ] WSL 1\n\n### Kernel Version\n\n6.6.87.1-1\n\n### Distro Version\n\nUbuntu 22.04LTS\n\n### Other Software\n\nSince some days / weeks (cannot say it precisely), a binary program that used to work thanks to the vsyscall emulation, fails now with a segmentation fault. i have tried all possible values for vsyscall, with no success.\nHas anything changed in WSL kernel lately that breaks backward compatibility ?\n\nHere is the gdb backtrace:\n`\nProgram received signal SIGSEGV, Segmentation fault.\n0xffffffffff600000 in ?? ()\n(gdb) bt full\n#0 0xffffffffff600000 in ?? ()\nNo symbol table info available.\n#1 0x00000000004daa2d in gettimeofday () at ../sysdeps/unix/sysv/linux/x86_64/gettimeofday.S:37\nNo locals.\n#2 0x000000000043f4ab in for_since_epoch_t ()\nNo symbol table info available.\n#3 0x000000000041e0ff in for_rtl_init_ ()\nNo symbol table info available.\n#4 0x0000000000400359 in main ()\nNo symbol table info available.\n#5 0x00000000004c1e94 in __libc_start_main (main=0x400330 , argc=1, ubp_av=0x7fffffffd788, init=0x4c2380 , fini=0x4c2340 , rtld_fini=0x0, stack_end=0x7fffffffd778)\n at libc-start.c:226\n self = \n result = \n ubp_ev = \n auxvec = \n stack_chk_guard = \n unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 0, 0, 4989760, 4989824, 0, -1386217472, 653851885568}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0,\n canceltype = 0}}}\n not_first_call = \n#6 0x0000000000400239 in _start () at ../sysdeps/x86_64/elf/start.S:113\nNo locals.\n`\n\n### Repro Steps\n\nRun an old binary on an Ubuntu 22.04 running on the latest wsl2. fails with a Segmentation Fault\n\n### Expected Behavior\n\nThe program shall run normally. (as it used to)\n\n### Actual Behavior\n\nThe program ends with a Segmentation fault issue\n\n### Diagnostic Logs\n\n_No response_","author_login":"Samfaitmal","author_association":"NONE","created_at":"2025-06-02T15:37:12+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2931633293","fragment_type":"issue_comment","sequence":1,"text":"The easiest way for me to reproduce this was to try and run Ubuntu 4.10 in WSL2, which requires `kernelCommandLine=\"vsyscall=emulate\"`.\n\nThis isn't just running an old binary that requires vsyscall emulate, but an _entire distro_. I don't do this often, but I do know it worked for a long time, at least as late as 18 months ago on the 5.x WSL kernel series.\n\nI can confirm it no longer works.\n\nImage\n\nWSL version: 2.5.7.0\nKernel version: 6.6.87.1-1\n\nWslLogs-2025-06-02_13-06-40.zip","author_login":"sirredbeard","author_association":"COLLABORATOR","created_at":"2025-06-02T17:08:40+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2931795881","fragment_type":"issue_comment","sequence":2,"text":"The easiest way I have to reproduce this is to run Ubuntu 4.10, _an entire distro_ that requires `vsyscall=emulate`, in WSL2. \n\nIt's been a while since I've used this, but it worked as late as 18 months ago on the 5.x kernel series.\n\nI installed an Ubuntu 4.10 rootfs rootfs and tried to launch it. It will not run:\n\nImage\n\nWSL version: 2.5.7.0\nKernel version: 6.6.87.1-1\n\nWslLogs-2025-06-02_13-40-47.zip","author_login":"sirredbeard","author_association":"COLLABORATOR","created_at":"2025-06-02T17:52:11+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2931838016","fragment_type":"issue_comment","sequence":3,"text":"`CONFIG_X86_VSYSCALL_EMULATION` has been disabled in 6.6.y series kernel config.\n\nThis is a change from 6.1.y, 5.15.y before that, going back to 4.19.y.\n\nThis appears to be a regression of #4694 unless there is an overriding reason to deprecate support in 6.6.y+.","author_login":"sirredbeard","author_association":"COLLABORATOR","created_at":"2025-06-02T17:58:23+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2931862502","fragment_type":"issue_comment","sequence":4,"text":"`CONFIG_X86_VSYSCALL_EMULATION` was disabled in the same commit 4d72cb5bb5d14e520500e84316a5b7e0f9e572cf that raised #12987 and #12983","author_login":"sirredbeard","author_association":"COLLABORATOR","created_at":"2025-06-02T18:06:59+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[3096876409],"is_known_query_context":false},{"document_id":"gh_comment_2932366163","fragment_type":"issue_comment","sequence":5,"text":"We're planning to fix this issue in the next kernel release. In the meantime, you can build a custom kernel with the config enabled as a workaround.","author_login":"chessturo","author_association":"COLLABORATOR","created_at":"2025-06-02T20:25:44+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2932972350","fragment_type":"issue_comment","sequence":6,"text":"I think it actually caused by synchronizing the configurations from Azure Linux. (Maybe Azure Linux did that for security or something.)\n URL \n\nKenji Mouri","author_login":"MouriNaruto","author_association":"NONE","created_at":"2025-06-03T00:26:00+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[3096876409],"is_known_query_context":false},{"document_id":"gh_comment_2933112666","fragment_type":"issue_comment","sequence":7,"text":"@sirredbeard I‘m hugely agree with you about that. I mentioned that git commit id just for making people to know when the modifications were actually introduced. Also, I'm curious about why disabling vsyscall=emulate will improve the security because Azure Linux guys don't make more explanations for that in their commits. (I think I should ask for LLM models first.)\n\nKenji Mouri","author_login":"MouriNaruto","author_association":"NONE","created_at":"2025-06-03T02:04:24+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2938035780","fragment_type":"issue_comment","sequence":8,"text":"@Samfaitmal you can download versions of WSL with the old kernel from here)","author_login":"harristomy","author_association":"NONE","created_at":"2025-06-04T01:51:08+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2939086727","fragment_type":"issue_comment","sequence":9,"text":"@moikot From what I have tested (and I have not tested all the versions) 2.4.13 is working.","author_login":"Samfaitmal","author_association":"NONE","created_at":"2025-06-04T08:22:48+08:00","repo_name":"microsoft/WSL","issue_id":3110684800,"issue_number":13031,"issue_url":"https://github.com/microsoft/WSL/issues/13031","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3096876409","fragment_type":"issue_description","sequence":0,"text":"WSL kernel 6.6 disables `CONFIG_MODIFY_LDT_SYSCALL`\n### Windows Version\n\nMicrosoft Windows [Version 10.0.26100.4061]\n\n### WSL Version\n\n2.5.7.0\n\n### Are you using WSL 1 or WSL 2?\n\n- [x] WSL 2\n- [ ] WSL 1\n\n### Kernel Version\n\n6.6.87.1-1\n\n### Distro Version\n\nUbuntu 24.04\n\n### Other Software\n\nwibo, version 0.6.16\n\n### Repro Steps\n\n- Update to WSL 2.5.7.0\n- Run wibo\n\n### Expected Behavior\n\n- wibo should run wrapped executable\n\n### Actual Behavior\n\n- wibo exits with error\n\nThis was working previously with kernel 5.5, and also works when custom compiling 6.x kernel with `CONFIG_MODIFY_LDT_SYSCALL` re-enabled (was disabled in this commit)\n\nWith that said, this is a breaking change between kernel versions that was unexpected and not trivial to diagnose. Additionally resolving it requires custom compiling either a 5.x kernel which works by default, or a 6.x kernel with this flag enabled (since MS does not appear to have pre-built kernel bzImages available for older versions as far as I could tell)\n\n### Diagnostic Logs\n\nWslLogs-2025-05-28_20-38-42.zip","author_login":"JoshSchreuder","author_association":"NONE","created_at":"2025-05-28T10:33:32+08:00","repo_name":"microsoft/WSL","issue_id":3096876409,"issue_number":12987,"issue_url":"https://github.com/microsoft/WSL/issues/12987","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2916988180","fragment_type":"issue_comment","sequence":1,"text":"@chessturo - looks like CONFIG_MODIFY_LDT_SYSCALL was dropped from the 6.6 kernel.","author_login":"benhillis","author_association":"MEMBER","created_at":"2025-05-28T16:46:31+08:00","repo_name":"microsoft/WSL","issue_id":3096876409,"issue_number":12987,"issue_url":"https://github.com/microsoft/WSL/issues/12987","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2931959756","fragment_type":"issue_comment","sequence":2,"text":"FWIW, this also impacts URL \n\n$ zgrep MODIFY_LDT /proc/config.gz\n# CONFIG_MODIFY_LDT_SYSCALL is not set\n\n$ ...retrowin32 run\nthread 'main' panicked at win32/src/ldt.rs:68:17:\nsyscall(SYS_modify_ldt): Function not implemented (os error 38)","author_login":"evmar","author_association":"NONE","created_at":"2025-06-02T18:29:06+08:00","repo_name":"microsoft/WSL","issue_id":3096876409,"issue_number":12987,"issue_url":"https://github.com/microsoft/WSL/issues/12987","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2932365126","fragment_type":"issue_comment","sequence":3,"text":"We're planning to fix this issue in the next kernel release. In the meantime, you can build a custom kernel with the config enabled as a workaround.","author_login":"chessturo","author_association":"COLLABORATOR","created_at":"2025-06-02T20:25:18+08:00","repo_name":"microsoft/WSL","issue_id":3096876409,"issue_number":12987,"issue_url":"https://github.com/microsoft/WSL/issues/12987","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0385","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Lab messages] Using the 'Person search' option when creating new entities, via processing lab messages, creates a new person?","query_context":"### Bug Description\n \nWhen processing lab messages to create new entities (cases and contacts), if the user uses the 'Person Search' option, the newly created entity is not associated with the selected person, but instead a new person gets created.\n\n### Steps to Reproduce\n \n1. Create a person by creating a new entity (i.e. 'person1');\n2. Navigate to 'Lab messages' in the 'Samples' directory and click 'Process' on an unprocessed lab message;\n3. In the first pop-up for 'Pick or create person' select 'Create new person' and click 'Confirm';\n4. In the second pop-up for 'Pick or create entry' select 'Create new case' or 'Create new contact';\n5. In the 'Create new case/contact' form, for the person related fields, use the 'Person search' option to select the person created at step1 ('person1');\n6. Save the new entity (case or contact);\n7. Navigate to the 'Persons' directory and observe the entities.\n\n### Actual Behavior\n \nThere are 2 persons with the details of 'person1', but one of them is associated with the entity created at step1 and one of them is associated with the entity created at step6.\n\n### Expected Behavior\n \nThere is 1 person with the details of 'person1' and it has 2 entities associated: the entity created at step1 and the entity created at step6.\n\n### Screenshots\n \nimage\n\nimage\n\n### System Details\n \n* Device: Windows 10\n* SORMAS version: 1.69.0-SNAPSHOT\n* Android version/Browser: Chrome\n* Server URL: test-de2.sormas.netzlink.com\n* User Role: Admin, NatUser\n\n### Additional Information\n \nNote 1: When processing a lab message and choosing to create a new event participant, the behavior described in the ticket does not reproduce.\n\nNote 2: This issue might be related to ticket #8012","known_context_document_ids":["gh_issue_1138657743"],"reference_answer":"@bernardsilenou Almost. I think what you need to realize is that using the search function is totally different than triggering duplicate detection. The search will merely serve as a selection option of existing persons. Selecting a person will basically fill the person_id in the case table with an existing reference and therefore, duplicate detection would not be triggered, yes.\n\nThink of converting contacts or ep's to cases, the person link is already there. It will work the same way when selecting existing persons.","answer_document_id":"gh_comment_913758296","silver_evidence_path":["gh_comment_1044048061","gh_issue_987152905","gh_comment_913758296"],"evidence_issue_ids":[1138657743,987152905],"source_repo_name":"hzi-braunschweig/SORMAS-Project","source_issue_id":1138657743,"source_issue_number":8013,"source_issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","target_repo_name":"hzi-braunschweig/SORMAS-Project","target_issue_id":987152905,"target_issue_number":6599,"target_issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","reference_anchor_document_id":"gh_comment_1044048061","reference_answer_author":"kwa20","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2353,"anchor_target_overlap":0.3235,"target_answer_overlap":0.3077},"issue_created_at":"2022-02-15T12:57:21+08:00","valid_comment_count":35,"fragments":[{"document_id":"gh_issue_1138657743","fragment_type":"issue_description","sequence":0,"text":"[Lab messages] Using the 'Person search' option when creating new entities, via processing lab messages, creates a new person\n### Bug Description\n \nWhen processing lab messages to create new entities (cases and contacts), if the user uses the 'Person Search' option, the newly created entity is not associated with the selected person, but instead a new person gets created.\n\n### Steps to Reproduce\n \n1. Create a person by creating a new entity (i.e. 'person1');\n2. Navigate to 'Lab messages' in the 'Samples' directory and click 'Process' on an unprocessed lab message;\n3. In the first pop-up for 'Pick or create person' select 'Create new person' and click 'Confirm';\n4. In the second pop-up for 'Pick or create entry' select 'Create new case' or 'Create new contact';\n5. In the 'Create new case/contact' form, for the person related fields, use the 'Person search' option to select the person created at step1 ('person1');\n6. Save the new entity (case or contact);\n7. Navigate to the 'Persons' directory and observe the entities.\n\n### Actual Behavior\n \nThere are 2 persons with the details of 'person1', but one of them is associated with the entity created at step1 and one of them is associated with the entity created at step6.\n\n### Expected Behavior\n \nThere is 1 person with the details of 'person1' and it has 2 entities associated: the entity created at step1 and the entity created at step6.\n\n### Screenshots\n \nimage\n\nimage\n\n### System Details\n \n* Device: Windows 10\n* SORMAS version: 1.69.0-SNAPSHOT\n* Android version/Browser: Chrome\n* Server URL: test-de2.sormas.netzlink.com\n* User Role: Admin, NatUser\n\n### Additional Information\n \nNote 1: When processing a lab message and choosing to create a new event participant, the behavior described in the ticket does not reproduce.\n\nNote 2: This issue might be related to ticket #8012","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-02-15T12:57:21+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1042598302","fragment_type":"issue_comment","sequence":1,"text":"I am not sure whether the expected behaviour described above is the only reasonable option here.\nWhen being in the entry (case/contact/event participant) creation form during processing a lab message, the user has already gone through a person selection. \nAn alternative expected behaviour could be that the person search button does not show in those forms when processing a lab message. \nimage","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-17T05:49:34+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042656616","fragment_type":"issue_comment","sequence":2,"text":"@adinaflorea9 @FredrikSchaeferVitagroup I think the problem here is that firstly, the person that was selected in the person search pop-up is not actually linked and secondly, the existing case is for the selected person is not detected as a duplicate.\n\nThe person search in lab message processing is actually quite crucial because often enough the duplicate detection is not reliable enough to detect actual duplicates and users are then forced to create them to get the lab message data elsewhere in the system. If not at least one person is suggested as a duplicate, they're also not able to search for a different person without this option.\n\nWhen a person is selected in the search person pop-up, there is no duplicate detection trigger needed because a person has been selected that already exists. However, it needs to be linked instead of created again. For the subsequent entity, e.g. case, this person might also already have a duplicate which was not previously suggested because the person wasn't detected. At this point this should get triggered again for a selected person.","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2022-02-17T07:39:39+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042669359","fragment_type":"issue_comment","sequence":3,"text":"@kwa20 So this is the workflow you describe:\n\n1. Start processing a lab message\n2. Create a person (because the correct existing person is not proposed)\n3. Select one of the entry creation forms (e.g. case creation form)\n4. Select another person there\n5. (continue)\n\nI don't like it, for two reasons.\nFirst, the newly created person is saved after step 2. When 4. is done, it needs to be removed, which is cumbersome.\nSecond, it's quite an effort for the user to get the correct person selected.\n\nHow about\n- [ ] hide the search person button in the entry creation forms when processing a lab message\n- [ ] show it in the Select or Create Person dialog when processing a lab message instead","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-17T07:59:59+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042693298","fragment_type":"issue_comment","sequence":4,"text":"@FredrikSchaeferVitagroup I think I like that general idea and it would support that users usually work from a person oriented perspective.\n \n\nThis pop-up is only triggered when a duplicate is suggested and it already gives you the option to search for a different person. The main problem here is that this pop-up is not shown all the time, even if duplicates might exist the detection might not find and suggest it.\n\nMaybe we need to initialize that pop-up all the time and force users to chose if they want to search for an existing person, select a found duplicate or create a new one.","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2022-02-17T08:31:03+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042711748","fragment_type":"issue_comment","sequence":5,"text":"@kwa20 Good point. So how about this?\n- [ ] hide the search person button in the entry (case/contact/EP) creation forms when processing a lab message.\n- [ ] show it in the Pick or create person dialog when processing a lab message instead (as 1 below).\n- [ ] always show the Pick or create Person dialog, no matter whether a possible duplicate was automatically detected or not.\n- [ ] change the behaviour of the list of proposed person (2 below). Fill it with possible matches automatically (like it is now). When the list is empty, hide it. Instead show a label stating: `No possible match could automatically be determined. You can manually search for existing persons.` Whatever person gets select by the manual search, add it to the list of proposed persons and select it (so that users can directly click on the `CONFIRM` button).\n- [ ] change the caption of the option from `Select a matching person` to `Select an existing person`.\n\nimage","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-17T08:54:24+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042857882","fragment_type":"issue_comment","sequence":6,"text":"@FredrikSchaeferVitagroup Sounds like a good plan!\n\nJust some minor comments: \n \n\nMight be nice to have it as a little info icon plus text\n \n\nThe current caption is fine I think and would then be consistent with the other pop-ups","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2022-02-17T11:36:16+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042934337","fragment_type":"issue_comment","sequence":7,"text":"Looking at the list of comments trying to specify this, I am pretty certain that this is not a bug, but a change request. I will change the ticket labels accordingly. This also means that it will not necessarily be done in this sprint.","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-17T13:10:49+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042936976","fragment_type":"issue_comment","sequence":8,"text":"Quickly resolving the problem described in the summary (e.g. by hiding the search person button) could be a bugfix.","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-17T13:13:46+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1044048061","fragment_type":"issue_comment","sequence":9,"text":"@FredrikSchaeferVitagroup @adinaflorea9 I think what we need to fix here at least is the correct linking of the selected person. Otherwise, the implementation of URL will be discarded for lab messages and that would be very unfortunate.\n\nI think we can agree that the process is not ideal as descried in URL Therefore, I suggest to fix the person link with the bugfix so the implemented feature can be used and create a change request to implement what is described here URL","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2022-02-18T07:19:09+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[987152905],"is_known_query_context":false},{"document_id":"gh_comment_1044064286","fragment_type":"issue_comment","sequence":10,"text":"Really fixing this is not so easy. As I wrote before, the duplicate person gets created and saved before the user selects another one.","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-18T07:35:43+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1044481402","fragment_type":"issue_comment","sequence":11,"text":"As @kwa20 pointed out, it is necessary that the pick or create person dialog always shows when processing lab messages then, not only when there are possible matches. This should also be be implemented in this ticket.","author_login":"FredrikSchaeferVitagroup","author_association":"CONTRIBUTOR","created_at":"2022-02-18T12:53:51+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":1138657743,"issue_number":8013,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/8013","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_987152905","fragment_type":"issue_description","sequence":0,"text":"Add a person search option on creation forms [3]\n### Situation Description\n \nCurrently, users cannot search for existing persons in the system and simply add another entity (e.g. case) to them. They are forced to go through duplicate detection in order to do so.This is not very user friendly or efficient when users have to handle many entities at once or quickly search for existing persons during the creation process.\n### Feature Description\n \n- Add a search button next to the person name in any creation form (cases, contacts, event participants, travel entries, immunizations; also when processing lab messages)\n- Upon clicking the button, open a pop-up to search existing persons in the system (cf. screenshot2)\n - When confirming the existing person, link the entity to be created to the existing person when saving.\n - Visually, grey out person related fields and show the persons details that has just been selected (cf. screenshot3)\n- When a person has been selected in the creation form, there needs to be the option to remove the person if the linkage or selection was not desired for whatever reason.\n- Only show persons that the user has unpseudonymized access to based on the user filter\n- Person duplicate detection can be skipped when a person has been selected, but case/contact/event participant duplicate detection still needs to be triggered\n### Possible Alternatives\n \n\n### Additional Information\n \n\n<img width=\"571\" alt=\"SearchPerson\" src=\" URL \n<img width=\"559\" alt=\"SearchPerson3\" src=\" URL \n<img width=\"577\" alt=\"SearchPerson2\" src=\" URL","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2021-09-02T20:50:46+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912118864","fragment_type":"issue_comment","sequence":1,"text":"@kwa20 Question please:\n- By adding this search on the creation form, does it mean automatic duplicate person detection should be turned off? because this specification is exactly what duplicate detection does in an automatic way, or I did not understand it well?\n- Currently we can search a person on person directory. In your initial specification of the person directory/ from, the next phase was to extend this form to be able to add entities to the person. Is your initial idea no longer valid? \n- I would vote for the option to add entities through the person form.","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-02T23:05:11+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912263569","fragment_type":"issue_comment","sequence":2,"text":"@bernardsilenou no the duplicate detection should not turned off as they user might not know that person was in the system before. But if the user knows it, he/she must not enter all details which are required to save and start the duplicate detection.\n\nI would vote to have both ways (person form and this option) to be more flexible for the user.","author_login":"Marko-ilmkreis","author_association":"NONE","created_at":"2021-09-03T05:21:14+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912289030","fragment_type":"issue_comment","sequence":3,"text":"@bernardsilenou @Marko-ilmkreis I also think we should have both options because the creation option in person forms will e.g. not solve the problem of persons not being properly detected when processing lab messages. I also see advantages in flexibility of workflows.","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2021-09-03T06:22:08+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912303148","fragment_type":"issue_comment","sequence":4,"text":"I strongly support this feature request.\n\nBeing forced to re-enter a person's data and trust the system to find a \"duplicate\" even though you know exactly that the person is already in the system is not a very effective way and has a much higher potential for errors.","author_login":"Jan-Boehme","author_association":"NONE","created_at":"2021-09-03T06:54:38+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912443010","fragment_type":"issue_comment","sequence":5,"text":"@All: I think there are some point that I still do not get it. I do not understand the main difference between user trigger (this issue) and automatic trigger person detection.\n1. While creating a case, search a person and if person is\n 1.1 found, should duplicate person detection be called? ( If yes, then this is double, right?)\n 1.2 not found, should duplicate person detection be called? (If yes, then duplicate detection should also not find any person since the back-end methods should be the same )\n2. While creating a case, and do not search for duplicate person , should duplicate person detection be called? (If yes, then what does manual trigger add in the workflow?)\n3. Another point is the multiplicity of functions on each form. In most systems like sormas, then general rule is that users begin by searching a person on the person directory, if they find the person, add new entities to them, it not, create a new person and add entities to them. \n4. Having two ways of doing the same thing in the system also comes with a cost (probability of having more bugs + maintenance). If this is a better way, then we can we drop the other option of going through the person form?","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-03T10:42:48+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912444885","fragment_type":"issue_comment","sequence":6,"text":"@Jan-Boehme \nPlease can you elaborate on this URL \nIf there any possibility to detect duplicate person without entering some of the person variables (, name, sex , ...) ?","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-03T10:46:33+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[987152905],"is_known_query_context":false},{"document_id":"gh_comment_912447782","fragment_type":"issue_comment","sequence":7,"text":"- Another advantage to encourage user to first search through the person directory is that they can use more variables of the person (birth date, address, name, sex, ...) rather than just name, thus more sensitive.\n- I have a feeling that the current duplicate person detection is not working as intended. Because this issue is describing how it should work, no matter if user search person or not. Maybe I am just missing something.\n-","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-03T10:52:13+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_912529533","fragment_type":"issue_comment","sequence":8,"text":"Sure.\nAt the moment there is no other way to get the system to find a potential duplicate person without at least entering first name, last name, birthdate and sex. And even if you enter all them there is still the possibility of the system not finding any duplicate (i.e. a typo in the birthdate). But when you realize that you made an error it is too late and there's no way to revert any of it.\n\nGeneral comment:\nI agree with @bernardsilenou that, from an end user's perspective, everything should revolve around the person and it should be the first entry point for doing anything in SORMAS.\nThe question is how realistic is it to change that now?\nImplementing this issue would help somewhat with that because you would be able to search the person directory and pick the correct one before committing to save date.\n\nI think the confusion stems from the fact that searching the person directory and freely picking one is tied to the duplicate detection window at the moment when they really are two different things.\n\nWhen clicking on the \"looking glass\" button the user is not forcefully triggering the duplicate detection code but just opening the window where he can search and pick any person from the person directory.\nIf the users does so, there is of course no need to do the automatic detection upon saving. That would mess with the whole point of the feature.","author_login":"Jan-Boehme","author_association":"NONE","created_at":"2021-09-03T13:12:46+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[987152905],"is_known_query_context":false},{"document_id":"gh_comment_912599377","fragment_type":"issue_comment","sequence":9,"text":"@Jan-Boehme \nThanks for the explanation URL \n- `I think the confusion stems from the fact that searching the person directory and freely picking one is tied to the duplicate detection window at the moment when they really are two completely different things.` I think what you meant here is that the person directory filter case person by default, right? I think the default should be \"All person\", the current implementation can mislead users . Centralized systems like in France has many persons and this tab takes much time to load. I think this should not be a valid reason to limit the person directory only to cases by default. There should be a technical solution for this I suppose.\n- @MateStrysewske what about creating a copy of the person table with only the columns used by filters: name, address, tel, age, dob, etc such that when we search for a person on the person directory, we do not do any merging of tables but use this one table only, this just a rough idea.\n- If you have a difficult and easy task to do, always do the difficult one first (leads to higher increment), Suggest we work on #6053 and then work on this one later.","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-03T14:53:55+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[987152905],"is_known_query_context":false},{"document_id":"gh_comment_913333173","fragment_type":"issue_comment","sequence":10,"text":"@bernardsilenou @MateStrysewske @Jan-Boehme In my opinion these are complete different ways to find the right person an open a case/contact/ep for them. The duplicate detection should be only used for the cases the user does not know that there is a duplicate.\nThe \"looking glass\" is importent for users which are creating a lot of contacts/cases/ep and dont want to switch between them and the person tab. They just want to work. With these function to search we must make sure that the user sees all persons (even in other jurisdictions), like in duplicate detection. \nThe #6053 should be also enabled because thats also a very usable way to create the c/c/ep.","author_login":"Marko-ilmkreis","author_association":"NONE","created_at":"2021-09-06T04:38:47+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913410814","fragment_type":"issue_comment","sequence":11,"text":"I second what @Marko-ilmkreis said. Those two issues are not interchangable and we can't implement one or the other as they both try to achieve different things. \n\n@bernardsilenou At the moment I feel like we are talking about two different things.\nThis issue is just about providing the users with a \"shortcut\" to a functionality that we already have in the system.\nWhich is the possibility to search for any person and link it to a case/contact/lab message, etc. during creation in order to speed up the process and give the user more control over what is happening.\n(The same thing that currently happens when the duplicate detection is triggered and the user selects \"Select a person\" in the popup window.\nThis has nothing to do with the person directory view that comes up when clicking on \"Persons\" in the main navigation or it's performance.","author_login":"Jan-Boehme","author_association":"NONE","created_at":"2021-09-06T07:25:46+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913518809","fragment_type":"issue_comment","sequence":12,"text":"I think this feature makes sense because it allows users to use this functionality without having to navigate to the person directory if they're in a process of documenting several cases, or even when they've already filled in case details and only then realise that the person is probably already in the system. I don't think it should replace anything else (e.g. duplicate detection), and I also believe that having a full-fledged person directory copy would be overkill.","author_login":"MateStrysewske","author_association":"MEMBER","created_at":"2021-09-06T10:02:32+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913594600","fragment_type":"issue_comment","sequence":13,"text":"@Jan-Boehme @MateStrysewske @Marko-ilmkreis \n- I also agree with you that users should not navigate to person directory all the time when creating entities.\n- My main question has not still been answered. Sorry if i have not understood the request.\n- @MateStrysewske How does this method differ from duplicate person detection please? When a user create a case, contact or any entity linked to a person, sormas should automatically search for all duplicate persons that the user has access to. Why does the user has to use the \"looking glass\" to search for the person when the idea of duplicate person detection is that this should always work irrespective of users choice in activating \"looking glass\".","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-06T12:04:43+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913636554","fragment_type":"issue_comment","sequence":14,"text":"@bernardsilenou Duplicate detection takes place AFTER the user clicks von \"Save\". This method here would be an option for the user to manually search for the person before, e.g. when they're not sure how exactly the person is called, or when they know for a fact that the person is in the system, but don't want to rely on duplicate detection.","author_login":"MateStrysewske","author_association":"MEMBER","created_at":"2021-09-06T13:07:07+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913743983","fragment_type":"issue_comment","sequence":15,"text":"@MateStrysewske @kwa20 Thanks\n- So the main difference here is whether we click on \"save\" or \"search\" in order to trigger duplicate detection. Then that is fine, I though there was a difference in back-end method.\n- So if user search and pick a match, then no need to call duplicate detection again, right? because users may get annoyed. Similarly to if they search, find no duplicate and when they save, calling duplicate detection again may annoy them.\n- So if user trigger \"looking glass\" and either choose a person or create a new person, we do not call duplicate person detection, what do you think pls?","author_login":"bernardsilenou","author_association":"COLLABORATOR","created_at":"2021-09-06T15:59:24+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_913758296","fragment_type":"issue_comment","sequence":16,"text":"@bernardsilenou Almost. I think what you need to realize is that using the search function is totally different than triggering duplicate detection. The search will merely serve as a selection option of existing persons. Selecting a person will basically fill the person_id in the case table with an existing reference and therefore, duplicate detection would not be triggered, yes.\n\nThink of converting contacts or ep's to cases, the person link is already there. It will work the same way when selecting existing persons.","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2021-09-06T16:24:45+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1024235104","fragment_type":"issue_comment","sequence":17,"text":"Verified ticket on test-de2.sormas.netzlink.com and test.sormas.netzlink.com.\n\nI have discussed with @BarnaBartha and the ticket will be reopened due to the following:\n\n1. Person search option needs to be added to the 'Create new travel entry' form;\n\n2. Person search option should not be displayed in forms where the person related information is already filled in by the system:\n- 'Create new contact' form (that is accessed from the 'Cases' directory - 'Epidemiological data' tab - 'Contacts with source case' card);\n- 'New immunization' form (that is accessed from the 'Persons' directory - 'Person' page - 'Immunizations' card);\n- 'Create new contact' form (that is accessed from the 'Events' directory - 'Event Participant' tab - 'Contacts' card).","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-01-28T13:39:46+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1024528763","fragment_type":"issue_comment","sequence":18,"text":"@BarnaBartha @adinaflorea9 These are some UI issues that I have found when testing:\n\n|current|desired|\n|:-|:-\n|<img width=\"378\" alt=\"personSearchUI\" src=\" URL width=\"383\" alt=\"personSearchUiFix\" src=\" URL \n|<img width=\"620\" alt=\"personSearchUI2\" src=\" URL width=\"622\" alt=\"personSearchUiFix2\" src=\" URL","author_login":"kwa20","author_association":"COLLABORATOR","created_at":"2022-01-28T19:14:56+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1025587189","fragment_type":"issue_comment","sequence":19,"text":"While testing the ticket a new issue has been observed. After a discussion with @BarnaBartha it has been decided that a comment should be added to detail the behavior observed.\n\nLogging the comment in the same format as a bug:\n\nBug description:\nUsing the 'Person search option' allows the user to set 1 person as multiple event participants for the same event.\n\nSteps to reproduce:\n1. Open or create an event;\n2. Click ‘Add Participant’ and create a new event participant (e.g. Person1);\n3. Afterwards, add a second event participant to the same event;\n4. When creating the new event participant, instead of entering person details manually, use the search for person feature;\n5. Search for Person1 (the first event participant added at step 2) and select them from the list below;\n6. Save the new event participant;\n7. Person1 is now listed twice as event participant in the same event.\n\nActual Behavior:\nThe same person is listed as 2 event participants in the same event.\n\nExpected Behavior:\nThe same person can not be listed as 2 event participants in the same event.\n\nAdditional information:\nIf a user tries to add Person1 as event participant manually (by entering the name and sex in the ‘create new event participant’ form) then they trigger the duplicate detection; if they pick the existing person from the list and try to save, they get an error that informs them that this person is already an event participant. \n\nScreenshot of the error message that appears:\nenter 1 person 2 times as event participant manually - you get an error saying that they can not be event participant twice","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-01-31T10:25:24+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1025629191","fragment_type":"issue_comment","sequence":20,"text":"@kwa20 I'd suggest to not fix the first very minor UI issue (the left-aligned button) because finding a way to fix it would take some time and is in no way worth the effort we'd need to put into it, in my opinion.","author_login":"MateStrysewske","author_association":"MEMBER","created_at":"2022-01-31T11:15:00+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1025647983","fragment_type":"issue_comment","sequence":21,"text":"While testing the ticket on test-de1.sormas.netzlink.com and test.sormas.netzlink.com., a new issue has been observed. After a discussion with @BarnaBartha it has been decided that a comment should be added to detail the behavior observed.\n\nLogging the comment in the same format as a bug:\n\nBug Description:\n\nAn error message stating ‘An error has occurred. An unexpected error occurred. Please contact your supervisor or administrator and inform them about it’ appears in the ‘Immunizations’ directory and ‘Lab messages directory’.\n\nSteps to reproduce:\n1. Create a person by creating a new immunization from the ‘Immunizations’ directory;\n2. Create a second person by creating a new case from the ‘Cases’ directory (when creating this person through the new case, in the person related fields, input the same data as for the person created at step 1);\n3. Duplicate detection is triggered; select ‘Create new person’ form the pop-up;\n4. Go to the ‘Immunizations’ tab and open the ‘Create new immunization’ form;\n5. Select a different disease than the previously selected ones (i.e. the diseases used when creating the persons from step 1 and step 2);\n6. For the person related fields use the ‘Person search option’ and search using the name of the persons from steps 1 and 2;\n7. Click to select either of the persons;\n\nActual behavior:\nUser is not able to pick either of the persons from the list and an error message appears, stating ‘An error has occurred. An unexpected error occurred. Please contact your supervisor or administrator and inform them about it’.\n\nExpected behavior:\nUser is able to successfully pick either of the persons from the list.\n\nScreenshots:\nScreenshot of the error message:\nSecond time the error reproduced - you also have two persons\n\nAdditional information:\nThe same error message can be observed in the ‘Samples’ directory when attempting to process a lab message.\nSteps to reproduce:\n1. Pick an unprocessed lab message;\n2. From the first pop-up pick select matching person and pick a person from the list;\n3. From the second pop-up pick create new case and click confirm – error message appears;\n(if here the user picks create new contact no error message appears)\n(if here the user picks create new event participant no error message appears)\n Or,\n1. Pick an unprocessed lab message;\n2. From the first pop-up pick ‘select a different person’ and pick a person from the list;\n3. From the second pop-up pick create new case and click confirm – error message appears;\nOr, \n1. Pick an unprocessed lab message;\n2. From the first pop-up pick ‘create new person’;\n3. From the second pop-up pick create new case and click confirm - error message appears;\n(if here the user picks create new contact no error message appears)\n(if here the user picks create new event participant no error message appears)","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-01-31T11:37:14+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1027809475","fragment_type":"issue_comment","sequence":22,"text":"A similar error message that was reproducing for 'Immunizations' and 'Samples - Lab messages' directories was logged in the comments from above.\n\n@MateStrysewske has asked in a comment from ticket #7840 that I log the following as a comment here:\n\nBug description:\nAn error message stating ‘An error has occurred. An unexpected error occurred. Please contact your supervisor or administrator and inform them about it’ appears when the user goes through the following flows:\n\n- create a case for a contact person;\n\n- if a sample with a positive pathogen test result is added to a contact, a pop-up to create a resulting case is triggered; if the user selects 'Yes', the error message appears;\n\n- create a case for an event participant;\n\n- if a sample with a positive pathogen test result is added to an event participant, a pop-up to create a resulting case is triggered; if the user selects 'Yes', the error message appears;\n\n- create a case for a travel entry;\n\n- send a case to the reporting tool.\n\nActual Behavior\nAn error message stating ‘An error has occurred. An unexpected error occurred. Please contact your supervisor or administrator and inform them about it’\n\nExpected Behavior\nNo error message appears when the user goes through the flows described above.\n\nScreenshots:\nCreate case from an event participant error message\n\nSystem Details\nDevice: Windows 10\nSORMAS version: 1.68.0-SNAPSHOT\nAndroid version/Browser: Chrome\nServer URL: test-de1.sormas.netzlink.com\nUser Role: Admin, NatUser","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-02-02T10:49:09+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1028756763","fragment_type":"issue_comment","sequence":23,"text":"Tested the ticket on test-de1.sormas.netzlink.com and after a discussion with @BarnaBartha it has been decided that a comment should be added to detail the behavior observed.\n\n1. Person search option should not be displayed in forms where the person related information is already filled in by the system:\n- [ ] 'Create new travel entry' form (that is accessed from the 'Persons' directory - 'Person' page - 'Travel Entries' card);\n- [ ] 'Create new travel entry' form (that is accessed from the 'Cases' directory - 'Epidemiological data' tab - 'Travel Entries' card);\n\n2. Person search option needs to be added to:\n- [ ] the 'Add new event participant' form that is accessed from the 'Samples' directory - via 'Lab messages' - unprocessed lab message - 'Create new event participant';\n\n- [ ] Error message stating ‘An error has occurred. An unexpected error occurred. Please contact your supervisor or administrator and inform them about it’ appears when the user goes through the following flow:\n - create or open an existing event;\n - open the 'Add new event participant' form;\n - input data in the mandatory fields;\n - click 'Save';\n - observe the error message.\n \nScreenshot of the error message:\nCreated new event - tried to add a brand new event participant - error message appears on my local host","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-02-03T09:01:18+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1031311035","fragment_type":"issue_comment","sequence":24,"text":"Verified ticket on the local machine and test-de2.sormas.netzlink.com using the latest version of Sormas 1.68.0-SNAPSHOT.\n\n3 follow up issues that were initially logged on the 3rd of February in a comment on this ticket, have been moved into a separate ticket #7903.","author_login":"adinaflorea9","author_association":"NONE","created_at":"2022-02-07T10:28:49+08:00","repo_name":"hzi-braunschweig/SORMAS-Project","issue_id":987152905,"issue_number":6599,"issue_url":"https://github.com/hzi-braunschweig/SORMAS-Project/issues/6599","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0387","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Ensure that all codeowners are members of the OpenTelemetry organization?","query_context":"### Component(s)\n\n_No response_\n\n### Describe the issue you're reporting\n\n_See URL for the last campaign_\n\nNot all codeowners of this repository are members of the OpenTelemetry github organization, which membership is associated with membership of the OpenTelemetry project.\n\nThe guidelines enforce membership because it allows to assign and ping codeowners on issues or pull requests. Unfortunately, if you try to create an issue or assign a PR to a codeowner who is not member of OpenTelemetry, the workflow fails. I would like to fix this issue.\n\nGoing forward, I would also ideally like to make sure that we check that codeowners are members of the github organization whenever the codeowners file is touched.\n\nThe process to become a member of OpenTelemetry is straightforward. Open this issue template on the community project to get started.\n\nI have identified a list of codeowners who are not currently members of OpenTelemetry. I will ping them in this issue below.\n1. Please cross your name to indicate you have seen this message.\n2. (optional) Please get in touch over Slack: I have created a slack channel for the purpose of codeowner discussions, #otel-collector. Feel free to reply here as well and provide clarifications if any information is incorrect.\n3. Please work towards membership. Feel free to use 2. for any questions.\n4. If I don't hear from you in the next 60 days (tentative), I will open an issue to follow up. The issue will offer to either help you become a member or open a pull request to move to emeritus status.\n\n* [ ] @Caleb-Hurshman\n* [ ] @MaxKsyunz\n* [ ] @MitchellGale\n* [ ] @YANG-DB\n* [ ] @asaharn\n* [x] @billmeyer\n* [x] @emreyalvac\n* [ ] @shaochengwang\n* [ ] @yiyang5055\n* [ ] @am-kinetica\n* [x] @mcube8\n* [x] @sokoide\n* [x] @zdaratom\n* [x] @braydonk\n\nThank you and apologies for the inconvenience.","known_context_document_ids":["gh_issue_2081282258"],"reference_answer":"I would prefer to remove the old account, since having multiple accounts may imply multiple votes during elections for example.\n\n@open-telemetry/governance-committee what is your take here?","answer_document_id":"gh_comment_1894897390","silver_evidence_path":["gh_comment_1894100385","gh_issue_2083273582","gh_comment_1894897390"],"evidence_issue_ids":[2081282258,2083273582],"source_repo_name":"open-telemetry/opentelemetry-collector-contrib","source_issue_id":2081282258,"source_issue_number":30552,"source_issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","target_repo_name":"open-telemetry/community","target_issue_id":2083273582,"target_issue_number":1876,"target_issue_url":"https://github.com/open-telemetry/community/issues/1876","reference_anchor_document_id":"gh_comment_1894100385","reference_answer_author":"bogdandrutu","reference_answer_author_association":"MEMBER","quality_score":78.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.4286,"anchor_target_overlap":0.2857,"target_answer_overlap":0.0},"issue_created_at":"2024-01-15T05:33:07+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2081282258","fragment_type":"issue_description","sequence":0,"text":"Ensure that all codeowners are members of the OpenTelemetry organization\n### Component(s)\n\n_No response_\n\n### Describe the issue you're reporting\n\n_See URL for the last campaign_\n\nNot all codeowners of this repository are members of the OpenTelemetry github organization, which membership is associated with membership of the OpenTelemetry project.\n\nThe guidelines enforce membership because it allows to assign and ping codeowners on issues or pull requests. Unfortunately, if you try to create an issue or assign a PR to a codeowner who is not member of OpenTelemetry, the workflow fails. I would like to fix this issue.\n\nGoing forward, I would also ideally like to make sure that we check that codeowners are members of the github organization whenever the codeowners file is touched.\n\nThe process to become a member of OpenTelemetry is straightforward. Open this issue template on the community project to get started.\n\nI have identified a list of codeowners who are not currently members of OpenTelemetry. I will ping them in this issue below.\n1. Please cross your name to indicate you have seen this message.\n2. (optional) Please get in touch over Slack: I have created a slack channel for the purpose of codeowner discussions, #otel-collector. Feel free to reply here as well and provide clarifications if any information is incorrect.\n3. Please work towards membership. Feel free to use 2. for any questions.\n4. If I don't hear from you in the next 60 days (tentative), I will open an issue to follow up. The issue will offer to either help you become a member or open a pull request to move to emeritus status.\n\n* [ ] @Caleb-Hurshman\n* [ ] @MaxKsyunz\n* [ ] @MitchellGale\n* [ ] @YANG-DB\n* [ ] @asaharn\n* [x] @billmeyer\n* [x] @emreyalvac\n* [ ] @shaochengwang\n* [ ] @yiyang5055\n* [ ] @am-kinetica\n* [x] @mcube8\n* [x] @sokoide\n* [x] @zdaratom\n* [x] @braydonk\n\nThank you and apologies for the inconvenience.","author_login":"atoulme","author_association":"CONTRIBUTOR","created_at":"2024-01-15T05:33:07+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1892220382","fragment_type":"issue_comment","sequence":1,"text":"I am unable to check the checkbox for my name, but I have seen the issue.\n\n`#otel-collector-codeowners` is an archived channel, will you be unarchiving it for this issue's purposes?","author_login":"braydonk","author_association":"CONTRIBUTOR","created_at":"2024-01-15T13:54:15+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894100385","fragment_type":"issue_comment","sequence":2,"text":"_Just adding a couple reference issues_\n\n@braydonk - URL \n@zdaratom - URL","author_login":"crobert-1","author_association":"MEMBER","created_at":"2024-01-16T16:34:01+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[2083273582],"is_known_query_context":false},{"document_id":"gh_comment_2009150072","fragment_type":"issue_comment","sequence":3,"text":"\"zdaratom\" is no longer needed as it has been updated via URL","author_login":"zdaratom-s1","author_association":"CONTRIBUTOR","created_at":"2024-03-20T09:47:15+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2085561953","fragment_type":"issue_comment","sequence":4,"text":"As of 2024/04/30:\n\n$ githubgen\n2024/04/30 10:50:08 codeowners are not members: Caleb-Hurshman, MaxKsyunz, MitchellGale, YANG-DB, adcharre, am-kinetica, asaharn, cheempz, driverpt, emreyalvac, jcreixell, jerrytfleung, rlankfo, shaochengwang, swar8080, thmshmm, yiyang5055, zpzhuSplunk","author_login":"alxbl","author_association":"NONE","created_at":"2024-04-30T14:54:08+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2458843048","fragment_type":"issue_comment","sequence":5,"text":"After a long wait, a few of the folks here are still not members of the OpenTelemetry organization. Unfortunately, it is time to move you to emeritus. See URL \n\nIf you have any problem with this approach, please get in touch.","author_login":"atoulme","author_association":"CONTRIBUTOR","created_at":"2024-11-06T06:51:39+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2463145558","fragment_type":"issue_comment","sequence":6,"text":"Hi @atoulme,\n\nThank you very much for your understanding. I need one more sponsor. How should I proceed?","author_login":"emreyalvac","author_association":"CONTRIBUTOR","created_at":"2024-11-07T20:24:48+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2463151134","fragment_type":"issue_comment","sequence":7,"text":"Hi @atoulme,\n\nThank you very much for your understanding. I need one more sponsor. I am trying to find a sponsor.\n\n URL","author_login":"emreyalvac","author_association":"CONTRIBUTOR","created_at":"2024-11-07T20:28:22+08:00","repo_name":"open-telemetry/opentelemetry-collector-contrib","issue_id":2081282258,"issue_number":30552,"issue_url":"https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30552","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2083273582","fragment_type":"issue_description","sequence":0,"text":"REQUEST: New membership for zdaratom\n### GitHub Username\n\n@zdaratom\n\n### Requirements\n\n- [ x] I have reviewed the community membership guidelines ( URL \n- [ x] I have enabled 2FA on my GitHub account. See URL \n- [ x] I have subscribed to the Slack channel (use URL to get an invite)\n- [x ] I am actively contributing to 1 or more OpenTelemetry subprojects\n- [x ] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines. Among other requirements, sponsors must be approvers or maintainers of at least one repository in the organization and not both affiliated with the same company\n- [ x] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application\n\n### Sponsors\n\n@zdaratom-s1\n@atoulme\n\n### List of contributions to the OpenTelemetry project\n\n- URL \n- URL \n- URL","author_login":"zdaratom","author_association":"NONE","created_at":"2024-01-16T08:18:18+08:00","repo_name":"open-telemetry/community","issue_id":2083273582,"issue_number":1876,"issue_url":"https://github.com/open-telemetry/community/issues/1876","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894897390","fragment_type":"issue_comment","sequence":1,"text":"I would prefer to remove the old account, since having multiple accounts may imply multiple votes during elections for example.\n\n@open-telemetry/governance-committee what is your take here?","author_login":"bogdandrutu","author_association":"MEMBER","created_at":"2024-01-17T03:56:39+08:00","repo_name":"open-telemetry/community","issue_id":2083273582,"issue_number":1876,"issue_url":"https://github.com/open-telemetry/community/issues/1876","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894926811","fragment_type":"issue_comment","sequence":2,"text":"I agree, this is more like an account transfer than a new membership. @zdaratom does that work for you?","author_login":"tedsuo","author_association":"CONTRIBUTOR","created_at":"2024-01-17T04:38:44+08:00","repo_name":"open-telemetry/community","issue_id":2083273582,"issue_number":1876,"issue_url":"https://github.com/open-telemetry/community/issues/1876","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0388","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Expected to read 4 header bytes but only received 0.","query_context":"### The issue\nThis error is thrown on `SaveChanges` in one Web Api Action, every time. Other Actions don't have this issue.\nI am updating about 20 entries in this SaveChanges, more than in others. After getting this error in this one place a few times, other actions also starts throwing it. After a few seconds they go back to normal.\n\nI am using the latest MySQL on Google Cloud, and I am using **SSL** for connections.\nI am surprised at how little info on this issue is on the web, and this seems to be a completely generic error.\n\n**connect_timeout** 10\n**delayed_insert_timeout** 300\n**have_statement_timeout** YES\n**innodb_flush_log_at_timeout** 1\n**innodb_lock_wait_timeout** 50\n**innodb_rollback_on_timeout** OFF\n**interactive_timeout** 28800\n**lock_wait_timeout** 31536000\n**net_read_timeout** 30\n**net_write_timeout** 600\n**rpl_stop_slave_timeout** 31536000\n**slave_net_timeout** 30\n**wait_timeout** 28800\n\nException message:\nStack trace:\n\nSystem.IO.EndOfStreamException: Expected to read 4 header bytes but only received 0.\n at MySqlConnector.Protocol.Serialization.ProtocolUtility. g__AddContinuation|5_0(ValueTask`1 readPacketTask, BufferedByteReader bufferedByteReader, IByteHandler byteHandler, Func`1 getNextSequenceNumber, ArraySegmentHolder`1 previousPayloads, ProtocolErrorBehavior protocolErrorBehavior, IOBehavior ioBehavior) in /_/src/MySqlConnector/Protocol/Serialization/ProtocolUtility.cs:line 476\n at MySqlConnector.Core.ServerSession.ReceiveReplyAsyncAwaited(ValueTask`1 task) in /_/src/MySqlConnector/Core/ServerSession.cs:line 943\n\n### Further technical details\n\nMySQL version: 8.0.18-google\nPomelo.EntityFrameworkCore.MySql version: 6.0.1\nMicrosoft.AspNetCore.App version: 6.0","known_context_document_ids":["gh_issue_1116814296"],"reference_answer":"The general meaning of this error is that the library is waiting for data from the server, but none has arrived (and I think the connection has been closed, otherwise a timeout would have occurred). \n\nI note that this seems to be coming from `CreateMinimumPooledSessions`; is there any improvement if you set `MinPoolSize=0` in your connection string?\n\nFinally, these code style issues are unlikely to be contributing to the problem, but you have unnecessary patterns in your code. The `try`/`catch { throw; }`/`finally` code can all be deleted; `using (var conn = new MySqlConnection())` will correctly close (Dispose) the connection when control leaves the `using` block. You should also add a second `using` block around `using (var grid = await conn.QueryMultipleAsync())` because Dapper's GridReader is `IDisposable`.","answer_document_id":"gh_comment_429013538","silver_evidence_path":["gh_comment_1023765792","gh_issue_368923078","gh_comment_429013538"],"evidence_issue_ids":[1116814296,368923078],"source_repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","source_issue_id":1116814296,"source_issue_number":1610,"source_issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","target_repo_name":"mysql-net/MySqlConnector","target_issue_id":368923078,"target_issue_number":571,"target_issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","reference_anchor_document_id":"gh_comment_1023765792","reference_answer_author":"bgrainger","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1429,"target_answer_overlap":0.25},"issue_created_at":"2022-01-27T22:45:10+08:00","valid_comment_count":34,"fragments":[{"document_id":"gh_issue_1116814296","fragment_type":"issue_description","sequence":0,"text":"Expected to read 4 header bytes but only received 0.\n### The issue\nThis error is thrown on `SaveChanges` in one Web Api Action, every time. Other Actions don't have this issue.\nI am updating about 20 entries in this SaveChanges, more than in others. After getting this error in this one place a few times, other actions also starts throwing it. After a few seconds they go back to normal.\n\nI am using the latest MySQL on Google Cloud, and I am using **SSL** for connections.\nI am surprised at how little info on this issue is on the web, and this seems to be a completely generic error.\n\n**connect_timeout** 10\n**delayed_insert_timeout** 300\n**have_statement_timeout** YES\n**innodb_flush_log_at_timeout** 1\n**innodb_lock_wait_timeout** 50\n**innodb_rollback_on_timeout** OFF\n**interactive_timeout** 28800\n**lock_wait_timeout** 31536000\n**net_read_timeout** 30\n**net_write_timeout** 600\n**rpl_stop_slave_timeout** 31536000\n**slave_net_timeout** 30\n**wait_timeout** 28800\n\nException message:\nStack trace:\n\nSystem.IO.EndOfStreamException: Expected to read 4 header bytes but only received 0.\n at MySqlConnector.Protocol.Serialization.ProtocolUtility. g__AddContinuation|5_0(ValueTask`1 readPacketTask, BufferedByteReader bufferedByteReader, IByteHandler byteHandler, Func`1 getNextSequenceNumber, ArraySegmentHolder`1 previousPayloads, ProtocolErrorBehavior protocolErrorBehavior, IOBehavior ioBehavior) in /_/src/MySqlConnector/Protocol/Serialization/ProtocolUtility.cs:line 476\n at MySqlConnector.Core.ServerSession.ReceiveReplyAsyncAwaited(ValueTask`1 task) in /_/src/MySqlConnector/Core/ServerSession.cs:line 943\n\n### Further technical details\n\nMySQL version: 8.0.18-google\nPomelo.EntityFrameworkCore.MySql version: 6.0.1\nMicrosoft.AspNetCore.App version: 6.0","author_login":"SavoInfostream","author_association":"NONE","created_at":"2022-01-27T22:45:10+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1023724996","fragment_type":"issue_comment","sequence":1,"text":"@SavoInfostream Are you using the version of `MySqlConnector` that is referenced by Pomelo `6.0.1` (which is `2.1.2`), or are you using a newer version?\n\nWhat OS is your app running on (or is it executed serverless)?","author_login":"lauxjpn","author_association":"COLLABORATOR","created_at":"2022-01-27T23:10:07+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1023765792","fragment_type":"issue_comment","sequence":2,"text":"See URL for some background. Are you using something like ProxySQL?","author_login":"mguinness","author_association":"COLLABORATOR","created_at":"2022-01-28T00:26:59+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[368923078],"is_known_query_context":false},{"document_id":"gh_comment_1023952467","fragment_type":"issue_comment","sequence":3,"text":"@lauxjpn I tries with 2.0.0, 2.1.4 (latest currently) and 2.1.2. Same things happens.\nClient app is running on Windows 10. It is a local dev environment.","author_login":"SavoInfostream","author_association":"NONE","created_at":"2022-01-28T07:24:20+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1024226762","fragment_type":"issue_comment","sequence":4,"text":"@SavoInfostream Okay, so the app is running on your local Windows 10 machine, and is directly connected to a Google Cloud hosted MySQL instance, correct?\n\nI would suggest to log the SQL statements generated by the failing `SaveChanges()` call. Then replay those statements (in a transaction) in one go from your local dev machine to the Google Cloud hosted MySQL instance using the `mysql.exe` command line tool to see, whether this issue is potentially a Pomelo/MySqlConnector issue or an issue with the setup of the MySQL instance.\n\nAlso, check the MySQL error log for additional information.","author_login":"lauxjpn","author_association":"COLLABORATOR","created_at":"2022-01-28T13:28:34+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1024448200","fragment_type":"issue_comment","sequence":5,"text":"Also see MySql Long Running Query Fails on Docker .NET Core for a possible solution.","author_login":"mguinness","author_association":"COLLABORATOR","created_at":"2022-01-28T17:33:02+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1024704941","fragment_type":"issue_comment","sequence":6,"text":"Well, I have found a bug in MySQL. \nOne of my commands was a DELETE command which was causing the error. Google Cloud MySql log was showing:\n\"The manual page at URL contains information that should help you find out what is causing the crash.\"\n\nAnyways, this DELETE statement would try to delete a row from a table, and do a CASCADE delete from another table (foreign key). Besides cascade delete, another interesting thing is that the child table has a multi-valued index on one of its json columns. These two things combined, with or without transaction, crash the MySql. \n\nIf I delete the child row manually, it works. If I drop the index and delete the parent row, it deletes the parent and the child row.\n\nThanks for the help, everyone.\nI will try and report this to MySql people.","author_login":"SavoInfostream","author_association":"NONE","created_at":"2022-01-28T22:32:56+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1024736600","fragment_type":"issue_comment","sequence":7,"text":"@SavoInfostream Nice detective work! Thanks for letting us know and for reporting it to the MySQL team.","author_login":"lauxjpn","author_association":"COLLABORATOR","created_at":"2022-01-28T23:21:47+08:00","repo_name":"PomeloFoundation/Pomelo.EntityFrameworkCore.MySql","issue_id":1116814296,"issue_number":1610,"issue_url":"https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/issues/1610","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_368923078","fragment_type":"issue_description","sequence":0,"text":"MySql.Data.MySqlClient.MySqlException: Couldn't connect to server ---> System.IO.EndOfStreamException: Expected to read 4 header bytes but only received 0\nWe recently updated Mysqlconnector from 0.7.3 to .45.1 on a dotnet core 2.0 application. \n\nWe also turned connection pool on, to avoid information_schema.parameters calls for stored procedures.\n\nWe are seeing this exception consistently. We had to roll back. I've looked at Global variables and they seem to be identical to lower stack environments where we are unable to reproduce the issue. \n\n at MySqlConnector.Utilities.ValueTaskExtensions. d__0`2.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Utilities\\ValueTaskExtensions.cs:line 8\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()\n at MySqlConnector.Utilities.ValueTaskExtensions. d__0`2.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Utilities\\ValueTaskExtensions.cs:line 8\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at MySqlConnector.Core.ServerSession.TryAsyncContinuation(Task`1 task) in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Core\\ServerSession.cs:line 1230\n at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()\n at System.Threading.Tasks.Task.Execute()\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()\n at MySqlConnector.Core.ServerSession. d__58.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Core\\ServerSession.cs:line 356\n --- End of inner exception stack trace ---\n at MySqlConnector.Core.ServerSession. d__58.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Core\\ServerSession.cs:line 380\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at MySqlConnector.Core.ConnectionPool. d__18.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Core\\ConnectionPool.cs:line 346\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at MySqlConnector.Core.ConnectionPool. d__10.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\Core\\ConnectionPool.cs:line 40\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\n at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()\n at MySql.Data.MySqlClient.MySqlConnection. d__81.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\MySql.Data.MySqlClient\\MySqlConnection.cs:line 405\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\n at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()\n at MySql.Data.MySqlClient.MySqlConnection. d__22.MoveNext() in C:\\projects\\mysqlconnector\\src\\MySqlConnector\\MySql.Data.MySqlClient\\MySqlConnection.cs:line 183\n--- End of stack trace from previous location where exception was thrown ---\n at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\n at System.Runtime.CompilerServices.TaskAwaiter.GetResult()\n\nour code looks like this:\n\n public async Task >> QueryMultipleAsync(string sp, object args, CommandType type, IEnumerable returnTypes)\n {\n var results = new Dictionary >();\n using (var conn = new MySqlConnection(_connectionString))\n {\n await conn.OpenAsync();\n try\n {\n var grid = await conn.QueryMultipleAsync(sql: sp, param: args, commandType: type);\n foreach (Type returnType in returnTypes)\n {\n var returnValues = grid.Read(returnType);\n if (returnValues.Any())\n {\n results.Add(returnType, returnValues);\n }\n }\n }\n catch { throw; }\n finally\n {\n\n if (conn != null && conn.State != ConnectionState.Closed)\n conn.Close();\n }\n }\n\n return results;\n }","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-11T02:09:25+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_429013538","fragment_type":"issue_comment","sequence":1,"text":"The general meaning of this error is that the library is waiting for data from the server, but none has arrived (and I think the connection has been closed, otherwise a timeout would have occurred). \n\nI note that this seems to be coming from `CreateMinimumPooledSessions`; is there any improvement if you set `MinPoolSize=0` in your connection string?\n\nFinally, these code style issues are unlikely to be contributing to the problem, but you have unnecessary patterns in your code. The `try`/`catch { throw; }`/`finally` code can all be deleted; `using (var conn = new MySqlConnection())` will correctly close (Dispose) the connection when control leaves the `using` block. You should also add a second `using` block around `using (var grid = await conn.QueryMultipleAsync())` because Dapper's GridReader is `IDisposable`.","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-11T16:01:45+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_429014011","fragment_type":"issue_comment","sequence":2,"text":"What is your connection string (with UserID/Password redacted)? What is your client OS, client OS version, server OS, DB Server (MySQL, MariaDB, Aurora, Google Cloud SQL, etc.) and version?","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-11T16:03:02+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_429142126","fragment_type":"issue_comment","sequence":3,"text":"Thank you for your feedback:\nThe connection string looks like: \n\"ConnectionString\": \"Server=hostname.domain.com;Port=1234;Uid=userName;Pwd=password;Database=SampleDataBaseName;Pooling=false;Connect Timeout=60;MinimumPoolSize=25;maximumpoolsize=100;\"","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-11T22:32:10+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_429158357","fragment_type":"issue_comment","sequence":4,"text":"we are running MySQL V 5.7.18 on CentOS, and the client is running on Windows server 2012 R2","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-11T23:47:23+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_429160177","fragment_type":"issue_comment","sequence":5,"text":"Do you have `Pooling=false;` _and_ `MinimumPoolSize=25;` in your connection string? Is there any improvement to your scenario if you set `MinimumPoolSize=0`?","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-11T23:58:24+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_429162027","fragment_type":"issue_comment","sequence":6,"text":"Actually, my bad, We see the issue when we set Pooling=true. this is to try to stop all the information_schema.parameters calls for stored procedures. Which is when we ran into the connection issue. I haven't tried MinPoolSize=0 yet","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-12T00:09:21+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_431965080","fragment_type":"issue_comment","sequence":7,"text":"After that failure, a new session was requested, one was not available so, it created one and did not try to do Create connection attributes this time, so things worked:\n==========\n\n2018-10-22 11:43:49.4006|||MySqlConnector.ConnectionPool|DEBUG| Pool1 waiting for an available session \n\n2018-10-22 11:43:49.4006|||MySqlConnector.ServerSession|DEBUG| Session1.2 created new session \n\n2018-10-22 11:43:49.4006|||MySqlConnector.ConnectionPool|INFO| Pool1 no pooled session available; created new Session1.2 \n\n2018-10-22 11:43:49.4006|||MySqlConnector.ServerSession|INFO| Session1.2 connecting to IpAddress ********** for HostName ********\n\n2018-10-22 11:43:49.4163|||MySqlConnector.ServerSession|DEBUG| Session1.2 connected to IpAddress ********* for HostName **********\n\n2018-10-22 11:43:49.4163|||MySqlConnector.ServerSession|DEBUG| Session1.2 server sent AuthPluginName=*********** \n\n2018-10-22 11:43:49.4319|||MySqlConnector.ServerSession|INFO| Session1.2 made connection; ServerVersion=5.7.18-enterprise-commercial-advanced-log; ConnectionId=*********; Compression=False; Attributes=True; DeprecateEof=True; Ssl=True \n\n2018-10-22 11:43:49.4319|||MySqlConnector.ServerSession|INFO| Session1.2 initializing TLS connection \n\n2018-10-22 11:43:49.4475|||MySqlConnector.ServerSession|INFO| Session1.2 connected TLS with Protocol Tls12 \n\n2018-10-22 11:43:49.4475|||MySqlConnector.ConnectionPool|DEBUG| Pool1 returning new Session1.2 to caller; LeasedSessionsCount=1 \n\n2018-10-22 11:43:49.5569|||MySqlConnector.TextCommandExecutor|DEBUG| Session1.2 ExecuteBehavior Asynchronous CommandText: SELECT COUNT(*)\n \nFROM information_schema.routines\n \nWHERE ROUTINE_SCHEMA = @schema AND ROUTINE_NAME = @component;\n \nSELECT ORDINAL_POSITION, PARAMETER_MODE, PARAMETER_NAME, DATA_TYPE, DTD_IDENTIFIER\n \nFROM information_schema.parameters\n \nWHERE SPECIFIC_SCHEMA = @schema AND SPECIFIC_NAME = @component\n \nORDER BY ORDINAL_POSITION \n\n2018-10-22 11:43:49.7288|||MySqlConnector.ServerSession|DEBUG| Session1.2 entering FinishQuerying; SessionState=Querying \n\n2018-10-22 11:43:49.7444|||MySqlConnector.TextCommandExecutor|DEBUG| Session1.2 ExecuteBehavior Asynchronous CommandText: CALL GetSomethingById(@inParam0) \n\n2018-10-22 11:43:49.8694|||MySqlConnector.ServerSession|DEBUG| Session1.2 entering FinishQuerying; SessionState=Querying \n\n2018-10-22 11:43:49.8694|||MySqlConnector.ServerSession|DEBUG| Session1.2 returning to Pool1 \n\n2018-10-22 11:43:49.8850|||MySqlConnector.ConnectionPool|DEBUG| Pool1 receiving Session1.2 back","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-22T20:09:53+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_431981590","fragment_type":"issue_comment","sequence":8,"text":"Do you have logging enabled on your MySQL Server? Particularly the error log, but the general log may also be helpful in tracking this down.\n\nIn the failed and successful sessions, the following information is logged (you've redacted it):\n\n2018-10-22 11:43:25.2756|||MySqlConnector.ServerSession|INFO| Session1.1 made connection; ServerVersion=5.7.18-enterprise-commercial-advanced-log; ConnectionId=111111111111111111111; Compression=False; Attributes=True; DeprecateEof=True; Ssl=True \n...\n2018-10-22 11:43:49.4319|||MySqlConnector.ServerSession|INFO| Session1.2 made connection; ServerVersion=5.7.18-enterprise-commercial-advanced-log; ConnectionId=*********; Compression=False; Attributes=True; DeprecateEof=True; Ssl=True \n\nGet the `ConnectionId` attribute logged by the client, and cross-reference it with the server log to see if there's something wrong. I'm guessing the server is simply closing the `Session1.1` connection, but I don't know why. Perhaps the server log will provide some clues.","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-22T20:54:03+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_431983896","fragment_type":"issue_comment","sequence":9,"text":"any guess as to why one session succeeds and one fails? It seem the issue is confined to this block of code:\n\n using (var handshakeResponsePayload = HandshakeResponse41Payload.Create(initialHandshake, cs, m_useCompression, m_supportsConnectionAttributes ? cs.ConnectionAttributes : null))\n await SendReplyAsync(handshakeResponsePayload, ioBehavior, cancellationToken).ConfigureAwait(false);\n payload = await ReceiveReplyAsync(ioBehavior, cancellationToken).ConfigureAwait(false);\n\n // if server doesn't support the authentication fast path, it will send a new challenge\n if (payload.HeaderByte == AuthenticationMethodSwitchRequestPayload.Signature)\n {\n payload = await SwitchAuthenticationAsync(cs, payload, ioBehavior, cancellationToken).ConfigureAwait(false);\n }\n\n OkPayload.Create(payload.AsSpan());\n\n if (m_useCompression)\n m_payloadHandler = new CompressedPayloadHandler(m_payloadHandler.ByteHandler);\n\n if (ShouldGetRealServerDetails())\n await GetRealServerDetailsAsync(ioBehavior, CancellationToken.None).ConfigureAwait(false);","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-22T20:59:49+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_431984322","fragment_type":"issue_comment","sequence":10,"text":"It seems like you cache the connectionAttributes? the first time around, so you no longer make that call the second time around. \n\n== >(m_supportsConnectionAttributes && cs.ConnectionAttributes == null)\n cs.ConnectionAttributes = CreateConnectionAttributes(cs.ApplicationName);","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-22T21:00:56+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_431984517","fragment_type":"issue_comment","sequence":11,"text":"I will have to check if we have MySql logging enabled. Most probably not.","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-22T21:01:32+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_431992140","fragment_type":"issue_comment","sequence":12,"text":"for perf reasons, server logs are not enabled. Any idea why the first session only fails?","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-22T21:22:30+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_432033346","fragment_type":"issue_comment","sequence":13,"text":"I'm not sure yet; I was hoping server logs would help tell us. 😀","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-22T23:59:30+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_432836654","fragment_type":"issue_comment","sequence":14,"text":"so it looks like the first session takes 15 seconds for the SSL negotiation. Hence the issue. Subsequent requests are lightning fast.","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-24T21:35:27+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_433479823","fragment_type":"issue_comment","sequence":15,"text":"I've been seeing this as well, and I have SSLMode=None and Pooling=true\n \nSystem.IO.EndOfStreamException: Expected to read 4 header bytes but only received 0.\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess\n at MySqlConnector.Protocol.Serialization.ProtocolUtility.DoReadPayloadAsync\n at MySqlConnector.Protocol.Serialization.StandardPayloadHandler.ReadPayloadAsync\n at MySqlConnector.Core.ServerSession.ReceiveReplyAsync\n at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess\n at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification\n at System.Threading.Tasks.ValueTask`1.get_Result\n at d__59.MoveNext","author_login":"alexthekid07","author_association":"NONE","created_at":"2018-10-26T17:14:41+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434159844","fragment_type":"issue_comment","sequence":16,"text":"@iamomie Would it be possible to get a packet capture (with Wireshark or similar) of both the failed and successful SSL sessions?","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-30T03:33:33+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434427838","fragment_type":"issue_comment","sequence":17,"text":"let me try to get one. are you thinking, there is an issue with MySqlConnector with some configurations causing the server to disconnect when pooling is turned on?","author_login":"iamomie","author_association":"NONE","created_at":"2018-10-30T18:58:26+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434564582","fragment_type":"issue_comment","sequence":18,"text":"I suspect that your server simply stops sending data, or closes the connection, but I would need a packet capture to confirm this.","author_login":"bgrainger","author_association":"MEMBER","created_at":"2018-10-31T05:20:12+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_437407245","fragment_type":"issue_comment","sequence":19,"text":"0 bytes read is the indication that server closed the TCP connection (in an ordinary fashion, with closesocket, and linger). This is how APIs handle received FIN. Sockets are closed by server in 2 main cases\n\n- KILL CONNECTION for this connection\n\n- One of the timeouts has expired. This usually will be either the inactivity timeout (_wait_timeout_ server variable) or the _write_timeout_ . _write_timeout_ happens when server sends a lot of result set rows quickly, but client is much slower processing rows, than server sends them. \nWhat happens is that TCP send buffer on the server side gets full, server gets stuck trying to write some data to socket. If server gets stuck for more than _write_timeout_ seconds, connection is closed.","author_login":"vaintroub","author_association":"CONTRIBUTOR","created_at":"2018-11-09T16:06:53+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_448791981","fragment_type":"issue_comment","sequence":20,"text":"This was a configuration issue on our side and is now resolved. Thank you for all your help.","author_login":"iamomie","author_association":"NONE","created_at":"2018-12-19T23:41:08+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_466211387","fragment_type":"issue_comment","sequence":21,"text":"@iamomie Any chance you can elaborate on what the issue was? We're facing the same issue right now with this configuration string: \n\nServer={dbServer};Port={dbPort};Database={dbName};Uid={dbUser};pwd={dbPassword};SslMode=none;default command timeout=10;Connection Timeout=3;MinimumPoolSize=20;maximumpoolsize=500","author_login":"robborden","author_association":"NONE","created_at":"2019-02-21T23:28:38+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_501860541","fragment_type":"issue_comment","sequence":22,"text":"@iamomie \nWe are also facing the same issue. Can you please let us know the fix ?","author_login":"roopakoneru","author_association":"NONE","created_at":"2019-06-13T20:10:34+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_554700434","fragment_type":"issue_comment","sequence":23,"text":"@iamomie Hi, We are also facing the same issue. Can you please let us know the fix ?","author_login":"liguobao","author_association":"NONE","created_at":"2019-11-17T03:37:32+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_554898327","fragment_type":"issue_comment","sequence":24,"text":"It was related to SSL. The very first attempt to connect would take 15 seconds to connect and time out. We just added a test to make sure the connection was good and if not retry. If you make sure SSL is configured correctly, the issue will go away altogether","author_login":"iamomie","author_association":"NONE","created_at":"2019-11-18T07:59:54+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_554915638","fragment_type":"issue_comment","sequence":25,"text":"@iamomie how to \"added a test to make sure the connection was good and if not retry\",\n\nOur configuration string like it:\nserver=127.0.0.1;port=3309;database=lemon_novel;uid=root;pwd=xxxx;Allow User Variables=True;Connection Timeout=30;SslMode=None;Charset=utf8mb4;","author_login":"liguobao","author_association":"NONE","created_at":"2019-11-18T08:51:33+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_555443664","fragment_type":"issue_comment","sequence":26,"text":"Put a try a catch. In the try block, attempt to get a connection from the pool, if it throws AND If the exception is of a type related to connection failure, go back and try to get a connection again. This way if you are hit with the issue, you don't fail completely. However, this is only a stop gap and a resiliency fix. You should continue to troubleshoot","author_login":"iamomie","author_association":"NONE","created_at":"2019-11-19T10:34:48+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_865458769","fragment_type":"issue_comment","sequence":27,"text":"occurs again\n\nmysql logs with\n\n2021-06-22T09:45:55.540725+08:00 20334629 [Note] Got an error reading communication packets\n2021-06-22T09:46:05.542053+08:00 20334636 [Note] Got an error reading communication packets\n2021-06-22T09:46:15.543313+08:00 20334745 [Note] Got an error reading communication packets\n2021-06-22T09:46:25.036277+08:00 20334717 [Note] Got timeout reading communication packets\n2021-06-22T09:46:25.037289+08:00 20334719 [Note] Got timeout reading communication packets\n2021-06-22T09:46:25.047396+08:00 20334741 [Note] Got timeout reading communication packets\n2021-06-22T09:46:25.047399+08:00 20334714 [Note] Got timeout reading communication packets\n2021-06-22T09:46:25.544400+08:00 20334756 [Note] Got an error reading communication packets\n2021-06-22T09:46:31.872522+08:00 20334738 [Note] Bad handshake\n2021-06-22T09:46:31.895078+08:00 20334762 [Note] Got an error reading communication packets\n2021-06-22T09:46:31.895110+08:00 20334761 [Note] Got an error reading communication packets\n2021-06-22T09:46:31.954108+08:00 20334736 [Note] Bad handshake\n2021-06-22T09:46:31.954620+08:00 20334727 [Note] Bad handshake\n2021-06-22T09:46:31.954912+08:00 20334740 [Note] Bad handshake\n2021-06-22T09:46:31.955325+08:00 20334734 [Note] Bad handshake\n2021-06-22T09:46:31.955985+08:00 20334737 [Note] Bad handshake\n2021-06-22T09:46:31.956544+08:00 20334721 [Note] Bad handshake\n2021-06-22T09:46:31.957220+08:00 20334722 [Note] Bad handshake\n2021-06-22T09:46:31.957663+08:00 20334739 [Note] Bad handshake\n2021-06-22T09:46:31.958200+08:00 20334726 [Note] Got an error reading communication packets\n2021-06-22T09:46:31.958597+08:00 20334720 [Note] Bad handshake\n2021-06-22T09:46:31.959103+08:00 20334730 [Note] Got an error reading communication packets\n2021-06-22T09:46:31.959435+08:00 20334744 [Note] Bad handshake\n2021-06-22T09:46:31.959817+08:00 20334723 [Note] Bad handshake\n2021-06-22T09:46:31.960346+08:00 20334724 [Note] Bad handshake\n2021-06-22T09:46:31.960754+08:00 20334731 [Note] Bad handshake\n2021-06-22T09:46:31.961178+08:00 20334743 [Note] Bad handshake\n2021-06-22T09:46:31.961742+08:00 20334729 [Note] Bad handshake\n2021-06-22T09:46:31.962358+08:00 20334732 [Note] Bad handshake\n2021-06-22T09:46:31.962691+08:00 20334725 [Note] Bad handshake\n2021-06-22T09:46:31.963022+08:00 20334728 [Note] Bad handshake\n2021-06-22T09:46:31.963393+08:00 20334742 [Note] Bad handshake\n2021-06-22T09:46:31.963862+08:00 20334735 [Note] Bad handshake\n2021-06-22T09:46:31.964187+08:00 20334718 [Note] Got an error reading communication packets\n2021-06-22T09:46:31.965984+08:00 20334733 [Note] Bad handshake\n2021-06-22T09:46:35.545970+08:00 20334765 [Note] Got an error reading communication packets\n2021-06-22T09:46:45.547540+08:00 20334781 [Note] Got an error reading communication packets\n2021-06-22T09:46:55.548971+08:00 20334789 [Note] Got an error reading communication packets\n2021-06-22T09:47:05.550948+08:00 20334796 [Note] Got an error reading communication packets\n2021-06-22T09:47:15.551971+08:00 20334803 [Note] Got an error reading communication packets\n2021-06-22T09:47:25.553656+08:00 20334814 [Note] Got an error reading communication packets\n2021-06-22T09:47:35.555200+08:00 20334820 [Note] Got an error reading communication packets\n2021-06-22T09:47:45.556536+08:00 20334827 [Note] Got an error reading communication packets","author_login":"naughtyGitCat","author_association":"NONE","created_at":"2021-06-22T01:48:45+08:00","repo_name":"mysql-net/MySqlConnector","issue_id":368923078,"issue_number":571,"issue_url":"https://github.com/mysql-net/MySqlConnector/issues/571","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0389","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"build: 16 KB native library alignment on Android?","query_context":"**Description**\n\nThe Google Play console gives the following warning on `flutter_soloud` native artefacts:\n\n* Recompile your app with 16 KB native library alignment\n\nI'm not exactly sure what's needed to be changed. Here is the Android reference on this:\n URL \n\nLibraries that do not support 16 KB:\n\nbase/lib/arm64-v8a/libflutter_soloud_plugin.so\nbase/lib/arm64-v8a/libogg.so\nbase/lib/arm64-v8a/libopus.so\nbase/lib/x86_64/libflutter_soloud_plugin.so\nbase/lib/x86_64/libogg.so\nbase/lib/x86_64/libopus.so\n\n**Requirements**\n\n- [ ] The build system is passing","known_context_document_ids":["gh_issue_3080513619"],"reference_answer":"On Android gradle decides, with the building tasks, what needs to be built. If you change some native sources or the CMakeLists, the native build is for sure triggered, but if you change an environment variable, nothing is changed for gradle and nothing is rebuilt.\n\nTo trigger the rebuild when an environment variable is changed, I have added this task which triggers the `externalNativeBuild` with a cmake argument. If this argument changes, the rebuild is performed.\n\nThis is what I understood looking around, but maybe I am wrong. Anyway it works :)\n\nI tried this solution in the app gradle without success, I think because the app does not need to build native code.","answer_document_id":"gh_comment_2710272126","silver_evidence_path":["gh_comment_2962548761","gh_issue_2904915070","gh_comment_2710272126"],"evidence_issue_ids":[3080513619,2904915070],"source_repo_name":"alnitak/flutter_soloud","source_issue_id":3080513619,"source_issue_number":248,"source_issue_url":"https://github.com/alnitak/flutter_soloud/issues/248","target_repo_name":"alnitak/flutter_soloud","target_issue_id":2904915070,"target_issue_number":198,"target_issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","reference_anchor_document_id":"gh_comment_2962548761","reference_answer_author":"alnitak","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3529,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1087},"issue_created_at":"2025-05-21T14:52:59+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_3080513619","fragment_type":"issue_description","sequence":0,"text":"build: 16 KB native library alignment on Android\n**Description**\n\nThe Google Play console gives the following warning on `flutter_soloud` native artefacts:\n\n* Recompile your app with 16 KB native library alignment\n\nI'm not exactly sure what's needed to be changed. Here is the Android reference on this:\n URL \n\nLibraries that do not support 16 KB:\n\nbase/lib/arm64-v8a/libflutter_soloud_plugin.so\nbase/lib/arm64-v8a/libogg.so\nbase/lib/arm64-v8a/libopus.so\nbase/lib/x86_64/libflutter_soloud_plugin.so\nbase/lib/x86_64/libogg.so\nbase/lib/x86_64/libopus.so\n\n**Requirements**\n\n- [ ] The build system is passing","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-05-21T14:52:59+08:00","repo_name":"alnitak/flutter_soloud","issue_id":3080513619,"issue_number":248,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/248","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2962548761","fragment_type":"issue_comment","sequence":1,"text":"@alnitak not really... Ironically I also not using the \"ogg\" libs and they are the re due to #198\n\nThe GitHub copilot agent says this and makes the patch below\n\n----\nThe warning from the Google Play Console means your native libraries (`.so` files) must be aligned to 16 KB (16384 bytes) boundaries, which is now required for Android apps targeting recent API levels. This is a new requirement for native libraries in APKs and AABs.\n\nTo fix this, you need to ensure that your build system (CMake, Gradle, or other) aligns the `.so` files to 16 KB. The recommended way is to use the `zipalign` tool after building your APK/AAB, but for libraries inside the APK, you should ensure the `.so` files themselves are aligned before packaging.\n\nFor CMake, you can set the alignment using linker flags. For Android, you should add the following to your linker flags:\n\n-Wl,--section-start,.text=0x4000\n\nBut the best and most future-proof way is to use the `--page-size` linker flag if your linker supports it:\n\n-Wl,--page-size=0x4000\n\nYour CMakeLists.txt already attempts to set the linker option for 16 KB page size with:\n\ncmake\ntarget_compile_options(\"${PLUGIN_NAME}\" PRIVATE -z max-page-size=16384 ...)\n\nHowever, the correct way to set this for the linker is with `target_link_options` (not `target_compile_options`), and the syntax should be:\n\ncmake\ntarget_link_options(${PLUGIN_NAME} PRIVATE \"-Wl,-z,max-page-size=16384\")\n\nThis ensures the linker aligns the native library as required by Google Play.\n\nI'll update your CMakeLists.txt to use `target_link_options` for the 16 KB alignment.","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-06-11T12:45:00+08:00","repo_name":"alnitak/flutter_soloud","issue_id":3080513619,"issue_number":248,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/248","linked_issue_ids":[2904915070],"is_known_query_context":false},{"document_id":"gh_comment_2963159991","fragment_type":"issue_comment","sequence":2,"text":"Have you tried to remove `max-page-size=16384`? Maybe the correct flags are taken from the app's main CMakeLists.txt. I don't remember why I added that option!","author_login":"alnitak","author_association":"OWNER","created_at":"2025-06-11T14:55:01+08:00","repo_name":"alnitak/flutter_soloud","issue_id":3080513619,"issue_number":248,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/248","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3146747237","fragment_type":"issue_comment","sequence":3,"text":"copilot is right, it should be set as a linker option, not compiler option\n\nafterwards, you can check the binary with `objdump -p your.so`. LOAD section should be aligned by `2**14`","author_login":"mx1up","author_association":"NONE","created_at":"2025-08-02T21:52:09+08:00","repo_name":"alnitak/flutter_soloud","issue_id":3080513619,"issue_number":248,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/248","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3148286926","fragment_type":"issue_comment","sequence":4,"text":"I fixed this on version 3.2.3 with the @ekuleshov solution. I don't have an app to try publishing it, but I checked the `.so` library as suggested by @mx1up, and instead of an align of `2**12`, I see now `2**14`.\n\nI'll close this as completed, but feel free to reopen.","author_login":"alnitak","author_association":"OWNER","created_at":"2025-08-03T09:21:22+08:00","repo_name":"alnitak/flutter_soloud","issue_id":3080513619,"issue_number":248,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/248","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2904915070","fragment_type":"issue_description","sequence":0,"text":"feat: allow to specify NO_OPUS_OGG_LIBS exclusion in Android build files\n**Description**\n\nThe current instructions require to specify ENV variable NO_OPUS_OGG_LIBS to exclude Opus and Ogg libraries. It would be really handy to be able to have it somehow defined in the Android build files.\n\n**Requirements**\n\n- [ ] Allow to specify exclusion for Opus and Ogg libraries in the Android target build files (i.e. Gradle scripts)\n\n**Additional Context**\n\nAs an alternative maybe you could publish a separate artifact to pub.dev like `flutter_soloud_no_ogg` or a version like `3.0.3-no-ogg`. The ffmpeg_kit_flutter plugin used this approach to distribute various platform binaries.","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-03-08T17:15:38+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708408309","fragment_type":"issue_comment","sequence":1,"text":"Hi @ekuleshov,\n\nI didn't try, but I think you can add something like this in the `app/build.gradle`:\n\n externalNativeBuild {\n cmake {\n environment \"NO_OPUS_OGG_LIBS\", \"1\"\n }\n }\n\nor maybe also add this line in the `settings.gradle`:\n\nNO_OPUS_OGG_LIBS=1\n\nI can't try now, but please let me know if one of those works, so I can update the doc!","author_login":"alnitak","author_association":"OWNER","created_at":"2025-03-08T17:32:42+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708431849","fragment_type":"issue_comment","sequence":2,"text":"@alnitak it needs to be `android / defaultConfig / externalNativeBuild / cmake`...\n\nBut unfortunately the `cmake` Gradle task doesn't have `environment` option.\n\n URL \n\nThere are `arguments`, `cFlags` and `cppFalgs`. E.g. example from the docs below.\n\nI tried to add `arguments \"-DNO_OPUS_OGG_LIBS=1\"` but the ogg libs are still bundled when running `flutter build appbundle` command, because `flutter_soloud/android/CMakeLists.txt` is always looking for the ENV variable.\n\nUsing argument like `-DNO_OPUS_OGG_LIBS` also fail with a cmake command line syntax error, because it expects `name=value`.\n\nSo, it is likely necessary to change the Android's `CMakeLists.txt` to also look at the arguments like below. Then the following Gradle change seem to work:\n\nandroid {\n ...\n defaultConfig {\n ...\n externalNativeBuild {\n cmake {\n arguments \"-DNO_OPUS_OGG_LIBS=1\"\n }\n }\n }\n ...","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-03-08T18:25:52+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708462677","fragment_type":"issue_comment","sequence":3,"text":"When you added `AND NOT DEFINED NO_OPUS_OGG_LIBS` the plugin rebuild has been triggered by the change made on CMakeLists. If you then try to remove the lines from build.gradle and try to run again, the change has no effects and the plugin is not rebuilt (the libs are not linked).\n\nI am trying to figure out the gradle tasks to see if there is something that can help.","author_login":"alnitak","author_association":"OWNER","created_at":"2025-03-08T19:40:10+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708474970","fragment_type":"issue_comment","sequence":4,"text":"@alnitak my thought was to pass a cmake command line argument that would be used in that condition.\n\nI wasn't been able to find a way to set ENV variable for that cmake build. Also tried this with no success:\n\ntasks.withType(Exec) {\n environment \"NO_OPUS_OGG_LIBS\", \"1\"\n}","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-03-08T20:22:03+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708482152","fragment_type":"issue_comment","sequence":5,"text":"yes, I tried that also and some other things but still nothing. I am still trying, but just out of curiosity, why not use the IDE trick to set the variable or use the command line to run the app (or a GitHub action for building):\n\nexport NO_OPUS_OGG_LIBS=\"1\" && flutter run\n\nThis thing we are doing could be handy anyway, but it's driving me crazy 😃","author_login":"alnitak","author_association":"OWNER","created_at":"2025-03-08T20:47:56+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708925125","fragment_type":"issue_comment","sequence":6,"text":"Just trying to make build self-contained and having general command `flutter build appbundle` do the right thing without additional parameters that has to be remembered or set somewhere.\n\nI'm still somewhat puzzled why condition like `(NOT DEFINED ENV{NO_OPUS_OGG_LIBS} AND NOT DEFINED NO_OPUS_OGG_LIBS)` won't work.","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-03-09T15:47:50+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2710272126","fragment_type":"issue_comment","sequence":7,"text":"On Android gradle decides, with the building tasks, what needs to be built. If you change some native sources or the CMakeLists, the native build is for sure triggered, but if you change an environment variable, nothing is changed for gradle and nothing is rebuilt.\n\nTo trigger the rebuild when an environment variable is changed, I have added this task which triggers the `externalNativeBuild` with a cmake argument. If this argument changes, the rebuild is performed.\n\nThis is what I understood looking around, but maybe I am wrong. Anyway it works :)\n\nI tried this solution in the app gradle without success, I think because the app does not need to build native code.","author_login":"alnitak","author_association":"OWNER","created_at":"2025-03-10T11:29:40+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2710706755","fragment_type":"issue_comment","sequence":8,"text":"@alnitak I don't think it is a concern. It rebuilds when Gradle scripts or CMakeLists are edited. I also used `flutter clean` to get a fresh full rebuild. It probably isn't something that will be changed back and forth.","author_login":"ekuleshov","author_association":"NONE","created_at":"2025-03-10T14:00:11+08:00","repo_name":"alnitak/flutter_soloud","issue_id":2904915070,"issue_number":198,"issue_url":"https://github.com/alnitak/flutter_soloud/issues/198","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0390","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Determine BIDS-friendly naming scheme for Webknossos datasets with multiple imaging layers?","query_context":"## Description\n\nWe are working towards naming all assets on the LINC Data Platform according to the BIDS specification. Webknossos datasets will consist of several assets from the LINC Data Platform as imaging/color layers. Let's aim to name these Webknossos datasets according to the BIDS specification (or as close as possible).\n\n## Goals\n\n1. Determine a standard way to name these Webknossos datasets with multiple imaging layers.\n2. Document this naming scheme on the LINC docs.\n\nThank you.","known_context_document_ids":["gh_issue_2558067132"],"reference_answer":"After discussion with the team, we decided that these annotations will be performed on a single layer, so I updated the initial comment.","answer_document_id":"gh_comment_2445041699","silver_evidence_path":["gh_comment_2445097707","gh_issue_2558107784","gh_comment_2445041699"],"evidence_issue_ids":[2558067132,2558107784],"source_repo_name":"lincbrain/webknossos","source_issue_id":2558067132,"source_issue_number":19,"source_issue_url":"https://github.com/lincbrain/webknossos/issues/19","target_repo_name":"lincbrain/webknossos","target_issue_id":2558107784,"target_issue_number":20,"target_issue_url":"https://github.com/lincbrain/webknossos/issues/20","reference_anchor_document_id":"gh_comment_2445097707","reference_answer_author":"kabilar","reference_answer_author_association":"MEMBER","quality_score":82.55,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.25,"target_answer_overlap":0.0909},"issue_created_at":"2024-10-01T03:05:38+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2558067132","fragment_type":"issue_description","sequence":0,"text":"Determine BIDS-friendly naming scheme for Webknossos datasets with multiple imaging layers\n## Description\n\nWe are working towards naming all assets on the LINC Data Platform according to the BIDS specification. Webknossos datasets will consist of several assets from the LINC Data Platform as imaging/color layers. Let's aim to name these Webknossos datasets according to the BIDS specification (or as close as possible).\n\n## Goals\n\n1. Determine a standard way to name these Webknossos datasets with multiple imaging layers.\n2. Document this naming scheme on the LINC docs.\n\nThank you.","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-01T03:05:38+08:00","repo_name":"lincbrain/webknossos","issue_id":2558067132,"issue_number":19,"issue_url":"https://github.com/lincbrain/webknossos/issues/19","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2392046266","fragment_type":"issue_comment","sequence":1,"text":"Thanks @jingjingwu1225. Sounds great. Will we be creating Webknossos datasets that are comprised of a histology image plus the previous generated annotations from Vaanathi's work that are now in the Zarr format?","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-03T18:22:02+08:00","repo_name":"lincbrain/webknossos","issue_id":2558067132,"issue_number":19,"issue_url":"https://github.com/lincbrain/webknossos/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2392240792","fragment_type":"issue_comment","sequence":2,"text":"Hi @kabilar, thanks for the reminder. Yes, after we got the updated groundtruth annotations from Vaanathi's work I'll upload them to lincbrain and add both datasets itself and masks to webknossos in one dataset, and delete the current one. The annotations will be saved separately with the dataset but added as layers in webknossos.","author_login":"jingjingwu1225","author_association":"NONE","created_at":"2024-10-03T20:08:40+08:00","repo_name":"lincbrain/webknossos","issue_id":2558067132,"issue_number":19,"issue_url":"https://github.com/lincbrain/webknossos/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2412634666","fragment_type":"issue_comment","sequence":3,"text":"Thanks @jingjingwu1225. How would you name these Webknossos datasets with multiple layers? I presume that this would be a case where this is not a 1-1 mapping between the naming on lincbrain.org and on Webknossos.","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-15T01:29:33+08:00","repo_name":"lincbrain/webknossos","issue_id":2558067132,"issue_number":19,"issue_url":"https://github.com/lincbrain/webknossos/issues/19","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2445097707","fragment_type":"issue_comment","sequence":4,"text":"@jingjingwu1225 @jssyq @elissabell Thanks for the discussion last week. We decided that Webknossos datasets with multiple layers are currently needed in order to visualize the previously generated annotations. So these Webknossos datasets will be named as described in #20 with Vaanathi Sundaresan's initials.","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-29T18:59:35+08:00","repo_name":"lincbrain/webknossos","issue_id":2558067132,"issue_number":19,"issue_url":"https://github.com/lincbrain/webknossos/issues/19","linked_issue_ids":[2558107784],"is_known_query_context":false},{"document_id":"gh_issue_2558107784","fragment_type":"issue_description","sequence":0,"text":"Determine BIDS-friendly naming scheme for Webknossos annotations\n## Description\n\nWe are working towards naming all assets on the LINC Data Platform according to the BIDS specification. As Webknossos annotations will be uploaded to the LINC Data Platform, let's aim to name these annotation files according to the BIDS specification (or as close as possible). We can reference the BIDS specification for discrete segmentations. ~This task is a bit complicated as Webknossos datasets will consist of several assets from the LINC Data Platform as imaging/color layers, so this issue depends on #19.~\n\n## Goals\n\n1. Determine a standard way to name these Webknossos annotations ~that are based on Webknossos datasets with multiple imaging layers~.\n2. Document this naming scheme on the LINC docs.\n\nThank you.","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-01T03:48:39+08:00","repo_name":"lincbrain/webknossos","issue_id":2558107784,"issue_number":20,"issue_url":"https://github.com/lincbrain/webknossos/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2391581897","fragment_type":"issue_comment","sequence":1,"text":"Hi Kabi, the LINC documentation site can't be opened @kabilar","author_login":"jssyq","author_association":"NONE","created_at":"2024-10-03T14:33:23+08:00","repo_name":"lincbrain/webknossos","issue_id":2558107784,"issue_number":20,"issue_url":"https://github.com/lincbrain/webknossos/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2392246551","fragment_type":"issue_comment","sequence":2,"text":"Hi @kabilar, after discussion, we agreed on adding initials of annotator after label desc and a suffix of _dseg to represent it's discrete segmentations. For a dataset with name of sub-MR243_sample-slice0000slice0004_stain-LY_DF on webknossos, its corresponding annotations will have name of sub-MR243_sample-slice0000slice0004_stain-LY_DF_desc-JW_dseg. We're working on adding the naming scheme on LINC docs. Thanks!","author_login":"jingjingwu1225","author_association":"NONE","created_at":"2024-10-03T20:11:51+08:00","repo_name":"lincbrain/webknossos","issue_id":2558107784,"issue_number":20,"issue_url":"https://github.com/lincbrain/webknossos/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2415196231","fragment_type":"issue_comment","sequence":3,"text":"Thank you, @jingjingwu1225 @jssyq. I have left some suggestions in URL","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-15T21:25:53+08:00","repo_name":"lincbrain/webknossos","issue_id":2558107784,"issue_number":20,"issue_url":"https://github.com/lincbrain/webknossos/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2445039409","fragment_type":"issue_comment","sequence":4,"text":"Crossposting the discussion with the BIDS team on using the `desc` entity: URL","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-29T18:28:10+08:00","repo_name":"lincbrain/webknossos","issue_id":2558107784,"issue_number":20,"issue_url":"https://github.com/lincbrain/webknossos/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2445041699","fragment_type":"issue_comment","sequence":5,"text":"After discussion with the team, we decided that these annotations will be performed on a single layer, so I updated the initial comment.","author_login":"kabilar","author_association":"MEMBER","created_at":"2024-10-29T18:29:25+08:00","repo_name":"lincbrain/webknossos","issue_id":2558107784,"issue_number":20,"issue_url":"https://github.com/lincbrain/webknossos/issues/20","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0391","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Translator Mode: The original subtitle cannot be recovered in a file?","query_context":"When working in translator mode, SE opens both translated subtitle and the original subtitle with the File/Reopen command which displays a list of files. Among them, it shows translated.srt + original.srt as a single item file. SE works ok.\nBut, I cannot get the original.srt file as I see it in the translator mode Window. This has happened, probably, after my using the File/Save original subtitle command.\nThe original subtitle file looks like a file generated by the File/Restore auto-backup command with twice more lines including many empty ones.\n\nSpas Velev\nEnemy at the Gates 2001 2160p.copy.txt","known_context_document_ids":["gh_issue_1669418078"],"reference_answer":"Ctrl+C copies the translation row(s) to clipboard in SRT format:\n\nE.g. like:\n\n3\n00:00:06,222 --> 00:00:07,835\nLine3\n\nFor this to work, that would require SE to include the original text... like:\n\n3\n00:00:06,222 --> 00:00:07,835\nLine3 O3\n\nWhere ` ` is some separator symbol... \n\nAny comments? @darnn @LeonCheung","answer_document_id":"gh_comment_1368386217","silver_evidence_path":["gh_comment_1510148582","gh_issue_1077655392","gh_comment_1368386217"],"evidence_issue_ids":[1669418078,1077655392],"source_repo_name":"SubtitleEdit/subtitleedit","source_issue_id":1669418078,"source_issue_number":6833,"source_issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","target_repo_name":"SubtitleEdit/subtitleedit","target_issue_id":1077655392,"target_issue_number":5597,"target_issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/5597","reference_anchor_document_id":"gh_comment_1510148582","reference_answer_author":"niksedk","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2449,"anchor_target_overlap":0.2195,"target_answer_overlap":0.1818},"issue_created_at":"2023-04-15T14:04:42+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1669418078","fragment_type":"issue_description","sequence":0,"text":"Translator Mode: The original subtitle cannot be recovered in a file\nWhen working in translator mode, SE opens both translated subtitle and the original subtitle with the File/Reopen command which displays a list of files. Among them, it shows translated.srt + original.srt as a single item file. SE works ok.\nBut, I cannot get the original.srt file as I see it in the translator mode Window. This has happened, probably, after my using the File/Save original subtitle command.\nThe original subtitle file looks like a file generated by the File/Restore auto-backup command with twice more lines including many empty ones.\n\nSpas Velev\nEnemy at the Gates 2001 2160p.copy.txt","author_login":"SpasV","author_association":"NONE","created_at":"2023-04-15T14:04:42+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1510148582","fragment_type":"issue_comment","sequence":1,"text":"You probably had a desync and didn't realize it. That is, the number of subtitles in the original file and in the translated file changed, but in the Subtitle Edit window, they still seemed the same. However, when you closed and opened them again, they opened in their desynchronized form. The main thing I know that can cause a desync right now is using copy+paste on entire subtitles (see here URL \nThere is an indicator of whether or not this has happened. This is a screenshot of the window before it happens:\nse-split-01\nAnd this is a screenshot after:\nse-split-02\n\nNote that \"OK\" on the left has changed into \"count does not match\".\nAt this point I'd go back to the earliest backups in AutoBackup that were still synched, and apply any changes I made since then myself before opening the files in translator mode again.\n\nOh, also, this sometimes happens when you use the undo function. SE will, for whatever reason, instead of undoing the latest change, will undo many, many of them at once, including any merging or splitting of lines, but only in the translation, not in the source, which will also create a desync. This is harder to pin down, though, and only happens every once in a while, so I couldn't tell you how to avoid it. Just keep an eye on that indicator after you use undo.","author_login":"darnn","author_association":"NONE","created_at":"2023-04-16T07:45:54+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[1077655392],"is_known_query_context":false},{"document_id":"gh_comment_1510313156","fragment_type":"issue_comment","sequence":2,"text":"Thanks, sure I'll avoid these situations.\nBut, the question remains: why SE doesn't \"Save original subtitle\" the same way as they are shown in the Translator Mode Window? It has them properly synced.","author_login":"SpasV","author_association":"NONE","created_at":"2023-04-16T11:36:20+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1510460944","fragment_type":"issue_comment","sequence":3,"text":"@SpasV: Can you describe steps for me to re-create this? (screenshots are nice)","author_login":"niksedk","author_association":"MEMBER","created_at":"2023-04-16T19:06:02+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1515287581","fragment_type":"issue_comment","sequence":4,"text":"Sorry, I'm late.\nI'll post examples tomorrow. For now, I'll briefly describe the main.\n**Translator Mode**.\nI've seen two cases when desync happened. The common reason is saving the Original subtitles.\n1. I don't know the reason for the event to happen. But, after some **text** corrections have been made in the Translated subtitles SE prompts for saving the original subtitles.\n2. The second is obvious. After **timing** corrections have been made the Original subtitles need to be saved also.\n\nAfter saving the Original subtitles every file copy opened is **desynced**.\nThe Original subtitles **are** synced when both Translated and Original are **Reopen**ed as T.srt+O.srt.","author_login":"SpasV","author_association":"NONE","created_at":"2023-04-19T19:47:28+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1516084780","fragment_type":"issue_comment","sequence":5,"text":"Sorry, I couldn't get desync example having tried two timing corrections using the \"**Split line at the cursor position**\" command.\nI'll try later on again.","author_login":"SpasV","author_association":"NONE","created_at":"2023-04-20T10:22:09+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1516087653","fragment_type":"issue_comment","sequence":6,"text":"This seems to have been fixed, at least from the few times I've tried, at some point in the past few months (I believe). If you're using the latest beta, split at cursor position shouldn't cause a desync.","author_login":"darnn","author_association":"NONE","created_at":"2023-04-20T10:24:42+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1669418078,"issue_number":6833,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/6833","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1077655392","fragment_type":"issue_description","sequence":0,"text":"Copy-paste in translator mode causes desync\n3.6.4 NEXT beta 68.\nIn translator mode, select any subtitle in list view. Press ctrl+c and then ctrl+v. Desync between the original and the translation occurs.\nBefore:\nse-desync-01\n\nAfter:\nse-desync-02","author_login":"darnn","author_association":"NONE","created_at":"2021-12-11T21:32:30+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1077655392,"issue_number":5597,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/5597","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1289391581","fragment_type":"issue_comment","sequence":1,"text":"@niksedk Any chance you could look at this at some point? It's still happening as of 3.6.8. It makes it really hard to edit source and translation subtitles together. For instance, if I need to add 150 empty lines, instead of just pasting them in the translation and having the source match, I need to add them manually one by one.\nIdeally there would be a copy source+translation (and paste source+translation) mode, but I'd settle for just being able to paste into one and having the other match it instead of desyncing.","author_login":"darnn","author_association":"NONE","created_at":"2022-10-24T17:58:42+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1077655392,"issue_number":5597,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/5597","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368386217","fragment_type":"issue_comment","sequence":2,"text":"Ctrl+C copies the translation row(s) to clipboard in SRT format:\n\nE.g. like:\n\n3\n00:00:06,222 --> 00:00:07,835\nLine3\n\nFor this to work, that would require SE to include the original text... like:\n\n3\n00:00:06,222 --> 00:00:07,835\nLine3 O3\n\nWhere ` ` is some separator symbol... \n\nAny comments? @darnn @LeonCheung","author_login":"niksedk","author_association":"MEMBER","created_at":"2023-01-01T08:30:16+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1077655392,"issue_number":5597,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/5597","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368388564","fragment_type":"issue_comment","sequence":3,"text":"It does. With beta 3.6.10 NEXT beta 184, I copied the second line:\nse3 6 10-184-copypaste01\n\nAnd then pasted:\nse3 6 10-184-copypaste02\n\nPart of the issue might be that when it pastes, it tries to modify the timecode so that it doesn't overlap with the timecode of the copied subtitle. But I don't think this should happen anyway, I think the timecode should remain the same.\n\nAs for the separator symbol, I don't think I understand what you mean. Ideally, in translator mode, when you paste a subtitle (or several subtitles), they should be pasted into the translation file normally, and the original file should just be updated with corresponding subtitles with no text in them, to avoid a desync.\n\nOf course, it would be even nicer if we could copy the original and the translation at once, but I assume this would take more work, and it's not as essential for me. I can always do that myself with a few more steps, using \"switch original and translation\".","author_login":"darnn","author_association":"NONE","created_at":"2023-01-01T08:50:09+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1077655392,"issue_number":5597,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/5597","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1368390031","fragment_type":"issue_comment","sequence":4,"text":"Hmm, I'm not a programmer but I guess it could be like a little batch operation? I mean, by hitting Ctrl C once, SE will do the same thing for both the original and translation side. Same as Ctrl V.","author_login":"LeonCheung","author_association":"CONTRIBUTOR","created_at":"2023-01-01T09:01:20+08:00","repo_name":"SubtitleEdit/subtitleedit","issue_id":1077655392,"issue_number":5597,"issue_url":"https://github.com/SubtitleEdit/subtitleedit/issues/5597","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0392","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"FSL recipe generation never completes?","query_context":"tried to run the following and nothing ever happens\n\nthe command never terminates\n\nbash\ndocker run --rm -it kaczmarj/neurodocker:0.9.1 \\\n generate docker \\\n --base-image bids/base_validator \\\n --pkg-manager apt \\\n --fsl method=binaries version=6.0.3 > Dockerfile","known_context_document_ids":["gh_issue_1517687469"],"reference_answer":"@mateuszpawlik - i'm glad it's working now.\n\none note on the line `RUN . ${FSLDIR}/etc/fslconf/fsl.sh`. the sourced variables will not persist to future instructions. each `RUN` instruction starts up its own shell and then tears down that shell when it's finished.\n\nyou could get around this in two ways: either source the `fsl.sh` file when you start the container, or hardcode the environment variables in `fsl.sh` with `ENV` instructions.","answer_document_id":"gh_comment_1128915388","silver_evidence_path":["gh_comment_1370202531","gh_issue_1232935588","gh_comment_1128915388"],"evidence_issue_ids":[1517687469,1232935588],"source_repo_name":"ReproNim/neurodocker","source_issue_id":1517687469,"source_issue_number":485,"source_issue_url":"https://github.com/ReproNim/neurodocker/issues/485","target_repo_name":"ReproNim/neurodocker","target_issue_id":1232935588,"target_issue_number":450,"target_issue_url":"https://github.com/ReproNim/neurodocker/issues/450","reference_anchor_document_id":"gh_comment_1370202531","reference_answer_author":"kaczmarj","reference_answer_author_association":"COLLABORATOR","quality_score":82.96,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.037,"anchor_target_overlap":0.1724,"target_answer_overlap":0.2571},"issue_created_at":"2023-01-03T17:12:43+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1517687469","fragment_type":"issue_description","sequence":0,"text":"FSL recipe generation never completes\ntried to run the following and nothing ever happens\n\nthe command never terminates\n\nbash\ndocker run --rm -it kaczmarj/neurodocker:0.9.1 \\\n generate docker \\\n --base-image bids/base_validator \\\n --pkg-manager apt \\\n --fsl method=binaries version=6.0.3 > Dockerfile","author_login":"Remi-Gau","author_association":"NONE","created_at":"2023-01-03T17:12:43+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1370035486","fragment_type":"issue_comment","sequence":1,"text":"Using older version of neurodocker lead to build that end up with never completing either.\n\n URL","author_login":"Remi-Gau","author_association":"NONE","created_at":"2023-01-03T17:24:52+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370051883","fragment_type":"issue_comment","sequence":2,"text":"this is running into a prompt that requests acknowledgment for noncommercial use. if you type `y` it should complete. however, this is a bug. \n\n- the prompt doesn't show up even when `-it` is specified in docker.\n- fsl should have an option to accept the license to disable the interactive prompt.","author_login":"satra","author_association":"CONTRIBUTOR","created_at":"2023-01-03T17:42:30+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370131022","fragment_type":"issue_comment","sequence":3,"text":"Thanks for the the tip.\n\nManaged to create a Dockerfile with the latest version but it fails to build:\n\n URL \n\n URL \n\nFYI: the base image for this is is the following on that is based on the latest ubuntu.\n\n URL","author_login":"Remi-Gau","author_association":"NONE","created_at":"2023-01-03T19:11:38+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1370202531","fragment_type":"issue_comment","sequence":4,"text":"i'm pretty sure this has something to do with the fsl conda installation. there is a separate thread on this #450 . it may be worthwhile for fsl to move to mamba instead of conda. i don't know why the install times are that crazy. the only thing i can think of is time to resolve conflicts. an alternative would be to hack the fsl python install script and try.","author_login":"satra","author_association":"CONTRIBUTOR","created_at":"2023-01-03T20:38:27+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[1232935588],"is_known_query_context":false},{"document_id":"gh_comment_1370444087","fragment_type":"issue_comment","sequence":5,"text":"it could be a function of the base image, but i could not get it to build even manually. the fsl python installation fails for this version. any chance of switching to a debian base image, which may be more stable [old].","author_login":"satra","author_association":"CONTRIBUTOR","created_at":"2023-01-04T03:20:43+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1374613862","fragment_type":"issue_comment","sequence":6,"text":"how far back in time should I go?\n\nbecause this CI workflow tells me that the problem might not be a distro issue:\n\n URL","author_login":"Remi-Gau","author_association":"NONE","created_at":"2023-01-07T21:11:29+08:00","repo_name":"ReproNim/neurodocker","issue_id":1517687469,"issue_number":485,"issue_url":"https://github.com/ReproNim/neurodocker/issues/485","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1232935588","fragment_type":"issue_description","sequence":0,"text":"FSL installation takes long\nThis is not a neurodocker question but may be relevant. I think it is a more FSL or conda question. However, I though about asking here for some hints because FSL support is tedious with their mailing list.\n\nI'm trying to build a Docker container with FSL. The \"Stage 2\" of \"Performing post install tasks\" takes forever. It's not my Internet connection. Maybe someone here has a similar experience.\n\nHere's the part installing FSL:\n\nFROM debian:stable\n...\nWORKDIR /opt\n# Install FSL for pydeface\n# file command is used by FSL installer\nRUN apt-get -y install file\nRUN curl -s URL -o fslinstaller.py\nRUN python3 fslinstaller.py -d /opt/fsl -V 6.0.5\nRUN rm fslinstaller.py\n# Variables and config for FSL.\nENV FSLDIR=\"/opt/fsl\"\nRUN . ${FSLDIR}/etc/fslconf/fsl.sh\nENV PATH=\"${FSLDIR}/bin:${PATH}\"\n\nI narrowed it down to the following command:\n\n/opt/fsl/fslpython/bin/python /opt/fsl/fslpython/bin/conda-env create -f /opt/fsl/etc/fslconf/fslpython_environment.yml\n\nHowever, it doesn't do much but creates a conda environment.\n\n \n \nHere are the contents of `/opt/fsl/etc/fslconf/fslpython_environment.yml`.\n \n\nname: fslpython\nchannels:\n - conda-forge\n - defaults\n - URL \ndependencies:\n - eddy_qc=1.0.3\n - fmrib-unpack=2.8.0\n - fsl-add_module=0.3.2\n - fsl-get_standard=0.1.0\n - fsl_mrs=1.1.8\n - fsl-pyfeeds=0.9.5\n - fsl_sub=2.5.7\n - fsl_sub_plugin_sge=1.4.7\n - fsl_sub_plugin_slurm=1.3.7\n - fsl-tirl=v2.1.3b1\n - fsleyes=1.3.0\n - fslpy=3.7.0\n - ipython=7.23.1\n - matplotlib=3.4.2\n - mkl-service=2.3.0\n - nidmresults=2.1.0\n - nidmresults-fsl=2.2.0\n - nibabel=3.2.1\n - nilearn>=0.7.1\n - numpy=1.20.3\n - pandas=1.2.4\n - paramiko=2.7.2\n - pip=21.1.1\n - python=3.8.6\n - pyyaml=5.4.1\n - scikit-image=0.18.1\n - scikit-learn=0.24.2\n - scipy=1.6.3\n - seaborn=0.11.1\n - vtk=9.0.1\n - wire=1.0.0\n - wxpython=4.0.7.post2","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-11T16:54:46+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124668794","fragment_type":"issue_comment","sequence":1,"text":"An update. I've tried version 6.0.2 and it went through but with error:\n\n[OK] Installer updated to latest version 3.2.3\n[OK] Installer self update successful.\nDownloading...\nChecking FSL package \n[OK] File downloaded\nInstalling FSL software version 6.0.2...\n[OK] FSL software installed.\nPerforming post install tasks\nStage 1\nBy installing this python distribution you agree to the license terms in\n/opt/fsl/fslpython/LICENSE.txt\n100%\n/opt/fsl/etc/fslconf/fslpython_install.sh: line 188: /opt/fsl/fslpython/bin/conda: No such file or directory\n/opt/fsl/etc/fslconf/fslpython_install.sh: line 189: /opt/fsl/fslpython/bin/conda: No such file or directory\n/opt/fsl/etc/fslconf/fslpython_install.sh: line 190: /opt/fsl/fslpython/bin/conda: No such file or directory\n/opt/fsl/etc/fslconf/fslpython_install.sh: line 191: /opt/fsl/fslpython/bin/conda: No such file or directory\nStage 2\n100%\nFailed to create FSL Python environment - see /tmp/fslpythonvQ5d/fslpython_miniconda_installer.log for details\nPost install setup failed\n[OK] Post installation setup complete\nError processing tar file(exit status 1): write /opt/fsl/data/first/models_317_bin/R_Late_bin.bmv: no space left on device","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-12T08:12:11+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1124916854","fragment_type":"issue_comment","sequence":2,"text":"Update. I changed `RUN python3 fslinstaller.py -d /opt/fsl -V 6.0.2` into `RUN /usr/bin/python3 fslinstaller.py -d /opt/fsl -V 6.0.2`. It didn't change anything.","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-12T12:14:27+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1125021757","fragment_type":"issue_comment","sequence":3,"text":"Cześć @kaczmarj :-) Thanks for the tip. Yes, I've seen this post but I'm trying to install FSL in Docker, so executing these steps is a little bit problematic. But I will try it next.\n\nWith version 6.0.2, Stage 2 doesn't last long. I think it stalls in newer versions because something goes wrong. I'm really surprised that the FSL developers don't fix these issues. But well, it is what it is.\n\nSmall update. I've added\n\nENV FSLDIR=\"/opt/fsl\"\nRUN [ -d \"$FSLDIR/fslpython\" ] && rm -r $FSLDIR/fslpython; \\\n $FSLDIR/etc/fslconf/fslpython_install.sh -f $FSLDIR\n\nas indicated in Troubleshooting section but it didn't change anything.","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-12T13:50:45+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1125066219","fragment_type":"issue_comment","sequence":4,"text":"Funny thing, the `-L` option is in the newer FSL version of `fslpython_install.sh` but not 6.0.2. I added it in 6.0.2 and now \"Stage 2\" stalls as originally. That's the current Docker snippet:\n\n# Install FSL for pydeface\nRUN echo \"INFO Installing FSL ...\"\n# file command is used by FSL installer\nRUN apt-get -y install file\nRUN curl -s URL -o fslinstaller.py\nRUN /usr/bin/python3 fslinstaller.py -d /opt/fsl -V 6.0.2; \\\n rm fslinstaller.py\n# Try solution from URL \nENV FSLDIR=\"/opt/fsl\"\nRUN sed -i \"s/dl_cmd_opts=\\\"--fail\\\"/dl_cmd_opts=\\\"--fail -L\\\"/g\" $FSLDIR/etc/fslconf/fslpython_install.sh\nRUN [ -d \"$FSLDIR/fslpython\" ] && rm -r $FSLDIR/fslpython; \\\n $FSLDIR/etc/fslconf/fslpython_install.sh -f $FSLDIR\n# Variables and config for FSL.\nRUN . ${FSLDIR}/etc/fslconf/fsl.sh\nENV PATH=\"${FSLDIR}/bin:${PATH}\"","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-12T14:28:53+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1125069017","fragment_type":"issue_comment","sequence":5,"text":"the stall is normal. conda takes its time to create the environment :) from my experience, it could take around 15 minutes or more for the conda installation to complete. please let me know if your docker build succeeds","author_login":"kaczmarj","author_association":"COLLABORATOR","created_at":"2022-05-12T14:31:22+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1125879930","fragment_type":"issue_comment","sequence":6,"text":"I've built a Dockerfile using Neurodocker with `neurodocker generate docker --pkg-manager apt --base-image debian:stable --fsl version=6.0.2 > Dockerfile.nd.fsl` It finished building but I don't have a detailed timestamp. It was less than 2.5h.\n\nI'll try my Dockerfile again. It seems FSL takes a long time to install.","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-13T10:10:13+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1125994116","fragment_type":"issue_comment","sequence":7,"text":"i think the neurodocker build is the way to go. but unfortunately, fsl does take a long time to install. first, the fsl binaries have to be downloaded, and then the conda environment has to be created. both of these processes take some time as you have seen. these will go slower is the internet speed is low.\n\nregarding the progress `Stage 2 0%`, in my experience the percentage did not increase until the very end of the process... so i wouldn't rely on that as a marker of whether the installation has stalled. you could look at `htop` or your computer's activity monitor to see what processes are going on in the build.","author_login":"kaczmarj","author_association":"COLLABORATOR","created_at":"2022-05-13T12:15:57+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1128746040","fragment_type":"issue_comment","sequence":8,"text":"I'd like to thank you @kaczmarj for help. I've build the Docker container using mine and Neurodocker-generated Dockerfile, both for FSL 6.0.5.1 Both work. Both take around 2.5h to install FSL (**not** due to the Internet bandwidth).\n\nI generated Nerodocker Dockerfile with `neurodocker generate docker --pkg-manager apt --base-image debian:stable --fsl version=6.0.5.1 > Dockerfile.nd.fsl_6.0.5.1`.\n\nSnippet from my Dockerfile:\n\nFROM debian:stable\n...\n# Install FSL for pydeface\nRUN echo \"INFO Installing FSL ...\"\nRUN curl -s URL -o fslinstaller.py\nRUN /usr/bin/python3 fslinstaller.py -d /opt/fsl -V 6.0.5.1; \\\n rm fslinstaller.py\n# Variables and config for FSL\nENV FSLDIR=\"/opt/fsl\"\nRUN . ${FSLDIR}/etc/fslconf/fsl.sh\nENV PATH=\"${FSLDIR}/bin:${PATH}\"","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-17T11:21:06+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1128915388","fragment_type":"issue_comment","sequence":9,"text":"@mateuszpawlik - i'm glad it's working now.\n\none note on the line `RUN . ${FSLDIR}/etc/fslconf/fsl.sh`. the sourced variables will not persist to future instructions. each `RUN` instruction starts up its own shell and then tears down that shell when it's finished.\n\nyou could get around this in two ways: either source the `fsl.sh` file when you start the container, or hardcode the environment variables in `fsl.sh` with `ENV` instructions.","author_login":"kaczmarj","author_association":"COLLABORATOR","created_at":"2022-05-17T14:05:55+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1129755087","fragment_type":"issue_comment","sequence":10,"text":"Thank you for that. It would most probably hurt later :wink:","author_login":"mateuszpawlik","author_association":"NONE","created_at":"2022-05-18T09:00:35+08:00","repo_name":"ReproNim/neurodocker","issue_id":1232935588,"issue_number":450,"issue_url":"https://github.com/ReproNim/neurodocker/issues/450","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0393","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Investigate failing example tests?","query_context":"URL \n\nNo idea why \n\n(assertion for unit tests seems to fail)\n\nxtend examples fail too\n URL \n\n(also test fails here)","known_context_document_ids":["gh_issue_2526049731"],"reference_answer":"Caused by: java.lang.Error: Unresolved compilation problem: \n SANITY CHECK: Invalid opcode -88 at pc 162 for stackmap table attribute for method foo()\n\n at foo.Test.foo(Test.java:7)\n ... 59 more","answer_document_id":"gh_comment_2336717557","silver_evidence_path":["gh_comment_2354587712","gh_issue_2512361262","gh_comment_2336717557"],"evidence_issue_ids":[2526049731,2512361262],"source_repo_name":"eclipse/xtext","source_issue_id":2526049731,"source_issue_number":3193,"source_issue_url":"https://github.com/eclipse/xtext/issues/3193","target_repo_name":"eclipse/xtext","target_issue_id":2512361262,"target_issue_number":3188,"target_issue_url":"https://github.com/eclipse/xtext/issues/3188","reference_anchor_document_id":"gh_comment_2354587712","reference_answer_author":"cdietrich","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.125,"target_answer_overlap":0.1176},"issue_created_at":"2024-09-14T07:27:18+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_2526049731","fragment_type":"issue_description","sequence":0,"text":"Investigate failing example tests\nURL \n\nNo idea why \n\n(assertion for unit tests seems to fail)\n\nxtend examples fail too\n URL \n\n(also test fails here)","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-14T07:27:18+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2350906450","fragment_type":"issue_comment","sequence":1,"text":"@LorenzoBettini wonder if we can archive the screenshots somehow if swtbot takes any","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-14T08:13:13+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2350908553","fragment_type":"issue_comment","sequence":2,"text":"at least locally i see 2 launch configs for the xtend anno example. no idea why","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-14T08:18:06+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2350912594","fragment_type":"issue_comment","sequence":3,"text":"=> looks like the workaround transitive dependeny does not work for some reason?","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-14T08:30:11+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2350934922","fragment_type":"issue_comment","sequence":4,"text":"@cdietrich Yes, see for example URL \n\nTo be honest, I thought we already archived screenshots in Xtext itself, but maybe we never needed to.","author_login":"LorenzoBettini","author_association":"CONTRIBUTOR","created_at":"2024-09-14T09:52:22+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2350935942","fragment_type":"issue_comment","sequence":5,"text":"@cdietrich when it happened in the past in my projects, that was due to some changed transitive/re-exported dependencies. Explicitly adding the dep used to work for me.","author_login":"LorenzoBettini","author_association":"CONTRIBUTOR","created_at":"2024-09-14T09:56:42+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2354585587","fragment_type":"issue_comment","sequence":6,"text":"java.lang.IllegalArgumentException: Java code compiled with errors:\nPb(0) SANITY CHECK: Invalid opcode -88 at pc 156 for stackmap table attribute for method doStuff()\n\nCode was:\nimport org.eclipse.xtext.xbase.lib.Procedures.Procedure1;\nimport org.eclipse.xtext.xbase.lib.util.ToStringBuilder;\n\n@SuppressWarnings(\"all\")\npublic class Foo {\n public Foo() {\n }\n\n public Foo(final Procedure1 initializer) {\n initializer.apply(this);\n }\n\n public Object doStuff() {\n String _xtrycatchfinallyexpression = null;\n try {\n _xtrycatchfinallyexpression = \"MyString\";\n } finally {\n \"bla\".length();\n }\n return ((String) _xtrycatchfinallyexpression);\n }\n\n @Override\n public String toString() {\n String result = new ToStringBuilder(this).addAllFields().toString();\n return result;\n }\n}\n\n at org.eclipse.xtext.xbase.testing.OnTheFlyJavaCompiler2.compileToClass(OnTheFlyJavaCompiler2.java:92)\n at org.eclipse.xtext.example.domainmodel.tests.XbaseIntegrationTest.invokeXbaseExpression(XbaseIntegrationTest.java:59)\n at org.eclipse.xtext.xbase.testing.evaluation.AbstractXbaseEvaluationTest.assertEvaluatesTo(AbstractXbaseEvaluationTest.java:5346)\n at org.eclipse.xtext.xbase.testing.evaluation.AbstractXbaseEvaluationTest.testCastedExpression_06(AbstractXbaseEvaluationTest.java:2967)\n at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)\n at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n at java.base/java.lang.reflect.Method.invoke(Method.java:569)\n at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)\n at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)\n at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)\n at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)\n at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)\n at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)\n at org.eclipse.xtext.testing.XtextRunner$1.evaluate(XtextRunner.java:50)\n at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)\n at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)\n at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)\n at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)\n at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)\n at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)\n at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)\n at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)\n at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)\n at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)\n at org.junit.runners.ParentRunner.run(ParentRunner.java:413)\n at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:93)\n at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)\n at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:529)\n at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:756)\n at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:452)\n at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-17T05:51:10+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2354587712","fragment_type":"issue_comment","sequence":7,"text":"wonder why the patch for \n URL \nis not working. maybe we cannot determine version :(","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-17T05:52:58+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[2512361262],"is_known_query_context":false},{"document_id":"gh_comment_2354596117","fragment_type":"issue_comment","sequence":8,"text":"java.lang.NullPointerException: Cannot invoke \"org.eclipse.core.runtime.Plugin.getBundle()\" because the return value of \"org.eclipse.jdt.core.JavaCore.getPlugin()\" is null\n at org.eclipse.xtext.xbase.testing.InMemoryJavaCompiler.findInlineJsrBytecode(InMemoryJavaCompiler.java:226)\n at org.eclipse.xtext.xbase.testing.InMemoryJavaCompiler. (InMemoryJavaCompiler.java:223)\n at org.eclipse.xtext.xbase.testing.OnTheFlyJavaCompiler2. (OnTheFlyJavaCompiler2.java:52)\n at org.eclipse.xtext.xbase.testing.OnTheFlyJavaCompiler2. (OnTheFlyJavaCompiler2.java:48)\n at org.eclipse.xtext.xbase.testing.OnTheFlyJavaCompiler2$$FastClassByGuice$$11bb94bc.GUICE$TRAMPOLINE( )\n at org.eclipse.xtext.xbase.testing.OnTheFlyJavaCompiler2$$FastClassByGuice$$11bb94bc.apply( )\n at com.google.inject.internal.DefaultConstructionProxyFactory$FastClassProxy.newInstance(DefaultConstructionProxyFactory.java:82)\n\nof course this CRAPPPPPPPPP\ndoes not work in standalone mode\n=> no version check possible.\n\n=> check if setter is there. if yes invoke it :(","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-17T05:58:21+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2354673810","fragment_type":"issue_comment","sequence":9,"text":"Moreover, we should have a test for the on the fly compiler.\nI thought we had some...","author_login":"LorenzoBettini","author_association":"CONTRIBUTOR","created_at":"2024-09-17T06:41:41+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2354746888","fragment_type":"issue_comment","sequence":10,"text":"I think we do have tests but those are often executed as plugin tests, no?","author_login":"szarnekow","author_association":"CONTRIBUTOR","created_at":"2024-09-17T07:24:32+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2355484017","fragment_type":"issue_comment","sequence":11,"text":"But that should be the case for domainmodel as well, during a Maven build.\nBut maybe, @cdietrich, you're referring to the case when running from Eclipse as a plain JUnit test, aren't you?","author_login":"LorenzoBettini","author_association":"CONTRIBUTOR","created_at":"2024-09-17T11:49:58+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2355490147","fragment_type":"issue_comment","sequence":12,"text":"yes this is what the swt bot tests in xtext-reference-projects/integrationtests do.\nthey create projects and do eclipse interactions with it","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-17T11:52:16+08:00","repo_name":"eclipse/xtext","issue_id":2526049731,"issue_number":3193,"issue_url":"https://github.com/eclipse/xtext/issues/3193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2512361262","fragment_type":"issue_description","sequence":0,"text":"Even more problems with latest jdt\n/home/jenkins/agent/workspace/xtext_main/org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java:[207] \n05:21:12 [ERROR] this.compilerOptions.inlineJsrBytecode = true;\n05:21:12 [ERROR] ^^^^^^^^^^^^^^^^^\n05:21:12 [ERROR] inlineJsrBytecode cannot be resolved or is not a field\n05:21:12 [ERROR] 1 problem (1","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-08T12:21:34+08:00","repo_name":"eclipse/xtext","issue_id":2512361262,"issue_number":3188,"issue_url":"https://github.com/eclipse/xtext/issues/3188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2336713733","fragment_type":"issue_comment","sequence":1,"text":"of course now i see a ton of test errors i cannot reproduce locally.","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-08T14:47:00+08:00","repo_name":"eclipse/xtext","issue_id":2512361262,"issue_number":3188,"issue_url":"https://github.com/eclipse/xtext/issues/3188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2336717557","fragment_type":"issue_comment","sequence":2,"text":"Caused by: java.lang.Error: Unresolved compilation problem: \n SANITY CHECK: Invalid opcode -88 at pc 162 for stackmap table attribute for method foo()\n\n at foo.Test.foo(Test.java:7)\n ... 59 more","author_login":"cdietrich","author_association":"MEMBER","created_at":"2024-09-08T14:59:02+08:00","repo_name":"eclipse/xtext","issue_id":2512361262,"issue_number":3188,"issue_url":"https://github.com/eclipse/xtext/issues/3188","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2336726956","fragment_type":"issue_comment","sequence":3,"text":"You mean 4.33? The option there is **always true** independently what is set. In 4.34 the option is gone.","author_login":"iloveeclipse","author_association":"CONTRIBUTOR","created_at":"2024-09-08T15:29:09+08:00","repo_name":"eclipse/xtext","issue_id":2512361262,"issue_number":3188,"issue_url":"https://github.com/eclipse/xtext/issues/3188","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0394","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"AltTab silently crashing since 7.20?","query_context":"_This issue was opened by a bot after a user submitted feedback through the in-app form._\n\n__From:__ steve.hoek@gmail.com\n\n__Message:__\n \n \n \n\n \n Debug profile \n \n\n* App version: 7.20.0\n* App preferences: \n * MSAppCenter310AppCenterUserDefaultsMigratedKey: 1\n * MSAppCenter310CrashesUserDefaultsMigratedKey: 1\n * MSAppCenterInstallId: A8C808E7-34D7-4E34-8CA7-EDAE97A0228D\n * MSAppCenterNetworkRequestsAllowed: 0\n * MSAppCenterPastDevices: {length = 1149, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000389 }\n * MSAppCenterSessionIdHistory: {length = 460, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000156 }\n * MSAppCenterUserIdHistory: {length = 455, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000151 }\n * NSNavLastRootDirectory: /Applications\n * NSNavPanelExpandedSizeForOpenMode: {800, 448}\n * NSStatusItem Preferred Position Item-0: 12268\n * NSWindow Frame NSFontPanel: 997 176 445 235 0 0 1512 944 \n * NSWindow Frame NSNavPanelAutosaveName: 356 255 800 448 0 0 1512 944 \n * NSWindow Frame SUStatusFrame: 556 624 400 135 0 0 1512 944 \n * NSWindow Frame SUUpdateAlert: 446 427 620 398 0 0 1512 944 \n * SUAutomaticallyUpdate: 1\n * SUEnableAutomaticChecks: 1\n * SUHasLaunchedBefore: 1\n * SULastCheckTime: 2025-02-19 18:12:14 +0000\n * SUUpdateRelaunchingMarker: 0\n * alignThumbnails: 0\n * appearanceVisibility: 2\n * appsToShow: 0\n * arrowKeysEnabled: true\n * blacklist: [{\"hide\":\"2\",\"ignore\":\"0\",\"bundleIdentifier\":\"com.apple.finder\"},{\"bundleIdentifier\":\"com.microsoft.rdc.macos\",\"hide\":\"0\",\"ignore\":\"2\"},{\"hide\":\"0\",\"ignore\":\"2\",\"bundleIdentifier\":\"com.teamviewer.TeamViewer\"},{\"bundleIdentifier\":\"org.virtualbox.app.VirtualBoxVM\",\"hide\":\"0\",\"ignore\":\"2\"},{\"bundleIdentifier\":\"com.parallels.\",\"ignore\":\"2\",\"hide\":\"0\"},{\"bundleIdentifier\":\"com.vmware.fusion\",\"hide\":\"0\",\"ignore\":\"2\"},{\"ignore\":\"2\",\"bundleIdentifier\":\"com.apple.ScreenSharing\",\"hide\":\"0\"},{\"ignore\":\"0\",\"hide\":\"1\",\"bundleIdentifier\":\"cools.wins.main\"}]\n * cancelShortcut: ⎋\n * closeWindowShortcut: \n * crashPolicy: 2\n * fadeOutAnimation: true\n * focusWindowShortcut: \n * hideAppBadges: false\n * hideShowAppShortcut: \n * hideStatusIcons: false\n * hideWindowlessApps: true\n * holdShortcut: ⌘\n * minDeminWindowShortcut: \n * mouseHoverEnabled: false\n * nextWindowShortcut2: ⇥\n * preferencesVersion: 7.20.0\n * previewFocusedWindow: false\n * previousWindowShortcut: ⇧⌘\n * quitAppShortcut: \n * screensToShow: 1\n * screensToShow2: 1\n * showHiddenWindows: 1\n * showHiddenWindows2: 2\n * showMinimizedWindows: 2\n * showMinimizedWindows2: 2\n * showTabsAsWindows: false\n * showTitles: 0\n * spacesToShow: 0\n * startAtLogin: true\n * theme: 0\n * titleTruncation: 0\n * toggleFullscreenWindowShortcut: \n * updatePolicy: 2\n * windowMaxWidthInRow: 30\n* Applications: 122\n* Windows: 15\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 4, spaceIndexes: 2}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 6, spaceIndexes: 4}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: true, isOnAllSpaces: false, shouldShowTheUser: false, spaceIds: , spaceIndexes: }\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: true, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1235, spaceIndexes: 7}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 7, spaceIndexes: 5}\n * {isFullscreen: true, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1269, spaceIndexes: 6}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: true, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1407, spaceIndexes: 8}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: true, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: true, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n* OS version: Version 15.3.1 (Build 24D70)\n* OS architecture: arm64\n* Locale: en_US (fixed en_US)\n* Spaces: 8\n* Dark mode: Dark\n* \"Displays have separate Spaces\": checked\n* Hardware model: Mac15,8\n* Screens: 1\n * {x: 0.0, y: 0.0, width: 1512.0, height: 982.0}\n* CPU model: Apple M3 Max\n* Memory size: 68.72 GB\n* Active CPU count: 16\n* Current CPU frequency: nil\n* Resource utilization: \n * CPU: 0.0%\n * Memory: 156M-\n * Threads count: 26","known_context_document_ids":["gh_issue_2865065194"],"reference_answer":"I think you're experiencing URL \n\nCould you please try out the latest release? I think it will fix this issue 👍","answer_document_id":"gh_comment_2675593074","silver_evidence_path":["gh_comment_2675593659","gh_issue_2868506291","gh_comment_2675593074"],"evidence_issue_ids":[2865065194,2868506291],"source_repo_name":"lwouis/alt-tab-macos","source_issue_id":2865065194,"source_issue_number":4244,"source_issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4244","target_repo_name":"lwouis/alt-tab-macos","target_issue_id":2868506291,"target_issue_number":4252,"target_issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","reference_anchor_document_id":"gh_comment_2675593659","reference_answer_author":"lwouis","reference_answer_author_association":"OWNER","quality_score":85.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.1333,"target_answer_overlap":0.1111},"issue_created_at":"2025-02-20T04:45:30+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_2865065194","fragment_type":"issue_description","sequence":0,"text":"AltTab silently crashing since 7.20\n_This issue was opened by a bot after a user submitted feedback through the in-app form._\n\n__From:__ steve.hoek@gmail.com\n\n__Message:__\n \n \n \n\n \n Debug profile \n \n\n* App version: 7.20.0\n* App preferences: \n * MSAppCenter310AppCenterUserDefaultsMigratedKey: 1\n * MSAppCenter310CrashesUserDefaultsMigratedKey: 1\n * MSAppCenterInstallId: A8C808E7-34D7-4E34-8CA7-EDAE97A0228D\n * MSAppCenterNetworkRequestsAllowed: 0\n * MSAppCenterPastDevices: {length = 1149, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000389 }\n * MSAppCenterSessionIdHistory: {length = 460, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000156 }\n * MSAppCenterUserIdHistory: {length = 455, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000151 }\n * NSNavLastRootDirectory: /Applications\n * NSNavPanelExpandedSizeForOpenMode: {800, 448}\n * NSStatusItem Preferred Position Item-0: 12268\n * NSWindow Frame NSFontPanel: 997 176 445 235 0 0 1512 944 \n * NSWindow Frame NSNavPanelAutosaveName: 356 255 800 448 0 0 1512 944 \n * NSWindow Frame SUStatusFrame: 556 624 400 135 0 0 1512 944 \n * NSWindow Frame SUUpdateAlert: 446 427 620 398 0 0 1512 944 \n * SUAutomaticallyUpdate: 1\n * SUEnableAutomaticChecks: 1\n * SUHasLaunchedBefore: 1\n * SULastCheckTime: 2025-02-19 18:12:14 +0000\n * SUUpdateRelaunchingMarker: 0\n * alignThumbnails: 0\n * appearanceVisibility: 2\n * appsToShow: 0\n * arrowKeysEnabled: true\n * blacklist: [{\"hide\":\"2\",\"ignore\":\"0\",\"bundleIdentifier\":\"com.apple.finder\"},{\"bundleIdentifier\":\"com.microsoft.rdc.macos\",\"hide\":\"0\",\"ignore\":\"2\"},{\"hide\":\"0\",\"ignore\":\"2\",\"bundleIdentifier\":\"com.teamviewer.TeamViewer\"},{\"bundleIdentifier\":\"org.virtualbox.app.VirtualBoxVM\",\"hide\":\"0\",\"ignore\":\"2\"},{\"bundleIdentifier\":\"com.parallels.\",\"ignore\":\"2\",\"hide\":\"0\"},{\"bundleIdentifier\":\"com.vmware.fusion\",\"hide\":\"0\",\"ignore\":\"2\"},{\"ignore\":\"2\",\"bundleIdentifier\":\"com.apple.ScreenSharing\",\"hide\":\"0\"},{\"ignore\":\"0\",\"hide\":\"1\",\"bundleIdentifier\":\"cools.wins.main\"}]\n * cancelShortcut: ⎋\n * closeWindowShortcut: \n * crashPolicy: 2\n * fadeOutAnimation: true\n * focusWindowShortcut: \n * hideAppBadges: false\n * hideShowAppShortcut: \n * hideStatusIcons: false\n * hideWindowlessApps: true\n * holdShortcut: ⌘\n * minDeminWindowShortcut: \n * mouseHoverEnabled: false\n * nextWindowShortcut2: ⇥\n * preferencesVersion: 7.20.0\n * previewFocusedWindow: false\n * previousWindowShortcut: ⇧⌘\n * quitAppShortcut: \n * screensToShow: 1\n * screensToShow2: 1\n * showHiddenWindows: 1\n * showHiddenWindows2: 2\n * showMinimizedWindows: 2\n * showMinimizedWindows2: 2\n * showTabsAsWindows: false\n * showTitles: 0\n * spacesToShow: 0\n * startAtLogin: true\n * theme: 0\n * titleTruncation: 0\n * toggleFullscreenWindowShortcut: \n * updatePolicy: 2\n * windowMaxWidthInRow: 30\n* Applications: 122\n* Windows: 15\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 4, spaceIndexes: 2}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 6, spaceIndexes: 4}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: true, isOnAllSpaces: false, shouldShowTheUser: false, spaceIds: , spaceIndexes: }\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: true, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1235, spaceIndexes: 7}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 7, spaceIndexes: 5}\n * {isFullscreen: true, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1269, spaceIndexes: 6}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1, spaceIndexes: 1}\n * {isFullscreen: true, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 1407, spaceIndexes: 8}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: true, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n * {isFullscreen: false, isWindowlessApp: false, isMinimized: true, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceIds: 5, spaceIndexes: 3}\n* OS version: Version 15.3.1 (Build 24D70)\n* OS architecture: arm64\n* Locale: en_US (fixed en_US)\n* Spaces: 8\n* Dark mode: Dark\n* \"Displays have separate Spaces\": checked\n* Hardware model: Mac15,8\n* Screens: 1\n * {x: 0.0, y: 0.0, width: 1512.0, height: 982.0}\n* CPU model: Apple M3 Max\n* Memory size: 68.72 GB\n* Active CPU count: 16\n* Current CPU frequency: nil\n* Resource utilization: \n * CPU: 0.0%\n * Memory: 156M-\n * Threads count: 26","author_login":"alt-tab-macos-bot","author_association":"NONE","created_at":"2025-02-20T04:45:30+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2865065194,"issue_number":4244,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4244","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2672535073","fragment_type":"issue_comment","sequence":1,"text":"I've had it crash once with 7.20.1. I am running from the command line with logging enabled now to see if it happens again.","author_login":"stevehoek","author_association":"NONE","created_at":"2025-02-20T19:53:58+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2865065194,"issue_number":4244,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4244","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675465461","fragment_type":"issue_comment","sequence":2,"text":"@emdoe thank you for sharing this! I think I found the bug. It was introduced in v7.20.0.\n\nCould you please try out this local build, and let me know if the issue is fixed?\n\nThank you 🙇","author_login":"lwouis","author_association":"OWNER","created_at":"2025-02-21T20:20:01+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2865065194,"issue_number":4244,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4244","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675593659","fragment_type":"issue_comment","sequence":3,"text":"Thanks @lwouis for the quick fix! I am starting to test the fix and so far I have not experienced any new problems. I guess #4252 could be caused by the same issue?","author_login":"emdoe","author_association":"NONE","created_at":"2025-02-21T21:35:30+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2865065194,"issue_number":4244,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4244","linked_issue_ids":[2868506291],"is_known_query_context":false},{"document_id":"gh_issue_2868506291","fragment_type":"issue_description","sequence":0,"text":"Crash after system wake\n**Describe the bug**\n\nI cannot say for sure it's every time, but I am pretty sure that sleep/system-wake is the culprit which causes a quite recurring crash of the app.\n\n**Screenshots / video**\n\n---\n\n**Steps to reproduce the bug**\n\n---\n\n**Your environment**\n\n* AltTab version: Version 7.20.1\n* macOS version: macOS Sequoia 15.3.1 (24D70)\n* Other relevant info: I use an external keyboard and one external monitor, other than that I can't think of anything relevant right now.","author_login":"qns7","author_association":"NONE","created_at":"2025-02-21T09:35:53+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674314943","fragment_type":"issue_comment","sequence":1,"text":"I think I also experience this bug now (after yesterday's update), but my macos version is 14.7.4 (23H420)","author_login":"danilagalimov","author_association":"NONE","created_at":"2025-02-21T11:35:24+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674338273","fragment_type":"issue_comment","sequence":2,"text":"Hi,\nDid you share the crash report upon relaunching the app?\nIf not, could you please share any crash report or logs here?\nThank you","author_login":"lwouis","author_association":"OWNER","created_at":"2025-02-21T11:46:13+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674368279","fragment_type":"issue_comment","sequence":3,"text":"Hi @lwouis , where can I find the crash report? Actually there was no crash window, so maybe it was just quit.","author_login":"danilagalimov","author_association":"NONE","created_at":"2025-02-21T12:00:38+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674370038","fragment_type":"issue_comment","sequence":4,"text":"Also I have \n\n policy, so I assume it should be sent automatically","author_login":"danilagalimov","author_association":"NONE","created_at":"2025-02-21T12:01:26+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674445401","fragment_type":"issue_comment","sequence":5,"text":"I shared them a bunch of times when it happened - using the prompt.\nAfter the third time or so I also chose \"Always send crash reports\".\n\nSometimes there also pops up an 'allowance-prompt' where it asks something like:\n\"Allow Alt-Tab to use screen-recording **directly** bypassing the '**picker**'\"\nor something like that (next time that pops up I make a screenshot of course). \nI allowed that one the first time, but then it came up a second time, which I allowed too.\n\nRecently I reset my allowances \n\nreset ScreenCapture com.lwouis.alt-tab-macos && \\\ntccutil reset Microphone com.lwouis.alt-tab-macos && \\\ntccutil reset Camera com.lwouis.alt-tab-macos && \\\ntccutil reset Accessibility com.lwouis.alt-tab-macos\n\nand app-settings and now check if that helps; should have done that before posting, sorry.\n\nI'll keep you posted.\n\nBest regards \nQ","author_login":"qns7","author_association":"NONE","created_at":"2025-02-21T12:36:31+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674718326","fragment_type":"issue_comment","sequence":6,"text":"I don't know if that's related to what I'm experiencing as well, but after the 7.20, the app was crashing and giving me option to submit a report, after I updated to 7.20.1, looks like it's silently quitting and not asking me to submit a crash report when I open it again.","author_login":"drauziooppenheimer","author_association":"NONE","created_at":"2025-02-21T14:36:38+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675018347","fragment_type":"issue_comment","sequence":7,"text":"I had two sleep/system-wakes since I reset my allowances and app-settings (including of course allowing both 'Accessibility' and 'Screen & System Audio Recording' again after starting Alt-Tab afterwards; and setting my settings as I prefer them) and both times nothing crashed since then. \nNot after waking up and not randomly in my sessions.\nI will report as soon as it happens again.\nAnd since two are experiencing the same thing I keep the issue open for now. 🐧","author_login":"qns7","author_association":"NONE","created_at":"2025-02-21T16:33:17+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2675593074","fragment_type":"issue_comment","sequence":8,"text":"I think you're experiencing URL \n\nCould you please try out the latest release? I think it will fix this issue 👍","author_login":"lwouis","author_association":"OWNER","created_at":"2025-02-21T21:35:14+08:00","repo_name":"lwouis/alt-tab-macos","issue_id":2868506291,"issue_number":4252,"issue_url":"https://github.com/lwouis/alt-tab-macos/issues/4252","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0395","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[ECR] [Bug]: Creation of two untagged images when pulling an image through ECR Cache?","query_context":"### Community Note\n\n* Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request\n* Please do not leave \"+1\" or \"me too\" comments, they generate extra noise for issue followers and do not help prioritize the request\n* If you are interested in working on this issue or have submitted a pull request, please leave a comment\n\n \n\n \n\n**Tell us about your request**\nI had observed a bug with pulling images using ECR Cache \n\n**Which service(s) is this request for?**\nECR\n\n**Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?**\nThe issue is when I pull an image from the upstream repository in the public registry using ECR cache it creates two additional untagged images along with the image with the tag mentioned in the \"docker pull\" command.\n\n**Are you currently working around this issue?**\nHow are you currently solving this problem?\nI am currently implementing life cycle policies for the repositories to delete un tagged images \n URL \n\n**Additional context**\nAnything else we should know?\nBelow is my replication scenario for more understanding of the issue :\n\n $ docker pull .dkr.ecr. .amazonaws.com/ecr-public/amazonlinux/amazonlinux:latest\n latest: Pulling from ecr-public/amazonlinux/amazonlinux\n xxx: Pull complete \n Digest: sha256:xxxxxxxxxxxxxxx\n Status: Downloaded newer image for .dkr.ecr. .amazonaws.com/ecr-public/amazonlinux/amazonlinux:latest\n .dkr.ecr. .amazonaws.com/ecr-public/amazonlinux/amazonlinux:latest\n\n$ aws ecr list-images --repository-name ecr-public/amazonlinux/amazonlinux --filter tagStatus=UNTAGGED --region \n{\n \"imageIds\": [\n {\n \"imageDigest\": \"sha256:xxxxxxxxxxxx\"\n },\n {\n \"imageDigest\": \"sha256:xxxxxxxxxxxx\"\n }\n ]\n}\n\n**Attachments**\nIf you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)","known_context_document_ids":["gh_issue_1091031544"],"reference_answer":"I'm surprised you see it working in containerd. This has been a known error of containerd pusher that it repushes the tag multiple times. Maybe something has changed or containerd case is not quite the same.","answer_document_id":"gh_comment_790329331","silver_evidence_path":["gh_comment_2010595120","gh_issue_818862586","gh_comment_790329331"],"evidence_issue_ids":[1091031544,818862586],"source_repo_name":"aws/containers-roadmap","source_issue_id":1091031544,"source_issue_number":1612,"source_issue_url":"https://github.com/aws/containers-roadmap/issues/1612","target_repo_name":"moby/buildkit","target_issue_id":818862586,"target_issue_number":2004,"target_issue_url":"https://github.com/moby/buildkit/issues/2004","reference_anchor_document_id":"gh_comment_2010595120","reference_answer_author":"tonistiigi","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.3529,"target_answer_overlap":0.3333},"issue_created_at":"2021-12-30T11:01:40+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1091031544","fragment_type":"issue_description","sequence":0,"text":"[ECR] [Bug]: Creation of two untagged images when pulling an image through ECR Cache\n### Community Note\n\n* Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request\n* Please do not leave \"+1\" or \"me too\" comments, they generate extra noise for issue followers and do not help prioritize the request\n* If you are interested in working on this issue or have submitted a pull request, please leave a comment\n\n \n\n \n\n**Tell us about your request**\nI had observed a bug with pulling images using ECR Cache \n\n**Which service(s) is this request for?**\nECR\n\n**Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?**\nThe issue is when I pull an image from the upstream repository in the public registry using ECR cache it creates two additional untagged images along with the image with the tag mentioned in the \"docker pull\" command.\n\n**Are you currently working around this issue?**\nHow are you currently solving this problem?\nI am currently implementing life cycle policies for the repositories to delete un tagged images \n URL \n\n**Additional context**\nAnything else we should know?\nBelow is my replication scenario for more understanding of the issue :\n\n $ docker pull .dkr.ecr. .amazonaws.com/ecr-public/amazonlinux/amazonlinux:latest\n latest: Pulling from ecr-public/amazonlinux/amazonlinux\n xxx: Pull complete \n Digest: sha256:xxxxxxxxxxxxxxx\n Status: Downloaded newer image for .dkr.ecr. .amazonaws.com/ecr-public/amazonlinux/amazonlinux:latest\n .dkr.ecr. .amazonaws.com/ecr-public/amazonlinux/amazonlinux:latest\n\n$ aws ecr list-images --repository-name ecr-public/amazonlinux/amazonlinux --filter tagStatus=UNTAGGED --region \n{\n \"imageIds\": [\n {\n \"imageDigest\": \"sha256:xxxxxxxxxxxx\"\n },\n {\n \"imageDigest\": \"sha256:xxxxxxxxxxxx\"\n }\n ]\n}\n\n**Attachments**\nIf you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)","author_login":"sumanthst25","author_association":"NONE","created_at":"2021-12-30T11:01:40+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1107798579","fragment_type":"issue_comment","sequence":1,"text":"After a long time, is there still no progress on this issue?","author_login":"guvmao","author_association":"NONE","created_at":"2022-04-24T09:11:02+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477639371","fragment_type":"issue_comment","sequence":2,"text":"Has anyone found a solution to have only a tagged image in the ECR registry?","author_login":"dariocurr","author_association":"NONE","created_at":"2023-03-21T11:02:59+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1691735196","fragment_type":"issue_comment","sequence":3,"text":"I think I'm struggling with the same issue. I have to use lifecycle policy to delete untagged images. They are produced when using caching mechanism and size of image is the same as tagged image.","author_login":"ktomaszx","author_association":"NONE","created_at":"2023-08-24T13:58:07+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1711706845","fragment_type":"issue_comment","sequence":4,"text":"Hi everyone, apologies for such a long delay replying to this issue. I've just put an update on the issue tagged above, which I hope is helpful.\n\n URL \n\nI don't think there is a bug here, but definitely a UX improvement we can make. The ECR console shows all content - images, artifacts, indexes, etc. And we show it whether it's tagged or untagged content. So in this case, a multiplatform image with two supported ISAs shows up as three things in the view: one index and two images. Whether the underlying images are tagged or not is up to you - using BuildKit image are by default untagged.\n\nAll this said, we would like to make this a nicer and more obvious experience. We are considering making a change which would nest the related images under the index in the view, so you would by default see the tagged index, and then click to expand and see the referred images. We hope this will clarify things and make it easier to reason about.\n\nI'm going to close this one as a duplicate of #1596 since this isn't a bug related to PTC, but an enhancement for a better console view. Thanks!","author_login":"jlbutler","author_association":"NONE","created_at":"2023-09-08T13:50:00+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2010567931","fragment_type":"issue_comment","sequence":5,"text":"@jlbutler coming back to the creation of 2 images on ECR when pushing a multiplatform one. \n\nI think there is indeed a bug on ECR, not for the lifecycle as mentioned in the linked comments but rather due to mutability (or lack thereof) of the tags. \n\nIn my case, our repositories have `immutable` tags, so when trying to push a multiplatform image to ECR it fails with a `failed commit on ref unexpected status from put ...`. Checking the dockerd debug log I found out that the 2 ` ` images are the culprit as both have the \"same tag\" so ECR rejects pushing it twice.","author_login":"carocad","author_association":"NONE","created_at":"2024-03-20T20:30:12+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2010595120","fragment_type":"issue_comment","sequence":6,"text":"probably related to URL even though the linked PR over there says that the issue has been solved. In my case I am using `containerd` for building the multiplatform images not buildx with `docker-container`.","author_login":"carocad","author_association":"NONE","created_at":"2024-03-20T20:47:28+08:00","repo_name":"aws/containers-roadmap","issue_id":1091031544,"issue_number":1612,"issue_url":"https://github.com/aws/containers-roadmap/issues/1612","linked_issue_ids":[818862586],"is_known_query_context":false},{"document_id":"gh_issue_818862586","fragment_type":"issue_description","sequence":0,"text":"Failure pushing multi-arch images to Private AWS ECR with tag immutability enabled\nHi,\n\nAs per the instructions in TROUBLESHOOTING.md for the docker/build-push-action GitHub Action, I am opening an issue here. If this is not the right place, please let me know. This could be an issue with the ECR implementation of manifest lists.\n\n**TL;DR**, from Twitter:\n \n \n \n \n \n \n\n--- \n\nPushing a multi-arch (AMD, ARM) image to a private AWS ECR repository fails with `unexpected status: 400 Bad Request`. Pushing the same image to ECR, using containerd works.\n\nI created an example repository to show the issue and the relevant config/logs. You can see the GitHub Action failing here and you can see containerd working here.\n\nRelevant logs for the failure:\n\n2021-03-01T13:06:04.8482250Z #21 exporting to image\n2021-03-01T13:06:04.8483337Z #21 sha256:e8c613e07b0b7ff33893b694f7759a10d42e180f2b4dc349fb57dc6b71dcab00\n2021-03-01T13:06:07.6660224Z #21 pushing layers 3.3s done\n2021-03-01T13:06:07.6663629Z #21 pushing manifest for ***.dkr.ecr.***.amazonaws.com/bug-report:buildkit-dfa6ddf4705485840c392c397106932c03bf4961\n2021-03-01T13:06:08.4085934Z #21 pushing manifest for ***.dkr.ecr.***.amazonaws.com/bug-report:buildkit-dfa6ddf4705485840c392c397106932c03bf4961 0.7s done\n2021-03-01T13:06:08.4088745Z #21 ERROR: failed commit on ref \"manifest-sha256:672d30d763ba54a9c7f5169573b554f16efd3e8a25deb60413d259a29b204d76\": unexpected status: 400 Bad Request\n2021-03-01T13:06:08.4090060Z ------\n2021-03-01T13:06:08.4090863Z > exporting to image:\n2021-03-01T13:06:08.4091431Z ------\n2021-03-01T13:06:08.4093157Z error: failed to solve: rpc error: code = Unknown desc = failed commit on ref \"manifest-sha256:672d30d763ba54a9c7f5169573b554f16efd3e8a25deb60413d259a29b204d76\": unexpected status: 400 Bad Request\n2021-03-01T13:06:08.4160997Z ##[error]buildx call failed with: error: failed to solve: rpc error: code = Unknown desc = failed commit on ref \"manifest-sha256:672d30d763ba54a9c7f5169573b554f16efd3e8a25deb60413d259a29b204d76\": unexpected status: 400 Bad Request\n\nFunnily enough, if I go to the ECR repository and list the images, **there is** something pushed for both:\n\ncontainerd-dfa6ddf4705485840c392c397106932c03bf4961 01 Mar 2021 15:06:51 380.83MB sha256:d14dffbdc33c894279a22d6ff71671ab6d243a3b488563ad3360bdca781914a9\n 01 Mar 2021 15:06:50 370.38MB sha256:2fd9e0a11c41f27986d6c0bc6b949a76b85bb9ade27685c4200b87f1c84e991b\n 01 Mar 2021 15:06:50 380.83MB sha256:43c4984a930ced6b904820bcce54a85a31235cbd915ba3eaf45c31cc7810cf2b\nbuildkit-dfa6ddf4705485840c392c397106932c03bf4961 01 Mar 2021 15:06:08 380.83MB sha256:2eb8f205617af17c0af81e1871b43f2d69a59b3c723a9c5bf61258b1712b9411\n\n<img width=\"2466\" alt=\"Screenshot of the ECR console shxtwing the above text\" src=\" URL","author_login":"Vlaaaaaaad","author_association":"NONE","created_at":"2021-03-01T13:23:02+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_788144058","fragment_type":"issue_comment","sequence":1,"text":"@Vlaaaaaaad Can you try the following permutations for the buildx step please:\n\n* `driver-opts: image=moby/buildkit:v0.8.1`\n* `driver-opts: image=moby/buildkit:buildx-stable-1` (default)","author_login":"crazy-max","author_association":"COLLABORATOR","created_at":"2021-03-01T17:51:04+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_788153245","fragment_type":"issue_comment","sequence":2,"text":"@crazy-max sure!\n\nHere's `v0.8.1`: URL \nHere's `buildx-stable-1`: URL \n\nUnfortunately, the same error is reported. Let me know if the changes are not in the right place and I can re-test 🙂","author_login":"Vlaaaaaaad","author_association":"NONE","created_at":"2021-03-01T18:04:25+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_788158514","fragment_type":"issue_comment","sequence":3,"text":"@Vlaaaaaaad Ok thanks for your feedback. There is something odd and I think it's a scope issue on ECR. We have e2e tests with several registries to detect if there is something wrong early. And everything looks fine atm with our private ECR. Can you check if the the requirement to push to ECR with AmazonEC2ContainerRegistryPowerUser managed policy is ok? Thanks.","author_login":"crazy-max","author_association":"COLLABORATOR","created_at":"2021-03-01T18:11:52+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_788162297","fragment_type":"issue_comment","sequence":4,"text":"@Vlaaaaaaad Wonder if this is not linked to a specific region. Can you disclose it? WDYT @jtoberon?","author_login":"crazy-max","author_association":"COLLABORATOR","created_at":"2021-03-01T18:17:28+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_788167254","fragment_type":"issue_comment","sequence":5,"text":"@crazy-max hm... does your test ECR repo have \"_Immutable tags_\" enabled? I could not find a definition for the repo itself. The docker/build-push-action action works great on non-immutable repos.\n\nThe repo is in `eu-west-1`. \nI doubt there's a policy issue as the the IAM user used has **both** `AmazonEC2ContainerRegistryPowerUser` **and** the following policy attached:\n\n{\n \"Version\": \"2012-10-17\",\n \"Statement\": [\n {\n \"Sid\": \"VisualEditor0\",\n \"Effect\": \"Allow\",\n \"Action\": [\n \"ecr:GetDownloadUrlForLayer\",\n \"ecr:BatchGetImage\",\n \"ecr:CompleteLayerUpload\",\n \"ecr:UploadLayerPart\",\n \"ecr:InitiateLayerUpload\",\n \"ecr:BatchCheckLayerAvailability\",\n \"ecr:PutImage\"\n ],\n \"Resource\": \"arn:aws:ecr:eu-west-1:000000000000:repository/bug-report\"\n },\n {\n \"Sid\": \"VisualEditor1\",\n \"Effect\": \"Allow\",\n \"Action\": \"ecr:GetAuthorizationToken\",\n \"Resource\": \"*\"\n }\n ]\n}\n\nI can test another region if you think it would help!","author_login":"Vlaaaaaaad","author_association":"NONE","created_at":"2021-03-01T18:24:48+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_790329331","fragment_type":"issue_comment","sequence":6,"text":"I'm surprised you see it working in containerd. This has been a known error of containerd pusher that it repushes the tag multiple times. Maybe something has changed or containerd case is not quite the same.","author_login":"tonistiigi","author_association":"MEMBER","created_at":"2021-03-04T06:21:01+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_790335137","fragment_type":"issue_comment","sequence":7,"text":"Looking at the code I think containerd does a trick on pushing by tag and digest together. In that case tags are ignored for objects where digest does not match. I think we should be able to do the same thing.","author_login":"tonistiigi","author_association":"MEMBER","created_at":"2021-03-04T06:29:12+08:00","repo_name":"moby/buildkit","issue_id":818862586,"issue_number":2004,"issue_url":"https://github.com/moby/buildkit/issues/2004","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0396","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Can I beta test?","query_context":"Hi! Thanks so much for working on this. Could we put this on HACS to beta test it, even if it's not ready for HA Core yet? There are so many Snoo integration repos, but this one looks the most promising!","known_context_document_ids":["gh_issue_2798276709"],"reference_answer":"Yes! \n\nI have that figured out in the python library. and I can set the level very easily\n\nThe tricky thing is just that I need the current value which gets a bit weird in their event based system as it shares its value with other things - so HA would get confused when the level suddenly changes to 'sticky_white_noise' instead of 'level1'.\n\nThey have a 'up_transition' and a 'down_transition' entry in the event and I think I can use those to determine what the current level is reliably. I'll try to add it when i can!","answer_document_id":"gh_comment_2605765523","silver_evidence_path":["gh_comment_2603590459","gh_issue_2800620994","gh_comment_2605765523"],"evidence_issue_ids":[2798276709,2800620994],"source_repo_name":"Lash-L/python-snoo","source_issue_id":2798276709,"source_issue_number":13,"source_issue_url":"https://github.com/Lash-L/python-snoo/issues/13","target_repo_name":"Lash-L/snoo-hacs","target_issue_id":2800620994,"target_issue_number":1,"target_issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","reference_anchor_document_id":"gh_comment_2603590459","reference_answer_author":"Lash-L","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2941,"anchor_target_overlap":0.6471,"target_answer_overlap":0.1143},"issue_created_at":"2025-01-20T06:07:01+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2798276709","fragment_type":"issue_description","sequence":0,"text":"Can I beta test?\nHi! Thanks so much for working on this. Could we put this on HACS to beta test it, even if it's not ready for HA Core yet? There are so many Snoo integration repos, but this one looks the most promising!","author_login":"villasenor","author_association":"NONE","created_at":"2025-01-20T06:07:01+08:00","repo_name":"Lash-L/python-snoo","issue_id":2798276709,"issue_number":13,"issue_url":"https://github.com/Lash-L/python-snoo/issues/13","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2603339573","fragment_type":"issue_comment","sequence":1,"text":"Hi @villasenor - I'd be happy to make it easy to do a custom component for testing. I'll try to get something out today or tomorrow!","author_login":"Lash-L","author_association":"OWNER","created_at":"2025-01-20T23:05:58+08:00","repo_name":"Lash-L/python-snoo","issue_id":2798276709,"issue_number":13,"issue_url":"https://github.com/Lash-L/python-snoo/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603370982","fragment_type":"issue_comment","sequence":2,"text":"Hi Again @villasenor!\n\nI went ahead and did it\n\n URL \n\nAdded a few more platforms than what the core version has (as I can only do one platform at a time)\n\nThis is still missing some functionality and I will try to add it so that you can test it for me! \n\nNamely\n- Events when the baby cries\n- Turn snoo on\n- Turn snoo off\n- Set intensity level\n- Other various things to enable/disable.\n\nMy baby isn't actually born yet, so all my testing has been very limited, so i'm sure you will find bugs.","author_login":"Lash-L","author_association":"OWNER","created_at":"2025-01-20T23:46:32+08:00","repo_name":"Lash-L/python-snoo","issue_id":2798276709,"issue_number":13,"issue_url":"https://github.com/Lash-L/python-snoo/issues/13","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603590459","fragment_type":"issue_comment","sequence":3,"text":"Thanks so much for putting a HACS repo together so quickly! We use the Snoo a lot and I'm happy to test! I just tried setting it up and got an error - I opened an issue in the repo URL","author_login":"villasenor","author_association":"NONE","created_at":"2025-01-21T03:35:24+08:00","repo_name":"Lash-L/python-snoo","issue_id":2798276709,"issue_number":13,"issue_url":"https://github.com/Lash-L/python-snoo/issues/13","linked_issue_ids":[2800620994],"is_known_query_context":false},{"document_id":"gh_issue_2800620994","fragment_type":"issue_description","sequence":0,"text":"Setup Wizard Bug\nThanks so much for putting this up on HACS! I just tried setting it up after installing it as a custom repository in HACS. After going through the UI wizard in Integrations, I got an error that said the integration could not be loaded, try restarting Home Assistant or something like that.\n\nThis is all I find in the logs:\n\nLogger: homeassistant.setup\nSource: setup.py:269\nFirst occurred: 7:20:42 PM (1 occurrences)\nLast logged: 7:20:42 PM\n\nSetup failed for custom integration 'snoo': No setup or config entry setup function defined.\n\nI would have grabbed more debug for you but it looks like the integration doesn't support debug logging...apparently you need to add a line to the manifest? URL \n\nHappy to test more when you get time to look at this. Thanks!","author_login":"villasenor","author_association":"NONE","created_at":"2025-01-21T03:33:19+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603611685","fragment_type":"issue_comment","sequence":1,"text":"Sorry about that - oddly enough a file was incorrectly copied over from my dev instance! I just tested on my real instance and it worked, so it should work for you now as well!","author_login":"Lash-L","author_association":"OWNER","created_at":"2025-01-21T04:03:06+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2603652108","fragment_type":"issue_comment","sequence":2,"text":"That worked! Thanks! Here is what I get for the Snoo when it is stopped, which I assume is expected.\n\nImage","author_login":"villasenor","author_association":"NONE","created_at":"2025-01-21T04:52:15+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2604935559","fragment_type":"issue_comment","sequence":3,"text":"Yep! State should update as it runs. You can click on the entity to see everything it can be.\n\nSticky white noise is white noise without the snoo running\n\nTime left should(?) update as it times out from one level down. i.e. it goes up to level 3 for 480 seconds, the baby is calming down, it will set a timer for 480 seconds and then go down to level 2.","author_login":"Lash-L","author_association":"OWNER","created_at":"2025-01-21T14:46:36+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2605758851","fragment_type":"issue_comment","sequence":4,"text":"Awesome! Will we be able to change the Snoo level at some point in the future? (in other words, have you figured out the API spec for that?)","author_login":"villasenor","author_association":"NONE","created_at":"2025-01-21T21:18:10+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2605765523","fragment_type":"issue_comment","sequence":5,"text":"Yes! \n\nI have that figured out in the python library. and I can set the level very easily\n\nThe tricky thing is just that I need the current value which gets a bit weird in their event based system as it shares its value with other things - so HA would get confused when the level suddenly changes to 'sticky_white_noise' instead of 'level1'.\n\nThey have a 'up_transition' and a 'down_transition' entry in the event and I think I can use those to determine what the current level is reliably. I'll try to add it when i can!","author_login":"Lash-L","author_association":"OWNER","created_at":"2025-01-21T21:22:16+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755884888","fragment_type":"issue_comment","sequence":6,"text":"Hi @villasenor and @calvinbui\n\nAnd anyone else who is using this repository I'm not aware of. I'm going to archive this repository as all the features here + a event entity that will let you know if your baby is crying! Have been added to the core integration as of the 2025.4 release! Please switch over!","author_login":"Lash-L","author_association":"OWNER","created_at":"2025-03-26T22:30:46+08:00","repo_name":"Lash-L/snoo-hacs","issue_id":2800620994,"issue_number":1,"issue_url":"https://github.com/Lash-L/snoo-hacs/issues/1","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0397","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Streaming results: error appears as a result row?","query_context":"### Describe the bug\n\nWhen using `.stream()` to stream rows as JSON, if an error occurs mid-query, the \"exception\" appears as a row in the results. This effectively means you need to scan the results for a row containing only `\"exception\"`. This is costly (not much, but every bit counts) and silly.\n\nIf you have a scenario where the query legitimately returns a column named `exception`, then...well you get the point.\n\nInitially I used `StreamReadable.on('error', ...)` expecting that listener to be invoked, but it wasn't. On one hand, I guess it makes sense since it wasn't a stream/read related error, but the fact that errors aren't surfaced in a first-class way is a design limitation.\n\n### Steps to reproduce\n\nRun a query that will produce an error mid-way through, i.e.\n\nsql\nSELECT \n number, \n if(number > 420000, throwIf(1, 'BOOM!'), number) AS value\nFROM \n numbers(1000000)\n\nStream that via `ClickHouseClient.query().stream()`. You'll see the row with `\"exception\"` appears among the results.\n\n### Expected behaviour\n\nErrors should be surfaced in a more first-class way. Proposals:\n\n- Ideally each data chunk of results should have an envelope indicating whether an error occurred. That way you would only need to check for an error once per chunk, rather than once per row. Think millions+ of rows, think compression enabled -- it's only a handful of chunks. This would be a difference maker -- and much more elegant.\n- Consider having the SDK intercept the error (in a performant way, one way or another) and surface it via the `StreamReadable.on('error', ...)` listener.\n- Dirt simple: instead of `\"text\"` you could distinguish it as `\"error\"`. This would still require checking each row, far from ideal, but a step in the right direction.\n\nThank you!!","known_context_document_ids":["gh_issue_2792692569"],"reference_answer":"ClickHouse seems to attach `X-ClickHouse-Exception-Code` header, which can be used to detect the problem. see URL and URL","answer_document_id":"gh_comment_2441111408","silver_evidence_path":["gh_comment_2596079142","gh_issue_2551311750","gh_comment_2441111408"],"evidence_issue_ids":[2792692569,2551311750],"source_repo_name":"ClickHouse/clickhouse-js","source_issue_id":2792692569,"source_issue_number":378,"source_issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/378","target_repo_name":"ClickHouse/clickhouse-js","target_issue_id":2551311750,"target_issue_number":332,"target_issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/332","reference_anchor_document_id":"gh_comment_2596079142","reference_answer_author":"mshustov","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1532,"anchor_target_overlap":0.4472,"target_answer_overlap":0.2222},"issue_created_at":"2025-01-16T13:00:44+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2792692569","fragment_type":"issue_description","sequence":0,"text":"Streaming results: error appears as a result row\n### Describe the bug\n\nWhen using `.stream()` to stream rows as JSON, if an error occurs mid-query, the \"exception\" appears as a row in the results. This effectively means you need to scan the results for a row containing only `\"exception\"`. This is costly (not much, but every bit counts) and silly.\n\nIf you have a scenario where the query legitimately returns a column named `exception`, then...well you get the point.\n\nInitially I used `StreamReadable.on('error', ...)` expecting that listener to be invoked, but it wasn't. On one hand, I guess it makes sense since it wasn't a stream/read related error, but the fact that errors aren't surfaced in a first-class way is a design limitation.\n\n### Steps to reproduce\n\nRun a query that will produce an error mid-way through, i.e.\n\nsql\nSELECT \n number, \n if(number > 420000, throwIf(1, 'BOOM!'), number) AS value\nFROM \n numbers(1000000)\n\nStream that via `ClickHouseClient.query().stream()`. You'll see the row with `\"exception\"` appears among the results.\n\n### Expected behaviour\n\nErrors should be surfaced in a more first-class way. Proposals:\n\n- Ideally each data chunk of results should have an envelope indicating whether an error occurred. That way you would only need to check for an error once per chunk, rather than once per row. Think millions+ of rows, think compression enabled -- it's only a handful of chunks. This would be a difference maker -- and much more elegant.\n- Consider having the SDK intercept the error (in a performant way, one way or another) and surface it via the `StreamReadable.on('error', ...)` listener.\n- Dirt simple: instead of `\"text\"` you could distinguish it as `\"error\"`. This would still require checking each row, far from ideal, but a step in the right direction.\n\nThank you!!","author_login":"dcheckoway","author_association":"NONE","created_at":"2025-01-16T13:00:44+08:00","repo_name":"ClickHouse/clickhouse-js","issue_id":2792692569,"issue_number":378,"issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/378","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2596079142","fragment_type":"issue_comment","sequence":1,"text":"I think this is the same issue as this one: URL The complication there is that a mid-stream error appears as part of the results, _and_ it is also format-dependant. \n\nUnfortunately, the HTTP interface fixes in 24.11+ did not improve the situation in these scenarios.\n\nWe are currently discussing internally what could be the best approach there, as there are a few major complications:\n\n- The client needs to somehow parse the error from the response body, as due to HTTP protocol limitations, the exception can only go there if the error occurs after the response headers are sent, as it is not possible to send additional headers during the streaming. The way the error is printed by CH in the body stream is format dependent, e.g., `JSONEachRow` will have an object with an `exception` field, `JSONCompactEachRow` = just an exception as a single element in the array, etc., etc. The most complicated part is streaming into files with formats like `Parquet`.\n- There are awkward corner cases like this (if someone has a field named `exception`):\n \n\n curl \" URL --data-binary \"select throwIf(number = 5, 'There was an error in the stream!') AS _, randomPrintableASCII(20) AS exception from system.numbers limit 30000 SETTINGS max_block_size=1 FORMAT JSONEachRow\"\n \n {\"_\":0,\"exception\":\"&vn]M\\\"\\/B]c=Z1FFF\\\\u,Z\"}\n {\"_\":0,\"exception\":\"\\\"y}oIU\\/ ~Q47B3hg>928\"}\n {\"exception\": \"Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 5_UInt8) :: 3, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 5_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.12.2.29 (official build))\"}\n \n\nCurrently, the only reliable way to avoid this is to use the `wait_end_of_query=1` setting, which causes the response to be buffered in memory or temp files on the server side before the streaming starts; in this case, the error will be thrown at the very beginning.\n\nts\nimport { createClient } from '@clickhouse/client'\n\nvoid (async () => {\n const client = createClient()\n try {\n let rowsCount = 0\n const rs = await client.query({\n query: `\n SELECT\n number,\n if(number > 420000, throwIf(1, 'Intentional Error Triggered'), number) AS value\n FROM\n numbers(1000000)\n `,\n format: 'JSONEachRow',\n clickhouse_settings: {\n max_block_size: '1000',\n wait_end_of_query: 1,\n },\n }) // if(greater(__table1.number, 420000_UInt32), throwIf(1_UInt8, 'Intentional Error Triggered'_String), __table1.number) UInt64 : 2'. \n at parseError (/home/serge/work/clickhouse-js/examples/node_modules/packages/client-common/src/error/parse_error.ts:30:12)\n at ClientRequest.onResponse (/home/serge/work/clickhouse-js/examples/node_modules/packages/client-node/src/connection/node_base_connection.ts:474:28)\n at processTicksAndRejections (node:internal/process/task_queues:95:5) {\n code: '395',\n type: 'FUNCTION_THROW_IF_VALUE_IS_NON_ZERO'\n}\n\nHowever, this might not be an option if the result sets are too large.","author_login":"slvrtrn","author_association":"CONTRIBUTOR","created_at":"2025-01-16T15:48:37+08:00","repo_name":"ClickHouse/clickhouse-js","issue_id":2792692569,"issue_number":378,"issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/378","linked_issue_ids":[2551311750],"is_known_query_context":false},{"document_id":"gh_comment_2596148094","fragment_type":"issue_comment","sequence":2,"text":"Thanks for replying @slvrtrn . We don't really need the error to be thrown at the beginning of the query. It might process and return 1B rows before encountering the row with the error. We'd just like the error to be surfaced _if and when_ it happens.\n\nWe have huge result sets, and I can't imagine buffering is practical -- not to mention, we really do want results to start flowing as soon as possible, since \"time to first byte\" is critical for our use case.\n\nI completely understand the factors you mentioned. This isn't trivial. I'm glad you & others are already considering it. Thank you!!","author_login":"dcheckoway","author_association":"NONE","created_at":"2025-01-16T16:16:37+08:00","repo_name":"ClickHouse/clickhouse-js","issue_id":2792692569,"issue_number":378,"issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/378","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2551311750","fragment_type":"issue_description","sequence":0,"text":"An error occurred in a middle of a select stream processing should be thrown\nMin repro (note: `wait_end_of_query` setting is not used):\n\nts\nimport { createClient } from '@clickhouse/client'\n\nvoid (async () => {\n const client = createClient()\n let rowsCount = 0\n try {\n const resultSet = await client.query({\n query: `\n SELECT\n throwIf(number = 2, 'There was an error in the stream!') AS e,\n randomPrintableASCII(1) AS s\n FROM system.numbers\n LIMIT 2000\n `,\n format: 'JSONEachRow',\n clickhouse_settings: {\n max_block_size: '1',\n },\n })\n console.log(await resultSet.json())\n } catch (err) {\n console.error(`Got ${rowsCount} rows before an error:`, err)\n }\n await client.close()\n})()\n\nPrints:\n\n[\n { e: 0, s: '}' },\n {\n exception: \"Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 2_UInt8) :: 3, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 2_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\"\n }\n]\n\nHowever, the client should handle and throw during the stream consumption instead of providing the error as a row.\n\nCaveat: the stream error representation depends on the format.\n\nFor example:\n- `JSON`, `JSONCompact`, `JSONStrings`, `JSONCompactStrings` - the exception resides in the `exception` field and can be extracted from there\n \n\n {\n \"meta\":\n [\n {\n \"name\": \"throwIf(equals(number, 2), 'There was an error in the stream!')\",\n \"type\": \"UInt8\"\n },\n {\n \"name\": \"randomPrintableASCII(2000)\",\n \"type\": \"String\"\n }\n ],\n \n \"data\":\n [\n \n ],\n \n \"rows\": 0,\n \n \"exception\": \"Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 2_UInt8) :: 3, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 2_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\"\n }\n \n\n- JSONObjectEachRow behaves similarly to JSON\n \n\n curl \" URL --data-binary \"select throwIf(number = 10, 'There was an error in the stream!') AS e, randomPrintableASCII(2) AS s from system.numbers limit 3000 SETTINGS max_block_size=1 FORMAT JSONObjectEachRow\"\n {\n \"row_1\": {\"e\":0,\"s\":\"hK\"},\n \"row_2\": {\"e\":0,\"s\":\"RT\"},\n \"row_3\": {\"e\":0,\"s\":\"dT\"},\n \"row_4\": {\"e\":0,\"s\":\"JU\"},\n \"row_5\": {\"e\":0,\"s\":\"W=\"},\n \"row_6\": {\"e\":0,\"s\":\"a&\"},\n \"exception\": \"Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 10_UInt8) :: 3, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 10_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\"\n }\n \n\n- CSV, TSV - those formats contain the error in the last line\n \n\n curl \" URL --data-binary \"select throwIf(number = 2, 'There was an error in the stream!'), randomPrintableASCII(2) from system.numbers limit 3 SETTINGS max_block_size=1 FORMAT TSV\" \n 0 NK\n Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 2_UInt8) :: 4, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 2_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\n \n\n- JSONEachRow\n \n\n curl \" URL --data-binary \"select throwIf(number = 2, 'There was an error in the stream!') AS e, randomPrintableASCII(2) AS s from system.numbers limit 3 SETTINGS max_block_size=1 FORMAT JSONEachRow\"\n {\"e\":0,\"s\":\"4S\"}\n {\"exception\": \"Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 2_UInt8) :: 4, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 2_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\"}\n \n\n- JSONCompact*EachRow\n \n\n curl \" URL --data-binary \"select throwIf(number = 5, 'There was an error in the stream!') AS e, randomPrintableASCII(2) AS s from system.numbers limit 3000 SETTINGS max_block_size=1 FORMAT JSONCompactEachRow\"\n [0, \"$,\"]\n [\"Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 5_UInt8) :: 3, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 5_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\"]\n \n\n- Worst case: `JSONColumnsWithMetadata`\n \n\n curl \" URL --data-binary \"select throwIf(number = 200, 'There was an error in the stream!'), randomPrintableASCII(2000) from system.numbers limit 300 SETTINGS max_block_size=1 FORMAT JSONColumnsWithMetadata\"\n {\n \"meta\":\n [\n {\n \"name\": \"throwIf(equals(number, 200), 'There was an error in the stream!')\",\n \"type\": \"UInt8\"\n },\n {\n \"name\": \"randomPrintableASCII(2000)\",\n \"type\": \"String\"\n }\n ]Code: 395. DB::Exception: There was an error in the stream!: while executing 'FUNCTION throwIf(equals(__table1.number, 200_UInt8) :: 3, 'There was an error in the stream!'_String :: 2) -> throwIf(equals(__table1.number, 200_UInt8), 'There was an error in the stream!'_String) UInt8 : 0'. (FUNCTION_THROW_IF_VALUE_IS_NON_ZERO) (version 24.8.3.59 (official build))\n \n\n- Parquet: probably won't be able to catch it, unless we add `parquet-wasm` as a package dependency to parse the last row","author_login":"slvrtrn","author_association":"NONE","created_at":"2024-09-26T18:50:20+08:00","repo_name":"ClickHouse/clickhouse-js","issue_id":2551311750,"issue_number":332,"issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/332","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2441111408","fragment_type":"issue_comment","sequence":1,"text":"ClickHouse seems to attach `X-ClickHouse-Exception-Code` header, which can be used to detect the problem. see URL and URL","author_login":"mshustov","author_association":"MEMBER","created_at":"2024-10-28T09:58:00+08:00","repo_name":"ClickHouse/clickhouse-js","issue_id":2551311750,"issue_number":332,"issue_url":"https://github.com/ClickHouse/clickhouse-js/issues/332","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0398","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Just some feedback and a litte warning :)?","query_context":"Hi,\n\nfirst of all I love this project. Fantastic work.\n\nI would like to give some feedback about my problems getting it to run on my multisplit configuration.\n1x oudoor \"SCM 45 ZS-W\" and 2x indoor units one \"SRK 25 ZS-W and one SRK 35 ZS-W\".\n\nThe OpData for the outdoor unit is the same on both, but OpData for indoor unit differs. I think that's totally okay.\n\nI had some problems getting MHI-AC-Ctrl to work, first I had a little mistake in defining MQTT topic, but my main problem was different.\nI always got a WDT Soft reset/boot loop. I tried diffenet things on the software side including the freqency messurement INO. Nothing helped.\n\nHere are the errors I got:\n\n- frequency was correct (3.2 kHz), boot loop\n- frequency was wrong (1.7 kHz), boot loop\n- frequency was correct, connect to wifi, boot loop\n- frequency was correct, connect to wifi, connect to mqtt, boot loop\n- frequency was correct, connect to wifi, connect to mqtt, publich data (Yeah!), boot loop (That happend only ONCE an then never again)\n- finally my ESP was unable to connect to Wifi again, fully erased, no change\n\nAll of them WITHOUT changing anythin on the hardware! Then I decided to have a more comfortable access to the serial console by connection a second ESP with \"esp-link\" to RX/TX (Serial2 WIFI) instead of laying on the floor with a laptop ...\n\nAs I got 3 WEMOS from china (labeld as \"ESP12-F\") I was thinking that would be easy. Well I was wrong. \"esp-link\" also boot-looped on my WEMOS, on all 3 (!). WTF?! I flashed ESPEasy and Tasmoto, just for reference, and they seems to work.\nWell taht took me \"Nahe einem Nervenzusammenbruch\", but okay, I had one older NodeMCU and some naked ESP8266, lets try them.\n\nThe NodeMCU just worked fine, no boot loop. Okay, lets go a step further, I desoldered the \"ESP12-F\" from the WEMOS and replaced it by a naked ESP8266 ... and ... it workes fine. And it is still working!\n\nLong story short, be aware that there are maybe some cheap WEMOS D1 mini with \"ESP12-F\" which are NOT working for MHI-AC-Ctrl. Don't ask me why, but that's what I found out.\n\nMay I try to sniff some SPI packets next to see if \"3D Auto\" or some other function reflected on SPI as well.","known_context_document_ids":["gh_issue_1579897217"],"reference_answer":"If you have a logic analyser this will help.\nOtherwise maybe with the oscilloscoop you can monitor the behavior of the MISO line at the board without the esp. It should be steady 0 Volt. \nOtherwise strip the program to only measure the frequency repeatly and look with the oscilloscoop.","answer_document_id":"gh_comment_1646877376","silver_evidence_path":["gh_comment_1668402137","gh_issue_1816886894","gh_comment_1646877376"],"evidence_issue_ids":[1579897217,1816886894],"source_repo_name":"absalom-muc/MHI-AC-Ctrl","source_issue_id":1579897217,"source_issue_number":134,"source_issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/134","target_repo_name":"absalom-muc/MHI-AC-Ctrl","target_issue_id":1816886894,"target_issue_number":151,"target_issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","reference_anchor_document_id":"gh_comment_1668402137","reference_answer_author":"glsf91","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.2857,"target_answer_overlap":0.1364},"issue_created_at":"2023-02-10T15:32:48+08:00","valid_comment_count":11,"fragments":[{"document_id":"gh_issue_1579897217","fragment_type":"issue_description","sequence":0,"text":"Just some feedback and a litte warning :)\nHi,\n\nfirst of all I love this project. Fantastic work.\n\nI would like to give some feedback about my problems getting it to run on my multisplit configuration.\n1x oudoor \"SCM 45 ZS-W\" and 2x indoor units one \"SRK 25 ZS-W and one SRK 35 ZS-W\".\n\nThe OpData for the outdoor unit is the same on both, but OpData for indoor unit differs. I think that's totally okay.\n\nI had some problems getting MHI-AC-Ctrl to work, first I had a little mistake in defining MQTT topic, but my main problem was different.\nI always got a WDT Soft reset/boot loop. I tried diffenet things on the software side including the freqency messurement INO. Nothing helped.\n\nHere are the errors I got:\n\n- frequency was correct (3.2 kHz), boot loop\n- frequency was wrong (1.7 kHz), boot loop\n- frequency was correct, connect to wifi, boot loop\n- frequency was correct, connect to wifi, connect to mqtt, boot loop\n- frequency was correct, connect to wifi, connect to mqtt, publich data (Yeah!), boot loop (That happend only ONCE an then never again)\n- finally my ESP was unable to connect to Wifi again, fully erased, no change\n\nAll of them WITHOUT changing anythin on the hardware! Then I decided to have a more comfortable access to the serial console by connection a second ESP with \"esp-link\" to RX/TX (Serial2 WIFI) instead of laying on the floor with a laptop ...\n\nAs I got 3 WEMOS from china (labeld as \"ESP12-F\") I was thinking that would be easy. Well I was wrong. \"esp-link\" also boot-looped on my WEMOS, on all 3 (!). WTF?! I flashed ESPEasy and Tasmoto, just for reference, and they seems to work.\nWell taht took me \"Nahe einem Nervenzusammenbruch\", but okay, I had one older NodeMCU and some naked ESP8266, lets try them.\n\nThe NodeMCU just worked fine, no boot loop. Okay, lets go a step further, I desoldered the \"ESP12-F\" from the WEMOS and replaced it by a naked ESP8266 ... and ... it workes fine. And it is still working!\n\nLong story short, be aware that there are maybe some cheap WEMOS D1 mini with \"ESP12-F\" which are NOT working for MHI-AC-Ctrl. Don't ask me why, but that's what I found out.\n\nMay I try to sniff some SPI packets next to see if \"3D Auto\" or some other function reflected on SPI as well.","author_login":"HeadCrash66","author_association":"NONE","created_at":"2023-02-10T15:32:48+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1579897217,"issue_number":134,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/134","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1651772402","fragment_type":"issue_comment","sequence":1,"text":"i my case Wifi Problem and D1 mini was a to small Cap on 3.3V on some D1 Mini PCB \ngot Spikes on 3.3V during WLAN data transfer\nso its a good Idea to add a extra minimal 10uF CAP : 3.3V / GND \nsymptom:: Connect to WLAN fail , loss connection","author_login":"melmager","author_association":"NONE","created_at":"2023-07-26T13:08:19+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1579897217,"issue_number":134,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/134","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1668402137","fragment_type":"issue_comment","sequence":2,"text":"@HeadCrash66 have you solved it already or found a workarround, you might want to look into #151","author_login":"SmOeL-swdev","author_association":"NONE","created_at":"2023-08-07T18:39:15+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1579897217,"issue_number":134,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/134","linked_issue_ids":[1816886894],"is_known_query_context":false},{"document_id":"gh_issue_1816886894","fragment_type":"issue_description","sequence":0,"text":"MISO not zero during startup in software versions 2 and above\nName of my AC: MHI SRK50ZJX-S1\nUsed MHI-AC-Ctrl HW: 2.2\nUsed MHI-AC-Ctrl SW: 2.6\n\nI have a strange issue. I have ordered the latest hardware pcb, programmed a ESP with the latest software, and it didn`t work. The ESP keeps getting rebooted due to a too high MISO frequency.\nSee the serial output here;\nStarting MHI-AC-Ctrl v2.6\nCPU frequency[Hz]=160000000\nESP.getCoreVersion()=3.1.2\nESP.getSdkVersion()=2.2.2-dev(38a443e)\nESP.checkFlashCRC()=1\nMeasure frequency for SCK, MOSI and MISO pin\nSCK frequency=2400Hz (expected: >3000Hz) out of range!\nMOSI frequency=300Hz (expected: 3000Hz) out of range!\nMOSI frequency=315Hz (expected: <SCK frequency) o.k.\nMISO frequency=0Hz (expected: ~0Hz) o.k.\nFound 0 DS18xxx family devices.\nUnable to find address for Device 0\nDevice 0 Address: 0000000000000000\n........ connected to xxx, IP address: xxx\nOTA Ready, IP address: xxx\nAttempting MQTT connection...connected\nWrong MOSI signature: 0x6C 0x80 0x04 or checksum received!\n\nSo the main question boils down to, how can the measured MISO frequency be higher when I use the latest software versions?\n\nIt`s nice to have it working, but keeping up with the newer versions would be preferrable.","author_login":"NickyNL","author_association":"NONE","created_at":"2023-07-22T20:34:42+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646816363","fragment_type":"issue_comment","sequence":1,"text":"I have tried two more things;\n\n- With software version 2.6, just for testing i disconnected only the MISO pin between the pcb and the airco.\n Doing this resulted in a MISO readout of zero, a voltage on the MISO pin on the airco side of zero,\n And the data worked only partially. It only send out data from the indoor unit as far as I could see.\n- In software version 2.6, I commented out the while(1) so the software wouldn`t reboot, to see if for example MISO would later \n on become zero.\n After this the program seems to work and I get all the data. Also sending commands works. However the MISO does not go \n to zero.\n And also the serial output is clogging with \"mhi_ac_ctrl_core.loop error: -4\"","author_login":"NickyNL","author_association":"NONE","created_at":"2023-07-23T11:32:04+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646822288","fragment_type":"issue_comment","sequence":2,"text":"Removing the while(1) can damage the ac or your board as mentioned in Troubleshooting.md\nThere is no difference in measuring the pins in 1.4 and 2.6.\nIf the board is connected to your ac with a cable, maybe it is picking up some noise.","author_login":"glsf91","author_association":"COLLABORATOR","created_at":"2023-07-23T12:02:30+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646824017","fragment_type":"issue_comment","sequence":3,"text":"And please re-check your PCB if there is a short between MISO signal and another signal, maybe a bridge due to poor PCB quality or by solder. I suggest a loupe.","author_login":"absalom-muc","author_association":"OWNER","created_at":"2023-07-23T12:09:20+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646874582","fragment_type":"issue_comment","sequence":4,"text":"Thanks for your responses.\nYes I did read the disclaimer about damaging, I knew it was a bit risky.\n\nAlso I did look at #22 which is about the wrong level shifter,\nI also looked at #26 and #84, but none seems to display exact behavior to what I am seeing.\n\nSo picking up some noise would sound reasonable... However, it does not explain the difference in 1.4 and 2.6.\n\nAlso a fault on the PCB would not explain that difference if you ask me.\n\nI have though measured by multimeter,\nAnd the only resistive values I saw where 10k/20k due to the pull/up/down resistors on the level shifter.\nMeasureable between ground and SCK/MOSI/MISO is some 10k/20k, and between SCK/MOSI/MISO also some 10k/20k.\nBetween VCC(12V) and SCK/MOSI/MISO it`s all measuring mega ohms.\n\nI do have oscilliscopes and stuff to measure things, but unsure at the moment of what to measure.","author_login":"NickyNL","author_association":"NONE","created_at":"2023-07-23T15:51:10+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646877376","fragment_type":"issue_comment","sequence":5,"text":"If you have a logic analyser this will help.\nOtherwise maybe with the oscilloscoop you can monitor the behavior of the MISO line at the board without the esp. It should be steady 0 Volt. \nOtherwise strip the program to only measure the frequency repeatly and look with the oscilloscoop.","author_login":"glsf91","author_association":"COLLABORATOR","created_at":"2023-07-23T16:04:02+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1646910879","fragment_type":"issue_comment","sequence":6,"text":"I don`t have a logic analyser readily available.\nWhen I have some more time I`ll sure hookup a scope to at least look what the signals look like.\n\nI just measured with my multimeter, the MISO pin reads a steady 2,6V when the PCB is connected to the airco. Even without the ESP on it. Without the PCB so measuring just the airco pins it the MISO pin reads 0V.\nSo at least this voltage must be coming from the on the PCB itself (including level shifter).\n\nAm wondering now if it is due to the resistances on the level shifter.\nSo measuring with my scope I should be able te verify if it is a voltage diveded copy of SCK and/or MOSI.\nWould suspect SCK since that is 5V.\n(Although I am wondering why nobody else had the issue)\nThese are the level shifters I`ve used; URL \n\nI`ll update next when I`ve had time to hook up a scope!","author_login":"NickyNL","author_association":"NONE","created_at":"2023-07-23T17:56:18+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1665885780","fragment_type":"issue_comment","sequence":7,"text":"@NickyNL have you managed to solve the issue? I was facing the same issue. I have made a complete different hardware version though (manually soldered with stuff I had laying arround).\nInitially I used the same pinning as described in the repository. \nI solved the issue by changing the MISO pin to GPIO16 (Seems like internal crosstalk of the ESP). \nI have created al sorts of filtering initially that didn't help, changing pin did. You might need some changing when using the PCB version.\n\nGroeten","author_login":"SmOeL-swdev","author_association":"NONE","created_at":"2023-08-04T16:29:13+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1665991051","fragment_type":"issue_comment","sequence":8,"text":"@SmOeL-swdev thanks for the tip! Will definitely try swapping to that pin soon.\n\nIt also was a good trigger that I still had to do something.\nAs it is \"working\" as is, it sometimes gets forgotten.\n\nSo, hereby at least some captures with a oscilloscope;\nMeasured straight on the pins on the pcb coming from the AC.\nWith the ESP on the pcb as well.\n\nRed MISO Blue SCK (2)\nRed MISO\nRed MISO Blue SCK","author_login":"NickyNL","author_association":"NONE","created_at":"2023-08-04T18:04:04+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1666523246","fragment_type":"issue_comment","sequence":9,"text":"I`ve given your trick a try, and it works!\nSwapped MISO from GPIO12 to GPIO16 and now the MISO reading remains 0!\nReimplementing the MISO check on boot and everything is okay now.\n\nCudos to @SmOeL-swdev!\nOf course I live and work in probably the same country, the Netherlands :)","author_login":"NickyNL","author_association":"NONE","created_at":"2023-08-05T14:38:32+08:00","repo_name":"absalom-muc/MHI-AC-Ctrl","issue_id":1816886894,"issue_number":151,"issue_url":"https://github.com/absalom-muc/MHI-AC-Ctrl/issues/151","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0399","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Feature] Context aware alias interpretation?","query_context":"I managed to spend two hours trying to solve a \"bug\" with my keyboard specific mappings. I tried to define a device/application specific \"leader\" key in this manner:\n\nperl\n[default]\n Leader = Comma !150ms\n\n[device=/Keychron K15 Pro/]\n Leader = EscMiddle !150ms # Esc between a split spacebar\n\n[device=/Keychron K3 Pro/]\n Leader = Comma !150ms\n\n[class=\"slack\"]\n Leader F >> slack_switch_channel\n Leader 1 >> slack_goto_workspace1\n Leader 2 >> slack_goto_workspace2\n Leader H >> slack_goto_home\n Leader A >> slack_goto_activity\n\nInitially I thought the device specific aliases aren't applying at all as the leader key was `Comma` regardless of the keyboard. I removed the default block which didn't help. I then made sure the device specific blocks are handled with a `T >> 'K3' and 'K15'` debug print which worked as expected.\n\nI then thought the issue is with having both keyboards connected as it's just for testing anyway, but after disconnecting my K3 Pro, I still got `Comma` as the leader. I made sure to check `xinput list` to verify only K15 Pro is visible and just in case restarted both the daemon and the app. No diffference.\n\nI then replaced the block for K3 with this:\n\nperl\n[device=\"Foobar\"]\n Leader = Comma !150ms\n\n...but still got the `Leader` reassigned. (A bug perhaps?).\n\nThe workaround I found was to name the leader key differently and duplicate the keymappings separately for each keyboard which is not an ideal solution as my config file seems to grow at a rapid pace. :sweat_smile:\n\nSo, it'd be great if the aliases could be context aware in some way. I can see it gettting messy given on how the config works now, so let's say device specific context awareness would be the most useful (IMHO). But just skipping the non-matching sections would be a slight* improvement.\n\n*) I assume most dual keyboard use cases would include differentiating an external keyboard and a laptop keyboard which isn't exactly simple to disconnect. Another relatively common use case could be sharing a config file between two or more computers.","known_context_document_ids":["gh_issue_2066063121"],"reference_answer":"Yes, multiple devices with identical names should not cause problems.\nMaybe you can start `keymapperd` with `-v` and check if the devices are un/grabbed as expected when plugging in/out.","answer_document_id":"gh_comment_1887779135","silver_evidence_path":["gh_comment_1889761686","gh_issue_1385513000","gh_comment_1887779135"],"evidence_issue_ids":[2066063121,1385513000],"source_repo_name":"houmain/keymapper","source_issue_id":2066063121,"source_issue_number":97,"source_issue_url":"https://github.com/houmain/keymapper/issues/97","target_repo_name":"houmain/keymapper","target_issue_id":1385513000,"target_issue_number":41,"target_issue_url":"https://github.com/houmain/keymapper/issues/41","reference_anchor_document_id":"gh_comment_1889761686","reference_answer_author":"houmain","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.1026,"target_answer_overlap":0.1429},"issue_created_at":"2024-01-04T17:29:12+08:00","valid_comment_count":42,"fragments":[{"document_id":"gh_issue_2066063121","fragment_type":"issue_description","sequence":0,"text":"[Feature] Context aware alias interpretation\nI managed to spend two hours trying to solve a \"bug\" with my keyboard specific mappings. I tried to define a device/application specific \"leader\" key in this manner:\n\nperl\n[default]\n Leader = Comma !150ms\n\n[device=/Keychron K15 Pro/]\n Leader = EscMiddle !150ms # Esc between a split spacebar\n\n[device=/Keychron K3 Pro/]\n Leader = Comma !150ms\n\n[class=\"slack\"]\n Leader F >> slack_switch_channel\n Leader 1 >> slack_goto_workspace1\n Leader 2 >> slack_goto_workspace2\n Leader H >> slack_goto_home\n Leader A >> slack_goto_activity\n\nInitially I thought the device specific aliases aren't applying at all as the leader key was `Comma` regardless of the keyboard. I removed the default block which didn't help. I then made sure the device specific blocks are handled with a `T >> 'K3' and 'K15'` debug print which worked as expected.\n\nI then thought the issue is with having both keyboards connected as it's just for testing anyway, but after disconnecting my K3 Pro, I still got `Comma` as the leader. I made sure to check `xinput list` to verify only K15 Pro is visible and just in case restarted both the daemon and the app. No diffference.\n\nI then replaced the block for K3 with this:\n\nperl\n[device=\"Foobar\"]\n Leader = Comma !150ms\n\n...but still got the `Leader` reassigned. (A bug perhaps?).\n\nThe workaround I found was to name the leader key differently and duplicate the keymappings separately for each keyboard which is not an ideal solution as my config file seems to grow at a rapid pace. :sweat_smile:\n\nSo, it'd be great if the aliases could be context aware in some way. I can see it gettting messy given on how the config works now, so let's say device specific context awareness would be the most useful (IMHO). But just skipping the non-matching sections would be a slight* improvement.\n\n*) I assume most dual keyboard use cases would include differentiating an external keyboard and a laptop keyboard which isn't exactly simple to disconnect. Another relatively common use case could be sharing a config file between two or more computers.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-04T17:29:12+08:00","repo_name":"houmain/keymapper","issue_id":2066063121,"issue_number":97,"issue_url":"https://github.com/houmain/keymapper/issues/97","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1889761686","fragment_type":"issue_comment","sequence":1,"text":"Hi, sorry I did not answer earlier.\nYes, the aliases are not context aware. They are applied when the configuration is loaded.\nMaking them context aware would be quite complicated. I am not sure if I should attempt it.\n\nThe configuration you posted in #41:\n\n[modifier=\"!AutoShift\"]\n toggle_autoshift >> $(show_indicator) ^ AutoShift\n\n[modifier=\"AutoShift\"]\n toggle_autoshift >> $(hide_indicator) ^ AutoShift\n\nI tested it with the following configuration, which should behave the same (A/B are output instead of your terminal commands) but I did not see a problem :\n\ntoggle_autoshift = F1\nAutoShift = Virtual1\n\n[modifier=\"!AutoShift\"]\n toggle_autoshift >> A ^ AutoShift\n\n[modifier=\"AutoShift\"]\n toggle_autoshift >> B ^ AutoShift\n\nThis can also be achived this way (the toggling of the virtual key can also trigger output):\n\ntoggle_autoshift = F1\nAutoShift = Virtual1\n\ntoggle_autoshift >> AutoShift ^\nAutoShift >> A ^ B","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-12T18:24:04+08:00","repo_name":"houmain/keymapper","issue_id":2066063121,"issue_number":97,"issue_url":"https://github.com/houmain/keymapper/issues/97","linked_issue_ids":[1385513000],"is_known_query_context":false},{"document_id":"gh_comment_1890759476","fragment_type":"issue_comment","sequence":2,"text":"My simplified example failed to make it apparent, `toggle_autoshift` was not defined as an alias, only used as an abstract command. I had not realized the syntax on your examples is valid. Are _aliases_ and _abstract commands_ the same thing, I assume so? On the example config in the repo, nothing is ever assigned to a lowercase identifier, this created the confusion.\n\nNow after reading the section on abstract commands again, I realize the \"issue\" I noticed, appears to be documented behavior:\n \n\nIt looks like I'll also need to read the functional principle section thoroughly again. My prior understanding of it seems to be contradicting at several places. I had figured it's the first match from top to bottom that is selected and thought I've noticed it when tweaking the config. But now when I think about it, it could be this what I was seeing:\n \n\nDo I read this correctly know, that even if I have a config like:\n\ntoml\n[device=\\Keychron K15 Pro\\ class=\"google-chrome\"]\nA >> B\n\n[device=\\Keychron K15 Pro\\]\nA !250ms B >> C\nA >> D\n\nTyping `A`, then `B` within 250ms within a Chrome window would result in the output being `C`? If so, no wonder I've had some pretty damn difficult to debug situations with my config. :smile: \n\nI guess the best way ahead is to create a simplified test config and just output characters with different type of contexts and see what comes out. It's funny how with all things with computers, you might get pretty far with the wrong understanding of how things work with just plain luck. Then under the false idea of understanding you might fail to remember to try to recreate a simplified setup to verify. With 15 years in the industry, I should not fall for this anymore.\n\nI'll probably close this as it appears to not make much sense given the inner workings. I'll first test if what you suggested gets around the issue.\n\nMy plan was to later create another feature request suggesting nested context, to be able to define somehing like:\n\ntoml\n[class=\\chrome|chromium]\n [device=\"KeyboardA\"]\n # some mappings\n [end]\n\n [device=\"KeyboardB\"]\n # some other mappings\n [end]\n\n # common mappings for Chrome/Chromium\n[end]\n\nI now doubt if this would make sense either. :thinking:","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-13T20:23:26+08:00","repo_name":"houmain/keymapper","issue_id":2066063121,"issue_number":97,"issue_url":"https://github.com/houmain/keymapper/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1891186422","fragment_type":"issue_comment","sequence":3,"text":"I did run into quite a few unexpected behavior while testing your suggestion and my understanding of the inner workings. For instance, I didn't expect aliases to have an effect even in a mapping\n\nAutoShift = Virtual1\ndebug_autoshift_toggled >> 'AutoShift toggled'\n\n...to result in `Virtual1 toggled` typed, but it was easy to avoid by defining `AutoShift` after the string in the config file. Do aliases work pretty much like a `#define` macro, just replacing each occurrence in the config? I expected it to be more constrained but after knowing it works this way is actually pretty nice. It didn't occur to me to see if can also be used in place of regex matchers... That would be nice!\n\nMy test config is below. Your tip on using a virtual key press/release for the indicator was brilliant. I somehow assumed multiple of such active would not be supported nor did this occur to me.\n\nAfter a while debugging with typed strings, I came up with this trick of using `notify-send`. I found it quite quite neat, even if I say myself.\n\nEverything included in this config seems to work as expected, even with both keyboards attached at the same time, although both keyboards need to be connected when the config is loaded. At least the `F1` mapping doesn't seem to trigger on either keyboard if I attach them after the config. At one point I also saw both keyboards output the same device specific string. Is it expected based on the implementation? I could not reproduce it while writing this though.\n\nAnyway, it seems the concept of this feature request can at least partly be worked around by defining prefixed aliases and keeping in mind only the `>>` mappings can be context specific (please correct me if I'm wrong). I'll close this, thank you for the help!\n\nperl\n# Forward mods\nMeta >> Meta\nControl >> Control\nAltLeft >> AltLeft\n\n# Key aliases\nAlt = AltLeft\nAltGr = AltRight\n\n# Key groups\nLetter = A | B | C | D | E | F | G | H | I | J | K | L | M | N | O | P | Q | R | S | T | U | V | W | X | Y | Z\nNumber = 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9\n\nNOTIFY_TIMEOUT = 5000\n\n# For debugging\nnotify = notify-send -t NOTIFY_TIMEOUT \"keymapper\"\n\n# These simulate key indicators from my original config\nnotify_capsword_on = $(notify \"CapsWord on\")\nnotify_capsword_off = $(notify \"CapsWord off\")\n\nnotify_autoshift_on = $(notify \"AutoShift on\")\nnotify_autoshift_off = $(notify \"AutoShift off\")\n\n# QMK CapsWord emulation ( URL \n[default]\n CapsWord = Virtual1\n CapsWordKey = Letter | Number | Minus | Backspace\n\n Shift{200ms} >> Shift\n ShiftLeft{ShiftRight} >> CapsWord CapsLock ^\n Shift{CapsLock} >> CapsWord CapsLock ^\n CapsWord >> notify_capsword_on ^ notify_capsword_off\n\n[modifier=\"CapsWord\"]\n Minus >> Shift{Minus}\n CapsWordKey >> CapsWordKey\n !CapsWordKey Any >> CapsWord CapsLock Any ^\n\n# QMK AutoShift emulation ( URL \n[default]\n AutoShiftLock = F12\n AutoShift = Virtual2\n AutoShifted = BracketLeft | BracketRight | Number | Minus | Equal | Comma | Period\n\n F12 >> AutoShift ^\n AutoShift >> notify_autoshift_on ^ notify_autoshift_off\n\n[modifier=\"AutoShift\"]\n Shift{AutoShifted} >> (Shift AutoShifted)\n AutoShifted{120ms} !AutoShifted >> (Shift AutoShifted) ^\n AutoShifted{Any} >> AutoShifted Any\n AutoShifted >> AutoShifted\n\n# Device context test\n[device=/Keychron K3 Pro/]\n F3 >> AutoShift ^\n F1 >> $(notify \"F1 press on K3 Pro\") ^\n\n[device=/Keychron K15 Pro/]\n F5 >> AutoShift ^\n F1 >> $(notify \"F1 press on K15 Pro\") ^\n\n# vim: ft=toml sw=2 ts=2 sts=2 expandtab","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-15T01:57:50+08:00","repo_name":"houmain/keymapper","issue_id":2066063121,"issue_number":97,"issue_url":"https://github.com/houmain/keymapper/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894487293","fragment_type":"issue_comment","sequence":4,"text":"Yes, right, they are just substituted. In 3.5.0 I improved the behavior. Now they are no longer substituted in strings but they are in context filters.\n \n\nThis sounds strange. Please file another issue if you can definitely reproduce broken behavior.","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-16T20:47:00+08:00","repo_name":"houmain/keymapper","issue_id":2066063121,"issue_number":97,"issue_url":"https://github.com/houmain/keymapper/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1385513000","fragment_type":"issue_description","sequence":0,"text":"Keymapper stops working after some time, but only for class specific mappings\nI've had this issue for a while and now I've narrowed it down to only class specific abstract mappings.\n\nE.g. I have things like these\n\n# default mappings for abstract commands\n next_tab >> Ctrl{E}\n prev_tab >> Ctrl{Q}\n delete_word >> Ctrl{Backspace}\n\nAnd then, in specific class names, I remap them\n\n[class=/brave-browser|Navigator|chromium|google-chrome|betterbird|firefox/]\n next_tab >> Ctrl{Tab}\n prev_tab >> Ctrl{Shift{Tab}}\n\n Ext{1} >> Ctrl{1}\n Ext{2} >> Ctrl{2}\n Ext{3} >> Ctrl{3}\n\n[class=\"guake\"]\n next_tab >> Ctrl{PageDown}\n prev_tab >> Ctrl{PageUp}\n delete_word >> Ctrl{D}\n\nBut at some point in time (I'm not sure if it's timed with waking up from sleep, but if it is, it's not consistent) only the abstract command mappings stop working, i.e. I cannot switch tabs in `firefox` with `capslock-e`, but can jump to the first tab with `capslock-1`.\n\nThe `capslock` is also an alias.\n\n# aliases\n Ext = CapsLock\n Ctrl = Control\n\nThe problem is fixed either by restarting both `keymapper` and `keymapperd`, or putting the system to sleep and waking it up again.\n\nWhat else can I provide? Sadly I cannot reproduce it consistently so I'm hoping you might have a better insight into what's wrong.","author_login":"mark2185","author_association":"NONE","created_at":"2022-09-26T06:41:59+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1261351428","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the report.\nI have no clue yet. Does it happen on Windows or Linux (X11, Wayland / Gnome or another WM)?","author_login":"houmain","author_association":"OWNER","created_at":"2022-09-28T19:07:59+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1261378517","fragment_type":"issue_comment","sequence":2,"text":"Ah, sorry, forgot to add. \n\n`Linux`, `X11`, `i3-wm`, built from latest `master`.","author_login":"mark2185","author_association":"NONE","created_at":"2022-09-28T19:32:38+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1277577575","fragment_type":"issue_comment","sequence":3,"text":"Additional information: it might coincide with 100% CPU usage.","author_login":"mark2185","author_association":"NONE","created_at":"2022-10-13T13:05:08+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291830745","fragment_type":"issue_comment","sequence":4,"text":"I will check that too, it stopped to work after hours on my **Fedora Silverblue**","author_login":"RichardFevrier","author_association":"CONTRIBUTOR","created_at":"2022-10-26T10:34:07+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291873721","fragment_type":"issue_comment","sequence":5,"text":"Welp, it happened to me an hour ago, and I didn't feel like restarting the `daemon`.\n\nAn hour later it miraculously started working again. :shrug:","author_login":"mark2185","author_association":"NONE","created_at":"2022-10-26T11:14:39+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291936433","fragment_type":"issue_comment","sequence":6,"text":"And also only mappings for a specific window class stopped working?","author_login":"houmain","author_association":"OWNER","created_at":"2022-10-26T12:09:24+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291938796","fragment_type":"issue_comment","sequence":7,"text":"No I think the client crashed, but I have a specific window class in my config","author_login":"RichardFevrier","author_association":"CONTRIBUTOR","created_at":"2022-10-26T12:11:23+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1305208969","fragment_type":"issue_comment","sequence":8,"text":"To add, may be relevant, I don't know - after restarting `i3` (which in turns restarts `keymapper`), the `keymapper -u` command pins one CPU core at 100%. \n\nIt's still working as one would expect, but I have no idea what causes it to hog so much CPU time.","author_login":"mark2185","author_association":"NONE","created_at":"2022-11-07T07:51:23+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306106725","fragment_type":"issue_comment","sequence":9,"text":"Thanks! I have also seen this once. I suspected two running `keymapper` processes to cause the problems, but I could not reproduce it.","author_login":"houmain","author_association":"OWNER","created_at":"2022-11-07T19:49:53+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1310069268","fragment_type":"issue_comment","sequence":10,"text":"Happened again, the log looked \"normal\", just messages about switching focused windows, but there was a reasonable number of them.\n\nAlso there was only one `keymapper` process, confirmed by running `pgrep -x keymapper`.","author_login":"mark2185","author_association":"NONE","created_at":"2022-11-10T10:23:43+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328037414","fragment_type":"issue_comment","sequence":11,"text":"Hi, I fixed two things in the Linux version which might have caused these problems. So please give the 2.4.0 release a try.","author_login":"houmain","author_association":"OWNER","created_at":"2022-11-26T12:24:59+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1347922280","fragment_type":"issue_comment","sequence":12,"text":"I've been running it since then and now it's the second time it stopped working, both occurrences coincided with high CPU usage after which `keymapper --update --verbose` hogs up one core at `100%`. \n\nThe log contains nothing except `Detected focused window changed` blocks, and they aren't false, I did switch between those windows.\n\nI'll try to reproduce it in a virtual machine with 1 CPU and will get back to you.","author_login":"mark2185","author_association":"NONE","created_at":"2022-12-13T08:29:01+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1372230216","fragment_type":"issue_comment","sequence":13,"text":"Unfortunately, it still happens.\n\n`keymapper` pins one CPU core at `100%`, _certain_ mappings stop working, and I have to kill _it_ and `keymapperd` and restart it all to get it hopefully working.\n\nSometimes I don't feel like doing that so I just put the laptop to sleep and wake it up again, and that _may or may not_ fix it.","author_login":"mark2185","author_association":"NONE","created_at":"2023-01-05T13:42:15+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1845794975","fragment_type":"issue_comment","sequence":14,"text":"Now that you've mentioned it, I'm on `3.1.0` currently and don't remember hitting the same issue in these past few months (I have reinstalled OS tho). \n\nI suggest that we close this issue, I'll update to `3.2.0` and if it starts happening again I'll reopen it :)","author_login":"mark2185","author_association":"NONE","created_at":"2023-12-07T17:35:37+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1874450669","fragment_type":"issue_comment","sequence":15,"text":"Unfortunately it resurfaced, a few times in the last couple of days, luckily restarting `keymapperd` fixes the issue.","author_login":"mark2185","author_association":"NONE","created_at":"2024-01-02T19:26:35+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1883448679","fragment_type":"issue_comment","sequence":16,"text":"I'm also experiencing this or something related. I've noticed it pretty much every morning after unlocking my computer, but also occasionally while I'm working. It doesn't reproduce simply by locking/unlocking though. I haven't yet checked if either of the processes is eating a lot of CPU, I'll check if this is the case when it happens the next time. \n\nSome possibly relevant notes:\n- Ubuntu 20.04, i3wm, keymapper is built from source {Wayland support disabled)\n- Keychron K15 Pro keyboard (QMK firmware)\n- `keymapper` has been running with the `--update` flag\n- I've defined various device specific mappings\n- opening and saving the config file activates the mappings again, reconnecting the keyboard does not","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-09T17:06:58+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1883799957","fragment_type":"issue_comment","sequence":17,"text":"Hi, I just fixed a problem, when two `keymapper` instances were running. The context updates of the second instance were not processed by `keymapperd` and so the send buffer could fill up until it began to busy loop... Now it knows that it is not connected.\n\nI could not reproduce it with one process yet. Maybe `keymapperd` still thinks that the lock-key is still pressed and therefore does not process any context updates. I need to do some more testing.\n\n@ristomatti, wow your configuration is really impressive!","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-09T21:12:27+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1883963032","fragment_type":"issue_comment","sequence":18,"text":"I'm pretty confident I only had a single instance. After my comment, I ran `keymapper -u -v` foreground to see if it would give some hints. It didn't took long for the bug to reproduce. I just had to go to get some groceries.\n\nThere was nothing on the verbose logs though, I didn't yet try with `keymapperd` on verbose though. System `journal` indicated my keyboard had disconnected and reconnected but I then remembered I disconnected it myself to charge another device. I've now built the latest version, I'll report back on the results.\n\nAlso, thanks for the kind words! I've been planning to post the config or some snippets of it on the discussion section at a later time. Keymapper has been very inspiring to say the least! It's also great for avoiding real work too... :sweat_smile:","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-09T23:36:49+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1883972351","fragment_type":"issue_comment","sequence":19,"text":"Actually, I just found at least one way to reproduce the same behavior. Both my Keychron keyboards show up with different names depending on how they're connected:\n\nsh\n# USB-cable\n$ xinput list | grep K15\n⎜ ↳ Keychron Keychron K15 Pro Consumer Control id=32 [slave pointer (2)]\n⎜ ↳ Keychron Keychron K15 Pro Mouse id=37 [slave pointer (2)]\n ↳ Keychron Keychron K15 Pro id=20 [slave keyboard (3)]\n ↳ Keychron Keychron K15 Pro System Control id=23 [slave keyboard (3)]\n ↳ Keychron Keychron K15 Pro Keyboard id=24 [slave keyboard (3)]\n ↳ Keychron Keychron K15 Pro Consumer Control id=36 [slave keyboard (3)]\n\n# Bluetooth\n$ xinput list | grep K15\n⎜ ↳ Keychron K15 Pro Keyboard id=9 [slave pointer (2)]\n⎜ ↳ Keychron K15 Pro Mouse id=17 [slave pointer (2)]\n ↳ Keychron K15 Pro Keyboard id=10 [slave keyboard (3)]\n\nDue to this behavior, I use a regex to match it:\n\ntoml\n[device=/Keychron K15 Pro Keyboard/]\n # ...\n\nIf I change from USB to Bluetooth or vice versa, the mappings stop working. So technically it's not the same device. Should this work regardless? Typically I've had it on cable all the time, so there's something else going on though.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-09T23:49:36+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1887779135","fragment_type":"issue_comment","sequence":20,"text":"Yes, multiple devices with identical names should not cause problems.\nMaybe you can start `keymapperd` with `-v` and check if the devices are un/grabbed as expected when plugging in/out.","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-11T18:59:53+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1887937515","fragment_type":"issue_comment","sequence":21,"text":"Will definitely do that, but it might take a while until I come back to this. Experimenting with keymapper is \"somewhat\" addicting. I'll need to focus a bit on actual work for a change. :grin: \n\nHave you noticed #97 btw? I think I ran to another possibly related issue today with virtual modifiers and abstract commands. I managed to hack together an emulation of QMK's \"Auto Shift\" feature, then made it toggleable together with the config that allows me to write umlauts in a convenient manner. I then realized it'd be useful to somehow see when either is active. On the latest two revisions of my config you'll see the initial implementation of the indicators. The indicators are shown on my i3wm status bar:\n\nimage\n\nIn the latest revision I attempted to reduce the config required for the indicators but ran into odd issue and had to just work around with lots of trial and error. I'm wondering if I've misunderstood how the config is processed or if I ran across some bugs. To explain them, I'd need too recreate them as I've already deleted the parts. That will be some later time.\n\nBut briefly, I had added two sections at the end of the file. Something like this:\n\ntoml\n[modifier=\"!AutoShift\"]\n toggle_autoshift >> $(show_indicator) ^ AutoShift\n\n[modifier=\"AutoShift\"]\n toggle_autoshift >> $(hide_indicator) ^ AutoShift\n\nThis toggled the feature correctly, but regardless of the state of `AutoShift`, keymapper would always call the script on the lower blow. So the indicator was either always on or off.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-11T20:47:35+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1888034529","fragment_type":"issue_comment","sequence":22,"text":"I diffed the log of the earlier failed reconnect via Bluetooth after USB and this later properly working one. I can't spot anything different.. 🤔\n\nimage","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-11T21:58:44+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1888040351","fragment_type":"issue_comment","sequence":23,"text":"Is there any way to enable more verbose logging? I now tried swapping from Bluetooth to USB quicker, while the BT still seems to be connected. Mappings persisted.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-11T22:03:35+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1888081687","fragment_type":"issue_comment","sequence":24,"text":"Likely not much use. I'd need some advice on how to assist further. Sadly my only \"C++\" experience is from intermediate hobby level Arduino snippets, in which all the actual low level parts are abstracted behind simplified libraries.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-11T22:39:22+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1889767533","fragment_type":"issue_comment","sequence":25,"text":"Thank you for your thorough tests!\nOk, the grabbing seems to work as expected, good.\nI also tried un/plugging two keyboards with a basic configuration containing a context:\n`[device=/Keyboard/]`\nUnfortunately here the context's mappings never stopped working.\nI am thinking about whether the verbose logging can be improved somehow.","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-12T18:28:53+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1890735440","fragment_type":"issue_comment","sequence":26,"text":"I guess I could also try removing the dock from the equation and connect the cable on the laptop and/or see if the Bluetooth connection is more stable.\n\nI do prefer using the cable though since it always sits on the desk. Also I've only recently got the keyboard and still doing some QMK remaps using URL or URL I'm trying to get away with as little done there as possible since using just Keymapper would be much more convenient.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-13T19:13:34+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1896596308","fragment_type":"issue_comment","sequence":27,"text":"Since a couple of days ago, I've also seen `keymapper` suddently maxing out one CPU core. If I restart it before restarting 'keymapperd', it gets stuck waiting for connection. Somewhat interestingly, some mappings keep working even when `keymapper` is not running at all (before restarting `keymapperd`). \n\nI don't remember having such issues other than this week. I've changed the config quite a bit and introduced a set of mappings to another keyboard after that for instance. I suspect it's in some way related to the parts included in the config I posted here: #99.\n\nMy earlier config did not use virtual keys or executing external commands, both of which I've added last week.\n\nBut this might be off topic and unrelated to this particular issue. I just thought to mention as this is what @mark2185 mention the sudden high CPU usage.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-17T20:00:38+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1901747892","fragment_type":"issue_comment","sequence":28,"text":"A quick update. Yesterday I noticed a message on syslog there's indicated insufficient power to allow all functionality when a device had been connected. It turned out to be just my phone, and it indeed was not losing power rather than charging when connected. Anyway, after this I tested various USB power paths using two USB testers and didn't notice the voltage dropping even close to the minimum of the USB specification. Just in case, I tried swapping my keyboard to a separately powered USB hubx from my laptop dock.\n\nThat did not help though. I've got this happen at least 5 times today. There's been various input device disconnection events but no clear pattern has emerged. I suspect it might be a hardware issue as many are reporting frequent disconnection issues on some Keychron model. But then again, what device had caused a . All of them keep working just fine regardless. I wish there was a way to someway check when this occurs to be able to restart Keymapper.\n\nAny chance the fix for #101 could have fixed this as a side effect?","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-20T04:50:00+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906386646","fragment_type":"issue_comment","sequence":29,"text":"There should be no need for restarting keymapper when devices dis-/appear. Doesn't it work as expected?\n \n\nI think #99 could have fixed this issue since with it context updates are no longer hold back. \nTogether with the fix for the problem that occured when two instances of keymapper where running.\n\n@mark2185 and @ristomatti can you confirm that it works now?","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-23T16:04:34+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906516048","fragment_type":"issue_comment","sequence":30,"text":"Sorry I haven't had time to post updates to this thread. Unless my memory is failing due to continous lack of proper sleep the last few weeks, I would say I saw this happen plenty of times after upgrading to v3.5.1.\n\nBased on my logs, it's always been intermittent input device disconnections. At first it seemed to be some specific device or two, but after a while that was proven wrong as well. Some just disconnect more frequently:\n\n$ journalctl -u acpid --since 2024-01-01 | rg '.*input device has been disconnected, fd (\\d+)' -r '/dev/input/event$1' | sort | uniq -cd | sort -nr\n 121 /dev/input/event29\n 94 /dev/input/event8\n 91 /dev/input/event7\n 83 /dev/input/event9\n 73 /dev/input/event26\n 67 /dev/input/event24\n 66 /dev/input/event23\n 64 /dev/input/event25\n 63 /dev/input/event10\n 55 /dev/input/event18\n 50 /dev/input/event30\n 38 /dev/input/event27\n 36 /dev/input/event31\n 33 /dev/input/event22\n 24 /dev/input/event28\n 22 /dev/input/event32\n 11 /dev/input/event11\n 10 /dev/input/event12\n 7 /dev/input/event19\n 5 /dev/input/event33\n 3 /dev/input/event35\n 3 /dev/input/event34\n 3 /dev/input/event20\n 2 /dev/input/event21\n\n`event29` is `keymapperd` virtual device, so it's irrelevant.\n\nBut with that said, yesterday morning I switched some USB devices around between my dock and the two USB2 hubs attached to it. Since then the issue has not yet reproduced once. It includes two changes which I think could have made the difference.\n\n1. I connected my keyboard directly to a port on my USB-C dock\n2. I switched my seconcary (left hand side) Logitech Anywhere 2S mouse from Bluetooth to connection via a Unifying Receiver USB dongle.\n\nIf the reason is either of those, I'd put my money on the latter. I originally changed it to BT when I bought my new primary mouse, Logitech G502 X (it uses a Logitech Lightspeed dongle instead) due to interference issues. Namely, my then also new Keychron K3 Pro sufferenced from random stuck keys and this change fixed the issue completely, even though the keyboard was connected via USB.\n\nI had noticed the mouse disconnecting several times a day (I assume for power saving), so I thought it's worth the shot to try the dongle again as the two hubs are further apart. And indeed, no interference issues so far either.\n\nI believe swapping my keyboard to a port on the dock is less likely to have made a difference. as before doing that, I tried connecting it directly on the laptop. It didn't have any effect.\n\n@houmain If you've got a Bluetooth input device at hand but not connected, it'd be interesting to hear if you'll then see this occur as well.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-23T17:00:37+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906525376","fragment_type":"issue_comment","sequence":31,"text":"I already had an idea of using e.g. `entr` to restart the process after detecting a change in `/dev/input` but I haven't had to try that out yet.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-23T17:05:40+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906544369","fragment_type":"issue_comment","sequence":32,"text":"Perhaps this could be some type of a race condition, like `keymapperd` grabbing the devices too fast after a change? For instance, my logs earlier on the thread show there's sometimes two consecutive `Updating device list` logs when a device is disconnected.","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-23T17:14:52+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906563816","fragment_type":"issue_comment","sequence":33,"text":"Regardless if this turns out to fix the issue for me for good, it would be useful to be able to either make `keymapperd` grab only specific devices or to be able to blacklist some of them. This would also prevent virtual keys releasing unnecessarily. So many devices seem to also show up as input devices. In my case as an example:\n\n/dev/input/event0: Sleep Button\n/dev/input/event1: Lid Switch\n/dev/input/event2: Power Button\n/dev/input/event3: AT Translated Set 2 keyboard\n/dev/input/event4: Video Bus\n/dev/input/event5: SynPS/2 Synaptics TouchPad\n/dev/input/event6: TPPS/2 Elan TrackPoint\n/dev/input/event7: Logitech USB Receiver\n/dev/input/event8: Logitech USB Receiver Keyboard\n/dev/input/event9: Keychron Keychron K15 Pro\n/dev/input/event10: Keychron Keychron K15 Pro Mouse\n/dev/input/event11: Keychron Keychron K15 Pro System Control\n/dev/input/event12: Keychron Keychron K15 Pro Consumer Control\n/dev/input/event13: Lenovo ThinkPad Thunderbolt 3 Dock USB Audio\n/dev/input/event14: Keychron Keychron K15 Pro Keyboard\n/dev/input/event15: ThinkPad Extra Buttons\n/dev/input/event16: HDA NVidia HDMI/DP,pcm=3\n/dev/input/event17: HDA NVidia HDMI/DP,pcm=7\n/dev/input/event18: HDA NVidia HDMI/DP,pcm=8\n/dev/input/event19: HDA NVidia HDMI/DP,pcm=9\n/dev/input/event20: HDA NVidia HDMI/DP,pcm=10\n/dev/input/event21: HDA NVidia HDMI/DP,pcm=11\n/dev/input/event22: Integrated Camera: Integrated C\n/dev/input/event23: Integrated Camera: Integrated I\n/dev/input/event24: Generic Blue Microphones Consumer Control\n/dev/input/event25: sof-hda-dsp Mic\n/dev/input/event26: sof-hda-dsp Headphone\n/dev/input/event27: Logitech Webcam C925e\n/dev/input/event28: Generic Blue Microphones\n/dev/input/event29: Keymapper\n/dev/input/event30: MX Anywhere 2S Keyboard\n/dev/input/event31: MX Anywhere 2S Mouse\n\nFrom this list, I don't need Keymapper to grab any of these:\n\n/dev/input/event0: Sleep Button\n/dev/input/event1: Lid Switch\n/dev/input/event2: Power Button\n/dev/input/event4: Video Bus\n/dev/input/event5: SynPS/2 Synaptics TouchPad\n/dev/input/event13: Lenovo ThinkPad Thunderbolt 3 Dock USB Audio\n/dev/input/event16: HDA NVidia HDMI/DP,pcm=3\n/dev/input/event17: HDA NVidia HDMI/DP,pcm=7\n/dev/input/event18: HDA NVidia HDMI/DP,pcm=8\n/dev/input/event19: HDA NVidia HDMI/DP,pcm=9\n/dev/input/event20: HDA NVidia HDMI/DP,pcm=10\n/dev/input/event21: HDA NVidia HDMI/DP,pcm=11\n/dev/input/event22: Integrated Camera: Integrated C\n/dev/input/event23: Integrated Camera: Integrated I\n/dev/input/event24: Generic Blue Microphones Consumer Control\n/dev/input/event25: sof-hda-dsp Mic\n/dev/input/event26: sof-hda-dsp Headphone\n/dev/input/event27: Logitech Webcam C925e\n/dev/input/event28: Generic Blue Microphones","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-23T17:25:35+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1906579683","fragment_type":"issue_comment","sequence":34,"text":"Unfortunately I could never reproduce it, so let's just hope it's fixed and I'll be sure to report back if it's not! :)","author_login":"mark2185","author_association":"NONE","created_at":"2024-01-23T17:33:00+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1908970303","fragment_type":"issue_comment","sequence":35,"text":"Awesome, so you were able to reproduce it? I'll pull in the changes and deliberately reconnect the other mouse via BT and leave it running for the night. :crossed_fingers:","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-24T21:48:20+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1908981407","fragment_type":"issue_comment","sequence":36,"text":"A quick unrelated question that I remembered when I was about to build the package: I've added a niceness setting to `keymapperd.service`:\n\nproperties\n[Service]\nExecStart=keymapperd\nNice=-5\n\nWhat's your opinion, could this have any meaningful effect on the input latency?","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-24T21:56:49+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1912031102","fragment_type":"issue_comment","sequence":37,"text":"Yes, even quicker I guess, since my device had different names when connecting via dongle/bluetooh.\n \n\nMaybe, do you perceive any latency or can measure it somehow?\n\nAre you still having problems with context mappings which stop working?","author_login":"houmain","author_association":"OWNER","created_at":"2024-01-26T12:58:15+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1912472314","fragment_type":"issue_comment","sequence":38,"text":"It's difficult to answer on perceived latency. I've noticed a strong correlation with perceived latency and lack of sleep. I haven't done any back and forth testing if I notice a difference after changing the nice/priority setting. As an experiment I've been using the duration based mappings quite a lot. I'll try to tweak each duration to the shortest I can consistently get. Sometimes i've tweaked with 5ms increments. Somehow I'd lean to thinking this could make a difference on a heavy load...\n \n\nNope. I'm pretty confident you found the root cause. From my side this can be closed. If the issue re-appears, I'd be willing to say it will be a different issue and therefore better handled on a new issue.\n\nThat was the last actual issue I've ran across. Stellar work! 👏\n\nYesterday it occurred to me that AutoHotkey was the one of the few Windows apps I haven't found a replacement I'd be willing to do. Most of my use for AHK was application specific mappings and hotstring replacements, both of which can be achieved with Keymapper. :100:","author_login":"ristomatti","author_association":"NONE","created_at":"2024-01-26T18:05:54+08:00","repo_name":"houmain/keymapper","issue_id":1385513000,"issue_number":41,"issue_url":"https://github.com/houmain/keymapper/issues/41","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0400","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Using `externals` as `script` generate unexpected code?","query_context":"# Bug report\n\n \n \n \n \n\n**What is the current behavior?**\n\nResulting bundle contains unexpected non-es5 instruction: `async`/`await`, arrow function; that does not match expected target, e.g., having defaults target `browserslist` with `android 36`, result:\n \n \n \nmodule.exports = (async () => {\n__webpack_require__.r(__webpack_exports__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(299);\nfoo_bar__WEBPACK_IMPORTED_MODULE_0__ = await Promise.resolve(foo_bar__WEBPACK_IMPORTED_MODULE_0__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_0___default = /*#__PURE__*/__webpack_require__.n(foo_bar__WEBPACK_IMPORTED_MODULE_0__);\n\nfoo_bar__WEBPACK_IMPORTED_MODULE_0___default()();\n \n \n\n(function webpackUniversalModuleDefinition(root, factory) {\n if(typeof exports === 'object' && typeof module === 'object')\n module.exports = factory();\n else if(typeof define === 'function' && define.amd)\n define([], factory);\n else if(typeof exports === 'object')\n exports[\"myLib\"] = factory();\n else\n root[\"myLib\"] = factory();\n})(globalThis, function() {\nreturn /******/ (() => { // webpackBootstrap\n/******/ var __webpack_modules__ = ({\n\n/***/ 5579:\n/***/ ((module, __webpack_exports__, __webpack_require__) => {\n\n\"use strict\";\nmodule.exports = (async () => {\n__webpack_require__.r(__webpack_exports__);\n/* harmony import */ var core_js_modules_es_object_to_string_js__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(1539);\n/* harmony import */ var core_js_modules_es_object_to_string_js__WEBPACK_IMPORTED_MODULE_0___default = /*#__PURE__*/__webpack_require__.n(core_js_modules_es_object_to_string_js__WEBPACK_IMPORTED_MODULE_0__);\n/* harmony import */ var core_js_modules_es_promise_js__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(8674);\n/* harmony import */ var core_js_modules_es_promise_js__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/__webpack_require__.n(core_js_modules_es_promise_js__WEBPACK_IMPORTED_MODULE_1__);\n/* harmony import */ var regenerator_runtime_runtime_js__WEBPACK_IMPORTED_MODULE_2__ = __webpack_require__(5666);\n/* harmony import */ var regenerator_runtime_runtime_js__WEBPACK_IMPORTED_MODULE_2___default = /*#__PURE__*/__webpack_require__.n(regenerator_runtime_runtime_js__WEBPACK_IMPORTED_MODULE_2__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_3__ = __webpack_require__(5299);\nfoo_bar__WEBPACK_IMPORTED_MODULE_3__ = await Promise.resolve(foo_bar__WEBPACK_IMPORTED_MODULE_3__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_3___default = /*#__PURE__*/__webpack_require__.n(foo_bar__WEBPACK_IMPORTED_MODULE_3__);\n\nfunction asyncGeneratorStep(gen, resolve, reject, _next, _throw, key, arg) { try { var info = genkey; var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { Promise.resolve(value).then(_next, _throw); } }\n\nfunction _asyncToGenerator(fn) { return function () { var self = this, args = arguments; return new Promise(function (resolve, reject) { var gen = fn.apply(self, args); function _next(value) { asyncGeneratorStep(gen, resolve, reject, _next, _throw, \"next\", value); } function _throw(err) { asyncGeneratorStep(gen, resolve, reject, _next, _throw, \"throw\", err); } _next(undefined); }); }; }\n\nfoo_bar__WEBPACK_IMPORTED_MODULE_3___default()();\n\n/*\n skip other code\n\nAdded following core-js polyfills:\n es.object.to-string { \"android\":\"36\" }\n es.promise { \"android\":\"36\" }\n\nBased on your code and targets, added regenerator-runtime.\n*/\n});\n\n \n\n**STR**\n\nConfigure webpack to resolve some package as external via `script`\n\n externalsType: \"script\",\n externals: {\n 'foo-bar': 'FooBar@ URL \n },\n\n \nConfigure target via `target: ['web', 'es5']` or via browserslist:\n\n \"browserslist\": [\n \"android >= 36\"\n ],\n\nRun on code:\n\nimport Foo from 'foo-bar';\n\nFoo();\n\n(async () => {\n await Promise.resolve();\n})();\n\n \n \n \n \n \n \n\n**What is the expected behavior?**\n\nResulting bundle does not contains unexpected instruction. Expecting to have bundle where **all** code match expected target, via `target`: ['web', es5']` or default, based on browserslist, as same as transpiled source. \n\n \n \n\n**Other relevant information:**\nwebpack version: 5.16.0\nNode.js version: 14","known_context_document_ids":["gh_issue_790328298"],"reference_answer":"at least as I know there is no plan to support code transformation since this will require huge internal webpack changes. old `Dependency` design will no longer work since dependencies operate not on AST level of source code, but only insert/remove/change strings inside source code.\n\nUnfortunately, I am not familiar with babel, but I guess transforming top level await does not help.. since it is required to `await` module import. e.g. in example:\n\nmodule A\n\nconst a = await somePromise;\nexport { a }\n\nmodule B\n\nimport { a } from 'module-a';\n// here we should wait for promise 'somePromise'\n\nconsole.log(a);\n\nin case of transformation just async/await this will not work correctly since you need to transform hole module tree ( thats an issue with currect webpack design, we dont have all code as an AST internally )\n\nTo sum up. as a user you can do things that I mentions above + chunk transformation ( this will bring additional code unfortunately )","answer_document_id":"gh_comment_1859788502","silver_evidence_path":["gh_comment_1100593235","gh_issue_732602098","gh_comment_1859788502"],"evidence_issue_ids":[790328298,732602098],"source_repo_name":"webpack/webpack","source_issue_id":790328298,"source_issue_number":12465,"source_issue_url":"https://github.com/webpack/webpack/issues/12465","target_repo_name":"webpack/webpack","target_issue_id":732602098,"target_issue_number":11874,"target_issue_url":"https://github.com/webpack/webpack/issues/11874","reference_anchor_document_id":"gh_comment_1100593235","reference_answer_author":"vankop","reference_answer_author_association":"MEMBER","quality_score":95.86,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2143,"anchor_target_overlap":0.4286,"target_answer_overlap":0.0972},"issue_created_at":"2021-01-20T21:15:06+08:00","valid_comment_count":29,"fragments":[{"document_id":"gh_issue_790328298","fragment_type":"issue_description","sequence":0,"text":"Using `externals` as `script` generate unexpected code\n# Bug report\n\n \n \n \n \n\n**What is the current behavior?**\n\nResulting bundle contains unexpected non-es5 instruction: `async`/`await`, arrow function; that does not match expected target, e.g., having defaults target `browserslist` with `android 36`, result:\n \n \n \nmodule.exports = (async () => {\n__webpack_require__.r(__webpack_exports__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(299);\nfoo_bar__WEBPACK_IMPORTED_MODULE_0__ = await Promise.resolve(foo_bar__WEBPACK_IMPORTED_MODULE_0__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_0___default = /*#__PURE__*/__webpack_require__.n(foo_bar__WEBPACK_IMPORTED_MODULE_0__);\n\nfoo_bar__WEBPACK_IMPORTED_MODULE_0___default()();\n \n \n\n(function webpackUniversalModuleDefinition(root, factory) {\n if(typeof exports === 'object' && typeof module === 'object')\n module.exports = factory();\n else if(typeof define === 'function' && define.amd)\n define([], factory);\n else if(typeof exports === 'object')\n exports[\"myLib\"] = factory();\n else\n root[\"myLib\"] = factory();\n})(globalThis, function() {\nreturn /******/ (() => { // webpackBootstrap\n/******/ var __webpack_modules__ = ({\n\n/***/ 5579:\n/***/ ((module, __webpack_exports__, __webpack_require__) => {\n\n\"use strict\";\nmodule.exports = (async () => {\n__webpack_require__.r(__webpack_exports__);\n/* harmony import */ var core_js_modules_es_object_to_string_js__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(1539);\n/* harmony import */ var core_js_modules_es_object_to_string_js__WEBPACK_IMPORTED_MODULE_0___default = /*#__PURE__*/__webpack_require__.n(core_js_modules_es_object_to_string_js__WEBPACK_IMPORTED_MODULE_0__);\n/* harmony import */ var core_js_modules_es_promise_js__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(8674);\n/* harmony import */ var core_js_modules_es_promise_js__WEBPACK_IMPORTED_MODULE_1___default = /*#__PURE__*/__webpack_require__.n(core_js_modules_es_promise_js__WEBPACK_IMPORTED_MODULE_1__);\n/* harmony import */ var regenerator_runtime_runtime_js__WEBPACK_IMPORTED_MODULE_2__ = __webpack_require__(5666);\n/* harmony import */ var regenerator_runtime_runtime_js__WEBPACK_IMPORTED_MODULE_2___default = /*#__PURE__*/__webpack_require__.n(regenerator_runtime_runtime_js__WEBPACK_IMPORTED_MODULE_2__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_3__ = __webpack_require__(5299);\nfoo_bar__WEBPACK_IMPORTED_MODULE_3__ = await Promise.resolve(foo_bar__WEBPACK_IMPORTED_MODULE_3__);\n/* harmony import */ var foo_bar__WEBPACK_IMPORTED_MODULE_3___default = /*#__PURE__*/__webpack_require__.n(foo_bar__WEBPACK_IMPORTED_MODULE_3__);\n\nfunction asyncGeneratorStep(gen, resolve, reject, _next, _throw, key, arg) { try { var info = genkey; var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { Promise.resolve(value).then(_next, _throw); } }\n\nfunction _asyncToGenerator(fn) { return function () { var self = this, args = arguments; return new Promise(function (resolve, reject) { var gen = fn.apply(self, args); function _next(value) { asyncGeneratorStep(gen, resolve, reject, _next, _throw, \"next\", value); } function _throw(err) { asyncGeneratorStep(gen, resolve, reject, _next, _throw, \"throw\", err); } _next(undefined); }); }; }\n\nfoo_bar__WEBPACK_IMPORTED_MODULE_3___default()();\n\n/*\n skip other code\n\nAdded following core-js polyfills:\n es.object.to-string { \"android\":\"36\" }\n es.promise { \"android\":\"36\" }\n\nBased on your code and targets, added regenerator-runtime.\n*/\n});\n\n \n\n**STR**\n\nConfigure webpack to resolve some package as external via `script`\n\n externalsType: \"script\",\n externals: {\n 'foo-bar': 'FooBar@ URL \n },\n\n \nConfigure target via `target: ['web', 'es5']` or via browserslist:\n\n \"browserslist\": [\n \"android >= 36\"\n ],\n\nRun on code:\n\nimport Foo from 'foo-bar';\n\nFoo();\n\n(async () => {\n await Promise.resolve();\n})();\n\n \n \n \n \n \n \n\n**What is the expected behavior?**\n\nResulting bundle does not contains unexpected instruction. Expecting to have bundle where **all** code match expected target, via `target`: ['web', es5']` or default, based on browserslist, as same as transpiled source. \n\n \n \n\n**Other relevant information:**\nwebpack version: 5.16.0\nNode.js version: 14","author_login":"Kyr","author_association":"NONE","created_at":"2021-01-20T21:15:06+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1090360739","fragment_type":"issue_comment","sequence":1,"text":"all async modules on webpack side behave as top-level-await ( in case if `import x from \"async-module\"` )\n\n_______\n\nwe discussed this internally so.. supporting promises on webpack side would require huge code transformation, that webpack in current version can not perform. There is a PR to add warning in case when output environment does not supports async/await.\n\nAs user you can:\n- build for environment that supports async/await\n- don't using top-level-await","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-06T14:49:19+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097516216","fragment_type":"issue_comment","sequence":2,"text":"@aoisummer did you find a solution to bellow?\n \n \n \n \n \n \n \n \n\n@alexander-akait Could you please share the link of the documentation where it's referring about polyfills would fix this issue? We are struggling on this issue as we have a requirement to build the project into es5 and we use externals heavily","author_login":"williamjacobszoon","author_association":"NONE","created_at":"2022-04-13T03:29:01+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097660062","fragment_type":"issue_comment","sequence":3,"text":"@williamjacobszoon you should use dynamic import (`import()`) then.. As I said transforming top-level-await (async/await => promises) is not possible in current webpack design.. \n\nmaybe you can use `babel` for this (for es5 builds transform chunks after compiling..)","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-13T07:37:29+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1098736588","fragment_type":"issue_comment","sequence":4,"text":"@vankop Could you please share some input on how to use babel on runtime chunk? I tried it didn't work for runtime chunk. Appropriate your help on this matter","author_login":"williamjacobszoon","author_association":"NONE","created_at":"2022-04-14T05:55:58+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099059071","fragment_type":"issue_comment","sequence":5,"text":"not sure about correct config.. I think `@babel/preset-env` will be enough","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-14T10:46:49+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099842717","fragment_type":"issue_comment","sequence":6,"text":"@vankop still not working with babel loader as per my understanding the runtime is not loaded via loaders so it's not going through the babel loader.\n\nI was expecting, Webpack would generate code according to the target option specified in the config in all aspects and seems like It is not.\n\nShouldn't this be a major bug in webpack as It's no honoring the target set by the config when it's generating the webpack related code (runtime/helpers)?","author_login":"williamjacobszoon","author_association":"NONE","created_at":"2022-04-15T04:34:27+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099963521","fragment_type":"issue_comment","sequence":7,"text":"@williamjacobszoon not `babel-loader`, just use babel on output ( only for es5 )\n\n______\n\nbetter use `import()` instead of top-level-await","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-15T08:32:16+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099964069","fragment_type":"issue_comment","sequence":8,"text":"It does. By in case of top-level-await it is not possible in current design ( transform async to promises ), so you have 2 options URL","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-15T08:33:12+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099999435","fragment_type":"issue_comment","sequence":9,"text":"@vankop I'm kind of disappointed see your response. because non of these things are explained in the documentation about using externals will cause the output to be not compatible with es5. I'm getting to know all these things at the final phase of our application development now I have to restructure the whole app again 😭","author_login":"williamjacobszoon","author_association":"NONE","created_at":"2022-04-15T09:37:37+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100000824","fragment_type":"issue_comment","sequence":10,"text":"yeah, sorry about this.. changing `import x from \"x\"` to `import(\"x\")` should not be a big problem.","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-15T09:40:36+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100588536","fragment_type":"issue_comment","sequence":11,"text":"I try to reproduce that today, but it has been fixed in newer version. This issue still exists, which means the feature `externals script` cannot run when your browser does not support async function. Here is my test code:\n\n// webpack.config.js\nmodule.exports = {\n mode: 'development',\n target: ['web', 'es5'],\n externalsType: 'script',\n externals: {\n react: 'React@ URL \n 'react-dom': 'ReactDOM@ URL \n },\n};\n\nwebpack: 5.72.0\nnode: 16.14.2\nbrowser: IE 11","author_login":"aoisummer","author_association":"NONE","created_at":"2022-04-16T06:48:56+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100593235","fragment_type":"issue_comment","sequence":12,"text":"@aoisummer Thanks for the update.\n\nI just found out there is separate issue raised for top-level await generation on es5 target.\n\nCompile top-level await to ES5 #11874\n\n URL","author_login":"williamjacobszoon","author_association":"NONE","created_at":"2022-04-16T07:18:36+08:00","repo_name":"webpack/webpack","issue_id":790328298,"issue_number":12465,"issue_url":"https://github.com/webpack/webpack/issues/12465","linked_issue_ids":[732602098],"is_known_query_context":false},{"document_id":"gh_issue_732602098","fragment_type":"issue_description","sequence":0,"text":"Compile top-level await to ES5\n# Bug report\n\n \n \n \n \n\n**What is the current behavior?**\n\nTop-level await code is currently always compiled to native async/await code and therefore doesn't work in browsers like IE11.\n\n**If the current behavior is a bug, please provide the steps to reproduce.**\n\nReproduction repository: URL \n\nHere's the relevant part of the output:\n\njs\n!(function () {\n \"use strict\";\n var r = {\n 568: function (r, o) {\n r.exports = (async () => ((o.Z = await Promise.resolve(1)), o))();\n },\n 138: function (r, o, e) {\n r.exports = (async () => {\n var r = e(568);\n (r = await Promise.resolve(r)), console.log(r.Z);\n })();\n },\n },\n o = {};\n !(function e(t) {\n if (o[t]) return o[t].exports;\n var s = (o[t] = { exports: {} });\n return rt, s.exports;\n })(138);\n})();\n\n \n \n \n \n \n \n\n**What is the expected behavior?**\n\nIt would be great if the code would compile to regular promises that are awaited by calling `.then`.\n\nI tried configuring `target: ['web', 'es5']` and adding a `browserslist` config, but it seems like that doesn't have an effect.\n\n \n \n\n**Other relevant information:**\nwebpack version: 5.3.1\nNode.js version: 14.15.0\nOperating System: macOS\nAdditional tools: I initially observed this behaviour in a Next.js app and have created a failing test in the Next.js repository.","author_login":"amannn","author_association":"NONE","created_at":"2020-10-29T19:39:42+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719514363","fragment_type":"issue_comment","sequence":1,"text":"Thanks for your quick response!\n\nI've created a `babel-loader` branch based on your feedback in my repo: URL \n \n\nIs it? It seems like it at least compiled. I've now changed the code to this:\n\njs\nconst value = await Promise.resolve(1);\n\nexport default value;\n\nDoes that look ok to you?\n \n\nI've added babel loader, `@babel/preset-env` and `@babel/plugin-transform-async-to-generator` in the branch now. I've also included some regular async/await code in the example code. The regular async/await code is transformed as expected, but not the top-level async/await.\n\nI've read at URL that this plugin only parses the syntax but doesn't do any transformation itself.\n\nAs far as I understand, Babel runs before the webpack compilation, right? So in this case webpack inserts new async/await statements in the code that was already compiled by Babel, so Babel wouldn't be able to transform the result – is that correct?","author_login":"amannn","author_association":"NONE","created_at":"2020-10-30T12:05:11+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719575907","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the pointer! I've created an initial PR with a failing test ( URL but I'm struggling a bit to understand how I can wrap the whole module consumption in a `.then(…)`. If you could help with some more guidance, that would be great! I'm a first-time contributor and not really familiar with the internals of webpack.","author_login":"amannn","author_association":"NONE","created_at":"2020-10-30T14:12:32+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719580241","fragment_type":"issue_comment","sequence":3,"text":"I'm really not sure how 🙂. It looks like with `AwaitDependenciesInitFragment` I can add a line before the module exports are consumed, but how can I wrap the whole consumption? I'd need to insert code at the end as well, right?","author_login":"amannn","author_association":"NONE","created_at":"2020-10-30T14:20:08+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719587300","fragment_type":"issue_comment","sequence":4,"text":"try experimenting, just open `node_modules/webpack/lib/async-modules/AwaitDependenciesInitFragment.js` in your reproducible test repo and change runtime and look what webpack generated","author_login":"evilebottnawi","author_association":"MEMBER","created_at":"2020-10-30T14:32:17+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_727535798","fragment_type":"issue_comment","sequence":5,"text":"I took a look at this yesterday, and realised something. In order for untranspiled top-level await user code to work, webpack needs to provide it with an async context. The only way to do that is by wrapping it with an `async` function. We can't replace this `async` function with `.then` because that would remove the async context and make untranspiled top-level await fail. I think that in order to make top-level await compatible with ie11, webpack output will need to be transpiled in a post-processing step.","author_login":"Janpot","author_association":"MEMBER","created_at":"2020-11-15T08:44:23+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_972910872","fragment_type":"issue_comment","sequence":6,"text":"well , I write a wepack plugin to transform async to es5 \n`class BabelTransformAsyncPlugin {\n apply(compiler) {\n compiler.hooks.compilation.tap(\n \"BabelTransformAsyncPlugin\",\n (compilation) => {\n compilation.hooks.optimizeChunkAssets.tapAsync(\n \"BabelTransformAsyncPlugin\",\n (chunks, done) => {\n chunks.forEach(function(chunk) {\n chunk.files.forEach(function(fileName) {\n var result = compilation.assets[fileName].source();\n console.log(fileName);\n if (fileName.endsWith(\".js\") && result.includes(\"async \")) {\n console.log(\"babel async trans\", fileName);\n\n result = require(\"@babel/core\").transformSync(result, {\n configFile: false,\n plugins: [\"@babel/plugin-transform-async-to-generator\"],\n }).code;\n // ...require(\"./babel.config\"),\n\n compilation.assets[fileName] = new ConcatSource(result);\n }\n });\n });\n done();\n }\n );\n }\n );\n }\n}`","author_login":"vanceeasleaf","author_association":"NONE","created_at":"2021-11-18T14:22:33+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066157408","fragment_type":"issue_comment","sequence":7,"text":"Hi @vanceeasleaf, Have you created the webapck plugin? If not how are you achieving the the top level await for IE11?","author_login":"siawo","author_association":"NONE","created_at":"2022-03-13T18:29:50+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100652054","fragment_type":"issue_comment","sequence":8,"text":"we discussed this internally so.. supporting promises on webpack side would require huge code transformation, that webpack in current version can not perform. There is a PR to add warning in case when output environment does not supports async/await.\n\nAs user you can:\n\n- build for environment that supports async/await\n- don't use top-level-await","author_login":"vankop","author_association":"MEMBER","created_at":"2022-04-16T12:21:42+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100777993","fragment_type":"issue_comment","sequence":9,"text":"@vankop Just wanted to make sure that this issue will be fixed in a future version of webpack right? adding a warning is a temporary solution I guess.","author_login":"williamjacobszoon","author_association":"NONE","created_at":"2022-04-17T00:37:59+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1859264378","fragment_type":"issue_comment","sequence":10,"text":"So I decided to write a plugin as well for this and put it on NPM: URL \n\nIt's kind of similar to the one pasted above by @vanceeasleaf in that it uses Babel, but with some key advantages:\n\n- Handles source maps\n- Operates on the modules directly before they are written to chunks instead of transforming the chunks, meaning Babel helper injections won't pollute the global scope and it still works if an \"eval\" `devTool` is used\n- Uses `@babel/preset-env` to be able to just specify targets and so that the generators can also be transpiled down to ES5 (just `plugin-transform-async-to-generator` is not enough)\n\nFunctionally it seems to work fine. The biggest issue I have is that it doesn't use `@babel/plugin-transform-runtime` because it's way too late in the Webpack process to handle injected imports. So if you have a lot of TLAs or even just 1 or 2 that permeate and result in a lot of downstream async modules, then the repeated helper and regenerator functions add up quickly in a large bundle. I plan to try and address this: URL \n\n@alexander-akait or @vankop if you have any ideas or advice on the best way to seamlessly add the `@babel/runtime` dependencies, I would appreciate it. I'm looking at doing something similar to the way `ProvidePlugin` works, but I'm just starting to get myself familiar with how the `InitFragment` class works. I'm not sure if there is a hook order that will work to replace the imports or if I need to flag and rebuild to make it work.","author_login":"steverep","author_association":"CONTRIBUTOR","created_at":"2023-12-17T19:52:21+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1859788502","fragment_type":"issue_comment","sequence":11,"text":"at least as I know there is no plan to support code transformation since this will require huge internal webpack changes. old `Dependency` design will no longer work since dependencies operate not on AST level of source code, but only insert/remove/change strings inside source code.\n\nUnfortunately, I am not familiar with babel, but I guess transforming top level await does not help.. since it is required to `await` module import. e.g. in example:\n\nmodule A\n\nconst a = await somePromise;\nexport { a }\n\nmodule B\n\nimport { a } from 'module-a';\n// here we should wait for promise 'somePromise'\n\nconsole.log(a);\n\nin case of transformation just async/await this will not work correctly since you need to transform hole module tree ( thats an issue with currect webpack design, we dont have all code as an AST internally )\n\nTo sum up. as a user you can do things that I mentions above + chunk transformation ( this will bring additional code unfortunately )","author_login":"vankop","author_association":"MEMBER","created_at":"2023-12-18T08:36:09+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[732602098],"is_known_query_context":false},{"document_id":"gh_comment_1861758787","fragment_type":"issue_comment","sequence":12,"text":"@vankop I think maybe you are misunderstanding how the plugin and transformations work. I don't think huge Webpack changes are necessary to support this.\n \n\nAs you probably know, Babel cannot transform top level await; it simply supports the syntax to possibly transpile the expression, but otherwise leaves the `await` as is. However, once the `await` is inside an `async` function,it transpiles that function by:\n1. Turning it into a generator function that yields a promise\n2. Turning that generator into a regular function using a state machine that returns the promise\n \n\nThat's not necessary. Once Webpack wraps the original module in an `async function`, the new modified module can be transformed by Babel with no other knowledge of the tree. My plugin does this by tapping into the `renderModuleContent` hook in the `JavascriptModulesPlugin`, so right before it gets wrapped in a container for the chunk. This works fine.\n\nThe enhancement I'd like to make is regarding helper code. As part of that transformation, Babel inserts some expensive helpers at the top of the module:\n\njs\nvar helper1 = function (...) // expensive state machine function\nvar helper2 = function (...) // expensive asyncToGenerator converter function\n... // Transpiled version of async-wrapped module\n\nInstead of repeating those expensive helpers over and over again, Babel can instead import them from the `@babel/runtime` package:\n\njs\nvar helper1 = require(\"@babel/runtime/helper1\");\nvar helper2 = require(\"@babel/runtime/helper2\");\n... // Transpiled version of async-wrapped module\n\nSo my question is: is there a way I can not repeat those helpers by replacing those requires with something Webpack understands? From what I can see, there's no way to add dependencies at that stage as the graphs are already built and optimized. And there's no way to know which modules are wrapped in async functions without building and optimizing the graph first. Correct me if I'm wrong there.\n\nMy only thought was to flag the async modules on 1st pass, then add the dependencies on a call to `module.rebuild()`, but that seems risky as the graph could keep changing? Or maybe the helpers could be added to Webpack's runtime code somehow to avoid all that?","author_login":"steverep","author_association":"CONTRIBUTOR","created_at":"2023-12-18T22:00:13+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1862116873","fragment_type":"issue_comment","sequence":13,"text":"you need to do this on loader level. `modulGraph.isAsync` returns `true` for any module that imports top-level-await module.","author_login":"vankop","author_association":"MEMBER","created_at":"2023-12-19T04:55:25+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1862781307","fragment_type":"issue_comment","sequence":14,"text":"I don't see how to use the loader interface to accomplish it at all. You don't know where the TLAs are without parsing and you don't know which others import it until the whole graph is finished, right?\n\nThese imports also cannot be treated like any other dependency because then they'll be wrapped inside the async function. They need to be in the module scope.","author_login":"steverep","author_association":"CONTRIBUTOR","created_at":"2023-12-19T13:41:35+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1869074229","fragment_type":"issue_comment","sequence":15,"text":"Let's keep open if sombody wants to improve it, right now I think we need to output a warning for our users to prevent some problems on production (when you have lower the `target` option)","author_login":"alexander-akait","author_association":"MEMBER","created_at":"2023-12-25T18:12:49+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2135823219","fragment_type":"issue_comment","sequence":16,"text":"For anyone interested, I did make the plugin I wrote work with `@babel/runtime` pretty seamlessly, so I consider it pretty much a finished product that I'll make an effort to maintain.\n\n@alexander-akait I'm not sure what criteria you'd hope to achieve to close this, but I could certainly offer a PR to point the docs and/or error message to my plugin. Alternatively, I could try putting it directly in Webpack, but that would be a big chore for me and introduce a dependency on Babel that I'm not sure would be desired.\n\nIMO, a solution here without using an external transpiler certainly has advantages, but in the end reinvents the wheel and becomes unnecessarily burdensome for Webpack maintainers.","author_login":"steverep","author_association":"CONTRIBUTOR","created_at":"2024-05-28T17:57:35+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2137692649","fragment_type":"issue_comment","sequence":17,"text":"@steverep Thank you for your work and link, let's put it in our docs on site :+1:","author_login":"alexander-akait","author_association":"MEMBER","created_at":"2024-05-29T15:27:08+08:00","repo_name":"webpack/webpack","issue_id":732602098,"issue_number":11874,"issue_url":"https://github.com/webpack/webpack/issues/11874","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0401","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Feature Request] Add support for NovelAI v4 structure?","query_context":"NovelAI's v4 model features a new png data format, and chooses to use this new form and the older form that DiffusionToolkit recognizes seemingly at random. I tested with the same prompts, changing no settings, but generated images will still switch between the two formats.\n\nDiffusionToolkit will recognize and display the image with this format: \n\nImage\n\nBut does not detect another image that has the same prompt and settings, but in this format:\n\nImage\n\nThis is the only difference I can find between the two images, but I'm not very savvy with this kind of stuff.\nIf you could take a look and see if you could make DiffusionToolkit able to detect and display images with this new format, it would be greatly appreciated. Thanks :)","known_context_document_ids":["gh_issue_2892616500"],"reference_answer":"Thanks for finding this.\n\nThis build should resolve your issue while I am adding features and bug fixes for the next release.\n\n URL","answer_document_id":"gh_comment_2365310179","silver_evidence_path":["gh_comment_2741592696","gh_issue_2537846635","gh_comment_2365310179"],"evidence_issue_ids":[2892616500,2537846635],"source_repo_name":"RupertAvery/DiffusionToolkit","source_issue_id":2892616500,"source_issue_number":279,"source_issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","target_repo_name":"RupertAvery/DiffusionToolkit","target_issue_id":2537846635,"target_issue_number":259,"target_issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/259","reference_anchor_document_id":"gh_comment_2741592696","reference_answer_author":"RupertAvery","reference_answer_author_association":"OWNER","quality_score":86.67,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0833,"anchor_target_overlap":0.1389,"target_answer_overlap":0.2143},"issue_created_at":"2025-03-04T00:26:30+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2892616500","fragment_type":"issue_description","sequence":0,"text":"[Feature Request] Add support for NovelAI v4 structure\nNovelAI's v4 model features a new png data format, and chooses to use this new form and the older form that DiffusionToolkit recognizes seemingly at random. I tested with the same prompts, changing no settings, but generated images will still switch between the two formats.\n\nDiffusionToolkit will recognize and display the image with this format: \n\nImage\n\nBut does not detect another image that has the same prompt and settings, but in this format:\n\nImage\n\nThis is the only difference I can find between the two images, but I'm not very savvy with this kind of stuff.\nIf you could take a look and see if you could make DiffusionToolkit able to detect and display images with this new format, it would be greatly appreciated. Thanks :)","author_login":"NDWaffles","author_association":"NONE","created_at":"2025-03-04T00:26:30+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2699149401","fragment_type":"issue_comment","sequence":1,"text":"Recognized by toolkit:\n\nImage\n\nNot recognized by toolkit:\n\nImage","author_login":"NDWaffles","author_association":"NONE","created_at":"2025-03-04T22:45:48+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2739379478","fragment_type":"issue_comment","sequence":2,"text":"I've loaded the images into my toolkit and I'm seeing that both of them have metadata. Am I missing something?\n\nImage\n\nImage","author_login":"RupertAvery","author_association":"OWNER","created_at":"2025-03-20T06:51:20+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2741048426","fragment_type":"issue_comment","sequence":3,"text":"I'll attach one with more character prompts, the metadata works but it only shows under others (Not sure if there's a convenient way to work for that). I'm on the bugfix version from sept 21, and the metadata does show up fine for me.\nI think there were some issues with NAI metadata in the august release, which is still the current one if they aren't on anything more recent.\nImage","author_login":"Kluvwen","author_association":"NONE","created_at":"2025-03-20T16:33:01+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2741592696","fragment_type":"issue_comment","sequence":4,"text":"Ah.\nIt seems I'm having the exact same issue Kluvwen was having before in this issue: \n URL \n\nSince it was only NAI images not showing (local images are totally unaffected), I assumed it was a different problem. So I apologize for not following the fix from that post before.\n\nBut now, when I try to follow the link at URL , I get a \" Failed to generate URL to download artifact. \" error. Would that be caused by the issue being closed now?","author_login":"NDWaffles","author_association":"NONE","created_at":"2025-03-20T20:30:22+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[2537846635],"is_known_query_context":false},{"document_id":"gh_comment_2742143258","fragment_type":"issue_comment","sequence":5,"text":"Managed to fix the images that were not showing up by installing through the \"Build through source\" method. I see now that this issue was already fixed, and I was just using a wrong version. Thanks for the comment Kluvwen, made me realize what was going wrong. Again, sorry for the trouble","author_login":"NDWaffles","author_association":"NONE","created_at":"2025-03-21T03:15:39+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2754395715","fragment_type":"issue_comment","sequence":6,"text":"Sorry, yes it was probably fixed in recent code.\n\nBuild artifacts are only up for a limited time so it probably expired.","author_login":"RupertAvery","author_association":"OWNER","created_at":"2025-03-26T13:25:42+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2892616500,"issue_number":279,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/279","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2537846635","fragment_type":"issue_description","sequence":0,"text":"[BUG] Image not displayed, The given key was not present\nUsing primarily Novel AI, the error The given key was not present in the dictionary. has been occurring frequently as of some updates from them.\n9/20/2024 12:26:56 AM: An error occurred while reading C:\\Users\\Kluvw\\Downloads\\AI\\_{{{{{zero pictured}}}}}, castle s-3338614828.png: The given key was not present in the dictionary.\n\n at System.Text.Json.JsonElement.GetProperty(String propertyName)\n at Diffusion.IO.Metadata.ReadFooocusMREParameters(String data)\n at Diffusion.IO.Metadata.ReadFromFile(String file)\n at Diffusion.IO.MetadataScanner.Scan(IEnumerable`1 files)+MoveNext()\n**Version:**\nDiffusion Toolkit 1.7 Fix\n\n**Tool:**\nNovelAI\n\n**To Reproduce**\nThis isn't happenning with every image, however it is happening frequently, with no change in prompt or methodology.\n\n**Expected behavior**\nThis is not expected, particularly images not showing at all, I was not aware this was an issue for some time until one I'd just added wasn't showing up and checking the log.\n\n**Affected Image(s)**\n_{{{{{zero pictured}}}}}, castle s-3338614828\n\nIf possible, it would be preferable to show images even if they're producing an error if error allows for images to be shown.","author_login":"Kluvwen","author_association":"NONE","created_at":"2024-09-20T04:32:29+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2537846635,"issue_number":259,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2365310179","fragment_type":"issue_comment","sequence":1,"text":"Thanks for finding this.\n\nThis build should resolve your issue while I am adding features and bug fixes for the next release.\n\n URL","author_login":"RupertAvery","author_association":"OWNER","created_at":"2024-09-21T20:24:29+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2537846635,"issue_number":259,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/259","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2365411121","fragment_type":"issue_comment","sequence":2,"text":"Yes keep it open for now in case anyone else has the same issue, thanks!","author_login":"RupertAvery","author_association":"OWNER","created_at":"2024-09-22T01:53:12+08:00","repo_name":"RupertAvery/DiffusionToolkit","issue_id":2537846635,"issue_number":259,"issue_url":"https://github.com/RupertAvery/DiffusionToolkit/issues/259","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0403","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"The window is not responding?","query_context":"Type: Performance Issue \n\nThe window is not responding, You can reopen the window or keep writing.\n\nVS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)\nOS version: Windows_NT x64 10.0.19045\nModes:\nSandboxed: Yes\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx (8 x 2096)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled|\n|Load (avg)|undefined|\n|Memory (System)|5.95GB (2.28GB free)|\n|Process Argv|C:\\\\Users\\\\m4n0c\\\\OneDrive\\\\Desktop --crash-reporter-id 46fc3c4d-4e2c-46c3-bdbe-81104efea636|\n|Screen Reader|no|\n|VM|0%|\n \n Process Info \n\nCPU % Mem MB PID Process\n 0 96 1380 code main\n 1 87 1424 window [2] (Issue Reporter)\n 0 48 2056 utility-network-service\n 0 133 2132 extensionHost [1]\n 0 27 5924 crashpad-handler\n 0 132 6596 window [1] (Welcome - Desktop - Visual Studio Code)\n 0 82 6776 fileWatcher [1]\n 0 164 7284 shared-process\n 0 80 4672 ptyHost\n 1 123 9992 gpu-process\n\n \n \n Workspace Info \n\n| Window (Welcome - Desktop - Visual Studio Code)\n| Folder (Desktop): 3 files\n| File types: lnk(2) ini(1)\n| Conf files:;\n\n \n Extensions (14) \n\nExtension|Author (truncated)|Version\n---|---|---\nblackbox|Bla|0.10.94\nbracket-pair-color-dlw|Bra|0.0.6\npython|ms-|2023.8.0\nvscode-pylance|ms-|2023.5.30\njava|red|1.18.0\nLiveServer|rit|5.7.9\nintellicode-api-usage-examples|Vis|0.2.7\nvscodeintellicode|Vis|1.2.30\nvscode-java-debug|vsc|0.50.0\nvscode-java-dependency|vsc|0.22.0\nvscode-java-pack|vsc|0.25.11\nvscode-java-test|vsc|0.38.2\nvscode-maven|vsc|0.41.0\nJavaScriptSnippets|xab|1.8.0\n\n \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383cf:30185419\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\nvserr242cf:30382550\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263:30335439\nvscorecescf:30445987\nvscod805cf:30301675\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\ncmake_vspar411:30581797\nvsaa593cf:30376535\npythonvs932:30410667\ncppdebug:30492333\nvsclangdc:30486549\nc4g48928:30535728\ndsvsc012:30540252\npynewext54:30695312\nazure-dev_surveyone:30548225\nvscccc:30610679\n3biah626:30602489\npyind779:30671433\n89544117:30613380\npythonsymbol12:30671437\nshowlangstatbar:30737416\nvsctsb:30748421\npythonms35:30701012\npythonfmttext:30731395\nfixshowwlkth:30730052\nhidesbindicator:30730055\npythongtdpath:30739704\n\n \n\n \n\n[tasklist]\n### Tasks","known_context_document_ids":["gh_issue_1723159846"],"reference_answer":"Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.\n\nHappy Coding!","answer_document_id":"gh_comment_1495910578","silver_evidence_path":["gh_comment_1560458262","gh_issue_1651278957","gh_comment_1495910578"],"evidence_issue_ids":[1723159846,1651278957],"source_repo_name":"microsoft/vscode","source_issue_id":1723159846,"source_issue_number":183290,"source_issue_url":"https://github.com/microsoft/vscode/issues/183290","target_repo_name":"microsoft/vscode","target_issue_id":1651278957,"target_issue_number":178962,"target_issue_url":"https://github.com/microsoft/vscode/issues/178962","reference_anchor_document_id":"gh_comment_1560458262","reference_answer_author":"VSCodeTriageBot","reference_answer_author_association":"COLLABORATOR","quality_score":79.55,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3636,"target_answer_overlap":0.0909},"issue_created_at":"2023-05-24T04:37:07+08:00","valid_comment_count":35,"fragments":[{"document_id":"gh_issue_1723159846","fragment_type":"issue_description","sequence":0,"text":"The window is not responding\nType: Performance Issue \n\nThe window is not responding, You can reopen the window or keep writing.\n\nVS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)\nOS version: Windows_NT x64 10.0.19045\nModes:\nSandboxed: Yes\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx (8 x 2096)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled|\n|Load (avg)|undefined|\n|Memory (System)|5.95GB (2.28GB free)|\n|Process Argv|C:\\\\Users\\\\m4n0c\\\\OneDrive\\\\Desktop --crash-reporter-id 46fc3c4d-4e2c-46c3-bdbe-81104efea636|\n|Screen Reader|no|\n|VM|0%|\n \n Process Info \n\nCPU % Mem MB PID Process\n 0 96 1380 code main\n 1 87 1424 window [2] (Issue Reporter)\n 0 48 2056 utility-network-service\n 0 133 2132 extensionHost [1]\n 0 27 5924 crashpad-handler\n 0 132 6596 window [1] (Welcome - Desktop - Visual Studio Code)\n 0 82 6776 fileWatcher [1]\n 0 164 7284 shared-process\n 0 80 4672 ptyHost\n 1 123 9992 gpu-process\n\n \n \n Workspace Info \n\n| Window (Welcome - Desktop - Visual Studio Code)\n| Folder (Desktop): 3 files\n| File types: lnk(2) ini(1)\n| Conf files:;\n\n \n Extensions (14) \n\nExtension|Author (truncated)|Version\n---|---|---\nblackbox|Bla|0.10.94\nbracket-pair-color-dlw|Bra|0.0.6\npython|ms-|2023.8.0\nvscode-pylance|ms-|2023.5.30\njava|red|1.18.0\nLiveServer|rit|5.7.9\nintellicode-api-usage-examples|Vis|0.2.7\nvscodeintellicode|Vis|1.2.30\nvscode-java-debug|vsc|0.50.0\nvscode-java-dependency|vsc|0.22.0\nvscode-java-pack|vsc|0.25.11\nvscode-java-test|vsc|0.38.2\nvscode-maven|vsc|0.41.0\nJavaScriptSnippets|xab|1.8.0\n\n \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383cf:30185419\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\nvserr242cf:30382550\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263:30335439\nvscorecescf:30445987\nvscod805cf:30301675\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\ncmake_vspar411:30581797\nvsaa593cf:30376535\npythonvs932:30410667\ncppdebug:30492333\nvsclangdc:30486549\nc4g48928:30535728\ndsvsc012:30540252\npynewext54:30695312\nazure-dev_surveyone:30548225\nvscccc:30610679\n3biah626:30602489\npyind779:30671433\n89544117:30613380\npythonsymbol12:30671437\nshowlangstatbar:30737416\nvsctsb:30748421\npythonms35:30701012\npythonfmttext:30731395\nfixshowwlkth:30730052\nhidesbindicator:30730055\npythongtdpath:30739704\n\n \n\n \n\n[tasklist]\n### Tasks","author_login":"Yashmodi071","author_association":"NONE","created_at":"2023-05-24T04:37:07+08:00","repo_name":"microsoft/vscode","issue_id":1723159846,"issue_number":183290,"issue_url":"https://github.com/microsoft/vscode/issues/183290","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1560458262","fragment_type":"issue_comment","sequence":1,"text":"/duplicate\n\nMarking as duplicate of URL Please let us know if McAfee is not installed on your PC, else use the instructions to resolve.","author_login":"gjsjohnmurray","author_association":"CONTRIBUTOR","created_at":"2023-05-24T04:58:27+08:00","repo_name":"microsoft/vscode","issue_id":1723159846,"issue_number":183290,"issue_url":"https://github.com/microsoft/vscode/issues/183290","linked_issue_ids":[1651278957],"is_known_query_context":false},{"document_id":"gh_comment_1560458680","fragment_type":"issue_comment","sequence":2,"text":"Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.\n\nHappy Coding!","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2023-05-24T04:58:59+08:00","repo_name":"microsoft/vscode","issue_id":1723159846,"issue_number":183290,"issue_url":"https://github.com/microsoft/vscode/issues/183290","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1651278957","fragment_type":"issue_description","sequence":0,"text":"Mcafee slowing down the application\nUpdate from @isidorn: McAfee team acknowledged this issue and are working on a fix. More details in this article with a **workaround** to exclude VS Code from being scanned:\n URL \n\n***\n\nType: Performance Issue \n\na week ago this issue started to happen. I don't know why the vs does't open fast like before. my pc performance is perfect and I have a very good specifications.\ncorei7\n16GB RAM\n4G vega nevidia\n\nand everytime I get a small window which has three options reopen, close, and wait program \n\nVS Code version: Code 1.77.0 (7f329fe6c66b0f86ae1574c2911b681ad5a45d63, 2023-03-29T10:02:16.981Z)\nOS version: Windows_NT x64 10.0.22621\nModes:\nSandboxed: No\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off|\n|Load (avg)|undefined|\n|Memory (System)|15.81GB (7.78GB free)|\n|Process Argv|--crash-reporter-id 8fd832f6-9de4-416f-89ae-88b2c3b75006|\n|Screen Reader|no|\n|VM|0%|\n \n Process Info \n\nCPU % Mem MB PID Process\n 0 99 43800 code main\n 0 28 9816 crashpad-handler\n 0 81 27452 fileWatcher [1]\n 0 227 43324 extensionHost [1]\n 0 114 17044 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node --max-old-space-size=3072 \"c:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js\" --serverMode partialSemantic --useInferredProjectPerProjectRoot --disableAutomaticTypingAcquisition --cancellationPipeName C:\\Users\\obada\\AppData\\Local\\Temp\\vscode-typescript\\439eb021dc574ea9b4a7\\tscancellation-97ea4191a10871dac99e.tmp* --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation --useNodeIpc)\n 0 81 37036 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node \"c:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\extensions\\json-language-features\\server\\dist\\node\\jsonServerMain\" --node-ipc --clientProcessId=43324)\n 0 168 40276 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node c:\\Users\\obada\\.vscode\\extensions\\streetsidesoftware.code-spell-checker-2.20.3\\packages\\_server\\dist\\main.js --node-ipc --clientProcessId=43324)\n 0 79 49752 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node c:\\Users\\obada\\.vscode\\extensions\\kisstkondoros.vscode-gutter-preview-0.30.0\\dist\\server.js --node-ipc --clientProcessId=43324)\n 0 124 50104 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node --max-old-space-size=3072 \"c:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\resources\\app\\extensions\\node_modules\\typescript\\lib\\tsserver.js\" --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName C:\\Users\\obada\\AppData\\Local\\Temp\\vscode-typescript\\439eb021dc574ea9b4a7\\tscancellation-c1b3d0dc3cb7c5eb634d.tmp* --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation --useNodeIpc)\n 0 83 13592 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node \"c:/Users/obada/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/typescript/lib/typingsInstaller.js\" --globalTypingsCacheLocation C:/Users/obada/AppData/Local/Microsoft/TypeScript/5.0 --enableTelemetry --typesMapLocation \"c:/Users/obada/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/typescript/lib/typesMap.json\" --validateDefaultNpmLocation)\n 0 77 51608 electron-nodejs (\"C:\\Users\\obada\\AppData\\Local\\Programs\\Microsoft VS Code\\Code.exe\" --ms-enable-electron-run-as-node c:\\Users\\obada\\.vscode\\extensions\\formulahendry.auto-rename-tag-0.1.10\\packages\\server\\dist\\serverMain.js --node-ipc --clientProcessId=43324)\n 0 88 44932 window [5] (Issue Reporter)\n 0 149 49156 gpu-process\n 0 198 49644 window [1] (getNumber.js - data-structure-algorethmes-udemy - Visual Studio Code)\n 0 48 49652 utility-network-service\n 0 104 51852 shared-process\n 0 79 11556 ptyHost\n\n \n \n Workspace Info \n\n| Window (getNumber.js - data-structure-algorethmes-udemy - Visual Studio Code)\n| Folder (data-structure-algorethmes-udemy): 48 files\n| File types: js(35)\n| Conf files:;\n\n \n Extensions (23) \n\nExtension|Author (truncated)|Version\n---|---|---\nvscode-color-picker|Ant|0.0.4\ngithub-markdown-preview|bie|0.3.0\nmarkdown-checkbox|bie|0.4.0\nmarkdown-emoji|bie|0.3.0\nmarkdown-footnotes|bie|0.1.1\nmarkdown-mermaid|bie|1.18.0\nmarkdown-preview-github-styles|bie|1.0.1\nmarkdown-yaml-preamble|bie|0.1.0\npath-intellisense|chr|2.8.4\nvscode-markdownlint|Dav|0.49.0\ngitlens|eam|13.4.0\nvscode-html-css|ecm|1.13.1\nprettier-vscode|esb|9.10.4\nauto-rename-tag|for|0.1.10\ncode-runner|for|0.12.0\nvscode-pull-request-github|Git|0.62.0\nvscode-gutter-preview|kis|0.30.0\nemoji-icons|mig|1.5.2\ncolorful-comments|Par|1.0.0\nmaterial-icon-theme|PKi|4.25.0\nLiveServer|rit|5.7.9\ncode-spell-checker|str|2.20.3\nmaterial-theme|zhu|3.15.8\n\n \n A/B Experiments \n\nvsliv368cf:30146710\nvsreu685:30147344\npython383:30185418\nvspor879:30202332\nvspor708:30202333\nvspor363:30204092\nvslsvsres303:30308271\nvserr242cf:30382550\npythontb:30283811\nvsjup518:30340749\npythonptprofiler:30281270\nvshan820:30294714\nvstes263cf:30335440\npythondataviewer:30285071\nvscod805cf:30301675\nbinariesv615:30325510\nbridge0708:30335490\nbridge0723:30353136\ncmake_vspar411:30581797\nvsaa593cf:30376535\npythonvs932:30410667\ncppdebug:30492333\nvscaat:30438848\nvsclangdc:30486549\nc4g48928:30535728\ndsvsc012cf:30540253\npynewext54:30695312\nazure-dev_surveyone:30548225\nnodejswelcome1cf:30587006\n282f8724:30602487\npyind779:30671433\nf6dab269:30613381\npythonsymbol12:30671437\n2i9eh265:30646982\nvsccsb:30677849\nvscodedisable:30660115\npythonb192:30669360\nfunctionswalk:30687959\npythonms35:30701012","author_login":"ObadaMoustafa","author_association":"NONE","created_at":"2023-04-03T03:51:00+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1495909829","fragment_type":"issue_comment","sequence":1,"text":"/needsMoreInfo\n\nPlease use this guide to provide more information: URL Thanks.","author_login":"jrieken","author_association":"MEMBER","created_at":"2023-04-04T12:44:55+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1495910578","fragment_type":"issue_comment","sequence":2,"text":"Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.\n\nHappy Coding!","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2023-04-04T12:45:28+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497071993","fragment_type":"issue_comment","sequence":3,"text":"Do you have McAfee antivirus installed, we had reports URL , URL with the AV slowing down startup with recent update.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-04-05T07:54:23+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497300531","fragment_type":"issue_comment","sequence":4,"text":"@deepak1556 Thanks it works fine now after putting the `code.exe` file in the exclude list in McAfee.","author_login":"ObadaMoustafa","author_association":"NONE","created_at":"2023-04-05T11:01:03+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1497392400","fragment_type":"issue_comment","sequence":5,"text":"Thanks for confirming, I will keep this open to track duplicates.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-04-05T12:17:43+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1540111100","fragment_type":"issue_comment","sequence":6,"text":"OK, so I'd venture and dare to say: don't use McAfee. There are better AV solutions out there.\nI know it's not what some people want to hear, though :-)","author_login":"lorand-horvath","author_association":"NONE","created_at":"2023-05-09T13:18:56+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1543836137","fragment_type":"issue_comment","sequence":7,"text":"Can users impacted provide the trace following the steps below to help us understand why the process launches are slow on your device, thanks!\n\n* Open `Windows Performance Recorder` from system start menu\n* Have the following settings\n\nScreenshot 2022-08-23 200440\n\n* Start the recorder\n* Open the application\n* Once the editor has completely loaded, stop the recorder and save the profile\n* Send the profile to Deepak.Mohan@microsoft.com instead of attaching to this issue, since it will contain sensitive information.","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-05-11T11:37:06+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1546191497","fragment_type":"issue_comment","sequence":8,"text":"Slow and unresponsive startup is temporarily solved by excluding the code.exe file from mcafee realtime scanning. This has to be done daily though. I just bought mcafee for another year, what to do?","author_login":"Johng117","author_association":"NONE","created_at":"2023-05-12T19:32:41+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1546227285","fragment_type":"issue_comment","sequence":9,"text":"Honestly, I would uninstall it and install Avast Free from the offline installer URL \nBut YMMV.","author_login":"lorand-horvath","author_association":"NONE","created_at":"2023-05-12T20:04:49+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1546658414","fragment_type":"issue_comment","sequence":10,"text":"@Johng117 this didn't happened with me. Once I excluded the code.exe file I didn't need to do it again. but I remember that I only need to do that when I update vscode then I need to exclude it again. it's not a big deal for me and I am okay with it.","author_login":"ObadaMoustafa","author_association":"NONE","created_at":"2023-05-13T13:55:03+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1546877917","fragment_type":"issue_comment","sequence":11,"text":"Yeah, its not that big a deal. VsCode seems to update daily for me though. I might try and see if I can limit the uploads to once a week?","author_login":"Johng117","author_association":"NONE","created_at":"2023-05-14T11:32:11+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1547360886","fragment_type":"issue_comment","sequence":12,"text":"I haven't received any profiles yet, asked in URL it would be great if the affected users can provide one to help us move this issue forward, thanks!","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-05-15T07:51:51+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[1651278957],"is_known_query_context":false},{"document_id":"gh_comment_1550492086","fragment_type":"issue_comment","sequence":13,"text":"Hello Everyone,\n\nThanks for the guidance. I have included `code.exe` file in the `excluded files` list in McAfee but i feel its not a good practice to do so. The purpose of antivirus is to scan the system for viruses etc.\n\nIs there is a more feasible solution for this ?","author_login":"venkatrahul-software-development","author_association":"NONE","created_at":"2023-05-16T23:43:32+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1550511868","fragment_type":"issue_comment","sequence":14,"text":"I tested with extensions settings and starting up VS Code via `code --disable-extensions` is actually lot more faster even without including `code.exe` file in the `excluded files` list in McAfee. The above command temporarily disables extensions and clicking on `reload and enable extensions` as shown in screenshot below is loading all extensions as before.\n\nPlease see the screenshot below:\nExtensions-Settings\n\nI also tried with `Help: Start Extension Bisect` from Command Palette and opened this issue cmake related to cmake plugin\n\nThanks everyone","author_login":"venkatrahul-software-development","author_association":"NONE","created_at":"2023-05-17T00:13:44+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560472621","fragment_type":"issue_comment","sequence":15,"text":"@venkatrahul-software-development please see URL \n\nIndeed **anyone** with the problem could help by responding to that call for information by @deepak1556","author_login":"gjsjohnmurray","author_association":"CONTRIBUTOR","created_at":"2023-05-24T05:20:05+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[1651278957],"is_known_query_context":false},{"document_id":"gh_comment_1573565141","fragment_type":"issue_comment","sequence":16,"text":"Thank you so much, the issue is resolved. Turns out it was McAfee that was slowing the application.","author_login":"elvislobo472","author_association":"NONE","created_at":"2023-06-02T11:13:43+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1587928062","fragment_type":"issue_comment","sequence":17,"text":"Hello I'm facing the same issue of extremely high loading time. I don't use McAfee. Does this issue also reproduce for Windows Defender.","author_login":"srshah27","author_association":"NONE","created_at":"2023-06-12T19:12:13+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1596136881","fragment_type":"issue_comment","sequence":18,"text":"Same issue here. It was really painful to start vs code. And I'm working on a Next.js project, and it was taking ages to refresh it on the page after saving a file. I tried different things to solve this problem here, but nothing worked (I have McAfee installed on my machine, but didn't realize this could be the problem) ... but then, two or three days ago, after an vs code update was launched (not sure) the problem was gone. It's staring real fast and everything works fine now! Thanks a lot! 😁👍","author_login":"siqueira-gustavo","author_association":"NONE","created_at":"2023-06-18T13:06:10+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1596526219","fragment_type":"issue_comment","sequence":19,"text":"TREND security agent also has this problem\n\nDisable TREND security agent can solve","author_login":"we684123","author_association":"NONE","created_at":"2023-06-19T05:23:56+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1601082572","fragment_type":"issue_comment","sequence":20,"text":"Hi...happy to help 😁. \n\nRegarding the flags, I added code.exe back to Mcafee scanning and ran the above command. The launch was still laggy and made no difference.","author_login":"Neil-140301","author_association":"NONE","created_at":"2023-06-21T15:43:43+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1601096214","fragment_type":"issue_comment","sequence":21,"text":"Thanks for confirming, in your traces the processes were all sandboxed. The flags were to confirm if disabling the sandbox made any difference, but seems like it doesn't which is good to know. Apart from the launch delay, do you see any `The window is not responding` messages and is the application responsive as when excluding the binary from Mcafee ?","author_login":"deepak1556","author_association":"CONTRIBUTOR","created_at":"2023-06-21T15:52:33+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1603749868","fragment_type":"issue_comment","sequence":22,"text":"The application remains unresponsive/laggy and I still get the \"The window is not responding\" messages on launch. As of now the best solution has been excluding the file from scanning giving no problems.","author_login":"Neil-140301","author_association":"NONE","created_at":"2023-06-23T06:36:36+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1614918659","fragment_type":"issue_comment","sequence":23,"text":"Hi,\nHow to do this?\nLike how to add this code.exe file in excluded file list?","author_login":"GuptajiRocks","author_association":"NONE","created_at":"2023-06-30T16:50:57+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1614946098","fragment_type":"issue_comment","sequence":24,"text":"The McAfee app has a section called Real time scanning. If you open that it has a button to add files to exclude from scanning.\n\nThe path to code.exe is something like \n\nC:\\Users\\{UserName}\\AppData\\Local\\Programs\\Microsoft\\vscode","author_login":"Neil-140301","author_association":"NONE","created_at":"2023-06-30T17:15:42+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1616524321","fragment_type":"issue_comment","sequence":25,"text":"McAfee does real time scanning, and this's probably the reason vs code is running slow (since its scanning vs code too). You can exclude vs code from McAfee scanner.","author_login":"rohankishore","author_association":"NONE","created_at":"2023-07-02T09:29:43+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1623280101","fragment_type":"issue_comment","sequence":26,"text":"We have contacted the McAfee team and they acknowledged this issue and are working on a fix. More details in this article with a **workaround** to exclude VS Code from being scanned:\n URL","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-07-06T09:10:59+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1626419340","fragment_type":"issue_comment","sequence":27,"text":"You cant just exclude files in organizations. Most users in orgs have 0 control over that. Unfortunately.","author_login":"jamespack","author_association":"NONE","created_at":"2023-07-08T01:45:00+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1634813778","fragment_type":"issue_comment","sequence":28,"text":"assets/images/marketplace/marketplace-transactions.png #187774","author_login":"Malithdananjana","author_association":"NONE","created_at":"2023-07-13T19:46:27+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1662686370","fragment_type":"issue_comment","sequence":29,"text":"Update from McAfee: the McAfee release that will tackle this issue is planned for end of August. \nThank you","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-08-02T17:46:10+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1667070680","fragment_type":"issue_comment","sequence":30,"text":"see. Here are some things you can try to fix the performance issue with Visual Studio Code:\n\nDisable hardware acceleration. This can sometimes help to improve performance. To do this, open the Command Palette (Ctrl+Shift+P) and run the Preferences: Configure Runtime Arguments command. In the argv.json file that opens, add the following line:\n\"disable-hardware-acceleration\": true\nDisable extensions. If you have a lot of extensions installed, they can sometimes slow down Visual Studio Code. To disable extensions, open the Extensions pane (Ctrl+Shift+X) and uncheck the boxes next to the extensions you want to disable.\n\nReset Visual Studio Code. This will restore Visual Studio Code to its default settings. To do this, open the Command Palette (Ctrl+Shift+P) and run the Reset Visual Studio Code command.\n\nUpdate Visual Studio Code. There may be a newer version of Visual Studio Code available that fixes the performance issue. To check for updates, open the Command Palette (Ctrl+Shift+P) and run the Check for Updates command.\n\nIf you have tried all of these things and the performance issue is still happening, you can try contacting Microsoft support for help.\n\nHere are some additional troubleshooting tips that you can try:\n\nCheck your CPU and memory usage to see if there is anything else that is running that is using up a lot of resources.\nMake sure that you have enough disk space available.\nTry restarting your computer.\nUpdate your graphics card drivers.\nI hope this helps! Let me know if you have any other questions.","author_login":"myabanky","author_association":"NONE","created_at":"2023-08-07T01:53:34+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1667072971","fragment_type":"issue_comment","sequence":31,"text":"Thank you for providing the information. I understand that Visual Studio Code can slow down when McAfee software is installed. This is because the Real-Time Scanner in McAfee scans a specific Visual Studio program file, which can cause a delay when opening or using Visual Studio Code.\n\nTo work around this issue, you can exclude the Visual Studio file from being scanned by McAfee. To do this, follow the steps below:\n\nOpen LiveSafe or Total Protection.\nOn the left menu, click the My Protection Widgets icon in McAfee security software for Windows tab.\nClick Real-Time Scanning.\nClick Add file.\nBrowse to find the code.exe file. This file can usually be found in the following location:\nC:\\Users\\(USERNAME)\\AppData\\Local\\Programs\\Microsoft VS Code\\code.exe\nWith code.exe selected, click Open. The file is now excluded.\nOpen Visual Studio Code to confirm that it opens without a delay.\nIf your installation of Visual Studio is updated before McAfee fixes this issue, you will need to exclude the code.exe file again. This is because when code.exe is updated, your McAfee software sees it as a new executable file that has not yet been excluded.\n\nI hope this helps!","author_login":"myabanky","author_association":"NONE","created_at":"2023-08-07T01:57:02+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1689979739","fragment_type":"issue_comment","sequence":32,"text":"Update from McAfee: the fix got delayed and is now planned for the release at end of September.","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-08-23T13:35:54+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1778786770","fragment_type":"issue_comment","sequence":33,"text":"Update from McAfee: It took longer than expected to push the release with the fix out, but it is finally deployed to production.\nIt will take about 2 weeks to rollout it to most of our users.\nPlease note, with the current implementation after system restart the very first launch of VS Code will be still slow, this will be addressed with our next release in the first half of November.\n\nThus I am closing this issue as done 👏 Thanks everyone for the patience.\n\n@joaomoreno we can keep it pinned for 10 more days until the McAfee rollout is completed.","author_login":"isidorn","author_association":"CONTRIBUTOR","created_at":"2023-10-25T08:39:05+08:00","repo_name":"microsoft/vscode","issue_id":1651278957,"issue_number":178962,"issue_url":"https://github.com/microsoft/vscode/issues/178962","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0404","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Android] Android x86 emulator failures in System.Diagnostics.DiagnosticSource runtime metrics?","query_context":"## Build Information\nBuild: URL \nBuild error leg or test failing: `System.Diagnostics.DiagnosticSource.Tests`\nAffected CI: `android_x86_release_allsubsets_mono` (`runtime-extra-platforms`)\n\nStack trace example:\n\n07-20 10:08:58.329 16840 16860 I DOTNET : 1) [FAIL] System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount Test name: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount\n07-20 10:08:58.329 16840 16860 I DOTNET : Assembly: [System.Diagnostics.DiagnosticSource.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]\n07-20 10:08:58.329 16840 16860 I DOTNET : Exception messages: Expected to find a measurement for 'gen0'. Exception stack traces: at System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount() in /_/src/libraries/System.Diagnostics.DiagnosticSource/tests/RuntimeMetricsTests.cs:line 111\n07-20 10:08:58.329 16840 16860 I DOTNET : at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)\n07-20 10:08:58.329 16840 16860 I DOTNET : at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)\n\n \n## Error Message\n\nFill the error message using step by step known issues guidance.\n\n \n\njson\n{\n \"ErrorMessage\": \"Expected to find a measurement for 'gen0'\",\n \"BuildRetry\": false,\n \"ExcludeConsoleLog\": false\n}\n\n \n ### Known issue validation\n**Build: :mag_right:** URL \n**Error message validated:** `[Expected to find a measurement for 'gen0'`]\n**Result validation:** :white_check_mark: Known issue matched with the provided build.\n**Validation performed at:** 7/21/2024 4:49:54 PM UTC\n \n \n\n### Report\n\n|Build|Definition|Test|Pull Request|\n|---|---|---|---|\n|758343|dotnet/runtime|System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount||\n|748618|dotnet/runtime|System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount||\n#### Summary\n|24-Hour Hit Count|7-Day Hit Count|1-Month Count|\n|---|---|---|\n|0|1|2|","known_context_document_ids":["gh_issue_2421519076"],"reference_answer":"Thank you, would you like to open a PR to disable them or should I take a look?\n\nDo you know if this is an issue that should be fixed on the Mono runtime side or is it by design of the test? It looks like only a few tests are failing so I suppose the `RuntimeMetricsTests` suit isn't CoreCLR specific.","answer_document_id":"gh_comment_2243499324","silver_evidence_path":["gh_comment_2241710909","gh_issue_2421513481","gh_comment_2243499324"],"evidence_issue_ids":[2421519076,2421513481],"source_repo_name":"dotnet/runtime","source_issue_id":2421519076,"source_issue_number":105203,"source_issue_url":"https://github.com/dotnet/runtime/issues/105203","target_repo_name":"dotnet/runtime","target_issue_id":2421513481,"target_issue_number":105202,"target_issue_url":"https://github.com/dotnet/runtime/issues/105202","reference_anchor_document_id":"gh_comment_2241710909","reference_answer_author":"matouskozak","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2273,"anchor_target_overlap":0.1818,"target_answer_overlap":0.16},"issue_created_at":"2024-07-21T16:49:11+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2421519076","fragment_type":"issue_description","sequence":0,"text":"[Android] Android x86 emulator failures in System.Diagnostics.DiagnosticSource runtime metrics\n## Build Information\nBuild: URL \nBuild error leg or test failing: `System.Diagnostics.DiagnosticSource.Tests`\nAffected CI: `android_x86_release_allsubsets_mono` (`runtime-extra-platforms`)\n\nStack trace example:\n\n07-20 10:08:58.329 16840 16860 I DOTNET : 1) [FAIL] System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount Test name: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount\n07-20 10:08:58.329 16840 16860 I DOTNET : Assembly: [System.Diagnostics.DiagnosticSource.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]\n07-20 10:08:58.329 16840 16860 I DOTNET : Exception messages: Expected to find a measurement for 'gen0'. Exception stack traces: at System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount() in /_/src/libraries/System.Diagnostics.DiagnosticSource/tests/RuntimeMetricsTests.cs:line 111\n07-20 10:08:58.329 16840 16860 I DOTNET : at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)\n07-20 10:08:58.329 16840 16860 I DOTNET : at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)\n\n \n## Error Message\n\nFill the error message using step by step known issues guidance.\n\n \n\njson\n{\n \"ErrorMessage\": \"Expected to find a measurement for 'gen0'\",\n \"BuildRetry\": false,\n \"ExcludeConsoleLog\": false\n}\n\n \n ### Known issue validation\n**Build: :mag_right:** URL \n**Error message validated:** `[Expected to find a measurement for 'gen0'`]\n**Result validation:** :white_check_mark: Known issue matched with the provided build.\n**Validation performed at:** 7/21/2024 4:49:54 PM UTC\n \n \n\n### Report\n\n|Build|Definition|Test|Pull Request|\n|---|---|---|---|\n|758343|dotnet/runtime|System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount||\n|748618|dotnet/runtime|System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.GcCollectionsCount||\n#### Summary\n|24-Hour Hit Count|7-Day Hit Count|1-Month Count|\n|---|---|---|\n|0|1|2|","author_login":"matouskozak","author_association":"MEMBER","created_at":"2024-07-21T16:49:11+08:00","repo_name":"dotnet/runtime","issue_id":2421519076,"issue_number":105203,"issue_url":"https://github.com/dotnet/runtime/issues/105203","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2241710909","fragment_type":"issue_comment","sequence":1,"text":"Similarly to URL likely related to the new tests introduced in URL affecting only x86 Android emulator at the moment. Do you know if these tests should be disabled or same changes are needed for them to work on x86 Android emulators? @stevejgordon @tarekgh ?","author_login":"matouskozak","author_association":"MEMBER","created_at":"2024-07-21T16:52:14+08:00","repo_name":"dotnet/runtime","issue_id":2421519076,"issue_number":105203,"issue_url":"https://github.com/dotnet/runtime/issues/105203","linked_issue_ids":[2421513481],"is_known_query_context":false},{"document_id":"gh_comment_2242734498","fragment_type":"issue_comment","sequence":2,"text":"@matouskozak I'd say it's best and safe to disable these on the affected platforms.","author_login":"stevejgordon","author_association":"CONTRIBUTOR","created_at":"2024-07-22T11:31:20+08:00","repo_name":"dotnet/runtime","issue_id":2421519076,"issue_number":105203,"issue_url":"https://github.com/dotnet/runtime/issues/105203","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2421513481","fragment_type":"issue_description","sequence":0,"text":"[apple] Mobile failures in `System.Diagnostics.DiagnosticSource` runtime metrics\n## Build Information\nBuild: URL \nBuild error leg or test failing: `System.Diagnostics.DiagnosticSource.Tests`\nAffected CI: `[ios][tvos]simulator_x64_release_allsubsets_mono`, `maccatalyst_[x64/arm64]_release_allsubsests_mono` (`runtime-extra-platforms`)\nRange of commits: URL \n\nStack trace example from MacCatalyst x64:\n\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] 1) [FAIL] System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements Test name: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements (metricName: \"dotnet.jit.compiled_il.size\", valueAssertion: Func`2 { Method = System.ValueTuple`2[System.Boolean,System.String] b__21_1(Int64), Target = <>c { } }, beforeRecord: null) Test case: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] Assembly: [System.Diagnostics.DiagnosticSource.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] Exception messages: Expected value to be greater than zero. Actual value was: 0. Exception stack traces: at System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateSingleMeasurementInt64\n at System.Object.InvokeStub_RuntimeMetricsTests.ValidateMeasurements(Object , Span`1 )\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n Execution time: 0.1050582\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] 2) [FAIL] System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements Test name: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements (metricName: \"dotnet.jit.compiled_methods\", valueAssertion: Func`2 { Method = System.ValueTuple`2[System.Boolean,System.String] b__21_1(Int64), Target = <>c { } }, beforeRecord: null) Test case: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] Assembly: [System.Diagnostics.DiagnosticSource.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] Exception messages: Expected value to be greater than zero. Actual value was: 0. Exception stack traces: at System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateSingleMeasurementInt64\n at System.Object.InvokeStub_RuntimeMetricsTests.ValidateMeasurements(Object , Span`1 )\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n Execution time: 0.1024496\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] 3) [FAIL] System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements Test name: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements (metricName: \"dotnet.jit.compilation.time\", valueAssertion: Func`2 { Method = System.ValueTuple`2[System.Boolean,System.String] b__21_3(Double), Target = <>c { } }, beforeRecord: null) Test case: System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateMeasurements\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] Assembly: [System.Diagnostics.DiagnosticSource.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]\n2024-07-19 06:05:58.025 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] Exception messages: Expected value to be greater than zero. Actual value was: 0. Exception stack traces: at System.Diagnostics.Metrics.Tests.RuntimeMetricsTests.ValidateSingleMeasurementDouble\n at System.Object.InvokeStub_RuntimeMetricsTests.ValidateMeasurements(Object , Span`1 )\n2024-07-19 06:05:58.026 Df System.Diagnostics.DiagnosticSource.Tests[5417:db10] at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n Execution time: 0.1059831\n\n \n## Error Message\n\nFill the error message using step by step known issues guidance.\n\n \n\njson\n{\n \"ErrorMessage\": \"Expected value to be greater than zero. Actual value was: 0.\",\n \"BuildRetry\": false,\n \"ExcludeConsoleLog\": false\n}\n\n \n ### Known issue validation\n**Build: :mag_right:** URL \n**Error message validated:** `[Expected value to be greater than zero. Actual value was: 0.`]\n**Result validation:** :white_check_mark: Known issue matched with the provided build.\n**Validation performed at:** 7/21/2024 4:35:30 PM UTC\n \n \n\n### Report\n\n|Build|Definition|Test|Pull Request|\n|---|---|---|---|\n|758343|dotnet/runtime|System.Diagnostics.DiagnosticSource.Tests.WorkItemExecution||\n|755747|dotnet/runtime|System.Diagnostics.DiagnosticSource.Tests.WorkItemExecution||\n|751577|dotnet/runtime|System.Diagnostics.DiagnosticSource.Tests.WorkItemExecution||\n|750924|dotnet/runtime|System.Diagnostics.DiagnosticSource.Tests.WorkItemExecution||\n|748618|dotnet/runtime|System.Diagnostics.DiagnosticSource.Tests.WorkItemExecution||\n|747439|dotnet/runtime|System.Diagnostics.DiagnosticSource.Tests.WorkItemExecution||\n#### Summary\n|24-Hour Hit Count|7-Day Hit Count|1-Month Count|\n|---|---|---|\n|0|2|6|","author_login":"matouskozak","author_association":"MEMBER","created_at":"2024-07-21T16:33:29+08:00","repo_name":"dotnet/runtime","issue_id":2421513481,"issue_number":105202,"issue_url":"https://github.com/dotnet/runtime/issues/105202","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2241706830","fragment_type":"issue_comment","sequence":1,"text":"Possibly related to the new tests introduced in URL Do you know if these tests should be disabled or same changes are needed for them to work on Apple mobile targets? @stevejgordon @tarekgh ?","author_login":"matouskozak","author_association":"MEMBER","created_at":"2024-07-21T16:36:09+08:00","repo_name":"dotnet/runtime","issue_id":2421513481,"issue_number":105202,"issue_url":"https://github.com/dotnet/runtime/issues/105202","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2243070367","fragment_type":"issue_comment","sequence":2,"text":"@matouskozak I think we can safely skip this platform in the runtime metrics tests.","author_login":"stevejgordon","author_association":"CONTRIBUTOR","created_at":"2024-07-22T14:13:51+08:00","repo_name":"dotnet/runtime","issue_id":2421513481,"issue_number":105202,"issue_url":"https://github.com/dotnet/runtime/issues/105202","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2243499324","fragment_type":"issue_comment","sequence":3,"text":"Thank you, would you like to open a PR to disable them or should I take a look?\n\nDo you know if this is an issue that should be fixed on the Mono runtime side or is it by design of the test? It looks like only a few tests are failing so I suppose the `RuntimeMetricsTests` suit isn't CoreCLR specific.","author_login":"matouskozak","author_association":"MEMBER","created_at":"2024-07-22T17:50:16+08:00","repo_name":"dotnet/runtime","issue_id":2421513481,"issue_number":105202,"issue_url":"https://github.com/dotnet/runtime/issues/105202","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0406","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Bad integer for large problems with `--kron-mode sparse`?","query_context":"**Describe the bug**\nI believe a int overflow is causing higher level 1x3v mixed grid runs to fail when using `--kron-mode sparse`. This does not happen with `--kron-mode dense`\n\nHere's the result upon debugging: \n\nasgard: ~/asgard/src/distribution.hpp:269: double asgard::get_MB(int64_t) [with P = int; int64_t = long int]: Assertion `num_elems > 0' failed.\n\n**To Reproduce**\nSteps to reproduce the behavior:\nRun command \n\n./asgard -p riemann_1x3v -d 3 -l \"7 6 6 6\" -x -t 2.3419e-4 -n 210 -m 7 --kron-mode sparse --wave_freq 7 --inner_it 10 --tol 1e-8 --mixed_grid_group 1\n\n**Expected behavior**\nA clear and concise description of what you expected to happen.\n\n**System:**\n - andremarie","known_context_document_ids":["gh_issue_1916128056"],"reference_answer":"currently we are:\n\ncasting unsigned quantities (like `.size()` returns from STL) to signed quantities. where it is possible that `size()` is `>=INT_MAX`, we precede this case with an assertion.\n\nswitching to `ssize()` in C++20: URL should help.","answer_document_id":"gh_comment_569778305","silver_evidence_path":["gh_comment_1738064670","gh_issue_453943285","gh_comment_569778305"],"evidence_issue_ids":[1916128056,453943285],"source_repo_name":"project-asgard/asgard","source_issue_id":1916128056,"source_issue_number":641,"source_issue_url":"https://github.com/project-asgard/asgard/issues/641","target_repo_name":"project-asgard/asgard","target_issue_id":453943285,"target_issue_number":8,"target_issue_url":"https://github.com/project-asgard/asgard/issues/8","reference_anchor_document_id":"gh_comment_1738064670","reference_answer_author":"bmcdanie","reference_answer_author_association":"COLLABORATOR","quality_score":82.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1132,"anchor_target_overlap":0.0164,"target_answer_overlap":0.2},"issue_created_at":"2023-09-27T18:42:52+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1916128056","fragment_type":"issue_description","sequence":0,"text":"Bad integer for large problems with `--kron-mode sparse`\n**Describe the bug**\nI believe a int overflow is causing higher level 1x3v mixed grid runs to fail when using `--kron-mode sparse`. This does not happen with `--kron-mode dense`\n\nHere's the result upon debugging: \n\nasgard: ~/asgard/src/distribution.hpp:269: double asgard::get_MB(int64_t) [with P = int; int64_t = long int]: Assertion `num_elems > 0' failed.\n\n**To Reproduce**\nSteps to reproduce the behavior:\nRun command \n\n./asgard -p riemann_1x3v -d 3 -l \"7 6 6 6\" -x -t 2.3419e-4 -n 210 -m 7 --kron-mode sparse --wave_freq 7 --inner_it 10 --tol 1e-8 --mixed_grid_group 1\n\n**Expected behavior**\nA clear and concise description of what you expected to happen.\n\n**System:**\n - andremarie","author_login":"stefan-schnake","author_association":"CONTRIBUTOR","created_at":"2023-09-27T18:42:52+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1737965517","fragment_type":"issue_comment","sequence":1,"text":"Running with `CXXFLAGS=-fsanitize=undefined`\n\n$ ./asgard -p riemann_1x3v -d 3 -l \"7 6 6 6\" -x -t 2.3419e-4 -n 210 -m 7 --kron-mode sparse --inner_it 10 --tol 1e-8 --mixed_grid_group 1\nBranch: develop\nCommit Summary: 6d9cb87cd16c17c0ee53f5037e1f3a9bbdaec9b0\n Date: Fri Sep 22 09:22:33 2023 -0400\n Update OpenBLAS to v0.3.24\nThis executable was built on Wednesday, September 27 2023 at 3:25 pm\ngenerating: pde...\nASGarD problem configuration:\n selected PDE: riemann_1x3v\n degree: 3\n N steps: 210\n write freq: 0\n realspace freq: 0\n implicit: 0\n full grid: 0\n CFL number: 0.01\n Poisson solve: 0\n starting levels: 7 6 6 6 \n max adaptivity levels: 7\n--- begin setup ---\n generating: adaptive grid...\n degrees of freedom: 7133184\n generating: basis operator...\n basis operator allocation (MB): 0.0348816\n generating: dimension mass matrices...\n generating: initial conditions...\n degrees of freedom (post initial adapt): 7133184\n generating: coefficient matrices...\n generating: moment vectors...\n--- begin time loop staging ---\n--- begin time loop w/ dt 0.00023419 ---\n dim0 lev = 7\n dim1 lev = 6\n -- moment_mat map size = 7133184\n384\n -- moment_mat map size = 7133184\n384\n -- moment_mat map size = 7133184\n384\n -- moment_mat map size = 7133184\n384\n -- moment_mat map size = 7133184\n768\n -- moment_mat map size = 7133184\n768\n -- moment_mat map size = 7133184\n768\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:177:43: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:178:43: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:178:30: runtime error: shift exponent -1 is negative\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:178:43: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:177:30: runtime error: shift exponent -1 is negative\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:177:43: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:178:43: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'\n/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:178:43: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'","author_login":"quantumsteve","author_association":"COLLABORATOR","created_at":"2023-09-27T19:33:30+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738064670","fragment_type":"issue_comment","sequence":2,"text":"backtrace\n\n768\nasgard: /home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:173: bool asgard::check_connected(int, int, int, int): Assertion `L1 > 0 && L1 ::digits' failed.\n\nThread 1 \"asgard\" received signal SIGABRT, Aborted.\n__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50\n50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.\n(gdb) bt\n#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50\n#1 0x00007fffee087859 in __GI_abort () at abort.c:79\n#2 0x00007fffee087729 in __assert_fail_base (fmt=0x7fffee21d588 \"%s%s%s:%u: %s%sAssertion `%s' failed.\\n%n\", assertion=0x5555567dc508 \"L1 > 0 && L1 ::digits\", \n file=0x5555567dc3a0 \"/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp\", line=173, function= ) at assert.c:92\n#3 0x00007fffee098fd6 in __GI___assert_fail (assertion=0x5555567dc508 \"L1 > 0 && L1 ::digits\", file=0x5555567dc3a0 \"/home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp\", line=173, \n function=0x5555567dc4c8 \"bool asgard::check_connected(int, int, int, int)\") at assert.c:101\n#4 0x000055555605d84f in asgard::check_connected (L1=0, p1=0, L2=0, p2=0) at /home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:173\n#5 0x000055555605de92 in asgard::check_connected (num_dimensions=4, row=0x7fffdc08c010, col=0x7fffdc08c010) at /home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:226\n#6 0x0000555556061086 in asgard::compute_mem_usage (pde=..., discretization=..., program_options=..., imex=asgard::imex_flag::imex_explicit, spcache=..., memory_limit_MB=0, index_limit=2147483646, force_sparse=false)\n at /home/svh/Documents/asgard/src/asgard_kronmult_matrix.cpp:854\n#7 0x000055555601901c in asgard::matrix_list ::make (this=0x7fffffffcc70, entry=asgard::imex_explicit, pde=..., grid=..., opts=...) at /home/svh/Documents/asgard/src/asgard_kronmult_matrix.hpp:787\n#8 0x000055555601f5f8 in asgard::matrix_list ::reset_coefficients (this=0x7fffffffcc70, entry=asgard::imex_explicit, pde=..., grid=..., opts=...) at /home/svh/Documents/asgard/src/asgard_kronmult_matrix.hpp:851\n#9 0x0000555556009a6d in asgard::time_advance::imex_advance (pde=..., operator_matrices=..., adaptive_grid=..., transformer=..., program_opts=..., unscaled_parts=..., f_0=..., x_prev=..., time=0.00023419000000000001, \n solver=asgard::solve_opts::gmres, update_system=true) at /home/svh/Documents/asgard/src/time_advance.cpp:778\n#10 0x0000555556003592 in asgard::time_advance::adaptive_advance (step_method=asgard::time_advance::method::imex, pde=..., operator_matrices=..., adaptive_grid=..., transformer=..., program_opts=..., x_orig=..., \n time=0.00023419000000000001, update_system=true) at /home/svh/Documents/asgard/src/time_advance.cpp:73\n#11 0x0000555555d3eb18 in main (argc=22, argv=0x7fffffffd098) at /home/svh/Documents/asgard/src/main.cpp:270","author_login":"quantumsteve","author_association":"COLLABORATOR","created_at":"2023-09-27T20:54:47+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[453943285],"is_known_query_context":false},{"document_id":"gh_comment_1738076111","fragment_type":"issue_comment","sequence":3,"text":"Printing the indexes, we are getting an index of 31. Now digging in the index formation to see what went wrong.","author_login":"mkstoyanov","author_association":"CONTRIBUTOR","created_at":"2023-09-27T21:04:43+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738094166","fragment_type":"issue_comment","sequence":4,"text":"@quantumsteve I don't understand the trace. We count the levels from 0, even though we don't allow the user to work with level less than 1. We need at least two levels to form a \"wavelet\" basis.","author_login":"mkstoyanov","author_association":"CONTRIBUTOR","created_at":"2023-09-27T21:20:30+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738102273","fragment_type":"issue_comment","sequence":5,"text":"If `L1 <= 0` or `L2 <= 0` the bit shift would be by a negative number.\n\n URL","author_login":"quantumsteve","author_association":"COLLABORATOR","created_at":"2023-09-27T21:28:20+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738109173","fragment_type":"issue_comment","sequence":6,"text":"Is that considered an `overflow`? The case `L1=0` and `L2=0` exists in absolutely every grid we have ever used and tested.","author_login":"mkstoyanov","author_association":"CONTRIBUTOR","created_at":"2023-09-27T21:35:12+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738116328","fragment_type":"issue_comment","sequence":7,"text":"BTW @stefan-schnake did you enable memory limits in CMake when you compiled this?","author_login":"mkstoyanov","author_association":"CONTRIBUTOR","created_at":"2023-09-27T21:41:56+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738134177","fragment_type":"issue_comment","sequence":8,"text":"There is a small bug that throws us off in the error message, I'll fix that tonight.\n\nNevertheless, I think we are likely to run out of GPU memory for this problem and we may have to enable the memory limits (which in turn may cancel all benefits of going sparse).","author_login":"mkstoyanov","author_association":"CONTRIBUTOR","created_at":"2023-09-27T21:59:56+08:00","repo_name":"project-asgard/asgard","issue_id":1916128056,"issue_number":641,"issue_url":"https://github.com/project-asgard/asgard/issues/641","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_453943285","fragment_type":"issue_description","sequence":0,"text":"get rid of casts for signed/unsigned comparisons\nASGarD\n asgardasgard\n Issues\n #8\n\nOpen\nOpened 6 months ago by Graham Lopez\nClose issue\nNew issue\nget rid of casts for signed/unsigned comparisons\n\ncasting to get rid of signed/unsigned comparison compiler warnings is bad, in general. We always prefer signed integers in the code. We need to find the good way to deal with this.\nRelated issues\n0\n\n Graham Lopez @bgl added hygeine label 6 months ago\n Graham Lopez @bgl added someday label 5 months ago\n Graham Lopez\nGraham Lopez @bgl · 4 months ago\n\n@3bm take a look at this and let me know your thoughts URL","author_login":"grahamlopez","author_association":"COLLABORATOR","created_at":"2019-06-09T21:47:54+08:00","repo_name":"project-asgard/asgard","issue_id":453943285,"issue_number":8,"issue_url":"https://github.com/project-asgard/asgard/issues/8","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_569778305","fragment_type":"issue_comment","sequence":1,"text":"currently we are:\n\ncasting unsigned quantities (like `.size()` returns from STL) to signed quantities. where it is possible that `size()` is `>=INT_MAX`, we precede this case with an assertion.\n\nswitching to `ssize()` in C++20: URL should help.","author_login":"bmcdanie","author_association":"COLLABORATOR","created_at":"2019-12-30T19:52:06+08:00","repo_name":"project-asgard/asgard","issue_id":453943285,"issue_number":8,"issue_url":"https://github.com/project-asgard/asgard/issues/8","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0408","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"`stork-service-discovery-kubernetes` extension requires some extra configutation that is not documented?","query_context":"### Describe the bug\n\n`stork-service-discovery-kubernetes` requires `org.bouncycastle:bctls-jdk15on` dependency and also some extra configuration on your application.properties:\n\nExample \n\n# application properties should be here\nquarkus.security.security-providers=BCJSSE\n\nquarkus.http.ssl.certificate.key-store-file=server-keystore.jks\nquarkus.http.ssl.certificate.key-store-password=password\nquarkus.http.ssl.certificate.trust-store-file=server-truststore.jks\nquarkus.http.ssl.certificate.trust-store-password=password\n\nquarkus.native.additional-build-args=--allow-incomplete-classpath\n\nAlso, end-user must be sure that has the following K8s/ocp cluster roles binding (JVM and native mode):\n\nCluster Role\n\nkind: ClusterRole\napiVersion: rbac.authorization.k8s.io/v1\nmetadata:\n namespace: \"${NAMESPACE}\"\n name: endpoints-reader\nrules:\n - apiGroups: [\"\"] # \"\" indicates the core API group\n resources: [\"endpoints\"]\n verbs: [\"get\", \"watch\", \"list\"]\n\nClusterRoleBinding\n\napiVersion: rbac.authorization.k8s.io/v1\nkind: ClusterRoleBinding\nmetadata:\n name: fabric8-rbac\nsubjects:\n - kind: ServiceAccount\n # Reference to upper's `metadata.name`\n name: default\n namespace: \"${NAMESPACE}\"\nroleRef:\n kind: ClusterRole\n name: cluster-admin\n apiGroup: rbac.authorization.k8s.io\n\nI think that these requirements should be documented:\nDocRef: URL \n\nAlso would be great to understand why `org.bouncycastle:bctls-jdk15on` is needed and check if we could do something in order to avoid this extra dependency\n\nReproducer: URL \n\n### Expected behavior\n\n_No response_\n\n### Actual behavior\n\n_No response_\n\n### How to Reproduce?\n\n_No response_\n\n### Output of `uname -a` or `ver`\n\n_No response_\n\n### Output of `java -version`\n\n_No response_\n\n### GraalVM version (if different from Java)\n\n_No response_\n\n### Quarkus version or git rev\n\n_No response_\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\n_No response_\n\n### Additional information\n\n_No response_","known_context_document_ids":["gh_issue_1175257864"],"reference_answer":"Hi @edeandrea ,\n\nI've checked and seems that #25750 fixes this problem.\nLet me know if you need anything else.","answer_document_id":"gh_comment_1144756811","silver_evidence_path":["gh_comment_1131907234","gh_issue_1241990411","gh_comment_1144756811"],"evidence_issue_ids":[1175257864,1241990411],"source_repo_name":"quarkusio/quarkus","source_issue_id":1175257864,"source_issue_number":24444,"source_issue_url":"https://github.com/quarkusio/quarkus/issues/24444","target_repo_name":"quarkusio/quarkus","target_issue_id":1241990411,"target_issue_number":25688,"target_issue_url":"https://github.com/quarkusio/quarkus/issues/25688","reference_anchor_document_id":"gh_comment_1131907234","reference_answer_author":"aureamunoz","reference_answer_author_association":"MEMBER","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3182,"target_answer_overlap":0.0},"issue_created_at":"2022-03-21T11:37:41+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1175257864","fragment_type":"issue_description","sequence":0,"text":"`stork-service-discovery-kubernetes` extension requires some extra configutation that is not documented\n### Describe the bug\n\n`stork-service-discovery-kubernetes` requires `org.bouncycastle:bctls-jdk15on` dependency and also some extra configuration on your application.properties:\n\nExample \n\n# application properties should be here\nquarkus.security.security-providers=BCJSSE\n\nquarkus.http.ssl.certificate.key-store-file=server-keystore.jks\nquarkus.http.ssl.certificate.key-store-password=password\nquarkus.http.ssl.certificate.trust-store-file=server-truststore.jks\nquarkus.http.ssl.certificate.trust-store-password=password\n\nquarkus.native.additional-build-args=--allow-incomplete-classpath\n\nAlso, end-user must be sure that has the following K8s/ocp cluster roles binding (JVM and native mode):\n\nCluster Role\n\nkind: ClusterRole\napiVersion: rbac.authorization.k8s.io/v1\nmetadata:\n namespace: \"${NAMESPACE}\"\n name: endpoints-reader\nrules:\n - apiGroups: [\"\"] # \"\" indicates the core API group\n resources: [\"endpoints\"]\n verbs: [\"get\", \"watch\", \"list\"]\n\nClusterRoleBinding\n\napiVersion: rbac.authorization.k8s.io/v1\nkind: ClusterRoleBinding\nmetadata:\n name: fabric8-rbac\nsubjects:\n - kind: ServiceAccount\n # Reference to upper's `metadata.name`\n name: default\n namespace: \"${NAMESPACE}\"\nroleRef:\n kind: ClusterRole\n name: cluster-admin\n apiGroup: rbac.authorization.k8s.io\n\nI think that these requirements should be documented:\nDocRef: URL \n\nAlso would be great to understand why `org.bouncycastle:bctls-jdk15on` is needed and check if we could do something in order to avoid this extra dependency\n\nReproducer: URL \n\n### Expected behavior\n\n_No response_\n\n### Actual behavior\n\n_No response_\n\n### How to Reproduce?\n\n_No response_\n\n### Output of `uname -a` or `ver`\n\n_No response_\n\n### Output of `java -version`\n\n_No response_\n\n### GraalVM version (if different from Java)\n\n_No response_\n\n### Quarkus version or git rev\n\n_No response_\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\n_No response_\n\n### Additional information\n\n_No response_","author_login":"pjgg","author_association":"CONTRIBUTOR","created_at":"2022-03-21T11:37:41+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1074183383","fragment_type":"issue_comment","sequence":1,"text":"Regarding native mode is also possible to make it work by adding the following configuration to your application.properties:\n\nquarkus.native.additional-build-args=--allow-incomplete-classpath, --initialize-at-run-time=io.fabric8.kubernetes.client.internal.CertUtils, --enable-url-protocols=https","author_login":"pjgg","author_association":"CONTRIBUTOR","created_at":"2022-03-21T17:19:31+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082094935","fragment_type":"issue_comment","sequence":2,"text":"It's not clear to me why we need to setup bouncycastle. Can you please provide some more details?\n\nThe rbac configuration is indeed needed (with some minor modifications). However, when the kubernetes-client extension is used along with the kubernetes extension, these are expected to be generated.\n\nI think that the main issue here is that stork-service-discovery-kubernetes is not reusing the kubernetes-client extension.","author_login":"iocanel","author_association":"COLLABORATOR","created_at":"2022-03-29T16:26:28+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082144343","fragment_type":"issue_comment","sequence":3,"text":"Yes, the rbac configuration is needed, I'm working in the documentation about it and will create a PR soon.\n\nRegarding the bouncycastle, the problem is a `NoClassDefFoundError` Error: Class initialization of io.fabric8.kubernetes.client.internal.CertUtils$1 failed. Use the option --initialize-at-run-time=io.fabric8.kubernetes.client.internal.CertUtils$1 to explicitly request delayed initialization of this class.\nOriginal exception that caused the problem: java.lang.NoClassDefFoundError: org/bouncycastle/jce/provider/BouncyCastleProvider\n at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)\n at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1042)\n at jdk.unsupported/sun.misc.Unsafe.ensureClassInitialized(Unsafe.java:698)\n at","author_login":"aureamunoz","author_association":"MEMBER","created_at":"2022-03-29T17:09:48+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083128428","fragment_type":"issue_comment","sequence":4,"text":"Bouncy Castle dependencies are optional and should only be necessary in case ECDSA keys are used. I think these might also be required for FIPS mode.\n\nIs this property `quarkus.security.security-providers=BCJSSE` something you are adding due to this issue (on top of the BC dependencies)?","author_login":"manusa","author_association":"CONTRIBUTOR","created_at":"2022-03-30T13:16:21+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091467988","fragment_type":"issue_comment","sequence":5,"text":"IIUC, the whole problem is that Stork does not use the Kubernetes Client provided by the Kubernetes extension, correct?","author_login":"geoand","author_association":"CONTRIBUTOR","created_at":"2022-04-07T10:01:25+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091500125","fragment_type":"issue_comment","sequence":6,"text":"Thanks for the description of the problem.\n\nCould Stork not have an SPI that basically allows the Kubernetes Client to be set and then in Quarkus when the Kubernetes Client capability is present have the SPI implemented by pulling the Kubernetes Client from CDI?","author_login":"geoand","author_association":"CONTRIBUTOR","created_at":"2022-04-07T10:15:51+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091521367","fragment_type":"issue_comment","sequence":7,"text":"It could be done via QuarkusStorkInfrastructure: URL \n\nRight now it's only used to reuse the Quarkus Vertx instance but it's easy to change the Kube service discovery to use it for kube client as well.\n\nHow does it help? Would you want the user to add the kubernetes client extension when they add the kube service discovery?","author_login":"michalszynkiewicz","author_association":"MEMBER","created_at":"2022-04-07T10:25:20+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091526659","fragment_type":"issue_comment","sequence":8,"text":"Pretty much, yeah. Similarly to how we expect users to add `quarkus-kotlin` if they plan to do Kotlin. \nWe can also easily warn about the missing extension at build time.","author_login":"geoand","author_association":"CONTRIBUTOR","created_at":"2022-04-07T10:27:40+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091655908","fragment_type":"issue_comment","sequence":9,"text":"We can require adding kube client without sharing the client between the discovery and the other places. If someone adds it now, it will all work, right @aureamunoz ?","author_login":"michalszynkiewicz","author_association":"MEMBER","created_at":"2022-04-07T12:09:03+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1117136703","fragment_type":"issue_comment","sequence":10,"text":"I just discussed this issue with @aureamunoz and @michalszynkiewicz \n\nThe plan of action is the following:\n\n- in the stroke processor, detect if the kubernetes service discovery is used (looking at the provider class on the classpath).\n- if it's used, detect if the kubernetes client extension is present (capability check)\n- if not -> fail the build and ask the user to add the kubernetes client extension","author_login":"cescoffier","author_association":"MEMBER","created_at":"2022-05-04T10:03:58+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1131907234","fragment_type":"issue_comment","sequence":11,"text":"Hey @cescoffier I just filed #25688. This creates a problem when using stork with the various kubernetes extensions if you have created any of your own kubernetes files in `src/main/kubernetes`. The resulting yamls generated by the combination of the `kubernetes-client` and the kubernetes extensions aren't deployable.","author_login":"edeandrea","author_association":"CONTRIBUTOR","created_at":"2022-05-19T16:02:04+08:00","repo_name":"quarkusio/quarkus","issue_id":1175257864,"issue_number":24444,"issue_url":"https://github.com/quarkusio/quarkus/issues/24444","linked_issue_ids":[1241990411],"is_known_query_context":false},{"document_id":"gh_issue_1241990411","fragment_type":"issue_description","sequence":0,"text":"kubernetes-client and kubernetes extension combinations don't generate the correct things\n### Describe the bug\n\nIf I have a project which contains both the `kubernetes-client` extension and any of the other kubernetes extensions (`openshift`, `kubernetes`, `minikube`), if `src/main/kubernetes` contains other `Deployments`/etc, then the `ServiceAccount` object doesn't get generated, yet a `serviceAccountName` attribute gets added to each and every `Deployment` or `DeploymentConfig`.\n\n This should not happen.\n\n### Expected behavior\n\n_No response_\n\n### Actual behavior\n\n_No response_\n\n### How to Reproduce?\n\nHere's a reproducer:\n\nkubernetes-service-account.zip\n\n1. Download & unzip `kubernetes-service-account.zip`\n2. `cd kubernetes-service-account`\n3. `./mvnw clean package -DskipTests -Dquarkus.kubernetes.deployment-type=openshift`\n4. Inspect `target/kubernetes/openshift.yml`\n\nNotice there is is only a single `kind: ServiceAccount` object for the `fights-db`, yet the `DeploymentConfig` for `name: kubernetes-service-account` contains `serviceAccountName: kubernetes-service-account`, which does not exist.\n\nThis fails to deploy because the service account is missing.\n\n### Output of `uname -a` or `ver`\n\n_No response_\n\n### Output of `java -version`\n\n_No response_\n\n### GraalVM version (if different from Java)\n\n_No response_\n\n### Quarkus version or git rev\n\n_No response_\n\n### Build tool (ie. output of `mvnw --version` or `gradlew --version`)\n\n_No response_\n\n### Additional information\n\n_No response_","author_login":"edeandrea","author_association":"CONTRIBUTOR","created_at":"2022-05-19T15:55:03+08:00","repo_name":"quarkusio/quarkus","issue_id":1241990411,"issue_number":25688,"issue_url":"https://github.com/quarkusio/quarkus/issues/25688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1132766574","fragment_type":"issue_comment","sequence":1,"text":"FYI @michalszynkiewicz / @aureamunoz - I discovered this after I merged quarkusio/quarkus-super-heroes#82. After that merged I was no longer able to deploy the system to k8s using the yamls generated by the various kubernetes extensions.\n\nI had to remove the `kubernetes-client` dependency and re-add the bouncycastle ones manually in order to work around this (see URL I'll revert that once this is fixed & rolled into a Quarkus release.","author_login":"edeandrea","author_association":"CONTRIBUTOR","created_at":"2022-05-20T10:58:35+08:00","repo_name":"quarkusio/quarkus","issue_id":1241990411,"issue_number":25688,"issue_url":"https://github.com/quarkusio/quarkus/issues/25688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144756811","fragment_type":"issue_comment","sequence":2,"text":"Hi @edeandrea ,\n\nI've checked and seems that #25750 fixes this problem.\nLet me know if you need anything else.","author_login":"aureamunoz","author_association":"MEMBER","created_at":"2022-06-02T11:30:00+08:00","repo_name":"quarkusio/quarkus","issue_id":1241990411,"issue_number":25688,"issue_url":"https://github.com/quarkusio/quarkus/issues/25688","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144760342","fragment_type":"issue_comment","sequence":3,"text":"Thanks @aureamunoz !\n\nHow about helping get #25750 and #25756 merged? Right now they are still just sitting open.","author_login":"edeandrea","author_association":"CONTRIBUTOR","created_at":"2022-06-02T11:34:08+08:00","repo_name":"quarkusio/quarkus","issue_id":1241990411,"issue_number":25688,"issue_url":"https://github.com/quarkusio/quarkus/issues/25688","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0410","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Consequences / support for access policy?","query_context":"The DaSSCo access policy introduces various restrictions on access / publishing of records. How well is this supported in Specify?","known_context_document_ids":["gh_issue_1625481675"],"reference_answer":"After talking this through with @Sosannah we came to the following: \n\nAbout half of the required metadata fields are already supported by Specify out of the box (see mapping table below). \nThe other half could in principle be added as singular records in the `attachmentmetadata` table of which multiple entries can be associated with a single attachment record. In the following, these will be referred to as \"extra metadata\" records. \n\n| **Metadate field** | **Specify Table** | **Specify Field name** |**Notes** | **DarwinCore (Simple Multimedia extension)** | \n|-------------------|-----------------|-------------------|----|----|\n| Copyright owner | attachment | CopyrightHolder | | URL |\n|Copyright license | attachment | License | | URL |\n| Whether the attachment will be visible externally | attachment | IsPublic | | |\n|Persistent identifier for media which is resolvable (link) | attachment | AttachmentLocation | Only the terminal end of a \"persistent\" identifier prefixed by the URL of the attachment server + collection name e.g. URL | URL | \n|Date media created | attachment | FileCreatedDate | | URL | \n|File format (jpeg, tiff etc) | attachment | MimeType | | URL | | \n|Type/description of attachment (CT scan, specimen image etc) | attachment | Remarks / Type | | URL | \n|Type of exception (see data access policy) | | | | |\n|Person responsible for exception | | | | |\n|Details of exception – e.g., requested by for x reason, authorized by | | | how big must the field be? | |\n|Exception review date | | | | \n|Date media deleted | | | | \n|Deletion reason | | | how big must the field be? | |\n\n**Generation of extra metadata records**\nThe question is how these extra metadata records can be created. We understood that the mass digitization pipeline process can be adapted to do that, and in principle we could add these extra metadata fields to the Specify Interface to enable manual editing. However, otherwise we can't think of an automatic process for doing that. \n\n**Publication** \nAlthough we are unsure of how many of these metadata fields will be parsed and visible on sites like GBIF, in principle the information _is_ published digitally online as the DarwinCore Archive generated by Specify7 (retrieved by GBIF). The DarwinCore (DwC) Archive is a zip file of csv files and can be both machine read and human read. The images are published in the archive as links that are accessible through the web asset server. _However_ only fields that can be mapped to DarwinCore fields can be made public this way. The currently used DwC Extension Simple MultiMedia does not (see above table), but Audubon Media Description may have better options. \n\n**\"Deletion\"**\nAfter discussion the matter of \"deletion\" with @PipBrewer it turned out that instead of actual deletion of attachments, rather a kind of modal \"hiding\" is meant where the actual image would be replaced by a thumbnail. However, we cannot see how an images is represented externally by a thumbnail yet internally by the actual image. Perhaps the replacement of the web asset server can be adapted to provide that functionality. For instance, the replacement web asset server could be programmed to represent the \"deleted\" image as a thumbnail to the outside, but as the actual image when requests originate internally.","answer_document_id":"gh_comment_1549559599","silver_evidence_path":["gh_comment_1568409786","gh_issue_1625476655","gh_comment_1549559599"],"evidence_issue_ids":[1625481675,1625476655],"source_repo_name":"NHMDenmark/DanSpecify","source_issue_id":1625481675,"source_issue_number":222,"source_issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","target_repo_name":"NHMDenmark/DanSpecify","target_issue_id":1625476655,"target_issue_number":221,"target_issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","reference_anchor_document_id":"gh_comment_1568409786","reference_answer_author":"FedorSteeman","reference_answer_author_association":"COLLABORATOR","quality_score":86.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.3793,"target_answer_overlap":0.2},"issue_created_at":"2023-03-15T12:58:23+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_1625481675","fragment_type":"issue_description","sequence":0,"text":"Consequences / support for access policy\nThe DaSSCo access policy introduces various restrictions on access / publishing of records. How well is this supported in Specify?","author_login":"kimstp","author_association":"NONE","created_at":"2023-03-15T12:58:23+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1477799772","fragment_type":"issue_comment","sequence":1,"text":"The \"Visibility\" field is an integer and therefore supports multiple states. It should be investigate whether this can be used and how.","author_login":"FedorSteeman","author_association":"COLLABORATOR","created_at":"2023-03-21T13:02:19+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523603995","fragment_type":"issue_comment","sequence":2,"text":"Original version of Data Access policy sent for comment on 22/09/2023. Current draft incorporated into email sent by Pip Brewer on 26/04/2023 (i.e., list of new Specify fields required and new functionality)","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-04-26T15:19:45+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1568034706","fragment_type":"issue_comment","sequence":3,"text":"Would it be possible to get an updated timeline of when things can be implemented in Specify, so I can update the DaSSCo Steering Group in the next couple of weeks and inform KU management when we can implement the policy?","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-05-30T08:53:45+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1568409786","fragment_type":"issue_comment","sequence":4,"text":"Many of these questions are answered here:\n URL \n\nExtra attachment fields to data entry form in Specify can be created/tested on this week, preferably not later than 1st of June.\n\nNext step will be investigating the existing DarwinCore (DwC) extensions to publish the metadata (or at least part of it) as a DarwinCore Archive.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-05-30T13:10:02+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[1625476655],"is_known_query_context":false},{"document_id":"gh_comment_1573647796","fragment_type":"issue_comment","sequence":5,"text":"Extra attachment fields are available without using extra metadata table (in Exhibition collection of the test database).\nDeletion reason is missing, but maybe that information can be placed under the Details of exception.\n\nproposed_attachment_form\n\nThe fields above are visible and searchable. \nChanging some of them to drop-down lists (for instance Type of exception or Licence) is possible.\n\nUsing of metadata table needs one more step (if it's necessary) - waiting for an answer from Kansas. \n\nimage\n\nInvestigation of existing DarwinCore (DwC) extensions to publish the metadata (or at least part of it) as a DarwinCore Archive is still needed.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-06-02T12:20:34+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1594305823","fragment_type":"issue_comment","sequence":6,"text":"From ticket #221: \n\nAdditional work required:\n* Add extra attachment fields to data entry form in Specify (done)\n* Potentially script an import of attachment metadata into Specify BUT not until we have a concrete example and use case","author_login":"FedorSteeman","author_association":"COLLABORATOR","created_at":"2023-06-16T08:23:27+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[1625476655],"is_known_query_context":false},{"document_id":"gh_comment_1594401334","fragment_type":"issue_comment","sequence":7,"text":"There are available Darwin Core fields for publishing metadata of our assets, see in the attached sheet:\nattachment_metadata_fields.xlsx","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-06-16T09:34:39+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1602565898","fragment_type":"issue_comment","sequence":8,"text":"Investigation of existing DarwinCore (DwC) extensions to publish the metadata as a DarwinCore Archive is accomplished:\nattachment_metadata_fields.xlsx","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-06-22T12:39:29+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1689740516","fragment_type":"issue_comment","sequence":9,"text":"@Sosannah Do we know when this can be added to the live database? All looks good from my end.","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-08-23T10:51:16+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1693298143","fragment_type":"issue_comment","sequence":10,"text":"Now it's been added to the Vascular Plants collection in the live database.\nShould I modify the Entomology collection also?","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-08-25T12:42:01+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1693304971","fragment_type":"issue_comment","sequence":11,"text":"This is for all collections and all museums\n________________________________\nFrom: ZsuzsannaPapp ***@***.***>\nSent: 25 August 2023 14:42:10\nTo: NHMDenmark/DanSpecify\nCc: Pip Brewer; Mention\nSubject: Re: [NHMDenmark/DanSpecify] Consequences / support for access policy (Issue #222)\n\nNow it's been added to the Vascular Plants collection in the live database.\nShould I modify the Entomology collection also?\n\n—\nReply to this email directly, view it on GitHub","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-08-25T12:47:31+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1693315123","fragment_type":"issue_comment","sequence":12,"text":"I see. Then I need some more time - it will be done by Wednesday at the latest.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-08-25T12:55:01+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1698929440","fragment_type":"issue_comment","sequence":13,"text":"Since it would be a general modification for all of them, it would make sense to modify the global.views, but it's not so obvious. After several dead-ends, I've contacted Kansas - until they answer, I should put this on hold.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-08-30T10:48:34+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1705015760","fragment_type":"issue_comment","sequence":14,"text":"Status:\nUnfortunately, at this time, it should be done at the discipline (collection) level. The global or common view form definitions cannot be replaced directly, though there is an issue on GitHub (#3780) open aiming to address this problem at Kansas.\n\nThe suggested come-around should be tested, then implemented in each collections and museums.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-09-04T10:29:13+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1770346408","fragment_type":"issue_comment","sequence":15,"text":"Naturama and FIMUS has an old version of Specify. While the requested subviews were added to them, minor configuration will be necessary after server move.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-10-19T08:46:03+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1801555945","fragment_type":"issue_comment","sequence":16,"text":"After this change we got several complaints from those who still uses Specify 6 for work.\nI copy one detailed report here:\n\n “Since last week I have had an issue when opening Collection Object-forms, or opening new or existing Collection Object Attachments:\n Multiple pop-up windows with “An Issue of Concern” appear – I have attached jpeg-screencaps of the four different types I have identified. \n Also, it seems that the Collection Object Attachment-form has been expanded with new fields – I have attached another screencap of this.\n Could you please fix this; the pop-up windows appear *every* time I open Collection Object or Collection Object Attachments and being force to close the windows *every time* is wasting a lot of time, when I am working in Specify.”\n\nFix is needed.","author_login":"Sosannah","author_association":"COLLABORATOR","created_at":"2023-11-08T10:25:07+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625481675,"issue_number":222,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/222","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1625476655","fragment_type":"issue_description","sequence":0,"text":"Attachments metadata and synchronization between Specify and DaSSCo Storage Service\nWhat and how much meta-data can be stored in Specify with each attachment. Can it be synchronized using the Specify API?","author_login":"kimstp","author_association":"NONE","created_at":"2023-03-15T12:55:42+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523601560","fragment_type":"issue_comment","sequence":1,"text":"This ticket also relates to a conversation and email sent (Pip Brewer to Fedor Steeman) on 18/01/2023 and to a later email sent on 26/04/2023 (superceding the previous one).","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-04-26T15:18:04+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1549392846","fragment_type":"issue_comment","sequence":2,"text":"From correspondance with @PipBrewer: \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n \n\nMore from @kimstp :","author_login":"FedorSteeman","author_association":"COLLABORATOR","created_at":"2023-05-16T10:19:25+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1549559599","fragment_type":"issue_comment","sequence":3,"text":"After talking this through with @Sosannah we came to the following: \n\nAbout half of the required metadata fields are already supported by Specify out of the box (see mapping table below). \nThe other half could in principle be added as singular records in the `attachmentmetadata` table of which multiple entries can be associated with a single attachment record. In the following, these will be referred to as \"extra metadata\" records. \n\n| **Metadate field** | **Specify Table** | **Specify Field name** |**Notes** | **DarwinCore (Simple Multimedia extension)** | \n|-------------------|-----------------|-------------------|----|----|\n| Copyright owner | attachment | CopyrightHolder | | URL |\n|Copyright license | attachment | License | | URL |\n| Whether the attachment will be visible externally | attachment | IsPublic | | |\n|Persistent identifier for media which is resolvable (link) | attachment | AttachmentLocation | Only the terminal end of a \"persistent\" identifier prefixed by the URL of the attachment server + collection name e.g. URL | URL | \n|Date media created | attachment | FileCreatedDate | | URL | \n|File format (jpeg, tiff etc) | attachment | MimeType | | URL | | \n|Type/description of attachment (CT scan, specimen image etc) | attachment | Remarks / Type | | URL | \n|Type of exception (see data access policy) | | | | |\n|Person responsible for exception | | | | |\n|Details of exception – e.g., requested by for x reason, authorized by | | | how big must the field be? | |\n|Exception review date | | | | \n|Date media deleted | | | | \n|Deletion reason | | | how big must the field be? | |\n\n**Generation of extra metadata records**\nThe question is how these extra metadata records can be created. We understood that the mass digitization pipeline process can be adapted to do that, and in principle we could add these extra metadata fields to the Specify Interface to enable manual editing. However, otherwise we can't think of an automatic process for doing that. \n\n**Publication** \nAlthough we are unsure of how many of these metadata fields will be parsed and visible on sites like GBIF, in principle the information _is_ published digitally online as the DarwinCore Archive generated by Specify7 (retrieved by GBIF). The DarwinCore (DwC) Archive is a zip file of csv files and can be both machine read and human read. The images are published in the archive as links that are accessible through the web asset server. _However_ only fields that can be mapped to DarwinCore fields can be made public this way. The currently used DwC Extension Simple MultiMedia does not (see above table), but Audubon Media Description may have better options. \n\n**\"Deletion\"**\nAfter discussion the matter of \"deletion\" with @PipBrewer it turned out that instead of actual deletion of attachments, rather a kind of modal \"hiding\" is meant where the actual image would be replaced by a thumbnail. However, we cannot see how an images is represented externally by a thumbnail yet internally by the actual image. Perhaps the replacement of the web asset server can be adapted to provide that functionality. For instance, the replacement web asset server could be programmed to represent the \"deleted\" image as a thumbnail to the outside, but as the actual image when requests originate internally.","author_login":"FedorSteeman","author_association":"COLLABORATOR","created_at":"2023-05-16T12:22:29+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1551097561","fragment_type":"issue_comment","sequence":4,"text":"Following discussion with @FedorSteeman today:\n\n1. We need to test whether we can easily import image records with a mixture of information from the main attachment record and the extra attachment metadata records (key/value pairs).\n\n2. The publication information provided above is acknowledged. If the image metadata can't be accomodated by a publisher, I'm not concerned. If it can be acccomodated, we should try to map it.\n\n3. There are 2 associated issues regarding attachments which should not be viewable on the web. For attachments which have been deleted in our storage system (web asset server), it sounds like we can still publish the attachment records (the metadata), but with a stand in thumbnail. This is \"tombstoning\" the record and meets our needs. For attachments where we would like to embargo or not show the attachment itself, but would like to show the metadata/attachment record, Specify does not currently support this. This is something that should be requested by the Specify community on behalf of DiSSCo. In the meantime, the DaSSCo website, could provide details on the number of records embargoed for transparency purposes.\n\nI also discussed the two additional requirements needed - For all new attachment records that are created:\n• If it is an image it should automatically be given a CC-BY licence unless it is associated with an exception in the metadata, or this is later changed manually.\n• If it is a document, the attachment itself will not be visible externally.\n\n4. Fedor advised that when anyone creates a new attachment record we could always default the licence to CC-BY. This we should be able to manually change after the effect if necessary.\n\n5. For documents, there is no way to automatically mark new attachment records that are documents are to be not pushed to the web. For published datasets, this is being selected manually (i.e., only images and ones which are selected as being pushed to the web are) during the mapping phase. \n\nWOuld it be possible to get an idea of timeline as to when A. the additional metadata fields can be added to teh attachment records and B. when we can test that we can do a workbench import using mutliple attachment tables (e.g., including the extra metadata fields)? Adding the licence automatically can come after them.","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-05-17T09:56:03+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1551148853","fragment_type":"issue_comment","sequence":5,"text":"Follow on.\n\nFedor advised that You can't map attachment data in Workbench and neither attachment metadata\nalso need to add extra attachment fields to the data entry form\n\nSo additional work required:\n\n- Add extra attachment fields to data entry form in Specify - will need doing\n- Potentially script an import of attachment metadata into Specify BUT not until we have a concrete example and use case","author_login":"PipBrewer","author_association":"NONE","created_at":"2023-05-17T10:34:33+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1594310488","fragment_type":"issue_comment","sequence":6,"text":"@Sosannah and I agreed that this issue is covered and therefore subsumed by #222 and will therefore be closed.","author_login":"FedorSteeman","author_association":"COLLABORATOR","created_at":"2023-06-16T08:27:28+08:00","repo_name":"NHMDenmark/DanSpecify","issue_id":1625476655,"issue_number":221,"issue_url":"https://github.com/NHMDenmark/DanSpecify/issues/221","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0411","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Base table or view not found: 1146 Table 'prevarisc.platauconsultation' doesn't exist?","query_context":"Bonjour,\n\nNous rencontrons un problème avec la passerelle depuis la dernière mise à jour.\nle message d'erreur parle d'une table \"'prevarisc.platauconsultation\" qu'on a pas dans notre base prevarisc ! est ce qu'on a raté une mise à jour ?\n\n**Le Healthcheck affiche le message suivant :**\n\"Base de données Prevarisc incompatible. Avez-vous pensé à la mise à jour ?\"\n\n**Dans email de confirmation on a le message suivant :**\n\nRecherche de toutes les consultations en attente d'avis ou traitées ...\nPHP Warning: Undefined variable $pieces in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107 PHP Warning: foreach() argument must be of type array|object, null given in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107\n\nIn ExceptionConverter.php line 49:\n \n An exception occurred while executing a query: SQLSTATE[42S02]: Base table \n or view not found: 1146 Table 'prevarisc.platauconsultation' doesn't exist \n \n\nIn Exception.php line 28:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \n \n\nIn Statement.php line 134:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \nRecherche de toutes les consultations en attente d'avis ou traitées ...\nPHP Warning: Undefined variable $pieces in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107 PHP Warning: foreach() argument must be of type array|object, null given in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107\n\nIn ExceptionConverter.php line 49:\n \n An exception occurred while executing a query: SQLSTATE[42S02]: Base table \n or view not found: 1146 Table 'prevarisc.platauconsultation' doesn't exist \n \n\nIn Exception.php line 28:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \n \n\nIn Statement.php line 134:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \n\n \nMerci d'avance pour votre retour,\nCordialement,\nLe webmaster de sdis91","known_context_document_ids":["gh_issue_2009743833"],"reference_answer":"effectivement, la fonctionnalité d'export de documents est livrée ! URL \n\nnous maintenons activement la passerelle, mais pas le dépot prevarisc. Pas de merge de prévu de notre côté, mais vous pouvez le faire directement sur votre version de prevarisc en utilisant la branche de travail URL","answer_document_id":"gh_comment_1819286402","silver_evidence_path":["gh_comment_1827514186","gh_issue_1162771253","gh_comment_1819286402"],"evidence_issue_ids":[2009743833,1162771253],"source_repo_name":"SDIS62/prevarisc-passerelle-platau","source_issue_id":2009743833,"source_issue_number":54,"source_issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/54","target_repo_name":"SDIS62/prevarisc-passerelle-platau","target_issue_id":1162771253,"target_issue_number":21,"target_issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","reference_anchor_document_id":"gh_comment_1827514186","reference_answer_author":"kdubuc","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2273,"anchor_target_overlap":0.3182,"target_answer_overlap":0.1429},"issue_created_at":"2023-11-24T13:37:05+08:00","valid_comment_count":27,"fragments":[{"document_id":"gh_issue_2009743833","fragment_type":"issue_description","sequence":0,"text":"Base table or view not found: 1146 Table 'prevarisc.platauconsultation' doesn't exist\nBonjour,\n\nNous rencontrons un problème avec la passerelle depuis la dernière mise à jour.\nle message d'erreur parle d'une table \"'prevarisc.platauconsultation\" qu'on a pas dans notre base prevarisc ! est ce qu'on a raté une mise à jour ?\n\n**Le Healthcheck affiche le message suivant :**\n\"Base de données Prevarisc incompatible. Avez-vous pensé à la mise à jour ?\"\n\n**Dans email de confirmation on a le message suivant :**\n\nRecherche de toutes les consultations en attente d'avis ou traitées ...\nPHP Warning: Undefined variable $pieces in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107 PHP Warning: foreach() argument must be of type array|object, null given in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107\n\nIn ExceptionConverter.php line 49:\n \n An exception occurred while executing a query: SQLSTATE[42S02]: Base table \n or view not found: 1146 Table 'prevarisc.platauconsultation' doesn't exist \n \n\nIn Exception.php line 28:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \n \n\nIn Statement.php line 134:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \nRecherche de toutes les consultations en attente d'avis ou traitées ...\nPHP Warning: Undefined variable $pieces in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107 PHP Warning: foreach() argument must be of type array|object, null given in /var/www/html/prevarisc-passerelle-platau/src/Command/ExportAvis.php on line 107\n\nIn ExceptionConverter.php line 49:\n \n An exception occurred while executing a query: SQLSTATE[42S02]: Base table \n or view not found: 1146 Table 'prevarisc.platauconsultation' doesn't exist \n \n\nIn Exception.php line 28:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \n \n\nIn Statement.php line 134:\n \n SQLSTATE[42S02]: Base table or view not found: 1146 Table 'prevarisc.platau \n consultation' doesn't exist \n\n \nMerci d'avance pour votre retour,\nCordialement,\nLe webmaster de sdis91","author_login":"SDIS91","author_association":"CONTRIBUTOR","created_at":"2023-11-24T13:37:05+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":2009743833,"issue_number":54,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/54","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1827497093","fragment_type":"issue_comment","sequence":1,"text":"Bonjour,\n\nLes changements de la base de données sont dans des pull requests de prevarisc sans merge dans le master, est ce qu'ont doit les appliquer ?","author_login":"SDIS91","author_association":"CONTRIBUTOR","created_at":"2023-11-27T09:52:38+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":2009743833,"issue_number":54,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/54","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1827514186","fragment_type":"issue_comment","sequence":2,"text":"Bonjour,\n\nCette évolution nécessite effectivement une mise à jour de Prevarisc en lui-même pour pouvoir être pleinement exploitée. Je vous renvoie vers la discussion du sujet sur le ticket de l'évolution d'export des rapports qui suggère d'appliquer les modifications.\n\nDans tous les cas, la sélection des documents à envoyer sur Plat'AU s'effectue directement depuis Prevarisc.\n\nCordialement,\nMaxime Merrien","author_login":"A709197","author_association":"CONTRIBUTOR","created_at":"2023-11-27T10:00:14+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":2009743833,"issue_number":54,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/54","linked_issue_ids":[1162771253],"is_known_query_context":false},{"document_id":"gh_comment_1827674021","fragment_type":"issue_comment","sequence":3,"text":"Oui effectivement\n\npour que ce soit plus clair, j'ai détaillé cela dans le readme URL","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-11-27T11:45:14+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":2009743833,"issue_number":54,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/54","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1162771253","fragment_type":"issue_description","sequence":0,"text":"Export des rapports\nBonjour\n\nNous recevons actuellement les dossiers et leurs pièces jointes sans problèmes.\nLes avis (favorables ou défavorables) et les prises en compte (positives ou négatives) sont exportées.\nMais qu'en est-il des rapports générés? doivent ils être exportés sur Plat'au? Si oui, comment et sous quelle format?\n\nMerci d'avance","author_login":"SDIS91","author_association":"CONTRIBUTOR","created_at":"2022-03-08T15:08:29+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061906616","fragment_type":"issue_comment","sequence":1,"text":"actuellement, aucun document n'est envoyé sur Plat'AU par la passerelle.\n\nC'est une demande que vous avez eu ?","author_login":"kdubuc","author_association":"MEMBER","created_at":"2022-03-08T15:33:47+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1061940307","fragment_type":"issue_comment","sequence":2,"text":"L'API Syncplicity - upload est déjà intégrée dans notre application sur Piste mais je ne sais pas quel upload elle fait.\nEn tout cas, à mon avis, la dématérialisation ne serait pas complète sans le retour du rapport par la même voie.\nMerci pour le ticket.","author_login":"SDIS91","author_association":"NONE","created_at":"2022-03-08T16:04:56+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1065059343","fragment_type":"issue_comment","sequence":3,"text":"Bonjour à tous\n\nJe sors d'un point interne au SDIS33 concernant tous les aspects liés à la nouvelle procédure de démat des AU pour communiquer avec les services instructeurs via Plat'AU.\n\nC'était déjà une problématique qui avait été identifiée lors de nos tests de début d'année avec Bordeaux Métropole, et j'ai eu la confirmation que la possibilité d'exporter les rapports générés dans PREVARISC serait d'une grande utilité pour nos préventionnistes/prévisionnistes et les services instructeurs, puisque ça permettrait de garder pratiquement les mêmes procédures et surtout le même formalisme pour le document final (rapport).\n\nD'autre part, le fait de renvoyer uniquement des prescriptions (au moment où l'on rend l'avis) dans le fonctionnement actuel de la passerelle, reste assez rébarbatif en terme d'utilisation et ne permet pas de transmettre des pièces jointes telles que des schémas, des tableaux, ... qui peuvent être utiles pour étayer l'avis rendu.\n\nNous sommes donc très preneur d'une évolution de la passerelle permettant d'exporter des pièces jointes lorsque l'on rend l'avis ! Nous avions aussi repérer la problématique d'identifier les documents à envoyer, et la solution d'envoyer toutes les pièces jointes liées au dossier nous conviendrait.","author_login":"CFX-SDIS33","author_association":"NONE","created_at":"2022-03-11T12:14:52+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1068995978","fragment_type":"issue_comment","sequence":4,"text":"Bonjour Kevin\nJe confirme comme les autres qu'il s'agit plus que d'une \"amélioration possible\", mais d'une amélioration attendue par obligation de réponse aux services instructeurs\nCdt Dellac Laurent. Chef service ERP SDIS33","author_login":"dellac","author_association":"NONE","created_at":"2022-03-16T10:57:21+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082811896","fragment_type":"issue_comment","sequence":5,"text":"Pour information.\nHier mardi 29 mars en réunion à la DG qui confirme que Plat'Au accepte l'import pièces jointes en retour d'avis. \nPossibilité de paramétrage connecteur.\nA priori, le Cne Servant Carré va transmettre l'information.","author_login":"dellac","author_association":"NONE","created_at":"2022-03-30T09:00:35+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1126263278","fragment_type":"issue_comment","sequence":6,"text":"Tout d'actualité\nBonjour Kevin\nJe confirme comme les autres qu'il s'agit plus que d'une \"amélioration possible\", mais d'une amélioration attendue par obligation de réponse aux services instructeurs\nCdt Dellac Laurent. Chef service ERP SDIS33","author_login":"dellac","author_association":"NONE","created_at":"2022-05-13T17:02:32+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1131490974","fragment_type":"issue_comment","sequence":7,"text":"Bien reçu le besoin @dellac, le ticket est et restera ouvert le temps que ce développement soit intégré dans notre roadmap interne.\n\nJ'en profite pour rappeler que nous sommes ouvert à toutes contributions au code de la passerelle via les Pull Request","author_login":"kdubuc","author_association":"MEMBER","created_at":"2022-05-19T09:58:14+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1396502599","fragment_type":"issue_comment","sequence":8,"text":"Des nouvelles du développement Atos pour le SDIS 85 ? Et mise à disposition de la communauté ?","author_login":"LD-SDIS33","author_association":"NONE","created_at":"2023-01-19T06:34:47+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1401496006","fragment_type":"issue_comment","sequence":9,"text":"Bonjour,\nNous venons de commencer le développement de cette fonctionnalité. Il s'agira donc de pouvoir choisir via des cases à cocher dans Prevarisc les pièces jointes du dossier à renvoyer, et une commande sur la passerelle permettra de faire l'action.\nNous estimons pouvoir mettre cela à disposition sur notre GitHub pour fin Mars, et nous reverserons cette évolution dans ce GitHub.\nJe mentionnerais la Pull Request lorsque ce sera d'acutalité.\n\nCordialement,\nMaxime Merrien","author_login":"A709197","author_association":"CONTRIBUTOR","created_at":"2023-01-24T07:32:41+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1407155917","fragment_type":"issue_comment","sequence":10,"text":"@A709197 Maxime, voici la branche de travail sur l'export de pièces dans la passerelle URL ça vous aidera à vous raccrocher à nous.\n\nSi vous devez pousser une mise à jour sur Prevarisc (notamment au niveau de la gestion des cases à cocher), veuillez faire la PR dans le dépôt officiel URL depuis la branche 2.x pour simplifier la mise à niveau des SDIS.","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-01-27T22:38:07+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1425676514","fragment_type":"issue_comment","sequence":11,"text":"Pour répondre à @A709197 ( URL \n \n\nPour lier la pièce à un avis, il faut qu'on puisse obtenir un identifiant de pièce (idsPieces), que l'on obtient avec l'endpoint POST /pieces. Je veux bien le retour du ticket pour voir plus clair.\n\nPs : je suis off pendant une semaine, je reprendrai ce ticket à mon retour pour aller plus loin","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-02-10T11:36:01+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1425711850","fragment_type":"issue_comment","sequence":12,"text":"J'en profite, afin d'être assez clair, que l'ensemble des travaux initiés par le SDIS62 dans le développement de la fonctionnalité d'export de pièces doit servir de base pour les développements collaboratifs amenés par les différents acteurs, publics ou privés. La branche doit être mise à jour en fonction des avancées, pour que nous puissions l'intégrer dans la passerelle. Aussi nous travaillons en parallèle sur cette commande, n'hésitez donc pas à venir vers nous pour synchronisation.","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-02-10T11:58:58+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439642153","fragment_type":"issue_comment","sequence":13,"text":"Bonjour,\nDéveloppement toujours en cours et réalisé en grande partie. Quelques questions fonctionnelles se posent et nous finaliserons donc le développement suite à la prochaine réunion avec l'équipe Plat'AU.\n\nCordialement,\nMaxime Merrien","author_login":"A709197","author_association":"CONTRIBUTOR","created_at":"2023-02-22T08:52:12+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1469707575","fragment_type":"issue_comment","sequence":14,"text":"Bonjour @kdubuc,\n\nJe viens d'effectuer les PRs pour la passerelle ainsi que pour Prevarisc. Les 2 PRs sont actuellement en Draft le temps que nous finalisions les tests et que nous fassions un peu de ménage dans l'historique des commits.\n\nN'hésites pas à revenir vers moi si des modifications sont à apporter.\nCordialement,\nMaxime Merrien","author_login":"A709197","author_association":"CONTRIBUTOR","created_at":"2023-03-15T10:02:54+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470111818","fragment_type":"issue_comment","sequence":15,"text":"Merci Maxime, mais tu as créé une nouvelle PR. La PR active pour intégrer l'export de rapport est celle ci : URL Elle est à la base des travaux sur l'export, il faut donc mettre à jour cette dernière pour intégrer le travail du 62.","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-03-15T14:29:49+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1470116745","fragment_type":"issue_comment","sequence":16,"text":"j'ai peut être parlé un trop vite, le merge entre les deux branches va peut être mettre à jour la PR 43 automatiquement. Je reviendrai sur ce fil après avoir levé le doute.","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-03-15T14:32:33+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1516991086","fragment_type":"issue_comment","sequence":17,"text":"Avez vous des nouvelles du déploiement et retours essais au SDIS 85 ?","author_login":"LD-SDIS33","author_association":"NONE","created_at":"2023-04-20T21:55:56+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1517364276","fragment_type":"issue_comment","sequence":18,"text":"Bonjour @LD-SDIS33,\n\nLe SDIS 85 a installé la version pour test. Nous n'avons pour le moment pas de retours concernant la fonctionnalité.\n\nCordialement,\nMaxime Merrien","author_login":"A709197","author_association":"CONTRIBUTOR","created_at":"2023-04-21T07:03:48+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1523507477","fragment_type":"issue_comment","sequence":19,"text":"Nous proposons de participer aux tests, si vous en êtes d'accord.","author_login":"LD-SDIS33","author_association":"NONE","created_at":"2023-04-26T14:21:28+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1531009029","fragment_type":"issue_comment","sequence":20,"text":"Bonjour @LD-SDIS33,\n\nC'est possible !\nNous avons une petite correction à faire sur la branche Prevarisc qui pourra être intégrée avec la version du SDIS 62. Je vous donne toutes les informations demain dans la journée.\n\nCordialement,\nMaxime Merrien","author_login":"A709197","author_association":"CONTRIBUTOR","created_at":"2023-05-02T07:27:44+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1678433878","fragment_type":"issue_comment","sequence":21,"text":"Kevin, peut on savoir à quel stade en est la validation du déploiement ?","author_login":"LD-SDIS33","author_association":"NONE","created_at":"2023-08-15T05:08:14+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1744659979","fragment_type":"issue_comment","sequence":22,"text":"Bonjour Kevin,\n\nNous n'avons finalement pas récupéré les développements effectués par Atos sur leur dépôt, nous avons préféré attendre une version éprouvée afin d'éviter au maximum les dysfonctionnements.\nNous sommes donc toujours en attente d'éléments concernant la validation de cette fonctionnalité.\nLes tests ont-ils été concluants ?\nEst-il prévu d'intégrer la pull request dans votre dépôt ?","author_login":"CFX-SDIS33","author_association":"NONE","created_at":"2023-10-03T10:15:08+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1818771944","fragment_type":"issue_comment","sequence":23,"text":"Bonjour @kdubuc et @A709197 \n\nJ'ai constaté que la fonctionnalité d'export de PJ vers Plat'AU a été intégrée au GitHub du SDIS62 pour la partie concernant le dépôt prevarisc-passerelle-platau (#45).\n\nToutefois, pour pouvoir exploiter cette amélioration de la passerelle, il faudrait aussi récupérer l'adaptation de l'application : Remontée de documents vers Plat'AU #698.\n\nEst-ce qu'un merge de cette PR est prévu ?\n\nMerci d'avance pour un retour de votre part.","author_login":"CFX-SDIS33","author_association":"NONE","created_at":"2023-11-20T10:25:45+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1819286402","fragment_type":"issue_comment","sequence":24,"text":"effectivement, la fonctionnalité d'export de documents est livrée ! URL \n\nnous maintenons activement la passerelle, mais pas le dépot prevarisc. Pas de merge de prévu de notre côté, mais vous pouvez le faire directement sur votre version de prevarisc en utilisant la branche de travail URL","author_login":"kdubuc","author_association":"MEMBER","created_at":"2023-11-20T15:29:07+08:00","repo_name":"SDIS62/prevarisc-passerelle-platau","issue_id":1162771253,"issue_number":21,"issue_url":"https://github.com/SDIS62/prevarisc-passerelle-platau/issues/21","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0412","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Benchmark: Experiment with different slot durations?","query_context":"Benchmark how the worker behaves with different slot lengths. Especially regarding transactions per block.","known_context_document_ids":["gh_issue_1273560758"],"reference_answer":"How does this behave if we increase block time to 1s? Does it also go down to near zero tps or does it approach a steady level?","answer_document_id":"gh_comment_1150705446","silver_evidence_path":["gh_comment_1158824122","gh_issue_1258106304","gh_comment_1150705446"],"evidence_issue_ids":[1273560758,1258106304],"source_repo_name":"integritee-network/worker","source_issue_id":1273560758,"source_issue_number":798,"source_issue_url":"https://github.com/integritee-network/worker/issues/798","target_repo_name":"integritee-network/worker","target_issue_id":1258106304,"target_issue_number":775,"target_issue_url":"https://github.com/integritee-network/worker/issues/775","reference_anchor_document_id":"gh_comment_1158824122","reference_answer_author":"brenzi","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.2308,"anchor_target_overlap":0.1111,"target_answer_overlap":0.1},"issue_created_at":"2022-06-16T13:23:09+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1273560758","fragment_type":"issue_description","sequence":0,"text":"Benchmark: Experiment with different slot durations\nBenchmark how the worker behaves with different slot lengths. Especially regarding transactions per block.","author_login":"Niederb","author_association":"CONTRIBUTOR","created_at":"2022-06-16T13:23:09+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1157678432","fragment_type":"issue_comment","sequence":1,"text":"Some first findings for a slot duration of 6s:\n- Scenario: 100 clients generating 250 transactions as fast as possible\n- The maximum number of transactions that can be in the queue is currently 8192\n- The maximum number of transactions I saw in a single block so far is 5400\n - around 2000-3000 transactions is typical\n - Two threads are reaching 100% CPU usage on a core under these circumstances. So I think we reach some kind of CPU bottleneck.\n - The CLI client is also creating a lot of CPU load","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-16T13:43:21+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158052283","fragment_type":"issue_comment","sequence":2,"text":"Thanks. How does the throughput degradation look with growing state?","author_login":"brenzi","author_association":"COLLABORATOR","created_at":"2022-06-16T19:26:09+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1158824122","fragment_type":"issue_comment","sequence":3,"text":"- This is a similar plot as in #775 but with a slot time of 6s and 100 clients instead of 20 (leading to more transactions per block in general)\n- As expected the throughput remains unaffected by the CPU for a longer time.\n- In the end the state was around 20 MB in size, so still a long shot from 128 MB. I think it will be difficult to reach 128 MB with the current benchmark.\n- Every 6s there is a high amount of interrupts on the system (around 7500/s). Seems quite high. Not sure this can be explained with just disk IO or network.\n- The system seemed to \"recover\" at the end for a bit before degrading again. Not sure what happened there. Maybe something else was consuming system resources for a while (compiling or so)\n\nbenchmark-slot-time-6s-100-clients\n \n@brenzi @masapr","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-17T12:30:04+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[1258106304],"is_known_query_context":false},{"document_id":"gh_comment_1159790067","fragment_type":"issue_comment","sequence":4,"text":"during the linear phase, you create 100'000 accounts within ~1900 blocks, 6s each. If the number of accounts equals the number of tx, then we only have 8.77 tps. As I understand, this low throughput is caused by the limited number of clients. \nI suspect we would see degradation much earlier if we could send more tps. I guess we need to combine burst tests (send tx without waiting for any confirmation with this state growth test. Possibly with one service per strategy, simultaneously hitting the validateer. What do you think?","author_login":"brenzi","author_association":"COLLABORATOR","created_at":"2022-06-19T18:36:37+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1160023340","fragment_type":"issue_comment","sequence":5,"text":"Yes the throughput is limited by the number of clients. I did not test with too many clients on purpose as I did not want to introduce new issues/problems due to that.\nAt the moment the tests without waiting are very hard to control and then to make sense on what happened. \nMaybe we could add some kind or rate limiting. For example each client can have N outstanding transactions or send maximum N transactions per second.\nI think this could help to increase the throughput while still maintaining some kind of predictability and control.","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-20T06:22:24+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1160457132","fragment_type":"issue_comment","sequence":6,"text":"I'm confused about the 8.77 tps. Above @Niederb said, he has 2000-3000 transactions in a single block. With a block time of 6s this results to 333 tps, doesn't it? Wouldn't that be the result?","author_login":"masapr","author_association":"NONE","created_at":"2022-06-20T13:34:20+08:00","repo_name":"integritee-network/worker","issue_id":1273560758,"issue_number":798,"issue_url":"https://github.com/integritee-network/worker/issues/798","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1258106304","fragment_type":"issue_description","sequence":0,"text":"CPU load of integritee-service increases over time\n- The CPU usage of the integritee-service steadily increases from initially 20% up to 90% when executing a long running benchmark\n - When I stop sending transaction the CPU does not decrease. It seems stuck at high load.\n - After restarting the process the CPU usage is back to normal again\n- Some first investigation points towards the \"interval_block_production_timer\" thread\n - Unfortunately I cannot see inside the enclave for further information\n - It would help enormously when we could see the stack of the threads\n - See #761","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-02T12:19:22+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145574835","fragment_type":"issue_comment","sequence":1,"text":"Will this cause a crash or stale when running for a longer period of time?","author_login":"brenzi","author_association":"COLLABORATOR","created_at":"2022-06-03T04:31:21+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145903009","fragment_type":"issue_comment","sequence":2,"text":"@brenzi So far I have not managed to bring the system to a complete halt/crash, but the system performance goes all the way down until only a single transaction is processed per block.\nSee the following section from the log where there are more than a thousand transactions in the queue waiting but sometimes only and handful get processed into the block:\n\n[2022-06-03T12:09:01Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1249 Time slot: 5 Transactions in Block: 1\n[2022-06-03T12:09:01Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1478 Time slot: 94 Transactions in Block: 197\n[2022-06-03T12:09:02Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1536 Time slot: 22 Transactions in Block: 11\n[2022-06-03T12:09:03Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1957 Time slot: 37 Transactions in Block: 59\n[2022-06-03T12:09:05Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2327 Time slot: 0 Transactions in Block: 1\n[2022-06-03T12:09:05Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2547 Time slot: 15 Transactions in Block: 1\n[2022-06-03T12:09:06Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2645 Time slot: 69 Transactions in Block: 115\n[2022-06-03T12:09:06Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2530 Time slot: 184 Transactions in Block: 382\n[2022-06-03T12:09:06Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2148 Time slot: 26 Transactions in Block: 19\n[2022-06-03T12:09:07Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2129 Time slot: 23 Transactions in Block: 10\n[2022-06-03T12:09:07Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2119 Time slot: 16 Transactions in Block: 1\n[2022-06-03T12:09:07Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2118 Time slot: 64 Transactions in Block: 109\n[2022-06-03T12:09:08Z ERROR its_consensus_aura::slot_proposer] Operations queue: 2009 Time slot: 114 Transactions in Block: 222\n[2022-06-03T12:09:08Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1787 Time slot: 30 Transactions in Block: 1\n[2022-06-03T12:09:08Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1786 Time slot: 2 Transactions in Block: 1\n[2022-06-03T12:09:08Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1785 Time slot: 21 Transactions in Block: 2\n[2022-06-03T12:09:09Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1783 Time slot: 14 Transactions in Block: 1\n[2022-06-03T12:09:09Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1782 Time slot: 2 Transactions in Block: 1\n[2022-06-03T12:09:09Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1781 Time slot: 35 Transactions in Block: 36\n[2022-06-03T12:09:10Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1745 Time slot: 65 Transactions in Block: 118\n[2022-06-03T12:09:10Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1627 Time slot: 50 Transactions in Block: 69\n[2022-06-03T12:09:10Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1558 Time slot: 26 Transactions in Block: 14\n[2022-06-03T12:09:10Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1544 Time slot: 20 Transactions in Block: 1\n[2022-06-03T12:09:11Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1543 Time slot: 95 Transactions in Block: 183\n[2022-06-03T12:09:11Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1360 Time slot: 47 Transactions in Block: 74\n[2022-06-03T12:09:11Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1286 Time slot: 36 Transactions in Block: 36\n[2022-06-03T12:09:12Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1250 Time slot: 35 Transactions in Block: 33\n[2022-06-03T12:09:12Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1217 Time slot: 70 Transactions in Block: 128\n[2022-06-03T12:09:12Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1089 Time slot: 3 Transactions in Block: 1\n[2022-06-03T12:09:13Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1088 Time slot: 24 Transactions in Block: 3\n[2022-06-03T12:09:13Z ERROR its_consensus_aura::slot_proposer] Operations queue: 1085 Time slot: 66 Transactions in Block: 120\n\nIt also leads to the effect that sometimes the block production does not happen at regular 300ms intervals anymore but instead takes more than twice as long:\n\nTime since last slot: 671\nTime since last slot: 640\nTime since last slot: 707\nTime since last slot: 683\nTime since last slot: 660\nTime since last slot: 587\nTime since last slot: 613\nTime since last slot: 604\nTime since last slot: 369","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-03T12:16:02+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145986580","fragment_type":"issue_comment","sequence":3,"text":"ok. \n* the good: lifeness is still maintained\n* the bad: availability is severely harmed\n* the ugly: this happens way too soon\n\nso I think an investigation is necessary","author_login":"brenzi","author_association":"COLLABORATOR","created_at":"2022-06-03T13:50:59+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1146014004","fragment_type":"issue_comment","sequence":4,"text":"@haerdib I think I have to correct myself regarding the behavior after a restart: If I just kill the `integritee-service` and restart it then it goes back to having a high CPU load immediately.\n@brenzi Before I had 4 MB of state, but I'm not sure it is directly related to the state size. I will keep an eye on it tough.","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-03T14:20:25+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1149845319","fragment_type":"issue_comment","sequence":5,"text":"See the following two graphs that show the percentage of transactions in the queue that are included in the next block over time (max. 20 Transactions are in the queue). In both cases the performance degrades over time but much slower in the second case (note the different time scale in the two graphs). Orange line is the moving average.\n\nbenchmark\n\nAfter the changes from @mullefel that keep the state in memory:\nbenchmark-improved","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-08T12:23:23+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1150705446","fragment_type":"issue_comment","sequence":6,"text":"How does this behave if we increase block time to 1s? Does it also go down to near zero tps or does it approach a steady level?","author_login":"brenzi","author_association":"COLLABORATOR","created_at":"2022-06-09T06:01:23+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1150825688","fragment_type":"issue_comment","sequence":7,"text":"can you plot state size / number of accounts along the performance plz?","author_login":"brenzi","author_association":"COLLABORATOR","created_at":"2022-06-09T08:25:55+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1154806114","fragment_type":"issue_comment","sequence":8,"text":"@brenzi Is this what you had in mind?\nThe state size saturates because hardly any transactions are processed. The number of accounts is directly linked to the number of transactions.\nbenchmark-with-state\n\nSome findings:\n- Keeping the state in memory instead of writing it on the disk definitely helps (see plots above)\n - The call `write_after_mutation(..)` in `apply_state_update(..)` is still getting slower over time even though it is now supposed to write anymore. Would need further investigation to see why.\n- `apply_state_update(...)` in `impls.rs` is a function that generates more and more CPU load as the state grows\n - Calculating the hash over the state twice is quite expensive\n - Also the `clone()` and assignment of the copy grow more and more expensive as the state grows","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-14T07:14:42+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1161334232","fragment_type":"issue_comment","sequence":9,"text":"This is a flamegraph that is maybe worth looking at:\nflamegraph-worker-good.svg","author_login":"Niederb","author_association":"NONE","created_at":"2022-06-21T06:52:34+08:00","repo_name":"integritee-network/worker","issue_id":1258106304,"issue_number":775,"issue_url":"https://github.com/integritee-network/worker/issues/775","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0413","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"FR: Is there a way to disable end-of-chapter footnotes?","query_context":"Whether I enable or disable \"Show footnotes in popup\", footnotes still show at the end of chapter. The In-page EPUB footnotes options are disabled.\n\nIs there a way to disable that? The behavior I want is to show footnotes only in the popup. If they must be shown, then at the end of the document.\n\nThanks","known_context_document_ids":["gh_issue_2810826397"],"reference_answer":"There's a CRe callcache implemented in the Lua frontend, yeah.\n\nI'd say it's in credocument, but I'm not at my dev box right now ;).\n\nIn the meantime, you can disable it in the developer options menu ;).","answer_document_id":"gh_comment_719952767","silver_evidence_path":["gh_comment_2613920029","gh_issue_726525270","gh_comment_719952767"],"evidence_issue_ids":[2810826397,726525270],"source_repo_name":"koreader/koreader","source_issue_id":2810826397,"source_issue_number":13135,"source_issue_url":"https://github.com/koreader/koreader/issues/13135","target_repo_name":"koreader/koreader","target_issue_id":726525270,"target_issue_number":6809,"target_issue_url":"https://github.com/koreader/koreader/issues/6809","reference_anchor_document_id":"gh_comment_2613920029","reference_answer_author":"NiLuJe","reference_answer_author_association":"MEMBER","quality_score":92.9,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.087,"anchor_target_overlap":0.2647,"target_answer_overlap":0.0588},"issue_created_at":"2025-01-25T07:27:07+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_2810826397","fragment_type":"issue_description","sequence":0,"text":"FR: Is there a way to disable end-of-chapter footnotes\nWhether I enable or disable \"Show footnotes in popup\", footnotes still show at the end of chapter. The In-page EPUB footnotes options are disabled.\n\nIs there a way to disable that? The behavior I want is to show footnotes only in the popup. If they must be shown, then at the end of the document.\n\nThanks","author_login":"gd4c","author_association":"NONE","created_at":"2025-01-25T07:27:07+08:00","repo_name":"koreader/koreader","issue_id":2810826397,"issue_number":13135,"issue_url":"https://github.com/koreader/koreader/issues/13135","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2613842695","fragment_type":"issue_comment","sequence":1,"text":"I can find In-page footnotes but not end-of-chapter. I also tried a menu search.","author_login":"gd4c","author_association":"NONE","created_at":"2025-01-25T08:35:00+08:00","repo_name":"koreader/koreader","issue_id":2810826397,"issue_number":13135,"issue_url":"https://github.com/koreader/koreader/issues/13135","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613854892","fragment_type":"issue_comment","sequence":2,"text":"Could there be an option to relegate them to the end of the epub, please? Like treat them as endnotes?","author_login":"gd4c","author_association":"NONE","created_at":"2025-01-25T09:07:25+08:00","repo_name":"koreader/koreader","issue_id":2810826397,"issue_number":13135,"issue_url":"https://github.com/koreader/koreader/issues/13135","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2613920029","fragment_type":"issue_comment","sequence":3,"text":"We can't relegate them at the end of the EPUB: they are part of the book rendering flow where they are set, we can't just reorder the pages :) We just can \"hide\" some parts.\nExcept in the first case described below, we can't automatically do anything that you wish for :)\n\nBut _you_ can mark some continuous set of pages as \"hidden flows\", so they are skipped when using prev/next page navigation.\nThis can be done either:\n\n- automatically, if the publisher has set some xhtml file in the .opf with `linear=\"no\"`- #6847 #6809 - you'll have a menu item in the first menu:\nImage\n\n- with a style tweak, if you can target the DocFragment or any other block section, you can yourself tag them as being non-linear - see URL \nA page break will be forced before and after, and these sections marked as non-linear, and that menu item will appear on next book reload.\n\n- manually on any book, including PDF by enabling in the first menu's `Settings> [x] Custom hidden flows` - see #10982.","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2025-01-25T10:33:46+08:00","repo_name":"koreader/koreader","issue_id":2810826397,"issue_number":13135,"issue_url":"https://github.com/koreader/koreader/issues/13135","linked_issue_ids":[726525270],"is_known_query_context":false},{"document_id":"gh_issue_726525270","fragment_type":"issue_description","sequence":0,"text":"FR: Support for `linear=\"no\"` files in EPUB\nThe EPUB specification provides for \"non-linear\" documents, files inside the EPUB that are not included in the normal flow of the text (turning pages from first to last), but that can be accessed though the TOC or hyperlinks. As far as I can see, this property is not supported by KOReader (or most other reading systems), and the non-linear files are treated as any other file. See URL (Note that non-linear documents must still be in the spine, so it is always clear what should be shown when paging forward/backward past their limits.)\n\n**Describe the solution you'd like**\nI'd like non-linear documents to be excluded from the normal flow, skipped when paging forward/backward and not counted in the total number of pages for the book or the chapter. If one \"visits\" these non-linear documents, there should be some indication that the \"pages\" are now outside the normal flow.\n\nFor instance, a book could have several chapters and after the final one a non-linear document with end-notes. When reading the book on page `140/322`, I find a link to an end-note, if I follow the link, I may be in page `[3/18]`. If I page forward to page `[18/18]`, and once again, nothing happens, because that's not the \"end of the book\" it's just the end of this out-of-flow document. If I page backward to `[1/18]` and one again, I go back to the \"normal flow\", to page `322/322`. And if I now page forward again, the \"end of book\" popup appears, because this is the end of the book (the last linear document). Of course I could instead \"return to previous position\" to go back to page `140/322` and continue reading the main text.\n\n**Describe alternatives you've considered**\nWell, the alternative is not doing anything, like currently, and having the book with 322+18 = 340 pages, and after page 322 forcing me to page through 18 pages of end-notes (which I may have already read) to reach the end of the book. Another alternative is excluding the non-linear document from normal paging, but not affecting the number of pages, which would be confusing if the book ends up finishing on page `322/340`.","author_login":"Jellby","author_association":"CONTRIBUTOR","created_at":"2020-10-21T14:04:11+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_713628547","fragment_type":"issue_comment","sequence":1,"text":"I have personally no interest in that - and I'd prefer in this case (as in other non-KOReader related contexts) to not be limited to what I'm shown, and see the real thing (all the pages, in their raw order) rather than some kind of view/hide setup a publisher has decided.\n \n\nI quite like that, and I do browse thru them, just to see if there is not some easter egg or some other pages than footnotes I have missed (or bug in footnotes and some content that would not have been part of the in-page footnotes, like images, tables...)\nAnd we have the SkimTo widget that helps a lot with that, skipping boring sections, knowing there's stuff after (what would this SkimTo widget show in the case of non-linear stuff?)\n\nAnyway, with crengine/KOReader, we have a single whole linear very-heighty document, and we cut slices in it to make pages. We have a single set of pages (with their top coordinates in the single heighty document), and we access these pages and the top coordinate to show page. That's how we pilot what to show from KOReader. So, this will and should never change.\nAny other abstraction should be another map of virtual_pages > real_pages/Xpointers/Y-top-coordinate, a bit like what was done for source page numbers in #6004 (except that in your case, the new page numbers are not absolute but a direct subset, with numbers possibly shifted, of the internal page numbers - and limitations in paging should be done in frontend, and toggable (crengine does not need to know and bother about that).\n\nSome thoughs anyways if one is having a go at that:\n- in crengine, we could mark docfragment as linear/hidden - but we should force a page-break when that flag changes between consecutive docfragments, as CSS might not ensure that.\n- frontend could then call a function to see if there is non-linear stuff, and if yes, it would fetch the list of pages and their flags (linear/hidden) to build a virtual pagemap\n- would need to add hooks in everything that go N page forward/backwards to stop, which would be kinda ugly, for some very rare books.\n\n(I'm sure very little books with footnotes would use that feature to help you from not having to browse thru these footnotes :) so, I wouldn't bother - I bothered with the source page numbers, as this might be to some a kind of valuable additional info.)\n \n\nIf one goes at that, I'd replace the last MAY by a SHOULD :)","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-21T14:43:24+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_713645309","fragment_type":"issue_comment","sequence":2,"text":"You're welcome to page through 3000 pages of footnotes in URL ;)\n \n\nYou bet. Since it's an optional feature that is nowhere implemented, as far as I know. But I'm not interested in bought or downloaded books, I'm interested in the books I create or edit, and having a good reading experience on those. And if KOReader could support this, I would enjoy it (I already add `linear=\"no\"` where relevant, although it has no effect).\n \n \n \n\nI agree that, if implemented, it should be a choice.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-21T15:07:13+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_713695680","fragment_type":"issue_comment","sequence":3,"text":"Btw, on your 1001 nights book, KOReader complains (but fixes) about:\n\n10/21/20-18:08:25 DEBUG validateAndFixToc(): quick scan\n10/21/20-18:08:25 DEBUG validateAndFixToc(): TOC needs fixing\n10/21/20-18:08:25 DEBUG BOGUS TOC: 241 3774 > 240 4589 - 1 31\n10/21/20-18:08:25 DEBUG fix prev 240 4589 => 3713\n10/21/20-18:08:25 INFO TOC had 1 bogus page numbers: fixed 1 items to keep them ordered.\n\nIt's one of your `linear=no` page that comes later in the spine vs when it appears in the toc - and we expect/require the TOC to be linearly increasing/monotonic - so we do this dynamic fix to keep it working. (I guess what you did is allowed, but not supported by our TOC code :)\n\nxml\n \n \n Khelifeh the Fisherman of Baghdad \n \n \n \n \n \n [Variant: Khelif the Fisherman of Baghdad]","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-21T16:22:43+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_713705841","fragment_type":"issue_comment","sequence":4,"text":"Thanks for pointing that out. I never tried it with KOReader, actually, how does it look? I believe I checked whether that was allowed and arrived to the conclusion that it was. But yes, I admit it's a bit clunky. In the paper book the \"variant\" appears as an appendix to one of the volumes, but with the all-in-one version I didn't want to put it as an appendix to the whole, and I didn't want to force a break in the nights flow.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-21T16:39:12+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_713716131","fragment_type":"issue_comment","sequence":5,"text":"It looks quite fine.\nSome possibly excessive quoting may be :) : \nimage","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-21T16:56:22+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_713724652","fragment_type":"issue_comment","sequence":6,"text":"You've seen nothing. Check e.g. Night XXXIII ;) That's what happens with the story-within-story thing.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-21T17:10:58+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_715899887","fragment_type":"issue_comment","sequence":7,"text":"Than part was easy, I could e.g. add a `hidden` attribute to the ` ` element and modify the css for extra fun:\n\nDocFragment[hidden] {\n page-break-before: always !important;\n page-break-after: always !important;\n background-color: red;\n}\n\n \n\nThat's where I'm getting stuck. How do I know which pages belong to each ` `? Or which ` ` contains the first line in a page?","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-24T11:13:16+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_715905143","fragment_type":"issue_comment","sequence":8,"text":"That was just some rhetorical thoughts :) I'm not sure I'd want anybody to have a go at that :)\nBut ok... providing more rhetorical thoughts :/\n \n\nYou can't currently. And I don't think it should be adressed that way.\nThere's some bit of code that does page splitting: lvpagesplitter. It's quite complex, tortuous and fragile - and it shouldn't care about xpaths/xpointers and fetch anything from the DOM, so it shouldn't think about accessing the DOM to know about a DocFragment.\nAfter a few minutes thinking, I think the more natural way to do that in the way crengine works would be:\n\nA) EPUB parsing, linear=false => add attribute to DocFragment - what you have already done. No need for the CSS page-break tweaks.\n\nB) Then, in lvrend.cpp/renderBlockEnhanced/FlowState, we walk the DOM. FlowState maintain some state and is a proxy to the page splitting code: renderBlockEnhanced adds \"lines/space\" (slices of document roll) with properties, and FlowState adds more properties or lines and ensure margin collapsing and page split flags.\nI think it should be around there that your cooking should happen:\n\nB1) Have a new member in FlowState to know if we're in a linear=true/false part of the DOM: update/reset it when entering/leaving a DocFragment with linear=false (I would prefer in that code that the state is nonlinear=true, so we can ignore stuff when reading and assume the normal case is \"false\").\n\nB2) when FlowState is forwarding \"lines\" to lvpagesplitter/LVRendPageContext, it would forward that flag - and ensure a page break when that state has changed (or may be lvpagesplitter should do that)\n\nB3) lvpagesplitter would have a new member/flag to its \"line/lineinfo\" objects, and a new member/flag to its \"page\" objects. When making pages from all the lines it has, (it could force a page split when meeting a new lines where that flag is changed), it would forward that flag to the \"page\" it is creating and adding.\n\nB4) then, in the list of pages, you have all pages with that new flag: whether the page is made of lines from a non-linear DOM section, or not.\n\nC) After that, I don't know :) we'd need to store somewhere that there are nonlinear pages. Frontend should know that and be able to get the page list (I don't think it ever needed that until now). So, stuff to add to cre.cpp and a bit of glue to lvdocview or lvtinydom to fetch that.\n\nD) After that, it's mostly ugly frontend Lua code :) I have no idea if it can/could/should be handled by the existing ReaderPageMap stuff, or if it would need a new module, or if it should be integrated into core readerrolling (I hope not).\nMay be that new module could provide a `getInternalPageNumber(cur_page, advance)`, and we would use everywhere we assumed `page_num = page_num + 1`, -1, +10, -10, `page_num = getInternalPageNumber(page_num, -10)` - which would just return `page_num -10` when no linear stuff or when it's disabled, and only do more complex stuff when it's enabled. (Oh my, I don't even want to think about all the edges cases, the footer page number, the TOC items pointing to stuff in non-linear pages, the reading statistics total page accounting, ... :)","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-24T12:02:47+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_715913375","fragment_type":"issue_comment","sequence":9,"text":"And I'm not sure I'll get anywhere. I'm not committing myself to implement this or making any promise, I'm just playing around.\n \n \n\nThanks, I think this was the missing piece. I had already guessed/tried to add some property (member) to the lines and pages, but was still missing the connection with the DOM.\n \n\nI'll worry about that later. I've never done any Lua, so that will be \"fun\" too.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-24T13:13:29+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_715915014","fragment_type":"issue_comment","sequence":10,"text":"You might not even need to add any new member (except may be a bool to lvRendPageList, the only thing that stays after rendering and is saved in the cache). Lines and Pages already have flags, and you could just add one bit:\n URL \nlike `RN_LINE_IS_NON_LINEAR 0x2000` and `RN_PAGE_NON_LINEAR 0x40`\n\n(I was going to propose to do B1-B4 and C - as I think it would be non intrusive and cheap - and would need me only a few hours - but you may already be deep in it :) so just say if you need me.)","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-24T13:26:50+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719663243","fragment_type":"issue_comment","sequence":11,"text":"I think I have something working. Still many things to polish and test, though. I have taken the following approach:\n* Page back/forward in \"reading mode\" skip non-linear fragments\n* In skim mode, all pages are accessed, so -10/+10 work as always\n\nI have also added an option to enable/disable the skipping behavior. This should trigger a repagination of the whole document, because of the forced pagebreaks that have to be introduced when enabled. How do I make sure that happens from the lua end? It's similar to changing font / margins / styles, I guess.\n\nSome pending issues:\n* I don't think this can be made to work in continuous mode, or is there some way to remove a fragment from the flow and still keep the rest as a continuous \"scroll\"? (`display: none` would work, but then it cannot be seen at all, not even in footnotes)\n* I haven't looked into the 2-page display yet, but I'm hoping this will be easier.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-30T16:41:13+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719723694","fragment_type":"issue_comment","sequence":12,"text":"On my emulator, among the 366 epubs I have gathered for testing or fixing stuff, 41 have some instance of `linear=.no` in their .opf. So, that makes ~10 % - non negligeable.\n \n\nGood :)\n \n\nOK. But once you're in a non-linear fragment (that you can reach only thru something else than page backward/forward), once in there, do page backward and page forward still allow you to page in that non-linear section (so, you can read in there a multi-pages footnote) ?\n \n\nNote that be default, we have this in epub.css : \n\ncss\n/* EPUB container of each individual HTML file */\nDocFragment {\n page-break-before: always;\n}\n\nThe only way to not have this is thru the Style tweaks \"Prevent page break at chapter start (or end)\".\n \n\nIt's a bit of some ugly work. It would need to be handled as a property of the ldomDocument/tinyNodeCollection, a bit like the global variables that have been made members of the document in URL (gHangingPunctuationEnabled is a bool, but does not need a re-render - gInterlineScaleFactor an int, and cause a re-render). Or may be a clearer example URL of how we interface from frontend and provide values (lvdocviewprops, lvdocview, lvtinydom).\n\nAnother option, if that's very rare, would be to use an additional -cr-hint CSS named value, so that the additional page-break work can be asked or prevented by just using an additional style tweak:\n\ncss\nDocFragment[linear=\"no\" i] {\n -cr-hint: ensure-non-linear-page-breaking;\n /* or if you want it enabled by default : */\n -cr-hint: skip-non-linear-page-breaking;\n}\n\nThat would be a bit less implicit than a proper menu item showing there are non-linear elements and providing options - but that's a solution.","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-30T18:28:11+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719731899","fragment_type":"issue_comment","sequence":13,"text":"Then it may also be helpful/useful for others... or it may show that those books are broken :grin: \n \n\nYes, you page normally. Only once you reach the boundary of the fragment you're taken back to the main flow. (So, if you're reading a multi-page footnote, reach the end and page forward without noticing it's the end, you may get the finish book dialog or get carried to some strange place in the book, depending on where exactly this fragment is placed in the spine.)\n \n\nRight, that was my point. I wouldn't want to \"break\" those tweaks.\n\nI'll consider your suggestions and see if it's worth it.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-30T18:45:01+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719952032","fragment_type":"issue_comment","sequence":14,"text":"Silly question: Is Lua caching my function calls? If so, how can I force it to forget them?\n\nWithout going too much into the details, I have something like:\n\nfunction CreDocument:getPageFlow(page)\n print(\"getPageFlow\", page)\n ... some other stuff that calls the crengine interface and returns a value\nend\n\nThis should be called once or several times for each page turn, since the frontend needs to know the flow for each page, so in `readerrolling.lua` there's something like:\n\n test_page = test_page + step\n test_page_flow = self.ui.document:getPageFlow(test_page)\n print(\"testing page\",test_page,\"flow\",test_page_flow)\n\nThe point here, I'm calling `getPageFlow` every time before printing `testing page`, so I should get the two prints. But I get this:\n\ngetPageFlow 3\ntesting page 3 flow 0\ngetPageFlow 4\ntesting page 4 flow 2\ngetPageFlow 5\ntesting page 5 flow 0\n\nwhich is good, now if I page back:\n\ntesting page 4 flow 2\ntesting page 3 flow 0\n\nno `getPageFlow` lines printed.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-31T15:52:04+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719952767","fragment_type":"issue_comment","sequence":15,"text":"There's a CRe callcache implemented in the Lua frontend, yeah.\n\nI'd say it's in credocument, but I'm not at my dev box right now ;).\n\nIn the meantime, you can disable it in the developer options menu ;).","author_login":"NiLuJe","author_association":"MEMBER","created_at":"2020-10-31T15:58:09+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719953184","fragment_type":"issue_comment","sequence":16,"text":"Yep, it does:\n URL \n\nEither disable this (while developping) in File browser > Tools > More tools > [ ] Enable cre call cache.\nOr add (now or later, you'll have to later) your new function(s) into the next stuff like:\n URL \nor the other ones depending on how the result can be cached.","author_login":"poire-z","author_association":"CONTRIBUTOR","created_at":"2020-10-31T16:01:29+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_719962893","fragment_type":"issue_comment","sequence":17,"text":"Hmm... Thank you both. I'd have to add `getPageCount` too, but that doesn't look clean.\nSomehow, when I change the view mode to continuous or paged, the relevant cache entries seem to be cleared/updated, but I can't figure out how/where. If I could do the same when toggling the \"hide non-linear\" option, that would be preferable, I believe.","author_login":"Jellby","author_association":"NONE","created_at":"2020-10-31T17:22:01+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_720092992","fragment_type":"issue_comment","sequence":18,"text":"That was my guess, but I'm calling a `set*` function and I don't get the cache cleared... Anyway, we can maybe discuss it further once I have an implementation to share.","author_login":"Jellby","author_association":"NONE","created_at":"2020-11-01T13:59:34+08:00","repo_name":"koreader/koreader","issue_id":726525270,"issue_number":6809,"issue_url":"https://github.com/koreader/koreader/issues/6809","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0414","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Consider adding a marker file like /.flatpak-info?","query_context":"This was suggested to my by Christian Hergert.\n\nIt would help him to improve debugging and tracing apps running in toolboxes.\n\nSomething like /.toolbox-info would be a nice parallel to what flatpak does. Alternatively, the already existing /run/.containerenv could maybe add enough information to clearly identify a container as a toolbox. E.g., it could show the container-init process.","known_context_document_ids":["gh_issue_1390623803"],"reference_answer":"Toolbox already uses `--privileged`, so that's fine. Any other flag that we can specify as a command-line argument is also fine.","answer_document_id":"gh_comment_737172518","silver_evidence_path":["gh_comment_1262350068","gh_issue_616644906","gh_comment_737172518"],"evidence_issue_ids":[1390623803,616644906],"source_repo_name":"containers/toolbox","source_issue_id":1390623803,"source_issue_number":1129,"source_issue_url":"https://github.com/containers/toolbox/issues/1129","target_repo_name":"containers/podman","target_issue_id":616644906,"target_issue_number":6192,"target_issue_url":"https://github.com/containers/podman/issues/6192","reference_anchor_document_id":"gh_comment_1262350068","reference_answer_author":"debarshiray","reference_answer_author_association":"MEMBER","quality_score":87.55,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.2619,"target_answer_overlap":0.0909},"issue_created_at":"2022-09-29T10:19:14+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1390623803","fragment_type":"issue_description","sequence":0,"text":"Consider adding a marker file like /.flatpak-info\nThis was suggested to my by Christian Hergert.\n\nIt would help him to improve debugging and tracing apps running in toolboxes.\n\nSomething like /.toolbox-info would be a nice parallel to what flatpak does. Alternatively, the already existing /run/.containerenv could maybe add enough information to clearly identify a container as a toolbox. E.g., it could show the container-init process.","author_login":"matthiasclasen","author_association":"COLLABORATOR","created_at":"2022-09-29T10:19:14+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1262137592","fragment_type":"issue_comment","sequence":1,"text":"When we tried to look for /run/.containerenv in Nieves' toolboxes, we could not find it, so there may be some unreliability in what podman does. The documentation sounds like the file may depend on the --privileged flag. That might be another reason for having our own marker file that is always there.","author_login":"matthiasclasen","author_association":"COLLABORATOR","created_at":"2022-09-29T11:20:32+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1262340948","fragment_type":"issue_comment","sequence":2,"text":"We do already have an empty `/run/.toolboxenv` to identify Toolbx containers that sits next to the more generic `/run/.containerenv` added by Podman.\n\nIf it's only a matter of filtering Toolbxes from other Podman containers, then `/run/.toolboxenv` should work. eg., it's already used in `/etc/profile.d/toolbox.sh`.\n \n \n \n\nCurrently, `/run/.containerenv` inside a Toolbx container looks like:\n\nengine=\"podman-4.2.0\"\nname=\"fedora-toolbox-36\"\nid=\"f030bfbfa089c191ab617f12d66a407e712b0e2b0c5a2f8dc5bced1dc0fbd1e2\"\nimage=\"registry.fedoraproject.org/fedora-toolbox:36\"\nimageid=\"a68a838b182ac44d4d53330bbe3aa49f9a7239f420bea22a8650f765ac4c1a9c\"\nrootless=1\ngraphRootMounted=1\n\nDo we only need a way to identify a Toolbx? Or do we need some more information? We could request Podman to add some more metadata bits to that file.","author_login":"debarshiray","author_association":"MEMBER","created_at":"2022-09-29T14:09:34+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1262350068","fragment_type":"issue_comment","sequence":3,"text":"That's odd.\n\nWhat about the `Annotations` and `CreateCommand` in the `podman inspect --type container ` JSON? Do they contain `privileged`?\n\nI have:\n\n$ podman inspect --type container fedora-toolbox-36 | grep privileged\n \"io.podman.annotations.privileged\": \"TRUE\",\n \"--privileged\",\n\n \n \n\nA `/run/.containerenv` file should always be there, regardless of whether the container was created with `--privileged` or not. The `--privileged` flag decides whether the file would be empty or have some metadata in it. That's because people were worried about potential security problems caused by the information leaking out through the `/run/.containerenv` file.\n\nToolbx containers are always created with `--privileged`, so they should always have a non-empty `/run/.containerenv`.","author_login":"debarshiray","author_association":"MEMBER","created_at":"2022-09-29T14:16:27+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[616644906],"is_known_query_context":false},{"document_id":"gh_comment_1262354760","fragment_type":"issue_comment","sequence":4,"text":"By the way, the `/run/.toolboxenv` file is mentioned in the `podman-create(1)` manual under *Container Configuration*.\n\nThere's also the `com.github.containers.toolbox` label for identifying Toolbxes from the host, which is used by `toolbox list`.","author_login":"debarshiray","author_association":"MEMBER","created_at":"2022-09-29T14:19:45+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1262363393","fragment_type":"issue_comment","sequence":5,"text":"Thanks, I'll ask Christian Hergert to chime in here with what, if anything, would be useful for him.","author_login":"matthiasclasen","author_association":"COLLABORATOR","created_at":"2022-09-29T14:26:35+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1262421954","fragment_type":"issue_comment","sequence":6,"text":"I think toolbox is the easier of situations to solve, at least when it comes to sysprof symbol decoding. If we know we can rely on access to the file-system, symbol resolving can mostly be a \"add this prefix to symbol paths to find the real .so/binary on the host\".","author_login":"chergert","author_association":"NONE","created_at":"2022-09-29T15:10:36+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1262622258","fragment_type":"issue_comment","sequence":7,"text":"@chergert Is other information about the toolbox setup that would be useful to you, that could be included in /run/.toolboxenv ?","author_login":"matthiasclasen","author_association":"COLLABORATOR","created_at":"2022-09-29T17:57:00+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1262756938","fragment_type":"issue_comment","sequence":8,"text":"Perhaps the location where the host system is mounted, so that we don't hard code things? But honestly, I'm fine with hard coding.\n\nI think I'll know more once we have a prototype to fix symbol resolving though.","author_login":"chergert","author_association":"NONE","created_at":"2022-09-29T20:06:05+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1263852867","fragment_type":"issue_comment","sequence":9,"text":"At the moment, it should be fine to hard code `/run/host` as the location where the host filesystem is bind mounted inside the container.\n\nFlatpak has a similar location, but I have heard that `/host` is used in the world of OpenShift.\n\nRegardless, `/run/host` is crucial for Toolbx at the moment. It's even embedded inside the `toolbox` binary.","author_login":"debarshiray","author_association":"MEMBER","created_at":"2022-09-30T17:50:55+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1263889659","fragment_type":"issue_comment","sequence":10,"text":"Thanks!\n\nI think it's probably fine to close this issue now until we have concrete needs for Sysprof/Builder/etc.","author_login":"chergert","author_association":"NONE","created_at":"2022-09-30T18:29:49+08:00","repo_name":"containers/toolbox","issue_id":1390623803,"issue_number":1129,"issue_url":"https://github.com/containers/toolbox/issues/1129","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_616644906","fragment_type":"issue_description","sequence":0,"text":"Provide metadata to identify a container from inside\n/kind feature\n\n**Description**\n\nSometimes I come across people who are looking for ways to identify their Toolbox containers while sitting inside them. One use-case is to customize the shell prompt, just like one of those fancy Git prompts that identify the current branch and such.\n\nI don't know what the ideal format would be.\n\nFlatpak puts a INI-style file with stanzas at `/.flatpak-info` that describes the container. JSON is another option, but it isn't something that you can parse using the barebones POSIX shell utilities.\n\n**Output of `podman version`:**\n\nVersion: 1.9.1\nRemoteAPI Version: 1\nGo Version: go1.13.10\nOS/Arch: linux/amd64\n\n**Output of `podman info --debug`:**\n\ndebug:\n compiler: gc\n gitCommit: \"\"\n goVersion: go1.13.10\n podmanVersion: 1.9.1\nhost:\n arch: amd64\n buildahVersion: 1.14.8\n cgroupVersion: v2\n conmon:\n package: conmon-2.0.15-1.fc31.x86_64\n path: /usr/bin/conmon\n version: 'conmon version 2.0.15, commit: 4152e6044da92e0c5f246e5adf14c85f41443759'\n cpus: 4\n distribution:\n distribution: fedora\n version: \"31\"\n eventLogger: file\n hostname: kolache\n idMappings:\n gidmap:\n - container_id: 0\n host_id: 1000\n size: 1\n - container_id: 1\n host_id: 100000\n size: 65536\n uidmap:\n - container_id: 0\n host_id: 1000\n size: 1\n - container_id: 1\n host_id: 100000\n size: 65536\n kernel: 5.4.14-200.notify.fc31.x86_64\n memFree: 1459437568\n memTotal: 8107806720\n ociRuntime:\n name: crun\n package: crun-0.13-2.fc31.x86_64\n path: /usr/bin/crun\n version: |-\n crun version 0.13\n commit: e79e4de4ac16da0ce48777afb72c6241de870525\n spec: 1.0.0\n +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL\n os: linux\n rootless: true\n slirp4netns:\n executable: /usr/bin/slirp4netns\n package: slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31.x86_64\n version: |-\n slirp4netns version 0.4.0-beta.3+dev\n commit: bbd6f25c70d5db2a1cd3bfb0416a8db99a75ed7e\n swapFree: 4133482496\n swapTotal: 4133482496\n uptime: 36m 30.59s\nregistries:\n search:\n - docker.io\n - registry.fedoraproject.org\n - registry.access.redhat.com\n - registry.centos.org\n - quay.io\nstore:\n configFile: /home/rishi/.config/containers/storage.conf\n containerStore:\n number: 1\n paused: 0\n running: 0\n stopped: 1\n graphDriverName: overlay\n graphOptions:\n overlay.mount_program:\n Executable: /usr/bin/fuse-overlayfs\n Package: fuse-overlayfs-1.0.0-1.fc31.x86_64\n Version: |-\n fusermount3 version: 3.6.2\n fuse-overlayfs: version 1.0.0\n FUSE library version 3.6.2\n using FUSE kernel interface version 7.29\n graphRoot: /home/rishi/.local/share/containers/storage\n graphStatus:\n Backing Filesystem: extfs\n Native Overlay Diff: \"false\"\n Supports d_type: \"true\"\n Using metacopy: \"false\"\n imageStore:\n number: 2\n runRoot: /run/user/1000/containers\n volumePath: /home/rishi/.local/share/containers/storage/volumes\n\n**Package info (e.g. output of `rpm -q podman` or `apt list podman`):**\n\npodman-1.9.1-1.fc31.x86_64","author_login":"debarshiray","author_association":"MEMBER","created_at":"2020-05-12T13:11:53+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_627356382","fragment_type":"issue_comment","sequence":1,"text":"Easy enough to do. Only 2 real questions in my mind are:\n- What metadata to include?\n- What format to use?","author_login":"mheon","author_association":"COLLABORATOR","created_at":"2020-05-12T13:46:42+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_627357014","fragment_type":"issue_comment","sequence":2,"text":"Initial suggestions on the first one: Full ID and name of the container, image it was created from (if applicable). Maybe whether we are rootless?","author_login":"mheon","author_association":"COLLABORATOR","created_at":"2020-05-12T13:47:46+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_627800872","fragment_type":"issue_comment","sequence":3,"text":"Here is how a typical /.flatpak-info looks:\n\n[Application]\nname=org.gnome.gedit\nruntime=runtime/org.gnome.Platform/x86_64/3.36\n\n[Instance]\ninstance-id=3514724854\ninstance-path=/home/alex/.var/app/org.gnome.gedit\napp-path=/var/lib/flatpak/app/org.gnome.gedit/x86_64/stable/8a739f92d76e9cb67976d63b3c307089340b6197ef0183575f5e21c97549b3b8/files\napp-commit=8a739f92d76e9cb67976d63b3c307089340b6197ef0183575f5e21c97549b3b8\nruntime-path=/home/alex/.local/share/flatpak/runtime/org.gnome.Platform/x86_64/3.36/ad7f022f9489ce44301a53fb2707858e8d38a9632ee4ee634885f1b618d858cf/files\nruntime-commit=ad7f022f9489ce44301a53fb2707858e8d38a9632ee4ee634885f1b618d858cf\nruntime-extensions=org.gnome.Platform.Locale=632d8a1afcb20db2f533b00cf4c3780e3494cff681ae08a692ed7805258e1784;org.freedesktop.Platform.GL.default=0d51f4a9d159c86e56afd387531de155129b1d5439d530133fc4b972713165bf;org.freedesktop.Platform.GL.nvidia-440-82=0ee7950a8725c1a50ed4a88052533f2d37993a2521f3eab28e6495799886eb35;org.freedesktop.Platform.openh264=15266352ca7587793d013fdb17530a24d728e09be4f4cf315dc5bf99ad4323e8\nbranch=stable\narch=x86_64\nflatpak-version=1.6.3\nsession-bus-proxy=true\nsystem-bus-proxy=true\n\n[Context]\nshared=ipc;\nsockets=x11;wayland;\nfilesystems=/foo;host;\n\n[Session Bus Policy]\norg.gtk.vfs.*=talk\n\n[Environment]\nGI_TYPELIB_PATH=/app/lib/girepository-1.0\nGST_PLUGIN_SYSTEM_PATH=/app/lib/gstreamer-1.0:/usr/lib/extensions/gstreamer-1.0:/usr/lib/x86_64-linux-gnu/gstreamer-1.0\nXDG_DATA_DIRS=/app/share:/usr/share:/usr/share/runtime/share:/run/host/user-share:/run/host/share\n\nI think, somewhat in order of importance, what most people are interested in is:\n\n * Am I in a container or on the host\n * What sort of container technology is used (i.e. flatpak vs podman)\n * What sort of environment am i running in (flatpak app+runtime, container name, base image name, etc)\n * What kind of permissions do I have wrt the host (network access, fs access, uid mapping, etc)\n\nBeyond this, most things are similar to on the host system and you if you want to look for a feature or option you can just use whatever probing code you would use on the host.","author_login":"alexlarsson","author_association":"NONE","created_at":"2020-05-13T07:25:52+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_628204693","fragment_type":"issue_comment","sequence":4,"text":"We currently create /run/.containerenv with no data in it.\nDocker creates /.dockerenv\n\nWe could populate these files with content, but don't we really need a standard location for returning this content between podman, buildah, cri-o, flatpack (bubblewrap?)\nI believe .containerenv is the correct name for this but I guess we could argue about location.\nName value pairs is the best thing for bash to use.","author_login":"rhatdan","author_association":"MEMBER","created_at":"2020-05-13T19:40:36+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_628209200","fragment_type":"issue_comment","sequence":5,"text":"The Flatpack example seems to be TOML, which seems like it would work pretty well as well","author_login":"mheon","author_association":"COLLABORATOR","created_at":"2020-05-13T19:49:43+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_628209430","fragment_type":"issue_comment","sequence":6,"text":"Ah, nevermind, it's not - no quoting, etc... I need more coffee","author_login":"mheon","author_association":"COLLABORATOR","created_at":"2020-05-13T19:50:16+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_690221830","fragment_type":"issue_comment","sequence":7,"text":"I suggest to create a package in common `github.com/containers/pkg/containerenv` and define a struct there along with a useful API to create and populate the file.\n\n@lsm5 could you do this (after bug week)? The reasoning to pack it into c/common is to allow other tools to use it and semi-standardize on a format.\n\nOnce we a PR draft is open, we can start bikeshedding on the format and fields.","author_login":"vrothberg","author_association":"MEMBER","created_at":"2020-09-10T12:00:05+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_706168020","fragment_type":"issue_comment","sequence":8,"text":"If someone wants to open a PR in containers/common to kick this off, it would be great. I like name value pares since it makes it easier to process from bash. \n\nI would worry about information leakage, so we need to be careful about what goes into this file.","author_login":"rhatdan","author_association":"MEMBER","created_at":"2020-10-09T13:03:15+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_724213390","fragment_type":"issue_comment","sequence":9,"text":"Ok no one has stepped forward for the past month on this. But what kind of data do we want. Looking at @alexlarsson Data, I am not sure how much of this makes sense. Are you looking for more info then the following. There is a slippery line where we don't want to leak too much information into the container for hacker purposes.\n\n[Container]\nNames=TestContainer\nId=5f7540486e88b23c42ceb658c7576d1b73e07de3b0c67e016bd0c34d7e00095a\n[Image]\nname=registry.centos.org/centos:latest\ndigest=c46009597289604ac5b188492347119c00f274a5591bd8d2f08e50b3101fab1a\n[Engine]\nname=podman-2.2.0-dev","author_login":"rhatdan","author_association":"MEMBER","created_at":"2020-11-09T19:03:50+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_726756237","fragment_type":"issue_comment","sequence":10,"text":"@rhatdan I think that, for most cases, you want/need to know which image (name, tag and digest) you are in. So, the info you propose should be more than enough.\n\nI mean this for general purposes and cases like **toolbox** users. Some other use cases, as **Flatpak**, probably would need more info, but they already have their ways and it might be too much info for more general cases.","author_login":"juanje","author_association":"NONE","created_at":"2020-11-13T13:10:51+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_726764976","fragment_type":"issue_comment","sequence":11,"text":"Yes, the container name and ID, and the image name and ID are the most important, I think.\n\nAs for the *engine*, would it be the version of Podman that started the container? Or the one that called `podman create`? I wouldn't mind leaving it out, unless someone specifically asks for it.","author_login":"debarshiray","author_association":"MEMBER","created_at":"2020-11-13T13:29:11+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_736816406","fragment_type":"issue_comment","sequence":12,"text":"@debarshiray What do you think if we only give this information out in --privileged mode? Or have a config flag and containers.conf to say whether we reveal it.\n\nSome engineers are raising concerns about the information leak, being a vector to attach the system.","author_login":"rhatdan","author_association":"MEMBER","created_at":"2020-12-01T20:59:16+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_737172518","fragment_type":"issue_comment","sequence":13,"text":"Toolbox already uses `--privileged`, so that's fine. Any other flag that we can specify as a command-line argument is also fine.","author_login":"debarshiray","author_association":"MEMBER","created_at":"2020-12-02T11:30:11+08:00","repo_name":"containers/podman","issue_id":616644906,"issue_number":6192,"issue_url":"https://github.com/containers/podman/issues/6192","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0415","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"GameCube Blueretro conflicts with Wavebird?","query_context":"### BlueRetro firmware version\n\n24.10\n\n### BlueRetro firmware specification\n\nHW1\n\n### BlueRetro firmware variant\n\nSystem specific\n\n### BlueRetro hardware type\n\nInternal install DIY\n\n### Manufacturer\n\nMyself\n\n### System used\n\nNintendo GameCube\n\n### Bluetooth controller brand & name\n\nWavebird\n\n### What is problem? (only list ONE problem per report)\n\nAfter I soldered the ESP32 HW1 on my Cube's controller board it works as it should with modern BT controllers but strangely enough the Wavebird controller stopped functioning since then. The analog stick does not work at all, I tried different frequencies like 1,6,8,16 but the issue persists.\nWhen I plug in a wired OEM controller it works perfectly fine.\n\nI also tried to add a small switch on the negative of ESP32 so that I can turn it OFF when I want to use Wavebird but when I do turn off the ESP32 the controller board does not work at all, it does not recognize any controllers at all!\n\nIf ESP32 can not coexist with Wavebird in peace thenn please provide instructions on how to disable ESP32 before using Wavebird.\n\n### What did you expect to happen?\n\nWavebird should function properly with ESP32 Blueretro\n\n### Attach files like logs or Bluetooth traces here\n\n_No response_","known_context_document_ids":["gh_issue_2594290900"],"reference_answer":"This is definetly an HW issues best to contact Greg, maybe he can test to see it's something specific to your board or not.","answer_document_id":"gh_comment_2816474332","silver_evidence_path":["gh_comment_2435497356","gh_issue_2571472369","gh_comment_2816474332"],"evidence_issue_ids":[2594290900,2571472369],"source_repo_name":"darthcloud/BlueRetro","source_issue_id":2594290900,"source_issue_number":1102,"source_issue_url":"https://github.com/darthcloud/BlueRetro/issues/1102","target_repo_name":"darthcloud/BlueRetro","target_issue_id":2571472369,"target_issue_number":1088,"target_issue_url":"https://github.com/darthcloud/BlueRetro/issues/1088","reference_anchor_document_id":"gh_comment_2435497356","reference_answer_author":"darthcloud","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1111,"anchor_target_overlap":0.1111,"target_answer_overlap":0.25},"issue_created_at":"2024-10-17T10:23:44+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2594290900","fragment_type":"issue_description","sequence":0,"text":"GameCube Blueretro conflicts with Wavebird\n### BlueRetro firmware version\n\n24.10\n\n### BlueRetro firmware specification\n\nHW1\n\n### BlueRetro firmware variant\n\nSystem specific\n\n### BlueRetro hardware type\n\nInternal install DIY\n\n### Manufacturer\n\nMyself\n\n### System used\n\nNintendo GameCube\n\n### Bluetooth controller brand & name\n\nWavebird\n\n### What is problem? (only list ONE problem per report)\n\nAfter I soldered the ESP32 HW1 on my Cube's controller board it works as it should with modern BT controllers but strangely enough the Wavebird controller stopped functioning since then. The analog stick does not work at all, I tried different frequencies like 1,6,8,16 but the issue persists.\nWhen I plug in a wired OEM controller it works perfectly fine.\n\nI also tried to add a small switch on the negative of ESP32 so that I can turn it OFF when I want to use Wavebird but when I do turn off the ESP32 the controller board does not work at all, it does not recognize any controllers at all!\n\nIf ESP32 can not coexist with Wavebird in peace thenn please provide instructions on how to disable ESP32 before using Wavebird.\n\n### What did you expect to happen?\n\nWavebird should function properly with ESP32 Blueretro\n\n### Attach files like logs or Bluetooth traces here\n\n_No response_","author_login":"Aleksi87","author_association":"NONE","created_at":"2024-10-17T10:23:44+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2594290900,"issue_number":1102,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1102","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2435497356","fragment_type":"issue_comment","sequence":1,"text":"Sounds a little similar to the issue I put in #1088. I have the full on laserbear kit though.","author_login":"bkacjios","author_association":"NONE","created_at":"2024-10-24T14:43:07+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2594290900,"issue_number":1102,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1102","linked_issue_ids":[2571472369],"is_known_query_context":false},{"document_id":"gh_comment_2437148867","fragment_type":"issue_comment","sequence":2,"text":"Edit: I have followed the MundoYakara method actually, maybe that is the reason I have these issues?\n URL","author_login":"Aleksi87","author_association":"NONE","created_at":"2024-10-25T08:02:41+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2594290900,"issue_number":1102,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816472876","fragment_type":"issue_comment","sequence":3,"text":"You can't make an internal mod this way.\n\nYou basicly got two devices talking on the same port simultenously. This will create issue.\n\nYou need something more complex like the lazerbear mod for this to work.","author_login":"darthcloud","author_association":"OWNER","created_at":"2025-04-19T02:21:46+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2594290900,"issue_number":1102,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2835294913","fragment_type":"issue_comment","sequence":4,"text":"Thank you very much for the response darthcloud! Please could you provide links to the individual pcbs and components each of them need to achieve an internal Blueretro result without having to order the Laserbear Controller PCB from USA ? You see I live in Albania and ordering from USA is very expensive and time waiting.\n\nThank you in advance!","author_login":"Aleksi87","author_association":"NONE","created_at":"2025-04-28T13:43:15+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2594290900,"issue_number":1102,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1102","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2571472369","fragment_type":"issue_description","sequence":0,"text":"Wavebird controllers sometimes don't work depending on order plugged in?\n### BlueRetro firmware version\n\n24.10\n\n### BlueRetro firmware specification\n\nHW2\n\n### BlueRetro firmware variant\n\nSystem specific\n\n### BlueRetro hardware type\n\nInternal install modkit\n\n### Manufacturer\n\nLaserbear\n\n### System used\n\nNintendo GameCube\n\n### Bluetooth controller brand & name\n\nN/A\n\n### What is problem? (only list ONE problem per report)\n\nThis is a weird one, and I'm not even really sure if this is a software bug or a hardware bug with Laserbear's Blue Retro Internal Adapter V3.\n\nThe best way to explain it, plugging in multiple wavebird receivers sometimes causes controllers to not be detected by the gamecube. This only seems to happen if the receivers are in ports that are next to each other, for example 1 & 2, 2 & 3, or 3 & 4. 1 & 4 also seem to cause the same issue. An odd thing to note is that plugging in 3 receivers in any order seems to fix it. 4 all plugged in also works as well.\n\nI tested this by putting all my receivers and a single wavebird on channel 1.\n\n URL \n\nAt 24 seconds, you can see the lights somewhat dim and flickering, which makes me think it's like constantly turning on and off the ports or something. I can confirm neither port was responding to inputs in Melee at that time.\n\n### What did you expect to happen?\n\nAll receivers to work no matter what position or how many are plugged in.\n\n### Attach files like logs or Bluetooth traces here\n\n_No response_","author_login":"bkacjios","author_association":"NONE","created_at":"2024-10-07T21:02:42+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2571472369,"issue_number":1088,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1088","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816474332","fragment_type":"issue_comment","sequence":1,"text":"This is definetly an HW issues best to contact Greg, maybe he can test to see it's something specific to your board or not.","author_login":"darthcloud","author_association":"OWNER","created_at":"2025-04-19T02:24:45+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2571472369,"issue_number":1088,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1088","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816874449","fragment_type":"issue_comment","sequence":2,"text":"Ah heck. Looks like I have actually have a v2 of the internal mod, and they now released v3 with better port detection.. I'm guessing it fixes this.\n\nThanks for looking though.","author_login":"bkacjios","author_association":"NONE","created_at":"2025-04-19T21:34:12+08:00","repo_name":"darthcloud/BlueRetro","issue_id":2571472369,"issue_number":1088,"issue_url":"https://github.com/darthcloud/BlueRetro/issues/1088","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0416","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Login Failing with utils.py?","query_context":"Kept receiving the error \"mechanicalsoup.utils.LinkNotFoundError\" when following the login instructions on your page using my Kenpom credentials. I noticed I was able to fix it when I commented out these two lines in utils.py:\n\n8 from ._DESAdapter import DESAdapter, environment_requires_DES_adapter\n24 if environment_requires_DES_adapter():\n25 session.mount(' URL DESAdapter())\n\nHope this helps!","known_context_document_ids":["gh_issue_1586758329"],"reference_answer":"Absolutely brilliant analysis @nickostendorf! Really appreciate you providing this info.\n\nAt first glance I am ok with the solution as proposed but would like to take some time to fully understand the (primarily security-related) implications (if any) of the fix for my own knowledge. I also want to make sure we logically gate this to apply only for those running Python 3.10.x and below.\n\nOnce I've gotten a grasp on it I plan to branch `master` and test in my own Azure environment. If you have time of your own in the next day or so and you're so inclined, feel free to take a stab at a PR for this.","answer_document_id":"gh_comment_1362884106","silver_evidence_path":["gh_comment_1442391609","gh_issue_1423798537","gh_comment_1362884106"],"evidence_issue_ids":[1586758329,1423798537],"source_repo_name":"j-andrews7/kenpompy","source_issue_id":1586758329,"source_issue_number":43,"source_issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","target_repo_name":"j-andrews7/kenpompy","target_issue_id":1423798537,"target_issue_number":33,"target_issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","reference_anchor_document_id":"gh_comment_1442391609","reference_answer_author":"esqew","reference_answer_author_association":"COLLABORATOR","quality_score":92.45,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0909,"anchor_target_overlap":0.1818,"target_answer_overlap":0.0435},"issue_created_at":"2023-02-15T23:45:52+08:00","valid_comment_count":57,"fragments":[{"document_id":"gh_issue_1586758329","fragment_type":"issue_description","sequence":0,"text":"Login Failing with utils.py\nKept receiving the error \"mechanicalsoup.utils.LinkNotFoundError\" when following the login instructions on your page using my Kenpom credentials. I noticed I was able to fix it when I commented out these two lines in utils.py:\n\n8 from ._DESAdapter import DESAdapter, environment_requires_DES_adapter\n24 if environment_requires_DES_adapter():\n25 session.mount(' URL DESAdapter())\n\nHope this helps!","author_login":"spaceman-spiff-else","author_association":"NONE","created_at":"2023-02-15T23:45:52+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1442391609","fragment_type":"issue_comment","sequence":1,"text":"See #44, this is probably related to #33 and the fix for it. Updating to python 3.11 _might_ fix it, but we need to look into this further.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2023-02-23T20:30:22+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[1423798537],"is_known_query_context":false},{"document_id":"gh_comment_1449188250","fragment_type":"issue_comment","sequence":2,"text":"Hi all, sorry to be late to the party (again, thanks to real life).\n\n@spaceman-spiff-else Can you comment with info regarding your execution environment (OS, Python version) as well as the full stack trace of the error itself?\n\nReviewing recently-raised issues (that I missed thanks to my day job being a day-and-night job in the new year) it seems this isn't working as expected for everyone. The `LinkNotFoundError`s being somehow related to `DESAdapter` are interesting as the configuration that it does for older Python versions shouldn't directly impact the content that comes back to the point where it throws these types of errors. For that code, I'd expect something more along the lines of the error described in #44 about the ciphers and whatnot.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2023-03-01T01:40:15+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1450643779","fragment_type":"issue_comment","sequence":3,"text":"Hey @esqew - no worries. Definitely higher priorities out there than troubleshooting this. Thanks for getting back to me though. I'm running Python 3.10.1 on Windows. For some reason I'm not able to create the error again. Attached screenshot is the current error I get (when I revert back to the full utils.py code). I was; however, able to pull the old error from a log. See below:\nFile \"C:\\Users\\XXX\\AppData\\Local\\Programs\\Python\\Python310\\lib\\site-packages\\mechanicalsoup\\stateful_browser.py\", line 222, in select_form\n raise LinkNotFoundError()\nmechanicalsoup.utils.LinkNotFoundError\n\nI'll upload to python 11 and revert back on any changes.\n\nimage","author_login":"spaceman-spiff-else","author_association":"NONE","created_at":"2023-03-01T18:21:38+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454363940","fragment_type":"issue_comment","sequence":4,"text":"@spaceman-spiff-else Did you install `kenpompy` using `pip` or did you download the zip from Github and install using `pip install .`? \nI'm wondering if the relative import error is because of how the package was configured. \n\nThe `LinkNotFoundError` can be a slew of things, but I believe this is getting thrown because kenpom.com is rejecting traffic due to `mechanicalsoup` not using the correct ciphers (`DESAdapter` not applying them to the mechanicalsoup session)? I could be wrong though. \n\nAs @esqew pointed out, this still should not be getting throw if you have Python >= 3.11.\n\n@spaceman-spiff-else can you run your script again and then run `python -V` and paste the terminal output here","author_login":"nickostendorf","author_association":"CONTRIBUTOR","created_at":"2023-03-04T03:48:52+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454973163","fragment_type":"issue_comment","sequence":5,"text":"I cannot reproduce this using either Python 3.9.6 or Python 3.11.0, albeit my environment is macOS. I'll have to finagle a Windows test environment sometime soon to see if I can reproduce there.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2023-03-05T03:04:24+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1456565838","fragment_type":"issue_comment","sequence":6,"text":"Here's the requested screenshot. Run using Windows Command Prompt. Again, just commenting out _from ._DESAdapter import DESAdapter_ works fine and I haven't found online a package of this name and so have never been able to download to my python environment. Also, kenpompy was installed using pip.\n\nimage","author_login":"spaceman-spiff-else","author_association":"NONE","created_at":"2023-03-06T17:19:04+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1457346136","fragment_type":"issue_comment","sequence":7,"text":"@spaceman-spiff-else Can you try invoking `schedules.py` using the Python interpreter, i.e. `py schedules.py` and let us know if you see the same issue? I'm curious if invoking it the way you are may be contributing to the issue you're seeing (I personally have never been able to get Python on Windows to execute Python files by themselves without invoking the interpreter itself).","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2023-03-07T01:34:41+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1457450473","fragment_type":"issue_comment","sequence":8,"text":"As an aside, I _highly_ recommend you look into the Windows Subsystem for Linux if you plan on trying to do any real programming on Windows @spaceman-spiff-else. It will save you much pain in the long run.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2023-03-07T03:19:04+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1458475578","fragment_type":"issue_comment","sequence":9,"text":"I missed this in my first read-through and wanted to address it for absolute clarity:\n \n\n`_DESAdapter` is a something we developed for #38 to fix some issues which were contributing to Cloudflare blocking our scrapes. It is not a discrete package and is not something you need to download separately since the complete code for the class is included in the codebase here.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2023-03-07T16:35:58+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1460659803","fragment_type":"issue_comment","sequence":10,"text":"Got it thanks for the info @j-andrews7. What would you say is the benefit to of WSL? I've just been lazy with using Command Prompt. I did finally move my script to a Jupyter Notebook and unfortunately still received the same error.\n\n@esqew - same thing happens when invoking the interpreter. Honestly I don't know enough about python to understand the difference between all the ways to execute my script. I just know it only works in Command Prompt without the DESAdapter import.\n\nimage","author_login":"spaceman-spiff-else","author_association":"NONE","created_at":"2023-03-08T18:28:20+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1460807562","fragment_type":"issue_comment","sequence":11,"text":"Having stuff just work, mostly. Pretty much every programming tool/library/package/whatever in existence works with Linux. Getting stuff to work natively in Windows is often a headache.\n\nBut WSL works great, and I've been using it professionally for years to great effect. Keep the convenience of Windows while still having a true unix command-line/environment. It's like cygwin, except it doesn't suck.\n\nTrust me, trying to stick solely with native Windows and programming is a path that leads only to pain.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2023-03-08T20:14:23+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1460911021","fragment_type":"issue_comment","sequence":12,"text":"@j-andrews7 good to know! I'm sure I've already run into countless errors that could have been simply a Windows environment issue. I'll definitely give WSL a try!","author_login":"spaceman-spiff-else","author_association":"NONE","created_at":"2023-03-08T21:38:32+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1475029093","fragment_type":"issue_comment","sequence":13,"text":"I cannot reproduce this issue on any platform/Python version combination.\n\nI'll do what I can to resolve the relative import issue in the next push that goes to `master`, but unless we can reliably reproduce the other symptoms relating to the login failure I'll consider this closed for the time being.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2023-03-18T23:22:57+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1586758329,"issue_number":43,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/43","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1423798537","fragment_type":"issue_description","sequence":0,"text":"Login failure due to Cloudflare intercepting requests\nHello,\n\nI am getting the following error when trying to use the login function: LinkNotFoundError()\n\nI am using the following code:\n\nbrowser = login(email, password)\n\nlinknotfounderror\n\nThis used to work fine last season\n\nAppreciate the help!","author_login":"steveroks","author_association":"NONE","created_at":"2022-10-26T10:30:01+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1293142203","fragment_type":"issue_comment","sequence":1,"text":"Here is the response im getting. Seems it is being blocked by Cloudflare...\n\n \n \n Please enable cookies. \n \n \n Sorry, you have been blocked \n You are unable to access kenpom.com \n \n \n \n \n \n \n \n \n \n \n\n \n \n \n Why have I been blocked? \n\n This website is using a security service to protect itself from online attacks. The action you just performed triggered the security solution. There are several actions that could trigger this block including submitting a certain word or phrase, a SQL command or malformed data. \n \n\n \n What can I do to resolve this? \n\n You can email the site owner to let them know you were blocked. Please include what you were doing when this page came up and the Cloudflare Ray ID found at the bottom of this page.","author_login":"steveroks","author_association":"NONE","created_at":"2022-10-27T08:01:30+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1293719357","fragment_type":"issue_comment","sequence":2,"text":"Thanks for the report! This was previously discovered in #24. A patch was subsequently issued and merged into `master` as part of #25, however the release on PyPi hasn't caught up to what we've got here.\n\nIf you need this functionality in the immediate term, you can install from the GitHub source but I imagine @j-andrews7 will push a new release with all the bug fixes we've got in the hopper before the season starts.","author_login":"esqew","author_association":"CONTRIBUTOR","created_at":"2022-10-27T15:37:32+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1305707568","fragment_type":"issue_comment","sequence":3,"text":"Will try to push a new release tonight.\n\nOn Mon, Nov 7, 2022, 8:11 AM trludt ***@***.***> wrote:","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-07T14:35:36+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[1423798537],"is_known_query_context":false},{"document_id":"gh_comment_1306568826","fragment_type":"issue_comment","sequence":4,"text":"This should be resolved in the latest release. Or at least the tests pass. If everything's still broken, blame @esqew.\n\nDo not actually do that - he's the only reason this ever got fixed. Thanks Sean!\n\n`pip install --upgrade kenpompy` should get you the latest version with this fix and a few others.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-08T03:16:46+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306574737","fragment_type":"issue_comment","sequence":5,"text":"<img width=\"609\" alt=\"Screenshot 2022-11-07 at 9 22 47 PM\" src=\" URL \n\nStill getting a Cloudfare error?","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T03:23:37+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306576923","fragment_type":"issue_comment","sequence":6,"text":"Working fine for me.\n\nWhat's `pip freeze | grep kenpom` give ya?","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-08T03:27:10+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306580056","fragment_type":"issue_comment","sequence":7,"text":"Hm. @esqew, have you noticed any inconsistencies with this? Working fine with python 3.8-3.10.\n\n@trludt can you try a few more times and see if you can get through? We are somewhat at Ken's power here, and if for whatever reason your IP is subject to more stringent measures, there's likely not a ton we can do.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-08T03:32:00+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306584036","fragment_type":"issue_comment","sequence":8,"text":"I've tried a bunch still no luck... This is wild. I probably pulled data once per day of the season last year. Could that have restricted my IP? And does a VPN change anything?","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T03:38:06+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306586155","fragment_type":"issue_comment","sequence":9,"text":"I asked Ken about this before I published it, and he basically said as long as people didn't abuse it, he was totally cool with it. I can't imagine once a day is a problem. \n\nNot sure about the VPN, though it could make sense if it's changing your IP geolocation to an area identified as more likely to be an attack.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-08T03:41:46+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306608938","fragment_type":"issue_comment","sequence":10,"text":"I just shot him an email. Hopefully he gets back to me. I've tried the browser = (email, pass) line at least 50 times today and still errors every time.","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T04:18:01+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1306700615","fragment_type":"issue_comment","sequence":11,"text":"FYI I'm using Spyder v5.1.5 and Python 3.9.12 in my script if that helps towards anything","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T06:28:49+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307159661","fragment_type":"issue_comment","sequence":12,"text":"I unfortunately cannot reproduce this on my end, and the CI/CD tests checked out fine last night.\n\n@trludt Where does your VPN reside geographically? Cloudflare will more closely scrutinize connections from IPs in higher-risk areas. Separately, can you provide a stripped down example that demonstrates this? Is it possible you're also trying to log in a bunch of times or scrape a ton of data in a short period?","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-11-08T12:45:09+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307283404","fragment_type":"issue_comment","sequence":13,"text":"<img width=\"718\" alt=\"Screenshot 2022-11-08 at 8 05 21 AM\" src=\" URL \n\n<img width=\"585\" alt=\"Screenshot 2022-11-08 at 8 10 10 AM\" src=\" URL \n\nI am always running into the Cloudflare error on that login step. I'm not always using the VPN (ExpressVPN) but when I am using it, my connection runs through primarily big US cities (Atlanta, Dallas, Phoenix)","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T14:11:08+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307327991","fragment_type":"issue_comment","sequence":14,"text":"Thanks for the context. Without being able to reproduce this issue, it's likely this is something relating to how Cloudflare is handling your specific connection or sessions.\n\nIt's possible Cloudflare's heuristics have detected either/both that (among other possibilities) (a) your account has logged in from multiple geographies in too short of a time span (\"impossible travel\" anomaly detection), or (b) your script, at one point or another, launched too many requests and Cloudflare is now taking it upon itself to block further requests for an indefinite amount of time.\n\nIf you're able, can you set your debugger to break on this exception and dump the contents of `str(browser.page.contents)` here to ensure that this exception is firing correctly at the very least?","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-11-08T14:42:29+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307342458","fragment_type":"issue_comment","sequence":15,"text":"Would that be in my script or altering the utils.py file under the Kenpompy code? @esqew","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T14:53:00+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307381988","fragment_type":"issue_comment","sequence":16,"text":"['html', '[if lt IE 7]> \n \n Attention Required! | Cloudflare \n \n \n \n \n \n \n \n body{margin:0;padding:0} \n \n \n if (!navigator.cookieEnabled) {\n window.addEventListener('DOMContentLoaded', function () {\n var cookieEl = document.getElementById('cookie-alert');\n cookieEl.style.display = 'block';\n })\n }\n \n \n \n \n \n Please enable cookies. \n \n \n Sorry, you have been blocked \n You are unable to access kenpom.com \n \n \n \n \n \n \n \n \n \n \n \n Why have I been blocked? \n This website is using a security service to protect itself from online attacks. The action you just performed triggered the security solution. There are several actions that could trigger this block including submitting a certain word or phrase, a SQL command or malformed data. \n \n \n What can I do to resolve this? \n You can email the site owner to let them know you were blocked. Please include what you were doing when this page came up and the Cloudflare Ray ID found at the bottom of this page. \n \n \n \n \n \n Cloudflare Ray ID: 766f4301ccfdf7e4 \n • \n \n Your IP:\n Click to reveal \n 136.29.142.190 \n • \n \n Performance & security by Cloudflare \n \n (function(){function d(){var b=a.getElementById(\"cf-footer-item-ip\"),c=a.getElementById(\"cf-footer-ip-reveal\");b&&\"classList\"in b&&(b.classList.remove(\"hidden\"),c.addEventListener(\"click\",function(){c.classList.add(\"hidden\");a.getElementById(\"cf-footer-ip\").classList.remove(\"hidden\")}))}var a=document;document.addEventListener&&a.addEventListener(\"DOMContentLoaded\",d)})(); \n \n \n \n \n window._cf_translation = {};\n \n \n \n \n , '\\n']","author_login":"trludt","author_association":"NONE","created_at":"2022-11-08T15:16:07+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307422743","fragment_type":"issue_comment","sequence":17,"text":"So it's definitely a Cloudflare interstitial (so the exception itself is working as intended). Unfortunately without a reliable way to reproduce this behavior outside your specific environment there's not much else we can advise you to do. Cloudflare deliberately doesn't share a ton of details to make it more difficult to circumvent their protections. Unless you're able to get in touch with KenPom himself (or someone who handles his Cloudflare account) and can look at the logs specific to the Cloudflare Ray ID values from the markup you posted, we're just shooting in the dark.\n\nIf you have the resources available, you may consider attempting to try this same code from another machine and/or using another KenPom account to see if it's reproducible across environments/accounts. The only other course of action I could recommend at this point would be to drop this altogether for at least a couple days to let any rate limiting that may be at play get fully reset.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-11-08T15:43:32+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307748746","fragment_type":"issue_comment","sequence":18,"text":"@trludt Please let me know if he reaches out to you on this issue. I am having similar results being blocked by Cloudflare. I originally had my own scraping pipeline developed through beautifulsoup that I used last year (about daily similar to you). Recently I ran my script to see if it still worked for this season and I received the 403 forbidden code. I then tried this python library as an alternative and received the same block. In my personal pipeline I also tried modifying User-Agent status and several other request headers and nothing resolved the issue.","author_login":"AVA-27","author_association":"NONE","created_at":"2022-11-08T19:49:51+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307763453","fragment_type":"issue_comment","sequence":19,"text":"@trludt and @AVA-27 I have also received the same LinkNotFoundError (now is replaced by Exception: Opening kenpom.com failed - request was intercepted by Cloudflare protection) after forcing kenpompy update via pip)\n\nI have also reached out to Ken via email and will let you know if I hear anything.\n\nFor context, I use a VPN (NordVPN) out of Atlanta (physically located in TN). Last night at about 2:00 AM CST I received the first error (on VPN), and tried again disconnected (still received LinkNotFound error).\n\nToday, after updating, I explicitly tried to re-run while being disconnected from VPN to see if there was a difference, but I'm afraid I might already be blacklisted b/c of the re-geotagging of my first request via VPN.","author_login":"RobMepham","author_association":"NONE","created_at":"2022-11-08T20:03:53+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307772642","fragment_type":"issue_comment","sequence":20,"text":"@RobMepham I never utilized a VPN to access the website and still cannot gain access so I am not sure if that is playing a role or not.","author_login":"AVA-27","author_association":"NONE","created_at":"2022-11-08T20:12:18+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1308064195","fragment_type":"issue_comment","sequence":21,"text":"Good to know I'm not alone! Currently working on migrating my script over to a lambda function on AWS, which was ultimately my plan all along. Maybe this is a good thing my hand is being forced 🤣","author_login":"trludt","author_association":"NONE","created_at":"2022-11-09T01:20:11+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1315060121","fragment_type":"issue_comment","sequence":22,"text":"So it seems Cloudflare interception may be more prevalent than I had initially anticipated. At this point, we know (or can reasonably infer) that the following factors play at least *something* of a role in determining whether or not to intercept requests:\n\n- Requesting against KenPom.com without including a `User-Agent` header\n- Using a \"browser\" without JavaScript support or otherwise disabled\n- Using while connected to a public VPN provider\n- Connecting from an IP block associated with a \"high risk\" geolocation\n\nThe latter two are a bit out of our scope of control in this instance, but I will be carving time in the coming days to tee up some experimentation where we can try to reconfigure how the requests are sent for those affected by this. Watch this space!","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-11-15T09:51:51+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1315794446","fragment_type":"issue_comment","sequence":23,"text":"This has been incredibly frustrating. I've been having my friend run this on his computer. Sometimes it works, sometimes it doesn't. It hasn't been working in an AWS lambda function either, triggering the Cloudflare exception. \n\nConsidering we all already pay for the access to the data, I wish we could at least get a response back from him why he's doing this","author_login":"trludt","author_association":"NONE","created_at":"2022-11-15T19:54:16+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1315807584","fragment_type":"issue_comment","sequence":24,"text":"It's a busy time of year for him, I expect he's travelling a lot and such. He _has_ responded to me in the past via e-mail, so I'd just advise some patience. It is an off-label use and all. \n\nLike @esqew said, there are a few kind of hack-y workarounds we can try, but there's no guarantee. Given that neither of us is able to reliably replicate the issue, we may need folks to test, so stay tuned.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-15T20:07:37+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316108307","fragment_type":"issue_comment","sequence":25,"text":"I had a few hours this morning to start experimenting specifically with how the `User-Agent` value actually affects what comes back from the server.\n\nIn short, using valid `User-Agent` values from modern browsers (h/t to @pzb's list) actually *triggers* the Cloudflare interstitial, and flipping back to the standard `Mozilla/7.0` we've got in `main` right now works as intended (in my environment, anyway). On this same tested-working connection path to the target site, `curl` actually works as well when given the explicit `User-Agent` value to use: `curl \" URL -A \"Mozilla/7.0\"` As such, I think it's fair to surmise the `User-Agent` header as it's currently configured in `utils.py` is unlikely the culprit causing these interstitials to pop.\n\nKnowing this, I would deduce that the blocks that have been reported are *moreso* driven by the IP ranges from which folks are running this code. Since popular VPN and cloud providers' IP blocks are well known, it is quite trivial for Cloudflare to block traffic originating from these sources. Since I haven't used Cloudflare in many years I had to do some research on how this is typically configured - turns out this blocking is fine-tuned by site owners/administrators. From a thread describing a similar issue on Cloudflare Community:\n \n\nWhat I am curious about is if this protection would also apply to a setup which would present itself as a modern browser with full-fledged support for JavaScript (a la Selenium, `pyppeteer`) that's running from within one of these IP ranges, but I dread the idea of bringing on something that has such a huge comptuational overhead compared to what we have working right now.\n\nIn any event, I'm going to start experimenting down this route running in an Azure/Colab/other cloud environment and report back. If this does seem to alleviate some of this blockage we'll have to see what we can do in terms of marking these more resource-heavy libraries as extras to be used in the event that all else fails.\n\nI would also *really* like to see if Ken does return anyone's email and what his opinion on the whole thing is, but I'm not holding my breath - he is a pretty busy guy.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-11-16T00:55:44+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1316168380","fragment_type":"issue_comment","sequence":26,"text":"I also played with the user-agent settings and found much the same.\n\nI originally tried the selenium route previously, but it was...not trivial\nand definitely had way more overhead.\n\nI _have_ managed to get a response from Ken before, but he's likely very\nbusy and potentially travelling right now.\n\nOn Tue, Nov 15, 2022, 6:55 PM Sean Quinn ***@***.***> wrote:","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-11-16T01:52:13+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[1423798537],"is_known_query_context":false},{"document_id":"gh_comment_1316302244","fragment_type":"issue_comment","sequence":27,"text":"I'm curious if he's open to someone helping him build an API that people can pay a little extra for access to the data. I brought that up in my last email to him","author_login":"trludt","author_association":"NONE","created_at":"2022-11-16T04:11:53+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1317375075","fragment_type":"issue_comment","sequence":28,"text":"Wanted to chime in here for anyone still having issues. We were able to workaround the 403 error by adding this line to our code. \nbrowser.set_user_agent('any-random-thing')\n\nAdded that line right below \"browser = mechanicalsoup.StatefulBrowser()\"\n\nThis was following advice from this post URL","author_login":"jkiddUA","author_association":"NONE","created_at":"2022-11-16T17:16:58+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1319405201","fragment_type":"issue_comment","sequence":29,"text":"@jkiddUA kudos to you, I was able to find a workaround. Updating to python 3.11 has fixed the Cloudflare issue, and I can now load data successfully.","author_login":"jacksonw765","author_association":"NONE","created_at":"2022-11-18T00:47:05+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1320771200","fragment_type":"issue_comment","sequence":30,"text":"I updated to python 3.11, however I tried to reinstall kenpompy, and receive an error \"Error: failed to build wheel for lxml\". How did you get around this once you upgraded?","author_login":"Harrisoneller","author_association":"NONE","created_at":"2022-11-19T03:11:57+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1320797986","fragment_type":"issue_comment","sequence":31,"text":"So I had to download the lxml wheel (.whl) from here URL Just download the correct one for your machine and place it in your working directory. In my case it was lxml‑4.9.0‑cp311‑cp311‑win_amd64.whl because I'm using a 64bit windows machine. And then from my virtual environment I ran the command, pip install lxml‑4.9.0‑cp311‑cp311‑win_amd64.whl. \n\nOnce that's successfully installed you should be able to run the kenpompy install.","author_login":"jkiddUA","author_association":"NONE","created_at":"2022-11-19T04:39:15+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1325638277","fragment_type":"issue_comment","sequence":32,"text":"Hi all, my testing the use of browser control libraries to overcome the reported Cloudflare issues remains ongoing as my availability permits. To recap what we know for sure:\n\n* Connections originating from infrastructure with outbound IPs assigned to popular public cloud providers (Azure/AWS/etc.) **will** be blocked/filtered\n* Connections originating with outbound IPs known to be associated with popular public VPN providers **will** be blocked/filtered\n* Connections without a \"valid\" `User-Agent` HTTP header **will** be blocked/filtered\n\nPotential mitigations:\n* Update to the latest version of `kenpompy` that's been published to `pypi`, if you haven't already: \n \n \nbash\n python3 -m pip install --upgrade kenpompy\n \n\n \n This will ensure that the latest patch with an appropriate `User-Agent` header setting is in place.\n* Some users indicate that updating to Python 3.11 may help ref , but it's unclear if this will work for 100% of users experiencing Cloudflare-related issues, or even *why* it works in the first place\n* Using a browser automation framework instead of the `MechanicalSoup` stateful browser (currently being developed and tested locally)\n* For those who **must** run their workload in a public cloud, it may be worth exploring whether an HTTP proxy might help to mitigate this - I'm looking to see if it might be helpful to allow the passing of a preconfigured `MechanicalSoup` instance to `login()` to allow for this type of configuration up front\n* Write to KenPom and beg/plead ask how we might be able to sidestep this protection for scraping purposes","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-11-23T20:44:05+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[1423798537],"is_known_query_context":false},{"document_id":"gh_comment_1333902937","fragment_type":"issue_comment","sequence":33,"text":"Hi all, I haven't lost sight of this! My local testing continues as my availability allows with a `selenium`-based retrofit for the MechanicalSoup functionality we use today.\n\nInterestingly, using `selenium` with a \"headless\" WebDriver is filtered by Cloudflare 100% of the time. This is slightly surprising (at least to me) because primitive/headless-only clients (like `cURL`), with the proper `User-Agent` header, are not normally filtered in the same way.\n\nAs a result, those who do require headless functionality are likely going to find this solution untenable, at least if/until we find a workaround. I'm aware of projects like `selenium-stealth` which have in the past been able to overcome this detection of headless webdrivers, but are now largely unmaintained (ostensibly due to the strides these providers have made in detecting them anyway). **I'm open to any and all suggestions from the folks here if someone is aware of something more modern that might have a better success rate.**\n\nThe next test I'm taking on is running non-headlessly from within an Azure environment to see if our hypothesis holds true that this should bypass Cloudflare's heuristics. If successful, I'll publish an experimental branch for others to test in the near future. More to come!","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-01T15:04:38+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1336417887","fragment_type":"issue_comment","sequence":34,"text":"I was trying to figure this out yesterday and I can't find anything that would indicate it is an issue specific to `MechanicalSoup`. In fact, I actually found the problem appeared to originate in the python `requests` library. There is clearly something that is not \"liking\" the way the library is sending the requests (Cloudflare most likely has a ruleset in place since majority of scraping is through python). I can't quite put my finger on it.\n\nI tested with a popular ruby library, `HTTParty` while on my VPN (through NordVPN) and got a 200 and like you mentioned cURL with the same exact headers works.\n\nI am going to continue digging when I get a bit more time.","author_login":"mbrundige","author_association":"NONE","created_at":"2022-12-04T13:54:56+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1338386685","fragment_type":"issue_comment","sequence":35,"text":"@johnfeldhausen Thanks for the report. Can you give us a bit more detail around your environment? Are you running on cloud infrastructure or through a VPN?","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-06T00:01:42+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340111057","fragment_type":"issue_comment","sequence":36,"text":"@esqew - I did get this to work with the following version (upgraded from 3.10 to 3.11):\n\n`Python 3.11.0 (v3.11.0:deaf509e8f, Oct 24 2022, 14:43:23) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin`. \n\nI deduce that this may be something with TLS fingerprinting in older versions of the `ssl` wrapper library. Here is the version of openssl (which is pertinent for the TLS fingerprint issue):\n\n`OpenSSL 1.1.1q 5 Jul 2022`","author_login":"mbrundige","author_association":"NONE","created_at":"2022-12-06T22:43:07+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1340234840","fragment_type":"issue_comment","sequence":37,"text":"@mbrundige Fascinating. I definitely missed an OpenSSL upgrade in the 3.11 RC2 release notes, but sure enough OpenSSL 1.1.1q is mentioned. I don’t doubt TLS fingerprinting plays a major role in Cloudflare heuristics, so this could indeed make a lot of sense if the changes in OpenSSL materially affect how this is carried out.\n\nThis would also track with earlier reports that a Ruby-based HTTP library didn't have issues being filtered when `MechanicalSoup`'s `requests` baseline did\n\nIn any event, this would certainly preclude the need for any browser-based workarounds.\n\n@steveroks @trludt @AVA-27 @RobMepham If possible, would you mind updating to the latest `kenpompy` and Python 3.11.0 and report of this resolves your Cloudflare-related issues?","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-07T01:07:47+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1345355390","fragment_type":"issue_comment","sequence":38,"text":"I will assume that if we don't hear back from anyone in the next week or so that the proposed fix (updating to Python 3.11) is working for those still otherwise experiencing this issue, and will close this issue accordingly.\n\nI'll also add a small section to `README` or a Wiki page to summarize the issue & fix as a place to point future users to.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-10T18:25:31+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1359752550","fragment_type":"issue_comment","sequence":39,"text":"Closing due to inactivity per my previous comment. We will consider the guidance to update to Python 3.11.x as the best solution. On the flipside, I am open to more reports in the future that might contradict that, in which case we'll re-open this and do further investigation on a case-by-case basis.\n\nThanks to everyone for their assistance to date!","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-20T17:06:24+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1360710078","fragment_type":"issue_comment","sequence":40,"text":"@esqew I found a workaround for Python < 3.11\n\n@mbrundige was right that it was a TLS fingerprinting issue. \nIt seems it is a cipher negotiation failure between requests and kenpom.\n\nI noticed that the ciphers were different in 3.11 than in 3.9. \nSo, I installed Python 3.11 in a virtual env and ran the following to export the ciphers:\n\n`python -c \"import ssl; print(ssl._DEFAULT_CIPHERS);\"`\n\nI then went back to my 3.9 environment and appended the 3.11 ciphers:\n\n`requests.packages.urllib3.util.ssl_.DEFAULT_CIPHERS += \\ ':@SECLEVEL=2:ECDH+AESGCM:ECDH+CHACHA20:ECDH+AES:DHE+AES:!aNULL:!eNULL:!aDSS:!SHA1:!AESCCM'`\n\nI don't believe this is the \"safest\" workaround as it could break some requests, but it works for this use case.\n\nFor anyone that may proceed with this, I recommend to export your current python environment's SSL ciphers and keep them so you can overwrite this change in case your requests package breaks.\n\nLet me know if anyone needs anymore context on this workaround.","author_login":"nickostendorf","author_association":"NONE","created_at":"2022-12-21T02:15:27+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1362884106","fragment_type":"issue_comment","sequence":41,"text":"Absolutely brilliant analysis @nickostendorf! Really appreciate you providing this info.\n\nAt first glance I am ok with the solution as proposed but would like to take some time to fully understand the (primarily security-related) implications (if any) of the fix for my own knowledge. I also want to make sure we logically gate this to apply only for those running Python 3.10.x and below.\n\nOnce I've gotten a grasp on it I plan to branch `master` and test in my own Azure environment. If you have time of your own in the next day or so and you're so inclined, feel free to take a stab at a PR for this.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-22T14:10:55+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363551049","fragment_type":"issue_comment","sequence":42,"text":"I'm happy to report that the proposed fix seems to alleviate the Cloudflare issue in all the environments in which I've been able to re-create the Cloudflare filtering issue! I would encourage everyone who is so inclined to pull a new copy of the repo locally and run the test suite to confirm that this is working for them.\n\nThanks again to you @nickostendorf - will be lodging a PR against `master` in a few minutes to have @j-andrews7 merge and push a new release to PyPi.","author_login":"esqew","author_association":"COLLABORATOR","created_at":"2022-12-23T02:28:07+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363644120","fragment_type":"issue_comment","sequence":43,"text":"@esqew 100% coverage on the test suite! \nGreat work and thank you for implementing.","author_login":"nickostendorf","author_association":"NONE","created_at":"2022-12-23T05:58:45+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1363644910","fragment_type":"issue_comment","sequence":44,"text":"Thanks for the work all. I'll push a new package release to PyPi in the next day or two.","author_login":"j-andrews7","author_association":"OWNER","created_at":"2022-12-23T06:00:42+08:00","repo_name":"j-andrews7/kenpompy","issue_id":1423798537,"issue_number":33,"issue_url":"https://github.com/j-andrews7/kenpompy/issues/33","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0417","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"build: Ram usage spike and potential stalling at 637/650 (linking?)?","query_context":"When building cosmic-applets, I and some other users experience a ram usage spike at this step. The step also takes longer than 30 minutes and still does not complete on my machine with 16 GB of ram. I had to quit the process because it was going nowhere for > 30 minutes.\n\nExtra note: This is when using `just build-release`. `just build-debug` has the same problem but at a different number (588/611 iirc)\n\nI talked with someone who knows a little more about rust than I do and it seems to be a problem when linking starts.","known_context_document_ids":["gh_issue_2141489273"],"reference_answer":"This might be made worse by building all the applets in parallel. Maybe limiting the amount of parallel jobs to one would help? `CARGO_BUILD_JOBS=1`","answer_document_id":"gh_comment_1941381645","silver_evidence_path":["gh_comment_1952160542","gh_issue_2131002754","gh_comment_1941381645"],"evidence_issue_ids":[2141489273,2131002754],"source_repo_name":"pop-os/cosmic-applets","source_issue_id":2141489273,"source_issue_number":236,"source_issue_url":"https://github.com/pop-os/cosmic-applets/issues/236","target_repo_name":"pop-os/cosmic-applets","target_issue_id":2131002754,"target_issue_number":221,"target_issue_url":"https://github.com/pop-os/cosmic-applets/issues/221","reference_anchor_document_id":"gh_comment_1952160542","reference_answer_author":"Drakulix","reference_answer_author_association":"MEMBER","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3529,"anchor_target_overlap":0.3529,"target_answer_overlap":0.0},"issue_created_at":"2024-02-19T04:42:24+08:00","valid_comment_count":4,"fragments":[{"document_id":"gh_issue_2141489273","fragment_type":"issue_description","sequence":0,"text":"build: Ram usage spike and potential stalling at 637/650 (linking?)\nWhen building cosmic-applets, I and some other users experience a ram usage spike at this step. The step also takes longer than 30 minutes and still does not complete on my machine with 16 GB of ram. I had to quit the process because it was going nowhere for > 30 minutes.\n\nExtra note: This is when using `just build-release`. `just build-debug` has the same problem but at a different number (588/611 iirc)\n\nI talked with someone who knows a little more about rust than I do and it seems to be a problem when linking starts.","author_login":"ryanabx","author_association":"NONE","created_at":"2024-02-19T04:42:24+08:00","repo_name":"pop-os/cosmic-applets","issue_id":2141489273,"issue_number":236,"issue_url":"https://github.com/pop-os/cosmic-applets/issues/236","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1951722106","fragment_type":"issue_comment","sequence":1,"text":"Update: I tried compiling cosmic-applets on my desktop (i7-13700k, 32GiB of ram) and maxed out the ram on the same step. The CPU seems to not max out, but the ram certainly does.","author_login":"ryanabx","author_association":"NONE","created_at":"2024-02-19T05:25:29+08:00","repo_name":"pop-os/cosmic-applets","issue_id":2141489273,"issue_number":236,"issue_url":"https://github.com/pop-os/cosmic-applets/issues/236","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1952160542","fragment_type":"issue_comment","sequence":2,"text":"Possibly the same problem as URL ?\n\nCompiling all applets in parallel takes quite the toll on ram usage, building them one-by-one should be much easier.","author_login":"Drakulix","author_association":"MEMBER","created_at":"2024-02-19T10:35:34+08:00","repo_name":"pop-os/cosmic-applets","issue_id":2141489273,"issue_number":236,"issue_url":"https://github.com/pop-os/cosmic-applets/issues/236","linked_issue_ids":[2131002754],"is_known_query_context":false},{"document_id":"gh_issue_2131002754","fragment_type":"issue_description","sequence":0,"text":"LTO=\"fat\" causing OOM\nI've tried on both nightly and stable gnu, it seems like, at least of this project, enabling fat LTO is causing high levels of memory usage, enough to crash my PC since it fills both ram and swap, and oom on linux is... well oom on linux. Reverting it to LTO=\"thin\" resolves the crashing.","author_login":"Quackdoc","author_association":"CONTRIBUTOR","created_at":"2024-02-12T21:20:31+08:00","repo_name":"pop-os/cosmic-applets","issue_id":2131002754,"issue_number":221,"issue_url":"https://github.com/pop-os/cosmic-applets/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1941381645","fragment_type":"issue_comment","sequence":1,"text":"This might be made worse by building all the applets in parallel. Maybe limiting the amount of parallel jobs to one would help? `CARGO_BUILD_JOBS=1`","author_login":"Drakulix","author_association":"MEMBER","created_at":"2024-02-13T12:13:20+08:00","repo_name":"pop-os/cosmic-applets","issue_id":2131002754,"issue_number":221,"issue_url":"https://github.com/pop-os/cosmic-applets/issues/221","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1950752204","fragment_type":"issue_comment","sequence":2,"text":"Doing 1 did prevent an OOM but the compile took over 40min to complete, I did try 4 jobs however that still hit an OOM","author_login":"Quackdoc","author_association":"NONE","created_at":"2024-02-18T01:49:37+08:00","repo_name":"pop-os/cosmic-applets","issue_id":2131002754,"issue_number":221,"issue_url":"https://github.com/pop-os/cosmic-applets/issues/221","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0418","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"`ivy.flatten`?","query_context":"ivy codebase lacks ivy.flatten method to flatten a matrix or a tensor which I feel is relevant for a lot of frontend/backend methods that would be added in future","known_context_document_ids":["gh_issue_1342170655"],"reference_answer":"Hello @Viditagarwal7479\nThanks for the suggestion but we have this function on Ivy API ivy.max()🙂","answer_document_id":"gh_comment_1290805227","silver_evidence_path":["gh_comment_1236080714","gh_issue_1356871035","gh_comment_1290805227"],"evidence_issue_ids":[1342170655,1356871035],"source_repo_name":"unifyai/ivy","source_issue_id":1342170655,"source_issue_number":3161,"source_issue_url":"https://github.com/unifyai/ivy/issues/3161","target_repo_name":"unifyai/ivy","target_issue_id":1356871035,"target_issue_number":3856,"target_issue_url":"https://github.com/unifyai/ivy/issues/3856","reference_anchor_document_id":"gh_comment_1236080714","reference_answer_author":"hirwa-nshuti","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.2941,"target_answer_overlap":0.375},"issue_created_at":"2022-08-17T19:15:09+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1342170655","fragment_type":"issue_description","sequence":0,"text":"`ivy.flatten`\nivy codebase lacks ivy.flatten method to flatten a matrix or a tensor which I feel is relevant for a lot of frontend/backend methods that would be added in future","author_login":"5hv5hvnk","author_association":"NONE","created_at":"2022-08-17T19:15:09+08:00","repo_name":"unifyai/ivy","issue_id":1342170655,"issue_number":3161,"issue_url":"https://github.com/unifyai/ivy/issues/3161","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1225461996","fragment_type":"issue_comment","sequence":1,"text":"Hi @5hv5hvnk,\n\nThanks for flagging, I will mention to the team!\n\nI will leave this issue open and report back :)","author_login":"jkeane508","author_association":"CONTRIBUTOR","created_at":"2022-08-24T09:23:28+08:00","repo_name":"unifyai/ivy","issue_id":1342170655,"issue_number":3161,"issue_url":"https://github.com/unifyai/ivy/issues/3161","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1225560216","fragment_type":"issue_comment","sequence":2,"text":"Hi,\n\nI have linked the issue to a PR that was working on an implementation for `ivy.flatten`. Once this PR has been merged this issue will be closed.\n\nThanks for Flagging!","author_login":"jkeane508","author_association":"CONTRIBUTOR","created_at":"2022-08-24T10:57:14+08:00","repo_name":"unifyai/ivy","issue_id":1342170655,"issue_number":3161,"issue_url":"https://github.com/unifyai/ivy/issues/3161","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1236080714","fragment_type":"issue_comment","sequence":3,"text":"We have discussed internally, and we have accepted that this function should be added to Ivy's functional API. This item has been added to our ongoing Ivy Extension issue. Therefore, this issue will now be closed. Thanks!","author_login":"johanjino","author_association":"CONTRIBUTOR","created_at":"2022-09-03T09:11:39+08:00","repo_name":"unifyai/ivy","issue_id":1342170655,"issue_number":3161,"issue_url":"https://github.com/unifyai/ivy/issues/3161","linked_issue_ids":[1356871035],"is_known_query_context":false},{"document_id":"gh_issue_1356871035","fragment_type":"issue_description","sequence":0,"text":"Extend Ivy Functional API\nExtend Ivy functional API ivy//ivy/functional/experimental. Each function will need implementation in each backend API and also the Ivy API. The tests will also need to be implemented. See the Deep Dive for more general information on how the functions should be implemented. Particular attention should be placed on the Superset Behaviour section when considering how best to design the function, and what features and arguments it should have. More information about this specific task is provided in the Open Tasks section of the contributor guide. All the implementations have to be placed in `experimental` directories for both, functional API, backend APIs, Array, and Container instances.\n\n`Linear algebra functions:` ivy//ivy/functional/experimental/linalg.py\n\n- [x] #5991\n- [x] #6180\n- [ ] #6269\n- [x] #6228\n- [x] #7748\n- [x] #8990\n- [ ] eigh_tridiagonal\n- [x] #8806\n- [ ] solve_triangular\n- [ ] #9579\n- [ ] #9325\n\n`sorting functions:` ivy//ivy/functional/experimental/sorting.py\n\n- [x] #6138\n\n`Manipulation functions:` ivy//ivy/functional/experimental/manipulation.py\n\n- [x] #5542\n- [ ] #5944\n- [x] #5787\n- [x] #5614\n- [x] #5683\n- [x] #5977\n- [x] #6874\n- [x] #5978\n- [x] #6079\n- [x] #7967\n- [x] #6787\n- [x] #6334\n- [x] #6340\n- [ ] frombuffer\n- [x] #7222\n- [x] #6873\n- [x] #6222\n- [x] #6734\n- [x] #6728\n- [x] #6761\n- [x] #6883\n- [x] #6886\n- [x] #6908 \n\n`Random functions:` ivy//ivy/functional/experimental/random.py\n\n- [x] #6156\n\n`Statistical functions:` ivy//ivy/functional/experimental/statistical.py\n\n- [ ] #7717\n- [x] #5715\n- [x] #6808\n- [x] #6702\n- [ ] #9566\n- [ ] #7014\n- [x] #6934\n- [x] #9298\n- [ ] histogramdd\n- [ ] bincount\n- [ ] #9417\n- [ ] percentile\n\n`Layers functions:` ivy//ivy/functional/experimental/layers.py\n\n- [x] #5303\n- [x] #5548\n- [x] #6888 \n- [x] #5465\n- [x] #5541\n- [ ] idct\n- [x] #9132\n- [x] #5620\n- [x] #5540\n- [x] #5501\n- [ ] #8827\n- [ ] #5325\n- [ ] #5105\n- [x] #5147\n- [ ] dropout3d\n- [ ] collapse_repeated\n- [x] #6120\n- [ ] inverse_mdct\n- [ ] inverse_stft\n- [ ] inverse_stft_window_fn\n- [ ] mdct\n- [ ] quantize\n- [ ] adaptive_avg_pool1d\n- [ ] #9522\n- [ ] #9381\n\n`Elementwise functions:` ivy//ivy/functional/experimental/elementwise.py\n\n- [x] #4236\n- [x] #5438\n- [x] #4789\n- [x] #4237\n- [x] #4815\n- [x] #6280\n- [x] #5793\n- [x] #5880\n- [x] #5706\n- [x] #5716\n- [ ] #9255\n- [x] #6864\n- [x] #6345\n- [x] #9208\n- [x] #6462\n- [x] #6123\n- [x] #6810\n- [x] #7809\n- [ ] frexp\n- [x] diff\n- [x] #6196\n- [x] #9009\n- [x] #6482\n- [x] #6284\n- [x] #6534\n- [x] #6468\n- [x] #6910\n- [x] #6684\n- [ ] hypot\n- [x] #6350\n- [x] #6097\n- [x] #6335\n- [ ] #9260\n- [x] #7150\n- [ ] real\n- [x] #9171\n\n`Sparse Array class:` ivy//ivy/functional/experimental/sparse_array.py\n\n- [x] #4097\n\n`Activation functions:` ivy//ivy/functional/experimental/activations.py\n\n- [x] #4529\n- [x] #8962\n\n`Creation functions:` ivy//ivy/functional/experimental/creation.py\n\n- [x] #6007\n\n`Norms:` ivy/ivy/functional/experimental/norms.py\n\n- [x] #9549\n\n`Utility:` ivy/ivy/functional/experimental/utility.py\n\n- [ ] #6695","author_login":"johanjino","author_association":"CONTRIBUTOR","created_at":"2022-08-31T06:44:33+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1290649570","fragment_type":"issue_comment","sequence":1,"text":"max() function is also missing could this be added in active tasks? Then I shall create a PR corresponding to it. \nAs this is also needed for PyTorch frontend open task URL","author_login":"Viditagarwal7479","author_association":"CONTRIBUTOR","created_at":"2022-10-25T14:29:46+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1290805227","fragment_type":"issue_comment","sequence":2,"text":"Hello @Viditagarwal7479\nThanks for the suggestion but we have this function on Ivy API ivy.max()🙂","author_login":"hirwa-nshuti","author_association":"MEMBER","created_at":"2022-10-25T16:05:10+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291025980","fragment_type":"issue_comment","sequence":3,"text":"Hey @hirwa-nshuti \nOhhh! I see my bad. Later noticed and fixed the error which was coming due to some sort of linking issue :smile:","author_login":"Viditagarwal7479","author_association":"CONTRIBUTOR","created_at":"2022-10-25T19:17:53+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1291026293","fragment_type":"issue_comment","sequence":4,"text":"Hey @hirwa-nshuti\nOhhh! I see my bad. Later noticed and fixed the error, which was coming due to some sort of linking issue smile","author_login":"Viditagarwal7479","author_association":"CONTRIBUTOR","created_at":"2022-10-25T19:18:12+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1579150610","fragment_type":"issue_comment","sequence":5,"text":"Added nanmin and nanmax function for PyTorch, Numpy, Jax, TensorFlow and Paddle backend. Additionally, implement api functions for ivy array and ivy container. #16328 #16327","author_login":"g-1f","author_association":"NONE","created_at":"2023-06-06T17:08:53+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1587182866","fragment_type":"issue_comment","sequence":6,"text":"Hi @YasCoMa, the two functions you are referencing seem to have been reserved already. Please make sure you follow our ToDo issues policy explained here every time you intend to start working on a function.","author_login":"AnnaTz","author_association":"CONTRIBUTOR","created_at":"2023-06-12T11:56:21+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588856341","fragment_type":"issue_comment","sequence":7,"text":"@khushi-411 Hey, Kushi . I have an idea in mind about implementing `erfc` for `ivy` function API but you're tagged in-that hence, pining you in-here .\n\nAlso, I see that you've already made a **PR** URL but it is showing as closed! \n\nIn case you're allowed to work with other people or just want to discuss it ; feel free to ping me ! \nWriting it in here as I can't find you on discord!","author_login":"akshatvishu","author_association":"CONTRIBUTOR","created_at":"2023-06-13T08:59:38+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1588877328","fragment_type":"issue_comment","sequence":8,"text":"Hey, @akshatvishu! My PR is still open, just that I was on leave for a couple of days, so I kept it draft (i.e., work in progress). I'll make sure to finish that soon. Thanks for your kind interest!\n\nIf interested, please feel free to pick any other exciting open issues at Ivy! Thanks.","author_login":"khushi-411","author_association":"CONTRIBUTOR","created_at":"2023-06-13T09:11:24+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1594571071","fragment_type":"issue_comment","sequence":9,"text":"@johanjino \n\nI created an issue on GitHub for the NCE loss function implementation. Could you link the NCE issue with the latest comment on this page?\n\nHere is the link for that issue page","author_login":"MarkCodering","author_association":"NONE","created_at":"2023-06-16T12:03:53+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1594691633","fragment_type":"issue_comment","sequence":10,"text":"Here you can find instructions on how to link your issues to our ToDos URL","author_login":"AnnaTz","author_association":"CONTRIBUTOR","created_at":"2023-06-16T13:38:12+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1602074724","fragment_type":"issue_comment","sequence":11,"text":"Hey, @hirwa-nshuti I don't see the API specification of modf in docstring, is there any other doc that can help me write the Extended Ivy Functional API of modf.","author_login":"RakshitKumar04","author_association":"CONTRIBUTOR","created_at":"2023-06-22T06:24:06+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1604209626","fragment_type":"issue_comment","sequence":12,"text":"But i saw and follow the instructions, it was not implemented even in experimental folder. I do not see a reason to disqualify my contribution.","author_login":"YasCoMa","author_association":"NONE","created_at":"2023-06-23T12:24:57+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1617567746","fragment_type":"issue_comment","sequence":13,"text":"Hi! You can open an issue for this. Please refer to the ToDo List Issues instructions.","author_login":"AnnaTz","author_association":"CONTRIBUTOR","created_at":"2023-07-03T07:56:29+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1663527795","fragment_type":"issue_comment","sequence":14,"text":"As I see you have added them to comments here above, they'll be assigned to you automatically🙂","author_login":"hirwa-nshuti","author_association":"MEMBER","created_at":"2023-08-03T08:32:55+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1674147231","fragment_type":"issue_comment","sequence":15,"text":"I have to add a small description in ivy\\ivy\\functional\\ivy\\experimental\\set.py for the function, i'll create a PR after that, can you assign the task back again, Tysm.","author_login":"nnilayy","author_association":"NONE","created_at":"2023-08-11T02:35:14+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1683831417","fragment_type":"issue_comment","sequence":16,"text":"@AnnaTz @hirwa-nshuti the implementation of log_poisson_loss is implemented wrong and tests are failing for it..can u assign that to me ?\nI will implement that in the correct way.","author_login":"sushmanthreddy","author_association":"CONTRIBUTOR","created_at":"2023-08-18T12:14:21+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1725185008","fragment_type":"issue_comment","sequence":17,"text":"my comment to work on binary cross entropy has vanished? Is someone already working on it? @hirwa-nshuti","author_login":"RummanAli","author_association":"NONE","created_at":"2023-09-19T09:53:01+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1725188730","fragment_type":"issue_comment","sequence":18,"text":"why I am not getting assigned to binary cross entropy? @hirwa-nshuti","author_login":"RummanAli","author_association":"NONE","created_at":"2023-09-19T09:55:28+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1759101185","fragment_type":"issue_comment","sequence":19,"text":"Hey `index_add` is missing from this list and here is an issue explaining why it's needs to be added #26801","author_login":"imsoumya18","author_association":"CONTRIBUTOR","created_at":"2023-10-12T07:43:54+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1786757430","fragment_type":"issue_comment","sequence":20,"text":"Kindly assign the below issue to me.\n\nlocal_response_norm #27187","author_login":"kamlishgoswami","author_association":"CONTRIBUTOR","created_at":"2023-10-31T08:44:23+08:00","repo_name":"unifyai/ivy","issue_id":1356871035,"issue_number":3856,"issue_url":"https://github.com/unifyai/ivy/issues/3856","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0420","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"No connection?","query_context":"Hi,\n\nI just installed Owntracks on my server yesterday. The server installed is not exposed to the Internet directly but behind a firewall and a reverse proxy. \nOn installation I didn't state a mail address to disable let's encrypt and configured my reverse proxy to do the SSL things as well as receive the (anyway optional) traffic on http/https and Forward it to my owntracks server. \nThe MQTT port 8883 is forwarded directly. \nI can access the frontend via Internet and my configured domain.\n\nMy problem is, that the app cannot connect to the app. In the firewall I see the traffic is going through. On the server I don't see anything listening on 0.0.0.0:8883 using `ss -l`.\nThere is just something listening on 127.0.0.1:1883 which turned out to be the mosquito broker. I am now unsure what should be and what the issue may be. \nAll of the three services are running. \nBtw: when I change to HTTP connection instead of MQTT nothing changes.\nReading the MQTT messages on the server I just see the ones from otrec.\n\nAny ideas?","known_context_document_ids":["gh_issue_2479989335"],"reference_answer":"Can you please verify that the Recorder is actually running?\n\n$ ps ax | grep recorder\n\nand can you see if you can query it from the command line of your Raspi?\n\n$ curl URL \n\nAs to the configuration you created in `configuration.yaml`: did you originally add an email address for Let's Encrypt to be activated?","answer_document_id":"gh_comment_2297314264","silver_evidence_path":["gh_comment_2308558778","gh_issue_2473963931","gh_comment_2297314264"],"evidence_issue_ids":[2479989335,2473963931],"source_repo_name":"owntracks/quicksetup","source_issue_id":2479989335,"source_issue_number":59,"source_issue_url":"https://github.com/owntracks/quicksetup/issues/59","target_repo_name":"owntracks/quicksetup","target_issue_id":2473963931,"target_issue_number":57,"target_issue_url":"https://github.com/owntracks/quicksetup/issues/57","reference_anchor_document_id":"gh_comment_2308558778","reference_answer_author":"jpmens","reference_answer_author_association":"MEMBER","quality_score":93.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1176,"anchor_target_overlap":0.2059,"target_answer_overlap":0.0435},"issue_created_at":"2024-08-22T05:02:27+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_2479989335","fragment_type":"issue_description","sequence":0,"text":"No connection\nHi,\n\nI just installed Owntracks on my server yesterday. The server installed is not exposed to the Internet directly but behind a firewall and a reverse proxy. \nOn installation I didn't state a mail address to disable let's encrypt and configured my reverse proxy to do the SSL things as well as receive the (anyway optional) traffic on http/https and Forward it to my owntracks server. \nThe MQTT port 8883 is forwarded directly. \nI can access the frontend via Internet and my configured domain.\n\nMy problem is, that the app cannot connect to the app. In the firewall I see the traffic is going through. On the server I don't see anything listening on 0.0.0.0:8883 using `ss -l`.\nThere is just something listening on 127.0.0.1:1883 which turned out to be the mosquito broker. I am now unsure what should be and what the issue may be. \nAll of the three services are running. \nBtw: when I change to HTTP connection instead of MQTT nothing changes.\nReading the MQTT messages on the server I just see the ones from otrec.\n\nAny ideas?","author_login":"Hunv","author_association":"NONE","created_at":"2024-08-22T05:02:27+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2303925698","fragment_type":"issue_comment","sequence":1,"text":"Nothing is listening on the MQTT TLS port (`0.0.0.0:8883`) because you disabled Let's Encrypt and we can thus not configure it for the Mosquitto broker which is now listening on `:1883` as you've already determined.\n\nIf you configure your devices to use non-TLS MQTT to that port, and your firewall is correctly configured to redirect to your OwnTracks server you should see data, also log entries for Mosquitto.","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-22T06:59:11+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2304969906","fragment_type":"issue_comment","sequence":2,"text":"OK that works. I see the data in the mosquitto broker now after I reconfigured the mosquito config to listen on 0.0.0.0:1883.\nThere is also an option to use WebSockets. Would that help? My expectation would be, that in that case the data is send via https to the server, which would be my reverse proxy. That one will \"unpack\" the https and forward the http to the OwnTracks server. Does it works that way (in theory)? Because in practice this is not working the same way I do it for a couple of regular websites.","author_login":"Hunv","author_association":"NONE","created_at":"2024-08-22T15:18:12+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2306957435","fragment_type":"issue_comment","sequence":3,"text":"Our OwnTracks Recorder can also have positions sent to it via HTTP (not Websockets), and our apps (iOS and Android) support HTTP as well.\n\nDo note, however, that a) support for multiple Friends is more difficult with HTTP and b) many of us think MQTT (over TLS) is the more reliable protocol to use with our apps.","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-23T12:07:38+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2307657449","fragment_type":"issue_comment","sequence":4,"text":"I'm just thinking about the best method I have that is in best case encrypted.\nI cannot use let's encrypt behind the reverse proxy because the reverse proxy is already doing it and is handling all of that requests. So the let's encrypt handling will never reach the OT server.\nIf I would use HTTP(S), the reverse proxy can handle the SSL certificate.\n\nAnother thing is: Should the position be visible in realtime in the \"Frontend\"-map? I see my position in the live map (if something is sent since I opened it). At the moment it is empty for me.","author_login":"Hunv","author_association":"NONE","created_at":"2024-08-23T19:05:47+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2307709916","fragment_type":"issue_comment","sequence":5,"text":"when Frontend loads new data, the positions will be visible, but it doesn't refresh by itself.\n\nI see my position in the live map (if something is sent since I opened it). At the moment it is empty for me.\n\nthat's unclear to me: what is empty?\n\nVerify that data is being received and stored by Recorder by checking files in /var/spool/owntracks/recorder/store/rec/ / /YYYY-mm.rec\n\nThat's the data the Recorder API uses to populate the maps.","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-23T19:42:47+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2307761450","fragment_type":"issue_comment","sequence":6,"text":"OK, that was a bit confusing:\nI see myself on the live map but I see nothing on the \"Frontend\" map - even after refresh.\nIn the file of the recorder are several coordinates with the current timestamp.","author_login":"Hunv","author_association":"NONE","created_at":"2024-08-23T20:24:04+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2307769688","fragment_type":"issue_comment","sequence":7,"text":"Please check the following:\n1. that you've selected a generous timeframe in Frontend\n2. also that you see a list of users / devices (right hand top of Frontend)\n3. do you see a version number of owntracks/recorder in Frontend? What does it say?","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-23T20:31:07+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308549442","fragment_type":"issue_comment","sequence":8,"text":"Hi,\n1. I use the standard timeframe (1 month from now to the past)\n2. In the right combobox I just have \"Show all\"\n3. It says \n\n[owntracks/frontend] (2.15.3)\n[owntracks/recorder] (Loading version...)\n\n4. When I open the Frontend page, the page is always fully zoomed in the sea at the south of Ghana. I think this is just the \"middle\" of the map and the default if there is nothing else to focus on?","author_login":"Hunv","author_association":"NONE","created_at":"2024-08-24T21:46:16+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308558778","fragment_type":"issue_comment","sequence":9,"text":"Sorry you're having trouble with this. I fear that during our last release of the Recorder we got the startup script wrong, at least that's what it's looking like.\n\nPlease start reading the steps in this issue and see whether they apply to your situation as well. In particular:\n\n1. is the Recorder actually running and providing data\n2. is the `baseUrl` in Frontend's config correct?","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-24T22:29:54+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[2473963931],"is_known_query_context":false},{"document_id":"gh_comment_2308570534","fragment_type":"issue_comment","sequence":10,"text":"Hi,\n1. Yes, it is running\n2. Yes and no. The URL was http:// but it actually is https:// due to the reverse proxy. If you access http:// you will automatically redirected to URL But the Reverse Proxy itself is talking with HTTP (no S) to the OwnTracks server.\nIt was like `baseUrl: \" URL and I added the `s` and restarted the server after. I don't know if that should be enough.","author_login":"Hunv","author_association":"NONE","created_at":"2024-08-24T23:18:54+08:00","repo_name":"owntracks/quicksetup","issue_id":2479989335,"issue_number":59,"issue_url":"https://github.com/owntracks/quicksetup/issues/59","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2473963931","fragment_type":"issue_description","sequence":0,"text":"ownTracks frontend without OpenStreetMaps\nI followed installation guide: URL and successfully installed all necessary components on a raspberry pi 3 B rev. 1.2\n\n_system info\nLast bootstrap: 2024-08-16T11:21:02Z\nAnsible version: 2.17.3\nOS distro: Debian / 12\nOS distribution: bookworm_\n\n\"Live map\" and \"device table\" work perfectly, mobile device reports location correctly.\n\n**BUT**, when using \"Frontend\" instead of OpenStreetMaps just a light blue map is shown -> screenshot\nowntracks/frontend (2.15.3)\n\nAny idea?\nownTracks_Frontend","author_login":"dietmarhein","author_association":"NONE","created_at":"2024-08-19T18:39:21+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297218838","fragment_type":"issue_comment","sequence":1,"text":"That sounds a bit as though Frontend hasn't yet \"seen\" data from the Recorder API...\n\nOn the top right of Frontend is a selector for users & devices: do you see any data populated there?\n\nAnd if a bit further on the left you select an older time range?","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-19T18:48:41+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297257753","fragment_type":"issue_comment","sequence":2,"text":"ownTracks_Frontend_info\nthat's all I see. Maybe some issues with user permissions? Version is never displayed owntracks/recorder **(Loading version...)** when clicking on \"information\"\nownTracks_Frontend_info","author_login":"dietmarhein","author_association":"NONE","created_at":"2024-08-19T19:10:36+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297314264","fragment_type":"issue_comment","sequence":3,"text":"Can you please verify that the Recorder is actually running?\n\n$ ps ax | grep recorder\n\nand can you see if you can query it from the command line of your Raspi?\n\n$ curl URL \n\nAs to the configuration you created in `configuration.yaml`: did you originally add an email address for Let's Encrypt to be activated?","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-19T19:43:13+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297323683","fragment_type":"issue_comment","sequence":4,"text":"- yes, recorder is running\n- curl URL -> {\"version\":\"0.9.8\",\"git\":\"0.9.8-0-g488eabe3e3\"}\n- yes, I originally added an email-address; Let's encrypt SSL certificate is present.","author_login":"dietmarhein","author_association":"NONE","created_at":"2024-08-19T19:48:47+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297343484","fragment_type":"issue_comment","sequence":5,"text":"Please check whether the content of Frontend's configuration makes sense, particularly the `baseUrl` value:\n\n$ cat /usr/share/nginx/html/owntracks/frontend/config/config.js\n\n(no need to paste that here, for privacy; if you're unsure, please send us the file to `support@owntracks.org` and we'll look at it)\n\nIf the file does make sense, and the URL is accessible *from* your Raspi to your Raspi (`curl` will tell you that), then I'm going to do something unusual and ask you to please reboot the Raspi ...","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-19T20:00:28+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297345963","fragment_type":"issue_comment","sequence":6,"text":"To clarify: the `baseUrl` must be accessible from your Web browser.","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-19T20:01:32+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2297939822","fragment_type":"issue_comment","sequence":7,"text":"Thank you very much for your hints. Finally I fixed the issue. 🤗\n\nProblem was: I had to open another port than 443 at my ISP router forwarded to raspi 443.\n\nI had to add the opened WAN port to `baseUrl` to get OpenStreetMaps working on Frontends page.\n\nMaybe a feature for quicksetup would be to choose the local port at setup.","author_login":"dietmarhein","author_association":"NONE","created_at":"2024-08-20T04:26:18+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2298068456","fragment_type":"issue_comment","sequence":8,"text":"Glad you got it working!\n\nSo in essence, your ISP offered you, say, TCP port `1009` which you are redirecting into `443`, so you've configured your `baseUrl` to be ` URL for an _nginx_ on the Quicksetup machine running on 443.\n\nI'll make a mental note to consider your feature request. However, one of the ideas behind _quicksetup_ was to keep it as simple (and thus configuration-free) as possible...\n\nPlease keep in mind for your own installation, that whenever you re-run `./bootstrap.sh`, say to add a friend, or reconfigure something, that your Frontend's `config.js` will be overwritten.","author_login":"jpmens","author_association":"MEMBER","created_at":"2024-08-20T06:30:31+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2298414100","fragment_type":"issue_comment","sequence":9,"text":"yes, absolutly correct and I keep in mind that each time I do a re-run of `./bootstrap.sh`, I will have to reconfigure `config.js` to fit my needs regarding ISP WAN/LAN forwarding. Thanks again for pointing me to the problem!","author_login":"dietmarhein","author_association":"NONE","created_at":"2024-08-20T09:34:43+08:00","repo_name":"owntracks/quicksetup","issue_id":2473963931,"issue_number":57,"issue_url":"https://github.com/owntracks/quicksetup/issues/57","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0421","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[v2 QUESTION]: Ray \"Failed to start the dashboard\"?","query_context":"**What are you trying to do?**\nI'm a beginner for chemprop and machine learning. I recently started trying out the hyperparameter optimization feature. After installing the ray package, I attempted to run the command \"chemprop hpopt --data-path --task-type --search-parameter-keywords --hpopt-save-dir \". However, I always encountered errors\"Failed to start the dashboard , return code 3221226505\". It seems to be a problem with Ray.\nray 2.46.0\nchemprop 2.1.2\ngrpcio 1.71.0\naiohttp 3.11.16\nprotobuf 6.30.2\nPrevious attempts\n\n**Previous attempts**\nI tried to uninstall ray and used \"pip install ray[default]\". However, the problem is still there.\n\n**Screenshots**\nImage","known_context_document_ids":["gh_issue_3101822811"],"reference_answer":"@kolcker Could you try the following wheel depending on your Python version and see if it works for you:\n\n URL \n\n URL \n\n URL \n\n URL","answer_document_id":"gh_comment_2980956749","silver_evidence_path":["gh_comment_2922948417","gh_issue_3036241069","gh_comment_2980956749"],"evidence_issue_ids":[3101822811,3036241069],"source_repo_name":"chemprop/chemprop","source_issue_id":3101822811,"source_issue_number":1241,"source_issue_url":"https://github.com/chemprop/chemprop/issues/1241","target_repo_name":"ray-project/ray","target_issue_id":3036241069,"target_issue_number":52739,"target_issue_url":"https://github.com/ray-project/ray/issues/52739","reference_anchor_document_id":"gh_comment_2922948417","reference_answer_author":"jjyao","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.25,"anchor_target_overlap":0.3125,"target_answer_overlap":0.1},"issue_created_at":"2025-05-30T01:07:53+08:00","valid_comment_count":25,"fragments":[{"document_id":"gh_issue_3101822811","fragment_type":"issue_description","sequence":0,"text":"[v2 QUESTION]: Ray \"Failed to start the dashboard\"\n**What are you trying to do?**\nI'm a beginner for chemprop and machine learning. I recently started trying out the hyperparameter optimization feature. After installing the ray package, I attempted to run the command \"chemprop hpopt --data-path --task-type --search-parameter-keywords --hpopt-save-dir \". However, I always encountered errors\"Failed to start the dashboard , return code 3221226505\". It seems to be a problem with Ray.\nray 2.46.0\nchemprop 2.1.2\ngrpcio 1.71.0\naiohttp 3.11.16\nprotobuf 6.30.2\nPrevious attempts\n\n**Previous attempts**\nI tried to uninstall ray and used \"pip install ray[default]\". However, the problem is still there.\n\n**Screenshots**\nImage","author_login":"Alang-chem","author_association":"NONE","created_at":"2025-05-30T01:07:53+08:00","repo_name":"chemprop/chemprop","issue_id":3101822811,"issue_number":1241,"issue_url":"https://github.com/chemprop/chemprop/issues/1241","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2922100667","fragment_type":"issue_comment","sequence":1,"text":"Can you share this file?\n\nC:\\Users\\LENOVO\\AppData\\Local\\Temp\\ray \\session_2025-05-30_09-00-17_586800_104820\\logs\\dashboard.err\n\nI think it has more details about the error.","author_login":"KnathanM","author_association":"MEMBER","created_at":"2025-05-30T11:21:43+08:00","repo_name":"chemprop/chemprop","issue_id":3101822811,"issue_number":1241,"issue_url":"https://github.com/chemprop/chemprop/issues/1241","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2922948417","fragment_type":"issue_comment","sequence":2,"text":"@Alang-chem I think it's this error: URL \n\nWhich you may be able to resolve by running `pip install 'ray[tune]==2.44.1'` - could you try that and then re-run your command to see if it works?","author_login":"JacksonBurns","author_association":"MEMBER","created_at":"2025-05-30T17:24:03+08:00","repo_name":"chemprop/chemprop","issue_id":3101822811,"issue_number":1241,"issue_url":"https://github.com/chemprop/chemprop/issues/1241","linked_issue_ids":[3036241069],"is_known_query_context":false},{"document_id":"gh_comment_2945739829","fragment_type":"issue_comment","sequence":3,"text":"Maybe your error is similar to this one? URL \nTry using these flags to tell ray what resources it can use:\n\n--raytune-use-gpu\n--raytune-num-cpus 20,\n--raytune-num-gpus 1 \n--raytune-max-concurrent-trials 1\n\nSee also: URL","author_login":"KnathanM","author_association":"MEMBER","created_at":"2025-06-05T19:02:46+08:00","repo_name":"chemprop/chemprop","issue_id":3101822811,"issue_number":1241,"issue_url":"https://github.com/chemprop/chemprop/issues/1241","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2955240724","fragment_type":"issue_comment","sequence":4,"text":"Thank you for your advice.\nI used those command as you said.\nrun`chemprop hpopt --data-path tests/data/regression.csv --task-type regression --search-parameter-keywords depth ffn_num_layers message_hidden_dim --hpopt-save-dir results --raytune-use-gpu --raytune-num-cpus 20 --raytune-num-gpus 1 --raytune-max-concurrent-trials 1`\nI always received the same error\n`[W socket.cpp:697] [c10d] The client socket has failed to connect to [LAPTOP-5AHFJTSJ]:55660 (system error: 10049 - �����������У�������ĵ�ַ��Ч��)`\nIt seems that pytorch canont strat the distributed training in my windows. I find some similar problems on #80638 and #42831. Is it related to Windows 11 system?\n\nHere is my result and error file.\n\nresult 25.6.9.txt\nerror.txt","author_login":"Alang-chem","author_association":"NONE","created_at":"2025-06-09T09:35:34+08:00","repo_name":"chemprop/chemprop","issue_id":3101822811,"issue_number":1241,"issue_url":"https://github.com/chemprop/chemprop/issues/1241","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2963871434","fragment_type":"issue_comment","sequence":5,"text":"Seems like there are bits and pieces of this problem reported all over the place.\n\nMy suggestion would be to set `USE_LIBUV` to `0` to try and force PyTorch to use a different distributed backend, which is possibly at least tangentially related to this problem.\n\nOther good solution is to just keep downgrading `ray[tune]` and `pytorch` until you find some set of them that works.\n\nThis does not seem to be a chemprop error, so I will close this issue for now. Please re-open if the errors start coming from something to do with chemprop, or if you find a solution that might be useful to others.","author_login":"JacksonBurns","author_association":"MEMBER","created_at":"2025-06-11T19:04:06+08:00","repo_name":"chemprop/chemprop","issue_id":3101822811,"issue_number":1241,"issue_url":"https://github.com/chemprop/chemprop/issues/1241","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3036241069","fragment_type":"issue_description","sequence":0,"text":"[Core] `ray.init()` and `ray start` fails on Windows 11 in ray 2.45+\n### What happened + What you expected to happen\n\nHello,\n\nafter installing latest release 2.45 - no upgrade, removed older release before - I notice following fundamental issue.\n\nCalling ray start --head in CLI leads to following console output.\n \n \n \n \n \n \n \n \n \n \n \n\nI am surprised that the app says \"Ray runtime started\", but I do not get` ray status` feedback.\n \n \n\nContent of `dashboard.log` file\n \n \n \n \n \n \n \n \n \n \n \n\nContent of `dashboard.error` file\n \n\n### Versions / Dependencies\n\nray == 2.45\nWindows == 26100.3915\n\n### Reproduction script\n\n`> ray start --head`\n\n### Issue Severity\n\nHigh: It blocks me from completing my task.","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-05-02T15:01:46+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2849100785","fragment_type":"issue_comment","sequence":1,"text":"I'm experiencing the same issue. Some addtional information from raylet.log \n\n[2025-05-04 12:06:23,685 I 32292 25604] (raylet.exe) agent_manager.cc:83: Agent process with name dashboard_agent exited, exit code 1.\n[2025-05-04 12:06:23,685 E 32292 25604] (raylet.exe) agent_manager.cc:87: The raylet exited immediately because one Ray agent failed, agent_name = dashboard_agent.\nThe raylet fate shares with the agent. This can happen because\n- The version of `grpcio` doesn't follow Ray's requirement. Agent can segfault with the incorrect `grpcio` version. Check the grpcio version `pip freeze | grep grpcio`.\n- The agent failed to start because of unexpected error or port conflict. Read the log `cat /tmp/ray/session_latest/logs/{dashboard_agent|runtime_env_agent}.log`. You can find the log file structure here URL \n- The agent is killed by the OS (e.g., out of memory).\n[2025-05-04 12:06:23,686 I 32292 35296] (raylet.exe) main.cc:307: Raylet graceful shutdown triggered, reason = UNEXPECTED_TERMINATION, reason message = dashboard_agent failed and raylet fate-shares with it.\n[2025-05-04 12:06:23,686 I 32292 35296] (raylet.exe) main.cc:310: Shutting down...\n[2025-05-04 12:06:23,686 I 32292 35296] (raylet.exe) accessor.cc:515: Unregistering node node_id=2547f168cb62f79248f1ebdb4d408b1f1ac93d33f1d41244737eb966\n[2025-05-04 12:06:23,689 I 32292 35296] (raylet.exe) accessor.cc:528: Finished unregistering node info, status = OK node_id=2547f168cb62f79248f1ebdb4d408b1f1ac93d33f1d41244737eb966\n[2025-05-04 12:06:23,689 W 32292 19800] (raylet.exe) store.cc:368: Disconnecting client due to connection error with code 2: End of file\n[2025-05-04 12:06:23,695 I 32292 35296] (raylet.exe) agent_manager.cc:116: Killing agent dashboard_agent, pid 8496.\n[2025-05-04 12:06:23,695 I 32292 35296] (raylet.exe) agent_manager.cc:116: Killing agent runtime_env_agent, pid 6348.\n[2025-05-04 12:06:23,696 I 32292 9940] (raylet.exe) agent_manager.cc:83: Agent process with name runtime_env_agent exited, exit code 1067.\n[2025-05-04 12:06:23,697 I 32292 35296] (raylet.exe) io_service_pool.cc:48: IOServicePool is stopped.\n\u001b[0m\u001b[0m[2025-05-04 12:06:23,915 I 32292 35296] (raylet.exe) stats.h:120: Stats module has shutdown.\n\nUpdating of grpcio version to 1.72 doesn't help. \nCurrent environment works fine with ray 2.44.1. \n\n**Versions / Dependencies**\nray == 2.45\nWindows == 26100.3915\n\n**Issue Severity**\nHigh: It blocks me from completing my task.\n\nLet me know if any additional information will be helpful.","author_login":"kolcker","author_association":"NONE","created_at":"2025-05-04T09:14:48+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2880885782","fragment_type":"issue_comment","sequence":2,"text":"@kolcker: Thanks for your contribution to the error defintion. Changed the title of the GH issue accordingly.","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-05-14T16:41:24+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2894344594","fragment_type":"issue_comment","sequence":3,"text":"@masoudcharkhabi should this not include the \"bug\" label as well? It prevents Ray from starting altogether on Windows.\n\nThe issue is with redirecting stderr to a file - I'm guess this is closed somewhere. Possibly in PR 51731 - @dentiny ?","author_login":"DanZee","author_association":"NONE","created_at":"2025-05-20T13:07:40+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2922744942","fragment_type":"issue_comment","sequence":4,"text":"*push* - I would consider this topic as a release blocker for windows users. At least, it would be great to get to know a workaround, if applicable.","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-05-30T15:45:51+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2926590691","fragment_type":"issue_comment","sequence":5,"text":"CI runs on windows succeed, so there is something different in your local machine setup. Could you modify `C:\\Users\\Philipp\\anaconda3\\envs\\py311-raynew\\Lib\\site-packages\\ray_private\\logging_utils.py` to try, except an error around the line `sys.stderr = ...` and print the values of `stderr_fileno`, `stderr_filepath`, `rotation_bytes`, `rotation_backup_count`?","author_login":"mattip","author_association":"CONTRIBUTOR","created_at":"2025-06-01T05:49:00+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2927200110","fragment_type":"issue_comment","sequence":6,"text":"hi @mattip ,\n\nI added strategic logging and got the following insights.\n\n- stdout file number is 1, stderror file number is 2.\n- Rotation bytes are always 0, backup count are always 1.\n- After complete hard `ray stop` and no ray process running at all, the log rotation init works for stdout, but not for stderr.\n- dashboard.out is opened as fully empty file (0 bytes). dashboard.err gets 1 initial byte which is shown in Windows Cmd as \"\u001b[0m\".\n\nSee console log.","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-06-01T13:03:09+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2927630552","fragment_type":"issue_comment","sequence":7,"text":"For your information, in ray version 2.44.1, the same spot looks like this:","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-06-01T18:03:25+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2931132854","fragment_type":"issue_comment","sequence":8,"text":"It looks like, I localized error even without ray.init. \n\nfrom ray._private.utils import open_log\nfrom ray._raylet import StreamRedirector\nimport sys, logging\n\n# Setup redirection for stdout and stderr.\nstdout_filepath = 'e:/projects/ray_test/stdout.log'\nstderr_filepath = 'e:/projects/ray_test/stderr.log'\n\nprint(sys.stdout)\nprint(sys.platform)\n\nif stdout_filepath:\n StreamRedirector.redirect_stdout(\n stdout_filepath,\n 0, #args.logging_rotate_bytes if sys.platform != \"win32\" else 0,\n 1, # args.logging_rotate_backup_count if sys.platform != \"win32\" else 1\n False, # tee_to_stdout\n False, # tee_to_stderr\n )\n\nstdout_fileno = sys.stdout.fileno()\nprint(\"stdout_fileno\", stdout_fileno, file=sys.stderr)\nprint(\"print to stdout\")\nsys.stdout = open_log(stdout_fileno, unbuffered=True, closefd=False)\n\nBased on my investigations problem inside `StreamRedirector.redirect_stdout, StreamRedirector.redirect_stderr`. As soon as these methods called we are receiving bad descriptor for writing to log files. \n\nHere is an output: \n\nE:\\projects\\ray_test\\.venv12\\Scripts\\python.exe E:\\projects\\ray_test\\test.py \nstdout_fileno 1\nTraceback (most recent call last):\n File \"E:\\projects\\ray_test\\test.py\", line 25, in \n print(\"print to stdout\")\nOSError: [Errno 9] Bad file descriptor\n ' mode='w' encoding='utf-8'>\nwin32\n\nProcess finished with exit code -1073740791 (0xC0000409)\n\nMost likely regression issue appeared somewhere around URL \n\nPlease let me know if any information from debugger will be helpful.\n\n@mattip please take a look.","author_login":"kolcker","author_association":"NONE","created_at":"2025-06-02T14:56:25+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2932075128","fragment_type":"issue_comment","sequence":9,"text":"Further finding: The issue does not occur on Windows 10 (Version 10.0.19045 Build 19045).\n\nHere, ray 2.45 shows following behavior for the StreamRedirection:","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-06-02T19:03:14+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2933315005","fragment_type":"issue_comment","sequence":10,"text":"## New Contributor - Same Windows Issue Confirmed\n\nHi, I'm new to Ray development and encountered the same Windows issue while following the official development setup guide.\n\n### My Experience:\n- **Background:** First-time Ray contributor trying to set up development environment\n- **Following:** URL \n- **OS:** Windows 11 with conda environment\n\n### Issues Encountered:\n- **Ray 3.0.0.dev0 (nightly):** Failed with import errors and version compatibility issues\n- **Ray 2.45+:** Similar initialization problems as reported in this issue\n\n### Working Solution:\nAfter reading this thread, I downgraded to Ray 2.44.0, and everything worked as expected — no import errors, and ray.init() runs successfully.\nJust sharing my experience in case it helps other Windows users or maintainers trying to reproduce the issue.\n\nbash\npip install \"ray[default]==2.44.0\"\ngit checkout ray-2.44.0 \npython python/ray/setup-dev.py -y","author_login":"AndySung320","author_association":"NONE","created_at":"2025-06-03T03:51:46+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2945133769","fragment_type":"issue_comment","sequence":11,"text":"I am able to reproduce this error,\n\npowershell\n(ray-dev) PS C:\\Users\\czgdp1807\\Anyscale\\ray\\python> ray start --head\nEnable usage stats collection? This prompt will auto-proceed in 10 seconds to avoid blocking cluster startup. Confirm [Y/n]:\nUsage stats collection is enabled. To disable this, add `--disable-usage-stats` to the command that starts the cluster, or run the following command: `ray disable-usage-stats` before starting the cluster. See URL for more details.\n\nLocal node IP: 127.0.0.1\n2025-06-05 16:10:27,199 ERROR services.py:1355 -- Failed to start the dashboard , return code 3221226505\n2025-06-05 16:10:27,201 ERROR services.py:1380 -- Error should be written to 'dashboard.log' or 'dashboard.err'. We are printing the last 20 lines for you. See ' URL to find where the log file is.\n2025-06-05 16:10:27,219 ERROR services.py:1424 --\nThe last 20 lines of C:\\Users\\CZGDP1~1\\AppData\\Local\\Temp\\ray\\session_2025-06-05_16-10-17_593443_6000\\logs\\dashboard.log (it contains the error message from the dashboard):\nTraceback (most recent call last):\n File \"c:\\users\\czgdp1807\\anyscale\\ray\\python\\ray\\dashboard\\dashboard.py\", line 246, in \n logging_utils.redirect_stdout_stderr_if_needed(\n File \"c:\\users\\czgdp1807\\anyscale\\ray\\python\\ray\\_private\\logging_utils.py\", line 49, in redirect_stdout_stderr_if_needed\n sys.stderr = open_log(stderr_fileno, unbuffered=True, closefd=False)\n File \"c:\\users\\czgdp1807\\anyscale\\ray\\python\\ray\\_private\\utils.py\", line 444, in open_log\n stream = open(path, **kwargs)\nOSError: [WinError 6] The handle is invalid\n\n--------------------\nRay runtime started.\n--------------------\n\nNext steps\n\n To connect to this Ray cluster:\n import ray\n ray.init()\n\n To terminate the Ray runtime, run\n ray stop\n\n To view the status of the cluster, use\n ray status\n\nLet me see what's going on.","author_login":"czgdp1807","author_association":"CONTRIBUTOR","created_at":"2025-06-05T16:13:53+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2960513004","fragment_type":"issue_comment","sequence":12,"text":"We are actively working on this together with @mattip. Will give an update in a day or two. In the meantime, are you able to use WSL?","author_login":"jjyao","author_association":"COLLABORATOR","created_at":"2025-06-10T20:33:03+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2973656402","fragment_type":"issue_comment","sequence":13,"text":"@kolcker : For me it is now working with ray release 2.47. Kindly try again with latest version published on Friday.\n\nI am interested in what was now the root cause and the fix, though.","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-06-15T10:58:21+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2974063461","fragment_type":"issue_comment","sequence":14,"text":"@PhilippWillms thank you for information. \n\nI still have the same issue after the clean installation of ray 2.47. \nInstallation `pip install -U \"ray[train,tune]\"` to the new Virtualenv\n\nScript to reproduce\n\nimport ray\nray.init(include_dashboard=False)\n\nthe same error\n\nE:\\projects\\ray_test\\.venv15\\Scripts\\python.exe E:\\projects\\ray_test\\test3.py \n2025-06-15 18:07:39,219 ERROR services.py:1355 -- Failed to start the dashboard , return code 3221226505\n2025-06-15 18:07:39,219 ERROR services.py:1380 -- Error should be written to 'dashboard.log' or 'dashboard.err'. We are printing the last 20 lines for you. See ' URL to find where the log file is.\n2025-06-15 18:07:39,224 ERROR services.py:1424 -- \nThe last 20 lines of C:\\WINDOWS\\TEMP\\ray\\session_2025-06-15_18-07-34_072267_35384\\logs\\dashboard.log (it contains the error message from the dashboard): \nTraceback (most recent call last):\n File \"E:\\projects\\ray_test\\.venv15\\Lib\\site-packages\\ray\\dashboard\\dashboard.py\", line 246, in \n logging_utils.redirect_stdout_stderr_if_needed(\n File \"E:\\projects\\ray_test\\.venv15\\Lib\\site-packages\\ray\\_private\\logging_utils.py\", line 49, in redirect_stdout_stderr_if_needed\n sys.stderr = open_log(stderr_fileno, unbuffered=True, closefd=False)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"E:\\projects\\ray_test\\.venv15\\Lib\\site-packages\\ray\\_private\\utils.py\", line 444, in open_log\n stream = open(path, **kwargs)\n ^^^^^^^^^^^^^^^^^^^^\nOSError: [WinError 6] The handle is invalid\n\n2025-06-15 18:07:39,414 INFO worker.py:1917 -- Started a local Ray instance.\n[2025-06-15 18:07:42,064 E 35384 36528] core_worker.cc:513: Failed to register worker to Raylet: IOError: [RayletClient] Unable to register worker with raylet. Unknown error worker_id=01000000ffffffffffffffffffffffffffffffffffffffffffffffff\n\nrequirements.txt \n\nannotated-types==0.7.0\nattrs==25.3.0\ncertifi==2025.6.15\ncharset-normalizer==3.4.2\nclick==8.2.1\ncolorama==0.4.6\nfilelock==3.18.0\nfsspec==2025.5.1\nidna==3.10\njsonschema==4.24.0\njsonschema-specifications==2025.4.1\nmsgpack==1.1.1\nnumpy==2.3.0\npackaging==25.0\npandas==2.3.0\nprotobuf==6.31.1\npyarrow==20.0.0\npydantic==2.11.7\npydantic_core==2.33.2\npython-dateutil==2.9.0.post0\npytz==2025.2\nPyYAML==6.0.2\nray==2.47.0\nreferencing==0.36.2\nrequests==2.32.4\nrpds-py==0.25.1\nsix==1.17.0\ntensorboardX==2.6.4\ntyping-inspection==0.4.1\ntyping_extensions==4.14.0\ntzdata==2025.2\nurllib3==2.4.0\n\nRay team, please let us know if you have any updates regarding status of this issue.\n\nThanks in advance.","author_login":"kolcker","author_association":"NONE","created_at":"2025-06-15T15:20:20+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2977718855","fragment_type":"issue_comment","sequence":15,"text":"Good point. Checking the details, I see that now my Windows has build ID **26100.4351**. Updates which were installed last Friday, 2025-06-11, are KB5061935 and KB5063060.","author_login":"PhilippWillms","author_association":"NONE","created_at":"2025-06-16T18:51:24+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2980956749","fragment_type":"issue_comment","sequence":16,"text":"@kolcker Could you try the following wheel depending on your Python version and see if it works for you:\n\n URL \n\n URL \n\n URL \n\n URL","author_login":"jjyao","author_association":"COLLABORATOR","created_at":"2025-06-17T16:04:25+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3013697717","fragment_type":"issue_comment","sequence":17,"text":"I'm running Windows 11 Build 22631.5472 and Ray 2.47.1 and still get the issue: **_OSError: [WinError 6] The handle is invalid_**\nAny recommendation on what to do to resolve the issue. It was working ok on Windows 10 OS, but lately corporate made us upgrading to Windows 11.\nRight now, i'm stuck because of this. Any help would be greatly appreciated. Thanks","author_login":"Nick346-surf","author_association":"NONE","created_at":"2025-06-27T16:41:40+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3079326197","fragment_type":"issue_comment","sequence":18,"text":"Hi @kolcker 2.48 is cut and will be released within a few days.","author_login":"jjyao","author_association":"COLLABORATOR","created_at":"2025-07-16T16:14:38+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3092289253","fragment_type":"issue_comment","sequence":19,"text":"Pleasee help with this error, after installing version 2.48 on windows 11 i get this after training:\n`config = (\n SACConfig()\n .environment(\n TradingEnv, # NOT TradingEnv() or a wrapped function unless using register_env\n env_config={\n \"train\": train,\n \"close\": close,\n \"close2\": close2,\n \"highs\": highs,\n \"lows\": lows,\n \"starting_index\": 0,\n }\n )\n # .callbacks(EpisodeReturn)\n .training(\n gamma=0.9,\n actor_lr=0.001,\n critic_lr=0.002,\n train_batch_size_per_learner=32,\n )\n .env_runners(\n rollout_fragment_length=1000, # Collect more steps\n # num_env_runners=1,\n )\n)\nconfig = config.framework(\"torch\")\nfor i in range(10):\n algo.train()\nenv = TradingEnv({\n \"train\": train,\n \"close\": close,\n \"close2\": close2,\n \"highs\": highs,\n \"lows\": lows,\n \"starting_index\": 10,\n })\npolicy = algo.get_policy()\ntotal_reward = 0\ndone = False \nstate, _ = env.reset()\nwhile not done:\n state, reward, done, _ = loaded_policy.compute_single_action(state)\n total_reward += reward`\n\nResults in \n\n`----> 9 policy = algo.get_policy()\n 10 total_reward = 0\n 11 done = False \n\nFile ~\\AppData\\Local\\Programs\\Python\\Python310\\lib\\site-packages\\ray\\rllib\\algorithms\\algorithm.py:2398, in Algorithm.get_policy(self, policy_id)\n 2391 @OldAPIStack\n 2392 def get_policy(self, policy_id: PolicyID = DEFAULT_POLICY_ID) -> Policy:\n 2393 \"\"\"Return policy for the specified id, or None.\n 2394 \n 2395 Args:\n 2396 policy_id: ID of the policy to return.\n 2397 \"\"\"\n-> 2398 return self.env_runner.get_policy(policy_id)\n\nAttributeError: 'SingleAgentEnvRunner' object has no attribute 'get_policy'\n`","author_login":"Hydraxx10","author_association":"NONE","created_at":"2025-07-19T11:17:42+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3097245476","fragment_type":"issue_comment","sequence":20,"text":"@Hydraxx10 could you file a separate issue for the latest error since it's different from the issue this ticket is about. cc @sven1977 i think it's rllib issue now.","author_login":"jjyao","author_association":"COLLABORATOR","created_at":"2025-07-21T15:27:58+08:00","repo_name":"ray-project/ray","issue_id":3036241069,"issue_number":52739,"issue_url":"https://github.com/ray-project/ray/issues/52739","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0422","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"July 2022 LWG issues?","query_context":"(Previous meta-issue: #2527)\n\nAt the July 2022 virtual plenary meeting, the resolutions of the following LWG issues were merged into the C++ Working Paper. \n\n# ❔ Not yet analyzed\n\n# ❌ Not applicable\n\nIf an issue requires no action from implementers, we mark it as N/A. Categories:\n* Pure wording clarifications with nothing to implement (these can be changes to non-normative text like examples and informative notes, or wording cleanups to normative text that don't impact observable behavior)\n * [x] LWG-3659 Consider `ATOMIC_FLAG_INIT` undeprecation\n * MSVC STL has never deprecated this macro, and it might be impossible to reflect such deprecation in a library implementation\n* Something that increases the restrictions placed on users, but implementers aren't expected to enforce those restrictions.\n* Fixes for obviously broken wording, where implementers would have done the right thing anyways\n * [x] LWG-3709 LWG-3703 was underly ambitious\n * [x] LWG-3713 Sorted with respect to comparator (only)\n\n# 😸 Already implemented\nSometimes we cite LWG issues in product code comments as we're implementing their proposed resolutions. When the resolutions are officially accepted, we should remove the citations (as the default assumption is that we're implementing what the Standard says). If something is especially subtle, we can convert the citation to mention the relevant Standard section.\n\nSometimes we should add test coverage - e.g. when the Standard begins requiring something that we were already doing, but weren't explicitly testing for.\n\n* Already implemented, comments need to be removed and messages need to cite the Standard\n * [x] LWG-3670 *Cpp17InputIterator*s don't have integer-class difference types\n * [x] LWG-3705 Hashability shouldn't depend on `basic_string`'s allocator\n* Implemented without comments\n * [x] LWG-3687`expected ` move constructor should move\n * [x] LWG-3703 Missing requirements for `expected requires is_void `\n * [x] LWG-3704 LWG-2059 added overloads that might be ill-formed for sets\n * [x] LWG-3708 `take_while_view::`_`sentinel`_'s conversion constructor should move\n\n# 🩹 Patches an unimplemented feature\nWe should record this LWG issue in the GitHub issue tracking the feature. That way, we'll remember to verify it, but it doesn't represent net new work.\n * [x] LWG-3692 `zip_view::`_`iterator`_'s `operator ` is overconstrained\n * [x] LWG-3702 Should `zip_transform_view::`_`iterator`_ remove `operator ::value_type` and `iterator_category` should use `const F&`\n * [x] LWG-3617 `function`/`packaged_task` deduction guides and deducing `this`\n * Note that WG21-P1169 (static `operator()`) also changes these deduction guides.\n * [x] LWG-3701 Make `formatter , charT>` requirement explicit\n * PR out for review\n * [ ] LWG-3656 Inconsistent bit operations returning a count (implemented in #2880 )\n * [ ] LWG-3671 `atomic_fetch_xor` missing from `stdatomic.h` (implemented in #2905 )\n * [ ] LWG-3672 `common_iterator::operator->()` should return by value (implemented in #2907 )\n * [ ] LWG-3683 `operator==` for `polymorphic_allocator` cannot deduce template argument in common cases (implemented in #2879 )\n * [ ] LWG-3707 `chunk_view::`_`outer-iterator`_`::value_type::size` should return unsigned type (implemented in #2883 )\n * [ ] LWG-3710 The `end` of `chunk_view` for input ranges can be `const` (implemented in #2878 )\n * [ ] LWG-3711 Missing preconditions for `slide_view` constructor (implemented in #2946)\n * [ ] LWG-3712 `chunk_view` and `slide_view` should not be `default_initializable` (implemented in #2943 )\n * [ ] LWG-3715 `view_interface::empty` is overconstrained (implemented in #2946 )\n * [ ] LWG-3719 Directory iterators should be usable with default sentinel (implemented in #2902 )\n * [ ] LWG-3721 Allow an _arg-id_ with a value of zero for width in _std-format-spec_ (implemented in #2906 )\n * [ ] LWG-3724 _`decay-copy`_ should be constrained (implemented in #2903 )","known_context_document_ids":["gh_issue_1307419181"],"reference_answer":"I will add a note to the OP to make sure that `zip` implementation doesn't miss the changes from P2165R4. There's enough to P2165R4 that I think of it as more a standalone feature than simply a patch on `zip`, so I'll leave the separate feature issue.","answer_document_id":"gh_comment_1197686029","silver_evidence_path":["gh_comment_1196172596","gh_issue_1015818300","gh_comment_1197686029"],"evidence_issue_ids":[1307419181,1015818300],"source_repo_name":"microsoft/STL","source_issue_id":1307419181,"source_issue_number":2872,"source_issue_url":"https://github.com/microsoft/STL/issues/2872","target_repo_name":"microsoft/STL","target_issue_id":1015818300,"target_issue_number":2252,"target_issue_url":"https://github.com/microsoft/STL/issues/2252","reference_anchor_document_id":"gh_comment_1196172596","reference_answer_author":"CaseyCarter","reference_answer_author_association":"MEMBER","quality_score":87.56,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1875,"anchor_target_overlap":0.0938,"target_answer_overlap":0.2857},"issue_created_at":"2022-07-18T05:19:22+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1307419181","fragment_type":"issue_description","sequence":0,"text":"July 2022 LWG issues\n(Previous meta-issue: #2527)\n\nAt the July 2022 virtual plenary meeting, the resolutions of the following LWG issues were merged into the C++ Working Paper. \n\n# ❔ Not yet analyzed\n\n# ❌ Not applicable\n\nIf an issue requires no action from implementers, we mark it as N/A. Categories:\n* Pure wording clarifications with nothing to implement (these can be changes to non-normative text like examples and informative notes, or wording cleanups to normative text that don't impact observable behavior)\n * [x] LWG-3659 Consider `ATOMIC_FLAG_INIT` undeprecation\n * MSVC STL has never deprecated this macro, and it might be impossible to reflect such deprecation in a library implementation\n* Something that increases the restrictions placed on users, but implementers aren't expected to enforce those restrictions.\n* Fixes for obviously broken wording, where implementers would have done the right thing anyways\n * [x] LWG-3709 LWG-3703 was underly ambitious\n * [x] LWG-3713 Sorted with respect to comparator (only)\n\n# 😸 Already implemented\nSometimes we cite LWG issues in product code comments as we're implementing their proposed resolutions. When the resolutions are officially accepted, we should remove the citations (as the default assumption is that we're implementing what the Standard says). If something is especially subtle, we can convert the citation to mention the relevant Standard section.\n\nSometimes we should add test coverage - e.g. when the Standard begins requiring something that we were already doing, but weren't explicitly testing for.\n\n* Already implemented, comments need to be removed and messages need to cite the Standard\n * [x] LWG-3670 *Cpp17InputIterator*s don't have integer-class difference types\n * [x] LWG-3705 Hashability shouldn't depend on `basic_string`'s allocator\n* Implemented without comments\n * [x] LWG-3687`expected ` move constructor should move\n * [x] LWG-3703 Missing requirements for `expected requires is_void `\n * [x] LWG-3704 LWG-2059 added overloads that might be ill-formed for sets\n * [x] LWG-3708 `take_while_view::`_`sentinel`_'s conversion constructor should move\n\n# 🩹 Patches an unimplemented feature\nWe should record this LWG issue in the GitHub issue tracking the feature. That way, we'll remember to verify it, but it doesn't represent net new work.\n * [x] LWG-3692 `zip_view::`_`iterator`_'s `operator ` is overconstrained\n * [x] LWG-3702 Should `zip_transform_view::`_`iterator`_ remove `operator ::value_type` and `iterator_category` should use `const F&`\n * [x] LWG-3617 `function`/`packaged_task` deduction guides and deducing `this`\n * Note that WG21-P1169 (static `operator()`) also changes these deduction guides.\n * [x] LWG-3701 Make `formatter , charT>` requirement explicit\n * PR out for review\n * [ ] LWG-3656 Inconsistent bit operations returning a count (implemented in #2880 )\n * [ ] LWG-3671 `atomic_fetch_xor` missing from `stdatomic.h` (implemented in #2905 )\n * [ ] LWG-3672 `common_iterator::operator->()` should return by value (implemented in #2907 )\n * [ ] LWG-3683 `operator==` for `polymorphic_allocator` cannot deduce template argument in common cases (implemented in #2879 )\n * [ ] LWG-3707 `chunk_view::`_`outer-iterator`_`::value_type::size` should return unsigned type (implemented in #2883 )\n * [ ] LWG-3710 The `end` of `chunk_view` for input ranges can be `const` (implemented in #2878 )\n * [ ] LWG-3711 Missing preconditions for `slide_view` constructor (implemented in #2946)\n * [ ] LWG-3712 `chunk_view` and `slide_view` should not be `default_initializable` (implemented in #2943 )\n * [ ] LWG-3715 `view_interface::empty` is overconstrained (implemented in #2946 )\n * [ ] LWG-3719 Directory iterators should be usable with default sentinel (implemented in #2902 )\n * [ ] LWG-3721 Allow an _arg-id_ with a value of zero for width in _std-format-spec_ (implemented in #2906 )\n * [ ] LWG-3724 _`decay-copy`_ should be constrained (implemented in #2903 )","author_login":"frederick-vs-ja","author_association":"CONTRIBUTOR","created_at":"2022-07-18T05:19:22+08:00","repo_name":"microsoft/STL","issue_id":1307419181,"issue_number":2872,"issue_url":"https://github.com/microsoft/STL/issues/2872","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1186779973","fragment_type":"issue_comment","sequence":1,"text":"@StephanTLavavej @CaseyCarter feel free to edit this if my analyzation for any LWG issue is incorrect, or P/R for any issue hasn't been voted into the working paper.","author_login":"frederick-vs-ja","author_association":"CONTRIBUTOR","created_at":"2022-07-18T05:22:30+08:00","repo_name":"microsoft/STL","issue_id":1307419181,"issue_number":2872,"issue_url":"https://github.com/microsoft/STL/issues/2872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1189451080","fragment_type":"issue_comment","sequence":2,"text":"Wow, thanks @frederick-vs-ja! This is a ton of work. I'm going to tag this (and any relevant PRs) as \"blocked\" until we actually get approval for the proposed resolutions in the WG21 virtual plenary on 2022-07-25, but folks should feel free to go ahead and submit/review such PRs.","author_login":"CaseyCarter","author_association":"MEMBER","created_at":"2022-07-19T19:04:42+08:00","repo_name":"microsoft/STL","issue_id":1307419181,"issue_number":2872,"issue_url":"https://github.com/microsoft/STL/issues/2872","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1196172596","fragment_type":"issue_comment","sequence":3,"text":"I believe every issue has now been processed. We have PRs out for the majority, I've recorded the two that patch `zip` in #2252, filed issues for the three that don't yet have pull requests, and submitted a PR to cleanup comments for the two we implemented speculatively with comments.\n\nThanks to everyone, and again extra-special thanks to @frederick-vs-ja for filing this issue and a majority of the resolution PRs.","author_login":"CaseyCarter","author_association":"MEMBER","created_at":"2022-07-27T01:40:21+08:00","repo_name":"microsoft/STL","issue_id":1307419181,"issue_number":2872,"issue_url":"https://github.com/microsoft/STL/issues/2872","linked_issue_ids":[1015818300],"is_known_query_context":false},{"document_id":"gh_issue_1015818300","fragment_type":"issue_description","sequence":0,"text":"P2321R2 `zip`\nP2321R2 `zip`\n\nFeature-test macro:\n\ncpp\n#define __cpp_lib_ranges_zip 202110L\n\nBe sure to implement the resolutions of these LWG issues which patch this feature:\n\n* LWG-3692 `zip_view::`_`iterator`_'s `operator ` is overconstrained\n* LWG-3702 Should `zip_transform_view::`_`iterator`_ remove `operator<`?\n* LWG-3773 `views::zip_transform` still requires `F` to be `copy_constructible` when empty pack\n* LWG-3798 Rvalue reference and `iterator_category`\n + Affects `views::adjacent_transform`, see [\\[range.adjacent.transform.iterator\\]/1.1]( URL \n* LWG-3848 `adjacent_view`, `adjacent_transform_view`, and `slide_view` missing `base` accessor\n\nand the pertinent changes from P2165R4 and P2494R2.","author_login":"StephanTLavavej","author_association":"MEMBER","created_at":"2021-10-05T02:33:19+08:00","repo_name":"microsoft/STL","issue_id":1015818300,"issue_number":2252,"issue_url":"https://github.com/microsoft/STL/issues/2252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1112400062","fragment_type":"issue_comment","sequence":1,"text":"Not that I would want to make promises, that I will create a MR any time soon. But I at least implemented some of the minor changes as well as zip_view in URL \nI could use some help with:\n- 5.1 & 5.2: Constructors and assignment operators for `std::tuple` and `std::pair`\n- 5.4: Not sure which changes this requires\n- 5.6: Is implemented as described in the paper. But are there functions whose noexceptness should be strengthened?","author_login":"Ukilele","author_association":"CONTRIBUTOR","created_at":"2022-04-28T16:15:38+08:00","repo_name":"microsoft/STL","issue_id":1015818300,"issue_number":2252,"issue_url":"https://github.com/microsoft/STL/issues/2252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133109102","fragment_type":"issue_comment","sequence":2,"text":"Hey @miscco , I assume this question is addressed to me? If so, thanks for asking! Unfortunately, currently I wont find the time to work on this. The missing parts in my branch are noexcept-strengthening, unit tests as well as `adjacent` and `adjacent_transform`.","author_login":"Ukilele","author_association":"CONTRIBUTOR","created_at":"2022-05-20T16:40:44+08:00","repo_name":"microsoft/STL","issue_id":1015818300,"issue_number":2252,"issue_url":"https://github.com/microsoft/STL/issues/2252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1133168772","fragment_type":"issue_comment","sequence":3,"text":"Note that you do not need to implement everything in a go.\n\nCould you do a squash and rebase on main? I would be happy to give it another round of review and Tam implemented most prerequisites","author_login":"miscco","author_association":"CONTRIBUTOR","created_at":"2022-05-20T17:53:53+08:00","repo_name":"microsoft/STL","issue_id":1015818300,"issue_number":2252,"issue_url":"https://github.com/microsoft/STL/issues/2252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1196675572","fragment_type":"issue_comment","sequence":4,"text":"P2165R4 also changes `zip_view` etc. (making them no longer use `pair`) and `basic_common_reference` and `common_type` partial specializations.","author_login":"frederick-vs-ja","author_association":"CONTRIBUTOR","created_at":"2022-07-27T12:39:56+08:00","repo_name":"microsoft/STL","issue_id":1015818300,"issue_number":2252,"issue_url":"https://github.com/microsoft/STL/issues/2252","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1197686029","fragment_type":"issue_comment","sequence":5,"text":"I will add a note to the OP to make sure that `zip` implementation doesn't miss the changes from P2165R4. There's enough to P2165R4 that I think of it as more a standalone feature than simply a patch on `zip`, so I'll leave the separate feature issue.","author_login":"CaseyCarter","author_association":"MEMBER","created_at":"2022-07-28T05:36:45+08:00","repo_name":"microsoft/STL","issue_id":1015818300,"issue_number":2252,"issue_url":"https://github.com/microsoft/STL/issues/2252","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0423","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Getting an ERR_UNSUPPORTED_ESM_URL_SCHEME error?","query_context":"### Describe the bug\n\nI'm currently following the guide and at chapter 1 where I am now trying to run: \n\n`npm run start` but getting the following error:\n\nError: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'f:'\n\nI'm currently using `node 20.10.0`\n\nHere's my `server.ts`\n\nimport { MikroORM } from \"@mikro-orm/mysql\";\nimport express from \"express\";\nconst app = express();\nconst port = 3000;\n\n// initialize the ORM, loading the config file dynamically\nconst orm = await MikroORM.init();\nconsole.log(orm.em); // access EntityManager via `em` property\nconsole.log(orm.schema); // access SchemaGeneartor via `schema` property\n\napp.get(\"/\", (req, res) => {\n res.send(\"Hello World!\");\n});\n\napp.listen(port, () => {\n return console.log(`Express is listening at URL \n});\n\nand my `package.json`\n\n{\n \"name\": \"server\",\n \"version\": \"1.0.0\",\n \"description\": \"\",\n \"scripts\": {\n \"build\": \"tsc && npx mikro-orm-esm cache:generate --combined\",\n \"start\": \"node --no-warnings=ExperimentalWarning --loader ts-node/esm src/server.ts\",\n \"test\": \"vitest\"\n },\n \"keywords\": [],\n \"author\": \"\",\n \"license\": \"ISC\",\n \"type\": \"module\",\n \"dependencies\": {\n \"@mikro-orm/core\": \"^6.4.15\",\n \"@mikro-orm/mysql\": \"^6.4.15\",\n \"express\": \"^5.1.0\",\n \"un\": \"^0.0.0\",\n \"zod\": \"^3.25.20\"\n },\n \"devDependencies\": {\n \"@eslint/js\": \"^9.27.0\",\n \"@mikro-orm/cli\": \"^6.4.15\",\n \"@mikro-orm/reflection\": \"^6.4.15\",\n \"@types/express\": \"^5.0.2\",\n \"@types/node\": \"^22.15.19\",\n \"eslint\": \"^9.27.0\",\n \"globals\": \"^16.1.0\",\n \"ts-node\": \"^10.9.2\",\n \"typescript\": \"^5.8.3\",\n \"typescript-eslint\": \"^8.32.1\",\n \"vitest\": \"^3.1.4\"\n }\n}\n\n### Reproduction\n\nFollow the guide and after setting up a basic entity, run `npm run start` \n\n### What driver are you using?\n\nMySQL (mikro-oorm/mysql 6.4.15)\n\n### MikroORM version\n\n6.4.15\n\n### Node.js version\n\n20.10.0\n\n### Operating system\n\nWindows 11\n\n### Validations\n\n- [x] Read the Contributing Guidelines.\n- [x] Read the docs.\n- [x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.\n- [x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord.\n- [x] The provided reproduction is a minimal reproducible example of the bug.","known_context_document_ids":["gh_issue_3081998122"],"reference_answer":"Absolute paths (either unix or windows style) aren't valid URLs, though.\n\nsh-session\n$ node -p 'new URL(\"/Users/user/file.js\").href'\ninternal/url.js:243\n throw new ERR_INVALID_URL(input);\n ^\n\nTypeError [ERR_INVALID_URL]: Invalid URL: /Users/user/file.js\n\n(same behavior in Chrome)\n\nI 100% agree with passing the path through `url.pathToFileURL` first (that's the fixed I've applied in Jest), but I think it should be required on _all_ platforms, not just Windows.","answer_document_id":"gh_comment_587364286","silver_evidence_path":["gh_comment_2900456007","gh_issue_562234617","gh_comment_587364286"],"evidence_issue_ids":[3081998122,562234617],"source_repo_name":"mikro-orm/mikro-orm","source_issue_id":3081998122,"source_issue_number":6670,"source_issue_url":"https://github.com/mikro-orm/mikro-orm/issues/6670","target_repo_name":"nodejs/node","target_issue_id":562234617,"target_issue_number":31710,"target_issue_url":"https://github.com/nodejs/node/issues/31710","reference_anchor_document_id":"gh_comment_2900456007","reference_answer_author":"SimenB","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3704,"anchor_target_overlap":0.3148,"target_answer_overlap":0.2381},"issue_created_at":"2025-05-22T04:26:45+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_3081998122","fragment_type":"issue_description","sequence":0,"text":"Getting an ERR_UNSUPPORTED_ESM_URL_SCHEME error\n### Describe the bug\n\nI'm currently following the guide and at chapter 1 where I am now trying to run: \n\n`npm run start` but getting the following error:\n\nError: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'f:'\n\nI'm currently using `node 20.10.0`\n\nHere's my `server.ts`\n\nimport { MikroORM } from \"@mikro-orm/mysql\";\nimport express from \"express\";\nconst app = express();\nconst port = 3000;\n\n// initialize the ORM, loading the config file dynamically\nconst orm = await MikroORM.init();\nconsole.log(orm.em); // access EntityManager via `em` property\nconsole.log(orm.schema); // access SchemaGeneartor via `schema` property\n\napp.get(\"/\", (req, res) => {\n res.send(\"Hello World!\");\n});\n\napp.listen(port, () => {\n return console.log(`Express is listening at URL \n});\n\nand my `package.json`\n\n{\n \"name\": \"server\",\n \"version\": \"1.0.0\",\n \"description\": \"\",\n \"scripts\": {\n \"build\": \"tsc && npx mikro-orm-esm cache:generate --combined\",\n \"start\": \"node --no-warnings=ExperimentalWarning --loader ts-node/esm src/server.ts\",\n \"test\": \"vitest\"\n },\n \"keywords\": [],\n \"author\": \"\",\n \"license\": \"ISC\",\n \"type\": \"module\",\n \"dependencies\": {\n \"@mikro-orm/core\": \"^6.4.15\",\n \"@mikro-orm/mysql\": \"^6.4.15\",\n \"express\": \"^5.1.0\",\n \"un\": \"^0.0.0\",\n \"zod\": \"^3.25.20\"\n },\n \"devDependencies\": {\n \"@eslint/js\": \"^9.27.0\",\n \"@mikro-orm/cli\": \"^6.4.15\",\n \"@mikro-orm/reflection\": \"^6.4.15\",\n \"@types/express\": \"^5.0.2\",\n \"@types/node\": \"^22.15.19\",\n \"eslint\": \"^9.27.0\",\n \"globals\": \"^16.1.0\",\n \"ts-node\": \"^10.9.2\",\n \"typescript\": \"^5.8.3\",\n \"typescript-eslint\": \"^8.32.1\",\n \"vitest\": \"^3.1.4\"\n }\n}\n\n### Reproduction\n\nFollow the guide and after setting up a basic entity, run `npm run start` \n\n### What driver are you using?\n\nMySQL (mikro-oorm/mysql 6.4.15)\n\n### MikroORM version\n\n6.4.15\n\n### Node.js version\n\n20.10.0\n\n### Operating system\n\nWindows 11\n\n### Validations\n\n- [x] Read the Contributing Guidelines.\n- [x] Read the docs.\n- [x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.\n- [x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord.\n- [x] The provided reproduction is a minimal reproducible example of the bug.","author_login":"the-black-viper","author_association":"NONE","created_at":"2025-05-22T04:26:45+08:00","repo_name":"mikro-orm/mikro-orm","issue_id":3081998122,"issue_number":6670,"issue_url":"https://github.com/mikro-orm/mikro-orm/issues/6670","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2900456007","fragment_type":"issue_comment","sequence":1,"text":"We encountered the same issue on Windows. It's a problem that occurs when using dynamic imports with absolute paths. On Windows, the drive letter in the path (e.g., `f:`) is interpreted as a protocol, since `import()` accepts URLs. As a result, it requires the `file:` protocol, which can be properly constructed using `pathToFileURL`.\n\n@the-black-viper You can resolve this by adding a `dynamicImportProvider` to the init config:\n\ntypescript\nimport { MikroORM } from '@mikro-orm/mysql';\nimport { pathToFileURL } from 'node:url';\n\nconst orm = await MikroORM.init({\n dynamicImportProvider: (path) => import(pathToFileURL(path).href),\n});\n\n@B4nan This can be fixed by updating the defaults here:\n\n URL \n\n URL \n\nBoth should use pathToFileURL as shown above.\n\nFor reference, here's the related Node.js issue: URL","author_login":"Ruby184","author_association":"CONTRIBUTOR","created_at":"2025-05-22T09:04:49+08:00","repo_name":"mikro-orm/mikro-orm","issue_id":3081998122,"issue_number":6670,"issue_url":"https://github.com/mikro-orm/mikro-orm/issues/6670","linked_issue_ids":[562234617],"is_known_query_context":false},{"document_id":"gh_comment_2900461525","fragment_type":"issue_comment","sequence":2,"text":"Thanks, I was expecting something like that. Could you send a PR please? I would rather not try to fix this in the blind.","author_login":"B4nan","author_association":"MEMBER","created_at":"2025-05-22T09:06:43+08:00","repo_name":"mikro-orm/mikro-orm","issue_id":3081998122,"issue_number":6670,"issue_url":"https://github.com/mikro-orm/mikro-orm/issues/6670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2903001637","fragment_type":"issue_comment","sequence":3,"text":"@Ruby184 Adding `dynamicImportProvider` to the config along with explicitly initializing the config as follows fixed the issue:\n\n// mikro-orm.config.ts\nconst config: Options = {\n ...\n debug: true,\n dynamicImportProvider: (path) => import(pathToFileURL(path).href),\n};\n\n// server.ts\n\nconst orm = await MikroORM.init(config);","author_login":"the-black-viper","author_association":"NONE","created_at":"2025-05-23T01:23:08+08:00","repo_name":"mikro-orm/mikro-orm","issue_id":3081998122,"issue_number":6670,"issue_url":"https://github.com/mikro-orm/mikro-orm/issues/6670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_562234617","fragment_type":"issue_description","sequence":0,"text":"ES Module loading with abolute path fails on windows\n* **Version**: v13.8.0\n* **Platform**: Windows 10 64-bit version 1809\n* **Subsystem**: \"esm\" maybe?\n\n### What steps will reproduce the bug?\n\n1. Create a new project in `C:\\prog\\node\\genast`\n2. Add \"type\": \"module\" in package.json\n3. Make a \"other.js\" with some content, like\n\nconst thing = \"hej\"\nexport default thing\n\n4. Make \"index.js\" with the following:\n\nimport other from \"./other.js\"\nconsole.log(other)\n\n5. \n\n \nhej\n\n(as expected!)\n\n6. Change index.js to:\n\nimport other from \"C:\\\\prog\\\\node\\\\genast\\\\other.js\"\nconsole.log(other)\n\nIt errors out with:\ninternal/modules/run_main.js:54\n internalBinding('errors').triggerUncaughtException(\n ^\n\nError [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader\n at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:33:11)\n at Loader.resolve (internal/modules/esm/loader.js:85:40)\n at Loader.getModuleJob (internal/modules/esm/loader.js:188:40)\n at ModuleWrap. (internal/modules/esm/module_job.js:42:40)\n at link (internal/modules/esm/module_job.js:41:36) {\n code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME'\n}\n\nUsing forward- och backward slashes doesn't make a difference.\n\n### How often does it reproduce? Is there a required condition?\n\n100%\n\n### What is the expected behavior?\n\nAbsolute includes should work the same as relative\n\n### What do you see instead?\n\n \n\n### Additional information\n\nThe same issue is seen with both static ES imports and dynamic ES imports.","author_login":"lulzmachine","author_association":"NONE","created_at":"2020-02-09T20:32:06+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_583890501","fragment_type":"issue_comment","sequence":1,"text":"Sorry about the sources being one-linered. I can't figure out how to convince the markdown here how to allow multiline code blocks.","author_login":"lulzmachine","author_association":"NONE","created_at":"2020-02-09T20:38:47+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_583916239","fragment_type":"issue_comment","sequence":2,"text":"You'd need to write `file:///c:/x/y/z` instead of `c:/x/y/z`","author_login":"devsnek","author_association":"MEMBER","created_at":"2020-02-10T00:49:22+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584482385","fragment_type":"issue_comment","sequence":3,"text":"**As per node.js documentation:**\n\nThe specifier of an import statement is the string after the from keyword, e.g. 'path' in import { sep } from 'path'. Specifiers are also used in export from statements, and as the argument to an import() expression.\n\nThere are four types of specifiers:\n\n- Bare specifiers like 'some-package'. They refer to an entry point of a package by the package name.\n\n- Deep import specifiers like 'some-package/lib/shuffle.mjs'. They refer to a path within a package prefixed by the package name.\n\n- Relative specifiers like './startup.js' or '../config.mjs'. They refer to a path relative to the location of the importing file.\n\n- Absolute specifiers like 'file:///opt/nodejs/config.js'. They refer directly and explicitly to a full path.\n\nBare specifiers, and the bare specifier portion of deep import specifiers, are strings; but everything else in a specifier is a URL.\n\nOnly file: and data: URLs are supported. A specifier like ' URL may be supported by browsers but it is not supported in Node.js.\n\nSpecifiers may not begin with / or //. These are reserved for potential future use. The root of the current volume may be referenced via file:///.","author_login":"kiranpwr1260","author_association":"NONE","created_at":"2020-02-11T05:23:05+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584539214","fragment_type":"issue_comment","sequence":4,"text":"@kiranpwr1260 thanks!\n\nIt works on mac os though. Maybe not the same way you posted, but it works according to expectation.\n\nOn macos, if you do this:\n\n1. type: module in package.json\n2. In index.js, put\n\nimport \"/Users/ /prog/node/genast/other.mjs\"\n\n3. In other.mjs, put `console.log('wep')`\n4. `node index.js`\nOutputs, as expected, `wep`\n\nI expected the same to be true on windows, hence the issue report :)","author_login":"lulzmachine","author_association":"NONE","created_at":"2020-02-11T09:15:36+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584576823","fragment_type":"issue_comment","sequence":5,"text":"Yeah, I think this is either a bug on macos & linux or windows.\n\nMac and Linux (alpine docker image, to be precise):\n\nsh-session\n$ echo 'export default \"hello!\";' > file.mjs\n$ node -e 'import(require.resolve(\"./file.mjs\")).then(console.log, console.error)'\n(node:28) ExperimentalWarning: The ESM module loader is experimental.\n[Module] { default: 'hello!' }\n\nWindows:\n\nsh-session\n$ echo 'export default \"hello!\";' > file.mjs\n$ node -e 'import(require.resolve(\"./file.mjs\")).then(console.log, console.error)'\n(node:3036) ExperimentalWarning: The ESM module loader is experimental.\nError [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader\n at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:33:11)\n at Loader.resolve (internal/modules/esm/loader.js:85:40)\n at Loader.getModuleJob (internal/modules/esm/loader.js:188:40)\n at Loader.import (internal/modules/esm/loader.js:163:28)\n at importModuleDynamically (internal/modules/cjs/loader.js:1094:27)\n at exports.importModuleDynamicallyCallback (internal/process/esm_loader.js:37:14)\n at Object. (C:\\Users\\IEUser\\script.js:1:16)\n at Module._compile (internal/modules/cjs/loader.js:1151:30)\n at Object.Module._extensions..js (internal/modules/cjs/loader.js:1171:10)\n at Module.load (internal/modules/cjs/loader.js:1000:32) {\n code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME'\n}\n\nWith `url.pathToFileURL` it works, so we can use that in Jest. I'd still consider this a bug in node, though","author_login":"SimenB","author_association":"MEMBER","created_at":"2020-02-11T10:49:48+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584683372","fragment_type":"issue_comment","sequence":6,"text":"the issue is that `C:/` is ambiguous with a URL. (like `HTTP:/`) and we use URLs in the loader.","author_login":"devsnek","author_association":"MEMBER","created_at":"2020-02-11T15:12:50+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584692346","fragment_type":"issue_comment","sequence":7,"text":"From a user perspective it's really weird that absolute paths work for some OSes, but not all. Would it make sense to throw on absolute paths without `file://` on mac and linux as well?","author_login":"SimenB","author_association":"MEMBER","created_at":"2020-02-11T15:30:16+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_584719733","fragment_type":"issue_comment","sequence":8,"text":"Yeah, I've changed to use that in Jest now, but it's still odd to me that it behaves differently across OSes, even though `pathToFileURL` fixes it. You have to actually test on windows to notice absolute paths doesn't work (in our case, we only tested windows on Node 12, while our test only runs on Node 13), then find about that API (followed by either fixing your own code, or reporting it to some library).\n\nMaybe the error message could include something about passing the file path provided through `pathToFileURL`? Should hopefully mean less googling for people hitting it","author_login":"SimenB","author_association":"MEMBER","created_at":"2020-02-11T16:24:12+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587211387","fragment_type":"issue_comment","sequence":9,"text":"This is because `C:/path/to/module.js` gets parsed as:\n\njs\nURL {\n scheme: \"c:\",\n host: null,\n path: \"/path/to/module.js\",\n}\n\nAnd **Node** doesn’t know how to deal with a URL with a scheme of `c:`.\n\nWhat you want is `file:///C:/path/to/module.js`:\n\njs\nURL {\n scheme: \"file:\",\n host: \"\",\n path: \"/C:/path/to/module.js\",\n}","author_login":"ExE-Boss","author_association":"NONE","created_at":"2020-02-18T00:15:56+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587345749","fragment_type":"issue_comment","sequence":10,"text":"Yeah, I understand _why_ it happens, I just disagree with the behavior that absolute paths are treated differently between platforms, and would prefer it to just accept either relative paths or absolute paths that has the `file` protocol to avoid the foot gun of code working fine on one platform and not the other.\n\nThat ship might have sailed though 🙂","author_login":"SimenB","author_association":"MEMBER","created_at":"2020-02-18T08:46:56+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587359250","fragment_type":"issue_comment","sequence":11,"text":"@SimenB it doesn't accept paths, it accept urls. like i said, the correct thing to do if you have a path is to use pathToFileURL.","author_login":"devsnek","author_association":"MEMBER","created_at":"2020-02-18T09:21:18+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587364286","fragment_type":"issue_comment","sequence":12,"text":"Absolute paths (either unix or windows style) aren't valid URLs, though.\n\nsh-session\n$ node -p 'new URL(\"/Users/user/file.js\").href'\ninternal/url.js:243\n throw new ERR_INVALID_URL(input);\n ^\n\nTypeError [ERR_INVALID_URL]: Invalid URL: /Users/user/file.js\n\n(same behavior in Chrome)\n\nI 100% agree with passing the path through `url.pathToFileURL` first (that's the fixed I've applied in Jest), but I think it should be required on _all_ platforms, not just Windows.","author_login":"SimenB","author_association":"MEMBER","created_at":"2020-02-18T09:32:17+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587434048","fragment_type":"issue_comment","sequence":13,"text":"So to summarize and clarify, ESM importing right now works like this:\n\n- relative paths:\n - works on mac/linux\n - works on windows\n- absolute paths:\n - works on mac/linux\n - **doesn't work on windows**\n- \"local file urls\"\n - works on mac/linux\n - works on windows\n\nFor my money, I would love to have absolute paths work on windows as well. It only makes sense that a function to include other files can actually handle paths. At least when running in a node.js environment.\n\nI understand the difficulties differentiating between a windows absolute path and an url, since the drive letter could be confused with a URL scheme. And single-letter schemes seem to be valid according to this RFC: URL . But I think it's safe to assume that introducing single-letter URL schemes in a world where windows exists is not likely to happen","author_login":"lulzmachine","author_association":"NONE","created_at":"2020-02-18T12:21:05+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587535445","fragment_type":"issue_comment","sequence":14,"text":"@SimenB they aren't valid *absolute* urls, but they are valid as relative urls ( URL which is why they're accepted in `import`.\n\nI'm not sure how we could detect the intent of someone when they typed it, since that's all that separates an absolute path from a relative path absolute url string.","author_login":"devsnek","author_association":"MEMBER","created_at":"2020-02-18T16:02:16+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_587553049","fragment_type":"issue_comment","sequence":15,"text":"Aha, gotcha! Didn't think about the case when it's a `path` with a separately provided `base`. Thanks for being patient with me 👍 \n\nsh-session\n$ node -p 'new URL(\"/Users/user/file.js\", \" URL \n URL \n\nSo what essentially happens is `import(specifier) => import(new URL(specifier, import.meta.url))` to resolve the absolute path? In that case I don't really have any ideas on how to best detect it 😅 I assume being stricter (i.e. only treating paths starting with `./` as relative and not `/`) is not an option? Would probably be bad for browser interop.\n\nI think this should be highlighted in the docs somewhere, although I'm not entirely sure _where_. `pathToFileURL` is only mentioned in one place in the current ESM docs, and that's in an example transform loader. Maybe in the section talking about relative specifiers to `import()`? The 2 relative examples use `./`, might be an idea to mention `/` will be treated as relative to the root of the FS, which breaks on Windows? While I now (finally) understand why it behaves the way it does, it feels like a footgun if you're migrating from `require` to `import`.","author_login":"SimenB","author_association":"MEMBER","created_at":"2020-02-18T16:36:38+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_598318530","fragment_type":"issue_comment","sequence":16,"text":"As discussed, this behaviour is by design. A docs PR to help clarify further would be very welcome.","author_login":"guybedford","author_association":"CONTRIBUTOR","created_at":"2020-03-12T17:35:06+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_766008043","fragment_type":"issue_comment","sequence":17,"text":"You can work with absolute paths in windows using simport for dynamic imports. \nIt also makes you feel like you using promisified `require` with `ESM` support.\n\njs\n// other.mjs\nexport const hello = 'world';\n\njs\n// index.mjs\nimport {createSimport} = require('simport');\nconst simport = createSimport(import.meta.url);\n\nconst {hello} = await simport('c:\\\\other.mjs');\nconsole.log(hello)\n// outputs\n'world';","author_login":"coderaiser","author_association":"CONTRIBUTOR","created_at":"2021-01-23T13:08:38+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_881876814","fragment_type":"issue_comment","sequence":18,"text":"Can you please provide the line number of the source code that causes the error, in the error message?","author_login":"jsutil37","author_association":"NONE","created_at":"2021-07-17T10:56:52+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097798710","fragment_type":"issue_comment","sequence":19,"text":"The PR stalled, so the docs did not get updated to actually explain what is happening.\nPlease re-open the issue and/or fix up and merge the PR!\n\nSpecifically, this PR was supposed to address how to dynamically import absolute paths in the docs.\n\nEven more specifically, this proposed change (rendered version here) is actually the solution (I tested it, and it works!):\n\njs\nimport { pathToFileURL } from 'url';\n\nconst fileUrl = pathToFileURL('C:\\\\path\\\\to\\\\file.js').href;\n\nawait import(fileUrl)","author_login":"Domiii","author_association":"NONE","created_at":"2022-04-13T09:30:15+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1815656288","fragment_type":"issue_comment","sequence":20,"text":"It would be nice to be able to load an absolute path... in this case I don't have a way to set the current working directory, and `file:///c:/...` or `file://c:/...` do not work. It ends up prepending the current path (which again I don't have control over) and attempting to load like `c:\\tmp\\file:\\c:\\` for `node file:///c:/tmp/shell/node_modules/...` I just happen to be in c:\\tmp when testing this, but that is not likely to be the path.","author_login":"d3x0r","author_association":"NONE","created_at":"2023-11-17T02:34:09+08:00","repo_name":"nodejs/node","issue_id":562234617,"issue_number":31710,"issue_url":"https://github.com/nodejs/node/issues/31710","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0424","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Drag-and-drop doesn't work under chromium (wayland)?","query_context":"### Regression?\n\nYes\n\n### System Info and Version\n\n System/Version info \n\nsh\nHyprland, built from branch main at commit 688fe5c14781c63a1db23d4d02bf239283068ff6 dirty (windowrules: add fullscreenstate field (7466)).\nDate: Sat Aug 24 03:42:14 2024\nTag: v0.42.0-62-g688fe5c1, commits: 5131\n\nflags: (if any)\n\nSystem Information:\nSystem name: Linux\nNode name: Arch\nRelease: 6.10.5-2-cachyos-lto\nVersion: #1 SMP PREEMPT_DYNAMIC Thu, 15 Aug 2024 08:14:57 +0000\n\nGPU information: \n64:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c7) (prog-if 00 [VGA controller])\n\nos-release: NAME=\"Arch Linux\"\nPRETTY_NAME=\"Arch Linux\"\nID=arch\nBUILD_ID=rolling\nANSI_COLOR=\"38;2;23;147;209\"\nHOME_URL=\" URL \nDOCUMENTATION_URL=\" URL \nSUPPORT_URL=\" URL \nBUG_REPORT_URL=\" URL \nPRIVACY_POLICY_URL=\" URL \nLOGO=archlinux-logo\n\nplugins:\n\n \n\n### Description\n\nI tried bisect and went back to aquamarine before drag-and-drop didn't work either, probably influenced by other factors.\n\n### How to reproduce\n\n1. with `chromium --ozone-platform=wayland` command startup chromium\n2. Click on a link tag and drag\n\n### Crash reports, logs, images, videos\n\n URL","known_context_document_ids":["gh_issue_2484564567"],"reference_answer":"hm, odd. it surely works for me. Anything else you can find to trigger this? Some config opt?","answer_document_id":"gh_comment_2170381330","silver_evidence_path":["gh_comment_2308629805","gh_issue_2354762310","gh_comment_2170381330"],"evidence_issue_ids":[2484564567,2354762310],"source_repo_name":"hyprwm/Hyprland","source_issue_id":2484564567,"source_issue_number":7496,"source_issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","target_repo_name":"hyprwm/Hyprland","target_issue_id":2354762310,"target_issue_number":6509,"target_issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","reference_anchor_document_id":"gh_comment_2308629805","reference_answer_author":"vaxerski","reference_answer_author_association":"MEMBER","quality_score":89.64,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0909,"anchor_target_overlap":0.0909,"target_answer_overlap":0.0},"issue_created_at":"2024-08-24T12:45:12+08:00","valid_comment_count":29,"fragments":[{"document_id":"gh_issue_2484564567","fragment_type":"issue_description","sequence":0,"text":"Drag-and-drop doesn't work under chromium (wayland)\n### Regression?\n\nYes\n\n### System Info and Version\n\n System/Version info \n\nsh\nHyprland, built from branch main at commit 688fe5c14781c63a1db23d4d02bf239283068ff6 dirty (windowrules: add fullscreenstate field (7466)).\nDate: Sat Aug 24 03:42:14 2024\nTag: v0.42.0-62-g688fe5c1, commits: 5131\n\nflags: (if any)\n\nSystem Information:\nSystem name: Linux\nNode name: Arch\nRelease: 6.10.5-2-cachyos-lto\nVersion: #1 SMP PREEMPT_DYNAMIC Thu, 15 Aug 2024 08:14:57 +0000\n\nGPU information: \n64:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c7) (prog-if 00 [VGA controller])\n\nos-release: NAME=\"Arch Linux\"\nPRETTY_NAME=\"Arch Linux\"\nID=arch\nBUILD_ID=rolling\nANSI_COLOR=\"38;2;23;147;209\"\nHOME_URL=\" URL \nDOCUMENTATION_URL=\" URL \nSUPPORT_URL=\" URL \nBUG_REPORT_URL=\" URL \nPRIVACY_POLICY_URL=\" URL \nLOGO=archlinux-logo\n\nplugins:\n\n \n\n### Description\n\nI tried bisect and went back to aquamarine before drag-and-drop didn't work either, probably influenced by other factors.\n\n### How to reproduce\n\n1. with `chromium --ozone-platform=wayland` command startup chromium\n2. Click on a link tag and drag\n\n### Crash reports, logs, images, videos\n\n URL","author_login":"hdm9527","author_association":"NONE","created_at":"2024-08-24T12:45:12+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2308436605","fragment_type":"issue_comment","sequence":1,"text":"I didn't describe it well, it's possible to drag a link into a new tab, followed by no response to left mouse click anywhere in chromium.","author_login":"hdm9527","author_association":"NONE","created_at":"2024-08-24T15:49:48+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308440128","fragment_type":"issue_comment","sequence":2,"text":"Happening for me as well on brave since yesterday. After dragging something on the page or even dragging toolbar elements like extensions, the browser gets stucked with a hand symbol in place of the cursor.\n\nSee this:\n- URL \n- URL \n \n \ndrag-and-drop loop when dealing with misbehaving/buggy or malicious\nWayland compositors.\n \nas described in the linked crbugs.","author_login":"nexsych","author_association":"NONE","created_at":"2024-08-24T16:02:55+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308441506","fragment_type":"issue_comment","sequence":3,"text":"Happening for me as well on brave. After dragging something on the page or even dragging toolbar elements like extensions, the browser gets stucked with a hand symbol in place of the cursor.\n\nSee this:\n- URL \n- URL \n \n \ndrag-and-drop loop when dealing with misbehaving/buggy or malicious\nWayland compositors.\n \nas described in the linked crbugs.","author_login":"nexsych","author_association":"NONE","created_at":"2024-08-24T16:07:26+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2308629805","fragment_type":"issue_comment","sequence":4,"text":"Similar issue: URL \n\nThis issue started appearing again on the newer versions (nightly/unstable) of the browsers.","author_login":"hiddenruins","author_association":"NONE","created_at":"2024-08-25T02:42:07+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[2354762310],"is_known_query_context":false},{"document_id":"gh_comment_2309089242","fragment_type":"issue_comment","sequence":5,"text":"I have this issue with Brave and Google Chrome, but no with Chromium.\n\nBrave: Version 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit)\nGoogle Chrome: Version 128.0.6613.84 (Official Build) (64-bit)\nChromium: Version 127.0.6533.99 (Official Build) Fedora Project (64-bit)\n\n System/Version info \n\nsh\nHyprland, built from branch at commit 918d8340afd652b011b937d29d5eea0be08467f5 (flake.lock: update).\nDate: Tue Jun 25 12:06:02 2024\nTag: v0.41.2, commits: 4886\n\nflags: (if any)\n\nSystem Information:\nSystem name: Linux\nNode name: fedora\nRelease: 6.10.6-100.fc39.x86_64\nVersion: #1 SMP PREEMPT_DYNAMIC Mon Aug 19 14:35:32 UTC 2024\n\nGPU information: \n00:02.0 VGA compatible controller [0300]: Intel Corporation Skylake GT2 [HD Graphics 520] [8086:1916] (rev 07) (prog-if 00 [VGA controller])\n\nos-release: NAME=\"Fedora Linux\"\nVERSION=\"39 (Workstation Edition)\"\nID=fedora\nVERSION_ID=39\nVERSION_CODENAME=\"\"\nPLATFORM_ID=\"platform:f39\"\nPRETTY_NAME=\"Fedora Linux 39 (Workstation Edition)\"\nANSI_COLOR=\"0;38;2;60;110;180\"\nLOGO=fedora-logo-icon\nCPE_NAME=\"cpe:/o:fedoraproject:fedora:39\"\nDEFAULT_HOSTNAME=\"fedora\"\nHOME_URL=\" URL \nDOCUMENTATION_URL=\" URL \nSUPPORT_URL=\" URL \nBUG_REPORT_URL=\" URL \nREDHAT_BUGZILLA_PRODUCT=\"Fedora\"\nREDHAT_BUGZILLA_PRODUCT_VERSION=39\nREDHAT_SUPPORT_PRODUCT=\"Fedora\"\nREDHAT_SUPPORT_PRODUCT_VERSION=39\nSUPPORT_END=2024-11-12\nVARIANT=\"Workstation Edition\"\nVARIANT_ID=workstation","author_login":"gmr458","author_association":"NONE","created_at":"2024-08-26T00:46:05+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2309271463","fragment_type":"issue_comment","sequence":6,"text":"@hdm9527 I know, but for some reason Brave and Google Chrome have the issue and Chromium doesn't.","author_login":"gmr458","author_association":"NONE","created_at":"2024-08-26T04:13:04+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2310583290","fragment_type":"issue_comment","sequence":7,"text":"@gmr458 I have the same issue in the most updated Chromium 130.0.6681.0","author_login":"wenjie1991","author_association":"NONE","created_at":"2024-08-26T16:18:27+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2310796657","fragment_type":"issue_comment","sequence":8,"text":"Same problem here, with Brave and Chromium\n\nHyprland, built from branch at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259 (props: bump version to 0.42.0).\nDate: Wed Aug 7 19:17:10 2024\nTag: v0.42.0, commits: 5069\n\nflags: (if any)","author_login":"aryklein","author_association":"NONE","created_at":"2024-08-26T18:18:49+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2312993140","fragment_type":"issue_comment","sequence":9,"text":"Got the same issue on Brave. I think it started after nvidia 560 drivers.\n\n System/Version info \n\nsh\nHyprland, built from branch at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259 (props: bump version to 0.42.0).\nDate: Wed Aug 7 19:17:10 2024\nTag: v0.42.0, commits: 5069\n\nflags: (if any)\n\nSystem Information:\nSystem name: Linux\nNode name: karamanliev\nRelease: 6.10.6-arch1-1\nVersion: #1 SMP PREEMPT_DYNAMIC Mon, 19 Aug 2024 17:02:39 +0000\n\nGPU information:\n26:00.0 VGA compatible controller [0300]: NVIDIA Corporation TU104 [GeForce RTX 2070 SUPER] [10de:1e84] (rev a1) (prog-if 00 [VGA controller])\nNVRM version: NVIDIA UNIX x86_64 Kernel Module 560.35.03 Fri Aug 16 21:39:15 UTC 2024\n\nos-release: NAME=\"Arch Linux\"\nPRETTY_NAME=\"Arch Linux\"\nID=arch\nBUILD_ID=rolling\nANSI_COLOR=\"38;2;23;147;209\"\nHOME_URL=\" URL \nDOCUMENTATION_URL=\" URL \nSUPPORT_URL=\" URL \nBUG_REPORT_URL=\" URL \nPRIVACY_POLICY_URL=\" URL \nLOGO=archlinux-logo","author_login":"karamanliev","author_association":"NONE","created_at":"2024-08-27T16:14:35+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2314872812","fragment_type":"issue_comment","sequence":10,"text":"The Plasma/KWin people had a similar problem. Perhaps related? \n URL","author_login":"MHellmund","author_association":"NONE","created_at":"2024-08-28T09:58:30+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2314962635","fragment_type":"issue_comment","sequence":11,"text":"From my testing, it seems likely that a regression occurred on Chromium side between version 127 and 128 and @gmr458 message seems to point to the same direction.","author_login":"alex73630","author_association":"NONE","created_at":"2024-08-28T10:42:10+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2315056608","fragment_type":"issue_comment","sequence":12,"text":"URL \n\nMhm, so looks like a bug in chromium that could be somewhat alleviated on our side","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-08-28T11:27:27+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2315142040","fragment_type":"issue_comment","sequence":13,"text":"Just switched to `hyprland-git` on Arch and I can confirm issue is solved with the fix :+1:","author_login":"alex73630","author_association":"NONE","created_at":"2024-08-28T12:05:09+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2326459782","fragment_type":"issue_comment","sequence":14,"text":"yes because it's a chromium regression that can be alleviated if hyprland better responds to invalid protocol usage","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-09-03T12:57:40+08:00","repo_name":"hyprwm/Hyprland","issue_id":2484564567,"issue_number":7496,"issue_url":"https://github.com/hyprwm/Hyprland/issues/7496","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2354762310","fragment_type":"issue_description","sequence":0,"text":"Click and drag cursor cannot release on Chromium(Wayland mode)\n### Bug or Regression?\n\nBug\n\n### System Info and Version\n\n System/Version info \n\nsh\nHyprland, built from branch main at commit 4842eb83b444418ad3fe1901d645dd02224989e5 (helpers: make shm_open() portable after 8bcccf9f0f0f (6471)).\nDate: Thu Jun 13 20:20:14 2024\nTag: v0.41.1-2-g4842eb83, commits: 4820\n\nflags: (if any)\n\nSystem Information:\nSystem name: Linux\nNode name: Arch\nRelease: 6.9.3-2-cachyos-echo-lto\nVersion: #1 SMP PREEMPT_DYNAMIC Thu, 06 Jun 2024 06:05:56 +0000\n\nGPU information: \n64:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c7) (prog-if 00 [VGA controller])\n\nos-release: NAME=\"Arch Linux\"\nPRETTY_NAME=\"Arch Linux\"\nID=arch\nBUILD_ID=rolling\nANSI_COLOR=\"38;2;23;147;209\"\nHOME_URL=\" URL \nDOCUMENTATION_URL=\" URL \nSUPPORT_URL=\" URL \nBUG_REPORT_URL=\" URL \nPRIVACY_POLICY_URL=\" URL \nLOGO=archlinux-logo\n\nplugins:\n\n \n\n### Description\n\nClicking on a tab or button and dragging it under chromium does not release the cursor.\n\n### How to reproduce\n\n1. start chromium with `chromium --ozone-platform=wayland`.\n2. clicking on a tab or button on a web page and dragging it.\n\n### Crash reports, logs, images, videos\n\n URL","author_login":"hdm9527","author_association":"NONE","created_at":"2024-06-15T11:20:36+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2169909356","fragment_type":"issue_comment","sequence":1,"text":"this is a broken chromium impl it seems, at least for the home screen icon drag, as that is broken on sway too. The getting stuck is a hyprland bug.","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-06-15T15:32:09+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170354245","fragment_type":"issue_comment","sequence":2,"text":"it surely was released on my end. Make sure you're on the right version with `hyprctl version`","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-06-15T17:00:47+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170366674","fragment_type":"issue_comment","sequence":3,"text":"Hyprland, built from branch main at commit 91fe58f8f278d126852877eadc87c50ca7b9b78d (window: improve swallowing functionality).\nDate: Sun Jun 16 00:20:41 2024\nTag: v0.41.1-18-g91fe58f8, commits: 4836\n\nflags: (if any)","author_login":"hdm9527","author_association":"NONE","created_at":"2024-06-15T17:05:33+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170381330","fragment_type":"issue_comment","sequence":4,"text":"hm, odd. it surely works for me. Anything else you can find to trigger this? Some config opt?","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-06-15T17:11:59+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170398866","fragment_type":"issue_comment","sequence":5,"text":"I commented out the chromium-flags.conf configuration and just started chromium with the chromium --ozone-platform=wayland command and it still doesn't release the cursor","author_login":"hdm9527","author_association":"NONE","created_at":"2024-06-15T17:23:07+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170401835","fragment_type":"issue_comment","sequence":6,"text":"The cursor is not released even if the text is selected and dragged.","author_login":"hdm9527","author_association":"NONE","created_at":"2024-06-15T17:26:05+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2170731855","fragment_type":"issue_comment","sequence":7,"text":"it... works on my end but is really wonky, I'll try to look at it tomorrow","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-06-15T20:54:14+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2171691433","fragment_type":"issue_comment","sequence":8,"text":"It seems to be worse, before it was the current tab not releasing the cursor.\n\n URL","author_login":"hdm9527","author_association":"NONE","created_at":"2024-06-16T14:33:47+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2171748668","fragment_type":"issue_comment","sequence":9,"text":"Helvum didn’t get fixed for me with the previous patch. Trying your latest one now that I’ve got a good dev env set up.","author_login":"andrewathalye","author_association":"NONE","created_at":"2024-06-16T15:44:56+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2171753920","fragment_type":"issue_comment","sequence":10,"text":"@vaxerski It still does not work in Helvum for me so I’ll open a new issue","author_login":"andrewathalye","author_association":"NONE","created_at":"2024-06-16T16:05:19+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2187816210","fragment_type":"issue_comment","sequence":11,"text":"For the people that are not using the `-git` package version, when are you going to release a new version? :)","author_login":"aryklein","author_association":"NONE","created_at":"2024-06-25T02:10:53+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2310282598","fragment_type":"issue_comment","sequence":12,"text":"Yes, it seems it's happening again for me as well\n\nHyprland, built from branch at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259 (props: bump version to 0.42.0).\nDate: Wed Aug 7 19:17:10 2024\nTag: v0.42.0, commits: 5069\n\nflags: (if any)","author_login":"aryklein","author_association":"NONE","created_at":"2024-08-26T13:56:34+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2323039858","fragment_type":"issue_comment","sequence":13,"text":"Happening to me as well. When setting the ozone platform to X11 it goes away but you get those big gaps around the modal windows.\n\nHyprland, built from branch at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259 (props: bump version to 0.42.0).\nDate: Wed Aug 7 19:17:10 2024\nTag: v0.42.0, commits: 5069\n\nflags: (if any)","author_login":"sleklere","author_association":"NONE","created_at":"2024-08-31T20:49:18+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2329129882","fragment_type":"issue_comment","sequence":14,"text":"Yea, seems like this is happening to me too\n\n$hyprctl version\nHyprland, built from branch at commit 9a09eac79b85c846e3a865a9078a3f8ff65a9259 (props: bump version to 0.42.0).\nDate: Wed Aug 7 19:17:10 2024\nTag: v0.42.0, commits: 5069\n\nflags: (if any)\n\nUploading 2024-09-04 19-17-10.mp4…","author_login":"adityavishwakarma69","author_association":"NONE","created_at":"2024-09-04T13:51:19+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2330368881","fragment_type":"issue_comment","sequence":15,"text":"IT IS FIXED IN GIT PLEASE STOP POSTING THAT IT HAPPENS IN 0.42","author_login":"vaxerski","author_association":"MEMBER","created_at":"2024-09-05T00:25:10+08:00","repo_name":"hyprwm/Hyprland","issue_id":2354762310,"issue_number":6509,"issue_url":"https://github.com/hyprwm/Hyprland/issues/6509","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0425","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Vue + Markdown example not working?","query_context":"npm init vitebook vitebook\n\nSelect Vue & Markdown.\n\nnpm install\necho \"# Hello World\" > src/test.md\nnpm run vitebook:dev\n\nThe Markdown file will not show up.","known_context_document_ids":["gh_issue_1189682532"],"reference_answer":"I finally found some time to fix it all and also finished upgrading to Vite 3 :) Everything should be working in latest, feel free to give it a try and let me know how you go. Raise a new issue if there's any problems.","answer_document_id":"gh_comment_1192129257","silver_evidence_path":["gh_comment_1091249655","gh_issue_1195480260","gh_comment_1192129257"],"evidence_issue_ids":[1189682532,1195480260],"source_repo_name":"vitebook/vitebook","source_issue_id":1189682532,"source_issue_number":64,"source_issue_url":"https://github.com/vitebook/vitebook/issues/64","target_repo_name":"vitebook/vitebook","target_issue_id":1195480260,"target_issue_number":72,"target_issue_url":"https://github.com/vitebook/vitebook/issues/72","reference_anchor_document_id":"gh_comment_1091249655","reference_answer_author":"mihar-22","reference_answer_author_association":"MEMBER","quality_score":75.85,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.0526,"target_answer_overlap":0.0833},"issue_created_at":"2022-04-01T11:49:41+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1189682532","fragment_type":"issue_description","sequence":0,"text":"Vue + Markdown example not working\nnpm init vitebook vitebook\n\nSelect Vue & Markdown.\n\nnpm install\necho \"# Hello World\" > src/test.md\nnpm run vitebook:dev\n\nThe Markdown file will not show up.","author_login":"louwers","author_association":"NONE","created_at":"2022-04-01T11:49:41+08:00","repo_name":"vitebook/vitebook","issue_id":1189682532,"issue_number":64,"issue_url":"https://github.com/vitebook/vitebook/issues/64","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1088066647","fragment_type":"issue_comment","sequence":1,"text":"I get the same issue for the svelte example too, i get an empty vitebook default theme page with no menu, it seems like it loads correctly, it redirects to the default example component, but it never shows it.\n\nnpm init vitebook my-vitebook-test-app -- --template svelte\ncd my-vitebook-test-app\nnpm i\nnpm run vitebook:dev\n\nI also get the same behaviour on an previously perfectly working vitebook page so i suspect some (peer?) dependency somewhere was bumped and broke it.\n\nWorth noting is that running `npm run vitebook:build && npm run vitebook:preview` works fine and builds a working page.","author_login":"possan","author_association":"NONE","created_at":"2022-04-04T22:16:45+08:00","repo_name":"vitebook/vitebook","issue_id":1189682532,"issue_number":64,"issue_url":"https://github.com/vitebook/vitebook/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1088652658","fragment_type":"issue_comment","sequence":2,"text":"After too many hours of attempts to debug why i got a blank screen i tried to downgrade some dependencies and found that it works fine by just \"downgrading\" to an explicit dependency on vite `2.8.4` but not with newer ones.","author_login":"possan","author_association":"NONE","created_at":"2022-04-05T12:37:53+08:00","repo_name":"vitebook/vitebook","issue_id":1189682532,"issue_number":64,"issue_url":"https://github.com/vitebook/vitebook/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1090993400","fragment_type":"issue_comment","sequence":3,"text":"@possan I facing the same issue with react, you downgrade vite to 2.8.4?","author_login":"GZLiew","author_association":"NONE","created_at":"2022-04-07T01:48:32+08:00","repo_name":"vitebook/vitebook","issue_id":1189682532,"issue_number":64,"issue_url":"https://github.com/vitebook/vitebook/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091249655","fragment_type":"issue_comment","sequence":4,"text":"@possan Might be related to #72, as both are very recent problems, and one might lead to the other, i suggest that we focus efforts there to address this issue, and close this one (and other similar issues) once it's solved","author_login":"henriquehbr","author_association":"NONE","created_at":"2022-04-07T08:03:36+08:00","repo_name":"vitebook/vitebook","issue_id":1189682532,"issue_number":64,"issue_url":"https://github.com/vitebook/vitebook/issues/64","linked_issue_ids":[1195480260],"is_known_query_context":false},{"document_id":"gh_comment_1192129737","fragment_type":"issue_comment","sequence":5,"text":"I finally found some time to fix it all and also finished upgrading to Vite 3 :) Everything should be working in latest, feel free to give it a try and let me know how you go. Raise a new issue if there's any problems.","author_login":"mihar-22","author_association":"MEMBER","created_at":"2022-07-22T03:00:30+08:00","repo_name":"vitebook/vitebook","issue_id":1189682532,"issue_number":64,"issue_url":"https://github.com/vitebook/vitebook/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1195480260","fragment_type":"issue_description","sequence":0,"text":"Broken since 0.18.6\nHI this is a great idea so far \n\nIm facing an issue where nothing works anymore after updating to 0.19.0 and beyond\n\nI even tried the same changes for your documentation site and it shows that it wasnt working\n\nThis library has alot of potential to be better than storybook...\n\nreproducible link: URL \nif you update to 0.19.0 and after the pages wont show anymore","author_login":"GZLiew","author_association":"NONE","created_at":"2022-04-07T03:44:08+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091157895","fragment_type":"issue_comment","sequence":1,"text":"If you're talking about the missing source files error I got the same kind of issue, but with other versions:\n\ngit clone URL \ncd svelte-babylon\n# until here everthing works\nnpm i -d vite # at the time of writing going from vite 2.7.0 to vite 2.9.2\nnpm run vitebook:dev\n\nError message:\n`Sourcemap for \"/home/user/Projects/svelte-babylon/library/node_modules/@vitebook/client/dist/client/addons/events/EventsAddon.svelte\" points to missing source files`\n\nMy vitebook versions are `^0.23.4`, so I assume, that the error originates from `vite`.\n\nThere have been similar reports:\n- URL \n- URL","author_login":"Myrmod","author_association":"NONE","created_at":"2022-04-07T07:09:29+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091196603","fragment_type":"issue_comment","sequence":2,"text":"@Myrmod hmm I still think the issue is caused by vitebook rather than vite. Since im able to run vite at `2.9.1` with vitebook `0.18.6`","author_login":"GZLiew","author_association":"NONE","created_at":"2022-04-07T07:36:24+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091224885","fragment_type":"issue_comment","sequence":3,"text":"Thanks for reporting this @GZLiew, i'm facing the same issue, tried downgrading vitebook to `0.18.6` as a temporary workaround, couldn't get it to work, but i think it's due to a completely unrelated reason:\n\n4:50:50 AM [vite] Internal server error: /home/hbr/repos/github/itatiaia-portal-web/node_modules/@vitebook/client/dist/client/App.svelte:29:16 Cannot have an {:else} block outside an {#if ...} or {#each ...} block\n Plugin: vite-plugin-svelte\n File: /home/hbr/repos/github/itatiaia-portal-web/node_modules/@vitebook/client/dist/client/App.svelte\n 27 | const file = \"node_modules/@vitebook/client/dist/client/App.svelte\";\n 28 |\n 29 | // (17:0) {:else}\n ^\n 30 | function create_else_block(ctx) {\n 31 | let switch_instance;\n\nI'm also using the exact vite version of you (`2.9.1`)","author_login":"henriquehbr","author_association":"NONE","created_at":"2022-04-07T07:51:10+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092447594","fragment_type":"issue_comment","sequence":4,"text":"I've confirmed that the issue is with Vite `2.9.1` to get things working I recommend anchoring your Vite version to `2.8.6` which is the last working version for Vitebook","author_login":"joseaquino","author_association":"NONE","created_at":"2022-04-08T05:11:06+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092456414","fragment_type":"issue_comment","sequence":5,"text":"@joseaquino nope still doesnt work for me can you share me a sample repo? \n\nI tested it by bumping vite to `2.8.6` in their example stackblitz URL","author_login":"GZLiew","author_association":"NONE","created_at":"2022-04-08T05:30:09+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1093561868","fragment_type":"issue_comment","sequence":6,"text":"@joseaquino you're right! 👍🏻 hard fixing the dependencies of vite to `2.8.6` does fixes the solution. Guys Im going to mark this as the solution until vite solves the problem for us.","author_login":"GZLiew","author_association":"NONE","created_at":"2022-04-09T01:29:04+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1120346383","fragment_type":"issue_comment","sequence":7,"text":"The issue still persists for me with Vite@2.9.8.\n\nVite@2.8.6 working well, I'm running Vitebook with Vitest and testing my components by using the preact testing library.","author_login":"CM-IV","author_association":"NONE","created_at":"2022-05-08T04:12:53+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1172836561","fragment_type":"issue_comment","sequence":8,"text":"It looks like vite@2.8.6 is the last working version\n\nI was able to revive the examples (I tried `examples/svelte-kit`) with pinning vite-plugin-svelte and vite package versions in package.json:\n\njsonc\n// package.json\n{\n ...\n \"devDependencies\": {\n+ \"@sveltejs/vite-plugin-svelte\": \"1.0.0-next.36\",\n ...\n+ \"vite\": \"2.8.6\"\n },\n+ \"pnpm\": {\n+ \"overrides\" : {\n+ \"@sveltejs/vite-plugin-svelte\": \"1.0.0-next.36\",\n+ \"vite\": \"2.8.6\"\n+ }\n+ },\n ...\n}","author_login":"iva2k","author_association":"NONE","created_at":"2022-07-02T05:09:20+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1192129257","fragment_type":"issue_comment","sequence":9,"text":"I finally found some time to fix it all and also finished upgrading to Vite 3 :) Everything should be working in latest, feel free to give it a try and let me know how you go. Raise a new issue if there's any problems.","author_login":"mihar-22","author_association":"MEMBER","created_at":"2022-07-22T03:00:07+08:00","repo_name":"vitebook/vitebook","issue_id":1195480260,"issue_number":72,"issue_url":"https://github.com/vitebook/vitebook/issues/72","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0426","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Explain how to use `git pr list --template` feature, or at least give some hints and an example?","query_context":"### Describe the feature or problem you’d like to solve\n\nThe `gh pr list` command has an argument `--template`; the only documentation for it that I could find states:\n \n\nBut what does that mean? For Go aficionados this might be crystal clear, but others (including me) may have no clue at all what that means.\n\n### Proposed solution\n\nExplain this more. At the very least, perhaps a link to an external site could be inserted that explains what a \"Go template\" is. A minimal example would also be very nice.","known_context_document_ids":["gh_issue_1341961946"],"reference_answer":"@heaths Looks pretty good! I think you're definitely on to something here.\n\nDoes `text/tabwriter` work when the lines passed in contain ANSI escape sequences? I would have guessed that it doesn't recognize these escape sequences as non-printable and that they can mess up horizontal alignment.","answer_document_id":"gh_comment_826695955","silver_evidence_path":["gh_comment_1219364500","gh_issue_864493180","gh_comment_826695955"],"evidence_issue_ids":[1341961946,864493180],"source_repo_name":"cli/cli","source_issue_id":1341961946,"source_issue_number":6089,"source_issue_url":"https://github.com/cli/cli/issues/6089","target_repo_name":"cli/cli","target_issue_id":864493180,"target_issue_number":3488,"target_issue_url":"https://github.com/cli/cli/issues/3488","reference_anchor_document_id":"gh_comment_1219364500","reference_answer_author":"mislav","reference_answer_author_association":"MEMBER","quality_score":77.08,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.3,"target_answer_overlap":0.0417},"issue_created_at":"2022-08-17T15:41:48+08:00","valid_comment_count":24,"fragments":[{"document_id":"gh_issue_1341961946","fragment_type":"issue_description","sequence":0,"text":"Explain how to use `git pr list --template` feature, or at least give some hints and an example\n### Describe the feature or problem you’d like to solve\n\nThe `gh pr list` command has an argument `--template`; the only documentation for it that I could find states:\n \n\nBut what does that mean? For Go aficionados this might be crystal clear, but others (including me) may have no clue at all what that means.\n\n### Proposed solution\n\nExplain this more. At the very least, perhaps a link to an external site could be inserted that explains what a \"Go template\" is. A minimal example would also be very nice.","author_login":"fingolfin","author_association":"NONE","created_at":"2022-08-17T15:41:48+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1219364500","fragment_type":"issue_comment","sequence":1,"text":"### Website\n URL \n\n### GitHub cli/cli repo\nCheck the comments made by @heaths on ticket #3488","author_login":"LangLangBart","author_association":"NONE","created_at":"2022-08-18T11:11:22+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[864493180],"is_known_query_context":false},{"document_id":"gh_comment_1219537700","fragment_type":"issue_comment","sequence":2,"text":"Running `gh help template` (or maybe \"templates\") will show you lots of information with examples. `gh pr list --help` should say that like I know other commands do. Does it not?","author_login":"heaths","author_association":"CONTRIBUTOR","created_at":"2022-08-18T14:06:10+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1219543864","fragment_type":"issue_comment","sequence":3,"text":"@LangLangBart thanks that's helpful, I didn't find it\n\n@heaths neither `gh help template` nor `gh help templates` does anything useful for me. Aha, but combined with what @LangLangBart pointed out, I am guessing `gh help formatting` is what you had in mind?\n\nAs it is `gh pr list --help` does not mention this or anything like it. And e.g. `gh issue list --help` also lists a `--template` option, but again without any examples or pointers where to find out more.\n\nIf\n\n -t, --template string Format JSON output using a Go template\n\nwas changed to, say\n\n -t, --template string Format JSON output using a Go template, for more details consult `gh help formatting`\n\nor if those help pages just would mention this at the bottom, that'd be swell","author_login":"fingolfin","author_association":"NONE","created_at":"2022-08-18T14:11:30+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1220250908","fragment_type":"issue_comment","sequence":4,"text":"@fingolfin Thats seems like a good idea. Will you make the PR ?\n\n___\n\nOnce you have selected your values for your `--json` flag and made them pretty with `--template`, you can then pass your command through fzf for an interactive experience.\n\nTake advantage of the environment variable `GH_FORCE_TTY`, to enable terminal-style output even when the output is redirected (see `gh environment` for more details about it).\n### Example: \n#### Code\n\nzsh\n# .zshrc gh pr list command extended with fzf, see the man page (man fzf) for an explanation of the arguments.\nfunction ghpr {\n [[ ! \"$(git rev-parse --is-inside-work-tree)\" ]] && return 1\n GH_COMMAND='gh pr list --state open --json number,author,additions,deletions,updatedAt,title --template \"\n {{- tablerow (\\\"PR\\\" | color \\\"blue+b\\\") (\\\"LAST UPDATE\\\" | color \\\"blue+b\\\") (\\\"AUTHOR\\\" | color \\\"blue+b\\\") \\\"\\\" \\\"\\\" (\\\"TITLE\\\" | color \\\"blue+b\\\") -}}\n {{- range . -}}\n {{- tablerow (printf \\\"#%v\\\" .number | color \\\"green+h\\\") (timeago .updatedAt | color \\\"gray+h\\\") (.author.login | color \\\"cyan+h\\\") (printf \\\"+%v\\\" .additions | color \\\"green\\\") (printf \\\"-%v\\\" .deletions | color \\\"red\\\") .title -}}\n {{- end -}}\" --search'\n FZF_DEFAULT_COMMAND=\"$GH_COMMAND ${1:-\\\"\\\"}\" \\\n GH_FORCE_TTY=100% fzf --ansi --disabled --no-multi --header-lines=1 \\\n --header $'CTRL+B - Browser | CTRL+D - Toggle Diff | CTRL+X - Checkout\\nCTRL+E - Edit | CTRL+I - Toggle Info | CTRL+Y - Comment' \\\n --prompt 'Search Open PRs >' --preview-window hidden:wrap \\\n --layout=reverse --info=inline --no-multi \\\n --bind \"change:reload:sleep 0.25; $GH_COMMAND {q} || true\" \\\n --bind 'ctrl-b:execute-silent(gh pr view {1} --web)' \\\n --bind 'ctrl-d:toggle-preview+change-preview(gh pr diff {1} --color always)' \\\n --bind 'ctrl-i:toggle-preview+change-preview(gh pr view {1} --comments)' \\\n --bind 'ctrl-e:accept+execute(gh pr edit {1})' \\\n --bind 'ctrl-x:accept+execute(gh pr checkout {1})' \\\n --bind 'ctrl-y:accept+execute(gh pr comment {1})'\n}\n\n#### GIF\nIn the example I used `nano` as editor to write the comment, but you can set your own with `gh config set editor ...`.","author_login":"LangLangBart","author_association":"NONE","created_at":"2022-08-19T04:59:02+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1222696795","fragment_type":"issue_comment","sequence":5,"text":"Now that I'm back at a workstation, running `gh issue list --help` does show:\n \n\n`gh pr list --help` shows the same thing:\n \n\nGiven I was on my phone with no easy way to look up, I misremembered \"template\" (or variant) instead of \"formatting\", but that's what I was trying to remember.\n\nIf the maintainers are good with adding text to the individual usage line, do it at the following locationand it'll apply to all commands using it: URL","author_login":"heaths","author_association":"CONTRIBUTOR","created_at":"2022-08-22T17:40:29+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1226075409","fragment_type":"issue_comment","sequence":6,"text":"I would be thrilled for better docs around this and am cool with heaths's suggestion. I would also be fine with further additions added to `gh help formatting` if there are ways to make that doc more helpful.","author_login":"vilmibm","author_association":"MEMBER","created_at":"2022-08-24T18:19:39+08:00","repo_name":"cli/cli","issue_id":1341961946,"issue_number":6089,"issue_url":"https://github.com/cli/cli/issues/6089","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_864493180","fragment_type":"issue_description","sequence":0,"text":"Provide Go template functions to format table output\n### Describe the feature or problem you’d like to solve\n\nRelated to #3487 there was no great way to provide table output like you do for most (or perhaps all) your other commands like `gh issue list`. You expose a `color` function and I can use `printf` to align and pad strings, but what would be really great is a `table` function.\n\n### Proposed solution\n\nThe Docker CLI lets you specify a `table` function that works like this:\n\nbash\ndocker images --format \"table {{.Repository}}\\t{{.Tag}}\"\n\nIt would then output something like:\n\nnone\nREPOSITORY TAG\nazuresecuritykeyvaultcertificatestests latest\ndotnet-sdk 5.0-ubuntu-18.04\njupyter/base-notebook latest\n\nThis is done via, mostly, URL It is effectively like `{{range}}` but splits on tabs and determines optimal width automatically.\n\nAlternatively, if there was some way to declare the scope of nodes to format as a table automatically, perhaps you could - when specified - format that with survey as you do your own table output.","author_login":"heaths","author_association":"CONTRIBUTOR","created_at":"2021-04-22T03:03:48+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_825493659","fragment_type":"issue_comment","sequence":1,"text":"Looking through the built-in formatting more, I wonder if this could instead be used for built-in command output rather than manually formatting the output. The crux of Docker's `table` template function is \"text/tabwriter\" which uses elastic tabstops, so even paginated results should align properly. I'm interested in taking a crack at this if there's interest in accepting it. At the minimum, I think making it available for `gh api --template` would be a good start, and whether to adopt it for built-in commands could be a separate discussion. You could combine that with your existing `color` functions, though it seems you'll need to add a couple more color options to match what you use currently for built-in command colored output.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-23T08:30:07+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_825634345","fragment_type":"issue_comment","sequence":2,"text":"@heaths I'd be interested in having a table template function!\n \n\nIf our templating support gets full-featured enough, we could theoretically switch built-in output to the template approach. That would also serve as a starting template for someone who would like to tweak the output in their own scripts. But for now, I'd propose expanding `--template` functionality first, then exploring if built-in commands can switch to it separately.","author_login":"mislav","author_association":"MEMBER","created_at":"2021-04-23T12:47:27+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_825785348","fragment_type":"issue_comment","sequence":3,"text":"I am +1 on these ideas but defer to @mislav on the details as he is the one who's been thinking most about programmatic output like this.","author_login":"vilmibm","author_association":"MEMBER","created_at":"2021-04-23T16:50:14+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_825791755","fragment_type":"issue_comment","sequence":4,"text":"@heaths You are welcome to send a PR adding a `table` helper. I'm interested in how it will work 👍","author_login":"mislav","author_association":"MEMBER","created_at":"2021-04-23T17:01:33+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_825985341","fragment_type":"issue_comment","sequence":5,"text":"I'll try to take a look this weekend. I need to play around with things a little (probably just a scratch program) to see if `{{with pipeline}}` will work since your GraphQL results typically have the juicy bits nested lower. Using Docker's `table` as a pattern, it only wants leaf nodes and seems to expect strings. If `{{with}}` doesn't work, may need to tweak this `table` function a little more to handle nesting, but I don't foresee a problem.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-23T23:06:12+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826144497","fragment_type":"issue_comment","sequence":6,"text":"After playing around with a few options last night, I think this might be better served by a PR to the text/template package itself. Docker's \"function\" is really just a hack: if the template starts with \"table\" (or a couple others like \"raw\"), that prefix is stripped from the template and it does some simple string transforms on the remaining pipeline. It works well when your output is already an array, but if you're array is arbitrarily nested (like a GraphQL query might often end up), it wouldn't work. Even if we scanned the string for any occurrence of \"table\" (or similar), there's no obvious end. The `text/template/parse.Tree` that is compiled is where the change really needs to happen. I can also make it work with 2 templates, but it seems like an even bigger hack and not very user-friendly to have two arguments for a table, like `--template '{{with .Nodes}}{{template \"table\"}}{{end}}` then, if you use a table, `--template-table '{{range .}}{{.Id}}{{\"\\t\"}}{{.Name}}{{end}}'`.\n\nFor now, let me see if there's any interest in a change to the text/template package. I think it could be an all-around useful addition.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-24T19:49:42+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826289408","fragment_type":"issue_comment","sequence":7,"text":"Thanks for exploring all this! I have little faith that the proposal to `text/template` will be accepted, since I think you will be told to just implement this programmatically (either via custom helper function or nested templates), but even if it doesn't get into Go, I think we can just invent some approach ourselves. For example:\n\ngotemplate\n{{range .}}{{ tableRow .number .title .author }}{{end}}\n{{tableRender}}","author_login":"mislav","author_association":"MEMBER","created_at":"2021-04-25T09:18:13+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826343909","fragment_type":"issue_comment","sequence":8,"text":"I've been considering some similar approaches under the assumption it won't be accepted because it actually emits formatted text, which seems out of scope.\n\nOne idea was similar to what you suggested, but the problem is that you can't pass fields to functions if, for example, you wanted to color text. Maybe some was to do that would be more acceptable, like inline pipelines via syntax like (partial) `{{tableRow (.I'd | color \"green\")}}`.\n\nIf not even that, I've been thinking that we could pre-parse the template and, like Docker CLI, manipulate it to make another named template internally. I'll continue to play around with this in my scratch program.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-25T15:37:22+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826356742","fragment_type":"issue_comment","sequence":9,"text":"Well...I'm shocked. Apparently parenthesis already work. While perusing through the text/template/parse code and making a few preliminary changes to support my proposal, I failed to see how parsed parenthesis were used.\n\nThis commit shows my idea above already works:\n\nimage\n\nI'll proceed with this course of action, but would also like to add a couple more helper functions that I think will also help in the future if we wanted to replace the built-in formatting with this new set of functions, e.g. `truncate`, though I think I might reverse the `uint` and `string` params so you can do either `{{truncate 30 .Title | color \"green\"}}` or `{{.Title | truncate 30 | color \"green\"}}`.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-25T17:09:57+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826369744","fragment_type":"issue_comment","sequence":10,"text":"After further consideration I propose support for multiple tables, which could be beneficial down the road. Effectively, this:\n\n`{{table}}{{range .Books}}{{row (.Title | truncate 30 | green) .ISBN13}}{{end}}{{endTable}}`\n\nWe could use `{{tableRow}}` as well, but with `{{table}}` I figured it would be fairly obvious and slightly prefer brevity over specificity in a rather limited scope like this.\n\n`{{table}}` would set the current table for subsequent `{{row}}` calls, while `{{endTable}}` would flush the current table an nilify it.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-25T18:37:07+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826695955","fragment_type":"issue_comment","sequence":11,"text":"@heaths Looks pretty good! I think you're definitely on to something here.\n\nDoes `text/tabwriter` work when the lines passed in contain ANSI escape sequences? I would have guessed that it doesn't recognize these escape sequences as non-printable and that they can mess up horizontal alignment.","author_login":"mislav","author_association":"MEMBER","created_at":"2021-04-26T09:58:35+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826870536","fragment_type":"issue_comment","sequence":12,"text":"C-style escape sequences within the text won't be interpreted, but literal escapes will. While the web forms appear to prevent this (or at least make it harder), I was able to add an issue with literal escapes in both the title and text. Seems I'll have to create a replacer that perhaps JS-encodes all but `\\ux1b` used for vterm sequences.","author_login":"heaths","author_association":"NONE","created_at":"2021-04-26T14:15:02+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_826914922","fragment_type":"issue_comment","sequence":13,"text":"Actually, looks like this shouldn't be a problem:\n\nbash\n$ gh api graphql -f query='query {\n repository(name: \"templ\", owner: \"heaths\") {\n issue(number: 1) {\n number\n title\n bodyText\n }\n }\n}'\n\njson\n{\n \"data\": {\n \"repository\": {\n \"issue\": {\n \"number\": 1,\n \"title\": \"Title:\\u0008 with escape\",\n \"bodyText\": \"This\\tbody has\\nescape sequences\"\n }\n }\n }\n}","author_login":"heaths","author_association":"NONE","created_at":"2021-04-26T15:09:31+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_827359527","fragment_type":"issue_comment","sequence":14,"text":"Working on some tests and docs, but a preview of using a table template for `gh issues list`:\n\nbash\nbin/gh issue list --json number,title,labels,updatedAt --template '{{table}}{{range .}}{{row (.number | printf \"#%v\" | color \"green\") (.title | ellipsis 50) (.labels | pluck \"name\" | join \", \" | printf \"(%s)\" | color \"gray\") (timeago .updatedAt | color \"gray\")}}{{end}}{{endTable}}'\n\nimage","author_login":"heaths","author_association":"CONTRIBUTOR","created_at":"2021-04-27T06:51:17+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_917636321","fragment_type":"issue_comment","sequence":15,"text":"For those wondering what gh template ended as. Here is an example:\n\ngh issue list --milestone \"GD 2.3.3\" -s all --json number,title,url -t'{{range .}}{{tablerow .number .url .title}}{{end}}{{tablerender}}'\n\n- \"range .\" loop over all elements of the collections.\n- tablerow prepares the table using the element of each item of the collections (the names are the ones provided to --json option\n- tablerender will render the final table\n- any space between {{ }} will be used as is\n- it is not possible to use anything outside {{}} as it will be interpreted as option for the cmd or error out (it would be nice to be able to pass a file btw)\n\nHope that helps.\n\nPS: It would be awesome to add that to the doc here and there.","author_login":"pierrejoye","author_association":"NONE","created_at":"2021-09-12T13:27:23+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_917718648","fragment_type":"issue_comment","sequence":16,"text":"I did add that to the `formatting` help topic, though that page you reference doesn't seem to be rendering it correctly:\n\nWith `--template`, the provided Go template is rendered using the JSON data as input.\nFor the syntax of Go templates, see: URL \n\nThe following functions are available in templates:\n- `autocolor`: like `color`, but only emits color to terminals\n- `color `: colorize input using URL \n- `join `: joins values in the list using a separator\n- `pluck `: collects values of a field from all items in the input\n- `tablerow ...`: aligns fields in output vertically as a table\n- `tablerender`: renders fields added by tablerow in place\n- `timeago `: renders a timestamp as relative to now\n- `timefmt `: formats a timestamp using Go's Time.Format function\n- `truncate `: ensures input fits within length\n\nEXAMPLES\n # format issues as table\n $ gh issue list --json number,title --template \\\n '{{range .}}{{tablerow (printf \"#%v\" .number | autocolor \"green\") .title}}{{end}}'\n\n # format a pull request using multiple tables with headers\n $ gh pr view 3519 --json number,title,body,reviews,assignees --template \\\n '{{printf \"#%v\" .number}} {{.title}}\n\n {{.body}}\n\n {{tablerow \"ASSIGNEE\" \"NAME\"}}{{range .assignees}}{{tablerow .login .name}}{{end}}{{tablerender}}\n {{tablerow \"REVIEWER\" \"STATE\" \"COMMENT\"}}{{range .reviews}}{{tablerow .author.login .state .body}}{{end}}\n '\n\nAlso, you don't need `{{tablerender}}` unless you want to render any text - plain or even another table - after that. The table is automatically rendered after all records are processed if not rendered explicitly first.","author_login":"heaths","author_association":"CONTRIBUTOR","created_at":"2021-09-12T22:05:37+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082512625","fragment_type":"issue_comment","sequence":17,"text":"How would I add, for example, a comma-separated list of label names into a `tablerow`? I've tried:\n\n`.labels.name`\n\nbut get:\n\ntemplate: :1:135: executing \"\" at : can't evaluate field name in type interface {}\n\nI've also tried various forms of nesting `{{range}}` instead tablerow and using `join` but nothing seems to work. I've got an equivalent jq expression working, but would rather use a go template for better formatting.","author_login":"rocketraman","author_association":"NONE","created_at":"2022-03-30T01:04:22+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083414935","fragment_type":"issue_comment","sequence":18,"text":"Go templates don't expand slices like that. But you can use some scope operator like `range` or a specific operator like `pluck` for a slice of labels like so:\n\n URL","author_login":"heaths","author_association":"CONTRIBUTOR","created_at":"2022-03-30T17:22:52+08:00","repo_name":"cli/cli","issue_id":864493180,"issue_number":3488,"issue_url":"https://github.com/cli/cli/issues/3488","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0427","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"WebSocket Disconnection Issue After Running for Some Time the Companion Web API Service?","query_context":"**Describe the bug**\nWe are experiencing an issue where WebSocket connections in our application are getting disconnected after running for some time. The application initially runs without any issues, but after a certain period, WebSockets stop functioning, and we receive the following error in the logs when performing certain API calls:\n\n`\nfail: Microsoft.AspNetCore.Server.Kestrel[13]\n Connection id \"*****\", Request id \"*****:00000001\": An unhandled exception was thrown by the application.\n {\"type\":\"WebSocketException\",\"title\":\"HttpRequestException\",\"status\":500,\"detail\":\"-2147467259\"}\n`\n\nAfter a restart of the service, everything works correctly again.\n\n**To Reproduce**\n1. Deploy mcr.microsoft.com/iot/industrial-iot-services-all:2.9.11\n2. Perform an API call to get history values: history/v2/read/ /values\n3. At the beginning is working properly, after some time it stops working\n\n**Expected behavior**\nWebSocket connections should remain stable without unexpected disconnections.\n\n**Actual Behavior**\nWebSockets disconnect after a certain period, and the application logs the error mentioned above.\n\n**Version**\nThe version used is mcr.microsoft.com/iot/industrial-iot-services-all:2.9.11","known_context_document_ids":["gh_issue_2924720437"],"reference_answer":"@NoTuxNoBux, the plan proposed here would be to stop releasing the \"cloud webapp\" container, which would include the Twin API you are referencing. But this companion webapp just wraps the device twin and device methods behind a REST interface (with retries etc.) so apps in the cloud do not need to call any IoT Hub device methods directly. So that you are not seeing the same behavior is surprising and would need to be looked at. You could use the code in the web app in your Azure function, would that work? \n\nYou could also use 2.9.14 of the container on MCR, but there would not be any more security fixes published, nor would we run end to end tests with 2.9.15+ of OPC Publisher then. \n\nAnyway, we could slice the webapp to just what you need and make it a sample, if that is ok for you, a list of API you are using would be great.\n\nThe core issue is that we just do not have cycles to update the deployment scripts and e2e devops pipelines to comply with security requirements for hosting on Microsoft build system. we are forced to turn off our builds/tests for this component at some point or muster time to stay in compliance. \n\nI want to say this too, so it is not misconstrued: The OPC Publisher is not affected by this at all, we did all the work to be compliant internally already. It can still be controlled via Device Methods from IoT Hub, the API will not change, and no support timelines/conditions are affected, it remains fully integrated there and no changes are planned there. The OPC Publisher module will also retain all its capabilities, nothing will be removed which includes its HTTPS API endpoint if you enable it. \n\nThere was very limited feedback here until yesterday, nor did we ever get a support ticket on this component, which indicates that usage is very light. It would be great if we can come up with a plan quickly that does not break anyone.","answer_document_id":"gh_comment_2969400034","silver_evidence_path":["gh_comment_2970338769","gh_issue_2795610304","gh_comment_2969400034"],"evidence_issue_ids":[2924720437,2795610304],"source_repo_name":"Azure/Industrial-IoT","source_issue_id":2924720437,"source_issue_number":2385,"source_issue_url":"https://github.com/Azure/Industrial-IoT/issues/2385","target_repo_name":"Azure/Industrial-IoT","target_issue_id":2795610304,"target_issue_number":2370,"target_issue_url":"https://github.com/Azure/Industrial-IoT/issues/2370","reference_anchor_document_id":"gh_comment_2970338769","reference_answer_author":"marcschier","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.2857,"target_answer_overlap":0.4074},"issue_created_at":"2025-03-17T11:27:58+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2924720437","fragment_type":"issue_description","sequence":0,"text":"WebSocket Disconnection Issue After Running for Some Time the Companion Web API Service\n**Describe the bug**\nWe are experiencing an issue where WebSocket connections in our application are getting disconnected after running for some time. The application initially runs without any issues, but after a certain period, WebSockets stop functioning, and we receive the following error in the logs when performing certain API calls:\n\n`\nfail: Microsoft.AspNetCore.Server.Kestrel[13]\n Connection id \"*****\", Request id \"*****:00000001\": An unhandled exception was thrown by the application.\n {\"type\":\"WebSocketException\",\"title\":\"HttpRequestException\",\"status\":500,\"detail\":\"-2147467259\"}\n`\n\nAfter a restart of the service, everything works correctly again.\n\n**To Reproduce**\n1. Deploy mcr.microsoft.com/iot/industrial-iot-services-all:2.9.11\n2. Perform an API call to get history values: history/v2/read/ /values\n3. At the beginning is working properly, after some time it stops working\n\n**Expected behavior**\nWebSocket connections should remain stable without unexpected disconnections.\n\n**Actual Behavior**\nWebSockets disconnect after a certain period, and the application logs the error mentioned above.\n\n**Version**\nThe version used is mcr.microsoft.com/iot/industrial-iot-services-all:2.9.11","author_login":"MickeyMouseS","author_association":"NONE","created_at":"2025-03-17T11:27:58+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2924720437,"issue_number":2385,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2385","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2730594254","fragment_type":"issue_comment","sequence":1,"text":"Do you have more logs to pinpoint the issue? It sounds the entire app service is not working anymore, is that correct? Because you are saying you needed to restart the app service instance/service.","author_login":"marcschier","author_association":"COLLABORATOR","created_at":"2025-03-17T19:20:58+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2924720437,"issue_number":2385,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2385","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2749388003","fragment_type":"issue_comment","sequence":2,"text":"Yes, here I add more logs. The app is still working and replying successfully to other API calls, but not to the history read ones for a given endpoint.\n\n`\nfail: Microsoft.AspNetCore.Server.Kestrel[13]\n Connection id \"0HNB566KS58R0\", Request id \"0HNB566KS58R0:00000001\": An unhandled exception was thrown by the application.\n {\"type\":\"WebSocketException\",\"title\":\"HttpRequestException\",\"status\":500,\"detail\":\"-2147467259\"}\ninfo: Microsoft.AspNetCore.Hosting.Diagnostics[2]\n Request finished HTTP/1.1 POST URL - 500 0 - 846.6320ms\ninfo: Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker[105]\n Executed action Azure.IIoT.OpcUa.Publisher.Service.WebApi.Controllers.HistoryController.HistoryReadValuesAsync (Azure.IIoT.OpcUa.Publisher.Service.WebApi) in 884.4223ms\ninfo: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]\n Executed endpoint 'Azure.IIoT.OpcUa.Publisher.Service.WebApi.Controllers.HistoryController.HistoryReadValuesAsync (Azure.IIoT.OpcUa.Publisher.Service.WebApi)'\nfail: Microsoft.AspNetCore.Server.Kestrel[13]\n Connection id \"0HNB566KS58QV\", Request id \"0HNB566KS58QV:00000001\": An unhandled exception was thrown by the application.\n {\"type\":\"WebSocketException\",\"title\":\"HttpRequestException\",\"status\":500,\"detail\":\"-2147467259\"}\ninfo: Microsoft.AspNetCore.Hosting.Diagnostics[2]\n Request finished HTTP/1.1 POST URL - 500 0 - 885.1963ms\ninfo: Microsoft.AspNetCore.Hosting.Diagnostics[1]\n Request starting HTTP/1.1 GET URL - - -\ninfo: Microsoft.AspNetCore.Hosting.Diagnostics[1]\n Request starting HTTP/1.1 GET URL - - -\ninfo: Microsoft.AspNetCore.Routing.EndpointMiddleware[0]\n Executing endpoint 'Health checks'\ninfo: Microsoft.AspNetCore.Routing.EndpointMiddleware[0]\n Executing endpoint 'Health checks'\ninfo: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]\n Executed endpoint 'Health checks'\ninfo: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]\n Executed endpoint 'Health checks'\ninfo: Microsoft.AspNetCore.Hosting.Diagnostics[2]\n Request finished HTTP/1.1 GET URL - 200 - text/plain 0.4270ms\ninfo: Microsoft.AspNetCore.Hosting.Diagnostics[2]\n Request finished HTTP/1.1 GET URL - 200 - text/plain 0.4268ms\n`","author_login":"MickeyMouseS","author_association":"NONE","created_at":"2025-03-24T21:02:10+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2924720437,"issue_number":2385,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2385","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2970338769","fragment_type":"issue_comment","sequence":3,"text":"We are removing the companion app as per #2370 , closing as wont fix.","author_login":"marcschier","author_association":"COLLABORATOR","created_at":"2025-06-13T13:08:26+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2924720437,"issue_number":2385,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2385","linked_issue_ids":[2795610304],"is_known_query_context":false},{"document_id":"gh_issue_2795610304","fragment_type":"issue_description","sequence":0,"text":"Notice: Deprecation and removal of cloud REST companion web application is planned for release 2.9.15.\nBased on the feedback below that we received since Jan 17th, we will remove the REST companion web app in 2.9.15 release and only ship the OPC Publisher IoT Edge module going forward.","author_login":"marcschier","author_association":"COLLABORATOR","created_at":"2025-01-17T14:27:32+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2795610304,"issue_number":2370,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2639739452","fragment_type":"issue_comment","sequence":1,"text":"At least for us it is not a concern. Albeit it is always nice to have a sample.","author_login":"quality-leftovers","author_association":"CONTRIBUTOR","created_at":"2025-02-06T12:49:13+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2795610304,"issue_number":2370,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2969400034","fragment_type":"issue_comment","sequence":2,"text":"@NoTuxNoBux, the plan proposed here would be to stop releasing the \"cloud webapp\" container, which would include the Twin API you are referencing. But this companion webapp just wraps the device twin and device methods behind a REST interface (with retries etc.) so apps in the cloud do not need to call any IoT Hub device methods directly. So that you are not seeing the same behavior is surprising and would need to be looked at. You could use the code in the web app in your Azure function, would that work? \n\nYou could also use 2.9.14 of the container on MCR, but there would not be any more security fixes published, nor would we run end to end tests with 2.9.15+ of OPC Publisher then. \n\nAnyway, we could slice the webapp to just what you need and make it a sample, if that is ok for you, a list of API you are using would be great.\n\nThe core issue is that we just do not have cycles to update the deployment scripts and e2e devops pipelines to comply with security requirements for hosting on Microsoft build system. we are forced to turn off our builds/tests for this component at some point or muster time to stay in compliance. \n\nI want to say this too, so it is not misconstrued: The OPC Publisher is not affected by this at all, we did all the work to be compliant internally already. It can still be controlled via Device Methods from IoT Hub, the API will not change, and no support timelines/conditions are affected, it remains fully integrated there and no changes are planned there. The OPC Publisher module will also retain all its capabilities, nothing will be removed which includes its HTTPS API endpoint if you enable it. \n\nThere was very limited feedback here until yesterday, nor did we ever get a support ticket on this component, which indicates that usage is very light. It would be great if we can come up with a plan quickly that does not break anyone.","author_login":"marcschier","author_association":"COLLABORATOR","created_at":"2025-06-13T07:37:01+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2795610304,"issue_number":2370,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2969569528","fragment_type":"issue_comment","sequence":3,"text":"Hi @marcschier Thanks for clarifying, in that case, if I understood correctly, we are indeed not affected by this change and don't mind it going away 🙂.\n\nWhat we are doing right now is indeed calling HTTPS/REST API methods on the OPC Publisher directly on the IP address of the machine hosting it, using ApiKey authentication. From what I understand now the cloud webapp is a separate application that we thus aren't using (we just deploy the OPC Publisher itself).","author_login":"NoTuxNoBux","author_association":"NONE","created_at":"2025-06-13T08:44:58+08:00","repo_name":"Azure/Industrial-IoT","issue_id":2795610304,"issue_number":2370,"issue_url":"https://github.com/Azure/Industrial-IoT/issues/2370","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0428","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Assertion fails if cancellation is requested before connection establish?","query_context":"It seems when we send cancellation signal during the connection phase this assertion fails.\ni'm using URL \n`\n: ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:536: void aedis::detail::reader_op >::operator()(Self &, boost::system::error_code, std::size_t) [Conn = aedis::connection<>, Self = boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::experimental::detail::parallel_group_op_handler >, boost::asio::detail::composed_work , boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::detail::as_tuple_handler >>, void (boost::system::error_code)>, void (boost::system::error_code)>, (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:358:13), (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:359:13), (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:360:13), (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:361:13)>, void (boost::system::error_code)>]: Assertion !conn->read_buffer_.empty()' failed.\n`","known_context_document_ids":["gh_issue_1382432703"],"reference_answer":"All forms of cancellation are now supported, for example, implicit with operator || and && or explicit with the cancel member function.","answer_document_id":"gh_comment_1288109993","silver_evidence_path":["gh_comment_1264578732","gh_issue_1393678666","gh_comment_1288109993"],"evidence_issue_ids":[1382432703,1393678666],"source_repo_name":"mzimbres/aedis","source_issue_id":1382432703,"source_issue_number":28,"source_issue_url":"https://github.com/mzimbres/aedis/issues/28","target_repo_name":"mzimbres/aedis","target_issue_id":1393678666,"target_issue_number":32,"target_issue_url":"https://github.com/mzimbres/aedis/issues/32","reference_anchor_document_id":"gh_comment_1264578732","reference_answer_author":"mzimbres","reference_answer_author_association":"OWNER","quality_score":85.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0714,"anchor_target_overlap":0.2143,"target_answer_overlap":0.4167},"issue_created_at":"2022-09-22T13:13:05+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1382432703","fragment_type":"issue_description","sequence":0,"text":"Assertion fails if cancellation is requested before connection establish\nIt seems when we send cancellation signal during the connection phase this assertion fails.\ni'm using URL \n`\n: ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:536: void aedis::detail::reader_op >::operator()(Self &, boost::system::error_code, std::size_t) [Conn = aedis::connection<>, Self = boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::experimental::detail::parallel_group_op_handler >, boost::asio::detail::composed_work , boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::detail::as_tuple_handler >>, void (boost::system::error_code)>, void (boost::system::error_code)>, (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:358:13), (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:359:13), (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:360:13), (lambda at ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:361:13)>, void (boost::system::error_code)>]: Assertion !conn->read_buffer_.empty()' failed.\n`","author_login":"nejati-deriv","author_association":"NONE","created_at":"2022-09-22T13:13:05+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1255046863","fragment_type":"issue_comment","sequence":1,"text":"You can easily reproduce it with simple loop like:\n\nC++\nfor (;;)\n{\n auto timer = asio::steady_timer{ executor, std::chrono::milliseconds{ 10 } };\n co_await (connection.async_run(endpoint, asio::use_awaitable) || timer.async_wait(asio::use_awaitable));\n}","author_login":"nejati-deriv","author_association":"NONE","created_at":"2022-09-22T13:44:12+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255214596","fragment_type":"issue_comment","sequence":2,"text":"Thanks for reporting. Aedis was designed to provide built-in timeouts. The call to \n\nco_await (connection.async_run(endpoint, asio::use_awaitable) || timer.async_wait(asio::use_awaitable));\n\nis probably messing around with the internal operations in a way I did not test before. I am considering disabling this type of cancellation unless there is a reason for not doing so. I want to avoid every user implementing timeouts on their side over and over again. For all possible timeouts see URL","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-09-22T15:43:14+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255230385","fragment_type":"issue_comment","sequence":3,"text":"Timeout here is just for demonstration, I'm not using timers like that I just cancel the connection for other reasons.\nPoint is that async_run is not can cancellable properly.","author_login":"ashtum","author_association":"NONE","created_at":"2022-09-22T15:56:27+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255238611","fragment_type":"issue_comment","sequence":4,"text":"Timeout here is just for demonstration, I'm not using timers like that I just cancel the connection for other reasons.\nPoint is that async_run is not can cancellable properly.","author_login":"ashtum","author_association":"NONE","created_at":"2022-09-22T16:03:18+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255274488","fragment_type":"issue_comment","sequence":5,"text":"How are you cancelling, with `connection::cancel(operation::run)`? Do you observe the same behaviour if you cancel like this\n\ntimer.async_wait(&{conn.cancel(operation::run)})\n\nI will investigate this issue on the weekend.","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-09-22T16:32:24+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255286246","fragment_type":"issue_comment","sequence":6,"text":"Haven't test that, but because I am using it in coroutines, it needs to be cancellable because even if I use current coroutines cancellation slot it will get overwritten by `co_await conn.async_run(...)`","author_login":"ashtum","author_association":"NONE","created_at":"2022-09-22T16:43:47+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1256921527","fragment_type":"issue_comment","sequence":7,"text":"I can't reproduce the crash with this\n\n#include \n#include \n\n#include \n#include \n#include \n#include \n\nnamespace net = boost::asio;\nusing namespace net::experimental::awaitable_operators;\nusing aedis::endpoint;\nusing connection = aedis::connection<>;\n\nnet::awaitable reconnect(std::shared_ptr db)\n{\n net::steady_timer timer{co_await net::this_coro::executor};\n for (;;) {\n timer.expires_after(std::chrono::milliseconds{10});\n endpoint ep{\"127.0.0.1\", \"6379\"};\n co_await (\n db->async_run(ep, net::use_awaitable) ||\n timer.async_wait(net::use_awaitable)\n );\n std::cout (ioc);\n net::co_spawn(ioc, reconnect(db), net::detached);\n ioc.run();\n}","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-09-24T09:25:13+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1256922905","fragment_type":"issue_comment","sequence":8,"text":"The crash on line `: ~/third_party/aedis/include/aedis/detail/connection_ops.hpp:536` is not possible on a normal cancellation. I am afraid this is indicating a buffer overflow somewhere in your program. Can you please enable sanitizers? For example, I get a crash if I use\n\n co_await (\n db->async_run({\"127.0.0.1\", \"6379\"}, net::use_awaitable) ||\n timer.async_wait(net::use_awaitable)\n );\n\ninstead of\n\n endpoint ep{\"127.0.0.1\", \"6379\"};\n co_await (\n db->async_run(ep, net::use_awaitable) ||\n timer.async_wait(net::use_awaitable)\n );","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-09-24T09:29:51+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257225375","fragment_type":"issue_comment","sequence":9,"text":"I can reproduce the with your code here, it takes a lite time to happen (most of the times under 60 sec). some times it leads to that assertion fail some times dead lock.\nTry change the time form 10ms to 6ms it happens faster.\nAnd of course make sure you are in debug build.\nChanging timer to something low like 1ms leads to a new assertion fail:\n`test: ~/third_party/aedis/include/aedis/detail/net.hpp:101: void aedis::detail::resolve_op , boost::asio::basic_waitable_timer >::operator()(Self &, std::array , boost::system::error_code, boost::asio::ip::tcp::resolver::results_type, boost::system::error_code) [Resolver = boost::asio::ip::basic_resolver , Timer = boost::asio::basic_waitable_timer , Self = boost::asio::detail::composed_op , boost::asio::basic_waitable_timer >, boost::asio::detail::composed_work , boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::detail::awaitable_handler , void (boost::system::error_code)>, void (boost::system::error_code)>, void (boost::system::error_code, boost::asio::ip::basic_resolver_results )>]: Assertion (!ec2)&&(\"resolve_op: Incompatible state.\")' failed.`","author_login":"nejati-deriv","author_association":"NONE","created_at":"2022-09-25T16:08:07+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257231771","fragment_type":"issue_comment","sequence":10,"text":"The second assertion you found is something I thought was impossible to happen but does not represent a pre condition for my code to work. I will remove it since it can indeed happen. Thanks again for reporting.","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-09-25T16:43:51+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257276851","fragment_type":"issue_comment","sequence":11,"text":"This commit URL fixes the problems I could reproduce so far. There is still a problem though if use very short timeouts like 1ms, in this case it seems that the cancellation gets lost. I will have to investigate more.","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-09-25T20:49:33+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257483010","fragment_type":"issue_comment","sequence":12,"text":"Are you using the same commit that I mentioned in first comment?\nhere is another assertion fail:\n`\ntest: ~/third_party/aedis/include/aedis/resp3/detail/exec.hpp:133: void aedis::resp3::detail::exec_with_timeout_op , boost::asio::basic_waitable_timer , aedis::adapter::detail::general_aggregate >>, boost::asio::dynamic_string_buffer , std::allocator >>::operator()(Self &, std::array , boost::system::error_code, std::size_t, boost::system::error_code) [AsyncStream = boost::asio::basic_stream_socket , Timer = boost::asio::basic_waitable_timer , Adapter = aedis::adapter::detail::general_aggregate >>, DynamicBuffer = boost::asio::dynamic_string_buffer , std::allocator >, Self = boost::asio::detail::composed_op , boost::asio::basic_waitable_timer , aedis::adapter::detail::general_aggregate >>, boost::asio::dynamic_string_buffer , std::allocator >>, boost::asio::detail::composed_work , boost::asio::detail::composed_op >, boost::asio::detail::composed_work , boost::asio::detail::awaitable_handler , void (boost::system::error_code)>, void (boost::system::error_code, unsigned long)>]: Assertion (!ec2)&&(\"exec_with_timeout_op: Unexpected completion order.\")' failed.\n`\n\nMaybe using the following code helps to reproduce it faster:\n\nC++\n\n#include \n#include \n\n#include \n#include \n#include \n#include \n\nnamespace net = boost::asio;\nusing namespace net::experimental::awaitable_operators;\nusing aedis::endpoint;\nusing connection = aedis::connection<>;\n\nnet::awaitable \nreconnect()\n{\n auto executor = co_await net::this_coro::executor;\n auto db1 = connection{ executor };\n auto db2 = connection{ executor };\n auto db3 = connection{ executor };\n auto db4 = connection{ executor };\n auto timer = net::steady_timer{ executor };\n for (int i = 0;; i++)\n {\n timer.expires_after(std::chrono::milliseconds{ 10 });\n endpoint ep{ \"127.0.0.1\", \"6379\" };\n co_await (db1.async_run(ep, net::use_awaitable) || db2.async_run(ep, net::use_awaitable) ||\n db3.async_run(ep, net::use_awaitable) || db4.async_run(ep, net::use_awaitable) ||\n timer.async_wait(net::use_awaitable));\n std::cout << i << std::endl;\n }\n}\n\nint\nmain()\n{\n net::io_context ioc;\n net::co_spawn(ioc, reconnect(), net::detached);\n ioc.run();\n}","author_login":"nejati-deriv","author_association":"NONE","created_at":"2022-09-26T04:58:00+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1264578732","fragment_type":"issue_comment","sequence":13,"text":"I have created a new issue to improve cancellation support, see #32 so I will continue there. AFAICS, this ticket can be closed as the crashes have been fixed.","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-10-02T07:58:21+08:00","repo_name":"mzimbres/aedis","issue_id":1382432703,"issue_number":28,"issue_url":"https://github.com/mzimbres/aedis/issues/28","linked_issue_ids":[1393678666],"is_known_query_context":false},{"document_id":"gh_issue_1393678666","fragment_type":"issue_description","sequence":0,"text":"Improve support for cancellation\nAt the moment the `connection` classes provide support to cancellation with `cancel` member function. Although not common or even advisable, some users may want to cancel operations with timeouts like this\n\ncpp\nco_await (conn.async_run(...) || timer.async_wait(...));\n\nThis is working as long as the timeout is not too small e.g. `10ms`. To handle that properly Aedis need to improve cancelation support. Below some parts of a conversation I've had with Richard\n \n \n \n\ncpp\n// some code...\nasio::post(exec, some_next_step(std::move(my_handler));\n// cancellation happens here...\n// some_next_step will not know that the handler was cancelled unless it checks.\n// ...\n// ... some_next_step now executes...\n\ncpp\nvoid some_next_step(auto handler)\n{\n auto cs = get_canecllation_state(handler);\n if (cs.cancelled() != asio::cancellation_type::none)\n {\n complete(handler, operation_aborted);\n return;\n }\n // ... not cancelled\n}","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-10-02T07:55:32+08:00","repo_name":"mzimbres/aedis","issue_id":1393678666,"issue_number":32,"issue_url":"https://github.com/mzimbres/aedis/issues/32","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1288109993","fragment_type":"issue_comment","sequence":1,"text":"All forms of cancellation are now supported, for example, implicit with operator || and && or explicit with the cancel member function.","author_login":"mzimbres","author_association":"OWNER","created_at":"2022-10-23T13:11:08+08:00","repo_name":"mzimbres/aedis","issue_id":1393678666,"issue_number":32,"issue_url":"https://github.com/mzimbres/aedis/issues/32","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0429","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[QUESTION] \"Could not find prepared statement with handle 1\" - probably, it was fixed?","query_context":"## Question\n \nRandom exception: \"Could not find prepared statement with handle 1\", mssql-jdbc-11.2.3.jre11.jar\nProbably, it was fixed in latest versions?\n\nStack:\nCaused by: com.microsoft.sqlserver.jdbc.SQLServerException: Could not find prepared statement with handle 1.\n at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:265) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1676) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:620) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:540) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7620) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:3916) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:268) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:242) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeQueryInternal(SQLServerPreparedStatement.java:473) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerDatabaseMetaData.getResultSetFromStoredProc(SQLServerDatabaseMetaData.java:360) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerDatabaseMetaData.getResultSetWithProvidedColumnNames(SQLServerDatabaseMetaData.java:374) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerDatabaseMetaData.getIndexInfo(SQLServerDatabaseMetaData.java:1162) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n## Relevant Issues and Pull Requests","known_context_document_ids":["gh_issue_2203498485"],"reference_answer":"The 12.7 preview release is available. The next stable release to include this will either be the 12.6.2 hotfix and/or the 12.8 GA release. We have not finalized a date for the hotfix, but the GA can be expected at the end of July (July 31).","answer_document_id":"gh_comment_2101011289","silver_evidence_path":["gh_comment_2018565042","gh_issue_2196682312","gh_comment_2101011289"],"evidence_issue_ids":[2203498485,2196682312],"source_repo_name":"microsoft/mssql-jdbc","source_issue_id":2203498485,"source_issue_number":2362,"source_issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","target_repo_name":"microsoft/mssql-jdbc","target_issue_id":2196682312,"target_issue_number":2356,"target_issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","reference_anchor_document_id":"gh_comment_2018565042","reference_answer_author":"Jeffery-Wasty","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.375,"target_answer_overlap":0.1429},"issue_created_at":"2024-03-22T23:34:23+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2203498485","fragment_type":"issue_description","sequence":0,"text":"[QUESTION] \"Could not find prepared statement with handle 1\" - probably, it was fixed?\n## Question\n \nRandom exception: \"Could not find prepared statement with handle 1\", mssql-jdbc-11.2.3.jre11.jar\nProbably, it was fixed in latest versions?\n\nStack:\nCaused by: com.microsoft.sqlserver.jdbc.SQLServerException: Could not find prepared statement with handle 1.\n at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:265) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1676) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:620) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:540) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7620) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:3916) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:268) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:242) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeQueryInternal(SQLServerPreparedStatement.java:473) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerDatabaseMetaData.getResultSetFromStoredProc(SQLServerDatabaseMetaData.java:360) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerDatabaseMetaData.getResultSetWithProvidedColumnNames(SQLServerDatabaseMetaData.java:374) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n at com.microsoft.sqlserver.jdbc.SQLServerDatabaseMetaData.getIndexInfo(SQLServerDatabaseMetaData.java:1162) ~[mssql-jdbc-11.2.3.jre11.jar:?]\n## Relevant Issues and Pull Requests","author_login":"smesh","author_association":"NONE","created_at":"2024-03-22T23:34:23+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2203498485,"issue_number":2362,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2017423041","fragment_type":"issue_comment","sequence":1,"text":"Seems not to be fixed recently - I get the same errors randomly after some time since switching from 12.4.2.jre8 to 12.6.1.jre8\n\ncom.microsoft.sqlserver.jdbc.SQLServerException: Could not find prepared statement with handle 1.\nat com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:261)\nat com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1752)\nat com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:675)\nat com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:594)\nat com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7739)\nat com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:4384)\nat com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:293)\nat com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:263)\nat com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeQuery(SQLServerPreparedStatement.java:509)","author_login":"bhoeferlin","author_association":"NONE","created_at":"2024-03-25T08:04:09+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2203498485,"issue_number":2362,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2018565042","fragment_type":"issue_comment","sequence":2,"text":"hi @smesh\n\nthis looks like it might be related to #2356 could you please tell us what your connection string is?","author_login":"lilgreenbird","author_association":"MEMBER","created_at":"2024-03-25T17:48:07+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2203498485,"issue_number":2362,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","linked_issue_ids":[2196682312],"is_known_query_context":false},{"document_id":"gh_comment_2018648144","fragment_type":"issue_comment","sequence":3,"text":"Hi @lilgreenbird ,\nConnection url is: jdbc:sqlserver:// ;authentication=SqlPassword;DatabaseName= ;trustServerCertificate=true;SelectMethod=cursor","author_login":"smesh","author_association":"NONE","created_at":"2024-03-25T18:30:41+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2203498485,"issue_number":2362,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2019080996","fragment_type":"issue_comment","sequence":4,"text":"we have another issue relating to this that we are working on, we think it's related to the cache not being cleared. Can you pls try to disable prepared statement handle caching and see if that resolves your issue? if so, that's a temporary workaround for the issue for now. \n\ni.e. add `disableStatementPooling=false;statementPoolingCacheSize=0` to your connection string","author_login":"lilgreenbird","author_association":"MEMBER","created_at":"2024-03-25T23:09:00+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2203498485,"issue_number":2362,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2041638641","fragment_type":"issue_comment","sequence":5,"text":"Sorry for not replying, we could not try workaround in the production.","author_login":"smesh","author_association":"NONE","created_at":"2024-04-07T23:08:29+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2203498485,"issue_number":2362,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2362","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2196682312","fragment_type":"issue_description","sequence":0,"text":"Erroneously inserted rows with statement pooling enabled and when a Connection gets re-used from the ConnectionPool\n## Driver version\n\n \n com.microsoft.sqlserver \n mssql-jdbc \n 12.6.1.jre11 \n \n\n## SQL Server version\n\nMicrosoft SQL Server 2019 (RTM-CU18) (KB5017593) - 15.0.4261.1 (X64) \n Sep 12 2022 15:07:06 \n Copyright (C) 2019 Microsoft Corporation\n Developer Edition (64-bit) on Windows 10 Pro 10.0 (Build 19045: )\n\n## Client Operating System\nWindows 10 Pro\n\n## JAVA/JVM version\nJava 17\n\n## Problem description\nThere are some duplicate inserts and some missing entries when a custom connection pool is being utilized and server side statement pooling is enabled (using the setDisableStatementPooling flag). When the connection is re-used from the connection pool and the flag `setDisableStatementPooling is set to false` this issue seems to happen.\n\nTo test this instance, I was able to simulate a very basic stand alone as below :\nPlease see the following test program, where I intentionally return the previously created connection object from the _userToConnectionsMap cache map for subsequent runs. \n\nimport java.sql.Connection;\nimport java.sql.PreparedStatement;\nimport java.sql.SQLException;\nimport java.sql.Statement;\nimport java.util.Collection;\nimport java.util.Iterator;\nimport java.util.Map;\nimport java.util.concurrent.ConcurrentHashMap;\nimport java.util.concurrent.CopyOnWriteArrayList;\nimport java.util.concurrent.locks.ReentrantLock;\nimport java.util.logging.Level;\nimport java.util.logging.Logger;\nimport javax.sql.PooledConnection;\n\npublic class SQLConnectionPool {\n\n final private ReentrantLock _connLock = new ReentrantLock();\n final private Map _userToConnectionsMap = new ConcurrentHashMap();\n static String tableName = \"batchTest\";\n /**\n * Crate a new connection\n * \n * @return the new created connection\n * @throws SQLException When fail to create a new connection.\n */\n private Connection createNewConnection(final String username, final String password) throws SQLException {\n\n com.microsoft.sqlserver.jdbc.SQLServerConnectionPoolDataSource msDs = new com.microsoft.sqlserver.jdbc.SQLServerConnectionPoolDataSource();\n msDs.setUser(username);\n msDs.setApplicationName(\"SQL Server Duplicate Row\");\n msDs.setPassword(password);\n msDs.setServerName(\"<>\");\n msDs.setPortNumber(0);\n msDs.setDatabaseName(\"<>\");\n msDs.setInstanceName(\"<>\");\n msDs.setEncrypt(\"false\");\n msDs.setDisableStatementPooling(false);\n msDs.setStatementPoolingCacheSize(20);\n msDs.setServerPreparedStatementDiscardThreshold(20);\n msDs.setSendTemporalDataTypesAsStringForBulkCopy(false);\n // ... create the ACTUAL new connection...\n PooledConnection actual = msDs.getPooledConnection(username, password);\n // ... cache it...\n Collection conns = (Collection) _userToConnectionsMap.get(username);\n if (conns == null || conns.isEmpty()) {\n conns = new CopyOnWriteArrayList();\n _userToConnectionsMap.put(username, conns);\n }\n \n conns.add(actual);\n return actual.getConnection();\n }\n\n final public Connection getConnection(final String username, final String password)\n throws SQLException, InterruptedException {\n\n if (username == null) {\n throw new NullPointerException(\"The username cannot be null.\");\n }\n if (password == null) {\n throw new NullPointerException(\"The password cannot be null.\");\n }\n\n // Acquire a lock...\n _connLock.lock();\n // Declare the connection to be returned...\n Connection conn = null;\n try {\n\n conn = getAvailableConnection(username);\n // If none found...\n if (conn == null) {\n conn = createNewConnection(username, password);\n }\n// \n } finally {\n // Ensure that the lock is released...\n _connLock.unlock();\n }\n // Return the connection...\n return conn;\n }\n\n private Connection getAvailableConnection(final String username) throws SQLException {\n // Get the connections for the specified user...\n Collection conns = (Collection) _userToConnectionsMap.get(username);\n // If none found, then NO connections are available...\n if (conns == null || conns.isEmpty()) {\n return null;\n }\n // ... otherwise, check to see if any of the connections are available...\n boolean isAvailable = false;\n final Iterator iterator = conns.iterator();\n PooledConnection pconn = null;\n while (iterator.hasNext()) { \n pconn = (PooledConnection) iterator.next();\n\n return pconn.getConnection();\n // Is this connection available? ignore this check for this sample test\n \n }\n return null;\n }\n\n public static void main(String[] args) throws SQLException, ClassNotFoundException, InterruptedException {\n\n Logger logger = Logger.getLogger(\"com.microsoft.sqlserver.jdbc.Statement\");\n logger.setLevel(Level.FINER);\n Class.forName(\"com.microsoft.sqlserver.jdbc.SQLServerDriver\");\n\n SQLConnectionPool pool = new SQLConnectionPool();\n\n try {\n \n Connection conn = pool.getConnection(\"<>\", \"<>\");\n try (Statement stmt = conn.createStatement();) {\n\n String dropSql = \"if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[\" + tableName\n + \"]') and OBJECTPROPERTY(id, N'IsUserTable') = 1) DROP TABLE [\" + tableName + \"]\";\n stmt.execute(dropSql);\n\n String createSql = \"create table \" + tableName + \" (c1 int, c2 varchar(20))\";\n stmt.execute(createSql);\n }\n for (int j = 0; j \", \"<>\");\n conn.setAutoCommit(false);\n try (PreparedStatement pstmt = conn.prepareStatement(\"insert into \" + tableName + \" values (?, ?)\");) {\n for (int i = 0; i < 3; i++) {\n pstmt.setInt(1, i);\n pstmt.setString(2, \"test\" + i);\n pstmt.addBatch();\n }\n\n long start = System.currentTimeMillis();\n pstmt.executeBatch();\n conn.commit();\n long end = System.currentTimeMillis();\n\n System.out.println(\"Finished. Time taken : \" + (end - start) + \" milliseconds.\");\n }\n conn.close();\n }\n } finally {\n // nothing for this test\n }\n\n }\n}\n\nThis program results in incorrect entries being inserted to the test table with last item of the batch being repeated and the first item of the batch missed out.\n\n## Expected behavior\nCaching and connection pool shouldn't lead to incorrect insert to the table. Should see no duplicates and no missing rows.\n\n## Actual behavior\nAt the end of the stand alone program run, could see there are (2*j) - 1 = 9 rows instead of 5 rows for column c1 : 2 and (j-1) = 4 entries missing for column c1 : 0\n\nimage\n\n## Error message/stack trace\nWith FINER logging enabled for SQL driver , could see the following exception : `SQLException: com.microsoft.sqlserver.jdbc.SQLServerException: Could not find prepared statement with handle`\n\nimage\n\n## Any other details that can be helpful\n\nThis issue does not happen when I comment the call to `sp_reset_connection` in **SQLServerPooledConnection.java** \nimage\n\n## JDBC trace logs\nSQL Profiler data \n\nimage","author_login":"PriyadharshiniP","author_association":"CONTRIBUTOR","created_at":"2024-03-20T05:16:40+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2010953028","fragment_type":"issue_comment","sequence":1,"text":"hi @PriyadharshiniP \n\nthanks for the repro we can see the issue will be implementing a fix for this in the upcoming preview.","author_login":"lilgreenbird","author_association":"MEMBER","created_at":"2024-03-21T00:17:56+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2011226655","fragment_type":"issue_comment","sequence":2,"text":"Thanks for looking into this.\n\n1. Additionally, it appears that the following modifications to the `SQLServerPreparedStatement` : by resetting the `batchParam` value to fetch the metadata of first row(0) instead of the last row seems to prevent duplicates from happening in this case. \nBut not entirely sure of the consequences.\nPlease have a look as it may help you fix this issue :\nimage\n\n2. I'm also not clear why, when we re-use the same connection from the pool, a `Could not find prepared statement with handle exception is thrown`. I would really appreciate any clarifications to assist me better comprehend statement pooling.","author_login":"PriyadharshiniP","author_association":"CONTRIBUTOR","created_at":"2024-03-21T05:05:12+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2013967560","fragment_type":"issue_comment","sequence":3,"text":"I believe this is happening cos the cache is messed up. If I clear the preparedStatementHandleCache in resetPooledConnection() then this works. I'm just doing some testing now.","author_login":"lilgreenbird","author_association":"MEMBER","created_at":"2024-03-21T22:34:14+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2014340623","fragment_type":"issue_comment","sequence":4,"text":"I appreciate you committing the fix.\nIt appears to prevent duplicates from happening by creating a new prepared statement handler for every usage of same connection from the connection pool. But I don't fully understand this fix.\nI am aware that this statement pooling is per-connection and not server-wide.\nBut the prepared statement handler should be retained for re-using the connection having the same user name and password from pool : SQLServerPooledConnection , is it not ?\nIf statement caching was implemented and a connection pool was in use, it seems to be a waste in both client and server side and no real performance improvements with statement cache? \nPlease clarify.","author_login":"PriyadharshiniP","author_association":"CONTRIBUTOR","created_at":"2024-03-22T04:37:19+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2015713679","fragment_type":"issue_comment","sequence":5,"text":"Statement pooling is per connection, yes, but sp_reset_connection (resetPooledConnection) clears any prepared statements in the session on the server (among many other cleanup tasks). That's why you see the _Could not find prepared statement with handle_ error. Clearing the cache would keep the driver from re-using invalid prepared statement handles. But I'd be worried that the driver is executing some of the batch or consuming/flushing results on the wrong side of the pool use boundary. ExecuteBatch() should be executing and consuming all the results from the server immediately and I wonder if it's leaving some hanging until the next statement execution (which is happening after the connection goes back into and then comes out of the pool again).","author_login":"David-Engel","author_association":"CONTRIBUTOR","created_at":"2024-03-22T18:50:13+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2017217969","fragment_type":"issue_comment","sequence":6,"text":"Thanks for clarifying that the statement pooling is per connection and cannot be shared even when the connection is used , goes back and is re-used from pool. \nIt appears that the un prepare call is not being initiated explicitly, and presumably, there can still be a performance improvement if statement pooling and pooling are enabled.\n\nWith the fix under this issue, it seems to have fixed the corrupt client side prepared statement cache by clearing it when the connection gets re-used from the pool.\nBut I am still not sure, if there can be some duplicates or entries from a batch mistakenly inserted due to any other scenarios where there is a corrupt prepared statement cache or no server prepared handle with a retry. I cannot replicate such a scenario yet with 8179 and 586 exceptions. However it is in the exception handling, I think it may be possible.\nThe row in batchParam ought to have also been reset to the index of numBatchesPrepared rather than the last row if the retryBasedOnFailedReuseOfCachedHandle method returns true, right? I'm saying that there may still be instances where this exception stack trace occurs, and that the batch should be correctly retried.\nPlease advise.\nimage","author_login":"PriyadharshiniP","author_association":"CONTRIBUTOR","created_at":"2024-03-25T05:02:44+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2023706456","fragment_type":"issue_comment","sequence":7,"text":"yes we agree there may be other issues there we will take a closer look into this when we can, thanks","author_login":"lilgreenbird","author_association":"MEMBER","created_at":"2024-03-27T18:48:13+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2099710290","fragment_type":"issue_comment","sequence":8,"text":"Hi @lilgreenbird \nThanks for fixing. May I know when a stable release (12.7.0) for this be available ?","author_login":"PriyadharshiniP","author_association":"CONTRIBUTOR","created_at":"2024-05-08T04:19:58+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2101011289","fragment_type":"issue_comment","sequence":9,"text":"The 12.7 preview release is available. The next stable release to include this will either be the 12.6.2 hotfix and/or the 12.8 GA release. We have not finalized a date for the hotfix, but the GA can be expected at the end of July (July 31).","author_login":"Jeffery-Wasty","author_association":"MEMBER","created_at":"2024-05-08T16:55:33+08:00","repo_name":"microsoft/mssql-jdbc","issue_id":2196682312,"issue_number":2356,"issue_url":"https://github.com/microsoft/mssql-jdbc/issues/2356","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0430","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Don't pass test data to `.predict()`?","query_context":"@eschrom We talked about the possibility for `.augment_data()` to leak information about the future into models. But I'm realizing that `.predict()` explicitly takes the *test* data? Presumably this is something about target dates, but it's something we should change because (1) this is incompatible with doing prospective forecasts and (2) it's a real bad smell w.r.t. leakage.","known_context_document_ids":["gh_issue_2903630654"],"reference_answer":"This is a very useful mental framework. We should keep in mind that a refactor of the autoregressive model is imminent, after which (1) and (2) will be cleanly separable just like for the Hill model. The soon-to-be-refactored AR model will have parameters which govern the true latent incident uptake from week to week, and separate parameters which govern the observation process. Thus, in both cases, we will be able to use the $n$ posterior samples generated during fitting to produce retrospective estimates or future forecasts of true latent uptake, and then \"add\" observation uncertainty to that, using $k=1$ draws per posterior sample as you've suggested. Does this sound correct, @afmagee42?","answer_document_id":"gh_comment_2695924139","silver_evidence_path":["gh_comment_2714696032","gh_issue_2816566349","gh_comment_2695924139"],"evidence_issue_ids":[2903630654,2816566349],"source_repo_name":"CDCgov/cfa-immunization-uptake-projection","source_issue_id":2903630654,"source_issue_number":134,"source_issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/134","target_repo_name":"CDCgov/cfa-immunization-uptake-projection","target_issue_id":2816566349,"target_issue_number":110,"target_issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","reference_anchor_document_id":"gh_comment_2714696032","reference_answer_author":"eschrom","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2222,"target_answer_overlap":0.1389},"issue_created_at":"2025-03-07T18:09:06+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2903630654","fragment_type":"issue_description","sequence":0,"text":"Don't pass test data to `.predict()`\n@eschrom We talked about the possibility for `.augment_data()` to leak information about the future into models. But I'm realizing that `.predict()` explicitly takes the *test* data? Presumably this is something about target dates, but it's something we should change because (1) this is incompatible with doing prospective forecasts and (2) it's a real bad smell w.r.t. leakage.","author_login":"swo","author_association":"COLLABORATOR","created_at":"2025-03-07T18:09:06+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2903630654,"issue_number":134,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/134","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2707255929","fragment_type":"issue_comment","sequence":1,"text":"You are correct - `predict()` wants the test data so that it can adjust the user-specified target dates to match the closest target dates in the test data, during retrospective forecasting.\n\nNote that:\n1) When making prospective forecasts, the `forecast.py` script sets `test_data` to `None`, which is passed to `predict()` and is sensibly interpreted to mean that the user-specified target dates need not be adjusted at all.\n2) Inside `predict()`, `test_data` is _only_ passed to `augment_scaffold` for the purpose of (possibly) adjusting target dates; `test_data` has no influence on the uptake values that are predicted for those target dates.\n\nMaybe the appearance of passing `test_data` to `predict()` is not ideal, but I think the substance of it is fine.","author_login":"eschrom","author_association":"COLLABORATOR","created_at":"2025-03-07T19:35:49+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2903630654,"issue_number":134,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/134","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2707595897","fragment_type":"issue_comment","sequence":2,"text":"Agree, I don't have any concerns about the current work\n\nBut I do think it would be better to refactor (at some point) so that predict takes target dates, rather than something that looks like data about the future","author_login":"swo","author_association":"COLLABORATOR","created_at":"2025-03-07T22:15:18+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2903630654,"issue_number":134,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/134","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2714696032","fragment_type":"issue_comment","sequence":3,"text":"This is pertinent to the discussion that evolved in #110, and in particular sounds like an argument for Option 3 in URL","author_login":"afmagee42","author_association":"NONE","created_at":"2025-03-11T15:09:48+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2903630654,"issue_number":134,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/134","linked_issue_ids":[2816566349],"is_known_query_context":false},{"document_id":"gh_issue_2816566349","fragment_type":"issue_description","sequence":0,"text":"Separate fitting and forecasting seeds\nI think this is worth a separate discussion-- I think we might want separate fitting and prediction keys\n\nLike, I think it's fair for us to fit the model a small number of times (1? 3?) but then we'll want to draw a number of trajectories (100? 1000?).\n\nI want the same fitted model to produce the same trajectory when given the same input key.\n\nThere are some nice ways to generate child keys from a parent key.\n\n_Originally posted by @swo in URL","author_login":"swo","author_association":"COLLABORATOR","created_at":"2025-01-28T19:40:57+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2695436661","fragment_type":"issue_comment","sequence":1,"text":"To the extent that prediction requires drawing new values, then from first principles I think having it be key-configurable is a good idea?\n\nBut I think we're in a danger zone for confusion here and need to be careful about what we mean and what's being separated from what. There are two distinct data-conditioned sets of things which we can refer to with prediction:\n1. Draw observations from the observation model, this is the posterior predictive distribution. NumPyro provides this with `Predictive` (which also includes the prior predictive, but that's not data-conditioned).\n2. _Forecasting_ predictions; asking about what will happen in the future.\n\nThese aren't always neatly factorizable.\n\nAs of #125 with the Hill model, we have a model where they can be factorized. That model has a deterministic uptake curve and a model for how reality gets observed from it. For the Hill model, predictions about the latent true uptake in the future, that is (2) are deterministic given posterior samples, but that needn't be true in general. And for any time period, future or not, given the latent uptake (1) involves a \"new\" RNG call, in that if all you have are posterior samples, you can't just get this for free.\n\nThe autoregressive model, as currently implemented and as I understand it, hides this distinction by saying that what we've seen _is_ the uptake, so for the future (1) + (2) are the same, and in the past they're inapplicable.","author_login":"afmagee42","author_association":"NONE","created_at":"2025-03-03T20:12:45+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2695449054","fragment_type":"issue_comment","sequence":2,"text":"I suggest that the general easy mental model for thinking about this all is that the number of posterior predictive samples which is _natural_ for $n$ samples from the posterior distribution is\n1. $k n$, where we usually have $k = 1$ and draw one new observation per posterior sample. This is what stan does. (We can also \"thin\" if we need to here, and have $k 1$ and draw more.)\n2. $n$. This works both for models which do not have future randomness given the posterior (Hill) and which do (autoregressive). (Technically we could have more samples for models with additional randomness, but I don't think it's worth the headache.)","author_login":"afmagee42","author_association":"NONE","created_at":"2025-03-03T20:19:17+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2695924139","fragment_type":"issue_comment","sequence":3,"text":"This is a very useful mental framework. We should keep in mind that a refactor of the autoregressive model is imminent, after which (1) and (2) will be cleanly separable just like for the Hill model. The soon-to-be-refactored AR model will have parameters which govern the true latent incident uptake from week to week, and separate parameters which govern the observation process. Thus, in both cases, we will be able to use the $n$ posterior samples generated during fitting to produce retrospective estimates or future forecasts of true latent uptake, and then \"add\" observation uncertainty to that, using $k=1$ draws per posterior sample as you've suggested. Does this sound correct, @afmagee42?","author_login":"eschrom","author_association":"COLLABORATOR","created_at":"2025-03-04T01:07:47+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2697804584","fragment_type":"issue_comment","sequence":4,"text":"Yep. I'd say that in general the order of operations is relatively flexible, but my understanding of NumPyro is that (2) as post-processing is the natural fit. (In stan, it's in-MCMC with `generated quantities {}`.)\n\nWhich brings up one last consideration here, while there's in-progress refactoring: should (1) be done as part of the posterior sampling, or as post-processing. That is, should MCMC produce, for each sample, a latent true trajectory for _all times_ we will ever want to know the value, whether or not we have data for them?\n\nMy inclination is to say that we should do it as part of MCMC, if at all reasonable. For the cost of carrying around some extra variables in MCMC, it simplifies the post-processing greatly because all models only need to be able to draw from their likelihoods/observation models. It should also tend to make shapes more consistent, as a posterior for the same season will always have all parameters of the same length.","author_login":"afmagee42","author_association":"NONE","created_at":"2025-03-04T14:20:54+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2698565658","fragment_type":"issue_comment","sequence":5,"text":"Producing a latent true trajectory for all times we will ever care about could be a little tricky. We want the user to specify the exact time frame over which to make forecasts. For example, a user could request uptake to be forecasted weekly from March 3 2025 to June 2 2025, or from March 4 2025 to June 3 2025. These will differ slightly. So to be safe, each model would need MCMC to return a latent true trajectory with predicted uptake on every single day within each season.\n\n This is fine for the Hill model, but the AR model currently uses \"incident uptake one week ago\" to predict \"incident uptake this week.\" More precisely, the AR model uses \"the daily average uptake last week\" to predict \"the daily average uptake this week.\" As such, each observed data point predicts the next, without being fooled by the occasional non-7- (usually 6- or 8-) day interval between observations. So the AR model's notion of single days (rather than weeks) isn't as explicit as it would need to be, in order to do what you're suggesting.\n\nThis brings us to a conversation we've had in another channel - maybe the AR model should account for slight variations in the inter-observation intervals differently, instead of this \"daily average\" business I've been using. Perhaps the AR model should use \"incident uptake yesterday\" to predict \"incident uptake today.\" In this setting, a lot of data is \"missing\" - we have observations roughly once every 7 days rather than once every day - but it's simple enough for a model to generate predictions of uptake daily and yet to only be compared to observations weekly. Is this part of the AR refactor you have in mind, @afmagee?","author_login":"eschrom","author_association":"COLLABORATOR","created_at":"2025-03-04T18:39:19+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2701134959","fragment_type":"issue_comment","sequence":6,"text":"I am of several conflicting minds here.\n- I was under the impression that we really did have weekly data (with the occasional multi-week skip at the beginning) in which case a shift of a day's difference only should matter if that moves the start date/end date across a week boundary, so we shouldn't have to worry about daily at all.\n- Make it daily and don't worry about missing data too much. I agree that computing the weekly likelihood from daily data isn't that big a deal. On the other hand, this introduces a _lot_ of extra variables to sample for stochastic models, and worse off, they're going to be highly correlated in a block structure (the weekly data means that increasing one day's uptake will favor decreases in at least one other day).\n- Reframe the problem and change the model specs a smidge. Make the user say (1) when the observations are and (2) when they want forecasts for. No restrictions on when those are, other than \"within the season.\" Then make all models have to be able to deal with an irregular grid of observations.\n - This is clearly not a problem for something deterministic that lives in continuous time, like a Hill model.\n - For autoregressive models, some re-thinking is needed, but doable. Mostly it means that you'll not just have a mean model but also a variance model. Consider a model where the only thing that matters is the last observation's uptake. The mean model is $\\mu(t\\_{i + 1}) = \\beta u(t\\_i)$. The variance model is $\\sigma(t\\_{i + 1}) = \\sigma^2 (t\\_i - t\\_{i - 1})$. When all points are evenly spaced, we can remove the variance model for a constant variance. But when they're not, it says that while last time point's uptake is predictive of this time point's, the effect diminishes with distance. We'd have to work out some details on other bits, and make sure it all plays together. But again, it's doable.","author_login":"afmagee42","author_association":"NONE","created_at":"2025-03-05T14:38:53+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2701170522","fragment_type":"issue_comment","sequence":7,"text":"The irregular grid option is attractive for\n- Allowing us to get the shape fixed in advanced while trimming some extra baggage (daily predictions we'll never use)\n- Including \"just do daily\" as a special case.\n\nThe tradeoff being the bit of extra math in some cases, and that technically I think it makes some stochastic models inapplicable and/or wrong/incoherent. Because what we're really doing is approximating integrals/sums over the missing data, and that doesn't always add up to a nicely computable distribution on the next time point. But if we're thinking about an underlying discrete daily model, and everything is Gaussian, things may well integrate out such that there is an easy \"right\" thing that looks like the above. I can convince myself it's \"right\" for the model above when $\\beta = 1$, but I'm not _quite_ sure it's right otherwise. Anyways, whether or not it's technically incoherent as a stochastic process doesn't have the biggest bearing on whether it works as a prediction tool.","author_login":"afmagee42","author_association":"NONE","created_at":"2025-03-05T14:52:17+08:00","repo_name":"CDCgov/cfa-immunization-uptake-projection","issue_id":2816566349,"issue_number":110,"issue_url":"https://github.com/CDCgov/cfa-immunization-uptake-projection/issues/110","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0432","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[FP]: jackson-databind-2.13.2?","query_context":"### Package URl\n\npkg:maven/com.fasterxml.jackson.core/jackson-databind@2.13.2\n\n### CPE\n\ncpe:2.3:a:fasterxml:jackson-databind:2.13.2:*:*:*:*:*:*:* and cpe:2.3:a:fasterxml:jackson-modules-java8:2.13.2:*:*:*:*:*:*:*)\n\n### CVE\n\nCVE-2020-36518\n\n### ODC Integration\n\n_No response_\n\n### ODC Version\n\n7.0.1\n\n### Description\n\nFrom URL \n \n\nWhen reporting this CVE for jackson-databind 2.13.2 it seems like a false positive.","known_context_document_ids":["gh_issue_1181590386"],"reference_answer":"One final thing: I also went ahead and released `jackson-bom:2.13.2.1` just so that Gradle Module Metadata issue for `jackson-databind:2.13.2.1` SHOULD be fully resolved. So while there is also `2.13.2.2` of `jackson-databind` (with actual already valid GMM) it seems better not to leave 2.13.2.1 with dangling reference to non-existing module info.","answer_document_id":"gh_comment_1082617258","silver_evidence_path":["gh_comment_1079640365","gh_issue_678075273","gh_comment_1082617258"],"evidence_issue_ids":[1181590386,678075273],"source_repo_name":"jeremylong/DependencyCheck","source_issue_id":1181590386,"source_issue_number":4267,"source_issue_url":"https://github.com/jeremylong/DependencyCheck/issues/4267","target_repo_name":"FasterXML/jackson-databind","target_issue_id":678075273,"target_issue_number":2816,"target_issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","reference_anchor_document_id":"gh_comment_1079640365","reference_answer_author":"cowtowncoder","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2273,"anchor_target_overlap":0.2273,"target_answer_overlap":0.3462},"issue_created_at":"2022-03-26T08:26:17+08:00","valid_comment_count":68,"fragments":[{"document_id":"gh_issue_1181590386","fragment_type":"issue_description","sequence":0,"text":"[FP]: jackson-databind-2.13.2\n### Package URl\n\npkg:maven/com.fasterxml.jackson.core/jackson-databind@2.13.2\n\n### CPE\n\ncpe:2.3:a:fasterxml:jackson-databind:2.13.2:*:*:*:*:*:*:* and cpe:2.3:a:fasterxml:jackson-modules-java8:2.13.2:*:*:*:*:*:*:*)\n\n### CVE\n\nCVE-2020-36518\n\n### ODC Integration\n\n_No response_\n\n### ODC Version\n\n7.0.1\n\n### Description\n\nFrom URL \n \n\nWhen reporting this CVE for jackson-databind 2.13.2 it seems like a false positive.","author_login":"kajh","author_association":"NONE","created_at":"2022-03-26T08:26:17+08:00","repo_name":"jeremylong/DependencyCheck","issue_id":1181590386,"issue_number":4267,"issue_url":"https://github.com/jeremylong/DependencyCheck/issues/4267","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1079640365","fragment_type":"issue_comment","sequence":1,"text":"Hello, :wave: \n\nThis does not looks like a false positive to me. The vulnerability has been acknowledged by the jackson-databind contributors and they are actively working on it. A fix has been integrated in version `2.13.2.1`, `2.13.2` is considered to be impacted. Please see URL","author_login":"nhumblot","author_association":"CONTRIBUTOR","created_at":"2022-03-26T08:33:26+08:00","repo_name":"jeremylong/DependencyCheck","issue_id":1181590386,"issue_number":4267,"issue_url":"https://github.com/jeremylong/DependencyCheck/issues/4267","linked_issue_ids":[678075273],"is_known_query_context":false},{"document_id":"gh_comment_1082850576","fragment_type":"issue_comment","sequence":2,"text":"Hi all 👋 please note that one more patch, `2.13.2.2`, has appeared.","author_login":"baldram","author_association":"NONE","created_at":"2022-03-30T09:39:59+08:00","repo_name":"jeremylong/DependencyCheck","issue_id":1181590386,"issue_number":4267,"issue_url":"https://github.com/jeremylong/DependencyCheck/issues/4267","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_678075273","fragment_type":"issue_description","sequence":0,"text":"Optimize `UntypedObjectDeserializer` wrt recursion [CVE-2020-36518]\n**EDIT**: related to to CVE-2020-36518 (see URL \n\n**EDIT**: Fix included in\n\n* 2.13.2.2 (see URL \n * use with `jackson-bom` version `2.13.2.20220328`\n * NOTE: ALSO included in `2.13.2.1` but there is a problem in Gradle Module Metadata declaration which is why `2.13.2.2` was released -- if not using GMM can use either\n* 2.12.6.1: (see URL \n * use with `jackson-bom` version `2.12.6.1.20220326`\n\n-----\n\nCurrent implementation `UntypedObjectDeserializer` is relatively expensive for deeply nested Object and Array values as it uses recursion even for \"vanilla\" case (one where there are no custom `List`/array or `Map` deserializers).\nIn practical terms it is possible to exhaust typical modest JVM heap sizes with documents having about ten thousand levels of nestings.\n\n*NOTE*: specifically this ONLY APPLIES if the target type is \"untyped\" or generic `Collection ` / `Map ` -- it DOES NOT APPLY to cases where target is POJO (except if POJO itself has \"untyped\" property or properties).\n\nSimilar issue was already solved wrt `JsonNode` (see #3397), included in 2.13.0; this might show a way to approach this problem: by replacing simple recursion with iteration, either completely or at some inner levels.\n\nAlso note that it may ultimately be necessary to have lower-level constraints for streaming parser too, see: URL \n\nIdeally it should be:\n\n1. Possible to handle at least tens of thousands of levels of nesting (100k should be processable with 256M heap, say)\n2. Have streaming level limits that -- by default -- block documents with more than limit we deem safe (less than 100k -- perhaps 10k or something, to be determined).\n\nThis issue is specifically about (1) as (2) is about `jackson-core`.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2020-08-13T01:12:31+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_673234512","fragment_type":"issue_comment","sequence":1,"text":"Looks like nesting of about 2000 works, 3000 fails, with default settings for both Arrays and Objects.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2020-08-13T03:41:39+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1034481647","fragment_type":"issue_comment","sequence":2,"text":"FWTW, similar issues does NOT affect `JsonNode`, as of Jackson 2.13.0 and later on.\nShould have created separate issue to point to, but iterate version of `JsonNodeDeserializer` was merged in at around March 2021.\nWould be great to achieve the same here for 2.14.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-02-10T04:29:04+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1065916119","fragment_type":"issue_comment","sequence":3,"text":"@cowtowncoder , could you please clarify if the same fix is planned to be backported to the versions `2.12.x` and `2.11.x` of Jackson?","author_login":"meier-th","author_association":"NONE","created_at":"2022-03-12T16:44:13+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066000457","fragment_type":"issue_comment","sequence":4,"text":"@meier-th Very unlikely that I would try to backport this to anything prior to 2.14.0. The new implementation probably has non-trivial chance of regression and this functionality is widely used. Note that no implementation yet exists, but I fully intend to work on this to try to get it done for 2.14.0 (or someone else could beat me to it).","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-13T01:30:23+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066543224","fragment_type":"issue_comment","sequence":5,"text":"@meier-th I'm sure that the same issue existing in `2.12.x` and `2.11.x`. May I know the fixing plan ? if the issue can only be fixed by upgrading to `2.14.x`, when do you plan to release this version ?","author_login":"AlvinYueChao","author_association":"NONE","created_at":"2022-03-14T09:11:42+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1067138541","fragment_type":"issue_comment","sequence":6,"text":"Oh fucking great. Someone decided to file an CVE for this one. \n\nSurely teaches me to file issues on things I want to work on -- and then some arsehole going to file an CVE.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-14T18:15:23+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1068804071","fragment_type":"issue_comment","sequence":7,"text":"I recommend that you simply throw some error if the nesting is to deep to cope with. You could improve the nesting depth later on, but you (and we users) will get rid of this annoying cve.","author_login":"wsdng","author_association":"NONE","created_at":"2022-03-16T07:07:30+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1069612114","fragment_type":"issue_comment","sequence":8,"text":"You could just add a try/catch around UntypedObjectDeserializer's entire deserialize method. The catch clause could just be:\n\n } catch (StackOverflowError soe) {\n throw new JsonMappingException(\"JSON is too deeply nested.\", soe);\n }\n \nThen instead of throwing an undeclared/unchecked runtime error (StackOverflowError), it throws a declared/checked JsonMappingException. That should mean anyone calling the function is actually catching the exception and hopefully doing something appropriate instead of letting their application fail in an unexpected way.\n\nI tested the above on the 2.13 branch - is it simple enough to just release that as a 2.13.3? I wasn't sure whether it would actually be appreciated or not so I didn't make a PR, and I'm not sure if there's other spots (or a better spot) to check for the StackOverflowError at. But I can confirm I did it locally and that it compiles. The currently failing test could be changed to expect a JsonMappingException instead of expecting an object to be returned.","author_login":"TaylorSMarks","author_association":"NONE","created_at":"2022-03-16T20:42:29+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1069675779","fragment_type":"issue_comment","sequence":9,"text":"First of all: thank you everyone for your ideas, input, help. Much appreciated!\n\n@wsdng That is one possibility, but due to statelessness of deserializers requires a bit of refactoring. It also would be better to add limits at streaming level (there is a separate issue there) but I do agree that there's timing issue where ideally this would be tackled first.\nSince I have the general idea -- of not having to use nesting counters -- from earlier `JsonNodeDeserializer` work all I need is time to work on this.\nI did consider simple (conceptually) counter approach earlier and only abandoned that since solving it in (IMO) better way by avoiding recursion. This is (I think) better esp. eventually when we get streaming level general limits.\n\n@TaylorSMarks unfortunately I don't think that approach is workable: by the time SOE is thrown the damage is done -- all catching would do would be to give slightly friendlier exception message.\nWhile that can be useful in itself (and POJO (de)serializers do this, I think) I don't think it helps us here, unfortunately.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-16T21:58:41+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1070839995","fragment_type":"issue_comment","sequence":10,"text":"Hey, thanks everyone and @cowtowncoder for this library.\n\nI just wanted comment that; unfortunately, our nexusiq instance started to fail our builds by this issue as indexed 7.5 HIGH severity. I think the only solution is to waive this CVE for now. \n\nBtw, still planned in 2.14? Not possible to patch only this issue in 2.13.3?","author_login":"memoricab","author_association":"NONE","created_at":"2022-03-17T12:01:53+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1071028624","fragment_type":"issue_comment","sequence":11,"text":"@cowtowncoder - I have approval to spend a day of company time on fixing this. Our company uses Black Duck for security scanning, which is flagging all versions of Jackson-databind for having this issue.\n\nI'm hoping for a solution that's simple enough to implement in a few hours, factoring in that I'm not particularly familiar with this project (I wrote a few custom deserializers a few weeks ago - that's the most exposure I had prior to downloading/compiling/running the tests so that I could make the PR last night.)\n\nFixes I can think of, in order of how simple they'd be to implement/test:\n\n1 - Catch the SOE and throw a checked exception. This should improve stability of the code calling it, but it has the issues you mentioned.\n\n2 - Add a counter, maybe to the DeserializationContext? Everytime we enter an array or object, increment the counter. When we return, decrement it. If the counter exceeds a predefined depth, throw an exception. What's a reasonable default for the max depth? 20? 100? 200? In the exception message mention how to configure it to allow for more deeply nested objects. This has the same benefits as what I did for the PR, and now additionally it means we intentionally limit how much resources are consumed by a malicious payload. The downside is there's some cost to having to keep track of how deep we are. The cost seems acceptable to me.\n\n3 - Don't make Vanilla.mapArray and Vanilla.mapObject separate methods - just include them straight in Vanilla.deserialize. I question the value of even mentioning this. It's hideous and decreases maintainability. The only positive thing to say about it is it doubles the maximum depth of the payload that can be handled before it throws a Stack Overflow Error.\n\n4 - Removing recursion. I suspect there's a lot of existing code that I haven't looked at that I'd need to understand and rework to do this. I think it's worth pointing out that, like #3 above, this doesn't really fix the issue, though. You still have the potential to consume all available memory and then throw an OutOfMemory exception.\n\nI'm pretty sure the second of the options I listed is best from a security perspective. As soon as we realize it's not a serious payload, we're rejecting it, minimizing wasted resources and throwing a checked exception which the calling code will know they have to handle somehow. I'd probably also leave what I already did yesterday for the PR (the first of the proposals)... leaking a runtime exception if they set the parameter too high and they received a payload that's too big doesn't seem great.","author_login":"TaylorSMarks","author_association":"NONE","created_at":"2022-03-17T16:10:39+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1071125567","fragment_type":"issue_comment","sequence":12,"text":"Ok, starting in reverse order.\n\n2.13.3. I guess due to high visibility, it may be necessary, despite non-trivial regression risk.\nRelease takes 2-4 hours for me; Jackson currently is not part of my daytime job. So it's weekend voluntary work for me, essentially. If and when CVE was solved I'd say 3-10 days after that.\nWell, except... this would qualify for a micro-patch, 2.13.2.1. That can be released much faster since it is only 2 repos (Jackson-databind and Jackson-bom). I think that'd be the way to go.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-17T17:29:20+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1071134406","fragment_type":"issue_comment","sequence":13,"text":"As to suggested approaches, my initial quick thoughts:\n\n1. Not worth pursuing, IMO.\n2. Something I have considered and may be viable -- selecting default value is problematic indeed; making it configurable even bigger issue since there's no clean API to extend. AND if this is temporary... in fact I would leave it non-configurable altogether at first, waiting for better solution IF this was pursued\n3. Yeah just doubling does not really seem like worth the effort.\n4. This is the approach I would take (and am planning to take): have a look at `JsonNodeDeserializer` which did this for 2.13; can contrast with earlier (2.12) implementation.\n\nAs to (4) \"not fixing\", I agree and disagree. Correct, fundamentally one can still run out of resources with big enough input. But to me the initial point is that there is difference between say, \"only 2000 levels\" (document of 2000 characters) and something like \"only 1 million levels\" (megabyte document). So this fix would change the nature of problem; you cannot just send a small document, you need to be able to send a very much bigger one.\n\nBut I think bigger reason why I think this makes sense is that I think that fundamentally limits for document aspects should go through this:\n\n URL \n\nso that the ultimate protection is via global document limits (\"maximum nesting: 10,000 levels\"), but we also make default deserializers more robust to let us keep the default document limits rather loose.\n\nSo: I'd go for (4), similar to handling of `JsonNode`: and for 2.14 try to get general document limits for streaming parser.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-17T17:38:13+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1071316282","fragment_type":"issue_comment","sequence":14,"text":"@cowtowncoder - This PR has changed from just catching a Stack Overflow Error and rethrowing a JsonMappingException to instead tracking the nesting depth and throwing if it's \"Too Deep\".\n\n256 was chosen as the max depth. It's mostly arbitrary. I looked into the maximum folder depth allowed on different platforms - it's less than 130 on Windows, less than 512 on macOS. I don't hear people complaining that they can't nest their folders any deeper on Windows, so... I figured 256 was a safe maximum depth for json.\n\nThe unit tests were updated. It'll verify that 250 nested arrays or objects will deserialize properly. It verifies that 300 nested arrays or objects throws a JsonParseException.","author_login":"TaylorSMarks","author_association":"NONE","created_at":"2022-03-17T19:55:51+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073244902","fragment_type":"issue_comment","sequence":15,"text":"To be honest, I don't see how this is a CVE for only Jackson when both Gson and JSON-B have the same issue.\n\nI've created a small test program that creates a simple JSON string with only nested objects for any given depth, then tries with Jackson, Gson and JSON-B until there is a StackOverflowError.\n\n public static void main(String[] args) throws Exception {\n testJackson();\n testGson();\n testJson();\n }\n\n private static void testJackson() throws IOException {\n final int maxDepth = 10_000;\n for (int i = 2000; i map = new ObjectMapper().readValue(json, Map.class);\n map.size();\n } catch (StackOverflowError e) {\n System.out.printf(\"Jackson: %d%n\", i);\n return;\n }\n }\n System.out.printf(\"Jackson: no failure for depth %d%n\", maxDepth);\n }\n\n private static void testGson() {\n final int maxDepth = 10_000;\n for (int i = 2000; i map = new Gson().fromJson(json, Map.class);\n map.size();\n } catch (StackOverflowError e) {\n System.out.printf(\"Gson: %d%n\", i);\n return;\n }\n }\n System.out.printf(\"Gson: no failure for depth %d%n\", maxDepth);\n }\n\n private static void testJson() {\n final int maxDepth = 10_000;\n for (int i = 2000; i map = JsonbBuilder.create().fromJson(json, Map.class);\n map.size();\n } catch (StackOverflowError e) {\n System.out.printf(\"Json: %d%n\", i);\n return;\n }\n }\n System.out.printf(\"Json: no failure for depth %d%n\", maxDepth);\n }\n\n private static String createJson(int depth) {\n StringBuilder sb = new StringBuilder(10000);\n for (int i = 0; i < depth; i++) {\n sb.append(\"{\\\"m\\\":\");\n }\n sb.append(\"{}\");\n for (int i = 0; i < depth; i++) {\n sb.append('}');\n }\n return sb.toString();\n }\n\nUnsurprisingly, it's not just Jackson that fails but the others as well. Gson fails later, but it still fails. JSON-B fails at around the same depth.","author_login":"robtimus","author_association":"NONE","created_at":"2022-03-20T12:52:56+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073708077","fragment_type":"issue_comment","sequence":16,"text":"I can not understand why this becomes a CVE with a \"high\" rating.\nDOS attack, really?\nSuch a StackOverflow occurs after about 500ms when I try this here. Means an attacker would get the error after that time, which seems not to be too high for me. \nMinimal effort on flow control on the http level (which you need to have in place anyway!) is enough to mitigate this.\nOr do I miss something here?","author_login":"schlm3","author_association":"NONE","created_at":"2022-03-21T10:04:10+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073726186","fragment_type":"issue_comment","sequence":17,"text":"@schlm3 You can also exhaust some heap this way. However that will probably just lead to an error for the attacker also, not actual DoS for other users. I guess an attacker could open a connection, consume a large amount of memory in UntypedObjectDeserializer, and then keep it open for a while to put pressure on the heap that affects other users. But yes, the \"high\" CVSS availability impact that justifies the \"high\" CVSS for this vuln seems a bit far-fetched. (easy exploitability is true, though ofc most users aren't using the `UntypedObjectDeserializer` anyway so are not impacted)\n\nThe \"high\" rating for this vuln is more an issue with the limited info that can be crammed into a single CVSS score.","author_login":"yawkat","author_association":"MEMBER","created_at":"2022-03-21T10:23:18+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1074412071","fragment_type":"issue_comment","sequence":18,"text":"@schlm3 I am with you here, I don't quite understand the high rating. And like someone mentioned (I think? but can't see a reference), many other JSON libraries have similar challenges -- so theoretically similar CVE should be filed against GSON, Genson, fast-json, for relevant types (disclaimer: I have not tested personally which ones have similar problem, some might have checks). But the reason Jackson gets the first dibs is due to our popularity: the potential attack vector is bigger, so that's somewhat reasonable I guess. Underhanded compliment if you wish :)\n\nI have heard that some of the ratings are also auto-generated; or, almost as bad, just using submitters original suggestion with little validation. I sort of understand this in that fully grokking most important aspects is a lot of work, and the torrent of reports is high. It's bit like challenges patent application clerks face in evaluating if an app is actually novel invention -- not enough time to do proper searches; or as in here, dig in the code.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-21T20:59:39+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1074420525","fragment_type":"issue_comment","sequence":19,"text":"@abdullahali99 there is a plan (see PR #3416) which for practical reasons probably must be micro-patch like `2.13.2.1` of `jackson-databind` (along with matching `jackson-bom`).\nI hope to get it out some time this week. Really wish system did not cause these stupid fire drills for CVEs of dubious severity rating, but here we are :-)","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-21T21:09:10+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1074694388","fragment_type":"issue_comment","sequence":20,"text":"Merged the fix in for 2.13; left out for 2.14 and master (3.0) for now. Getting late, will try to get release out tomorrow.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-22T03:45:45+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1074918877","fragment_type":"issue_comment","sequence":21,"text":"@cowtowncoder I added that as a comment here first, but then decided that URL was a better place to place that comment, so I removed it here.\n\nI have reproduced this issue with Gson and JSON-B; the code snippet in that comment can easily be adapted to also test others.","author_login":"rob-spoor","author_association":"NONE","created_at":"2022-03-22T09:17:45+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075195156","fragment_type":"issue_comment","sequence":22,"text":"@cowtowncoder there is contradictory guidance in the market about your fix release version. Could you please clarify \"Merged the fix in for 2.13...\" Is 2.13.* vulnerable? What is the fix version number?","author_login":"jaime-castells","author_association":"NONE","created_at":"2022-03-22T13:41:17+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075197146","fragment_type":"issue_comment","sequence":23,"text":"@jaime-castells It has been merged into the 2.13 *branch*, but there has not been a 2.13 *release* yet. The release with the fix will be 2.13.3.","author_login":"yawkat","author_association":"MEMBER","created_at":"2022-03-22T13:42:57+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075679952","fragment_type":"issue_comment","sequence":24,"text":"Out of curiosity, do you think there will be a 2.12.6.1 with the fix? \nNot sure what your threshold is for micro-patches on 2.12, or if the 2.13 fix will even backport easily.\n URL","author_login":"zacthompson","author_association":"NONE","created_at":"2022-03-22T21:53:50+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075685524","fragment_type":"issue_comment","sequence":25,"text":"I'd really prefer not to have to backport this, but... based on past experiences I have a feeling I will cave in and do backport :-D\n2.12 branch is officially still open, unlike earlier ones. And I suspect `UntypedObjectDeserializer` can actually be merged without problems.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-22T22:01:47+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075761324","fragment_type":"issue_comment","sequence":26,"text":"@cowtowncoder thank you in advance for your time on this. How this CVE came about is a little ridiculous, and the severity it was given is not very defendable.\n@TaylorSMarks thank you for contributing URL \n\nMy one and only reason in replying: Open source is not a thankless job. You are appreciated. I checked both your profiles and neither has any way to donate, so this is currently what I have the ability to do.\n\nThank you!","author_login":"jeffhubLR","author_association":"NONE","created_at":"2022-03-22T23:49:41+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075912200","fragment_type":"issue_comment","sequence":27,"text":"Hi, Still facing this CVE alert, are there any plan to fix and release next version?\n URL","author_login":"Syed-Shahul-Hameed","author_association":"NONE","created_at":"2022-03-23T04:52:04+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1075913619","fragment_type":"issue_comment","sequence":28,"text":"@Syed-Shahul-Hameed more that I have to spend time on answering this question slower the release is. As soon as I find time -- this is a non-paid voluntary activity for me, alongside a real job and family -- I will make a release.\n\nIn the meantime I just hope users will eventually push back on security tool vendors that cause all of this stress and fake alarm: Security Circus at its worst.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-23T04:55:50+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1076386026","fragment_type":"issue_comment","sequence":29,"text":"I don't think that 'fake alarm' is appropriate. We were able to execute an DOS attack on a web application in a test system by using this attack vector.","author_login":"chrempl","author_association":"NONE","created_at":"2022-03-23T13:38:07+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1078828684","fragment_type":"issue_comment","sequence":30,"text":"Does the new 2.13.2.1 already contain the fix? Sorry, I've got to ask, as there are no release notes.","author_login":"rebbuh","author_association":"NONE","created_at":"2022-03-25T09:35:58+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1078850567","fragment_type":"issue_comment","sequence":31,"text":"@cowtowncoder : kudos for all the work regarding this nasty thing!\n\nYou mentioned a probable fix for 2.12. What are your current thoughts/plans for that?","author_login":"jensborrmann","author_association":"NONE","created_at":"2022-03-25T10:00:09+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1078866815","fragment_type":"issue_comment","sequence":32,"text":"Just quoting cowtowncoder: URL \n \n\nLeaving this here just in case someone hasn't noticed it: URL","author_login":"jorsol","author_association":"NONE","created_at":"2022-03-25T10:11:47+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[678075273],"is_known_query_context":false},{"document_id":"gh_comment_1079280481","fragment_type":"issue_comment","sequence":33,"text":"@rebbuh Yes, 2.13.2.1 does contain the fix. Micro-patch release notes are bit tricky to find as they are on minor version page like so:\n\n URL \n\nbut I will update fixed-in version of this issue.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-25T18:13:26+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079289843","fragment_type":"issue_comment","sequence":34,"text":"On 2.12.6.1: I will do that, it is only a question of finding time. Right now my time for OSS is limited and although getting this version out is the highest priority item, it has to compete with paying work and family and my personal health (I'm fine, not to worry -- and aim to stay that way! -- but it all takes work).\n\nSo please be patient: I will update this issue, Tweet, once version is out.\n\nIn the meantime, anyone able to is recommended to use 2.13.2.1 that is already out.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-25T18:25:29+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079363307","fragment_type":"issue_comment","sequence":35,"text":"We were able to update to 2.13.2.1 at my company without an issue.\n\nBlackDuck (OSS scanner tool) already recognizes that there is a version 2.13.2.1 and that it fixes the CVE, but the automatic scanner mistook it for being version 2.13.2, so we had to manually verify that we’re only using 2.13.2.1 and update the BlackDuck report to say that.\n\nTaylor","author_login":"TaylorSMarks","author_association":"CONTRIBUTOR","created_at":"2022-03-25T19:21:55+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079512532","fragment_type":"issue_comment","sequence":36,"text":"@TaylorSMarks or others, sorry to ask a noob question, but the 2.13.2.1 does not seem to be in the Maven central just yet, how can we upgrade to that micro patch version ?","author_login":"bbarman4u","author_association":"NONE","created_at":"2022-03-25T23:25:11+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079512953","fragment_type":"issue_comment","sequence":37,"text":"@bbarman4u it is on maven central. Only jackson-databind got an update though.","author_login":"yawkat","author_association":"MEMBER","created_at":"2022-03-25T23:26:15+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079521897","fragment_type":"issue_comment","sequence":38,"text":"Sorry for being lost, I see only the version update up to 2.13.2 here in the Maven Central, when we declare it explicitly in the Maven pom.xml also it does not resolve.\n\n URL \nimage","author_login":"bbarman4u","author_association":"NONE","created_at":"2022-03-25T23:52:31+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079579788","fragment_type":"issue_comment","sequence":39,"text":"@bbarman4u thank you. As to `jackson-bom`, for micro-patches its versioning differs because there is no full matching set of versions, so a timestamp-based fourth part is added: so in this case you can either:\n\n1. Use `jackson-bom` version `2.13.2` but override version for `jackson-databind`\n2. Use `jackson-bom` version `2.13.2.20220324` which does (1) essentially (everything else has version 2.13.2 but `jackson-databind` 2.13.2.1)","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-26T03:04:00+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079591766","fragment_type":"issue_comment","sequence":40,"text":"@cowtowncoder first, thanks a lot for your work! can i update only jackson-databind、jackson-core and jackson-annotations to 2.13.2(or 2.13.2.1), but let jackson-dataformat-xxx and jackson-module-xxx still 2.12.x. as 2.12.6.1 is still on the way, it is compatible to do this.","author_login":"zhanganyuan","author_association":"NONE","created_at":"2022-03-26T03:54:27+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079636341","fragment_type":"issue_comment","sequence":41,"text":"@zhanganyuan it depends on the module. Generally 2.12.x does not always work with 2.13.x. However sometimes it will work fine.","author_login":"yawkat","author_association":"MEMBER","created_at":"2022-03-26T08:05:16+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079726516","fragment_type":"issue_comment","sequence":42,"text":"@zhanganyuan As general guidance, no, you should NOT mix different minor versions; exception being that in certain directions you may use \"adjacent\" ones. In particular: \"lower\" component like `jackson-core` MAY have HIGHER minor version than \"higher level\" component. So what is expected to work (but not guaranteed) would be:\n\n* `jackson-core:2.13.x` but `jackson-databind:2.12.x`\n* `jackson-databind:2.12.x` but `jackson-dataformat-xx:2.11.x`\n\nbut the reverse is not likely to work.\n\nThat said I would strongly recommend attempting to align all minor versions.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-26T16:23:19+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079729960","fragment_type":"issue_comment","sequence":43,"text":"Quick note: I hope to release 2.12.6.1 today (2022-03-26) but there are some on-going discussions about use of `jackson-bom` (see URL that I think need to be resolved first. Stay tuned!","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-26T16:42:35+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079757262","fragment_type":"issue_comment","sequence":44,"text":"@cowtowncoder another thank you for your work on jackson-databind 2.13.2.1","author_login":"melahn","author_association":"NONE","created_at":"2022-03-26T19:13:09+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1079824029","fragment_type":"issue_comment","sequence":45,"text":"Jackson 2.12.6.1 released with jackson-bom 2.12.6.20220326: on its way to Maven Central now.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-27T02:51:51+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081037832","fragment_type":"issue_comment","sequence":46,"text":"If anyone knows how to submit an update to include exclusion for 2.12.6.1, that'd be great.\nI don't know how to do that and will focus on getting 2.13.2.2 out today.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-28T19:13:45+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081041508","fragment_type":"issue_comment","sequence":47,"text":"You can send an email to `cpe_dictionary@nist.gov` and ask them to amend the CPE list to reflect that 2.12.6.1 should not be affected.","author_login":"norrisjeremy","author_association":"NONE","created_at":"2022-03-28T19:17:05+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081046753","fragment_type":"issue_comment","sequence":48,"text":"I did that a few hours before I posted the above; they didn't respond.","author_login":"JoshDM","author_association":"NONE","created_at":"2022-03-28T19:22:18+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081067886","fragment_type":"issue_comment","sequence":49,"text":"I've at least submitted PR URL to improve CVE-2020-36518 with the 2.12 version fix.","author_login":"JoshDM","author_association":"NONE","created_at":"2022-03-28T19:46:21+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081075245","fragment_type":"issue_comment","sequence":50,"text":"Thank you @JoshDM. I think the omission is just due to update indicating 2.13.2.1 when 2.12.6.1 was not yet available.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-28T19:55:36+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081079320","fragment_type":"issue_comment","sequence":51,"text":"@JoshDM & @cowtowncoder got you guys updated on the GHSA. Thanks for the contributions 👍","author_login":"darakian","author_association":"NONE","created_at":"2022-03-28T19:58:41+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1081329356","fragment_type":"issue_comment","sequence":52,"text":"Finally found time to release:\n\n* `jackson-databind:2.13.2.2` with corrected GMM manifest\n* Optional `jackson-bom:2.13.2.20220328` bill-of-materials that includes version set that includes `jackson-databind:2.13.2.2` overrides over other `2.13.2` components\n\nPlease let me know if there are further issues; this SHOULD work with Gradle, similar to 2.12.6.1.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-29T02:17:23+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082110938","fragment_type":"issue_comment","sequence":53,"text":"@blazespinnaker nobody is questioning that people parse untrusted json (most people do!), and I'm sure quite a few of those use the affected deserializer. \n\nHowever, why do you think this is a DoS issue for those affected? The bug fixed here has the potential to throw a stack overflow exception, however that can be handled cleanly (and it *is* handled cleanly eg by app servers), so it is not at all clear how an attacker could cause DoS here. Just causing an error is not DoS, there's other ways to do that, you have to actually affect other users of the service.","author_login":"yawkat","author_association":"MEMBER","created_at":"2022-03-29T16:41:43+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082218353","fragment_type":"issue_comment","sequence":54,"text":"@yawkat That's good context, however this is what I read at the top:\n \n \n \n \n \n\nPerhaps that should be changed to reflect your perspective? I don't want to get into specifics, but I've done experimentation and the severity seems justified. I could be missing something though and would appreciate further techncial reassurance.","author_login":"blazespinnaker","author_association":"NONE","created_at":"2022-03-29T18:13:02+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082228480","fragment_type":"issue_comment","sequence":55,"text":"@cowtowncoder Agreed, the scanners are a pain because they are very dumb. I encourage folks to know their frameworks and use tools like opencve if they can.","author_login":"blazespinnaker","author_association":"NONE","created_at":"2022-03-29T18:23:29+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082616246","fragment_type":"issue_comment","sequence":56,"text":"@blazespinnaker Ah, good point on my bit misleading description: it gives impression that there is on-going memory retention which is... sort of not the case -- thread stack is exhausted, not heap, and the actual overload is bit different. And at the point of SOE memory retention will disappear.\nThis does not mean there is no possibility of DoS -- there is a way to cause excessive load with modest-sized documents -- but my description suggests a bigger problem.\n\nAnyone have suggestions for a better description; maybe something to copy from an existing issue? :)","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-30T04:43:24+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082617258","fragment_type":"issue_comment","sequence":57,"text":"One final thing: I also went ahead and released `jackson-bom:2.13.2.1` just so that Gradle Module Metadata issue for `jackson-databind:2.13.2.1` SHOULD be fully resolved. So while there is also `2.13.2.2` of `jackson-databind` (with actual already valid GMM) it seems better not to leave 2.13.2.1 with dangling reference to non-existing module info.","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-03-30T04:45:58+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082820065","fragment_type":"issue_comment","sequence":58,"text":"Wondering if there is a 2.13.3 version planned that includes fix for this issue?","author_login":"holgerhaag","author_association":"NONE","created_at":"2022-03-30T09:08:49+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083064944","fragment_type":"issue_comment","sequence":59,"text":"To add some context to my question about 2.13.3 - our pom.xml files are structured in a way (with properties) that assigns the same property (version) to all jackson dependencies. The version is never a range, but a fixed version. That can of course be changed, but we prefer fixed versions aiming for repeatable build results. I think we're not the only organization which structures pom.xml files that way.\n\nSo changing just one dependency to a slightly different version like 2.13.2.2 is of course possible, but requires some work and will have to be rolled back as soon as 2.13.3 (or 2.14.0) comes out. Otherwise we have to remember to keep two properties in sync in pom.xml file which we want to avoid.\n\nThen again, most important thing is that there is a fix for this CVE and I'd like to thank everybody who has contributed to that.","author_login":"holgerhaag","author_association":"NONE","created_at":"2022-03-30T12:14:28+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1083395414","fragment_type":"issue_comment","sequence":60,"text":"From NIST\n\nThank you for bringing this to our attention. We appreciate community input in order to provide the most accurate and up-to-date information as possible. After reviewing publicly available information, we have made the appropriate modifications to reflect that the affected versions are up to (excluding) 2.12.6.1 and from (including) 2.13.0 up to (excluding) 2.13.2.1. Please allow up to 24 hours for the changes to be reflected on the website and in the data feeds. \n\nV/r,\nCommon Platform Enumeration Team\ncpe_dictionary@nist.gov","author_login":"JoshDM","author_association":"NONE","created_at":"2022-03-30T17:05:23+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1095110794","fragment_type":"issue_comment","sequence":61,"text":"Hi, is this a typo mistake? I find the bom version of 2.12 mentioned above is `2.12.6.1.20220326`, but in the release notes it's `2.12.6.20220326`.\n\nimage","author_login":"yhs0092","author_association":"NONE","created_at":"2022-04-11T14:18:09+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097657875","fragment_type":"issue_comment","sequence":62,"text":"Hi @cowtowncoder, any way to determine if one is affected or not?\nYou write that UntypedObjectDeserializer needs to be used in combination with Collection / Map - at least this is what I understand. \nI scanned my code and we are not using UntypedObjectDeserializer, however, it might be used by other jackson-databind code that we use. Could you please clarify how to determine if one is affected by this CVE?","author_login":"MaximilianTews","author_association":"CONTRIBUTOR","created_at":"2022-04-13T07:34:50+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1099243440","fragment_type":"issue_comment","sequence":63,"text":"@cowtowncoder \n \nuse with jackson-bom version `2.12.6.1.20220326`\n\nthe version for the bom here looks incorrect, should be `2.12.6.20220326` ?","author_login":"jtnord","author_association":"NONE","created_at":"2022-04-14T14:26:50+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144478255","fragment_type":"issue_comment","sequence":64,"text":"Hi @cowtowncoder, could you please clarify what methods are affected by this vulnerability? I am specifically interested if ObjectMapper.readTree is affected?","author_login":"MaximilianTews","author_association":"CONTRIBUTOR","created_at":"2022-06-02T06:15:14+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1144612958","fragment_type":"issue_comment","sequence":65,"text":"readTree is not affected, readValue is affected if you use untyped fields somewhere in the object graph youre deserializing","author_login":"yawkat","author_association":"MEMBER","created_at":"2022-06-02T08:49:31+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1145012898","fragment_type":"issue_comment","sequence":66,"text":"@MaximilianTews see #2816 for more information. This is just a rewrite of that fix.\n\nAnd @yawkat is correct: `readTree()` is not affected. `readValue()` MAY be affected BUT ONLY if the nominal type is or includes target type of `java.lang.Object`. Term \"untyped\" in Jackson context means `java.lang.Object` as binding target type (either explicitly, or via raw types, `?` type parameter and so on).","author_login":"cowtowncoder","author_association":"MEMBER","created_at":"2022-06-02T15:42:59+08:00","repo_name":"FasterXML/jackson-databind","issue_id":678075273,"issue_number":2816,"issue_url":"https://github.com/FasterXML/jackson-databind/issues/2816","linked_issue_ids":[678075273],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0433","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Pi-hole admin pages will load in an iFrame, but table data will not (Invalid JSON response)?","query_context":"### Versions\n\n- Pi-hole: [v5.12.2]\n- AdminLTE: [v5.18.1]\n- FTL: [v5.15.1]\n\n### Platform\n\n- OS and version: Raspbian Buster\n\n- Platform: Raspberry Pi 4B\n\n### Expected behavior\n\nNormal functionality in an Organizr iFrame after commenting out \"X-Frame-Options\" => \"DENY\" in lighttpd.conf on the Pi-hole host machine.\n\n### Actual behavior / bug\n\nPi-hole AdminLTE pages will load, but table data will not. Also, if a password is enabled, one can never get past the login screen -- the login page just keeps reappearing. With the Pi-hole password disabled, any pages that contain table data generate an error of \"DataTables warning: table id=groupsTable - Invalid JSON response.\", or similar depending on which DataTable is applicable to a given AdminLTE page.\n\n### Steps to reproduce\n\nSteps to reproduce the behavior:\n\n1. Go to /etc/lighttpd/lighttpd.conf and comment out \"X-Frame-Options\" => \"DENY\" (as shown below), remove Pi-hole password using pihole -a -p\n\n# If the URL starts with /admin, it is the Web interface\n$HTTP[\"url\"] =~ \"^/admin/\" {\n # X-Pi-hole is a response header for debugging using curl -I\n # X-Frame-Options prevents clickjacking attacks and helps ensure your content is not embedded into other sites via , or .\n # X-XSS-Protection sets the configuration for the cross-site scripting filters built into most browsers. This is important because it tells the browser to block the response if a malicious script has been inserted from a user input.\n # X-Content-Type-Options stops a browser from trying to MIME-sniff the content type and forces it to stick with the declared content-type. This is important because the browser will only load external resources if their content-type matches what is expected, and not malicious hidden code.\n # Content-Security-Policy tells the browser where resources are allowed to be loaded and if it’s allowed to parse/run inline styles or Javascript. This is important because it prevents content injection attacks, such as Cross Site Scripting (XSS).\n # X-Permitted-Cross-Domain-Policies is an XML document that grants a web client, such as Adobe Flash Player or Adobe Acrobat (though not necessarily limited to these), permission to handle data across domains.\n # Referrer-Policy allows control/restriction of the amount of information present in the referral header for links away from your page—the URL path or even if the header is sent at all.\n setenv.add-response-header = (\n \"X-Pi-hole\" => \"The Pi-hole Web interface is working!\",\n# \"X-Frame-Options\" => \"DENY\",\n \"X-XSS-Protection\" => \"1; mode=block\",\n \"X-Content-Type-Options\" => \"nosniff\",\n \"Content-Security-Policy\" => \"default-src 'self' 'unsafe-inline';\",\n \"X-Permitted-Cross-Domain-Policies\" => \"none\",\n \"Referrer-Policy\" => \"same-origin\"\n\n2. Configure Pi-hole admin pages to load through an Organizr iFrame tab\n3. Click on 'Groups'\n4. See error\n\n## Debug Token\n\n- URL: \n\n URL \n\n### Screenshots\n\nScreenshot 2022-09-27 082202\n\n### Additional context\n\nOrganizr is such a great tool for organizing web-based setup pages for applications on one's LAN. Pi-hole isn't the only application that requires minor tweaks to work in an iFrame, but it would be nice to know what those tweaks are for full Pi-hole admin page functionality. Any help would be greatly appreciated!","known_context_document_ids":["gh_issue_1388070841"],"reference_answer":"At this moment in time its:\n\nroot@222b35f401b9:/# lighttpd -v\nlighttpd/1.4.53 (ssl) - a light and fast webserver\n\nSo you should be good to go\n\nThere are still a few things to look at around env vars before we can think about looking at this, but it is probably worth noting that `lighttpd` will be dropped in the future with Pi-hole 6.0 (no ETA) - so not 100% sure it's worth the work for this particular use case which has a perfectly adequate workaround in using `external.conf` for now","answer_document_id":"gh_comment_1010267713","silver_evidence_path":["gh_comment_1263760684","gh_issue_355637145","gh_comment_1010267713"],"evidence_issue_ids":[1388070841,355637145],"source_repo_name":"pi-hole/AdminLTE","source_issue_id":1388070841,"source_issue_number":2377,"source_issue_url":"https://github.com/pi-hole/AdminLTE/issues/2377","target_repo_name":"pi-hole/docker-pi-hole","target_issue_id":355637145,"target_issue_number":327,"target_issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","reference_anchor_document_id":"gh_comment_1263760684","reference_answer_author":"PromoFaux","reference_answer_author_association":"MEMBER","quality_score":95.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2727,"anchor_target_overlap":0.1212,"target_answer_overlap":0.0833},"issue_created_at":"2022-09-27T16:52:11+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_1388070841","fragment_type":"issue_description","sequence":0,"text":"Pi-hole admin pages will load in an iFrame, but table data will not (Invalid JSON response)\n### Versions\n\n- Pi-hole: [v5.12.2]\n- AdminLTE: [v5.18.1]\n- FTL: [v5.15.1]\n\n### Platform\n\n- OS and version: Raspbian Buster\n\n- Platform: Raspberry Pi 4B\n\n### Expected behavior\n\nNormal functionality in an Organizr iFrame after commenting out \"X-Frame-Options\" => \"DENY\" in lighttpd.conf on the Pi-hole host machine.\n\n### Actual behavior / bug\n\nPi-hole AdminLTE pages will load, but table data will not. Also, if a password is enabled, one can never get past the login screen -- the login page just keeps reappearing. With the Pi-hole password disabled, any pages that contain table data generate an error of \"DataTables warning: table id=groupsTable - Invalid JSON response.\", or similar depending on which DataTable is applicable to a given AdminLTE page.\n\n### Steps to reproduce\n\nSteps to reproduce the behavior:\n\n1. Go to /etc/lighttpd/lighttpd.conf and comment out \"X-Frame-Options\" => \"DENY\" (as shown below), remove Pi-hole password using pihole -a -p\n\n# If the URL starts with /admin, it is the Web interface\n$HTTP[\"url\"] =~ \"^/admin/\" {\n # X-Pi-hole is a response header for debugging using curl -I\n # X-Frame-Options prevents clickjacking attacks and helps ensure your content is not embedded into other sites via , or .\n # X-XSS-Protection sets the configuration for the cross-site scripting filters built into most browsers. This is important because it tells the browser to block the response if a malicious script has been inserted from a user input.\n # X-Content-Type-Options stops a browser from trying to MIME-sniff the content type and forces it to stick with the declared content-type. This is important because the browser will only load external resources if their content-type matches what is expected, and not malicious hidden code.\n # Content-Security-Policy tells the browser where resources are allowed to be loaded and if it’s allowed to parse/run inline styles or Javascript. This is important because it prevents content injection attacks, such as Cross Site Scripting (XSS).\n # X-Permitted-Cross-Domain-Policies is an XML document that grants a web client, such as Adobe Flash Player or Adobe Acrobat (though not necessarily limited to these), permission to handle data across domains.\n # Referrer-Policy allows control/restriction of the amount of information present in the referral header for links away from your page—the URL path or even if the header is sent at all.\n setenv.add-response-header = (\n \"X-Pi-hole\" => \"The Pi-hole Web interface is working!\",\n# \"X-Frame-Options\" => \"DENY\",\n \"X-XSS-Protection\" => \"1; mode=block\",\n \"X-Content-Type-Options\" => \"nosniff\",\n \"Content-Security-Policy\" => \"default-src 'self' 'unsafe-inline';\",\n \"X-Permitted-Cross-Domain-Policies\" => \"none\",\n \"Referrer-Policy\" => \"same-origin\"\n\n2. Configure Pi-hole admin pages to load through an Organizr iFrame tab\n3. Click on 'Groups'\n4. See error\n\n## Debug Token\n\n- URL: \n\n URL \n\n### Screenshots\n\nScreenshot 2022-09-27 082202\n\n### Additional context\n\nOrganizr is such a great tool for organizing web-based setup pages for applications on one's LAN. Pi-hole isn't the only application that requires minor tweaks to work in an iFrame, but it would be nice to know what those tweaks are for full Pi-hole admin page functionality. Any help would be greatly appreciated!","author_login":"bnhf","author_association":"NONE","created_at":"2022-09-27T16:52:11+08:00","repo_name":"pi-hole/AdminLTE","issue_id":1388070841,"issue_number":2377,"issue_url":"https://github.com/pi-hole/AdminLTE/issues/2377","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1263760684","fragment_type":"issue_comment","sequence":1,"text":"This appears to only be an issue when Organizr and Pi-hole are installed on different hosts. When they're on the same host, and particularly if installed in Docker containers, the TableData JSON errors disappear and so does the problem with the perpetual login screen -- so there's no need to disable the password.\n\nThis leaves only the need to change the X-Frame-Options in a way that survives updates, which for Docker installations is addressed here:\n\n URL","author_login":"bnhf","author_association":"NONE","created_at":"2022-09-30T16:09:38+08:00","repo_name":"pi-hole/AdminLTE","issue_id":1388070841,"issue_number":2377,"issue_url":"https://github.com/pi-hole/AdminLTE/issues/2377","linked_issue_ids":[355637145],"is_known_query_context":false},{"document_id":"gh_comment_1263782218","fragment_type":"issue_comment","sequence":2,"text":"This is a Feature Request.\n\nWe receive a high number of requests, but as a free open-source project run by volunteers we have very limited resources.\nPlease, we ask that you open your Feature Requests at our Discourse Forum.\n\nThank you for your understanding.\n\n---\n\n**Pi-hole links:**\n- Discourse Forum: URL \n- Documentation: URL \n- Feature Requests: URL","author_login":"rdwebdesign","author_association":"MEMBER","created_at":"2022-09-30T16:31:22+08:00","repo_name":"pi-hole/AdminLTE","issue_id":1388070841,"issue_number":2377,"issue_url":"https://github.com/pi-hole/AdminLTE/issues/2377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_355637145","fragment_type":"issue_description","sequence":0,"text":"Feature request to add frame options as docker env variable\nThis is a... \n\n- [x] Request for a new or modified feature\n- [ ] Issue trying to run the docker image\n- [ ] Issue trying to build / test / develop the docker image\n\n## Description\nI would like to embed the pi.hole/admin interface in an iframe inside Home Assistant. But the \"X-Frame-Options\" => \"DENY\" inside lighttpd conf is preventing this.\nI can't override it in external.conf as it won't allow a duplicate setting.\n\nCan this be added as a env variable that replaces the setting during docker start?","author_login":"oohlaf","author_association":"NONE","created_at":"2018-08-30T15:26:38+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_422415529","fragment_type":"issue_comment","sequence":1,"text":"Have you tried using a volume to overwrite the lighttpd conf?","author_login":"diginc","author_association":"MEMBER","created_at":"2018-09-18T14:27:29+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423653403","fragment_type":"issue_comment","sequence":2,"text":"Yes that would be one way to do it, but wouldn't it be nicer to be able to control it with a variable? That way any improvements to the main config would be kept on new releases without having to manually merge files.","author_login":"oohlaf","author_association":"NONE","created_at":"2018-09-21T19:55:16+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423690223","fragment_type":"issue_comment","sequence":3,"text":"I suppose it's not too difficult to add `sed -i '/X-Frame-Options/d' /etc/lighttpd/lighttpd.conf` controlled by an environment variable.\n\nUntil that happens, you could make a persistent customization that always runs on boot by adding the `sed` command to a bash script which is then volume mounted into the startup auto executed scripts folder. `-v :/etc/cont-init.d/10-my-prestart-script.sh`","author_login":"diginc","author_association":"MEMBER","created_at":"2018-09-21T22:46:20+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530414881","fragment_type":"issue_comment","sequence":4,"text":"So real work solution \n\n1. Create a file `allow-iframe.sh` on host machine \n\nshell\n#!/usr/bin/with-contenv bash\n\n# Remove header\nsed -i '/X-Frame-Options/d' /etc/lighttpd/lighttpd.conf\n\n# We stop it, watchdog will restart it with our conf\n/etc/init.d/lighttpd stop\n\n2. When you will start your docker image need to add a volume\n`... -v :/etc/cont-init.d/21-allow-iframe.sh`\n21 - because we have 20-start.sh which replace lighttpd.conf to new. And that is cause why need to restart the lighttpd service","author_login":"Toxblh","author_association":"NONE","created_at":"2019-09-11T14:46:44+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_531204967","fragment_type":"issue_comment","sequence":5,"text":"file would be owned by my user as its part of the git pull to that device, I am running OpenMediaVault so essentially debian 9, I will try to chown file to root and see what happens at work rn.","author_login":"shanehughes1990","author_association":"NONE","created_at":"2019-09-13T11:41:57+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_540667345","fragment_type":"issue_comment","sequence":6,"text":"@shanehughes1990 \n \n \n \n \n \n \n \n \n \n\nidk if it's just a typo or not, but take out the leading . on the line for the shell script and try that. you're not executing it from that line, you're simply copying it to the container (if I understand this correctly, i'm still pretty new to docker) and then it runs in order because of the 21. I setup this shell script in a config folder on the host and restarted the container using portainer, after adding this to the volume section and it worked a treat. make sure you've chmodded the script so that it's executable as well. \n\n<img width=\"966\" alt=\"Screen Shot 2019-10-10 at 10 23 53 AM\" src=\" URL","author_login":"kamikaze2112","author_association":"NONE","created_at":"2019-10-10T16:30:01+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_671037641","fragment_type":"issue_comment","sequence":7,"text":"Seconding this, an environment variable for setting this would be great.","author_login":"tommyalatalo","author_association":"NONE","created_at":"2020-08-09T11:01:35+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_672197187","fragment_type":"issue_comment","sequence":8,"text":"FYI, you can add this to your `external.conf` to overwrite the default setting:\n\n$SERVER[\"socket\"] == \":443\" {\n $HTTP[\"url\"] =~ \"^/admin/\" {\n # Allow framin (for my home-assistant)\n setenv.set-response-header += (\n \"X-Frame-Options\" => \"Allow\"\n )\n }\n}\n\nI have this with SSL. Should work if you change it to :80. I don't know lighttpd well enough to know of the $HTTP will work outside of the server block (didn't test it).\n\nAdd that to `external.conf` and mount it on start: \n\n volumes: \n - my-external.conf:/etc/lighthttpd/external.conf\n\nIt's a better solution than script using `sed`.","author_login":"guice","author_association":"NONE","created_at":"2020-08-11T18:57:56+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_680271182","fragment_type":"issue_comment","sequence":9,"text":"@guice as long as your answer is really great it doesn't work very well. \nCurrent Pi-Hole runs on Lighttpd **1.4.45** and _setenv.set-response-header_ is supported since **1.4.46** (!). So close... _add-response-header_ on the other hand throws an error because there's a duplicate.","author_login":"ipatalas","author_association":"NONE","created_at":"2020-08-25T21:09:08+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_680289668","fragment_type":"issue_comment","sequence":10,"text":"😬\n\nSorry. I'm using a local-install of Pihole on RasPi. I didn't even look at lighttpd versions. This is the method I'm using there, but admittedly, it's lighttpd 1.4.53.\n\nI just connected dots from there: external.conf is meant for external configurations, and you can mount it directly via docker. Didn't even think the `set-response-header` wouldn't work within the docker version due to _one_ (minor) version number. Sorry. :(","author_login":"guice","author_association":"NONE","created_at":"2020-08-25T21:57:14+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_680662566","fragment_type":"issue_comment","sequence":11,"text":"No worries, it's not your fault. It's really good, clean, solution. It just needs some time before we can use it 🙃 \n\nIn the meantime I think I need to fall back to mounting entire lighttpd.conf.","author_login":"ipatalas","author_association":"NONE","created_at":"2020-08-26T05:22:43+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_693525364","fragment_type":"issue_comment","sequence":12,"text":"Hi, just dropping an idea. As this is a long-standing issue (2 years!), while the environment variables might take longer to be reworked, could the DENY value be changed to SAMEORIGIN, so that at least we can iframe it inside the same homeassistant docker site? Or is there any drawback to not use sameorigin either?\nThanks.","author_login":"diamant-x","author_association":"NONE","created_at":"2020-09-16T16:39:59+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_782775829","fragment_type":"issue_comment","sequence":13,"text":"I did it, but it logs me off after loging in, any solution on that?","author_login":"jglezp","author_association":"NONE","created_at":"2021-02-21T01:11:30+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_801819594","fragment_type":"issue_comment","sequence":14,"text":"correct Docker-compose Volume Path is:\n`volumes: \n - ./my-external.conf:/etc/lighttpd/external.conf\n`","author_login":"scobby","author_association":"NONE","created_at":"2021-03-18T10:44:44+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1010254127","fragment_type":"issue_comment","sequence":15,"text":"If you use Nginx to reverse proxy a quick fix would be to add this line to it's location block:\n\n`proxy_hide_header X-Frame-Options;`","author_login":"STaRDoGG","author_association":"NONE","created_at":"2022-01-11T18:41:49+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1010267713","fragment_type":"issue_comment","sequence":16,"text":"At this moment in time its:\n\nroot@222b35f401b9:/# lighttpd -v\nlighttpd/1.4.53 (ssl) - a light and fast webserver\n\nSo you should be good to go\n\nThere are still a few things to look at around env vars before we can think about looking at this, but it is probably worth noting that `lighttpd` will be dropped in the future with Pi-hole 6.0 (no ETA) - so not 100% sure it's worth the work for this particular use case which has a perfectly adequate workaround in using `external.conf` for now","author_login":"PromoFaux","author_association":"MEMBER","created_at":"2022-01-11T18:59:04+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477955359","fragment_type":"issue_comment","sequence":17,"text":"I'm leaving this here for anyone that finds this solution later. You need to mount the .conf file to /etc/lighttpd/conf-enabled as mentioned in release 23.01","author_login":"maraid","author_association":"NONE","created_at":"2023-03-21T14:36:55+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049373046","fragment_type":"issue_comment","sequence":18,"text":"tried the solution mentioned by the @pralor-bot and it actually fixes a part of the problem: the PiHole UI is displayed in the iframe now (inside the home assistand GUI).\n\nHowever loggin in does not work - the login-screen will be displayed over and over again.\n\nDoes anyone has a suggestion ?","author_login":"Def3nder","author_association":"NONE","created_at":"2024-04-11T10:17:48+08:00","repo_name":"pi-hole/docker-pi-hole","issue_id":355637145,"issue_number":327,"issue_url":"https://github.com/pi-hole/docker-pi-hole/issues/327","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0435","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Bug: view on open sauced location?","query_context":"### Describe the bug\n\nWhen you open a profile that does not have a bio, the view on open source will not show. \n\n### Steps to reproduce\n\n1. go to your profile\n2. remove your bio \n3. refresh the page :) \n\n### Affected services\n\nbrowser-extension\n\n### Platforms\n\n_No response_\n\n### Browsers\n\n_No response_\n\n### Environment\n\n_No response_\n\n### Additional context\n\n_No response_\n\n### Code of Conduct\n\n- [X] I agree to follow this project's Code of Conduct\n\n### Contributing Docs\n\n- [ ] I agree to follow this project's Contribution Docs","known_context_document_ids":["gh_issue_1728707593"],"reference_answer":"For first contributors to work on this you can do the next: \n1. 🔍 Search for the keyword in the broken button (View On OpenSauced) \n2. 🤔 Try to understand the component and code written within it. \n3. 💭 Figure out where did we use this component Solution/spoiler 😄 The needed function: injectViewOnOpenSaucedButton \n4. 👍 When you find the function related to this component, you can add extra logic to check whether it's the same logged-in user profile. (you can do this by finding a unique selector for user profile) Solution/spoiler 😄 \nYou can do this by checking the Edit profile button, Solution/spoiler 😄 \nthe related class selector: js-profile-editable-edit-button\n \n \n\n@bdougie @Anush008 @diivi, what's your input about this? I am considering labeling it as a good-first-issue if it's clear and not blocking any business logic.","answer_document_id":"gh_comment_1556304165","silver_evidence_path":["gh_comment_1565416522","gh_issue_1718648839","gh_comment_1556304165"],"evidence_issue_ids":[1728707593,1718648839],"source_repo_name":"open-sauced/ai","source_issue_id":1728707593,"source_issue_number":146,"source_issue_url":"https://github.com/open-sauced/ai/issues/146","target_repo_name":"open-sauced/ai","target_issue_id":1718648839,"target_issue_number":97,"target_issue_url":"https://github.com/open-sauced/ai/issues/97","reference_anchor_document_id":"gh_comment_1565416522","reference_answer_author":"a0m0rajab","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.375,"target_answer_overlap":0.122},"issue_created_at":"2023-05-27T12:57:24+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_1728707593","fragment_type":"issue_description","sequence":0,"text":"Bug: view on open sauced location\n### Describe the bug\n\nWhen you open a profile that does not have a bio, the view on open source will not show. \n\n### Steps to reproduce\n\n1. go to your profile\n2. remove your bio \n3. refresh the page :) \n\n### Affected services\n\nbrowser-extension\n\n### Platforms\n\n_No response_\n\n### Browsers\n\n_No response_\n\n### Environment\n\n_No response_\n\n### Additional context\n\n_No response_\n\n### Code of Conduct\n\n- [X] I agree to follow this project's Code of Conduct\n\n### Contributing Docs\n\n- [ ] I agree to follow this project's Contribution Docs","author_login":"a0m0rajab","author_association":"MEMBER","created_at":"2023-05-27T12:57:24+08:00","repo_name":"open-sauced/ai","issue_id":1728707593,"issue_number":146,"issue_url":"https://github.com/open-sauced/ai/issues/146","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1565416522","fragment_type":"issue_comment","sequence":1,"text":"This is related to: URL and URL \n\n# Suggested solution: \n\n1. 🔍 find a unique identifier for the profile menu, by doing the next: \n2. 🕵️ inspect the profile page, the bio and the edit button. \n3. 👍 see if we can find a unique identifier to use it. \n4. 🏥 review the code and the JS query selector to use that identifier \n\n# Challenge\n\nLet this work on your profile and other people's profiles. \nFor your profile, it will be under the bio information on top of the edit profile, \nFor other people's profiles\n\n \n 😄 Hint \n\nYou might find a unique selector for the edit profile button \n Your own profile selector: show the selector \n\n`btn-block js-profile-editable-edit-button`\n\n \n \n Other people profile selector: \n\n`user-following-container`\n\n \n\n Use a condition maybe \nYou can check if the selector is not provided for your profile to trigger the selector for other people profiles, and add the button, in cases it will be need to be prepended.","author_login":"a0m0rajab","author_association":"MEMBER","created_at":"2023-05-27T13:14:05+08:00","repo_name":"open-sauced/ai","issue_id":1728707593,"issue_number":146,"issue_url":"https://github.com/open-sauced/ai/issues/146","linked_issue_ids":[1718648839],"is_known_query_context":false},{"document_id":"gh_comment_1574426779","fragment_type":"issue_comment","sequence":2,"text":"@amartya3ac, the issue is assigned to you. Feel free to take issues to check the contributor guide as well: \n\n URL","author_login":"a0m0rajab","author_association":"MEMBER","created_at":"2023-06-02T23:14:39+08:00","repo_name":"open-sauced/ai","issue_id":1728707593,"issue_number":146,"issue_url":"https://github.com/open-sauced/ai/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1643760127","fragment_type":"issue_comment","sequence":3,"text":"@diivi I have implemented the solution can you tell me how can i raise a pr and what all should I include ?","author_login":"Pratham-19","author_association":"NONE","created_at":"2023-07-20T11:32:34+08:00","repo_name":"open-sauced/ai","issue_id":1728707593,"issue_number":146,"issue_url":"https://github.com/open-sauced/ai/issues/146","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1718648839","fragment_type":"issue_description","sequence":0,"text":"Bug: odd location of view on open sauced\n### Describe the bug\n\nThe location of view profile on open sacued is okay on other pages, but it's odd on personal page here is a screenshot\n\nview of open sauced location\n\n### Suggestions: \n\nAdd a control to check if it's the personal page to add it on the right location, \n\n### Steps to reproduce\n\n1. open your own profile page.\n\n### Affected services\n\nbrowser-extension\n\n### Platforms\n\n_No response_\n\n### Browsers\n\n_No response_\n\n### Environment\n\n_No response_\n\n### Additional context\n\n_No response_\n\n### Code of Conduct\n\n- [X] I agree to follow this project's Code of Conduct\n\n### Contributing Docs\n\n- [ ] I agree to follow this project's Contribution Docs","author_login":"a0m0rajab","author_association":"MEMBER","created_at":"2023-05-21T21:39:36+08:00","repo_name":"open-sauced/ai","issue_id":1718648839,"issue_number":97,"issue_url":"https://github.com/open-sauced/ai/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1556304165","fragment_type":"issue_comment","sequence":1,"text":"For first contributors to work on this you can do the next: \n1. 🔍 Search for the keyword in the broken button (View On OpenSauced) \n2. 🤔 Try to understand the component and code written within it. \n3. 💭 Figure out where did we use this component Solution/spoiler 😄 The needed function: injectViewOnOpenSaucedButton \n4. 👍 When you find the function related to this component, you can add extra logic to check whether it's the same logged-in user profile. (you can do this by finding a unique selector for user profile) Solution/spoiler 😄 \nYou can do this by checking the Edit profile button, Solution/spoiler 😄 \nthe related class selector: js-profile-editable-edit-button\n \n \n\n@bdougie @Anush008 @diivi, what's your input about this? I am considering labeling it as a good-first-issue if it's clear and not blocking any business logic.","author_login":"a0m0rajab","author_association":"MEMBER","created_at":"2023-05-21T22:02:05+08:00","repo_name":"open-sauced/ai","issue_id":1718648839,"issue_number":97,"issue_url":"https://github.com/open-sauced/ai/issues/97","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560584532","fragment_type":"issue_comment","sequence":2,"text":"Done, feel free to ask for help if you got stuck or needed any support, good luck 👍","author_login":"a0m0rajab","author_association":"MEMBER","created_at":"2023-05-24T07:22:18+08:00","repo_name":"open-sauced/ai","issue_id":1718648839,"issue_number":97,"issue_url":"https://github.com/open-sauced/ai/issues/97","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0437","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Reference to `this` is unknown inside cloud.Api method definition?","query_context":"### Community Note\n \n \n\n### I tried this:\n\n`wing it`\n\nts\nbring cloud;\n\nclass TaskList { \n init() {\n }\n \n inflight add(title: str): str {\n let id = \"1\";\n return id;\n }\n}\n \nclass TaskListApi {\n api: cloud.Api;\n task_list: TaskList;\n \n init(task_list: TaskList) {\n this.task_list = task_list;\n this.api = new cloud.Api();\n \n this.api.post(\"/tasks\", inflight (req: cloud.ApiRequest): cloud.ApiResponse => {\n let id = this.task_list.add(\"title\");\n return cloud.ApiResponse { status:201, body: id };\n });\n }\n}\n\nlet task_list = new TaskList();\nlet t = new TaskListApi(task_list);\n\nThen in wing console I tried to `POST` to `/tasks` a simple request with `body: {\"title\": \"Yossarian\"}` and `content-type` header `application/json`.\n\n### I expected this:\n\nWing console to print: success.\n\n### Instead, this happened:\n\nsh\nevalmachine. :19\n async handle(req) { const { this } = this; {\n ^^^^\n\nSyntaxError: Unexpected token 'this'\n at new Script (node:vm:100:7)\n at createScript (node:vm:265:10)\n at Object.runInContext (node:vm:296:10)\n at /Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:238:149\n at new Promise ( )\n at n2t (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:9364)\n at Object.activity (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:8767)\n at Object.withTrace (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:238:8269)\n at XH.invoke (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:8689)\n at /Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:2531\n\n### Is there a workaround?\n\nYes, this seems to work (notice assignment of `self`):\n\nts\nbring cloud;\n\nclass TaskList { \n init() {\n }\n \n inflight add(title: str): str {\n let id = \"1\";\n return id;\n }\n}\n \nclass TaskListApi {\n api: cloud.Api;\n task_list: TaskList;\n \n init(task_list: TaskList) {\n this.task_list = task_list;\n this.api = new cloud.Api();\n\n let self = this;\n \n this.api.post(\"/tasks\", inflight (req: cloud.ApiRequest): cloud.ApiResponse => {\n let id = self.task_list.add(\"title\");\n return cloud.ApiResponse { status:201, body: id };\n });\n }\n}\n\nlet task_list = new TaskList();\nlet t = new TaskListApi(task_list);\n\nThis code now runs into a different issue #1969\n\n### Component:\n\nCompiler\n\n### Wing Version:\n\n0.8.26\n\n### Node.js Version:\n\n19.3.0\n\n### Platform(s):\n\nMacOS\n\n### Anything else?\n\n_No response_","known_context_document_ids":["gh_issue_1651890096"],"reference_answer":"@Chriscbr \n\nSince my technical knowledge here is very limited, it might be that this suggestion is really off, so please don't take me too seriously. \n\nWhat if we take a slightly different approach and treat all global variables as Root members making:\n1. Create a $FILE_ resource\n2. Put all code inside the init function\n3. transform all global `let`/`let var` statements into members\n5. Instantiate $FILE_ resource \n\nMaking this:\n\nts (wing)\nbring cloud;\n\nlet b = new cloud.Bucket();\n\nlet handler = inflight (payload: str) => {\n assert(b.list().length == 0);\n b.put(\"hello.txt\", \"world\");\n assert(b.list().length == 1);\n});\nnew cloud.Function(handler) as \"test:put\";\n\nInto this:\n\nts (wing)\nbring cloud;\n\nresource $FILE_AppW {\n b: cloud.Bucket;\n handler: inflight (str);\n init(){\n this.b = new cloud.Bucket();\n this.handler = inflight (payload: str) => {\n assert(this.b.list().length == 0);\n this.b.put(\"hello.txt\", \"world\");\n assert(this.b.list().length == 1);\n }; \n new cloud.Function(this.handler) as \"test:put\"; \n }\n \n}\nnew $FILE_AppW();\n\nThe above code doesn't work because of #1966 (and maybe other stuff) and I don't see how it solves your `TypeAnnotation` problem... so I don't know how useful it is for you 🤷","answer_document_id":"gh_comment_1512203533","silver_evidence_path":["gh_comment_1510351090","gh_issue_1572524251","gh_comment_1512203533"],"evidence_issue_ids":[1651890096,1572524251],"source_repo_name":"winglang/wing","source_issue_id":1651890096,"source_issue_number":1966,"source_issue_url":"https://github.com/winglang/wing/issues/1966","target_repo_name":"winglang/wing","target_issue_id":1572524251,"target_issue_number":1448,"target_issue_url":"https://github.com/winglang/wing/issues/1448","reference_anchor_document_id":"gh_comment_1510351090","reference_answer_author":"ekeren","reference_answer_author_association":"COLLABORATOR","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.5,"target_answer_overlap":0.2083},"issue_created_at":"2023-04-03T11:35:27+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1651890096","fragment_type":"issue_description","sequence":0,"text":"Reference to `this` is unknown inside cloud.Api method definition\n### Community Note\n \n \n\n### I tried this:\n\n`wing it`\n\nts\nbring cloud;\n\nclass TaskList { \n init() {\n }\n \n inflight add(title: str): str {\n let id = \"1\";\n return id;\n }\n}\n \nclass TaskListApi {\n api: cloud.Api;\n task_list: TaskList;\n \n init(task_list: TaskList) {\n this.task_list = task_list;\n this.api = new cloud.Api();\n \n this.api.post(\"/tasks\", inflight (req: cloud.ApiRequest): cloud.ApiResponse => {\n let id = this.task_list.add(\"title\");\n return cloud.ApiResponse { status:201, body: id };\n });\n }\n}\n\nlet task_list = new TaskList();\nlet t = new TaskListApi(task_list);\n\nThen in wing console I tried to `POST` to `/tasks` a simple request with `body: {\"title\": \"Yossarian\"}` and `content-type` header `application/json`.\n\n### I expected this:\n\nWing console to print: success.\n\n### Instead, this happened:\n\nsh\nevalmachine. :19\n async handle(req) { const { this } = this; {\n ^^^^\n\nSyntaxError: Unexpected token 'this'\n at new Script (node:vm:100:7)\n at createScript (node:vm:265:10)\n at Object.runInContext (node:vm:296:10)\n at /Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:238:149\n at new Promise ( )\n at n2t (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:9364)\n at Object.activity (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:8767)\n at Object.withTrace (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:238:8269)\n at XH.invoke (/Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:8689)\n at /Applications/Wing Console.app/Contents/Resources/app.asar/dist/vite/electron/main/index.js:237:2531\n\n### Is there a workaround?\n\nYes, this seems to work (notice assignment of `self`):\n\nts\nbring cloud;\n\nclass TaskList { \n init() {\n }\n \n inflight add(title: str): str {\n let id = \"1\";\n return id;\n }\n}\n \nclass TaskListApi {\n api: cloud.Api;\n task_list: TaskList;\n \n init(task_list: TaskList) {\n this.task_list = task_list;\n this.api = new cloud.Api();\n\n let self = this;\n \n this.api.post(\"/tasks\", inflight (req: cloud.ApiRequest): cloud.ApiResponse => {\n let id = self.task_list.add(\"title\");\n return cloud.ApiResponse { status:201, body: id };\n });\n }\n}\n\nlet task_list = new TaskList();\nlet t = new TaskListApi(task_list);\n\nThis code now runs into a different issue #1969\n\n### Component:\n\nCompiler\n\n### Wing Version:\n\n0.8.26\n\n### Node.js Version:\n\n19.3.0\n\n### Platform(s):\n\nMacOS\n\n### Anything else?\n\n_No response_","author_login":"staycoolcall911","author_association":"CONTRIBUTOR","created_at":"2023-04-03T11:35:27+08:00","repo_name":"winglang/wing","issue_id":1651890096,"issue_number":1966,"issue_url":"https://github.com/winglang/wing/issues/1966","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1494754860","fragment_type":"issue_comment","sequence":1,"text":"This is true for any inflight closure defined within a resource, not just API handlers.","author_login":"eladb","author_association":"CONTRIBUTOR","created_at":"2023-04-03T18:05:20+08:00","repo_name":"winglang/wing","issue_id":1651890096,"issue_number":1966,"issue_url":"https://github.com/winglang/wing/issues/1966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1510351090","fragment_type":"issue_comment","sequence":2,"text":"@Chriscbr please keep this ticket in mind when working on #1448","author_login":"staycoolcall911","author_association":"CONTRIBUTOR","created_at":"2023-04-16T11:59:03+08:00","repo_name":"winglang/wing","issue_id":1651890096,"issue_number":1966,"issue_url":"https://github.com/winglang/wing/issues/1966","linked_issue_ids":[1572524251],"is_known_query_context":false},{"document_id":"gh_comment_1564797067","fragment_type":"issue_comment","sequence":3,"text":"Tested this today, and calling the API currently causes a runtime error when I call the API in Wing Console: \"Unknown error: Missing environment variable: API_HANDLE_5f3a2e5e\"","author_login":"Chriscbr","author_association":"CONTRIBUTOR","created_at":"2023-05-26T18:53:23+08:00","repo_name":"winglang/wing","issue_id":1651890096,"issue_number":1966,"issue_url":"https://github.com/winglang/wing/issues/1966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1572524251","fragment_type":"issue_description","sequence":0,"text":"existing closure mechanism is causing permissive permissions\n### Community Note\n \n \n\n### Feature Spec\nGenerate custom resources from inflight closures\n\nts\nlet my_closure = (x: num) => {\n print(\"${x}\"); \n};\n\nWe would like the compiler to generate a custom resource with a single method from this closure. Modeling closures as resources will allow us to correctly handle all use cases of closures and jsify it correctly.\n\n### End consumer Impact\n\nThe way we calculate permissions is based on the resource (`this.*`) mechanism and this ticket is required in order to make sure that we do not give permissive permissions to resources when capturing them in this way:\n\nts (wing)\nlet b = new cloud.Bucket();\nnew cloud.Function(inflight () => {\n b.put(\"aa\", \"aaa\");\n});\n\nwill give all permissions for the bucket, while:\n\nts (wing)\nbring cloud;\nresource A impl cloud.IFunctionHandler {\n b: cloud.Bucket;\n init(b: cloud.Bucket) { this.b = b;}\n\n inflight handle() {\n this.b.put(\"aa\", \"aaa\");\n }\n}\nnew cloud.Function(new A(new cloud.Bucket()));\n\n \n\nwill give minimum permission\n\n### Use Cases\n\nFor example #1447 for an inflight closure instead of a resource method will work out of the box once #1447 is fixed.\n\n### Implementation Notes\n\n_No response_\n\n### Component\n\nCompiler","author_login":"staycoolcall911","author_association":"CONTRIBUTOR","created_at":"2023-02-06T12:58:50+08:00","repo_name":"winglang/wing","issue_id":1572524251,"issue_number":1448,"issue_url":"https://github.com/winglang/wing/issues/1448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479758846","fragment_type":"issue_comment","sequence":1,"text":"@staycoolcall911 , I am turning this into P1 (see End consumer Impact section in description for details)","author_login":"ekeren","author_association":"COLLABORATOR","created_at":"2023-03-22T15:15:30+08:00","repo_name":"winglang/wing","issue_id":1572524251,"issue_number":1448,"issue_url":"https://github.com/winglang/wing/issues/1448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1511677366","fragment_type":"issue_comment","sequence":2,"text":"The latest update is I've run into issues issues when trying to extend the transformation further to automatically \"close over\" free variables. The problem I found is that in order to do so, we would need to produce `TypeAnnotation` nodes in our AST for each referenced variable:\n\njs\nbring \"my_lib\" as my_lib_alias;\n\nlet foo = new my_lib_alias.Foo();\nlet bar = foo.bar; // type: constructs.Construct\n\n// before\nlet handler = inflight () => {\n log(bar.toString());\n};\n\n// after\nresource $Resource1 {\n bar: constructs.Construct; // PROBLEM\n init(bar: constructs.Construct) {\n this.bar = bar;\n }\n inflight handle(req: str): str {\n log(this.bar.toString());\n }\n}\nlet handler = new $Resource1(b);\n\nAt the line above labeled PROBLEM, we see that we need a type annotation for `constructs.Construct` (though in practice it could be any type really). The type checker has code for resolving `TypeAnnotation` into `Type`, but there isn't a safe way to convert arbitrary `Type` values into `TypeAnnotation` nodes without introducing new `bring` statements and so on. This would be pretty hairy.\n\nSo instead I'll try investigating how to solve #1447 so that the transformation doesn't need to close over any variables.","author_login":"Chriscbr","author_association":"CONTRIBUTOR","created_at":"2023-04-17T16:10:53+08:00","repo_name":"winglang/wing","issue_id":1572524251,"issue_number":1448,"issue_url":"https://github.com/winglang/wing/issues/1448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512203533","fragment_type":"issue_comment","sequence":3,"text":"@Chriscbr \n\nSince my technical knowledge here is very limited, it might be that this suggestion is really off, so please don't take me too seriously. \n\nWhat if we take a slightly different approach and treat all global variables as Root members making:\n1. Create a $FILE_ resource\n2. Put all code inside the init function\n3. transform all global `let`/`let var` statements into members\n5. Instantiate $FILE_ resource \n\nMaking this:\n\nts (wing)\nbring cloud;\n\nlet b = new cloud.Bucket();\n\nlet handler = inflight (payload: str) => {\n assert(b.list().length == 0);\n b.put(\"hello.txt\", \"world\");\n assert(b.list().length == 1);\n});\nnew cloud.Function(handler) as \"test:put\";\n\nInto this:\n\nts (wing)\nbring cloud;\n\nresource $FILE_AppW {\n b: cloud.Bucket;\n handler: inflight (str);\n init(){\n this.b = new cloud.Bucket();\n this.handler = inflight (payload: str) => {\n assert(this.b.list().length == 0);\n this.b.put(\"hello.txt\", \"world\");\n assert(this.b.list().length == 1);\n }; \n new cloud.Function(this.handler) as \"test:put\"; \n }\n \n}\nnew $FILE_AppW();\n\nThe above code doesn't work because of #1966 (and maybe other stuff) and I don't see how it solves your `TypeAnnotation` problem... so I don't know how useful it is for you 🤷","author_login":"ekeren","author_association":"COLLABORATOR","created_at":"2023-04-17T23:03:57+08:00","repo_name":"winglang/wing","issue_id":1572524251,"issue_number":1448,"issue_url":"https://github.com/winglang/wing/issues/1448","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1512274646","fragment_type":"issue_comment","sequence":4,"text":"Curious... I guess if we take that a step further and transform the handler, we could get something like this:\n\njs\nbring cloud;\n\nresource $FILE_AppW {\n b: cloud.Bucket;\n handler: inflight (str);\n init(){\n this.b = new cloud.Bucket();\n resource $Inflight1 {\n root: $FILE_AppW;\n init(root: $FILE_AppW) {\n this.root = root;\n }\n inflight handle(payload: str) {\n assert(this.root.b.list().length == 0);\n this.root.b.put(\"hello.txt\", \"world\");\n assert(this.root.b.list().length == 1);\n }\n }\n this.handler = new $Inflight1(this); // is passing `this` logical?\n new cloud.Function(this.handler) as \"test:put\";\n }\n \n}\nnew $FILE_AppW();\n\nIt does look like it could fix the problem I was describing with `Type`'s and `TypeAnnotation`'s since only one value needs to be passed into the constructor of `$Inflight1`, and the type of it is `$FILE_AppW` which we could calculate easily.\n\nBut I think the issue is by giving `$Inflight1` access to `this`, then all of the children resources' inflight clients also need to be bundled into the cloud function. So for example, suppose the user's app has other resources, like counters and queues and so on, and the particular inflight does not need to use them. Since `$Inflight1` has the entire app as a child resource (named `root`), it will need permissions for all the app's resources inflight, which defeats the purpose of least privilege permissions.\n\nI think the idea of having the app as a single resource is pretty interesting though, I will definitely keep it in my back pocket","author_login":"Chriscbr","author_association":"CONTRIBUTOR","created_at":"2023-04-18T00:29:16+08:00","repo_name":"winglang/wing","issue_id":1572524251,"issue_number":1448,"issue_url":"https://github.com/winglang/wing/issues/1448","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0438","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"d405 calibration issue?","query_context":"| | |\n|---|---|\n|**librealsense**|2.56.3 RELEASE|\n|**OS**|Windows|\n\nIntel RealSense Viewer / Depth Quality Tool has crashed with the following error message:\n\nUnhandled exception escaping from a worker thread!\nError type: Access Violation!","known_context_document_ids":["gh_issue_3082776098"],"reference_answer":"You are very welcome. It's great to hear that you had a successful outcome. Thanks very much for the update!","answer_document_id":"gh_comment_2818352786","silver_evidence_path":["gh_comment_2900634930","gh_issue_3007507777","gh_comment_2818352786"],"evidence_issue_ids":[3082776098,3007507777],"source_repo_name":"IntelRealSense/librealsense","source_issue_id":3082776098,"source_issue_number":14020,"source_issue_url":"https://github.com/IntelRealSense/librealsense/issues/14020","target_repo_name":"IntelRealSense/librealsense","target_issue_id":3007507777,"target_issue_number":13955,"target_issue_url":"https://github.com/IntelRealSense/librealsense/issues/13955","reference_anchor_document_id":"gh_comment_2900634930","reference_answer_author":"MartyG-RealSense","reference_answer_author_association":"COLLABORATOR","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1429,"target_answer_overlap":0.0},"issue_created_at":"2025-05-22T09:54:38+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_3082776098","fragment_type":"issue_description","sequence":0,"text":"d405 calibration issue\n| | |\n|---|---|\n|**librealsense**|2.56.3 RELEASE|\n|**OS**|Windows|\n\nIntel RealSense Viewer / Depth Quality Tool has crashed with the following error message:\n\nUnhandled exception escaping from a worker thread!\nError type: Access Violation!","author_login":"muxiddin19","author_association":"NONE","created_at":"2025-05-22T09:54:38+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3082776098,"issue_number":14020,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/14020","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2900634930","fragment_type":"issue_comment","sequence":1,"text":"Hi @muxiddin19 Please see URL for information about this error. Thanks!","author_login":"MartyG-RealSense","author_association":"COLLABORATOR","created_at":"2025-05-22T10:02:30+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3082776098,"issue_number":14020,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/14020","linked_issue_ids":[3007507777],"is_known_query_context":false},{"document_id":"gh_comment_2921355416","fragment_type":"issue_comment","sequence":2,"text":"Hi @muxiddin19 Do you require further assistance with this case, please? Thanks!","author_login":"MartyG-RealSense","author_association":"COLLABORATOR","created_at":"2025-05-30T06:25:35+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3082776098,"issue_number":14020,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/14020","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3007507777","fragment_type":"issue_description","sequence":0,"text":"on chip calibration error persist\n| | |\n|---|---|\n|**librealsense**|2.56.3 RELEASE|\n|**OS**|Windows|\n\nIntel RealSense Viewer / Depth Quality Tool has crashed with the following error message:\n\nUnhandled exception escaping from a worker thread!\nError type: Access Violation!","author_login":"Sangeethaj152","author_association":"NONE","created_at":"2025-04-21T04:06:45+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3007507777,"issue_number":13955,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/13955","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2817802000","fragment_type":"issue_comment","sequence":1,"text":"Hi @Sangeethaj152 Please first check whether permission to access the camera hardware and permission for applications to access the camera are both set to 'On' in the Windows camera privacy settings. This can be done using the instructions at URL \n\nIf you are able to enable the depth stream in the RealSense Viewer tool then an alternative to performing on-chip calibration to improve the calibration is to reset the camera in the Viewer to its factory-new default calibration using instructions at URL","author_login":"MartyG-RealSense","author_association":"COLLABORATOR","created_at":"2025-04-21T07:05:53+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3007507777,"issue_number":13955,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/13955","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2818352786","fragment_type":"issue_comment","sequence":2,"text":"You are very welcome. It's great to hear that you had a successful outcome. Thanks very much for the update!","author_login":"MartyG-RealSense","author_association":"COLLABORATOR","created_at":"2025-04-21T12:53:02+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3007507777,"issue_number":13955,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/13955","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2844380657","fragment_type":"issue_comment","sequence":3,"text":"Case closed due to solution achieved and no further comments received.","author_login":"MartyG-RealSense","author_association":"COLLABORATOR","created_at":"2025-05-01T08:33:26+08:00","repo_name":"IntelRealSense/librealsense","issue_id":3007507777,"issue_number":13955,"issue_url":"https://github.com/IntelRealSense/librealsense/issues/13955","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0439","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Cursor has problems in Wayland?","query_context":"Hi,\n\nI don't know if it's related to RetroArch apparently lacking pointer confinement on Wayland, as I commented here:\n URL \n\n...But for example, Lemmings or Ishar have major problems with cursor movement on Wayland, like cursor is stuck on the right half of the screen, or in a certain area.\nThis happens on all Wayland compositors I tried: Weston, Sway and tinywl.\n\nHas anybody tried this core on Wayland compositors?","known_context_document_ids":["gh_issue_1379715867"],"reference_answer":"Are you running the latest master branch. We very recently (<2 weeks) applied a patch on pointer constraints.\n\nIf running the latest doesn't solve this, could you try `sway` and/or `weston` before we start looking too deep.","answer_document_id":"gh_comment_1452549786","silver_evidence_path":["gh_comment_1454705334","gh_issue_1605843036","gh_comment_1452549786"],"evidence_issue_ids":[1379715867,1605843036],"source_repo_name":"realnc/dosbox-core","source_issue_id":1379715867,"source_issue_number":48,"source_issue_url":"https://github.com/realnc/dosbox-core/issues/48","target_repo_name":"labwc/labwc","target_issue_id":1605843036,"target_issue_number":809,"target_issue_url":"https://github.com/labwc/labwc/issues/809","reference_anchor_document_id":"gh_comment_1454705334","reference_answer_author":"johanmalm","reference_answer_author_association":"COLLABORATOR","quality_score":85.38,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2727,"anchor_target_overlap":0.6364,"target_answer_overlap":0.0476},"issue_created_at":"2022-09-20T16:51:26+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1379715867","fragment_type":"issue_description","sequence":0,"text":"Cursor has problems in Wayland\nHi,\n\nI don't know if it's related to RetroArch apparently lacking pointer confinement on Wayland, as I commented here:\n URL \n\n...But for example, Lemmings or Ishar have major problems with cursor movement on Wayland, like cursor is stuck on the right half of the screen, or in a certain area.\nThis happens on all Wayland compositors I tried: Weston, Sway and tinywl.\n\nHas anybody tried this core on Wayland compositors?","author_login":"vanfanel","author_association":"NONE","created_at":"2022-09-20T16:51:26+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1252645092","fragment_type":"issue_comment","sequence":1,"text":"Do other cores that read mouse input from RA behave the same? (Like PUAE.)","author_login":"realnc","author_association":"OWNER","created_at":"2022-09-20T17:02:58+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1255311475","fragment_type":"issue_comment","sequence":2,"text":"@realnc No, PUAE works perfectly well on that regard, only dosbox-core seems to be affected.","author_login":"vanfanel","author_association":"NONE","created_at":"2022-09-22T17:07:57+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257228308","fragment_type":"issue_comment","sequence":3,"text":"@realnc Also, I have been playing around with all core-specific options related to mouse handling, and they make no difference: mouse seems to be trapped inside certain regions.\nDo you have a Wayland system you can test this on?","author_login":"vanfanel","author_association":"NONE","created_at":"2022-09-25T16:23:08+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307321426","fragment_type":"issue_comment","sequence":4,"text":"I have no idea what to do about it. The core just reads mouse input from RA. The cursor behaves in whatever way RA tells the core to behave.","author_login":"realnc","author_association":"OWNER","created_at":"2022-11-08T14:37:11+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1307692352","fragment_type":"issue_comment","sequence":5,"text":"In Ishar 1, RA traps the mouse inside a small window in the center of the screen.","author_login":"realnc","author_association":"OWNER","created_at":"2022-11-08T19:02:27+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1449986872","fragment_type":"issue_comment","sequence":6,"text":"@realnc I have been thinking about this bug: Is there a place where you initialize the screen area size for the mouse? I think that could be missing, because the cursor works perfectly once it's moved around the screen.","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-01T11:48:23+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1450970543","fragment_type":"issue_comment","sequence":7,"text":"There is no such thing. The core has no idea how big the screen is. The core simply tells RetroArch what the game's resolution is (like 320x200) and RA sends mouse input suitable for that resolution. In X11, if you don't enable \"grab mouse\" in RA (or \"game focus\" which also grabs the mouse ), you get the same issue where you need to move the mouse in all directions first. \"Grab mouse\" is a RA hotkey. I have it bound to F11.\n\nMaybe \"grab mouse\" doesn't work correctly on Wayland?","author_login":"realnc","author_association":"OWNER","created_at":"2023-03-01T22:48:51+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1451016283","fragment_type":"issue_comment","sequence":8,"text":"@realnc Yep, that has to be it. These features must be implemented by the compositor (labwc in this case) so I guess it's missing. I will ask the labwc devs :)","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-01T23:19:41+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454705334","fragment_type":"issue_comment","sequence":9,"text":"@realnc It seems that RetroArch is missing mouse grab in the Wayland backend:\n\n URL \n\nSo, that's the problem it seems.","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-04T11:20:30+08:00","repo_name":"realnc/dosbox-core","issue_id":1379715867,"issue_number":48,"issue_url":"https://github.com/realnc/dosbox-core/issues/48","linked_issue_ids":[1605843036],"is_known_query_context":false},{"document_id":"gh_issue_1605843036","fragment_type":"issue_description","sequence":0,"text":"Missing mouse grabbing feature?\nHi there!\n\nI have noticed that, with the labwc compositor, some RetroArch cores have mouse problems.\nFor example, dosbox-core has pointer wrongly locked to a small area of the screen until the cursor is moved around beyond this small area:\n URL \n\nThis seems to be caused by the lack of mouse grabbing, which is a feature implemented (I guess) by the Wayland compositors.\n\nSo, would it be possible to have this feature implemented, please? Or maybe there's a problem with the current implementation?\n\nThanks!","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-01T23:26:35+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1451757116","fragment_type":"issue_comment","sequence":1,"text":"\"Mouse grabbing\" in the wayland context is two things AFAIU:\n- cursor confinement which restricts the cursor to a specific area of the surface\n- cursor confinement which locks the cursor into a specific place\n\nRelated to the lock confinement, there is also a relative pointer motion protocol which (even though the actual cursor doesn't move) tells the wayland client about relative movements of the cursor and thus can be used by applications to render their own cursor. So I think the compositor side of the puzzle should be working, maybe RetroArch / dosbox-core (I don't really know how either of them work) just don't implement the \"grab cursor\" feature when it detects that its running under wayland?","author_login":"Consolatis","author_association":"CONTRIBUTOR","created_at":"2023-03-02T12:02:00+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1452501786","fragment_type":"issue_comment","sequence":2,"text":"@Consolatis I would like, at last, know where the problem really is: on the Wayland/labwc or on the RetroArch side. Thanks for trying to help me finding out! :)\n\nWhat function should be used from RetroArch's side to grab the mouse, please? I can look on the RetroArch sources for that function, so I can find out if it's being used or not.\n\nThe idea of the missing compensation for scaling is also very plausible: the games in RetroArch are scaled from, let's say, 320x200, to 1920x10080.\nWould the lack of scaling compensation cause cursor to be confined to a region and then moving it would finally \"unlock\" it?","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-02T20:27:45+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1452549786","fragment_type":"issue_comment","sequence":3,"text":"Are you running the latest master branch. We very recently (<2 weeks) applied a patch on pointer constraints.\n\nIf running the latest doesn't solve this, could you try `sway` and/or `weston` before we start looking too deep.","author_login":"johanmalm","author_association":"COLLABORATOR","created_at":"2023-03-02T21:10:00+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1453183552","fragment_type":"issue_comment","sequence":4,"text":"Y es, I'm running the latest GIT code: cursor confinement in fullscreen mode works perfectly in Scummvm since these changes you mention! scummvm runs on SDL2.\n\nSway and Weston have the exact same problem with the dosbox-core core in retroarch. I understand they implement all the grabbing functions?","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-03T08:53:51+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1453623940","fragment_type":"issue_comment","sequence":5,"text":"I'd assume so, yes (but didn't actually verify).\n \n\nI don't think so, that sounds like some retroarch / dosbox issue.\nI've just tested using an output scale of `2` for a nested output and the confinement seems to work correctly in that case as well.\n \n\nShould be either `zwp_pointer_constraints_v1_confine_pointer` or `zwp_pointer_constraints_v1_lock_pointer`","author_login":"Consolatis","author_association":"CONTRIBUTOR","created_at":"2023-03-03T14:35:45+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454710184","fragment_type":"issue_comment","sequence":6,"text":"@Consolatis Ah, thanks for taking a look :)\nI am trying to implement mouse grab in RetroArch, exactly in `input_wl_grab_mouse()` where you pointed me to.\n\nHowever, first problem is that never did any Wayland specific coding, so I am getting `undefined reference` when adding a call to `zwp_pointer_constraints_v1_confine_pointer` or `zwp_pointer_constraints_v1_lock_pointer`.\n\nI did a grep search on `/usr/local/include` on my system (which runs latest stable WLRoots and the fantastic latest GIT Labwc on top of it with no problems at all), and had zero results, which is very puzzling.\nAre these plain functions? Then I guess they should be on some system-installed header file under /usr... unless I am fundamentally wrong on something.","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-04T11:40:42+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454857268","fragment_type":"issue_comment","sequence":7,"text":"@Consolatis Ok, opened the issue in RetroArch: URL \n\nNow, let's see what they say about this...","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-04T19:56:36+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1475948184","fragment_type":"issue_comment","sequence":8,"text":"@Consolatis The last problem was on RetroArch and is now fixed! \n URL \n\nSo this can be closed.\n\nLabwc is now my daily driver! Thanks a lot! This compositor is incredible.","author_login":"vanfanel","author_association":"NONE","created_at":"2023-03-20T10:09:39+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1477083696","fragment_type":"issue_comment","sequence":9,"text":"Nice work. Congratz on adding the feature and getting it merged :)","author_login":"Consolatis","author_association":"CONTRIBUTOR","created_at":"2023-03-20T23:28:47+08:00","repo_name":"labwc/labwc","issue_id":1605843036,"issue_number":809,"issue_url":"https://github.com/labwc/labwc/issues/809","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0440","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Data Wrangler view does not remember hidden side bar / bottom panel?","query_context":"Type: Bug \n\n \n \n\n# Behaviour\n\n## Expected vs. Actual\n\nWhen I hide the side bar and the panel in the Data Wrangler view, change the tab to an open notebook and return to the Data Wrangler view, the side bar and the panel show up again. I expect, them to stay hidden upon tab switch.\n\n \n\n# Diagnostic data\n\n- Jupyter extension version: 2023.10.1100000000\n- Python extension version: 2023.20.0\n- .NET Install Tool for Extension Authors extension version: 2.0.0\n- Python package dependencies:\n\njson\n{\n \"satisfied\": {\n \"pandas\": {\n \"installedVersion\": \"2.1.3\",\n \"requiredVersion\": \"0.25.2\"\n }\n },\n \"unsatisfied\": {}\n}\n\nExtension version: 0.20.0\nVS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:50:47.800Z)\nOS version: Linux x64 6.5.9-1-MANJARO\nModes:","known_context_document_ids":["gh_issue_1996791710"],"reference_answer":"Hi folks! Thank you very much for your patience and for providing great feedback on this issue.\n\nWe've just added a setting to disable the automatic panel behaviour in pre-release version 1.13.3. The following setting needs to be disabled to prevent the panels from appearing on startup and on tab focus:\nImage\n\nPlease feel free to give this a try and let us know if you have any additional feedback. Thanks!","answer_document_id":"gh_comment_2487056292","silver_evidence_path":["gh_comment_2487081464","gh_issue_1943467909","gh_comment_2487056292"],"evidence_issue_ids":[1996791710,1943467909],"source_repo_name":"microsoft/vscode-data-wrangler","source_issue_id":1996791710,"source_issue_number":103,"source_issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","target_repo_name":"microsoft/vscode-data-wrangler","target_issue_id":1943467909,"target_issue_number":96,"target_issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","reference_anchor_document_id":"gh_comment_2487081464","reference_answer_author":"pwang347","reference_answer_author_association":"MEMBER","quality_score":84.71,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0588,"anchor_target_overlap":0.4706,"target_answer_overlap":0.2},"issue_created_at":"2023-11-16T12:51:41+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_1996791710","fragment_type":"issue_description","sequence":0,"text":"Data Wrangler view does not remember hidden side bar / bottom panel\nType: Bug \n\n \n \n\n# Behaviour\n\n## Expected vs. Actual\n\nWhen I hide the side bar and the panel in the Data Wrangler view, change the tab to an open notebook and return to the Data Wrangler view, the side bar and the panel show up again. I expect, them to stay hidden upon tab switch.\n\n \n\n# Diagnostic data\n\n- Jupyter extension version: 2023.10.1100000000\n- Python extension version: 2023.20.0\n- .NET Install Tool for Extension Authors extension version: 2.0.0\n- Python package dependencies:\n\njson\n{\n \"satisfied\": {\n \"pandas\": {\n \"installedVersion\": \"2.1.3\",\n \"requiredVersion\": \"0.25.2\"\n }\n },\n \"unsatisfied\": {}\n}\n\nExtension version: 0.20.0\nVS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:50:47.800Z)\nOS version: Linux x64 6.5.9-1-MANJARO\nModes:","author_login":"tea-de-kay","author_association":"NONE","created_at":"2023-11-16T12:51:41+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1996791710,"issue_number":103,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1831114453","fragment_type":"issue_comment","sequence":1,"text":"Hi @tea-de-kay, thanks for opening this issue!\n\nNote that this behaviour is currently by design due to limitations with VS Code API. However, we are experimenting with some fixes to improve this experience. I will update this thread when the changes are checked in.","author_login":"pwang347","author_association":"MEMBER","created_at":"2023-11-29T02:30:23+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1996791710,"issue_number":103,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1925909932","fragment_type":"issue_comment","sequence":2,"text":"Wanted to add my support for this request. Often I will be switching between the data wrangler view & my jupyter notebook and it is frustrating to have to close the bottom and side panel. Awesome extension though, thanks for the extension!","author_login":"ryanyord","author_association":"NONE","created_at":"2024-02-04T20:48:45+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1996791710,"issue_number":103,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2010742737","fragment_type":"issue_comment","sequence":3,"text":"Adding support as well. Definitely wish there were a way to have the panel and side bar auto close when exiting the data wrangler editor.","author_login":"hashtagswagboy","author_association":"NONE","created_at":"2024-03-20T22:16:06+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1996791710,"issue_number":103,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2227470508","fragment_type":"issue_comment","sequence":4,"text":"Adding support for this as well. This would be a great addition!","author_login":"pszewi","author_association":"NONE","created_at":"2024-07-14T20:10:21+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1996791710,"issue_number":103,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2487081464","fragment_type":"issue_comment","sequence":5,"text":"Hi folks! Just wanted to let you know that there is now an option to not automatically reveal the panels (both on startup and on tab switch) in pre-release version 1.13.3.\n\nFor more details, please see: URL \n\nWill close this issue for now since this setting should address the pain points mentioned here, but please feel free to reopen if you have additional feedback. Thanks!","author_login":"pwang347","author_association":"MEMBER","created_at":"2024-11-20T00:58:00+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1996791710,"issue_number":103,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/103","linked_issue_ids":[1943467909],"is_known_query_context":false},{"document_id":"gh_issue_1943467909","fragment_type":"issue_description","sequence":0,"text":"feature request: add option to disable opening sidebar+console\nThe current behavior of data-wranggler provides a poor UX on smaller screens. Please give an option to disable opening the side-bar and console view. Thanks!","author_login":"bobcolner","author_association":"NONE","created_at":"2023-10-14T18:32:10+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1769521002","fragment_type":"issue_comment","sequence":1,"text":"Hi @bobcolner, thanks for making this feature request! This is a great callout - we're currently exploring different ways to address the panel real estate issue and will provide any updates here.","author_login":"pwang347","author_association":"MEMBER","created_at":"2023-10-18T22:49:05+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2129104782","fragment_type":"issue_comment","sequence":2,"text":"I would really appreciate this as well, since I find it incredibly annoying to have to close it again and again every time I just want to have a look at my data and don't need to see the basic Data Summary.","author_login":"kleinlennart","author_association":"NONE","created_at":"2024-05-24T09:48:12+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2378449169","fragment_type":"issue_comment","sequence":3,"text":"I just think an option should be added to not open the panel. I don't think it's a matter of re-thinking the side bar philosophy.","author_login":"jonpedros","author_association":"NONE","created_at":"2024-09-27T05:49:46+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2443817812","fragment_type":"issue_comment","sequence":4,"text":"I was about to open an issue on this, then I realized it was already done. Please change this standard behaviour: it does not happen for other extensions!","author_login":"guidocioni","author_association":"NONE","created_at":"2024-10-29T10:22:53+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2450474317","fragment_type":"issue_comment","sequence":5,"text":"Please add this, has been a pain for a while. Much appreciated!","author_login":"tacitli","author_association":"NONE","created_at":"2024-10-31T17:47:02+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2471437405","fragment_type":"issue_comment","sequence":6,"text":"It would be great to be able to change Data Summary panel behavior in Settings similar to enabling/disabling Column Insight.","author_login":"BrazilForever11","author_association":"NONE","created_at":"2024-11-12T19:51:21+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2487056292","fragment_type":"issue_comment","sequence":7,"text":"Hi folks! Thank you very much for your patience and for providing great feedback on this issue.\n\nWe've just added a setting to disable the automatic panel behaviour in pre-release version 1.13.3. The following setting needs to be disabled to prevent the panels from appearing on startup and on tab focus:\nImage\n\nPlease feel free to give this a try and let us know if you have any additional feedback. Thanks!","author_login":"pwang347","author_association":"MEMBER","created_at":"2024-11-20T00:42:33+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2488238397","fragment_type":"issue_comment","sequence":8,"text":"Finally! :) Thanks a lot. I can confirm it is indeed working on the pre-release version","author_login":"guidocioni","author_association":"NONE","created_at":"2024-11-20T10:47:04+08:00","repo_name":"microsoft/vscode-data-wrangler","issue_id":1943467909,"issue_number":96,"issue_url":"https://github.com/microsoft/vscode-data-wrangler/issues/96","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0441","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"🗂 - Deprecated -moz-any and -webkit-any pseudo-classes used in Taiga UI CSS?","query_context":"### Description\n\nDear Taiga UI Team,\n\nI've encountered warnings during the build process of my Angular 19 or from version 17+ applications that uses Taiga UI. These warnings indicate the use of deprecated -moz-any and -webkit-any pseudo-classes in Taiga UI's CSS.\n\nDuring the Angular build process (using ng build), the following warnings are generated:\n\n[WARNING] 391 rules skipped due to selector errors:\n[tuiAppearance][data-appearance=accent]:-webkit-any(a,button,select,textarea,input,label):not([data-state]) -> Unknown pseudo-class :-webkit-any\n[tuiAppearance][data-appearance=accent]:-moz-any(a,button,select,textarea,input,label):not([data-state]) -> Unknown pseudo-class :-moz-any\n... (many similar warnings for different appearances)....\n\nDescription of the issue:\n\nThese warnings stem from the use of -webkit-any and -moz-any, which are non-standard and deprecated. The standard replacement is the :is() pseudo-class.\n\nExpected behavior:\n\nTaiga UI's CSS should use the standard :is() pseudo-class to ensure compatibility with modern browsers and avoid build warnings.\n\nCurrent behavior:\n\nThe build process generates warnings due to the presence of -webkit-any and -moz-any in Taiga UI's CSS. While the application may still function, these warnings clutter the build output and indicate the use of outdated CSS.","known_context_document_ids":["gh_issue_2781390562"],"reference_answer":"Closing this issue because ownership of Critters has moved to the Nuxt team, who will be maintaining the project going forward. This repo is archived and won't receive any future updates.\n \nIf the issue is still relevant, please re-post it to the actively-maintained fork at URL","answer_document_id":"gh_comment_2438545636","silver_evidence_path":["gh_comment_2585310996","gh_issue_2099419852","gh_comment_2438545636"],"evidence_issue_ids":[2781390562,2099419852],"source_repo_name":"taiga-family/taiga-ui","source_issue_id":2781390562,"source_issue_number":10145,"source_issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","target_repo_name":"GoogleChromeLabs/critters","target_issue_id":2099419852,"target_issue_number":153,"target_issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","reference_anchor_document_id":"gh_comment_2585310996","reference_answer_author":"kara","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1579,"anchor_target_overlap":0.2368,"target_answer_overlap":0.1538},"issue_created_at":"2025-01-10T23:16:34+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_2781390562","fragment_type":"issue_description","sequence":0,"text":"🗂 - Deprecated -moz-any and -webkit-any pseudo-classes used in Taiga UI CSS\n### Description\n\nDear Taiga UI Team,\n\nI've encountered warnings during the build process of my Angular 19 or from version 17+ applications that uses Taiga UI. These warnings indicate the use of deprecated -moz-any and -webkit-any pseudo-classes in Taiga UI's CSS.\n\nDuring the Angular build process (using ng build), the following warnings are generated:\n\n[WARNING] 391 rules skipped due to selector errors:\n[tuiAppearance][data-appearance=accent]:-webkit-any(a,button,select,textarea,input,label):not([data-state]) -> Unknown pseudo-class :-webkit-any\n[tuiAppearance][data-appearance=accent]:-moz-any(a,button,select,textarea,input,label):not([data-state]) -> Unknown pseudo-class :-moz-any\n... (many similar warnings for different appearances)....\n\nDescription of the issue:\n\nThese warnings stem from the use of -webkit-any and -moz-any, which are non-standard and deprecated. The standard replacement is the :is() pseudo-class.\n\nExpected behavior:\n\nTaiga UI's CSS should use the standard :is() pseudo-class to ensure compatibility with modern browsers and avoid build warnings.\n\nCurrent behavior:\n\nThe build process generates warnings due to the presence of -webkit-any and -moz-any in Taiga UI's CSS. While the application may still function, these warnings clutter the build output and indicate the use of outdated CSS.","author_login":"HBFLEX","author_association":"NONE","created_at":"2025-01-10T23:16:34+08:00","repo_name":"taiga-family/taiga-ui","issue_id":2781390562,"issue_number":10145,"issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2585198221","fragment_type":"issue_comment","sequence":1,"text":"This is an Angular bug, Taiga UI has to use these classes to support Safari 13, which is the minimum required version for Taiga 4","author_login":"waterplea","author_association":"COLLABORATOR","created_at":"2025-01-11T10:36:40+08:00","repo_name":"taiga-family/taiga-ui","issue_id":2781390562,"issue_number":10145,"issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585204391","fragment_type":"issue_comment","sequence":2,"text":"Is there a way, where I can restrict or get rid of the warnings when am building, my bosses are not happy with warnings in builds but I successfully convinced them to start using Taiga UI. Any help would be appreciated Lol 🙏","author_login":"HBFLEX","author_association":"NONE","created_at":"2025-01-11T11:03:45+08:00","repo_name":"taiga-family/taiga-ui","issue_id":2781390562,"issue_number":10145,"issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2585310996","fragment_type":"issue_comment","sequence":3,"text":"I believe you can disable critical CSS inline as mentioned in original Angular CLI issue:\n URL \n\nThat issue was then closed as Critters issue:\n URL \n\nWhich was then discontinued – I suppose it needs to be fixed under this new fork that Angular uses:\n URL \n\nFiled it just in case, but I wouldn't hold my breath since even though it's a valid selector – it's pretty much outdated for anything other than Safari 13 and below:\n URL","author_login":"waterplea","author_association":"COLLABORATOR","created_at":"2025-01-11T15:57:06+08:00","repo_name":"taiga-family/taiga-ui","issue_id":2781390562,"issue_number":10145,"issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","linked_issue_ids":[2099419852],"is_known_query_context":false},{"document_id":"gh_comment_2589279524","fragment_type":"issue_comment","sequence":4,"text":"Let's see if this combination of selector helps, since they also cover all the browsers we must support","author_login":"waterplea","author_association":"COLLABORATOR","created_at":"2025-01-14T08:17:17+08:00","repo_name":"taiga-family/taiga-ui","issue_id":2781390562,"issue_number":10145,"issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2589309423","fragment_type":"issue_comment","sequence":5,"text":"Thank you so much sir 🚀, time to update. Am a big fan of your Library. Much love for the changes ✅","author_login":"HBFLEX","author_association":"NONE","created_at":"2025-01-14T08:33:55+08:00","repo_name":"taiga-family/taiga-ui","issue_id":2781390562,"issue_number":10145,"issue_url":"https://github.com/taiga-family/taiga-ui/issues/10145","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2099419852","fragment_type":"issue_description","sequence":0,"text":"Building Angular 17.1 with Angular CLI when using Bootstrap 5.3.2 results in Critical CSS Inlining failing because 2 rules are skipped due to selector errors\nThe 2 rules are the same rule listed twice:\n\n- Generating index html...2 rules skipped due to selector errors:\n .form-floating>~label -> Did not expect successive traversals.\n .form-floating>~label -> Did not expect successive traversals.\n\n`>~` is obviously an invalid selector, however it doesn't look like that's ever actually used in the Bootstrap code. I've checked myself, and one of the bootstrap devs has also confirmed it twbs/bootstrap#39323. The base style is simply `.form-floating > label` while there are a number of styles in the format of `.form-floating > [another selector] ~ label`. It seems one of those intermediary selectors is being removed during CSS processing.\n\nThere is a workaround of disabled Inlining of Critical CSS, but of course we're then missing out on a possible performance improvement.\n\nThis was reported as an Issue with Angular CLI last year, but they indicated it is a problem with Critters: URL","author_login":"elezar42","author_association":"NONE","created_at":"2024-01-25T01:56:18+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1912653539","fragment_type":"issue_comment","sequence":1,"text":"Even in the empty angular 17.1.0 project I get some errors\n\nScreenshot 2024-01-26 232318","author_login":"eilzee","author_association":"NONE","created_at":"2024-01-26T20:26:50+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1961626092","fragment_type":"issue_comment","sequence":2,"text":"Chipping in from the ng-bootstrap repo, where there was also a bug filed last year about this problem and it was resolved intermittently by critters version `0.0.18`. \nAs it now resurfaces this likely is a regression. \nI saw the warnings with `@angular-devkit/build-angular:17.2.1` which references critters at version `0.0.20`,","author_login":"DanielHabenicht","author_association":"NONE","created_at":"2024-02-23T16:24:40+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1962229545","fragment_type":"issue_comment","sequence":3,"text":"While the error looks similar, this issue is **not** a duplicate of #103. Because the whole project was heavily refactored in #124, specifically to solve #103. So it is unlikely to be the same root cause, and this issue needs its own proper investigation.","author_login":"PowerKiKi","author_association":"NONE","created_at":"2024-02-24T03:04:09+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1962437533","fragment_type":"issue_comment","sequence":4,"text":"Same on my side. Setup an Angular ssr project from scratch including bootstrap and get exactly the same output running ng build.\n\nUploading warnings.png…","author_login":"schneefeldio","author_association":"NONE","created_at":"2024-02-24T17:54:44+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1981381951","fragment_type":"issue_comment","sequence":5,"text":"I see a lot of similar errors with picocss in Angular 17.2. For the moment I set \"inlineCritical\": false to have a working build.","author_login":"eiswind","author_association":"NONE","created_at":"2024-03-06T17:13:11+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2100752223","fragment_type":"issue_comment","sequence":6,"text":"We're adding SSR to our legacy Angular project after upgrading to Angular v17.3.6, and it's now crashing the server-side node app due to looping selector errors (both with Vite dev server and express production app builds). The CSS styles are Telerik's, which may be hard to mitigate:\n\nAngular is running in development mode.\n7 rules skipped due to selector errors:\n .k-input-label:dir(rtl) -> Unknown pseudo-class :dir\n\nBesides the \"inlineCritical\" workaround, which doesn't seem(?) to work initially, I saw that the Angular team commented on maybe finding a temporary solution that involves pinning a working Critters version... can anyone here indicate what version that should be, as well as whether this is targeted for a near-term fix?","author_login":"jitterbox","author_association":"NONE","created_at":"2024-05-08T14:42:38+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2136822994","fragment_type":"issue_comment","sequence":7,"text":"Here's a case where it fails on a valid, albeit deprecated selector that we have to use because we need Safari 13 (only Safari 14 supports `:is( )`, we have to use `-webkit-any( )`:\n URL","author_login":"waterplea","author_association":"NONE","created_at":"2024-05-29T08:19:22+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2213011407","fragment_type":"issue_comment","sequence":8,"text":"I'm getting same warning after upgrade my angular 17.3.0 to 18.0.6","author_login":"KasunNi","author_association":"NONE","created_at":"2024-07-08T04:38:34+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2438545636","fragment_type":"issue_comment","sequence":9,"text":"Closing this issue because ownership of Critters has moved to the Nuxt team, who will be maintaining the project going forward. This repo is archived and won't receive any future updates.\n \nIf the issue is still relevant, please re-post it to the actively-maintained fork at URL","author_login":"kara","author_association":"COLLABORATOR","created_at":"2024-10-25T18:24:24+08:00","repo_name":"GoogleChromeLabs/critters","issue_id":2099419852,"issue_number":153,"issue_url":"https://github.com/GoogleChromeLabs/critters/issues/153","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0442","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Pluto.TV Addon: DAZN Channels could no longer played?","query_context":"Hi @matthuisman , I noticed in the Pluto.TV addon that the DAZN (for examle \"DAZN Darts x Pluto TV\" or \"DAZN International Football x Pluto TV\") channels could no longer be played. The error message “Unable to play” always appears. Do you have an idea why that is?\n\nkodi_slyg_pluto_dazn.log\n\nGreetings Weri","known_context_document_ids":["gh_issue_2110022173"],"reference_answer":"oh wow. i dont get that all.\nIs that a cloudflare message or their site returning it?","answer_document_id":"gh_comment_1882360453","silver_evidence_path":["gh_comment_1920714110","gh_issue_2069930924","gh_comment_1882360453"],"evidence_issue_ids":[2110022173,2069930924],"source_repo_name":"matthuisman/slyguy.addons","source_issue_id":2110022173,"source_issue_number":673,"source_issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","target_repo_name":"matthuisman/slyguy.addons","target_issue_id":2069930924,"target_issue_number":657,"target_issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","reference_anchor_document_id":"gh_comment_1920714110","reference_answer_author":"matthuisman","reference_answer_author_association":"OWNER","quality_score":76.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2174,"anchor_target_overlap":0.0,"target_answer_overlap":0.0},"issue_created_at":"2024-01-31T12:47:19+08:00","valid_comment_count":32,"fragments":[{"document_id":"gh_issue_2110022173","fragment_type":"issue_description","sequence":0,"text":"Pluto.TV Addon: DAZN Channels could no longer played\nHi @matthuisman , I noticed in the Pluto.TV addon that the DAZN (for examle \"DAZN Darts x Pluto TV\" or \"DAZN International Football x Pluto TV\") channels could no longer be played. The error message “Unable to play” always appears. Do you have an idea why that is?\n\nkodi_slyg_pluto_dazn.log\n\nGreetings Weri","author_login":"werimail","author_association":"NONE","created_at":"2024-01-31T12:47:19+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1920714110","fragment_type":"issue_comment","sequence":1,"text":"Yes @kyl416 , I saw #657 . This entry has now been closed with the result that everything is working again. This is also the case, with the exception of the DAZN channels. Maybe @matthuisman no longer wants to support this because of the topic described?\n\nGreetings Weri","author_login":"werimail","author_association":"NONE","created_at":"2024-02-01T07:57:18+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[2069930924],"is_known_query_context":false},{"document_id":"gh_comment_1922415367","fragment_type":"issue_comment","sequence":2,"text":"thats not the case. the dazn channels are there. its just they need to switch to v2 hls manifest","author_login":"matthuisman","author_association":"OWNER","created_at":"2024-02-01T22:42:36+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1923310263","fragment_type":"issue_comment","sequence":3,"text":"Ah ok @matthuisman , where can this setting be made? Or does your addon need to be adapted for this?\n\nGreetings Weri","author_login":"werimail","author_association":"NONE","created_at":"2024-02-02T08:25:46+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1930618737","fragment_type":"issue_comment","sequence":4,"text":"Hi @matthuisman I noticed that after a certain time the stream from DAZN Darts x PlutoTV simply stops and ends up back in the Kodi main menu. It is irrelevant which Kodi version is used. Is this due to the addon or Inputstream.adaptive? \nGreetings Weri\nkodi_plutlo_omega.log","author_login":"werimail","author_association":"NONE","created_at":"2024-02-06T19:31:38+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987370066","fragment_type":"issue_comment","sequence":5,"text":"Hi @matthuisman I have created an additional debug.log for the problem presented. \n\nkodi.log\nGreetings Weri","author_login":"werimail","author_association":"NONE","created_at":"2024-03-10T21:35:58+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1987384548","fragment_type":"issue_comment","sequence":6,"text":"itll be the ad breaks / x-discontuity. So inputstream.adaptive needs to support it fully\nnothing i can do my end sorry","author_login":"matthuisman","author_association":"OWNER","created_at":"2024-03-10T22:31:33+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2110022173,"issue_number":673,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/673","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2069930924","fragment_type":"issue_description","sequence":0,"text":"PlutoTV playlists / add-on OFFLINE until further notice\nNews article about what and why:\n URL \n\nHave taken offline to keep Vultr happy and hopefully not take down my hosting.\n\nin the meantime users could try URL instead\n\nI'll search for alternatives and keep everyone posted here","author_login":"matthuisman","author_association":"OWNER","created_at":"2024-01-08T08:10:35+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1881800224","fragment_type":"issue_comment","sequence":1,"text":"Is the software you use to generate the m3u's for pluto open source, similar to maddox/pluto-to-channels?","author_login":"jac4e","author_association":"NONE","created_at":"2024-01-08T20:50:41+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882136957","fragment_type":"issue_comment","sequence":2,"text":"+1 for this repo. Spun-up a container, locked network for jellyfin access only and working great. It will return the streams for my region only though (UY). I havent found a way to pull up brazil regions that I want.","author_login":"maurirope","author_association":"NONE","created_at":"2024-01-09T01:43:11+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882267638","fragment_type":"issue_comment","sequence":3,"text":"ill try get a docker solution sorted so users can simply generate their own","author_login":"matthuisman","author_association":"OWNER","created_at":"2024-01-09T02:54:41+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882355142","fragment_type":"issue_comment","sequence":4,"text":"got this:\n\"\nSorry, you have been blocked\nYou are unable to access nocords.xyz\n\"\n;<","author_login":"ChiFungLam","author_association":"NONE","created_at":"2024-01-09T03:38:55+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882360453","fragment_type":"issue_comment","sequence":5,"text":"oh wow. i dont get that all.\nIs that a cloudflare message or their site returning it?","author_login":"matthuisman","author_association":"OWNER","created_at":"2024-01-09T03:41:40+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882377554","fragment_type":"issue_comment","sequence":6,"text":"seems from cloudflare (can't upload screen capture to show the screen)","author_login":"ChiFungLam","author_association":"NONE","created_at":"2024-01-09T04:00:52+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882381784","fragment_type":"issue_comment","sequence":7,"text":"Yeah was getting that yesterday but the site loads using VPN. Not sure how viable that is long-term.\n\nHoping Matt comes up with a good solution in the next days/weeks..","author_login":"boeder8","author_association":"NONE","created_at":"2024-01-09T04:07:08+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1882586508","fragment_type":"issue_comment","sequence":8,"text":"Hello,\nWe are in a bad situation. But is there a problem if you generate xml epgs? The url you gave doesn't support french epg and others.\nThanks","author_login":"jeepcook","author_association":"NONE","created_at":"2024-01-09T08:11:31+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1883936717","fragment_type":"issue_comment","sequence":9,"text":"i've also hacked together a node script that generates the m3u8 and xml for different regions (to get other regions, an IP address from that region is needed).\n\n URL \n\nI hope this helps others.","author_login":"4v3ngR","author_association":"NONE","created_at":"2024-01-09T23:05:06+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1884148830","fragment_type":"issue_comment","sequence":10,"text":"Hey cool tool it actually helped me get the MX m3u8 and xml.","author_login":"th3p0l4rb34r","author_association":"NONE","created_at":"2024-01-10T03:48:55+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1884519898","fragment_type":"issue_comment","sequence":11,"text":"Hello, Thanks for these great work.\n\nIs it possible to use same tvg-id as the one used by Matt.\n\nExample:\n- with your script every tvg-id are followed by the country code: 64edf6eaa7ec0d000812f58c-uk\n- with Matt script the tvg-id is just 64edf6eaa7ec0d000812f58c\n\nThanks","author_login":"jeepcook","author_association":"NONE","created_at":"2024-01-10T09:52:13+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1884838118","fragment_type":"issue_comment","sequence":12,"text":"Previously I found that pluto TV sometimes uses the same channel id for different channels in different locations. My local setup merges several playlists and xml files into one, and I wanted to ensure the ids were globally unique.\n\nIf you want, you could edit lib/plutotv/api.js and remove the '-${region}' suffixes from the ids in the m3u8 and xmltv functions.","author_login":"4v3ngR","author_association":"NONE","created_at":"2024-01-10T13:19:51+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1884849839","fragment_type":"issue_comment","sequence":13,"text":"Ok I understand your choice. I never detected the same if for different channels but you yes, so your choice is better.","author_login":"jeepcook","author_association":"NONE","created_at":"2024-01-10T13:27:02+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1888316626","fragment_type":"issue_comment","sequence":14,"text":"I thought i was giving you feedback of issues by sending you a screenshot\nstupid me\n\nOn Fri, 12 Jan 2024 at 12:13, Matt Huisman ***@***.***> wrote:","author_login":"rippledmindd","author_association":"NONE","created_at":"2024-01-12T02:20:37+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[2069930924],"is_known_query_context":false},{"document_id":"gh_comment_1889734702","fragment_type":"issue_comment","sequence":15,"text":"Thanks Matt. It's a shame Torrentfreak brought more attention to your work. Thanks for sharing a backup.","author_login":"WeirdG","author_association":"NONE","created_at":"2024-01-12T18:02:43+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1891080896","fragment_type":"issue_comment","sequence":16,"text":"Try different VPN servers. US ones generally work for me. \n\nIt's a good alternative but far FAR inferior to what Matt had in terms of quantity and EPGs. Power to him. Hope he finds a way to bring it back..","author_login":"boeder8","author_association":"NONE","created_at":"2024-01-14T21:44:26+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1891113126","fragment_type":"issue_comment","sequence":17,"text":"Just use the 4v3ngR software and you will have exactly the same files as the one generated by Matt. I'm using it still few days and I 've detected no problem.","author_login":"jeepcook","author_association":"NONE","created_at":"2024-01-14T23:40:13+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1891200796","fragment_type":"issue_comment","sequence":18,"text":"Great, see if someone package it into a docker solution so that everyone can install their own version e.g. on Vercel","author_login":"ChiFungLam","author_association":"NONE","created_at":"2024-01-15T02:19:07+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1891462262","fragment_type":"issue_comment","sequence":19,"text":"Currently a noob and no idea how to use it but I will definitely try to learn :)","author_login":"boeder8","author_association":"NONE","created_at":"2024-01-15T07:29:37+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1891632164","fragment_type":"issue_comment","sequence":20,"text":"More than once a day. At least 3 times I think. So that's why you have to implement the tool on your system.","author_login":"jeepcook","author_association":"NONE","created_at":"2024-01-15T09:08:47+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1892132729","fragment_type":"issue_comment","sequence":21,"text":"For those that are interested, I've pushed the scraper to the npmjs repo. There's no longer any need to check out the source code and do npm install etc. Do note that both npm and node (version >= 14) is required. Once node is installed on your system, a quick `npm install -g plutotv-scraper` is all that is needed to run it. There's also exttra options to support features other wanted.\n\nrunning `plutotv-scraper --help` will provide some details of the options.\n\nI'll also note that there is a \"feature\" where it will load config.json from the current directory. I'm not yet sure if this is a bug or a feature. For now it is a feature.\n\nI also changed the license from AGPL to MIT, so everyone is free to use it however they want.\n\nFinally, thanks to Matt for providing the original streams for so many years.","author_login":"4v3ngR","author_association":"NONE","created_at":"2024-01-15T12:59:10+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1892134696","fragment_type":"issue_comment","sequence":22,"text":"I read many posts, but I can't understand why can't someone upload another working Pluto addon","author_login":"rocknrollradio","author_association":"NONE","created_at":"2024-01-15T13:00:30+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894870353","fragment_type":"issue_comment","sequence":23,"text":"The playlists and epgs for Plex, Roku and Samsung now appear to have vanished","author_login":"davidmguest","author_association":"NONE","created_at":"2024-01-17T03:16:01+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894880020","fragment_type":"issue_comment","sequence":24,"text":"The Australian and NZ playlists and epgs have gone as well .\nIt looks to me like this is affecting all lists where Matt had his own urls redirecting to the official ones.\nThe Stirr list is still up (for the moment), but that use the official urls.\n\nI wonder if a return to using the official urls without redirection might be acceptable to the providers/host?","author_login":"davidmguest","author_association":"NONE","created_at":"2024-01-17T03:30:34+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894898805","fragment_type":"issue_comment","sequence":25,"text":"Thanks for update. Please update here as well. I don't follow Twitter 👍","author_login":"derrgoo","author_association":"NONE","created_at":"2024-01-17T03:58:53+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894926828","fragment_type":"issue_comment","sequence":26,"text":"Awesome! Huge thanks! Is there an issue with Pluto that is different from the one highlighted earlier?","author_login":"boeder8","author_association":"NONE","created_at":"2024-01-17T04:38:45+08:00","repo_name":"matthuisman/slyguy.addons","issue_id":2069930924,"issue_number":657,"issue_url":"https://github.com/matthuisman/slyguy.addons/issues/657","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0444","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Epic: Implement remaining JetBrains IDE's (CLion, WebStorm, Rider, RubyMine)?","query_context":"We are currently only supporting the following JetBrains IDE's\n- [x] GoLand\n- [x] IntelliJ\n- [x] PHPStorm\n- [x] PyCharm\n\nHowever, we need to add remote development backends support for: \n- [x] CLion ( URL \n- [x] Rider ( URL \n- [x] RubyMine ( URL \n- [x] WebStorm ( URL \n\nRelated:\n- URL \n\n Front conversations\n\n**Callout:** 👋 Are you interested in this feature? We would be interested to talk to you to hear your feedback.\n\nInternal conversation [1]","known_context_document_ids":["gh_issue_1110276915"],"reference_answer":"It should be in `.gitpod.yml` if we create a dependency from the init task. \nWould it as an intermediate solution be ok to simply download the binaries (in docker or init task) instead of configuring the IDE on project level?","answer_document_id":"gh_comment_1038756406","silver_evidence_path":["gh_comment_1268131819","gh_issue_1055875912","gh_comment_1038756406"],"evidence_issue_ids":[1110276915,1055875912],"source_repo_name":"gitpod-io/gitpod","source_issue_id":1110276915,"source_issue_number":7751,"source_issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","target_repo_name":"gitpod-io/gitpod","target_issue_id":1055875912,"target_issue_number":6740,"target_issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","reference_anchor_document_id":"gh_comment_1268131819","reference_answer_author":"svenefftinge","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2778,"anchor_target_overlap":0.1379,"target_answer_overlap":0.1176},"issue_created_at":"2022-01-21T09:59:40+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_1110276915","fragment_type":"issue_description","sequence":0,"text":"Epic: Implement remaining JetBrains IDE's (CLion, WebStorm, Rider, RubyMine)\nWe are currently only supporting the following JetBrains IDE's\n- [x] GoLand\n- [x] IntelliJ\n- [x] PHPStorm\n- [x] PyCharm\n\nHowever, we need to add remote development backends support for: \n- [x] CLion ( URL \n- [x] Rider ( URL \n- [x] RubyMine ( URL \n- [x] WebStorm ( URL \n\nRelated:\n- URL \n\n Front conversations\n\n**Callout:** 👋 Are you interested in this feature? We would be interested to talk to you to hear your feedback.\n\nInternal conversation [1]","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-01-21T09:59:40+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1018362138","fragment_type":"issue_comment","sequence":1,"text":"I think it depends on URL Till we cannot do it automatically with smoke testing it will be tedious to review so many PRs.","author_login":"akosyakov","author_association":"MEMBER","created_at":"2022-01-21T10:07:49+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1121351653","fragment_type":"issue_comment","sequence":2,"text":"Is there any expected time of arrival for other IDEs support?","author_login":"sinansonmez","author_association":"NONE","created_at":"2022-05-09T17:02:53+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1153670564","fragment_type":"issue_comment","sequence":3,"text":"Gitpod current focus is on the IntelliJ experience (which has a lot of overlap with the other JetBrains IDEs), which is also where JetBrains themselves are focussing a lot of their remote development energy. As the experience improves for the other IDEs we'll be looking to roll those as soon as we reasonably can 🙏","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-06-13T09:10:16+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1243714105","fragment_type":"issue_comment","sequence":4,"text":"With URL done, we can simplify our build process to add more components easier.","author_login":"akosyakov","author_association":"MEMBER","created_at":"2022-09-12T13:07:01+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1268131819","fragment_type":"issue_comment","sequence":5,"text":"Hey folks, wanted to give a quick update (as many have asked!). Firstly, thanks so much to all our users who have given feedback in the community for our JetBrains integration. Please continue to do so, we're learning a lot from you and we're able to refine the experience based on your input. \n\nIf you're late to the party, I wanted to give a little background and context into Gitpod IDE support and why we've not yet released full support of the IDEs just yet. For background, we have a partnership with JetBrains. In real terms is that we have conversations with the friendly JetBrains people to help input on the future of JetBrains Gateway as a whole and help create a really great remote dev experience with JetBrains in Gitpod and beyond! \n\nOpening up an IDE is only one step in the process to bringing a great developer experience in Gitpod. Whilst a lot of the Gitpod functionality is shared across the JetBrains IDEs, such as prebuild support, integration of Gitpod task terminals, port forwarding and port behaviours. There are also lots of language specific product changes that need to be made in both Gitpod and JetBrains. \n\n**For example:** \n* Ensuring coverage of plugins / VS Code extensions for the language - see recently added Oracle support in OpenVSX\n* Our documentation support is good - see recently updated Java page\n* Integration with build tools for the language - we are working on Maven right now, etc). \n\nFor that reason we've been a bit deliberate in how (and when) we roll out other IDE support. We don't want to open up an IDE for our Gitpod users to go try the integration, but then be dissapointed (let's say if some aspect of the integration is not up to the standard they expect, some plugin doesn't work, etc). \n\n**In simpler terms: The quality of the experience is really important to us.** \n\nWe just opened up WebStorm and RubyMine (yet to be announced). So hopefully we will get to the remaining IDEs in the coming weeks ! Come join us on Discord, chat about your experience and give us your feedback (we are listening!). We're super excited for what's to come with JetBrains + Gitpod 🙏","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-10-05T08:41:51+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[1055875912],"is_known_query_context":false},{"document_id":"gh_comment_1327763142","fragment_type":"issue_comment","sequence":6,"text":"- Rider + CLion docs published: \n- Changelog in draft, will be published soon\n\nClosing as complete ✅","author_login":"andreafalzetti","author_association":"CONTRIBUTOR","created_at":"2022-11-25T18:11:34+08:00","repo_name":"gitpod-io/gitpod","issue_id":1110276915,"issue_number":7751,"issue_url":"https://github.com/gitpod-io/gitpod/issues/7751","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1055875912","fragment_type":"issue_description","sequence":0,"text":"Epic: JetBrains Prebuilds for Maven\nWe haven't yet investigated this, this ticket is a placeholder for any changes required on our side to make indexing easier for IntelliJ and/or document any processes that improve the performance. \n\n**Remaining**\n\n- [x] Move warmup login in JetBrains Launcher\n - [x] Update JetBrains Launcher to support warmup command [[1]]( URL \n - [x] Move warmup logic from ide-service to JetBrains Launcher [[2]]( URL \n - [x] deploy and rebuild all stable and latest images (re-run nightly jobs)\n- [x] switch 100% of traffic to new ide-service resolver workspace config endpoint\n- [x] decouple JetBrains Launcher from JB IDE images\n- [ ] Remove warmup logic from ide-service.ts in server\n\n**Completed**\n- [x] Allow layering multiple JetBrains products in one image\n\n**Value & measuring the impact**\n- [ ] Sync with Dev Rel on some possible announcements and content or blog posts (e.g. blog post showing working with a single project like petclinic for Maven. Show some performance before/after benchmarks and talk about the relation and relevance to CDEs, Gitpod Prebuilds, etc)\n\n### Considerations\n\n* **Performance and cost implications** - Ideally we need to find a way for a project to opt-in to indexing, without burdening the user with too much (or any configuration) if we can. \n* **Backends included in prebuilds** - Currently backends are loaded on top of an existing workspace, not during pre-build, so for the indexing to be done before the workspace starts we need to have the backend executed within a prebuild. \n\n**Related issues:** \n\n- URL \n- See internal link from discussion with Jetbrains\n- Also see internal thread from Gitpodders discussing implementation\n- URL","author_login":"loujaybee","author_association":"MEMBER","created_at":"2021-11-17T09:03:31+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_971595011","fragment_type":"issue_comment","sequence":1,"text":"The `remote-dev-server.sh` seems to support a `warm-up` command (similar to `installPlugins`) which could be used.","author_login":"U1F984","author_association":"NONE","created_at":"2021-11-17T13:42:52+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_976358214","fragment_type":"issue_comment","sequence":2,"text":"@U1F984 yes, but there are several issues:\n- desktop IDEs right now are not running in prebuilds\n- index is not stored in /workspace folder, so it is not cached and does not survive restart","author_login":"akosyakov","author_association":"MEMBER","created_at":"2021-11-23T10:03:16+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_977196979","fragment_type":"issue_comment","sequence":3,"text":"If it is unfeasible to store the system directory in /workspace maybe Shared project indexes could be used. However this is an ultimate edition feature.","author_login":"U1F984","author_association":"NONE","created_at":"2021-11-23T21:48:01+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_994634205","fragment_type":"issue_comment","sequence":4,"text":"@akosyakov can you link to full workspace back-up issues, etc that might be blocking this issue?","author_login":"loujaybee","author_association":"MEMBER","created_at":"2021-12-15T10:24:45+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1038734964","fragment_type":"issue_comment","sequence":5,"text":"System config and cache directories were moved under `/workspace` folder as a part of URL \n\nWe need to add ability to include JB backend into prebuilds. There following things to consider:\n- indexes created by one backend is mostly not reusable by created by another backend, so there should be a way to configure for which backend indexes should be created per repo/project\n- there are different places where we could configure it, like in .gitpod.yml or in settings of project.\n\nAs a prototype, for the start we could support only IntelliJ indexing and it in .gitpod.yml as an experimental feature.","author_login":"akosyakov","author_association":"MEMBER","created_at":"2022-02-14T07:16:49+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1038756406","fragment_type":"issue_comment","sequence":6,"text":"It should be in `.gitpod.yml` if we create a dependency from the init task. \nWould it as an intermediate solution be ok to simply download the binaries (in docker or init task) instead of configuring the IDE on project level?","author_login":"svenefftinge","author_association":"MEMBER","created_at":"2022-02-14T07:44:23+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1043247611","fragment_type":"issue_comment","sequence":7,"text":"We are currently trying out Gitpod as maintainers of URL and the IntelliJ integration is a big improvement for us a Java developer. \n\nHowever, one of my main use cases is to review and try out PRs and because of the nature of our repository, IntelliJ will take 10 minutes or more to index the project. This makes using workspaces as throwaway instances for trying out things very hard for me.\n\nSo I just tried to explain our use case and highlight how such a feature would considerably unblock our Gitpod adoption 🙂","author_login":"kiview","author_association":"NONE","created_at":"2022-02-17T17:59:08+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1049888098","fragment_type":"issue_comment","sequence":8,"text":"We don't support it natively yet, but I got it working in this branch: URL \n\nImportant bits:\n- make sure that your gradle/maven projects have configured java target compatible with Java in your image (11 in default image) otherwise JDK indexing is stuck: URL \n- add prebuild task: URL \n\nThis task downloads IntelilJ backend which MUST be aligned with URL \nThen it configures to move indexes to the same directory which will be used by real backend in regular workspace and runs warm up.\n\nIf something does not work (hangs) you can run the same task in regular workspace to trace with jstack. Important thought you should use another folder, since only backend can lock the folder at the same time. Please capture then warm task logs and jstack output and share here.","author_login":"akosyakov","author_association":"MEMBER","created_at":"2022-02-24T14:00:10+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1110707633","fragment_type":"issue_comment","sequence":9,"text":"We shipped an **experimental** support of indexing for IntelliJ IDEA using Prebuilds.","author_login":"akosyakov","author_association":"MEMBER","created_at":"2022-04-27T08:29:09+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141921272","fragment_type":"issue_comment","sequence":10,"text":"Adding note that we have URL - To move prebuild configurations to the project page. It might therefore make sense to move the JetBrains prebuilds configurations also to that page in the UI rather than in the configuration.","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-05-31T09:52:44+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1260953958","fragment_type":"issue_comment","sequence":11,"text":"Renamed the title of this issue, it was created a long time ago when our understanding of JetBrains Gateway was just forming. We can see now the opportunity to focus on Maven for the time being to get the Prebuilds and opening IDE experience working really well. I'll scope this issue down now to just Maven. However, we'll come back and open a companion issue for Gradle also in time. Learnings from integrating Maven fully with Gitpod will then also carry over.","author_login":"loujaybee","author_association":"MEMBER","created_at":"2022-09-28T13:55:24+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373843818","fragment_type":"issue_comment","sequence":12,"text":"@andreafalzetti has been doing some analysis to compare:\n\n* starting without prebuild to starting with prebuild\n* restarting a stopped container\n\nWill share on the issue.","author_login":"loujaybee","author_association":"MEMBER","created_at":"2023-01-06T16:09:25+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436763474","fragment_type":"issue_comment","sequence":13,"text":"Work currently paused, waiting on some input from JetBrains.","author_login":"loujaybee","author_association":"MEMBER","created_at":"2023-02-20T11:08:14+08:00","repo_name":"gitpod-io/gitpod","issue_id":1055875912,"issue_number":6740,"issue_url":"https://github.com/gitpod-io/gitpod/issues/6740","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0445","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"macos local run fails?","query_context":"### Can we access your project?\n\n- [X] I give permission for members of the FlutterFlow team to access and test my project for the sole purpose of investigating this issue.\n\n### Current Behavior\n\nflutterflow local run gives below error : CocoaPods's specs repository is too out-of-date to satisfy dependencies. To update the CocoaPods specs, run: pod repo update\n\nif i do pod install --repo-update then i get error : \\[!\\] Unable to find a specification for `firebase_core` depended upon by `cloud_functions`\n\nYou have either:\n\n* mistyped the name or version.\n* not added the source repo that hosts the Podspec to your Podfile.\n\n### Expected Behavior\n\nI did followed everything from internet and tried all possible upgrading , deleting , cleaning , ruby upgrade , cocoappod upgrading , even manual symlinks creation from firebase and nothing helps. I have latest M4 chip macbook , latest os : sequoia 15.5 , with latest xcode 16.4 , latest cocoapod 1.16.2 , latest ruby 3.4.4 , ios 18.5 , simulator with device iphone 16 plus. there is nothing to upgrade. And basic simple local run doesnt works\n\n### Steps to Reproduce\n\n1.just simple local launch doesnt work in any macos even the latest one available in the world.\n\n### Reproducible from Blank\n\n- [ ] The steps to reproduce above start from a blank project.\n\n### Bug Report Code (Required)\n\n\\[!\\] Unable to find a specification for `firebase_core` depended upon by `cloud_functions` You have either: \\* mistyped the name or version. \\* not added the source repo that hosts the Podspec to your Podfile.\n\n### Visual documentation\n\n \n\n### Environment\n\nmarkdown\n- FlutterFlow version: latest desktop APP\n- Platform:MACOS\n- Browser name and version:NA\n- Operating system and version affected: latest M4 chip macbook , latest os : sequoia 15.5 , with latest xcode 16.4 , latest cocoapod 1.16.2 , latest ruby 3.4.4 , ios 18.5 , simulator with device iphone 16 plus.\n\n### Additional Information\n\n*No response*","known_context_document_ids":["gh_issue_3157837594"],"reference_answer":"**Hi there!**\n\nThanks for reporting this issue. It has already been submitted previously, so I’ll go ahead and link both reports and close this one as a duplicate.\n\nI recommend following the main thread here: URL This will help us keep all updates in one place and ensure clearer communication as we work on a resolution.\n\nThanks for your understanding!","answer_document_id":"gh_comment_3020357008","silver_evidence_path":["gh_comment_3023834655","gh_issue_3188689067","gh_comment_3020357008"],"evidence_issue_ids":[3157837594,3188689067],"source_repo_name":"FlutterFlow/flutterflow-issues","source_issue_id":3157837594,"source_issue_number":6023,"source_issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","target_repo_name":"FlutterFlow/flutterflow-issues","target_issue_id":3188689067,"target_issue_number":6085,"target_issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6085","reference_anchor_document_id":"gh_comment_3023834655","reference_answer_author":"Juansarmi","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2632,"anchor_target_overlap":0.6842,"target_answer_overlap":0.1034},"issue_created_at":"2025-06-18T18:39:39+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_3157837594","fragment_type":"issue_description","sequence":0,"text":"macos local run fails\n### Can we access your project?\n\n- [X] I give permission for members of the FlutterFlow team to access and test my project for the sole purpose of investigating this issue.\n\n### Current Behavior\n\nflutterflow local run gives below error : CocoaPods's specs repository is too out-of-date to satisfy dependencies. To update the CocoaPods specs, run: pod repo update\n\nif i do pod install --repo-update then i get error : \\[!\\] Unable to find a specification for `firebase_core` depended upon by `cloud_functions`\n\nYou have either:\n\n* mistyped the name or version.\n* not added the source repo that hosts the Podspec to your Podfile.\n\n### Expected Behavior\n\nI did followed everything from internet and tried all possible upgrading , deleting , cleaning , ruby upgrade , cocoappod upgrading , even manual symlinks creation from firebase and nothing helps. I have latest M4 chip macbook , latest os : sequoia 15.5 , with latest xcode 16.4 , latest cocoapod 1.16.2 , latest ruby 3.4.4 , ios 18.5 , simulator with device iphone 16 plus. there is nothing to upgrade. And basic simple local run doesnt works\n\n### Steps to Reproduce\n\n1.just simple local launch doesnt work in any macos even the latest one available in the world.\n\n### Reproducible from Blank\n\n- [ ] The steps to reproduce above start from a blank project.\n\n### Bug Report Code (Required)\n\n\\[!\\] Unable to find a specification for `firebase_core` depended upon by `cloud_functions` You have either: \\* mistyped the name or version. \\* not added the source repo that hosts the Podspec to your Podfile.\n\n### Visual documentation\n\n \n\n### Environment\n\nmarkdown\n- FlutterFlow version: latest desktop APP\n- Platform:MACOS\n- Browser name and version:NA\n- Operating system and version affected: latest M4 chip macbook , latest os : sequoia 15.5 , with latest xcode 16.4 , latest cocoapod 1.16.2 , latest ruby 3.4.4 , ios 18.5 , simulator with device iphone 16 plus.\n\n### Additional Information\n\n*No response*","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-06-18T18:39:39+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2990988000","fragment_type":"issue_comment","sequence":1,"text":"i have followed above step and no help , as soon as i run last step pod install --repo-update , i get below error:\nAnalyzing dependencies\nPre-downloading: `FirebaseFirestore` from ` URL tag `11.4.0`\ncloud_functions: Using Firebase SDK version '11.4.0' defined in 'firebase_core'\nfirebase_auth: Using Firebase SDK version '11.4.0' defined in 'firebase_core'\nfirebase_messaging: Using Firebase SDK version '11.4.0' defined in 'firebase_core'\nfirebase_performance: Using Firebase SDK version '11.4.0' defined in 'firebase_core'\nfirebase_storage: Using Firebase SDK version '11.4.0' defined in 'firebase_core'\n[!] Unable to find a specification for `firebase_core` depended upon by `cloud_functions`\n\nYou have either:\n * mistyped the name or version.\n * not added the source repo that hosts the Podspec to your Podfile.\n\n----------------\nI think you guys are adding wrong dependency version for cloud functions and firebase.","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-06-20T10:59:38+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2993683850","fragment_type":"issue_comment","sequence":2,"text":"Could you kindly share the output of the `flutter doctor -v` command with us? That will help us better understand your environment and assist you more effectively.","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2025-06-21T17:22:16+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2993691220","fragment_type":"issue_comment","sequence":3,"text":"sure here is output , i installed flutter via flutterflow desktop app only and hope android toolchain should not matter on mac os:\nLast login: Wed Jun 18 13:16:22 on ttys000\ndiksha@Dikshas-MacBook-Air ~ % flutter doctor -v\n\n┌─────────────────────────────────────────────────────────┐\n│ A new version of Flutter is available! │\n│ │\n│ To update to the latest version, run \"flutter upgrade\". │\n└─────────────────────────────────────────────────────────┘\n[✓] Flutter (Channel stable, 3.27.3, on macOS 15.5 24F74 darwin-arm64, locale en-CA)\n • Flutter version 3.27.3 on channel stable at /Users/diksha/Library/Application Support/io.flutterflow.prod.mac/flutter\n • Upstream repository URL \n • Framework revision c519ee916e (5 months ago), 2025-01-21 10:32:23 -0800\n • Engine revision e672b006cb\n • Dart version 3.6.1\n • DevTools version 2.40.2\n\n[✗] Android toolchain - develop for Android devices\n ✗ Unable to locate Android SDK.\n Install Android Studio from: URL \n On first launch it will assist you in installing the Android SDK components.\n (or visit URL for detailed instructions).\n If the Android SDK has been installed to a custom location, please use\n `flutter config --android-sdk` to update to that location.\n\n[✓] Xcode - develop for iOS and macOS (Xcode 16.4)\n • Xcode at /Applications/Xcode.app/Contents/Developer\n • Build 16F6\n • CocoaPods version 1.16.2\n\n[✓] Chrome - develop for the web\n • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome\n\n[!] Android Studio (not installed)\n • Android Studio not found; download from URL \n (or visit URL for detailed instructions).\n\n[✓] VS Code (version 1.101.0)\n • VS Code at /Applications/Visual Studio Code.app/Contents\n • Flutter extension version 3.112.0\n\n[✓] Connected device (4 available)\n • iPhone 16 Plus (mobile) • A453322F-A3CB-459D-9565-B61135BA4762 • ios • com.apple.CoreSimulator.SimRuntime.iOS-18-5 (simulator)\n • macOS (desktop) • macos • darwin-arm64 • macOS 15.5 24F74 darwin-arm64\n • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 15.5 24F74 darwin-arm64\n • Chrome (web) • chrome • web-javascript • Google Chrome 137.0.7151.120\n\n[✓] Network resources\n • All expected network resources are available.\n\n! Doctor found issues in 2 categories.","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-06-21T17:38:35+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3006017949","fragment_type":"issue_comment","sequence":4,"text":"**Hi there!**\n\nJust a quick question—has the issue been resolved on your end with the latest FlutterFlow update?\n\nIf not, I recommend reaching out to our support team through the in-app chat or by emailing support@flutterflow.io. They’ll be able to provide more detailed guidance and assist you further, as this may be beyond what I can help with directly.\n\nThanks!","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2025-06-25T20:14:55+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3006424879","fragment_type":"issue_comment","sequence":5,"text":"no , still same issue with latest 6.0.33 flutterflow desktop app","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-06-25T22:29:46+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3019303568","fragment_type":"issue_comment","sequence":6,"text":"Hi , i reproduced this issue with a blank project , as soon as i add firebase project with basic auth and firebase storage this issue comes. If the project is without firebase then it works.","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-06-30T14:06:01+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3023799919","fragment_type":"issue_comment","sequence":7,"text":"Hello!\n\nPerfect—thanks for confirming! Could you please share the bug report code of the project here so we can take a closer look?","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2025-07-01T12:25:38+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3023834655","fragment_type":"issue_comment","sequence":8,"text":"here is bug report code : IT40kvLlx5NgofVA0JDubPlagio5Jlw6a7gFiO1RaCosfZT2BLMcec/RVERvZ/bhYHx2eVmKo2oW09L3jYThGu5daUmsfYg5zLtqEzvhXkC5eLauFJWgT3NSO59RBUjG1pmziBF4D7J2SiQt1FyENdyQTXftGKbTClgsD6/LZO4=\n\nI created new ticket as well for blank project failing which has more detail but similar only : URL","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-07-01T12:35:29+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[3188689067],"is_known_query_context":false},{"document_id":"gh_comment_3023863211","fragment_type":"issue_comment","sequence":9,"text":"Here’s how you can fix the iOS pod install issue:\n\n### 1\\. Update CocoaPods Specs\n\nIn your project’s `ios/` folder, open a terminal and run:\n\ncd ios\npod install --repo-update\n\nThis updates your local CocoaPods specs and installs dependencies in one step.\n\n### 2\\. Check Your Podfile\n\nMake sure your `ios/Podfile` starts like this:\n\nsource ' URL \nplatform :ios, '12.0'\n\nuse_frameworks!\nuse_modular_headers!\n\ntarget 'Runner' do\n flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))\nend\n\n### 3\\. Clean Pods If the Issue Persists\n\nIf you’re still seeing errors, do a clean install:\n\ncd ios\nrm -rf Pods Podfile.lock\npod install --repo-update\n\n### 4\\. Rebuild the iOS App\n\nFrom the root of your Flutter project:\n\nflutter clean\nflutter pub get\nflutter run\n\n### Why This Works\n\nCocoaPods needs the latest podspecs to find newer versions like `firebase_core 11.4.0`. If they’re missing, pod install fails. Cleaning up Pods ensures no outdated configurations interfere.\n\nLet us know if that helps or if you hit any other issues!","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2025-07-01T12:44:10+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3031846281","fragment_type":"issue_comment","sequence":10,"text":"Again same repeated answers , i have taken all of the above steps multiple times and even beyond that.\nPls just try to simply add firebase integration in blank flutterflow project in the latest ios environment mentioned and u will see the issue , then try to resolve it.","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-07-03T11:01:02+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3032075089","fragment_type":"issue_comment","sequence":11,"text":"Hello again! The reason I’m asking you to try that again is because the issue appears to be only reproducible on your end. Neither I nor any colleagues have been able to replicate it, even after trying the steps you mentioned.\n\nGiven that this seems to be project- or setup-specific rather than a general bug, I recommend reaching out to our Support team directly via support@flutterflow.io or through the in-app chat on the web platform. The GitHub issue tracker is intended for bugs that can be easily reproduced in a new, clean project, and Support is better equipped to handle more specific cases like this.\n\nThanks for your understanding!","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2025-07-03T12:25:02+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3062166146","fragment_type":"issue_comment","sequence":12,"text":"Closing this issue since we haven't heard back from you. If you are still facing the problem please submit a new issue. Thank you!","author_login":"Alezanello","author_association":"COLLABORATOR","created_at":"2025-07-11T12:34:17+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3157837594,"issue_number":6023,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6023","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_3188689067","fragment_type":"issue_description","sequence":0,"text":"Mac os local run fails as soon as firebase project added\n### Can we access your project?\n\n- [X] I give permission for members of the FlutterFlow team to access and test my project for the sole purpose of investigating this issue.\n\n### Current Behavior\n\nMacos local run fails with error : firebase_performance: Using Firebase SDK version '11.4.0' defined in 'firebase_core' \\[!\\] Unable to find a specification for `firebase_core` depended upon by `firebase_auth`. rememeber without firebase my project runs that means i dont have issues with environment on my system.\n\n### Expected Behavior\n\nThis is empty project with just firebase added for auth and storage this is the most basic and empty setup. This is the most important function provided by flutterflow which is broken from at least 3 months. I have been raising tickets and flutterflow team closes it saying that they cant reproduce because my project had lot of things and they never tried to reproduce it with simple blank project.\n\nthe error log at very bottom shows garbage and confusing error related to cocoapod out of date but thats just confusing error , i have done every possible stuff present on internet and even idea provided by u guys to update it. I have created old tickets for same issue for my real project which were closed because it was big project and team said its specific to my project thats why i created now blank project and it fails with same issue : URL URL \n\n### Steps to Reproduce\n\n1. create basic project with firebase on latest macos\n\n### Reproducible from Blank\n\n- [X] The steps to reproduce above start from a blank project.\n\n### Bug Report Code (Required)\n\nIT40kvLlx5NgofVA0JDubPlagio5Jlw6a7gFiO1RaCosfZT2BLMcec/RVERvZ/bhYHx2eVmKo2oW09L3jYThGu5daUmsfYg5zLtqEzvhXkC5eLauFJWgT3NSO59RBUjG1pmziBF4D7J2SiQt1FyENdyQTXftGKbTClgsD6/LZO4=\n\n### Visual documentation\n\n \n\n### Environment\n\nmarkdown\n- FlutterFlow version: latest desktop APP\n- Platform: MACOS\n- Browser name and version:NA\n- Operating system and version affected: latest M4 chip macbook , latest os : sequoia 15.5 , with latest xcode 16.4 , latest cocoapod 1.16.2 , latest ruby 3.4.4 , ios 18.5 , simulator with device iphone 16 plus.\n\n### Additional Information\n\nflutter doctor output : \ni installed flutter via flutterflow desktop app only and hope android toolchain should not matter on mac os:\nLast login: Wed Jun 18 13:16:22 on ttys000\ndiksha@Dikshas-MacBook-Air \\~ % flutter doctor -v\n\n┌─────────────────────────────────────────────────────────┐\n│ A new version of Flutter is available! │\n│ │\n│ To update to the latest version, run \"flutter upgrade\". │\n└─────────────────────────────────────────────────────────┘\n\\[✓\\] Flutter (Channel stable, 3.27.3, on macOS 15.5 24F74 darwin-arm64, locale en-CA)\n• Flutter version 3.27.3 on channel stable at /Users/diksha/Library/Application Support/io.flutterflow.prod.mac/flutter\n• Upstream repository URL \n• Framework revision c519ee916e (5 months ago), 2025-01-21 10:32:23 -0800\n• Engine revision e672b006cb\n• Dart version 3.6.1\n• DevTools version 2.40.2\n\n\\[✗\\] Android toolchain - develop for Android devices\n✗ Unable to locate Android SDK.\nInstall Android Studio from: URL \nOn first launch it will assist you in installing the Android SDK components.\n(or visit URL for detailed instructions).\nIf the Android SDK has been installed to a custom location, please use\nflutter config --android-sdk to update to that location.\n\n\\[✓\\] Xcode - develop for iOS and macOS (Xcode 16.4)\n• Xcode at /Applications/Xcode.app/Contents/Developer\n• Build 16F6\n• CocoaPods version 1.16.2\n\n\\[✓\\] Chrome - develop for the web\n• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome\n\n\\[!\\] Android Studio (not installed)\n• Android Studio not found; download from URL \n(or visit URL for detailed instructions).\n\n\\[✓\\] VS Code (version 1.101.0)\n• VS Code at /Applications/Visual Studio Code.app/Contents\n• Flutter extension version 3.112.0\n\n\\[✓\\] Connected device (4 available)\n• iPhone 16 Plus (mobile) • A453322F-A3CB-459D-9565-B61135BA4762 • ios • com.apple.CoreSimulator.SimRuntime.iOS-18-5 (simulator)\n• macOS (desktop) • macos • darwin-arm64 • macOS 15.5 24F74 darwin-arm64\n• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 15.5 24F74 darwin-arm64\n• Chrome (web) • chrome • web-javascript • Google Chrome 137.0.7151.120\n\n\\[✓\\] Network resources\n• All expected network resources are available.\n\n! Doctor found issues in 2 categories.","author_login":"raichandramohan27ca","author_association":"NONE","created_at":"2025-06-30T14:23:16+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3188689067,"issue_number":6085,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6085","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3020357008","fragment_type":"issue_comment","sequence":1,"text":"**Hi there!**\n\nThanks for reporting this issue. It has already been submitted previously, so I’ll go ahead and link both reports and close this one as a duplicate.\n\nI recommend following the main thread here: URL This will help us keep all updates in one place and ensure clearer communication as we work on a resolution.\n\nThanks for your understanding!","author_login":"Juansarmi","author_association":"COLLABORATOR","created_at":"2025-06-30T18:56:08+08:00","repo_name":"FlutterFlow/flutterflow-issues","issue_id":3188689067,"issue_number":6085,"issue_url":"https://github.com/FlutterFlow/flutterflow-issues/issues/6085","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0446","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Standardising some of the synonym types?","query_context":"Typical ones we use are:\n\n- layperson\n- acronyms\n- abbreviation\n\nWe may also need things like:\n\n- machine-translated (google translate etc).\n\nAFAIK, there is this problem with OBO format that it translated these:\n\nsynonym: \"IGHD\" EXACT ABBREVIATION [DOID:0060870]\n\nInto:\n\n \n \n\nThis is very unfortunate, as it creates incompatible properties all across the OBO sphere.. What is least painful strategy to get out of this problem?","known_context_document_ids":["gh_issue_984824173"],"reference_answer":"@dosumis, regarding order of operations, do you recommend opening a ticket in OMO to incorporate Uberon's abbreviation AP and then pulling that into CL?","answer_document_id":"gh_comment_1046746964","silver_evidence_path":["gh_comment_1046942347","gh_issue_1121886401","gh_comment_1046746964"],"evidence_issue_ids":[984824173,1121886401],"source_repo_name":"information-artifact-ontology/ontology-metadata","source_issue_id":984824173,"source_issue_number":70,"source_issue_url":"https://github.com/information-artifact-ontology/ontology-metadata/issues/70","target_repo_name":"obophenotype/cell-ontology","target_issue_id":1121886401,"target_issue_number":1441,"target_issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","reference_anchor_document_id":"gh_comment_1046942347","reference_answer_author":"bvarner-ebi","reference_answer_author_association":"COLLABORATOR","quality_score":83.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.4286,"target_answer_overlap":0.1667},"issue_created_at":"2021-09-01T07:46:49+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_984824173","fragment_type":"issue_description","sequence":0,"text":"Standardising some of the synonym types\nTypical ones we use are:\n\n- layperson\n- acronyms\n- abbreviation\n\nWe may also need things like:\n\n- machine-translated (google translate etc).\n\nAFAIK, there is this problem with OBO format that it translated these:\n\nsynonym: \"IGHD\" EXACT ABBREVIATION [DOID:0060870]\n\nInto:\n\n \n \n\nThis is very unfortunate, as it creates incompatible properties all across the OBO sphere.. What is least painful strategy to get out of this problem?","author_login":"matentzn","author_association":"CONTRIBUTOR","created_at":"2021-09-01T07:46:49+08:00","repo_name":"information-artifact-ontology/ontology-metadata","issue_id":984824173,"issue_number":70,"issue_url":"https://github.com/information-artifact-ontology/ontology-metadata/issues/70","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1046942347","fragment_type":"issue_comment","sequence":1,"text":"We are also keen on having abbreviation and acronym in CL and UBERON - see URL","author_login":"shawntanzk","author_association":"NONE","created_at":"2022-02-21T14:33:09+08:00","repo_name":"information-artifact-ontology/ontology-metadata","issue_id":984824173,"issue_number":70,"issue_url":"https://github.com/information-artifact-ontology/ontology-metadata/issues/70","linked_issue_ids":[1121886401],"is_known_query_context":false},{"document_id":"gh_comment_1048642875","fragment_type":"issue_comment","sequence":2,"text":"Is a separate ticket required to bring the abbreviation and acronym synonym types into CL and UBERON? Kindly advise what is required to facilitate this. @shawntanzk, given your technical expertise, would you be able to help with the implementation plan?","author_login":"bvarner-ebi","author_association":"NONE","created_at":"2022-02-23T10:32:19+08:00","repo_name":"information-artifact-ontology/ontology-metadata","issue_id":984824173,"issue_number":70,"issue_url":"https://github.com/information-artifact-ontology/ontology-metadata/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048648038","fragment_type":"issue_comment","sequence":3,"text":"lol 100% no expertise >.< \n\nI think this requires community agreement and support/need to push this up the priority list more than anything","author_login":"shawntanzk","author_association":"NONE","created_at":"2022-02-23T10:38:00+08:00","repo_name":"information-artifact-ontology/ontology-metadata","issue_id":984824173,"issue_number":70,"issue_url":"https://github.com/information-artifact-ontology/ontology-metadata/issues/70","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1121886401","fragment_type":"issue_description","sequence":0,"text":"Create synonym_type_property 'abbreviation' for CL\nUBERON has the Annotation property 'abbreviation' (Superproperty 'synonym_type_property'). URL \n\nSo editors can also leverage this property in CL, I request for Annotation property 'abbreviation' to be imported from UBERON into CL.\n\nPR that inspired this request: PR #1440","author_login":"bvarner-ebi","author_association":"COLLABORATOR","created_at":"2022-02-02T12:49:43+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1033046167","fragment_type":"issue_comment","sequence":1,"text":"would be a bit weird to add a uberon specific AP to CL. I've previously used exact synonym in CL but do understand that there might be use cases for that - thoughts on this @dosumis?","author_login":"shawntanzk","author_association":"CONTRIBUTOR","created_at":"2022-02-08T20:46:44+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040073878","fragment_type":"issue_comment","sequence":2,"text":"@shawntanzk (cc @bvarner-ebi )\n \n\nWhile OBO members may not all agree on how strict we should be with the \"exact\" synonym scope, I do think that in CL there are plenty of use cases for the \"abbreviation\" annotation property. E.g. ESC, Treg, TAC... Abbreviations and acronyms are also discussed in the OBOOK here, so we wouldn't be going against consensus practice if we imported that AP. (Uberon has way more APs than CL and I think we've imported at least one before - location grouping - but I can't find mention of it.)","author_login":"paolaroncaglia","author_association":"CONTRIBUTOR","created_at":"2022-02-15T09:56:31+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040083181","fragment_type":"issue_comment","sequence":3,"text":"100% agree that abbreivation AP would be useful in CL, but I guess my question then is should we be adding a specific AP to CL? should this live in a more general location given its usefulness? If so where? This seems to vary and was wondering what the best way to handle this would be. \n\nSome notes on this:\nMONDO seems to have their own AP for abbreviation\nLike things like hasexactsynonym has a GO iri ( URL","author_login":"shawntanzk","author_association":"CONTRIBUTOR","created_at":"2022-02-15T10:06:14+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040112520","fragment_type":"issue_comment","sequence":4,"text":"Yes, it seems that synonym policy/SOP aren't applied homogeneously throughout OBO. Understandably, reaching a consensus may not be a high priority. Would be great to have feedback from others. Perhaps @nicolevasilevsky , who wrote the Mondo synonyms guide, might comment please. :-)","author_login":"paolaroncaglia","author_association":"CONTRIBUTOR","created_at":"2022-02-15T10:34:50+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1040537018","fragment_type":"issue_comment","sequence":5,"text":"Yes, we have our own AP in Mondo. HPO uses a similar AP too, that is their own as well: URL","author_login":"nicolevasilevsky","author_association":"MEMBER","created_at":"2022-02-15T17:04:11+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1046680857","fragment_type":"issue_comment","sequence":6,"text":"I'd favour adding abbreviation as a synonym type to CL ASAP. Could re-use the Uberon one or add to CL following similar pattern. However, I think this should move to OMO or IAO ASAP. It will be a pain to query in integrated resources (e.g. Ubergraph) if every ontology has their own version. \n\nNote - there may be some OBO format compatibility issues","author_login":"dosumis","author_association":"CONTRIBUTOR","created_at":"2022-02-21T09:57:20+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1046746964","fragment_type":"issue_comment","sequence":7,"text":"@dosumis, regarding order of operations, do you recommend opening a ticket in OMO to incorporate Uberon's abbreviation AP and then pulling that into CL?","author_login":"bvarner-ebi","author_association":"COLLABORATOR","created_at":"2022-02-21T10:56:30+08:00","repo_name":"obophenotype/cell-ontology","issue_id":1121886401,"issue_number":1441,"issue_url":"https://github.com/obophenotype/cell-ontology/issues/1441","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0447","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Some font will cause line break in -?","query_context":"If using `xeCJK` and `\\setmainfont{TeX Gyre Termes}`, `{-}` is right, but `-` will cause breakline. I found some in #257 and #145, but the situation is not quite the same.\n\nlatex\n\\documentclass{article}\n\\usepackage{xeCJK}\n% \\usepackage{fontspec}\n\\setmainfont{TeX Gyre Termes}\n% \\setmainfont{Latin Modern Roman}\n\\usepackage{tabularray}\n\\begin{document}\n\\begin{tblr}{colspec={l},hlines,vlines}\nW-ADAPT\\cite{test} \\\\\nW{-}ADAPT\\cite{test} \\\\\n\\end{tblr}\n\\begin{tabular}{|l|}\n\\hline\nW-ADAPT\\cite{test} \\\\\n\\hline\nW{-}ADAPT\\cite{test} \\\\\n\\hline\n\\end{tabular}\n\\end{document}\n\nimage\n\nIf I change `\\setmainfont{TeX Gyre Termes}` to `\\setmainfont{Latin Modern Roman}`. All is normal.\n\nimage\n\nBut if I change it to `\\usepackage{fontspec}` and `\\setmainfont{TeX Gyre Termes}` without using `xeCJK`.\n\nimage","known_context_document_ids":["gh_issue_1610105883"],"reference_answer":"Titled \"Bug in 3.141592653-2.6-0.999995 (TeX Live 2023) with fontspec and tabularray?\"","answer_document_id":"gh_comment_1974117604","silver_evidence_path":["gh_comment_1455043899","gh_issue_912095835","gh_comment_1974117604"],"evidence_issue_ids":[1610105883,912095835],"source_repo_name":"lvjr/tabularray","source_issue_id":1610105883,"source_issue_number":377,"source_issue_url":"https://github.com/lvjr/tabularray/issues/377","target_repo_name":"lvjr/tabularray","target_issue_id":912095835,"target_issue_number":16,"target_issue_url":"https://github.com/lvjr/tabularray/issues/16","reference_anchor_document_id":"gh_comment_1455043899","reference_answer_author":"muzimuzhi","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.3415,"anchor_target_overlap":0.3939,"target_answer_overlap":0.1667},"issue_created_at":"2023-03-05T08:33:28+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_1610105883","fragment_type":"issue_description","sequence":0,"text":"Some font will cause line break in -\nIf using `xeCJK` and `\\setmainfont{TeX Gyre Termes}`, `{-}` is right, but `-` will cause breakline. I found some in #257 and #145, but the situation is not quite the same.\n\nlatex\n\\documentclass{article}\n\\usepackage{xeCJK}\n% \\usepackage{fontspec}\n\\setmainfont{TeX Gyre Termes}\n% \\setmainfont{Latin Modern Roman}\n\\usepackage{tabularray}\n\\begin{document}\n\\begin{tblr}{colspec={l},hlines,vlines}\nW-ADAPT\\cite{test} \\\\\nW{-}ADAPT\\cite{test} \\\\\n\\end{tblr}\n\\begin{tabular}{|l|}\n\\hline\nW-ADAPT\\cite{test} \\\\\n\\hline\nW{-}ADAPT\\cite{test} \\\\\n\\hline\n\\end{tabular}\n\\end{document}\n\nimage\n\nIf I change `\\setmainfont{TeX Gyre Termes}` to `\\setmainfont{Latin Modern Roman}`. All is normal.\n\nimage\n\nBut if I change it to `\\usepackage{fontspec}` and `\\setmainfont{TeX Gyre Termes}` without using `xeCJK`.\n\nimage","author_login":"note286","author_association":"NONE","created_at":"2023-03-05T08:33:28+08:00","repo_name":"lvjr/tabularray","issue_id":1610105883,"issue_number":377,"issue_url":"https://github.com/lvjr/tabularray/issues/377","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1455043899","fragment_type":"issue_comment","sequence":1,"text":"It is a XeTeX bug (see #16), and LuaTeX produces correct result with the same example:\n\nlatex\n\\documentclass{article}\n\\usepackage{fontspec}\n\\setmainfont{TeX Gyre Termes}\n\\usepackage{tabularray}\n\\parindent=0pt\n\\begin{document}\n\\def\\mytext{W-ADAPT[?]}\n\\setbox0=\\hbox{\\mytext}\n\\setbox2=\\vbox{\\hsize=\\wd0 \\mytext} \\box2\n\\setbox2=\\vbox{\\hsize=\\wd0 \\raggedright \\mytext} \\box2\n\\setbox2=\\vbox{\\hsize=\\wd0 \\centering \\mytext} \\box2\n\\setbox2=\\vbox{\\hsize=\\wd0 \\raggedleft \\mytext} \\box2\n\\end{document} \n\nBut it seems the workaround in #16 doesn't work for this case.","author_login":"lvjr","author_association":"OWNER","created_at":"2023-03-05T10:02:50+08:00","repo_name":"lvjr/tabularray","issue_id":1610105883,"issue_number":377,"issue_url":"https://github.com/lvjr/tabularray/issues/377","linked_issue_ids":[912095835],"is_known_query_context":false},{"document_id":"gh_comment_1455048239","fragment_type":"issue_comment","sequence":2,"text":"Thank you for your answer, I have a certain understanding of it. But I am still curious why there are differences between different fonts? What factors of different fonts lead to this situation? I stumbled upon this issue by chance, and when I tried modifying some characters, the problem disappeared, which is really puzzling.","author_login":"note286","author_association":"NONE","created_at":"2023-03-05T10:18:58+08:00","repo_name":"lvjr/tabularray","issue_id":1610105883,"issue_number":377,"issue_url":"https://github.com/lvjr/tabularray/issues/377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1455049166","fragment_type":"issue_comment","sequence":3,"text":"Sorry, I can't answer these questions. Only people familiar with XeTeX source code could answer them (and fix this bug).","author_login":"lvjr","author_association":"OWNER","created_at":"2023-03-05T10:23:14+08:00","repo_name":"lvjr/tabularray","issue_id":1610105883,"issue_number":377,"issue_url":"https://github.com/lvjr/tabularray/issues/377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1455049575","fragment_type":"issue_comment","sequence":4,"text":"I have found a solution in URL and I can deal with this problem again. Thank you very much for your answer.","author_login":"note286","author_association":"NONE","created_at":"2023-03-05T10:24:57+08:00","repo_name":"lvjr/tabularray","issue_id":1610105883,"issue_number":377,"issue_url":"https://github.com/lvjr/tabularray/issues/377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1552161549","fragment_type":"issue_comment","sequence":5,"text":"A hack I came up with was to wrap cells in an `mbox`. For example this style specification\n\n row{1} = {font=\\itshape, cmd=\\mbox}\n\ncauses every cell on row 1 to be wrapped in an mbox, thus suppressing hyphen breaking for any hyphens on row 1. Alternatively, `cmd = \\exhyphenpenalty10000` also works, at least until the bug is fixed.","author_login":"jcrippen","author_association":"NONE","created_at":"2023-05-17T22:20:49+08:00","repo_name":"lvjr/tabularray","issue_id":1610105883,"issue_number":377,"issue_url":"https://github.com/lvjr/tabularray/issues/377","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_912095835","fragment_type":"issue_description","sequence":0,"text":"Unwanted line break for some cell text\nIn fixing issue #15, I found another issue:\n\n`latex\n\\documentclass[11pt]{article}\n\\usepackage{tabularray}\n\\begin{document}\n\\begin{tblr}{ll}\n\\hline\nSrc-Addr & Dest-Addr \\\\\n\\hline\n\\end{tblr}\n\\end{document} \n\n`\nimage\n\nThe result is correct if we change font size to `10pt` or `12pt`.","author_login":"lvjr","author_association":"OWNER","created_at":"2021-06-05T04:16:06+08:00","repo_name":"lvjr/tabularray","issue_id":912095835,"issue_number":16,"issue_url":"https://github.com/lvjr/tabularray/issues/16","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_857278108","fragment_type":"issue_comment","sequence":1,"text":"It's a bug of XeTeX engine:\n URL \n URL \nWe don't need to fix it here.","author_login":"lvjr","author_association":"OWNER","created_at":"2021-06-09T00:17:51+08:00","repo_name":"lvjr/tabularray","issue_id":912095835,"issue_number":16,"issue_url":"https://github.com/lvjr/tabularray/issues/16","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1016338936","fragment_type":"issue_comment","sequence":2,"text":"With the latest package code, there is a wordaround for XeTeX users:\n\nlatex\n\\makeatletter\n\\AddToHook{cmd/TblrAlignBoth/after}{\\@rightskip=-1sp \\rightskip=\\@rightskip}\n\\AddToHook{cmd/TblrAlignLeft/after}{\\@rightskip=-1sp plus 1fil \\rightskip=\\@rightskip}\n\\AddToHook{cmd/TblrAlignCenter/after}{\\@rightskip=-1sp plus 1fil \\rightskip=\\@rightskip}\n\\AddToHook{cmd/TblrAlignRight/after}{\\leftskip=-1sp plus 1fil}\n\\makeatother\n\nAnd it doesn't break any existing test files.\n\nlatex\n\\documentclass[11pt]{article}\n\\usepackage{tabularray}\n\\begin{document}\n\n\\begin{tblr}{jj}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\begin{tblr}{ll}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\begin{tblr}{cc}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\begin{tblr}{rr}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\bigskip\n\\makeatletter\n\\AddToHook{cmd/TblrAlignBoth/after}{\\@rightskip=-1sp \\rightskip=\\@rightskip}\n\\AddToHook{cmd/TblrAlignLeft/after}{\\@rightskip=-1sp plus 1fil \\rightskip=\\@rightskip}\n\\AddToHook{cmd/TblrAlignCenter/after}{\\@rightskip=-1sp plus 1fil \\rightskip=\\@rightskip}\n\\AddToHook{cmd/TblrAlignRight/after}{\\leftskip=-1sp plus 1fil}\n\\makeatother\n\n\\begin{tblr}{jj}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\begin{tblr}{ll}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\begin{tblr}{cc}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\begin{tblr}{rr}\n\\hline\nSrc-Addr & Dest-Addr \\\\\nSrc-Addr & Dest-Addr1111 \\\\\n\\hline\n\\end{tblr}\n\n\\end{document} \n\nimage","author_login":"lvjr","author_association":"OWNER","created_at":"2022-01-19T11:04:22+08:00","repo_name":"lvjr/tabularray","issue_id":912095835,"issue_number":16,"issue_url":"https://github.com/lvjr/tabularray/issues/16","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1974105523","fragment_type":"issue_comment","sequence":3,"text":"There were some discussions on this XeTeX bug on tex-live mail list:\n\n URL \n\n URL","author_login":"lvjr","author_association":"OWNER","created_at":"2024-03-02T00:02:42+08:00","repo_name":"lvjr/tabularray","issue_id":912095835,"issue_number":16,"issue_url":"https://github.com/lvjr/tabularray/issues/16","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1974117604","fragment_type":"issue_comment","sequence":4,"text":"Titled \"Bug in 3.141592653-2.6-0.999995 (TeX Live 2023) with fontspec and tabularray?\"","author_login":"muzimuzhi","author_association":"COLLABORATOR","created_at":"2024-03-02T00:12:32+08:00","repo_name":"lvjr/tabularray","issue_id":912095835,"issue_number":16,"issue_url":"https://github.com/lvjr/tabularray/issues/16","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0449","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"test PPC with LLVM_IAS=1?","query_context":"@aik sent a series for enabling LLVM_IAS=1. @mpe accepted it, so it should be in linux-next soon. The cover letter mentions we need URL that @nemanjai is working on. As soon as that lands, we should be able to start testing probably our ppc64le configs on linux-next with clang-14 with LLVM_IAS=1 enabled.","known_context_document_ids":["gh_issue_1090119776"],"reference_answer":"@MaskRay noted\n \ngit://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\nmaster and got a conflict.\nSeems that URL \n(\"[PATCH kernel v4] powerpc/64: Add UADDR64 relocation support\") fixed\nthe issue.\nIt just doesn't change arch/powerpc/boot/crt0.S\n\nSo this seems implicitly fixed in -next.\ncommit d79976918852 (\"powerpc/64: Add UADDR64 relocation support\")\n \n\nfedora and suse CI green runs.","answer_document_id":"gh_comment_1064541550","silver_evidence_path":["gh_comment_1059786077","gh_issue_1126635462","gh_comment_1064541550"],"evidence_issue_ids":[1090119776,1126635462],"source_repo_name":"ClangBuiltLinux/continuous-integration2","source_issue_id":1090119776,"source_issue_number":265,"source_issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","target_repo_name":"ClangBuiltLinux/linux","target_issue_id":1126635462,"target_issue_number":1581,"target_issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","reference_anchor_document_id":"gh_comment_1059786077","reference_answer_author":"nickdesaulniers","reference_answer_author_association":"MEMBER","quality_score":93.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0667,"anchor_target_overlap":0.2,"target_answer_overlap":0.2571},"issue_created_at":"2021-12-28T20:45:54+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_1090119776","fragment_type":"issue_description","sequence":0,"text":"test PPC with LLVM_IAS=1\n@aik sent a series for enabling LLVM_IAS=1. @mpe accepted it, so it should be in linux-next soon. The cover letter mentions we need URL that @nemanjai is working on. As soon as that lands, we should be able to start testing probably our ppc64le configs on linux-next with clang-14 with LLVM_IAS=1 enabled.","author_login":"nickdesaulniers","author_association":"MEMBER","created_at":"2021-12-28T20:45:54+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1004467786","fragment_type":"issue_comment","sequence":1,"text":"It also needs the hwsync suport which is already merged in LLVM.","author_login":"mpe","author_association":"NONE","created_at":"2022-01-04T01:38:34+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1013340247","fragment_type":"issue_comment","sequence":2,"text":"With D115419 applied and Linux at commit 112450df61b7 (\"Merge branch 'i2c/for-mergewindow' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux\"), we get closer to building a `powernv_defconfig` kernel with `LLVM=1`:\n\n$ make -skj\"$(nproc)\" ARCH=powerpc LLVM=1 powernv_defconfig all\n/usr/sbin/ld: unrecognised emulation mode: elf64lppc\nSupported emulations: elf_x86_64 elf32_x86_64 elf_i386 elf_iamcu elf_l1om elf_k1om\nclang-14: error: linker command failed with exit code 1 (use -v to see invocation)\nmake[2]: *** [arch/powerpc/kernel/vdso64/Makefile:44: arch/powerpc/kernel/vdso64/vdso64.so.dbg] Error 1\n...\n\nThis is URL If I quickly hack around that error:\n\ndiff\ndiff --git a/arch/powerpc/kernel/vdso64/Makefile b/arch/powerpc/kernel/vdso64/Makefile\nindex 3c5baaa6f1e7..45dc62ba1541 100644\n--- a/arch/powerpc/kernel/vdso64/Makefile\n+++ b/arch/powerpc/kernel/vdso64/Makefile\n@@ -39,6 +39,8 @@ asflags-y := -D__VDSO64__ -s\n targets += vdso64.lds\n CPPFLAGS_vdso64.lds += -P -C -U$(ARCH)\n\n+vdsold-$(CONFIG_LD_IS_LLD) := -fuse-ld=lld\n+\n # link rule for the .so file, .lds has to be first\n $(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) $(obj)/vgettimeofday.o FORCE\n $(call if_changed,vdso64ld_and_check)\n@@ -53,4 +55,4 @@ include/generated/vdso64-offsets.h: $(obj)/vdso64.so.dbg FORCE\n\n # actual build commands\n quiet_cmd_vdso64ld_and_check = VDSO64L $@\n- cmd_vdso64ld_and_check = $(CC) $(c_flags) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^); $(cmd_vdso_check)\n+ cmd_vdso64ld_and_check = $(CC) $(c_flags) $(vdsold-y) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^); $(cmd_vdso_check)\n\nI get another one:\n\nld.lld: warning: cannot find entry symbol _start; not setting start address\nobjcopy: Unable to recognise the format of the input file `vmlinux'\nmake[2]: *** [arch/powerpc/boot/Makefile:391: arch/powerpc/boot/zImage.pseries] Error 1\nobjcopy: Unable to recognise the format of the input file `vmlinux'\nmake[2]: *** [arch/powerpc/boot/Makefile:391: arch/powerpc/boot/zImage.epapr] Error 1\nmake[2]: Target 'arch/powerpc/boot/zImage' not remade because of errors.\nmake[1]: *** [arch/powerpc/Makefile:283: zImage] Error 2\n\nLooks like `arch/powerpc/boot/wrapper` has hardcoded references to the GNU tools (e.g. `${CROSS}objcopy`), so we cannot omit `CROSS_COMPILE` for now. After adding `CROSS_COMPILE=powerpc64le-linux-gnu-` back to the command line, I get a kernel that boots in QEMU:\n\n$ boot-qemu.sh -a ppc64le -k . -t 30s\nQEMU location: /qemu/bin\n\nQEMU version: QEMU emulator version 6.2.50 (v6.2.0-39-g0da6106883)\n...\n[ 0.000000][ T0] Linux version 5.16.0-09670-g112450df61b7-dirty (nathan@archlinux-ax161) (ClangBuiltLinux clang version 14.0.0 ( URL 1344e35c9822db4998d9eec7f219ecab700ecaa1), LLD 14.0.0) #1 SMP Fri Jan 14 17:53:20 UTC 2022\n...\n\n`ppc64le_defconfig` builds as well.\n\nVery close!","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-01-14T18:02:16+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1013423972","fragment_type":"issue_comment","sequence":3,"text":"When I looked last time I explored this for hermetic builds a couple of years ago, it was not super apparent what the fix should be because it sounds like `arch/powerpc/boot/wrapper` is used in other projects so we cannot just convert those references over to `${OBJCOPY}` or the like (@mpe can correct me if I am wrong). It looks like @gwelymernans touched this area in 5.11, perhaps he could shed some light on how we might work around this.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-01-14T19:40:11+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1014482016","fragment_type":"issue_comment","sequence":4,"text":"Do you have a link to the discussion from a couple of years ago?\n\nAFAIK the wrapper is not used in any other projects, although that was the idea of it originally.\n\nIt is potentially called by other scripts from outside the kernel tree. I think in the old days maybe some distro scripts called it, but I think the modern distros don't. Possibly some 32-bit embedded stuff still uses it.\n\nAlso eg. see torvalds/linux@528229d210781b2da66c6d257a326c21099982b5, which talks about \"the signing tool\" calling the wrapper script. I'm not sure that signing tool was ever released, and it's basically dead now, but that's the kind of thing we have to keep in mind, external scripts that call the wrapper and expect it to behave a certain way.\n\nSo the main thing is to make any change backward compatible, if possible. ie. so that an existing caller will get the same behaviour it used to.\n\nWhat is the LLVM alternative to `objcopy` ?","author_login":"mpe","author_association":"NONE","created_at":"2022-01-17T12:46:10+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018882794","fragment_type":"issue_comment","sequence":5,"text":"I have tried to find it but I do not recall ever bringing this up to upstream, so I could be misremembering something... _shrugs_\n \n \n \n \n \n \n \n\nAck. I have hacked something up that works for `powernv_defconfig` when building `zImage.epapr`:\n\n URL \n\n$ make -skj\"$(nproc)\" ARCH=powerpc LLVM=1 distclean powernv_defconfig zImage.epapr\nld.lld: warning: cannot find entry symbol _start; not setting start address\n\n$ boot-qemu.sh -a ppc64le -k . -t 30s\nQEMU location: /usr/bin\n\nQEMU version: QEMU emulator version 6.2.0\n...\n[ 0.000000][ T0] Linux version 5.16.0-11415-gc1a97611aaa2 (nathan@dev-arch.archlinux-ax161) (ClangBuiltLinux clang version 14.0.0 ( URL d4ffb6ec65d7173ee63fa0e70eedd049944ceeff), LLD 14.0.0) #1 SMP Fri Jan 21 12:16:52 MST 2022\n...\n\nHowever, the build fails when building `zImage.pseries` (included in the `all` target, obviously related to the new use of `ld.lld`):\n\n$ make -skj\"$(nproc)\" ARCH=powerpc LLVM=1 distclean powernv_defconfig all\n...\nld.lld: error: relocation R_PPC64_ADDR64 cannot be used against symbol '_start'; recompile with -fPIC\n \n\nld.lld: error: relocation R_PPC64_ADDR64 cannot be used against symbol '_etext'; recompile with -fPIC\n \n\nld.lld: error: relocation R_PPC64_ADDR64 cannot be used against symbol '__bss_start'; recompile with -fPIC\n \n\nld.lld: error: relocation R_PPC64_ADDR64 cannot be used against symbol '_end'; recompile with -fPIC\n \nmake[2]: *** [arch/powerpc/boot/Makefile:400: arch/powerpc/boot/zImage.pseries] Error 1\n...\n\nIf I apply the same fix as commit 4c078c86b4a4 (\"powerpc/boot/wrapper: Add \"-z notext\" flag to disable diagnostic\") to the `pseries` case in `arch/powerpc/boot/wrapper`, `zImage.pseries` builds successfully and I can boot it in QEMU, just like `zImage.epapr`.\n\nThere was one other issue I noticed with `ppc44x_defconfig` (the 32-bit config that we test and boot) related to `relro`. I solved this by adding `-z norelro`.\n \n\n`llvm-objcopy` :)","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-01-21T21:37:36+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1047271436","fragment_type":"issue_comment","sequence":6,"text":"I realized that `tuxsuite` provides `CROSS_COMPILE` so we can actually enable this configuration with `LLVM_IAS=1` as soon as URL is merged, which will allow us to workaround URL and URL","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-02-21T22:31:01+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1059786077","fragment_type":"issue_comment","sequence":7,"text":"I am reopening this due to #324 and URL I build tested it locally but did not boot test.\n\nI will likely just build these configurations with `ld.bfd` in the meantime but I am open to other suggestions.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-03-05T15:48:23+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[1126635462],"is_known_query_context":false},{"document_id":"gh_comment_1062254467","fragment_type":"issue_comment","sequence":8,"text":"So we have a few different ways to work around URL \n\n1. Disable the boot tests for the distribution configurations.\n2. Disable `CONFIG_RELOCATABLE=y` for the distribution configurations.\n3. Use `ld.bfd` instead of `ld.lld`.\n\n@nickdesaulniers do you have a preference?","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-03-08T21:55:06+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[1126635462],"is_known_query_context":false},{"document_id":"gh_comment_1062463202","fragment_type":"issue_comment","sequence":9,"text":"IMHO `ld.lld` having an \"imprecise\" value for `DT_RELACOUNT` is just plainly a bug in `ld.lld`.\n\nOur relocation code is primitive, it runs very very early in boot, and no doubt it could be improved, but it has worked for the last ~13 years with no issue.","author_login":"mpe","author_association":"NONE","created_at":"2022-03-09T01:32:11+08:00","repo_name":"ClangBuiltLinux/continuous-integration2","issue_id":1090119776,"issue_number":265,"issue_url":"https://github.com/ClangBuiltLinux/continuous-integration2/issues/265","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1126635462","fragment_type":"issue_description","sequence":0,"text":"Boot hang with certain PowerPC configurations after da0e5b885b25cf4ded0fa89b965dc6979ac02ca9\nAfter URL both Fedora and OpenSUSE's powerpc64le configurations fail to boot for me in QEMU. On v5.17-rc3:\n\n$ curl -LSso .config URL \n\n$ make -skj\"$(nproc)\" ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- LLVM=1 LLVM_IAS=0 olddefconfig zImage.epapr\n\n$ boot-qemu.sh -a ppc64le -k . -t 45s\n...\n[ 10.042804807,5] INIT: Waiting for kernel...\n[ 10.042963994,5] INIT: platform wait for kernel load failed\n[ 10.043178236,5] INIT: Assuming kernel at 0x20000000\n[ 10.043400737,5] INIT: 64-bit LE kernel discovered\n[ 10.043816082,2] NVRAM: Failed to load\n[ 10.092415012,5] INIT: Starting kernel at 0x20010000, fdt at 0x3068dbd0 16441 bytes\n\nzImage starting: loaded at 0x0000000020010000 (sp: 0x0000000020cdcda0)\nAllocating 0x2c37501 bytes for kernel...\nDecompressing (0x0000000000000000 <- 0x0000000020023000:0x0000000020cdb275)...\nDone! Decompressed 0x2a60000 bytes\n\nLinux/PowerPC load:\nFinalizing device tree... flat tree at 0x20cddca0\nqemu-system-ppc64: terminating on signal 15 from pid 863670 (timeout)\n+ RET=124\n+ set +x\n\nAt the commit prior to that one, the kernel fires right up:\n\n[ 10.046432374,5] INIT: Waiting for kernel...\n[ 10.046600313,5] INIT: platform wait for kernel load failed\n[ 10.046828764,5] INIT: Assuming kernel at 0x20000000\n[ 10.047069394,5] INIT: 64-bit LE kernel discovered\n[ 10.047512051,2] NVRAM: Failed to load\n[ 10.097703665,5] INIT: Starting kernel at 0x20010000, fdt at 0x3068dbd0 16441 bytes\n\nzImage starting: loaded at 0x0000000020010000 (sp: 0x0000000020cdcda0)\nAllocating 0x2c37501 bytes for kernel...\nDecompressing (0x0000000000000000 <- 0x0000000020023000:0x0000000020cdb254)...\nDone! Decompressed 0x2a60000 bytes\n\nLinux/PowerPC load:\nFinalizing device tree... flat tree at 0x20cddca0\n[ 0.000000] dt-cpu-ftrs: setup for ISA 2070\n[ 0.000000] dt-cpu-ftrs: not enabling: subcore (unknown and unsupported by kernel)\n[ 0.000000] dt-cpu-ftrs: final cpu/mmu features = 0x000000fb8f5db187 0x3c006001\n[ 0.000000] hash-mmu: Page sizes from device-tree:\n[ 0.000000] hash-mmu: base_shift=12: shift=12, sllp=0x0000, avpnm=0x00000000, tlbiel=1, penc=0\n[ 0.000000] hash-mmu: base_shift=12: shift=16, sllp=0x0000, avpnm=0x00000000, tlbiel=1, penc=7\n[ 0.000000] hash-mmu: base_shift=12: shift=24, sllp=0x0000, avpnm=0x00000000, tlbiel=1, penc=56\n[ 0.000000] hash-mmu: base_shift=16: shift=16, sllp=0x0110, avpnm=0x00000000, tlbiel=1, penc=1\n[ 0.000000] hash-mmu: base_shift=16: shift=24, sllp=0x0110, avpnm=0x00000000, tlbiel=1, penc=8\n[ 0.000000] hash-mmu: base_shift=24: shift=24, sllp=0x0100, avpnm=0x00000001, tlbiel=0, penc=0\n[ 0.000000] hash-mmu: base_shift=34: shift=34, sllp=0x0120, avpnm=0x000007ff, tlbiel=0, penc=3\n[ 0.000000] Enabling pkeys with max key count 32\n[ 0.000000] Activating Kernel Userspace Access Prevention\n[ 0.000000] Activating Kernel Userspace Execution Prevention\n[ 0.000000] Using 1TB segments\n[ 0.000000] hash-mmu: Initializing hash mmu with SLB\n[ 0.000000] Linux version 5.17.0-rc3 (nathan@dev-arch.archlinux-ax161) (ClangBuiltLinux clang version 14.0.0 ( URL 460830a9c664e8cce959c660648faa7747ad8bdc), LLD 14.0.0) #1 SMP Mon Feb 7 16:59:00 MST 2022\n[ 0.000000] Found initrd at 0xc000000028000000:0xc000000028856200\n...\n\nI have done no further triage, as I am currently testing a few different things. cc @MaskRay in case something obvious sticks out to you. I am happy to provide any information that might make figuring out what is going wrong any easier.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-02-08T00:02:57+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1034058932","fragment_type":"issue_comment","sequence":1,"text":"I encounter a pahole (my `apt info dwarves` is `1.20-1+gl0`) issue.\n\n LD .tmp_vmlinux.btf\n BTF .btf.vmlinux.bin.o\n[750483] INT DW_ATE_unsigned_56 Error emitting BTF type\nEncountered error while encoding BTF.\n LD .tmp_vmlinux.kallsyms1\n KSYMS .tmp_vmlinux.kallsyms1.S\n AS .tmp_vmlinux.kallsyms1.S\n LD .tmp_vmlinux.kallsyms2\n KSYMS .tmp_vmlinux.kallsyms2.S\n AS .tmp_vmlinux.kallsyms2.S\n LD vmlinux\n BTFIDS vmlinux\nFAILED: load BTF from vmlinux: Invalid argument\nmake[2]: *** [/home/maskray/Dev/linux/Makefile:1155: vmlinux] Error 255\nmake[2]: *** Deleting file 'vmlinux'\nmake[1]: *** [/home/maskray/Dev/linux/Makefile:350: __build_one_by_one] Error 2\nmake[1]: Leaving directory '/tmp/linux/ppc64le'\nmake: *** [Makefile:219: __sub-make] Error 2\n\nThe change refactored how `DT_RELACOUNT` (shown as `RELACOUNT` in `readelf -d` output), which is defined for `-z combreloc` (default): the number of `R_*_RELATIVE` relocations in the beginning of `.rela.dyn`. I can find some `RELACOUNT` usage in arch/powerpc/ . Is the `DT_RELACOUNT` value now wrong?\n\n% rg RELACOUNT\ninclude/uapi/linux/elf.h\n108:#define DT_RELACOUNT 0x6ffffff9\n\narch/powerpc/kernel/reloc_64.S\n11:RELACOUNT = 0x6ffffff9\n30: * Scan the dynamic section for the RELA and RELACOUNT entries.\n41:2: addis r6,r6,(-RELACOUNT)@ha\n42: cmpdi r6,RELACOUNT@l\n44: ld r8,8(r11) /* get RELACOUNT value in r8 */\n47:4: cmpdi r7,0 /* check we have both RELA and RELACOUNT */\n\narch/powerpc/boot/crt0.S\n11:RELACOUNT = 0x6ffffff9\n68: * We need the RELA and RELACOUNT entries. */\n78:11: addis r8,r8,(-RELACOUNT)@ha\n79: cmpwi r8,RELACOUNT@l\n81: lwz r0,4(r12) /* get RELACOUNT value in r0 */\n88: * The R_PPC_RELATIVE ones come first and there are RELACOUNT\n163:10: addis r12,r12,(-RELACOUNT)@ha\n164: cmpdi r12,RELACOUNT@l\n166: ld r8,8(r11) /* get RELACOUNT value in r8 */\n170: cmpdi r13,0 /* check we have both RELA and RELACOUNT */","author_login":"MaskRay","author_association":"MEMBER","created_at":"2022-02-09T18:18:09+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1034100267","fragment_type":"issue_comment","sequence":2,"text":"`vmlinux` has some position-independent long branch thunks which need `R_*_RELATIVE` relocations. In such a case, ld.lld generated `DT_RELACOUNT` value is smaller than the actual value. I can make it correct but.. well, it's just more code without many benefits.\n\nglibc logic is the following and a smaller DT_LACOUNT value will still work.\n\nc\nTreat the DT_RELACOUNT relocations as R_PPC64_RELATIVE. Don't check their type\n\nFor the rest relocations, check the type and perform R_PPC64_RELATIVE/R_PPC64_ADDR64/...\n\nThe arch/powerpc code just seems to assume that there is no `R_PPC64_RELATIVE` after the first `DT_RELACOUNT` relocations.","author_login":"MaskRay","author_association":"MEMBER","created_at":"2022-02-09T19:07:58+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1034134726","fragment_type":"issue_comment","sequence":3,"text":"There's probably some important context as _why_ the number of that type of relocation is hard coded in the source...","author_login":"nickdesaulniers","author_association":"MEMBER","created_at":"2022-02-09T19:50:54+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1048213536","fragment_type":"issue_comment","sequence":4,"text":"It appears that `arch/powerpc/kernel/reloc_64.S` is the code that handles these relocations. I am not sure how it should be reworked to handle `ld.lld`'s imprecise `DT_RELACOUNT` value.\n\ncc @aik since I noticed you opened URL above.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-02-22T21:08:54+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1062571454","fragment_type":"issue_comment","sequence":5,"text":"This patch can fix the issue\n\npatch\nFrom 9822ba2edb1808a2cf3a4690178d20a0ea8dfd36 Mon Sep 17 00:00:00 2001\nFrom: Fangrui Song \nDate: Tue, 8 Mar 2022 21:31:51 -0800\nSubject: [PATCH] ppc64: Replace DT_RELACOUNT usage with DT_RELASZ\n\nDT_RELACOUNT is an ELF dynamic tag inherited from SunOS indicating the number\nof R_*_RELATIVE relocations. It is optional but {ld.lld,ld.lld} -z combreloc\nalways creates it (if non-zero) to slightly speed up glibc ld.so relocation\nresolving. The tag is otherwise nearly unused.\n\nlld>=15 (since commit da0e5b885b25cf4ded0fa89b965dc6979ac02ca9) underestimates\nDT_RELACOUNT for ppc64 when position-independent long branch thunks are used.\nSince our code always compares the relocation type with R_PPC64_RELATIVE,\nreplacing every occurrence of DT_RELACOUNT with\nDT_RELASZ/sizeof(Elf64_Rela)=DT_RELASZ/24 is correct. Make such changes to\navoid using the obscure DT_RELACOUNT.\n\nFor an unsigned 32-bit integer (the bound of DT_RELASZ), x divided by 24\ncan be implemented as x*0xaaaaaaab >> 4.\n\nLink: URL \nReported-by: Nathan Chancellor \nSigned-off-by: Fangrui Song \n---\n arch/powerpc/boot/crt0.S | 28 +++++++++++++++++-----------\n arch/powerpc/kernel/reloc_64.S | 15 +++++++++------\n 2 files changed, 26 insertions(+), 17 deletions(-)\n\ndiff --git a/arch/powerpc/boot/crt0.S b/arch/powerpc/boot/crt0.S\nindex feadee18e271..1c96ebe7ef1a 100644\n--- a/arch/powerpc/boot/crt0.S\n+++ b/arch/powerpc/boot/crt0.S\n@@ -8,7 +8,7 @@\n #include \"ppc_asm.h\"\n \n RELA = 7\n-RELACOUNT = 0x6ffffff9\n+RELASZ = 8\n \n .data\n /* A procedure descriptor used when booting this as a COFF file.\n@@ -65,7 +65,7 @@ p_base: mflr r10 /* r10 now points to runtime addr of p_base */\n subf r11,r11,r12 /* runtime - linktime offset */\n \n /* The dynamic section contains a series of tagged entries.\n- * We need the RELA and RELACOUNT entries. */\n+ * We need the RELA and RELASZ entries. */\n li r9,0\n li r0,0\n 9: lwz r8,0(r12) /* get tag */\n@@ -75,18 +75,21 @@ p_base: mflr r10 /* r10 now points to runtime addr of p_base */\n bne 11f\n lwz r9,4(r12) /* get RELA pointer in r9 */\n b 12f\n-11: addis r8,r8,(-RELACOUNT)@ha\n- cmpwi r8,RELACOUNT@l\n+11: cmpwi r8,RELASZ\n bne 12f\n- lwz r0,4(r12) /* get RELACOUNT value in r0 */\n+ lwz r0,4(r12) /* get RELASZ / 24 in r0 */\n+ lis r8,0xaaaa\n+ ori r8,r8,0xaaab\n+ mulhwu r0,r0,r8\n+ srwi r0,r0,4\n 12: addi r12,r12,8\n b 9b\n \n /* The relocation section contains a list of relocations.\n * We now do the R_PPC_RELATIVE ones, which point to words\n * which need to be initialized with addend + offset.\n- * The R_PPC_RELATIVE ones come first and there are RELACOUNT\n- * of them. */\n+ * The R_PPC_RELATIVE ones come first and there are at most\n+ * RELASZ/24 of them. */\n 10: /* skip relocation if we don't have both */\n cmpwi r0,0\n beq 3f\n@@ -160,14 +163,17 @@ p_base: mflr r10 /* r10 now points to runtime addr of p_base */\n bne 10f\n ld r13,8(r11) /* get RELA pointer in r13 */\n b 11f\n-10: addis r12,r12,(-RELACOUNT)@ha\n- cmpdi r12,RELACOUNT@l\n+10: cmpdi r12,RELASZ\n bne 11f\n- ld r8,8(r11) /* get RELACOUNT value in r8 */\n+ ld r8,8(r11) /* get RELASZ / 24 in r8 */\n+ lis r0,0xaaaa\n+ ori r0,r0,0xaaab\n+ mulhwu r8,r8,r0\n+ srwi r8,r8,4\n 11: addi r11,r11,16\n b 9b\n 12:\n- cmpdi r13,0 /* check we have both RELA and RELACOUNT */\n+ cmpdi r13,0 /* check we have both RELA and RELASZ */\n cmpdi cr1,r8,0\n beq 3f\n beq cr1,3f\ndiff --git a/arch/powerpc/kernel/reloc_64.S b/arch/powerpc/kernel/reloc_64.S\nindex 02d4719bf43a..362be759609f 100644\n--- a/arch/powerpc/kernel/reloc_64.S\n+++ b/arch/powerpc/kernel/reloc_64.S\n@@ -8,7 +8,7 @@\n #include \n \n RELA = 7\n-RELACOUNT = 0x6ffffff9\n+RELASZ = 8\n R_PPC64_RELATIVE = 22\n \n /*\n@@ -27,7 +27,7 @@ _GLOBAL(relocate)\n add r10,r10,r12 /* r10 has runtime addr of _stext */\n \n /*\n- * Scan the dynamic section for the RELA and RELACOUNT entries.\n+ * Scan the dynamic section for the RELA and RELASZ entries.\n */\n li r7,0\n li r8,0\n@@ -38,13 +38,16 @@ _GLOBAL(relocate)\n bne 2f\n ld r7,8(r11) /* get RELA pointer in r7 */\n b 3f\n-2: addis r6,r6,(-RELACOUNT)@ha\n- cmpdi r6,RELACOUNT@l\n+2: cmpdi r6,RELASZ\n bne 3f\n- ld r8,8(r11) /* get RELACOUNT value in r8 */\n+ ld r8,8(r11) /* get RELA / 24 in r8 */\n+ lis r0,0xaaaa\n+ ori r0,r0,0xaaab\n+ mulhwu r8,r8,r0\n+ srwi r8,r8,4\n 3: addi r11,r11,16\n b 1b\n-4: cmpdi r7,0 /* check we have both RELA and RELACOUNT */\n+4: cmpdi r7,0 /* check we have both RELA and RELASZ */\n cmpdi cr1,r8,0\n beq 6f\n beq cr1,6f\n-- \n2.35.1","author_login":"MaskRay","author_association":"MEMBER","created_at":"2022-03-09T05:34:48+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[1126635462],"is_known_query_context":false},{"document_id":"gh_comment_1063271782","fragment_type":"issue_comment","sequence":6,"text":"Thanks a lot Fangrui! That patch works for me, I have provided a tag upstream.\n\n URL","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-03-09T19:18:52+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1064541550","fragment_type":"issue_comment","sequence":7,"text":"@MaskRay noted\n \ngit://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\nmaster and got a conflict.\nSeems that URL \n(\"[PATCH kernel v4] powerpc/64: Add UADDR64 relocation support\") fixed\nthe issue.\nIt just doesn't change arch/powerpc/boot/crt0.S\n\nSo this seems implicitly fixed in -next.\ncommit d79976918852 (\"powerpc/64: Add UADDR64 relocation support\")\n \n\nfedora and suse CI green runs.","author_login":"nickdesaulniers","author_association":"MEMBER","created_at":"2022-03-10T21:56:27+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1064542247","fragment_type":"issue_comment","sequence":8,"text":"cc @aik @mpe on @MaskRay 's comment about arch/powerpc/boot/crt0.S. Should @MaskRay resend just his hunks against that patch?","author_login":"nickdesaulniers","author_association":"MEMBER","created_at":"2022-03-10T21:57:23+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1064551898","fragment_type":"issue_comment","sequence":9,"text":"Do note that both of those runs did not use `LD=ld.lld` (see the `CC=clang`). Let me test `next-20220310` with both of those configurations locally then I will update URL by dropping Fangrui's patch and applying Alexey's patch to mainline.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-03-10T22:08:44+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1082508958","fragment_type":"issue_comment","sequence":10,"text":"Merged into mainline: URL \n\nI am not sure this would be an acceptable backport for stable, so I am just going to close this up for now.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-03-30T00:55:54+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1103193834","fragment_type":"issue_comment","sequence":11,"text":"As d799769188529abc6cbf035a10087a51f7832b6b also resolves #1594, I have started a thread about whether or not applying that change to stable is appropriate.","author_login":"nathanchance","author_association":"MEMBER","created_at":"2022-04-19T21:31:40+08:00","repo_name":"ClangBuiltLinux/linux","issue_id":1126635462,"issue_number":1581,"issue_url":"https://github.com/ClangBuiltLinux/linux/issues/1581","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0450","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"2-way sync maybe possible now?","query_context":"With the higher accuracy, maybe a 2-way sync like the trakt plugin is now possible?\n\nMaybe there is a somewhat reasonable way to-do this now, its just super convienent to have all your watched status in trakt and simply do a sync on a fresh install, so everything is back where you left.\n\nSo for normal shows/movies using the trakt plugin i dont have to care about any backup or library state, i can just reinstall the server point it to my libs and via a trakt resync all watched states are set to where i left off.\n\nWould be super cool to have this also for Anime, but i understand that this can be more complex to get right.","known_context_document_ids":["gh_issue_1267750981"],"reference_answer":"Hi, unfortunately it only updates MAL after you have actively watched something. \nThat being said I will add this to the main project as a possible addition later on down the line, as it seems to be a good feature to add to the plugin.","answer_document_id":"gh_comment_1100630288","silver_evidence_path":["gh_comment_1152965802","gh_issue_1206059249","gh_comment_1100630288"],"evidence_issue_ids":[1267750981,1206059249],"source_repo_name":"vosmiic/jellyfin-ani-sync","source_issue_id":1267750981,"source_issue_number":20,"source_issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","target_repo_name":"vosmiic/jellyfin-ani-sync","target_issue_id":1206059249,"target_issue_number":12,"target_issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/12","reference_anchor_document_id":"gh_comment_1152965802","reference_answer_author":"vosmiic","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1633,"anchor_target_overlap":0.2727,"target_answer_overlap":0.15},"issue_created_at":"2022-06-10T16:07:50+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1267750981","fragment_type":"issue_description","sequence":0,"text":"2-way sync maybe possible now?\nWith the higher accuracy, maybe a 2-way sync like the trakt plugin is now possible?\n\nMaybe there is a somewhat reasonable way to-do this now, its just super convienent to have all your watched status in trakt and simply do a sync on a fresh install, so everything is back where you left.\n\nSo for normal shows/movies using the trakt plugin i dont have to care about any backup or library state, i can just reinstall the server point it to my libs and via a trakt resync all watched states are set to where i left off.\n\nWould be super cool to have this also for Anime, but i understand that this can be more complex to get right.","author_login":"Andy2244","author_association":"CONTRIBUTOR","created_at":"2022-06-10T16:07:50+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1152529867","fragment_type":"issue_comment","sequence":1,"text":"So instead of doing an \"outwards\" sync (Jellyfin -> AniList/MAL/Kitsu), we sync the Jellyfin library to a provider (AniList/MAL/Kitsu -> Jellyfin)?\nThis has been requested before here #12.\nWhile it wasn't exactly the original idea of the plugin, I still feel like it falls into the same realm.\nWe could even make it an optional scheduled event, for those who update their AniList/MAL/Kitsu manually outside of Jellyfin.\nI can't see how it would be that difficult to achieve, simply retrieve the users complete/in progress list and update the Jellyfin library.\nI'll look into it and keep you updated.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-06-10T16:21:02+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[1206059249],"is_known_query_context":false},{"document_id":"gh_comment_1152540202","fragment_type":"issue_comment","sequence":2,"text":"The main issue is you need to-be very carefully how/what you sync and also offer/study the settings options the trakt plugin has.\n\nThere can be a catastrophic case, where you wrongly sync the \"unwatched\" state to from remote to the local library and than quickly via a scheduled task, resync this new bad \"unwatched\" state back to the external list, basically wiping your watched states.\n\nTo prevent this case all trakt plugins by default disable remote->local \"unwatched\" sync via settings and also arrange the update jobs, so that the user has a chance to fix setting issues, before a full resync happens.\n\nSo by default you want the plugin to handle mainly \"watched\" states between local remote lists and via settings allow certain \"unwatched\" state combinations.\n\nAs example, the trakt plugin has specific settings to only set remote \"watched/unwatched\" if the user manually set the state. This is safer, since we detect a specific user toggled state change instead of doing some general assumptions.\n\nSo if you don't use the trakt plugin already, i strongly recommend to check it out and what settings combinations it offers, so you can avoid running into those catastrophic cases. We want safe defaults and carefully worded settings, similar to trakt so users quickly understand whats happening.","author_login":"Andy2244","author_association":"NONE","created_at":"2022-06-10T16:33:56+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152964320","fragment_type":"issue_comment","sequence":3,"text":"@vosmiic btw i took the liberty to add the plugin to the official documentation: URL","author_login":"Andy2244","author_association":"NONE","created_at":"2022-06-11T16:57:37+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152965562","fragment_type":"issue_comment","sequence":4,"text":"Ah great, thanks. I think we are now in a comfortable enough position to have it there.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-06-11T17:04:08+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152965802","fragment_type":"issue_comment","sequence":5,"text":"Just as a FYI, #12 isn't really about what @Andy2244 is asking for here, which is importing watch status from a remote Trakt-like third-party provider (i.e. AniList/MAL/Kitsu -> Jellyfin) but rather an extended functionality of what Ani-Sync already does, which is exporting watch status to a third-party provider (i.e. Jellyfin -> AniList/MAL/Kitsu) but _without_ the hard requirement that I must first initiate playback of an anime for AniSync to scan it and update its remote status.\n\nMy issue (and I'm pretty certain I'm far from the only one affected) is that many of my anime were already watched or in various states of _media res_ before I ever installed AniSync, but I'd just never bothered to manually update my MAL profile. So what I'd love for AniSync to be able to do, and what I asked for in #12, would be that it be able to scan my local Jellyfin library, find which anime I have already watched and which shows I'm currently watching, and then update my MAL profile accordingly. And if it could also add my completely untouched anime to the \"plan to watch\" category, that would be even more awesome.\n\nAfter this has been done, then adding what @Andy2244 is actually asking for, i.e. the ability to also import watch state from MAL et al to Jellyfin, would be the cherry on top.","author_login":"Nocifer","author_association":"NONE","created_at":"2022-06-11T17:05:26+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[1206059249],"is_known_query_context":false},{"document_id":"gh_comment_1152966413","fragment_type":"issue_comment","sequence":6,"text":"I kinda included your scenario, its just a subpart of what a full 2-way sync does.","author_login":"Andy2244","author_association":"NONE","created_at":"2022-06-11T17:08:43+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1152966896","fragment_type":"issue_comment","sequence":7,"text":"I know, I was replying to @vosmiic here:\n \n \n\n\"This\" isn't what has been requested in #12 :)","author_login":"Nocifer","author_association":"NONE","created_at":"2022-06-11T17:11:32+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[1206059249],"is_known_query_context":false},{"document_id":"gh_comment_1152968240","fragment_type":"issue_comment","sequence":8,"text":"Yeah sorry I got a bit confused.\nI think I understand what would like to be achieved here, as it has been said before we would like both way sync between Jellyfin and the providers.\nI also understand what @Andy2244 said with being careful how we handle it. Need to make sure it doesn't turn into a nasty loop of updating each others lists and end up with broken watch statuses on both sides. I can see that you explained how the trakt plugin handles it, and it seems to be the best method.\nI'll take all of this into account when implementing these changes.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-06-11T17:20:52+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[1206059249],"is_known_query_context":false},{"document_id":"gh_comment_1160802779","fragment_type":"issue_comment","sequence":9,"text":"Hitting into some trouble syncing Jellyfin from the providers (AniList/MAL/Kitsu -> Jellyfin).\nAs most of the APIs don't contain the season number, we can't actually tell what season the user is on. Luckily each item in the providers database is a separate season.\nThe obvious way to accomplish this is to get the users watch list from the appropriate provider, get the IDs of the anime in said list and then run them through the anime offline database to get the AniDB ID and AniList ID of each season (if we are not using it as the selected provider to sync from) and then cross reference that to Jellyfin's database to see which seasons we have locally that match the IDs (we cannot use the local anime list XML file as that would only give us a TVDB ID which is bound to the series, not the season).\nOnly problem being is that Jellyfin does not seem to store season provider IDs, at least not for me. It stores the _series_ provider IDs, but not separate seasons.\nThe only time that we will get a match with a provider ID from the Jellyfin database is if we are working with the first season of a show from the users watch list.\nCould someone please confirm that it isn't only me not having any provider IDs (labelled \"external IDs\" in the Jellyfin interface) for seasons? I have tried running the metadata fetcher multiple times and I don't get any extra provider IDs for seasons. I get a TVDB ID, but when I cross reference it with the XML file I get no results. I'm not entirely sure what the ID represents as I even tried looking it up on TVDB but got no results.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-06-20T20:01:14+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1164863618","fragment_type":"issue_comment","sequence":10,"text":"I have now got it updating shows from a users AniList watched list.\nJust need to clean it up and get it working with other providers.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-06-23T20:54:04+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1175440843","fragment_type":"issue_comment","sequence":11,"text":"Forgot to update here recently but I believe I have got updating the Jellyfin library from providers anime list fully working.\nI have added a warning to let users know that the feature is in \"alpha\" and that it may disrupt their Jellyfin libraries.\nNext to do is to get the other direction working (Jellyfin to provider anime list).","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-07-05T19:55:04+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1189519457","fragment_type":"issue_comment","sequence":12,"text":"This feature is now fully implemented on master.\nJust doing some testing and then I should be able to release a new version with this functionality included.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-07-19T20:27:22+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1191880873","fragment_type":"issue_comment","sequence":13,"text":"Okay, the update with this has been released. Currently testing it locally and I am not hitting into any trouble. \nThat being said, I would be very careful using this - it could quite easily mess up your Jellyfin library or provider watch lists.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-07-21T20:01:44+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1267750981,"issue_number":20,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1206059249","fragment_type":"issue_description","sequence":0,"text":"Update playback status for previously watched items\nJust a quick question, will this scan for already watched anime and update their playback status on MAL, or will it only work for anime that I watch from now on? That would be a real bummer, because most of my stuff has already been watched back when this nice plugin wasn't yet around... :)","author_login":"Nocifer","author_association":"NONE","created_at":"2022-04-16T08:53:52+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1206059249,"issue_number":12,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/12","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1100630288","fragment_type":"issue_comment","sequence":1,"text":"Hi, unfortunately it only updates MAL after you have actively watched something. \nThat being said I will add this to the main project as a possible addition later on down the line, as it seems to be a good feature to add to the plugin.","author_login":"vosmiic","author_association":"OWNER","created_at":"2022-04-16T10:20:13+08:00","repo_name":"vosmiic/jellyfin-ani-sync","issue_id":1206059249,"issue_number":12,"issue_url":"https://github.com/vosmiic/jellyfin-ani-sync/issues/12","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0452","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"INC0112560 - NR 3606562 showing as rejected and also \"refund requested\"?","query_context":"### Description\n\nGot this report from Debbie today, Oct 6th (**INC0112560**). Don't think there is any ops work, but created a bug to prevent this from occurring again.\n \n \n \n\nIt seems that this NR was able to be cancelled even though it was rejected first.\nOR\nIt was rejected, even though it was cancelled first?\nI can't tell from the transaction history.\n\nAlso in the transaction history, it says that when the client went to edit their NR, the entity type is \"N/A\". That is kinda weird, is that related?\n\n### Reproduce\nTry rejecting a cancelled name\nAlso try \"cancel and refund\"ing a rejected name\n\n### Expected behavior\n* Clients **can't** see the \"Cancel and refund\" button, or use the feature, if the NR has already been approved OR rejected\n\n* Staff **Can't** reject or approve an NR that has been \"cancel and refund\"ed\n\n### Impact\nBad data, incorrect actions being taken, breaking business rules\n\n### Chance of occurring\nUnsure","known_context_document_ids":["gh_issue_1018919808"],"reference_answer":"From @yuisotozaki :\n\nHere's the preview of the messages:\n\n \n\nScenario 1 - When a user attempts to edit or request refund, if the following conditions are met:\n\na. the request is in examination or has been examined but the screen the user is viewing does not yet reflect this state,\n\nb. OR the request is being editing by another user.\n\n \n\nMessage: Please refresh the page or try again later, as there may be simultaneous updates in progress. This can happen if a name examiner is examining this name request. This can also happen if there is another user making changes to this name request or there is another tab on your browser with this name request in edit mode.\n\n \n\nScenario 2 - When a user is about to confirm the NR content and go to payment, to avoid duplicate request, an error shows up when the following conditions are met:\n\na. there exists an NR requested by the same user,\n\nb. AND all the names exact match the names of the current request,\n\nc. AND in pending for review or payment pending status.\n\n \n\nMessage: You have already created an identical name request. To request a different name, please go back and change the name to request and try again.","answer_document_id":"gh_comment_1766634887","silver_evidence_path":["gh_comment_1736386924","gh_issue_1914303075","gh_comment_1766634887"],"evidence_issue_ids":[1018919808,1914303075],"source_repo_name":"bcgov/entity","source_issue_id":1018919808,"source_issue_number":9392,"source_issue_url":"https://github.com/bcgov/entity/issues/9392","target_repo_name":"bcgov/entity","target_issue_id":1914303075,"target_issue_number":17945,"target_issue_url":"https://github.com/bcgov/entity/issues/17945","reference_anchor_document_id":"gh_comment_1736386924","reference_answer_author":"eve-git","reference_answer_author_association":"COLLABORATOR","quality_score":94.15,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.1923,"target_answer_overlap":0.4483},"issue_created_at":"2021-10-06T18:21:03+08:00","valid_comment_count":16,"fragments":[{"document_id":"gh_issue_1018919808","fragment_type":"issue_description","sequence":0,"text":"INC0112560 - NR 3606562 showing as rejected and also \"refund requested\"\n### Description\n\nGot this report from Debbie today, Oct 6th (**INC0112560**). Don't think there is any ops work, but created a bug to prevent this from occurring again.\n \n \n \n\nIt seems that this NR was able to be cancelled even though it was rejected first.\nOR\nIt was rejected, even though it was cancelled first?\nI can't tell from the transaction history.\n\nAlso in the transaction history, it says that when the client went to edit their NR, the entity type is \"N/A\". That is kinda weird, is that related?\n\n### Reproduce\nTry rejecting a cancelled name\nAlso try \"cancel and refund\"ing a rejected name\n\n### Expected behavior\n* Clients **can't** see the \"Cancel and refund\" button, or use the feature, if the NR has already been approved OR rejected\n\n* Staff **Can't** reject or approve an NR that has been \"cancel and refund\"ed\n\n### Impact\nBad data, incorrect actions being taken, breaking business rules\n\n### Chance of occurring\nUnsure","author_login":"sienna-oldaccountdontuse","author_association":"CONTRIBUTOR","created_at":"2021-10-06T18:21:03+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1576900244","fragment_type":"issue_comment","sequence":1,"text":"@pwei1018 @PCC199 there are two active ops tickets related to this investigation, can we please reopen for grooming.\n\n URL \n URL","author_login":"ozamani9gh","author_association":"COLLABORATOR","created_at":"2023-06-05T14:20:20+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583428770","fragment_type":"issue_comment","sequence":2,"text":"According to the events record, the NR checked in right before refund. It is good:\nimage.png","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-06-08T21:44:17+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1583483466","fragment_type":"issue_comment","sequence":3,"text":"So, the problem come from checkin/checkout process. Should the name states back to previous, the same as request state, when checkin?","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-06-08T22:31:23+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1612083000","fragment_type":"issue_comment","sequence":4,"text":"Probably is about the conflict between namerequst and name-examination.\nThe **[Edit]** button in **Name Request** should not be available when the name state is changed to INPROCESS in Name-Examination.\nSo do the **[Upgrade Priority]** and **[Cancel and Refund]** buttons in **Name Request**.","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-06-28T20:45:59+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1642747198","fragment_type":"issue_comment","sequence":5,"text":"The changes are apply to namerequest. Hold it for \"Way Of Navigating\" to be done.","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-07-19T20:57:20+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1734505883","fragment_type":"issue_comment","sequence":6,"text":"@yuisotozaki @oanyahuru \nSeeking UX assistance to improve the phrasing in the Error Dialog:\nCurrent error dialog is like: \nPrivate Zenhub Image\n\nI suggest replacing the highlighted text with something along the lines of: 'The Name Request is currently under examination and editing/canceling is not available. For assistance, please contact BC Registries staff:","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-09-25T21:43:58+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1734554656","fragment_type":"issue_comment","sequence":7,"text":"I would go further and update the title for this scenario.\n\nTitle: \"This Name Request is being examined by BC Registries staff\"\nDescription: \"This Name Request is currently under examination. It cannot be edited or cancelled until the examination is complete. For assistance, please contact BC Registries staff:\"\n\nIf we know more about how long a typical examination takes, we can include that in the message so that the user knows how long to wait before checking on the NR's status. For example, if name examination + system synch time is around 30 minutes, we can use the following message.\n\nDescription: \"This Name Request is currently under examination. It cannot be edited or cancelled until the examination is complete. The approval status will reflect the result of the examination. This process typically takes about 30 minutes. For assistance, please contact BC Registries staff:\"","author_login":"yuisotozaki","author_association":"COLLABORATOR","created_at":"2023-09-25T22:33:44+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1736386924","fragment_type":"issue_comment","sequence":8,"text":"I don't think the previous word in Error dialog (for payment) works for the scenario. After discuss with Yui, I opened URL for UX to review and decide the error message.\nThe modifications in error.vue may be temporary, with the hope that they will suffice until UX provides further guidance.","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-09-26T22:25:33+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[1914303075],"is_known_query_context":false},{"document_id":"gh_comment_1737796138","fragment_type":"issue_comment","sequence":9,"text":"@eve-git I tested following the steps you outlined earlier (in your comment on June 28th). The 'edit' and the 'cancel and refund' buttons did not work once the NR status changed to \"In Progress\" on NameX. it rather displayed an error.\n\nPrivate Zenhub Image\n\nWhen I refreshed the page on Name Request, only the download receipts button was displayed when the request status was 'in progress'. As expected, clicking on it produced another error message\n\nPrivate Zenhub Image","author_login":"oanyahuru","author_association":"COLLABORATOR","created_at":"2023-09-27T17:19:10+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1737822645","fragment_type":"issue_comment","sequence":10,"text":"The error for the receipt shouldn't be there. I will look into it.","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-09-27T17:40:11+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1737878886","fragment_type":"issue_comment","sequence":11,"text":"Looks like the receipt error is from pay-db and not in the scope of this ticket.\n\n2023-09-27 17:39:11,309 - namex - DEBUG in payments:payments.py:13 - get_payment: {'_links': {'collection': '/api/v1/payment-requests?invoice_id=713929', 'self': '/api/v1/payment-requests/713929'}, 'businessIdentifier': 'NR 5795820', 'corpTypeCode': 'NRO', 'createdBy': 'IDIR\\\\OANYAHUR', 'createdName': 'Oge Anyahuru', 'createdOn': '2023-09-27T17:03:59+00:00', 'details': [{'label': 'NR Number:', 'value': 'NR 5795820'}, {'label': 'Name Choices:', 'value': ''}, {'label': '1.', 'value': 'RIGSHORE AND HORSE POWER TOOLS LTD.'}], 'id': 713929, 'isPaymentActionRequired': False, 'lineItems': [{'description': 'Name Request fee', 'filingFees': 30.0, 'futureEffectiveFees': 0.0, 'gst': 0.0, 'id': 716283, 'priorityFees': 0.0, 'pst': 0.0, 'quantity': 1, 'serviceFees': 0.0, 'statusCode': 'ACTIVE', 'total': 30.0, 'waivedBy': None, 'waivedFees': 0.0}], 'paid': 0.0, 'paymentAccount': {'accountId': '1999', 'accountName': \"Ministry of Citizens' Services-BC Registries and Online Services Staff\", 'billable': True}, 'paymentMethod': 'INTERNAL', 'refund': 0.0, 'routingSlip': '206462426', 'serviceFees': 0.0, 'statusCode': 'APPROVED', 'total': 30.0}\n2023-09-27 17:39:11,309 - namex - DEBUG in payment:payment.py:298 - get: adding temporary receipt details.\nError when calling call_api get ( URL \n2023-09-27 17:39:12,767 - namex - ERROR in api_resource:api_resource.py:14 - handle_exception: Error: SBCPaymentException('SBC Pay API exception.')\nError when calling call_api get ( URL \n2023-09-27 17:40:42,229 - namex - ERROR in api_resource:api_resource.py:14 - handle_exception: Error: SBCPaymentException('SBC Pay API exception.')","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-09-27T18:24:44+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1738005093","fragment_type":"issue_comment","sequence":12,"text":"@eve-git, if everything else is ok, I will move the ticket to Ready for Release. Another ticket can be opened for the receipt error.","author_login":"oanyahuru","author_association":"COLLABORATOR","created_at":"2023-09-27T20:06:08+08:00","repo_name":"bcgov/entity","issue_id":1018919808,"issue_number":9392,"issue_url":"https://github.com/bcgov/entity/issues/9392","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1914303075","fragment_type":"issue_description","sequence":0,"text":"Name Request: Enhance the error message in the Error Dialog to provide specificity and better meaning\nCurrently the error messages in Error Dialog are exclusively related to payment failures . This can cause confusion and make it challenging to tell what exact the error is:\n\nPrivate Zenhub Image\n\nThe error messages should be reevaluated in the following scenarios:\n1. URL when a request to be edited/refunded, and an error raised by the below reasons : \n a. the request is in examination or exanimated by a staff\n b. OR the request is editing by another user.\n\n2. URL when a request is about to be confirmed and go to payment. To avoid duplicate request, an error shows up when the following conditions satisfied:\n a. there exists an NR requested by the same user and\n b. all the names exact match the names of the current request and\n c. in pending for review or payment pending status","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-09-26T21:04:17+08:00","repo_name":"bcgov/entity","issue_id":1914303075,"issue_number":17945,"issue_url":"https://github.com/bcgov/entity/issues/17945","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1766634887","fragment_type":"issue_comment","sequence":1,"text":"From @yuisotozaki :\n\nHere's the preview of the messages:\n\n \n\nScenario 1 - When a user attempts to edit or request refund, if the following conditions are met:\n\na. the request is in examination or has been examined but the screen the user is viewing does not yet reflect this state,\n\nb. OR the request is being editing by another user.\n\n \n\nMessage: Please refresh the page or try again later, as there may be simultaneous updates in progress. This can happen if a name examiner is examining this name request. This can also happen if there is another user making changes to this name request or there is another tab on your browser with this name request in edit mode.\n\n \n\nScenario 2 - When a user is about to confirm the NR content and go to payment, to avoid duplicate request, an error shows up when the following conditions are met:\n\na. there exists an NR requested by the same user,\n\nb. AND all the names exact match the names of the current request,\n\nc. AND in pending for review or payment pending status.\n\n \n\nMessage: You have already created an identical name request. To request a different name, please go back and change the name to request and try again.","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-10-17T15:18:11+08:00","repo_name":"bcgov/entity","issue_id":1914303075,"issue_number":17945,"issue_url":"https://github.com/bcgov/entity/issues/17945","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1769369448","fragment_type":"issue_comment","sequence":2,"text":"From @yuisotozaki \n\nHi Eve, the design team spent a good chunk of time reviewing the scenarios and I have a new text for scenario 1. The designers were OK with scenario 2 proposal.\n\nScenario 1 Title\nChanges Temporarily Unavailable\n\nScenario 1 Message\nAnother user may be making updates to this Name Request and this action is unavailable at this time. Please try again later. Typical reasons are as follows:\n\n- Another user may be editing this name request\n- BC Registries staff may be currently reviewing this Name Request\n- Status of this Name Request has changed","author_login":"eve-git","author_association":"COLLABORATOR","created_at":"2023-10-18T21:45:08+08:00","repo_name":"bcgov/entity","issue_id":1914303075,"issue_number":17945,"issue_url":"https://github.com/bcgov/entity/issues/17945","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1776079051","fragment_type":"issue_comment","sequence":3,"text":"@eve-git \nScenario 1 updated as requested\nimage\n\nScenario 2 - updated as requested\nimage","author_login":"oanyahuru","author_association":"COLLABORATOR","created_at":"2023-10-23T21:51:30+08:00","repo_name":"bcgov/entity","issue_id":1914303075,"issue_number":17945,"issue_url":"https://github.com/bcgov/entity/issues/17945","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1777645643","fragment_type":"issue_comment","sequence":4,"text":"For Scenario 1, there is an extra line above \"For assistance...\" that should be removed. Low priority though.","author_login":"yuisotozaki","author_association":"COLLABORATOR","created_at":"2023-10-24T16:53:38+08:00","repo_name":"bcgov/entity","issue_id":1914303075,"issue_number":17945,"issue_url":"https://github.com/bcgov/entity/issues/17945","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0453","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Deprecate use of $smoothLine as well as $plotStyle='lineMarker' in Chart/DataSeries for ScatterCharts?","query_context":"This is:\n\n- [x] a bug report\n- [x] a feature request\n- [ ] **not** a usage question (ask them on URL or URL \n\nN.B. DataSeries->plotStyle property value STYLE_LINEMARKER (='lineMarker') is currently examined only in Chart/Renderer/JpGraph.php, whose use is deprecated. Otherwise, DataSeries property value 'lineMarker' is unused.\n\nSimilarly, the DataSeries->smoothLine property is never tested, but its presence potentially confuses users who mistakenly use this (identically named) property and its (identically named) getter/setter methods in both DataSeries as well as DataSeriesValues.\n\n### What is the expected behavior?\nWhen the user assigns the 'smoothLine' property to a DataSeriesValues array [via $DSV->set_smoothLine(true) ] then the Chart line should be displayed as a smooth Bezier line regardless of any property in its DataSeries, (in my opinion).\n\n### What is the current behavior?\nIf DataSeriesValues->smoothLine == TRUE its line will be straight if its DataSeries->plotStyle == 'lineMarker' (regardless of the value of DataSeries->smoothLine,) This is because Chart/Writer/Xlsx qualifies its writing of the element with a logical AND of '$plotType ===DataSeries::TYPE_SCATTERCHART' and '$plotStyle' === 'smoothMarker'. Therefore, a DataSeriesValues array with a specified property value of TRUE for 'smoothLine' will not be expressed in the xml as unless the DataSeries' plotStyle == 'smoothMarker'. Instead, will be absent from the xml.\n\n### What are the steps to reproduce?\nIn example file samples/Chart/33_Chart_create_scatter2.php, change as follows:\nWAS: DataSeries::STYLE_SMOOTHMARKER // plotStyle\n\n1. IS: DataSeries::STYLE_LINEMARKER // plotStyle\nThis changes the original smooth (Bezier) line nature of the first DataSeriesValues series to a straight line point connection (which is the default behavior).\n\n2. IS: // DataSeries::STYLE_LINEMARKER // plotStyle\nSame result.\n\nNeither result is affected by any value of property DataSeries->smoothLine, including null.\n\nPlease provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:\n\nphp\n<?php\n\nrequire __DIR__ . '/vendor/autoload.php';\n\n// Create new Spreadsheet object\n$spreadsheet = new \\PhpOffice\\PhpSpreadsheet\\Spreadsheet();\n\n// add code that show the issue here...\n\nIf this is an issue with reading a specific spreadsheet file, then it may be appropriate to provide a sample file that demonstrates the problem; but please keep it as small as possible, and sanitize any confidential information before uploading.\n\n### What features do you think are causing the issue\n\n- [ ] Reader\n- [x] Writer\n- [ ] Styles\n- [ ] Data Validations\n- [ ] Formula Calulations\n- [x] Charts\n- [ ] AutoFilter\n- [ ] Form Elements\n\n### Does an issue affect all spreadsheet file formats? If not, which formats are affected?\nXlsx is affected\n\n### Which versions of PhpSpreadsheet and PHP are affected?\n1.24 7.3","known_context_document_ids":["gh_issue_1302470096"],"reference_answer":"We can now use mitoteam/jpgraph, which is maintained in Composer, in place of jpgraph/jpgraph. Closing this issue.","answer_document_id":"gh_comment_1235006071","silver_evidence_path":["gh_comment_1182630692","gh_issue_1217350863","gh_comment_1235006071"],"evidence_issue_ids":[1302470096,1217350863],"source_repo_name":"PHPOffice/PhpSpreadsheet","source_issue_id":1302470096,"source_issue_number":2935,"source_issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","target_repo_name":"PHPOffice/PhpSpreadsheet","target_issue_id":1217350863,"target_issue_number":2783,"target_issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2783","reference_anchor_document_id":"gh_comment_1182630692","reference_answer_author":"oleibman","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2115,"anchor_target_overlap":0.1154,"target_answer_overlap":0.1111},"issue_created_at":"2022-07-12T18:29:55+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1302470096","fragment_type":"issue_description","sequence":0,"text":"Deprecate use of $smoothLine as well as $plotStyle='lineMarker' in Chart/DataSeries for ScatterCharts\nThis is:\n\n- [x] a bug report\n- [x] a feature request\n- [ ] **not** a usage question (ask them on URL or URL \n\nN.B. DataSeries->plotStyle property value STYLE_LINEMARKER (='lineMarker') is currently examined only in Chart/Renderer/JpGraph.php, whose use is deprecated. Otherwise, DataSeries property value 'lineMarker' is unused.\n\nSimilarly, the DataSeries->smoothLine property is never tested, but its presence potentially confuses users who mistakenly use this (identically named) property and its (identically named) getter/setter methods in both DataSeries as well as DataSeriesValues.\n\n### What is the expected behavior?\nWhen the user assigns the 'smoothLine' property to a DataSeriesValues array [via $DSV->set_smoothLine(true) ] then the Chart line should be displayed as a smooth Bezier line regardless of any property in its DataSeries, (in my opinion).\n\n### What is the current behavior?\nIf DataSeriesValues->smoothLine == TRUE its line will be straight if its DataSeries->plotStyle == 'lineMarker' (regardless of the value of DataSeries->smoothLine,) This is because Chart/Writer/Xlsx qualifies its writing of the element with a logical AND of '$plotType ===DataSeries::TYPE_SCATTERCHART' and '$plotStyle' === 'smoothMarker'. Therefore, a DataSeriesValues array with a specified property value of TRUE for 'smoothLine' will not be expressed in the xml as unless the DataSeries' plotStyle == 'smoothMarker'. Instead, will be absent from the xml.\n\n### What are the steps to reproduce?\nIn example file samples/Chart/33_Chart_create_scatter2.php, change as follows:\nWAS: DataSeries::STYLE_SMOOTHMARKER // plotStyle\n\n1. IS: DataSeries::STYLE_LINEMARKER // plotStyle\nThis changes the original smooth (Bezier) line nature of the first DataSeriesValues series to a straight line point connection (which is the default behavior).\n\n2. IS: // DataSeries::STYLE_LINEMARKER // plotStyle\nSame result.\n\nNeither result is affected by any value of property DataSeries->smoothLine, including null.\n\nPlease provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:\n\nphp\n<?php\n\nrequire __DIR__ . '/vendor/autoload.php';\n\n// Create new Spreadsheet object\n$spreadsheet = new \\PhpOffice\\PhpSpreadsheet\\Spreadsheet();\n\n// add code that show the issue here...\n\nIf this is an issue with reading a specific spreadsheet file, then it may be appropriate to provide a sample file that demonstrates the problem; but please keep it as small as possible, and sanitize any confidential information before uploading.\n\n### What features do you think are causing the issue\n\n- [ ] Reader\n- [x] Writer\n- [ ] Styles\n- [ ] Data Validations\n- [ ] Formula Calulations\n- [x] Charts\n- [ ] AutoFilter\n- [ ] Form Elements\n\n### Does an issue affect all spreadsheet file formats? If not, which formats are affected?\nXlsx is affected\n\n### Which versions of PhpSpreadsheet and PHP are affected?\n1.24 7.3","author_login":"bridgeplayr","author_association":"NONE","created_at":"2022-07-12T18:29:55+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1182421835","fragment_type":"issue_comment","sequence":1,"text":"JpGraph is not deprecated. It is just not maintained in Composer, and the version there is not Php8 compatible (maybe not even some versions of 7) so we can't allow its use in our test suite. However, you can manually substitute the current version of that product for the version that Composer brings in, and it should work just fine. I have no idea what it's doing with lineMarker, but am reluctant to make it stop working (under the uncertain assumption that it works now).\n\nAs for smoothLine, that was one of your first requests that I worked on. It seemed to me at the time that Excel required it at both the DS and the DSV levels. I can look into it again.","author_login":"oleibman","author_association":"COLLABORATOR","created_at":"2022-07-12T19:57:29+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1182601362","fragment_type":"issue_comment","sequence":2,"text":"This annoying behavior tripped me up while I was testing Axis cases.\n\nThank you for the JpGraph clarification - I had hoped to use it, and I now feel free to try it - if I can find a compatible version.\n\n[N.B. I understand removing properties is a breaking change, but having two identically-named properties in two similarly-named classes (DataSeriesValues & DataSeries) with identical getter/setter methods is seriously confusing. At least to me.]\n\nI repeat my previous request to remove DataSeries property $smoothLine and its getter/setter methods. In a ScatterChart, the accidental assignment of 'lineMarker' to $plotStyle will suppress a $DSV whose $smoothLine property is true, and the user will have a difficult time discovering the reason for the resultant straight-line. To prevent this unfortunate circumstance, I propose that Writer/Xlsx change the qualification for the call to startElement('c:smooth') in the \"// Values\" section of function writePlotArea() from:\n\nWAS: if ($groupType === DataSeries::TYPE_SCATTERCHART && $plotGroup->getPlotStyle() === 'smoothMarker')\n\nIS: if ($groupType === DataSeries::TYPE_SCATTERCHART)\n\nThis will allow a $DSV->smoothLine property value of TRUE to be expressed correctly in the xml regardless of its containing $DS->plotStyle value, (which is the correct behavior in my opinion.)","author_login":"bridgeplayr","author_association":"NONE","created_at":"2022-07-12T23:42:08+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1182630692","fragment_type":"issue_comment","sequence":3,"text":"Under what circumstances would you \"accidentally\" set the style to lineMarker? It sounds like you're trying to get PhpSpreadsheet to ignore something the programmer has explicitly requested - it certainly isn't used as any kind of a default. Perhaps, after looking at the finished product, smooth lines aren't desired after all, and it's easier to change the DataSeries property to lineMarker in one place than it is to remove the smooth declarations from all the DSVs? It is possible that you can make a stronger case for using the c:smooth tag for \"not lineMarker\"; I would still need to think about that.\n\nIssue #2783 has more details about how to use JpGraph.","author_login":"oleibman","author_association":"COLLABORATOR","created_at":"2022-07-13T00:28:01+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[1217350863],"is_known_query_context":false},{"document_id":"gh_comment_1182650215","fragment_type":"issue_comment","sequence":4,"text":"Excel describes 'smooth line' charts as well as 'line charts'. It is not a stretch to associate those choices with 'lineMarker' and 'smoothMarker'. But what if you want a mix?\n\nI submit that a programmer who assembles a ScatterChart may simply ignore assigning any value to the DS->plotStyle property since it is possible to desire an XY chart with both smooth lines and straight lines, and maybe no lines. So the programmer omits it, and its value is null. If the programmer has assigned TRUE to any DSV->smoothLine property, she will be mystified why it doesn't work. (We'll know, but she won't have much of a clue.) Changing Writer masks her (unfortunate) choice of not assigning 'smoothMarker' to DS->plotStyle.\n\nThank you for the JpGraph link.","author_login":"bridgeplayr","author_association":"NONE","created_at":"2022-07-13T01:08:09+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1189041491","fragment_type":"issue_comment","sequence":5,"text":"Sorry, I don't think you've made a case for any code changes. You have made a case for documentation changes, and 2950, which will close this ticket when merged, will document (in both places) that scatterLines needs to be set at both the DS and DSV level.","author_login":"oleibman","author_association":"COLLABORATOR","created_at":"2022-07-19T13:16:50+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1189356855","fragment_type":"issue_comment","sequence":6,"text":"Ok. Your call certainly. Documenting will help avoid the possibility shown below using sample/Chart/33_Chart_create_scatter2.php.\n\nCase 1: As written - behavior as expected\n\n$series = new DataSeries(\n DataSeries::TYPE_SCATTERCHART, // plotType\n ...\n DataSeries::STYLE_SMOOTHMARKER // plotStyle\n);\n\nimage\n\nCase 2: Modified to comment the SMOOTHMARKER designation. I suggest this might be reasonable thinking since, after all, I know one line will be smooth, one straight, and one has no line at all. To ensure the correct display, I have specified each DSV's line charactieristics. Since I don't want to have the series combination ($series) override each DSV assignment, I comment the last line,)\nThe smooth line is now a straight line. \n\n$series = new DataSeries(\n DataSeries::TYPE_SCATTERCHART, // plotType\n ...\n // DataSeries::STYLE_SMOOTHMARKER // plotStyle\n);\n\nimage","author_login":"bridgeplayr","author_association":"NONE","created_at":"2022-07-19T17:21:00+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1302470096,"issue_number":2935,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2935","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1217350863","fragment_type":"issue_description","sequence":0,"text":"Chart read write HTML and PDF\nThis is:\n\n- [x] a bug report\n- [ ] a feature request\n- [ ] **not** a usage question (ask them on URL or URL \n\n### What is the expected behavior?\nThe pdf and html file with the charts\n\n### What is the current behavior?\n\n32 Chart read write HTML\n15:13:01 Load Test from Xlsx file 36writeLineChart1.xlsx\n15:13:01 Iterate worksheets looking at the charts\n15:13:01 Worksheet: Data\n15:13:01 chart1 - \"Sales\"\n15:13:01\n15:13:01 lineChart\nFatal error: Uncaught TypeError: JpGraphException::defaultHandler(): Argument #1 ($exception) must be of type Exception, Error given in C:\\xampp.8.0.18\\htdocs\\phpexcel\\vendor\\jpgraph\\jpgraph\\lib\\jpgraph\\src\\jpgraph_errhandler.inc.php:158 Stack trace: #0 [internal function]: JpGraphException::defaultHandler(Object(Error)) #1 {main} thrown in C:\\xampp.8.0.18\\htdocs\\phpexcel\\vendor\\jpgraph\\jpgraph\\lib\\jpgraph\\src\\jpgraph_errhandler.inc.php on line 158\n\n32 Chart read write PDF\n15:07:46 Load Test from Xlsx file 36writeLineChart1.xlsx\n15:07:46 Iterate worksheets looking at the charts\n15:07:46 Worksheet: Data\n15:07:46 chart1 - \"Sales\"\n15:07:46\n15:07:46 lineChart\nFatal error: Uncaught TypeError: JpGraphException::defaultHandler(): Argument #1 ($exception) must be of type Exception, Error given in C:\\xampp.8.0.18\\htdocs\\phpexcel\\vendor\\jpgraph\\jpgraph\\lib\\jpgraph\\src\\jpgraph_errhandler.inc.php:158 Stack trace: #0 [internal function]: JpGraphException::defaultHandler(Object(Error)) #1 {main} thrown in C:\\xampp.8.0.18\\htdocs\\phpexcel\\vendor\\jpgraph\\jpgraph\\lib\\jpgraph\\src\\jpgraph_errhandler.inc.php on line 158\n\n### What are the steps to reproduce?\nRun 32_Chart_read_write_HTML.php\nRun 32_Chart_read_write_PDF.php\n\n### What features do you think are causing the issue\n\n- [ ] Reader\n- [ ] Writer\n- [ ] Styles\n- [ ] Data Validations\n- [ ] Formula Calulations\n- [x] Charts\n- [ ] AutoFilter\n- [ ] Form Elements\n\nphp8.0\n\"phpoffice/phpspreadsheet\": \"^1.23\",\n\"mpdf/mpdf\": \"^8.1\",\n\"dompdf/dompdf\": \"^1.2\",\n\"tecnickcom/tcpdf\": \"^6.4\",\n\"jpgraph/jpgraph\": \"^4.0\"","author_login":"ivangy","author_association":"NONE","created_at":"2022-04-27T13:20:05+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1217350863,"issue_number":2783,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2783","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1235006071","fragment_type":"issue_comment","sequence":1,"text":"We can now use mitoteam/jpgraph, which is maintained in Composer, in place of jpgraph/jpgraph. Closing this issue.","author_login":"oleibman","author_association":"COLLABORATOR","created_at":"2022-09-02T02:43:07+08:00","repo_name":"PHPOffice/PhpSpreadsheet","issue_id":1217350863,"issue_number":2783,"issue_url":"https://github.com/PHPOffice/PhpSpreadsheet/issues/2783","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0455","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Opened connections are not closed?","query_context":"### Describe the bug\n\nHey 👋 ,\nI've started using this driver with a service that was originally using pgJDBC, I just replaced the driver with AWS JDBC driver. \n\nthere is a behaviour that I'm seeing which is very consistent where opened connections keep increasing and never closed which causes a OOM.\n\nI'm using Spring JDBC template to issue SQL queries to the DB.\n\n### Expected Behavior\n\nconnections are closed and no OOM is thrown\n\n### What plugins are used? What other connection properties were set?\n\nauroraConnectionTracker,efm,failover,iam\n\n### Current Behavior\n\norg.postgresql.jdbc.PgConnection seem to not get closed\n\nI have enabled driver logs and I can see this \n\nOpened Connections Tracked: [\n[\n [ instance-1.rds.amazonaws.com:5432:\n {\n org.postgresql.jdbc.PgConnection@245253d8,\n org.postgresql.jdbc.PgConnection@43a9541c\n .... \n }]\n]\n\n \nwhich initially starts with connections = number of connections configured in the hikari pool (15), but after a couple of hours the number keeps increasing (reaching 100+) till a OOM is thrown.\n\nthis service have very little memory pressure yet it throws a out of heap space every couple of hours.\n\n### Reproduction Steps\n\nUsing the following\n\nAWS JDBC Version: 2.2.4\nPostgresql runtime driver dependency: 42.6.0 \nSpring boot: 2.7.11\npg-Aurora: 15.3 (2 read instances & 1 writer)\nHikari: 4.0.3\n\nDriver config:\nspring:\n datasource:\n type: com.zaxxer.hikari.HikariDataSource\n url: ${DB_URL}\n username: ${DB_USERNAME}\n driver-class-name: software.amazon.jdbc.Driver\n hikari:\n data-source-properties:\n wrapperPlugins: auroraConnectionTracker,efm,failover,iam\n wrapperDialect: aurora-pg\n wrapperLogUnclosedConnections: true\n wrapperLoggerLevel: ALL\n exception-override-class-name: software.amazon.jdbc.util.HikariCPSQLException\n max-lifetime: 300000\n connection-timeout: 1200\n validation-timeout: 1000\n maximum-pool-size: 15\n\nand using the sslmode=verify-full & AWS RDS global-bundle.pem\n\n### Possible Solution\n\n_No response_\n\n### Additional Information/Context\n\n_No response_\n\n### The AWS Advanced JDBC Driver version used\n\n2.2.4\n\n### JDK version used\n\noracle-jdk:17 (17.0.6+9-LTS-190)\n\n### Operating System and version\n\nRed Hat Enterprise Linux 8.7 (Ootpa)","known_context_document_ids":["gh_issue_1905187547"],"reference_answer":"Hi all,\n\nWe've recently added an **experimental** Host Monitoring Plugin (PR #764) to the driver, called the Host Monitoring Plugin v2. More information can be found here. The Host Monitoring Plugin v2 is functionally equivalent to the Host Monitoring Plugin and they are configured using the same parameters. The Host Monitoring Plugin v2 was created to address the issues that you all have been experiencing, and it is meant to be a more stable version of the Host Monitoring Plugin.\n\nAs it is currently an experimental plugin, please note that it should be tested before being used in a production environment. This plugin can be tried out by using the snapshot build `aws-advanced-jdbc-wrapper-2.3.2-20231213.213138-10.jar`. For more information on using a snapshot build, see this page. If you are able to test out the plugin, please let us know if you encounter any errors or if this plugin was able to resolve the issues you've encountered.\n\nThank you!","answer_document_id":"gh_comment_1854848979","silver_evidence_path":["gh_comment_1854955195","gh_issue_1935845772","gh_comment_1854848979"],"evidence_issue_ids":[1905187547,1935845772],"source_repo_name":"awslabs/aws-advanced-jdbc-wrapper","source_issue_id":1905187547,"source_issue_number":646,"source_issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","target_repo_name":"awslabs/aws-advanced-jdbc-wrapper","target_issue_id":1935845772,"target_issue_number":675,"target_issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","reference_anchor_document_id":"gh_comment_1854955195","reference_answer_author":"crystall-bitquill","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1053,"anchor_target_overlap":0.8947,"target_answer_overlap":0.14},"issue_created_at":"2023-09-20T15:00:01+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_1905187547","fragment_type":"issue_description","sequence":0,"text":"Opened connections are not closed\n### Describe the bug\n\nHey 👋 ,\nI've started using this driver with a service that was originally using pgJDBC, I just replaced the driver with AWS JDBC driver. \n\nthere is a behaviour that I'm seeing which is very consistent where opened connections keep increasing and never closed which causes a OOM.\n\nI'm using Spring JDBC template to issue SQL queries to the DB.\n\n### Expected Behavior\n\nconnections are closed and no OOM is thrown\n\n### What plugins are used? What other connection properties were set?\n\nauroraConnectionTracker,efm,failover,iam\n\n### Current Behavior\n\norg.postgresql.jdbc.PgConnection seem to not get closed\n\nI have enabled driver logs and I can see this \n\nOpened Connections Tracked: [\n[\n [ instance-1.rds.amazonaws.com:5432:\n {\n org.postgresql.jdbc.PgConnection@245253d8,\n org.postgresql.jdbc.PgConnection@43a9541c\n .... \n }]\n]\n\n \nwhich initially starts with connections = number of connections configured in the hikari pool (15), but after a couple of hours the number keeps increasing (reaching 100+) till a OOM is thrown.\n\nthis service have very little memory pressure yet it throws a out of heap space every couple of hours.\n\n### Reproduction Steps\n\nUsing the following\n\nAWS JDBC Version: 2.2.4\nPostgresql runtime driver dependency: 42.6.0 \nSpring boot: 2.7.11\npg-Aurora: 15.3 (2 read instances & 1 writer)\nHikari: 4.0.3\n\nDriver config:\nspring:\n datasource:\n type: com.zaxxer.hikari.HikariDataSource\n url: ${DB_URL}\n username: ${DB_USERNAME}\n driver-class-name: software.amazon.jdbc.Driver\n hikari:\n data-source-properties:\n wrapperPlugins: auroraConnectionTracker,efm,failover,iam\n wrapperDialect: aurora-pg\n wrapperLogUnclosedConnections: true\n wrapperLoggerLevel: ALL\n exception-override-class-name: software.amazon.jdbc.util.HikariCPSQLException\n max-lifetime: 300000\n connection-timeout: 1200\n validation-timeout: 1000\n maximum-pool-size: 15\n\nand using the sslmode=verify-full & AWS RDS global-bundle.pem\n\n### Possible Solution\n\n_No response_\n\n### Additional Information/Context\n\n_No response_\n\n### The AWS Advanced JDBC Driver version used\n\n2.2.4\n\n### JDK version used\n\noracle-jdk:17 (17.0.6+9-LTS-190)\n\n### Operating System and version\n\nRed Hat Enterprise Linux 8.7 (Ootpa)","author_login":"abdoofathy95","author_association":"NONE","created_at":"2023-09-20T15:00:01+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1728332023","fragment_type":"issue_comment","sequence":1,"text":"Hi @abdoofathy95,\n\nThanks for reaching out and raising this issue.\n\nWe'll take a look at this and keep you updated as we investigate.\n\nIn the meantime, could you provide the following additional information if possible?\n- Driver logs, which can be enabled as seen here.\n- A bit of sample code, to get a better idea of how you're using the driver.\n\nThank you for your patience!","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-09-20T19:46:39+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1729209558","fragment_type":"issue_comment","sequence":2,"text":"Hi @crystall-bitquill,\n* for the driver logs, as mentioned above, the Opened Connections Tracked log shows a list that keeps growing (never shrinks), or are you interested in another bit of the log ? \n* a sample code:\n\nspring:\n datasource:\n type: com.zaxxer.hikari.HikariDataSource\n url: ${DB_URL}\n username: ${DB_USERNAME}\n driver-class-name: software.amazon.jdbc.Driver\n hikari:\n data-source-properties:\n wrapperPlugins: auroraConnectionTracker,efm,failover,iam\n wrapperDialect: aurora-pg\n wrapperLogUnclosedConnections: true\n wrapperLoggerLevel: ALL\n exception-override-class-name: software.amazon.jdbc.util.HikariCPSQLException\n max-lifetime: 300000\n connection-timeout: 1200\n validation-timeout: 1000\n maximum-pool-size: 15\n\nclass Repository {\n...\nprivate final JdbcTemplate jdbcTemplate;\n public int[] query(paramArray) {\n return jdbcTemplate.batchUpdate(\"SQL\", paramArray);\n }\n}\n....","author_login":"abdoofathy95","author_association":"NONE","created_at":"2023-09-21T09:33:22+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1735668708","fragment_type":"issue_comment","sequence":3,"text":"Hey, this seems related mainly to using efm plugin, when disabled and instead using the following plugins \n`auroraConnectionTracker,failover,iam` not OOMs are observed. I didn't get the time to properly look at the exact root cause tho.","author_login":"abdoofathy95","author_association":"NONE","created_at":"2023-09-26T14:32:14+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1745768402","fragment_type":"issue_comment","sequence":4,"text":"Hi @abdoofathy95,\n\nTo update you, it seems like the additional connections you're seeing in the connection tracker comes from the Hikari pool. When idle connections reach the maxLifetime, they are closed and new connections are made. The connection tracker is logging these closed connections. However, all of these closed connections are weak references and can be removed by garbage collection. Have you made any changes to any garbage collection settings? If not, it is unlikely that the OOM error was caused by the connections visible in the tracker, as they should be garbage collected before the OOM error occurs. This occurs regardless of which plugins are used. \n\nYou mentioned you didn't get the OOM error when efm was disabled. Would you be able to try the following plugin combinations to confirm where the error is?\n1. No plugins - this can be done by setting the `wrapperPlugins` property to an empty string (the driver has several plugins enabled by default).\n2. EFM only\n\nIn addition, I have a few questions:\n1. Are you able to see how much free memory you have before and after starting your application?\n2. Are you ablt to tell at what rate the amount of free memory you have available is decreasing?\n3. Are any failover events occurring?","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-10-03T21:39:25+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1750736737","fragment_type":"issue_comment","sequence":5,"text":"Hey @crystall-bitquill, \nthank you for your reply, \nI'm using the following flags\n`-XX:+UseG1GC -Xms1536m -Xmx1536m -XX:MaxMetaspaceSize=256M -Xss2m`.\n\nI will try to disable all the plugins and see the behaviour.\n\n1. not sure I get what you mean here by before starting the application, it's a pod that as soon as it gets deployed, the application starts.\n2. this is the JVM heap metric URL \n3. There are no failover events occurring.","author_login":"abdoofathy95","author_association":"NONE","created_at":"2023-10-06T14:04:13+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1854955195","fragment_type":"issue_comment","sequence":6,"text":"Hi @abdoofathy95,\n\nTo update you, similar issues (#675) have been reported regarding a memory leak in the Host Monitoring plugin.\n\nWe've recently added an **experimental** Host Monitoring Plugin (PR #764) to the driver, called the Host Monitoring Plugin v2. More information can be found here. The Host Monitoring Plugin v2 is functionally equivalent to the Host Monitoring Plugin and they are configured using the same parameters. The Host Monitoring Plugin v2 was created to address the issues that you and others have been experiencing, and it is meant to be a more stable version of the Host Monitoring Plugin.\n\nAs it is currently an experimental plugin, please note that it should be tested before being used in a production environment. This plugin can be tried out by using the snapshot build `aws-advanced-jdbc-wrapper-2.3.2-20231213.213138-10.jar`. For more information on using a snapshot build, see this page. If you are able to test out the plugin, please let us know if you encounter any errors or if this plugin was able to resolve the issues you've encountered.\n\nThank you!","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-12-14T01:24:58+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[1935845772],"is_known_query_context":false},{"document_id":"gh_comment_1863533959","fragment_type":"issue_comment","sequence":7,"text":"Hi @abdoofathy95 ,\n\nHeads up that the aforementioned experimental Host Monitoring Plugin is now available on our latest release of the driver.\n\nAlso wanted to reiterate that it is currently an experimental plugin that should be tested before being used in a production environment.\n\nIf you are able to test out the plugin, please let us know if it resolves these issues or if there are any other issues encountered.\n\nI'll be closing this ticket. But if this issue still persists or if you encounter any other issues, please feel free to create a new ticket or re-open this one.\n\nThank you","author_login":"aaronchung-bitquill","author_association":"COLLABORATOR","created_at":"2023-12-19T22:02:31+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1905187547,"issue_number":646,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/646","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1935845772","fragment_type":"issue_description","sequence":0,"text":"Memory Leak in EFM Plugin\n### Describe the bug\n\nIn our application we've two aurora databases each with an own jdbc connection. Through our monitoring we found that our pods randomly restarted due to out of memory. After some investigation we found out that the `software.amazon.jdbc.plugin.efm.MonitorImpl` of one of our jdbc connections stopped working and we don't saw any exceptions. In this case it collects `software.amazon.jdbc.plugin.efm.MonitorConnectionContext` objects in the `newContexts` queue. In one of our heap dumps we found out that in the `newContexts` queue were over 4000000 objects.\n\nThis screenshot from one of our heap show that the first instance is `stopped=true` with over 411MB of objects in the `newContexts` queue. The second one is the one which is working it no objects in the `newContexts` queue.\n<img width=\"1263\" alt=\"grafik\" src=\" URL \n\n### Expected Behavior\n\nNo memory leak.\n\n### What plugins are used? What other connection properties were set?\n\nauroraConnectionTracker,failover,efm,iam\n\n### Current Behavior\n\nRandomly the Monitor stopps and objects are stored in `newContexts` but they won't ever be removed.\n\n### Reproduction Steps\n\nWe couldn't find any reproducer as we just observed this behavior randomly without any pattern.\n\n### Possible Solution\n\nAt least catch and log `RuntimeException` and return an appropriate `ConnectionStatus` object in `software.amazon.jdbc.plugin.efm.MonitorImpl#checkConnectionStatus` to avoid that uncaught runtime exceptions stop the monitoring thread without shutting down the monitor completly.\n\n### Additional Information/Context\n\n_No response_\n\n### The AWS Advanced JDBC Driver version used\n\n2.2.2\n\n### JDK version used\n\nzulu 11.0.17\n\n### Operating System and version\n\nDistroless Docker Image at AWS EKS","author_login":"chr-fritz","author_association":"NONE","created_at":"2023-10-10T17:08:12+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1758285265","fragment_type":"issue_comment","sequence":1,"text":"Hi @chr-fritz,\n\nThanks for reaching out and raising this issue.\n\nWe'll take a look at this and keep you updated as we investigate.\n\nThank you for your patience!","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-10-11T18:39:35+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1782136204","fragment_type":"issue_comment","sequence":2,"text":"Hi @chr-fritz,\n\nWe've recently merged some changes (PR #676) that updated our monitoring implementation and added additional logging. I understand that you aren't able to reproduce this consistently, but would you be able to check out our snapshot build with driver logs enabled (logs can be enabled as seen here) and let us know how that goes?\n\nThank you!","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-10-27T01:05:13+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1811383590","fragment_type":"issue_comment","sequence":3,"text":"Hey @crystall-bitquill,\n\nI'm also experiencing the same issue reported here. I've using a snapshot build and getting the following log line (identifying details removed). I'm thinking we need to include the exception type in the log line.\n\nWARNING: Continuing monitoring after unhandled exception was thrown in monitoring thread for node -02. .us-west-2.rds.amazonaws.com: null\nNov 14, 2023 9:23:23 PM software.amazon.jdbc.plugin.efm.MonitorImpl run","author_login":"andrecloutier-pd","author_association":"NONE","created_at":"2023-11-14T21:53:15+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1815653089","fragment_type":"issue_comment","sequence":4,"text":"Hi @andrecloutier-pd,\n\nThanks for trying out the snapshot build and for letting us know about the logs. There were some changes merged recently (PR #718) that make the logger message include the entire exception. Could you kindly check out the latest snapshot build and let us know how that goes?\n\nThank you!","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-11-17T02:29:41+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1824009094","fragment_type":"issue_comment","sequence":5,"text":"costly\n\nI wonder if this is the same issue? Two days ago we got a budget warning from AWS. Something had generated a few gigabytes (or hundreds of dollars depending on how you want to measure it) of cloudwatch log entries. The CPU was spinning on 100% generating the output in the image as fast as it could. \n\nNo wonder AWS is big business for Amazon","author_login":"kimble","author_association":"NONE","created_at":"2023-11-23T08:50:22+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1825035204","fragment_type":"issue_comment","sequence":6,"text":"Hi @kimble, thank you for reaching out with this information.\n\nThe driver logs thrown by the monitoring thread are necessary to inform the user of potential monitoring problems. This info can help the user and team diagnose and address issues that may arise. However, we understand that the volume of logs generated by this particular scenario was greater than you expected. To address this, we have created PR #751, which lowers the logging level for the particular messages you are seeing to avoid potential surprises for other customers. Thank you for raising your concern. Please note that you can also filter the logs using the properties file. For example, to filter out the logs in the posted image you can add the following line to your `.properties` file:\n\nsoftware.amazon.jdbc.plugin.efm.MonitorImpl.level=OFF\n\nRegarding the memory leaks issue, we have made improvements to the monitoring objects to ensure they are synchronized and the driver does not cache references to them in PR #718.\nWe will keep you updated for when we create an official release containing this fix.\n\nIn the meantime, could you please help us further improve our driver by checking out our snapshot build containing changes from PR #751 and PR #718, and send us the unhandled exceptions your application is throwing so we can triage it?","author_login":"karenc-bq","author_association":"CONTRIBUTOR","created_at":"2023-11-24T01:05:58+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1825275314","fragment_type":"issue_comment","sequence":7,"text":"Reducing the log level will probably just hide the problem that there is a thread consuming 100% printing the lines from my screenshot over and over as fast as it can. \n \n\nNot sure what you mean by this?","author_login":"kimble","author_association":"NONE","created_at":"2023-11-24T07:57:02+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1836594300","fragment_type":"issue_comment","sequence":8,"text":"Hi @kimble,\n\n1. The logs will only be printed if you choose to enable `FINEST/DEBUG` level logs. You can also disable logging for that particular thread.\n2. We have released v2.3.1 containing fixes from #751 and #718. Could you please give it a try? If the issue persists can you please send us the driver logs related to the issue?","author_login":"karenc-bq","author_association":"CONTRIBUTOR","created_at":"2023-12-01T18:35:49+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1854848979","fragment_type":"issue_comment","sequence":9,"text":"Hi all,\n\nWe've recently added an **experimental** Host Monitoring Plugin (PR #764) to the driver, called the Host Monitoring Plugin v2. More information can be found here. The Host Monitoring Plugin v2 is functionally equivalent to the Host Monitoring Plugin and they are configured using the same parameters. The Host Monitoring Plugin v2 was created to address the issues that you all have been experiencing, and it is meant to be a more stable version of the Host Monitoring Plugin.\n\nAs it is currently an experimental plugin, please note that it should be tested before being used in a production environment. This plugin can be tried out by using the snapshot build `aws-advanced-jdbc-wrapper-2.3.2-20231213.213138-10.jar`. For more information on using a snapshot build, see this page. If you are able to test out the plugin, please let us know if you encounter any errors or if this plugin was able to resolve the issues you've encountered.\n\nThank you!","author_login":"crystall-bitquill","author_association":"COLLABORATOR","created_at":"2023-12-13T23:25:22+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1863433581","fragment_type":"issue_comment","sequence":10,"text":"Hi all,\n\nHeads up that the aforementioned experimental Host Monitoring Plugin is now available on our latest release of the driver.\n\nAlso wanted to reiterate that it is currently an experimental plugin that should be tested before being used in a production environment. \n\nIf you are able to test out the plugin, please let us know if it resolves these issues or if there are any other issues encountered. \n\nThank you","author_login":"aaronchung-bitquill","author_association":"COLLABORATOR","created_at":"2023-12-19T20:32:15+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1863493709","fragment_type":"issue_comment","sequence":11,"text":"Hi all,\n\nHeads up that the aforementioned experimental Host Monitoring Plugin is now available on our latest release of the driver.\n\nAlso wanted to reiterate that it is currently an experimental plugin that should be tested before being used in a production environment.\n\nIf you are able to test out the plugin, please let us know if it resolves these issues or if there are any other issues encountered.\n\nThank you","author_login":"aaronchung-bitquill","author_association":"COLLABORATOR","created_at":"2023-12-19T21:25:26+08:00","repo_name":"awslabs/aws-advanced-jdbc-wrapper","issue_id":1935845772,"issue_number":675,"issue_url":"https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/675","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0456","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"update_bindings failed?","query_context":"I met the issue on ubuntu 20.04 and python3.8 \nAnd met the issue:\naceback (most recent call last):\n File \"/root/ompl/py-bindings/generate_bindings.py\", line 967, in \n globals()'ompl_'+module+'_generator_t'\n File \"/root/ompl/py-bindings/generate_bindings.py\", line 626, in __init__\n replacement)\n File \"/root/ompl/py-bindings/ompl/bindings_generator.py\", line 142, in __init__\n self.std_ns = self.mb.namespace('std')\n File \"/usr/local/lib/python3.8/dist-packages/pyplusplus/module_builder/module_builder.py\", line 267, in namespace\n , recursive=recursive )\n File \"/usr/local/lib/python3.8/dist-packages/pygccxml-2.2.1-py3.8.egg/pygccxml/declarations/namespace.py\", line 121, in namespace\n recursive=recursive)\n File \"/usr/local/lib/python3.8/dist-packages/pygccxml-2.2.1-py3.8.egg/pygccxml/declarations/scopedef.py\", line 464, in _find_single\n found = matcher.get_single(decl_matcher, decls, False)\n File \"/usr/local/lib/python3.8/dist-packages/pygccxml-2.2.1-py3.8.egg/pygccxml/declarations/scopedef.py\", line 92, in get_single\n raise runtime_errors.multiple_declarations_found_t(decl_matcher)\npygccxml.declarations.runtime_errors.multiple_declarations_found_t: Multiple declarations have been found. Matcher: [(decl type==namespace_t) and (name==std)]\n\nIs there anyone that can help me to solve it ?\nWords fail me to express the heartfelt gratitude","known_context_document_ids":["gh_issue_1573975188"],"reference_answer":"Should be fixed by the recently merged #1100 - let me know if that isn't the case.","answer_document_id":"gh_comment_1830576093","silver_evidence_path":["gh_comment_1421389113","gh_issue_1565368720","gh_comment_1830576093"],"evidence_issue_ids":[1573975188,1565368720],"source_repo_name":"ompl/ompl","source_issue_id":1573975188,"source_issue_number":986,"source_issue_url":"https://github.com/ompl/ompl/issues/986","target_repo_name":"ompl/ompl","target_issue_id":1565368720,"target_issue_number":981,"target_issue_url":"https://github.com/ompl/ompl/issues/981","reference_anchor_document_id":"gh_comment_1421389113","reference_answer_author":"zkingston","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.1429,"target_answer_overlap":0.1429},"issue_created_at":"2023-02-07T09:24:38+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1573975188","fragment_type":"issue_description","sequence":0,"text":"update_bindings failed\nI met the issue on ubuntu 20.04 and python3.8 \nAnd met the issue:\naceback (most recent call last):\n File \"/root/ompl/py-bindings/generate_bindings.py\", line 967, in \n globals()'ompl_'+module+'_generator_t'\n File \"/root/ompl/py-bindings/generate_bindings.py\", line 626, in __init__\n replacement)\n File \"/root/ompl/py-bindings/ompl/bindings_generator.py\", line 142, in __init__\n self.std_ns = self.mb.namespace('std')\n File \"/usr/local/lib/python3.8/dist-packages/pyplusplus/module_builder/module_builder.py\", line 267, in namespace\n , recursive=recursive )\n File \"/usr/local/lib/python3.8/dist-packages/pygccxml-2.2.1-py3.8.egg/pygccxml/declarations/namespace.py\", line 121, in namespace\n recursive=recursive)\n File \"/usr/local/lib/python3.8/dist-packages/pygccxml-2.2.1-py3.8.egg/pygccxml/declarations/scopedef.py\", line 464, in _find_single\n found = matcher.get_single(decl_matcher, decls, False)\n File \"/usr/local/lib/python3.8/dist-packages/pygccxml-2.2.1-py3.8.egg/pygccxml/declarations/scopedef.py\", line 92, in get_single\n raise runtime_errors.multiple_declarations_found_t(decl_matcher)\npygccxml.declarations.runtime_errors.multiple_declarations_found_t: Multiple declarations have been found. Matcher: [(decl type==namespace_t) and (name==std)]\n\nIs there anyone that can help me to solve it ?\nWords fail me to express the heartfelt gratitude","author_login":"tuanhe","author_association":"NONE","created_at":"2023-02-07T09:24:38+08:00","repo_name":"ompl/ompl","issue_id":1573975188,"issue_number":986,"issue_url":"https://github.com/ompl/ompl/issues/986","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1420456518","fragment_type":"issue_comment","sequence":1,"text":"Some updated:\npip3 list\nPackage Version\n---------- -------\nnumpy 1.17.4 \npip 20.0.2 \npygccxml 2.2.1 \npyplusplus 1.8.5 \n\n $castxml --version\ncastxml version 0.5.0\n\nCastXML project maintained and supported by Kitware (kitware.com).\n\nclang version 13.0.0\nTarget: aarch64-unknown-linux-gnu\nThread model: posix","author_login":"tuanhe","author_association":"NONE","created_at":"2023-02-07T09:27:02+08:00","repo_name":"ompl/ompl","issue_id":1573975188,"issue_number":986,"issue_url":"https://github.com/ompl/ompl/issues/986","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1421389113","fragment_type":"issue_comment","sequence":2,"text":"This is the same issue as reported in #981, please keep discussion there.","author_login":"zkingston","author_association":"CONTRIBUTOR","created_at":"2023-02-07T20:19:07+08:00","repo_name":"ompl/ompl","issue_id":1573975188,"issue_number":986,"issue_url":"https://github.com/ompl/ompl/issues/986","linked_issue_ids":[1565368720],"is_known_query_context":false},{"document_id":"gh_issue_1565368720","fragment_type":"issue_description","sequence":0,"text":"Cannot build Python bindings on NVidia Jetson Orin\nHi all, recently I tried to build OMPL Python bindings on Nvidia Jetson Orin but faild. \nI have tried OMPL 1.5.2, OMPL 1.6.0 and the main(d9c9566) branch which updated recently, but still get the same error while compiling: \nimage\nI have tried the provied script **install-ompl-ubuntu.sh** and the **Dockerfile**, respectly under Ubuntu 20.04 and 22.04 in docker, and also tried different version of **Castxml** (the latest **0.5.0** and **0.3.6**). \n\nI notice the similar issues and tried, but still met that error. \n\nthx for reading and hope your reply","author_login":"gongchengli","author_association":"NONE","created_at":"2023-02-01T03:30:29+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1412373715","fragment_type":"issue_comment","sequence":1,"text":"How much RAM does your platform have? Building the Python bindings can be rather RAM hungry - at least 6GB is recommended.","author_login":"zkingston","author_association":"CONTRIBUTOR","created_at":"2023-02-01T16:45:08+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413102388","fragment_type":"issue_comment","sequence":2,"text":"Hi Zachary @zkingston , appreciate your timely reply. Our target platform is Nvidia Jetson AGX Orin Developer Kit, the memory is 32 GB 256-bit LPDDR5.","author_login":"im-renpei","author_association":"NONE","created_at":"2023-02-02T03:31:46+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1413204420","fragment_type":"issue_comment","sequence":3,"text":"Thx for your reply. \nAs for the RAM, I think that's quite enough as shown below, \nimage","author_login":"gongchengli","author_association":"NONE","created_at":"2023-02-02T06:09:48+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1415099722","fragment_type":"issue_comment","sequence":4,"text":"oops, I also met the exactly same issue ! It f**ked me for nearly a month.\nQuite strange, that Cannot build on ubuntu Arm platform.\n@zkingston , could you help to check it ?\nThanks","author_login":"tuanhe","author_association":"NONE","created_at":"2023-02-03T06:20:03+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1416151173","fragment_type":"issue_comment","sequence":5,"text":"Can you please post the full output of trying to compile the docker image on your platform? #958 also had issues compiling on ARM.","author_login":"zkingston","author_association":"CONTRIBUTOR","created_at":"2023-02-03T17:03:00+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1416681366","fragment_type":"issue_comment","sequence":6,"text":"Here is the output of building the docker container, \n\nlog.out.txt","author_login":"gongchengli","author_association":"NONE","created_at":"2023-02-04T07:00:03+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1418279044","fragment_type":"issue_comment","sequence":7,"text":"The error appears to be with CastXML on ARM, a number of these errors appear, indicating that it failed to generate output, and thus the rest of the Python binding pipeline failed:\n\nIn file included from /tmp/tmpapu0i3zy.h:1:\nIn file included from ./bindings/base.h:1145:\nIn file included from /usr/include/eigen3/Eigen/Core:214:\n/usr/include/eigen3/Eigen/src/Core/arch/NEON/PacketMath.h:3096:10: error: use of undeclared identifier 'vrndn_f32'\n{ return vrndn_f32(a); }\n\nI'm surprised this error occurred with the latest CastXML - it appears to have been fixed in the past: URL \nCan you verify that if you install the latest CastXML in Docker if things work?","author_login":"zkingston","author_association":"CONTRIBUTOR","created_at":"2023-02-05T22:13:09+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1418458314","fragment_type":"issue_comment","sequence":8,"text":"@zkingston I've just verified castxml 0.5.0 from the official URL (the \"castxml_v0.5.0-linux-aarch64.tar.gz\"), \n\nand updated the Dockerfile (only comment out the castxml and use COPY command), \nompl.Dockerfile.txt\n\nAfter all, the output shows like, \nlog0206.out.txt","author_login":"gongchengli","author_association":"NONE","created_at":"2023-02-06T03:31:31+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1419449911","fragment_type":"issue_comment","sequence":9,"text":"I believe this is now an issue with pygccxml ( URL - please make sure the most recent version is installed in the docker as well. Also take a look at the discussion in URL - the same error message appears there.","author_login":"zkingston","author_association":"CONTRIBUTOR","created_at":"2023-02-06T17:22:34+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420113352","fragment_type":"issue_comment","sequence":10,"text":"HI, just followed the issue these days and tried your tips , but all failed! All failed. \nWe had absolutely 100% sure that we use the latset pygccxml(it's 2.2.1) and the latest commit of the pygccxml is May.25.2021\nAnd\n#725 is the same issue , but no one can solve it!!!!","author_login":"tuanhe","author_association":"NONE","created_at":"2023-02-07T02:39:18+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420261461","fragment_type":"issue_comment","sequence":11,"text":"@zkingston I am sure that the latest pygccxml is installed in the docker. \nAlso, I tried the solutions mentioned in #725 , but unfortunately they doesn't work.","author_login":"gongchengli","author_association":"NONE","created_at":"2023-02-07T06:24:41+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1421409296","fragment_type":"issue_comment","sequence":12,"text":"I do not have an ARM platform to test on to replicate this, could you insert `traceback.print_exc()` at the bottom of `generate_bindings.py` to see where exactly the error is occuring?","author_login":"zkingston","author_association":"CONTRIBUTOR","created_at":"2023-02-07T20:34:58+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1830576093","fragment_type":"issue_comment","sequence":13,"text":"Should be fixed by the recently merged #1100 - let me know if that isn't the case.","author_login":"zkingston","author_association":"MEMBER","created_at":"2023-11-28T19:43:21+08:00","repo_name":"ompl/ompl","issue_id":1565368720,"issue_number":981,"issue_url":"https://github.com/ompl/ompl/issues/981","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0457","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"UnsatisfiedLinkError / SIGSEGV (createSkiaSurface) on Android <= 9 with 9.13.1+?","query_context":"### Description\n\nAfter upgrading from 9.13.0 to 9.13.1 or above, our app crashes on Android 8 and 9 devices due to native lib loading error. \n\nI traced it down to 9.13.1 and potentially the change from NDK 25 to 27 or the cmake option changes. \n URL \n\nOr at least that's the only change in 9.13.1 that looks suspicious to causing any issues. \n\n### Provide a Repro\n\nUse Rive in an app and open the screen with the rive component on an Android 9 device. Notice that with 9.13.0 it works and with 9.13.1 the app crashes. I can only make it crash when I go to the screen with the component but based on Play Store console / Instabug it might to happen on app launch as well. \n\n### Expected behavior\n\nShould not crash\n\n#### Screenshots\n\nCrash #1: \n \n \n\nCrash #2: \n \n \n\n### Device & Versions\n\n- Device: Broad range of devices - the device count is low because we pushed an update quickly reverting to 9.13.0\n \n\n- SDK Level [e.g. Android SDK API Level 30]\n26, 27, 28\n\n#### Additional context\n\nThe app is targeting / compile SDK is 35.","known_context_document_ids":["gh_issue_2773264236"],"reference_answer":"Hello @graart124, and thank you for your report. I am the maintainer of Rive Android, and am looking into this now. I believe this should be solved in version 10+, as Skia is no longer a dependency for Rive Android. More details can be found on this issue which has similar causes.\n\nPlease upgrade to 10+ to resolve this. I will be closing this issue for now as resolved, but do leave a comment if the issue persists after upgrading. Thanks!","answer_document_id":"gh_comment_2702268051","silver_evidence_path":["gh_comment_2575991988","gh_issue_2755746626","gh_comment_2702268051"],"evidence_issue_ids":[2773264236,2755746626],"source_repo_name":"rive-app/rive-android","source_issue_id":2773264236,"source_issue_number":350,"source_issue_url":"https://github.com/rive-app/rive-android/issues/350","target_repo_name":"rive-app/rive-android","target_issue_id":2755746626,"target_issue_number":348,"target_issue_url":"https://github.com/rive-app/rive-android/issues/348","reference_anchor_document_id":"gh_comment_2575991988","reference_answer_author":"ErikUggeldahl","reference_answer_author_association":"COLLABORATOR","quality_score":89.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3,"anchor_target_overlap":0.0,"target_answer_overlap":0.1714},"issue_created_at":"2025-01-07T16:29:11+08:00","valid_comment_count":5,"fragments":[{"document_id":"gh_issue_2773264236","fragment_type":"issue_description","sequence":0,"text":"UnsatisfiedLinkError / SIGSEGV (createSkiaSurface) on Android <= 9 with 9.13.1+\n### Description\n\nAfter upgrading from 9.13.0 to 9.13.1 or above, our app crashes on Android 8 and 9 devices due to native lib loading error. \n\nI traced it down to 9.13.1 and potentially the change from NDK 25 to 27 or the cmake option changes. \n URL \n\nOr at least that's the only change in 9.13.1 that looks suspicious to causing any issues. \n\n### Provide a Repro\n\nUse Rive in an app and open the screen with the rive component on an Android 9 device. Notice that with 9.13.0 it works and with 9.13.1 the app crashes. I can only make it crash when I go to the screen with the component but based on Play Store console / Instabug it might to happen on app launch as well. \n\n### Expected behavior\n\nShould not crash\n\n#### Screenshots\n\nCrash #1: \n \n \n\nCrash #2: \n \n \n\n### Device & Versions\n\n- Device: Broad range of devices - the device count is low because we pushed an update quickly reverting to 9.13.0\n \n\n- SDK Level [e.g. Android SDK API Level 30]\n26, 27, 28\n\n#### Additional context\n\nThe app is targeting / compile SDK is 35.","author_login":"thorbenprimke","author_association":"NONE","created_at":"2025-01-07T16:29:11+08:00","repo_name":"rive-app/rive-android","issue_id":2773264236,"issue_number":350,"issue_url":"https://github.com/rive-app/rive-android/issues/350","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2575991988","fragment_type":"issue_comment","sequence":1,"text":"It's the same as #348. We build out so files with NDK 26. So not sure if this is simply NDK related since the change was upgrading from NDK 25 to 27.","author_login":"thorbenprimke","author_association":"NONE","created_at":"2025-01-07T18:43:36+08:00","repo_name":"rive-app/rive-android","issue_id":2773264236,"issue_number":350,"issue_url":"https://github.com/rive-app/rive-android/issues/350","linked_issue_ids":[2755746626],"is_known_query_context":false},{"document_id":"gh_comment_2624696578","fragment_type":"issue_comment","sequence":2,"text":"We had also had the UnsatisfiedLinkError when starting rive. Which was caused due to having multiple dependencies which have native libraries\n\nIn our case we have both mapbox and rive as a dependency and both try to add libc++_shared.so.\nMapbox uses the ndk23 to compile their native code so libc++_shared.so is not using 16kb page size yet.\n\nWe were using:\n\nkotlin\npackagingOptions {\n jniLibs.pickFirsts += setOf(\"**/libc++_shared.so\")\n}\n\nfix the error\n\n* What went wrong:\nExecution failed for task ':android:vriendenloterij:mergeAccDebugNativeLibs'.\n \n \n - /Users/user/.gradle/caches/8.12.1/transforms/40386025456db6d0cd93126c8a44ec07/transformed/common-24.9.0/jni/arm64-v8a/libc++_shared.so\n - /Users/user/.gradle/caches/8.12.1/transforms/6f1af6f97dcf0effdcb3e9de2c15ce67/transformed/rive-android-9.13.10/jni/arm64-v8a/libc++_shared.so\n If you are using jniLibs and CMake IMPORTED targets, see\n URL \n\nSo it always picks the first .so file which is found so in this case the Mapbox one.\n\nThe fix is to ensure all native libraries are compiled with ndk27. For mapbox it was easy since the provide a separate artifact `com.mapbox.maps:android-ndk27` \n\nSo would recommend Rive to revert the change the made in 9.13.1 where they update the NDK which seems a breaking change, not perse for Rive but for other native libraries. and if the want to also build a NDK27 version make a separate artifact. To ensure its backwards compatible and once NDK28 is released the artifacts should be reversed with a specific artifact targeting ndk26 or lower. Since 16kb pages will be enabled by default then.","author_login":"aegis123","author_association":"NONE","created_at":"2025-01-30T14:44:38+08:00","repo_name":"rive-app/rive-android","issue_id":2773264236,"issue_number":350,"issue_url":"https://github.com/rive-app/rive-android/issues/350","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2700123804","fragment_type":"issue_comment","sequence":3,"text":"Looks like it is solved with `10.x` (tested on `10.0.1`). Can anyone else confirm that as well?","author_login":"PhilippNowak96","author_association":"NONE","created_at":"2025-03-05T07:49:00+08:00","repo_name":"rive-app/rive-android","issue_id":2773264236,"issue_number":350,"issue_url":"https://github.com/rive-app/rive-android/issues/350","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2794618481","fragment_type":"issue_comment","sequence":4,"text":"We're still getting crashes with 10.0.5 on API 23 (6.0) - the crash just changed:\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] JNI DETECTED ERROR IN APPLICATION: JNI CallVoidMethodV called with pending exception java.lang.NoSuchMethodError: no non-static method \"Lapp/rive/runtime/kotlin/renderers/RiveArtboardRenderer;.setRendererType(I)V\"\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at long app.rive.runtime.kotlin.renderers.Renderer.constructor(boolean, int) (Renderer.kt:-2)\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at void app.rive.runtime.kotlin.renderers.Renderer.make() (Renderer.kt:61)\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at void app.rive.runtime.kotlin.RiveTextureView.onAttachedToWindow() (RiveTextureView.kt:53)\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at void app.rive.runtime.kotlin.RiveAnimationView.onAttachedToWindow() (RiveAnimationView.kt:875)\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at void android.view.View.dispatchAttachedToWindow(android.view.View$AttachInfo, int) (View.java:14514)\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at void android.view.ViewGroup.dispatchAttachedToWindow(android.view.View$AttachInfo, int) (ViewGroup.java:2843)\n2025-04-09 18:21:56.193 6650-6650 art com.mudflap.mudflap.develop A art/runtime/java_vm_ext.cc:410] at void android.view.ViewGroup.dispatchAttachedToWindow(android.view.View$AttachInfo, int) (ViewGroup.java:2843)\n2025-04-0","author_login":"jt-gilkeson","author_association":"NONE","created_at":"2025-04-10T17:23:59+08:00","repo_name":"rive-app/rive-android","issue_id":2773264236,"issue_number":350,"issue_url":"https://github.com/rive-app/rive-android/issues/350","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2755746626","fragment_type":"issue_description","sequence":0,"text":"rive_android::SkiaThreadState::createSkiaSurface\n### Description\n\nAfter updating Rive Android SDK to version 9.13.4, fatal exceptions rive_android::SkiaThreadState::createSkiaSurface started appearing in Crashlytics. The issue occurs on devices running Android 9 and below (e.g., Galaxy S8, Galaxy S9, P20Pro, Galaxy S8+).\n\n### Provide a Repro\n\n \n\n### Expected behavior\n\nThe animation should display correctly on Android 9 and lower without causing crashes.\n\n#### Screenshots\n\n \n\nScreenshot\n\n### Device & Versions (please complete the following information)\nDevices: Galaxy S8, Galaxy S9, P20Pro, Galaxy S8+\nOS: Android 9 and below\nSDK Version: 9.13.4","author_login":"graart124","author_association":"NONE","created_at":"2024-12-23T10:43:51+08:00","repo_name":"rive-app/rive-android","issue_id":2755746626,"issue_number":348,"issue_url":"https://github.com/rive-app/rive-android/issues/348","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2702268051","fragment_type":"issue_comment","sequence":1,"text":"Hello @graart124, and thank you for your report. I am the maintainer of Rive Android, and am looking into this now. I believe this should be solved in version 10+, as Skia is no longer a dependency for Rive Android. More details can be found on this issue which has similar causes.\n\nPlease upgrade to 10+ to resolve this. I will be closing this issue for now as resolved, but do leave a comment if the issue persists after upgrading. Thanks!","author_login":"ErikUggeldahl","author_association":"COLLABORATOR","created_at":"2025-03-05T22:57:40+08:00","repo_name":"rive-app/rive-android","issue_id":2755746626,"issue_number":348,"issue_url":"https://github.com/rive-app/rive-android/issues/348","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0458","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Your local Keycloak doesn't seem to be running.","query_context":"Hello,\n\nsorry I this is not the correct Github project for this issue. I'm trying to follow the tutorial to check out Keycloakify. The steps I've follow were:\n1. Cloning the Keycloakify starter `git clone URL as mentioned here: URL \n2. Changing directory `cd keycloakify-starter`\n3. `yarn install`\n4. Testing the theme locally using Docker `npx keycloakify start-keycloak` (I've used version 25.0)\n\nAfter that everything appears to be running \n\nThe ftl files from ./dist_keycloak/theme are mounted in the Keycloak container.\n\nKeycloak Admin console: URL \n- user: admin\n- password: admin\n\nYour theme is accessible at:\n➜ URL \n\nYou can login with the following credentials:\n- username: testuser\n- password: password123\n\nWatching for changes in ./\n\nHowever, when I follow the link to URL as mentioned in the tutorial, I get the error `Your local Keycloak doesn't seem to be running. Please refer to the documentation.`\n\nHowever, the output of `docker ps` shows that the Docker container is running and ports are forwarded\n\nCONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES\nb7c0bd51e41a quay.io/keycloak/keycloak:25.0 \"/opt/keycloak/bin/k…\" About a minute ago Up About a minute 8443/tcp, 0.0.0.0:8080->8080/tcp, :::8080->8080/tcp, 9000/tcp keycloak-keycloakify\n\nAre there any steps that I'm missing?","known_context_document_ids":["gh_issue_2518730856"],"reference_answer":"Well I've updated URL so that it display an alert when using Safari. \n\n<img width=\"1186\" alt=\"image\" src=\" URL \n\nIt's not ideal but the Safary security policies being what they are the only workaround would be to to locally serve keycloakify/my-theme.keycloakify.dev when running `npx keycloakify start-dev` so I'll settle with the alert at least for now.","answer_document_id":"gh_comment_2205655812","silver_evidence_path":["gh_comment_2343115123","gh_issue_2386905821","gh_comment_2205655812"],"evidence_issue_ids":[2518730856,2386905821],"source_repo_name":"keycloakify/keycloakify-starter","source_issue_id":2518730856,"source_issue_number":27,"source_issue_url":"https://github.com/keycloakify/keycloakify-starter/issues/27","target_repo_name":"keycloakify/keycloakify","target_issue_id":2386905821,"target_issue_number":576,"target_issue_url":"https://github.com/keycloakify/keycloakify/issues/576","reference_anchor_document_id":"gh_comment_2343115123","reference_answer_author":"garronej","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.125,"anchor_target_overlap":0.1875,"target_answer_overlap":0.1481},"issue_created_at":"2024-09-11T06:59:24+08:00","valid_comment_count":9,"fragments":[{"document_id":"gh_issue_2518730856","fragment_type":"issue_description","sequence":0,"text":"Your local Keycloak doesn't seem to be running.\nHello,\n\nsorry I this is not the correct Github project for this issue. I'm trying to follow the tutorial to check out Keycloakify. The steps I've follow were:\n1. Cloning the Keycloakify starter `git clone URL as mentioned here: URL \n2. Changing directory `cd keycloakify-starter`\n3. `yarn install`\n4. Testing the theme locally using Docker `npx keycloakify start-keycloak` (I've used version 25.0)\n\nAfter that everything appears to be running \n\nThe ftl files from ./dist_keycloak/theme are mounted in the Keycloak container.\n\nKeycloak Admin console: URL \n- user: admin\n- password: admin\n\nYour theme is accessible at:\n➜ URL \n\nYou can login with the following credentials:\n- username: testuser\n- password: password123\n\nWatching for changes in ./\n\nHowever, when I follow the link to URL as mentioned in the tutorial, I get the error `Your local Keycloak doesn't seem to be running. Please refer to the documentation.`\n\nHowever, the output of `docker ps` shows that the Docker container is running and ports are forwarded\n\nCONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES\nb7c0bd51e41a quay.io/keycloak/keycloak:25.0 \"/opt/keycloak/bin/k…\" About a minute ago Up About a minute 8443/tcp, 0.0.0.0:8080->8080/tcp, :::8080->8080/tcp, 9000/tcp keycloak-keycloakify\n\nAre there any steps that I'm missing?","author_login":"CertainPassenger","author_association":"NONE","created_at":"2024-09-11T06:59:24+08:00","repo_name":"keycloakify/keycloakify-starter","issue_id":2518730856,"issue_number":27,"issue_url":"https://github.com/keycloakify/keycloakify-starter/issues/27","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2343115123","fragment_type":"issue_comment","sequence":1,"text":"Hello @CertainPassenger, \n\nSorry to heare you are experiencing an issue. \n\nThere might be some securities policies in place on the browser you are using that prevent opening an iframe to a non https location. It's the case for Safari. So I display this message. \n\nWhat web browser are you using by default, on which OS? \n\nMabe try with chrome and let me know if it work. \n\nAlso try to see if you can access ` URL","author_login":"garronej","author_association":"COLLABORATOR","created_at":"2024-09-11T09:23:17+08:00","repo_name":"keycloakify/keycloakify-starter","issue_id":2518730856,"issue_number":27,"issue_url":"https://github.com/keycloakify/keycloakify-starter/issues/27","linked_issue_ids":[2386905821],"is_known_query_context":false},{"document_id":"gh_comment_2343125575","fragment_type":"issue_comment","sequence":2,"text":"@garronej \n\nThanks! Your comment helped me narrowing down the issue! I am using Microsoft Edge on Linux (Ubuntu 24.04), however the issue was the addon uBlock Origin. After disabling the addon the redirect worked without any problems.","author_login":"CertainPassenger","author_association":"NONE","created_at":"2024-09-11T09:28:22+08:00","repo_name":"keycloakify/keycloakify-starter","issue_id":2518730856,"issue_number":27,"issue_url":"https://github.com/keycloakify/keycloakify-starter/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2343250256","fragment_type":"issue_comment","sequence":3,"text":"Thank for reporting back, I've added a notice on the my-theme app: URL","author_login":"garronej","author_association":"COLLABORATOR","created_at":"2024-09-11T10:23:33+08:00","repo_name":"keycloakify/keycloakify-starter","issue_id":2518730856,"issue_number":27,"issue_url":"https://github.com/keycloakify/keycloakify-starter/issues/27","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2386905821","fragment_type":"issue_description","sequence":0,"text":"Keycloakify v10 unable to test in Keycloak container\nThis is a continuation of URL I didn't want to pollute that PR any further!\n\nWhen running latest starter template within Keycloak docker (e.g. npx keycloakify start-keycloak) it just spits out a blank page with the following error:\n \n\n...and contains the following in the console:\n \n[Error] Fetch API cannot load URL due to access control checks.\n[Error] OIDC initialization error: Bad configuration. Timed out after 5000ms\nMaybe something to look into? I couldn't see anything in the config that would cause that.\n\nI've validated port 8080 is open and the Keycloak container is correctly binding to it. \n\nThis is on macOS 14.5. Using yarn 1.22 since no version is specified in package.json and hence corepack uses that by default.","author_login":"jamesdh","author_association":"NONE","created_at":"2024-07-02T18:39:06+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2204058065","fragment_type":"issue_comment","sequence":1,"text":"Damn this is the exact same config I'm using... \nAre you on apple Silicon? \nCan we jump on a quick call on discord to see what's up? \n URL","author_login":"garronej","author_association":"COLLABORATOR","created_at":"2024-07-02T18:43:20+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2204064016","fragment_type":"issue_comment","sequence":2,"text":"@garronej it's Safari vs Chrome 🤣 I just tried it in Chrome and it works. Safari must be more restrictive regarding CORS or redirect URL's or some such thing.","author_login":"jamesdh","author_association":"NONE","created_at":"2024-07-02T18:46:41+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2204068644","fragment_type":"issue_comment","sequence":3,"text":"It's a security feature of safari. I'll try and see if I can go around it, it should work with other browsers though. \nAnd it goes without saying that this problem only affect the test app that redirects to your locally running keycloak test instance.","author_login":"garronej","author_association":"COLLABORATOR","created_at":"2024-07-02T18:49:26+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2204087424","fragment_type":"issue_comment","sequence":4,"text":"Damn... there's no way around it :( to make it work on safari I'll have to spin another server locally just for this test app.","author_login":"garronej","author_association":"COLLABORATOR","created_at":"2024-07-02T19:01:38+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2205655812","fragment_type":"issue_comment","sequence":5,"text":"Well I've updated URL so that it display an alert when using Safari. \n\n<img width=\"1186\" alt=\"image\" src=\" URL \n\nIt's not ideal but the Safary security policies being what they are the only workaround would be to to locally serve keycloakify/my-theme.keycloakify.dev when running `npx keycloakify start-dev` so I'll settle with the alert at least for now.","author_login":"garronej","author_association":"COLLABORATOR","created_at":"2024-07-03T10:07:58+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2206142634","fragment_type":"issue_comment","sequence":6,"text":"Thanks @garronej! This seems like a good enough solution. Glad we were able to figure out the cause!","author_login":"jamesdh","author_association":"NONE","created_at":"2024-07-03T13:53:42+08:00","repo_name":"keycloakify/keycloakify","issue_id":2386905821,"issue_number":576,"issue_url":"https://github.com/keycloakify/keycloakify/issues/576","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0459","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: KeyError: 'title'?","query_context":"### Do you need to file an issue?\n\n- [x] I have searched the existing issues and this bug is not already filed.\n- [ ] My model is hosted on OpenAI or Azure. If not, please look at the \"model providers\" issue and don't file a new one here.\n- [x] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.\n\n### Describe the bug\n\nI used the official example - book.txt , but a bug occurred.\n`\nTraceback (most recent call last):\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/run/run_pipeline.py\", line 143, in _run_pipeline\n result = await workflow_function(config, context)\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/workflows/extract_graph.py\", line 46, in run_workflow\n entities, relationships = await extract_graph(\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/workflows/extract_graph.py\", line 82, in extract_graph\n extracted_entities, extracted_relationships = await extractor(\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/operations/extract_graph/extract_graph.py\", line 132, in extract_graph\n entities = _merge_entities(entity_dfs)\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/operations/extract_graph/extract_graph.py\", line 156, in _merge_entities\n all_entities.groupby([\"title\", \"type\"], sort=False)\n File \"/Users/slian/miniconda3/envs/graphrag/lib/python3.10/site-packages/pandas/core/frame.py\", line 9183, in groupby\n return DataFrameGroupBy(\n File \"/Users/slian/miniconda3/envs/graphrag/lib/python3.10/site-packages/pandas/core/groupby/groupby.py\", line 1329, in __init__\n grouper, exclusions, obj = get_grouper(\n File \"/Users/slian/miniconda3/envs/graphrag/lib/python3.10/site-packages/pandas/core/groupby/grouper.py\", line 1043, in get_grouper\n raise KeyError(gpr)\nKeyError: 'title'\n`\nHere is my settings.yaml\n\nyaml\n### This config file contains required core defaults that must be set, along with a handful of common optional settings.\n### For a full list of available settings, see URL \n\n### LLM settings ###\n## There are a number of settings to tune the threading and token limits for LLM calls - check the docs.\n\nmodels:\n default_chat_model:\n type: openai_chat # or azure_openai_chat\n api_base: URL \n # api_version: 2024-05-01-preview\n auth_type: api_key # or azure_managed_identity\n api_key: ollama # set this in the generated .env file\n # audience: \" URL \n # organization: \n model: llama3\n # deployment_name: \n encoding_model: cl100k_base # automatically set by tiktoken if left undefined\n # model_supports_json: true # recommended if this is available for your model.\n concurrent_requests: 25 # max number of simultaneous LLM requests allowed\n async_mode: threaded # or asyncio\n retry_strategy: native\n max_retries: -1 # set to -1 for dynamic retry logic (most optimal setting based on server response)\n tokens_per_minute: 0 # set to 0 to disable rate limiting\n requests_per_minute: 0 # set to 0 to disable rate limiting\n default_embedding_model:\n type: openai_embedding # or azure_openai_embedding\n api_base: URL \n # api_version: 2024-05-01-preview\n auth_type: api_key # or azure_managed_identity\n api_key: xinference\n # audience: \" URL \n # organization: \n model: bge-m3\n # deployment_name: \n encoding_model: cl100k_base # automatically set by tiktoken if left undefined\n # model_supports_json: true # recommended if this is available for your model.\n concurrent_requests: 25 # max number of simultaneous LLM requests allowed\n async_mode: threaded # or asyncio\n retry_strategy: native\n max_retries: -1 # set to -1 for dynamic retry logic (most optimal setting based on server response)\n tokens_per_minute: 0 # set to 0 to disable rate limiting\n requests_per_minute: 0 # set to 0 to disable rate limiting\n\nvector_store:\n default_vector_store:\n type: lancedb\n db_uri: output/lancedb\n container_name: default\n overwrite: True\n\nembed_text:\n model_id: default_embedding_model\n vector_store_id: default_vector_store\n\n### Input settings ###\n\ninput:\n type: file\n file_type: text\n base_dir: \"input\"\n text_column: \"text\"\n title_column: \"title\"\n \nchunks:\n size: 1200\n overlap: 100\n group_by_columns: [id,title]\n\n### Output settings ###\n## If blob storage is specified in the following four sections,\n## connection_string and container_name must be provided\n\ncache:\n type: file # [file, blob, cosmosdb]\n base_dir: \"cache\"\n\nreporting:\n type: file # [file, blob, cosmosdb]\n base_dir: \"logs\"\n\noutput:\n type: file # [file, blob, cosmosdb]\n base_dir: \"output\"\n\n### Workflow settings ###\n\nextract_graph:\n model_id: default_chat_model\n prompt: \"prompts/extract_graph.txt\"\n entity_types: [organization,person,geo,event]\n max_gleanings: 1\n\nsummarize_descriptions:\n model_id: default_chat_model\n prompt: \"prompts/summarize_descriptions.txt\"\n max_length: 500\n\nextract_graph_nlp:\n text_analyzer:\n extractor_type: regex_english # [regex_english, syntactic_parser, cfg]\n\nextract_claims:\n enabled: false\n model_id: default_chat_model\n prompt: \"prompts/extract_claims.txt\"\n description: \"Any claims or facts that could be relevant to information discovery.\"\n max_gleanings: 1\n\ncommunity_reports:\n model_id: default_chat_model\n graph_prompt: \"prompts/community_report_graph.txt\"\n text_prompt: \"prompts/community_report_text.txt\"\n max_length: 3000\n max_input_length: 80000\n\ncluster_graph:\n max_cluster_size: 10\n\nembed_graph:\n enabled: false # if true, will generate node2vec embeddings for nodes\n\numap:\n enabled: false # if true, will generate UMAP embeddings for nodes (embed_graph must also be enabled)\n\nsnapshots:\n graphml: false\n embeddings: false\n\n### Query settings ###\n## The prompt locations are required here, but each search method has a number of optional knobs that can be tuned.\n## See the config docs: URL \n\nlocal_search:\n chat_model_id: default_chat_model\n embedding_model_id: default_embedding_model\n prompt: \"prompts/local_search_system_prompt.txt\"\n\nglobal_search:\n chat_model_id: default_chat_model\n map_prompt: \"prompts/global_search_map_system_prompt.txt\"\n reduce_prompt: \"prompts/global_search_reduce_system_prompt.txt\"\n knowledge_prompt: \"prompts/global_search_knowledge_system_prompt.txt\"\n\ndrift_search:\n chat_model_id: default_chat_model\n embedding_model_id: default_embedding_model\n prompt: \"prompts/drift_search_system_prompt.txt\"\n reduce_prompt: \"prompts/drift_search_reduce_prompt.txt\"\n\nbasic_search:\n chat_model_id: default_chat_model\n embedding_model_id: default_embedding_model\n prompt: \"prompts/basic_search_system_prompt.txt\"\n\nWhat should I do?\n\n### Steps to reproduce\n\n_No response_\n\n### Expected Behavior\n\n_No response_\n\n### GraphRAG Config Used\n\nyaml\n# Paste your config here\n\n### Logs and screenshots\n\n_No response_\n\n### Additional Information\n\n- GraphRAG Version:\n- Operating System:\n- Python Version:\n- Related Issues:","known_context_document_ids":["gh_issue_2918730964"],"reference_answer":"2.6.0 is available now. Not only does it resolve the format issues from OpenAI, it also introduces the option to use LiteLLM to configure any model provider that they support.","answer_document_id":"gh_comment_3324919712","silver_evidence_path":["gh_comment_2749694635","gh_issue_2423692022","gh_comment_3324919712"],"evidence_issue_ids":[2918730964,2423692022],"source_repo_name":"microsoft/graphrag","source_issue_id":2918730964,"source_issue_number":1805,"source_issue_url":"https://github.com/microsoft/graphrag/issues/1805","target_repo_name":"microsoft/graphrag","target_issue_id":2423692022,"target_issue_number":657,"target_issue_url":"https://github.com/microsoft/graphrag/issues/657","reference_anchor_document_id":"gh_comment_2749694635","reference_answer_author":"natoverse","reference_answer_author_association":"COLLABORATOR","quality_score":86.4,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.08,"anchor_target_overlap":0.16,"target_answer_overlap":0.2667},"issue_created_at":"2025-03-14T01:06:29+08:00","valid_comment_count":18,"fragments":[{"document_id":"gh_issue_2918730964","fragment_type":"issue_description","sequence":0,"text":"[Bug]: KeyError: 'title'\n### Do you need to file an issue?\n\n- [x] I have searched the existing issues and this bug is not already filed.\n- [ ] My model is hosted on OpenAI or Azure. If not, please look at the \"model providers\" issue and don't file a new one here.\n- [x] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.\n\n### Describe the bug\n\nI used the official example - book.txt , but a bug occurred.\n`\nTraceback (most recent call last):\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/run/run_pipeline.py\", line 143, in _run_pipeline\n result = await workflow_function(config, context)\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/workflows/extract_graph.py\", line 46, in run_workflow\n entities, relationships = await extract_graph(\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/workflows/extract_graph.py\", line 82, in extract_graph\n extracted_entities, extracted_relationships = await extractor(\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/operations/extract_graph/extract_graph.py\", line 132, in extract_graph\n entities = _merge_entities(entity_dfs)\n File \"/Users/slian/Desktop/RAG/graphrag/graphrag/index/operations/extract_graph/extract_graph.py\", line 156, in _merge_entities\n all_entities.groupby([\"title\", \"type\"], sort=False)\n File \"/Users/slian/miniconda3/envs/graphrag/lib/python3.10/site-packages/pandas/core/frame.py\", line 9183, in groupby\n return DataFrameGroupBy(\n File \"/Users/slian/miniconda3/envs/graphrag/lib/python3.10/site-packages/pandas/core/groupby/groupby.py\", line 1329, in __init__\n grouper, exclusions, obj = get_grouper(\n File \"/Users/slian/miniconda3/envs/graphrag/lib/python3.10/site-packages/pandas/core/groupby/grouper.py\", line 1043, in get_grouper\n raise KeyError(gpr)\nKeyError: 'title'\n`\nHere is my settings.yaml\n\nyaml\n### This config file contains required core defaults that must be set, along with a handful of common optional settings.\n### For a full list of available settings, see URL \n\n### LLM settings ###\n## There are a number of settings to tune the threading and token limits for LLM calls - check the docs.\n\nmodels:\n default_chat_model:\n type: openai_chat # or azure_openai_chat\n api_base: URL \n # api_version: 2024-05-01-preview\n auth_type: api_key # or azure_managed_identity\n api_key: ollama # set this in the generated .env file\n # audience: \" URL \n # organization: \n model: llama3\n # deployment_name: \n encoding_model: cl100k_base # automatically set by tiktoken if left undefined\n # model_supports_json: true # recommended if this is available for your model.\n concurrent_requests: 25 # max number of simultaneous LLM requests allowed\n async_mode: threaded # or asyncio\n retry_strategy: native\n max_retries: -1 # set to -1 for dynamic retry logic (most optimal setting based on server response)\n tokens_per_minute: 0 # set to 0 to disable rate limiting\n requests_per_minute: 0 # set to 0 to disable rate limiting\n default_embedding_model:\n type: openai_embedding # or azure_openai_embedding\n api_base: URL \n # api_version: 2024-05-01-preview\n auth_type: api_key # or azure_managed_identity\n api_key: xinference\n # audience: \" URL \n # organization: \n model: bge-m3\n # deployment_name: \n encoding_model: cl100k_base # automatically set by tiktoken if left undefined\n # model_supports_json: true # recommended if this is available for your model.\n concurrent_requests: 25 # max number of simultaneous LLM requests allowed\n async_mode: threaded # or asyncio\n retry_strategy: native\n max_retries: -1 # set to -1 for dynamic retry logic (most optimal setting based on server response)\n tokens_per_minute: 0 # set to 0 to disable rate limiting\n requests_per_minute: 0 # set to 0 to disable rate limiting\n\nvector_store:\n default_vector_store:\n type: lancedb\n db_uri: output/lancedb\n container_name: default\n overwrite: True\n\nembed_text:\n model_id: default_embedding_model\n vector_store_id: default_vector_store\n\n### Input settings ###\n\ninput:\n type: file\n file_type: text\n base_dir: \"input\"\n text_column: \"text\"\n title_column: \"title\"\n \nchunks:\n size: 1200\n overlap: 100\n group_by_columns: [id,title]\n\n### Output settings ###\n## If blob storage is specified in the following four sections,\n## connection_string and container_name must be provided\n\ncache:\n type: file # [file, blob, cosmosdb]\n base_dir: \"cache\"\n\nreporting:\n type: file # [file, blob, cosmosdb]\n base_dir: \"logs\"\n\noutput:\n type: file # [file, blob, cosmosdb]\n base_dir: \"output\"\n\n### Workflow settings ###\n\nextract_graph:\n model_id: default_chat_model\n prompt: \"prompts/extract_graph.txt\"\n entity_types: [organization,person,geo,event]\n max_gleanings: 1\n\nsummarize_descriptions:\n model_id: default_chat_model\n prompt: \"prompts/summarize_descriptions.txt\"\n max_length: 500\n\nextract_graph_nlp:\n text_analyzer:\n extractor_type: regex_english # [regex_english, syntactic_parser, cfg]\n\nextract_claims:\n enabled: false\n model_id: default_chat_model\n prompt: \"prompts/extract_claims.txt\"\n description: \"Any claims or facts that could be relevant to information discovery.\"\n max_gleanings: 1\n\ncommunity_reports:\n model_id: default_chat_model\n graph_prompt: \"prompts/community_report_graph.txt\"\n text_prompt: \"prompts/community_report_text.txt\"\n max_length: 3000\n max_input_length: 80000\n\ncluster_graph:\n max_cluster_size: 10\n\nembed_graph:\n enabled: false # if true, will generate node2vec embeddings for nodes\n\numap:\n enabled: false # if true, will generate UMAP embeddings for nodes (embed_graph must also be enabled)\n\nsnapshots:\n graphml: false\n embeddings: false\n\n### Query settings ###\n## The prompt locations are required here, but each search method has a number of optional knobs that can be tuned.\n## See the config docs: URL \n\nlocal_search:\n chat_model_id: default_chat_model\n embedding_model_id: default_embedding_model\n prompt: \"prompts/local_search_system_prompt.txt\"\n\nglobal_search:\n chat_model_id: default_chat_model\n map_prompt: \"prompts/global_search_map_system_prompt.txt\"\n reduce_prompt: \"prompts/global_search_reduce_system_prompt.txt\"\n knowledge_prompt: \"prompts/global_search_knowledge_system_prompt.txt\"\n\ndrift_search:\n chat_model_id: default_chat_model\n embedding_model_id: default_embedding_model\n prompt: \"prompts/drift_search_system_prompt.txt\"\n reduce_prompt: \"prompts/drift_search_reduce_prompt.txt\"\n\nbasic_search:\n chat_model_id: default_chat_model\n embedding_model_id: default_embedding_model\n prompt: \"prompts/basic_search_system_prompt.txt\"\n\nWhat should I do?\n\n### Steps to reproduce\n\n_No response_\n\n### Expected Behavior\n\n_No response_\n\n### GraphRAG Config Used\n\nyaml\n# Paste your config here\n\n### Logs and screenshots\n\n_No response_\n\n### Additional Information\n\n- GraphRAG Version:\n- Operating System:\n- Python Version:\n- Related Issues:","author_login":"Slian22","author_association":"NONE","created_at":"2025-03-14T01:06:29+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2727818817","fragment_type":"issue_comment","sequence":1,"text":"请问如何解决呢，我也遇到了这个问题：\n09:32:35,458 graphrag.index.run.run_pipeline ERROR error running workflow extract_graph\nTraceback (most recent call last):\n File \"D:\\Work\\project\\GraphRAG-2.0\\graphrag\\graphrag\\index\\run\\run_pipeline.py\", line 143, in _run_pipeline\n result = await workflow_function(config, context)\n File \"D:\\Work\\project\\GraphRAG-2.0\\graphrag\\graphrag\\index\\workflows\\extract_graph.py\", line 46, in run_workflow\n entities, relationships = await extract_graph(\n File \"D:\\Work\\project\\GraphRAG-2.0\\graphrag\\graphrag\\index\\workflows\\extract_graph.py\", line 82, in extract_graph\n extracted_entities, extracted_relationships = await extractor(\n File \"D:\\Work\\project\\GraphRAG-2.0\\graphrag\\graphrag\\index\\operations\\extract_graph\\extract_graph.py\", line 132, in extract_graph\n entities = _merge_entities(entity_dfs)\n File \"D:\\Work\\project\\GraphRAG-2.0\\graphrag\\graphrag\\index\\operations\\extract_graph\\extract_graph.py\", line 156, in _merge_entities\n all_entities.groupby([\"title\", \"type\"], sort=False)\n File \"D:\\apps\\anaconda\\envs\\GraphRAG\\lib\\site-packages\\pandas\\core\\frame.py\", line 9183, in groupby\n return DataFrameGroupBy(\n File \"D:\\apps\\anaconda\\envs\\GraphRAG\\lib\\site-packages\\pandas\\core\\groupby\\groupby.py\", line 1329, in __init__\n grouper, exclusions, obj = get_grouper(\n File \"D:\\apps\\anaconda\\envs\\GraphRAG\\lib\\site-packages\\pandas\\core\\groupby\\grouper.py\", line 1043, in get_grouper\n raise KeyError(gpr)\nKeyError: 'title'","author_login":"songzhaohui12","author_association":"NONE","created_at":"2025-03-17T01:39:58+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2749694635","fragment_type":"issue_comment","sequence":2,"text":"A key error like this indicates the entity extraction didn't work correctly (commonly due to malformed model responses) so the final table is missing a primary column. Routing this to #657 as it's impossible for us to diagnose the config for every model variant.","author_login":"natoverse","author_association":"COLLABORATOR","created_at":"2025-03-25T00:07:04+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[2423692022],"is_known_query_context":false},{"document_id":"gh_comment_2752207533","fragment_type":"issue_comment","sequence":3,"text":"I think that my situation is a bit different because I have multiple folders of indexed documents (they are dynamically generated because I have multiple agents) and because of that I have to \"fill\" that environment value (normally the API key), so in my case this error was not enough to make me notice that. \n\nAnyway, I only think that this error is a bit confusing, but the fix for it is simple enough.","author_login":"NathanAP","author_association":"NONE","created_at":"2025-03-25T18:41:17+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2756493421","fragment_type":"issue_comment","sequence":4,"text":"What is the root cause and proper solution for it?\nBecause sometimes i get this error and sometimes not. It is intermittent but when it starts appearing it stays the whole day.","author_login":"amitt0488","author_association":"NONE","created_at":"2025-03-27T03:22:42+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2758910601","fragment_type":"issue_comment","sequence":5,"text":"In my case it seems that the API_KEY environment variable must be setted. I had to create a big workaround to make it work automatically (because I had dynamic indexes). You could also check the variables in settings as well.\n\nI'm just trying to help, but I'm not sure it is specifically this. To be honest, GraphRAG is totally broken for me. I have some bugs that only occurs while in a Docker container and others that depends on them to update packages, so there is almost no reason to go back and fix it to make it work because there are too many problems, but I wish luck for you.","author_login":"NathanAP","author_association":"NONE","created_at":"2025-03-27T17:34:06+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2812930445","fragment_type":"issue_comment","sequence":6,"text":"I get the error even with GPT-4o. I think the issue is not because of model provider but because the text itself does not contain any entities so it fails","author_login":"basitanees","author_association":"NONE","created_at":"2025-04-17T13:30:02+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2813484527","fragment_type":"issue_comment","sequence":7,"text":"I updated the prompts to include \"Extract at least two entities and one relationship\". It is more stable now.","author_login":"basitanees","author_association":"NONE","created_at":"2025-04-17T16:25:32+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3223306570","fragment_type":"issue_comment","sequence":8,"text":"This error depends on model and prompts. I received successful results with mistral and qwen2.5 (ollama) and did not tune the prompts. Tuned prompts (Auto-tune) caused KeyError despite the use of models mentioned above. I think those who encountered same error with non-openAI model should try to run the graphrag code based on another model with original prompts (not tuned).","author_login":"OphthalmicBigData","author_association":"NONE","created_at":"2025-08-26T09:12:00+08:00","repo_name":"microsoft/graphrag","issue_id":2918730964,"issue_number":1805,"issue_url":"https://github.com/microsoft/graphrag/issues/1805","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2423692022","fragment_type":"issue_description","sequence":0,"text":"Support model providers other than OpenAI and Azure\nRight now GraphRAG only natively supports models hosted by OpenAI and Azure. Many users would like to run additional models, including alternate APIs, SLMs, or models running locally. As a research team with limited bandwidth it is unlikely we will add native support for more model providers in the near future. Our focus is on memory structures and algorithms to improve LLM information retrieval, and we've got a lot of experiments in the queue!\n\nThere are alternative options to achieve extensibility, and many GraphRAG users have had luck extending the library. So far we've seen this most commonly with Ollama, which runs on localhost and supports a very wide variety of models. This approach depends on Ollama supporting the standard OpenAI API for chat completion and embeddings so it can proxy our API calls, and it looks like this is working for a lot of folks (though may require some hacking).\n\n*Please note*: while we are excited to see GraphRAG used with more models, our team will not have time to help diagnose issues. We'll do our best to route bug reports to existing conversations that might be helpful. For the most part you should expect that if you file a bug related to running an alternate solution, we'll link to this issue, a relevant conversation if we're aware of one, and then we'll close the bug.\n\nHere is a general discussion regarding OSS LLMs: URL \n\nAnd a couple of popular Ollama-related issues: #339 and #345. We'll link to others in the comments when relevant.\n\nHave a look at issues tagged with the community_support label as well.","author_login":"natoverse","author_association":"COLLABORATOR","created_at":"2024-07-22T20:13:50+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2258858455","fragment_type":"issue_comment","sequence":1,"text":"Here is a user-submitted solution for fixing the community rating value. We normally expect a float, but some models will send an int. URL","author_login":"natoverse","author_association":"CONTRIBUTOR","created_at":"2024-07-30T17:29:53+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2260310946","fragment_type":"issue_comment","sequence":2,"text":"If GraphRAG start's using Microsoft's own agent library AutoGen, supporting different model providers would not need to be re-implemented here.\n\nLLM Configurations docs for AutoGen","author_login":"nileshtrivedi","author_association":"NONE","created_at":"2024-07-31T11:35:12+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2293885394","fragment_type":"issue_comment","sequence":3,"text":"@Mxk-1 has found chunking settings that help resolve issues with create_base_entity_graph with Ollama:","author_login":"natoverse","author_association":"COLLABORATOR","created_at":"2024-08-16T17:26:23+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2345852458","fragment_type":"issue_comment","sequence":4,"text":"I collected several comments scattered across different issues and created a monkey patch script along with a working setting for Ollama. It has been tested on version 0.3.2 and works properly. I’m sharing it for those who might need it: URL \n\nI’m not sure if it’s appropriate to comment here, so if the reviewers think it’s not, I'll delete this comment and post it in a more suitable place. Thank you in advance!","author_login":"MortalHappiness","author_association":"NONE","created_at":"2024-09-12T10:18:57+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2539609372","fragment_type":"issue_comment","sequence":5,"text":"I wanted to test out Gemini's performance on GraphRAG. Since Gemini supports OpenAI's API structure I thought would just have to add the base_url and api key to get it work with GraphRAG. But i keep getting errors. Has anyone else tested GraphRAG with Gemini sucessfully ?","author_login":"shamalgithub","author_association":"NONE","created_at":"2024-12-12T17:45:48+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2565819242","fragment_type":"issue_comment","sequence":6,"text":"Please consider just using allowing openai compatible endpoint (vllm/llama-server) for llm and embedding model. I can get it to work for the normal llm, but not to make embeddings (nomic-embed-text) via llama-server. Please don't shoehorn this into only ollama, yet creating another niche constriction for usability.\n\n@MortalHappiness does your monkey-patch work with other openai locally hosted endpoints that are not ollama?","author_login":"satyaloka93","author_association":"NONE","created_at":"2024-12-30T18:59:49+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2567079471","fragment_type":"issue_comment","sequence":7,"text":"Hi @natoverse @MortalHappiness @satyaloka93 made a PR to add litellm - support for Ollama, Vertex AI, Gemini, Anthropic, Bedrock (100+LLMs) \n\n URL \n\nadds support for the above mentioned LLMs using LiteLLM URL \nLiteLLM is a lightweight package to simplify LLM API calls - use any llm as a drop in replacement for gpt-4o.\n\nExample\n\npython\nfrom litellm import completion\nimport os\n\n## set ENV variables\nos.environ[\"OPENAI_API_KEY\"] = \"your-openai-key\"\nos.environ[\"ANTHROPIC_API_KEY\"] = \"your-cohere-key\"\n\nmessages = [{ \"content\": \"Hello, how are you?\",\"role\": \"user\"}]\n\n# openai call\nresponse = completion(model=\"openai/gpt-4o\", messages=messages)\n\n# anthropic call\nresponse = completion(model=\"anthropic/claude-3-sonnet-20240229\", messages=messages)\nprint(response)\n\n### Response (OpenAI Format)\n\njson\n{\n \"id\": \"chatcmpl-565d891b-a42e-4c39-8d14-82a1f5208885\",\n \"created\": 1734366691,\n \"model\": \"claude-3-sonnet-20240229\",\n \"object\": \"chat.completion\",\n \"system_fingerprint\": null,\n \"choices\": [\n {\n \"finish_reason\": \"stop\",\n \"index\": 0,\n \"message\": {\n \"content\": \"Hello! As an AI language model, I don't have feelings, but I'm operating properly and ready to assist you with any questions or tasks you may have. How can I help you today?\",\n \"role\": \"assistant\",\n \"tool_calls\": null,\n \"function_call\": null\n }\n }\n ],\n \"usage\": {\n \"completion_tokens\": 43,\n \"prompt_tokens\": 13,\n \"total_tokens\": 56,\n \"completion_tokens_details\": null,\n \"prompt_tokens_details\": {\n \"audio_tokens\": null,\n \"cached_tokens\": 0\n },\n \"cache_creation_input_tokens\": 0,\n \"cache_read_input_tokens\": 0\n }\n}","author_login":"ishaan-jaff","author_association":"NONE","created_at":"2025-01-01T17:02:06+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2837140559","fragment_type":"issue_comment","sequence":8,"text":"Note that as of GraphRAG 2.0 we allow injection of custom model providers. There are some details on how to do this in the new models docs page.","author_login":"natoverse","author_association":"COLLABORATOR","created_at":"2025-04-29T00:50:17+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3299530132","fragment_type":"issue_comment","sequence":9,"text":"I just used `gpt-5-mini` with embeddings `text-embedding-3-small` and got nothing in return, i.e. `KeyError: \"Column(s) ['description', 'source_id', 'weight'] do not exist\"`. The output is empty; `stats.json` contains only 0s and `context.json` is `{}`.\n\nI wouldn't necessarily opt to support all models from all providers, as they can work differently with different prompts. However, I'd urge to have some integration test for models from the same provider.\n\nAlternatively, a list of provider/model which has been verified on different document corpora.","author_login":"laszukdawid","author_association":"NONE","created_at":"2025-09-16T16:33:06+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3324919712","fragment_type":"issue_comment","sequence":10,"text":"2.6.0 is available now. Not only does it resolve the format issues from OpenAI, it also introduces the option to use LiteLLM to configure any model provider that they support.","author_login":"natoverse","author_association":"COLLABORATOR","created_at":"2025-09-23T17:25:32+08:00","repo_name":"microsoft/graphrag","issue_id":2423692022,"issue_number":657,"issue_url":"https://github.com/microsoft/graphrag/issues/657","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0460","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"storybook for React Native can't excute resolve of promise?","query_context":"If you are reporting a bug or requesting support, start here:\n### Bug or support request summary\nWhen your start a story about react native component, you write a promise in the component and the promise's then does't work.\n\n### Please specify which version of Storybook and optionally any affected addons that you're running\n\n- @storybook/react-native 5.3.18\n- @storybook/addons 5.3.18\n\n### Screenshots / Screencast / Code Snippets (Optional)\ncode of story is as as below\n\njs\nimport React from \"react\";\nimport { storiesOf } from \"@storybook/react-native\";\nimport Article from \"./Article\";\n\nstoriesOf(\"Article\", module)\n .add(\"mock data\", () => (\n \n )\n\ncode of component is as as below\n\njs\nimport React, { Component } from \"react\";\nimport { View, Text } from \"react-native\";\nexport default class Article extends Component {\n public constructor(props) {\n super(props);\n this.state= {\n content: ''\n };\n }\n componentDidMount() {\n const getContent = new Promise((resolve) => {\n setTimeout(() => {\n resolve('Hello World')\n },3000)\n })\n getContent.then(res => {\n this.setState({content: res})\n }).catch(e => {\n console.log(e)\n });\n }\n\n render() {\n const { content } = this.state;\n return (\n \n {content} \n \n );\n }\n}\n\nThe function of setTimeout has been called,but getContent.then didn't work.I test same scene in \nstorybook for React, the then of promise works.Did storybook for React Native do something for promise so that it can't work?","known_context_document_ids":["gh_issue_632423082"],"reference_answer":"@pke patching the addons dependency to remove the corejs promise polyfill works as a workaround as far as I know. \n\nAlso there was a new version yesterday to fix some issues in the latest version of react native, not sure if its related to any issues you're having.","answer_document_id":"gh_comment_1296245501","silver_evidence_path":["gh_comment_1050820331","gh_issue_558649376","gh_comment_1296245501"],"evidence_issue_ids":[632423082,558649376],"source_repo_name":"storybookjs/react-native","source_issue_id":632423082,"source_issue_number":57,"source_issue_url":"https://github.com/storybookjs/react-native/issues/57","target_repo_name":"storybookjs/react-native","target_issue_id":558649376,"target_issue_number":20,"target_issue_url":"https://github.com/storybookjs/react-native/issues/20","reference_anchor_document_id":"gh_comment_1050820331","reference_answer_author":"dannyhw","reference_answer_author_association":"MEMBER","quality_score":93.58,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0698,"anchor_target_overlap":0.1628,"target_answer_overlap":0.16},"issue_created_at":"2020-06-03T10:19:21+08:00","valid_comment_count":38,"fragments":[{"document_id":"gh_issue_632423082","fragment_type":"issue_description","sequence":0,"text":"storybook for React Native can't excute resolve of promise\nIf you are reporting a bug or requesting support, start here:\n### Bug or support request summary\nWhen your start a story about react native component, you write a promise in the component and the promise's then does't work.\n\n### Please specify which version of Storybook and optionally any affected addons that you're running\n\n- @storybook/react-native 5.3.18\n- @storybook/addons 5.3.18\n\n### Screenshots / Screencast / Code Snippets (Optional)\ncode of story is as as below\n\njs\nimport React from \"react\";\nimport { storiesOf } from \"@storybook/react-native\";\nimport Article from \"./Article\";\n\nstoriesOf(\"Article\", module)\n .add(\"mock data\", () => (\n \n )\n\ncode of component is as as below\n\njs\nimport React, { Component } from \"react\";\nimport { View, Text } from \"react-native\";\nexport default class Article extends Component {\n public constructor(props) {\n super(props);\n this.state= {\n content: ''\n };\n }\n componentDidMount() {\n const getContent = new Promise((resolve) => {\n setTimeout(() => {\n resolve('Hello World')\n },3000)\n })\n getContent.then(res => {\n this.setState({content: res})\n }).catch(e => {\n console.log(e)\n });\n }\n\n render() {\n const { content } = this.state;\n return (\n \n {content} \n \n );\n }\n}\n\nThe function of setTimeout has been called,but getContent.then didn't work.I test same scene in \nstorybook for React, the then of promise works.Did storybook for React Native do something for promise so that it can't work?","author_login":"chundeluoyetian","author_association":"NONE","created_at":"2020-06-03T10:19:21+08:00","repo_name":"storybookjs/react-native","issue_id":632423082,"issue_number":57,"issue_url":"https://github.com/storybookjs/react-native/issues/57","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1050738215","fragment_type":"issue_comment","sequence":1,"text":"For those struggling with resolverMainFields – the array needs 'react-native' included, too: \n\n`['sbmodern', 'react-native', 'main']` \nand for expo `['sbmodern', 'react-native', ...defaultConfig.resolver.resolverMainFields]`\n\nSee: URL","author_login":"Peeeep","author_association":"NONE","created_at":"2022-02-25T10:38:23+08:00","repo_name":"storybookjs/react-native","issue_id":632423082,"issue_number":57,"issue_url":"https://github.com/storybookjs/react-native/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1050820331","fragment_type":"issue_comment","sequence":2,"text":"@Peeeep yes that does seem to be the case for some packages now.\n\nHowever since this is now resolved in 6.0 beta and also is mostly a duplicate of #20 I think it makes sense to close this issue.\n\nAlso for 5.3 you can patch storybook/addons to remove the es promise polyfill that fixes this.\n\ndiff --git a/node_modules/@storybook/addons/dist/index.js b/node_modules/@storybook/addons/dist/index.js\nindex 589d611..81bc9e7 100644\n--- a/node_modules/@storybook/addons/dist/index.js\n+++ b/node_modules/@storybook/addons/dist/index.js\n@@ -8,8 +8,6 @@ require(\"core-js/modules/es.object.to-string\");\n \n require(\"core-js/modules/es.object.values\");\n \n-require(\"core-js/modules/es.promise\");\n-\n require(\"core-js/modules/web.dom-collections.for-each\");\n \n Object.defineProperty(exports, \"__esModule\", {","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2022-02-25T12:41:14+08:00","repo_name":"storybookjs/react-native","issue_id":632423082,"issue_number":57,"issue_url":"https://github.com/storybookjs/react-native/issues/57","linked_issue_ids":[558649376],"is_known_query_context":false},{"document_id":"gh_comment_1373091964","fragment_type":"issue_comment","sequence":3,"text":"Hi @dannyhw. I've tried this patch\n\nbash\n \ndiff --git a/node_modules/@storybook/addons/dist/index.js b/node_modules/@storybook/addons/dist/index.js\nindex 589d611..8ae3a82 100644\n--- a/node_modules/@storybook/addons/dist/index.js\n+++ b/node_modules/@storybook/addons/dist/index.js\n@@ -8,8 +8,6 @@ require(\"core-js/modules/es.object.to-string\");\n\n require(\"core-js/modules/es.object.values\");\n\n-require(\"core-js/modules/es.promise\");\n-\n require(\"core-js/modules/web.dom-collections.for-each\");\n\n Object.defineProperty(exports, \"__esModule\", {\n\nbut I still end up with errors:\n\n ERROR [TypeError: new Promise(function (resolve) {\n remoteResolve = resolve;\n }).finally is not a function. (In 'new Promise(function (resolve) {\n remoteResolve = resolve;\n }).finally(function () {\n clearTimeout(autoResolveTimeout);\n })', 'new Promise(function (resolve) {\n remoteResolve = resolve;\n }).finally' is undefined)]\n\nI've tried restarting the Metro server without any caching to no avail. Do you have any suggestions?","author_login":"deiden26","author_association":"NONE","created_at":"2023-01-06T03:17:54+08:00","repo_name":"storybookjs/react-native","issue_id":632423082,"issue_number":57,"issue_url":"https://github.com/storybookjs/react-native/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373544014","fragment_type":"issue_comment","sequence":4,"text":"@deiden26 try searching your node_modules for this `require(\"core-js/modules/es.promise\");` and remove it in every instance.","author_login":"dannyhw","author_association":"MEMBER","created_at":"2023-01-06T12:02:24+08:00","repo_name":"storybookjs/react-native","issue_id":632423082,"issue_number":57,"issue_url":"https://github.com/storybookjs/react-native/issues/57","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_558649376","fragment_type":"issue_description","sequence":0,"text":"Promise.finally is being overwritten in React Native\n**Describe the bug**\nThe inclusion of Storybook inside a React Native app seems to remove the implementation of `Promise.prototype.finally`. Causing the `Promise.resolve(...).finally is not a function error` to occur.\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Create a fresh React Native project.\n2. Setup Storybook as reference here, URL `npx -p @storybook/cli sb init --type react_native` (no server)\n3. Add the code snippet reference below and you’ll see initially you can call `toString` on `Promise.prototype.finally` but after importing Storybook (you have to use `require` in this instance, not `import`, so the ordering works for the test to see that `finally` starts off being an actual function) it’s no undefined.\n\nExample repo here, URL \n\n**Expected behavior**\n`Promise.prototype.finally` to no be removed.\n\n**Screenshots**\nN/A\n\n**Code snippets**\n`finally` is valid here, but after the inclusion of Storybook, it’s `undefined`.\n\njs\nconsole.log('Before:', Promise.prototype.finally.toString());\n\nconst StoryBook = require('./storybook');\n\nconsole.log('After:', Promise.prototype.finally);\n\n**System:**\n\nEnvironment Info:\n\n System:\n OS: macOS Mojave 10.14.6\n CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz\n Binaries:\n Node: 10.16.0 - /var/folders/94/btf_scw12xbdnqv5dtv2t2hr0000gn/T/fnm-shell-8148567/bin/node\n Yarn: 1.17.3 - /usr/local/bin/yarn\n npm: 6.9.0 - /var/folders/94/btf_scw12xbdnqv5dtv2t2hr0000gn/T/fnm-shell-8148567/bin/npm\n Browsers:\n Chrome: 77.0.3865.90\n Firefox: 69.0.1\n Safari: 13.0.2\n npmPackages:\n @storybook/react-native: ^5.3.0-alpha.17 => 5.3.0-alpha.17\n\n**Additional context**\nIn my instance `redux-persist` use this in their `onBeforeLift` callback.","author_login":"benjaminreid","author_association":"NONE","created_at":"2019-10-10T11:10:46+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_661328357","fragment_type":"issue_comment","sequence":1,"text":"A good set it and forget it workaround for this issue is a combination of the solutions presented by @tjbenton and @limaAniceto above with patch-package:\n\n1. Open the entry file\n\nsh\nvi node_modules/@storybook/react-native/dist/index.js \n\n2. Append the fixes to the start and end of the file\n\njs\nconst fnFix = Promise.prototype.finally;/*original code*/Promise.prototype.finally = fn\n\n3. Save and commit the patch to your repository\n\nsh\nyarn patch-package @storybook/react-native && git add patches\n\nThis will ensure you do not include in your project patches to modules, that the package is always patched for every developer in your team and can even be included in CI/CD pipelines and containers.\n\nThe diff is contained in a `patches` directory and when the faulty module gets fixed, you can just remove it.","author_login":"joaocarmo","author_association":"NONE","created_at":"2020-07-20T20:55:31+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_677833870","fragment_type":"issue_comment","sequence":2,"text":"This issue just cost me a night and a morning trying to hunt down what was going on, so to find out it's a storybook issue _and it's been known about_ really has steam coming out of my ears.","author_login":"colinta","author_association":"NONE","created_at":"2020-08-20T18:43:22+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_677858970","fragment_type":"issue_comment","sequence":3,"text":"@colinta You’ve just reminded me this issue exists, I was hoping with version 6 this may have been closed. Shame if it’s still hanging around.","author_login":"benjaminreid","author_association":"NONE","created_at":"2020-08-20T19:33:17+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_679386721","fragment_type":"issue_comment","sequence":4,"text":"looking into a fix for this, seems like just changing the babel config could resolve this.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2020-08-24T21:55:51+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_679909253","fragment_type":"issue_comment","sequence":5,"text":"This is from corejs and it seems like the problem starts with storybook core because even if I remove all the old polyfills from the @storybook/react-native config then it still happens.\n\nThe babel preset env polyfill will cause this when ever 'core-js/modules/es.promise' gets imported, see the following issues:\n\n URL \n URL","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2020-08-25T09:18:15+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_737816651","fragment_type":"issue_comment","sequence":6,"text":"@apedroferreira unfortunately not since the issue is upstream I wasn't able to make progress on this. I'm hoping that maybe upgrading dependencies to 6.0+ will help. I'll test it in the 6.0 upgrade branch. \n\nFrom what I understand there would need to be a version of storybook client that isn't polyfilled or at least with a different browser target. So I think a workaround is the best chance we have for now, however I will raise the issue on the storybook repo to see if we can look into it.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2020-12-03T10:02:15+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_746523831","fragment_type":"issue_comment","sequence":7,"text":"@dannyhw Today, after doing an upgrade of the Expo SDK (40), the same error appeared.\n\nAfter some investigations, more or less dumb tries of making my app working, I discovered something quite interesting.\n\nIf I add `import 'core-js/features/promise/finally'` to `@storybook/react-native/dist/index.js` it still shows an error.\nBut if I remove the import and add it again after my app is fully loaded, and then save the file, the Fast Refresh feature of react-native handles the import and then everything works until the next JS bundle reload.\n\nI honestly don't know what to do with this info but maybe someone will.\n\nBtw, the above workaround did work for a while, but only for a while. I'm now quite stuck with this error and don't have any clue on how to get my app working. Any fix or workaround would be HUGELY appreciated.","author_login":"ajacquierbret","author_association":"NONE","created_at":"2020-12-16T15:55:18+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_746659699","fragment_type":"issue_comment","sequence":8,"text":"Ok I managed to get my app working ! \n\nAdding an import of `core-js/features/promise` AFTER importing Storybook is the fix. Above workarounds and patches don't work because `Promise.prototype.finally` keeps being overwritten even after the execution of `@storybook/react-native/dist/index.js`, maybe because of some Storybook plugins.\n\nIn my case, I had to import `core-js/features/promise` a bit deep in my app hierarchy, but this effectively resolves the issue.\n\nAnyway, some consideration about this issue from the Storybook team would be highly appreciated, since any RN developer working with promise based libs (e.g. @apollo/client 3.x) will be facing the same issue...","author_login":"ajacquierbret","author_association":"NONE","created_at":"2020-12-16T17:14:14+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_746823114","fragment_type":"issue_comment","sequence":9,"text":"@ajacquierbret hey thanks for posting your workaround hopefully that will save some people a lot of frustration. \n\nI've tried different things in the past to resolve this and the proper fix always seems to require changes upstream. It's hard to coordinate these changes since it's only rn with this problem. I think in the web versions it's fixed via webpack wizardry.\n\nI was kind of hoping that 6.0 might fix this but I'm not sure yet. I'll try it out in the upgrade branch soon.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2020-12-16T18:53:45+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_827158892","fragment_type":"issue_comment","sequence":10,"text":"Posting in case I can help save someone a few hours of their time, it looks like this polyfill behaviour of Storybook breaks `promise.resolve` in Native Module contexts too.\n\nExample in a native Android module\n\nkotlin\n@ReactMethod\nfun multiply(a: Int, b: Int, promise: Promise) {\n promise.resolve(a * b)\n}\n\nImporting any part of Storybook in a project breaks the above example (the promise is never resolved on the RN/JS side), e.g.\n\njavascript\nimport {getStorybookUI} from '@storybook/react-native';\ngetStorybookUI({});\n\n// The following will now never resolve (but did work prior to the inclusion of Storybook)\nAwesomeModule.multiply(3,7).then(...); // or\n(async () => { const res = await AwesomeModule.multiply(3,7); ... })();\n\nMVP repo with screenshots, basic example bootstrapped using `react-native init` & `create-react-native-library`\n\nHave tried the potential fixes mentioned in this thread, but currently I've been unsuccessful in figuring a way around the issue.","author_login":"4lun","author_association":"NONE","created_at":"2021-04-26T21:30:02+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_827209826","fragment_type":"issue_comment","sequence":11,"text":"@4lun thanks for providing information and examples.\n\nI will try out your example and see what comes up. In my projects I don't have issues with promises so I'm sure there is a way around this.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2021-04-26T23:43:26+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_827909640","fragment_type":"issue_comment","sequence":12,"text":"@4lun I've experimented a bit and the promise not returning only happens if you run the `getStorybookUI({})` function call.\nI'm still investigating so I can't offer a proper solution and instead just some insight.\n\nIn some cases you can get around this by not calling this function in the top of your app.tsx and instead have a function that will set up the UI when you need it.\nlike `const getSBUI = () => getStorybookUI({asyncStorage: null});` \nthen you can do something like\n\n \n if (showSB) {\n const SBUI = getSBUI();\n return ;\n }\n\nIt's kind of a workaround for the case where you want to have storybook optionally render without it breaking other things in the app. \n\nI realise it's not exactly the solution to your problem however it does make it possible to include storybook along side other react native code without breaking things when storybook isn't rendered.\n\nAlso it does confirm it's not the @react-native/storybook import. I'm still going to investigate further and see if I can find which line in the getStorybookUI function is causing this.\n\nMy theory on this is still that the polyfill issue comes from the storybook client api (found in the web storybook repo) which uses polyfills etc. I'm fairly confident in this because I've tried removing all polyfills from react-native storybook and it made no difference.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2021-04-27T20:31:23+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_827928986","fragment_type":"issue_comment","sequence":13,"text":"@4lun So I actually ended up finding what I think is the cause of the problem.\n\nIf you open up\nnode_modules/@storybook/addons/dist/index.js\n\nand comment out line 11 `//require(\"core-js/modules/es.promise\");` like this then it starts working.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2021-04-27T21:03:34+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_828767384","fragment_type":"issue_comment","sequence":14,"text":"Thanks @dannyhw, I've ended up doing something similar to your suggestion, wrapping up all references to Storybook and conditionally loading it via an env flag.\n\nThe native module I'm working on shouldn't ever be utilised a storybook context so this works quite well for the time being.","author_login":"4lun","author_association":"NONE","created_at":"2021-04-28T20:46:16+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_842233320","fragment_type":"issue_comment","sequence":15,"text":"A PR was created on the main storybook repository with a fix for future version of storybook. This means that this issue will be resolved in 6.0 of react native storybook. The PR enables provides a modern version of the distributed files, in your project you would add the following config `resolverMainFields:['sbmodern', 'main']` and the storybook dependencies used would be without polyfils.","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2021-05-17T11:06:20+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_861033581","fragment_type":"issue_comment","sequence":16,"text":"Since as yet there is no `@storybook/react-native@6`, I've found a more elegant workaround.\n\nThe below example lazy-loads Storybook. Convenient both to avoid polyfill downgrades as well as tree-shaking the code out of production builds.\n\ntypescript\nimport React, { ReactNode, useEffect, useState } from 'react'\n\nexport function StorybookScreen() {\n const [storybookUI, setStorybookUI] = useState (null)\n\n useEffect(() => {\n if (!__DEV__) return\n // eslint-disable-next-line @typescript-eslint/no-var-requires\n const { StorybookUI } = require('../../storybook')\n setStorybookUI( )\n }, [setStorybookUI])\n\n return <>{storybookUI} \n}","author_login":"defrex","author_association":"NONE","created_at":"2021-06-14T22:23:35+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_882093581","fragment_type":"issue_comment","sequence":17,"text":"Now that all the issues in the first milestone have been completed I have released the first alpha.\n\nI've also created an initial guide on how you can get setup with a fresh project. Migration guide to come in the future.\n\nFind the guide here:\n URL","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2021-07-18T17:44:46+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_897047215","fragment_type":"issue_comment","sequence":18,"text":"Following the approach of @defrex i've used the lazy approach with lazy and suspense:\n\nStorybookScreen.tsx\n\njavascript\nconst StorybookUI = lazy(() => import('../../storybook'));\n\nconst StorybookScreen: React.FC = () => {\n return (\n loading }>\n \n \n );\n};\n\nApp.tsx\n\njavascript\nconst App: React.FC = () => (\n { __DEV__? : }\n);","author_login":"mmoio","author_association":"NONE","created_at":"2021-08-11T18:18:48+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_897072132","fragment_type":"issue_comment","sequence":19,"text":"Following the approach of @defrex comment i've used the lazy approach with react lazy and suspense:\n\nStorybookScreen.tsx\n\njavascript\nconst StorybookUI = lazy(() => import('../../storybook'));\n\nconst StorybookScreen: React.FC = () => {\n return (\n loading }>\n \n \n );\n};\n\nApp.tsx\n\njavascript\nconst App: React.FC = () => (\n { __DEV__? : }\n);","author_login":"mmoio","author_association":"NONE","created_at":"2021-08-11T18:57:21+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[558649376],"is_known_query_context":false},{"document_id":"gh_comment_1046101914","fragment_type":"issue_comment","sequence":20,"text":"In this PR I demonstrate how you can use patch package to fix this error.\n\nBasically just this patch for @storybook/addons\n\ndiff --git a/node_modules/@storybook/addons/dist/index.js b/node_modules/@storybook/addons/dist/index.js\nindex 589d611..81bc9e7 100644\n--- a/node_modules/@storybook/addons/dist/index.js\n+++ b/node_modules/@storybook/addons/dist/index.js\n@@ -8,8 +8,6 @@ require(\"core-js/modules/es.object.to-string\");\n \n require(\"core-js/modules/es.object.values\");\n \n-require(\"core-js/modules/es.promise\");\n-\n require(\"core-js/modules/web.dom-collections.for-each\");\n \n Object.defineProperty(exports, \"__esModule\", {","author_login":"dannyhw","author_association":"CONTRIBUTOR","created_at":"2022-02-19T21:02:22+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1296245501","fragment_type":"issue_comment","sequence":21,"text":"@pke patching the addons dependency to remove the corejs promise polyfill works as a workaround as far as I know. \n\nAlso there was a new version yesterday to fix some issues in the latest version of react native, not sure if its related to any issues you're having.","author_login":"dannyhw","author_association":"MEMBER","created_at":"2022-10-30T12:28:16+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1296320177","fragment_type":"issue_comment","sequence":22,"text":"Removing the polyfill didn't work in my setup. I tried for hours. It worked in hot reload sometimes but not deterministic. Cold boot the app never worked. The timeout works. It's clearly a race condition and my setup might be slower or faster than the rest of the ones who tries the workarounds. \n\nI am on a fairly old RN version 66.3 and I still don't understand how the polyfill can even be active when RN provides a complete es6 promise including finally. I'd like to understand how the polyfill works. \n\nIn the corejs I found related bug and they clearly stated the way storybook authors use the polyfills is wrong. They shouldn't be imported from the modules folder.","author_login":"pke","author_association":"NONE","created_at":"2022-10-30T18:22:10+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1296361921","fragment_type":"issue_comment","sequence":23,"text":"@pke in the v6 beta we get around this problem by resolving to the modern build of storybook (bundled as sbmodern)","author_login":"dannyhw","author_association":"MEMBER","created_at":"2022-10-30T22:10:35+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1296383944","fragment_type":"issue_comment","sequence":24,"text":"now just checking back with my app its not working again... haha seems to be clock related or something weird.\nAnyway... I am going to give v6 a try. However I really would like to use the webserver as a co-pilot, which is not yet ready in v6 iiuc?","author_login":"pke","author_association":"NONE","created_at":"2022-10-31T00:00:37+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1296860209","fragment_type":"issue_comment","sequence":25,"text":"The server is not ready and probably won't be for some time. I don't really know how to make it work for v6 and if I were to recreate it I'd probably opt for implementing something a bit different.\n\nAs always if someone is willing to figure it out then I'll happily take a PR but I've tried a few times and it seems to not be compatible without making a lot of changes.","author_login":"dannyhw","author_association":"MEMBER","created_at":"2022-10-31T10:02:56+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1296906342","fragment_type":"issue_comment","sequence":26,"text":"I tried again removing the import and now it corejs runs into a stack overflow cause no promise seems to be defined and it uses some alternative setTimeout path or so.\nThat is on RN 66.3","author_login":"pke","author_association":"NONE","created_at":"2022-10-31T10:43:52+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1297796948","fragment_type":"issue_comment","sequence":27,"text":"@pke if you have a reproduction I can try to debug it for you.","author_login":"dannyhw","author_association":"MEMBER","created_at":"2022-10-31T23:06:58+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1300284711","fragment_type":"issue_comment","sequence":28,"text":"Thanks @dannyhw, I can't produce a version where its easily reproducable, thats the problem. It seems to be totally random.\nWhat I want to understand is: how does the polyfill thinks it needs to engage? RN has a complete Promise implementation and it should be loaded with RN at boot and therefore available when core-js runs. \nOr has it something to do with RN itself depending on core-js internally, but just a different version than storybook addons?","author_login":"pke","author_association":"NONE","created_at":"2022-11-02T12:25:22+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1328964368","fragment_type":"issue_comment","sequence":29,"text":"Hey, I tried upgrading to Storybook 6 and I still experience this problem with Apollo-client. Removing storybook fixes the issue. Any idea what to do?\n\n \"@storybook/addon-actions\": \"6.5.13\",\n \"@storybook/react-native\": \"6.0.1-beta.10\",\n \"react-native\": \"0.70.3\",\n \"@apollo/client\": \"3.7.1\",","author_login":"Waltari10","author_association":"NONE","created_at":"2022-11-28T12:06:17+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1329003745","fragment_type":"issue_comment","sequence":30,"text":"@Waltari10 make sure you add the metro config to resolve sbmodern.","author_login":"dannyhw","author_association":"MEMBER","created_at":"2022-11-28T12:37:04+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1345689860","fragment_type":"issue_comment","sequence":31,"text":"An alternative solution that should work for any version is to configure Metro so that it doesn't load the polyfill that Storybook packages load. \n\nInside `metro.config.js` add something like this:\n\njavascript\nconst { getDefaultConfig } = require('expo/metro-config');\n\nconst config = getDefaultConfig(__dirname);\n\nconfig.resolver.resolveRequest = (context, moduleName, platform) => {\n if (moduleName.startsWith('core-js/modules/es.promise')) {\n // Storybook patches Promise and removes finally, causing errors throughout the application\n // This configures it so that the offending package isn't loaded when requested\n return {\n type: 'empty',\n };\n } else {\n return context.resolveRequest(context, moduleName, platform);\n }\n};\n\nmodule.exports = config;","author_login":"MiguelAraCo","author_association":"NONE","created_at":"2022-12-11T23:33:40+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537798944","fragment_type":"issue_comment","sequence":32,"text":"Is there a more up-to-date solution to this? I'm trying to use `@rnx-kit/metro-resolver-symlinks`, but I must overwrite `resolveRequest`. It seems like this issue is affecting almost everyone using storybook in React Native, and it can be very difficult to find out that storybook is the source of it.","author_login":"tj-mc","author_association":"NONE","created_at":"2023-05-08T06:03:02+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537825685","fragment_type":"issue_comment","sequence":33,"text":"I have updated to the latest version, as I saw in a changelog that this issue was fixed, however it persists in my case\nI have set \n\n`config.resolver.resolverMainFields = ['sbmodern', 'react-native', 'browser', 'main'];`\n\nIn `metro.config.js`","author_login":"tj-mc","author_association":"NONE","created_at":"2023-05-08T06:29:24+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1539201449","fragment_type":"issue_comment","sequence":34,"text":"Turns out I needed to upgrade the other `@storybook` deps too. For anyone solving this issue, here is what I needed. \n\n \"@storybook/addon-actions\": \"^7.0.9\",\n \"@storybook/addon-knobs\": \"^7.0.2\",\n \"@storybook/addon-links\": \"^7.0.9\",\n \"@storybook/addon-ondevice-actions\": \"^6.5.3\",\n \"@storybook/addon-ondevice-knobs\": \"^6.5.3\",\n \"@storybook/react-native\": \"^6.5.3\",\n \"@storybook/react-native-server\": \"^6.5.3\",\n \n \"react-native\": \"0.69.8\",\n\nIn `metro.config.js`:\n\n`config.resolver.resolverMainFields = ['sbmodern', 'react-native', 'browser', 'main'];`\n\nThe last 3 values are the default for React Native.\n\nAnd for the record, this is an ejected Expo app. Now working fine without any errors. Thank you for your work on this! ❤️","author_login":"tj-mc","author_association":"NONE","created_at":"2023-05-08T23:51:12+08:00","repo_name":"storybookjs/react-native","issue_id":558649376,"issue_number":20,"issue_url":"https://github.com/storybookjs/react-native/issues/20","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0464","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"node-feature-discovery-workers sometimes fail and restart on the new joined nodes?","query_context":"**What happened**:\nHi! We noticed that node-feature-discovery-workers pods sometimes fail with the following error on the new nodes and even though we restart them, it takes couple of minutes to synchronize all the related labels. I'm not so sure how the whole node-feature-discovery works, so maybe you can help us to find the root cause of this.\n\ntext\nE0808 09:07:46.113306 1 main.go:83] \"error while running\" err=\"failed to advertise features (via CRD API): failed to update NodeFeature object \\\"gpu.worker12\\\": Operation cannot be fulfilled on nodefeatures.nfd.k8s-sigs.io \\\"gpu.worker12\\\": StorageError: invalid object, Code: 4, Key: /registry/nfd.k8s-sigs.io/nodefeatures/node-feature-discovery/gpu.worker12, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 5576298f-79f6-40af-9ff0-ffd5944bd794, UID in object meta: \"\n\n**What you expected to happen**:\nI expect node-feature-discovery would work as it is assigned to the new node.\n\n**How to reproduce it (as minimally and precisely as possible)**:\n-\n**Anything else we need to know?**:\nhelm chart version is `0.15.3`\n**Environment**:\n- Kubernetes version (use `kubectl version`): v1.29\n- Cloud provider or hardware configuration: onprem\n- OS (e.g: `cat /etc/os-release`): -\n- Kernel (e.g. `uname -a`): -\n- Install tools: -\n- Network plugin and version (if this is a network-related bug): -\n- Others: -","known_context_document_ids":["gh_issue_2455351183"],"reference_answer":"leaving in the milestone for visibility as we root cause whether this is a test-only issue or not","answer_document_id":"gh_comment_527539940","silver_evidence_path":["gh_comment_2276628454","gh_issue_487013930","gh_comment_527539940"],"evidence_issue_ids":[2455351183,487013930],"source_repo_name":"kubernetes-sigs/node-feature-discovery","source_issue_id":2455351183,"source_issue_number":1828,"source_issue_url":"https://github.com/kubernetes-sigs/node-feature-discovery/issues/1828","target_repo_name":"kubernetes/kubernetes","target_issue_id":487013930,"target_issue_number":82130,"target_issue_url":"https://github.com/kubernetes/kubernetes/issues/82130","reference_anchor_document_id":"gh_comment_2276628454","reference_answer_author":"liggitt","reference_answer_author_association":"MEMBER","quality_score":90.27,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0909,"anchor_target_overlap":0.1364,"target_answer_overlap":0.0},"issue_created_at":"2024-08-08T09:43:20+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_2455351183","fragment_type":"issue_description","sequence":0,"text":"node-feature-discovery-workers sometimes fail and restart on the new joined nodes\n**What happened**:\nHi! We noticed that node-feature-discovery-workers pods sometimes fail with the following error on the new nodes and even though we restart them, it takes couple of minutes to synchronize all the related labels. I'm not so sure how the whole node-feature-discovery works, so maybe you can help us to find the root cause of this.\n\ntext\nE0808 09:07:46.113306 1 main.go:83] \"error while running\" err=\"failed to advertise features (via CRD API): failed to update NodeFeature object \\\"gpu.worker12\\\": Operation cannot be fulfilled on nodefeatures.nfd.k8s-sigs.io \\\"gpu.worker12\\\": StorageError: invalid object, Code: 4, Key: /registry/nfd.k8s-sigs.io/nodefeatures/node-feature-discovery/gpu.worker12, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 5576298f-79f6-40af-9ff0-ffd5944bd794, UID in object meta: \"\n\n**What you expected to happen**:\nI expect node-feature-discovery would work as it is assigned to the new node.\n\n**How to reproduce it (as minimally and precisely as possible)**:\n-\n**Anything else we need to know?**:\nhelm chart version is `0.15.3`\n**Environment**:\n- Kubernetes version (use `kubectl version`): v1.29\n- Cloud provider or hardware configuration: onprem\n- OS (e.g: `cat /etc/os-release`): -\n- Kernel (e.g. `uname -a`): -\n- Install tools: -\n- Network plugin and version (if this is a network-related bug): -\n- Others: -","author_login":"ugur99","author_association":"NONE","created_at":"2024-08-08T09:43:20+08:00","repo_name":"kubernetes-sigs/node-feature-discovery","issue_id":2455351183,"issue_number":1828,"issue_url":"https://github.com/kubernetes-sigs/node-feature-discovery/issues/1828","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2276628454","fragment_type":"issue_comment","sequence":1,"text":"@ugur99 we've seen no reports on this before. On a quick search this looks like some (caching) issue in the kubernetes apiserver (ref e.g. URL You could try restarting the apiserver and see if the problems goes away(?)","author_login":"marquiz","author_association":"CONTRIBUTOR","created_at":"2024-08-08T20:49:23+08:00","repo_name":"kubernetes-sigs/node-feature-discovery","issue_id":2455351183,"issue_number":1828,"issue_url":"https://github.com/kubernetes-sigs/node-feature-discovery/issues/1828","linked_issue_ids":[487013930],"is_known_query_context":false},{"document_id":"gh_comment_2276661197","fragment_type":"issue_comment","sequence":2,"text":"yep you are right! Also found this; sorry for my quick reaction. I should have done more research before creating the issue. Thanks for the fast support.","author_login":"ugur99","author_association":"NONE","created_at":"2024-08-08T21:13:37+08:00","repo_name":"kubernetes-sigs/node-feature-discovery","issue_id":2455351183,"issue_number":1828,"issue_url":"https://github.com/kubernetes-sigs/node-feature-discovery/issues/1828","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_487013930","fragment_type":"issue_description","sequence":0,"text":"\"Precondition failed: UID in precondition\" flakes\n**Which jobs are failing**:\n\npull-kubernetes-integration\n\n**Which test(s) are failing**:\n\n URL \n\n`./vendor/k8s.io/apiextensions-apiserver/test/integration/subresources_test.go -run TestValidateOnlyStatus`\n\n`./vendor/k8s.io/apiextensions-apiserver/test/integration -run TestGeneration`\n\n`./vendor/k8s.io/apiextensions-apiserver/test/integration/subresources_test.go -run TestStatusSubresource`\n\nNot showing up in triage, oddly, but seen in individual failures:\n\n URL \n\n URL \n\n URL \n\n URL \n\n URL \n\n URL \n\n URL \n\nnot sure if this specific to custom resources, but that's where I'm seeing the flakes\n\n/sig api-machinery\n/priority important-soon\n/area custom-resources","author_login":"liggitt","author_association":"MEMBER","created_at":"2019-08-29T15:02:01+08:00","repo_name":"kubernetes/kubernetes","issue_id":487013930,"issue_number":82130,"issue_url":"https://github.com/kubernetes/kubernetes/issues/82130","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_527539940","fragment_type":"issue_comment","sequence":1,"text":"leaving in the milestone for visibility as we root cause whether this is a test-only issue or not","author_login":"liggitt","author_association":"MEMBER","created_at":"2019-09-03T16:40:26+08:00","repo_name":"kubernetes/kubernetes","issue_id":487013930,"issue_number":82130,"issue_url":"https://github.com/kubernetes/kubernetes/issues/82130","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_527633584","fragment_type":"issue_comment","sequence":2,"text":"I spent a while trying to recreate this and could not (again). I made one of the tests hotloop with QPS 100 doing get/update of the status subresource, then ran that in parallel with the other integration tests in the package. No failures found after running for ~10 minutes.\n\nUpdated description with testgrid link to locate recent flakes ( URL found a couple in the last week.","author_login":"liggitt","author_association":"MEMBER","created_at":"2019-09-03T20:48:33+08:00","repo_name":"kubernetes/kubernetes","issue_id":487013930,"issue_number":82130,"issue_url":"https://github.com/kubernetes/kubernetes/issues/82130","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_527665796","fragment_type":"issue_comment","sequence":3,"text":"iiuc, the error comes from apiserver comparing the requested obj UID against the watch cache. The requested obj is up-to-date since it was from etcd, but I didn't see mechanism that guarantees the watch cache to be up-to-date after a \"delete-create\" or \"delete-create-get\" sequence (the cacher implementation for Delete, Create and Get(rv=\"\") go through etcd directly). Is this failure an expected behavior, and should we just retry on precondition failure?","author_login":"roycaihw","author_association":"MEMBER","created_at":"2019-09-03T22:31:06+08:00","repo_name":"kubernetes/kubernetes","issue_id":487013930,"issue_number":82130,"issue_url":"https://github.com/kubernetes/kubernetes/issues/82130","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_527683188","fragment_type":"issue_comment","sequence":4,"text":"talked with @liggitt offline, we get it reproduced by adding some delay to the watch cache:\n\ndiff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/subresources_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/subresources_test.go\nindex bafcaa28404..deea5f01713 100644\n--- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/subresources_test.go\n+++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/subresources_test.go\n@@ -23,6 +23,7 @@ import (\n \"sort\"\n \"strings\"\n \"testing\"\n+ \"time\"\n \n autoscaling \"k8s.io/api/autoscaling/v1\"\n apierrors \"k8s.io/apimachinery/pkg/api/errors\"\n@@ -691,6 +692,7 @@ func TestGeneration(t *testing.T) {\n if updatedStatusInstance.GetGeneration() != 1 {\n t.Fatalf(\"updating status should not increment .metadata.generation: expected: %v, got: %v\", 1, updatedStatusInstance.GetGeneration())\n }\n+ time.Sleep(10 * time.Second)\n \n gottenNoxuInstance, err = noxuResourceClient.Get(\"foo\", metav1.GetOptions{})\n if err != nil {\ndiff --git a/staging/src/k8s.io/client-go/rest/config.go b/staging/src/k8s.io/client-go/rest/config.go\nindex fb81fb7b1cf..4e53ae87e2a 100644\n--- a/staging/src/k8s.io/client-go/rest/config.go\n+++ b/staging/src/k8s.io/client-go/rest/config.go\n@@ -41,8 +41,8 @@ import (\n )\n \n const (\n- DefaultQPS float32 = 5.0\n- DefaultBurst int = 10\n+ DefaultQPS float32 = 5000.0\n+ DefaultBurst int = 10000\n )\n \n var ErrNotInCluster = errors.New(\"unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined\")\ndiff --git a/staging/src/k8s.io/client-go/tools/cache/reflector.go b/staging/src/k8s.io/client-go/tools/cache/reflector.go\nindex 8abde7131a3..dd256fe7da9 100644\n--- a/staging/src/k8s.io/client-go/tools/cache/reflector.go\n+++ b/staging/src/k8s.io/client-go/tools/cache/reflector.go\n@@ -330,6 +330,7 @@ loop:\n case err := <-errc:\n return err\n case event, ok := <-w.ResultChan():\n+ time.Sleep(50 * time.Millisecond)\n if !ok {\n break loop\n }\n\nmake test-integration WHAT=./staging/src/k8s.io/apiextensions-apiserver/test/integration KUBE_TEST_ARGS=\"-run ^TestGeneration\" GOFLAGS=\"-v\"\n--- FAIL: TestGeneration (11.78s)\n testserver.go:141: runtime-config=map[api/all:true]\n testserver.go:142: Starting apiextensions-apiserver on port 46019...\n testserver.go:160: Waiting for /healthz to be ok...\n subresources_test.go:690: unable to update status: Operation cannot be fulfilled on noxus.mygroup.example.com \"foo\": StorageError: invalid object, Code: 4, Key: /ca6b7607-9396-4317-b5cb-8627b2b95e50/mygroup.example.com/noxus/not-the-default/foo, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: cd619d6f-f115-4ed4-b2fa-75cc8d4b742d, UID in object meta: 63839447-b154-4903-bd56-b51615002d0d\n\nas @liggitt suggested preconditions should retry on stale watch data instead of surfacing such error, this is not a test issue. I will send a fix","author_login":"roycaihw","author_association":"MEMBER","created_at":"2019-09-03T23:51:17+08:00","repo_name":"kubernetes/kubernetes","issue_id":487013930,"issue_number":82130,"issue_url":"https://github.com/kubernetes/kubernetes/issues/82130","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0465","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Maui -9.0.40 error : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139.","query_context":"### Description\n\nUpdated to the latest 9.0.40 maui \nRun our Azure pipeline and we get in iOS build\nerror : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139.\n\nwe do not have Microsoft.Maui.Controls.Compatibility anymore and not sure how to fix this.\n\n### Steps to Reproduce\n\nApologies, not sure how to reproduce as I cannot put my all azure pipeline\n\n### Link to public reproduction project repository\n\n_No response_\n\n### Version with bug\n\n9.0.30 SR3\n\n### Is this a regression from previous behavior?\n\nYes, this used to work in .NET MAUI\n\n### Last version that worked well\n\n9.0.30 SR3\n\n### Affected platforms\n\niOS\n\n### Affected platform versions\n\n_No response_\n\n### Did you find any workaround?\n\nno\nis this todo with SkiaSharp.Extended.UI.Maui , would using the preview version fix this. @mattleibow any suggestions please\n\n### Relevant log output\n\nshell\nerror : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139.\nerror : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139","known_context_document_ids":["gh_issue_2859582494"],"reference_answer":"This I agree with - I'm guessing that when we deprecated the assembly on non-Windows we didn't really do work to correctly annotate the APIs (that's actually quite a lot of work). We can open a bug on it, not sure if it will be fixed though.\n\nThe analyzer would have a hard time with this - mostly due to technical limitations. It's a Roslyn analyzer, which only sees your source code and metadata about references. If the code you're calling directly is not in the references, then C# compiler itself will fail - no need to analyze for that. And if you're calling code which has the problem, the analyzer doesn't see that code. Ultimately there are a set of problems which the analyzer can't see, missing references in dependencies is one such set.","answer_document_id":"gh_comment_2796347396","silver_evidence_path":["gh_comment_2669135101","gh_issue_2672738371","gh_comment_2796347396"],"evidence_issue_ids":[2859582494,2672738371],"source_repo_name":"dotnet/maui","source_issue_id":2859582494,"source_issue_number":27867,"source_issue_url":"https://github.com/dotnet/maui/issues/27867","target_repo_name":"dotnet/runtime","target_issue_id":2672738371,"target_issue_number":109966,"target_issue_url":"https://github.com/dotnet/runtime/issues/109966","reference_anchor_document_id":"gh_comment_2669135101","reference_answer_author":"vitek-karas","reference_answer_author_association":"MEMBER","quality_score":93.83,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2381,"anchor_target_overlap":0.4462,"target_answer_overlap":0.0566},"issue_created_at":"2025-02-18T07:32:04+08:00","valid_comment_count":84,"fragments":[{"document_id":"gh_issue_2859582494","fragment_type":"issue_description","sequence":0,"text":"Maui -9.0.40 error : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139.\n### Description\n\nUpdated to the latest 9.0.40 maui \nRun our Azure pipeline and we get in iOS build\nerror : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139.\n\nwe do not have Microsoft.Maui.Controls.Compatibility anymore and not sure how to fix this.\n\n### Steps to Reproduce\n\nApologies, not sure how to reproduce as I cannot put my all azure pipeline\n\n### Link to public reproduction project repository\n\n_No response_\n\n### Version with bug\n\n9.0.30 SR3\n\n### Is this a regression from previous behavior?\n\nYes, this used to work in .NET MAUI\n\n### Last version that worked well\n\n9.0.30 SR3\n\n### Affected platforms\n\niOS\n\n### Affected platform versions\n\n_No response_\n\n### Did you find any workaround?\n\nno\nis this todo with SkiaSharp.Extended.UI.Maui , would using the preview version fix this. @mattleibow any suggestions please\n\n### Relevant log output\n\nshell\nerror : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139.\nerror : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T07:32:04+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2664973075","fragment_type":"issue_comment","sequence":1,"text":"In my case, an update to VS 17.13 was to blame.\nAfter a rollback to 17.12.4, it worked again.\n\nThis behavior, that an iOS build via Windows->Mac suddenly no longer works from one day to the next, has been annoying me for a long time.\nThe team behind Xamarin.iOS is not doing a very good job with version coupling here","author_login":"baaaaif","author_association":"NONE","created_at":"2025-02-18T08:51:25+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2664993883","fragment_type":"issue_comment","sequence":2,"text":"@baaaaif oh thanks for that , now that makes sense because I downgraded to maui 9.0.30 and I still got the error and I have 17.12.5\nI will try to rollback to 17.12.4 hopefully its easily done . I was looking also at this thread URL","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T09:00:14+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[2672738371],"is_known_query_context":false},{"document_id":"gh_comment_2665212881","fragment_type":"issue_comment","sequence":3,"text":"Anyone from the Maui team ? we are stuck and tried forcing .net install 9.0.1 but the hosted agent did not allow it. We cannot deliver to production next week.\n\nany work around?","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T10:27:42+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2668890390","fragment_type":"issue_comment","sequence":4,"text":"Just to confirm, the only update is VS?\n\nAre you able to attach a binlog? URL","author_login":"mattleibow","author_association":"MEMBER","created_at":"2025-02-19T14:54:08+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2669135101","fragment_type":"issue_comment","sequence":5,"text":"@mattleibow locally everything works fine! but for some reasons when building the iOS app via Azure Pipeline we get \n\n IL stripping assemblies\n Tool /Users/runner/hostedtoolcache/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64/9.0.2/Sdk/../tools/mono-aot-cross execution finished (exit code = 139).\n \n/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.2/18.2.9173/targets/Xamarin.Shared.Sdk.targets(1279,3): error : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139. [/Users/runner/work/1/s/Clients/ClientA/src/MyApp/MyApp.csproj::TargetFramework=net9.0-ios]\n Tool /Users/runner/hostedtoolcache/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64/9.0.2/Sdk/../tools/mono-aot-cross execution finished (exit code = 139).\n \n/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.2/18.2.9173/targets/Xamarin.Shared.Sdk.targets(1279,3): error : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139. [/Users/runner/work/1/s/Clients/ClientA/src/MyApp/MyApp.csproj::TargetFramework=net9.0-ios]\n\ntill sunday this was building fine in azure , then started to fail , I think I did an upgrade of VS to 17.3 but not sure now but rolledback to 17.2.2 and nothing still fails , I am not the only one with this issue as you can see URL","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-19T16:21:28+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[2672738371],"is_known_query_context":false},{"document_id":"gh_comment_2671159369","fragment_type":"issue_comment","sequence":6,"text":"@gabsamples6 Thank you for linking that! This is unrelated to the MAUI UI Toolkit, you are hitting a runtime issue with AOT and there is nothing that can be fixed here. Since there is an open issue for it, runtime is the best place to have this conversation.\n\nDuplicate of URL","author_login":"drasticactions","author_association":"CONTRIBUTOR","created_at":"2025-02-20T10:59:31+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[2672738371],"is_known_query_context":false},{"document_id":"gh_comment_2671315727","fragment_type":"issue_comment","sequence":7,"text":"@drasticactions I appreciate that this its not a a maui issue but however it massivily impact the deployment of any IOS app , I assume you would have a vested interest making sure that this prioritized accorndingly. Do you see my point?","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-20T12:10:39+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2671345608","fragment_type":"issue_comment","sequence":8,"text":"@gabsamples6 Yes, which is why it should go into the runtime.\n\nThis is a repo for the MAUI Cross-Platform UI project, it's not for _all_ .NET mobile apps. Your issue could affect any app deployed to .NET iOS, including those that don't use any toolkits. So it should really go into the runtime repo and be tracked there unless there is something specific that can be fixed in this project.\n\nYou are talking to engineers (Like @rolfbjarne) that can help you here.","author_login":"drasticactions","author_association":"CONTRIBUTOR","created_at":"2025-02-20T12:23:39+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2679579353","fragment_type":"issue_comment","sequence":9,"text":"I'm seeing this error in my MAUI app on an Azure pipeline for iOS. It started breaking when I moved from 9.0.30 to 9.0.40\nBuild ios app 9.0.30 : Created the package: bin/Release-Test/net9.0-ios/ios-arm64/publish//C.Mobile.ipa\nBuild ios app 9.0.40: Tool /Users/runner/hostedtoolcache/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64/9.0.2/Sdk/../tools/mono-aot-cross execution finished (exit code = 139).\n/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.2/18.2.9173/targets/Xamarin.Shared.Sdk.targets(1279,3): error : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139. [/Users/runner/work/1/s/C.Mobile/C.Mobile.csproj::TargetFramework=net9.0-ios]\nWorkload updates are available. Run `dotnet workload list` for more information.","author_login":"vikher","author_association":"NONE","created_at":"2025-02-24T20:32:12+08:00","repo_name":"dotnet/maui","issue_id":2859582494,"issue_number":27867,"issue_url":"https://github.com/dotnet/maui/issues/27867","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2672738371","fragment_type":"issue_description","sequence":0,"text":"AOT compile aot-instances.dll, the AOT compiler exited with code 139.\n_From @bwinklesky on Fri, 15 Nov 2024 19:19:59 GMT_\n\n### Apple platform\n\niOS\n\n### Framework version\n\nnet9.0-*\n\n### Affected platform version\n\n.NET 9\n\n### Description\n\nAfter upgrading to Xcode 16 and upgrading source code to version 9 we are getting this error.\n\nIL stripping assemblies\n12:01:24 Tool /usr/local/share/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-arm64.Cross.ios-arm64/9.0.0/Sdk/../tools/mono-aot-cross execution finished (exit code = 139).\n12:01:24 \n12:01:24 /usr/local/share/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/targets/Xamarin.Shared.Sdk.targets(1277,3): error : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139.\n\n### Steps to Reproduce\n\ndotnet publish release\n\n### Did you find any workaround?\n\n_No response_\n\n### Build logs\n\n_No response_\n\n_Copied from original issue xamarin/xamarin-macios#21634_","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:33+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486161084","fragment_type":"issue_comment","sequence":1,"text":"_From @rolfbjarne on Fri, 15 Nov 2024 19:29:01 GMT_\n\nCould you get an MSBuild binlog and attach it here? Thanks!","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:35+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486161110","fragment_type":"issue_comment","sequence":2,"text":"_From @bwinklesky on Fri, 15 Nov 2024 19:52:13 GMT_\n\nmsbuild.binlog.zip\n\nLet me know if this doesn't work","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:36+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486161156","fragment_type":"issue_comment","sequence":3,"text":"_From @rolfbjarne on Mon, 18 Nov 2024 08:13:11 GMT_\n\nUnfortunately that didn't give me many clues.\n\nIs there any chance we could get access to your project to compile it ourselves?","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:36+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486161196","fragment_type":"issue_comment","sequence":4,"text":"_From @bwinklesky on Mon, 18 Nov 2024 19:06:13 GMT_\n \n \n \n\n@rolfbjarne I created a respository and gave you access. WasatchBackcountryAlliance is the app to build.\n\nI ask that you destroy the source code after you've diagnosed the issue.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:37+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486161229","fragment_type":"issue_comment","sequence":5,"text":"_From @rolfbjarne on Tue, 19 Nov 2024 12:28:31 GMT_\n \n \n \n \n \n \n\nI confirm I can reproduce the problem; I'll see if I can figure out where to route the bug and create a smaller test project that doesn't involve any of your code.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:38+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486161265","fragment_type":"issue_comment","sequence":6,"text":"_From @formerlymisterhenson on Tue, 19 Nov 2024 13:27:19 GMT_\n\nWell this error occured in my project as well, I went with:\n\n \n True \n -all,System.Private.Windows.Core","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2024-11-19T16:17:39+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2486999902","fragment_type":"issue_comment","sequence":7,"text":"Just to let you know that I have this problem also - exactly as described above. I gave the solution from @formerlymisterhenson a shot and my build has now completed OK. However, not sure whether\n\n True \n -all,System.Private.Windows.Core \n\n is going to have any adverse effects?","author_login":"mwilson25","author_association":"NONE","created_at":"2024-11-19T23:50:36+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2490525715","fragment_type":"issue_comment","sequence":8,"text":"@BrzVlad could you please repro from Rolf's repro and get a real callstack - the one in the crash report is probably without symbols. That should help us triage this better.","author_login":"vitek-karas","author_association":"MEMBER","created_at":"2024-11-21T09:28:47+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2528655512","fragment_type":"issue_comment","sequence":9,"text":"The fix is there, the release cycle will take a while. I would assume the new .NET9 version will be available sometime in January.","author_login":"BrzVlad","author_association":"MEMBER","created_at":"2024-12-09T16:42:44+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2559926608","fragment_type":"issue_comment","sequence":10,"text":"Tried the suggestion above and others separate and together and still same issues.IOSBuild.zip\n\n \n True \n Apple Distribution: Donald Joyce (53H6YZD9EN) \n Fertilizer Calc Distribution \n manual \n true \n None \n \n True \n \n True \n \n true \n True \n True \n True \n \n False \n \n --aot=verbose \n --aot-options=limit-llvm-stack=400MB \n --aot=threads=1 \n -all,System.Private.Windows.Core \n True","author_login":"Dark-MatterSoftware","author_association":"NONE","created_at":"2024-12-23T15:42:41+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2560457631","fragment_type":"issue_comment","sequence":11,"text":"True \n -all,System.Private.Windows.Core \n \n\nthis worked for me I was able to do a release build. @rolfbjarne thank you","author_login":"DCox2016","author_association":"NONE","created_at":"2024-12-24T00:12:46+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564337877","fragment_type":"issue_comment","sequence":12,"text":"As of to date. Still not able to do a release, but have been able to upload a \"Debug\" version of the app for Test Flight until this is fixed.","author_login":"Dark-MatterSoftware","author_association":"NONE","created_at":"2024-12-28T14:28:52+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564362970","fragment_type":"issue_comment","sequence":13,"text":"Not sure if you’re building against .NET 9 or not, but if you are… you can downgrade to version 8 and you should be able to publish a release build.","author_login":"bwinklesky","author_association":"NONE","created_at":"2024-12-28T15:31:51+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564554600","fragment_type":"issue_comment","sequence":14,"text":"I am developing for .Net 9. I did try switching to .Net 8 but many of my libraries also needed to be downgraded as well. Then some other issues came up that were fixed in the 9 libraries. So I will wait, this application is multi platform.","author_login":"Dark-MatterSoftware","author_association":"NONE","created_at":"2024-12-28T23:19:06+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2564664676","fragment_type":"issue_comment","sequence":15,"text":"Removing the package SixLabors.ImageSharp from the project \"resolved\" the problem for me.","author_login":"Migoked","author_association":"NONE","created_at":"2024-12-29T09:27:58+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2597618526","fragment_type":"issue_comment","sequence":16,"text":"Any word on when this fix will be released? I too have the SizLablrs.ImageSharp nuget package and I'm getting this error. Unfortunately, I can't remove that package.","author_login":"Robbidos","author_association":"NONE","created_at":"2025-01-17T07:42:34+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2597758239","fragment_type":"issue_comment","sequence":17,"text":"URL is now merged into the servicing branch for 9. It should go out with the next release (Feb). Assuming you're hitting the same problem the fix is for.","author_login":"vitek-karas","author_association":"MEMBER","created_at":"2025-01-17T09:07:24+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2600927334","fragment_type":"issue_comment","sequence":18,"text":"For a workaround at the moment. I can compile in Debug and Publish, but the Publish hangs. If you watch the folder \"/Users/{Username}/Library/Developer/Xcode/Archives\" on your Mac. A folder will be created with a date stamp \"YYYY-MM-DD\" format with an archive file located inside. From there I have to end Visual Studio via Task Manager. Canceling causes issues with the file, perhaps it's trying to roll back. Double clicking the file will open XCode to Validate and/or Distribute the app to the Store. My app is still in TestFlight for the moment so this is workable until this issue can be resolved.","author_login":"Dark-MatterSoftware","author_association":"NONE","created_at":"2025-01-19T16:14:21+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2628882858","fragment_type":"issue_comment","sequence":19,"text":"I am getting this too with .NET 8.0 on IOS when using VS 17.13 preview 4.0. Rollbacking to preview 1.0 fixes it. \n\nWill the fix in .net 9.0 will apply to .net 8.0 as well?\n\n-Mat","author_login":"BleuBleu","author_association":"NONE","created_at":"2025-02-01T09:54:05+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2635145991","fragment_type":"issue_comment","sequence":20,"text":"Another failure was detected on this sample with the 9.0.2 service release (due in February). An additional fix was required URL which will be included in 9.0.3 release (due in March from my understanding). Sorry about the delay.\n\n@BleuBleu A fix for these AOT compilation issues was introduced on .NET9 and these subsequent fixes expand on that work so they are only relevant for .NET9. There is nothing planned for .NET8.","author_login":"BrzVlad","author_association":"MEMBER","created_at":"2025-02-04T21:46:06+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2652768852","fragment_type":"issue_comment","sequence":21,"text":"I'm using MAUI on .NET 9 with ImageSharp as well, and @electro-logic workaround worked for me.\n\nWhile MtouchInterpreter -all didn't.","author_login":"bchehab","author_association":"NONE","created_at":"2025-02-12T06:19:49+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2653280294","fragment_type":"issue_comment","sequence":22,"text":"It does work, but makes the app very very slow.\nIt's already slow with Maui but with the interpréter it's horrible.","author_login":"softlion","author_association":"NONE","created_at":"2025-02-12T10:19:21+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2653307379","fragment_type":"issue_comment","sequence":23,"text":"@softlion true. I read that this option should still perform aot for everything it can, and fallback to interpreter mode. But my build used to take 20+ minutes and now it finishes in 5 mins. So I guess no aot is taking place.","author_login":"bchehab","author_association":"NONE","created_at":"2025-02-12T10:30:44+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2664956000","fragment_type":"issue_comment","sequence":24,"text":"not sure if a coincidence but since yesterday my iOS azure pipeline started to fail with.\n\n/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.2/18.2.9173/targets/Xamarin.Shared.Sdk.targets(1279,3): error : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139\nFailed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139\n\nI am using .net 9 and on sunday with maui 9.0.30 worked then upgraded to 9.0.40 and crashed, then reverted to 9.0.30 and still broken.. I am confused! And we are supposed to go to prod in a week , any suggestions @rolfbjarne ?","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T08:43:30+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665016704","fragment_type":"issue_comment","sequence":25,"text":"A new version of .NET (9.0.2) was released last week, that might be why it started failing recently, so it might work if you force the previous version (9.0.1) in your Azure pipeline.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-02-18T09:09:31+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665172129","fragment_type":"issue_comment","sequence":26,"text":"@rolfbjarne thanks for your suggestion , but for some reasons I cannot seem to force 9.0.1 in the pipeline it says\nI have tried both with macOS14 and 15 Hosted agent.. Am I missing something? \n\n **##[error]sdk version matching: 9.0.1 could not be found**\n\nand I have \n \n\n - task: UseDotNet@2\n displayName: .NET Version\n inputs:\n packageType: 'sdk'\n version: '9.0.1'\n includePreviewVersions: false","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T10:11:35+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665234841","fragment_type":"issue_comment","sequence":27,"text":"I've oriented myself on\n URL \nusing a global.json and\n\nsteps:\n- task: UseDotNet@2\n displayName: 'Use .NET Core sdk '\n inputs:\n useGlobalJson: true\n\nin the pipeline. Hope this helps and works for you","author_login":"baaaaif","author_association":"NONE","created_at":"2025-02-18T10:36:54+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665286132","fragment_type":"issue_comment","sequence":28,"text":"@baaaaif I dont have a global.json, not sure what that changes compared to what I have tried in the pipeline , may be my code to install 9.0.1 is wrong","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T10:54:31+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2665345540","fragment_type":"issue_comment","sequence":29,"text":"still very very confused\n\n16st Feb Sunday (last success pipeline) was using .net 9.0.200. and all was building..\nMonday starts failing... \n\n _IL stripping assemblies\n Tool /Users/runner/hostedtoolcache/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64/9.0.2/Sdk/../tools/mono-aot-cross execution finished (exit code = 139)._\n\ninstalled .net 9.0.100 but still makes no difference! \n\nwhat Am I missing? very grateful for any insight","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-18T11:17:58+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667581564","fragment_type":"issue_comment","sequence":30,"text":"We have been affected too and none of the solutions mentioned on this thread works apart setting the interpreter to true which defeats the point alltogether.\n\nDo we know if this is been worked on? Is there any chance of a quick fix and deploy?","author_login":"TedMobile","author_association":"NONE","created_at":"2025-02-19T06:00:24+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667609576","fragment_type":"issue_comment","sequence":31,"text":"That would be great as I rolled back to net8 to workaround that. But that can't be a long term solution given that Maui is not tied to the LTS of dotnet.","author_login":"softlion","author_association":"NONE","created_at":"2025-02-19T06:22:07+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667674780","fragment_type":"issue_comment","sequence":32,"text":"If you have any build logs from a working build, you could compare them with the current build logs to see if there are any version differences anywhere.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-02-19T07:01:36+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2668719490","fragment_type":"issue_comment","sequence":33,"text":"@rolfbjarne Hi, looked at the azure pipeline logs and I get as follows \n\n**Success last week**\n\n Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: URL \n Optimizing assemblies for size. This process might take a while.\n IL stripping assemblies\n Created the package: /Users/runner/work/1/s/Clients/ClientA/artifacts/ClientA.ipa\n\n**Failure**\n\n IL stripping assemblies\n Tool /Users/runner/hostedtoolcache/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64/9.0.2/Sdk/../tools/mono-aot-cross execution finished (exit code = 139).\n \n/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.2/18.2.9173/targets/Xamarin.Shared.Sdk.targets(1279,3): error : Failed to AOT compile aot-instances.dll, the AOT compiler exited with code 139. [/Users/runner/work/1/s/Clients/ClientA/src/MyApp/MyApp.csproj::TargetFramework=net9.0-ios]\n Tool /Users/runner/hostedtoolcache/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64/9.0.2/Sdk/../tools/mono-aot-cross execution finished (exit code = 139).\n \n/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.2/18.2.9173/targets/Xamarin.Shared.Sdk.targets(1279,3): error : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139. [/Users/runner/work/1/s/Clients/ClientA/src/MyApp/MyApp.csproj::TargetFramework=net9.0-ios]\n\nBoth they were using \n\nImage\n\nIs there any preview version that we could try? Or is there a fix in the works? grateful for any suggestions, we cannot revert to .net 8, to many changes to our code,","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-19T13:51:54+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2671246266","fragment_type":"issue_comment","sequence":34,"text":"There are many versions involved, so that doesn't give the full picture.\n\nMSBuild binlogs contains all the version information, alternatively executing this will also list all the versions:\n \n\nI understand both are rather difficult to get for the build that worked if you didn't already collect this information at that time, but it might be possible to get the significant versions with complete build logs instead of just snippets.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-02-20T11:39:03+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2674643543","fragment_type":"issue_comment","sequence":35,"text":"Thanks for the suggestions but I was not including in the pipeline to produce binlogs which I have now added, Hopefully there is someone else who might have a bin log!","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-21T14:05:59+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2680219267","fragment_type":"issue_comment","sequence":36,"text":"Coincidentally, this happened when I updated MAUI from 9.0.30 to 9.0.40. I had my pipeline build successfully on 9.0.2 on February 14 before it started crashing out of nowhere. I tried forcing 9.0.1, but it doesn’t make a difference. The only thing that fixes it for me is using true in the .csproj file.","author_login":"vikher","author_association":"NONE","created_at":"2025-02-25T02:20:10+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2681168078","fragment_type":"issue_comment","sequence":37,"text":"There is one known issue, and it's this one. You may be running into a different issue - the only way to know for sure is to either wait and try out the fix for this issue once it's been released, or provide us with a test project we can use to verify the fix against.\n \n\nThat depends on your app and what it does. For some apps the performance difference is undetectable, other apps can become unusable. As a very rough guideline, the more math an app does (think games, image processing, etc.) the bigger the performance hit. My recommendation would be to test your app and see how it behaves.\n \n\nIt may be possible to work around it by adding this to the project file:\n\nxml\n \n false \n \n\nThe effect of this is potentially a bigger app, but it won't affect performance.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-02-25T08:48:36+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2681916795","fragment_type":"issue_comment","sequence":38,"text":"Experiencing the same issue. If the info is any help, so far I've tried:\n\n True \n -all,System.Private.Windows.Core \n\nDidn't fix it unfortunately.\n\n \n false \n \n\n \n\nChanged the build error from `aot-assemblies.dll` to `SixLabors.ImageSharp.dll`:\n\n`(_AOTCompile target) -> /usr/local/share/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/targets/Xamarin.Shared.Sdk.targets(1277,3): error : Failed to AOT compile SixLabors.ImageSharp.dll, the AOT compiler exited with code 139. `\n\nI don't know if this error is directly related to ImageSharp in some way, or if it just affects ImageSharp by coincidence (ImageSharp is known to use some specific code to support AOT and such).\n\n true \n\nDid fix the build error, but impacted performance quite significantly when handling images (which is not ideal, but acceptable as image processing is not a huge part of the app).","author_login":"leonluc-dev","author_association":"CONTRIBUTOR","created_at":"2025-02-25T13:02:56+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2682183264","fragment_type":"issue_comment","sequence":39,"text":"I have to say that I tend to be more in line with what @vikher commented as I had the exact scenario, since updating to 9.0.40 and then reverted and also reverted to 9.0.1 from 9.0.2 and also reverted VSStudio I could not make it work anymore, I dont have the bin logs , but something odd happened there.. I just hope that a fix is in the works!","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-25T14:30:43+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2683344491","fragment_type":"issue_comment","sequence":40,"text":"@rolfbjarne Here's my update: I tried again today in an Azure DevOps pipeline with Xcode 16.2, .NET MAUI 9.0.40, and .NET 9.0.200. \nFor me the issue was Microsoft.Build can’t be higher than 17.12.6 \nanything above that breaks the build. If you use Microsoft.Build 17.13.9, you need to add ` true `\n\nInitially, I thought the issue was with the .NET MAUI 9.0.40 upgrade, but that was because I had done a bunch of NuGet updates at the same time, which led to some confusion. I’ll let you investigate how this ties into the .NET runtime.","author_login":"vikher","author_association":"NONE","created_at":"2025-02-25T21:32:24+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2684457041","fragment_type":"issue_comment","sequence":41,"text":"@vikher \n \n\nDid you do that with the use of a script in your azure pipeline? I would like to try thanks","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-02-26T09:50:02+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2684933661","fragment_type":"issue_comment","sequence":42,"text":"A (seemingly) related issue brought me here and I have no clue what to do with this. The problem started occurring at random when building the application in a pipeline. I looked into the logs and the build was succeeding when building the application using manifest version `18.2.9173`, but stopped working when using `18.2.9180`. I don't know whether this is issue is but it is really frustrating. I've already tried to use a `global.json` file but to no avail...","author_login":"johan-broekhof","author_association":"NONE","created_at":"2025-02-26T13:17:17+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2716698249","fragment_type":"issue_comment","sequence":43,"text":"I am facing the same issue. The only thing that solved the problem was ` true `...","author_login":"kyurkchyan","author_association":"NONE","created_at":"2025-03-12T06:38:05+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2717153408","fragment_type":"issue_comment","sequence":44,"text":"Unrelated but not sure where I should file this azure ms hosted agent when build iOS you cant see whats going on anymore its in permanent loading mode and problem is I am crashing and not sure what is going on @rolfbjarne any suggestion where to log this one?\n\nImage","author_login":"gabsamples6","author_association":"NONE","created_at":"2025-03-12T09:05:51+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730067735","fragment_type":"issue_comment","sequence":45,"text":"Is there any timeline for when this will be fixed? It's been 4 months since it was reported.","author_login":"bwinklesky","author_association":"NONE","created_at":"2025-03-17T16:03:50+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2730131525","fragment_type":"issue_comment","sequence":46,"text":"A fix for this was attempted in 9.0.2, but the fix in that release proved to be incomplete. Another fix was made but it somehow slipped through the cracks for the 9.0.3 release. So this should be fixed in 9.0.4 release, early April.","author_login":"BrzVlad","author_association":"MEMBER","created_at":"2025-03-17T16:24:46+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2753996768","fragment_type":"issue_comment","sequence":47,"text":"I can confirm that the **SixLabors.ImageSharp.dll** is definitely a problem. We updated our MAUI app to .NET 9.0 and ran into the problem described for the **iOS** app. We did not reference the SixLabors.ImageSharp.dll directly, but the **NPOI** Nuget package does. After removing the NPOI package from the project, the iOS app compiled successfully. But since we need the NPOI package, removing it does not solve the general problem.","author_login":"stefanottauma","author_association":"NONE","created_at":"2025-03-26T10:52:21+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2754215783","fragment_type":"issue_comment","sequence":48,"text":"A temporary workaround would be to use the interpreter instead of AOT for ImageSharp like this:\n\n \n -all,SixLabors.ImageSharp \n \n\nKeep in mind that while this will fix the build issue, it will make any Imagesharp code in release builds extremely slow (due to it relying heavily on AOT)","author_login":"leonluc-dev","author_association":"CONTRIBUTOR","created_at":"2025-03-26T12:19:42+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2755004264","fragment_type":"issue_comment","sequence":49,"text":"I can confirm that this has a catastrophic performance hit. Unfortunately, the v9 release as a whole has been catastrophic for Web and iOS projects.","author_login":"bwinklesky","author_association":"NONE","created_at":"2025-03-26T16:22:01+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2771934153","fragment_type":"issue_comment","sequence":50,"text":"Also hitting this one. Fingers crossed for this Patch Tuesday! 🤞","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-02T09:12:49+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2788660972","fragment_type":"issue_comment","sequence":51,"text":"@jeremy-visionaid could you please create a separate issue with some more details about the failure you're seeing? It's possible it's yet another combination we haven't seen so far and the existing fixes don't cover.","author_login":"vitek-karas","author_association":"MEMBER","created_at":"2025-04-09T07:42:29+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2788953218","fragment_type":"issue_comment","sequence":52,"text":"I could create a project. But actually it is quite easy to reproduce it.\nIn my case:\n\n- Create a new MAUI project targeting .Net 9.0\n- Reference an affected NuGet package like (SixLabors.ImageSharp)\n- Use code from the NuGet package in the MainPage\n- Try to compile the project for **iOS**\n\nImage","author_login":"stefanottauma","author_association":"NONE","created_at":"2025-04-09T09:17:42+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2789263979","fragment_type":"issue_comment","sequence":53,"text":"I installed the latest .NET, SDK 9.0.203, installed the maui workload and I can't reproduce the original issue from this bug. I also tried the repro steps from above, without reproducing any crashes.\n\nOn an arm64 mac I tried:\n- `dotnet new maui`; left only `net9.0-ios` target framework\n- `dotnet add package SixLabors.ImageSharp`, 3.1.7 version was added\n- added `var color = SixLabors.ImageSharp.Color.Aqua;` in `MainPage` ctor\n- `dotnet build -c Release` -> this was very expensive on memory/cpu, took around 16 mins due to llvm compilation\n- disabled llvm via ` false ` and ran the build again, successfully finished in 2 mins this time.","author_login":"BrzVlad","author_association":"MEMBER","created_at":"2025-04-09T10:54:21+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2789635776","fragment_type":"issue_comment","sequence":54,"text":"I can confirm that adding ** false ** to the project file resolves the problem for this test project.","author_login":"stefanottauma","author_association":"NONE","created_at":"2025-04-09T13:04:10+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2790557663","fragment_type":"issue_comment","sequence":55,"text":"For us it does not seem to work regardless MtouchUseLlvm true/false:\nImage","author_login":"formerlymisterhenson","author_association":"NONE","created_at":"2025-04-09T18:13:15+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2791271842","fragment_type":"issue_comment","sequence":56,"text":"No repro for me referencing `SixLabors.ImageSharp` as above on M2 Pro, but it takes a *very* long time...\n\ndotnet build -c:Release\nRestore complete (0.5s)\n MauiTestApp net9.0-ios succeeded (2806.4s) → bin/Release/net9.0-ios/iossimulator-arm64/MauiTestApp.dll\n\nBuild succeeded in 2807.0s\n\nUnfortunately, I can't share the project I can still repro on, but I'll have a go at cutting it down to something minimal to see which bit is causing the failure.","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-10T00:42:41+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2791314389","fragment_type":"issue_comment","sequence":57,"text":"At the risk of going off topic, does anybody know why Catalyst builds so much faster that iOS? For the SixLabours example:\n\ndotnet build -c:Release -f:net9.0-maccatalyst\n MauiTestApp net9.0-maccatalyst succeeded (11.6s) → bin/Release/net9.0-maccatalyst/maccatalyst-x64/MauiTestApp.dll\n MauiTestApp net9.0-maccatalyst succeeded (24.9s) → bin/Release/net9.0-maccatalyst/maccatalyst-arm64/MauiTestApp.dll\n\nFor the project I'm working on where I can repro, the iOS build fails after about 10 mins, but the Catalyst build fails after only 30 seconds.","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-10T01:23:26+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2791371507","fragment_type":"issue_comment","sequence":58,"text":"OK. I have a minimal repro... It's just referencing types from System.Drawing.Common:\n\n \n\nSystem.Diagnostics.Trace.WriteLine($\"{System.Drawing.Size.Empty}\");\n\nRepo available at URL \n\nBoth iOS and Catalyst fail, but Catalyst fails much faster:\n\ndotnet build -c:Release -f:net9.0-maccatalyst","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-10T02:09:26+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2791919786","fragment_type":"issue_comment","sequence":59,"text":"This is not an issue with the AOT compiler, rather a problem with packages and a missing dll. The errors reported during AOT compilation are `Could not load file or assembly 'System.Formats.Nrbf`. Adding a reference to `System.Formats.Nrbf` fixes compilation.\n\nHaving said this, you shouldn't use `System.Drawing.Common` in the first place, it was deprecated on non-windows platforms. URL \n\nThis particular problem was reported before, for example: URL","author_login":"BrzVlad","author_association":"MEMBER","created_at":"2025-04-10T08:08:22+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2792108025","fragment_type":"issue_comment","sequence":60,"text":"@BrzVlad Thanks for the reply. Sadly it's not so simple as just not using System.Drawing.Common since I'm investigating porting an old application from WinForms to MAUI. There would be a lot of code to port to new types and serialization of them in settings, documents etc. Sure I *could* at least handle it in code that I control (with some effort), but it's also possible a reference might be acquired transitively.\n\nI think there are some other points for consideration here (I don't necessarily expect a reply since they not all compiler/runtime related, so maybe a bit off topic for this project):\n1. The app builds and runs in Debug without giving any warnings (Why does the AOT compiler need the Nrfb reference but an interpreted build does not? Should this be covered by some AOT analyzer (or maybe the package owner)? Why are there no warnings by default for referencing the Drawing package if it's supposed to be attributed as Windows specific?)\n2. AOT compilation works for maccatalyst-x64 so why not maccatalyst-arm64?\n3. The cause of the build failure is not surfaced effectively. The messages regarding the missing types/reference isn't shown to the user in VS Code. The easiest way I can get to it at all is to build manually and turn off the terminal logger.\n\nI'm grateful to have a workaround (it's certainly a lot less work than removing the dependency), but it does feel like the developer experience could be improved here - even if that's beyond the scope of the compiler/runtime.","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-10T09:19:00+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2792455089","fragment_type":"issue_comment","sequence":61,"text":"For us adding ` ` fixes publishing, thanks. We're using System.Drawing.Common and were not aware of the deprecation for other operating systems.","author_login":"formerlymisterhenson","author_association":"NONE","created_at":"2025-04-10T11:38:03+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2792642265","fragment_type":"issue_comment","sequence":62,"text":"This is because there's no AOT compiler for x64, it'll always use the JIT/interpreter.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-04-10T12:47:12+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2794065107","fragment_type":"issue_comment","sequence":63,"text":"For me updating to .NET 9.0.4 (along with updating the iOS and MAUI workloads) fixed the build issue. (\".NET 9 for iOS\" project with ImageSharp)\nThe `_AOTCompile` step takes a bit longer with 9.0.4 than it did with .NET 8 (21 minutes vs 12 minutes), but it all compiles and runs.","author_login":"leonluc-dev","author_association":"CONTRIBUTOR","created_at":"2025-04-10T14:55:06+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2796199127","fragment_type":"issue_comment","sequence":64,"text":"Came across the same issue after adding a NotificationServiceExtension project for BlazorHybrid.\nIn BlazorHybrid I have:\n true \nWhen I added the same true to NotificationServiceExtension the error was gone.","author_login":"evgenyvalavin","author_association":"NONE","created_at":"2025-04-11T08:23:52+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2796214388","fragment_type":"issue_comment","sequence":65,"text":"Thanks @rolfbjarne! You're of course correct that _`AOTCompile` isn't being run, but I thought from the docs that it was:\n URL","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-11T08:30:54+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2796273620","fragment_type":"issue_comment","sequence":66,"text":"@vitek-karas Thanks to you also for taking the time for such a detailed reply! With respect to point 1, I was more looking at it from the Debug/JIT side... It would have been nice to have gotten some kind of warning. e.g. If `EnableAotAnalyzer` is enabled then should the intent be for that to result in a warning that AOT will fail? And should referencing System.Drawing.Common in a non-Windows project give a warning?","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-11T08:54:57+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2796347396","fragment_type":"issue_comment","sequence":67,"text":"This I agree with - I'm guessing that when we deprecated the assembly on non-Windows we didn't really do work to correctly annotate the APIs (that's actually quite a lot of work). We can open a bug on it, not sure if it will be fixed though.\n\nThe analyzer would have a hard time with this - mostly due to technical limitations. It's a Roslyn analyzer, which only sees your source code and metadata about references. If the code you're calling directly is not in the references, then C# compiler itself will fail - no need to analyze for that. And if you're calling code which has the problem, the analyzer doesn't see that code. Ultimately there are a set of problems which the analyzer can't see, missing references in dependencies is one such set.","author_login":"vitek-karas","author_association":"MEMBER","created_at":"2025-04-11T09:25:52+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2796379174","fragment_type":"issue_comment","sequence":68,"text":"All good. It's working for me now, so I'm happy enough, and I'm grateful for the help. There are just some orthoganal issues that made it a bit harder to deal with than I would have liked. FWIW, if types like `RotateFlipType` and some other had been in `System.Drawing.Primitives` and not `System.Drawing.Common` then I might not have hit it directly, but at least I don't have to work around it now 👍","author_login":"jeremy-visionaid","author_association":"NONE","created_at":"2025-04-11T09:39:51+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2824831155","fragment_type":"issue_comment","sequence":69,"text":"Try disabling Hot Reload, it brings in assemblies that need MAUI, so it won't work if you're not using MAUI.","author_login":"rolfbjarne","author_association":"MEMBER","created_at":"2025-04-23T16:14:07+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2824848755","fragment_type":"issue_comment","sequence":70,"text":"I guessed you meant Tools -> Options -> Debugging -> XAML Hot Reload. We've never used that feature. You were right, turning it off has fixed the problem. Thank you.\n\nI really hope you are able to improve these error messages, and prioritise doing so. They are so unhelpful!","author_login":"divil5000","author_association":"NONE","created_at":"2025-04-23T16:21:26+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2829565561","fragment_type":"issue_comment","sequence":71,"text":"Anecdotic datapoint: I do not use hot reload (my project is native .NET, not MAUI) in Rider and the issue appeared when I finally migrated from an Intel Mac to an Apple Silicon Mac last week. Same setup, except maybe the minor version of .NET 9 is newer now, haven't checked that one (the new machine got the latest 9.0.203).\n\n` true ` fixed it for now","author_login":"ivmirx","author_association":"NONE","created_at":"2025-04-25T07:13:32+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2854256716","fragment_type":"issue_comment","sequence":72,"text":"Tried without the interpreter and the app built on iOS azure pipeline but app crashes when run - trying to see what the error is... Added back interpreter=true and all good","author_login":"TedMobile","author_association":"NONE","created_at":"2025-05-06T11:40:25+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2922160192","fragment_type":"issue_comment","sequence":73,"text":"Just to update:\n- error still happing \n- .net 9 sdk version 9.0.203\n- ONLY on pipeline Azure Devops `vmImage: macOS-15` \n- Xcode version: 16.3\n\nBuild is OK \n\nError occurs just when run this command:\n\n`dotnet publish /Users/runner/work/1/s/Driver/Driver.csproj -c Release -f net9.0-ios -o /Users/runner/work/1/b -p:ArchiveOnBuild=true -p:RuntimeIdentifier=ios-arm64 -p:CodesignKey=Apple Distribution%3A My Company Inc.%2C The (359TXXXXX) -p:CodesignProvision=XXXX Distribution Profile /p:ApplicationVersion=123123 /p:ApplicationDisplayVersion=1.0.0`\n\nError logged:\n- ` error : Failed to AOT compile SkiaSharp.Views.iOS.dll, the AOT compiler exited with code 139` \n\nWoraround:\n\nit works OK when i put this in my `.csproj` \n\n \n True \n -all,SkiaSharp.Views.iOS","author_login":"elfiservice","author_association":"NONE","created_at":"2025-05-30T11:40:37+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2922284332","fragment_type":"issue_comment","sequence":74,"text":"@elfiservice Have you also tried disabling llvm ? Could you add `-v diag --tl:off` after `dotnet publish` and upload the log with the failure ? Thanks","author_login":"BrzVlad","author_association":"MEMBER","created_at":"2025-05-30T12:36:28+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3066050100","fragment_type":"issue_comment","sequence":75,"text":"@BrzVlad could you provide the Link of this original issue ? tks","author_login":"elfiservice","author_association":"NONE","created_at":"2025-07-12T21:14:25+08:00","repo_name":"dotnet/runtime","issue_id":2672738371,"issue_number":109966,"issue_url":"https://github.com/dotnet/runtime/issues/109966","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0466","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Private libs end up in public provides?","query_context":"yaml\ngcc-12-test-sca.yaml\npackage:\n name: gcc-12-test-sca\n version: 12.4.0\n epoch: 0\n description: \"the GNU compiler collection - version 12\"\n copyright:\n - license: GPL-3.0-or-later\n\nenvironment:\n contents:\n packages:\n - busybox\n - gcc-12\n\npipeline:\n - runs: |\n mkdir -p ${{targets.destdir}}/usr/lib\n cp -r /usr/lib/gcc ${{targets.destdir}}/usr/lib\n\nbuild output:\n\nconsole\n024/07/11 18:58:44 INFO generating package gcc-12-test-sca-12.4.0-r0\n2024/07/11 18:58:44 INFO scanning for shared object dependencies...\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libgomp.so.1.0.0\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libitm.so.1.0.0\n2024/07/11 18:58:44 INFO found lib libm.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libquadmath.so.0.0.0\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libquadmath.so.0.0.0\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libssp.so.0.0.0\n2024/07/11 18:58:44 INFO scanning for commands...\n2024/07/11 18:58:44 INFO scanning for pkg-config data...\n2024/07/11 18:58:44 INFO scanning for python modules...\n2024/07/11 18:58:44 INFO scanning for shbang deps...\n2024/07/11 18:58:44 INFO runtime:\n2024/07/11 18:58:44 INFO so:libc.so.6\n2024/07/11 18:58:44 INFO so:libm.so.6\n2024/07/11 18:58:44 INFO provides:\n2024/07/11 18:58:44 INFO so:libgomp.so.1=1\n2024/07/11 18:58:44 INFO so:libitm.so.1=1\n2024/07/11 18:58:44 INFO so:libquadmath.so.0=0\n2024/07/11 18:58:44 INFO so:libssp.so.0=0\n2024/07/11 18:58:44 INFO installed-size: 74429639\n2024/07/11 18:58:44 INFO data.tar.gz digest: f4370156bd67b791b8c0cb8eb0856a4a25a6a0301cad1f2ee85cfc26aa308e93\n2024/07/11 18:58:44 INFO wrote packages/x86_64/gcc-12-test-sca-12.4.0-r0.apk\n\nExpecting this to not happen:\n\n2024/07/11 18:58:44 INFO provides:\n2024/07/11 18:58:44 INFO so:libgomp.so.1=1\n2024/07/11 18:58:44 INFO so:libitm.so.1=1\n2024/07/11 18:58:44 INFO so:libquadmath.so.0=0\n2024/07/11 18:58:44 INFO so:libssp.so.0=0\n\nAs these libraries are in the private `/usr/lib/gcc/` location, these are not public libraries and should not conflict with `gcc` which ships them publically. As intention is for `gcc-12` to be co-installable with `gcc`.\n\nSeems like we check for `usr/lib/` prefix, but then we have unlimited depth, and subdirs shouldn't typically be included in automatic SCA provides as typically they are outside of the ldconfig.conf paths.\n\n(cc @smoser @imjasonh @jonjohnsonjr )","known_context_document_ids":["gh_issue_2403762914"],"reference_answer":"That sounds right based on the diff. We can fix this today, I don't remember why I exited early on no provides alone.","answer_document_id":"gh_comment_2222965398","silver_evidence_path":["gh_comment_2223557998","gh_issue_2403209917","gh_comment_2222965398"],"evidence_issue_ids":[2403762914,2403209917],"source_repo_name":"chainguard-dev/melange","source_issue_id":2403762914,"source_issue_number":1370,"source_issue_url":"https://github.com/chainguard-dev/melange/issues/1370","target_repo_name":"chainguard-dev/melange","target_issue_id":2403209917,"target_issue_number":1366,"target_issue_url":"https://github.com/chainguard-dev/melange/issues/1366","reference_anchor_document_id":"gh_comment_2223557998","reference_answer_author":"imjasonh","reference_answer_author_association":"MEMBER","quality_score":87.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1538,"anchor_target_overlap":0.3077,"target_answer_overlap":0.0833},"issue_created_at":"2024-07-11T18:02:09+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_2403762914","fragment_type":"issue_description","sequence":0,"text":"Private libs end up in public provides\nyaml\ngcc-12-test-sca.yaml\npackage:\n name: gcc-12-test-sca\n version: 12.4.0\n epoch: 0\n description: \"the GNU compiler collection - version 12\"\n copyright:\n - license: GPL-3.0-or-later\n\nenvironment:\n contents:\n packages:\n - busybox\n - gcc-12\n\npipeline:\n - runs: |\n mkdir -p ${{targets.destdir}}/usr/lib\n cp -r /usr/lib/gcc ${{targets.destdir}}/usr/lib\n\nbuild output:\n\nconsole\n024/07/11 18:58:44 INFO generating package gcc-12-test-sca-12.4.0-r0\n2024/07/11 18:58:44 INFO scanning for shared object dependencies...\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libgomp.so.1.0.0\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libitm.so.1.0.0\n2024/07/11 18:58:44 INFO found lib libm.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libquadmath.so.0.0.0\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libquadmath.so.0.0.0\n2024/07/11 18:58:44 INFO found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libssp.so.0.0.0\n2024/07/11 18:58:44 INFO scanning for commands...\n2024/07/11 18:58:44 INFO scanning for pkg-config data...\n2024/07/11 18:58:44 INFO scanning for python modules...\n2024/07/11 18:58:44 INFO scanning for shbang deps...\n2024/07/11 18:58:44 INFO runtime:\n2024/07/11 18:58:44 INFO so:libc.so.6\n2024/07/11 18:58:44 INFO so:libm.so.6\n2024/07/11 18:58:44 INFO provides:\n2024/07/11 18:58:44 INFO so:libgomp.so.1=1\n2024/07/11 18:58:44 INFO so:libitm.so.1=1\n2024/07/11 18:58:44 INFO so:libquadmath.so.0=0\n2024/07/11 18:58:44 INFO so:libssp.so.0=0\n2024/07/11 18:58:44 INFO installed-size: 74429639\n2024/07/11 18:58:44 INFO data.tar.gz digest: f4370156bd67b791b8c0cb8eb0856a4a25a6a0301cad1f2ee85cfc26aa308e93\n2024/07/11 18:58:44 INFO wrote packages/x86_64/gcc-12-test-sca-12.4.0-r0.apk\n\nExpecting this to not happen:\n\n2024/07/11 18:58:44 INFO provides:\n2024/07/11 18:58:44 INFO so:libgomp.so.1=1\n2024/07/11 18:58:44 INFO so:libitm.so.1=1\n2024/07/11 18:58:44 INFO so:libquadmath.so.0=0\n2024/07/11 18:58:44 INFO so:libssp.so.0=0\n\nAs these libraries are in the private `/usr/lib/gcc/` location, these are not public libraries and should not conflict with `gcc` which ships them publically. As intention is for `gcc-12` to be co-installable with `gcc`.\n\nSeems like we check for `usr/lib/` prefix, but then we have unlimited depth, and subdirs shouldn't typically be included in automatic SCA provides as typically they are outside of the ldconfig.conf paths.\n\n(cc @smoser @imjasonh @jonjohnsonjr )","author_login":"xnox","author_association":"CONTRIBUTOR","created_at":"2024-07-11T18:02:09+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2223557998","fragment_type":"issue_comment","sequence":1,"text":"This bug is the reason why `gcc-12` package uses `no-provides` which intern is buggy w.r.t. turning of depends, see URL","author_login":"xnox","author_association":"CONTRIBUTOR","created_at":"2024-07-11T18:02:52+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[2403209917],"is_known_query_context":false},{"document_id":"gh_comment_2223598757","fragment_type":"issue_comment","sequence":2,"text":"Do you have an idea how many packages list a `provides:` `so:` that's \"private\" today?\n\n(Is \"private\" here being defined as being under a subdirectory in `/usr/lib`?)","author_login":"imjasonh","author_association":"MEMBER","created_at":"2024-07-11T18:19:25+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2223883993","fragment_type":"issue_comment","sequence":3,"text":"Maybe this is helpful. Maybe not. I put together this crappy shell script URL . \n\nI'm going to attach the output in case you find it useful.\nout.d.tar.gz\n\nmore crappy shell scripts with that data can answer your question.","author_login":"smoser","author_association":"CONTRIBUTOR","created_at":"2024-07-11T20:35:38+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2223916191","fragment_type":"issue_comment","sequence":4,"text":"Just checking my understanding: another example of this is `py3-seaborn` which has\n\n-rwxr-xr-x root/root 249696 2024-01-26 10:15 usr/lib/python3.12/site-packages/numpy.libs/libquadmath-96973f99.so.0.0.0\n\nand so has it in its provides:\n\nprovides = so:libquadmath-96973f99.so.0.0.0=0.0.0\n\n URL \n\nIt sounds like that should be detected as a \"vendored\" .so, and not as a provided one. Is that right?","author_login":"imjasonh","author_association":"MEMBER","created_at":"2024-07-11T20:49:21+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2223957722","fragment_type":"issue_comment","sequence":5,"text":"It feels to me like we should only generate provides: for .so files in \"normal\" locations... those that we would put in /etc/ld.so.conf or /etc/so.conf.d/ . If something had a dependency on libquadmath above, then it is extremely unlikely that py-seaborn would successfully provide it.\n\nI feel like there are probably some cases where that is not true, but i would expect those to be outliers. I can imagine that\n * within the same origin package , things might \"know\" to look in additional paths\n * for some well defined/well known plugin architectures there might be paths that are not expected to be added to system search path.","author_login":"smoser","author_association":"CONTRIBUTOR","created_at":"2024-07-11T21:19:37+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225298535","fragment_type":"issue_comment","sequence":6,"text":"py3-seaborn => shouldn't really vendor in numpy, and should really depend on matching py3-numpy.\nAlso our libquadmath currently is not correctly shipped by gcc as a separate package, as that really out to be a separate package for things to depend on at runtime (as in py3-numpy likely should have dependency on so:libquadmath.so which is provided by libquadmath package which is currently empty, because bugs).","author_login":"xnox","author_association":"CONTRIBUTOR","created_at":"2024-07-12T10:36:30+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2816011425","fragment_type":"issue_comment","sequence":7,"text":"I'm closing this with the impression that URL fixed it. If I'm wrong please reopen it and let me know!","author_login":"murraybd","author_association":"CONTRIBUTOR","created_at":"2025-04-18T18:44:20+08:00","repo_name":"chainguard-dev/melange","issue_id":2403762914,"issue_number":1370,"issue_url":"https://github.com/chainguard-dev/melange/issues/1370","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2403209917","fragment_type":"issue_description","sequence":0,"text":"`no-provides` disables SCA depends (aka no-depends)\nI believe this is regression introduced in 2c11e1bfe62b7a5489b526911a9dfea72d740168\n\nExposed in URL by gcc-12 which has `options: no-provides: true` with intention not to provide duplicate / conflicting commands (however, no longer needed as all binaries are uniquely named with suffixes).\n\nHowever the above commit appears to nuke SCA Depends as well as Provides behind the `no-provides` option. \n\nIn URL I expect only provides-only generators to be gated behind \"no-provides\" (as in cmd:providers and pc: provides), and ensure that Deps generators are gated behind \"no-depends\".\n\nTiming matches because gcc-12 was last built in December 2023, and rebuilt only just recently, hence the January 2024 change in melange has potentially been missbuilding a few packages, or some packages started to rely on the fact that \"no-provides\" has been implying \"no-depends\" since January.\n\ncc: @smoser @pnasrat @imjasonh @jonjohnsonjr","author_login":"xnox","author_association":"CONTRIBUTOR","created_at":"2024-07-11T13:35:08+08:00","repo_name":"chainguard-dev/melange","issue_id":2403209917,"issue_number":1366,"issue_url":"https://github.com/chainguard-dev/melange/issues/1366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2222965398","fragment_type":"issue_comment","sequence":1,"text":"That sounds right based on the diff. We can fix this today, I don't remember why I exited early on no provides alone.","author_login":"imjasonh","author_association":"MEMBER","created_at":"2024-07-11T13:37:40+08:00","repo_name":"chainguard-dev/melange","issue_id":2403209917,"issue_number":1366,"issue_url":"https://github.com/chainguard-dev/melange/issues/1366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2222966862","fragment_type":"issue_comment","sequence":2,"text":"no rush, but need to analyse how many packages are affected/regressed/depend on this behaviour.","author_login":"xnox","author_association":"CONTRIBUTOR","created_at":"2024-07-11T13:38:14+08:00","repo_name":"chainguard-dev/melange","issue_id":2403209917,"issue_number":1366,"issue_url":"https://github.com/chainguard-dev/melange/issues/1366","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2222968340","fragment_type":"issue_comment","sequence":3,"text":"diff\n$ git diff busybox.yaml\ndiff --git a/busybox.yaml b/busybox.yaml\nindex 9fc1bf145..2a16aa839 100644\n--- a/busybox.yaml\n+++ b/busybox.yaml\n@@ -1,12 +1,14 @@\n package:\n name: busybox\n version: 1.36.1\n- epoch: 10\n+ epoch: 11\n description: \"swiss-army knife for embedded systems\"\n copyright:\n - license: GPL-2.0-only\n dependencies:\n provider-priority: 10\n+ options:\n+ no-provides: true\n scriptlets:\n trigger:\n paths:\n\nis reproducer, after applying this - `make package/busybox test/busybox` fails with missing runtime libraries.","author_login":"xnox","author_association":"CONTRIBUTOR","created_at":"2024-07-11T13:38:47+08:00","repo_name":"chainguard-dev/melange","issue_id":2403209917,"issue_number":1366,"issue_url":"https://github.com/chainguard-dev/melange/issues/1366","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0467","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Importing 24 word seed phrase throws \"Language not detected\" error?","query_context":"**Describe the bug**\nWhen importing a 24 word seed phrase as Bitcoin core hot wallet, instead of creating the \"device\" it will throw a language not detected error. \n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Go to 'Add New Device'\n2. Click on 'Bitcoin Core'\n3. Select 'Import'\n4. Paste 24 word seed phrase\n5. Click 'Continue'\n\n**Expected behavior**\nThe device should be created.\n\n**Screenshots**\nimage\n\n**Desktop (please complete the following information):**\n - Where is your node running: umbrel\n - Where is your specter running: umbrel\n - If you're running a binary, which OS: Linux\n - Browser: Brave\n - Specter Version: v1.14.3\n\n**Additional context**\nI tried separating the words with whitespace and newline but either attempt failed. I'm using the English dictionary.\n\nActually, when using newline => `Language not detected`\nwhen using whitespace => `ERROR: Invalid mnemonic entered.`","known_context_document_ids":["gh_issue_1536756716"],"reference_answer":"Just saw that you used the english language. So i just tried to reproduce on the master branch with \n\nghost ghost ghost ghost ghost ghost ghost ghost ghost ghost ghost machine\n\nThat worked without an issue. Can you test that?!","answer_document_id":"gh_comment_1398194497","silver_evidence_path":["gh_comment_1398182592","gh_issue_1195481802","gh_comment_1398194497"],"evidence_issue_ids":[1536756716,1195481802],"source_repo_name":"cryptoadvance/specter-desktop","source_issue_id":1536756716,"source_issue_number":2064,"source_issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","target_repo_name":"cryptoadvance/specter-desktop","target_issue_id":1195481802,"target_issue_number":1658,"target_issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/1658","reference_anchor_document_id":"gh_comment_1398182592","reference_answer_author":"k9ert","reference_answer_author_association":"COLLABORATOR","quality_score":81.81,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0851,"anchor_target_overlap":0.5745,"target_answer_overlap":0.0},"issue_created_at":"2023-01-17T17:18:50+08:00","valid_comment_count":14,"fragments":[{"document_id":"gh_issue_1536756716","fragment_type":"issue_description","sequence":0,"text":"Importing 24 word seed phrase throws \"Language not detected\" error\n**Describe the bug**\nWhen importing a 24 word seed phrase as Bitcoin core hot wallet, instead of creating the \"device\" it will throw a language not detected error. \n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Go to 'Add New Device'\n2. Click on 'Bitcoin Core'\n3. Select 'Import'\n4. Paste 24 word seed phrase\n5. Click 'Continue'\n\n**Expected behavior**\nThe device should be created.\n\n**Screenshots**\nimage\n\n**Desktop (please complete the following information):**\n - Where is your node running: umbrel\n - Where is your specter running: umbrel\n - If you're running a binary, which OS: Linux\n - Browser: Brave\n - Specter Version: v1.14.3\n\n**Additional context**\nI tried separating the words with whitespace and newline but either attempt failed. I'm using the English dictionary.\n\nActually, when using newline => `Language not detected`\nwhen using whitespace => `ERROR: Invalid mnemonic entered.`","author_login":"aphex3k","author_association":"CONTRIBUTOR","created_at":"2023-01-17T17:18:50+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1385776636","fragment_type":"issue_comment","sequence":1,"text":"Here is why I think it is not working: The seed phrase is used by a core wallet already known/loaded to bitcoin core but not by specter desktop but a different software. The error is a little but misleading.","author_login":"aphex3k","author_association":"CONTRIBUTOR","created_at":"2023-01-17T17:28:33+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1386068799","fragment_type":"issue_comment","sequence":2,"text":"Talk to Ledgerwallet Support on the Live support chat so that your issue can be looked into.","author_login":"mark-EthDev","author_association":"NONE","created_at":"2023-01-17T21:23:21+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1386081960","fragment_type":"issue_comment","sequence":3,"text":"The above comment is a SCAM link! Do not follow the link. Block/Report the user.","author_login":"aphex3k","author_association":"CONTRIBUTOR","created_at":"2023-01-17T21:35:14+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398182592","fragment_type":"issue_comment","sequence":4,"text":"#1658 seems related. There can also be a stacktrace be found:\n\nTraceback (most recent call last):\n File \"flask\\app.py\", line 1950, in full_dispatch_request\n File \"flask\\app.py\", line 1936, in dispatch_request\n File \"flask_login\\utils.py\", line 269, in decorated_view\n File \"cryptoadvance\\specter\\server_endpoints\\devices.py\", line 207, in new_device_mnemonic\n File \"cryptoadvance\\specter\\util\\mnemonic.py\", line 42, in validate_mnemonic\n File \"mnemonic\\mnemonic.py\", line 115, in detect_language\nmnemonic.mnemonic.ConfigurationError: Language not detected\n\nThat feature has been implemented in fc6521f and c3ae3d9 . I don't think all languages are supported and i guess the error-message and UX should be improved here.\n@moneymanolis can you qualify that better?","author_login":"k9ert","author_association":"COLLABORATOR","created_at":"2023-01-20T10:19:59+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[1195481802],"is_known_query_context":false},{"document_id":"gh_comment_1398195022","fragment_type":"issue_comment","sequence":5,"text":"Just saw that you used the english language. So i just tried to reproduce on the master branch with \n\nghost ghost ghost ghost ghost ghost ghost ghost ghost ghost ghost machine\n\nThat worked without an issue. Can you test that?!","author_login":"k9ert","author_association":"COLLABORATOR","created_at":"2023-01-20T10:31:49+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398300287","fragment_type":"issue_comment","sequence":6,"text":"Here is the link to the error from the upstream library from Trezor:\n URL \n \n\nDo you have a stacktrace?\n\nIf it looks like the one @k9ert posted (below again) it's rather unlikely. I am tagging @prusnak perhaps he can help us here to see in which direction to investigate.\n\nTraceback (most recent call last):\n File \"flask\\app.py\", line 1950, in full_dispatch_request\n File \"flask\\app.py\", line 1936, in dispatch_request\n File \"flask_login\\utils.py\", line 269, in decorated_view\n File \"cryptoadvance\\specter\\server_endpoints\\devices.py\", line 207, in new_device_mnemonic\n File \"cryptoadvance\\specter\\util\\mnemonic.py\", line 42, in validate_mnemonic\n File \"mnemonic\\mnemonic.py\", line 115, in detect_language\nmnemonic.mnemonic.ConfigurationError: Language not detected","author_login":"moneymanolis","author_association":"COLLABORATOR","created_at":"2023-01-20T12:14:56+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398302780","fragment_type":"issue_comment","sequence":7,"text":"@aphex3k just to make sure, all the words you use are from the BIP39 list and the checksum is correct?\nYou could check this by entering it on a signing device for example. If you are just testing around you can double-check here as well:\n URL","author_login":"moneymanolis","author_association":"COLLABORATOR","created_at":"2023-01-20T12:16:22+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398319804","fragment_type":"issue_comment","sequence":8,"text":"`detect_language` only uses the first word, so it would be best idea to share just the first word to narrow down the investigation","author_login":"prusnak","author_association":"NONE","created_at":"2023-01-20T12:34:10+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398648556","fragment_type":"issue_comment","sequence":9,"text":"first word in the mnemonic I tried is `about` but it looks like my seed is invalid anyways? I'm checking...","author_login":"aphex3k","author_association":"CONTRIBUTOR","created_at":"2023-01-20T16:43:38+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398658808","fragment_type":"issue_comment","sequence":10,"text":"My bad, apparently the mnemonic I tried is not BIP39. This can be closed...","author_login":"aphex3k","author_association":"CONTRIBUTOR","created_at":"2023-01-20T16:51:29+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1536756716,"issue_number":2064,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/2064","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1195481802","fragment_type":"issue_description","sequence":0,"text":"Error adding Bitcoin Core (hot wallet) Device Type\nTraceback (most recent call last):\n File \"flask\\app.py\", line 1950, in full_dispatch_request\n File \"flask\\app.py\", line 1936, in dispatch_request\n File \"flask_login\\utils.py\", line 269, in decorated_view\n File \"cryptoadvance\\specter\\server_endpoints\\devices.py\", line 207, in new_device_mnemonic\n File \"cryptoadvance\\specter\\util\\mnemonic.py\", line 42, in validate_mnemonic\n File \"mnemonic\\mnemonic.py\", line 115, in detect_language\nmnemonic.mnemonic.ConfigurationError: Language not detected","author_login":"sponge-b0b","author_association":"NONE","created_at":"2022-04-07T03:47:29+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1195481802,"issue_number":1658,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/1658","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091493786","fragment_type":"issue_comment","sequence":1,"text":"Which browser are you using on which operating system? Seems like your language-setup is somehow screwed?","author_login":"k9ert","author_association":"COLLABORATOR","created_at":"2022-04-07T10:13:04+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1195481802,"issue_number":1658,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/1658","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092145905","fragment_type":"issue_comment","sequence":2,"text":"OS: Windows 10 Home 64-Bit\nVersion: 10.0.19043 Build 19043\n\nBrowser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0\nBuild ID: 20220330194208","author_login":"sponge-b0b","author_association":"NONE","created_at":"2022-04-07T19:57:28+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1195481802,"issue_number":1658,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/1658","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1092554654","fragment_type":"issue_comment","sequence":3,"text":"Sorry, my fault. This has nothing to do with the browser but with the seed-words. BIP39 allows the seed words to be in different languages. You don't specify the language when you write in the seed words. So the algorithm gets the first word from your list and tries to find them in the different lists. That's the way the language is detected.\n\nSo in you case it could not find the first word in any of these lists. Please double-check!","author_login":"k9ert","author_association":"COLLABORATOR","created_at":"2022-04-08T07:46:04+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1195481802,"issue_number":1658,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/1658","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1398194497","fragment_type":"issue_comment","sequence":4,"text":"Just saw that you used the english language. So i just tried to reproduce on the master branch with \n\nghost ghost ghost ghost ghost ghost ghost ghost ghost ghost ghost machine\n\nThat worked without an issue. Can you test that?!","author_login":"k9ert","author_association":"COLLABORATOR","created_at":"2023-01-20T10:31:16+08:00","repo_name":"cryptoadvance/specter-desktop","issue_id":1195481802,"issue_number":1658,"issue_url":"https://github.com/cryptoadvance/specter-desktop/issues/1658","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0468","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"PCRE2 support?","query_context":"Does this package support PCRE2? Reading the code I can’t see any reference to PCRE2. Do you have any knowledge of another Haskell package with pcre2 support?","known_context_document_ids":["gh_issue_558555479"],"reference_answer":"Thanks for the report.\n\nI have no intuition about what the issue is. Maybe dig into uses of `Text.fromPtr`, `Text.copy`, `Text.dropWhile8`, `Text.useAsPtr`, etc.\n\nThat's great you got use out of the library for Ormolu, at least for a little while! ❤️","answer_document_id":"gh_comment_1371787158","silver_evidence_path":["gh_comment_2156434501","gh_issue_1519665110","gh_comment_1371787158"],"evidence_issue_ids":[558555479,1519665110],"source_repo_name":"haskell-hvr/regex-pcre","source_issue_id":558555479,"source_issue_number":1,"source_issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","target_repo_name":"sjshuck/hs-pcre2","target_issue_id":1519665110,"target_issue_number":34,"target_issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","reference_anchor_document_id":"gh_comment_2156434501","reference_answer_author":"sjshuck","reference_answer_author_association":"OWNER","quality_score":85.63,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1905,"target_answer_overlap":0.0526},"issue_created_at":"2020-02-01T15:27:11+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_558555479","fragment_type":"issue_description","sequence":0,"text":"PCRE2 support?\nDoes this package support PCRE2? Reading the code I can’t see any reference to PCRE2. Do you have any knowledge of another Haskell package with pcre2 support?","author_login":"robwithhair","author_association":"NONE","created_at":"2020-02-01T15:27:11+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2156390956","fragment_type":"issue_comment","sequence":1,"text":"Hi! :wave: \n\nI package pcre2 for Arch Linux. Since pcre is unmaintained we are working on moving to pcre2.\n@sjshuck from what I understand after reading your comment, some (but probably not all) projects in the haskell ecosystem could start relying on your package instead without huge switching costs?","author_login":"dvzrv","author_association":"NONE","created_at":"2024-06-09T08:32:13+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2156434501","fragment_type":"issue_comment","sequence":2,"text":"@dvzrv\n\nThere is an outstanding low-level bug that caused segfaults in the Ormolu project and required the authors to switch away from the library. While it's been an ambition of mine to eventually return to hs-pcre2, life has taken me in other directions in the past few years.\n\nThis does make me want to return to it; IMHO it's a good library, it just needs some attention. I can't give a time frame right now but I did want to be up front about the state of hs-pcre2.","author_login":"sjshuck","author_association":"NONE","created_at":"2024-06-09T10:33:37+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[1519665110],"is_known_query_context":false},{"document_id":"gh_comment_2277414347","fragment_type":"issue_comment","sequence":3,"text":"Is it difficult to enable pcre2 as backend for this package? sjshuck/hs-pcre2.git is interesting with its compile-time checks, but it misses `regex-base` compatibility.","author_login":"amigalemming","author_association":"NONE","created_at":"2024-08-09T08:18:11+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2283774899","fragment_type":"issue_comment","sequence":4,"text":"@amigalemming ultimately I ended up writing my own package as needed subset of pcre2 capabilities. It is only as complete as I needed for my personal project needs and I was much worse at Haskell back then so very beginner stuff, but you can find it here hpcre2. I found the foreign function interface in Haskell a lot easier than I was concerned about. Ultimately it was not as difficult as I thought to follow the pcre2 docs and code against them as a C library interface. I'm sure if I was writing it now I would have done very differently now I'm more experienced in Haskell but I had a problem to solve and got it done. \n\nI did try to get this added to hackage at some point but it was too time consuming to do. Now it is largely present as a reference for if others need to do the same thing.","author_login":"robwithhair","author_association":"NONE","created_at":"2024-08-12T11:58:25+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571678690","fragment_type":"issue_comment","sequence":5,"text":"To directly answer your question @dvzrv, in theory that could happen but the API is completely different than this library; even the smallest use sites will incur a switching cost, so if the ecosystem did that then yes, that would be huge in aggregate.\n\nPerhaps the path of least resistance will be to create a regex-pcre2 that implements regex-base. That's not a goal of mine right now but that can change.","author_login":"sjshuck","author_association":"NONE","created_at":"2025-01-05T16:21:56+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2653512244","fragment_type":"issue_comment","sequence":6,"text":"I've had a quick look at this and it seems that it's not so much work to get this working with pcre2. I'll likely send a pull request in the next few days.","author_login":"peteryland","author_association":"NONE","created_at":"2025-02-12T12:02:10+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2667252528","fragment_type":"issue_comment","sequence":7,"text":"regex-pcre2 is now on Hackage and soon hopefully on Stackage as well. It links against libpcre2.","author_login":"peteryland","author_association":"NONE","created_at":"2025-02-19T00:53:22+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2693433604","fragment_type":"issue_comment","sequence":8,"text":"Excellent, thanks a lot, @peteryland !\nI link to your new package from the (new) README here.","author_login":"andreasabel","author_association":"MEMBER","created_at":"2025-03-03T06:48:49+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2693934277","fragment_type":"issue_comment","sequence":9,"text":"Well done @peteryland what a milestone! Really appreciate your efforts and know it will make a difference for so many Haskell regex projects. Much appreciated.","author_login":"robwithhair","author_association":"NONE","created_at":"2025-03-03T10:35:16+08:00","repo_name":"haskell-hvr/regex-pcre","issue_id":558555479,"issue_number":1,"issue_url":"https://github.com/haskell-hvr/regex-pcre/issues/1","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1519665110","fragment_type":"issue_description","sequence":0,"text":"`Data.Text.Array.new: size overflow`\nSorry for this report being very non-minimally reproducible, please don't feel obligated to act on this in any way.\n\nWe are using hs-pcre2 to extract some information from the Hackage Hoogle database (500MB, 70k files): relevant function, and see this script for how to execute the app (this is Nix-based and hence fully reproducible, but it should be rather easily adaptable to not rely on Nix).\n\nAt some point (it still worked in May), the app started to crash after processing a few thousand files:\n\nextract-hackage-info: Data.Text.Array.new: size overflow\nCallStack (from HasCallStack):\n error, called at src/Data/Text/Array.hs:82:20 in text-1.2.5.0-B336hruu8LkEc19BqHCzAw:Data.Text.Array\n\nThis happens both with hs-pcre2 2.1.1.1 and 2.2.1 (so text-1.2 and text-2.0), but the error message for the latter goes like this:\n\nextract-hackage-info: Out of memory\n\nI replaced hs-pcre2 by megaparsec in URL which makes the error go away, so we are not blocked on this and I didn't investigate further what exactly is going on with hs-pcre2. But maybe this is still interesting to you or is ringing some bell.","author_login":"amesgen","author_association":"CONTRIBUTOR","created_at":"2023-01-04T22:27:06+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371787158","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the report.\n\nI have no intuition about what the issue is. Maybe dig into uses of `Text.fromPtr`, `Text.copy`, `Text.dropWhile8`, `Text.useAsPtr`, etc.\n\nThat's great you got use out of the library for Ormolu, at least for a little while! ❤️","author_login":"sjshuck","author_association":"OWNER","created_at":"2023-01-05T05:07:01+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1371796492","fragment_type":"issue_comment","sequence":2,"text":"URL \nJust a remark: It's funny that `Data.Text.Array.new` takes a signed `Int` for size, _and_ calls it \"overflow\" when it's negative.","author_login":"sjshuck","author_association":"OWNER","created_at":"2023-01-05T05:24:50+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2218657766","fragment_type":"issue_comment","sequence":3,"text":"The way to debug it is to build `text` with `developer` flag enabled. In order to force Cabal into doing so, pin a version of `text` which **mismatches** a boot package for GHC in use.\n\nAlso pass `--ghc-options='-fcheck-prim-bounds -fno-ignore-asserts'`.\n\nAlso you can fork `text` locally and start adding `HasCallStack` constraints to track the provenance of the error.\n\nI'm curious if the error is still reproducible.","author_login":"Bodigrim","author_association":"NONE","created_at":"2024-07-09T20:18:40+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2219231570","fragment_type":"issue_comment","sequence":4,"text":"I had another look, and I can still reproduce this (as described in the issue description; but I think it can be minimized somewhat, at the very least getting rid of the huge `ghc-lib-parser` dependency).\n\nBuilding with profiling and `+RTS -xc` for stack traces as well as enabling the `developer` flag as suggested by @Bodigrim pointed to the following issue:\n\nStack trace:\n\n *** Exception (reporting due to +RTS -xc): (THUNK_2_0), stack trace:\n Data.Text.Array.CAF\n --> evaluated by: Text.Regex.Pcre2.Internal.getErrorMessage,\n called from Text.Regex.Pcre2.Internal.check,\n called from Text.Regex.Pcre2.Internal.fix1,\n called from Text.Regex.Pcre2.Internal.matcherWithEnv,\n called from Text.Regex.Pcre2.Internal.pureUserMatcher,\n called from Text.Regex.Pcre2.TH.memoMatcher,\n called from Text.Regex.Pcre2.Internal.mapMS,\n called from Text.Regex.Pcre2.Internal._gcaptures,\n called from Text.Regex.Pcre2.TH._capturesTH,\n called from Text.Regex.Pcre2.Internal.toAlternativeOf,\n called from Text.Regex.Pcre2.TH.capturesTH,\n called from Main.extractFixitiesFromFile,\n called from Main.extractHoogleInfo,\n called from Main.main\n\nWith a few more manually inserted `putStrLn`s, it turns out that this is the offending line:\n URL \nHere, `cus` is `-29`, which corresponds to `PCRE2_ERROR_BADDATA`, which is returned by `pcre2_get_error_message` here URL \nbecause of this:\n \n\nThis in turn is because in `matcherWithEnv` here\n URL \nwe check whether `result` is positive, and throw an exception (which prints the error message) otherwise. Now the question is why `result` is non-positive. In fact, it is equal to `0`, as a result of a call to `pcre2_match`:\n URL \nFrom the docs (emphasis mine):\n \n\nThis is where I am stopping for now, as I am not at all familiar with the PCRE2 C API.\n\n---\n\nThe pattern in question is\n\n(?m)^\\\\s*?(? infix[rl]?)\\\\s+?(? [0-9])\\\\s+?(? (?:[^,\\\\s]+\\\\s*?,\\\\s*?)*?[^,\\\\s]+)\\\\s*$\n\nin case that is useful; I have tried to produce a minimal example of matching this pattern against the subject text, but I couldn't reproduce the error there.\n\n---\n\nBTW: \n \n\nA less hacky way to accomplish this is to use the following in your `cabal.project`:\n\ncabal\nconstraints: text source","author_login":"amesgen","author_association":"CONTRIBUTOR","created_at":"2024-07-10T00:50:56+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2221659381","fragment_type":"issue_comment","sequence":5,"text":"Could it be a pcre2 bug then? Looking at URL it seems we are doing everything by the book: allocate offset vector with `pcre2_match_data_create_from_pattern`, then pass it to `pcre2_match`.","author_login":"Bodigrim","author_association":"NONE","created_at":"2024-07-10T22:53:47+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2221697487","fragment_type":"issue_comment","sequence":6,"text":"I updated the PCRE2 submodule from 10.42 to 10.44 just now. Wonder if that makes a difference.","author_login":"sjshuck","author_association":"OWNER","created_at":"2024-07-10T23:26:23+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2221718396","fragment_type":"issue_comment","sequence":7,"text":"Hmm, when I build with\n\ncabal\nconstraints: text source\npackage text\n flags: +developer\n\nand hs-pcre2 2.1.1 from Hackage, I get\n\nextract-hackage-info: Data.Text.Array.new: size overflow\nCallStack (from HasCallStack):\n error, called at src/Data/Text/Array.hs:74:19 in text-2.0.2-f5aebd26e19e5a1c2907d840502e1f413aa9a5057431546d415964b124f1ffd2:Data.Text.Array\n\nIf I instead build from recent `master` commits (tried 2d01498056569905abc643fdffa697efbbd6c08c and 8ac889a7e0e26564f663f1edd2bffce9bbcb6f65, so with PCRE2 10.44 and 10.42), I instead get\n\nmalloc(): unsorted double linked list corrupted\nfish: Job 1, 'cabal run extract-hackage-info …' terminated by signal SIGABRT (Abort)\n\nor sometimes also\n\nmalloc(): mismatching next->prev_size (unsorted)\n\nMaybe the investigation I posted above is a red herring, and there is some nasty undefined behavior going on in pcre2 :thinking:","author_login":"amesgen","author_association":"CONTRIBUTOR","created_at":"2024-07-10T23:45:56+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2223688620","fragment_type":"issue_comment","sequence":8,"text":"URL suggests that both `malloc()` failures mean memory corruption.","author_login":"Bodigrim","author_association":"NONE","created_at":"2024-07-11T19:06:03+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571406195","fragment_type":"issue_comment","sequence":9,"text":"Debugging with a custom `malloc()` and `free()`, I am definitely seeing that `free()` is being called on unallocated addresses.\n\nIt happens\n* a variable number of times for a test of #39 (often but not always segfaulting), and\n* exactly twice for the sub callout test","author_login":"sjshuck","author_association":"OWNER","created_at":"2025-01-04T20:39:45+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2571521898","fragment_type":"issue_comment","sequence":10,"text":"Okay, after analyzing lifecycles of `Ptr`s I've narrowed this down a lot.\n\nIt's a use-after-`free()` of `pcre2_match_data` in this streaming function.\n\nRunning a test of #39 (in the above branch) produces this output. This is what I get 99% of the time. Note the last two lines.\n\nFailures:\n\n src/hs/Text/Regex/Pcre2/Internal.hs:969:38:\n 1) basic matching produces well-formed UTF-8 matches ( URL \n uncaught exception: ErrorCall\n ****** Using deallocated 0x00007836a8000f70 for pcre2_get_ovector_pointer ******\n malloc() for pcre2_match_data\n using for pcre2_match\n using for streamYield\n using for pcre2_get_ovector_pointer\n using for pcre2_get_ovector_pointer\n ...\n using for pcre2_get_ovector_pointer\n using for pcre2_get_ovector_pointer\n using for pcre2_match\n using for streamYield\n free() for pcre2_match_data\n using for pcre2_get_ovector_pointer\n\nI'm expecting that `withForeignPtr` will keep alive the `matchData :: ForeignPtr Pcre2_match_data`, and thus postpone the finalizer (`pcre2_match_data_free`), until the `ForeignPtr` is unreachable. Well, I think that was a reasonable expectation, except the `ForeignPtr` is unreachable a lot sooner than the underlying `Ptr` is unreachable. See this warning.","author_login":"sjshuck","author_association":"OWNER","created_at":"2025-01-05T06:42:49+08:00","repo_name":"sjshuck/hs-pcre2","issue_id":1519665110,"issue_number":34,"issue_url":"https://github.com/sjshuck/hs-pcre2/issues/34","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0469","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"No way to configure ALPN settings?","query_context":"Hi, while trying to use `rustls-acme` with `tonic`, we ran into problems that I think are related to not having the ability to configure `rustls` ALPN settings. (Full context is here: URL \n\nCurrently, the `rustls-acme` API doesn't allow setting `rustls` `ServerConfig` at all.\n\nWould it be preferable to expose the entire `ServerConfig` as part of the `AcmeConfig` builder API, or just the ALPN settings?","known_context_document_ids":["gh_issue_1664104480"],"reference_answer":"It's been a while, I'll close here, assuming there's no interest anymore. Feel free to reopen.","answer_document_id":"gh_comment_1761425453","silver_evidence_path":["gh_comment_1505864814","gh_issue_1665180471","gh_comment_1761425453"],"evidence_issue_ids":[1664104480,1665180471],"source_repo_name":"FlorianUekermann/rustls-acme","source_issue_id":1664104480,"source_issue_number":37,"source_issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/37","target_repo_name":"FlorianUekermann/rustls-acme","target_issue_id":1665180471,"target_issue_number":38,"target_issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/38","reference_anchor_document_id":"gh_comment_1505864814","reference_answer_author":"FlorianUekermann","reference_answer_author_association":"OWNER","quality_score":73.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.0714,"target_answer_overlap":0.0},"issue_created_at":"2023-04-12T08:34:02+08:00","valid_comment_count":6,"fragments":[{"document_id":"gh_issue_1664104480","fragment_type":"issue_description","sequence":0,"text":"No way to configure ALPN settings\nHi, while trying to use `rustls-acme` with `tonic`, we ran into problems that I think are related to not having the ability to configure `rustls` ALPN settings. (Full context is here: URL \n\nCurrently, the `rustls-acme` API doesn't allow setting `rustls` `ServerConfig` at all.\n\nWould it be preferable to expose the entire `ServerConfig` as part of the `AcmeConfig` builder API, or just the ALPN settings?","author_login":"hdevalence","author_association":"NONE","created_at":"2023-04-12T08:34:02+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1664104480,"issue_number":37,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/37","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1504981816","fragment_type":"issue_comment","sequence":1,"text":"Thanks for the opening the issue. Note that `AcmeConfig` is used for both the low level and high level API in `rustls-acme`. That's why it only offers configuration of acme related things. With the low level API you should be able to do what you want already (have a look at the `low_level*.rs` examples).\n\nBut I do think it would be nice to offer at least basic alpn control via the simple API (on `Incoming`).\n1. The most we can do here is allow the user to provide a `rustls_config` and simply overwrite the resolver. That would also cover other rustls config changes the user wants to make.\n2. Or we could let the user specify the alpn parameters at construction (`AcmeState::incoming_with_alpn(self, cb: Fn(rustls::ClientHello) -> ...)`)\n\nMaybe both. I'll see what I can come up with today. If you try the low level api and run into problems or have opinions/suggestions regarding the above, let me know.","author_login":"FlorianUekermann","author_association":"OWNER","created_at":"2023-04-12T09:47:21+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1664104480,"issue_number":37,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505276779","fragment_type":"issue_comment","sequence":2,"text":"I added an `alpn_protocols` argument to all functions that construct `Incoming`, which makes this available in the high-level api.\n`rustls-acme = { git = \" URL }`\n\nIn the long run I'm considering merging the low- and high-level APIs, by making the stream emit something similar to rustls::server::Accepted, which the user can turn into a stream using their own config. That would side-step the whole issue. But it is good to get this out the door first, so there's something to compare the new API to during development.\n\nPlease let me know if this works for you and if you have any usability concerns, so I can tag a release asap.","author_login":"FlorianUekermann","author_association":"OWNER","created_at":"2023-04-12T13:26:52+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1664104480,"issue_number":37,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505793258","fragment_type":"issue_comment","sequence":3,"text":"Amazing, thanks so much! We tested with a fork where we just hardcoded in ALPN settings and got things working, we'll try the patch now and let you know if it works.","author_login":"hdevalence","author_association":"NONE","created_at":"2023-04-12T19:12:46+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1664104480,"issue_number":37,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/37","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505864814","fragment_type":"issue_comment","sequence":4,"text":"We've tested and this works for us! If you'd be interested in #38, we could also submit a PR for that so you'd only have to do one release, but we'd also be happy to do that later if you'd prefer more deliberation. Whatever works.","author_login":"hdevalence","author_association":"NONE","created_at":"2023-04-12T20:11:42+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1664104480,"issue_number":37,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/37","linked_issue_ids":[1665180471],"is_known_query_context":false},{"document_id":"gh_issue_1665180471","fragment_type":"issue_description","sequence":0,"text":"Add an optional `tonic` feature with tonic compatibility helpers?\nWe're using `rustls-acme` with `tonic`, and so far we wrote a some boilerplatey code to hook up `rustls-acme` to Tonic's batteries-included server implementation.\n\nIf we extracted that code and submitted a PR, would you be interested in upstreaming it under a feature flag?\n\nI'm imagining implementing an extension trait, say `AcmeTonicExt`, so that instead of writing\n\nrust\nServer::builder()\n .add_service(/* ... */)\n .add_service(/* ... */)\n .serve(addr)\n\nfor an http server, it would be possible to write\n\nrust\nServer::builder()\n .add_service(/* ... */)\n .add_service(/* ... */)\n .serve_with_acme_tls(addr, acme_config)\n\nfor an auto-https server. The `serve_with_acme_tls` method would be provided by the extension trait, and handle gluing the `rustls-acme` methods to the `tonic` `serve_with_incoming` method.","author_login":"hdevalence","author_association":"NONE","created_at":"2023-04-12T20:09:33+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1665180471,"issue_number":38,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/38","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1506008148","fragment_type":"issue_comment","sequence":1,"text":"I'm definitely open to this. I'm not familiar with tonic, but if you send a PR or a more detailed sketch I'll happily review.","author_login":"FlorianUekermann","author_association":"OWNER","created_at":"2023-04-12T21:52:34+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1665180471,"issue_number":38,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/38","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1761425453","fragment_type":"issue_comment","sequence":2,"text":"It's been a while, I'll close here, assuming there's no interest anymore. Feel free to reopen.","author_login":"FlorianUekermann","author_association":"OWNER","created_at":"2023-10-13T12:20:34+08:00","repo_name":"FlorianUekermann/rustls-acme","issue_id":1665180471,"issue_number":38,"issue_url":"https://github.com/FlorianUekermann/rustls-acme/issues/38","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0470","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Vscode does not persist workspace state on closing?","query_context":"Related issue - #160077\n\nSystem Configuration\n- macOS Sonoma - Version 14.5 (23F79)\n- Apple M3 Chip\n\nVscode\n- Version: 1.91.0 (Universal)\n- Date: 2024-07-01T18:54:18.541Z (4 days ago)\n- Electron: 29.4.0\n- ElectronBuildId: 9728852\n- Chromium: 122.0.6261.156\n- Node.js: 20.9.0\n- V8: 12.2.281.27-electron.0\n- OS: Darwin arm64 23.5.0\n\nIssue - when closing VSCode via \"cmd + w\" / red-close button via GUI(this way of closing is the regular way) the previously opened folders/workspaces are not persisted when re-opening VSCode\n\nInstead after reopen every time the \"Welcome page\" is opened and all previous file changes / opened folders are lost and need to open them again.\n\nIf instead the VSCode window is closed via \"cmd + q\" / right-click -> quit via GUI then the workspaces / opened files are persisted on the next open, so the issue is only for \"cmd + w\" / close button quit.\n\nExpected: - \nPreviously opened workspaces / files should persist on close and reopen when reopening VSCode.\n\nActual: -\nPreviously opened workspaces / files are not persisted when closing VSCode, instead \"Welcome page\" opens everytime.","known_context_document_ids":["gh_issue_2393453354"],"reference_answer":"Hey @joaomoreno, this issue might need further attention.\n\n@degtiaan, you can help us out by closing this issue if the problem no longer exists, or adding more information.","answer_document_id":"gh_comment_2129293730","silver_evidence_path":["gh_comment_2232004074","gh_issue_2140184133","gh_comment_2129293730"],"evidence_issue_ids":[2393453354,2140184133],"source_repo_name":"microsoft/vscode","source_issue_id":2393453354,"source_issue_number":220140,"source_issue_url":"https://github.com/microsoft/vscode/issues/220140","target_repo_name":"microsoft/vscode","target_issue_id":2140184133,"target_issue_number":205440,"target_issue_url":"https://github.com/microsoft/vscode/issues/205440","reference_anchor_document_id":"gh_comment_2232004074","reference_answer_author":"VSCodeTriageBot","reference_answer_author_association":"COLLABORATOR","quality_score":94.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3571,"anchor_target_overlap":0.2857,"target_answer_overlap":0.0667},"issue_created_at":"2024-07-06T07:28:48+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_2393453354","fragment_type":"issue_description","sequence":0,"text":"Vscode does not persist workspace state on closing\nRelated issue - #160077\n\nSystem Configuration\n- macOS Sonoma - Version 14.5 (23F79)\n- Apple M3 Chip\n\nVscode\n- Version: 1.91.0 (Universal)\n- Date: 2024-07-01T18:54:18.541Z (4 days ago)\n- Electron: 29.4.0\n- ElectronBuildId: 9728852\n- Chromium: 122.0.6261.156\n- Node.js: 20.9.0\n- V8: 12.2.281.27-electron.0\n- OS: Darwin arm64 23.5.0\n\nIssue - when closing VSCode via \"cmd + w\" / red-close button via GUI(this way of closing is the regular way) the previously opened folders/workspaces are not persisted when re-opening VSCode\n\nInstead after reopen every time the \"Welcome page\" is opened and all previous file changes / opened folders are lost and need to open them again.\n\nIf instead the VSCode window is closed via \"cmd + q\" / right-click -> quit via GUI then the workspaces / opened files are persisted on the next open, so the issue is only for \"cmd + w\" / close button quit.\n\nExpected: - \nPreviously opened workspaces / files should persist on close and reopen when reopening VSCode.\n\nActual: -\nPreviously opened workspaces / files are not persisted when closing VSCode, instead \"Welcome page\" opens everytime.","author_login":"CoderSleek","author_association":"NONE","created_at":"2024-07-06T07:28:48+08:00","repo_name":"microsoft/vscode","issue_id":2393453354,"issue_number":220140,"issue_url":"https://github.com/microsoft/vscode/issues/220140","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2217945577","fragment_type":"issue_comment","sequence":1,"text":"also having this issue! M3 Chip with Sonoma 14.5, very very annoying.","author_login":"brunozalc","author_association":"NONE","created_at":"2024-07-09T14:55:27+08:00","repo_name":"microsoft/vscode","issue_id":2393453354,"issue_number":220140,"issue_url":"https://github.com/microsoft/vscode/issues/220140","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2232004074","fragment_type":"issue_comment","sequence":2,"text":"I have the same issue staring from Vscode release 1.86.2 and for all releases after that.\nUnfortunately my issue #205440 has been closed without fix.\n\nBUT ISSUE STILL EXISTS.","author_login":"degtiaan","author_association":"NONE","created_at":"2024-07-16T23:46:29+08:00","repo_name":"microsoft/vscode","issue_id":2393453354,"issue_number":220140,"issue_url":"https://github.com/microsoft/vscode/issues/220140","linked_issue_ids":[2140184133],"is_known_query_context":false},{"document_id":"gh_comment_2252916963","fragment_type":"issue_comment","sequence":3,"text":"The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.\n\nHappy Coding!","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2024-07-26T14:41:43+08:00","repo_name":"microsoft/vscode","issue_id":2393453354,"issue_number":220140,"issue_url":"https://github.com/microsoft/vscode/issues/220140","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2140184133","fragment_type":"issue_description","sequence":0,"text":"Workspace state is not preserved\nType: Bug \n\nOn Linux (Ubuntu 18.04) after manual update of portable version of VsCode from version 1.85.2 to 1.86.2 (just extract VSCode-linux-x64 folder from archive and copy \"/data\" subfolder from the previous version) start the new version ... but state of current workspace is not restored (folder trust warning appeared, all oppened files disapeared, c++ compiler kit cleared). This issue is repeated every time when the VsCode restarted.\n\nERROR RECOVERY:\nReturned back to the previous version of Vscode 1.85.2\n\nVS Code version: Code 1.86.2 (903b1e9d8990623e3d7da1df3d33db3e42d80eda, 2024-02-13T19:41:37.860Z)\nOS version: Linux x64 5.4.0-150-generic\nModes:\n\n \n System Info \n\n|Item|Value|\n|---|---|\n|CPUs|Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz (8 x 3027)|\n|GPU Status|2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off|\n|Load (avg)|0, 1, 1|\n|Memory (System)|31.01GB (22.36GB free)|\n|Process Argv||\n|Screen Reader|no|\n|VM|0%|\n|DESKTOP_SESSION|ubuntu|\n|XDG_CURRENT_DESKTOP|Unity|\n|XDG_SESSION_DESKTOP|ubuntu|\n|XDG_SESSION_TYPE|x11|\n Extensions (46) \n\nExtension|Author (truncated)|Version\n---|---|---\ncppincludeguard|aki|1.7.1\nBookmarks|ale|13.4.2\nvagrant|bbe|0.5.0\ncmake-format|che|0.6.11\ndoxdocgen|csc|1.4.0\ndlt-syntax|Dem|0.0.1\ngithistory|don|0.6.20\ngitlens|eam|14.8.2\ncmake-test-adapter|fre|0.17.2\npythonsnippets|frh|1.0.2\ngitlab-workflow|Git|4.2.0\ngo|gol|0.41.0\nvscode-test-explorer|hbe|2.21.1\nc-cpp-flylint|jbe|1.14.0\nbetter-cpp-syntax|jef|1.17.2\ncmake-language-support-vscode|jos|0.0.9\nvscode-catch2-test-adapter|mat|4.8.3\ndlt-logs|mbe|1.81.0\nthrift-syntax-support|mrk|0.0.12\nvscode-docker|ms-|1.29.0\nvscode-dotnet-runtime|ms-|2.0.1\ndebugpy|ms-|2024.0.0\nisort|ms-|2023.10.1\npython|ms-|2024.0.1\nvscode-pylance|ms-|2024.2.2\njupyter|ms-|2024.1.1\njupyter-keymap|ms-|1.1.2\njupyter-renderers|ms-|1.0.17\nvscode-jupyter-cell-tags|ms-|0.1.8\nvscode-jupyter-slideshow|ms-|0.1.5\nremote-containers|ms-|0.338.1\nremote-ssh|ms-|0.108.0\nremote-ssh-edit|ms-|0.86.0\nremote-wsl|ms-|0.86.0\nvscode-remote-extensionpack|ms-|0.25.0\ncmake-tools|ms-|1.17.15\ncpptools|ms-|1.19.3\nhexeditor|ms-|1.9.13\nremote-explorer|ms-|0.4.1\nremote-server|ms-|1.5.0\ntest-adapter-converter|ms-|0.1.9\nautodocstring|njp|0.6.1\npokowaka-iwyu|pok|1.0.3\ncode-spell-checker|str|3.0.1\numlet|the|15.1.0\ncmake|twx|0.0.17","author_login":"degtiaan","author_association":"NONE","created_at":"2024-02-17T15:18:32+08:00","repo_name":"microsoft/vscode","issue_id":2140184133,"issue_number":205440,"issue_url":"https://github.com/microsoft/vscode/issues/205440","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1966551464","fragment_type":"issue_comment","sequence":1,"text":"I can't repro this. Not only did the scenario work fine, it also showed me the release notes:\n\nImage\n\nCan you provide more details?","author_login":"joaomoreno","author_association":"MEMBER","created_at":"2024-02-27T13:27:05+08:00","repo_name":"microsoft/vscode","issue_id":2140184133,"issue_number":205440,"issue_url":"https://github.com/microsoft/vscode/issues/205440","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1976442915","fragment_type":"issue_comment","sequence":2,"text":"Hi\nJust recheck with new Vscode 1.87.0 ... the issue is reproduced \n\nFor current project I have to use custom linux toolchain so, use the next bash script for configure work env.\n\n`\n#!/bin/bash\n\n# Linux x86 custom toolchain\nsource /home/username/MyProjects/some-workspace/custom_toolchain_folder/environment-setup-x86_64-linux\n\ncd /home/username/MyProjects/some-workspace/\n/home/username/MyProjects/Utils/VSCode-linux-x64/code my_workspace_name &\n`\n\nSorry, I don't understand you note\n \"Not only did the scenario work fine, it also showed me the release notes\"\n\nthis seems is the error I'm talking about ... \nafter update ... every time when I start vscode is appeared\n- folder trust warning ;\nimage\n\n- welcome pages for updated extensions (e.g. GitLens, Bookmarks);\n\n- next warnings\nimage\n\n- all previously open project source files are closed/disappeared;\n\nif after that I configure/set c++ kit, open some source files ... close and open vscode ... all of the above is repeated again and again.\n\nBTW: I tried to use command-line parameter --user-data-dir just to avoid manual step \"copy \"/data\" subfolder from the previous version\" ... but looks like this doesn't work as expected ... extensions and configuration are not available \n\nRegards,\nAny help would be appreciated","author_login":"degtiaan","author_association":"NONE","created_at":"2024-03-04T12:11:21+08:00","repo_name":"microsoft/vscode","issue_id":2140184133,"issue_number":205440,"issue_url":"https://github.com/microsoft/vscode/issues/205440","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2129293730","fragment_type":"issue_comment","sequence":3,"text":"Hey @joaomoreno, this issue might need further attention.\n\n@degtiaan, you can help us out by closing this issue if the problem no longer exists, or adding more information.","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2024-05-24T11:25:05+08:00","repo_name":"microsoft/vscode","issue_id":2140184133,"issue_number":205440,"issue_url":"https://github.com/microsoft/vscode/issues/205440","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2143413439","fragment_type":"issue_comment","sequence":4,"text":"This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.\n\nHappy Coding!","author_login":"VSCodeTriageBot","author_association":"COLLABORATOR","created_at":"2024-06-01T11:25:53+08:00","repo_name":"microsoft/vscode","issue_id":2140184133,"issue_number":205440,"issue_url":"https://github.com/microsoft/vscode/issues/205440","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0471","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Update rules for author auto-notifications?","query_context":"1) When a curator edits a data submission, regardless of status, upon rebuilding/refreshing I believe the author receives an automatic confirmation email. \n\nFor example, this submission (10.7272/Q6Q23XH9) was edited multiple times by a curator in a matter of minutes. I believe that the author received email notifications each time the submission returned to PPR status after being edited. Visit SF case #18031.\n\nIs there a way to eliminate unnecessary auto-emails from being sent to the author? Specifically those notifications that are sent after curators have edited a submission? Perhaps create a rule based on operator? It might be helpful to view a list of rules set up for the auto-emails. \n\n2) Additionally, would it be possible to capture all auto-notifications sent in the Activity Log? It would be helpful to view all actions in the history for each dataset.","known_context_document_ids":["gh_issue_1428990988"],"reference_answer":"@jleighherzog That's exactly the confusion Ryan was talking about—this ticket is only about notifications sent by the system to journals and authors, so we have used the wording \"Status change notification was sent to [recipient]\" as Ryan suggested","answer_document_id":"gh_comment_1362773486","silver_evidence_path":["gh_comment_1338031408","gh_issue_1477278492","gh_comment_1362773486"],"evidence_issue_ids":[1428990988,1477278492],"source_repo_name":"CDL-Dryad/dryad-product-roadmap","source_issue_id":1428990988,"source_issue_number":2083,"source_issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2083","target_repo_name":"CDL-Dryad/dryad-product-roadmap","target_issue_id":1477278492,"target_issue_number":2153,"target_issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","reference_anchor_document_id":"gh_comment_1338031408","reference_answer_author":"ahamelers","reference_answer_author_association":"COLLABORATOR","quality_score":74.36,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":false,"anchor_query_overlap":0.0,"anchor_target_overlap":0.0909,"target_answer_overlap":0.375},"issue_created_at":"2022-10-30T19:31:08+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1428990988","fragment_type":"issue_description","sequence":0,"text":"Update rules for author auto-notifications\n1) When a curator edits a data submission, regardless of status, upon rebuilding/refreshing I believe the author receives an automatic confirmation email. \n\nFor example, this submission (10.7272/Q6Q23XH9) was edited multiple times by a curator in a matter of minutes. I believe that the author received email notifications each time the submission returned to PPR status after being edited. Visit SF case #18031.\n\nIs there a way to eliminate unnecessary auto-emails from being sent to the author? Specifically those notifications that are sent after curators have edited a submission? Perhaps create a rule based on operator? It might be helpful to view a list of rules set up for the auto-emails. \n\n2) Additionally, would it be possible to capture all auto-notifications sent in the Activity Log? It would be helpful to view all actions in the history for each dataset.","author_login":"jleighherzog","author_association":"COLLABORATOR","created_at":"2022-10-30T19:31:08+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1428990988,"issue_number":2083,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2083","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1338031408","fragment_type":"issue_comment","sequence":1,"text":"I have pulled out task 2 into its own ticket, #2153, as it's a different area of the project and might need discussion over details.","author_login":"ahamelers","author_association":"COLLABORATOR","created_at":"2022-12-05T19:31:20+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1428990988,"issue_number":2083,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2083","linked_issue_ids":[1477278492],"is_known_query_context":false},{"document_id":"gh_comment_1353641543","fragment_type":"issue_comment","sequence":2,"text":"@jleighherzog I've put in a check that won't send the PPR email notification if the submission has ever gone to PPR before. Is that fine, or is there any reason why, or workflow cycle where, you would want users to get multiple PPR notifications?","author_login":"ahamelers","author_association":"COLLABORATOR","created_at":"2022-12-15T20:03:16+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1428990988,"issue_number":2083,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2083","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1361202161","fragment_type":"issue_comment","sequence":3,"text":"@jleighherzog After discussion with Ryan and Scott, we are confused about the workflow that caused this issue and its actual frequency (see commentary in URL We think that it seems like an unusual set of circumstances. We'd like more information about it, maybe we can have a call in the new year?","author_login":"ahamelers","author_association":"COLLABORATOR","created_at":"2022-12-21T11:33:38+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1428990988,"issue_number":2083,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2083","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1477278492","fragment_type":"issue_description","sequence":0,"text":"Record email notifications in the Activity Log\nSeparated from #2083, suggested by @jleighherzog","author_login":"ahamelers","author_association":"COLLABORATOR","created_at":"2022-12-05T19:30:17+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1477278492,"issue_number":2153,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1352908967","fragment_type":"issue_comment","sequence":1,"text":"@ahamelers : Before this is completed, do you need more specifics?","author_login":"jleighherzog","author_association":"COLLABORATOR","created_at":"2022-12-15T11:12:37+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1477278492,"issue_number":2153,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353667646","fragment_type":"issue_comment","sequence":2,"text":"@jleighherzog I've put in code to add a short message each time an email is sent to the author or the journal, like\n \n\nor\n \n\nDo you think this will be sufficient? Phrasing okay? I thought we might need to ask questions about when to add the note to the curation activities, but it ended up being pretty easy to add it whenever there is an email sent out that's associated with a specific submission. 😄","author_login":"ahamelers","author_association":"COLLABORATOR","created_at":"2022-12-15T20:26:37+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1477278492,"issue_number":2153,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1353680304","fragment_type":"issue_comment","sequence":3,"text":"To avoid possible confusion, I would reword as \"Status change notification was sent to journal\"","author_login":"ryscher","author_association":"COLLABORATOR","created_at":"2022-12-15T20:39:26+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1477278492,"issue_number":2153,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1362157771","fragment_type":"issue_comment","sequence":4,"text":"@ahamelers : This might need a call to discuss too. \"Status change notification was sent to journal\" doesn't equal \"Journal sent status change notification\" -- those seem to be different communications to different parties. Let's include this in our call re: #2083?","author_login":"jleighherzog","author_association":"COLLABORATOR","created_at":"2022-12-21T21:58:49+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1477278492,"issue_number":2153,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1362773486","fragment_type":"issue_comment","sequence":5,"text":"@jleighherzog That's exactly the confusion Ryan was talking about—this ticket is only about notifications sent by the system to journals and authors, so we have used the wording \"Status change notification was sent to [recipient]\" as Ryan suggested","author_login":"ahamelers","author_association":"COLLABORATOR","created_at":"2022-12-22T12:18:53+08:00","repo_name":"CDL-Dryad/dryad-product-roadmap","issue_id":1477278492,"issue_number":2153,"issue_url":"https://github.com/CDL-Dryad/dryad-product-roadmap/issues/2153","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0472","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Need to change loggers location.","query_context":"As we have added logger's functionality, but these are saving logs in the same directory of code so whenever we pull latest code, we need to either stash or checkout, so I have two solutions:\n\n- Change the default location of logger (preferable)\n- adds these loggers to git ignore so they won't affect any more.","known_context_document_ids":["gh_issue_2073082391"],"reference_answer":"I have currently solve this issue by granting access to local user access by:\n`chmod +x ngrok_logger.txt` and one more file so i don't get this error for ttgo logger by\n`chmod +x logs.txt`","answer_document_id":"gh_comment_1894530572","silver_evidence_path":["gh_comment_1892780967","gh_issue_2082694322","gh_comment_1894530572"],"evidence_issue_ids":[2073082391,2082694322],"source_repo_name":"mhamidjamil/orangePi","source_issue_id":2073082391,"source_issue_number":67,"source_issue_url":"https://github.com/mhamidjamil/orangePi/issues/67","target_repo_name":"mhamidjamil/orangePi","target_issue_id":2082694322,"target_issue_number":71,"target_issue_url":"https://github.com/mhamidjamil/orangePi/issues/71","reference_anchor_document_id":"gh_comment_1892780967","reference_answer_author":"mhamidjamil","reference_answer_author_association":"OWNER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.12,"anchor_target_overlap":0.1429,"target_answer_overlap":0.4286},"issue_created_at":"2024-01-09T20:09:49+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2073082391","fragment_type":"issue_description","sequence":0,"text":"Need to change loggers location.\nAs we have added logger's functionality, but these are saving logs in the same directory of code so whenever we pull latest code, we need to either stash or checkout, so I have two solutions:\n\n- Change the default location of logger (preferable)\n- adds these loggers to git ignore so they won't affect any more.","author_login":"mhamidjamil","author_association":"OWNER","created_at":"2024-01-09T20:09:49+08:00","repo_name":"mhamidjamil/orangePi","issue_id":2073082391,"issue_number":67,"issue_url":"https://github.com/mhamidjamil/orangePi/issues/67","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1892780967","fragment_type":"issue_comment","sequence":1,"text":"@Amenawon Please have a look at this issue #71 and then you need to work on staging branch I recently updated the code, feel free to ask for more details if you need and can you please provide any estimate, or should I take care of this issue? as it's not a big deal for me and we must have to solve #71.","author_login":"mhamidjamil","author_association":"OWNER","created_at":"2024-01-15T21:26:28+08:00","repo_name":"mhamidjamil/orangePi","issue_id":2073082391,"issue_number":67,"issue_url":"https://github.com/mhamidjamil/orangePi/issues/67","linked_issue_ids":[2082694322],"is_known_query_context":false},{"document_id":"gh_comment_1894521644","fragment_type":"issue_comment","sequence":2,"text":"Currently I have solved this issue by granting local user access by:\n`chmod +x ngrok_logger.txt`","author_login":"mhamidjamil","author_association":"OWNER","created_at":"2024-01-16T21:13:15+08:00","repo_name":"mhamidjamil/orangePi","issue_id":2073082391,"issue_number":67,"issue_url":"https://github.com/mhamidjamil/orangePi/issues/67","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2082694322","fragment_type":"issue_description","sequence":0,"text":"Permission issue on logger file\nToday i got \n\nImage\n\n error.","author_login":"mhamidjamil","author_association":"OWNER","created_at":"2024-01-15T21:23:13+08:00","repo_name":"mhamidjamil/orangePi","issue_id":2082694322,"issue_number":71,"issue_url":"https://github.com/mhamidjamil/orangePi/issues/71","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1894530572","fragment_type":"issue_comment","sequence":1,"text":"I have currently solve this issue by granting access to local user access by:\n`chmod +x ngrok_logger.txt` and one more file so i don't get this error for ttgo logger by\n`chmod +x logs.txt`","author_login":"mhamidjamil","author_association":"OWNER","created_at":"2024-01-16T21:20:20+08:00","repo_name":"mhamidjamil/orangePi","issue_id":2082694322,"issue_number":71,"issue_url":"https://github.com/mhamidjamil/orangePi/issues/71","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0473","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"`ctrl-backspace` not working after swapping the `fn` and `ctrl` keys?","query_context":"Hey, I have an Asahi linux installed on an M1. I am using the below config to swap the `fn` and `ctrl` keys:\n\n[ids]\n*\n\n[main]\nfn = layer(control)\nleftcontrol = fn\n\n2 observations I had after applying the above config:\n1. `ctrl-backspace` no longer deletes one word to the left.\n2. In a text field, `ctrl-shift-left` selects all characters until the start of the text field instead of just selecting up to the start of the current line.\n\nI understand that I can play a little with macros, but I'd really like to use the native functionality to preserve the contextual behaviors of these keybindings; i.e. they should natively behave differently in vim than in a Firefox window.","known_context_document_ids":["gh_issue_1837765878"],"reference_answer":"Those above are correct, `fn` is usually handled in firmware so you will need to change it to another key like `control` in your bios before it can be detected and remapped by the OS.","answer_document_id":"gh_comment_1464356687","silver_evidence_path":["gh_comment_1668438988","gh_issue_1481552679","gh_comment_1464356687"],"evidence_issue_ids":[1837765878,1481552679],"source_repo_name":"rvaiya/keyd","source_issue_id":1837765878,"source_issue_number":549,"source_issue_url":"https://github.com/rvaiya/keyd/issues/549","target_repo_name":"rvaiya/keyd","target_issue_id":1481552679,"target_issue_number":401,"target_issue_url":"https://github.com/rvaiya/keyd/issues/401","reference_anchor_document_id":"gh_comment_1668438988","reference_answer_author":"rvaiya","reference_answer_author_association":"OWNER","quality_score":86.19,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1481,"anchor_target_overlap":0.0741,"target_answer_overlap":0.25},"issue_created_at":"2023-08-05T13:37:18+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_1837765878","fragment_type":"issue_description","sequence":0,"text":"`ctrl-backspace` not working after swapping the `fn` and `ctrl` keys\nHey, I have an Asahi linux installed on an M1. I am using the below config to swap the `fn` and `ctrl` keys:\n\n[ids]\n*\n\n[main]\nfn = layer(control)\nleftcontrol = fn\n\n2 observations I had after applying the above config:\n1. `ctrl-backspace` no longer deletes one word to the left.\n2. In a text field, `ctrl-shift-left` selects all characters until the start of the text field instead of just selecting up to the start of the current line.\n\nI understand that I can play a little with macros, but I'd really like to use the native functionality to preserve the contextual behaviors of these keybindings; i.e. they should natively behave differently in vim than in a Firefox window.","author_login":"ElSamhaa","author_association":"NONE","created_at":"2023-08-05T13:37:18+08:00","repo_name":"rvaiya/keyd","issue_id":1837765878,"issue_number":549,"issue_url":"https://github.com/rvaiya/keyd/issues/549","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1668220534","fragment_type":"issue_comment","sequence":1,"text":"Shouldn’t `Ctrl–Shift–Left` select only to the beginning of the current word? Anyway, to me this would indicate your fn key still submits fn, because `fn–Left` submits HOME on some hardware, which goes to the beginning of the line and Shift selects. Use the keyd monitor functionality to find out what the output really is.","author_login":"luetage","author_association":"NONE","created_at":"2023-08-07T16:30:05+08:00","repo_name":"rvaiya/keyd","issue_id":1837765878,"issue_number":549,"issue_url":"https://github.com/rvaiya/keyd/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1668438988","fragment_type":"issue_comment","sequence":2,"text":"@luetage It's swapped already, and `fn` acts as `ctrl`. It's the 2 observations that I'm concerned to report. As for #401, it holds true for certain OEMs like Lenovo. However, for Apple, I think that's not available unfortunately except from within MacOS itself (the first thing I did after getting my M1 😃).","author_login":"ElSamhaa","author_association":"NONE","created_at":"2023-08-07T19:11:54+08:00","repo_name":"rvaiya/keyd","issue_id":1837765878,"issue_number":549,"issue_url":"https://github.com/rvaiya/keyd/issues/549","linked_issue_ids":[1481552679],"is_known_query_context":false},{"document_id":"gh_comment_1683818304","fragment_type":"issue_comment","sequence":3,"text":"@ElSamhaa Can you test this too and verify you're seeing what I'm seeing?\n- #comment your rules (/etc/keyd/default.conf)\n- sudo keyd -m\n- press (and hold) the `fn` key\n- press `backspace`\n- press `left`\n- release `fn`\n\nI get the following output (\"delete\" instead of \"backspace\", \"home\" instead of \"left\"), which would indicate that the macbook is not sending the original keys for backspace and arrow keys when `fn` is held down (I'm using Fedora Asahi Remix on an M1 MacBook Air)\n\nkeyd virtual keyboard 0fac:0ade fn down\nkeyd virtual keyboard 0fac:0ade delete down\nkeyd virtual keyboard 0fac:0ade delete up\nkeyd virtual keyboard 0fac:0ade home down\nkeyd virtual keyboard 0fac:0ade home up\nkeyd virtual keyboard 0fac:0ade fn up","author_login":"rxhfcy","author_association":"NONE","created_at":"2023-08-18T12:02:42+08:00","repo_name":"rvaiya/keyd","issue_id":1837765878,"issue_number":549,"issue_url":"https://github.com/rvaiya/keyd/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1684907967","fragment_type":"issue_comment","sequence":4,"text":"@rxhfcy yep, exactly the same with me. I'm on the fedora Asahi remix too btw.","author_login":"ElSamhaa","author_association":"NONE","created_at":"2023-08-19T09:51:48+08:00","repo_name":"rvaiya/keyd","issue_id":1837765878,"issue_number":549,"issue_url":"https://github.com/rvaiya/keyd/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1684930220","fragment_type":"issue_comment","sequence":5,"text":"@ElSamhaa great, so this issue can be closed then (not a keyd bug but a feature of the Asahi Linux kernel)\n\nPS. About your earlier comment:\n \n\nLuckily, that's not true. Here's a pretty easy way to swap `fn` and `control` in Fedora Asahi Remix (permanently, you can later undo this by using `hid_apple.swap_fn_leftctrl=0` instead of `hid_apple.swap_fn_leftctrl=1` if you want):\n\nshell\nsudo grubby --update-kernel=ALL --args=\"hid_apple.swap_fn_leftctrl=1\"\n\n...and then reboot. Or if you want to see the effect immediately, you can do this too (not permanent):\n\nshell\necho 0 | sudo tee /sys/module/hid_apple/parameters/swap_fn_leftctrl","author_login":"rxhfcy","author_association":"NONE","created_at":"2023-08-19T12:12:08+08:00","repo_name":"rvaiya/keyd","issue_id":1837765878,"issue_number":549,"issue_url":"https://github.com/rvaiya/keyd/issues/549","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1481552679","fragment_type":"issue_description","sequence":0,"text":"Swap fn and leftcontrol on Thinkpad\nIs it possible to swap Fn and Control keys on a Thinkpad?\n\n`keyd -m` says that Fn key is `wakeup`, so I did this:\n\nwakeup = leftcontrol\nleftcontrol = wakeup\n\nWhich makes both `keyd` and `xev` recognize Fn key as Left Control.\n\nHowever, Fn key still does not function as Control and works with F1-12 keys as before the swap. And Control functions neither as control, nor as Fn key.\n\nI assume this key works on a firmware level and it's not possible to swap them on OS level, right?","author_login":"sarmong","author_association":"NONE","created_at":"2022-12-07T10:20:13+08:00","repo_name":"rvaiya/keyd","issue_id":1481552679,"issue_number":401,"issue_url":"https://github.com/rvaiya/keyd/issues/401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1372819825","fragment_type":"issue_comment","sequence":1,"text":"If the `Fn` key cannot be detected by the `keyd monitor`, then it is an area of hardware or firmware and should not be subject to control by keyd.","author_login":"tkna91","author_association":"CONTRIBUTOR","created_at":"2023-01-05T21:48:24+08:00","repo_name":"rvaiya/keyd","issue_id":1481552679,"issue_number":401,"issue_url":"https://github.com/rvaiya/keyd/issues/401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1379304935","fragment_type":"issue_comment","sequence":2,"text":"The wakeup keysym generated by the fn key cannot be used as a modifier. The BIOS handles that key and if you use it as a modifier, the BIOS will intercept before keyd gets it.","author_login":"vg250156","author_association":"NONE","created_at":"2023-01-11T18:21:44+08:00","repo_name":"rvaiya/keyd","issue_id":1481552679,"issue_number":401,"issue_url":"https://github.com/rvaiya/keyd/issues/401","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1464356687","fragment_type":"issue_comment","sequence":3,"text":"Those above are correct, `fn` is usually handled in firmware so you will need to change it to another key like `control` in your bios before it can be detected and remapped by the OS.","author_login":"rvaiya","author_association":"OWNER","created_at":"2023-03-10T20:08:16+08:00","repo_name":"rvaiya/keyd","issue_id":1481552679,"issue_number":401,"issue_url":"https://github.com/rvaiya/keyd/issues/401","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0475","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Is it compatible with Expo 50?","query_context":"### Prerequisites\n\n- [X] I checked the documentation and FAQ without finding a solution\n- [X] I checked to make sure that this issue has not already been filed\n- [X] I'm sure that question is related to the library itself and not Bluetooth Low Energy or Classic in general. If that so, please post your question on StackOverflow.\n- [X] I'm running the latest version\n\n### Question\n\nHello,\n\nI am using expo 50.\n\n\"dependencies\": {\n \"expo\": \"~50.0.14\",\n...\n\nWhen I tried to run `npx expo install @config-plugins/react-native-ble-plx`, I got the following error:\n\n› Installing 1 other package using npm\n \nnpm ERR! code ERESOLVE\nnpm ERR! ERESOLVE unable to resolve dependency tree\nnpm ERR!\nnpm ERR! While resolving: expo-ble@1.0.0\nnpm ERR! Found: expo@50.0.17\nnpm ERR! node_modules/expo\nnpm ERR! expo@\"~50.0.14\" from the root project\nnpm ERR!\nnpm ERR! Could not resolve dependency:\nnpm ERR! peer expo@\"^49\" from @config-plugins/react-native-ble-plx@7.0.0 \nnpm ERR! node_modules/@config-plugins/react-native-ble-plx\nnpm ERR! @config-plugins/react-native-ble-plx@\"*\" from the root project \nnpm ERR!\nnpm ERR! Fix the upstream dependency conflict, or retry\nnpm ERR! this command with --force or --legacy-peer-deps\nnpm ERR! to accept an incorrect (and potentially broken) dependency resolution.\n...\n\nI can see - it is compatible with Expo 49 in the readme, but I can't install the package with Expo 50. Isn't it compatible with 50?\n\nThank you,","known_context_document_ids":["gh_issue_2255051405"],"reference_answer":"This wasn't overlooked, this was the reason why I pointed out old config-plugins versions in my initial response. The ones with the correct version for this SDK version has been updated to use the correct AppDelegate. Older versions are not.\n\nI'm confused about your contribution to the thread. Were you having the same or a similar issue?","answer_document_id":"gh_comment_1537527489","silver_evidence_path":["gh_comment_2088136708","gh_issue_1246805056","gh_comment_1537527489"],"evidence_issue_ids":[2255051405,1246805056],"source_repo_name":"dotintent/react-native-ble-plx","source_issue_id":2255051405,"source_issue_number":1190,"source_issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","target_repo_name":"expo/expo-cli","target_issue_id":1246805056,"target_issue_number":4391,"target_issue_url":"https://github.com/expo/expo-cli/issues/4391","reference_anchor_document_id":"gh_comment_2088136708","reference_answer_author":"kbrandwijk","reference_answer_author_association":"MEMBER","quality_score":95.17,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1644,"anchor_target_overlap":0.1461,"target_answer_overlap":0.0833},"issue_created_at":"2024-04-21T12:30:09+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_2255051405","fragment_type":"issue_description","sequence":0,"text":"Is it compatible with Expo 50?\n### Prerequisites\n\n- [X] I checked the documentation and FAQ without finding a solution\n- [X] I checked to make sure that this issue has not already been filed\n- [X] I'm sure that question is related to the library itself and not Bluetooth Low Energy or Classic in general. If that so, please post your question on StackOverflow.\n- [X] I'm running the latest version\n\n### Question\n\nHello,\n\nI am using expo 50.\n\n\"dependencies\": {\n \"expo\": \"~50.0.14\",\n...\n\nWhen I tried to run `npx expo install @config-plugins/react-native-ble-plx`, I got the following error:\n\n› Installing 1 other package using npm\n \nnpm ERR! code ERESOLVE\nnpm ERR! ERESOLVE unable to resolve dependency tree\nnpm ERR!\nnpm ERR! While resolving: expo-ble@1.0.0\nnpm ERR! Found: expo@50.0.17\nnpm ERR! node_modules/expo\nnpm ERR! expo@\"~50.0.14\" from the root project\nnpm ERR!\nnpm ERR! Could not resolve dependency:\nnpm ERR! peer expo@\"^49\" from @config-plugins/react-native-ble-plx@7.0.0 \nnpm ERR! node_modules/@config-plugins/react-native-ble-plx\nnpm ERR! @config-plugins/react-native-ble-plx@\"*\" from the root project \nnpm ERR!\nnpm ERR! Fix the upstream dependency conflict, or retry\nnpm ERR! this command with --force or --legacy-peer-deps\nnpm ERR! to accept an incorrect (and potentially broken) dependency resolution.\n...\n\nI can see - it is compatible with Expo 49 in the readme, but I can't install the package with Expo 50. Isn't it compatible with 50?\n\nThank you,","author_login":"Santa0727","author_association":"NONE","created_at":"2024-04-21T12:30:09+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2068140146","fragment_type":"issue_comment","sequence":1,"text":"Hi @Santa0727\nWe checked compatibility with expo 50 and found no problems. In issue #1176 ( URL is an example using expo 50.","author_login":"dominik-czupryna-withintent","author_association":"COLLABORATOR","created_at":"2024-04-21T17:20:44+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2088136708","fragment_type":"issue_comment","sequence":2,"text":"This bugs me 😅 \n \n@dominik-czupryna-withintent Do you think it can somehow added anyways?\n\nI was able to successfully make a build 10 days ago with `\"expo\": \"~50.0.4\",`\n\nWhen I want to build my app (`\"expo\": \"~50.0.17\",`) with `eas`, I encounter this error URL \n\nError: [ios.dangerous]: withIosDangerousBaseMod: Unrecognised filter type - 127\n\nCleanShot 2024-05-01 at 09 52 26@2x\n\n`npx expo prebuild` runs fine on my local machine.\n\nHere are my investigations with `yarn why @expo/config-plugins` \n\nyarn why @expo/config-plugins\nyarn why v1.22.21\n[1/4] 🤔 Why do we have the module \"@expo/config-plugins\"...?\n[2/4] 🚚 Initialising dependency graph...\n[3/4] 🔍 Finding dependency...\n[4/4] 🚡 Calculating file sizes...\n=> Found \"@expo/config-plugins@7.9.1\"\ninfo Has been hoisted to \"@expo/config-plugins\"\ninfo Reasons this module exists\n - Hoisted from \"expo#@expo#config-plugins\"\n - Hoisted from \"react-native-ble-plx#@expo#config-plugins\" Found \"expo-updates#@expo/config-plugins@7.8.4\"\ninfo This module exists because \"expo-updates\" depends on it.\ninfo Disk size without dependencies: \"1.73MB\"\ninfo Disk size with unique dependencies: \"3.82MB\"\ninfo Disk size with transitive dependencies: \"8.32MB\"\ninfo Number of shared dependencies: 60\n✨ Done in 0.24s.\n\nOn my `app.config.ts` I added this\n\ntypescript\nplugins: [\n \"expo-router\",\n [\n \"react-native-ble-plx\",\n {\n isBackgroundEnabled: true,\n modes: [\"peripheral\", \"central\"],\n bluetoothAlwaysPermission:\n \"Allow $(PRODUCT_NAME) to detect your bluetooth device\"\n }\n ], \n\n@Santa0727 \nCan you please let us know if `eas build --platform=ios` is working on your side?","author_login":"flexbox","author_association":"NONE","created_at":"2024-05-01T08:15:40+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[1246805056],"is_known_query_context":false},{"document_id":"gh_comment_2088184388","fragment_type":"issue_comment","sequence":3,"text":"Hi @flexbox,\nThank you for your response.\nThe build command works on my side, and it builds ipa file.\n\nI've used expo managed workflow on my local. Is it impossible to use without ejecting expo?","author_login":"Santa0727","author_association":"NONE","created_at":"2024-05-01T09:05:55+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2094907769","fragment_type":"issue_comment","sequence":4,"text":"@flexbox \nI mean you shouldn't install URL because react-native-ble-plx is shipped with an Expo config plugin on its own.\n\n@Santa0727\nYou don't need to eject expo, you just need to prebuild the native code because without using native code this package won't work.","author_login":"dominik-czupryna-withintent","author_association":"COLLABORATOR","created_at":"2024-05-05T18:40:09+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2127349094","fragment_type":"issue_comment","sequence":5,"text":"Hi, I am not sure now, where should we add these configurations ?\n{\n isBackgroundEnabled: true,\n modes: [\"peripheral\", \"central\"],\n bluetoothAlwaysPermission:\n \"Allow $(PRODUCT_NAME) to detect your bluetooth device\"\n}","author_login":"kennyyen","author_association":"NONE","created_at":"2024-05-23T14:55:16+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2127824960","fragment_type":"issue_comment","sequence":6,"text":"@kennyyen \nin your `app.json` or `app.config.js` URL \n\njson\n{\n \"expo\": {\n \"plugins\": \n [\n \"react-native-ble-plx\", // URL \n {\n isBackgroundEnabled: true,\n modes: [\"peripheral\", \"central\"],\n bluetoothAlwaysPermission: \"Allow $(PRODUCT_NAME) to detect your controller with bluetooth\"\n }\n ],\n }\n}","author_login":"flexbox","author_association":"CONTRIBUTOR","created_at":"2024-05-23T18:50:54+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2128183049","fragment_type":"issue_comment","sequence":7,"text":"Thank you for the response, I did tried to put them in my app.json, and when I do\n`npx expo install react-native-ble-plx`\nI get this \n\nSkipping config plugin check: Plugin is an unexpected type: object","author_login":"kennyyen","author_association":"NONE","created_at":"2024-05-23T23:19:31+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2128186860","fragment_type":"issue_comment","sequence":8,"text":"Thank you for the clarification ! It works just fine as before !","author_login":"kennyyen","author_association":"NONE","created_at":"2024-05-23T23:24:53+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2162447175","fragment_type":"issue_comment","sequence":9,"text":"@kennyyen great news!\nIf your problem is solved can you please close the issue? \nIt sparks joy for maintainers ✨","author_login":"flexbox","author_association":"CONTRIBUTOR","created_at":"2024-06-12T08:44:42+08:00","repo_name":"dotintent/react-native-ble-plx","issue_id":2255051405,"issue_number":1190,"issue_url":"https://github.com/dotintent/react-native-ble-plx/issues/1190","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1246805056","fragment_type":"issue_description","sequence":0,"text":"[ios.dangerous]: withIosDangerousBaseMod: Could not locate a valid AppDelegate at root\n### Summary\n\nRunning\n`expo prebuild`\nor \n`expo eject`\n\n### Environment\n\nexpo-env-info 1.0.3 environment info:\n System:\n OS: macOS 12.3.1\n Shell: 5.8 - /bin/zsh\n Binaries:\n Node: 16.13.1 - /usr/local/bin/node\n Yarn: 1.22.18 - /usr/local/bin/yarn\n npm: 8.1.2 - /usr/local/bin/npm\n Managers:\n CocoaPods: 1.11.3 - /usr/local/bin/pod\n SDKs:\n iOS SDK:\n Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5\n IDEs:\n Xcode: 13.4/13F17a - /usr/bin/xcodebuild\n npmPackages:\n expo: ~45.0.3 => 45.0.4 \n react: 17.0.2 => 17.0.2 \n react-dom: 17.0.2 => 17.0.2 \n react-native: 0.68.2 => 0.68.2 \n react-native-web: 0.17.7 => 0.17.7 \n npmGlobalPackages:\n eas-cli: 0.41.1\n expo-cli: 5.0.1\n Expo Workflow: bare\n\n### Please specify your device/emulator/simulator platform, model and version\n\nmac\n\n### Error output\n\n_No response_\n\n### Reproducible demo or steps to reproduce from a blank project\n\n-","author_login":"Jigalag","author_association":"NONE","created_at":"2022-05-24T16:23:27+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1136414558","fragment_type":"issue_comment","sequence":1,"text":"I just had this happen to me after ejecting from a fresh Expo app. `expo init my-app` then `yarn eject`.","author_login":"trevordunn","author_association":"NONE","created_at":"2022-05-24T20:46:00+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1136423043","fragment_type":"issue_comment","sequence":2,"text":"Upgrading `expo-cli` from `4.12.10` to the latest (`5.4.6`) resolved it for me.","author_login":"trevordunn","author_association":"NONE","created_at":"2022-05-24T20:55:51+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1212145855","fragment_type":"issue_comment","sequence":3,"text":"I'm getting the same issue on `expo-cli` `6.0.2` when I run `expo prebuild --clean`","author_login":"ThakurBallary","author_association":"NONE","created_at":"2022-08-11T15:28:00+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1246635841","fragment_type":"issue_comment","sequence":4,"text":"@kbrandwijk @trevordunn @solarisn @Jigalag @hasunperera \nSame issue here on expo-cli 6.0.5\n\nexpo prebuild --clean\nWarning! Your git working tree is dirty.\nIt's recommended to commit all your changes before proceeding, so you can revert the changes made by this command if necessary.\n\n✔ Would you like to proceed? … yes\n\n✔ Cleared android, ios code\n✔ Created native projects | gitignore already synced\n⚠️ Skipped Metro config updates:\n› Existing Metro config found; not overwriting.\n› You will need to extend the default @expo/metro-config in your Metro config.\n Learn more: URL \n\n✔ Updated package.json and added index.js entry point for iOS and Android\ny🧶 Using Yarn to install packages. Pass --npm to use npm instead.\n✔ Installed JavaScript dependencies 1557ms\n✖ Config sync failed\n[ios.dangerous]: withIosDangerousBaseMod: Could not locate a valid AppDelegate at root: \"/Users/XXX/Documents/projects/project\"\nPlease report this as an issue on URL \nUnexpectedError: [ios.dangerous]: withIosDangerousBaseMod: Could not locate a valid AppDelegate at root: \"/Users/XXX/Documents/projects/project\"\nPlease report this as an issue on URL \n at getAppDelegateFilePath (/Users/XXX/Documents/projects/project/node_modules/expo-screen-orientation/node_modules/@expo/config-plugins/src/ios/Paths.ts:26:11)\n at Object.getAppDelegate (/Users/XXX/Documents/projects/project/node_modules/expo-screen-orientation/node_modules/@expo/config-plugins/src/ios/Paths.ts:63:20)\n at /Users/XXX/Documents/projects/project/node_modules/expo-screen-orientation/plugin/build/withScreenOrientation.js:39:63\n at action (/Users/XXX/Documents/projects/project/node_modules/expo-screen-orientation/node_modules/@expo/config-plugins/src/plugins/withMod.ts:214:29)\n at interceptingMod (/Users/XXX/Documents/projects/project/node_modules/expo-screen-orientation/node_modules/@expo/config-plugins/src/plugins/withMod.ts:100:27)\n at action (/usr/local/lib/node_modules/expo-cli/node_modules/@expo/config-plugins/src/plugins/withMod.ts:228:14)\n at interceptingMod (/usr/local/lib/node_modules/expo-cli/node_modules/@expo/config-plugins/src/plugins/withMod.ts:108:21)\n at interceptingMod (/usr/local/lib/node_modules/expo-cli/node_modules/@expo/config-plugins/src/plugins/withMod.ts:108:21)\n at action (/usr/local/lib/node_modules/expo-cli/node_modules/@expo/config-plugins/src/plugins/createBaseMod.ts:82:21)\n at interceptingMod (/usr/local/lib/node_modules/expo-cli/node_modules/@expo/config-plugins/src/plugins/withMod.ts:108:21)","author_login":"codal-mpawar","author_association":"NONE","created_at":"2022-09-14T11:36:42+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1253154817","fragment_type":"issue_comment","sequence":5,"text":"@kbrandwijk @trevordunn @solarisn @Jigalag @hasunperera Any update on this? we are stuck here.","author_login":"codal-mpawar","author_association":"NONE","created_at":"2022-09-21T03:18:49+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1256896946","fragment_type":"issue_comment","sequence":6,"text":"@kbrandwijk yes, but it was causing the same issue, but I was able to fix the error by following these steps, not sure which step fixed it though, \n1.) Upgraded MacOS to the latest version (MacOS Monterey 12.6)\n2.) Completely removed Xcode and all the other files\n3.) Restarted the machine\n4.) Installed latest Xcode 14.0 from app store\n5.) Installed other dependencies from the Xcode app (Xcode 14.0 command line tools)\n6.) Upgraded expo-cli to latest (version 6.0.5)\n6.) Restarted the machine\nAfter following these steps, above error disappeared and was able to run the expo build for IOS successfully. (expo run:ios) @trevordunn @solarisn @Jigalag","author_login":"hasunperera","author_association":"NONE","created_at":"2022-09-24T07:41:10+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1373915900","fragment_type":"issue_comment","sequence":7,"text":"Thanks @hasunperera I followed all your steps & I was still getting this error, so I followed this debugging thread (below) from @kbrandwijk.\n \n\nI had 3 packages pulling in v4.x (old) @expo/config-plugins dependencies — namely expo-cli, eas-cli, and expo. I removed expo-cli & eas-cli from my dependencies since they weren’t strictly necessary (I can just use npx to run each expo & eas in CI so that just left expo.\n\nHowever I wasn’t experiencing the same error when the project was built with eas. Which was curious. Something Brett Vatne mentioned in some other thread led me to the hypothesis that it could be related to my local node version vs the version I’d specified in eas.json (16.13.0 ) vs my local 16.10.x. I rm -rf’d my yarn.lock & node_modules, set my local nodenv to 16.13.0, reinstalled my dependencies, said a prayer, and ran `expo doctor` and voila, no more @expo/config-plugins version mismatch! Ran `expo prebuild` and no more error.","author_login":"kevinhylant","author_association":"NONE","created_at":"2023-01-06T17:20:32+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1527576362","fragment_type":"issue_comment","sequence":8,"text":"I just noticed the AppDelegate filename generated with expo prebuild is `AppDelegate.mm` rather than `AppDelegate.m`. I am using Expo 47","author_login":"Emex4gman","author_association":"NONE","created_at":"2023-04-28T13:36:06+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537527489","fragment_type":"issue_comment","sequence":9,"text":"This wasn't overlooked, this was the reason why I pointed out old config-plugins versions in my initial response. The ones with the correct version for this SDK version has been updated to use the correct AppDelegate. Older versions are not.\n\nI'm confused about your contribution to the thread. Were you having the same or a similar issue?","author_login":"kbrandwijk","author_association":"MEMBER","created_at":"2023-05-07T19:55:11+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1537562764","fragment_type":"issue_comment","sequence":10,"text":"Oh I see. Thanks for this insight. I was was making an observation and I had a similar issue with expo prebuild failing.","author_login":"Emex4gman","author_association":"NONE","created_at":"2023-05-07T23:07:15+08:00","repo_name":"expo/expo-cli","issue_id":1246805056,"issue_number":4391,"issue_url":"https://github.com/expo/expo-cli/issues/4391","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0476","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"(JP) Yomitan only scanning the last word in a sentence?","query_context":"The last day my Japanese yomitan setup hasn´t been working, and I can only scan the last word or kana of a sentence. Spanish yomitan settings are working fine, but for some reason I cannot scan the majority of words in Japanese. All permissions are given, this is a brand new issue. Image shows that yomitan isn´t completely turned off, but when I scan a sentence and come to the last word it will usually scan it.","known_context_document_ids":["gh_issue_2880633998"],"reference_answer":"Scan resolution isnt an issue here since it's forcibly turned off when switching to Japanese.","answer_document_id":"gh_comment_2698075397","silver_evidence_path":["gh_comment_2708493271","gh_issue_2894011314","gh_comment_2698075397"],"evidence_issue_ids":[2880633998,2894011314],"source_repo_name":"yomidevs/yomitan","source_issue_id":2880633998,"source_issue_number":1846,"source_issue_url":"https://github.com/yomidevs/yomitan/issues/1846","target_repo_name":"yomidevs/yomitan","target_issue_id":2894011314,"target_issue_number":1861,"target_issue_url":"https://github.com/yomidevs/yomitan/issues/1861","reference_anchor_document_id":"gh_comment_2708493271","reference_answer_author":"Kuuuube","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.4444,"target_answer_overlap":0.3},"issue_created_at":"2025-02-26T08:07:59+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_2880633998","fragment_type":"issue_description","sequence":0,"text":"(JP) Yomitan only scanning the last word in a sentence\nThe last day my Japanese yomitan setup hasn´t been working, and I can only scan the last word or kana of a sentence. Spanish yomitan settings are working fine, but for some reason I cannot scan the majority of words in Japanese. All permissions are given, this is a brand new issue. Image shows that yomitan isn´t completely turned off, but when I scan a sentence and come to the last word it will usually scan it.","author_login":"Dilutedsoda","author_association":"NONE","created_at":"2025-02-26T08:07:59+08:00","repo_name":"yomidevs/yomitan","issue_id":2880633998,"issue_number":1846,"issue_url":"https://github.com/yomidevs/yomitan/issues/1846","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2684237197","fragment_type":"issue_comment","sequence":1,"text":"To be clear this is not a bug, its a setting in yomitan which I cannot figure out where or what is causing it.","author_login":"Dilutedsoda","author_association":"NONE","created_at":"2025-02-26T08:13:26+08:00","repo_name":"yomidevs/yomitan","issue_id":2880633998,"issue_number":1846,"issue_url":"https://github.com/yomidevs/yomitan/issues/1846","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2708493271","fragment_type":"issue_comment","sequence":2,"text":"This is almost certainly #1861. You probably need to set `Dictionary search resolution` to `Letter`.","author_login":"Kuuuube","author_association":"MEMBER","created_at":"2025-03-08T21:26:04+08:00","repo_name":"yomidevs/yomitan","issue_id":2880633998,"issue_number":1846,"issue_url":"https://github.com/yomidevs/yomitan/issues/1846","linked_issue_ids":[2894011314],"is_known_query_context":false},{"document_id":"gh_issue_2894011314","fragment_type":"issue_description","sequence":0,"text":"Japanese Language Mode Fails to Automatically Set translation.searchResolution to \"letter\"\n**Description** \nWhen switching the target language to Japanese in Yomitan, the extension does not automatically update the settings `translation.searchResolution` to `\"letter\"`. Instead, they remain set to `\"word\"`, which is the default for languages like English. This causes issues with Japanese word segmentation, as the `\"word\"` mode fails to split compound terms or phrases correctly, leading to failed dictionary lookups. \n\n**Steps to Reproduce** \n1. Set Yomitan's primary language to English. \n2. Confirm that `translation.searchResolution` are set to `\"word\"` in the settings. \n3. Switch the target language to Japanese. \n4. Observe that the settings remain `\"word\"` instead of automatically switching to `\"letter\"`. \n\n**Expected Behavior** \nWhen Japanese is selected as the target language, Yomitan should automatically set: \n- `translation.searchResolution = \"letter\"` \n\n**Browser Version** \nany\n\n**Yomitan Version** \nlatest\n\n**Additional Notes** \n- Manually changing the settings to `\"letter\"` resolves the issue, but this should happen automatically when switching to Japanese. \n- Languages like Japanese often require `\"letter\"` mode for granular parsing, while `\"word\"` works better for spaced languages (e.g., English).","author_login":"ooopus","author_association":"NONE","created_at":"2025-03-04T11:58:42+08:00","repo_name":"yomidevs/yomitan","issue_id":2894011314,"issue_number":1861,"issue_url":"https://github.com/yomidevs/yomitan/issues/1861","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2698075397","fragment_type":"issue_comment","sequence":1,"text":"Scan resolution isnt an issue here since it's forcibly turned off when switching to Japanese.","author_login":"Kuuuube","author_association":"MEMBER","created_at":"2025-03-04T15:44:19+08:00","repo_name":"yomidevs/yomitan","issue_id":2894011314,"issue_number":1861,"issue_url":"https://github.com/yomidevs/yomitan/issues/1861","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0477","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"EatingWell zimit attempts fail?","query_context":"I double-checked the URL and zimit gave a failure on two attempts.\n\nI was using the default options / settings.\n\nURL: URL","known_context_document_ids":["gh_issue_1945261146"],"reference_answer":"You are right, sorry 😉\n\nBut this still needs to be fixed, and this is still very aggressive (I now know how to prevent a whole company/campus from accessing some websites, just do one HEAD request with `python-requests` UA from their public web browsing IP ...)","answer_document_id":"gh_comment_1774889068","silver_evidence_path":["gh_comment_1774773970","gh_issue_1956696791","gh_comment_1774889068"],"evidence_issue_ids":[1945261146,1956696791],"source_repo_name":"openzim/zimit","source_issue_id":1945261146,"source_issue_number":224,"source_issue_url":"https://github.com/openzim/zimit/issues/224","target_repo_name":"openzim/zimit","target_issue_id":1956696791,"target_issue_number":227,"target_issue_url":"https://github.com/openzim/zimit/issues/227","reference_anchor_document_id":"gh_comment_1774773970","reference_answer_author":"benoit74","reference_answer_author_association":"COLLABORATOR","quality_score":93.5,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0769,"anchor_target_overlap":0.125,"target_answer_overlap":0.087},"issue_created_at":"2023-10-16T13:46:50+08:00","valid_comment_count":19,"fragments":[{"document_id":"gh_issue_1945261146","fragment_type":"issue_description","sequence":0,"text":"EatingWell zimit attempts fail\nI double-checked the URL and zimit gave a failure on two attempts.\n\nI was using the default options / settings.\n\nURL: URL","author_login":"DaveD5501","author_association":"NONE","created_at":"2023-10-16T13:46:50+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1764861869","fragment_type":"issue_comment","sequence":1,"text":"Thank you. I appreciate what you are doing.\n\n\"Do you know if the site is \"protected\" by a CDN or something like that?\"\nI do not know - I had to lookup \"CDN\".\n\nEach time, Zimit took a long time working on the site before issuing the\nFailure.\n\nDave\n\n \n\nOn Mon, Oct 16, 2023 at 9:14 AM benoit74 ***@***.***> wrote:","author_login":"DaveD5501","author_association":"NONE","created_at":"2023-10-16T16:35:28+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1770179329","fragment_type":"issue_comment","sequence":2,"text":"Hello,\n\nI confirm there is an issue most probably linked to some form of protection against denial of service on the website, and this prevents us from proceeding with the content retrieval.\n\nI tested on a server and on my desktop and got the following result:\n- I get a systematic error (HTTP 405) on my server machine (even with simple commands like curl, even when I pass a proper user agent)\n- it works well on my desktop\n\nI suspect this is linked to some kind of ASN / IP filtering.\n\nI will confirm with the team what we usually do in such a situation.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-19T06:57:55+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1770187496","fragment_type":"issue_comment","sequence":3,"text":"It is indeed worse than expected. It does not work anymore on my desktop machine. Looks like protection is pretty aggressive.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-19T07:04:17+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1771606086","fragment_type":"issue_comment","sequence":4,"text":"Ok, Thanks for looking into this for me.\n\nI appreciate your time.\n\nDave\n\n \n\nOn Thu, Oct 19, 2023 at 1:58 AM benoit74 ***@***.***> wrote:","author_login":"DaveD5501","author_association":"NONE","created_at":"2023-10-19T19:45:55+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772156126","fragment_type":"issue_comment","sequence":5,"text":"I diagnosed this a bit further.\n\nThis morning I can request the website via curl again, so clearly there is some kind of active protection.\n\nI achieved to start the website crawl (which is the first phase before creating the ZIM) successfully by passing a User Agent.\n\n@DaveD5501 : could you please try again to request the ZIM on youzim.it and use the \"advanced option\".\n\nimage\n\nIn the option named \"User Agent\", input a valid User Agent from a Browser. You might for instance use mine which is \"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15\" (without the quotes).\n\nimage\n\nThis should be enough to make the crawl start successfully, I will monitor this, should it fail I will keep you informed here.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-20T06:25:02+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1772802648","fragment_type":"issue_comment","sequence":6,"text":"I tried it again using your User Agent setting. Rather quickly, I got a\nfailure \"Youzim.it task 84262 failed\".\n\nThanks for your efforts.\n\nDave\n\n \n\nOn Fri, Oct 20, 2023 at 1:25 AM benoit74 ***@***.***> wrote:","author_login":"DaveD5501","author_association":"NONE","created_at":"2023-10-20T14:04:38+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773199290","fragment_type":"issue_comment","sequence":7,"text":"I'm very sorry about that, there is a bug in handling parameters values with spaces. \n\nWe will have to fix this before you can proceed, you can track this upstream here: URL","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-20T18:23:53+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773204127","fragment_type":"issue_comment","sequence":8,"text":"Oh, no, I'm wrong, parameter without quotes is processed properly.\n\nIt is just that the User-Agent value is still not working. I will have a look at it on Monday, I suspect I already know the reason.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-20T18:27:38+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1773229418","fragment_type":"issue_comment","sequence":9,"text":"Ok, thanks for the update.\n\n \n\nOn Fri, Oct 20, 2023 at 1:27 PM benoit74 ***@***.***> wrote:","author_login":"DaveD5501","author_association":"NONE","created_at":"2023-10-20T18:48:57+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774773970","fragment_type":"issue_comment","sequence":10,"text":"By fixing #226, I finally got the real issue, the server does not like our check of the root URL:\n\nfailed to connect to URL 406 Client Error: Not Acceptable for url: URL \n\nFixing #227 will solve the issue.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-23T09:21:42+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[1956696791],"is_known_query_context":false},{"document_id":"gh_comment_1774781833","fragment_type":"issue_comment","sequence":11,"text":"While doing this, we may also consider making a `GET` request, stopping after the first bytes received. Some web servers don't implement HEAD and the scrape would fail for an invalid reason.","author_login":"rgaudin","author_association":"MEMBER","created_at":"2023-10-23T09:26:18+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1781078393","fragment_type":"issue_comment","sequence":12,"text":"@DaveD5501 now that code has been merged, could you please try to request the ZIM again (no additional parameter needed anymore, just provide the URL)? I tried to start the task and it worked well, not sure it will complete successfully but at least it made much more progress than before.\n\nThank you for your patience (and thank you for helping us fix all these issues, we made a good progress)","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-26T13:01:20+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1783033398","fragment_type":"issue_comment","sequence":13,"text":"Success! I have my ZIM. I clicked around enough to verify the results.\n\nIt took 12 hours and finished overnight. I watched it wait for a slot for several hours - so the long time to complete might have been due to slot availability.\n\nTHANK YOU very much.","author_login":"DaveD5501","author_association":"NONE","created_at":"2023-10-27T14:40:42+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1784039090","fragment_type":"issue_comment","sequence":14,"text":"Great it finally worked, and thank you again for reporting this and for your patience, it helped us solve an issue probably faced by other users.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-29T08:57:15+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1784040226","fragment_type":"issue_comment","sequence":15,"text":"And btw, yes, the 12 hours is just \"bad luck\". There was other requests in the pipe, and lot of them also took significant time to complete ; you could request it down it would start immediately to process ^^","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-29T09:03:04+08:00","repo_name":"openzim/zimit","issue_id":1945261146,"issue_number":224,"issue_url":"https://github.com/openzim/zimit/issues/224","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1956696791","fragment_type":"issue_description","sequence":0,"text":"Pass same User-Agent to check_url and crawler\nAs of today, at startup zimit is:\n- checking the URL with check_url, which uses Python requests\n - no useragent is specified, so default one is used, e.g. `python-requests/2.31.0`\n- starting browsertrix crawler\n - either browsertrix default user agent or the one specified to zimit through CLI flags is used\n\nIn all cases, the target server is hence receiving two requests from the same IP in few seconds from two different user agents. \n\nThis is not a good thing, and might even be the cause of #224.\n\nWe should use the same User-Agent for both situations.","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-23T09:05:07+08:00","repo_name":"openzim/zimit","issue_id":1956696791,"issue_number":227,"issue_url":"https://github.com/openzim/zimit/issues/227","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774768743","fragment_type":"issue_comment","sequence":1,"text":"That's very unlikely. This is an isolated **single HEAD request** that happens prior to the crawler staring and then emitting as much requests as it can, using an odd User-Agent.\nKeep in mind that an enormous share of Internet users use a shared IP address with their colleagues, household, or ther devices (phone), etc. I'd eat my arm if it was the reason for #224 😅\n \n\nAbsolutely.","author_login":"rgaudin","author_association":"MEMBER","created_at":"2023-10-23T09:18:42+08:00","repo_name":"openzim/zimit","issue_id":1956696791,"issue_number":227,"issue_url":"https://github.com/openzim/zimit/issues/227","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774788013","fragment_type":"issue_comment","sequence":2,"text":"I hope you are hungry, because I reproduced the issue 🤣\n\n \n \n \n406\n\nAnd then from this point, any requests (curl, python, whatever) from the same machine (IP, I imagine) fails with 405 errors.\n\nFrom a different machine:\n\n \n \n \n200\n \n \n200\n\nTada ... (yes, I hate this behavior, but I suspect this might even be the root cause of some situations of #185)","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-23T09:29:49+08:00","repo_name":"openzim/zimit","issue_id":1956696791,"issue_number":227,"issue_url":"https://github.com/openzim/zimit/issues/227","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774811259","fragment_type":"issue_comment","sequence":3,"text":"😨 Not so fast, the problem is not the one I quoted (ie. different UA from same IP) but the fact that any request with a `python-requests/` prefixed UA blacklists the IP for some time \n\npy\nIn [1]: import requests\n ...: resp = requests.head(\" URL headers={\"User-Agent\": \"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0\"})\n ...: print(resp.status_code)\n ...: resp = requests.get(\" URL headers={\"User-Agent\": \"Mozilla/5.0 (Macintosh; Intel Mac OS X x.y; rv:42.0) Gecko/20100101 Firefox/42.0\"})\n ...: print(resp.status_code)\n200\n200\n\nIn [2]:","author_login":"rgaudin","author_association":"MEMBER","created_at":"2023-10-23T09:42:49+08:00","repo_name":"openzim/zimit","issue_id":1956696791,"issue_number":227,"issue_url":"https://github.com/openzim/zimit/issues/227","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774889068","fragment_type":"issue_comment","sequence":4,"text":"You are right, sorry 😉\n\nBut this still needs to be fixed, and this is still very aggressive (I now know how to prevent a whole company/campus from accessing some websites, just do one HEAD request with `python-requests` UA from their public web browsing IP ...)","author_login":"benoit74","author_association":"COLLABORATOR","created_at":"2023-10-23T10:24:51+08:00","repo_name":"openzim/zimit","issue_id":1956696791,"issue_number":227,"issue_url":"https://github.com/openzim/zimit/issues/227","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0478","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"More about key reuse?","query_context":"So, I think I have a use case for key reuse for composite signatures. To allow the use of the native and alternative private and public keys of Catalyst (hssss) certificates to generate composite signatures. Composite private and public keys for the certificate wouldn't exist in the wild, but the native and alternative private keys of a certificate could be used to generate a composite signature.\n\nDue to the flexibility of these certificates, this means that a signature could be generated corresponding to the native key, the alternative key, or a composite of the native+alternative key.\n\nSome of you authors already know that I'm not generally in favour of Catalyst certificates, but there are those out there who still want to use them, so I'm coming at this from a harm-reduction perspective. And also from a forward-looking perspective, this draft is setting the standard for composite signatures. It would be easier if future composite signatures, for example PQ/PQ, could use the framework of this draft (and implementation) to define other composites (obviously with specific security considerations for the component algorithms involved). At that point, both component algorithms may take a context and key reuse could be done safely.\n\nTo that end, I wonder if it would be worth considering enabling key reuse of the component algorithms which take a context parameter by changing the context from:\n\nctx = Domain\n\nto:\n\nctx = Domain || Hash(PublicKey1 || PublicKey2)\n\nThis would provide domain separation for a key, ML-DSA for example, to be used standalone or as part of multiple composite keys (even multiple composite keys with the same Domain, because the key hash achieves the separation). I don't claim it's a good idea to reuse a key in multiple composite keys with the same Domain, just that this idea would protect the key if that happened.\n\nI'm interested in your opinions.","known_context_document_ids":["gh_issue_2611318460"],"reference_answer":"The RFC's for the ED448 and X25519 forbid use of the contexts, so doing the above violates our principal of using black-box implementations that already exist today.","answer_document_id":"gh_comment_2859035694","silver_evidence_path":["gh_comment_2436398961","gh_issue_2592162295","gh_comment_2859035694"],"evidence_issue_ids":[2611318460,2592162295],"source_repo_name":"lamps-wg/draft-composite-sigs","source_issue_id":2611318460,"source_issue_number":79,"source_issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","target_repo_name":"lamps-wg/draft-composite-sigs","target_issue_id":2592162295,"target_issue_number":64,"target_issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/64","reference_anchor_document_id":"gh_comment_2436398961","reference_answer_author":"johngray-dev","reference_answer_author_association":"COLLABORATOR","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.2366,"anchor_target_overlap":0.303,"target_answer_overlap":0.1429},"issue_created_at":"2024-10-24T11:46:02+08:00","valid_comment_count":17,"fragments":[{"document_id":"gh_issue_2611318460","fragment_type":"issue_description","sequence":0,"text":"More about key reuse\nSo, I think I have a use case for key reuse for composite signatures. To allow the use of the native and alternative private and public keys of Catalyst (hssss) certificates to generate composite signatures. Composite private and public keys for the certificate wouldn't exist in the wild, but the native and alternative private keys of a certificate could be used to generate a composite signature.\n\nDue to the flexibility of these certificates, this means that a signature could be generated corresponding to the native key, the alternative key, or a composite of the native+alternative key.\n\nSome of you authors already know that I'm not generally in favour of Catalyst certificates, but there are those out there who still want to use them, so I'm coming at this from a harm-reduction perspective. And also from a forward-looking perspective, this draft is setting the standard for composite signatures. It would be easier if future composite signatures, for example PQ/PQ, could use the framework of this draft (and implementation) to define other composites (obviously with specific security considerations for the component algorithms involved). At that point, both component algorithms may take a context and key reuse could be done safely.\n\nTo that end, I wonder if it would be worth considering enabling key reuse of the component algorithms which take a context parameter by changing the context from:\n\nctx = Domain\n\nto:\n\nctx = Domain || Hash(PublicKey1 || PublicKey2)\n\nThis would provide domain separation for a key, ML-DSA for example, to be used standalone or as part of multiple composite keys (even multiple composite keys with the same Domain, because the key hash achieves the separation). I don't claim it's a good idea to reuse a key in multiple composite keys with the same Domain, just that this idea would protect the key if that happened.\n\nI'm interested in your opinions.","author_login":"danvangeest","author_association":"NONE","created_at":"2024-10-24T11:46:02+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2435065842","fragment_type":"issue_comment","sequence":1,"text":"As Scott says elsewhere, 'belt and suspenders` but this is belt and suspenders and superglue.","author_login":"danvangeest","author_association":"NONE","created_at":"2024-10-24T11:52:23+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2436398961","fragment_type":"issue_comment","sequence":2,"text":"My first thought is what if the signer doesn't have access to the public key? My second thought is this works great to obtain what you want for ML-DSA or other component algorithms that take a context, but not at all for the ones that don't (which is RSA and most EC combinations except the Edwards ones). So at best in the context of the current draft it would give us separation for 1 of the components, but not the others, which would foil our security claim of EUF-CMA as long as one of them is EUF-CMA. My third thought is that we had thought about this property a few years ago (For instance, it would work with multiple independent certs as well), and there probably are lots of interesting use cases where keys could be joined to make a composite signature. After lots of discussions it seems this property wasn't desired in lieu of the security implications it brought to composite. \n\nPerhaps for combinations where a context string is used in BOTH algorithms this could make sense... We had talked about using context strings for other components that could support it. See URL but it was mostly decided against because the most compatible way is to use no context String... \n\nSo in summary for cases where both components take contexts, I would say it is interesting. For cases where some components don't take a context String, i don't think we want to go there.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2024-10-24T21:52:10+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[2592162295],"is_known_query_context":false},{"document_id":"gh_comment_2453055650","fragment_type":"issue_comment","sequence":3,"text":"Here is someone trying to combine separate keys using the composite signature construct. Check out IPSECME on Monday to see/influence how that goes.\n URL \n\nRegarding your second thought, yes it protects ML-DSA but not the trad key. My point is if someone is going to end up doing this anyways, better to protect only the ML-DSA key than neither key.","author_login":"danvangeest","author_association":"NONE","created_at":"2024-11-02T17:28:40+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2643842652","fragment_type":"issue_comment","sequence":4,"text":"Just looking at this again. Dan, are you suggesting that if we made this change:\n\nctx = Domain\n\nto:\n\nctx = Domain || Hash(PublicKey1 || PublicKey2)\n\nWe should allow re-use of the ML-DSA key (or any other context-supporting algorithm) in some other context? \n\nAn attacker could still construct the above ctx and pass that to a regular ML-DSA verifier (with context) and get the stripped signature validated. We recently added a prefix to mitigate this issue in traditional verifiers, #86 but I suppose it could be used by a pure ML-DSA verifier to determine if it is coming from a composite. Then a setting whether a composite validation is being attempted or not would be needed.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-02-07T19:26:43+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2657067370","fragment_type":"issue_comment","sequence":5,"text":"If the attacker can control the context used by a signer or verifier then the context parameter has no value and we shouldn't use it anywhere. Wherever a signature context is used, it should be a value entirely controlled by the signer or a protocol-specific value.\n \n\nThe extra context data doesn't have to be derived from the public key, it just has to be something unique to the composite keypair. It could even be some random bytes that is encoded into the composite private and public key formats so both signer and verifier have the same value. The important thing is that it is unique to a single composite keypair. \n \n\nI am asking:\n- Do you think, despite key reuse being forbidden, people will try to do it? I think that fact that draft-hu-ipsecme-pqt-hybrid-auth/ already exists suggests yes.\n- If we think people will try to do key reuse, should this draft try to protect them as best it can, despite having told them not to do it?\n- Alternately, if we have a way to do composites in a way that allows key reuse, should we?\n\nMy idea above would not protect ECDSA/RSA from key reuse, but this comment from a different issue is interesting: URL but was never addressed. It claims to give strong non-separability, although if the component keys were mixed and matched into different composites I think you could still get some separability-adjacent issues. If you took that idea and used a unique context per pair of composite keys (public key hashes, or random bytes encoded in the private and public key) then I think you could fix the mix-and-match problem.","author_login":"danvangeest","author_association":"NONE","created_at":"2025-02-13T16:04:54+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2692516865","fragment_type":"issue_comment","sequence":6,"text":"I'm consolidated the idea in #64 since it was related. I think it is an interesting idea to add context separation and the lower algorithm level for ALL algorithms. Today we only add the lower level context separation for ML-DSA... I reference Illari's idea from URL as well.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-03-02T02:10:44+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[2592162295],"is_known_query_context":false},{"document_id":"gh_comment_2692564920","fragment_type":"issue_comment","sequence":7,"text":"I've added the comments for #86 into #64. I think we should still forbid Key Reuse, but we could implement your idea which was mirror in URL which I've copied to #64. Essentially making use of context in all algorithms where it can be used, or wrapping algorithms that don't support context with a SHAKE(M',ctx=composite-sigs). I think I want to bring this to the mailing list, but I do think it is an interesting idea... \n\nA couple reasons against it:\n- I know some crypto libraries that don't support SHAKE which would now be required to add support for SHAKE BEFORE they could support composite\n- Many crypto libraries don't support the context in Ed448 or Ed25519","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-03-02T05:23:36+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[2592162295],"is_known_query_context":false},{"document_id":"gh_comment_2859016708","fragment_type":"issue_comment","sequence":8,"text":"Hi Dan,\n\nWe have discussed this numerous times as an authors group. We keep coming back to the conclusions\n- Timing issue \n - we don't want to further delay the document by needing further cryptographic review.\n- Usability issues: \n - needing to have the public keys at signing time\n - encoding of the public keys needs to be identical on both sides, which may not always be the case. \n\nThe above are mitigated by the fact that re-use is forbidden. This seems like a good middle ground compromise. This is also mitigated by Falco's suggestion of the prefix which if used by a traditional verifier would detect that it should have been a composite signature and not a single signature.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-05-07T15:19:07+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2910621003","fragment_type":"issue_comment","sequence":9,"text":"In the context of an HSM, the above idea doesn't work as the signer doesn't even have access to the private key... All they have is a reference to the private key. Therefore any artifacts added to the private key will not be available, meaning the full private key is not available.\n\nI discussed this with Mike Ounsworth today, and probably the best option is to make use of the application specific context if you want to use composites with the Catalyst certificate. So if we add something like the following to the draft, does this satisfy your request Dan?\n\n\"In the event that an application wishes to use two separate keys (for example from two single-algorithm certificates) and use them to construct a single Composite Signature, then it is RECOMMENDED to provide a composite ctx to prevent this signature from being validatable under a composite key made up of the same two component keys.\n\nFor example, an application or protocol called Foobar that wishes to do this might invoke the Composite algorithm as:\nComposite-ML-DSA.Sign( (sk1, sk2), M ctx=\"Foobar-dual-cert-sig\", PH)\"","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-05-26T20:59:41+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2921743217","fragment_type":"issue_comment","sequence":10,"text":"I don't think that suggestion would help since the application context being provided is only used to create the Composite-ML-DSA M'. So a component signature can still be separated from the composite signature to provide a valid single-algorithm signature for M'. The suggestion would help when using the same composite keypair in two different protocols, but it wouldn't help when using the composite keypair and reusing one of the components.","author_login":"danvangeest","author_association":"NONE","created_at":"2025-05-30T09:15:28+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2922567225","fragment_type":"issue_comment","sequence":11,"text":"Hi Dan,\n\nThe suggestion was for usages outside of this specification like in the catalyst certificate as you mention. Of course anyone that knows the application specific context could re-construct the message:\n\nM' = prefix | domain | ctx(len) | ctx | HashOID | PH (r | Message) \n\nAs of this week, they would also need the r from the full composite signature to make the construction before they could verify. At that point if they are doing all this message work to verify one component of the composite signature, they are basically purposefully doing a partial composite validation but calling it a single validation.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-05-30T14:33:38+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2935023336","fragment_type":"issue_comment","sequence":12,"text":"Would putting the application context or possibly r into the ML_DSA context help? Lets think about it.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-06-03T12:33:13+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2936423239","fragment_type":"issue_comment","sequence":13,"text":"Thanks Dan,\n\nI agree, adding the r into the context gives the attacker some control over the context string, which could be manipulated.\n\nSo we are left with this:\n \n\nThe r does help with some subset of key reuse, but not all cases. It solves we call the \"mixed-key forgery attack\": Take two composite keys `(mldsaPK1, tradPK1)` and `(mldsaPK2, tradPK2)` which do not share any key material and have them produce signatures `(r1, mldsaSig1, tradSig1)` and `(r2, mldsaSig2, tradSig2)` respectively over the same message `M`. Consider whether it is possible to construct a forgery by swapping components and presenting `(r, mldsaSig1, tradSig2)` that verifies under a forged public key `(mldsaPK1, tradPK2)`. This forgery attack is blocked by the randomizer `r` so long as `r1 != r2`.\n\nAlso if we have this more conventional key re-use scenario\n\nKeya = MldsaA+TradA1\nKeyb = MldsaA+TradA2\n\nAny signature produced by Key1 or Key2 would be of the form\n(r1, siga1,siga2) -> siga\n(r2, sigb1, sigb2) ->sigb\n\nM1 = prefix | domain | ctx(len) | ctx | HashOID | r1 | PH (r1 | Message)\nM2 = prefix | domain | ctx(len) | ctx | HashOID | r2 | PH (r2 | Message)\n\nIf you try to verify siga using the sigb key (as a composite), it will fail thanks to the traditional component, but that doesn't prevent key re-use:\nYou need to compute:\nM1 = prefix | domain | ctx(len) | ctx | HashOID | r1 | PH (r1 | Message)\nKeyb.mldsa would be able to replace Keyb.mldsa (its the same key and ctx domain), but the traditional component would still cause an overall failure. \n\n- if r1 was passed down into the ML-DSA ctx, so that MLDSA.ctx = domain | r1 then:\n\nMLDSA.Verify(Keyb.MldsaA, M1,ctx=domain | r1) = MLDSA.Verify(Keya.MldsaA, M1, ctx=domain | r1)\n\nSo it wouldn't help at all.\n\n- if Hash (Keya) is passed down into the ML-DSA ctx, so that MLDSA.ctx = domain | Hash (Keya) - the original request:\n\nk = Hash(Keya)\nMLDSA.Verify(Keyb.MldsaA, M1, ctx=domain | k) != MLDSA.Verify(Keya.MldsaA, M1, ctx=domain | Hash(Keyb) )\n\nThis works because you can do a check on the full public key being used to verify the signature at that instance. I think the only solution is probably using the Hash of the public key (or some combined aspects of the key itself that can be checked by the honest composite verifier). Thus we have come full circle. \n\nSo unfortunately, given the design constraint of not wanting to require access to the public key at signing time, and the fact that the private key components may not always be available in bytes but only in a reference on a HSM, I think we are left with the very strong language against key re-use in the draft.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-06-03T17:32:16+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2611318460,"issue_number":79,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/79","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2592162295","fragment_type":"issue_description","sequence":0,"text":"Should we use the context String for the underlying ED448 and X25519 algorithms\nWe are using the Domain as a context String for ML-DSA,\n\nWe can't use the Domain as the context for RSA or ECDSA as they algorithms don't take a context string.\n\nHowever, ED448 and X25519 do use a context String and could be used. \n\nThat would likely give us SUF security for those algorithm combinations.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2024-10-16T14:59:16+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2592162295,"issue_number":64,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2427582095","fragment_type":"issue_comment","sequence":1,"text":"Both RFC8410 (EdDSA in X.509) and RFC8419 (EdDSA in CMS) say explicitly that the context string is not used. Since currently X.509 and CMS do not use the context string of EdDSA, then the most backwards compatible thing is to maintain that behaviour for the EdDSA component.","author_login":"ounsworth","author_association":"CONTRIBUTOR","created_at":"2024-10-21T19:47:35+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2592162295,"issue_number":64,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2692511298","fragment_type":"issue_comment","sequence":2,"text":"The comments from Illari in this comment: URL would possibly allow context separation to work for all the algorithms. Maybe this is something to put on a slide at 122.\n\nAdding the text here so its not lost:\nAlternatively, since RSA and ECDSA actually sign a hash, and everything else relevant has context inputs, one could do something like the follows to get actual strong non-separability (even for RSA and ECDSA):\n\nPure:\n\nM' = Domain | 0 | len(ctx) | ctx | M\n\nPrehashed:\n\nM' = Domain | 1 | len(ctx) | ctx | HashOID | PH(M)\n\nRSA:\n\nRSA_signhash(cSHAKE256(M', ctx=\"sig-composite\"))\n\nECDSA:\n\nECDSA_signhash(bytes2bits_be(cSHAKE256(M', ctx=\"sig-composite\")))\n\nEd25519:\n\nEd25519ctx_sign(M', ctx=\"sig-composite\")\n\nEd448:\n\nEd448_sign(M', ctx=\"sig-composite\")\n\nML-DSA:\n\nMLDSA_sign(M', ctx=\"sig-composite\")\n\nSome notes:\n\nThe bytes2bits_be() is to ensure that ECDSA interprets the hash in the expected way.\nThis aligns with the model presented in the meeting.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-03-02T01:56:35+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2592162295,"issue_number":64,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2826338424","fragment_type":"issue_comment","sequence":3,"text":"@johngray-dev is this issue still open, or have we decided to stay with the current design?","author_login":"ounsworth","author_association":"CONTRIBUTOR","created_at":"2025-04-24T04:21:50+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2592162295,"issue_number":64,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/64","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2859035694","fragment_type":"issue_comment","sequence":4,"text":"The RFC's for the ED448 and X25519 forbid use of the contexts, so doing the above violates our principal of using black-box implementations that already exist today.","author_login":"johngray-dev","author_association":"COLLABORATOR","created_at":"2025-05-07T15:24:02+08:00","repo_name":"lamps-wg/draft-composite-sigs","issue_id":2592162295,"issue_number":64,"issue_url":"https://github.com/lamps-wg/draft-composite-sigs/issues/64","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0479","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Question-How are streams determined from files?","query_context":"For example, I have a plexon file that contains data grouped into 3 catagories. The wideband, the field potential of the wideband, and the spikes from the wideband. When reading the file and accessing a specific stream, the field potential is grouped into one stream and the wideband as well as the spikes are grouped into another stream. How are these streams determined and is it possible to separate the wideband and spikes into separate streams so I am able to only access one or the other? The wideband and spikes both have a sampling frequency of 40,000 hertz while the field potential has a sampling frequency of 10,000 hertz?","known_context_document_ids":["gh_issue_2403866526"],"reference_answer":"I agree with @pauladkisson that we should break streams. As a note, Streams are not about different types of preprocessing. It is basically stuff that can be processed together in the context of spikeitnerface and raw.io in neo (same sampling_rate, start and duration). The concept is not documented but you can find somedetails here. \n\nHow to break depth, channel and whatever else might come?\n* I think that depth (moving across planes) is a natural category. Space is there and is not moving anywhere. This should be a thing on its own and be addressed as an index/number. Moreover, this is dimension that the `PhotonSeries` in pynwb accepts and other related modalities take for granted (e.g. brain imaging). I think is a solid well defined concept so it gets a specification.\n* Channel is probably better addressed with a string. Sometimes is going to be a number but I also think that the concept of channel is less defined in ophys. In the current conversion that me and @alessandratrapani are working, this is used to describe two different filters (and therefore two molecules) but this does feel less stable and way more ad-hoc than space. Therefore, I think it should get a very (the most?) general type. \n* Whatever else might come? I feel that the instinct of @CodyCBakerPhD is right in trying to future proof here. We don't know how ophys will change and we might not want to commit ourselves to some specific categories. In that light, creating a common API which is now called streams to reflect this diversity (channel, modality, preprocessing or whatever else) is a good way of building resilient structure that we can move forward as technology changes. With the exception of deph for the reasons mentioned above, I would be fine with having optical channel dumped in streams along anything else that might come in the future specified as keyword argument with type string. This could be stream as we currently have it, could be modality, mode or any other word that we find and agree is better. \n\nAs for this:\n \nMultiImagingExtractor was designed to concatenate ImagingExtractors along the frames axis, but here we want to combine multiple IEs along a separate depth axis.\n\nThis is not true:\n URL \nBut I think it was changed here:\n URL \n\nI agree that we are conflating a tool to concatenate data extractors in time with some internal machinery to assemble extractors from channels, planes or sub-extractors in time. We came to need the latter because some formats provide multiple files and we judged (corrrectly?) that composing in this way is easier than ad-hoc parsing. I think it makes sense separting assembling in time, channels and depth.\n\nThe analgous in spikeinterface are concatenation and channel agregation.\n \nCan you point out to where does this show up and also add other wonky stuff / difficulties? I feel this point should be more descriptive of existing problems.\n\nI will add something about the third point later.","answer_document_id":"gh_comment_1725081487","silver_evidence_path":["gh_comment_2225755572","gh_issue_1901565182","gh_comment_1725081487"],"evidence_issue_ids":[2403866526,1901565182],"source_repo_name":"NeuralEnsemble/python-neo","source_issue_id":2403866526,"source_issue_number":1507,"source_issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","target_repo_name":"catalystneuro/roiextractors","target_issue_id":1901565182,"target_issue_number":245,"target_issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","reference_anchor_document_id":"gh_comment_2225755572","reference_answer_author":"h-mayorquin","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.2857,"anchor_target_overlap":0.3091,"target_answer_overlap":0.2896},"issue_created_at":"2024-07-11T18:44:51+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2403866526","fragment_type":"issue_description","sequence":0,"text":"Question-How are streams determined from files?\nFor example, I have a plexon file that contains data grouped into 3 catagories. The wideband, the field potential of the wideband, and the spikes from the wideband. When reading the file and accessing a specific stream, the field potential is grouped into one stream and the wideband as well as the spikes are grouped into another stream. How are these streams determined and is it possible to separate the wideband and spikes into separate streams so I am able to only access one or the other? The wideband and spikes both have a sampling frequency of 40,000 hertz while the field potential has a sampling frequency of 10,000 hertz?","author_login":"AbhiSwamiUConn","author_association":"NONE","created_at":"2024-07-11T18:44:51+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2225378618","fragment_type":"issue_comment","sequence":1,"text":"plexon 1 or plexon 2? (plx for pl2 files). The docs explain the general idea here. \n\nBut basically if the sampling frequencies are different they have to be different streams. I'm surprised Wideband and spikes are in the same stream. Once you let me know which plexon I'll dig into more :)","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T11:32:42+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225602056","fragment_type":"issue_comment","sequence":2,"text":"I see. yeah that might be a little bit of poor organization on our part. It seems like with the current setup you would just have to do a channel slice to get the correct channel for your purposes instead. Could you do the following and put it here.\n\npython\nfrom neo.rawio import PlexonRawIO\n\nreader = PlexonRawIO(file_name)\n\nreader.parse_header()\n\nprint(reader)\nprint(reader.header)\n\nOnce I double check how that displays I could check to see if there is a way to split those into separate streams. I might need a test file though.","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T13:33:03+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225610789","fragment_type":"issue_comment","sequence":3,"text":"That's why I'm having you run the print reader and print reader.header. If we aren't labeling the channels right, then it would be impossible, but often we give the channel's \"names\" which you could use to do the slice. Could you do the script I posted above so we can see if it is possible or whether we need to patch that right away ?","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T13:37:54+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225671679","fragment_type":"issue_comment","sequence":4,"text":"Spikeinterface defaults to the channel_ids\n\nso above we have ('WB01', '0',), so channel_name 'WB01' is channel_id '0' and channel_index 0. So yes for a `ChannelSliceRecording` in this case you slice from '0' - '15' to only get the WB channels.","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T14:11:10+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225674690","fragment_type":"issue_comment","sequence":5,"text":"It might be helpful if we make the channel_ids more meaningful in this case since we are losing WB vs spike information when going from name -> id which could cause mistakes for end users. I'll wait for some neuroconv people to weigh in, but I think if we can guarantee that the names are unique then we could use the names as the ids as well.","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T14:12:53+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225755572","fragment_type":"issue_comment","sequence":6,"text":"Two things:\n1) At spikeinterface level there is an option to change names as ids that should be used for plexon. I think this will make it easier. I will open a PR.\n2) @AbhiSwamiUConn I have a question, are you referring to the channels called `SPKC` as spikes? According to a plexon engineer that contribute here recently says that is just a filtered version of the wideband . That's the reason they are the same stream, they have the same dtype, they come from the same file and they have the same sampling rate.\n\nI think that a stream is a very unfortunate name that has already expanded to other parts of the ecosystem and has lead to a lot of confusion. The thing is that `stream` is just an implementation detail of neo. It is the part of the format data that cean be thought as a single block and put into a numpy or memmap array. That's why it is defined by having the same dtype, sampling_frequency, shape and coming from the same file. Nothing more.\n\nThe problem is that we expose this implementation detail at the user level interface by making users access the data through streams. Users then get confused thinking that stream must mean something like \"a type of qualitatively different data\" and in some cases it makes sense (neuropixel has a stream for ap and lf bands for example) but in some others it does not see here my own confusion in the past:\n\n URL \n\nI don't know if this should be made more prominent in the docs. As I mention it has lead to confusion in others parts of the ecosystem:\n URL","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T14:48:57+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[1901565182],"is_known_query_context":false},{"document_id":"gh_comment_2225808549","fragment_type":"issue_comment","sequence":7,"text":"Thanks for the clarification:\nIn spikeinterface it should be easy if we merge this PR:\n URL","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T15:16:38+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2225886855","fragment_type":"issue_comment","sequence":8,"text":"Thanks for clarifying both. Sorry yeah spikes in neo are suppose to be their own thing, but if spkc if just filtered than in Neo parlance it would absolutely be in the same stream. \n\nI agree we should probably find a better explanation of stream for our docs!","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T16:02:02+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226135338","fragment_type":"issue_comment","sequence":9,"text":"OK, now that URL is merged on spikeinterface I wrote the asnwer to your question in #3196 @AbhiSwamiUConn \n\nI think that we can close this @zm711 or maybe you want to leave it open until we write better documentation for this? The thing is that I am not sure the stream is ever exposed on neo directly, right?","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T18:17:46+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226138184","fragment_type":"issue_comment","sequence":10,"text":"Actually, final question @AbhiSwamiUConn. Do you happen to know what are the types of filering that is implemented for the \"FP\" and \"SPKC\" channels? It would be good for us to know more about this metadata.","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T18:19:34+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226143010","fragment_type":"issue_comment","sequence":11,"text":"They are exposed. here for example. The stream index gives us the sample rate, the gain, and the offset for the data so we can convert it and is necessary for the user functions. So I think we do need to document it. But stream itself is not exposed, just the indices of the streams. Is that your point?","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T18:22:49+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226208592","fragment_type":"issue_comment","sequence":12,"text":"My question was not well phrased. I guess the core of my question? Do users of neo need to know about streams the same way that users of spikeinterface need to know about streams?\n\nIn spikeinterface you need to know the streams to access the data but as I am not a userr of neo I don't know how users interact with the concept of stream and if this type of confusion can arise at the neo level.","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T19:10:49+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226234028","fragment_type":"issue_comment","sequence":13,"text":"Yes. \n\npython\nreader = neo.RawIO()\nreader.parse_header()\n\nin this example the reader will have the memmap for all streams, but to actually pull out the data you need to specify which stream of data you want. I would actually say that spikeinterface is nicer in that it can be fed with name, whereas all the functions at the rawio level expect the stream index. So you run into the issue that if you don't know the IO it isn't clear how to get what you want \n\nie how do you get digital data for intan -> you need stream_index = 3. So you basically need to look in the header to see which stream goes where. Again Intan has good names in the header, but it seems like Plexon says streams are Signal 0 and Signal 1 which aren't super helpful.","author_login":"zm711","author_association":"COLLABORATOR","created_at":"2024-07-12T19:30:46+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226263301","fragment_type":"issue_comment","sequence":14,"text":"Yes, we probably should have better signal streams in plexon but I we will need someone who actually has experimental experience with the format to venture in that direction.","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T19:56:15+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2226263996","fragment_type":"issue_comment","sequence":15,"text":"Thanks, I wonder if the values of the bandpass are fixed or something that people decide at run time.","author_login":"h-mayorquin","author_association":"CONTRIBUTOR","created_at":"2024-07-12T19:56:39+08:00","repo_name":"NeuralEnsemble/python-neo","issue_id":2403866526,"issue_number":1507,"issue_url":"https://github.com/NeuralEnsemble/python-neo/issues/1507","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1901565182","fragment_type":"issue_description","sequence":0,"text":"Unify Volumetric/MultiPlane Imaging API\n# Current Behavior\n\nRight now, the only imaging extractor that supports 3D imaging is BrukerTiff. It does so by taking a list of `SinglePlaneImagingExtractors` and combines them a la `MultiImagingExtractor`. Note that each `SinglePlaneImagingExtractor` is itself a `MultiImagingExtractor` that combines multiple 'chunked' files corresponding to a single depth plane. Each `SinglePlaneImagingExtractor` instance only supports 1 channel and 1 plane, which are passed via `stream_name` during the `__init__`. Each `MultiPlaneImagingExtractor` instance supports 1 channel (but all planes) which is passed via `stream_name` during the `__init__`.\n\n# Issues\n\n- 'streams' are a low-cohesion concept to represent optical channels and depth planes.\n - They are referred to by string names, which can be different in the `MultiPlaneImagingExtractor` (which only needs to specify the channel) and the `SinglePlaneImagingExtractor` (which needs to specify some formatted combination of channel and plane).\n - They are supposed to be analogous to 'AP', 'LF', etc. streams in spikeinterface, but those streams refer to collections of channels that undergo different types of pre-processing. In contrast, each stream as they are implemented in BrukerTiff just refer to 1 channel and 1 plane. There may be a relevant parallel in ophys (ex. functional vs anatomical streams), but specifying a plane/channel combo is not that parallel.\n - optical channels and depth planes are fully independent concepts (1 plane + many channels, 1 channel + many planes, many channels + many planes are all possible) with rich associated metadata that can guide the API: channel name, channel wavelength, plane depth, etc. By lumping these two axes together as 'streams' we lose the ability to interact with them separately.\n- Combining multiple `SinglePlaneImagingExtractors` with `MultiImagingExtractor` is a bit hacky and confusing.\n - `MultiImagingExtractor` was designed to concatenate `ImagingExtractors` along the `frames` axis, but here we want to combine multiple `IEs` along a separate depth axis.\n - Using `MultiImagingExtractor` for this purpose leads to wonky stuff like `start_frames = [0, 0, ..., 0]`.\n- BrukerTiff specifies channel during the `__init__` but all other IE's specify channel during the call to `get_video`.\n - Not sure which is better, but we should be consistent.\n\n# Proposed Solutions\n\n- Specify channel and plane separately by index (or ID?) and then the extractor handles the logic of how to load that channel/plane combo in their file structure (Bruker, ScanImage, etc.)\n- Add a `MultiPlaneImagingExtractor` base class to handle the combination of IE's along the depth axis. Could come with extra metadata properties like `get_plane_depth`.\n- We need to specify plane at `__init__` time so that SinglePlaneImagingExtractors can be appropriately combined into MultiPlaneImagingExtractors. So, to keep it consistent we should specify channel also at `__init__` time. This will require refactoring of all the existing IE's but I think it is the most convenient implementation agnostic to file structure. It also simplifies `get_video` to only take `start_frame` and `end_frame`, which I think is a good thing.\n\n### Do you have any interest in helping implement the feature?\n\nYes.\n\n### Code of Conduct\n\n- [X] I agree to follow this project's Code of Conduct\n- [X] Have you ensured this bug was not already reported?","author_login":"pauladkisson","author_association":"MEMBER","created_at":"2023-09-18T19:00:48+08:00","repo_name":"catalystneuro/roiextractors","issue_id":1901565182,"issue_number":245,"issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1724205335","fragment_type":"issue_comment","sequence":1,"text":"@CodyCBakerPhD @h-mayorquin @weiglszonja @alessandratrapani Please let me know what you all think!","author_login":"pauladkisson","author_association":"MEMBER","created_at":"2023-09-18T19:01:30+08:00","repo_name":"catalystneuro/roiextractors","issue_id":1901565182,"issue_number":245,"issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1724226173","fragment_type":"issue_comment","sequence":2,"text":"@pauladkisson Thanks for writing this all up, I'll look deeper and leave more comments over next couple days\n \nNot sure which is better, but we should be consistent.\n\nStrongly against having it in the `get_video` call because it leads to the 4D ambiguity; much clearer to have separate objects for each channel if you want to do anything with them side-by-side, which makes it a field specified at `__init__`\n\nSo totally on board with that solution\n \n\nYes and no - their code will have to be changed, but it was also code that was never tested or used perhaps outside of the `.sbx` case? Which we've also not seen used in quite a while\n \n\n👍\n \n\nYeah, been talking with @h-mayorquin about this lately. It's purposely ambiguous to also allow any other type of future formatting distinction we might need to add while remainig universal across the API\n\nIt's also flatter and simpler, though what it really does is shift the complexity of structure to the string itself, but as long as we have a convenient fetcher `get_stream_names` that is less complicated than breaking the approach into separate calls per plane/channel option.\n\nMultiple optic channels found? It shows up as a series of structured strings. Multiple planes found? They show up as another part of the string structure. Want to initialize an extractor? Just specify a single string that matches one of the selections.\n \n\nStrongly against the ID/index route. Neo supports both at the same time and the ID is the annoying one, the bane of many a stream index issue. Strongly recommend using a human-readable identifier. Less strongly against splitting `stream_name` into `channel_name` + `plane_name` if others think that is worth it compared to my 'single argument is simpler' point above","author_login":"CodyCBakerPhD","author_association":"MEMBER","created_at":"2023-09-18T19:16:05+08:00","repo_name":"catalystneuro/roiextractors","issue_id":1901565182,"issue_number":245,"issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1725081487","fragment_type":"issue_comment","sequence":3,"text":"I agree with @pauladkisson that we should break streams. As a note, Streams are not about different types of preprocessing. It is basically stuff that can be processed together in the context of spikeitnerface and raw.io in neo (same sampling_rate, start and duration). The concept is not documented but you can find somedetails here. \n\nHow to break depth, channel and whatever else might come?\n* I think that depth (moving across planes) is a natural category. Space is there and is not moving anywhere. This should be a thing on its own and be addressed as an index/number. Moreover, this is dimension that the `PhotonSeries` in pynwb accepts and other related modalities take for granted (e.g. brain imaging). I think is a solid well defined concept so it gets a specification.\n* Channel is probably better addressed with a string. Sometimes is going to be a number but I also think that the concept of channel is less defined in ophys. In the current conversion that me and @alessandratrapani are working, this is used to describe two different filters (and therefore two molecules) but this does feel less stable and way more ad-hoc than space. Therefore, I think it should get a very (the most?) general type. \n* Whatever else might come? I feel that the instinct of @CodyCBakerPhD is right in trying to future proof here. We don't know how ophys will change and we might not want to commit ourselves to some specific categories. In that light, creating a common API which is now called streams to reflect this diversity (channel, modality, preprocessing or whatever else) is a good way of building resilient structure that we can move forward as technology changes. With the exception of deph for the reasons mentioned above, I would be fine with having optical channel dumped in streams along anything else that might come in the future specified as keyword argument with type string. This could be stream as we currently have it, could be modality, mode or any other word that we find and agree is better. \n\nAs for this:\n \nMultiImagingExtractor was designed to concatenate ImagingExtractors along the frames axis, but here we want to combine multiple IEs along a separate depth axis.\n\nThis is not true:\n URL \nBut I think it was changed here:\n URL \n\nI agree that we are conflating a tool to concatenate data extractors in time with some internal machinery to assemble extractors from channels, planes or sub-extractors in time. We came to need the latter because some formats provide multiple files and we judged (corrrectly?) that composing in this way is easier than ad-hoc parsing. I think it makes sense separting assembling in time, channels and depth.\n\nThe analgous in spikeinterface are concatenation and channel agregation.\n \nCan you point out to where does this show up and also add other wonky stuff / difficulties? I feel this point should be more descriptive of existing problems.\n\nI will add something about the third point later.","author_login":"h-mayorquin","author_association":"COLLABORATOR","created_at":"2023-09-19T08:47:28+08:00","repo_name":"catalystneuro/roiextractors","issue_id":1901565182,"issue_number":245,"issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1728310764","fragment_type":"issue_comment","sequence":4,"text":"Thanks for the pointer @weiglszonja. I still would like to see more confusions that arise from this use. This is the only case that we have for Paul's second point.","author_login":"h-mayorquin","author_association":"COLLABORATOR","created_at":"2023-09-20T19:29:12+08:00","repo_name":"catalystneuro/roiextractors","issue_id":1901565182,"issue_number":245,"issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1746607116","fragment_type":"issue_comment","sequence":5,"text":"# Notes from Barcelona 2023:\n- Consensus that optical channels should be separate Extractors --> need to refactor old stuff to fit\n- 2 Main goals for the repo:\n - Make conversion easier\n - Define unified API for users like SpikeExtractors in e-phys\n- Guiding Principle: Focus on how it looks for the user (usu. conversions) and then design the API around that\n- specify channel_name and plane_name via string at init\n- look out for segments in the future if/when we get data\n- numpydoc_validation needs some kind of automatic docstring fixer before it's worth adding","author_login":"pauladkisson","author_association":"MEMBER","created_at":"2023-10-04T10:38:22+08:00","repo_name":"catalystneuro/roiextractors","issue_id":1901565182,"issue_number":245,"issue_url":"https://github.com/catalystneuro/roiextractors/issues/245","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0480","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Indexing boolean fields breaks something?","query_context":"python\nclass Something(JsonModel): \n name: str\n should_do_something: bool = Field(index=True, default=True)\n\nMigrator().run()\n\nSomething(name=\"test\").save()\n\nresult:\n\nSomething(pk='01H0HYP3C4YFF1MR6JV9MEZSF4', name='test', should_do_something=True)\n\nexecuting a basic get by pk works fine.\n\npython\nSomething.get('01H0HYP3C4YFF1MR6JV9MEZSF4') \n\nresult:\n\nSomething(pk='01H0HYP3C4YFF1MR6JV9MEZSF4', name='test', should_do_something=True)\n\nwhen running find().all(), the result is empty:\n\npython\nIn [22]: Something.find().all()\nOut [22]: []\n\nIf I set the bool value to Index=False, the indexing starts working fine:\n\npython\nIn [24]: class Something(JsonModel):\n ...: class Meta:\n ...: database = get_redis_instance()\n ...: \n ...: name: str\n ...: should_do_something: bool = Field(index=False, default=True)\n ...: \n\nIn [25]: Migrator().run()\n\nIn [26]: Something.find().all()\nOut[26]: \n[Something(pk='01H0HYP3C4YFF1MR6JV9MEZSF4', name='test', should_do_something=True),\n Something(pk='01H0HYGDBJF50GFRYK9MSPA8DQ', name='test 2', should_do_something=True),\n Something(pk='01H0HYB0MKSMV4QWJ7BM5G2DGH', name='test', should_do_something=True)]","known_context_document_ids":["gh_issue_1711670204"],"reference_answer":"I'm talking to the maintainers of the other Redis OM Clients for different languages to make sure that when we do add booleans to Python there's a common approach where possible.","answer_document_id":"gh_comment_1097901104","silver_evidence_path":["gh_comment_1639123067","gh_issue_1195172257","gh_comment_1097901104"],"evidence_issue_ids":[1711670204,1195172257],"source_repo_name":"redis/redis-om-python","source_issue_id":1711670204,"source_issue_number":510,"source_issue_url":"https://github.com/redis/redis-om-python/issues/510","target_repo_name":"redis/redis-om-python","target_issue_id":1195172257,"target_issue_number":193,"target_issue_url":"https://github.com/redis/redis-om-python/issues/193","reference_anchor_document_id":"gh_comment_1639123067","reference_answer_author":"simonprickett","reference_answer_author_association":"COLLABORATOR","quality_score":75.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1,"target_answer_overlap":0.0},"issue_created_at":"2023-05-16T09:54:17+08:00","valid_comment_count":7,"fragments":[{"document_id":"gh_issue_1711670204","fragment_type":"issue_description","sequence":0,"text":"Indexing boolean fields breaks something\npython\nclass Something(JsonModel): \n name: str\n should_do_something: bool = Field(index=True, default=True)\n\nMigrator().run()\n\nSomething(name=\"test\").save()\n\nresult:\n\nSomething(pk='01H0HYP3C4YFF1MR6JV9MEZSF4', name='test', should_do_something=True)\n\nexecuting a basic get by pk works fine.\n\npython\nSomething.get('01H0HYP3C4YFF1MR6JV9MEZSF4') \n\nresult:\n\nSomething(pk='01H0HYP3C4YFF1MR6JV9MEZSF4', name='test', should_do_something=True)\n\nwhen running find().all(), the result is empty:\n\npython\nIn [22]: Something.find().all()\nOut [22]: []\n\nIf I set the bool value to Index=False, the indexing starts working fine:\n\npython\nIn [24]: class Something(JsonModel):\n ...: class Meta:\n ...: database = get_redis_instance()\n ...: \n ...: name: str\n ...: should_do_something: bool = Field(index=False, default=True)\n ...: \n\nIn [25]: Migrator().run()\n\nIn [26]: Something.find().all()\nOut[26]: \n[Something(pk='01H0HYP3C4YFF1MR6JV9MEZSF4', name='test', should_do_something=True),\n Something(pk='01H0HYGDBJF50GFRYK9MSPA8DQ', name='test 2', should_do_something=True),\n Something(pk='01H0HYB0MKSMV4QWJ7BM5G2DGH', name='test', should_do_something=True)]","author_login":"ilyatovbin-pp","author_association":"NONE","created_at":"2023-05-16T09:54:17+08:00","repo_name":"redis/redis-om-python","issue_id":1711670204,"issue_number":510,"issue_url":"https://github.com/redis/redis-om-python/issues/510","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1639118566","fragment_type":"issue_comment","sequence":1,"text":"I can confirm this as well, that the JSONModel doesn't support indexing boolean fields. Here is my testcase that shows the same thing:\n\npython\n\"\"\"This file demonstrates that redis_om_python cannot index/search boolean fields\"\"\"\nfrom redis_om import Field, JsonModel, Migrator\n\nclass MyObjectBroken(JsonModel):\n my_string: str = Field(index=True)\n my_int: int = Field(index=True)\n my_bool: bool = Field(index=True)\n\nclass MyObjectWorks(JsonModel):\n my_string: str = Field(index=True)\n my_int: int = Field(index=True)\n\nMigrator().run()\n\n# Add some objects that are broken\nobject1 = MyObjectBroken(my_string=\"\", my_int=1, my_bool=False)\nobject1.save()\nobject2 = MyObjectBroken(my_string=\"\", my_int=1, my_bool=False)\nobject2.save()\n\n# Add some objects that work\nobject3 = MyObjectWorks(my_string=\"\", my_int=1)\nobject3.save()\nobject4 = MyObjectWorks(my_string=\"\", my_int=1)\nobject4.save()\n\nobjects = MyObjectBroken.find().all()\nprint(f\"Found {len(objects)} MyObjectBroken expected 2\")\n\nobject_get = MyObjectBroken.get(object1.pk)\nprint(f\"Found {object_get=} MyObjectBroken\")\n\nobjects = MyObjectWorks.find().all()\nprint(f\"Found {len(objects)} MyObjectWorks expected 2\")\n\nobject_get = MyObjectWorks.get(object3.pk)\nprint(f\"Found {object_get=} MyObjectWorks\")\n\nIf you run this, you'll get the following output showing the object with a boolean field doesn't work:\n\ntext\n$ python boolean_field_search_suppport.py\nFound 0 MyObjectBroken expected 2\nFound object_get=MyObjectBroken(pk='01H5K85HDADT687Y25Y7BAEWKK', my_string='', my_int=1, my_bool=False) MyObjectBroken\nFound 2 MyObjectWorks expected 2\nFound object_get=MyObjectWorks(pk='01H5K85HDCCAS49NADBDY39CXQ', my_string='', my_int=1) MyObjectWorks","author_login":"jrwagz","author_association":"NONE","created_at":"2023-07-18T01:03:46+08:00","repo_name":"redis/redis-om-python","issue_id":1711670204,"issue_number":510,"issue_url":"https://github.com/redis/redis-om-python/issues/510","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639123067","fragment_type":"issue_comment","sequence":2,"text":"See URL for where it's defined that booleans aren't supported yet, but seem to be supported at some point?","author_login":"jrwagz","author_association":"NONE","created_at":"2023-07-18T01:10:13+08:00","repo_name":"redis/redis-om-python","issue_id":1711670204,"issue_number":510,"issue_url":"https://github.com/redis/redis-om-python/issues/510","linked_issue_ids":[1195172257],"is_known_query_context":false},{"document_id":"gh_comment_1639149366","fragment_type":"issue_comment","sequence":3,"text":"From my sleuthing, since the `bool` class is implemented as a subclass of the `integer` class, we end up getting a numeric index created:\n\ntext\n\"ft.create\" \":__main__.MyObjectBroken:index\" \"ON\" \"JSON\" \"PREFIX\" \"1\" \":__main__.MyObjectBroken:\" \"SCHEMA\" \"$.pk\" \"AS\" \"pk\" \"TAG\" \"SEPARATOR\" \"|\" \"$.my_string\" \"AS\" \"my_string\" \"TAG\" \"SEPARATOR\" \"|\" \"$.my_int\" \"AS\" \"my_int\" \"NUMERIC\" \"$.my_bool\" \"AS\" \"my_bool\" \"NUMERIC\"\n\nThis is coming from this line:\n URL \n\nFrom the docs of `FT.CREATE` there isn't native support for boolean types, so it likely has to be mapped to `NUMERIC` for this to work, however it's unclear what's going on under the hood here, but I'm guessing that at least a part of it is related to saving actual RedisJSON boolean fields, but telling RediSearch that it's a numeric field.","author_login":"jrwagz","author_association":"NONE","created_at":"2023-07-18T01:43:41+08:00","repo_name":"redis/redis-om-python","issue_id":1711670204,"issue_number":510,"issue_url":"https://github.com/redis/redis-om-python/issues/510","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639162462","fragment_type":"issue_comment","sequence":4,"text":"I found a workaround for this issue. Since the `bool` class is a subclass of the `int` class, you can declare the model field as `int` and then convert between bool/int as necessary.\n\nHere is the code that I tested on redis-om 0.1.3:\n\npython\n\"\"\"This file demonstrates that redis_om_python cannot index/search boolean fields\"\"\"\nfrom redis_om import Field, JsonModel, Migrator\n\nclass MyObjectBroken(JsonModel):\n my_string: str = Field(index=True)\n my_int: int = Field(index=True)\n my_bool: int = Field(index=True) # declare as int, but pass in boolean values works\n\nclass MyObjectWorks(JsonModel):\n my_string: str = Field(index=True)\n my_int: int = Field(index=True)\n\nMigrator().run()\n\n# Add some objects that are broken\nobject1 = MyObjectBroken(my_string=\"\", my_int=1, my_bool=False)\nobject1.save()\nobject2 = MyObjectBroken(my_string=\"\", my_int=1, my_bool=True)\nobject2.save()\n\n# Add some objects that work\nobject3 = MyObjectWorks(my_string=\"\", my_int=1)\nobject3.save()\nobject4 = MyObjectWorks(my_string=\"\", my_int=1)\nobject4.save()\n\nobjects = MyObjectBroken.find().all()\nprint(f\"Found {len(objects)} MyObjectBroken expected 2\")\n\nobjects = MyObjectBroken.find(MyObjectBroken.my_bool == int(False)).all()\nprint(f\"Found {len(objects)} MyObjectBroken with bool as False expected 1\")\n\nobject_get = MyObjectBroken.get(object1.pk)\nprint(f\"Found {object_get=} MyObjectBroken\")\n\nobjects = MyObjectWorks.find().all()\nprint(f\"Found {len(objects)} MyObjectWorks expected 2\")\n\nobject_get = MyObjectWorks.get(object3.pk)\nprint(f\"Found {object_get=} MyObjectWorks\")\n\nHere is the output from it:\n\ntext\n$ python boolean_field_search_suppport.py\nFound 2 MyObjectBroken expected 2\nFound 1 MyObjectBroken with bool as False expected 1\nFound object_get=MyObjectBroken(pk='01H5KBCJMMCY9Z9SY74C87B20N', my_string='', my_int=1, my_bool=0) MyObjectBroken\nFound 2 MyObjectWorks expected 2\nFound object_get=MyObjectWorks(pk='01H5KBCJMP4RM26QSSVB77YKTQ', my_string='', my_int=1) MyObjectWorks","author_login":"jrwagz","author_association":"NONE","created_at":"2023-07-18T01:58:16+08:00","repo_name":"redis/redis-om-python","issue_id":1711670204,"issue_number":510,"issue_url":"https://github.com/redis/redis-om-python/issues/510","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1195172257","fragment_type":"issue_description","sequence":0,"text":"Missing support for boolean field or examples of how to do it\nI have a model like\n`\nMyModel(HashModel):\n local_auth: bool\n`\nWhen initing or saving I get:\n`DataError(\"Invalid input of type: 'bool'. Convert to a bytes, string, int or float first.\")`","author_login":"sriveros95","author_association":"NONE","created_at":"2022-04-06T20:49:18+08:00","repo_name":"redis/redis-om-python","issue_id":1195172257,"issue_number":193,"issue_url":"https://github.com/redis/redis-om-python/issues/193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1091608962","fragment_type":"issue_comment","sequence":1,"text":"Hi there - boolean fields aren't yet supported for JSON or Hash, they'll likely appear in JSON first as boolean is a native type there vs a Redis Hash that understands strings, floats and ints.","author_login":"simonprickett","author_association":"COLLABORATOR","created_at":"2022-04-07T11:16:01+08:00","repo_name":"redis/redis-om-python","issue_id":1195172257,"issue_number":193,"issue_url":"https://github.com/redis/redis-om-python/issues/193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1097901104","fragment_type":"issue_comment","sequence":2,"text":"I'm talking to the maintainers of the other Redis OM Clients for different languages to make sure that when we do add booleans to Python there's a common approach where possible.","author_login":"simonprickett","author_association":"COLLABORATOR","created_at":"2022-04-13T10:43:18+08:00","repo_name":"redis/redis-om-python","issue_id":1195172257,"issue_number":193,"issue_url":"https://github.com/redis/redis-om-python/issues/193","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1639119888","fragment_type":"issue_comment","sequence":3,"text":"@simonprickett , any update on native support for boolean fields?","author_login":"jrwagz","author_association":"NONE","created_at":"2023-07-18T01:05:36+08:00","repo_name":"redis/redis-om-python","issue_id":1195172257,"issue_number":193,"issue_url":"https://github.com/redis/redis-om-python/issues/193","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0481","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Pod metrics not shown?","query_context":"The node metrics are show. However the pod metrics are not shown. Can headlamp display that? the cpu and memory usage along with requests and limits information would greatly help\n\nHere is my output of `k top pods -A`\n\nNAMESPACE NAME CPU(cores) MEMORY(bytes)\ndefault cf-app-78ffc8ff85-wmg7g 3m 30Mi\nkube-system calico-kube-controllers-759cd8b574-vtp4k 2m 30Mi\nkube-system calico-node-58fdx 24m 100Mi\nkube-system coredns-7896dbf49-ktv8n 2m 30Mi\nkube-system metrics-server-df8dbf7f5-4jjjp 3m 35Mi\ntraefik traefik-6d574648c7-pz7vf 1m 79Mi\nvscode-ns vscodeapp-8c8687db7-4bjkl 2m 192Mi","known_context_document_ids":["gh_issue_2645535620"],"reference_answer":"Thanks @SquupS . We'll take a closer look and see how we can improve our metrics display.","answer_document_id":"gh_comment_1731845007","silver_evidence_path":["gh_comment_2853330017","gh_issue_1883365304","gh_comment_1731845007"],"evidence_issue_ids":[2645535620,1883365304],"source_repo_name":"kubernetes-sigs/headlamp","source_issue_id":2645535620,"source_issue_number":2553,"source_issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","target_repo_name":"kubernetes-sigs/headlamp","target_issue_id":1883365304,"target_issue_number":1380,"target_issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","reference_anchor_document_id":"gh_comment_2853330017","reference_answer_author":"joaquimrocha","reference_answer_author_association":"COLLABORATOR","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.2222},"issue_created_at":"2024-11-09T03:22:05+08:00","valid_comment_count":20,"fragments":[{"document_id":"gh_issue_2645535620","fragment_type":"issue_description","sequence":0,"text":"Pod metrics not shown\nThe node metrics are show. However the pod metrics are not shown. Can headlamp display that? the cpu and memory usage along with requests and limits information would greatly help\n\nHere is my output of `k top pods -A`\n\nNAMESPACE NAME CPU(cores) MEMORY(bytes)\ndefault cf-app-78ffc8ff85-wmg7g 3m 30Mi\nkube-system calico-kube-controllers-759cd8b574-vtp4k 2m 30Mi\nkube-system calico-node-58fdx 24m 100Mi\nkube-system coredns-7896dbf49-ktv8n 2m 30Mi\nkube-system metrics-server-df8dbf7f5-4jjjp 3m 35Mi\ntraefik traefik-6d574648c7-pz7vf 1m 79Mi\nvscode-ns vscodeapp-8c8687db7-4bjkl 2m 192Mi","author_login":"manju-rn","author_association":"NONE","created_at":"2024-11-09T03:22:05+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2470897052","fragment_type":"issue_comment","sequence":1,"text":"Hi! As I know for pod metrics to work you should have prometheus installed inside your k8s cluster","author_login":"feym78","author_association":"NONE","created_at":"2024-11-12T15:50:48+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2471279355","fragment_type":"issue_comment","sequence":2,"text":"Is this a headlamp requirement? Since pod metrics generally works fine without it as per my snapshot in earlier post above","author_login":"manju-rn","author_association":"NONE","created_at":"2024-11-12T18:31:49+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2472784315","fragment_type":"issue_comment","sequence":3,"text":"Yes, headlamp use prometheus plugin for rendering metrics, it search for a prometheus instance inside of the k8s cluster and grab metrics from it.","author_login":"feym78","author_association":"NONE","created_at":"2024-11-13T08:15:32+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2475499272","fragment_type":"issue_comment","sequence":4,"text":"Hi @manju-rn you can try installing prometheus in Headlamp app by selecting the Apps page from the sidebar. Please check prometheus plugins for more information.","author_login":"knrt10","author_association":"CONTRIBUTOR","created_at":"2024-11-14T06:13:42+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2847111722","fragment_type":"issue_comment","sequence":5,"text":"The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.\n\nThis bot triages un-triaged issues according to the following rules:\n- After 90d of inactivity, `lifecycle/stale` is applied\n- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied\n- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed\n\nYou can:\n- Mark this issue as fresh with `/remove-lifecycle rotten`\n- Close this issue with `/close`\n- Offer to help out with [Issue Triage][1]\n\nPlease send feedback to sig-contributor-experience at kubernetes/community.\n\n/lifecycle rotten\n\n[1]: URL","author_login":"k8s-triage-robot","author_association":"NONE","created_at":"2025-05-02T12:39:53+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2853330017","fragment_type":"issue_comment","sequence":6,"text":"I think this issue can be closed because there is an issue open for it here:\n- URL","author_login":"illume","author_association":"COLLABORATOR","created_at":"2025-05-06T05:34:20+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":2645535620,"issue_number":2553,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/2553","linked_issue_ids":[1883365304],"is_known_query_context":false},{"document_id":"gh_issue_1883365304","fragment_type":"issue_description","sequence":0,"text":"Getting real time mertrics on Pod level for CPU/Memory requests and Limits?\nHi,\n\nis it planned to implement real time metrics, so that the user can see what has been set as request and limit (CPU and memory) per pod and how much is utilized in %?\n\nI think that would be a great addition, if not already present and I missed a switch or so :-)\n\nBest regards","author_login":"SquupS","author_association":"NONE","created_at":"2023-09-06T06:54:16+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1719802158","fragment_type":"issue_comment","sequence":1,"text":"Hi @SquupS . We do show metrics if the metrics-server is installed in the cluster which does show the current utilization. Can you check if this is what you mean?\nWe're also working on time based charts, powered by Prometheus.","author_login":"joaquimrocha","author_association":"COLLABORATOR","created_at":"2023-09-14T16:49:40+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1722184522","fragment_type":"issue_comment","sequence":2,"text":"Is there the ability to translate Memory to `Mi` as opposed to the raw value?","author_login":"thepaulmacca","author_association":"NONE","created_at":"2023-09-16T09:10:51+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1727496969","fragment_type":"issue_comment","sequence":3,"text":"@thepaulmacca Can you show a screenshot so I know exactly which part of the UI we're talking about?","author_login":"joaquimrocha","author_association":"COLLABORATOR","created_at":"2023-09-20T10:59:14+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1727522617","fragment_type":"issue_comment","sequence":4,"text":"@joaquimrocha I'm only on mobile atm sorry, but if it helps it was when looking at HPAs","author_login":"thepaulmacca","author_association":"NONE","created_at":"2023-09-20T11:17:14+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1727546999","fragment_type":"issue_comment","sequence":5,"text":"Sorry for the late reply. So I am thinking of something a \"competitor\" of yours if offering on Pod level\n\nimage\n\nThis would really help tracking down resource issues. As of now, I always have to use something like for example k9s to get the current metrics of the pod. Maybe this calrifies a bit where I was originally coming from.\n\nBest regards","author_login":"SquupS","author_association":"NONE","created_at":"2023-09-20T11:34:22+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1731845007","fragment_type":"issue_comment","sequence":6,"text":"Thanks @SquupS . We'll take a closer look and see how we can improve our metrics display.","author_login":"joaquimrocha","author_association":"COLLABORATOR","created_at":"2023-09-22T18:08:48+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2325033327","fragment_type":"issue_comment","sequence":7,"text":"@joaquimrocha Hi!\nAny updates on this issue?\nApp is great, but this really useful feature is missing :)","author_login":"feym78","author_association":"NONE","created_at":"2024-09-02T16:01:04+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2325102213","fragment_type":"issue_comment","sequence":8,"text":"Is this the prometheus plugin? On my local env I see: \nimage","author_login":"JoniJnm","author_association":"CONTRIBUTOR","created_at":"2024-09-02T16:55:44+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2325108281","fragment_type":"issue_comment","sequence":9,"text":"@JoniJnm Sorry, I wasn't clear, my question was about pods requests/limits info (and maybe % of utilization from real time use).","author_login":"feym78","author_association":"NONE","created_at":"2024-09-02T17:02:17+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2332606857","fragment_type":"issue_comment","sequence":10,"text":"Agree, this is very useful information.\nIt's in the Grafana dashboard if you have that installed, but would be simpler for our less experienced users if it were in Headlamp too. \nExample from Grafana\nimage\nAnd from k9s\nimage","author_login":"sarg3nt","author_association":"NONE","created_at":"2024-09-05T20:50:02+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2771497379","fragment_type":"issue_comment","sequence":11,"text":"The Kubernetes project currently lacks enough contributors to adequately respond to all issues.\n\nThis bot triages un-triaged issues according to the following rules:\n- After 90d of inactivity, `lifecycle/stale` is applied\n- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied\n- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed\n\nYou can:\n- Mark this issue as fresh with `/remove-lifecycle stale`\n- Close this issue with `/close`\n- Offer to help out with [Issue Triage][1]\n\nPlease send feedback to sig-contributor-experience at kubernetes/community.\n\n/lifecycle stale\n\n[1]: URL","author_login":"k8s-triage-robot","author_association":"NONE","created_at":"2025-04-02T06:49:22+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3059133362","fragment_type":"issue_comment","sequence":12,"text":"pushed up a change for this, lmk if you'd prefer a different look. I figured a tooltip would work best because requests and limits are optional values and the table is already pretty packed with info. here's what it looks like in the context of the whole table on a larger screen:","author_login":"skoeva","author_association":"CONTRIBUTOR","created_at":"2025-07-10T21:18:21+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3062264808","fragment_type":"issue_comment","sequence":13,"text":"I'm not sure about this.\nAs I said earlier there is still requests part and it should be placed somewhere.\nFrom my point of view in pod list the most interesting is the pod limits along with actual usage, for resource requests I would just go to the pod's details (but still make sense show in details requests AND limits).\nIn other words: main place for requests and limits is the pod's details, but limits duplicated in pods list view.","author_login":"feym78","author_association":"NONE","created_at":"2025-07-11T13:04:00+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3145109592","fragment_type":"issue_comment","sequence":14,"text":"I would also like to see it in the specific pod view. Bonus points would be to plot it on the prometheus metrics dashboard as well to allow comparing usage to what's tolerated.","author_login":"engnatha","author_association":"NONE","created_at":"2025-08-01T16:20:43+08:00","repo_name":"kubernetes-sigs/headlamp","issue_id":1883365304,"issue_number":1380,"issue_url":"https://github.com/kubernetes-sigs/headlamp/issues/1380","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0482","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Proposal to define a strict value for aud claim in the private_key_jwt?","query_context":"**Problem description**\nReferring to the CIBA specs, the `aud` claim of the `private_key_jwt` can be any of the 3 options mentioned below. \nThe proposal is to prevent reuse of the `private_key_jwt` at other endpoints.\n \n\n**Possible evolution**\nEnforce the `aud` claim of the `private_key_jwt` to be the URL of the respective endpoint (as a string) at which the assertion is received, it must not be an item in an array.\nThe URLs of the endpoint can be populated from the OpenID Provider's `/.well-known/openid-configuration` with the following metadata:\n- token_endpoint\n- backchannel_authentication_endpoint\n\nExample: If the endpoint at which the assertion is being received is the backchannel_authentication_endpoint, the Relying Party will populate the `aud` claim of the `private_key_jwt` to be the URL of the backchannel_authentication_endpoint as per the OpenID Provider's `/.well-known/openid-configuration`.\n\n**Alternative solution**\nN.A\n\n**Additional context**\nOIDC profile is being defined for CAMARA","known_context_document_ids":["gh_issue_2153365614"],"reference_answer":"Thanks for the +1.\n\nI agree that the proposed API does not solve all problems but if Android provides then others might follow.\nFor the web case we go for universal links and assetlinks.\n URL \n URL \nWhich enable app-clips and instant apps, and also app-web-credential-sharing.\nTo get rid of ip2msisdn we have operatorTokens (best thing since sliced bread) defined in GSMA TS.43\n URL \n\nNo solution for everything or use case but we are getting there if MNO work together and build an ecosystem for all of us","answer_document_id":"gh_comment_2050302567","silver_evidence_path":["gh_comment_2049165399","gh_issue_2153408742","gh_comment_2050302567"],"evidence_issue_ids":[2153365614,2153408742],"source_repo_name":"camaraproject/IdentityAndConsentManagement","source_issue_id":2153365614,"source_issue_number":127,"source_issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","target_repo_name":"camaraproject/IdentityAndConsentManagement","target_issue_id":2153408742,"target_issue_number":128,"target_issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","reference_anchor_document_id":"gh_comment_2049165399","reference_answer_author":"AxelNennker","reference_answer_author_association":"COLLABORATOR","quality_score":93.44,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1765,"anchor_target_overlap":0.2059,"target_answer_overlap":0.0488},"issue_created_at":"2024-02-26T06:34:08+08:00","valid_comment_count":40,"fragments":[{"document_id":"gh_issue_2153365614","fragment_type":"issue_description","sequence":0,"text":"Proposal to define a strict value for aud claim in the private_key_jwt\n**Problem description**\nReferring to the CIBA specs, the `aud` claim of the `private_key_jwt` can be any of the 3 options mentioned below. \nThe proposal is to prevent reuse of the `private_key_jwt` at other endpoints.\n \n\n**Possible evolution**\nEnforce the `aud` claim of the `private_key_jwt` to be the URL of the respective endpoint (as a string) at which the assertion is received, it must not be an item in an array.\nThe URLs of the endpoint can be populated from the OpenID Provider's `/.well-known/openid-configuration` with the following metadata:\n- token_endpoint\n- backchannel_authentication_endpoint\n\nExample: If the endpoint at which the assertion is being received is the backchannel_authentication_endpoint, the Relying Party will populate the `aud` claim of the `private_key_jwt` to be the URL of the backchannel_authentication_endpoint as per the OpenID Provider's `/.well-known/openid-configuration`.\n\n**Alternative solution**\nN.A\n\n**Additional context**\nOIDC profile is being defined for CAMARA","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-26T06:34:08+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1964386211","fragment_type":"issue_comment","sequence":1,"text":"From my point of view, it is not a good idea to limit the value of the `aud` claim to that of the endpoint to which the request is made. The CIBA specification is clear (Issuer Identifier, Token Endpoint URL, or Backchannel Authentication Endpoint), and forcing implementations to deviate from the standard by rejecting requests they should accept could jeopardize existing integrations.\n\nIf replay attacks are to be avoided, there are better mechanisms, such as the `jti` claim to prevent reuse of the token.","author_login":"garciasolero","author_association":"NONE","created_at":"2024-02-26T15:15:37+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968392388","fragment_type":"issue_comment","sequence":2,"text":"@garciasolero \nThe concern is that the same signed JWT can be interchangeably use between the three endpoints:\n\n- /bc-authorize\n- /token\n- /authorize\n\n/token endpoint should be more secured as it allows `client_credentials` with scope.\nThe `aud` claim can be seem similarly as a scope for access.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-28T07:34:37+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968415871","fragment_type":"issue_comment","sequence":3,"text":"Proposed CAMARA OIDC - client-authentication profile states \n \n\nPlease clarify on this point.\n\nimage","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-28T07:53:04+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1969119410","fragment_type":"issue_comment","sequence":4,"text":"@mhfoo How about the text in this commit? \n\n URL \n\n## Client Authentication\n\nThis CAMARA document allows one client authentication method, private_key_jwt, as defined in OIDC OIDC Client Authentication\n\nOIDC Client Authentication defined the following about the audfield:\n\n REQUIRED. Audience. The aud (audience) Claim. Value that identifies the Authorization Server as an intended audience. The Authorization Server MUST verify that it is an intended audience for the token. The Audience SHOULD be the URL of the Authorization Server's Token Endpoint.\n\nThis document defines that for OIDC Authorization Code Flow and OAuth2 Client Credentials Grant the audience MUST be the URL of the Authorization Server's Token Endpoint. This document defines that for OIDC CIBA the audience MUST be the Backchannel Authentication Endpoint.","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-02-28T14:34:48+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970626141","fragment_type":"issue_comment","sequence":5,"text":"I think it is better to separate the use cases because some involve different types of JSON Web Tokens (JWTs). On one hand, we have the request object parameter, and on the other hand, we have the client assertion for authentication.\n\n- Request Object by value in `/authorize` request: It must be the Authorisation Server Issuer Identifier URL (RFC9101):\n \n\n- Client assertion for authentication in server-server requests: I think there could be some confusion here, and certain standards, such as CIBA, are proposing solutions to ensure interoperability. I think setting it up similar to CIBA could be the solution: Authorisation Server Issuer Identifier, Token Endpoint URL or Requested Endpoint URL. So the table you suggested would look like this:\n\n| Invoking Endpoint \\ Audience | issuer | token endpoint | bc-authorize endpoint | any other endpoint|\n| ------------------------------- | ------- |-----------------|------------------------|--------------------|\n| /token | Accept | Accept | Reject | Reject |\n| /bc-authorize | Accept | Accept | Accept | Reject |","author_login":"garciasolero","author_association":"NONE","created_at":"2024-02-29T08:15:59+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2039223081","fragment_type":"issue_comment","sequence":6,"text":"The `aud` claim requirements for authorization servers in the FAPI profile are: issuer, token endpoint, or the endpoint URL (as I suggested above). I'm not sure why the client requirements section restricts sending only the issuer (and as a string, not in an array) when authorization servers are expected to accept the other values. In my opinion, I would include the requirements for the authorization server.","author_login":"garciasolero","author_association":"NONE","created_at":"2024-04-05T08:15:32+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2039272162","fragment_type":"issue_comment","sequence":7,"text":"The section on clients is a \"should\", so clients can still use the other allowed values in FAPI 2.0 security.\n\nThe current text in #121 is this:\n \nThis document defines that for OIDC CIBA the audience MUST be the Backchannel Authentication Endpoint.\n\nIn other words, the aud is always the url the request is sent too. Which seems to be a simple rule, which is somewhat more secure than additionally allowing the \"issuer\" as well.\n\n| Invoking Endpoint \\ Audience | issuer | token endpoint | bc-authorize endpoint | any other endpoint|\n| ------------------------------- | ------- |-----------------|------------------------|--------------------|\n| /token | Reject | Accept | Reject | Reject |\n| /bc-authorize | Reject | Reject | Accept | Reject |\n\nPlease suggest \"better\" text if you think that is needed.","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-05T09:01:19+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2039386811","fragment_type":"issue_comment","sequence":8,"text":"Suggested text aligned with what the CIBA standard and the FAPI profile state:\n\n_To facilitate interoperability, the Authorization Server MUST accept its issuer identifier, the token endpoint URL, or the URL of the endpoint at which the assertion was received as values of the audience claim._","author_login":"garciasolero","author_association":"NONE","created_at":"2024-04-05T10:00:32+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2041955297","fragment_type":"issue_comment","sequence":9,"text":"@AxelNennker @garciasolero \n\nThe current text in URL is this:\n \n \n\nIn other words, the aud is always the url the request is sent too. Which seems to be a simple rule, which is somewhat more secure than additionally allowing the \"issuer\" as well.\n\n| Invoking Endpoint \\ Audience | issuer | token endpoint | bc-authorize endpoint | authorize endpoint | any other endpoint | mulitple endpoints |\n|--------|--------|--------|--------|--------|--------|--------|\n| /token | Reject | Accept | Reject | Reject | Reject | Reject |\n| /bc-authorize | Reject | Reject | Accept | Reject | Reject | Reject |\n| /authorize | Reject | Reject | Reject | Accept | Reject | Reject |\n\nAgree with Axel's statement above. The \naud\n claim should not be an array.\n\nThe signed Object Request RFC 9101 is a signed JWT and it is communicated in the public domain over the Internet when performing the Auth Code flow.\n\nThe signed JWT maybe used to invoke the /token /bc-authorized endpoints by a bad actor, as mentioned in Cross-JWT Confusion.\n \n \n \n\nThe above proposal is leaving the API Consumer to secure the Operator's endpoint. As an Operator, we should secure our endpoints with restrictions.\n \n \n \n \n\nAnother approach is to issue different \nclient_id\n for the same backend application when performing auth code flow and CIBA flow.\n\nBank XYZ will use client_id A for auth code flow, client_id B for CIBA flow. client_id A will not be accepted for CIBA flow, client_Id B will not be accepted for auth code flow.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-04-08T06:26:30+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2042941612","fragment_type":"issue_comment","sequence":10,"text":"1)\nRegarding the following two sections:\n \n \n\n@mhfoo Please do not add even more options to the mix.\n\n2) Not sure why write about 9101. Yes, that is also a signed JWT, and there also can be a mixup-attack.\nDoes your text after \"The signed Object Request...\" help with the solution if you assume that we assume that more concrete aud values are more secure?\n\n# To summarize this issue's discussion: \nSpecifying single, specific values for aud depending on the use-case and end point improves security.\nDoing that might possibly be bad for interoperability. Even though I am one of the editors of the CIBA standard I do not agree with the interoperability argument. Specifying the correct aud string is simple and I believe that clients are not overburdened with this task. While at the same time, we prevent mixup attacks.\n\nYou might challenge the \"simple\"-argument, but I think the other proposals (key management) are too complicated and implementing the aud-requirement discussed here is indeed simple.\n\n# Some examples for aud value in various implementations:\nThe example seem to use the endpoint url which agrees existing text.\n\n- URL \n \n\n- URL \n \n\n- URL \n \n\n- URL \n \n\n- URL","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-08T14:41:43+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2047599136","fragment_type":"issue_comment","sequence":11,"text":"| Invoking Endpoint \\ Audience | issuer | token endpoint | bc-authorize endpoint | authorize endpoint | any other endpoint | mulitple endpoints |\n|--------|--------|--------|--------|--------|--------|--------|\n| /token | Reject | Accept | Reject | Reject | Reject | Reject |\n| /bc-authorize | Reject | Reject | Accept | Reject | Reject | Reject |\n| /authorize | Reject | Reject | Reject | Accept | Reject | Reject |\n\n@garciasolero can TEF live with this table? As I said, I thing that using the endpoint url is not obstacle for client developers and provides better security.","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-10T13:47:50+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049161900","fragment_type":"issue_comment","sequence":12,"text":"@AxelNennker \n\nAs I mentioned earlier, we should clearly separate the audiences for these endpoints because they have their own requirements: `token` and `bc-authorize` endpoints deals with client assertions for authentication, while the `authorize` endpoint deals with request objects.\n\nIn relation to the audience claim within a client assertion, we suggest what CIBA standard or FAPI profile define: to accept the issuer, the token endpoint and the endpoint URL as valid audiences to ensure interoperability. \n\nCIBA:\n \n\nFAPI:\n \n \n \n \n \n\nOf course, you can simplify the possible values and, for example, accept only the endpoint URL. However, this would affect already deployed solutions that follow the CIBA standard. Therefore, we suggest that the profile should allow authorization servers to accept these three values and recommend using the endpoint URL to clients.\n\n---\nRegarding what would happen if we support RFC9101 by passing request objects by value, the standard already specifies what the value of the audience should be:\n \n\nIn relation to your concern about the use of a JWT issued for a request object in authorize flow as a client authentication JWT, the RFC9101 already suggests a way to mitigate this by avoiding the `client_id` as `sub` value within the request object:","author_login":"garciasolero","author_association":"NONE","created_at":"2024-04-11T08:11:55+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049165399","fragment_type":"issue_comment","sequence":13,"text":"@AxelNennker \n \nDoes your text after \"The signed Object Request...\" help with the solution if you assume that we assume that more concrete aud values are more secure?\n\nRegarding the above question, it is related to #128.\n\nThe following is the proposed text for PR #121 under OIDC Authorization Code Flow section.\n\nThe OIDC Authorization Code Flow is defined in OpenID Connect, incorporating RFC 9101, Passing a Request Object by Value.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-04-11T08:14:12+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[2153408742],"is_known_query_context":false},{"document_id":"gh_comment_2051369557","fragment_type":"issue_comment","sequence":14,"text":"We are not making progress with this issue. \n\nI changed the text regarding `client authentication and the aud values` to RECOMMEND instead of MUST.\n\nThe AZ still MUST ensure that it is the intended audience. The document, as always following the principle of no repeating the obvious, does not mention that fact because the standards are clear and no clarification is needed.\n\n## Client Authentication\n\nThis CAMARA document allows **one** client authentication method, `private_key_jwt`, as defined in OIDC\nOIDC Client Authentication\n\nThis document RECOMMENDS that for OIDC Authorization Code Flow and OAuth2 Client Credentials Grant the audience SHOULD be the URL of the Authorization Server's Token Endpoint.\nThis document RECOMMENDS that for OIDC CIBA the audience SHOULD be the Backchannel Authentication Endpoint.","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-12T09:16:25+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153365614,"issue_number":127,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/127","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2153408742","fragment_type":"issue_description","sequence":0,"text":"Proposal to protect the /authorize endpoint for the Authorization Code Flow (Auth Code Flow) - RFC9101\n**Problem description**\nThe /authorize endpoint is not protected, and the following undesired scenarios are security concerns.\n\n1. A bad actor can perform a DDoS attack with multiple Operator SIM cards on the Operator /authorize endpoint; this is an internal mobile network route without traversing the Internet.\n\n2. Aggregators are using mobile apps to query different operator /authorize endpoints to discover (at no cost) which operator the SIM card belongs too. \n\n**Possible evolution**\nProposal to have a one-time use token to prevent abuse of this un-protected endpoint on AuthServer.\nThe App Backend will need to obtain this one-time use token from the AuthServer and pass it to the Device App and then use it against the /authorize endpoint.\n\n1. The one-time use token will be validated at the Auth Service, and therefore protecting the downstream network nodes.\n2. The one-time use token will be associated with an Application Backend for charging purposes.\n\n**Alternative solution**\nN.A\n\n**Additional context**\nNumberVerification subproject issue 71","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-26T07:06:27+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1963455311","fragment_type":"issue_comment","sequence":1,"text":"Please refer to the following sequence diagrams. The interactions in blue is the proposed method.\n\nStandalone Open Gateway\nProposal\n\nFederated Open Gateway\nSimple Federated Proposal","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-26T07:14:09+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1964442751","fragment_type":"issue_comment","sequence":2,"text":"In our view, it is unnecessary to introduce additional flows beyond those that already exist. Instead, we recommend using the mechanisms provided by the OAuth standard itself. Our proposal to mitigate this issue is to force the application to pass the request object parameter by value in the authorize request of the authorization code flow, as described in RFC9101.\n\nBy using a signed JWT, we prevent requests that are not generated by the application. Additionally, we would need to require that the JWT contains the `jti` (to prevent the JWT from being replayed) and `exp` parameters.\n\nFor applications, the integration cost would not be high because they would already be generating signed-JWTs to authenticate server-to-server requests using `private_key_jwt`.","author_login":"garciasolero","author_association":"NONE","created_at":"2024-02-26T15:38:06+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1968277505","fragment_type":"issue_comment","sequence":3,"text":"@garciasolero Thanks for the proposal to mitigate this issue by forcing the application backend to pass the request object parameter by value in the authorize request of the authorization code flow, as described in RFC9101.\n\nThe request object will be a signed JWT containing the auth code flow request payload.\n\nThis will mitigate point 1. of the problem statements","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-28T05:45:24+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[2153408742],"is_known_query_context":false},{"document_id":"gh_comment_1968294433","fragment_type":"issue_comment","sequence":4,"text":"@garciasolero \nThe point of relying on the `jti` value alone when the signed JWT is from a third party, is not sufficient.\nIt should be a combination of at least `jti` + `iss` + `exp`.\n\nPoint 2 of the problem statements is related to a \"trusted\" aggregator using error codes to decode behaviours of the number verification flow.\n\nExample:\nIf this endpoint response successfully with a redirect 302, the SIM card belongs to this operator.\nIf this endpoint response with an error, the SIM card may not belong to this operator.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-28T06:03:55+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[2153408742],"is_known_query_context":false},{"document_id":"gh_comment_1968456698","fragment_type":"issue_comment","sequence":5,"text":"@mhfoo,\n\nYes, you are right. In my comment, I focused on a few fields. Obviously, it should also include the most typical ones: `iss`, `aud`, or `iat`.\n\nRegarding point 2, in the aggregation model for number verification, the entity responsible for routing the request to the correct operator is the aggregator based on the IP address of the request using the TelcoRouting service. Therefore, it should not be the case that the SIM card does not belong to the operator, and if it were to happen, it would be an exceptional case related to synchronisation issues in the TelcoFinder translation tables.","author_login":"garciasolero","author_association":"NONE","created_at":"2024-02-28T08:22:21+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1969676575","fragment_type":"issue_comment","sequence":6,"text":"@garciasolero \n\nIs there any specification of TelcoRouting service? \nWho will be responsible for it in terms of maintenance? \nWill every Telco expose API for exporting Public IP Pools records or what is the idea?\n\nOur current practice is that every Telco shares us IP Pools so we are able to do the routing on our side locally very easy and fast. Like using GeoIP Database with Telco resolution level. On that way there is no need for any additional external call which slow down the flow.","author_login":"ab-ip","author_association":"COLLABORATOR","created_at":"2024-02-28T19:15:15+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970454323","fragment_type":"issue_comment","sequence":7,"text":"@ab-ip \nThis question should be handled in GSMA Open Gateway","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-29T05:48:53+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970467974","fragment_type":"issue_comment","sequence":8,"text":"@garciasolero \n\nPoint 2 in this problem description is not about routing. Please refer to the following diagram for illustration of this problem statement.\n\nNumber Verify Issue drawio\n\nIn the above diagram, assume the Operators are standalone (not federated).\n\nThe aggregator: \n- has all the /authorize endpoints for Operator A, B, C, \n- has an SDK deployed in the mobile application which can query a list of provided /authorize endpoints.\n\nFrom this setup, the aggregator can determine the operator of the SIM card which is providing the mobile data connection, when the correct /authorize endpoint returns a 302 Location with an auth code in the query string.\nThe aggregator/mobile application does not need to continue with the auth code flow for number verify to determine the mobile number. The aggregator just needs to know the operator of the SIM card which the end customer is using.\n\nThis usage of the /authorize endpoint should be prevented.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-02-29T06:04:50+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[2153408742],"is_known_query_context":false},{"document_id":"gh_comment_1970869537","fragment_type":"issue_comment","sequence":9,"text":"@mhfoo \n\nThe case you mentioned is too expensive for Clients/Aggregators to use Trial-and-Error method to resolve Telco. It takes to much time and increases flow duration, which is something nobody wants.\n\nThere are many other (easier and faster) ways right now to do this:\n1. Clients can use IP to ASN resolution to find the Telco user belongs to.\n2. In case of SDK it is also available to read MCCMNC of the SIM. \n\nThat is why TelcoRouting service based on IP address is mandatory. Telco Public IP Pools should be publicly available and shared with Clients and Aggregators. The best approach will be to have separate API (under CAMARA) for export/synchronization of IP Pools, so that Clients and Aggregators can do synchronization of IP Pools with all Telcos in a unique way.\n\nIf you want to prevent Clients/Aggregators not to misuse /auth endpoint you can simple apply business model which will define ratio between /auth endpoint (Auth Code result) and other CAMARA API endpoints. Eg. if there is more then 20% of Auth Code result then API calls, then Client needs to pay some fee for that gap.","author_login":"ab-ip","author_association":"COLLABORATOR","created_at":"2024-02-29T10:46:20+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1970956059","fragment_type":"issue_comment","sequence":10,"text":"I would like you to explain the request `#9` in the sequence diagram of your solution. It appears that an `Authorization` header needs to be sent in the OAuth code flow, but that is not specified in the standard. \nI would also like to know how the sequence diagram would look if the SIM does not belong to the operator. \n\nIn the current solution, using an endpoint restricted by signed requests according to RFC9101, if the aggregator were to use authorization as a method to determine whether a SIM belongs to an operator (at no cost in order to reduce requests to TelcoFinder), the operator could detect abuse and deactivate their credentials.","author_login":"garciasolero","author_association":"NONE","created_at":"2024-02-29T11:40:44+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006019216","fragment_type":"issue_comment","sequence":11,"text":"@ab-ip \n \n\nSee URL \nThis is under the Open Gateway Repo. This API provides both the static and dynamic routes; shared between telco finders of operators and aggregators.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-03-19T07:05:08+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2006041354","fragment_type":"issue_comment","sequence":12,"text":"@garciasolero \n \n\nAgreed to drop this method as shown in `#9`. The signed request according to RFC9101 will be a better solution.\n \n\nAre you referring to any of the following scenarios:\na) federated scenario, route to partner operator or \nb) when the telco finder is unable to resolve the source Internet facing IP address?","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-03-19T07:12:29+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2007281236","fragment_type":"issue_comment","sequence":13,"text":"a) federated scenario, route to partner operator or \nb) when the telco finder is unable to resolve the source Internet facing IP address?\n\nI am referring to what the flow would be if an operator received a request from a SIM that does not belong to it, regardless of whether there is an aggregator in front of it or not.","author_login":"garciasolero","author_association":"NONE","created_at":"2024-03-19T14:08:16+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2008620701","fragment_type":"issue_comment","sequence":14,"text":"@garciasolero \n \n\nFederated Architecture-Network Auth Service drawio\n\nFor the standalone Open Gateway, currently there is no route from the Internet to reach /authorize endpoint. Only the operator's SIM card can reach the internal /authorise endpoint. Blue dash path.\n\nIn the federated model, the Internet facing /authorize endpoint should only accept requests from partner / federated operators' CGNAT Internet IP address. A) We may assess this security posture of whitelisting partner CGNAT IP addresses and block the rest of the traffic. Pink dash path.\n\nDuring the client onboarding process, the client will provide a redirect_uri.\nB) If the /authorize endpoint observed source IP address (from a CGNAT) cannot be resolved in the operator's Telco Finder, the response will be the failure redirect_uri (with a newly defined error code), following OIDC Authorization Code Flow and OAuth 2.0 This is a graceful failure for the client.\n\nWhat are your thoughts on this?","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-03-20T03:47:47+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2036486652","fragment_type":"issue_comment","sequence":15,"text":"Provided a diagram for review NumberVerification issues 93\n\n@garciasolero @jpengar","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-04-04T08:15:12+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2049334084","fragment_type":"issue_comment","sequence":16,"text":"@ab-ip \n \n \n \n\nPlease consider +1 this Android feature request, which would allow client's mobile applications to get the operator's openid configuration\n URL","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-11T09:53:43+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2050146260","fragment_type":"issue_comment","sequence":17,"text":"@AxelNennker +1 vote from my side. \nThis feature (API) is fine and useful, but unfortunately it won't solve Web use cases (but only App) and coverage issue will stay as well. \nHaving(knowing) OIDC Auth Endpoints does not mean that user can reach endpoint and be identified at the specific moment. \nWhen we talk about Seamless Auth the crucial part (for Service Providers/App Devs) is to know that it is possible to handle (resolve/identify) specific user. \nIn order to determinate this possibility it is required to know that user is on Cellular(Mobile) Connection of specific (supported) Carrier. The best and easiest way to do this is definitely by IP address resolution. \nYou can check how IPification do it for last 4 years with many partners (including 60+ Carriers and 100+ Service Providers)","author_login":"ab-ip","author_association":"COLLABORATOR","created_at":"2024-04-11T17:13:55+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2050302567","fragment_type":"issue_comment","sequence":18,"text":"Thanks for the +1.\n\nI agree that the proposed API does not solve all problems but if Android provides then others might follow.\nFor the web case we go for universal links and assetlinks.\n URL \n URL \nWhich enable app-clips and instant apps, and also app-web-credential-sharing.\nTo get rid of ip2msisdn we have operatorTokens (best thing since sliced bread) defined in GSMA TS.43\n URL \n\nNo solution for everything or use case but we are getting there if MNO work together and build an ecosystem for all of us","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-11T18:44:01+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2054428159","fragment_type":"issue_comment","sequence":19,"text":"@AxelNennker The following is the proposed text for PR URL under OIDC Authorization Code Flow section.\n\n----------------------\n\nThe OIDC Authorization Code Flow is defined in OpenID Connect and incorporates RFC 9101, Passing a Request Object by Value.","author_login":"mhfoo","author_association":"COLLABORATOR","created_at":"2024-04-15T02:28:20+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2059012375","fragment_type":"issue_comment","sequence":20,"text":"I suggest to move this issue or it resolution to the next version because I think incorporating this now would open up a longer discussion and I would like to get PR #121 soon.","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-04-16T12:48:06+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2150158312","fragment_type":"issue_comment","sequence":21,"text":"Please add your comment whether we should mandate implementation of 9101 and that clients must us it","author_login":"AxelNennker","author_association":"COLLABORATOR","created_at":"2024-06-05T14:23:52+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2157810004","fragment_type":"issue_comment","sequence":22,"text":"There are different solutions described as options to address the DDOS attack of the authZ server.\n1. Solution 1 (non standard): app server requests one-time token from authZ server (protected by API gateway throttling features), one-time token is used by device on auth code request\n2. Solution 2: RFC 9101: pass request object by value in the authorize request of the auth code flow\na. This requires that a key exchange happens upfront between the potential client device and the CSP, such that the client could use the private_key_jwt for singing.\n\nRegarding solution 2:\nWe think that RFC 9101 does not solve not DDOS attack issues. (even though it addresses confidentiality and integrity issues). A malicious client will still be able to send “signed” authcode requests. Ericsson does not support making RFC 9101 mandatory.\nRFC 9101 should not be made mandatory now.\n\nRegarding solution 1: \nThis is non-standard and thus is not (yet) endorsed by Ericsson. \n\nWe recommend traditional API end point protection solutions (e.g. a firewall) on top of the AuthZ server to protect the AuthZ server from being overloaded.\n\nIn addition: there was a prior discussion in NumberVerification workgroup about securing the authorization end point sating: \"GSMA have just approved a spec \"ASAC.01-Seamless Authenticator subsystem enhancement for TS.43 Operator Token\" which also deals with the security of the authorize endpoint… It may be a good idea to align with that initiative.\" - and the suggestion to align to this document in ICM. So we should not make a different solution mandatory now.","author_login":"Elisabeth-Ericsson","author_association":"CONTRIBUTOR","created_at":"2024-06-10T09:18:40+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2158636995","fragment_type":"issue_comment","sequence":23,"text":"@Elisabeth-Ericsson\n\nThe RFC9101 was never a proposal to address DDoS attacks. That specification was proposed to avoid processing requests that do not come from authenticated clients. In other words, it aims to mitigate the processing of fraudulent requests that could lead to increased costs, such as queries to TelcoFinder. \n\nSimilarly, one-time tokens do not solve the DDoS problem, as the request still reaches the API Gateway and must be processed to check whether the token has been used before or not.","author_login":"garciasolero","author_association":"CONTRIBUTOR","created_at":"2024-06-10T15:17:02+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2160355846","fragment_type":"issue_comment","sequence":24,"text":"In addition to Fabio's comment, RFC9101was also proposed as a solution to avoid the potential PII leakage problem raised by Vonage in the past, as mentioned at URL \n\nIn any case, as mentioned in the 5 June WG meeting, RFC9101 was proposed by Telefónica as a possible solution to some of the issues raised in #128 and #138 for consideration by the WG. As discussed, if the WG decides to support RFC9101, it would be necessary to mandate its implementation/use to both, clients and operators. Otherwise, if clients could choose not to use it, we would not be addressing the concerns raised here.\n\n**From Telefonica's point of view, we are fine with not mandating the implementation and support of RFC9101 for the time being. We propose to close this issue and leave RFC9101 support out of the scope of the next Fall24 meta-release. And revisit it in the future if necessary.**","author_login":"jpengar","author_association":"COLLABORATOR","created_at":"2024-06-11T10:09:52+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[2153408742],"is_known_query_context":false},{"document_id":"gh_comment_2180172008","fragment_type":"issue_comment","sequence":25,"text":"As agreed in the June 19 WG meeting call, we exclude RFC 9101 from the scope of the next meta release, also considering the time constraints. It is recommended that the issue be closed for now and reopened in the future if necessary.","author_login":"jpengar","author_association":"COLLABORATOR","created_at":"2024-06-20T08:58:24+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2757262447","fragment_type":"issue_comment","sequence":26,"text":"For the first Solution, OAuth2 has a specification standard 'RFC 9126: OAuth 2.0 Pushed Authorization Requests\" by extending JAR with `request_uri`. I think it can be a solution for provide confidential, integrity and available (DDoS issue) for the authorization endpoint.","author_login":"biennd279","author_association":"NONE","created_at":"2025-03-27T09:06:54+08:00","repo_name":"camaraproject/IdentityAndConsentManagement","issue_id":2153408742,"issue_number":128,"issue_url":"https://github.com/camaraproject/IdentityAndConsentManagement/issues/128","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0483","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Tree-sitter: use parse-trees to trigger multiline or singleline completions?","query_context":"Currently, we decide which completion (multi vs. single) to trigger based on hardcoded block start symbols and a couple of regexes. We can use tree-sitter to categorize completion triggers and use them instead of the current approach for supported languages.","known_context_document_ids":["gh_issue_1911086615"],"reference_answer":"Closing this tracking issue since the remaining issues are low priority, and we can review them separately. I added them to the eng tracking board.","answer_document_id":"gh_comment_1837386609","silver_evidence_path":["gh_comment_1774439492","gh_issue_1956308805","gh_comment_1837386609"],"evidence_issue_ids":[1911086615,1956308805],"source_repo_name":"sourcegraph/cody","source_issue_id":1911086615,"source_issue_number":1157,"source_issue_url":"https://github.com/sourcegraph/cody/issues/1157","target_repo_name":"sourcegraph/cody","target_issue_id":1956308805,"target_issue_number":1455,"target_issue_url":"https://github.com/sourcegraph/cody/issues/1455","reference_anchor_document_id":"gh_comment_1774439492","reference_answer_author":"valerybugakov","reference_answer_author_association":"MEMBER","quality_score":88.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.5,"target_answer_overlap":0.1538},"issue_created_at":"2023-09-25T09:37:57+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_1911086615","fragment_type":"issue_description","sequence":0,"text":"Tree-sitter: use parse-trees to trigger multiline or singleline completions\nCurrently, we decide which completion (multi vs. single) to trigger based on hardcoded block start symbols and a couple of regexes. We can use tree-sitter to categorize completion triggers and use them instead of the current approach for supported languages.","author_login":"valerybugakov","author_association":"MEMBER","created_at":"2023-09-25T09:37:57+08:00","repo_name":"sourcegraph/cody","issue_id":1911086615,"issue_number":1157,"issue_url":"https://github.com/sourcegraph/cody/issues/1157","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1734741961","fragment_type":"issue_comment","sequence":1,"text":"Examples:\n* Function signature + open parens => generate full function body (even for long functions)\n* Struct definitions => line by line (see how this affects CAR)","author_login":"beyang","author_association":"MEMBER","created_at":"2023-09-26T02:42:28+08:00","repo_name":"sourcegraph/cody","issue_id":1911086615,"issue_number":1157,"issue_url":"https://github.com/sourcegraph/cody/issues/1157","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1774439492","fragment_type":"issue_comment","sequence":2,"text":"Let's consider this issue closed by:\n1. URL \n2. URL \n\nThe follow-up work will be tracked here: URL","author_login":"valerybugakov","author_association":"MEMBER","created_at":"2023-10-23T05:00:59+08:00","repo_name":"sourcegraph/cody","issue_id":1911086615,"issue_number":1157,"issue_url":"https://github.com/sourcegraph/cody/issues/1157","linked_issue_ids":[1956308805],"is_known_query_context":false},{"document_id":"gh_issue_1956308805","fragment_type":"issue_description","sequence":0,"text":"Tracking issue: tree-sitter based completion intents (syntactic triggers)\nA tracking issue for the tree-sitter-based completion intent work based on RFC 848: Tree-sitter-powered intent detection for Cody:\n\n[tasklist]\n### Completion Intents\n- [x] URL \n- [ ] URL \n- [x] URL \n- [ ] URL \n- [ ] URL \n- [ ] URL \n- [x] URL \n\n[tasklist]\n### UPD\n- [x] Use completion intent info to track CAR more granularly in Looker. Update the existing queries/logic if needed.\n- [x] Pending the disable-streaming-truncation experiment results, consider leveraging intent information to expand the token limit for function/class declaration completion intents.\n- [x] Analyze the results of the `syntactic-triggers` experiment where we switched multiline completions to singleline for type/struct/interface declaration intents. If this change positively affects CAR, make this a default behavior.\n- [x] Make javascript completion intent queries more precise\n\n### After GA Tasks:\n\n[tasklist]\n### After GA","author_login":"valerybugakov","author_association":"MEMBER","created_at":"2023-10-23T04:05:46+08:00","repo_name":"sourcegraph/cody","issue_id":1956308805,"issue_number":1455,"issue_url":"https://github.com/sourcegraph/cody/issues/1455","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1837386609","fragment_type":"issue_comment","sequence":1,"text":"Closing this tracking issue since the remaining issues are low priority, and we can review them separately. I added them to the eng tracking board.","author_login":"valerybugakov","author_association":"MEMBER","created_at":"2023-12-03T06:39:23+08:00","repo_name":"sourcegraph/cody","issue_id":1956308805,"issue_number":1455,"issue_url":"https://github.com/sourcegraph/cody/issues/1455","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0484","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Should the excel file questionnaire prefix contain the suffix ccs01?","query_context":"The QV output has _ccs01 appended to the questionnaire column, but it doesn't append it in the TQ output. Both should be questionnaireprefix_ccs01.\n\nSo should the _ccs01 be included in the Excel and used as is, or will it be appended automatically to both outputs?","known_context_document_ids":["gh_issue_2391069928"],"reference_answer":"When I use this file as input, no files are generated, because there's no questionnaire or dataset prefix columns present.\n\nCan I assume these columns will be present, and that this file is not correctly formatted?\n\n[sws_covid_pq1_all_mappings_wip.xlsx\n](url)","answer_document_id":"gh_comment_2222545654","silver_evidence_path":["gh_comment_2210539602","gh_issue_2390905650","gh_comment_2222545654"],"evidence_issue_ids":[2391069928,2390905650],"source_repo_name":"CLOSER-Cohorts/archivist-utilities","source_issue_id":2391069928,"source_issue_number":15,"source_issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/15","target_repo_name":"CLOSER-Cohorts/archivist-utilities","target_issue_id":2390905650,"target_issue_number":14,"target_issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","reference_anchor_document_id":"gh_comment_2210539602","reference_answer_author":"ollylucl","reference_answer_author_association":"COLLABORATOR","quality_score":91.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":false,"anchor_query_overlap":0.3889,"anchor_target_overlap":0.1852,"target_answer_overlap":0.2667},"issue_created_at":"2024-07-04T15:06:41+08:00","valid_comment_count":8,"fragments":[{"document_id":"gh_issue_2391069928","fragment_type":"issue_description","sequence":0,"text":"Should the excel file questionnaire prefix contain the suffix ccs01?\nThe QV output has _ccs01 appended to the questionnaire column, but it doesn't append it in the TQ output. Both should be questionnaireprefix_ccs01.\n\nSo should the _ccs01 be included in the Excel and used as is, or will it be appended automatically to both outputs?","author_login":"HayleyMills","author_association":"NONE","created_at":"2024-07-04T15:06:41+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2391069928,"issue_number":15,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/15","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2210424452","fragment_type":"issue_comment","sequence":1,"text":"\"So should the _ccs01 be included in the Excel and used as is, or will it be appended automatically to both outputs?\"\n\nYou tell me! I can modify the code so _ccs01 gets appended automatically to both outputs, that's not difficult. If it's difficult/fiddly to modify whatever process generates the Excel file so that _ccs01 is in the questionnaire prefix column, we can just modify the code.\n\nWould it be trivial to include the _ccs01 suffix in the relevant columns in the Excel file?","author_login":"ollylucl","author_association":"COLLABORATOR","created_at":"2024-07-05T08:21:48+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2391069928,"issue_number":15,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2210539602","fragment_type":"issue_comment","sequence":2,"text":"Okay so it will be slightly easier for us if we didn't need to add the _ccs01 to the Excel, it's not onerous, but it might be easier for the studies to understand if it didn't include that. \n\nSO can we go with the script appending the _ccs01 please?\n\nSo in that case, I think it's only the TQ output which needs updating to append the _ccs01, as the QV already has this. \n\nIt also means the filename of the output can just be the questionnaire prefix as is in the Excel file and the ccs01 won't need removing #14","author_login":"HayleyMills","author_association":"NONE","created_at":"2024-07-05T09:32:47+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2391069928,"issue_number":15,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/15","linked_issue_ids":[2390905650],"is_known_query_context":false},{"document_id":"gh_comment_2211075474","fragment_type":"issue_comment","sequence":3,"text":"I've pushed up a commit which adds _ccs01 to the values in the questionnaire prefix column in tq.txt","author_login":"ollylucl","author_association":"COLLABORATOR","created_at":"2024-07-05T15:32:55+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2391069928,"issue_number":15,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/15","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2390905650","fragment_type":"issue_description","sequence":0,"text":"Names of exported files\nThe DV and TV now contain the dataset names in the filenames, as there could be more than one, for consistency, can we include the questionnaire prefix in the name (-ccs01) for the QV and TQ files?","author_login":"HayleyMills","author_association":"NONE","created_at":"2024-07-04T13:38:53+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2390905650,"issue_number":14,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2209139250","fragment_type":"issue_comment","sequence":1,"text":"Do you mean, that for the QV and TQ files, we should generate a file for every unique questionnaire prefix, and the title of those files should be a concatenation of the questionnaire prefix,'-ccs01', and '_qv.txt' , e.g. heaf_17_fup_4-ccs01_qv.txt?","author_login":"ollylucl","author_association":"COLLABORATOR","created_at":"2024-07-04T14:34:02+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2390905650,"issue_number":14,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2209262248","fragment_type":"issue_comment","sequence":2,"text":"Why do you have (-ccs01) in the opening message on this issue? That's confusing me.","author_login":"ollylucl","author_association":"COLLABORATOR","created_at":"2024-07-04T15:45:14+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2390905650,"issue_number":14,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2209309927","fragment_type":"issue_comment","sequence":3,"text":"Ah sorry it wasn't clear it was meant to be like minus the ccs01 which I think was in the excel files, but may not need to be see #15","author_login":"HayleyMills","author_association":"NONE","created_at":"2024-07-04T16:21:13+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2390905650,"issue_number":14,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2210748497","fragment_type":"issue_comment","sequence":4,"text":"I think I've implemented what you asked for, the qv and tq data are now in files named after the questionnaire prefixes. If there are multiple unique values for questionnaire prefixes in the input Excel file, there will be a text file generated for each one.","author_login":"ollylucl","author_association":"COLLABORATOR","created_at":"2024-07-05T11:59:15+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2390905650,"issue_number":14,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2222545654","fragment_type":"issue_comment","sequence":5,"text":"When I use this file as input, no files are generated, because there's no questionnaire or dataset prefix columns present.\n\nCan I assume these columns will be present, and that this file is not correctly formatted?\n\n[sws_covid_pq1_all_mappings_wip.xlsx\n](url)","author_login":"ollylucl","author_association":"COLLABORATOR","created_at":"2024-07-11T10:10:40+08:00","repo_name":"CLOSER-Cohorts/archivist-utilities","issue_id":2390905650,"issue_number":14,"issue_url":"https://github.com/CLOSER-Cohorts/archivist-utilities/issues/14","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0485","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"go mod download 404 Not Found for private module?","query_context":"### Go version\n\n1.23.1\n\n### Output of `go env` in your module/workspace:\n\nshell\nGO111MODULE=''\nGOARCH='amd64'\nGOBIN=''\nGOCACHE='/home/grbit/.cache/go-build'\nGOENV='/home/grbit/.config/go/env'\nGOEXE=''\nGOEXPERIMENT=''\nGOFLAGS=''\nGOHOSTARCH='amd64'\nGOHOSTOS='linux'\nGOINSECURE=''\nGOMODCACHE='/home/grbit/ssd/go/pkg/mod'\nGONOPROXY='gitlab.com/nextpax,bitbucket.org/nextpaxcom'\nGONOSUMDB='gitlab.com/nextpax,bitbucket.org/nextpaxcom'\nGOOS='linux'\nGOPATH='/home/grbit/ssd/go'\nGOPRIVATE='gitlab.com/nextpax,bitbucket.org/nextpaxcom'\nGOPROXY=' URL \nGOROOT='/home/grbit/.local/go'\nGOSUMDB='sum.golang.org'\nGOTMPDIR=''\nGOTOOLCHAIN='auto'\nGOTOOLDIR='/home/grbit/.local/go/pkg/tool/linux_amd64'\nGOVCS=''\nGOVERSION='go1.23.1'\nGODEBUG=''\nGOTELEMETRY='local'\nGOTELEMETRYDIR='/home/grbit/.config/go/telemetry'\nGCCGO='gccgo'\nGOAMD64='v1'\nAR='ar'\nCC='gcc'\nCXX='g++'\nCGO_ENABLED='1'\nGOMOD='/dev/null'\nGOWORK=''\nCGO_CFLAGS='-O2 -g'\nCGO_CPPFLAGS=''\nCGO_CXXFLAGS='-O2 -g'\nCGO_FFLAGS='-O2 -g'\nCGO_LDFLAGS='-O2 -g'\nPKG_CONFIG='pkg-config'\nGOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3978658459=/tmp/go-build -gno-record-gcc-switches'\n\n### What did you do?\n\ngo mod download -x gitlab.com/nextpax/nextpax-commons/v2@latest\n\n### What did you see happen?\n\ngo mod download -x gitlab.com/nextpax/nextpax-commons/v2@latest\n# get URL \n# get URL 404 Not Found (0.264s)\n# get URL \n# get URL 404 Not Found (0.255s)\ngo: gitlab.com/nextpax/nextpax-commons/v2@latest: unrecognized import path \"gitlab.com/nextpax/nextpax-commons/v2\": reading URL 404 Not Found\n\n### What did you expect to see?\n\nI expect that module will be correctly downloaded. Something like\n\n[0] $ go mod download -x gitlab.com/nextpax/nextpax-commons/v2@latest\n# get URL \n# get URL 200 OK (0.253s)\n# get URL \n# get URL 200 OK (0.186s)\n\nFrom the same command line curl get 200 OK for this URL\n\n$ curl -o /dev/null -s -w \"%{http_code}\\n\" URL \n200\n$ curl URL \n \n\nI want to debug what exactly go get does on my local machine, because I can not reproduce this behavior on any other machine. But the only option I have is `-x` option. I also have strace, but it doesn't give much info. The IP addresses are the same, but what `go mod` writes/reads to gitlab is different. Since it's https it's hard to dive inside to see the real difference.\n\nIf you could give my any clues on how to debug it, that would be nice.","known_context_document_ids":["gh_issue_2517040802"],"reference_answer":"@umputun and others: this should be fixed at head and on `release-branch.go1.13`. Could someone with access to a private GitLab subgroup please try a build from `release-branch.go1.13` and confirm?","answer_document_id":"gh_comment_534998554","silver_evidence_path":["gh_comment_2341521402","gh_issue_489466287","gh_comment_534998554"],"evidence_issue_ids":[2517040802,489466287],"source_repo_name":"golang/go","source_issue_id":2517040802,"source_issue_number":69381,"source_issue_url":"https://github.com/golang/go/issues/69381","target_repo_name":"golang/go","target_issue_id":489466287,"target_issue_number":34094,"target_issue_url":"https://github.com/golang/go/issues/34094","reference_anchor_document_id":"gh_comment_2341521402","reference_answer_author":"bcmills","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1343,"anchor_target_overlap":0.3881,"target_answer_overlap":0.2857},"issue_created_at":"2024-09-10T17:13:18+08:00","valid_comment_count":63,"fragments":[{"document_id":"gh_issue_2517040802","fragment_type":"issue_description","sequence":0,"text":"go mod download 404 Not Found for private module\n### Go version\n\n1.23.1\n\n### Output of `go env` in your module/workspace:\n\nshell\nGO111MODULE=''\nGOARCH='amd64'\nGOBIN=''\nGOCACHE='/home/grbit/.cache/go-build'\nGOENV='/home/grbit/.config/go/env'\nGOEXE=''\nGOEXPERIMENT=''\nGOFLAGS=''\nGOHOSTARCH='amd64'\nGOHOSTOS='linux'\nGOINSECURE=''\nGOMODCACHE='/home/grbit/ssd/go/pkg/mod'\nGONOPROXY='gitlab.com/nextpax,bitbucket.org/nextpaxcom'\nGONOSUMDB='gitlab.com/nextpax,bitbucket.org/nextpaxcom'\nGOOS='linux'\nGOPATH='/home/grbit/ssd/go'\nGOPRIVATE='gitlab.com/nextpax,bitbucket.org/nextpaxcom'\nGOPROXY=' URL \nGOROOT='/home/grbit/.local/go'\nGOSUMDB='sum.golang.org'\nGOTMPDIR=''\nGOTOOLCHAIN='auto'\nGOTOOLDIR='/home/grbit/.local/go/pkg/tool/linux_amd64'\nGOVCS=''\nGOVERSION='go1.23.1'\nGODEBUG=''\nGOTELEMETRY='local'\nGOTELEMETRYDIR='/home/grbit/.config/go/telemetry'\nGCCGO='gccgo'\nGOAMD64='v1'\nAR='ar'\nCC='gcc'\nCXX='g++'\nCGO_ENABLED='1'\nGOMOD='/dev/null'\nGOWORK=''\nCGO_CFLAGS='-O2 -g'\nCGO_CPPFLAGS=''\nCGO_CXXFLAGS='-O2 -g'\nCGO_FFLAGS='-O2 -g'\nCGO_LDFLAGS='-O2 -g'\nPKG_CONFIG='pkg-config'\nGOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3978658459=/tmp/go-build -gno-record-gcc-switches'\n\n### What did you do?\n\ngo mod download -x gitlab.com/nextpax/nextpax-commons/v2@latest\n\n### What did you see happen?\n\ngo mod download -x gitlab.com/nextpax/nextpax-commons/v2@latest\n# get URL \n# get URL 404 Not Found (0.264s)\n# get URL \n# get URL 404 Not Found (0.255s)\ngo: gitlab.com/nextpax/nextpax-commons/v2@latest: unrecognized import path \"gitlab.com/nextpax/nextpax-commons/v2\": reading URL 404 Not Found\n\n### What did you expect to see?\n\nI expect that module will be correctly downloaded. Something like\n\n[0] $ go mod download -x gitlab.com/nextpax/nextpax-commons/v2@latest\n# get URL \n# get URL 200 OK (0.253s)\n# get URL \n# get URL 200 OK (0.186s)\n\nFrom the same command line curl get 200 OK for this URL\n\n$ curl -o /dev/null -s -w \"%{http_code}\\n\" URL \n200\n$ curl URL \n \n\nI want to debug what exactly go get does on my local machine, because I can not reproduce this behavior on any other machine. But the only option I have is `-x` option. I also have strace, but it doesn't give much info. The IP addresses are the same, but what `go mod` writes/reads to gitlab is different. Since it's https it's hard to dive inside to see the real difference.\n\nIf you could give my any clues on how to debug it, that would be nice.","author_login":"GRbit","author_association":"NONE","created_at":"2024-09-10T17:13:18+08:00","repo_name":"golang/go","issue_id":2517040802,"issue_number":69381,"issue_url":"https://github.com/golang/go/issues/69381","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2341521402","fragment_type":"issue_comment","sequence":1,"text":"**Related Issues and Documentation**\n\n - cmd/go: \"package?go-get=1 404 not found\" errors occurs when go get private project in internal private gitlab repository #64223 (closed) \n - cmd/go: get fails on gitlab subgroups due to go-import meta tags referring to nonexistent repos #34094 (closed) \n - cmd/go: get fail with private and subdirectory repo in module mode #29470 (closed) \n - cmd/go: \"no go-import meta tags\" when fetching from a private GitLab repo #37504 (closed) \n - cmd/go: GO111MODULE=on go get -v -insecure gitlab.com/xxx/xxx failed #32569 (closed) \n - go get -u all is attempting to find a VCS repository for a module path that is replaced with a local directory #40326 (closed) \n - Go modules issue with gitlab groups and sub-groups #34469 (closed) \n - x/tools/gopls 410 on private repository (not default branch) #39569 (closed) \n - cmd/go: \"unknown revision\" error is misleading if the entire repo can't be found #47028 \n - Can't import package from non-github repo #43251 (closed) \n\n (Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)","author_login":"gabyhelp","author_association":"NONE","created_at":"2024-09-10T17:13:36+08:00","repo_name":"golang/go","issue_id":2517040802,"issue_number":69381,"issue_url":"https://github.com/golang/go/issues/69381","linked_issue_ids":[489466287],"is_known_query_context":false},{"document_id":"gh_comment_2341539775","fragment_type":"issue_comment","sequence":2,"text":"Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.\n\nFor questions please refer to URL","author_login":"seankhliao","author_association":"MEMBER","created_at":"2024-09-10T17:20:47+08:00","repo_name":"golang/go","issue_id":2517040802,"issue_number":69381,"issue_url":"https://github.com/golang/go/issues/69381","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2342852484","fragment_type":"issue_comment","sequence":3,"text":"Turned out it's a gitlab bug with access levels using tokens from `.netrc`, so techincally, the issue could be closed.\n\nHowever, I see it as a big problem that you cannot debug `go mod` or `go get` behavior.\nIf anyone could suggest any ways to debug `go mod` that would be AMAZING, because I've spent hours trying to find a problem with no result. It refuses to use `http_proxy` env variable, it has nothing like curl `SSLKEYLOGFILE` functionality to read it's requests with wireshark. It's a total pain to debug it.\n\nThe final solution that helped me was `strace` that showed all the files read by `go mod`. That's how I found .netrc file with credentials and detected this gitlab access problem.\n\nI wanted just a simple thing: add more verbosity to the way request is built by go, but I'm afraid there is no way to do it, and that's a problem.","author_login":"GRbit","author_association":"NONE","created_at":"2024-09-11T07:19:06+08:00","repo_name":"golang/go","issue_id":2517040802,"issue_number":69381,"issue_url":"https://github.com/golang/go/issues/69381","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2344120591","fragment_type":"issue_comment","sequence":4,"text":"@GRbit These are good issues to bring up in a forum, rather than the issue tracker. See URL Thanks.","author_login":"ianlancetaylor","author_association":"CONTRIBUTOR","created_at":"2024-09-11T16:25:02+08:00","repo_name":"golang/go","issue_id":2517040802,"issue_number":69381,"issue_url":"https://github.com/golang/go/issues/69381","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_489466287","fragment_type":"issue_description","sequence":0,"text":"cmd/go: get fails on gitlab subgroups due to go-import meta tags referring to nonexistent repos\n### What version of Go are you using (`go version`)?\n\n \n$ go version\ngo version go1.13 darwin/amd64\n \n\n### Does this issue reproduce with the latest release?\n\nyes\n\n### What operating system and processor architecture are you using (`go env`)?\n\n go env Output \n$ go env\nGO111MODULE=\"\"\nGOARCH=\"amd64\"\nGOBIN=\"\"\nGOCACHE=\"/Users/umputun/Library/Caches/go-build\"\nGOENV=\"/Users/umputun/Library/Application Support/go/env\"\nGOEXE=\"\"\nGOFLAGS=\"\"\nGOHOSTARCH=\"amd64\"\nGOHOSTOS=\"darwin\"\nGONOPROXY=\"\"\nGONOSUMDB=\"\"\nGOOS=\"darwin\"\nGOPATH=\"/Users/umputun/go-home\"\nGOPRIVATE=\"\"\nGOPROXY=\"direct\"\nGOROOT=\"/usr/local/Cellar/go/1.13/libexec\"\nGOSUMDB=\"off\"\nGOTMPDIR=\"\"\nGOTOOLDIR=\"/usr/local/Cellar/go/1.13/libexec/pkg/tool/darwin_amd64\"\nGCCGO=\"gccgo\"\nAR=\"ar\"\nCC=\"clang\"\nCXX=\"clang++\"\nCGO_ENABLED=\"1\"\nGOMOD=\"/Users/umputun/tmp/t/go.mod\"\nCGO_CFLAGS=\"-g -O2\"\nCGO_CPPFLAGS=\"\"\nCGO_CXXFLAGS=\"-g -O2\"\nCGO_FFLAGS=\"-g -O2\"\nCGO_LDFLAGS=\"-g -O2\"\nPKG_CONFIG=\"pkg-config\"\nGOGCCFLAGS=\"-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/fx/rzs1_n8137qfktxcbt_2v8pc0000gp/T/go-build570104617=/tmp/go-build -gno-record-gcc-switches -fno-common\"\n \n\n### What did you do?\n\n1. Created a public project on gitlab URL with a module gitlab.com/umputuntests/sub/example\n1. Tried to get it, i.e. `go get -v gitlab.com/umputuntests/sub/example`\n1. go get failed\n\nget \"gitlab.com/umputuntests/sub/example\": found meta tag get.metaImport{Prefix:\"gitlab.com/umputuntests/sub/example\", VCS:\"git\", RepoRoot:\" URL at //gitlab.com/umputuntests/sub/example?go-get=1\nget \"gitlab.com/umputuntests/sub\": found meta tag get.metaImport{Prefix:\"gitlab.com/umputuntests/sub\", VCS:\"git\", RepoRoot:\" URL at //gitlab.com/umputuntests/sub?go-get=1\ngo: finding gitlab.com/umputuntests/sub/example v0.0.2\ngo: downloading gitlab.com/umputuntests/sub/example v0.0.2\ngo: extracting gitlab.com/umputuntests/sub/example v0.0.2\ngo get gitlab.com/umputuntests/sub/example: git ls-remote -q URL in /Users/umputun/go-home/pkg/mod/cache/vcs/410d993df4daac0579ff6b4402c511af12bd3d00851d05ab6183293d03664961: exit status 128:\n fatal: could not read Username for ' URL terminal prompts disabled\nConfirm the import path was entered correctly.\nIf this is a private repository, see URL for additional information.\n\n \n\n### What did you expect to see?\n\nwith prev versions of go (1.12.x) it works file:\n\n go get -v gitlab.com/umputuntests/sub/example\nFetching URL \nParsing meta tags from URL (status code 200)\nget \"gitlab.com/umputuntests/sub/example\": found meta tag get.metaImport{Prefix:\"gitlab.com/umputuntests/sub/example\", VCS:\"git\", RepoRoot:\" URL at URL \ngo: finding gitlab.com/umputuntests/sub/example v0.0.2\ngo: finding github.com/stretchr/testify v1.3.0\ngo: finding github.com/stretchr/objx v0.1.0\ngo: finding github.com/davecgh/go-spew v1.1.0\ngo: finding github.com/pmezard/go-difflib v1.0.0\ngo: downloading gitlab.com/umputuntests/sub/example v0.0.2\ngo: extracting gitlab.com/umputuntests/sub/example v0.0.2\ngitlab.com/umputuntests/sub/example/strategy\ngitlab.com/umputuntests/sub/example\n\n### additional notes\n\nI think this is both gitlab problem and go 1.13 change. Gitlab seems to return `go-import` tag on the parent, which doesn't exist and this seems to confuse \"go get\", trying to check module's parent.\n\ncurl \" URL \n\n \n\nIn fact, gitlab returns good-looking `go-import` on any random path, for example:\n\ncurl \" URL","author_login":"umputun","author_association":"NONE","created_at":"2019-09-05T00:20:13+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528294665","fragment_type":"issue_comment","sequence":1,"text":"Go 1.13 tries all module prefixes in parallel, and if another error other than \"not-found\" happens, the query fails. Of course the root cause is on gitlab side, but I think it's reasonable to ignore all errors if at least one attempt succeeds.\nA quick workaround is clearing `err` if `found` is not empty in `queryPrefixModules()` in `cmd/go/internal/modload/query.go`.","author_login":"leonshaw","author_association":"NONE","created_at":"2019-09-05T10:05:43+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528359183","fragment_type":"issue_comment","sequence":2,"text":"I could see doing that if the provided Git URL itself returned a 404 or 410 status code, but note that `gitlab.com` today does not:\n\n~$ curl -sI URL | grep HTTP\nHTTP/1.1 401 Unauthorized","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-05T13:18:44+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528368983","fragment_type":"issue_comment","sequence":3,"text":"I'm running into issues with GitLab subgroups as well, but I'm getting a different error:\n\n$ go get -u example.com/group/subgroup/my-go-project.git\ngo: finding example.com/group/subgroup/my-go-project.git latest\ngo get example.com/group/subgroup/my-go-project.git: git ls-remote -q URL in C:\\Users\\dev\\go\\pkg\\mod\\cache\\vcs\\5af58fdf9c9bd0fd298253dde7a0add3f4e5d6be34206b0b46f6805ee365d4ea: exit status 128:\n remote: The project you were looking for could not be found.\n fatal: repository ' URL not found\n\nIt almost seems like it's assuming that the second part of the path must be the project. Going back to 1.12 fixes it.","author_login":"tangtony","author_association":"NONE","created_at":"2019-09-05T13:38:02+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528404217","fragment_type":"issue_comment","sequence":4,"text":"@bcmills I mean if a try on `gitlab.com/group/project` succeeds, we can ignore errors encountered trying `gitlab.com/group` and `gitlab.com/group/project/submodule`, no matter what they are.","author_login":"leonshaw","author_association":"NONE","created_at":"2019-09-05T14:44:59+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528410476","fragment_type":"issue_comment","sequence":5,"text":"@leonshaw, maybe..? The problem with that is that it's asymmetric.\n\nIf _I_ have credentials for module `example.com/foo` containing subdirectory `./bar/baz`, and _you_ have credentials for `example.com/foo/bar` containing subdirectory `./baz`, and we both run `go get example.com/foo/bar/baz`, then we'll end up with different results for the exact same query.\n\nThe solution to that is to treat responses other than 404/410 as hard errors. Then I'll fail to fetch `example.com/foo/bar`, and you'll fail to fetch `example.com/foo`, and we'll both (consistently!) know that we don't have enough credentials to produce a consistent result.\n\n(More generally: if servers want to avoid leaking information to unauthenticated users, then it's more robust to deny the existence of every module rather than claim the existence of every module — especially now that #29888 is fixed.)","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-05T14:55:37+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528420423","fragment_type":"issue_comment","sequence":6,"text":"I don't think this is possible, at least with giltab, as they don't have \"directory-level permissions\" but repository-level only. Probably the same for gihub.\n\nEven in case, if a user has credentials to every repo on the server, `go get` will fail to get that non-existing parent, but instead of the authorization failure `git ls-remote` complains about \"Could not read from remote repository.\"\n\n \nget \"example.com/commons/pkg\": found meta tag get.metaImport{Prefix:\"example.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at //example.com/commons/pkg?go-get=1\nget \"example.com/commons/pkg/multierror\": found meta tag get.metaImport{Prefix:\"example.com/commons/pkg/multierror\", VCS:\"git\", RepoRoot:\" URL at //example.com/commons/pkg/multierror?go-get=1\ngo get example.com/commons/pkg/multierror: git ls-remote -q URL in /Users/umputun/go-home/pkg/mod/cache/vcs/882b5ac6f69791979e3abd70af30e871e32fe91173f2e25079ef6a88464ec13e: exit status 128:\n \n fatal: Could not read from remote repository.","author_login":"umputun","author_association":"NONE","created_at":"2019-09-05T15:18:50+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528427191","fragment_type":"issue_comment","sequence":7,"text":"Is this something more fundamental? (A module can't be uniquely located by an import path.)","author_login":"leonshaw","author_association":"NONE","created_at":"2019-09-05T15:33:35+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528428074","fragment_type":"issue_comment","sequence":8,"text":"GitLab and GitHub are not the only ways to host a module. Ideally, the semantics of the `go` command should generalize to self-hosted domains with arbitrary structure.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-05T15:35:37+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528428766","fragment_type":"issue_comment","sequence":9,"text":"A _module_ has a unique path. The mapping of _package paths_ to modules is not guaranteed to be 1:1, although the `go` command fails with an error message if any one package within the package `import` graph is provided by more than one module in the module graph.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-05T15:37:16+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528442238","fragment_type":"issue_comment","sequence":10,"text":"Yes, this is the problem. We need a way to avoid the collision, if possible. If it's simply treated as error, `example.com/foo/bar` will be unusable if `example.com/foo` exists.","author_login":"leonshaw","author_association":"NONE","created_at":"2019-09-05T16:09:07+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528457322","fragment_type":"issue_comment","sequence":11,"text":"Probably, self-hosted giltab used by a majority of self-hosted git systems. However, this new behavior seems to conflict not with giltab only, but gitea as well and may conflict with any system surprised by parent discovery calls. I appreciate the generalized approach and concerns about asymmetrical behavior in some theoretical cases, but the current problem if very practical one.","author_login":"umputun","author_association":"NONE","created_at":"2019-09-05T16:48:10+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_528593459","fragment_type":"issue_comment","sequence":12,"text":"I have most of a solution coded up, but there is a bad interaction with proxy fallback that I still need to work out.\n\nEven then, my expectation is that a server that wishes to indicate “there is no repository here” (for a repository explicitly mentioned in a `go-import` ` ` tag) will serve a 404 or a 410 for the URL. I'm not sure whether `gitlab.com` does that for authenticated users, but for unauthenticated users they're currently serving 401s instead.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-05T21:21:08+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530051911","fragment_type":"issue_comment","sequence":13,"text":"Change URL mentions this issue: `cmd/go/internal/modfetch: report the module path for errors in (*codeRepo).Versions`","author_login":"gopherbot","author_association":"NONE","created_at":"2019-09-10T17:59:29+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530051921","fragment_type":"issue_comment","sequence":14,"text":"Change URL mentions this issue: `cmd/go/internal/modfetch/codehost: treat nonexistent repositories as “not found”`","author_login":"gopherbot","author_association":"NONE","created_at":"2019-09-10T17:59:30+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530078815","fragment_type":"issue_comment","sequence":15,"text":"@gopherbot, please backport to 1.13: this is a regression, and prevents previously-working modules from being fetched.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-10T19:10:50+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530078847","fragment_type":"issue_comment","sequence":16,"text":"Backport issue(s) opened: #34215 (for 1.13).\n\nRemember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to URL","author_login":"gopherbot","author_association":"NONE","created_at":"2019-09-10T19:10:57+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530397245","fragment_type":"issue_comment","sequence":17,"text":"I've implemented the approach described in URL That should solve the problem *if* GitLab is correctly serving 404 or 410 responses for nonexistent paths for signed-in users.\n\nHowever, I don't know whether they're doing that, so please help me confirm.\n\n@umputun (or one of the other folks with this problem): please try a `go` command built from head and let me know whether your problem is resolved. (The easy way to try a `go` command built from head is to install `golang.org/x/dl/gotip`, then run `gotip download` and use `gotip` in place of the regular `go` command.)","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-11T14:08:03+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[489466287],"is_known_query_context":false},{"document_id":"gh_comment_530397884","fragment_type":"issue_comment","sequence":18,"text":"Change URL mentions this issue: `[release-branch.go1.13] cmd/go/internal/modfetch/codehost: treat nonexistent repositories as “not found”`","author_login":"gopherbot","author_association":"NONE","created_at":"2019-09-11T14:09:28+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530515991","fragment_type":"issue_comment","sequence":19,"text":"@bcmills I have tried to test it with both public gitlab as well as self-hosted and it doesn't seem to work. I have also tried it with full credentials and git's \"insteadOf\" mapping from ` URL to `git@...` and it failed either. Both are working fine with 1.12.\n\nYou can try it with public repo from the original ticket, i.e. `go get -v gitlab.com/umputuntests/sub/example` vs `gotip get -v gitlab.com/umputuntests/sub/example`. \n \n\nI don't think giltab does it. To me it looks like they return 401 on any non-existent paths. Probably adding 401 to the list of the errors on the parent discovery you consider as \"missing module\" may fix it.","author_login":"umputun","author_association":"NONE","created_at":"2019-09-11T18:51:26+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530536643","fragment_type":"issue_comment","sequence":20,"text":"The ticket I have opened on gitlab was closed by them as a duplicate to another, 2y old ticket they refused to address.\n\nFrom what I understand, gitlab considers 404 on non-existent repos as a security issue, i.e. someone could realize what private repo exists. I don't think it has anything to do with authorized status - 401 seems to be returned on any nonexisting path regardless of the auth status.\n\nGenerally speaking, such behavior is a little bit odd, but not obviously wrong. `go get` is trying to access parent(s) of the repo which may not be repo at all, but some protected page/service. Sure it will be nice if gitlab return no `go-import` in such a case, but I guess they consider it security issue as well.","author_login":"umputun","author_association":"NONE","created_at":"2019-09-11T19:45:56+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530551617","fragment_type":"issue_comment","sequence":21,"text":"Ironically, GitHub seems to take the opposite approach: they return 404 for unauthenticated users.\n \n\nFor the example of `gitlab.com/umputuntests/sub/example`, the cat is already out of the bag: the non-401 response for ` URL already reveals the existence of the entities `gitlab.com/umputuntests` and `gitlab.com/umputuntests/sub`.\n\nThe same would seem to be true for private subgroups and appropriately-credentialed users.\nSo the “security issue” explanation does not seem to hold water.\n\nMoreover, given that #29888 has been addressed in Go 1.13, it seems that they could simply stop serving the `go-import` meta tags in 401 responses in order to avoid revealing information to unauthenticated users.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-11T20:26:58+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530564835","fragment_type":"issue_comment","sequence":22,"text":"Not sure I understand. Both `gitlab.com/umputuntests/sub` and `gitlab.com/umputuntests/sub/example` are public. If you try anything completely random, you will get 401 for any non-existent as well as any private repo. By doing this they are trying to hide the presence of private repos.\n\nhttp URL \nHTTP/1.1 401 Unauthorized\n\nHttp access to the real private repo as well as to non-existent repo redirects to gitlab.com/users/sign_in\n \n\nI see what you mean, but technically it is not entirely accurate - they serve meta tags with 200 status, not 401","author_login":"umputun","author_association":"NONE","created_at":"2019-09-11T21:03:48+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530569138","fragment_type":"issue_comment","sequence":23,"text":"Sure, but the `go` command is not trying “anything completely random”. It is trying prefixes of the requested import path, and we are assuming that the user has sufficient credentials to at least reveal the existence of _some_ module with a matching prefix.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-11T21:15:50+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_530580828","fragment_type":"issue_comment","sequence":24,"text":"Understood. I believe the root cause is meta, gitlab returns unconditionally with 200 on any path, but for the end-user, it looks and feels like a regression in go 1.3 - before update modules worked with gitlab, and after the update, it stopped to work.\n\nI'm not sure what changed with the parent discovery between 1.2 and 1.3, but if this is due to \"Go 1.13 tries all module prefixes in parallel, and if another error other than \"not-found\" happens, the query fails.\" can this logic be adjusted to succeed if the repo has go.mod regardless of the parrent status? If such behavior is not acceptable generally, maybe some env param to make gitlab happy and allow such forgiving modules discovery?","author_login":"umputun","author_association":"NONE","created_at":"2019-09-11T21:51:48+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_531243675","fragment_type":"issue_comment","sequence":25,"text":"@jamesramsay \n \n\nWith CL 194679 in, there are several possible fixes:\n\n1. You could continue to serve ` ` tags for all URLs that could potentially exist as repositories, but serve 404s or 410s (instead of 401s) for requests for the actual repository (` URL when that the user is authorized to access any repository that has the requested path as a prefix.\n * For example: if the user is authorized to see ` URL then a response for ` URL or ` URL should have code 404 or 410, not 401.\n\n2. You could remove the ` ` tags from ` URL responses for all URLs that don't correspond to actual repositories. (The HTTP response code does not matter as long as it is not a redirect.)\n * To preserve path secrecy, you would presumably want to also remove ` ` tags for repositories that the requester is not authorized to see. Unfortunately, that might cause `go get` to fail for users on Go 1.12 due to #29888 (which is fixed in 1.13).\n\n3. You could remove the ` ` tags from ` URL responses for all URLs that don't correspond to actual repositories _when the user is authorized to access a repository that has the requested path as a prefix_.\n * For example, if the user is authorized to see ` URL then a response for ` URL should omit the ` ` tag, since the user already knows that that URL does not correspond to an actual repository.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-13T13:47:22+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_531244961","fragment_type":"issue_comment","sequence":26,"text":"@leonshaw \n \n\nThat's true, but turns out not to matter that much: the `go` command intentionally looks for ` ` tags even within 404 (or 401) responses.\n\n(That is: the _content_ is what matters for the `?go-get=1` request, but the _status_ is what matters for the `.git` request, and the two are mostly orthogonal.)","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-13T13:50:49+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_531249471","fragment_type":"issue_comment","sequence":27,"text":"@jamesramsay \n \n\nIn CL 173017, I changed the `go` command's algorithm for mapping an unresolved import path to the corresponding module path.\n\nIt was previously a sequential search starting from the longest path, working downward to progressively shorter paths, and the error handling was a bit sloppy.\n\nNow, it searches in parallel for modules at all possible prefixes of the import path, which can significantly reduce overall latency (especially when a proxy is involved). However, the fact that the search occurs in parallel means that we end up trying a lot of potential module paths that turn out not to be valid.\n\nWe're fine with an invalid module path as long as the error is that the module does not exist.\n\n* The main mechanism for a server to indicate “the module does not exist” is to not serve a ` ` tag for the `?go-get=1` request for that path.\n\n* As of CL 194679, which is merged but not released, we also support a secondary mechanism: if the server provides a ` ` tag with an HTTPS URL, and that URL serves status 404 or 410, we interpret that to mean “the module would be at that URL if it existed, but it's not there so it doesn't exist.”","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-13T14:02:56+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_531669896","fragment_type":"issue_comment","sequence":28,"text":"@bcmills - I had a chance to test this issue with gitea. For 1.13 the situation is similar to gitlab's, i.e. the same regression (worked with 1.12 and fails on 1.13). However, with gotip it worked fine. gitea seems to return go meta on any path, pretty much the same way as gitlab. However for those non-existing repos gitea, unlike gitlab, returns 404.","author_login":"umputun","author_association":"NONE","created_at":"2019-09-16T07:32:36+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_533291719","fragment_type":"issue_comment","sequence":29,"text":"Thanks @bcmills and @umputun for all that context.\n\nOur plan is to start returning a `404` in response to the first stage `?go-get=1` request if the project doesn't exist or if the user is not sufficiently authenticated. We're tracking the issue URL We don't have capacity to look into this in the current development cycle, but I'll try to have this scheduled soon. Of course, anyone from the community would also be welcome to contribute a fix too 😄","author_login":"jamesramsay","author_association":"NONE","created_at":"2019-09-19T20:14:48+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_533733898","fragment_type":"issue_comment","sequence":30,"text":"I'm having an issue related to getting a 410 when trying to get modules which previously worked in 1.12. The actual error I get is:\n\nverifying gitlab.com/mycompany/subgroup/project.git@v1.0.4/go.mod: gitlab.com/mycompany/subgroup/project.git@v1.0.4/go.mod: reading URL 410 Gone\n\nIs this related?\n\nIn my ~/.gitconfig, I have the following:\n\n [url \"git@gitlab.com:\"]\n insteadOf = git://gitlab.com/\n [url \"git@gitlab.com:\"]\n insteadOf = URL","author_login":"herriojr","author_association":"NONE","created_at":"2019-09-20T22:44:14+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_533741443","fragment_type":"issue_comment","sequence":31,"text":"Is there a reason you can't do the module search in parallel but still walk the results in reverse order of specificity, thus ignoring errors unless every path had an error?\n\nThe permissions argument doesn't seem like it really applies much. In general, Go assumes one module path means one source code repository. If you were to return different results based on permissions, you could do that at the git layer in the same way you might at the `?go-get=` resolution layer. Either way, you're seriously breaking the go view of the world, and you'll probably know you are, but have deliberately decided to take on any pain associated with differing code results.\n\nThe way things are now implemented, that potential for pain for offenders now becomes real pain for anybody who relied on the more obvious behavior before, including indirectly, as in the case of those simply using these version control systems.","author_login":"andrewstuart","author_association":"NONE","created_at":"2019-09-20T23:17:38+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534666242","fragment_type":"issue_comment","sequence":32,"text":"Yeah, given the timeframe for fixes to the serving paths we should probably just do that.\n\n(I'm not particularly happy about burying errors in general, but it seems like the least-unpleasant solution here.)","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-24T17:35:43+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534674369","fragment_type":"issue_comment","sequence":33,"text":"Change URL mentions this issue: `cmd/go: suppress errors in package-to-module queries if the package is already found`","author_login":"gopherbot","author_association":"NONE","created_at":"2019-09-24T17:54:32+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534762406","fragment_type":"issue_comment","sequence":34,"text":"Change URL mentions this issue: `[release-branch.go1.13] cmd/go: suppress errors in package-to-module queries if the package is already found`","author_login":"gopherbot","author_association":"NONE","created_at":"2019-09-24T21:48:21+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_534998554","fragment_type":"issue_comment","sequence":35,"text":"@umputun and others: this should be fixed at head and on `release-branch.go1.13`. Could someone with access to a private GitLab subgroup please try a build from `release-branch.go1.13` and confirm?","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-25T12:29:55+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_535301491","fragment_type":"issue_comment","sequence":36,"text":"Just tested the latest build on `release-branch.go1.13` and can confirm it works with a private GitLab subgroup.","author_login":"tangtony","author_association":"NONE","created_at":"2019-09-26T02:19:54+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_535557052","fragment_type":"issue_comment","sequence":37,"text":"Thanks for confirming.\n\nIn general we don't have a lot of different configurations of Git servers running in our test environment, so please do be sure to try out Beta and RC releases to catch any future regressions. (We do our best to test the cases we know about, but we don't know about all of the possible interactions.)\n\nI'm going to leave this open to add a regression test on our end — I think this behavior, at least, we can replicate.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-09-26T15:25:55+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_541316338","fragment_type":"issue_comment","sequence":38,"text":"Does this mean that this will get fixed for Go1.14, but will still not work for 1.13?","author_login":"xavivars","author_association":"NONE","created_at":"2019-10-12T11:33:10+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_541320774","fragment_type":"issue_comment","sequence":39,"text":"@xavivars, this has already been fixed at head and backported to the 1.13 branch. It will be included in Go 1.13.3.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-12T12:32:22+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_543469371","fragment_type":"issue_comment","sequence":40,"text":"I've just tried with Go 1.13.3 but I still failed in `go get` my subgroup repository.\n\n$ go version\ngo version go1.13.3 linux/amd64\n\n$ go get -v gitlab.com/foo/bar/example\nget \"gitlab.com/foo/bar\": found meta tag get.metaImport{Prefix:\"gitlab.com/foo/bar\", VCS:\"git\", RepoRoot:\" URL at //gitlab.com/foo/bar?go-get=1\nget \"gitlab.com/foo/bar/example\": found meta tag get.metaImport{Prefix:\"gitlab.com/foo/bar\", VCS:\"git\", RepoRoot:\" URL at //gitlab.com/foo/bar/example?go-get=1\nget \"gitlab.com/foo/bar/example\": verifying non-authoritative meta tag\ngo get gitlab.com/foo/bar/example: git ls-remote -q URL in /home/koala/Workspace/gopath/pkg/mod/cache/vcs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: exit status 128:\n The project you were looking for could not be found.\n fatal: Could not read from remote repository.\n \n Please make sure you have the correct access rights\n and the repository exists.","author_login":"yookoala","author_association":"NONE","created_at":"2019-10-18T03:10:12+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_543755448","fragment_type":"issue_comment","sequence":41,"text":"@yookoala, you probably need to configure a `git` credential helper, or add a `.netrc` file containing credentials. (The `go` command is not intended to prompt for interactive logins.)\n\nSee URL and #29953.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-18T13:47:23+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_543889686","fragment_type":"issue_comment","sequence":42,"text":"I'm still seeing an issue with 1.13.3 on linux. It's pulling the code, but fails with an error.\n\ngo version go1.13.3 linux/amd64\n\nGOPRIVATE=gitlab.my-org.com/* go get gitlab.my-org.com/subgroup/test/go-micro-example\ngo: finding gitlab.my-org.com/subgroup/test/go-micro-example latest\n# runtime\n/usr/local/go/src/runtime/stubs_x86.go:10:6: stackcheck redeclared in this block\n previous declaration at /usr/local/go/src/runtime/stubs_amd64x.go:10:6\n/usr/local/go/src/runtime/unaligned1.go:11:6: readUnaligned32 redeclared in this block\n previous declaration at /usr/local/go/src/runtime/alg.go:321:40\n/usr/local/go/src/runtime/unaligned1.go:15:6: readUnaligned64 redeclared in this block\n previous declaration at /usr/local/go/src/runtime/alg.go:329:40","author_login":"six-arm","author_association":"NONE","created_at":"2019-10-18T19:01:17+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_543893835","fragment_type":"issue_comment","sequence":43,"text":"@six-arm, that error message seems unrelated to the issue reported here. Please open a new issue with steps to reproduce.\n\nGiven that there is no `src/runtime/stubs_x86.go` file on `release-branch.go1.13`, I suspect that there is some problem with your `GOROOT` setting vs. the `go` command in use.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-18T19:12:07+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_544066004","fragment_type":"issue_comment","sequence":44,"text":"go version 1.13.3 fixed the problem. I have tried it against public (gitlab hosted) repo as well as self-hosted giltab. In both cases worked as expected. thx @bcmills and others helped to diagnose and address the problem.\n\nshould I close the ticket? This was my first ticket here and I'm not sure what the rule.","author_login":"umputun","author_association":"NONE","created_at":"2019-10-19T02:55:31+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_544136563","fragment_type":"issue_comment","sequence":45,"text":"@umputun, thanks for confirming! I'm planning to leave the issue open for adding a more realistic regression test in 1.14 (probably during the freeze).","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-19T12:01:24+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_544868438","fragment_type":"issue_comment","sequence":46,"text":"My go version:\n \n \n\nsimple description: \nwith private subgroup can not be `go get`, see below:\n**my-group are public**\n**my-private-group and it's project sample all are private**\n**my-group and it's project sample all are public**\n**private-demo are private**\n \ngo: finding git2.my-gitlab.net.cn/my-group/my-subgroup/sample latest\ngo: downloading git2.my-gitlab.net.cn/my-group/my-subgroup/sample v0.0.0-20191022081546-6534fce037e9\ngo: extracting git2.my-gitlab.net.cn/my-group/my-subgroup/sample v0.0.0-20191022081546-6534fce037e9\n \ngo get git2.my-gitlab.net.cn/my-group/my-private-subgroup/sample: git ls-remote -q origin in D:\\workspace\\code\\go\\pkg\\mod\\cache\\vcs\\8314af4c2579c0ee8b974f039f8246d179834d34c834680bfe59ce583888c820: exit status 128:\n remote: The project you were looking for could not be found.\n fatal: repository ' URL not found\n \ngo: finding git2.my-gitlab.net.cn/my-group/private-demo latest\ngo: downloading git2.my-gitlab.net.cn/my-group/private-demo v0.0.0-20191022084509-90eb539586c8\ngo: extracting git2.my-gitlab.net.cn/my-group/private-demo v0.0.0-20191022084509-90eb539586c8\n\nSo, have you tested private group or subgroup on gitlab?\n\nThanks anyway!","author_login":"GerryLon","author_association":"NONE","created_at":"2019-10-22T08:59:35+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_545089451","fragment_type":"issue_comment","sequence":47,"text":"No, I didn't but tried it now with similar setup - `commons` group public, `pkg` subgroup public and `syncs` repo private (internal in gitlab's permissions). I see very similar results:\n\ngo version go1.13.3 darwin/amd64\n\ngo get -v git.internal.com/commons/pkg/syncs\nget \"git.internal.com/commons/pkg\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at //git.internal.com/commons/pkg?go-get=1\nget \"git.internal.com/commons/pkg/syncs\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at //git.internal.com/commons/pkg/syncs?go-get=1\nget \"git.internal.com/commons/pkg/syncs\": verifying non-authoritative meta tag\ngo get git.internal.com/commons/pkg/syncs: git ls-remote -q URL in /Users/umputun/go-home/pkg/mod/cache/vcs/882b5ac6f69791979e3abd70af30e871e32fe91173f2e25079ef6a88464ec13e: exit status 128:\n \n fatal: Could not read from remote repository.\n\n Please make sure you have the correct access rights\n and the repository exists.\n\nNot sure if important, but to access private repos from go I use insteadOf rewrite:\n\n [url \"git@git.internal.com:\"]\n insteadOf = URL","author_login":"umputun","author_association":"NONE","created_at":"2019-10-22T18:18:16+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_545093669","fragment_type":"issue_comment","sequence":48,"text":"@umputun, thanks for the additional detail.\n\nThis line in particular:\n\nget \"git.internal.com/commons/pkg/syncs\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at //git.internal.com/commons/pkg/syncs?go-get=1\n\nseems to indicate a bug or misconfiguration on the server side. If the repo is hosted at `git.internal.com/commons/pkg/syncs`, then the server should reply with that as the prefix and ` URL as the repo root (instead of the `git.internal.com/commons/pkg` subgroup as shown).\n\nDid that repository work with Go 1.12?","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-22T18:29:02+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_545102827","fragment_type":"issue_comment","sequence":49,"text":"doesn't work with 1.12 either\n\ngo version go1.12.12 linux/amd64, from `golang:1.12` container:\n\ngo get -v git.internal.com/commons/pkg/syncs\n\nFetching URL \nParsing meta tags from URL (status code 200)\nget \"git.internal.com/commons/pkg/syncs\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at URL \nget \"git.internal.com/commons/pkg/syncs\": verifying non-authoritative meta tag\nFetching URL \nParsing meta tags from URL (status code 200)\nFetching URL \nParsing meta tags from URL (status code 200)\nget \"git.internal.com/commons/pkg\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at URL \nFetching URL \nParsing meta tags from URL (status code 200)\nFetching URL \nParsing meta tags from URL (status code 200)\ngo get git.internal.com/commons/pkg/syncs: git ls-remote -q origin in /go/pkg/mod/cache/vcs/82b580717104e8b7bf1de06ef2b675a3ca5bf7d044f776fac4629633677f22da: exit status 128:\n \n fatal: Could not read from remote repository.\n\n Please make sure you have the correct access rights\n and the repository exists. \n\nHowever with ~/.netrc everyting seems to work (1.1.13):\n\ngo get -v git.internal.com/commons/pkg/syncs\nget \"git.internal.com/commons/pkg\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg\", VCS:\"git\", RepoRoot:\" URL at //git.internal.com/commons/pkg?go-get=1\nget \"git.internal.com/commons/pkg/syncs\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg/syncs\", VCS:\"git\", RepoRoot:\" URL at //git.internal.com/commons/pkg/syncs?go-get=1\ngo: finding git.internal.com/commons/pkg/syncs v1.1.0\ngo: downloading git.internal.com/commons/pkg/syncs v1.1.0\ngo: extracting git.internal.com/commons/pkg/syncs v1.1.0\nget \"git.internal.com/commons/pkg/multierror\": found meta tag get.metaImport{Prefix:\"git.internal.com/commons/pkg/multierror\", VCS:\"git\", RepoRoot:\" URL at //git.internal.com/commons/pkg/multierror?go-get=1\ngit.internal.com/commons/pkg/multierror\ngit.internal.com/commons/pkg/syncs \n\nSo, looks like .gitconfig insteadOf doesn't play well with go mods, but .netrc is fine.","author_login":"umputun","author_association":"NONE","created_at":"2019-10-22T18:52:05+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_545105875","fragment_type":"issue_comment","sequence":50,"text":"`.netrc` is what I would recommend anyway, so it sounds like the overall state is improving, at least. (`.netrc` wasn't working well in 1.12.)","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-22T18:59:22+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_546614527","fragment_type":"issue_comment","sequence":51,"text":"I'm still facing this issue with `go version go1.13.3 darwin/amd64`","author_login":"sha256x","author_association":"NONE","created_at":"2019-10-26T15:50:35+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_547112988","fragment_type":"issue_comment","sequence":52,"text":"@sha256x, “this issue” as reported by its original author has been verified as fixed. If you're seeing a similar symptom, please open a new issue with details and steps to reproduce it.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-10-28T19:40:44+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_553906281","fragment_type":"issue_comment","sequence":53,"text":"@bcmills @sha256x @umputun There is still the issue where with git-based URL rewriting in combination with GitLab groups you cannot successfully `go get ...` a repo unless you tell `go get` in the import path where the git repo actually is, such as `foo.bar.org/user/group1/group2/project.git` -- and then go modules throw up because the canonical path of that module is `foo.bar.org/user/group1/group2/project` without any `.git` adornments. Am I supposed to change the canonical import paths of my private Go modules now to carry that `.git` adornment?","author_login":"TheDiveO","author_association":"NONE","created_at":"2019-11-14T14:14:59+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_553909081","fragment_type":"issue_comment","sequence":54,"text":"Can you please explain? (otherwise, I cannot see how your reply might be of use to those who are not enlightened enough, such as me.)","author_login":"TheDiveO","author_association":"NONE","created_at":"2019-11-14T14:22:01+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_556898897","fragment_type":"issue_comment","sequence":55,"text":"@TheDiveO We had a similar problem, we solved it by using the `replace` directive. For example:\n\nrequire (\n private.gitlab.instance/project/team/somename v1.0.0\n)\n\nreplace (\n private.gitlab.instance/project/team/somename => private.gitlab.instance/project/team/somename.git v1.0.0\n)\n\nHowever please be aware that this solution does not work cleanly when trying to upgrade that said package to non-tagged versions, for example you would need to do something like:\n\ngo get private.gitlab.instance/project/team/somename.git@somecommithash \n\nWhich then will fail with a message similar to:\n\ngo: finding private.gitlab.instance/project/team somecommithash\ngo: finding private.gitlab.instance/project/team/somename.git somecommithash\ngo: downloading private.gitlab.instance/project/team/somename.git vXYZ-somecommithash\ngo: extracting private.gitlab.instance/project/team/somename.git vXYZ-somecommithash\ngo get: private.gitlab.instance/project/team/somename.git@vXYZ-somecommithash: parsing go.mod:\n module declares its path as: private.gitlab.instance/project/team/somename\n but was required as: private.gitlab.instance/project/team/somename.git\n\nWe literally have to copy `vXYZ-somecommithash`, manually edit `go.mod` and the overwrite that value, changing it to something like\n\nrequire (\n private.gitlab.instance/project/team/somename v1.0.0\n)\n\nreplace (\n private.gitlab.instance/project/team/somename => private.gitlab.instance/project/team/somename.git vXYZ-somecommithash\n)","author_login":"MarioCarrion","author_association":"NONE","created_at":"2019-11-21T03:13:55+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_562174242","fragment_type":"issue_comment","sequence":56,"text":"@TheDiveO, @MarioCarrion: if you are having issues with GitLab subgroups for reasons unrelated to the root cause originally reported for this issue, please open a new issue with details and steps to reproduce. Thanks.","author_login":"bcmills","author_association":"MEMBER","created_at":"2019-12-05T15:17:42+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_589815380","fragment_type":"issue_comment","sequence":57,"text":"I didn't get to the more realistic regression test during the 1.14 cycle, and by now I don't remember which cases were remaining to be tested. 😞\n\nI'm happy to review further improvements to GitLab integration testing, but I don't think we need to leave this issue open.","author_login":"bcmills","author_association":"MEMBER","created_at":"2020-02-21T20:08:25+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_591369061","fragment_type":"issue_comment","sequence":58,"text":"GitLab Community Edition 12.3.5 self-hosted\ngolang 1.13.8 & 1.14\nthis issue still there","author_login":"Yi-Hunter","author_association":"NONE","created_at":"2020-02-26T11:02:58+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_591437741","fragment_type":"issue_comment","sequence":59,"text":"@Yi-Hunter, “this issue” as reported by its original author has been verified as fixed. If you're seeing a similar symptom, please open a new issue with details and steps to reproduce it.","author_login":"bcmills","author_association":"MEMBER","created_at":"2020-02-26T13:55:34+08:00","repo_name":"golang/go","issue_id":489466287,"issue_number":34094,"issue_url":"https://github.com/golang/go/issues/34094","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0488","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"TypeError: Cannot read properties of undefined (reading 'sourceName')?","query_context":"### Version of Hardhat\n\n2.12.7\n\n### What happened?\n\n21 passing (2s)\n 1 failing\n\n/Users/k06a/Projects/limit-order-protocol/node_modules/hardhat/internal/hardhat-network/stack-traces/solidity-errors.js:111\n return new SolidityCallSite(sourceReference.sourceName, sourceReference.contract, sourceReference.function !== undefined\n ^\n\nTypeError: Cannot read properties of undefined (reading 'sourceName')\n(Use `node --trace-uncaught ...` to show where the exception was thrown)\nerror Command failed with exit code 7.\ninfo Visit URL for documentation about this command.\n\n### Minimal reproduction steps\n\nOn the following commit URL \n\nyarn && yarn test:ci --bail\n\n### Search terms\n\n_No response_","known_context_document_ids":["gh_issue_1582668934"],"reference_answer":"That's the first item in the checklist.\n \n\nThat's a llimitation of npm when a peer dependency and a pre-release version are mixed. You might need to use `npm install --force` when installing the `hardhat@ir` beta version.","answer_document_id":"gh_comment_1322377505","silver_evidence_path":["gh_comment_1438251288","gh_issue_1458215631","gh_comment_1322377505"],"evidence_issue_ids":[1582668934,1458215631],"source_repo_name":"NomicFoundation/hardhat","source_issue_id":1582668934,"source_issue_number":3670,"source_issue_url":"https://github.com/NomicFoundation/hardhat/issues/3670","target_repo_name":"NomicFoundation/hardhat","target_issue_id":1458215631,"target_issue_number":3365,"target_issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","reference_anchor_document_id":"gh_comment_1438251288","reference_answer_author":"fvictorio","reference_answer_author_association":"MEMBER","quality_score":80.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.1667,"target_answer_overlap":0.2941},"issue_created_at":"2023-02-13T16:26:46+08:00","valid_comment_count":15,"fragments":[{"document_id":"gh_issue_1582668934","fragment_type":"issue_description","sequence":0,"text":"TypeError: Cannot read properties of undefined (reading 'sourceName')\n### Version of Hardhat\n\n2.12.7\n\n### What happened?\n\n21 passing (2s)\n 1 failing\n\n/Users/k06a/Projects/limit-order-protocol/node_modules/hardhat/internal/hardhat-network/stack-traces/solidity-errors.js:111\n return new SolidityCallSite(sourceReference.sourceName, sourceReference.contract, sourceReference.function !== undefined\n ^\n\nTypeError: Cannot read properties of undefined (reading 'sourceName')\n(Use `node --trace-uncaught ...` to show where the exception was thrown)\nerror Command failed with exit code 7.\ninfo Visit URL for documentation about this command.\n\n### Minimal reproduction steps\n\nOn the following commit URL \n\nyarn && yarn test:ci --bail\n\n### Search terms\n\n_No response_","author_login":"k06a","author_association":"CONTRIBUTOR","created_at":"2023-02-13T16:26:46+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1582668934,"issue_number":3670,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3670","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1429879767","fragment_type":"issue_comment","sequence":1,"text":"Hey,\n\nThis should be fixed by #3415. I published a pre-release version of it as `hardhat@viair` and run your tests and now I get \n \n\nCan you check if that error is correct?","author_login":"alcuadrado","author_association":"MEMBER","created_at":"2023-02-14T14:57:31+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1582668934,"issue_number":3670,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1430043059","fragment_type":"issue_comment","sequence":2,"text":"@alcuadrado seems like something which can be correct for sure.","author_login":"k06a","author_association":"CONTRIBUTOR","created_at":"2023-02-14T16:37:09+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1582668934,"issue_number":3670,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1436009860","fragment_type":"issue_comment","sequence":3,"text":"Resolved the error for me. \n\n`MultiSolcUserConfig` compiler entry\n\n{\n version: \"0.8.14\",\n settings: {\n viaIR: true,\n optimizer: {\n enabled: true,\n runs: 200,\n details: {\n constantOptimizer: false,\n deduplicate: true,\n yul: true,\n },\n },\n outputSelection: {\n \"*\": {\n \"*\": [\n \"metadata\",\n \"abi\",\n \"storageLayout\",\n \"evm.methodIdentifiers\",\n \"devdoc\",\n \"userdoc\",\n \"evm.gasEstimates\",\n \"evm.byteCode\",\n ],\n },\n },\n },\n},","author_login":"panukettu","author_association":"NONE","created_at":"2023-02-19T14:55:37+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1582668934,"issue_number":3670,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3670","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1438251288","fragment_type":"issue_comment","sequence":4,"text":"Pretty sure this is caused by #3365, so I'm tentatively closing this.","author_login":"fvictorio","author_association":"MEMBER","created_at":"2023-02-21T10:41:41+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1582668934,"issue_number":3670,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3670","linked_issue_ids":[1458215631],"is_known_query_context":false},{"document_id":"gh_issue_1458215631","fragment_type":"issue_description","sequence":0,"text":"Support for IR\nThis is the tracking issue for having full support for solc's IR-based code generation.\n\nWe have already released a beta version with some basic support under the `ir` npm tag. This version can be installed with `npm install hardhat@ir`.\n\nThere are some pending things before we can release this in a stable version of Hardhat:\n\n- [ ] Reverts with a reason string sometimes are not correctly handled (see discussion in #2453). I'm not sure if this was fixed on the `ir` version or not.\n- [ ] What are exactly the best settings to have `viaIR` enabled but not lose important information used by stack traces and error inferring? Can we enable those settings automatically or should users do it?\n- [ ] `solidity-coverage` seems to have issues when `viaIR` is enabled (see for example this comment). It's not clear if this is a problem in Hardhat or in the coverage plugin, or in both. It might also be just a documentation issue.\n- [ ] At some point the \"contract too large\" heuristic wasn't working (see #2115). I believe this is fixed in the `ir` version, but we should double-check.","author_login":"fvictorio","author_association":"MEMBER","created_at":"2022-11-21T16:17:32+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1322348100","fragment_type":"issue_comment","sequence":1,"text":"The issue I'm having is my tests are now failing with viaIR: true, specifically the ones that check the revertedWith message. Which is a lot of them.\n\nFor now, I'm having to turn viaIR off. Help me help us get to the bottom of it!","author_login":"scotthconner","author_association":"NONE","created_at":"2022-11-21T16:41:55+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1322357583","fragment_type":"issue_comment","sequence":2,"text":"Also, turns out that hardhat@ir doesn't work with my version of solidity-coverage:\n\npm ERR! While resolving: @nomicfoundation/hardhat-toolbox@1.0.2\nnpm ERR! Found: solidity-coverage@0.8.2\nnpm ERR! node_modules/solidity-coverage\nnpm ERR! dev solidity-coverage@\"^0.8.2\" from the root project\nnpm ERR!\nnpm ERR! Could not resolve dependency:\nnpm ERR! peer solidity-coverage@\"^0.7.21\" from @nomicfoundation/hardhat-toolbox@1.0.2\nnpm ERR! node_modules/@nomicfoundation/hardhat-toolbox\nnpm ERR! @nomicfoundation/hardhat-toolbox@\"^1.0.2\" from the root project\nnpm ERR!\nnpm ERR! Conflicting peer dependency: solidity-coverage@0.7.22\nnpm ERR! node_modules/solidity-coverage\nnpm ERR! peer solidity-coverage@\"^0.7.21\" from @nomicfoundation/hardhat-toolbox@1.0.2\nnpm ERR! node_modules/@nomicfoundation/hardhat-toolbox\nnpm ERR! @nomicfoundation/hardhat-toolbox@\"^1.0.2\" from the root project","author_login":"scotthconner","author_association":"NONE","created_at":"2022-11-21T16:50:16+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1322377505","fragment_type":"issue_comment","sequence":3,"text":"That's the first item in the checklist.\n \n\nThat's a llimitation of npm when a peer dependency and a pre-release version are mixed. You might need to use `npm install --force` when installing the `hardhat@ir` beta version.","author_login":"fvictorio","author_association":"MEMBER","created_at":"2022-11-21T17:04:28+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1322426224","fragment_type":"issue_comment","sequence":4,"text":"Yup, thanks. I did --force and that worked.\n\nIt also works when running npm hardhat test. But when running coverage I get stack too deep.","author_login":"scotthconner","author_association":"NONE","created_at":"2022-11-21T17:39:31+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1369661709","fragment_type":"issue_comment","sequence":5,"text":"Is there a timeline for this to be included in the main release? Now that it's mark as ready I mean","author_login":"jmendiola222","author_association":"NONE","created_at":"2023-01-03T11:29:20+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1369674825","fragment_type":"issue_comment","sequence":6,"text":"@jmendiola222 we want to release this ASAP. Hopefully this or next week; definitely January.","author_login":"fvictorio","author_association":"MEMBER","created_at":"2023-01-03T11:43:52+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1407502717","fragment_type":"issue_comment","sequence":7,"text":"With IR, I get the following exception:\n\nAssertionError: Expected transaction to be reverted with ABC, but other\nexception was thrown: ProviderError: Error: Transaction reverted: function\nwas called with incorrect parameters\n\nfrom a function as simple as:\n\nfunction f() public {\n revert(\"ABC\");\n}\n\nWhen IR is not used, or other parts of the contracts are tinkered, or YUL steps are tinkered, the issue resolves. This issue is very similar to URL so I suspect it's a Hardhat issue.\n\nI tried many combinations of recent Solidity versions with Hardhat `2.12.6` and `2.12.1-ir.0`. My compiler settings are:\n\nviaIR: true,\noptimizer: {\n enabled: true,\n runs: 200\n}\n\nCurrently working around the issue with a custom order of YUL optimization steps.\n\nLet me know if you think if this's a Solidity issue.","author_login":"hantuzun","author_association":"NONE","created_at":"2023-01-28T22:35:34+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1407503255","fragment_type":"issue_comment","sequence":8,"text":"This's the stack trace from Hardhat `2.12.6`:\n\neth_estimateGas\n Error: Transaction reverted: function was called with incorrect parameters\n at Contract.f\n at processTicksAndRejections (node:internal/process/task_queues:96:5)\n at async EthModule._estimateGasAction (node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:429:7)\n at async HardhatNetworkProvider._sendWithLogging (node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:139:22)\n at async HardhatNetworkProvider.request (node_modules/hardhat/src/internal/hardhat-network/provider/provider.ts:116:18)\n at async JsonRpcHandler._handleRequest (node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:188:20)\n at async JsonRpcHandler._handleSingleRequest (node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:167:17)\n at async Server.JsonRpcHandler.handleHttp (node_modules/hardhat/src/internal/hardhat-network/jsonrpc/handler.ts:52:21)","author_login":"hantuzun","author_association":"NONE","created_at":"2023-01-28T22:38:51+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1424997065","fragment_type":"issue_comment","sequence":9,"text":"It didn't make it to the last release. :( Any update on the plan? @fvictorio","author_login":"jmendiola222","author_association":"NONE","created_at":"2023-02-10T00:02:12+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439587337","fragment_type":"issue_comment","sequence":10,"text":"I'm planning on merging that PR today, so it will definitely be included in the next release (this time for real :sweat_smile:).","author_login":"fvictorio","author_association":"MEMBER","created_at":"2023-02-22T08:09:18+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1460211896","fragment_type":"issue_comment","sequence":11,"text":"this warning when running tests\n\nYour solidity settings have viaIR enabled, which is not fully supported yet. You can still use Hardhat, but some features, like stack traces, might not work correctly.\n\nand losing information about error strings\n\nAssertionError: error string Error: Transaction reverted and Hardhat couldn't infer the reason.\n\nwith 2.13.0","author_login":"thedavidmeister","author_association":"NONE","created_at":"2023-03-08T14:09:22+08:00","repo_name":"NomicFoundation/hardhat","issue_id":1458215631,"issue_number":3365,"issue_url":"https://github.com/NomicFoundation/hardhat/issues/3365","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0489","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Places: cannot edit page (editorial team not on Fre side)?","query_context":"Users are not able to edit a places record. This is because on the French side, the editorial team is not selected. Linked to URL","known_context_document_ids":["gh_issue_2773485778"],"reference_answer":"Also occurring on the Know the hazards in your community page.\n\nRelated Drupal error message here.\n\nInvalidArgumentException: The URI '/en/prevent-prepare-wildfire#prepare-for-an-approaching-wildfire' is invalid. You must use a valid URI scheme. in Drupal\\Core\\Url::fromUri() (line 293 of /var/www/yukon-ca-d10/docroot/core/lib/Drupal/Core/Url.php).","answer_document_id":"gh_comment_2814169074","silver_evidence_path":["gh_comment_2575995796","gh_issue_2723765327","gh_comment_2814169074"],"evidence_issue_ids":[2773485778,2723765327],"source_repo_name":"ytgov/yukon-ca","source_issue_id":2773485778,"source_issue_number":817,"source_issue_url":"https://github.com/ytgov/yukon-ca/issues/817","target_repo_name":"ytgov/yukon-ca","target_issue_id":2723765327,"target_issue_number":746,"target_issue_url":"https://github.com/ytgov/yukon-ca/issues/746","reference_anchor_document_id":"gh_comment_2575995796","reference_answer_author":"sboots","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.3125,"anchor_target_overlap":0.4118,"target_answer_overlap":0.1481},"issue_created_at":"2025-01-07T18:31:03+08:00","valid_comment_count":12,"fragments":[{"document_id":"gh_issue_2773485778","fragment_type":"issue_description","sequence":0,"text":"Places: cannot edit page (editorial team not on Fre side)\nUsers are not able to edit a places record. This is because on the French side, the editorial team is not selected. Linked to URL","author_login":"lgontard","author_association":"COLLABORATOR","created_at":"2025-01-07T18:31:03+08:00","repo_name":"ytgov/yukon-ca","issue_id":2773485778,"issue_number":817,"issue_url":"https://github.com/ytgov/yukon-ca/issues/817","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_2575995796","fragment_type":"issue_comment","sequence":1,"text":"Linked to\nEditing page leads to \"encountered unexpected error\" (InvalidArgumentException error) · Issue #746 · ytgov/yukon-ca\n\nDepartment field missing on French side of Places · Issue #810 · ytgov/yukon-ca","author_login":"lgontard","author_association":"COLLABORATOR","created_at":"2025-01-07T18:45:57+08:00","repo_name":"ytgov/yukon-ca","issue_id":2773485778,"issue_number":817,"issue_url":"https://github.com/ytgov/yukon-ca/issues/817","linked_issue_ids":[2723765327],"is_known_query_context":false},{"document_id":"gh_comment_2583931319","fragment_type":"issue_comment","sequence":2,"text":"Please review this PR - #824 \n\nThis is a custom function that will update data on hitting the URL below:\n\n URL","author_login":"w3creatives","author_association":"COLLABORATOR","created_at":"2025-01-10T20:07:26+08:00","repo_name":"ytgov/yukon-ca","issue_id":2773485778,"issue_number":817,"issue_url":"https://github.com/ytgov/yukon-ca/issues/817","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2723765327","fragment_type":"issue_description","sequence":0,"text":"Editing page leads to \"encountered unexpected error\" (InvalidArgumentException error)\nWhen trying to edit a node, the site crashes with the error:\n \n\nThis seems to apply only to certain roles. \n \n \n\nThis is when accessing URL with a use having the following roles: \n- Writer\n- Editor\n- Publisher\n- Author In-Page Alerts\n- Blog Author\n- Author Site-Wide Alerts\n\nI am able to load the node-edit page with a user having the \"administrator\" role.\n\nError reported from Drupal (visible in Watchdog):\n \n\nReported by YHC","author_login":"leeomara","author_association":"MEMBER","created_at":"2024-12-06T19:24:02+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2524011263","fragment_type":"issue_comment","sequence":1,"text":"I'm unable to re-save that record, as it doesn't have any \"Places record type\" value. It looks like D7 doesn't have one either. Strange.","author_login":"leeomara","author_association":"MEMBER","created_at":"2024-12-06T19:30:13+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2524025545","fragment_type":"issue_comment","sequence":2,"text":"I've since made the \"Places record type\" not required on D10, and re-save the record. It now appears editable by others.\n\nCuriously, the list of available paragraph types from the \"Places record type\" list doesn't match what it's configured for.\n\n<img width=\"719\" alt=\"Screen Shot 2024-12-06 at 12 37 28 PM\" src=\" URL \n\n<img width=\"925\" alt=\"Screen Shot 2024-12-06 at 12 38 21 PM\" src=\" URL","author_login":"leeomara","author_association":"MEMBER","created_at":"2024-12-06T19:39:10+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2557846458","fragment_type":"issue_comment","sequence":3,"text":"This was reported again for URL e.g. URL \n\nSame also on prod.","author_login":"leeomara","author_association":"MEMBER","created_at":"2024-12-20T22:41:48+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2575994830","fragment_type":"issue_comment","sequence":4,"text":"Linked to\nPlaces: cannot edit page (editorial team not on Fre side) · Issue #817 · ytgov/yukon-ca\nDepartment field missing on French side of Places · Issue #810 · ytgov/yukon-ca","author_login":"lgontard","author_association":"COLLABORATOR","created_at":"2025-01-07T18:45:24+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2584143116","fragment_type":"issue_comment","sequence":5,"text":"Please review this PR - #824 \n\nThis is a config change. This was because of Linkit module. We have changed the setting as shown in the screenshot.\n\n URL","author_login":"w3creatives","author_association":"COLLABORATOR","created_at":"2025-01-10T20:55:02+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2686316222","fragment_type":"issue_comment","sequence":6,"text":"This was recently reported for some campground pages\n\n- URL \n- URL \n- URL \n- URL \n\nThe watchdog log showed:","author_login":"leeomara","author_association":"MEMBER","created_at":"2025-02-26T22:08:04+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2712070136","fragment_type":"issue_comment","sequence":7,"text":"We can address issue as it arises, but that can be a lot of work when it's a large grouping of pages.","author_login":"lgontard","author_association":"COLLABORATOR","created_at":"2025-03-10T23:25:45+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2715577310","fragment_type":"issue_comment","sequence":8,"text":"Updating the widget option linkit >> link for solve latest comment issue.","author_login":"w3creatives","author_association":"COLLABORATOR","created_at":"2025-03-11T20:01:59+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2814169074","fragment_type":"issue_comment","sequence":9,"text":"Also occurring on the Know the hazards in your community page.\n\nRelated Drupal error message here.\n\nInvalidArgumentException: The URI '/en/prevent-prepare-wildfire#prepare-for-an-approaching-wildfire' is invalid. You must use a valid URI scheme. in Drupal\\Core\\Url::fromUri() (line 293 of /var/www/yukon-ca-d10/docroot/core/lib/Drupal/Core/Url.php).","author_login":"sboots","author_association":"MEMBER","created_at":"2025-04-17T22:58:20+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3657092409","fragment_type":"issue_comment","sequence":10,"text":"Affecting campground pages. Seems to be fixed if Text format dropdown menu under Site description (app) field is changed to plain text \n\n \n\n Camping Nunatuk | Yukon.ca\n\nCamping Rock River | Yukon.ca\n\nCamping Simpson Lake | Yukon.ca","author_login":"lgontard","author_association":"NONE","created_at":"2025-12-15T18:47:40+08:00","repo_name":"ytgov/yukon-ca","issue_id":2723765327,"issue_number":746,"issue_url":"https://github.com/ytgov/yukon-ca/issues/746","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0490","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[PRE REVIEW]: blendR: An R package for blending survival curves?","query_context":"**Submitting author:** @n8thangreen ( )\n**Repository:** URL \n**Branch with paper.md** (empty if default branch): JOSS-paper \n**Version:** v1.0.0 \n**Editor:** @lrnv \n**Reviewers:** @NicolasNgo, @Nicolas-Schmidt \n**Managing EiC:** Chris Vernon\n\n## Status\n\nstatus\n\nStatus badge code:\n\nHTML: <a href=\" URL src=\" URL \nMarkdown: status\n\n**Author instructions**\n\nThanks for submitting your paper to JOSS @n8thangreen. **Currently, there isn't a JOSS editor assigned** to your paper.\n\n@n8thangreen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.\n\n**Editor instructions**\n\nThe JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:\n\n@editorialbot commands","known_context_document_ids":["gh_issue_3276991791"],"reference_answer":"Check final proof :point_right: URL \n\nIf the paper PDF and Crossref deposit XML look good in URL then you can now move forward with accepting the submission by compiling again with the flag `deposit=true` e.g.\n \n\n@whedon accept deposit=true","answer_document_id":"gh_comment_436146316","silver_evidence_path":["gh_comment_3136270512","gh_issue_361027685","gh_comment_436146316"],"evidence_issue_ids":[3276991791,361027685],"source_repo_name":"openjournals/joss-reviews","source_issue_id":3276991791,"source_issue_number":8672,"source_issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","target_repo_name":"openjournals/joss-reviews","target_issue_id":361027685,"target_issue_number":961,"target_issue_url":"https://github.com/openjournals/joss-reviews/issues/961","reference_anchor_document_id":"gh_comment_3136270512","reference_answer_author":"whedon","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1884,"anchor_target_overlap":0.2935,"target_answer_overlap":0.2083},"issue_created_at":"2025-07-30T13:04:18+08:00","valid_comment_count":22,"fragments":[{"document_id":"gh_issue_3276991791","fragment_type":"issue_description","sequence":0,"text":"[PRE REVIEW]: blendR: An R package for blending survival curves\n**Submitting author:** @n8thangreen ( )\n**Repository:** URL \n**Branch with paper.md** (empty if default branch): JOSS-paper \n**Version:** v1.0.0 \n**Editor:** @lrnv \n**Reviewers:** @NicolasNgo, @Nicolas-Schmidt \n**Managing EiC:** Chris Vernon\n\n## Status\n\nstatus\n\nStatus badge code:\n\nHTML: <a href=\" URL src=\" URL \nMarkdown: status\n\n**Author instructions**\n\nThanks for submitting your paper to JOSS @n8thangreen. **Currently, there isn't a JOSS editor assigned** to your paper.\n\n@n8thangreen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.\n\n**Editor instructions**\n\nThe JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:\n\n@editorialbot commands","author_login":"editorialbot","author_association":"COLLABORATOR","created_at":"2025-07-30T13:04:18+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_3136266158","fragment_type":"issue_comment","sequence":1,"text":"**License info**:\n\n🟡 License found: `GNU General Public License v3.0` (Check here for OSI approval)","author_login":"editorialbot","author_association":"COLLABORATOR","created_at":"2025-07-30T13:05:33+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3136267377","fragment_type":"issue_comment","sequence":2,"text":":point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:","author_login":"editorialbot","author_association":"COLLABORATOR","created_at":"2025-07-30T13:05:48+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3136270512","fragment_type":"issue_comment","sequence":3,"text":"**Five most similar historical JOSS papers:**\n\n⚠️ **Important note to authors:** Please do not directly contact the authors of these papers. If you believe these papers are relevant to your submission, please mention this in your submission or communicate with your handling editor.\n\nBayesMFSurv: An R Package to Estimate Bayesian Split-Population Survival Models With (and Without) Misclassified Failure Events\nSubmitting author: \n@Nicolas-Schmidt\n\nHandling editor: \n@marcosvital (Active)\n\nReviewers: \n@alletsee, @andybega\n\nSimilarity score: 0.6731\n\nsurvxai: an R package for structure-agnostic explanations of survival models\nSubmitting author: \n@AleksandraDabrowska\n\nHandling editor: \n@yochannah (Retired)\n\nReviewers: \n@hiendn, @dirmeier\n\nSimilarity score: 0.6620\n\nSurPyval: Survival Analysis with Python\nSubmitting author: \n@derrynknife\n\nHandling editor: \n@dfm (Retired)\n\nReviewers: \n@CamDavidsonPilon, @MatthewReid854\n\nSimilarity score: 0.6473\n\nRBF: An R package to compute a robust backfitting estimator for additive models\nSubmitting author: \n@alemermartinez\n\nHandling editor: \n@mikldk (Retired)\n\nReviewers: \n@mcavs, @mmrabe\n\nSimilarity score: 0.6397\n\nPyMSM: Python package for Competing Risks and Multi-State models for Survival Data\nSubmitting author: \n@hrossman\n\nHandling editor: \n@majensen (Active)\n\nReviewers: \n@CamDavidsonPilon, @stefanocoretta\n\nSimilarity score: 0.6302\n\n⚠️ **Note to editors:** If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors *before* considering asking the reviewers of these papers to review again for JOSS.","author_login":"editorialbot","author_association":"COLLABORATOR","created_at":"2025-07-30T13:06:27+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[361027685],"is_known_query_context":false},{"document_id":"gh_comment_3232113829","fragment_type":"issue_comment","sequence":4,"text":"Sorry but I am not available to perform this review\n\nHave a great day\n\nSincerely,\n\nMathieu FAUVERNIER\n\nLe mer. 27 août 2025 à 15:23, Oskar Laverny ***@***.***> a\nécrit :","author_login":"fauvernierma","author_association":"NONE","created_at":"2025-08-28T06:30:41+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3232960707","fragment_type":"issue_comment","sequence":5,"text":"I would be interested in this review, but I won't be available before October. \n\nKind regards,","author_login":"NicolasNgo","author_association":"NONE","created_at":"2025-08-28T10:41:20+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_3319288429","fragment_type":"issue_comment","sequence":6,"text":"@Nicolas-Schmidt, @NicolasNgo , @n8thangreen, let us change thread for the review itself.","author_login":"lrnv","author_association":"NONE","created_at":"2025-09-22T14:12:06+08:00","repo_name":"openjournals/joss-reviews","issue_id":3276991791,"issue_number":8672,"issue_url":"https://github.com/openjournals/joss-reviews/issues/8672","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_361027685","fragment_type":"issue_description","sequence":0,"text":"[REVIEW]: survxai: an R package for model agnostic explanations of survival models\n**Submitting author:** @AleksandraDabrowska ( )\n**Repository:** URL \n**Version:** 0.2.0\n**Editor:** @yochannah\n**Reviewer:** @hiendn, @dirmeier\n**Archive:** 10.5281/zenodo.1477857 \n\n## Status\n\nstatus\n\nStatus badge code:\n\nHTML: target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\n\n## Reviewer instructions & questions\n\n@hiendn & @dirmeier, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\n1. Make sure you're logged in to your GitHub account\n2. Be sure to accept the invite at this URL: URL \n\nThe reviewer guidelines are available here: URL Any questions/concerns please let @yochannah know.\n\n✨ **Please try and complete your review in the next two weeks** ✨ \n\n## Review checklist for @hiendn\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the JOSS code of conduct.\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the ?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?\n- [x] **Version:** Does the release version given match the GitHub release (0.2.0)?\n- [x] **Authorship:** Has the submitting author (@AleksandraDabrowska) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\n\n## Review checklist for @dirmeier\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the JOSS code of conduct.\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the ?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?\n- [x] **Version:** Does the release version given match the GitHub release (0.2.0)?\n- [x] **Authorship:** Has the submitting author (@AleksandraDabrowska) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-09-17T20:20:16+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_422156577","fragment_type":"issue_comment","sequence":1,"text":"Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @hiendn, it looks like you're currently assigned as the reviewer for this paper :tada:.\n\n**:star: Important :star:**\n\nIf you haven't already, you should seriously consider unsubscribing from GitHub notifications for this ( URL repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿\n\nTo fix this do the following two things:\n\n1. Set yourself as 'Not watching' URL \n\nwatching\n\n2. You may also like to change your default settings for this watching repositories in your GitHub profile here: URL \n\nnotifications\n\nFor a list of things I can do to help you, just type:\n\n@whedon commands","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-09-17T20:20:19+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_423161789","fragment_type":"issue_comment","sequence":2,"text":"Hi @AleksandraDabrowska, I am one of your reviewers! My comments and suggestions will be posted on the issues page of your repository.","author_login":"hiendn","author_association":"NONE","created_at":"2018-09-20T12:18:39+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_427971529","fragment_type":"issue_comment","sequence":3,"text":"Quick status check - looking at the original repo, issues 18 to [21[( URL need to be addressed before we can take this one forward, right?","author_login":"yochannah","author_association":"NONE","created_at":"2018-10-08T20:39:17+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_427973908","fragment_type":"issue_comment","sequence":4,"text":"Yeah, exactly. From my side these two and 20. All of them are minor changes.","author_login":"dirmeier","author_association":"COLLABORATOR","created_at":"2018-10-08T20:47:30+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_428011393","fragment_type":"issue_comment","sequence":5,"text":"@yochannah that's correct, resolving 22 would be good as well, if possible.","author_login":"hiendn","author_association":"COLLABORATOR","created_at":"2018-10-08T23:31:03+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_433567574","fragment_type":"issue_comment","sequence":6,"text":"Hey @AleksandraDabrowska - could you rebuild the pdf once you are finished with the reviews? Then I can close the respective issues in your repository.","author_login":"dirmeier","author_association":"COLLABORATOR","created_at":"2018-10-26T23:18:43+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434239020","fragment_type":"issue_comment","sequence":7,"text":":point_right: Check article proof :page_facing_up: :point_left:","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-10-30T09:58:42+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_434334223","fragment_type":"issue_comment","sequence":8,"text":":point_right: Check article proof :page_facing_up: :point_left:","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-10-30T14:56:19+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_435555419","fragment_type":"issue_comment","sequence":9,"text":"@hiendn @dirmeier Thank you very much for reviewing and for your kind words! :)\nShould we now issue a DOI for our archive, as it is written in \"The review process\" section ( URL","author_login":"AleksandraDabrowska","author_association":"NONE","created_at":"2018-11-03T03:02:06+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_435682974","fragment_type":"issue_comment","sequence":10,"text":"@AleksandraDabrowska Looking good! Before generating the archive, though, there is one issue with the manuscript I'd like to fix. Figures 3 and 4 are interspersed with the references in the most recent proof, but I'm reasonably sure they should be up in the main paper text. Can you fix this? Once this is fixed, please do generate an archive and share the URL in this thread!! 🎉","author_login":"yochannah","author_association":"NONE","created_at":"2018-11-04T16:17:08+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_435804401","fragment_type":"issue_comment","sequence":11,"text":":point_right: Check article proof :page_facing_up: :point_left:","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-11-05T09:13:28+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_436146316","fragment_type":"issue_comment","sequence":12,"text":"Check final proof :point_right: URL \n\nIf the paper PDF and Crossref deposit XML look good in URL then you can now move forward with accepting the submission by compiling again with the flag `deposit=true` e.g.\n \n\n@whedon accept deposit=true","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-11-06T06:36:16+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_436146481","fragment_type":"issue_comment","sequence":13,"text":"Doing it live! Attempting automated processing of paper acceptance...","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-11-06T06:37:19+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_436146602","fragment_type":"issue_comment","sequence":14,"text":"🚨🚨🚨 **THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS!** 🚨🚨🚨\n\n Here's what you must now do:\n\n0. Check final PDF and Crossref metadata that was deposited :point_right: URL \n1. Wait a couple of minutes to verify that the paper DOI resolves URL \n2. If everything looks good, then close this review issue.\n3. Party like you just published a paper! 🎉🌈🦄💃👻🤘\n\n Any issues? notify your editorial technical team...","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-11-06T06:38:01+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_436151743","fragment_type":"issue_comment","sequence":15,"text":"@hiendn, @dirmeier - many thanks for your reviews here, and to @yochannah for editing this submission ✨ \n\n@AleksandraDabrowska - your paper is now accepted into JOSS :zap: :rocket: :boom:","author_login":"arfon","author_association":"MEMBER","created_at":"2018-11-06T07:06:16+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_436151757","fragment_type":"issue_comment","sequence":16,"text":":tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:\n\nIf you would like to include a link to your paper from your README use the following code snippets:\n\nMarkdown:\nDOI\n\nHTML:\n \n \n\nreStructuredText:\n.. image:: URL \n :target: URL \n\nThis is how it will look in your documentation:\n\nDOI\n\n**We need your help!**\n\nJournal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:\n\n- Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: URL \n- Making a small donation to support our running costs here: URL","author_login":"whedon","author_association":"COLLABORATOR","created_at":"2018-11-06T07:06:19+08:00","repo_name":"openjournals/joss-reviews","issue_id":361027685,"issue_number":961,"issue_url":"https://github.com/openjournals/joss-reviews/issues/961","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0492","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[HELP] [BUG] Can't discover BACnet devices - Version 3.4.4?","query_context":"**Describe the issue**\nCreate description about your issue, and your actions to solve it.\n\n Have set up the BACnet connector from my ThingsBoard cloud instance, but it's not discovering the devices on the network. The devices are both at 192.168.11.35:47808, with first device being the gateway that connects to the plug via wireless mesh, with both devices being discoverable on YABE from the desktop machine. The command I used to set up the container is below, minus the host and accessToken\n \n `docker run -d -it --network=host --expose 8082 -e host= -e port=1883 -e accessToken= -p 60000-61000:60000-61000 -v \"C:\\Users\\Office Demos\\Documents\\tb-gateway\\config:/thingsboard_gateway/config\" -v \"C:\\Users\\Office Demos\\Documents\\tb-gateway\\extensions:/thingsboard_gateway/extensions\" -v \"C:\\Users\\Office Demos\\Documents\\tb-gateway\\logs:/thingsboard_gateway/logs\" --name tb-gateway --restart always thingsboard/tb-gateway`\n\nimage\n\n**Configuration** (Attach your configuration file)\n**Notate: Remove Access token from file if you want to attach a tb_gateway.yaml**\n\n{\n \"thingsboard\": {\n \"host\": \"thingsboard.cloud\",\n \"port\": 1883,\n \"remoteShell\": false,\n \"remoteConfiguration\": true,\n \"statistics\": {\n \"enable\": true,\n \"statsSendPeriodInSeconds\": 3600,\n \"configuration\": null,\n \"commands\": []\n },\n \"deviceFiltering\": {\n \"enable\": false,\n \"filterFile\": \"list.json\"\n },\n \"maxPayloadSizeBytes\": 1024,\n \"minPackSendDelayMS\": 200,\n \"minPackSizeToSend\": 500,\n \"checkConnectorsConfigurationInSeconds\": 60,\n \"handleDeviceRenaming\": true,\n \"security\": {\n \"accessToken\": \"\"\n },\n \"qos\": 1,\n \"checkingDeviceActivity\": {\n \"checkDeviceInactivity\": false,\n \"inactivityTimeoutSeconds\": 200,\n \"inactivityCheckPeriodSeconds\": 500\n }\n },\n \"storage\": {\n \"type\": \"memory\",\n \"read_records_count\": 100,\n \"max_records_count\": 100000,\n \"data_folder_path\": \"./data/\",\n \"max_file_count\": 10,\n \"max_read_records_count\": 10,\n \"max_records_per_file\": 10000,\n \"data_file_path\": \"./data/data.db\",\n \"messages_ttl_check_in_hours\": 1,\n \"messages_ttl_in_days\": 7\n },\n \"grpc\": {\n \"enabled\": false,\n \"serverPort\": 9595,\n \"keepaliveTimeMs\": 10000,\n \"keepaliveTimeoutMs\": 5000,\n \"keepalivePermitWithoutCalls\": true,\n \"maxPingsWithoutData\": 0,\n \"minTimeBetweenPingsMs\": 10000,\n \"minPingIntervalWithoutDataMs\": 5000,\n \"keepAliveTimeMs\": 10000,\n \"keepAliveTimeoutMs\": 5000\n },\n \"connectors\": [\n {\n \"type\": \"bacnet\",\n \"name\": \"BACnet\",\n \"configuration\": \"bacnet.json\"\n }\n ]\n}\n\n**Connector name (If you need help with some connector/converter):**\nBACnet Connector\n\n{\n \"name\": \"BACnet\",\n \"logLevel\": \"DEBUG\",\n \"general\": {\n \"objectName\": \"TB_gateway\",\n \"address\": \"0.0.0.0:47808\",\n \"objectIdentifier\": 599,\n \"maxApduLengthAccepted\": 1476,\n \"segmentationSupported\": \"segmentedBoth\",\n \"vendorIdentifier\": 15\n },\n \"devices\": [\n {\n \"deviceName\": \"S_1AC0_DemoPlug\",\n \"deviceType\": \"default\",\n \"address\": \"192.168.11.35:47808\",\n \"pollPeriod\": 10000,\n \"timeseries\": [\n {\n \"key\": \"InsRealPower1\",\n \"type\": \"int\",\n \"objectId\": \"analogInput:2\",\n \"propertyId\": \"InsRealPower1\"\n }\n ]\n },\n {\n \"deviceName\": \"HoneywellGateway_MainOffice\",\n \"deviceType\": \"default\",\n \"address\": \"192.168.11.35:47808\",\n \"pollPeriod\": 10000\n }\n ]\n}\n\n**Error traceback (If it was raised):**\n\n**Versions (please complete the following information):**\n - OS: Windows 10 - Docker Desktop v 24.0.7\n - Thingsboard IoT Gateway version 3.4.4\n - Python version - 3.11.7","known_context_document_ids":["gh_issue_2121119834"],"reference_answer":"Hi @ttrading,\n\nThis issue was closed, if you discover some issue - please open the new one. Also, please provide your BACnet connector configuration. \n\nDue to typical issues with BACnet - please check that you set host for application - your IP in the same network, as device and port - 47808, mask usually - 24.\n\nFor device - please try to set * instead of host and * instead of port, this will enable global broadcast for device search. Aslo I should mention that you need to run the gateway and emulator on different devices, because emulator may reserver port 47808 and the gateway won't be able to use it for application.","answer_document_id":"gh_comment_2896525104","silver_evidence_path":["gh_comment_2360803859","gh_issue_2505148864","gh_comment_2896525104"],"evidence_issue_ids":[2121119834,2505148864],"source_repo_name":"thingsboard/thingsboard-gateway","source_issue_id":2121119834,"source_issue_number":1294,"source_issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1294","target_repo_name":"thingsboard/thingsboard-gateway","target_issue_id":2505148864,"target_issue_number":1520,"target_issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","reference_anchor_document_id":"gh_comment_2360803859","reference_answer_author":"imbeacon","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.122,"anchor_target_overlap":0.2683,"target_answer_overlap":0.1333},"issue_created_at":"2024-02-06T15:52:40+08:00","valid_comment_count":13,"fragments":[{"document_id":"gh_issue_2121119834","fragment_type":"issue_description","sequence":0,"text":"[HELP] [BUG] Can't discover BACnet devices - Version 3.4.4\n**Describe the issue**\nCreate description about your issue, and your actions to solve it.\n\n Have set up the BACnet connector from my ThingsBoard cloud instance, but it's not discovering the devices on the network. The devices are both at 192.168.11.35:47808, with first device being the gateway that connects to the plug via wireless mesh, with both devices being discoverable on YABE from the desktop machine. The command I used to set up the container is below, minus the host and accessToken\n \n `docker run -d -it --network=host --expose 8082 -e host= -e port=1883 -e accessToken= -p 60000-61000:60000-61000 -v \"C:\\Users\\Office Demos\\Documents\\tb-gateway\\config:/thingsboard_gateway/config\" -v \"C:\\Users\\Office Demos\\Documents\\tb-gateway\\extensions:/thingsboard_gateway/extensions\" -v \"C:\\Users\\Office Demos\\Documents\\tb-gateway\\logs:/thingsboard_gateway/logs\" --name tb-gateway --restart always thingsboard/tb-gateway`\n\nimage\n\n**Configuration** (Attach your configuration file)\n**Notate: Remove Access token from file if you want to attach a tb_gateway.yaml**\n\n{\n \"thingsboard\": {\n \"host\": \"thingsboard.cloud\",\n \"port\": 1883,\n \"remoteShell\": false,\n \"remoteConfiguration\": true,\n \"statistics\": {\n \"enable\": true,\n \"statsSendPeriodInSeconds\": 3600,\n \"configuration\": null,\n \"commands\": []\n },\n \"deviceFiltering\": {\n \"enable\": false,\n \"filterFile\": \"list.json\"\n },\n \"maxPayloadSizeBytes\": 1024,\n \"minPackSendDelayMS\": 200,\n \"minPackSizeToSend\": 500,\n \"checkConnectorsConfigurationInSeconds\": 60,\n \"handleDeviceRenaming\": true,\n \"security\": {\n \"accessToken\": \"\"\n },\n \"qos\": 1,\n \"checkingDeviceActivity\": {\n \"checkDeviceInactivity\": false,\n \"inactivityTimeoutSeconds\": 200,\n \"inactivityCheckPeriodSeconds\": 500\n }\n },\n \"storage\": {\n \"type\": \"memory\",\n \"read_records_count\": 100,\n \"max_records_count\": 100000,\n \"data_folder_path\": \"./data/\",\n \"max_file_count\": 10,\n \"max_read_records_count\": 10,\n \"max_records_per_file\": 10000,\n \"data_file_path\": \"./data/data.db\",\n \"messages_ttl_check_in_hours\": 1,\n \"messages_ttl_in_days\": 7\n },\n \"grpc\": {\n \"enabled\": false,\n \"serverPort\": 9595,\n \"keepaliveTimeMs\": 10000,\n \"keepaliveTimeoutMs\": 5000,\n \"keepalivePermitWithoutCalls\": true,\n \"maxPingsWithoutData\": 0,\n \"minTimeBetweenPingsMs\": 10000,\n \"minPingIntervalWithoutDataMs\": 5000,\n \"keepAliveTimeMs\": 10000,\n \"keepAliveTimeoutMs\": 5000\n },\n \"connectors\": [\n {\n \"type\": \"bacnet\",\n \"name\": \"BACnet\",\n \"configuration\": \"bacnet.json\"\n }\n ]\n}\n\n**Connector name (If you need help with some connector/converter):**\nBACnet Connector\n\n{\n \"name\": \"BACnet\",\n \"logLevel\": \"DEBUG\",\n \"general\": {\n \"objectName\": \"TB_gateway\",\n \"address\": \"0.0.0.0:47808\",\n \"objectIdentifier\": 599,\n \"maxApduLengthAccepted\": 1476,\n \"segmentationSupported\": \"segmentedBoth\",\n \"vendorIdentifier\": 15\n },\n \"devices\": [\n {\n \"deviceName\": \"S_1AC0_DemoPlug\",\n \"deviceType\": \"default\",\n \"address\": \"192.168.11.35:47808\",\n \"pollPeriod\": 10000,\n \"timeseries\": [\n {\n \"key\": \"InsRealPower1\",\n \"type\": \"int\",\n \"objectId\": \"analogInput:2\",\n \"propertyId\": \"InsRealPower1\"\n }\n ]\n },\n {\n \"deviceName\": \"HoneywellGateway_MainOffice\",\n \"deviceType\": \"default\",\n \"address\": \"192.168.11.35:47808\",\n \"pollPeriod\": 10000\n }\n ]\n}\n\n**Error traceback (If it was raised):**\n\n**Versions (please complete the following information):**\n - OS: Windows 10 - Docker Desktop v 24.0.7\n - Thingsboard IoT Gateway version 3.4.4\n - Python version - 3.11.7","author_login":"TomAllen95","author_association":"NONE","created_at":"2024-02-06T15:52:40+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2121119834,"issue_number":1294,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1294","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1983684618","fragment_type":"issue_comment","sequence":1,"text":"Hi @TomAllen95 @kamisettychandan,\n\nThank you for interest in ThingsBoard IoT gateway. At the moment we are investigating the connection ability to YABE simulator, unfortunately for now, with no luck, but we will write you after finding the reason why it cannot connect.","author_login":"imbeacon","author_association":"MEMBER","created_at":"2024-03-07T14:57:02+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2121119834,"issue_number":1294,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1984984114","fragment_type":"issue_comment","sequence":2,"text":"@imbeacon \n\nPlease find my docker logs, then you can understand the problem.\n\nDay.4.Docker_Logs.txt\n\nPlease find Config files,\nbacnet.json.txt\ntb-gateway.txt\n\nKindly check and update","author_login":"kamisettychandan","author_association":"NONE","created_at":"2024-03-08T03:35:14+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2121119834,"issue_number":1294,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2360803859","fragment_type":"issue_comment","sequence":3,"text":"Hello,\n\nany news on this topic?\nI have the same issue.\nTB-Gateway is sending \"Unconfirmed-REQ who-Is\"-Messages to 'Room Control Simulator'.\nBut nothing more happens.\ngrafik\nI opended another case a few weeks ago, because I can`t access data from other bacnet-devices as well.\n( URL \nI can access all the data witch Yabe (of room simulator and bacnet end-device).\n\nIs anyone here using bacnet-connector of tb-gateway successfully?\n\nKind regards.","author_login":"mgruenberger21","author_association":"NONE","created_at":"2024-09-19T12:03:25+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2121119834,"issue_number":1294,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1294","linked_issue_ids":[2505148864],"is_known_query_context":false},{"document_id":"gh_comment_2534344779","fragment_type":"issue_comment","sequence":4,"text":"Hi all,\n\nPlease try to use the latest version of the gateway( URL we have completely remastered BACnet connector, migrate to bacpypes3 as a base for it, instead of bacpypes. Also, we have tested the connector with YABE, it was able to read and write data. \nI close this issue, because it relates to previous implementation of the connector, but please feel free to open new issues in case of noticing some misbehaving.","author_login":"imbeacon","author_association":"MEMBER","created_at":"2024-12-11T07:50:12+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2121119834,"issue_number":1294,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1294","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_2505148864","fragment_type":"issue_description","sequence":0,"text":"[HELP] Can't access data with Bacnet\nHello, \n\nI cant`t access data of a heating system with bacnet using thingsboard-gateway.\nWhen I use Yabe, I can accesss all the things I want to know.\nBut when requesting data with thingsboard-gateway, I don`t get any answer of the heating system to my request.\ngrafik\n\ne.g. the request for this value shold look like this I think:\n{\n \"general\": {\n \"objectName\": \"tb-gateway\",\n \"address\": \"0.0.0.0:47808\",\n \"objectIdentifier\": 599,\n \"maxApduLengthAccepted\": 1476,\n \"segmentationSupported\": \"segmentedBoth\",\n \"vendorIdentifier\": 15\n },\n \"devices\": [\n {\n \"deviceName\": \"BACnet Device ${objectName}\",\n \"deviceType\": \"default\",\n \"address\": \"IPADDR:47808\",\n \"pollPeriod\": 10000,\n \"attributes\": [\n {\n \"key\": \"Außentemperatur Kessel 1\",\n \"type\": \"double\",\n \"objectId\": \"analogInput:239\",\n \"propertyId\": \"presentValue\"\n }\n ]\n }\n ],\n \"logLevel\": \"DEBUG\",\n \"name\": \"Bacnet\",\n \"enableRemoteLogging\": true,\n \"id\": \"ac5e542d-623b-432a-9a96-04fe82655e34\"\n}\n\nDebug-Logs of thingsboard-gateway:\n\nb-gateway | 2024-09-04 11:50:37 - |INFO| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _process_config_request - 204 - Configuration update request received.\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _process_config_request - 205 - Got config update request: {'active_connectors': ['Bacnet']}\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _handle_active_connectors_update - 404 - Processing active connectors configuration update...\ntb-gateway | 2024-09-04 11:50:37 - |INFO| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _process_config_request - 204 - Configuration update request received.\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _process_config_request - 205 - Got config update request: {'Bacnet': {'mode': 'basic', 'name': 'Bacnet', 'type': 'bacnet', 'enableRemoteLogging': True, 'logLevel': 'DEBUG', 'sendDataOnlyOnChange': False, 'configuration': 'bacnet.json', 'configurationJson': {'general': {'objectName': 'tb-gateway', 'address': '0.0.0.0:47808', 'objectIdentifier': 599, 'maxApduLengthAccepted': 1476, 'segmentationSupported': 'segmentedBoth', 'vendorIdentifier': 15}, 'devices': [{'deviceName': 'BACnet Device ${objectName}', 'deviceType': 'default', 'address': 'IP-ADDR:47808', 'pollPeriod': 10000, 'attributes': [{'key': 'Außentemperatur Kessel 1', 'type': 'double', 'objectId': 'analogInput:239', 'propertyId': 'presentValue'}]}], 'logLevel': 'DEBUG', 'name': 'Bacnet', 'enableRemoteLogging': True, 'id': 'ac5e542d-623b-432a-9a96-04fe82655e34'}, 'ts': 1725450637146, 'key': 'auto', 'basicConfig': {'general': {'objectName': 'tb-gateway', 'address': '0.0.0.0:47808', 'objectIdentifier': 599, 'maxApduLengthAccepted': 1476, 'segmentationSupported': 'segmentedBoth', 'vendorIdentifier': 15}, 'devices': [{'deviceName': 'BACnet Device ${objectName}', 'deviceType': 'default', 'address': 'IP-ADDR:47808', 'pollPeriod': 10000, 'attributes': [{'key': 'Außentemperatur Kessel 1', 'type': 'double', 'objectId': 'analogInput:239', 'propertyId': 'presentValue'}]}], 'logLevel': 'DEBUG', 'name': 'Bacnet', 'enableRemoteLogging': True, 'id': 'ac5e542d-623b-432a-9a96-04fe82655e34'}}}\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _handle_connector_configuration_update - 449 - Processing connectors configuration update...\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - create_configuration_file_backup - 757 - Backup file created for configuration file bacnet.json in /thingsboard_gateway/config/backup/bacnet.backup.1725450637.json\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [bacnet_connector.py] - bacnet_connector - scan_network - 226 - WhoIsRequest has been sent.\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [bacnet_connector.py] - bacnet_connector - run - 80 - WhoIsRequest has been sent.\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [bacnet_connector.py] - bacnet_connector - scan_network - 226 - WhoIsRequest has been sent.\ntb-gateway | 2024-09-04 11:50:37 - |INFO| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _process_config_request - 204 - Configuration update request received.\ntb-gateway | 2024-09-04 11:50:37 - |DEBUG| - [tb_gateway_remote_configurator.py] - tb_gateway_remote_configurator - _process_config_request - 205 - Got config update request: {'Bacnet': {'mode': 'basic', 'name': 'Bacnet', 'type': 'bacnet', 'enableRemoteLogging': True, 'logLevel': 'DEBUG', 'sendDataOnlyOnChange': False, 'configuration': 'bacnet.json', 'configurationJson': {'general': {'objectName': 'tb-gateway', 'address': '0.0.0.0:47808', 'objectIdentifier': 599, 'maxApduLengthAccepted': 1476, 'segmentationSupported': 'segmentedBoth', 'vendorIdentifier': 15}, 'devices': [{'deviceName': 'BACnet Device ${objectName}', 'deviceType': 'default', 'address': 'IP-ADDR:47808', 'pollPeriod': 10000, 'attributes': [{'key': 'Außentemperatur Kessel 1', 'type': 'double', 'objectId': 'analogInput:239', 'propertyId': 'presentValue'}]}], 'logLevel': 'DEBUG', 'name': 'Bacnet', 'enableRemoteLogging': True, 'id': 'ac5e542d-623b-432a-9a96-04fe82655e34'}, 'ts': 1725450637146, 'key': 'auto', 'basicConfig': {'general': {'objectName': 'tb-gateway', 'address': '0.0.0.0:47808', 'objectIdentifier': 599, 'maxApduLengthAccepted': 1476, 'segmentationSupported': 'segmentedBoth', 'vendorIdentifier': 15}, 'devices': [{'deviceName': 'BACnet Device ${objectName}', 'deviceType': 'default', 'address': 'IP-ADDR:47808', 'pollPeriod': 10000, 'attributes': [{'key': 'Außentemperatur Kessel 1', 'type': 'double', 'objectId': 'analogInput:239', 'propertyId': 'presentValue'}]}], 'logLevel': 'DEBUG', 'name': 'Bacnet', 'enableRemoteLogging': True, 'id': 'ac5e542d-623b-432a-9a96-04fe82655e34'}}}\n\ntcpdump:\n\n13:57:32.811805 IP iotgw.bacnet > IPADDR.bacnet: UDP, length 8\n13:57:32.814702 IP iotgw.bacnet > IPADDR.bacnet: UDP, length 8\n\nCan someone please help me to solve this problem.?\nSorry, I´m not really a bacnet-specialist.\n\n**Versions (please complete the following information):**\n - OS: Rocky Linux 9.4\n - Thingsboard IoT Gateway version 3.5.1 (Docker)\n - Python version 3.9","author_login":"mgruenberger21","author_association":"NONE","created_at":"2024-09-04T12:02:05+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2336788030","fragment_type":"issue_comment","sequence":1,"text":"Try changing this IP address \n\n{\n\"general\": {\n\"objectName\": \"tb-gateway\",\n\"address\": \"**0.0.0.0**:47808\",\n\nTo be the IP address of the network interface of your TBGW.\n\nHarv","author_login":"HarvUK","author_association":"NONE","created_at":"2024-09-08T18:55:08+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2337428250","fragment_type":"issue_comment","sequence":2,"text":"Hello,\n\nthank you for your message.\nStill there is no answer of the Bacnet-Device.\nLooks like something is wrong with the request itself. In Wireshark I can see the request sent to bacnet-device, but nothing is sent back:\ngrafik\nSome flags look differnet in yabe-request:\ngrafik","author_login":"mgruenberger21","author_association":"NONE","created_at":"2024-09-09T08:12:47+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2383222747","fragment_type":"issue_comment","sequence":3,"text":"You could try URL to find all the objects. If you don't get your device, your problem might be related to URL","author_login":"jurkov","author_association":"NONE","created_at":"2024-09-30T13:38:07+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2383333900","fragment_type":"issue_comment","sequence":4,"text":"Ok thank you. I just installed bacpypes on my machine and downloaded ReadObjectList.py.\nNow the following arguments are required: device_id, device_addr\nHow, or where can i set this arguments?\ndevice_addr should look like \"192.0.0.1:47808\" for example?\nand what's the device_id?","author_login":"mgruenberger21","author_association":"NONE","created_at":"2024-09-30T14:14:36+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2385116975","fragment_type":"issue_comment","sequence":5,"text":"Thank you jurkov.\nWith bacpypes I can access all the data. And sorry for my stupid questions, but I`m not a bacnet-specialist :)\nBut my Bacnet-Device is only responding to \"Confirmed-REQ\"-messages:\npython samples/ReadObjectList.py --ini BACpypes.ini 2XXXXX5 10.XXX.XXXX.1\ngrafik\n\nWhen I send \"Unconfirmed-REQ who-Is\" (as thingsboard-gateway does), I get no answer:\ngrafik\n\nSo I need to make thingsboard to send Confirmed-REQ-messages to the bacnet-device?\nHow can I do this?\nHow to specify the device-ID for bacnet-device in thingsboard?","author_login":"mgruenberger21","author_association":"NONE","created_at":"2024-10-01T08:25:38+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2393399147","fragment_type":"issue_comment","sequence":6,"text":"You may have to create a feature request or create the feature by yourself. It is possible to create a custom uplink and downlink converter. See URL \n\nI added my BacNET devices based on URL line 12 and line 14.","author_login":"jurkov","author_association":"NONE","created_at":"2024-10-04T10:39:08+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2514403602","fragment_type":"issue_comment","sequence":7,"text":"Hi @mgruenberger21 and everyone!\nWe are pleased to inform you that we added a new Async BACnet connector that used bacpypes3 (via PR #1607).\nThe old BACnet connector is now deprecated and can only be enabled manually.\nPlease, run the latest version of the gateway via the master branch and let us know about the results.","author_login":"samson0v","author_association":"CONTRIBUTOR","created_at":"2024-12-03T12:16:24+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2533684996","fragment_type":"issue_comment","sequence":8,"text":"Hi all,\n\nNew implementation of connector was tested with YABE, please try it, for now I close this issue, feel free to open a new one if you discover some misbehaviour with new connector implementation (In gateway 3.6.2+).","author_login":"imbeacon","author_association":"MEMBER","created_at":"2024-12-11T05:38:11+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_2896525104","fragment_type":"issue_comment","sequence":9,"text":"Hi @ttrading,\n\nThis issue was closed, if you discover some issue - please open the new one. Also, please provide your BACnet connector configuration. \n\nDue to typical issues with BACnet - please check that you set host for application - your IP in the same network, as device and port - 47808, mask usually - 24.\n\nFor device - please try to set * instead of host and * instead of port, this will enable global broadcast for device search. Aslo I should mention that you need to run the gateway and emulator on different devices, because emulator may reserver port 47808 and the gateway won't be able to use it for application.","author_login":"imbeacon","author_association":"MEMBER","created_at":"2025-05-21T04:27:18+08:00","repo_name":"thingsboard/thingsboard-gateway","issue_id":2505148864,"issue_number":1520,"issue_url":"https://github.com/thingsboard/thingsboard-gateway/issues/1520","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0494","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"Scheduler - Scheme Mode - Thermostat Auto?","query_context":"### Card Version\n\nLatest release\n\n### Bug description\n\nI just discovered the \"Make Scheme\" button, which is absolutely fantastic for thermostat scheduling.\n\nFirst of all, THANKS for making this feature. Its amazing. I sent you a \"few cups of coffee\"\n\nSecond of all-\n\nYou cannot set a temp when using auto mode. \n\nYou can only set temp when using heat or cool. However, many mini splits have auto mode. \n\nThis functionality does exist within home assistant (and works via the climate card), however, the make scheme card cannot seem to handle this.\n\nAlso, this may or may not be a duplicate of URL","known_context_document_ids":["gh_issue_1179956844"],"reference_answer":"When setting a climate entity to hvac mode auto, there shouldn't be a temperature applied.\nSee here for the definition in HA:\n \n\nIn contrast to:\n \n\nI follow the definitions from HA, so I'd say that your problem is caused by the homematic integration.\n\nIf you want to do so anyway, see here for instructions for a workaround.","answer_document_id":"gh_comment_1066100709","silver_evidence_path":["gh_comment_1078666415","gh_issue_1167554242","gh_comment_1066100709"],"evidence_issue_ids":[1179956844,1167554242],"source_repo_name":"nielsfaber/scheduler-card","source_issue_id":1179956844,"source_issue_number":544,"source_issue_url":"https://github.com/nielsfaber/scheduler-card/issues/544","target_repo_name":"nielsfaber/scheduler-card","target_issue_id":1167554242,"target_issue_number":541,"target_issue_url":"https://github.com/nielsfaber/scheduler-card/issues/541","reference_anchor_document_id":"gh_comment_1078666415","reference_answer_author":"nielsfaber","reference_answer_author_association":"OWNER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1333,"anchor_target_overlap":0.1333,"target_answer_overlap":0.2174},"issue_created_at":"2022-03-24T19:32:31+08:00","valid_comment_count":3,"fragments":[{"document_id":"gh_issue_1179956844","fragment_type":"issue_description","sequence":0,"text":"Scheduler - Scheme Mode - Thermostat Auto\n### Card Version\n\nLatest release\n\n### Bug description\n\nI just discovered the \"Make Scheme\" button, which is absolutely fantastic for thermostat scheduling.\n\nFirst of all, THANKS for making this feature. Its amazing. I sent you a \"few cups of coffee\"\n\nSecond of all-\n\nYou cannot set a temp when using auto mode. \n\nYou can only set temp when using heat or cool. However, many mini splits have auto mode. \n\nThis functionality does exist within home assistant (and works via the climate card), however, the make scheme card cannot seem to handle this.\n\nAlso, this may or may not be a duplicate of URL","author_login":"XtremeOwnageDotCom","author_association":"NONE","created_at":"2022-03-24T19:32:31+08:00","repo_name":"nielsfaber/scheduler-card","issue_id":1179956844,"issue_number":544,"issue_url":"https://github.com/nielsfaber/scheduler-card/issues/544","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1078666415","fragment_type":"issue_comment","sequence":1,"text":"Thanks a lot for the coffees! It's a good motivation to keep improving things 👍 \n\nAs for your issue, it has been addressed multiple times. See URL for my response.","author_login":"nielsfaber","author_association":"OWNER","created_at":"2022-03-25T05:22:14+08:00","repo_name":"nielsfaber/scheduler-card","issue_id":1179956844,"issue_number":544,"issue_url":"https://github.com/nielsfaber/scheduler-card/issues/544","linked_issue_ids":[1167554242],"is_known_query_context":false},{"document_id":"gh_comment_1078998692","fragment_type":"issue_comment","sequence":2,"text":"Hey, You deserve far more for the work you have done on home assistant.\n\nBetween this, and alarmo, those are two extremely solid integrations.\n\nThanks for a response/solution!","author_login":"XtremeOwnageDotCom","author_association":"NONE","created_at":"2022-03-25T12:51:23+08:00","repo_name":"nielsfaber/scheduler-card","issue_id":1179956844,"issue_number":544,"issue_url":"https://github.com/nielsfaber/scheduler-card/issues/544","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1167554242","fragment_type":"issue_description","sequence":0,"text":"Set temperature in \"Auto Mode\" not possible\n### Checklist\n\n- [X] I checked for similar existing requests (both open and closed) before posting.\n- [X] My request is generic, other users may benefit from it too.\n- [X] I will participate in further discussion about this feature and can test it (if requested) once it's done.\n\n### Proposal\n\nThe Homematic IP app allows to set temperature in Auto Mode to a desired level. In scheduler this option is not exposed (see screenshot).\nimage\n\nOne must use Heating Mode to set a desired temperature which results in constant heating even if environment temp is already high enough. I'm not sure if this option is exposed via API but it would make settings more easy for me.\n\n### Additional info\n\nMaybe it's possible to make that temp slider available in automatic mode like here in Heating Mode:\nimage\n\nI'm unsure if the Rest API docs on URL expose anything useful. At least I wasn't able to find anything suitable.","author_login":"MikeOfGit","author_association":"NONE","created_at":"2022-03-13T11:32:53+08:00","repo_name":"nielsfaber/scheduler-card","issue_id":1167554242,"issue_number":541,"issue_url":"https://github.com/nielsfaber/scheduler-card/issues/541","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1066100709","fragment_type":"issue_comment","sequence":1,"text":"When setting a climate entity to hvac mode auto, there shouldn't be a temperature applied.\nSee here for the definition in HA:\n \n\nIn contrast to:\n \n\nI follow the definitions from HA, so I'd say that your problem is caused by the homematic integration.\n\nIf you want to do so anyway, see here for instructions for a workaround.","author_login":"nielsfaber","author_association":"OWNER","created_at":"2022-03-13T13:25:18+08:00","repo_name":"nielsfaber/scheduler-card","issue_id":1167554242,"issue_number":541,"issue_url":"https://github.com/nielsfaber/scheduler-card/issues/541","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0495","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"` ` eagerly makes selections?","query_context":"I believe the selection should be made when the option is chosen, not while it's just being perused:\n1. would prevent the width jank as shown in the video\n2. would prevent the `oninput` event from firing for each keyboard navigation\n3. would align it's behavior to that of a mouse\n\n \n see video \n\nKapture 2023-05-02 at 12 21 28\n\n \n\ncodepen for the above video","known_context_document_ids":["gh_issue_1693067351"],"reference_answer":"URL says a few things about up and down:\n \n \n \n \n \n\nI don't understand what it means by \"if the popup is available\" though. Does that mean if the popup listbox is showing? Does it have something to do with the combobox being editable? Is it about the autocomplete suggestion rather than the actual listbox? I'm going to assume it means what the example does:\n\nThe example opens the listbox popup when pressing up or down, and it doesn't change the option at all. I'm a little hesitant to do this since it doesn't seem to be the same as what ` ` does on most platforms, but if that's whats best for users then I guess we ought to go for it. Based on the resolution here, it sounds like we already have consensus to just follow these aria authoring practices.\n\nI also just noticed that there is no recommendation for right or left arrow keys in the aria authoring practices... maybe those should cycle the selected option without opening the listbox like Scott mentioned in his last comment?","answer_document_id":"gh_comment_1439288259","silver_evidence_path":["gh_comment_1532192823","gh_issue_1080096677","gh_comment_1439288259"],"evidence_issue_ids":[1693067351,1080096677],"source_repo_name":"openui/open-ui","source_issue_id":1693067351,"source_issue_number":742,"source_issue_url":"https://github.com/openui/open-ui/issues/742","target_repo_name":"openui/open-ui","target_issue_id":1080096677,"target_issue_number":433,"target_issue_url":"https://github.com/openui/open-ui/issues/433","reference_anchor_document_id":"gh_comment_1532192823","reference_answer_author":"josepharhar","reference_answer_author_association":"COLLABORATOR","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1667,"anchor_target_overlap":0.5833,"target_answer_overlap":0.1702},"issue_created_at":"2023-05-02T20:36:08+08:00","valid_comment_count":10,"fragments":[{"document_id":"gh_issue_1693067351","fragment_type":"issue_description","sequence":0,"text":"` ` eagerly makes selections\nI believe the selection should be made when the option is chosen, not while it's just being perused:\n1. would prevent the width jank as shown in the video\n2. would prevent the `oninput` event from firing for each keyboard navigation\n3. would align it's behavior to that of a mouse\n\n \n see video \n\nKapture 2023-05-02 at 12 21 28\n\n \n\ncodepen for the above video","author_login":"argyleink","author_association":"NONE","created_at":"2023-05-02T20:36:08+08:00","repo_name":"openui/open-ui","issue_id":1693067351,"issue_number":742,"issue_url":"https://github.com/openui/open-ui/issues/742","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1532192823","fragment_type":"issue_comment","sequence":1,"text":"@scottaohara do you know what the arrow key behavior should be while the listbox is open? I think that we discussed arrow key behavior while the listbox is closed but not while its open here: URL","author_login":"josepharhar","author_association":"COLLABORATOR","created_at":"2023-05-02T21:42:29+08:00","repo_name":"openui/open-ui","issue_id":1693067351,"issue_number":742,"issue_url":"https://github.com/openui/open-ui/issues/742","linked_issue_ids":[1080096677],"is_known_query_context":false},{"document_id":"gh_comment_1532198768","fragment_type":"issue_comment","sequence":2,"text":"iirc, windows works as the prototype shows but no other OS does? I've written JS to disable it so all browsers work the same when perusing select menu options from keyboard. Like on this site, if `change` fired while just navigating the options, it'd change the url and the user would lose their place and be surprised about the change. a screenreader doesnt have the issue, they've got the virtual cursor iirc.","author_login":"argyleink","author_association":"NONE","created_at":"2023-05-02T21:49:03+08:00","repo_name":"openui/open-ui","issue_id":1693067351,"issue_number":742,"issue_url":"https://github.com/openui/open-ui/issues/742","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1536584356","fragment_type":"issue_comment","sequence":3,"text":"if someone invokes the combobox's listbox popup, then the change event should only fire when a purposeful selection/closure of the listbox has been made. Windows does change the current option shown in the combobox trigger when cycling through focused options, but the change doesn't occur until the user purposefully makes the change. On macOS, chosen option in the trigger doesn't change until the purposeful selectin has been made. IMO this is the better option.\n\nSome points of clarity though, regardless of what choice is made, some 'jankiness' would still occur if the triggering element adjusted in size based on the current value. IMO that looks broken and maybe selectmenu should behave more like the select element here, and have its min-width based on the length of its longest option - allowing people to overwrite this if they see fit, but avoiding some of this awkward resizing behavior by default.\n\nRe: the commentary of how a screen reader would not have the 'change' issue - that's not really true, as this component would generally pop someone into forms mode - which is the expected way to interact with such a control. using virtual pc cursor would not be how someone would normally interact with the contents of the listbox popup, and is actually not even possible to be interacted with in this way with the native select element.\n\nFinal FYI, the UX of the select element on this site's is rather broken on Windows, as I can hear this is an unnamed combobox, and i can use up/down arrow keys to change the selection without opening the popup - but because the activation behavior has been suppressed, while i can hear myself changing the selected option, nothing happens. i have to then hit enter to attempt to select, but this then opens the popup instead, and now i have to re-activate the item i was already attempting to activate. a popup of a list of links would have been more expected here is all.","author_login":"scottaohara","author_association":"CONTRIBUTOR","created_at":"2023-05-05T17:50:25+08:00","repo_name":"openui/open-ui","issue_id":1693067351,"issue_number":742,"issue_url":"https://github.com/openui/open-ui/issues/742","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1080096677","fragment_type":"issue_description","sequence":0,"text":"Arrow key up/down on closed\nAnother ` ` behavior to discuss: what should happen when the control's listbox is closed, and a user arrow keys up/down on the control's button?\n\nPer my testing of ` ` in Chromium and Gecko on Windows, up/down arrow keys advance backwards/forwards through the list of options without opening the listbox.\n\nHowever looking at the example at URL up/down arrow open the listbox in addition to moving to the next previous option.\n \n \n \n \n \n \n \n\nThe guidance in URL doesn't state that up/down arrow should open the listbox.\n \n \n\nSo I'm not clear on whether the best practice is to open the listbox or not when up/down arrow is pressed. Thoughts?\n\n(Thanks @mfreed7 for pointing this out).","author_login":"dandclark","author_association":"COLLABORATOR","created_at":"2021-12-14T18:44:57+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_994152263","fragment_type":"issue_comment","sequence":1,"text":"I'm glad you opened this @dandclark, as I was reading through #386 and noticed this hadn't been mentioned yet.\n\nThe APG isn't going to be what can be looked at here for the definitive behavior since the `select` behaves differently depending on the platform, and the APG pattern takes a bit of both, though leaning a bit more towards macOS behavior. On macOS, the listbox always popsup when using the up or down arrow keys. Firefox on macOS allows for left and right arrows to cycle through the select's options when in the collapsed state. Safari and Chromium don't seem to behave that way, though.\n\nOn Windows, the expectation is that up , down , left and right will cycle through the select element's options without opening the listbox (firefox, chrome, edge). To open the listbox with arrow keys, someone would also need to use the alt key, along with up or down to get the listbox to popup.\n\nPer the discussion the other day about #429, these differences in the listbox popping up or not matter a bit less since the `change` event will fire the same either way. \n\nI'd imagine that preference for behavior may be contingent on people's familiarity with their primary OS.","author_login":"scottaohara","author_association":"CONTRIBUTOR","created_at":"2021-12-15T00:01:57+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1439288259","fragment_type":"issue_comment","sequence":2,"text":"URL says a few things about up and down:\n \n \n \n \n \n\nI don't understand what it means by \"if the popup is available\" though. Does that mean if the popup listbox is showing? Does it have something to do with the combobox being editable? Is it about the autocomplete suggestion rather than the actual listbox? I'm going to assume it means what the example does:\n\nThe example opens the listbox popup when pressing up or down, and it doesn't change the option at all. I'm a little hesitant to do this since it doesn't seem to be the same as what ` ` does on most platforms, but if that's whats best for users then I guess we ought to go for it. Based on the resolution here, it sounds like we already have consensus to just follow these aria authoring practices.\n\nI also just noticed that there is no recommendation for right or left arrow keys in the aria authoring practices... maybe those should cycle the selected option without opening the listbox like Scott mentioned in his last comment?","author_login":"josepharhar","author_association":"COLLABORATOR","created_at":"2023-02-22T00:57:30+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1452333042","fragment_type":"issue_comment","sequence":3,"text":"I tested out the behavior on various platforms and browsers:\n\n- Up and Left choose the previous option, Down and Right choose the next option. The listbox is not opened.\n - Windows Chrome\n - Windows Firefox\n - Linux Chrome\n - Linux Firefox\n- The listbox is opened. The selected option is focused but not moved forwards/backwards. Left and Right do nothing.\n - MacOS Chrome\n - MacOS Safari\n - MacOS Firefox\n\nAs scott mentioned, the behavior is platform specific and not browser specific, and users may expect it to act the way the existing select element does on their OS.\n\nAs I mentioned in my last comment, the ARIA practices seem to suggest doing the MacOS behavior but with an added funny behavior where pressing down opens the listbox and selects the last option.\n\nMy proposed resolution is to do the same thing that the existing select element does and change the behavior based on the OS because that is most likely to be what the user expects, but I am open to suggestions.","author_login":"josepharhar","author_association":"COLLABORATOR","created_at":"2023-03-02T18:20:11+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1452876921","fragment_type":"issue_comment","sequence":4,"text":"We resolved to make up, down, left, and right open the listbox without changing the selected option.","author_login":"josepharhar","author_association":"COLLABORATOR","created_at":"2023-03-03T02:45:48+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1453729346","fragment_type":"issue_comment","sequence":5,"text":"This issue got mirrored to I18N's repo due to the `i18n-tracker` label and I dug around to find the reason for the tag in the IRC log above:\n \n \n \n \n \n \n \n \n \n \n \n \n \n\nJust to confirm, arrow keys can signal either logical or physical movement, depending on context. Physical movement means \"left is left and right is right (etc.)\" regardless of text directionality or writing mode. Logical movement means that \"left is towards the start (in an LTR context) vs. right is towards the start (in an RTL context)\". Physical vs. logical movement depends on the operation in question. \n\nList navigation should generally be logical rather than physical, with up being towards the start and down being towards the end. Left is \"towards start\" for LTR (`dir=ltr`) and `vertical-lr` modes and \"towards end\" for RTL (`dir=rtl`) and `vertical-rl` modes (with right mirroring the behavior).\n\nSince you resolved to open the select (and not navigate), is there an equivalent issue somewhere about navigation? I don't see a reason here to reopen this issue.","author_login":"aphillips","author_association":"NONE","created_at":"2023-03-03T15:48:05+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454030745","fragment_type":"issue_comment","sequence":6,"text":"since i could make the call, just commenting to clarify that while I had mentioned that people may have preferences, that for this topic that wasn't meant to indicate that I wouldn't also agree that cross-browser/platform consistency.\n\ni actually think this is a good change. \n\nhowever, because I\"m me, i also wanted to respond to:\n \n\nlooking to design systems to mimic how they've implemented custom components like this would often mean a bunch of behaviors from the native equivalent were dropped. e.g., was left/right selection not implemented because of a purposeful choice, or because it wasn't ever thought about since the requirements were written by someone unfamiliar with the variations. Or, was it deemed too complex to implement? That often happens with custom select-only comboboxes in regards to the type ahead functionality. Most instances i come across don't allow for the quick jump to an option by pressing the first few characters of that option's label. For instance, neither Fluent UI or Salesforce comboboxes allow for this if using the select-only combobox. They also don't allow someone to click on their custom labels to move focus to the associated combobox element. That's not a dig on these, or anyone who worked on them. it's not \"required\" that they do these things. But they are missing features from what the current select element provide (or from what other custom made components may or may not provide). \n\nSo, very long way of saying \"yes, let's look at what other design systems are doing. BUT ALSO, let's look at what they didn't do compared to what they were trying to recreate. What did they leave out, and if something hit the cutting room floor, why?\"","author_login":"scottaohara","author_association":"CONTRIBUTOR","created_at":"2023-03-03T19:33:03+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1454042694","fragment_type":"issue_comment","sequence":7,"text":"Totally agree! I just wanted to make sure we weren't limiting our research to native select menus. Really, I think everyone in this week's meeting seemed to agree that the right way to pick the \"right\" behavior was to consider what's best for users, and do that. As I said at the end of the meeting, I'm quite sure this issue isn't closed, it's just \"closed for now\". Please add your thoughts on what's best and we'll keep discussing.","author_login":"mfreed7","author_association":"COLLABORATOR","created_at":"2023-03-03T19:40:58+08:00","repo_name":"openui/open-ui","issue_id":1080096677,"issue_number":433,"issue_url":"https://github.com/openui/open-ui/issues/433","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0496","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"vL3 DNS doesn't work in an interdomain context?","query_context":"## Expected Behavior\n\nAfter deploying the interdomain vL3 example, the vL3 DNS feature should work as described in its associated example.\n\nSpecifically, after modifying the `NSM_DNS_TEMPLATES` to avoid using the `{{ .NetworkService }}` property (which contains the illegal character `@` in the case of an interdomain vL3 service), the vL3 NSE should respond to DNS queries with the vL3 IP of the pod about which the query is.\n\nFor instance, in the context of the interdomain vL3 example example and after modifying the `NSM_DNS_TEMPLATES` to `{{ index .Labels \\\"podName\\\" }}.my-interdomain-vl3-network` for both vL3 NSEs, the NSEs should respond to DNS queries about the `alpine.my-interdomain-vl3-network` with the IP address of the `alpine` pod connected to the `my-interdomain-vl3-network` vL3 network. Since two `alpine` pods are deployed in this example (one in each cluster), whether the NSE should return the vL3 IP of the local alpine pod, the remote one, or both, remains to be defined.\n\n## Current Behavior\n\nIn the context described above, neither the alpine pods nor NSE pods are able to resolve the `alpine.my-interdomain-vl3-network` domain name.\n\n## Failure Information (for bugs)\n\nRunning `nslookup alpine.my-interdomain-vl3-network.` in either one alpine pod or one vL3 NSE pod results in the `SERVFAIL` error.\n\n## Steps to Reproduce\n\n1. Deploy the interdomain vL3 example while modifying the NSE deployment to use the `{{ index .Labels \\\"podName\\\" }}.my-interdomain-vl3-network` value for the `NSM_DNS_TEMPLATES` environment variable\n2. Run `apt update && apt install dnsutils && nslookup alpine.my-interdomain-vl3-network. 127.0.0.1` in the NSE pod\n3. Observe that the DNS query is failing\n4. Check the pod's logs for errors\n\n## Context\n\nThe interdomain vL3 example example was deployed on 3 VMs, each running a local `kind` cluster. The nodes of each kind cluster have InternalIPs in different ranges, and multicluster communication between nodes is possible using their InternalIPs. The nodes however do not have ExternalIPs.\n\nMetalLB is also deployed in each cluster to provide ExternalIPs to k8s services. These IPs are routable between the three VMs.\n\nI used Kind 0.17.0.\n\n## Failure Logs\n\nWhen a DNS query about the `alpine` pod is sent to the vL3 NSE, the following error appears in the pod's logs:\n\nJan 26 12:10:22.802 [TRAC] [id:55094] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/norecursion/norecursionDNSHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/memory/memoryHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/fanout/fanoutHandler.ServeDNS()\nJan 26 12:10:22.859 [TRAC] [id:55094] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nJan 26 12:10:22.859 [TRAC] [id:55094] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nJan 26 12:10:22.859 [ERRO] [id:55094] [noloopDNSHandler:ServeDNS] [type:dnsServer] (2.1) loop is not allowed: query: ;; opcode: QUERY, status: NOERROR, id: 55094; ;; flags:; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0; ; ;; QUESTION SECTION:; ;alpine.my-interdomain-vl3-network. IN A; ;\n\nThe complete logs of the vL3 NSE pod are available here.","known_context_document_ids":["gh_issue_1558180790"],"reference_answer":"@glazychev-art I feel we might need to verify it.\n\n@NikitaSkrynnik Could you please compare behaviour with NSM v1.5.0 (with coredns) and current main version?","answer_document_id":"gh_comment_1485044793","silver_evidence_path":["gh_comment_1446018492","gh_issue_1593247208","gh_comment_1485044793"],"evidence_issue_ids":[1558180790,1593247208],"source_repo_name":"networkservicemesh/sdk","source_issue_id":1558180790,"source_issue_number":1414,"source_issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","target_repo_name":"networkservicemesh/sdk","target_issue_id":1593247208,"target_issue_number":1425,"target_issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","reference_anchor_document_id":"gh_comment_1446018492","reference_answer_author":"denis-tingaikin","reference_answer_author_association":"MEMBER","quality_score":78.33,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.0,"anchor_target_overlap":0.2,"target_answer_overlap":0.0667},"issue_created_at":"2023-01-26T13:57:45+08:00","valid_comment_count":23,"fragments":[{"document_id":"gh_issue_1558180790","fragment_type":"issue_description","sequence":0,"text":"vL3 DNS doesn't work in an interdomain context\n## Expected Behavior\n\nAfter deploying the interdomain vL3 example, the vL3 DNS feature should work as described in its associated example.\n\nSpecifically, after modifying the `NSM_DNS_TEMPLATES` to avoid using the `{{ .NetworkService }}` property (which contains the illegal character `@` in the case of an interdomain vL3 service), the vL3 NSE should respond to DNS queries with the vL3 IP of the pod about which the query is.\n\nFor instance, in the context of the interdomain vL3 example example and after modifying the `NSM_DNS_TEMPLATES` to `{{ index .Labels \\\"podName\\\" }}.my-interdomain-vl3-network` for both vL3 NSEs, the NSEs should respond to DNS queries about the `alpine.my-interdomain-vl3-network` with the IP address of the `alpine` pod connected to the `my-interdomain-vl3-network` vL3 network. Since two `alpine` pods are deployed in this example (one in each cluster), whether the NSE should return the vL3 IP of the local alpine pod, the remote one, or both, remains to be defined.\n\n## Current Behavior\n\nIn the context described above, neither the alpine pods nor NSE pods are able to resolve the `alpine.my-interdomain-vl3-network` domain name.\n\n## Failure Information (for bugs)\n\nRunning `nslookup alpine.my-interdomain-vl3-network.` in either one alpine pod or one vL3 NSE pod results in the `SERVFAIL` error.\n\n## Steps to Reproduce\n\n1. Deploy the interdomain vL3 example while modifying the NSE deployment to use the `{{ index .Labels \\\"podName\\\" }}.my-interdomain-vl3-network` value for the `NSM_DNS_TEMPLATES` environment variable\n2. Run `apt update && apt install dnsutils && nslookup alpine.my-interdomain-vl3-network. 127.0.0.1` in the NSE pod\n3. Observe that the DNS query is failing\n4. Check the pod's logs for errors\n\n## Context\n\nThe interdomain vL3 example example was deployed on 3 VMs, each running a local `kind` cluster. The nodes of each kind cluster have InternalIPs in different ranges, and multicluster communication between nodes is possible using their InternalIPs. The nodes however do not have ExternalIPs.\n\nMetalLB is also deployed in each cluster to provide ExternalIPs to k8s services. These IPs are routable between the three VMs.\n\nI used Kind 0.17.0.\n\n## Failure Logs\n\nWhen a DNS query about the `alpine` pod is sent to the vL3 NSE, the following error appears in the pod's logs:\n\nJan 26 12:10:22.802 [TRAC] [id:55094] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/norecursion/norecursionDNSHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/memory/memoryHandler.ServeDNS()\nJan 26 12:10:22.803 [TRAC] [id:55094] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/fanout/fanoutHandler.ServeDNS()\nJan 26 12:10:22.859 [TRAC] [id:55094] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nJan 26 12:10:22.859 [TRAC] [id:55094] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nJan 26 12:10:22.859 [ERRO] [id:55094] [noloopDNSHandler:ServeDNS] [type:dnsServer] (2.1) loop is not allowed: query: ;; opcode: QUERY, status: NOERROR, id: 55094; ;; flags:; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0; ; ;; QUESTION SECTION:; ;alpine.my-interdomain-vl3-network. IN A; ;\n\nThe complete logs of the vL3 NSE pod are available here.","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-01-26T13:57:45+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1415766472","fragment_type":"issue_comment","sequence":1,"text":"Hi @fr-Pursuit ,\n\nCould you please recheck your problem with `{{ index .Labels \\\"podName\\\" }}.my-interdomain-vl3-network.`(added dot at the end)?","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-02-03T11:55:28+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1419936624","fragment_type":"issue_comment","sequence":2,"text":"Hi,\n\nWith the added dot at the end of the template, the DNS resolution partially works.\nif I have a pod named `yelb-ui` connected to the vL3 network `nslookup yelb-ui.my-interdomain-vl3-network` fails after initially returning the expected IP:\n\n# nslookup yelb-ui.my-interdomain-vl3-network. && echo success\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\nName: yelb-ui.my-interdomain-vl3-network\nAddress: 172.16.0.3\n** server can't find yelb-ui.my-interdomain-vl3-network: SERVFAIL\n\nThe same error also appears in the logs of the vL3 NSE that is in the same cluster as the `yelb-ui` pod:\n\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (1.1) message-request={\"Id\":29292,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":true,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"yelb-ui.my-interdomain-vl3-network.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 6 23:18:25.908 [DEBU] [id:29292] [type:dnsServer] (1.2) passed clientURLs: [{udp 172.16.1.1 false }]\nFeb 6 23:18:25.908 [DEBU] [id:29292] [type:dnsServer] (1.3) passed SearchDomains: []\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/norecursion/norecursionDNSHandler.ServeDNS()\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (3.1) message-request-diff=[{\"type\":\"update\",\"path\":[\"MsgHdr\",\"RecursionDesired\"],\"from\":true,\"to\":false}]\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/memory/memoryHandler.ServeDNS()\nFeb 6 23:18:25.908 [TRAC] [id:29292] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/fanout/fanoutHandler.ServeDNS()\nFeb 6 23:18:25.911 [TRAC] [id:29292] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 6 23:18:25.911 [TRAC] [id:29292] [type:dnsServer] (1.1) message-request={\"Id\":29292,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"yelb-ui.my-interdomain-vl3-network.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 6 23:18:25.911 [DEBU] [id:29292] [type:dnsServer] (1.2) passed clientURLs: [{udp 172.16.1.1 false }]\nFeb 6 23:18:25.911 [DEBU] [id:29292] [type:dnsServer] (1.3) passed SearchDomains: []\nFeb 6 23:18:25.911 [TRAC] [id:29292] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 6 23:18:25.911 [ERRO] [id:29292] [noloopDNSHandler:ServeDNS] [type:dnsServer] (2.1) loop is not allowed: query: ;; opcode: QUERY, status: NOERROR, id: 29292; ;; flags:; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0; ; ;; QUESTION SECTION:; ;yelb-ui.my-interdomain-vl3-network.my-interdomain-vl3-network. IN AAAA; ;\nFeb 6 23:18:25.911 [TRAC] [id:29292] [type:dnsServer] (2.2) message-response={\"Id\":29292,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"yelb-ui.my-interdomain-vl3-network.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\nFeb 6 23:18:25.913 [TRAC] [id:29292] [type:dnsServer] (5.1) message-response={\"Id\":29292,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"yelb-ui.my-interdomain-vl3-network.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\n\nIn practice, this error seems to considerably increase the time it takes for a program to perform a DNS resolution in the `my-interdomain-vl3-network` zone. For example, every time I use the `ping yelb-ui.my-interdomain-vl3-network` command, I have to wait a significant while before the actual pings get exchanged (whereas if I use the IP, the pings are exchanged almost immediately).\n\nPS: I changed the template to use a custom `domain` label instead of the default `podName` label to generate the domain name","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-06T23:32:00+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420679574","fragment_type":"issue_comment","sequence":3,"text":"Actually, the slow `ping` initialization seems to be caused by slow, failing reverse DNS queries: the command temporarily freezes _after_ the IP associated with the domain is shown, but _before_ the first response appears.\n\nIn the meantime, the following appears in the remote NSE's logs:\n\nFeb 7 12:06:14.957 [TRAC] [id:26676] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 7 12:06:14.957 [TRAC] [id:26676] [type:dnsServer] (1.1) message-request={\"Id\":26676,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"3.0.16.172.in-addr.arpa.\",\"Qtype\":12,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 7 12:06:14.958 [DEBU] [id:26676] [type:dnsServer] (1.2) passed clientURLs: [{udp 172.16.0.1 false }]\nFeb 7 12:06:14.958 [DEBU] [id:26676] [type:dnsServer] (1.3) passed SearchDomains: []\nFeb 7 12:06:14.958 [TRAC] [id:26676] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 7 12:06:14.958 [ERRO] [id:26676] [noloopDNSHandler:ServeDNS] [type:dnsServer] (2.1) loop is not allowed: query: ;; opcode: QUERY, status: NOERROR, id: 26676; ;; flags:; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0; ; ;; QUESTION SECTION:; ;3.0.16.172.in-addr.arpa. IN PTR; ;\nFeb 7 12:06:14.958 [TRAC] [id:26676] [type:dnsServer] (2.2) message-response={\"Id\":26676,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"3.0.16.172.in-addr.arpa.\",\"Qtype\":12,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\nFeb 7 12:06:15.011 [TRAC] [id:26676] [type:dnsServer] (5.1) message-response={\"Id\":26676,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"3.0.16.172.in-addr.arpa.\",\"Qtype\":12,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\n\nThe same error appears several times in the logs, as the server seems to handle one PTR request per entry in the pod's DNS search path.\n\nI've also noticed major slowdowns in the yelb app, but these don't seem to be caused by NSM: in order for the app to work regardless of how it is deployed, I added the `my-interdomain-vl3-network` domain in the pod's DNS search path. But since it was added at the end of the search path, the pod has to wait for several failing DNS queries to finish before sending the right query.","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-07T12:16:18+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420698448","fragment_type":"issue_comment","sequence":4,"text":"@fr-Pursuit \n`nslookup` makes both ipv4 and ipv6 requests by default. \n\nSo, we can check:\n`nslookup -debug yelb-ui.my-interdomain-vl3-network.`\nor \n`nslookup -type=a -debug yelb-ui.my-interdomain-vl3-network.`\n\nFor ping, force ipv4:\n`ping yelb-ui.my-interdomain-vl3-network. -4`","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-02-07T12:32:06+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420702990","fragment_type":"issue_comment","sequence":5,"text":"@glazychev-art Indeed! The `nslookup` failure came from an AAAA request. Here's the output of the command you sent:\n\n# nslookup -debug yelb-ui.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n -> yelb-ui.my-interdomain-vl3-network\n internet address = 172.16.0.3\n ttl = 283\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-ui.my-interdomain-vl3-network\nAddress: 172.16.0.3\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = AAAA, class = IN\n ANSWERS:\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\n** server can't find yelb-ui.my-interdomain-vl3-network: SERVFAIL\n\nI already tried to force IPv4 on ping though, which didn't change anything. I don't find this surprising though, since from what I saw the freeze came from reverse DNS queries.","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-07T12:35:52+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420733914","fragment_type":"issue_comment","sequence":6,"text":"I didn't see how `nslookup` could directly tell how long each request took, but using the `time` command, I got this:\n\nroot@yelb-appserver-55688766-pm8rf:/# time nslookup -debug yelb-ui.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n -> yelb-ui.my-interdomain-vl3-network\n internet address = 172.16.0.3\n ttl = 3511\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-ui.my-interdomain-vl3-network\nAddress: 172.16.0.3\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = AAAA, class = IN\n ANSWERS:\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\n** server can't find yelb-ui.my-interdomain-vl3-network: SERVFAIL\n\nreal 0m0.905s\nuser 0m0.014s\nsys 0m0.000s\n\nEach request took more or less the same time, so I'd say around 400/500ms per request.\n\nAs for the `PTR` requests, they come from the `ping` problem itself. From what I can see, `ping` performs a reverse DNS query when you use it with a domain name instead of an IP:\n\n% ping -4 google.com -c 4\nPING (216.58.213.78) 56(84) bytes of data.\n64 bytes from lhr25s01-in-f14.1e100.net (216.58.213.78): icmp_seq=1 ttl=110 time=4.92 ms\n64 bytes from lhr25s01-in-f14.1e100.net (216.58.213.78): icmp_seq=2 ttl=110 time=4.91 ms\n64 bytes from par21s18-in-f14.1e100.net (216.58.213.78): icmp_seq=3 ttl=110 time=4.98 ms\n64 bytes from lhr25s01-in-f78.1e100.net (216.58.213.78): icmp_seq=4 ttl=110 time=5.00 ms\n\n--- ping statistics ---\n4 packets transmitted, 4 received, 0% packet loss, time 3004ms\nrtt min/avg/max/mdev = 4.909/4.950/5.000/0.038 ms\n\n% ping -4 216.58.213.78 -c 4\nPING 216.58.213.78 (216.58.213.78) 56(84) bytes of data.\n64 bytes from 216.58.213.78: icmp_seq=1 ttl=110 time=4.86 ms\n64 bytes from 216.58.213.78: icmp_seq=2 ttl=110 time=4.87 ms\n64 bytes from 216.58.213.78: icmp_seq=3 ttl=110 time=4.96 ms\n64 bytes from 216.58.213.78: icmp_seq=4 ttl=110 time=4.92 ms\n\n--- 216.58.213.78 ping statistics ---\n4 packets transmitted, 4 received, 0% packet loss, time 3004ms\nrtt min/avg/max/mdev = 4.857/4.902/4.963/0.041 ms","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-07T13:00:51+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420754968","fragment_type":"issue_comment","sequence":7,"text":"Could you check please `time nslookup -debug -type=a yelb-ui.my-interdomain-vl3-network.` ?\n\nGot it, thanks. Apparently we also need to process PTR requests.","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-02-07T13:13:25+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1420758936","fragment_type":"issue_comment","sequence":8,"text":"Here's what I get when I only query `A` records:\n\n# time nslookup -debug -type=a yelb-ui.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n -> yelb-ui.my-interdomain-vl3-network\n internet address = 172.16.0.3\n ttl = 2402\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-ui.my-interdomain-vl3-network\nAddress: 172.16.0.3\n\nreal 0m0.380s\nuser 0m0.008s\nsys 0m0.008s","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-07T13:15:56+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422059586","fragment_type":"issue_comment","sequence":9,"text":"@fr-Pursuit \nIn fact, the cache should work. Here are the logs, where we see that the response from the first request was cached, and the second one simply takes the result from this cache (dnsCacheHandler):\n\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/checkmsg/checkMsgHandler.ServeDNS()\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (1.1) message-request={\"Id\":40104,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":true,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":true,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"alpine.my-interdomain-vl3-network.my.cluster3.\",\"Qtype\":1,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 8 05:54:55.385 [DEBU] [id:40104] [type:dnsServer] (2.1) passed clientURLs: [{udp 172.16.1.1 false } {udp 10.96.0.10 false }]\nFeb 8 05:54:55.385 [DEBU] [id:40104] [type:dnsServer] (2.2) passed SearchDomains: [ns-floating-vl3-basic.svc.cluster.local svc.cluster.local cluster.local]\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/searches/searchDomainsHandler.ServeDNS()\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/cache/dnsCacheHandler.ServeDNS()\nFeb 8 05:54:55.385 [TRAC] [id:40104] [type:dnsServer] (6) ⎆ sdk/pkg/tools/dnsutils/fanout/fanoutHandler.ServeDNS()\nFeb 8 05:54:55.386 [TRAC] [id:40104] [type:dnsServer] (6.1) message-response={\"Id\":40104,\"Response\":true,\"Opcode\":0,\"Authoritative\":true,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"alpine.my-interdomain-vl3-network.my.cluster3.\",\"Qtype\":1,\"Qclass\":1}],\"Answer\":[{\"Hdr\":{\"Name\":\"alpine.my-interdomain-vl3-network.my.cluster3.\",\"Rrtype\":1,\"Class\":1,\"Ttl\":3600,\"Rdlength\":4},\"A\":\"172.16.1.2\"}],\"Ns\":[],\"Extra\":[]}\n\nFeb 8 05:54:59.368 [TRAC] [id:23717] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/checkmsg/checkMsgHandler.ServeDNS()\nFeb 8 05:54:59.368 [TRAC] [id:23717] [type:dnsServer] (1.1) message-request={\"Id\":23717,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":true,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":true,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"alpine.my-interdomain-vl3-network.my.cluster3.\",\"Qtype\":1,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 8 05:54:59.368 [TRAC] [id:23717] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 8 05:54:59.368 [DEBU] [id:23717] [type:dnsServer] (2.1) passed clientURLs: [{udp 172.16.1.1 false } {udp 10.96.0.10 false }]\nFeb 8 05:54:59.368 [DEBU] [id:23717] [type:dnsServer] (2.2) passed SearchDomains: [ns-floating-vl3-basic.svc.cluster.local svc.cluster.local cluster.local]\nFeb 8 05:54:59.369 [TRAC] [id:23717] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/searches/searchDomainsHandler.ServeDNS()\nFeb 8 05:54:59.369 [TRAC] [id:23717] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 8 05:54:59.369 [TRAC] [id:23717] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/cache/dnsCacheHandler.ServeDNS()\nFeb 8 05:54:59.369 [TRAC] [id:23717] [type:dnsServer] (5.1) message-response={\"Id\":23717,\"Response\":true,\"Opcode\":0,\"Authoritative\":true,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"alpine.my-interdomain-vl3-network.my.cluster3.\",\"Qtype\":1,\"Qclass\":1}],\"Answer\":[{\"Hdr\":{\"Name\":\"alpine.my-interdomain-vl3-network.my.cluster3.\",\"Rrtype\":1,\"Class\":1,\"Ttl\":3597,\"Rdlength\":4},\"A\":\"172.16.1.2\"}],\"Ns\":[],\"Extra\":[]}\n\nCould you also check the latest main branch of deployments-k8s? We slightly increased the query speed, at least `nslookup type=a` should work faster.","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-02-08T06:02:48+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422379703","fragment_type":"issue_comment","sequence":10,"text":"Weirdly, I get similar logs in the `cmd-nsc` container, but logs from the NSE indicate it stills handles the requests, even though they should be cache in the local `cmd-nsc` container.\n\nI ran `dig yelb-appserver.my-interdomain-vl3-network` on the `yelb-appserver` container (so only the local NSE should get involved).\n\nI'll retry with the latest main branch (I'm currently using v1.7.0), and I'll get back to you.","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-08T10:34:04+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422490135","fragment_type":"issue_comment","sequence":11,"text":"Great! With the latest branch, the DNS resolutions are quite faster:\n\n# time nslookup -debug -type=a yelb-ui.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n -> yelb-ui.my-interdomain-vl3-network\n internet address = 172.16.1.4\n ttl = 3408\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-ui.my-interdomain-vl3-network\nAddress: 172.16.1.4\n\nreal 0m0.021s\nuser 0m0.009s\nsys 0m0.009s\n\nHowever, I have another issue... I deployed `yelb` using the same manifest as before, and for some reason `yelb-db.my-interdomain-vl3-network` cannot be resolved. The `yelb-db` pod was successfully connected to the vL3 network (with the address `172.16.0.2`), but the NSE fails when I try to resolve its associated name:\n\n# nslookup -debug -type=a yelb-db.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-db.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\n** server can't find yelb-db.my-interdomain-vl3-network: SERVFAIL\n\nThe following error appears in the NSE's logs:\n\nFeb 8 12:03:31.680 [TRAC] [id:40970] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 8 12:03:31.681 [TRAC] [id:40970] [type:dnsServer] (1.1) message-request={\"Id\":40970,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":true,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"yelb-db.my-interdomain-vl3-network.\",\"Qtype\":1,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 8 12:03:31.681 [DEBU] [id:40970] [type:dnsServer] (1.2) passed clientURLs: []\nFeb 8 12:03:31.681 [DEBU] [id:40970] [type:dnsServer] (1.3) passed SearchDomains: []\nFeb 8 12:03:31.681 [TRAC] [id:40970] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 8 12:03:31.681 [TRAC] [id:40970] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/norecursion/norecursionDNSHandler.ServeDNS()\nFeb 8 12:03:31.682 [TRAC] [id:40970] [type:dnsServer] (3.1) message-request-diff=[{\"type\":\"update\",\"path\":[\"MsgHdr\",\"RecursionDesired\"],\"from\":true,\"to\":false}]\nFeb 8 12:03:31.682 [TRAC] [id:40970] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/memory/memoryHandler.ServeDNS()\nFeb 8 12:03:31.682 [TRAC] [id:40970] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/fanout/fanoutHandler.ServeDNS()\nFeb 8 12:03:31.682 [ERRO] [id:40970] [fanoutHandler:ServeDNS] [type:dnsServer] (5.1) no urls to fanout\nFeb 8 12:03:31.682 [TRAC] [id:40970] [type:dnsServer] (5.2) message-response={\"Id\":40970,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"yelb-db.my-interdomain-vl3-network.\",\"Qtype\":1,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\n\nAll the other names can be resolved fine: only `yelb-db` has a problem.\n\nAny idea would could have gone wrong?","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-08T12:06:15+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422518737","fragment_type":"issue_comment","sequence":12,"text":"Is `yelb-db` another client as `yelb-ui` ?\n\nCould you upload the full NSE log to which it is connected?","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-02-08T12:29:26+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422524042","fragment_type":"issue_comment","sequence":13,"text":"`yelb-db` is indeed another client. The logs of the `nsc-cmd-init` container contained errors about a timeout being exceeded.\n\nI'm currently redeploying my clusters. It's probably better to restart with a clean setup, just to be sure my previous tinkering didn't affect anything.","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-08T12:34:17+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1422577140","fragment_type":"issue_comment","sequence":14,"text":"It appears something was wrong with my setup. After a clean reinstall, everything works fine.\n\nHowever, the resolution speedup only applies when I used the absolute DNS name:\n\n#time nslookup -debug -type=a yelb-db.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-db.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n -> yelb-db.my-interdomain-vl3-network\n internet address = 172.16.1.3\n ttl = 3406\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-db.my-interdomain-vl3-network\nAddress: 172.16.1.3\n\nreal 0m0.017s\nuser 0m0.005s\nsys 0m0.009s\n\nIf I use the relative name (`my-interdomain-vl3-network` being in the DNS search path), it still takes around 400ms:\n\n# time nslookup -debug -type=a yelb-db\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-db, type = A, class = IN\n ANSWERS:\n -> yelb-db.my-interdomain-vl3-network\n internet address = 172.16.1.3\n ttl = 3311\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-db.my-interdomain-vl3-network\nAddress: 172.16.1.3\n\nreal 0m0.305s\nuser 0m0.006s\nsys 0m0.012s","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-08T13:10:32+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1434573131","fragment_type":"issue_comment","sequence":15,"text":"@fr-Pursuit \nThank you for your results and comments! We really appreciate it.\n\nI think it's not quite right to solve all dns problems in one issue. Could you create a separate ones for other problems? For example, about PTR requests.","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-02-17T12:27:59+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1446018492","fragment_type":"issue_comment","sequence":16,"text":"Seems like root cause of the problem is fixed. \n\nNext problem will be considered separatly URL","author_login":"denis-tingaikin","author_association":"MEMBER","created_at":"2023-02-27T09:47:53+08:00","repo_name":"networkservicemesh/sdk","issue_id":1558180790,"issue_number":1414,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1414","linked_issue_ids":[1593247208],"is_known_query_context":false},{"document_id":"gh_issue_1593247208","fragment_type":"issue_description","sequence":0,"text":"The vL3 DNS doesn't support PTR requests\n## Expected Behavior\n\nThe vL3 DNS service should support PTR (ie: reverse DNS) requests, potentially by returning an empty response.\n\n## Current Behavior\n\nAn error occurs when the vL3 NSE receives PTR requests. When using the `ping` command with a vL3 domain name, this translates in a small freeze just before the first ping is sent (while the program waits for the timeout associated with the reverse DNS request).\n\n## Failure Information (for bugs)\n\nWhen the NSE receives a PTR request, this error appears in the logs:\n\nFeb 7 12:06:14.957 [TRAC] [id:26676] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nFeb 7 12:06:14.957 [TRAC] [id:26676] [type:dnsServer] (1.1) message-request={\"Id\":26676,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"3.0.16.172.in-addr.arpa.\",\"Qtype\":12,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nFeb 7 12:06:14.958 [DEBU] [id:26676] [type:dnsServer] (1.2) passed clientURLs: [{udp 172.16.0.1 false }]\nFeb 7 12:06:14.958 [DEBU] [id:26676] [type:dnsServer] (1.3) passed SearchDomains: []\nFeb 7 12:06:14.958 [TRAC] [id:26676] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nFeb 7 12:06:14.958 [ERRO] [id:26676] [noloopDNSHandler:ServeDNS] [type:dnsServer] (2.1) loop is not allowed: query: ;; opcode: QUERY, status: NOERROR, id: 26676; ;; flags:; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0; ; ;; QUESTION SECTION:; ;3.0.16.172.in-addr.arpa. IN PTR; ;\nFeb 7 12:06:14.958 [TRAC] [id:26676] [type:dnsServer] (2.2) message-response={\"Id\":26676,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"3.0.16.172.in-addr.arpa.\",\"Qtype\":12,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\nFeb 7 12:06:15.011 [TRAC] [id:26676] [type:dnsServer] (5.1) message-response={\"Id\":26676,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"3.0.16.172.in-addr.arpa.\",\"Qtype\":12,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\n\n## Steps to Reproduce\n\n1. Deploy the interdomain vL3 example (while renaming one alpine pod to `alpine2` to avoid confusion and setting the `NSM_DNS_TEMPLATES` environment variable to `{{ index .Labels \\\"podName\\\" }}.my-interdomain-vl3-network.` for the DNS service to work)\n2. Open a shell in the `alpine` pod\n3. Run `ping alpine2.my-interdomain-vl3-network`\n\n## Context\n\n`ping` is a great way to see how PTR requests are handled since when using ping with a domain name, the program performs a reverse DNS query on the source address of the response:\n\nI didn't see how nslookup could directly tell how long each request took, but using the time command, I got this:\n\nroot@yelb-appserver-55688766-pm8rf:/# time nslookup -debug yelb-ui.my-interdomain-vl3-network.\nServer: 127.0.0.1\nAddress: 127.0.0.1#53\n\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = A, class = IN\n ANSWERS:\n -> yelb-ui.my-interdomain-vl3-network\n internet address = 172.16.0.3\n ttl = 3511\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\nName: yelb-ui.my-interdomain-vl3-network\nAddress: 172.16.0.3\n------------\n QUESTIONS:\n yelb-ui.my-interdomain-vl3-network, type = AAAA, class = IN\n ANSWERS:\n AUTHORITY RECORDS:\n ADDITIONAL RECORDS:\n------------\n** server can't find yelb-ui.my-interdomain-vl3-network: SERVFAIL\n\nreal 0m0.905s\nuser 0m0.014s\nsys 0m0.000s\nEach request took more or less the same time, so I'd say around 400/500ms per request.\n\nAs for the PTR requests, they come from the ping problem itself. From what I can see, ping performs a reverse DNS query when you use it with a domain name instead of an IP:\n\n% ping -4 google.com -c 4\nPING (216.58.213.78) 56(84) bytes of data.\n64 bytes from lhr25s01-in-f14.1e100.net (216.58.213.78): icmp_seq=1 ttl=110 time=4.92 ms\n64 bytes from lhr25s01-in-f14.1e100.net (216.58.213.78): icmp_seq=2 ttl=110 time=4.91 ms\n64 bytes from par21s18-in-f14.1e100.net (216.58.213.78): icmp_seq=3 ttl=110 time=4.98 ms\n64 bytes from lhr25s01-in-f78.1e100.net (216.58.213.78): icmp_seq=4 ttl=110 time=5.00 ms\n\n--- ping statistics ---\n4 packets transmitted, 4 received, 0% packet loss, time 3004ms\nrtt min/avg/max/mdev = 4.909/4.950/5.000/0.038 ms\n\n% ping -4 216.58.213.78 -c 4\nPING 216.58.213.78 (216.58.213.78) 56(84) bytes of data.\n64 bytes from 216.58.213.78: icmp_seq=1 ttl=110 time=4.86 ms\n64 bytes from 216.58.213.78: icmp_seq=2 ttl=110 time=4.87 ms\n64 bytes from 216.58.213.78: icmp_seq=3 ttl=110 time=4.96 ms\n64 bytes from 216.58.213.78: icmp_seq=4 ttl=110 time=4.92 ms\n\n--- 216.58.213.78 ping statistics ---\n4 packets transmitted, 4 received, 0% packet loss, time 3004ms\nrtt min/avg/max/mdev = 4.857/4.902/4.963/0.041 ms\n\nThis problem was diagnosed as part of #1414 \n\nThe example was deployed on three kind clusters using kind `0.17.0` and the kindest `v1.25.3` image","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-02-21T10:46:02+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1475906040","fragment_type":"issue_comment","sequence":1,"text":"@glazychev-art Could you please add a test into deployments-k8s?","author_login":"denis-tingaikin","author_association":"MEMBER","created_at":"2023-03-20T09:41:10+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1479348606","fragment_type":"issue_comment","sequence":2,"text":"@fr-Pursuit \nCould you check PTR requests on the latest main branch if you get a chance?","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-03-22T10:56:32+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484224826","fragment_type":"issue_comment","sequence":3,"text":"@glazychev-art Hi! PTR requests seem to be handled correctly now. `ping` doesn't freeze at all :)\n\nHowever, I now need to explicitly use IPv4 in order for the ping to work...\n\n/ # ping -c 4 alpine2.my-interdomain-vl3-network\nping: bad address 'alpine2.my-interdomain-vl3-network'\n\n/ # ping -c 4 alpine2.my-interdomain-vl3-network -4\nPING alpine2.my-interdomain-vl3-network (172.16.0.2): 56 data bytes\n64 bytes from 172.16.0.2: seq=0 ttl=59 time=65.076 ms\n64 bytes from 172.16.0.2: seq=1 ttl=59 time=2.696 ms\n64 bytes from 172.16.0.2: seq=2 ttl=59 time=12.237 ms\n64 bytes from 172.16.0.2: seq=3 ttl=59 time=60.345 ms\n\nWhen the ping fails, this error appears in the NSE's logs:\n\nMar 26 21:04:34.885 [TRAC] [id:22041] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nMar 26 21:04:34.885 [TRAC] [id:22041] [type:dnsServer] (1.1) message-request={\"Id\":22041,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"alpine2.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nMar 26 21:04:34.885 [DEBU] [id:22041] [type:dnsServer] (1.2) passed clientURLs: [{udp 172.16.0.1 false } {udp 172.16.0.1 false }]\nMar 26 21:04:34.885 [DEBU] [id:22041] [type:dnsServer] (1.3) passed SearchDomains: []\nMar 26 21:04:34.885 [TRAC] [id:22041] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nMar 26 21:04:34.886 [TRAC] [id:22041] [type:dnsServer] (3) ⎆ sdk/pkg/tools/dnsutils/norecursion/norecursionDNSHandler.ServeDNS()\nMar 26 21:04:34.886 [TRAC] [id:22041] [type:dnsServer] (1) ⎆ sdk/pkg/tools/dnsutils/dnsconfigs/dnsConfigsHandler.ServeDNS()\nMar 26 21:04:34.887 [TRAC] [id:22041] [type:dnsServer] (4) ⎆ sdk/pkg/tools/dnsutils/memory/memoryHandler.ServeDNS()\nMar 26 21:04:34.887 [TRAC] [id:22041] [type:dnsServer] (1.1) message-request={\"Id\":22041,\"Response\":false,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":0,\"Question\":[{\"Name\":\"alpine2.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":null,\"Ns\":null,\"Extra\":null}\nMar 26 21:04:34.887 [DEBU] [id:22041] [type:dnsServer] (1.2) passed clientURLs: [{udp 172.16.0.1 false } {udp 172.16.0.1 false }]\nMar 26 21:04:34.887 [DEBU] [id:22041] [type:dnsServer] (1.3) passed SearchDomains: []\nMar 26 21:04:34.887 [TRAC] [id:22041] [type:dnsServer] (2) ⎆ sdk/pkg/tools/dnsutils/noloop/noloopDNSHandler.ServeDNS()\nMar 26 21:04:34.887 [ERRO] [id:22041] [noloopDNSHandler:ServeDNS] [type:dnsServer] (2.1) loop is not allowed: query: ;; opcode: QUERY, status: NOERROR, id: 22041; ;; flags:; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0; ; ;; QUESTION SECTION:; ;alpine2.my-interdomain-vl3-network. IN AAAA; ;\nMar 26 21:04:34.887 [TRAC] [id:22041] [type:dnsServer] (2.2) message-response={\"Id\":22041,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"alpine2.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\nMar 26 21:04:34.888 [TRAC] [id:22041] [type:dnsServer] (5) ⎆ sdk/pkg/tools/dnsutils/fanout/fanoutHandler.ServeDNS()\nMar 26 21:04:34.915 [TRAC] [id:22041] [type:dnsServer] (5.1) message-response={\"Id\":22041,\"Response\":true,\"Opcode\":0,\"Authoritative\":false,\"Truncated\":false,\"RecursionDesired\":false,\"RecursionAvailable\":false,\"Zero\":false,\"AuthenticatedData\":false,\"CheckingDisabled\":false,\"Rcode\":2,\"Question\":[{\"Name\":\"alpine2.my-interdomain-vl3-network.\",\"Qtype\":28,\"Qclass\":1}],\"Answer\":[],\"Ns\":[],\"Extra\":[]}\n\nIt seems the `AAAA` request fails in a way that makes `ping` fails before it even attempts to make a `A` request. I don't remember seeing that before. Is it be caused by a change in NSM or somewhere else?","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-03-26T21:08:53+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1484499135","fragment_type":"issue_comment","sequence":4,"text":"@fr-Pursuit \nNo, there were no changes in NSM in this direction. And this behavior was before, you can check versions v1.8.0 or v1.7.1 :)\n`ping` utility is the reason for this. Depending on the system settings, it prefers IPv6 over IPv4.\n\nAs far as I can see, in some linux versions this is solved by changing `/etc/gai.conf`. But not for alpine. Perhaps this will help you.","author_login":"glazychev-art","author_association":"CONTRIBUTOR","created_at":"2023-03-27T05:04:46+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1485044793","fragment_type":"issue_comment","sequence":5,"text":"@glazychev-art I feel we might need to verify it.\n\n@NikitaSkrynnik Could you please compare behaviour with NSM v1.5.0 (with coredns) and current main version?","author_login":"denis-tingaikin","author_association":"MEMBER","created_at":"2023-03-27T12:23:02+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1505027446","fragment_type":"issue_comment","sequence":6,"text":"@fr-Pursuit Hello, I've fixed the problem with `ping` and explicit `IPv4`. Could you please check it?","author_login":"NikitaSkrynnik","author_association":"CONTRIBUTOR","created_at":"2023-04-12T10:19:13+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1518689922","fragment_type":"issue_comment","sequence":7,"text":"@NikitaSkrynnik Hi! Sorry for the late reply.\n\nIt's all fixed, thanks!\n\n/ # ping -c 4 alpine2.my-interdomain-vl3-network\nPING alpine2.my-interdomain-vl3-network (172.16.1.2): 56 data bytes\n64 bytes from 172.16.1.2: seq=0 ttl=56 time=1.426 ms\n64 bytes from 172.16.1.2: seq=1 ttl=56 time=1.503 ms\n64 bytes from 172.16.1.2: seq=2 ttl=56 time=1.652 ms\n64 bytes from 172.16.1.2: seq=3 ttl=56 time=4.073 ms\n\n--- alpine2.my-interdomain-vl3-network ping statistics ---\n4 packets transmitted, 4 packets received, 0% packet loss\nround-trip min/avg/max = 1.426/2.163/4.073 ms","author_login":"fr-Pursuit","author_association":"NONE","created_at":"2023-04-22T15:47:00+08:00","repo_name":"networkservicemesh/sdk","issue_id":1593247208,"issue_number":1425,"issue_url":"https://github.com/networkservicemesh/sdk/issues/1425","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0497","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"[Bug]: Failed to launch the browser process!","query_context":"### Bug description\n\nAn error is thrown when I use the following code！\n\n const browser = await puppeteer.launch({\n headless: true\n });\n\nerror message:\n\nFailed to launch the browser process!\\n/opt/video-url-analysis/node_modules/_puppeteer@13.1.0@puppeteer/.local-chromium/linux-950341/chrome-linux/chrome: error while loading shared libraries: libatk-1.0.so.0: cannot open shared object file: No such file or directory\\n\\n\\nTROUBLESHOOTING: URL \n\nI saw the tips about node 14.0.0 Chrome is downloaded but fails to launch on Node.js 14 , but I use the node version is v14.18.1! \nWhat do I need to do to run it!\n\n### Puppeteer version\n\n13.1.0\n\n### Node.js version\n\nv14.18.1\n\n### npm version\n\n6.14.15\n\n### What operating system are you seeing the problem on?\n\nLinux\n\n### Relevant log output\n\nshell\nFailed to launch the browser process!\\n/opt/video-url-analysis/node_modules/_puppeteer@13.1.0@puppeteer/.local-chromium/linux-950341/chrome-linux/chrome: error while loading shared libraries: libatk-1.0.so.0: cannot open shared object file: No such file or directory\\n\\n\\nTROUBLESHOOTING: URL","known_context_document_ids":["gh_issue_1107802960"],"reference_answer":"@davicente I haven't seen this error before. Have you tried clearing the heroku build cache by chance?\n URL \n\nIf that doesn't work, try starting a new heroku app with the same repo, just to be sure we can rule heroku out of the equation.","answer_document_id":"gh_comment_1020114211","silver_evidence_path":["gh_comment_1019516471","gh_issue_1110511155","gh_comment_1020114211"],"evidence_issue_ids":[1107802960,1110511155],"source_repo_name":"puppeteer/puppeteer","source_issue_id":1107802960,"source_issue_number":7917,"source_issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","target_repo_name":"jontewks/puppeteer-heroku-buildpack","target_issue_id":1110511155,"target_issue_number":94,"target_issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","reference_anchor_document_id":"gh_comment_1019516471","reference_answer_author":"jontewks","reference_answer_author_association":"OWNER","quality_score":87.35,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":false,"technical_cue":true,"anchor_query_overlap":0.1429,"anchor_target_overlap":0.2857,"target_answer_overlap":0.087},"issue_created_at":"2022-01-19T08:31:31+08:00","valid_comment_count":21,"fragments":[{"document_id":"gh_issue_1107802960","fragment_type":"issue_description","sequence":0,"text":"[Bug]: Failed to launch the browser process!\n### Bug description\n\nAn error is thrown when I use the following code！\n\n const browser = await puppeteer.launch({\n headless: true\n });\n\nerror message:\n\nFailed to launch the browser process!\\n/opt/video-url-analysis/node_modules/_puppeteer@13.1.0@puppeteer/.local-chromium/linux-950341/chrome-linux/chrome: error while loading shared libraries: libatk-1.0.so.0: cannot open shared object file: No such file or directory\\n\\n\\nTROUBLESHOOTING: URL \n\nI saw the tips about node 14.0.0 Chrome is downloaded but fails to launch on Node.js 14 , but I use the node version is v14.18.1! \nWhat do I need to do to run it!\n\n### Puppeteer version\n\n13.1.0\n\n### Node.js version\n\nv14.18.1\n\n### npm version\n\n6.14.15\n\n### What operating system are you seeing the problem on?\n\nLinux\n\n### Relevant log output\n\nshell\nFailed to launch the browser process!\\n/opt/video-url-analysis/node_modules/_puppeteer@13.1.0@puppeteer/.local-chromium/linux-950341/chrome-linux/chrome: error while loading shared libraries: libatk-1.0.so.0: cannot open shared object file: No such file or directory\\n\\n\\nTROUBLESHOOTING: URL","author_login":"zhaosheng808","author_association":"NONE","created_at":"2022-01-19T08:31:31+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1016305449","fragment_type":"issue_comment","sequence":1,"text":"I'm having this same issue after deploying in Heroku. In local is working perfectly, but in Heroku it fails. I've followed the \nguidelines adding the buildpack and so, but same error.\n\nThis is how I initialize the browser:\n\n` browser = await puppeteer.launch({\n headless: true,\n args: ['--no-sandbox', '--disable-setuid-sandbox'],\n });`\n\nThe error I get:\n`Error: Failed to launch the browser process! `\n\nHere the buildpacks added in Heroku\nimage","author_login":"davicente","author_association":"NONE","created_at":"2022-01-19T10:40:12+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1017243489","fragment_type":"issue_comment","sequence":2,"text":"Now I've solved it！install libXScrnSaver in the server and can run it!\n\nsudo yum -y install libXScrnSaver-1.2.2-6.1.el7.x86_64","author_login":"zhaosheng808","author_association":"NONE","created_at":"2022-01-20T08:47:56+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018538038","fragment_type":"issue_comment","sequence":3,"text":"I think that's not valid for me in Heroku. Thanks anyway for your answer. I'll keep searching","author_login":"davicente","author_association":"NONE","created_at":"2022-01-21T14:11:28+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1019516471","fragment_type":"issue_comment","sequence":4,"text":"Just in case anyone comes here with same problem for Heroku, I created an issue in the libpack library for Heroku. Hopefully it will be discuss there:\n URL","author_login":"davicente","author_association":"NONE","created_at":"2022-01-23T16:11:04+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[1110511155],"is_known_query_context":false},{"document_id":"gh_comment_1073338069","fragment_type":"issue_comment","sequence":5,"text":"@davicente What does the command do?\n\nI am getting `bash: yum: command not found` as error.","author_login":"kouliavtsev","author_association":"NONE","created_at":"2022-03-20T19:55:24+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073338210","fragment_type":"issue_comment","sequence":6,"text":"@zhaosheng808 What does the command do?\n\nI am getting `bash: yum: command not found` as error.","author_login":"kouliavtsev","author_association":"NONE","created_at":"2022-03-20T19:56:32+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1073430633","fragment_type":"issue_comment","sequence":7,"text":"I don't know the specific principle of this, but I have performed the following operations and the problem has been solved\n\nsudo yum -y install libXScrnSaver-1.2.2-6.1.el7.x86_64\n\nand\n\nsudo yum install -y chromium\n\nyou can see this issues URL","author_login":"zhaosheng808","author_association":"NONE","created_at":"2022-03-21T02:48:25+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1228824203","fragment_type":"issue_comment","sequence":8,"text":"You may install the buildpack on the server using github repo: URL","author_login":"lifeofsoumya","author_association":"NONE","created_at":"2022-08-26T19:05:52+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1476948998","fragment_type":"issue_comment","sequence":9,"text":"In Ubuntu you have to:\n\n apt install chromium-browser\n apt install libxkbcommon0 \n apt install libxshmfence1\n apt install 1622 apt-get install ca-certificates \n apt install fonts-liberation \n apt install libasound2 \n apt install libatk-bridge2.0-0 \n apt install libatk1.0-0 \n apt install libc6 \n apt install libcairo2 \n apt install libcups2 \n apt install libdbus-1-3 \n apt install libexpat1 \n apt install libfontconfig1 \n apt install libgbm1 \n apt install libgcc1 \n apt install libglib2.0-0 \n apt install libgtk-3-0 \n apt install libnspr4 \n apt install libnss3 \n apt install libpango-1.0-0 \n apt install libpangocairo-1.0-0 \n apt install libstdc++6 \n apt install libx11-6 \n apt install libx11-xcb1 \n apt install libxcb1 \n apt install libxcomposite1 \n apt install libxcursor1 \n apt install libxdamage1 \n apt install libxext6 \n apt install libxfixes3 \n apt install libxi6 \n apt install libxrandr2 \n apt install libxrender1 \n apt install libxss1 \n apt install libxtst6 \n apt install lsb-release wget \n apt install xdg-utils\n apt install","author_login":"BlockChainCaffe","author_association":"NONE","created_at":"2023-03-20T21:18:45+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1532977323","fragment_type":"issue_comment","sequence":10,"text":"Getting the error `Failed to launch both playwright and puppeteer`","author_login":"alagiesellu","author_association":"NONE","created_at":"2023-05-03T12:51:59+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1560928476","fragment_type":"issue_comment","sequence":11,"text":"I have same issue\nin locally it work perfectly but when i copy it into docker i have got an error\n\ncmd\nError: Unable to launch browser, error message: Failed to launch the browser process!\n /usr/src/node_modules/puppeteer/.local-chromium/linux-1022525/chrome-linux/chrome: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory","author_login":"Samandar02","author_association":"NONE","created_at":"2023-05-24T11:13:55+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1573576000","fragment_type":"issue_comment","sequence":12,"text":"we were using azure web apps\nafter some restart we need to execute above \nin order make puppter working","author_login":"erica4appz","author_association":"NONE","created_at":"2023-06-02T11:22:18+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1763274420","fragment_type":"issue_comment","sequence":13,"text":"In Ubuntu you can try;\n\n`sudo apt install libxkbcommon0 libxshmfence1 ca-certificates fonts-liberation libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release wget xdg-utils` to install all the packages togather","author_login":"developer-alfarooqtech","author_association":"NONE","created_at":"2023-10-15T05:08:13+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1890846269","fragment_type":"issue_comment","sequence":14,"text":"thanks, man. can you explain why it's working after installing all the packages?","author_login":"techport-dev","author_association":"NONE","created_at":"2024-01-14T04:45:02+08:00","repo_name":"puppeteer/puppeteer","issue_id":1107802960,"issue_number":7917,"issue_url":"https://github.com/puppeteer/puppeteer/issues/7917","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1110511155","fragment_type":"issue_description","sequence":0,"text":"'Error: Failed to launch the browser process!' after trying all suggestions\nI'm having this issue that I know have appeared many times. But after checking all possible solutions, noone is working for me. Everything is working fine for me in local, but after deploying in Heroku, I recieve that error:\n\nThe error I get:\n'Error: Failed to launch the browser process!'\n\nThis is how I initialize the browser:\nbrowser = await puppeteer.launch({ headless: true, args: ['--no-sandbox', '--disable-setuid-sandbox'], });\n\nHere the buildpacks added in Heroku\nimage\n\nI'm a little lost and desperate\nI hope you can help me :)","author_login":"davicente","author_association":"NONE","created_at":"2022-01-21T14:09:50+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018540793","fragment_type":"issue_comment","sequence":1,"text":"Thanks @davicente lets see what we can do.\n\nFirst can you post the rest of the error too please?","author_login":"jontewks","author_association":"OWNER","created_at":"2022-01-21T14:15:00+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1018765374","fragment_type":"issue_comment","sequence":2,"text":"Hi @jontewks,\nfirst of all, thanks for your fast reply.\n\nThis is the stack:\n\nError: Failed to launch the browser process!\nERROR:platform_thread_posix.cc(148)] pthread_create: Resource temporarily unavailable (11)\nFATAL:browser_task_executor.cc(405)] Failed to start BrowserThread:IO\nhost app worker.1 - #0 0x56251b45c029 base::debug::CollectStackTrace()\nhost app worker.1 - #1 0x56251b3c3623 base::debug::StackTrace::StackTrace()\nhost app worker.1 - #2 0x56251b3d68f0 logging::LogMessage::~LogMessage()\nhost app worker.1 - #3 0x56251938bba6 content::BrowserTaskExecutor::CreateIOThread()\nhost app worker.1 - #4 0x56251af5e408 content::ContentMainRunnerImpl::RunBrowser()\nhost app worker.1 - #5 0x56251af5e117 content::ContentMainRunnerImpl::Run()\nhost app worker.1 - #6 0x56251af5b985 content::RunContentProcess()\nhost app worker.1 - #7 0x56251af5c45e content::ContentMain()\nhost app worker.1 - #8 0x56251afba7ce headless::HeadlessBrowserMain()\nhost app worker.1 - #9 0x56251afba4fd headless::HeadlessShellMain()\nhost app worker.1 - #10 0x562517d01133 ChromeMain\nhost app worker.1 - #11 0x7fb491ed50b3 __libc_start_main\nhost app worker.1 - #12 0x562517d00f6a _start\nhost app worker.1 - \nhost app worker.1 - Received signal 6\nhost app worker.1 - #0 0x56251b45c029 base::debug::CollectStackTrace()\nhost app worker.1 - #1 0x56251b3c3623 base::debug::StackTrace::StackTrace()\nhost app worker.1 - #2 0x56251b45bb01 base::debug::(anonymous namespace)::StackDumpSignalHandler()\nhost app worker.1 - #3 0x7fb492da63c0 (/usr/lib/x86_64-linux-gnu/libpthread-2.31.so+0x153bf)\nhost app worker.1 - #4 0x7fb491ef418b gsignal\nhost app worker.1 - #5 0x7fb491ed3859 abort\nhost app worker.1 - #6 0x56251b45ad95 base::debug::BreakDebuggerAsyncSafe()\nhost app worker.1 - #7 0x56251b3d6d1f logging::LogMessage::~LogMessage()\nhost app worker.1 - #8 0x56251938bba6 content::BrowserTaskExecutor::CreateIOThread()\nhost app worker.1 - #9 0x56251af5e408 content::ContentMainRunnerImpl::RunBrowser()\nhost app worker.1 - #10 0x56251af5e117 content::ContentMainRunnerImpl::Run()\nhost app worker.1 - #11 0x56251af5b985 content::RunContentProcess()\nhost app worker.1 - #12 0x56251af5c45e content::ContentMain()\nhost app worker.1 - #13 0x56251afba7ce headless::HeadlessBrowserMain()\nhost app worker.1 - #14 0x56251afba4fd headless::HeadlessShellMain()\nhost app worker.1 - #15 0x562517d01133 ChromeMain\nhost app worker.1 - #16 0x7fb491ed50b3 __libc_start_main\nhost app worker.1 - #17 0x562517d00f6a _start\n[...]\n\nLet me know if you have any idea about the problem.\nRegards","author_login":"davicente","author_association":"NONE","created_at":"2022-01-21T18:39:26+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1020113013","fragment_type":"issue_comment","sequence":3,"text":"@davicente I was going to say I haven't seen that error before but I see you closed it. Mind mentioning what your fix was here just in case anyone else comes across this in the future?","author_login":"jontewks","author_association":"OWNER","created_at":"2022-01-24T13:41:11+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1020114211","fragment_type":"issue_comment","sequence":4,"text":"@davicente I haven't seen this error before. Have you tried clearing the heroku build cache by chance?\n URL \n\nIf that doesn't work, try starting a new heroku app with the same repo, just to be sure we can rule heroku out of the equation.","author_login":"jontewks","author_association":"OWNER","created_at":"2022-01-24T13:42:32+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1045108058","fragment_type":"issue_comment","sequence":5,"text":"It looks like it was related with a problem with memory limitation in the pod (in case it happens to anyone again).\nThanks for your support :).","author_login":"davicente","author_association":"NONE","created_at":"2022-02-18T20:01:56+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1068418383","fragment_type":"issue_comment","sequence":6,"text":"hey @jontewks , this did not work for me.. i deleted cache a couple of times and I get this error everytime..\n\njs\n2022-03-15T20:03:34.549420+00:00 app[web.1]: Chrome Initialize failed: Error: Failed to launch the browser process!\n2022-03-15T20:03:34.549432+00:00 app[web.1]: [133:133:0315/200334.538525:ERROR:ozone_platform_x11.cc(247)] Missing X server or $DISPLAY\n2022-03-15T20:03:34.549445+00:00 app[web.1]: [133:133:0315/200334.538571:ERROR:env.cc(225)] The platform failed to initialize. Exiting.\n2022-03-15T20:03:34.549472+00:00 app[web.1]: TROUBLESHOOTING: URL \n2022-03-15T20:03:34.549484+00:00 app[web.1]: at onClose (/app/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserRunner.js:237:20)\n2022-03-15T20:03:34.549499+00:00 app[web.1]: at ChildProcess. (/app/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserRunner.js:228:79)\n2022-03-15T20:03:34.549521+00:00 app[web.1]: at ChildProcess.emit (events.js:412:35)\n2022-03-15T20:03:34.549530+00:00 app[web.1]: at Process.ChildProcess._handle.onexit (internal/child_process.js:282:12)\n\nany idea why this can be happening?","author_login":"jtourisNS","author_association":"NONE","created_at":"2022-03-15T20:06:06+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1068423824","fragment_type":"issue_comment","sequence":7,"text":"I see.. that is issue then, I am trying to run it as `headless: false`. Was not aware that heroku did not supported this feature. So for what you are saying there is absolutely no workaround for launching a puppeteer client with `headless: false` on heroku correct?","author_login":"jtourisNS","author_association":"NONE","created_at":"2022-03-15T20:12:22+08:00","repo_name":"jontewks/puppeteer-heroku-buildpack","issue_id":1110511155,"issue_number":94,"issue_url":"https://github.com/jontewks/puppeteer-heroku-buildpack/issues/94","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}
{"sample_id":"cross_issue_0499","source":"OpenDigger-GHArchive-Cross-Issue","annotation_level":"silver","split":"test","query":"RN 0.69.3, ReactNativeConfig.h file not found?","query_context":"## Description\n\nAfter updating project to new version RN 0.69.3 and run project on Xcode, error comings out\n\n<img width=\"1512\" alt=\"Schermata 2022-08-01 alle 16 46 30\" src=\" URL \n\n## Package versions\n\n| name | version |\n| ------------------------------------ | ------- |\n| react-native |0.69.3|\n| react-native-reanimated | ^2.4.1|\n| NodeJS |18.7.0|\n| Xcode |13.4.1|\n| Java |openjdk version \"11.0.16\"|\n| Gradle |7.3.3|\n| expo ||\n\n## Affected platforms\n\n \n\n- [ ] Android\n- [x] iOS\n- [ ] Web","known_context_document_ids":["gh_issue_1324216063"],"reference_answer":"Hey, Reanimated works with Fabric. If it doesn't work for you in your app, this is probably an issue with your configuration or setup.\n\n@shahmeer-ali Have you tried any steps that worked for other people?\n- URL \n- URL","answer_document_id":"gh_comment_1257134410","silver_evidence_path":["gh_comment_1201094662","gh_issue_1130578122","gh_comment_1257134410"],"evidence_issue_ids":[1324216063,1130578122],"source_repo_name":"software-mansion/react-native-reanimated","source_issue_id":1324216063,"source_issue_number":3430,"source_issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/3430","target_repo_name":"software-mansion/react-native-reanimated","target_issue_id":1130578122,"target_issue_number":2991,"target_issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","reference_anchor_document_id":"gh_comment_1201094662","reference_answer_author":"tomekzaw","reference_answer_author_association":"MEMBER","quality_score":96.0,"quality_details":{"explicit_cross_issue_reference":true,"resolution_cue":true,"technical_cue":true,"anchor_query_overlap":0.1304,"anchor_target_overlap":0.3043,"target_answer_overlap":0.1579},"issue_created_at":"2022-08-01T10:48:58+08:00","valid_comment_count":24,"fragments":[{"document_id":"gh_issue_1324216063","fragment_type":"issue_description","sequence":0,"text":"RN 0.69.3, ReactNativeConfig.h file not found\n## Description\n\nAfter updating project to new version RN 0.69.3 and run project on Xcode, error comings out\n\n<img width=\"1512\" alt=\"Schermata 2022-08-01 alle 16 46 30\" src=\" URL \n\n## Package versions\n\n| name | version |\n| ------------------------------------ | ------- |\n| react-native |0.69.3|\n| react-native-reanimated | ^2.4.1|\n| NodeJS |18.7.0|\n| Xcode |13.4.1|\n| Java |openjdk version \"11.0.16\"|\n| Gradle |7.3.3|\n| expo ||\n\n## Affected platforms\n\n \n\n- [ ] Android\n- [x] iOS\n- [ ] Web","author_login":"alzhab","author_association":"NONE","created_at":"2022-08-01T10:48:58+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1324216063,"issue_number":3430,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/3430","linked_issue_ids":[],"is_known_query_context":true},{"document_id":"gh_comment_1201042783","fragment_type":"issue_comment","sequence":1,"text":"Hello @alzhab! Thanks for submitting the issue. Here are some more questions:\n\n1. Do you use Expo?\n2. Did you remember to run `RCT_NEW_ARCH_ENABLED=1 pod install` in `ios` directory of your app?","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2022-08-01T10:57:17+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1324216063,"issue_number":3430,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/3430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1201094662","fragment_type":"issue_comment","sequence":2,"text":"I've just created a fresh RN 0.69.3 app, added react-native-reanimated, build the app for iOS and it works fine.\n\nPlease make sure that you enable Fabric via environmental variable `RCT_NEW_ARCH_ENABLED` and not directly in Podfile.\n\nRelated issues:\n* URL \n* URL","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2022-08-01T11:46:53+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1324216063,"issue_number":3430,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/3430","linked_issue_ids":[1130578122],"is_known_query_context":false},{"document_id":"gh_comment_1201630378","fragment_type":"issue_comment","sequence":3,"text":"Hello\n1 No, i don't use Expo\n2 Yes Fabric enabled and run command with flag RCT_NEW_ARCH_ENABLED=1","author_login":"alzhab","author_association":"NONE","created_at":"2022-08-01T19:37:03+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1324216063,"issue_number":3430,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/3430","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_issue_1130578122","fragment_type":"issue_description","sequence":0,"text":"Not working with Fabric on iOS\n## Description\n\nUsing latest Reanimated (2.4.1) together with the current 0.68 release candidate is not working with the new architecture/fabric enabled on iOS. \n\n### Expected behavior\n\nThe app compiles with the `USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1` flags. \n\n### Actual behavior & steps to reproduce\n\nThe app fails to compile with the error:\n\n'react/config/ReactNativeConfig.h' file not found\n\n## Snack or minimal code example\n\nbash\nnpx react-native init ReanimatedFabric --version 0.68.0-rc.1\ncd ReanimatedFabric\nyarn add react-native-reanimated@2.4.1\ncd ios\nUSE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 bundle exec pod install\nyarn ios\n\n## Package versions\n\n| name | version |\n| ------------------------------------ | ------- |\n| react-native | 0.68.0-rc.0, 0.68.0-rc.1 |\n| react-native-reanimated | 2.2.4, 2.4.1 |\n| NodeJS | 16.14.0 |\n| Xcode | 13.2.1 |\n\n## Affected platforms\n\n- [ ] Android\n- [x] iOS\n- [ ] Web","author_login":"oblador","author_association":"CONTRIBUTOR","created_at":"2022-02-10T18:00:58+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1035637363","fragment_type":"issue_comment","sequence":1,"text":"Hello! We're actively working on porting Reanimated to Fabric but it's not completely ready yet. In fact, Reanimated integrates quite closely with the renderer system so we need to rewrite some parts specifically for Fabric and that's exactly what we have been doing for the past few months.\n\nThe good news is that in parallel we're porting react-native-gesture-handler and react-native-screens to Fabric as well so hopefully the developers will be able to enable Fabric in their apps as soon as possible.","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2022-02-10T23:25:51+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1042587714","fragment_type":"issue_comment","sequence":2,"text":"URL \n\nI also opened discussion for nightly release support but now new architecture has shipped","author_login":"nomi9995","author_association":"CONTRIBUTOR","created_at":"2022-02-17T05:24:06+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1088481316","fragment_type":"issue_comment","sequence":3,"text":"Same issue.\nI upgrade `react-native-reanimated` to `v2.6.0` still has issue.","author_login":"alantoa","author_association":"NONE","created_at":"2022-04-05T09:32:29+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1089864012","fragment_type":"issue_comment","sequence":4,"text":"@alantoa @Tjerk-Haaye-Henricus they are actively working on it you can check the Fabric branch URL","author_login":"nomi9995","author_association":"CONTRIBUTOR","created_at":"2022-04-06T06:17:36+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1089867442","fragment_type":"issue_comment","sequence":5,"text":"Amazing :) Thanks a thousand times for that information 🙏\nbtw: i really really in love with your work and i'm using all of your rn repos inside of several projects 🤓","author_login":"Tjerk-Haaye-Henricus","author_association":"NONE","created_at":"2022-04-06T06:22:56+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1106735857","fragment_type":"issue_comment","sequence":6,"text":"FYI this does still seem be happening with react-native 0.68.1 and react-native-reanimated 2.8.0. I really appreciate all the hard work you guys are doing!","author_login":"mikeislearning","author_association":"NONE","created_at":"2022-04-22T17:53:57+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1130272814","fragment_type":"issue_comment","sequence":7,"text":"@ahmadzraiq They announced that version 3 should resolve this: URL","author_login":"mikeislearning","author_association":"NONE","created_at":"2022-05-18T17:12:49+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1134626618","fragment_type":"issue_comment","sequence":8,"text":"@mikeislearning \"If you’d like to try running Reanimated on the new Fabric architecture, make sure that you are using at least version 0.69 of React Native\"\n\nso it's not working for expo SDK 45, right? (Expo SDK 45 uses v0.68.2)","author_login":"dutradotdev","author_association":"NONE","created_at":"2022-05-23T12:40:57+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1134627587","fragment_type":"issue_comment","sequence":9,"text":"Version 3 is coming 😏 and hopefully solving this issue.\n\n URL","author_login":"Tjerk-Haaye-Henricus","author_association":"NONE","created_at":"2022-05-23T12:41:51+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141354931","fragment_type":"issue_comment","sequence":10,"text":"I'm still getting `'react/config/ReactNativeConfig.h' file not found` when building react-native v0.68.2 with v3.0.0-rc.0 and Fabric enabled. \n\nCould you anyone confirm that v3.0.0-rc.0 is supposed to work with Fabric enabled?","author_login":"maxperry","author_association":"NONE","created_at":"2022-05-30T17:07:34+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1141403037","fragment_type":"issue_comment","sequence":11,"text":"@maxperry Yes, but only with using RN 0.69, where you have the new arch enabled.","author_login":"hannojg","author_association":"NONE","created_at":"2022-05-30T18:31:12+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1165617488","fragment_type":"issue_comment","sequence":12,"text":"we got RN 0.69 released but the error 'react/config/ReactNativeConfig.h' file not found is still here","author_login":"skurgansky-sugarcrm","author_association":"NONE","created_at":"2022-06-24T14:13:16+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1173544389","fragment_type":"issue_comment","sequence":13,"text":"If you want to use Fabric in your app you need to install Reanimated 3, but if you just want to use react-native@0.69 you should use Reanimated 2.9.1","author_login":"piaskowyk","author_association":"MEMBER","created_at":"2022-07-04T08:55:35+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1175986007","fragment_type":"issue_comment","sequence":14,"text":"What if 0.68.2 (expo 45) is a hard requirement and the app depends on reanimated?","author_login":"WNemencha","author_association":"NONE","created_at":"2022-07-06T09:17:17+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1197886823","fragment_type":"issue_comment","sequence":15,"text":"Hey all, just wanted to sum up the discussion and close the issue since it was resolved with the release of 3.0.0-rc.0, which is the very first version that supports the new React Native renderer, Fabric. 🎉 \n\nIf you’d like to try running **Reanimated on the new Fabric architecture**, you need to upgrade to React Native 0.69 (or newer) and install Reanimated 3.0.0-rc.0 (or newer). Note that it will not work with Reanimated 2.x or React Native 0.68.x. For more details, check out this blog post.\n\nIf you want to use **Reanimated on the old Paper architecture**, you can still use version 2.x and React Native 0.64+. However, if you don't use old Reanimated 1 API, we encourage you to upgrade to Reanimated 3 (which is fully-compatible with Reanimated 2 API and built from sources on both platforms).\n\nCurrently (as of July 2022), Expo SDK does not support Fabric yet. Expo SDK 45 includes react-native 0.68.2 and react-native-reanimated 2.x which does not support Fabric.","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2022-07-28T09:19:58+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250405872","fragment_type":"issue_comment","sequence":16,"text":"I am getting this error on RN v0.70.1 with new architecture and fabric enabled. I have installed `3.0.0-rc.2` version of reanimated. Tried re-install node_modules, and pods. Also tried deleting pod lock file and cleaning build from XCode, but didn't help. @tomekzaw","author_login":"fawad-khalil","author_association":"NONE","created_at":"2022-09-18T23:05:57+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1250588674","fragment_type":"issue_comment","sequence":17,"text":"@fawad-khalil Can you try removing `ios/build` folder of your app?","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2022-09-19T05:33:53+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257105910","fragment_type":"issue_comment","sequence":18,"text":"So any solution so far making Reanimated to work with Fabric?\n\nscreenshot","author_login":"shahmeer-ali","author_association":"NONE","created_at":"2022-09-25T02:39:50+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1257134410","fragment_type":"issue_comment","sequence":19,"text":"Hey, Reanimated works with Fabric. If it doesn't work for you in your app, this is probably an issue with your configuration or setup.\n\n@shahmeer-ali Have you tried any steps that worked for other people?\n- URL \n- URL","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2022-09-25T06:56:12+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1584986433","fragment_type":"issue_comment","sequence":20,"text":"@tomekzaw \n Invalid `RNReanimated.podspec` file: [react-native-reanimated] Reanimated 3.2.0 supports the New Architecture only on the latest minor release of React Native. Please upgrade to React Native 0.72.0+ or downgrade to an older version of Reanimated v3.\n\nI am getting this message . only thing i did was new react native init , and pod install with fabric, and then installed reanimated all . by default react native is coming with .71 version. and reanimated asks for .72, i think its not stable yet so is there any solution to this.","author_login":"Commaando","author_association":"NONE","created_at":"2023-06-09T18:31:43+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false},{"document_id":"gh_comment_1585005681","fragment_type":"issue_comment","sequence":21,"text":"@Commaando Yeah, Reanimated 3.1.0 and 3.2.0 support Fabric only with React Native 0.72 which is not stable yet (currently latest pre-release is 0.72.0-rc.5). Sorry for this, we were just too fast. If you really need to use Reanimated with React Native 0.71, please use `react-native-reanimated@3.0.2`.","author_login":"tomekzaw","author_association":"MEMBER","created_at":"2023-06-09T18:52:53+08:00","repo_name":"software-mansion/react-native-reanimated","issue_id":1130578122,"issue_number":2991,"issue_url":"https://github.com/software-mansion/react-native-reanimated/issues/2991","linked_issue_ids":[],"is_known_query_context":false}],"human_reviewed":false}