File size: 3,828 Bytes
f4a5c87 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 | diff --git a/test_commands.json b/test_commands.json
new file mode 100644
index 00000000..96be81d1
--- /dev/null
+++ b/test_commands.json
@@ -0,0 +1,3 @@
+{
+ "test_commands": ["python -m pytest tests/units/test_core.py::TestCoreConfDirOnReadOnlyFS -v"]
+}
diff --git a/tests/units/test_core.py b/tests/units/test_core.py
index f5f118c4..45a7e1be 100644
--- a/tests/units/test_core.py
+++ b/tests/units/test_core.py
@@ -2244,3 +2244,80 @@ class TestCoreProductAlias(TestCoreBase):
# not existing product type
with self.assertRaises(NoMatchingProductType):
self.dag.get_product_type_from_alias("JUST_A_TYPE")
+
+
+class TestCoreConfDirOnReadOnlyFS(unittest.TestCase):
+ """Tests for EODataAccessGateway construction on a read-only filesystem
+ (AWS Lambda issue: $HOME is read-only)."""
+
+ def setUp(self):
+ import tempfile as _tempfile
+
+ self._tempfile = _tempfile
+
+ self.tmp_home_dir = TemporaryDirectory()
+ self.expanduser_patcher = mock.patch(
+ "os.path.expanduser",
+ autospec=True,
+ return_value=self.tmp_home_dir.name,
+ )
+ self.expanduser_patcher.start()
+
+
+ self._saved_env = {}
+ for k in ("EODAG_CFG_DIR", "EODAG_CFG_FILE", "EODAG_LOCS_CFG_FILE"):
+ self._saved_env[k] = os.environ.pop(k, None)
+
+
+ self._cleanup_paths = [
+ os.path.join(self._tempfile.gettempdir(), ".config", "eodag"),
+ ]
+
+ def tearDown(self):
+ self.expanduser_patcher.stop()
+ self.tmp_home_dir.cleanup()
+ for k, v in self._saved_env.items():
+ if v is None:
+ os.environ.pop(k, None)
+ else:
+ os.environ[k] = v
+
+ logger = logging.getLogger("eodag")
+ logger.handlers = []
+ logger.level = 0
+
+ for p in self._cleanup_paths:
+ if os.path.isdir(p):
+ shutil.rmtree(p, ignore_errors=True)
+
+ def test_default_conf_dir_uses_home(self):
+ """Regression: with no overrides, conf_dir defaults to ~/.config/eodag
+ and the directory is available."""
+ dag = EODataAccessGateway()
+ expected = os.path.join(self.tmp_home_dir.name, ".config", "eodag")
+ self.assertEqual(dag.conf_dir, expected)
+ self.assertTrue(os.path.isdir(dag.conf_dir))
+
+ def test_constructor_does_not_raise_on_readonly_home(self):
+ """Core user scenario from the issue: ``EODataAccessGateway()`` with no
+ arguments must not raise ``OSError`` when ``$HOME`` (and any path
+ derived from it) lives on a read-only filesystem, as is the case on
+ AWS Lambda. The fix may live at any layer (catch+fallback, lazy
+ creation, low-level swallow, ...): all that the user observes is the
+ absence of the exception."""
+ import errno as _errno
+
+ real_os_makedirs = os.makedirs
+ home = self.tmp_home_dir.name
+
+ def fake_os_makedirs(path, *args, **kwargs):
+
+ if path == home or path.startswith(home + os.sep):
+ raise OSError(
+ _errno.EROFS, "Read-only file system", path
+ )
+ return real_os_makedirs(path, *args, **kwargs)
+
+ with mock.patch("os.makedirs", side_effect=fake_os_makedirs):
+
+ EODataAccessGateway()
diff --git a/mimo_test_command.sh b/mimo_test_command.sh
new file mode 100755
--- /dev/null
+++ b/mimo_test_command.sh
@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+
+set -uo pipefail
+cd /testbed
+rc=0
+python -m pytest -v -rA tests/units/test_core.py::TestCoreConfDirOnReadOnlyFS::test_default_conf_dir_uses_home tests/units/test_core.py::TestCoreConfDirOnReadOnlyFS::test_constructor_does_not_raise_on_readonly_home
+rc=$(( rc | $? ))
+exit $rc
|