File size: 13,465 Bytes
9425aed
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
use anyhow::Result;
use chrono::{DateTime, Utc};
use dashmap::DashMap;
use serde::{Deserialize, Serialize};
use std::path::PathBuf;
use std::sync::Arc;
use tokio::sync::mpsc;
use tracing::{debug, info, warn};

use crate::audit_log::AuditLog;
use crate::commit_gateway::CommitGateway;

/// A change pending human review
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct PendingChange {
    pub id: String,
    pub description: String,
    pub evidence: String,
    pub agent_name: String,
    pub created_at: DateTime<Utc>,
    pub files: Vec<String>,
    pub diff: String,
}

/// Status of a change in the review pipeline
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
pub enum ChangeStatus {
    /// Awaiting human review
    Pending,
    /// Human is actively reviewing
    UnderReview,
    /// Change has been approved
    Approved,
    /// Change has been rejected
    Rejected,
    /// Approved and committed
    Committed,
}

/// Change with metadata
#[derive(Debug, Clone, Serialize, Deserialize)]
struct ChangeRecord {
    change: PendingChange,
    status: ChangeStatus,
    reviewed_by: Option<String>,
    review_timestamp: Option<DateTime<Utc>>,
    rejection_reason: Option<String>,
    commit_hash: Option<String>,
}

/// Human review pipeline queue
pub struct ReviewQueue {
    rx: mpsc::Receiver<PendingChange>,
    repo_path: PathBuf,
    audit_log: PathBuf,
    max_pending: usize,
    /// In-flight changes indexed by ID
    changes: Arc<DashMap<String, ChangeRecord>>,
    /// Order of pending changes (for FIFO processing)
    pending_queue: Arc<Vec<String>>,
}

impl ReviewQueue {
    /// Create a new review queue
    pub fn new(
        rx: mpsc::Receiver<PendingChange>,
        repo_path: PathBuf,
        audit_log: PathBuf,
        max_pending: usize,
    ) -> Result<Self> {
        info!(
            "πŸ“‹ ReviewQueue initialized (max_pending: {}, repo: {:?})",
            max_pending, repo_path
        );

        Ok(ReviewQueue {
            rx,
            repo_path,
            audit_log,
            max_pending,
            changes: Arc::new(DashMap::new()),
            pending_queue: Arc::new(Vec::new()),
        })
    }

    /// Process changes from the queue
    pub async fn process_queue(
        &mut self,
        gateway: CommitGateway,
        audit_log: AuditLog,
    ) -> Result<()> {
        info!("πŸ”„ Review queue processor started");

        loop {
            tokio::select! {
                Some(change) = self.rx.recv() => {
                    self.handle_incoming_change(change, &gateway, &audit_log).await?;
                }
                _ = tokio::time::sleep(tokio::time::Duration::from_secs(5)) => {
                    self.check_pending_reviews(&audit_log).await?;
                }
            }
        }
    }

    /// Handle a newly incoming change
    async fn handle_incoming_change(
        &self,
        change: PendingChange,
        _gateway: &CommitGateway,
        audit_log: &AuditLog,
    ) -> Result<()> {
        let change_id = change.id.clone();
        let agent = change.agent_name.clone();

        info!(
            "πŸ“₯ New change received (id: {}, agent: {}, files: {})",
            change_id,
            agent,
            change.files.len()
        );

        // Check queue capacity
        if self.changes.len() >= self.max_pending {
            warn!(
                "⚠️  Review queue full ({}). Rejecting new change: {}",
                self.max_pending, change_id
            );
            audit_log
                .log_rejection(&change_id, "Queue capacity exceeded", &agent)
                .await?;
            return Ok(());
        }

        // Format the change for human review
        let review_request = self.format_review_request(&change);

        // Store in queue
        let record = ChangeRecord {
            change: change.clone(),
            status: ChangeStatus::Pending,
            reviewed_by: None,
            review_timestamp: None,
            rejection_reason: None,
            commit_hash: None,
        };
        self.changes.insert(change_id.clone(), record);

        // Log to audit trail
        audit_log.log_submitted(&change).await?;

        // Display review prompt
        println!("{}", review_request);
        println!();
        println!("πŸ€” Awaiting human review. Enter 'approve <id>' or 'reject <id> <reason>'");
        println!();

        Ok(())
    }

    /// Format a change for human review
    fn format_review_request(&self, change: &PendingChange) -> String {
        format!(
            r#"

β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”

β”‚                   HUMAN REVIEW REQUEST                       β”‚

β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€

β”‚ ID:       {}

β”‚ Agent:    {}

β”‚ Time:     {}

β”‚ Status:   ⏳ AWAITING REVIEW

β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€

β”‚ DESCRIPTION:

β”‚ {}

β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€

β”‚ EVIDENCE:

β”‚ {}

β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€

β”‚ FILES MODIFIED: {}

β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€

β”‚ DECISION:

β”‚   βœ… approve {}  - Approve and commit

β”‚   ❌ reject {}   - Reject with reason

β”‚   πŸ“ inspect    - Show full diff

β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜

"#,
            change.id,
            change.agent_name,
            change.created_at.format("%Y-%m-%d %H:%M:%S UTC"),
            self.indent_text(&change.description, 2),
            self.indent_text(&change.evidence, 2),
            change.files.len(),
            change.id,
            change.id,
        )
    }

    /// Helper to indent text for display
    fn indent_text(&self, text: &str, spaces: usize) -> String {
        let indent = " ".repeat(spaces);
        text.lines()
            .map(|line| format!("{}{}", indent, line))
            .collect::<Vec<_>>()
            .join("\n")
    }

    /// Check for pending reviews (timeout, ready for commit)
    async fn check_pending_reviews(&self, _audit_log: &AuditLog) -> Result<()> {
        debug!("πŸ” Checking pending reviews...");

        let now = Utc::now();
        let timeout_secs = 3600; // 1 hour

        for entry in self.changes.iter() {
            let record = entry.value();

            if record.status == ChangeStatus::Approved {
                let elapsed = (now - record.review_timestamp.unwrap_or(now)).num_seconds();

                if elapsed > 0 {
                    debug!(
                        "βœ… Change {} approved by {}, ready for commit",
                        entry.key(),
                        record.reviewed_by.as_ref().unwrap_or(&"unknown".to_string())
                    );
                }
            }

            // Warn if pending too long
            if record.status == ChangeStatus::Pending {
                let elapsed = (now - record.change.created_at).num_seconds();

                if elapsed > timeout_secs {
                    warn!(
                        "⏰ Change {} pending review for {}s (timeout: {}s)",
                        entry.key(),
                        elapsed,
                        timeout_secs
                    );
                }
            }
        }

        Ok(())
    }

    /// Approve a change
    pub async fn approve_change(
        &self,
        change_id: &str,
        reviewer: &str,
        audit_log: &AuditLog,
    ) -> Result<()> {
        info!("βœ… Approving change: {} (reviewer: {})", change_id, reviewer);

        if let Some(mut entry) = self.changes.get_mut(change_id) {
            entry.status = ChangeStatus::Approved;
            entry.reviewed_by = Some(reviewer.to_string());
            entry.review_timestamp = Some(Utc::now());

            audit_log
                .log_approval(change_id, reviewer, &entry.change.description)
                .await?;

            info!("βœ… Change {} approved and ready for commit", change_id);
        } else {
            return Err(anyhow::anyhow!("Change not found: {}", change_id));
        }

        Ok(())
    }

    /// Reject a change
    pub async fn reject_change(
        &self,
        change_id: &str,
        reviewer: &str,
        reason: &str,
        audit_log: &AuditLog,
    ) -> Result<()> {
        info!(
            "❌ Rejecting change: {} (reviewer: {}, reason: {})",
            change_id, reviewer, reason
        );

        if let Some(mut entry) = self.changes.get_mut(change_id) {
            entry.status = ChangeStatus::Rejected;
            entry.reviewed_by = Some(reviewer.to_string());
            entry.review_timestamp = Some(Utc::now());
            entry.rejection_reason = Some(reason.to_string());

            audit_log
                .log_rejection(change_id, reason, reviewer)
                .await?;

            info!("❌ Change {} rejected. Reason: {}", change_id, reason);
        } else {
            return Err(anyhow::anyhow!("Change not found: {}", change_id));
        }

        Ok(())
    }

    /// Mark change as committed
    pub async fn mark_committed(
        &self,
        change_id: &str,
        commit_hash: &str,
        audit_log: &AuditLog,
    ) -> Result<()> {
        info!("πŸ“ Marking change {} as committed: {}", change_id, commit_hash);

        if let Some(mut entry) = self.changes.get_mut(change_id) {
            entry.status = ChangeStatus::Committed;
            entry.commit_hash = Some(commit_hash.to_string());

            audit_log
                .log_commit(change_id, commit_hash, entry.reviewed_by.as_deref().unwrap_or("unknown"))
                .await?;

            info!("βœ… Change {} committed with hash: {}", change_id, commit_hash);
        } else {
            return Err(anyhow::anyhow!("Change not found: {}", change_id));
        }

        Ok(())
    }

    /// Get current status
    pub fn status(&self) -> QueueStatus {
        let mut pending = 0;
        let mut approved = 0;
        let mut rejected = 0;
        let mut committed = 0;

        for entry in self.changes.iter() {
            match entry.value().status {
                ChangeStatus::Pending | ChangeStatus::UnderReview => pending += 1,
                ChangeStatus::Approved => approved += 1,
                ChangeStatus::Rejected => rejected += 1,
                ChangeStatus::Committed => committed += 1,
            }
        }

        QueueStatus {
            total: self.changes.len(),
            pending,
            approved,
            rejected,
            committed,
            capacity: self.max_pending,
        }
    }
}

/// Status snapshot of the review queue
#[derive(Debug, Serialize, Deserialize)]
pub struct QueueStatus {
    pub total: usize,
    pub pending: usize,
    pub approved: usize,
    pub rejected: usize,
    pub committed: usize,
    pub capacity: usize,
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_format_review_request() {
        let queue = ReviewQueue::new(
            mpsc::channel(100).1,
            PathBuf::from("."),
            PathBuf::from("audit.json"),
            100,
        )
        .unwrap();

        let change = PendingChange {
            id: "test-123".to_string(),
            description: "Add new feature".to_string(),
            evidence: "https://example.com/evidence".to_string(),
            agent_name: "test-agent".to_string(),
            created_at: Utc::now(),
            files: vec!["src/main.rs".to_string()],
            diff: "some diff".to_string(),
        };

        let formatted = queue.format_review_request(&change);
        assert!(formatted.contains("test-123"));
        assert!(formatted.contains("Add new feature"));
    }

    #[test]
    fn test_indent_text() {
        let queue = ReviewQueue::new(
            mpsc::channel(100).1,
            PathBuf::from("."),
            PathBuf::from("audit.json"),
            100,
        )
        .unwrap();

        let text = "line1\nline2";
        let indented = queue.indent_text(text, 2);
        assert!(indented.starts_with("  line1"));
    }
}